platform/upstream/VK-GL-CTS.git
6 years agoAdd more allowed 'dot' alternatives
Alexander Galazin [Thu, 17 Aug 2017 14:16:09 +0000 (16:16 +0200)]
Add more allowed 'dot' alternatives

Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.

Components: Vulkan

VK-GL-CTS issue: 634

Affects:
dEQP-VK.glsl.builtin.precision.dot.*
dEQP-VK.glsl.builtin.precision.reflect.*

Change-Id: I7fecbfa1cde04eab95bb3d418972631727d6d6af

6 years agoRun Draw*BaseVertex if EXT_draw_elements_base_vertex is present
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present

Draw*BaseVertex methods are enabled if
the EXT_draw_elements_base_vertex extension is present
Follow-up on 1b1ea05b

Components: AOSP

Affects: dEQP-GLES31.functional.draw_base_vertex.*

Change-Id: If8a4860a956c771ec5ea3341e2227f437b12a286

6 years agoFix texture mip level size in framebuffer fetch tests
Mika Isojrvi [Thu, 17 Aug 2017 00:08:48 +0000 (00:08 +0000)]
Fix texture mip level size in framebuffer fetch tests
am: be0d165a5d

Change-Id: I7fb9c075ee79e411ea295999e9edd7f38a5e5bc9

6 years agoFix texture mip level size in framebuffer fetch tests
Mika Isojärvi [Wed, 16 Aug 2017 20:40:22 +0000 (13:40 -0700)]
Fix texture mip level size in framebuffer fetch tests

Bug: 64280744
Test: Ran tests with multiple Google devices
Change-Id: I369a3c9b16270655332d5a608207f0da2633e0fe

6 years agoMerge "Use safe glFramebufferTexture* function"
james.glanville [Wed, 16 Aug 2017 19:04:43 +0000 (19:04 +0000)]
Merge "Use safe glFramebufferTexture* function"
am: ec5ccbe144

Change-Id: I156ecc2a6ed17e3e23ef17ebbe026be27c1670c3

6 years agoMerge "Do not use degenerate frames in EGL tests"
Michael Chock [Wed, 16 Aug 2017 19:04:22 +0000 (19:04 +0000)]
Merge "Do not use degenerate frames in EGL tests"
am: f5971fe17f

Change-Id: I9807e27047a0d0280e06bc826cab3e6cb88b5ab6

6 years agoMerge "Use safe glFramebufferTexture* function"
Treehugger Robot [Wed, 16 Aug 2017 18:59:45 +0000 (18:59 +0000)]
Merge "Use safe glFramebufferTexture* function"

6 years agoMerge "Do not use degenerate frames in EGL tests"
Treehugger Robot [Wed, 16 Aug 2017 18:59:42 +0000 (18:59 +0000)]
Merge "Do not use degenerate frames in EGL tests"

6 years agoMerge "Report tests using Draw*BaseVertex as NotSupported"
Alexander Galazin [Wed, 16 Aug 2017 18:47:50 +0000 (18:47 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"
am: f96636fdfa

Change-Id: Iccb20250f9b98f983fc831911a1f9b4d4a98fbfb

6 years agoMerge "Report tests using Draw*BaseVertex as NotSupported"
Treehugger Robot [Wed, 16 Aug 2017 18:36:54 +0000 (18:36 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"

6 years agoMerge "Fix error double accounting in fuzzyCompare()"
Alexander Galazin [Wed, 16 Aug 2017 18:20:18 +0000 (18:20 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"
am: 0cf17c4bf8

Change-Id: Ife3e4f1bd13c6f4cb939950635880ce32d2b1df3

6 years agoMerge "Fix error double accounting in fuzzyCompare()"
Treehugger Robot [Wed, 16 Aug 2017 18:06:52 +0000 (18:06 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"

6 years agoAvoid thread state races in EGL multithread tests
Michael Chock [Mon, 14 Aug 2017 15:36:11 +0000 (08:36 -0700)]
Avoid thread state races in EGL multithread tests

Previously, threads objects inside dEQP-EGL.functional.multithread.*
tests would conflate thread execution status with test results. The
former would only be set inside the thread, but the latter could be set
by other threads (e.g., a test thread might set its status to RUNNING
while another test might attempt to set the status of NOT_SUPPORTED).
These race conditions could lead to incorrect results.

Fix this by moving error and not-supported states out of the thread
execution state, and instead storing them as single-purpose flags inside
the test case object, avoiding the possibility of conflicting writes.

Change-Id: I2b117aa98c1c2b69b0d134610d6fd37656083e54

6 years agoDo not use degenerate frames in EGL tests
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests

The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).

Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.

Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28

6 years agoUse safe glFramebufferTexture* function
james.glanville [Wed, 16 Aug 2017 10:50:19 +0000 (11:50 +0100)]
Use safe glFramebufferTexture* function

glFramebufferTexture() is only supported when GL_EXT_geometry_shader is
present. Use glFramebufferTextureLayer() instead so that testing is
possible on unextended ES3.1 contexts.

Components: AOSP

Affects:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.framebuffer_texture_level

6 years agoReport tests using Draw*BaseVertex as NotSupported
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Report tests using Draw*BaseVertex as NotSupported

Draw*BaseVertex methods were added in GLES 3.2.
Report tests using these methods as NotSupported if
GLES 3.1 context is returned.

Components: AOSP

Affects: dEQP-GLES31.functional.draw_base_vertex.*

Change-Id: I87c918d5f66a0a5b547f8e625c662203a7f85048

6 years agoCheck for tessellation/geometry extensions being exposed
Alexander Galazin [Wed, 16 Aug 2017 00:32:11 +0000 (00:32 +0000)]
Check for tessellation/geometry extensions being exposed
am: 573154bb7b

Change-Id: I86d05362cf94c693d4000969d2c177c692f07686

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Alexander Galazin [Fri, 11 Aug 2017 16:32:00 +0000 (18:32 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Iae127509ee1d187291e37c0ee9da7d331b070646

6 years agoKeep buffer memory alive through BufferView creation
Gary Sweet [Wed, 26 Jul 2017 09:50:31 +0000 (10:50 +0100)]
Keep buffer memory alive through BufferView creation

The device memory used to create a buffer was going out
of scope and being freed too early. A buffer view was
subsequently made using the buffer. This is invalid.

This change extends the lifetime of the buffer memory to
match the buffer.

Affects:

dEQP-VK.api.buffer_view.create.*

Components: Vulkan

VK-GL-CTS issue: 574

Change-Id: I6605da750d6494587781285447a157ef12018459

6 years agoFix combined depth/stencil clear colors.
Dave Airlie [Thu, 27 Jul 2017 19:43:53 +0000 (05:43 +1000)]
Fix combined depth/stencil clear colors.

This test was clearing depth to 256.0, values > 1.0 are undefined.

This fixes the the combined depth/stencil clears to use valid values
for depth and stencil.

Affects:
dEQP-VK.api.copy_and_blit.core.image_to_image.all_formats.depth_stencil.*

VK-GL-CTS Issue: 591

Change-Id: I75fd7e2bf17a84f7a2730f36b4bcdc066af1177c

6 years agoFixed incorrect calculation of GCD
Oivind Boge [Thu, 10 Aug 2017 10:24:02 +0000 (12:24 +0200)]
Fixed incorrect calculation of GCD

The calculation of greatest common divisor was
implemented incorrect when first added.
The function was using the input parameter instead
of its local copy of the input, which is updated
for each iteration of the calculation.

Affects:

dEQP-VK.api.image_clearing.*

Components: Vulkan

VK-GL-CTS issue: 625

Change-Id: I6619e4a30d89148d2567a725dbd27161fcf29a47

6 years agoFix layout transition for WSI tests
Oivind Boge [Sat, 8 Jul 2017 12:09:12 +0000 (14:09 +0200)]
Fix layout transition for WSI tests

The initial layout of the renderpass can't be
COLOR_ATTACHMENT_OPTIMAL without any transition
happening upfront.

Affects:
dEQP-VK.wsi.android.display_timing.*
dEQP-VK.wsi.android.incremental_present.*

Components: Vulkan

VK-GL-CTS issue: 565

Change-Id: Ie62f7aee21c52145090bf228db7031c0e4afb347

6 years agoRespect sampleRateShading availability in interpolate tests
Gary Sweet [Thu, 27 Jul 2017 10:42:40 +0000 (11:42 +0100)]
Respect sampleRateShading availability in interpolate tests

Most of the tests in the dEQP-VK.pipeline.multisample_interpolation
group use one of the interpolatAt*() functions in their shaders.
These are only valid if sampleRateShading is available.

The multisampleStateInfo also blindly sets sampleShadingEnable
to true without checking.

Affects:

dEQP-VK.pipeline.multisample_interpolation.*

Components: Vulkan

VK-GL-CTS issue: 600

Change-Id: I95f91af9a7abb1e55ff2a3da0c0daefb819226f9

6 years agoFix regressions in synchronization tests for dedicated allocations
Slawomir Cygan [Mon, 31 Jul 2017 12:22:50 +0000 (14:22 +0200)]
Fix regressions in synchronization tests for dedicated allocations

Pass image memory requirements to allocation routine in allocateAndBindMemory.

VK_KHR_get_memory_requirements2 is a device extension (not instance).

Throw NotSupported when external handle requires dedicated allocation,
but 'suballocated' variant of test is being run.

Affects:
dEQP-VK.synchronization.cross_instance.*

Components: Vulkan

VK-GL-CTS issue: 604

Change-Id: I3636779459300f5dee2e22b0a2e04762eb7b0601

6 years agoCheck for tessellation/geometry extensions being exposed
Alexander Galazin [Fri, 11 Aug 2017 09:03:50 +0000 (11:03 +0200)]
Check for tessellation/geometry extensions being exposed

Some sample_variables tests use tessellation/geometry shaders.
Need to check that the relevant extensions are exposed.

Components: AOSP

Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.oes_sample_variables.access_built_in_types_inside_other_shaders

Change-Id: Iff74939d474082938955e5b7ebfc41ea3b4a6ec5

6 years agoSuppress non-critical warnings in external/deqp.
Chih-Hung Hsieh [Thu, 10 Aug 2017 16:22:23 +0000 (16:22 +0000)]
Suppress non-critical warnings in external/deqp.
am: b7ae0d8484

Change-Id: I203833d39406f0530796d10e6d7a4d8f9beb2dbb

6 years agoFix error double accounting in fuzzyCompare()
Alexander Galazin [Tue, 8 Aug 2017 11:15:40 +0000 (13:15 +0200)]
Fix error double accounting in fuzzyCompare()

fuzzyCompare() has a loop to go through all the pixels and generate error sum.
It skips some pixels using random number generator between 0-8.
Random number generator sometime generate 0 and it ends up
calculating error sum twice for the same pixel.
If this pixel has error, then this add up error sum twice.

Components: Framework

Change-Id: I08e06e29faedb99cfd8fa479e97a437c06008848

6 years agoSuppress non-critical warnings in external/deqp.
Chih-Hung Hsieh [Wed, 9 Aug 2017 23:23:07 +0000 (16:23 -0700)]
Suppress non-critical warnings in external/deqp.

* We should enable those warnings after fixing the upstream source code.

Bug: 64487164
Test: build with WITH_TIDY=1
Change-Id: Ie4961d23b8f57e8d3a3ada0e64df82ed18dd366f

6 years agoRespect maximum workgroup count in SpvAsmInstructionTests
Gary Sweet [Tue, 8 Aug 2017 08:44:35 +0000 (09:44 +0100)]
Respect maximum workgroup count in SpvAsmInstructionTests

The createOpAtomic group was using a hard-coded 1000000
for numElements which is later used as the workgroup count.
The minimum mandatory workgroup count is 65535, far less
than the 1000000 being used.

Affects:

dEQP-VK.spirv_assembly.instruction.compute.opatomic*

Components: Vulkan

VK-GL-CTS issue: 613

Change-Id: I523451d33dbb116e6ca2aaa00a948ec6782382b3

6 years agoSparse buffer test: allocate memory in one big chunk
Maciej Jesionowski [Wed, 26 Jul 2017 13:33:59 +0000 (15:33 +0200)]
Sparse buffer test: allocate memory in one big chunk

The test made excessive small memory allocations breaking the
maxMemoryAllocationCount limit.

Affects:

dEQP-VK.sparse_resources.buffer.transfer.sparse_binding.buffer_size_2_24

Components: Vulkan
VK-GL-CTS issue: 592

Change-Id: Ic7c1c07db2b805806e2c940d3fd4d96e12043aaf

6 years agoMerge "Release EGL resources in CTS worker threads"
Mika Isojarvi [Fri, 4 Aug 2017 23:10:09 +0000 (23:10 +0000)]
Merge "Release EGL resources in CTS worker threads"
am: fde96926aa

Change-Id: I8502a522e44c310dfb96710c7b301ebe798668ec

6 years agoMerge "Release EGL resources in CTS worker threads"
Mika Isojarvi [Fri, 4 Aug 2017 22:55:11 +0000 (22:55 +0000)]
Merge "Release EGL resources in CTS worker threads"

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:33:28 +0000 (22:33 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043 am: a2d901c3d8 am: 2431a0b0d9 am: 5fe6ec300f
am: 781a2ef1e0

Change-Id: I88ecd39f47d5c87973d92db0570e1a4dd46e3c27

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:33:09 +0000 (22:33 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1 am: 3558abf238 am: 222fa619e5
am: 37ce9a1ac7

Change-Id: I4732c21d607253f197be74652f87c71f069437e0

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:27:22 +0000 (22:27 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043 am: a2d901c3d8 am: 2431a0b0d9
am: 5fe6ec300f

Change-Id: I9bac6748b66744cccf998ee698f4f4b04e69e961

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:27:05 +0000 (22:27 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1 am: 3558abf238
am: 222fa619e5

Change-Id: I218a43847e48773bbfea387a68864204bf99cec3

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:21:26 +0000 (22:21 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043 am: a2d901c3d8
am: 2431a0b0d9

Change-Id: I80c9b1fe0131870b22c2d81d21543c59d2a3bf06

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:21:06 +0000 (22:21 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1
am: ea24f81118

Change-Id: I02de92c1f3a63550bc24575d73e67dce8c6d6923

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:21:04 +0000 (22:21 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1
am: 3558abf238

Change-Id: I2a9cf3840c5fa7f4a004cc2c46f41a22222a4ac6

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:20:34 +0000 (22:20 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043
am: a2d901c3d8

Change-Id: I4da52aeb3a4c496dd7071eedff513db057a86ed1

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:14:34 +0000 (22:14 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32
am: 5bd0fb31a1

Change-Id: Id14e6caccfe5173661572abb58006199597a945e

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:14:33 +0000 (22:14 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32
am: b8e4ff4043

Change-Id: I79289a400b489142682865c5a9f8153d2b97650f

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Fri, 4 Aug 2017 22:09:03 +0000 (22:09 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32
am: 5bd0fb31a1

Change-Id: I2ab773e341fe8a0819963ca9351894ee740591cf

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev
Graeme Leese [Fri, 4 Aug 2017 22:08:05 +0000 (22:08 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
am: 4f1051ad32

Change-Id: I3bc55d8c7271eb61c7c593505dab8e13e0b48e16

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev
Graeme Leese [Fri, 4 Aug 2017 22:03:02 +0000 (22:03 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
am: 4f1051ad32

Change-Id: I4f54481292ffaaf5e1cf56a05ef24f7dfa4983f3

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev
Treehugger Robot [Fri, 4 Aug 2017 21:56:36 +0000 (21:56 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev

6 years agoCheck for EGLimage support in EGLimage test
Michael Chock [Fri, 4 Aug 2017 19:38:53 +0000 (19:38 +0000)]
Check for EGLimage support in EGLimage test
am: 1886241d23

Change-Id: Ia4d21d273030b87dd9aa6b5e3eae5323bfe41dab

6 years agoRelease EGL resources in CTS worker threads
Michael Chock [Wed, 26 Jul 2017 17:07:16 +0000 (10:07 -0700)]
Release EGL resources in CTS worker threads

For worker threads in multithreaded EGL tests, call eglReleaseThread
before thread termination.

Affects:

dEQP-EGL.functional.color_clears.multi_thread.*
dEQP-EGL.functional.multithread.*
dEQP-EGL.functional.render.multi_thread.*
dEQP-EGL.functional.thread_cleanup.*
dEQP-EGL.performance.gles2_shared_render.*

Change-Id: I1e47fae1b9a3d1f148a80215c1c2baa0b684c57e

6 years agoCheck for EGLimage support in EGLimage test
Michael Chock [Tue, 25 Jul 2017 20:16:38 +0000 (13:16 -0700)]
Check for EGLimage support in EGLimage test

Verify support for EGL 1.5+, EGL_KHR_image, or EGL_KHR_image_base before
attempting to call eglCreateImage[KHR] in test
dEQP-EGL.functional.image.api.invalid_create_image.

Change-Id: Icde0f5c568a00da7b7aaa07bc2fb58b7d62df165

6 years agoCP: Add triangle edge guardband for Tex2D lookup diff
Kalle Raita [Tue, 18 Jul 2017 21:52:15 +0000 (14:52 -0700)]
CP: Add triangle edge guardband for Tex2D lookup diff

Cherry-pick AOSP Change: dcb5991811ed287fc4a72126663136a94eb7dc39

Previously 3D and cube textures allowed pixels along the seam of
triangles to use data from either triangle. This change copies that
allowance to the 2D texture computeTextureLookupDiff. The projection
values chosen for the mipmap.2d.projected group make the data
discontinous over the edge, making it sensitive to tie-breaker
resolution. This change resolves the issue.

Affects: framework

Test: Executed mipmap.2d.projected group with failing result images
Bug: 63335787
Change-Id: Ibaed590fb5e1bc9eb837c9027ddadcea2081f629

6 years agoAllow VK_KHR_relaxed_block_layout extension
Daniel Koch [Wed, 26 Jul 2017 17:38:21 +0000 (13:38 -0400)]
Allow VK_KHR_relaxed_block_layout extension

VK-GL-CTS Issue: 596

Affects:
dEQP-VK.api.info.device.extensions

Change-Id: I25395cbc76e2a4a176c74e9d46f16f3e105c4669
Component: Vulkan

6 years agoSparse buffer test: allocate memory in one big chunk
Maciej Jesionowski [Wed, 26 Jul 2017 13:33:59 +0000 (15:33 +0200)]
Sparse buffer test: allocate memory in one big chunk

The test made excessive small memory allocations breaking the
maxMemoryAllocationCount limit.

Affects:

dEQP-VK.sparse_resources.buffer.transfer.sparse_binding.buffer_size_2_24

Components: Vulkan
VK-GL-CTS issue: 592

Change-Id: Ic7c1c07db2b805806e2c940d3fd4d96e12043aaf

6 years agoAdd VK_KHR_relaxed_block_layout
Arkadiusz Sarwa [Wed, 15 Mar 2017 15:02:07 +0000 (16:02 +0100)]
Add VK_KHR_relaxed_block_layout

New tests:

dEQP-VK.ssbo.layout.multi_basic_types.*.relaxed_block*
dEQP-VK.ssbo.layout.random.relaxed.*

VK-GL-CTS issue: 117
Components: Vulkan

Change-Id: Ieda2aa291dcbff250b81e0da06c39781800f4af7
(cherry picked from commit 2a11db7c2e23afd4bef2f9a0eab84356d912ff3c)

6 years agoAdd GlslBuildOptions::FLAG_ALLOW_RELAXED_OFFSETS
Arkadiusz Sarwa [Tue, 9 May 2017 14:45:32 +0000 (16:45 +0200)]
Add GlslBuildOptions::FLAG_ALLOW_RELAXED_OFFSETS

Enabling the flag allows GLSL to use layout(offset = N) qualifiers that
follow VK_KHR_relaxed_block_layout rules instead of GLSL std140/std430
rules.

Components: Vulkan

Change-Id: I4f168b04ad0916b740891b603ddde2de0f4bcf50
(cherry picked from commit 4b82e12d3a7bf0947887e0b9d586d0ab63bd4888)

6 years agoSelect correct memory heap index for memory import
Tony Zlatinski [Wed, 19 Jul 2017 21:21:53 +0000 (16:21 -0500)]
Select correct memory heap index for memory import

When importing memory, the application (CTS) should follow
the spec rules about memory imports. I.e. The application must use the
same memory heap index for the import that has been used for the
exported memory. In addition, the application can't
import a buffer or image to a heap that does not support CPU mapping and
expect the memory to be CPU mappable/accessible.

This change modifies the export memory routines, now, returning the
index of the heap memory used for the export. Then the import routines are
modified to use those indexes for the memory import operations.

Components: Vulkan

Affects:
    dEQP-VK.api.external.memory.*
    dEQP-VK.synchronization.cross_instance.*

VK-GL-CTS issue: 585

Change-Id: I48ab85b7fd2b67655163f055fb03e8f2a3a42fd6

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Alexander Galazin [Fri, 21 Jul 2017 17:51:48 +0000 (19:51 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Ifac39caba5598cbb75d5fb25d271ad0b709140a6

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.0 into vk-gl-cts/vulkan-cts-1.0.1
Alexander Galazin [Fri, 21 Jul 2017 17:44:17 +0000 (19:44 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.0 into vk-gl-cts/vulkan-cts-1.0.1

Change-Id: If1266ef43a81d4d015c3f656315ea629acbbd55e

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Alexander Galazin [Fri, 21 Jul 2017 16:55:45 +0000 (18:55 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: I65f618365df474653f68d311647f601f91a38e4b

6 years agoFix layout transition in blitting tests
Igor Ostrowski [Tue, 4 Jul 2017 16:01:23 +0000 (18:01 +0200)]
Fix layout transition in blitting tests

Affects:
dEQP-VK.api.copy_and_blit.*.blit_image.*

Components: Vulkan
VK-GL-CTS issue: 571

Change-Id: I780374a8fbff336a7789bd6a745e635ac1202b62

6 years agoAdd metadata bindings in sparse tests
Igor Ostrowski [Wed, 12 Jul 2017 13:15:14 +0000 (15:15 +0200)]
Add metadata bindings in sparse tests

All metadata must be bound prior to device use of the sparse image

Affects:
dEQP-VK.sparse_resources.image_sparse_residency.*
dEQP-VK.sparse_resources.mipmap_sparse_residency.*
dEQP-VK.sparse_resources.shader_intrinsics.*

dEQP-VK.glsl.texture_functions.*sparse*
dEQP-VK.glsl.texture_gather.*sparse*

Components: Vulkan
VK-GL-CTS issue: 572

Change-Id: I4bbf2b74ed7fc0cea000084769cbed0dbe4a802e

6 years agoMerge "Add triangle edge guardband for Tex2D lookup diff"
Kalle Raita [Thu, 20 Jul 2017 19:42:12 +0000 (19:42 +0000)]
Merge "Add triangle edge guardband for Tex2D lookup diff"
am: da231f19ab

Change-Id: I5162ef3b9e6d763e55b7e6a9049ae80523cafdb3

6 years agoMerge "Add triangle edge guardband for Tex2D lookup diff"
Kalle Raita [Thu, 20 Jul 2017 19:30:15 +0000 (19:30 +0000)]
Merge "Add triangle edge guardband for Tex2D lookup diff"

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Wed, 19 Jul 2017 18:26:35 +0000 (18:26 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035 am: 68d441aedd am: 088fbbc341 am: e3939224e7
am: 495df8aec0

Change-Id: Ie22789b44c3ae1b00aedeaa9df52e24488993ed2

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Wed, 19 Jul 2017 18:24:02 +0000 (18:24 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035 am: 68d441aedd am: 088fbbc341
am: e3939224e7

Change-Id: Ib71adcb75609cafc2133ec1804411213466f0446

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Wed, 19 Jul 2017 18:21:30 +0000 (18:21 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035 am: 68d441aedd
am: 088fbbc341

Change-Id: I3468636282d98362d3f35be92a8cd86aefd14bb4

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac...
Mika Isojrvi [Wed, 19 Jul 2017 18:19:03 +0000 (18:19 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac am: 754e8f0192 am: d422ad8111
am: a8804ca914

Change-Id: I6518e6abcc83b89b14d187e2d16fec2754337298

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Wed, 19 Jul 2017 18:18:59 +0000 (18:18 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035
am: 68d441aedd

Change-Id: I0987771e5baa7f39cdecfcfa12dec7bf03c627a8

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Wed, 19 Jul 2017 18:16:00 +0000 (18:16 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f
am: 1b81ecf035

Change-Id: Ib2b42f6a400417daa850bd107b56373475058840

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac...
Mika Isojrvi [Wed, 19 Jul 2017 18:16:00 +0000 (18:16 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac am: 754e8f0192
am: d422ad8111

Change-Id: I6046d017e6528f4e80282ba82c58344c9d51085b

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3
Mika Isojrvi [Wed, 19 Jul 2017 18:13:49 +0000 (18:13 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3
am: 674ba44413

Change-Id: I182f8ee0b409eaa2000f3d18aa9c7d10b076b578

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813...
Mika Isojrvi [Wed, 19 Jul 2017 18:13:34 +0000 (18:13 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813 am: 66bd71c817
am: c06d76b076

Change-Id: I8c4a4123d2258dd3bd577ce309204141a3a20d7e

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e
Mika Isojrvi [Wed, 19 Jul 2017 18:13:31 +0000 (18:13 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e
am: 550064261f

Change-Id: I9cd9791970b8a466b1a3a31adae45d9375ab5321

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac
Mika Isojrvi [Wed, 19 Jul 2017 18:13:30 +0000 (18:13 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac
am: 754e8f0192

Change-Id: I8dfffa1cad4108bf3fd6f9cc8136cf5215d61ad6

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20
Mika Isojrvi [Wed, 19 Jul 2017 18:10:30 +0000 (18:10 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20
am: cae1fe52ac

Change-Id: Iad44b21021d6f24b0d6c126cf81cf24632a0aaab

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813
Mika Isojrvi [Wed, 19 Jul 2017 18:10:29 +0000 (18:10 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813
am: 66bd71c817

Change-Id: If7fb06d8679a3de6238cad0b726b5fe96bddd036

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209
Mika Isojrvi [Wed, 19 Jul 2017 18:10:29 +0000 (18:10 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209
am: 73a16f417e

Change-Id: I28d74629adfb6ebb7898c1fc7c9bd831ca4562ae

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
Mika Isojrvi [Wed, 19 Jul 2017 18:07:01 +0000 (18:07 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
am: 6e80057a20

Change-Id: I85568945b0bb02c5b82dbba6ba449cd851358694

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3
Mika Isojrvi [Wed, 19 Jul 2017 18:07:00 +0000 (18:07 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3
am: d20475d813

Change-Id: Ib23d8a8b67847c4444f7c1e2e05af16c023f9cb4

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad
Mika Isojrvi [Wed, 19 Jul 2017 18:07:00 +0000 (18:07 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad
am: 580f143209

Change-Id: Ib4610c6afd22db3a464e3079ddca088aefaed271

6 years agoFix atomic ssbo xor test am: f0fa05e898
Mika Isojrvi [Wed, 19 Jul 2017 18:04:31 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am: f0fa05e898
am: 14cd264501

Change-Id: Ide39036c1f956b64464d21eced9a16c0a2022f2b

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
Mika Isojrvi [Wed, 19 Jul 2017 18:04:31 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
am: d4c01761d3

Change-Id: I3fe580bed5dcdb5f41742c0e6e0ee1db05eae572

6 years agoFix atomic ssbo xor test am: f0fa05e898
Mika Isojrvi [Wed, 19 Jul 2017 18:04:29 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am: f0fa05e898
am: b426d8bfad

Change-Id: I98bcc7054eeca8fb9621694f0b628727bdcdec2c

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
Mika Isojrvi [Wed, 19 Jul 2017 18:03:03 +0000 (18:03 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501
am: d4c01761d3

Change-Id: I32a66d488ccd7f1544f23b299eaf4d0642cebc4a

6 years agoFix atomic ssbo xor test
Mika Isojrvi [Wed, 19 Jul 2017 18:02:00 +0000 (18:02 +0000)]
Fix atomic ssbo xor test
am: f0fa05e898

Change-Id: I593778e49374ab84b2b5b0b3fca57f36adf18684

6 years agoFix atomic ssbo xor test am: f0fa05e898
Mika Isojrvi [Wed, 19 Jul 2017 18:00:27 +0000 (18:00 +0000)]
Fix atomic ssbo xor test am: f0fa05e898
am: 14cd264501

Change-Id: Ib554d7464534203cbcde53f0ebd6931082900a82

6 years agoFix atomic ssbo xor test
Mika Isojrvi [Wed, 19 Jul 2017 17:57:28 +0000 (17:57 +0000)]
Fix atomic ssbo xor test
am: f0fa05e898

Change-Id: Ibc16a0ff1a6b1dbe764d4beafa5d9b63d9c090e9

6 years agoAdd triangle edge guardband for Tex2D lookup diff
Kalle Raita [Tue, 18 Jul 2017 21:52:15 +0000 (14:52 -0700)]
Add triangle edge guardband for Tex2D lookup diff

Previously 3D and cube textures allowed pixels along the seam of
triangles to use data from either triangle. This change copies that
allowance to the 2D texture computeTextureLookupDiff. The projection
values chosen for the mipmap.2d.projected group make the data
discontinous over the edge, making it sensitive to tie-breaker
resolution. This change resolves the issue.

Affects: framework

Test: Executed mipmap.2d.projected group with failing result images
Bug: 63335787
Change-Id: Ibaed590fb5e1bc9eb837c9027ddadcea2081f629

6 years agoEGL: Add wide-color tests
Courtney Goeltzenleuchter [Tue, 18 Jul 2017 20:25:01 +0000 (20:25 +0000)]
EGL: Add wide-color tests
am: 6a26fb1fd0

Change-Id: Ib496be50b20bce758c441f08a34b0e10998b2e98

6 years agoFix atomic ssbo xor test
Mika Isojärvi [Thu, 14 Apr 2016 17:28:16 +0000 (10:28 -0700)]
Fix atomic ssbo xor test

Allow any values in high order bits in xor tests when using uint types.

Bug: 28144118
Change-Id: I0670aa12642882a329cb923487198fdf045b912b

6 years agoEGL: Add wide-color tests
Courtney Goeltzenleuchter [Mon, 19 Jun 2017 16:35:01 +0000 (10:35 -0600)]
EGL: Add wide-color tests

Verify necessary extensions and functionality
is present to support wide-color. Specifically, pixel formats
FP16 and 10:10:10:2 and Display-P3 color space.

Test: adb -d shell \
      am start -n com.drawelements.deqp/android.app.NativeActivity \
      -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
      --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

TODO:
- Do we need test for EGL_EXT_gl_colorspace_scrgb_linear?
  That should be no-op for driver.

Change-Id: I537a04b1680e33e46215c4bb583f6987d20f0b4a

6 years agoMerge "Merge Vulkan CTS 1.0.2.4 into aosp/master"
Mika Isojarvi [Mon, 17 Jul 2017 20:19:45 +0000 (20:19 +0000)]
Merge "Merge Vulkan CTS 1.0.2.4 into aosp/master"
am: 0f5658c72b

Change-Id: Id028fbdc5b596d55e044fb80ad34ecc95d0563a4

6 years agoMerge "Merge Vulkan CTS 1.0.2.4 into aosp/master"
Mika Isojarvi [Mon, 17 Jul 2017 20:13:57 +0000 (20:13 +0000)]
Merge "Merge Vulkan CTS 1.0.2.4 into aosp/master"

6 years agoFix incorrect scale in pipeline_barrier tests
JarredDavies [Fri, 14 Jul 2017 14:55:46 +0000 (15:55 +0100)]
Fix incorrect scale in pipeline_barrier tests

The ImageBlitFromImage verfication code incorrectly scales the refrence image it creates.
The test should add 0.5 to the x and y coords before scaling them.

Affects:
dEQP-VK.memory.pipeline_barrier.*

Components: Vulkan

VK-GL-CTS issue: 577

Change-Id: I28d0b4deec0f1837c21cdc2dc68a9169ca8ae96b

6 years agocopies_and_blitting: fix ambiguous signed normalized 1.0 value
Slawomir Cygan [Thu, 6 Jul 2017 17:24:18 +0000 (19:24 +0200)]
copies_and_blitting: fix ambiguous signed normalized 1.0 value

Below tests copy floats to signed normalized 8-bit values.
In that process it happens that 1.0 float value is copied to 8_snorm
elements as: {0x00, 0x00, 0x80, 0x3f}

According to spec, on SNORM values:

"Note that while zero is exactly expressible in this representation,
one value (-128 in the example) is outside the representable range,
and must be clamped before use."

The problem occurs when 0x80 == 128 value is copied to buffer:
as it falls outside of <-1,1> range, it may be clamped to 0x81 (both values
represent -1.0 SNORM value).

The change here processes all result and expected data buffers to remove
all ambiguites by converting to float and back to signed normalized format.

Affects:
dEQP-VK.api.copy_and_blit.*.image_to_image.all_formats.color.r32_sfloat.a8b8g8r8_snorm_pack32.*
dEQP-VK.api.copy_and_blit.*.image_to_image.all_formats.color.r32_sfloat.r8g8b8a8_snorm.*

Components: Vulkan

VK-GL-CTS issue: 563

Change-Id: I175665f39811cf6a80862967ad0a9bb8e13527e9

6 years agoRelax threshold in cube map filtering tests
Yanjun Zhang [Fri, 7 Jul 2017 20:45:59 +0000 (13:45 -0700)]
Relax threshold in cube map filtering tests

Use the same colorThreshold calculation as GLES CTS so Vulkan CTS
has the same behavior as GLES CTS.

Components: Vulkan

Affects:
dEQP-VK.pipeline.sampler.view_type.cube.format.r5g6b5_unorm_pack16.*

VK-GL-CTS issue: 561

Change-Id: I9bd632bb242f653b1f2d8bb50ee9867da926e95b

6 years agocross_instance sync: run without VK_KHR_get_memory_requirements2
Slawomir Cygan [Fri, 7 Jul 2017 14:41:30 +0000 (16:41 +0200)]
cross_instance sync: run without VK_KHR_get_memory_requirements2

This extension is used in the test, to check if resource needs dedicated
allocations (to be used created by dependent VK_KHR_dedicated_allocation
extension).

If the extension is not supported assume there is no need for dedicated
allocations.

Affects: dEQP-VK.synchronization.cross_instance.*

VK-GL-CTS issue: 548
Components: Vulkan

Change-Id: Icb4f5a34b98da213d0cb665bcc4e6b048d7b8a3c

6 years agoRefactor synchronization test code to avoid compiler warning
gkbldval [Fri, 14 Jul 2017 16:49:26 +0000 (18:49 +0200)]
Refactor synchronization test code to avoid compiler warning

vkt::synchronization::s_resources is unused in recently
added file, causing -Wunused warning (treated as error).

Affects: dEQP-VK.synchronization.*

Components: Vulkan

VK-GL-CTS issue: 578

Change-Id: Ifd8ce0812673e6b2da7c28bacb4384b3c80f65d1

6 years agoFix gcc 5.4 warnings
Alexander Galazin [Wed, 5 Jul 2017 15:09:38 +0000 (17:09 +0200)]
Fix gcc 5.4 warnings

gcc 5.4 (default in Ubuntu 16.04) reports conversion to int
warnings/errors for bitwise or and assign operator.

GCC bug: 40752

Components: Framework, Vulkan

Change-Id: Ia857c44cf54d5571d857e1fada0e2aaa8f4b950d
(cherry picked from commit 0bd8828618d95d2a83bc7475179a9227bfd22f5f)

6 years agoAdd option to skip fetch external sources
Alexander Galazin [Fri, 14 Jul 2017 07:48:05 +0000 (09:48 +0200)]
Add option to skip fetch external sources

Added option to check_build_sanity.py to skip running
fetch_sources.py. Allows to run multiple concurrent invocations
of check_build_sanity.py using the same source folder.

Components: Framework

Change-Id: I6289920860fb20287c405cefc0213c27f326857b

6 years agoMerge Vulkan CTS 1.0.2.4 into aosp/master
Mika Isojärvi [Fri, 14 Jul 2017 22:20:31 +0000 (15:20 -0700)]
Merge Vulkan CTS 1.0.2.4 into aosp/master

Bug: 62712168
Change-Id: Ib5dcdc7645193825171cb93c5a3b8a0820cbc5a1