Michael Komitee [Thu, 14 Feb 2013 03:42:56 +0000 (22:42 -0500)]
New tests fail on python 3.x because read() returns bytes and the test checks for strings
Michael Komitee [Thu, 14 Feb 2013 02:28:32 +0000 (21:28 -0500)]
Adding test to ensure options like stream function with authentication
This test demonstrates the reason why we need to pass kwargs to hooks. Without
it, features like stream cannot work with authentication.
Michael Komitee [Thu, 14 Feb 2013 00:11:38 +0000 (19:11 -0500)]
Use user supplied options when resending authenticated requests
Hooks sometimes have to send requests (e.g. when responding to a 401 during
authentication).
All keyword arguments should be passed along when hooks are dispatched so that
if a user wanted to use a timeout, stream, specify a cert location with the
verify flag, etc, their specification can be followed.
Kenneth Reitz [Wed, 13 Feb 2013 10:13:31 +0000 (02:13 -0800)]
Merge pull request #1185 from sigmavirus24/fix_hook_dispatching
Dispatch hooks before following redirects
Ian Cordasco [Wed, 13 Feb 2013 04:00:06 +0000 (23:00 -0500)]
Dispatch hooks before following redirects
Fixes #1183
Kenneth Reitz [Tue, 12 Feb 2013 16:43:02 +0000 (08:43 -0800)]
Merge pull request #1181 from denis-ryzhkov/master
Fix of UnicodeDecodeError on unicode header name that can be converted to ascii.
Kenneth Reitz [Tue, 12 Feb 2013 08:27:05 +0000 (00:27 -0800)]
Merge pull request #1184 from piotr-dobrogost/numeric_codes
small cleanup of redirect codes
Denis Ryzhkov [Tue, 12 Feb 2013 06:51:46 +0000 (09:51 +0300)]
Deleted is_py2 check from unicode_header_name fix thanks to Lukasa.
Piotr Dobrogost [Mon, 11 Feb 2013 22:07:12 +0000 (23:07 +0100)]
removed no longer used redirect codes from models
added numeric values of redirect codes in comments
Denis Ryzhkov [Mon, 11 Feb 2013 12:37:58 +0000 (15:37 +0300)]
Fix of UnicodeDecodeError on unicode header name that can be converted to ascii.
Kenneth Reitz [Mon, 11 Feb 2013 00:43:21 +0000 (16:43 -0800)]
Merge pull request #1180 from sigmavirus24/master
Fix Session level Cookie Handling
Ian Cordasco [Mon, 11 Feb 2013 00:36:36 +0000 (19:36 -0500)]
Test and perfection for cookie handling.
I also fixed up some of the RequestsCookieJar methods so using
jar.update(other_jar) works without a problem. This cleans up some of the code
in sessions and the resolve_redirects method.
Ian Cordasco [Sun, 10 Feb 2013 22:49:49 +0000 (17:49 -0500)]
And tests
Kenneth Reitz [Sun, 10 Feb 2013 22:43:58 +0000 (17:43 -0500)]
urllib3 update
#1053
Ian Cordasco [Sun, 10 Feb 2013 22:43:37 +0000 (17:43 -0500)]
Fix Setting a cookie on redirect
Kenneth Reitz [Sun, 10 Feb 2013 22:21:13 +0000 (14:21 -0800)]
Merge pull request #1173 from sigmavirus24/use_send_in_resolve_redirects
Use send in resolve redirects
Ian Cordasco [Sun, 10 Feb 2013 22:14:45 +0000 (17:14 -0500)]
Resolve @piotr-dobrogost's concerns
Piotr had good objections to my not re-sending the body of the request on 307.
Ian Cordasco [Fri, 8 Feb 2013 03:53:37 +0000 (22:53 -0500)]
Preserve the original request.
Let's make a copy to preserve it.
Ian Cordasco [Fri, 8 Feb 2013 03:42:58 +0000 (22:42 -0500)]
We shouldn't be sending the data on redirect.
As such, we should remove the body from the old request as well as the
Content-Length header.
Ian Cordasco [Fri, 8 Feb 2013 02:08:20 +0000 (21:08 -0500)]
Fix the potential issue mentioned in #1151
See: https://github.com/kennethreitz/requests/pull/1151#issuecomment-
12905796
This is solved by just reusing the PreparedRequest from the last request.
Kenneth Reitz [Sun, 10 Feb 2013 22:07:08 +0000 (14:07 -0800)]
Merge pull request #1161 from sigmavirus24/fix1159
If Content-Length is already set, don't override
Kenneth Reitz [Sun, 10 Feb 2013 22:06:38 +0000 (14:06 -0800)]
Merge pull request #1119 from Lukasa/diags
Better diagnostics when trying to send unprepared request
Cory Benfield [Wed, 6 Feb 2013 18:48:47 +0000 (18:48 +0000)]
Guard against users sending unprepared requests.
Kenneth Reitz [Wed, 6 Feb 2013 21:05:04 +0000 (13:05 -0800)]
Merge pull request #1162 from Lukasa/proxy_auth
Proxy Authorization Headers
Kenneth Reitz [Wed, 6 Feb 2013 19:53:55 +0000 (11:53 -0800)]
Merge pull request #1168 from Lukasa/freeze
Feature freeze.
Cory Benfield [Wed, 6 Feb 2013 19:01:24 +0000 (19:01 +0000)]
Feature freeze.
Cory Benfield [Wed, 6 Feb 2013 18:24:23 +0000 (18:24 +0000)]
Add Proxy-Auth header when proxies have credentials.
Kenneth Reitz [Tue, 5 Feb 2013 19:42:51 +0000 (11:42 -0800)]
Merge pull request #1151 from sigmavirus24/fix1133
Move redirect handling from Session.request to Session.send
Ian Cordasco [Fri, 1 Feb 2013 16:55:02 +0000 (11:55 -0500)]
If Content-Length is already set, don't override
Re: #1159
Kenneth Reitz [Fri, 1 Feb 2013 15:30:47 +0000 (07:30 -0800)]
Merge pull request #1158 from yehudasa/master
Fix check that breaks handling of 303 response in some cases (v2)
Yehuda Sadeh [Thu, 31 Jan 2013 18:32:00 +0000 (10:32 -0800)]
Fix POST 303 redirect resonse handling
This fixes issue #1156.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
Kenneth Reitz [Thu, 31 Jan 2013 14:35:42 +0000 (14:35 +0000)]
moar
Kenneth Reitz [Thu, 31 Jan 2013 13:20:14 +0000 (13:20 +0000)]
HMG
Kenneth Reitz [Wed, 30 Jan 2013 23:56:21 +0000 (15:56 -0800)]
Merge pull request #1153 from cbare/master
use only base filename in multipart file upload
Kenneth Reitz [Wed, 30 Jan 2013 23:54:20 +0000 (15:54 -0800)]
Merge pull request #1152 from ekatsah/patch-1
Update docs/user/advanced.rst
Christopher Bare [Wed, 30 Jan 2013 23:33:43 +0000 (15:33 -0800)]
shorten filename by os.path.basename in guess_filename(obj)
ekatsah [Wed, 30 Jan 2013 20:22:24 +0000 (21:22 +0100)]
Update docs/user/advanced.rst
Rephrasing a line in the docs, add explicite mention of "client side certificate" (for indexing and clarity)
Ian Cordasco [Wed, 30 Jan 2013 15:58:32 +0000 (10:58 -0500)]
Thanks to @maxcountryman for the code review
Ian Cordasco [Wed, 30 Jan 2013 04:50:37 +0000 (23:50 -0500)]
Fix the elapsed test and #1133
Kenneth Reitz [Tue, 29 Jan 2013 04:52:17 +0000 (20:52 -0800)]
Merge pull request #1143 from Lukasa/master
Response as iterator
Cory Benfield [Sat, 26 Jan 2013 15:54:06 +0000 (15:54 +0000)]
Fix test for Py3.
Cory Benfield [Sat, 26 Jan 2013 15:24:25 +0000 (15:24 +0000)]
More useful docstring.
Cory Benfield [Sat, 26 Jan 2013 15:19:01 +0000 (15:19 +0000)]
Make Response objects iterable.
Kenneth Reitz [Mon, 28 Jan 2013 17:40:10 +0000 (09:40 -0800)]
Merge pull request #1148 from sigmavirus24/timing_switch
Move the timing work to Session.send
Ian Cordasco [Mon, 28 Jan 2013 16:53:02 +0000 (11:53 -0500)]
Move the timing work to Session.send
per @kennethreitz's request
Kenneth Reitz [Mon, 28 Jan 2013 03:11:15 +0000 (19:11 -0800)]
Merge pull request #1146 from oczkers/master
It`s more pep8 now
Kenneth Reitz [Mon, 28 Jan 2013 03:10:16 +0000 (19:10 -0800)]
Merge pull request #1138 from clee/master
Time each request
Chris Lee [Mon, 28 Jan 2013 03:01:39 +0000 (19:01 -0800)]
Use timedelta and change attribute name back to elapsed
Chris Lee [Thu, 24 Jan 2013 02:14:47 +0000 (18:14 -0800)]
Time how long each request takes
Stored as attribute Response.time_taken
oczkers [Sun, 27 Jan 2013 01:04:12 +0000 (02:04 +0100)]
it`s more pep8 now
Kenneth Reitz [Sat, 26 Jan 2013 17:05:19 +0000 (09:05 -0800)]
Merge pull request #1145 from sigmavirus24/master
Mock the links test
Ian Cordasco [Sat, 26 Jan 2013 16:55:08 +0000 (11:55 -0500)]
Mock the links test.
Kenneth Reitz [Sat, 26 Jan 2013 05:02:01 +0000 (21:02 -0800)]
Merge pull request #1103 from dmckeone/master
Restore the ability to use a list of 2-tuples for the data keyword argument with requests.post.
Kenneth Reitz [Sat, 26 Jan 2013 05:00:33 +0000 (21:00 -0800)]
Merge pull request #1123 from andrewjesaitis/master
Fixes DigestAuth with Sessions
Kenneth Reitz [Sat, 26 Jan 2013 04:58:35 +0000 (20:58 -0800)]
Merge pull request #1140 from ralphbean/cookie-test
Test for cookie parameters.
Kenneth Reitz [Sat, 26 Jan 2013 04:58:20 +0000 (20:58 -0800)]
Merge pull request #1142 from theaeolianmachine/removeGETContentLength
Remove default Content-Length from GET requests.
Johnny Goodnow [Sat, 26 Jan 2013 04:50:58 +0000 (20:50 -0800)]
Remove Content-Length from GET/HEAD by default.
Now, Content-Length is only auto-added for non-GET/HEAD requests.
Johnny Goodnow [Fri, 25 Jan 2013 20:07:24 +0000 (12:07 -0800)]
Always add Content-Length to HTTP PATCH.
Johnny Goodnow [Fri, 25 Jan 2013 08:19:09 +0000 (00:19 -0800)]
Add myself to AUTHORS.
Johnny Goodnow [Fri, 25 Jan 2013 05:25:14 +0000 (21:25 -0800)]
Fix python 2.6 unittest compatability issue.
Johnny Goodnow [Fri, 25 Jan 2013 05:10:12 +0000 (21:10 -0800)]
Remove default Content-Length from GET requests.
Fix #1051.
Ralph Bean [Fri, 25 Jan 2013 05:10:51 +0000 (00:10 -0500)]
purported py2.6 support for cookies test.
Kenneth Reitz [Thu, 24 Jan 2013 18:00:24 +0000 (10:00 -0800)]
Merge pull request #1099 from sprt/master
Make hooks work with prepared requests
Ralph Bean [Thu, 24 Jan 2013 17:47:55 +0000 (12:47 -0500)]
Test for cookie parameters.
sprt [Thu, 24 Jan 2013 17:36:53 +0000 (18:36 +0100)]
Merge branch 'master' of git://github.com/kennethreitz/requests
Conflicts:
test_requests.py
Kenneth Reitz [Thu, 24 Jan 2013 01:37:13 +0000 (17:37 -0800)]
Merge pull request #1137 from whit537/unperson_test
Remove a test per @kennethreitz in IRC
Kenneth Reitz [Thu, 24 Jan 2013 01:34:55 +0000 (17:34 -0800)]
Merge pull request #1136 from steveklabnik/test_link_header
introduce a test for link headers.
Chad Whitacre [Thu, 24 Jan 2013 01:32:03 +0000 (20:32 -0500)]
Remove a test per @kennethreitz in IRC
The test suite is moving from the httpbin pattern (which hits the
network) to depending on the request.prepare method (which doesn't).
Here's a start ...
Steve Klabnik [Thu, 24 Jan 2013 01:31:05 +0000 (20:31 -0500)]
introduce a test for link headers.
Kenneth Reitz [Thu, 24 Jan 2013 01:06:40 +0000 (17:06 -0800)]
Merge pull request #1134 from steveklabnik/remove_silly_assert
remove silly assert
Steve Klabnik [Thu, 24 Jan 2013 01:03:43 +0000 (20:03 -0500)]
remove silly assert
Kenneth Reitz [Wed, 23 Jan 2013 22:02:37 +0000 (14:02 -0800)]
Merge pull request #1132 from sburns/jsonkwargs
Pass kwargs to json.loads
Scott Burns [Wed, 23 Jan 2013 21:25:48 +0000 (15:25 -0600)]
Pass kwargs to json.loads
Not all JSON is created equally. This commit
addresses when users want to take control of the
json decode process.
Andrew Jesaitis [Wed, 23 Jan 2013 17:32:56 +0000 (10:32 -0700)]
Moves num_401_calls counter to HTTPDigestAuth
Ian Cordasco [Wed, 23 Jan 2013 16:51:37 +0000 (11:51 -0500)]
Only call the hook once.
Ian Cordasco [Wed, 23 Jan 2013 16:28:30 +0000 (11:28 -0500)]
Comment & replace something that keeps disappearing
sprt [Wed, 23 Jan 2013 14:45:44 +0000 (15:45 +0100)]
Refactor prepare_hooks()
sprt [Wed, 23 Jan 2013 14:45:14 +0000 (15:45 +0100)]
Add missing import
sprt [Wed, 23 Jan 2013 13:42:45 +0000 (14:42 +0100)]
Merge remote-tracking branch 'upstream/master'
Conflicts:
requests/sessions.py
Kenneth Reitz [Wed, 23 Jan 2013 03:43:50 +0000 (19:43 -0800)]
Merge pull request #1125 from juanriaza/master
HTTPDigestAuth: missing algorithm field
Kenneth Reitz [Wed, 23 Jan 2013 02:51:17 +0000 (18:51 -0800)]
Merge pull request #1116 from Lukasa/master
Correct type of Content-Length headers.
Kenneth Reitz [Wed, 23 Jan 2013 02:48:31 +0000 (18:48 -0800)]
Merge pull request #1117 from sigmavirus24/issue1106
Fix #1106
Kenneth Reitz [Wed, 23 Jan 2013 01:53:16 +0000 (17:53 -0800)]
Merge pull request #1127 from sigmavirus24/fix1126
A simple fix
Kenneth Reitz [Wed, 23 Jan 2013 01:45:00 +0000 (17:45 -0800)]
Merge pull request #1128 from mvid/master
Updating urllib3 to current master
Mantas Vidutis [Tue, 22 Jan 2013 22:40:10 +0000 (14:40 -0800)]
update urllib3 to current master with ssl bugfixes
Ian Cordasco [Tue, 22 Jan 2013 22:21:34 +0000 (17:21 -0500)]
Tests pass this time.
Juan Riaza [Tue, 22 Jan 2013 15:35:16 +0000 (16:35 +0100)]
missing algorithm field
Kenneth Reitz [Tue, 22 Jan 2013 14:40:24 +0000 (06:40 -0800)]
Merge pull request #1121 from Lukasa/typo
Small typo fixes.
Kenneth Reitz [Tue, 22 Jan 2013 13:11:14 +0000 (05:11 -0800)]
Merge pull request #1097 from matthewlmcclure/issues/1096
Resolves the parts of #1096 in requests proper.
Kenneth Reitz [Tue, 22 Jan 2013 13:10:19 +0000 (05:10 -0800)]
Merge pull request #1095 from Jud/patch-1
Fix spacing in setup.py
Kenneth Reitz [Tue, 22 Jan 2013 13:09:11 +0000 (05:09 -0800)]
Merge pull request #1122 from Lukasa/readline
Decrease default line length for iter_lines
Ian Cordasco [Tue, 22 Jan 2013 01:21:08 +0000 (20:21 -0500)]
Fix failing tests.
Andrew Jesaitis [Mon, 21 Jan 2013 23:34:11 +0000 (16:34 -0700)]
Fixes repeated 401s when using DigestAuth with a session
Cory Benfield [Mon, 21 Jan 2013 21:15:04 +0000 (21:15 +0000)]
Decrease default line length for iter_lines
Cory Benfield [Mon, 21 Jan 2013 19:55:08 +0000 (19:55 +0000)]
Small typo fixes.
Kenneth Reitz [Mon, 21 Jan 2013 19:27:41 +0000 (11:27 -0800)]
Merge pull request #1120 from spulec/patch-2
Add py3.3 testing back
Steve Pulec [Mon, 21 Jan 2013 19:19:29 +0000 (14:19 -0500)]
Add py3.3 testing back
Cory Benfield [Sat, 19 Jan 2013 17:14:32 +0000 (17:14 +0000)]
Remove test that cannot work on Python3.
Ian Cordasco [Sat, 19 Jan 2013 16:49:52 +0000 (11:49 -0500)]
Fix #1106
Cory Benfield [Sat, 19 Jan 2013 12:07:34 +0000 (12:07 +0000)]
Ensure Content-Length is a string.