platform/upstream/gstreamer.git
16 years agoMerge other changes from 0.10.19 release branch.
Tim-Philipp Müller [Mon, 7 Apr 2008 10:50:11 +0000 (10:50 +0000)]
Merge other changes from 0.10.19 release branch.

Original commit message from CVS:
* NEWS:
* RELEASE:
* gst-plugins-base.doap:
Merge other changes from 0.10.19 release branch.

16 years agogst/: Work around missing bits of thread-safety on older GLibs some more to avoid...
Tim-Philipp Müller [Sun, 6 Apr 2008 20:16:27 +0000 (20:16 +0000)]
gst/: Work around missing bits of thread-safety on older GLibs some more to avoid assertions when starting up multipl...

Original commit message from CVS:
* gst-libs/gst/audio/gstbaseaudiosink.c:
(gst_base_audio_sink_class_init):
* gst-libs/gst/audio/gstbaseaudiosrc.c:
(gst_base_audio_src_class_init):
* gst/playback/gstplayback.c: (plugin_init):
* gst/volume/gstvolume.c: (plugin_init):
Work around missing bits of thread-safety on older GLibs some
more to avoid assertions when starting up multiple playbin
objects concurrently (see #512382).

16 years agogst-libs/gst/pbutils/missing-plugins.c: Remove some more fields.
Tim-Philipp Müller [Sun, 6 Apr 2008 17:19:39 +0000 (17:19 +0000)]
gst-libs/gst/pbutils/missing-plugins.c: Remove some more fields.

Original commit message from CVS:
* gst-libs/gst/pbutils/missing-plugins.c: (copy_and_clean_caps):
Remove some more fields.

16 years agoconfigure.ac: Actually build dlls when cross-compiling with mingw32.
Damien Lespiau [Sun, 6 Apr 2008 08:56:07 +0000 (08:56 +0000)]
configure.ac: Actually build dlls when cross-compiling with mingw32.

Original commit message from CVS:
Patch by: Damien Lespiau <damien dot lespiau at gmail dot com>
* configure.ac:
Actually build dlls when cross-compiling with mingw32.
Fixes bug #526247.

16 years agoconfigure.ac: Bump version to 0.10.19.1 after the unplanned 0.10.19 release.
Tim-Philipp Müller [Thu, 3 Apr 2008 23:01:11 +0000 (23:01 +0000)]
configure.ac: Bump version to 0.10.19.1 after the unplanned 0.10.19 release.

Original commit message from CVS:
* configure.ac:
Bump version to 0.10.19.1 after the unplanned 0.10.19 release.

16 years agotests/examples/seek/seek.c: Add statusbar.
Wim Taymans [Thu, 3 Apr 2008 16:10:53 +0000 (16:10 +0000)]
tests/examples/seek/seek.c: Add statusbar.

Original commit message from CVS:
* tests/examples/seek/seek.c: (play_cb), (pause_cb), (stop_cb),
(msg_buffering), (connect_bus_signals), (main):
Add statusbar.
Add buffering support with feedback in the statusbar.

16 years agoext/ogg/gstoggmux.c: Fix sample pipeline description.
Tim-Philipp Müller [Thu, 3 Apr 2008 15:58:37 +0000 (15:58 +0000)]
ext/ogg/gstoggmux.c: Fix sample pipeline description.

Original commit message from CVS:
* ext/ogg/gstoggmux.c:
Fix sample pipeline description.

16 years agodocs/plugins/: Add playbin, playbin2, decodebin, decodebin2, uridecodebin and oggmux
Stefan Kost [Thu, 3 Apr 2008 14:58:06 +0000 (14:58 +0000)]
docs/plugins/: Add playbin, playbin2, decodebin, decodebin2, uridecodebin and oggmux

Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-base-plugins-docs.sgml:
* docs/plugins/gst-plugins-base-plugins-overrides.txt:
* docs/plugins/gst-plugins-base-plugins-sections.txt:
Add playbin, playbin2, decodebin, decodebin2, uridecodebin and oggmux
* docs/plugins/gst-plugins-base-plugins.args:
* docs/plugins/gst-plugins-base-plugins.hierarchy:
* docs/plugins/gst-plugins-base-plugins.interfaces:
* docs/plugins/gst-plugins-base-plugins.prerequisites:
* docs/plugins/inspect/plugin-adder.xml:
* docs/plugins/inspect/plugin-alsa.xml:
* docs/plugins/inspect/plugin-audioconvert.xml:
* docs/plugins/inspect/plugin-audiorate.xml:
* docs/plugins/inspect/plugin-audioresample.xml:
* docs/plugins/inspect/plugin-audiotestsrc.xml:
* docs/plugins/inspect/plugin-cdparanoia.xml:
* docs/plugins/inspect/plugin-decodebin.xml:
* docs/plugins/inspect/plugin-ffmpegcolorspace.xml:
* docs/plugins/inspect/plugin-gdp.xml:
* docs/plugins/inspect/plugin-gnomevfs.xml:
* docs/plugins/inspect/plugin-libvisual.xml:
* docs/plugins/inspect/plugin-ogg.xml:
* docs/plugins/inspect/plugin-pango.xml:
* docs/plugins/inspect/plugin-playback.xml:
* docs/plugins/inspect/plugin-queue2.xml:
* docs/plugins/inspect/plugin-subparse.xml:
* docs/plugins/inspect/plugin-tcp.xml:
* docs/plugins/inspect/plugin-theora.xml:
* docs/plugins/inspect/plugin-typefindfunctions.xml:
* docs/plugins/inspect/plugin-uridecodebin.xml:
* docs/plugins/inspect/plugin-video4linux.xml:
* docs/plugins/inspect/plugin-videorate.xml:
* docs/plugins/inspect/plugin-videoscale.xml:
* docs/plugins/inspect/plugin-videotestsrc.xml:
* docs/plugins/inspect/plugin-volume.xml:
* docs/plugins/inspect/plugin-vorbis.xml:
* docs/plugins/inspect/plugin-ximagesink.xml:
* docs/plugins/inspect/plugin-xvimagesink.xml:
Update introspection data.
* ext/ogg/gstoggmux.c:
Document oggmux.
* gst/playback/gstdecodebin2.c:
Don't use gtk-doc style comment start for private stuff, but make it
formatted like this for consistency.

16 years agogst/playback/gstdecodebin2.c: Remove fakesink hack, we can now implement this more...
Wim Taymans [Thu, 3 Apr 2008 12:16:04 +0000 (12:16 +0000)]
gst/playback/gstdecodebin2.c: Remove fakesink hack, we can now implement this more elegantly.

Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_bin_class_init),
(gst_decode_bin_init), (gst_decode_bin_dispose),
(gst_decode_bin_set_sink_caps), (gst_decode_bin_get_sink_caps),
(gst_decode_bin_set_property), (gst_decode_bin_get_property),
(analyze_new_pad), (connect_pad), (expose_pad),
(gst_decode_group_new), (gst_decode_group_control_demuxer_pad),
(gst_decode_group_expose), (gst_decode_group_free),
(do_async_start), (do_async_done), (gst_decode_bin_change_state):
Remove fakesink hack, we can now implement this more elegantly.
Added property to bypass typefinding.
Removed underrun callback and demuxer pad probe, we now use the srcpad
probe to expose groups.
API::sink-caps property
* gst/playback/gstplaybin2.c: (no_more_pads_cb):
Guard against multiple emissions of the no_more_pads signal, which
happens when we are dealing with chained oggs.
* gst/playback/gsturidecodebin.c: (remove_decoders),
(make_decoder), (type_found), (setup_streaming), (source_new_pad),
(setup_source):
For streams, use our own typefind element and plug our queue after it.
We will need this to determine the type of buffering to use for the
queue soon.

16 years agogst-libs/gst/audio/gstbaseaudiosink.c: Guard against over and underflows because...
Wim Taymans [Thu, 3 Apr 2008 10:37:03 +0000 (10:37 +0000)]
gst-libs/gst/audio/gstbaseaudiosink.c: Guard against over and underflows because of clock slaving.

Original commit message from CVS:
* gst-libs/gst/audio/gstbaseaudiosink.c:
(gst_base_audio_sink_skew_slaving), (gst_base_audio_sink_render):
Guard against over and underflows because of clock slaving.
When we are using our own clock, still compensate for any calibrations
that we might have done to our clock.

16 years agoext/theora/theoradec.c: Don't try to do anything fancy with the return code from...
Wim Taymans [Thu, 3 Apr 2008 10:22:33 +0000 (10:22 +0000)]
ext/theora/theoradec.c: Don't try to do anything fancy with the return code from pushing an event, it does not have e...

Original commit message from CVS:
* ext/theora/theoradec.c: (theora_handle_type_packet),
(theora_dec_chain):
Don't try to do anything fancy with the return code from pushing an
event, it does not have enough information to turn it into a
GST_FLOW_ERROR.

16 years agoext/ogg/gstoggdemux.c: Add small debug line.
Wim Taymans [Thu, 3 Apr 2008 10:19:43 +0000 (10:19 +0000)]
ext/ogg/gstoggdemux.c: Add small debug line.

Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_pad_reset),
(gst_ogg_demux_chain_elem_pad):
Add small debug line.
Pass return code from the internal decoder instead of the too generic
GST_FLOW_ERROR.

16 years agogst-libs/gst/cdda/: Use GLib's base64 implementation instead of our own.
Sebastian Dröge [Thu, 3 Apr 2008 06:39:27 +0000 (06:39 +0000)]
gst-libs/gst/cdda/: Use GLib's base64 implementation instead of our own.

Original commit message from CVS:
* gst-libs/gst/cdda/Makefile.am:
* gst-libs/gst/cdda/base64.c:
* gst-libs/gst/cdda/base64.h:
* gst-libs/gst/cdda/gstcddabasesrc.c:
(gst_cddabasesrc_calculate_musicbrainz_discid):
Use GLib's base64 implementation instead of our own.

16 years agoext/ogg/gstoggdemux.c: Refix oggdemux, we only have a problem if we failed to find...
Wim Taymans [Wed, 2 Apr 2008 15:41:50 +0000 (15:41 +0000)]
ext/ogg/gstoggdemux.c: Refix oggdemux, we only have a problem if we failed to find a chain and we are not EOF.

Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_activate_chain),
(gst_ogg_demux_read_chain):
Refix oggdemux, we only have a problem if we failed to find a chain and
we are not EOF.

16 years agoext/ogg/gstoggdemux.c: When we fail to find a BOS page and we and up with no chain...
Victor STINNER [Wed, 2 Apr 2008 15:07:01 +0000 (15:07 +0000)]
ext/ogg/gstoggdemux.c: When we fail to find a BOS page and we and up with no chain, error out properly instead of seg...

Original commit message from CVS:
Patch by: Victor STINNER <victor dot stinner at haypocalc dot com>
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_activate_chain),
(gst_ogg_demux_read_chain):
When we fail to find a BOS page and we and up with no chain, error out
properly instead of segfaulting. Fixes #525665.

16 years agoext/ogg/gstoggdemux.c: The new-pad-group sequence is add-pads, no-more-pads, add...
Wim Taymans [Wed, 2 Apr 2008 14:58:05 +0000 (14:58 +0000)]
ext/ogg/gstoggdemux.c: The new-pad-group sequence is add-pads, no-more-pads, add-pads, no-more-pads...

Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_activate_chain),
(gst_ogg_demux_read_chain), (gst_ogg_demux_handle_page):
The new-pad-group sequence is add-pads, no-more-pads, add-pads,
no-more-pads...

16 years agogst/playback/gstqueue2.c: Update the estimated input data when we push out a buffer.
Wim Taymans [Wed, 2 Apr 2008 11:08:05 +0000 (11:08 +0000)]
gst/playback/gstqueue2.c: Update the estimated input data when we push out a buffer.

Original commit message from CVS:
* gst/playback/gstqueue2.c: (update_out_rates),
(gst_queue_open_temp_location_file),
(gst_queue_close_temp_location_file), (gst_queue_handle_src_event),
(gst_queue_handle_src_query), (gst_queue_set_property):
Update the estimated input data when we push out a buffer.
Add some debug info about the temp file.
Only forward src events when we are not using a temp file.
Don't block the duration query, we need to find something better.
Don't leak the temp filename.

16 years agoconfigure.ac: Require GLib 2.12 and liboil 0.3.14.
Sebastian Dröge [Tue, 1 Apr 2008 14:01:14 +0000 (14:01 +0000)]
configure.ac: Require GLib 2.12 and liboil 0.3.14.

Original commit message from CVS:
* configure.ac:
Require GLib 2.12 and liboil 0.3.14.
* gst/volume/gstvolume.c: (volume_process_double):
Unconditionally use liboil 0.3.14 function.

16 years agogst-libs/gst/riff/riff-media.c: ms-gsm can have arbitrarty sample rates. See #481354.
Wim Taymans [Mon, 31 Mar 2008 16:08:45 +0000 (16:08 +0000)]
gst-libs/gst/riff/riff-media.c: ms-gsm can have arbitrarty sample rates. See #481354.

Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: (gst_riff_create_audio_caps):
ms-gsm can have arbitrarty sample rates. See #481354.

16 years agogst-libs/gst/riff/riff-media.c: MP4S is generic MPEG-4, not a microsoft variant.
Wim Taymans [Fri, 28 Mar 2008 16:22:35 +0000 (16:22 +0000)]
gst-libs/gst/riff/riff-media.c: MP4S is generic MPEG-4, not a microsoft variant.

Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
MP4S is generic MPEG-4, not a microsoft variant.

16 years agogst/gdp/gstgdpdepay.c: Check the body CRC (if set) when depayloading.
Michael Smith [Thu, 27 Mar 2008 15:26:38 +0000 (15:26 +0000)]
gst/gdp/gstgdpdepay.c: Check the body CRC (if set) when depayloading.

Original commit message from CVS:
* gst/gdp/gstgdpdepay.c: (gst_gdp_depay_chain):
Check the body CRC (if set) when depayloading.
Fixes #522401.

16 years agoext/pango/gsttextoverlay.c: Fix Since: version for new property.
Tim-Philipp Müller [Mon, 24 Mar 2008 17:45:36 +0000 (17:45 +0000)]
ext/pango/gsttextoverlay.c: Fix Since: version for new property.

Original commit message from CVS:
* ext/pango/gsttextoverlay.c: (gst_text_overlay_class_init):
Fix Since: version for new property.

16 years agogst-libs/gst/rtsp/gstrtspconnection.c: Don't error when poll_wait returns EAGAIN.
Wim Taymans [Mon, 24 Mar 2008 16:40:08 +0000 (16:40 +0000)]
gst-libs/gst/rtsp/gstrtspconnection.c: Don't error when poll_wait returns EAGAIN.

Original commit message from CVS:
* gst-libs/gst/rtsp/gstrtspconnection.c:
(gst_rtsp_connection_connect), (gst_rtsp_connection_write),
(gst_rtsp_connection_read_internal), (gst_rtsp_connection_poll):
Don't error when poll_wait returns EAGAIN.

16 years agogst/playback/gstqueue2.c: The queue is never filled when there are no buffers in...
Wim Taymans [Mon, 24 Mar 2008 14:08:22 +0000 (14:08 +0000)]
gst/playback/gstqueue2.c: The queue is never filled when there are no buffers in the queue at all.

Original commit message from CVS:
* gst/playback/gstqueue2.c: (gst_queue_is_filled):
The queue is never filled when there are no buffers in the queue at all.
Fixes #523993.

16 years agogst/playback/gstplaybin2.c: Update some docs.
Wim Taymans [Mon, 24 Mar 2008 12:26:30 +0000 (12:26 +0000)]
gst/playback/gstplaybin2.c: Update some docs.

Original commit message from CVS:
* gst/playback/gstplaybin2.c: (gst_play_bin_class_init),
(init_group), (free_group), (gst_play_bin_init),
(gst_play_bin_finalize), (gst_play_bin_set_uri),
(gst_play_bin_set_suburi), (gst_play_bin_get_video_tags),
(gst_play_bin_get_audio_tags), (gst_play_bin_get_text_tags),
(gst_play_bin_set_current_video_stream),
(gst_play_bin_set_current_audio_stream),
(gst_play_bin_set_current_text_stream),
(gst_play_bin_set_encoding), (gst_play_bin_set_property),
(gst_play_bin_get_property), (pad_added_cb), (pad_removed_cb),
(no_more_pads_cb), (perform_eos), (autoplug_select_cb),
(activate_group), (deactivate_group), (setup_next_source),
(save_current_group), (gst_play_bin_change_state):
Update some docs.
Add new locks and conds to protect pipeline creation and group
switching.
Implement the sub-uri property.
Keep track of pending uridecodebin creation and configure the output
pipeline after all streams are configured.
Propagate subtitle encoding to the uridecodebins.
Implement getting the video/audio/visualisation elements.
Use input-selector for stream switching.
If we are asked to do visualisation, prefer to autoplug raw sinks
instead of sinks that accept encoded data.

16 years agogst/playback/gstplaysink.*: Add methods to get audio/video/vis elements.
Wim Taymans [Mon, 24 Mar 2008 12:15:26 +0000 (12:15 +0000)]
gst/playback/gstplaysink.*: Add methods to get audio/video/vis elements.

Original commit message from CVS:
* gst/playback/gstplaysink.c: (gst_play_sink_class_init),
(gst_play_sink_init), (gst_play_sink_dispose),
(gst_play_sink_set_video_sink), (gst_play_sink_get_video_sink),
(gst_play_sink_set_audio_sink), (gst_play_sink_get_audio_sink),
(gst_play_sink_vis_unblocked), (gst_play_sink_vis_blocked),
(gst_play_sink_set_vis_plugin), (gst_play_sink_get_vis_plugin),
(gst_play_sink_set_volume), (gst_play_sink_get_volume),
(gst_play_sink_set_mute), (gen_video_chain), (gen_text_chain),
(gen_audio_chain), (gen_vis_chain), (gst_play_sink_reconfigure),
(gst_play_sink_set_font_desc), (gst_play_sink_get_font_desc),
(gst_play_sink_send_event_to_sink), (gst_play_sink_change_state):
* gst/playback/gstplaysink.h:
Add methods to get audio/video/vis elements.
Add methods to set the font description for the overlay.
Remove properties, we're using this element with its methods only.
Add support for subtitles.
Rearrange the locking a bit to not use the object lock for protecting
the pipeline construction.
Try to use the volume and mute property on the sink when its available.
Implement the mute option with volume when the sink does not have a mute
property.
Only add volume element when the sink has no volume property.
Only do visualisations with raw audio pads.

16 years agoext/pango/gsttextoverlay.*: Add property to configure waiting for text on the textpad...
Wim Taymans [Mon, 24 Mar 2008 12:03:02 +0000 (12:03 +0000)]
ext/pango/gsttextoverlay.*: Add property to configure waiting for text on the textpad or not, with the default behavi...

Original commit message from CVS:
* ext/pango/gsttextoverlay.c: (gst_text_overlay_class_init),
(gst_text_overlay_init), (gst_text_overlay_set_property),
(gst_text_overlay_get_property), (gst_text_overlay_src_event),
(gst_text_overlay_text_event), (gst_text_overlay_video_event),
(gst_text_overlay_text_chain), (gst_text_overlay_video_chain),
(gst_text_overlay_change_state):
* ext/pango/gsttextoverlay.h:
Add property to configure waiting for text on the textpad or not, with
the default behaviour being the old one (always wait for text before
rendering the video). This default behaviour is usually not the best one
because the text stream can very sparse and could require queueing a lot
of video.
Fix the flushing and EOS handing so that we don't mix up their meaning.

16 years agogst/playback/gsturidecodebin.c: Add a readonly source property and notify.
Wim Taymans [Mon, 24 Mar 2008 11:54:02 +0000 (11:54 +0000)]
gst/playback/gsturidecodebin.c: Add a readonly source property and notify.

Original commit message from CVS:
* gst/playback/gsturidecodebin.c:
(gst_uri_decode_bin_autoplug_factories),
(gst_uri_decode_bin_class_init), (gst_uri_decode_bin_init),
(gst_uri_decode_bin_finalize), (gst_uri_decode_bin_set_encoding),
(gst_uri_decode_bin_set_property),
(gst_uri_decode_bin_get_property), (no_more_pads_full),
(new_decoded_pad_cb), (gen_source_element), (remove_decoders),
(proxy_autoplug_factories_signal), (make_decoder),
(source_new_pad), (setup_source):
Add a readonly source property and notify.
Add new lock for protecting the construction of the pipeline.
Keep track of the decodebins we plugged.
Correctly proxy the autoplug signal so that it actually continues.
Proxy subtitle-encoding to the decodebins.

16 years agotests/examples/seek/seek.c: Rearrange some buttons in playbin2 and make some other...
Wim Taymans [Mon, 24 Mar 2008 11:46:15 +0000 (11:46 +0000)]
tests/examples/seek/seek.c: Rearrange some buttons in playbin2 and make some other boxes insensitive when needed.

Original commit message from CVS:
* tests/examples/seek/seek.c: (audio_toggle_cb), (video_toggle_cb),
(text_toggle_cb), (update_streams), (main):
Rearrange some buttons in playbin2 and make some other boxes insensitive
when needed.
Add language codes to subtitle selection boxes when we gind the right
tags for the streams.

16 years agogst/playback/gstdecodebin2.c: Protect caps property with the object lock.
Wim Taymans [Mon, 24 Mar 2008 11:36:08 +0000 (11:36 +0000)]
gst/playback/gstdecodebin2.c: Protect caps property with the object lock.

Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_bin_dispose),
(gst_decode_bin_set_caps), (gst_decode_bin_get_caps),
(gst_decode_bin_set_subs_encoding),
(gst_decode_bin_get_subs_encoding),
(gst_decode_bin_autoplug_factories), (connect_pad), (are_raw_caps),
(deactivate_free_recursive):
Protect caps property with the object lock.
Protect encoding property with the object lock.
Keep list of elements we added that have the subtitle-encoding property.
Distribute the subtitle-encoding to all of the elements when it
changes.

16 years agogst-libs/gst/audio/gstaudiosink.c: Small debug improvement.
Wim Taymans [Mon, 24 Mar 2008 11:24:22 +0000 (11:24 +0000)]
gst-libs/gst/audio/gstaudiosink.c: Small debug improvement.

Original commit message from CVS:
* gst-libs/gst/audio/gstaudiosink.c: (gst_audioringbuffer_release):
Small debug improvement.
* gst-libs/gst/audio/gstbaseaudiosink.c:
(gst_base_audio_sink_render):
Fix bug in determining the sample start/stop position, we want to base
this decision on the fact that we are going forwards or backwards, not
slower or faster. This fixes some ugly resync warnings when playing at
very slow speeds.

16 years agoext/gio/gstgio.c: Correctly set the supported URI schemes and don't leave some scheme...
Sebastian Dröge [Sun, 23 Mar 2008 13:41:28 +0000 (13:41 +0000)]
ext/gio/gstgio.c: Correctly set the supported URI schemes and don't leave some schemes in the middle or at the start ...

Original commit message from CVS:
* ext/gio/gstgio.c: (gst_gio_get_supported_protocols):
Correctly set the supported URI schemes and don't leave
some schemes in the middle or at the start at NULL.

16 years agotests/check/elements/gdpdepay.c: Make test compile without unused function/variable...
Tim-Philipp Müller [Sun, 23 Mar 2008 13:12:41 +0000 (13:12 +0000)]
tests/check/elements/gdpdepay.c: Make test compile without unused function/variable warnings on PPC.

Original commit message from CVS:
* tests/check/elements/gdpdepay.c:
Make test compile without unused function/variable warnings on PPC.

16 years agoUse G_PARAM_STATIC_STRINGS everywhere for GParamSpecs that use static strings (i...
Sebastian Dröge [Sat, 22 Mar 2008 15:00:53 +0000 (15:00 +0000)]
Use G_PARAM_STATIC_STRINGS everywhere for GParamSpecs that use static strings (i.e. all). This gives us less memory u...

Original commit message from CVS:
* configure.ac:
* ext/alsa/gstalsamixerelement.c:
(gst_alsa_mixer_element_class_init):
* ext/alsa/gstalsasink.c: (gst_alsasink_class_init):
* ext/alsa/gstalsasrc.c: (gst_alsasrc_class_init):
* ext/cdparanoia/gstcdparanoiasrc.c:
(gst_cd_paranoia_src_class_init):
* ext/gio/gstgiosink.c: (gst_gio_sink_class_init):
* ext/gio/gstgiosrc.c: (gst_gio_src_class_init):
* ext/gio/gstgiostreamsink.c: (gst_gio_stream_sink_class_init):
* ext/gio/gstgiostreamsrc.c: (gst_gio_stream_src_class_init):
* ext/gnomevfs/gstgnomevfssink.c: (gst_gnome_vfs_sink_class_init):
* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnome_vfs_src_class_init):
* ext/ogg/gstoggmux.c: (gst_ogg_mux_class_init):
* ext/pango/gsttextoverlay.c: (gst_text_overlay_class_init):
* ext/pango/gsttextrender.c: (gst_text_render_class_init):
* ext/theora/theoradec.c: (gst_theora_dec_class_init):
* ext/theora/theoraenc.c: (gst_theora_enc_class_init):
* ext/theora/theoraparse.c: (gst_theora_parse_class_init):
* ext/vorbis/vorbisenc.c: (gst_vorbis_enc_class_init):
* gst-libs/gst/audio/gstaudiofiltertemplate.c:
(gst_audio_filter_template_class_init):
* gst-libs/gst/audio/gstbaseaudiosink.c:
(gst_base_audio_sink_class_init):
* gst-libs/gst/audio/gstbaseaudiosrc.c:
(gst_base_audio_src_class_init):
* gst-libs/gst/cdda/gstcddabasesrc.c:
(gst_cdda_base_src_class_init):
* gst-libs/gst/interfaces/mixertrack.c:
(gst_mixer_track_class_init):
* gst-libs/gst/rtp/gstbasertpdepayload.c:
(gst_base_rtp_depayload_class_init):
* gst-libs/gst/rtp/gstbasertppayload.c:
(gst_basertppayload_class_init):
* gst/audioconvert/gstaudioconvert.c:
(gst_audio_convert_class_init):
* gst/audiorate/gstaudiorate.c: (gst_audio_rate_class_init):
* gst/audioresample/gstaudioresample.c:
(gst_audioresample_class_init):
* gst/audiotestsrc/gstaudiotestsrc.c:
(gst_audio_test_src_class_init):
* gst/gdp/gstgdppay.c: (gst_gdp_pay_class_init):
* gst/playback/gstdecodebin2.c: (gst_decode_bin_class_init):
* gst/playback/gstplaybasebin.c: (gst_play_base_bin_class_init),
(preroll_unlinked):
* gst/playback/gstplaybin.c: (gst_play_bin_class_init):
* gst/playback/gstplaybin2.c: (gst_play_bin_class_init):
* gst/playback/gstplaysink.c: (gst_play_sink_class_init):
* gst/playback/gstqueue2.c: (gst_queue_class_init):
* gst/playback/gststreaminfo.c: (gst_stream_info_class_init):
* gst/playback/gststreamselector.c: (gst_selector_pad_class_init),
(gst_stream_selector_class_init):
* gst/playback/gsturidecodebin.c: (gst_uri_decode_bin_class_init):
* gst/subparse/gstsubparse.c: (gst_sub_parse_class_init):
* gst/tcp/gstmultifdsink.c: (gst_multi_fd_sink_class_init):
* gst/tcp/gsttcpclientsink.c: (gst_tcp_client_sink_class_init):
* gst/tcp/gsttcpclientsrc.c: (gst_tcp_client_src_class_init):
* gst/tcp/gsttcpserversink.c: (gst_tcp_server_sink_class_init):
* gst/tcp/gsttcpserversrc.c: (gst_tcp_server_src_class_init):
* gst/videorate/gstvideorate.c: (gst_video_rate_class_init):
* gst/videoscale/gstvideoscale.c: (gst_video_scale_class_init):
* gst/videotestsrc/gstvideotestsrc.c:
(gst_video_test_src_class_init):
* gst/volume/gstvolume.c: (gst_volume_class_init):
* sys/v4l/gstv4lelement.c: (gst_v4lelement_class_init):
* sys/v4l/gstv4lmjpegsink.c: (gst_v4lmjpegsink_class_init):
* sys/v4l/gstv4lmjpegsrc.c: (gst_v4lmjpegsrc_class_init):
* sys/v4l/gstv4lsrc.c: (gst_v4lsrc_class_init):
* sys/ximage/ximagesink.c: (gst_ximagesink_class_init):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_class_init):
Use G_PARAM_STATIC_STRINGS everywhere for GParamSpecs that use
static strings (i.e. all). This gives us less memory usage,
fewer allocations and thus less memory defragmentation. Depend
on core CVS for this. Fixes bug #523806.

16 years agoext/gio/gstgio.c: Filter http and https protocols. GIO/GVfs handles them but it's...
Sebastian Dröge [Sat, 22 Mar 2008 14:13:55 +0000 (14:13 +0000)]
ext/gio/gstgio.c: Filter http and https protocols. GIO/GVfs handles them but it's impossible to implement iradio/icec...

Original commit message from CVS:
* ext/gio/gstgio.c: (gst_gio_get_supported_protocols):
Filter http and https protocols. GIO/GVfs handles them but it's
impossible to implement iradio/icecast with it. Better use
souphttpsrc or something else for this.
* ext/gio/gstgiobasesrc.c: (gst_gio_base_src_get_size):
If getting the file informations by a query fails try it with the
seek-to-end trick too.

16 years agogst/volume/gstvolume.c: memset buffers to zero if we get a GAP buffer. We usually...
Sebastian Dröge [Fri, 21 Mar 2008 16:46:33 +0000 (16:46 +0000)]
gst/volume/gstvolume.c: memset buffers to zero if we get a GAP buffer. We usually see a buffer as one unit so let's h...

Original commit message from CVS:
* gst/volume/gstvolume.c: (gst_volume_interface_supported),
(gst_volume_base_init), (gst_volume_class_init),
(volume_process_double), (volume_process_float),
(volume_transform_ip), (plugin_init):
memset buffers to zero if we get a GAP buffer. We usually see a
buffer as one unit so let's handle it as one and don't care about
volume changes while processing one buffer.
Also clean up some stuff a bit.

16 years agogst/audioconvert/gstaudioconvert.c: Make audioconvert GAP-aware by outputting silence...
Sebastian Dröge [Fri, 21 Mar 2008 15:58:44 +0000 (15:58 +0000)]
gst/audioconvert/gstaudioconvert.c: Make audioconvert GAP-aware by outputting silence buffers when the input has the ...

Original commit message from CVS:
* gst/audioconvert/gstaudioconvert.c: (gst_audio_convert_init),
(gst_audio_convert_create_silence_buffer),
(gst_audio_convert_transform):
Make audioconvert GAP-aware by outputting silence buffers when the
input has the GAP flag set. This is up to 8x faster.
Based on a patch by Stefan Kost. Fixes bug #517813.

16 years agogst/volume/gstvolume.c: Use oil_scalarmultiply_f64_ns() for double processing when...
Sebastian Dröge [Fri, 21 Mar 2008 15:54:54 +0000 (15:54 +0000)]
gst/volume/gstvolume.c: Use oil_scalarmultiply_f64_ns() for double processing when it's available at compile time.

Original commit message from CVS:
* gst/volume/gstvolume.c: (volume_process_double):
Use oil_scalarmultiply_f64_ns() for double processing when it's
available at compile time.

16 years agoconfigure.ac: Fix lrint/lrintf checks to actually work. These functions are in libm...
Sebastian Dröge [Fri, 21 Mar 2008 13:27:47 +0000 (13:27 +0000)]
configure.ac: Fix lrint/lrintf checks to actually work. These functions are in libm on Linux at least so try to link ...

Original commit message from CVS:
* configure.ac:
Fix lrint/lrintf checks to actually work. These functions are
in libm on Linux at least so try to link to it.

16 years agoconfigure.ac: Back to development - 0.10.18.1
Jan Schmidt [Fri, 21 Mar 2008 00:36:20 +0000 (00:36 +0000)]
configure.ac: Back to development - 0.10.18.1

Original commit message from CVS:
* configure.ac:
Back to development - 0.10.18.1

16 years agoRelease 0.10.18
Jan Schmidt [Fri, 21 Mar 2008 00:26:03 +0000 (00:26 +0000)]
Release 0.10.18

Original commit message from CVS:
Release 0.10.18

16 years agoUpdate .po files
Jan Schmidt [Fri, 21 Mar 2008 00:16:37 +0000 (00:16 +0000)]
Update .po files

Original commit message from CVS:
Update .po files

16 years ago0.10.17.4 pre-release
Jan Schmidt [Tue, 18 Mar 2008 12:19:43 +0000 (12:19 +0000)]
0.10.17.4 pre-release

Original commit message from CVS:
* configure.ac:
* win32/common/config.h:
0.10.17.4 pre-release

16 years agogst-libs/gst/sdp/gstsdpmessage.c: Use GST_STR_NULL when trying to print strings that...
Wim Taymans [Tue, 18 Mar 2008 11:20:05 +0000 (11:20 +0000)]
gst-libs/gst/sdp/gstsdpmessage.c: Use GST_STR_NULL when trying to print strings that could be NULL because this might...

Original commit message from CVS:
* gst-libs/gst/sdp/gstsdpmessage.c: (gst_sdp_message_dump):
Use GST_STR_NULL when trying to print strings that could be NULL because
this might crash on some platforms. See #520808.

16 years agogst-libs/gst/rtsp/gstrtspconnection.c: Generic Windows fixes that makes libgstrtsp...
Ole André Vadla Ravnås [Tue, 18 Mar 2008 11:10:12 +0000 (11:10 +0000)]
gst-libs/gst/rtsp/gstrtspconnection.c: Generic Windows fixes that makes libgstrtsp work on Windows when coupled with ...

Original commit message from CVS:
Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas@tandberg.com>
* gst-libs/gst/rtsp/gstrtspconnection.c:
(gst_rtsp_connection_connect), (gst_rtsp_connection_write),
(read_line), (gst_rtsp_connection_read_internal):
Generic Windows fixes that makes libgstrtsp work on Windows when
coupled with the new GstPoll API. See #520808.

16 years agoext/gio/gstgiobasesrc.c: If seeking to a new position succeeds don't simply return...
Milosz Derezynski [Mon, 17 Mar 2008 22:06:56 +0000 (22:06 +0000)]
ext/gio/gstgiobasesrc.c: If seeking to a new position succeeds don't simply return from create() without creating a b...

Original commit message from CVS:
Patch by: Milosz Derezynski <internalerror at gmail dot com>
* ext/gio/gstgiobasesrc.c: (gst_gio_base_src_create):
If seeking to a new position succeeds don't simply return from
create() without creating a buffer. Do this only in the case
seeking to the new position fails. Fixes bug #523054.

16 years agogst-libs/gst/video/video.c: Fix gst_video_format_parse_caps() for RGB caps with alpha...
Tim-Philipp Müller [Mon, 17 Mar 2008 10:32:28 +0000 (10:32 +0000)]
gst-libs/gst/video/video.c: Fix gst_video_format_parse_caps() for RGB caps with alpha channel (#522635).

Original commit message from CVS:
* gst-libs/gst/video/video.c: (gst_video_format_parse_caps),
(gst_video_format_from_rgba32_masks):
Fix gst_video_format_parse_caps() for RGB caps with alpha channel
(#522635).
* tests/check/libs/video.c: (test_parse_caps_rgb), (video_suite):
Add unit test for the RGB caps parsing and creation, checking for
internal consistency of the new API and consistency of the API with
the old GST_VIDEO_CAPS_* defines.

16 years agogst/videotestsrc/videotestsrc.c: Oops, revert last change because -base is in freeze.
David Schleef [Fri, 14 Mar 2008 18:42:35 +0000 (18:42 +0000)]
gst/videotestsrc/videotestsrc.c: Oops, revert last change because -base is in freeze.

Original commit message from CVS:
* gst/videotestsrc/videotestsrc.c:  Oops, revert last change
because -base is in freeze.

16 years agogst/videotestsrc/videotestsrc.c: Fix Bayer pattern generation.
William M. Brack [Fri, 14 Mar 2008 17:33:09 +0000 (17:33 +0000)]
gst/videotestsrc/videotestsrc.c: Fix Bayer pattern generation.

Original commit message from CVS:
Patch by: William M. Brack
* gst/videotestsrc/videotestsrc.c: Fix Bayer pattern generation.

16 years agogst/playback/gststreamselector.*: Revert change that caused regression until a real...
Wim Taymans [Fri, 14 Mar 2008 09:54:44 +0000 (09:54 +0000)]
gst/playback/gststreamselector.*: Revert change that caused regression until a real fix is found.

Original commit message from CVS:
* gst/playback/gststreamselector.c: (gst_selector_pad_event),
(gst_selector_pad_chain):
* gst/playback/gststreamselector.h:
Revert change that caused regression until a real fix is found.
Fixes #522203.

16 years agogst-libs/gst/audio/gstringbuffer.*: Rename recently added buffer types to make more...
Michael Smith [Wed, 12 Mar 2008 12:39:13 +0000 (12:39 +0000)]
gst-libs/gst/audio/gstringbuffer.*: Rename recently added buffer types to make more sense.

Original commit message from CVS:
* gst-libs/gst/audio/gstringbuffer.c: (gst_ring_buffer_parse_caps):
* gst-libs/gst/audio/gstringbuffer.h:
Rename recently added buffer types to make more sense.
* ext/alsa/gstalsasink.c: (alsasink_parse_spec),
(gst_alsasink_write):
Adapt for above API changes.
Fixes bug #520523.

16 years agowin32/common/libgstnetbuffer.def: Add new symbol gst_netaddress_equal. Fixes bug...
Sebastian Dröge [Tue, 11 Mar 2008 13:23:55 +0000 (13:23 +0000)]
win32/common/libgstnetbuffer.def: Add new symbol gst_netaddress_equal. Fixes bug #521743.

Original commit message from CVS:
* win32/common/libgstnetbuffer.def:
Add new symbol gst_netaddress_equal. Fixes bug #521743.

16 years ago0.10.17.3 pre-release
Jan Schmidt [Tue, 11 Mar 2008 00:25:13 +0000 (00:25 +0000)]
0.10.17.3 pre-release

Original commit message from CVS:
* configure.ac:
* win32/common/config.h:
0.10.17.3 pre-release

16 years agogst-libs/gst/audio/gstbaseaudiosrc.c: Fix duration when no clock was provided. Fixes...
Wim Taymans [Mon, 10 Mar 2008 17:19:56 +0000 (17:19 +0000)]
gst-libs/gst/audio/gstbaseaudiosrc.c: Fix duration when no clock was provided. Fixes #520300.

Original commit message from CVS:
* gst-libs/gst/audio/gstbaseaudiosrc.c:
(gst_base_audio_src_create):
Fix duration when no clock was provided. Fixes #520300.

16 years agoAdd trivial function to compare GstNetAddress. See #520626.
Olivier Crete [Fri, 7 Mar 2008 18:17:44 +0000 (18:17 +0000)]
Add trivial function to compare GstNetAddress. See #520626.

Original commit message from CVS:
Patch by: Olivier Crete  <tester at tester ca>
* docs/libs/gst-plugins-base-libs-sections.txt:
* gst-libs/gst/netbuffer/gstnetbuffer.c: (gst_netaddress_equal):
* gst-libs/gst/netbuffer/gstnetbuffer.h:
Add trivial function to compare GstNetAddress. See #520626.
API: GstNetBuffer::gst_netaddress_equal

16 years agogst/tcp/gstmultifdsink.c: Update mode property docs, it's deprecated now.
Wim Taymans [Fri, 7 Mar 2008 16:10:51 +0000 (16:10 +0000)]
gst/tcp/gstmultifdsink.c: Update mode property docs, it's deprecated now.

Original commit message from CVS:
* gst/tcp/gstmultifdsink.c: (gst_multi_fd_sink_class_init):
Update mode property docs, it's deprecated now.

16 years agogst/: Remove GstPollMode from gstpoll constructor.
Wim Taymans [Fri, 7 Mar 2008 15:48:51 +0000 (15:48 +0000)]
gst/: Remove GstPollMode from gstpoll constructor.

Original commit message from CVS:
* gst-libs/gst/rtsp/gstrtspconnection.c:
(gst_rtsp_connection_create):
* gst/tcp/gstmultifdsink.c: (gst_fdset_mode_get_type),
(gst_multi_fd_sink_class_init), (gst_multi_fd_sink_start):
* gst/tcp/gstmultifdsink.h:
* gst/tcp/gsttcpclientsrc.c: (gst_tcp_client_src_start):
* gst/tcp/gsttcpserversrc.c: (gst_tcp_server_src_start):
Remove GstPollMode from gstpoll constructor.

16 years ago0.10.17.2 pre-release
Jan Schmidt [Tue, 4 Mar 2008 00:26:46 +0000 (00:26 +0000)]
0.10.17.2 pre-release

Original commit message from CVS:
* configure.ac:
* win32/common/config.h:
0.10.17.2 pre-release

16 years agogst/Makefile.am: GST_PLUGINS_ALL correctly lists subparse and tcp now, don't distclea...
Jan Schmidt [Mon, 3 Mar 2008 23:59:45 +0000 (23:59 +0000)]
gst/Makefile.am: GST_PLUGINS_ALL correctly lists subparse and tcp now, don't distclean them twice

Original commit message from CVS:
* gst/Makefile.am:
GST_PLUGINS_ALL correctly lists subparse and tcp now, don't distclean
them twice
* win32/common/libgstinterfaces.def:
* win32/common/libgstrtp.def:
Add new API to the defs

16 years agogst-libs/gst/rtp/gstbasertpaudiopayload.*: API: add gst_base_rtp_audio_payload_set_sa...
Mersad Jelacic [Mon, 3 Mar 2008 16:11:50 +0000 (16:11 +0000)]
gst-libs/gst/rtp/gstbasertpaudiopayload.*: API: add gst_base_rtp_audio_payload_set_samplebits_options() to make it po...

Original commit message from CVS:
Patch by: Mersad Jelacic  <mersad at axis dot com>
* gst-libs/gst/rtp/gstbasertpaudiopayload.c:
* gst-libs/gst/rtp/gstbasertpaudiopayload.h:
API: add gst_base_rtp_audio_payload_set_samplebits_options() to make it
possible to specify the sample size in bits. (#509637)

16 years agotests/check/libs/mixer.c: Add a few simple checks for the new message types.
Tim-Philipp Müller [Mon, 3 Mar 2008 13:59:19 +0000 (13:59 +0000)]
tests/check/libs/mixer.c: Add a few simple checks for the new message types.

Original commit message from CVS:
* tests/check/libs/mixer.c:
Add a few simple checks for the new message types.

16 years agoAPI: add gst_mixer_options_list_changed(), gst_mixer_mixer_changed() and gst_mixer_me...
Tim-Philipp Müller [Mon, 3 Mar 2008 13:56:38 +0000 (13:56 +0000)]
API: add gst_mixer_options_list_changed(), gst_mixer_mixer_changed() and gst_mixer_message_parse_options_list_changed...

Original commit message from CVS:
* docs/libs/gst-plugins-base-libs-sections.txt:
* gst-libs/gst/interfaces/mixer.c: (gst_mixer_option_changed),
(gst_mixer_options_list_changed), (gst_mixer_mixer_changed),
(gst_mixer_message_get_type),
(gst_mixer_message_parse_option_changed),
(gst_mixer_message_parse_options_list_changed):
* gst-libs/gst/interfaces/mixer.h: (GstMixerType),
(GST_MIXER_MESSAGE_OPTION_CHANGED),
(GST_MIXER_MESSAGE_OPTIONS_LIST_CHANGED),
(GST_MIXER_MESSAGE_MIXER_CHANGED):
API: add gst_mixer_options_list_changed(), gst_mixer_mixer_changed()
and gst_mixer_message_parse_options_list_changed(). Fixes #519916.

16 years agogst-libs/gst/interfaces/mixeroptions.*: API: add GstMixerOptions::get_values vfunc...
Tim-Philipp Müller [Mon, 3 Mar 2008 13:50:18 +0000 (13:50 +0000)]
gst-libs/gst/interfaces/mixeroptions.*: API: add GstMixerOptions::get_values vfunc (#519906)

Original commit message from CVS:
* gst-libs/gst/interfaces/mixeroptions.c: (gst_mixer_options_init),
(gst_mixer_options_get_values):
* gst-libs/gst/interfaces/mixeroptions.h:
(GST_MIXER_OPTIONS_GET_CLASS), (GstMixerOptionsClass),
(_GstMixerOptions), (_GstMixerOptionsClass):
API: add GstMixerOptions::get_values vfunc (#519906)

16 years agoconfigure.ac: Use AG_GST_CHECK_PLUGIN and AG_GST_DISABLE_PLUGIN to simplify which...
Peter Kjellerstedt [Mon, 3 Mar 2008 12:01:15 +0000 (12:01 +0000)]
configure.ac: Use AG_GST_CHECK_PLUGIN and AG_GST_DISABLE_PLUGIN to simplify which plug-ins are included/excluded. (#4...

Original commit message from CVS:
* configure.ac:
Use AG_GST_CHECK_PLUGIN and AG_GST_DISABLE_PLUGIN to simplify which
plug-ins are included/excluded. (#498222)

16 years agogst/typefind/gsttypefindfunctions.c: Add typefinder for IMelody files, using audio...
Sebastian Dröge [Mon, 3 Mar 2008 06:22:39 +0000 (06:22 +0000)]
gst/typefind/gsttypefindfunctions.c: Add typefinder for IMelody files, using audio/x-imelody.

Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (plugin_init):
Add typefinder for IMelody files, using audio/x-imelody.
See bug #519516.

16 years agoCorrect all relevant warnings found by the sparse semantic code analyzer. This includ...
Sebastian Dröge [Mon, 3 Mar 2008 06:04:31 +0000 (06:04 +0000)]
Correct all relevant warnings found by the sparse semantic code analyzer. This include marking several symbols static...

Original commit message from CVS:
* ext/alsa/gstalsamixertrack.c: (gst_alsa_mixer_track_get_type):
* ext/alsa/gstalsasink.c: (set_hwparams):
* ext/alsa/gstalsasrc.c: (set_hwparams):
* ext/gio/gstgio.c: (gst_gio_uri_handler_get_uri):
* ext/ogg/gstoggmux.h:
* ext/ogg/gstogmparse.c:
* gst-libs/gst/audio/audio.c:
* gst-libs/gst/fft/kiss_fft_f64.c: (kiss_fft_f64_alloc):
* gst-libs/gst/pbutils/missing-plugins.c:
(gst_missing_uri_sink_message_new),
(gst_missing_element_message_new),
(gst_missing_decoder_message_new),
(gst_missing_encoder_message_new):
* gst-libs/gst/rtp/gstbasertppayload.c:
* gst-libs/gst/rtp/gstrtcpbuffer.c:
(gst_rtcp_packet_bye_get_reason):
* gst/audioconvert/gstaudioconvert.c:
* gst/audioresample/gstaudioresample.c:
* gst/ffmpegcolorspace/imgconvert.c:
* gst/playback/test.c: (gen_video_element), (gen_audio_element):
* gst/typefind/gsttypefindfunctions.c:
* gst/videoscale/vs_4tap.c:
* gst/videoscale/vs_4tap.h:
* sys/v4l/gstv4lelement.c:
* sys/v4l/gstv4lsrc.c: (gst_v4lsrc_get_any_caps):
* sys/v4l/v4l_calls.c:
* sys/v4l/v4lsrc_calls.c: (gst_v4lsrc_capture_init),
(gst_v4lsrc_try_capture):
* sys/ximage/ximagesink.c: (gst_ximagesink_check_xshm_calls),
(gst_ximagesink_ximage_new):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_check_xshm_calls),
(gst_xvimagesink_xvimage_new):
* tests/check/elements/audioconvert.c:
* tests/check/elements/audioresample.c:
(fail_unless_perfect_stream):
* tests/check/elements/audiotestsrc.c: (setup_audiotestsrc):
* tests/check/elements/decodebin.c:
* tests/check/elements/gdpdepay.c: (setup_gdpdepay),
(setup_gdpdepay_streamheader):
* tests/check/elements/gdppay.c: (setup_gdppay), (GST_START_TEST),
(setup_gdppay_streamheader):
* tests/check/elements/gnomevfssink.c: (setup_gnomevfssink):
* tests/check/elements/multifdsink.c: (setup_multifdsink):
* tests/check/elements/textoverlay.c:
* tests/check/elements/videorate.c: (setup_videorate):
* tests/check/elements/videotestsrc.c: (setup_videotestsrc):
* tests/check/elements/volume.c: (setup_volume):
* tests/check/elements/vorbisdec.c: (setup_vorbisdec):
* tests/check/elements/vorbistag.c:
* tests/check/generic/clock-selection.c:
* tests/check/generic/states.c: (setup), (teardown):
* tests/check/libs/cddabasesrc.c:
* tests/check/libs/video.c:
* tests/check/pipelines/gio.c:
* tests/check/pipelines/oggmux.c:
* tests/check/pipelines/simple-launch-lines.c:
(simple_launch_lines_suite):
* tests/check/pipelines/streamheader.c:
* tests/check/pipelines/theoraenc.c:
* tests/check/pipelines/vorbisdec.c:
* tests/check/pipelines/vorbisenc.c:
* tests/examples/seek/scrubby.c:
* tests/examples/seek/seek.c: (query_positions_elems),
(query_positions_pads):
* tests/icles/stress-xoverlay.c: (myclock):
Correct all relevant warnings found by the sparse semantic code
analyzer. This include marking several symbols static, using
NULL instead of 0 for pointers and using "foo (void)" instead
of "foo ()" for declarations.
* win32/common/libgstrtp.def:
Add gst_rtp_buffer_set_extension_data to the symbol definition file.

16 years agogst/playback/gstplaybin2.c: Make the function signature of the _get_*_tags() function...
José Alburquerque [Sun, 2 Mar 2008 18:43:15 +0000 (18:43 +0000)]
gst/playback/gstplaybin2.c: Make the function signature of the _get_*_tags() functions match the signature of the vfu...

Original commit message from CVS:
Patch by: José Alburquerque <jaalburqu svn gnome org>
* gst/playback/gstplaybin2.c:
Make the function signature of the _get_*_tags() functions match
the signature of the vfuncs they implement, ie. return a
GstTagList rather than a GstStructure, which is more correct,
even if one is typedef'ed to the other (#518940).

16 years agogst-libs/gst/rtsp/gstrtspconnection.c: Don't include unix headers unconditionally...
Tim-Philipp Müller [Sun, 2 Mar 2008 18:32:36 +0000 (18:32 +0000)]
gst-libs/gst/rtsp/gstrtspconnection.c: Don't include unix headers unconditionally (fixes #518037).

Original commit message from CVS:
* gst-libs/gst/rtsp/gstrtspconnection.c:
Don't include unix headers unconditionally (fixes #518037).

16 years agotests/check/libs/video.c: Add unit test that makes sure that the strides, offsets...
Tim-Philipp Müller [Sun, 2 Mar 2008 18:24:37 +0000 (18:24 +0000)]
tests/check/libs/video.c: Add unit test that makes sure that the strides, offsets and sizes returned for the various ...

Original commit message from CVS:
* tests/check/libs/video.c: (paintinfo), (paintinfo_struct),
(fourcc_list_struct), (fourcc_list), (fourcc_get_size),
(paint_setup_I420), (paint_setup_YV12), (paint_setup_AYUV),
(paint_setup_YUY2), (paint_setup_UYVY), (paint_setup_YVYU),
(paint_setup_IYU2), (paint_setup_Y41B), (paint_setup_Y42B),
(paint_setup_Y800), (paint_setup_YVU9), (paint_setup_YUV9),
(gst_video_format_is_packed), (video_format_is_packed):
Add unit test that makes sure that the strides, offsets and
sizes returned for the various YUV formats by the new video API
match the old reference implementation in videotestsrc.

16 years agogst-libs/gst/video/video.*: API: add GST_VIDEO_FORMAT_Y41B and GST_VIDEO_FORMAT_Y42B.
Tim-Philipp Müller [Sun, 2 Mar 2008 18:20:44 +0000 (18:20 +0000)]
gst-libs/gst/video/video.*: API: add GST_VIDEO_FORMAT_Y41B and GST_VIDEO_FORMAT_Y42B.

Original commit message from CVS:
* gst-libs/gst/video/video.c: (gst_video_calculate_display_ratio),
(gst_video_format_from_fourcc), (gst_video_format_to_fourcc),
(gst_video_format_is_rgb), (gst_video_format_is_yuv),
(gst_video_format_has_alpha), (gst_video_format_get_row_stride),
(gst_video_format_get_pixel_stride),
(gst_video_format_get_component_width),
(gst_video_format_get_component_height),
(gst_video_format_get_component_offset), (gst_video_format_get_size):
* gst-libs/gst/video/video.h: (GST_VIDEO_FORMAT_Y41B),
(GST_VIDEO_FORMAT_Y42B):
API: add GST_VIDEO_FORMAT_Y41B and GST_VIDEO_FORMAT_Y42B.

16 years agogst-libs/gst/video/video.c: YV12 is I420 with swapped components 1 and 2, so the...
Tim-Philipp Müller [Sun, 2 Mar 2008 18:07:10 +0000 (18:07 +0000)]
gst-libs/gst/video/video.c: YV12 is I420 with swapped components 1 and 2, so the offset of component 1 for I420 shoul...

Original commit message from CVS:
* gst-libs/gst/video/video.c: (gst_video_format_get_component_offset):
YV12 is I420 with swapped components 1 and 2, so the offset of
component 1 for I420 should be the offset for component 2 for YV12
and vice versa.

16 years agosys/v4l/gstv4lelement.c: Add missing semicolon to fix indentation.
Rene Stadler [Fri, 29 Feb 2008 21:48:00 +0000 (21:48 +0000)]
sys/v4l/gstv4lelement.c: Add missing semicolon to fix indentation.

Original commit message from CVS:
* sys/v4l/gstv4lelement.c:
Add missing semicolon to fix indentation.

16 years agoext/alsa/gstalsa.c: Probe for IEC958 pcm to detect if we can do SPDIF output.
Julien Moutte [Fri, 29 Feb 2008 18:44:36 +0000 (18:44 +0000)]
ext/alsa/gstalsa.c: Probe for IEC958 pcm to detect if we can do SPDIF output.

Original commit message from CVS:
2008-02-29  Julien Moutte  <julien@fluendo.com>

* ext/alsa/gstalsa.c: (gst_alsa_open_iec958_pcm),
(gst_alsa_probe_supported_formats): Probe for IEC958 pcm to
detect
if we can do SPDIF output.
* ext/alsa/gstalsa.h:
* ext/alsa/gstalsasink.c: (set_hwparams), (alsasink_parse_spec),
(gst_alsasink_prepare), (gst_alsasink_close),
(gst_alsasink_write):
* ext/alsa/gstalsasink.h: Initial support for SPDIF.
* gst-libs/gst/audio/gstringbuffer.c:
(gst_ring_buffer_parse_caps):
* gst-libs/gst/audio/gstringbuffer.h: Add non linear buffer
types
to support AC3, EC3 and IEC958 buffers.

16 years agogst-libs/gst/interfaces/mixer.c: De-cruft and fix message type assertions (NULL is...
Tim-Philipp Müller [Fri, 29 Feb 2008 17:59:16 +0000 (17:59 +0000)]
gst-libs/gst/interfaces/mixer.c: De-cruft and fix message type assertions (NULL is not a really valid mixer message t...

Original commit message from CVS:
* gst-libs/gst/interfaces/mixer.c: (GST_MIXER_MESSAGE_HAS_TYPE),
(gst_mixer_message_parse_mute_toggled),
(gst_mixer_message_parse_record_toggled),
(gst_mixer_message_parse_volume_changed),
(gst_mixer_message_parse_option_changed):
De-cruft and fix message type assertions (NULL is not a really
valid mixer message type string).

16 years agoext/libvisual/visual.c: When negotiating, actually start from a format that we can...
Wim Taymans [Fri, 29 Feb 2008 14:52:02 +0000 (14:52 +0000)]
ext/libvisual/visual.c: When negotiating, actually start from a format that we can support instead of from the too ge...

Original commit message from CVS:
* ext/libvisual/visual.c: (gst_vis_src_negotiate):
When negotiating, actually start from a format that we can support
instead of from the too generic template.

16 years agogst/playback/gstplaybin2.c: Enable vis setting.
Wim Taymans [Fri, 29 Feb 2008 12:26:48 +0000 (12:26 +0000)]
gst/playback/gstplaybin2.c: Enable vis setting.

Original commit message from CVS:
* gst/playback/gstplaybin2.c: (gst_play_bin_set_property):
Enable vis setting.
* gst/playback/gstplaysink.c: (gst_play_sink_init),
(gst_play_sink_dispose), (gst_play_sink_vis_unblocked),
(gst_play_sink_vis_blocked), (gst_play_sink_set_vis_plugin),
(gen_vis_chain):
Implement vis switching while playing.

16 years agogst-libs/gst/riff/riff-media.c: Add Dirac mapping
David Schleef [Fri, 29 Feb 2008 00:04:57 +0000 (00:04 +0000)]
gst-libs/gst/riff/riff-media.c: Add Dirac mapping

Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: Add Dirac mapping

16 years agogst/tcp/: Removed fdset and stress test, they are now known as GstPoll in core.
Peter Kjellerstedt [Thu, 28 Feb 2008 10:54:14 +0000 (10:54 +0000)]
gst/tcp/: Removed fdset and stress test, they are now known as GstPoll in core.

Original commit message from CVS:
Patch by: Peter Kjellerstedt  <pkj at axis com>
* gst/tcp/Makefile.am:
* gst/tcp/fdsetstress.c:
* gst/tcp/gstfdset.c:
* gst/tcp/gstfdset.h:
Removed fdset and stress test, they are now known as GstPoll in
core.
* gst/tcp/gstmultifdsink.c: (gst_multi_fd_sink_class_init),
(gst_multi_fd_sink_add_full), (gst_multi_fd_sink_remove),
(gst_multi_fd_sink_clear), (gst_multi_fd_sink_remove_client_link),
(gst_multi_fd_sink_handle_client_write),
(gst_multi_fd_sink_queue_buffer),
(gst_multi_fd_sink_handle_clients), (gst_multi_fd_sink_start),
(gst_multi_fd_sink_stop):
* gst/tcp/gstmultifdsink.h:
* gst/tcp/gsttcp.c: (gst_tcp_socket_read), (gst_tcp_socket_close),
(gst_tcp_read_buffer), (gst_tcp_gdp_read_buffer),
(gst_tcp_gdp_read_caps):
* gst/tcp/gsttcp.h:
* gst/tcp/gsttcpclientsink.c: (gst_tcp_client_sink_init),
(gst_tcp_client_sink_setcaps), (gst_tcp_client_sink_render),
(gst_tcp_client_sink_start), (gst_tcp_client_sink_stop):
* gst/tcp/gsttcpclientsink.h:
* gst/tcp/gsttcpclientsrc.c: (gst_tcp_client_src_init),
(gst_tcp_client_src_create), (gst_tcp_client_src_start),
(gst_tcp_client_src_stop), (gst_tcp_client_src_unlock):
* gst/tcp/gsttcpclientsrc.h:
* gst/tcp/gsttcpserversink.c: (gst_tcp_server_sink_handle_wait),
(gst_tcp_server_sink_init_send), (gst_tcp_server_sink_close):
* gst/tcp/gsttcpserversink.h:
* gst/tcp/gsttcpserversrc.c: (gst_tcp_server_src_init),
(gst_tcp_server_src_create), (gst_tcp_server_src_start),
(gst_tcp_server_src_stop), (gst_tcp_server_src_unlock):
* gst/tcp/gsttcpserversrc.h:
Port to GstPoll. See #505417.

16 years agoPatch Changelog a bit to give credit and refer to the relevant bug.
Wim Taymans [Thu, 28 Feb 2008 09:54:14 +0000 (09:54 +0000)]
Patch Changelog a bit to give credit and refer to the relevant bug.

Original commit message from CVS:
Patch Changelog a bit to give credit and refer to the
relevant bug.

16 years agogst-libs/gst/rtsp/gstrtspconnection.*: Use GstPoll for the rtsp connection.
Wim Taymans [Thu, 28 Feb 2008 09:50:52 +0000 (09:50 +0000)]
gst-libs/gst/rtsp/gstrtspconnection.*: Use GstPoll for the rtsp connection.

Original commit message from CVS:
* gst-libs/gst/rtsp/gstrtspconnection.c:
(gst_rtsp_connection_create), (gst_rtsp_connection_connect),
(gst_rtsp_connection_write), (gst_rtsp_connection_read_internal),
(gst_rtsp_connection_receive), (gst_rtsp_connection_close),
(gst_rtsp_connection_free), (gst_rtsp_connection_poll),
(gst_rtsp_connection_flush):
* gst-libs/gst/rtsp/gstrtspconnection.h:
Use GstPoll for the rtsp connection.

16 years agotests/examples/seek/seek.c: Add combo box for visualisations, populate it with a...
Wim Taymans [Wed, 27 Feb 2008 12:19:31 +0000 (12:19 +0000)]
tests/examples/seek/seek.c: Add combo box for visualisations, populate it with a factory list of all visualisation pl...

Original commit message from CVS:
* tests/examples/seek/seek.c: (vis_toggle_cb), (filter_features),
(init_visualization_features), (vis_combo_cb), (shot_cb), (main):
Add combo box for visualisations, populate it with a factory list
of all visualisation plugins, configure vis plugin instance in
playbin2.

16 years agotests/check/libs/rtp.c: Add check for RTP buffer defaults, padding and marker bit...
Wim Taymans [Wed, 27 Feb 2008 10:55:03 +0000 (10:55 +0000)]
tests/check/libs/rtp.c: Add check for RTP buffer defaults, padding and marker bit API.

Original commit message from CVS:
* tests/check/libs/rtp.c: (GST_START_TEST):
Add check for RTP buffer defaults, padding and marker bit API.

16 years agogst-libs/gst/cdda/sha1.c: Use memcpy() instead of upcasting a byte array to long...
Sebastian Dröge [Wed, 27 Feb 2008 10:42:08 +0000 (10:42 +0000)]
gst-libs/gst/cdda/sha1.c: Use memcpy() instead of upcasting a byte array to long *. This fixes an unaligned memory ac...

Original commit message from CVS:
* gst-libs/gst/cdda/sha1.c: (sha_transform):
Use memcpy() instead of upcasting a byte array to long *. This
fixes an unaligned memory access, resulting in SIGBUS on IA64.
This should be ported to GCheckSum once we can use GLib 2.16.
Partially fixes bug #500833.

16 years agogst-libs/gst/tag/gsttagdemux.c: Push tag event after the newsegment event. Log the...
Tim-Philipp Müller [Wed, 27 Feb 2008 10:23:27 +0000 (10:23 +0000)]
gst-libs/gst/tag/gsttagdemux.c: Push tag event after the newsegment event. Log the pointer of the buffer we're actual...

Original commit message from CVS:
* gst-libs/gst/tag/gsttagdemux.c: (gst_tag_demux_chain):
Push tag event after the newsegment event. Log the pointer of
the buffer we're actually going to push rather than the buffer
we're feeding to _make_metadata_writable().

16 years agogst/typefind/gsttypefindfunctions.c: Comment smoke typefinder for now. The smokedec...
Sebastian Dröge [Mon, 25 Feb 2008 07:21:33 +0000 (07:21 +0000)]
gst/typefind/gsttypefindfunctions.c: Comment smoke typefinder for now. The smokedec plugin needs one frame per buffer...

Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (plugin_init):
Comment smoke typefinder for now. The smokedec plugin needs one
frame per buffer but we have no parser yet, thus it simply crashes
in most situations.

16 years agogst/typefind/gsttypefindfunctions.c: Add typefinder for the smoke video codec. Copied...
Sebastian Dröge [Mon, 25 Feb 2008 06:48:14 +0000 (06:48 +0000)]
gst/typefind/gsttypefindfunctions.c: Add typefinder for the smoke video codec. Copied from the jpeg plugin.

Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (plugin_init):
Add typefinder for the smoke video codec. Copied from the jpeg plugin.

16 years agogst/typefind/gsttypefindfunctions.c: Add midi typefinder, copied from the timidity...
Sebastian Dröge [Mon, 25 Feb 2008 06:29:09 +0000 (06:29 +0000)]
gst/typefind/gsttypefindfunctions.c: Add midi typefinder, copied from the timidity plugin.

Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (mid_type_find),
(plugin_init):
Add midi typefinder, copied from the timidity plugin.

16 years agoForward slashes at the beginning and end of a line also signify italics (Fixes: ...
Tomasz Sałaciński [Sat, 23 Feb 2008 09:51:26 +0000 (09:51 +0000)]
Forward slashes at the beginning and end of a line also signify italics (Fixes: #518162).

Original commit message from CVS:
Based on patch by: Tomasz Sałaciński <tsalacinski gmail com>
* gst/subparse/gstsubparse.c: (parse_mdvdsub):
* tests/check/elements/subparse.c: (test_microdvd_with_italics),
(subparse_suite):
Forward slashes at the beginning and end of a line also signify
italics (Fixes: #518162).

16 years agotests/check/gst-plugins-base.supp: Add a suppression for a cached value in GIO that...
Sebastian Dröge [Fri, 22 Feb 2008 06:38:08 +0000 (06:38 +0000)]
tests/check/gst-plugins-base.supp: Add a suppression for a cached value in GIO that wasn't moved while moving gio fro...

Original commit message from CVS:
* tests/check/gst-plugins-base.supp:
Add a suppression for a cached value in GIO that wasn't moved
while moving gio from -bad to -base.

16 years agoconfigure.ac: Don't hardcode -Wall and -Werror for configure checks, this fails with...
Brian Cameron [Fri, 22 Feb 2008 05:27:24 +0000 (05:27 +0000)]
configure.ac: Don't hardcode -Wall and -Werror for configure checks, this fails with non-GCC compilers. Fixes bug #51...

Original commit message from CVS:
Patch by: Brian Cameron <brian dot cameron at sun dot com>
* configure.ac:
Don't hardcode -Wall and -Werror for configure checks, this fails
with non-GCC compilers. Fixes bug #517991.

16 years agogst/audiotestsrc/gstaudiotestsrc.c: Mark buffers as GAP,if volume is 0.0 and fix...
Stefan Kost [Thu, 21 Feb 2008 08:05:10 +0000 (08:05 +0000)]
gst/audiotestsrc/gstaudiotestsrc.c: Mark buffers as GAP,if volume is 0.0 and fix the previous logic.

Original commit message from CVS:
* gst/audiotestsrc/gstaudiotestsrc.c:
Mark buffers as GAP,if volume is 0.0 and fix the previous logic.

16 years agoext/gnomevfs/gstgnomevfssink.c: Return FALSE when seeking for a new segment fails...
Sebastian Dröge [Wed, 20 Feb 2008 15:37:36 +0000 (15:37 +0000)]
ext/gnomevfs/gstgnomevfssink.c: Return FALSE when seeking for a new segment fails instead of silently ignoring the fa...

Original commit message from CVS:
* ext/gnomevfs/gstgnomevfssink.c:
(gst_gnome_vfs_sink_handle_event):
Return FALSE when seeking for a new segment fails instead
of silently ignoring the failure and appending every buffer
that comes for the new segment.

16 years agogst/playback/gstplaysink.c: Recursively search the sink element for a last-frame...
Wim Taymans [Wed, 20 Feb 2008 11:52:28 +0000 (11:52 +0000)]
gst/playback/gstplaysink.c: Recursively search the sink element for a last-frame property so that we can also find th...

Original commit message from CVS:
* gst/playback/gstplaysink.c: (find_property),
(gst_play_sink_find_property), (gen_video_chain),
(gst_play_sink_reconfigure), (gst_play_sink_get_last_frame):
Recursively search the sink element for a last-frame property so that we
can also find the property in autovideosink and friends that don't
always proxy the internal sink properties.

16 years agogst-libs/gst/audio/multichannel.c: Fix confusing terminology in docs and code: struct...
Tim-Philipp Müller [Tue, 19 Feb 2008 20:42:09 +0000 (20:42 +0000)]
gst-libs/gst/audio/multichannel.c: Fix confusing terminology in docs and code: structure fields are 'fields' and not ...

Original commit message from CVS:
* gst-libs/gst/audio/multichannel.c:
(GST_AUDIO_CHANNEL_POSITIONS_FIELD_NAME),
(gst_audio_get_channel_positions), (gst_audio_set_channel_positions),
(gst_audio_set_structure_channel_positions_list),
(add_list_to_struct), (gst_audio_set_caps_channel_positions_list),
(gst_audio_fixate_channel_positions):
Fix confusing terminology in docs and code: structure fields are
'fields' and not 'properties'.

16 years agogst-libs/gst/audio/multichannel.c: Give more useful warning messages if one of the...
Tim-Philipp Müller [Tue, 19 Feb 2008 20:36:58 +0000 (20:36 +0000)]
gst-libs/gst/audio/multichannel.c: Give more useful warning messages if one of the channel layout enums passed to us ...

Original commit message from CVS:
* gst-libs/gst/audio/multichannel.c:
(gst_audio_check_channel_positions), (add_list_to_struct):
Give more useful warning messages if one of the channel
layout enums passed to us is invalid and if the "channels"
field in the caps has a GType we don't expect.

16 years agogst-libs/gst/audio/multichannel.c: Fix typo in docs blurb.
Tim-Philipp Müller [Tue, 19 Feb 2008 20:22:09 +0000 (20:22 +0000)]
gst-libs/gst/audio/multichannel.c: Fix typo in docs blurb.

Original commit message from CVS:
* gst-libs/gst/audio/multichannel.c:
Fix typo in docs blurb.

16 years agogst/typefind/gsttypefindfunctions.c: Increase the MPEG PS typefind lookup to fix...
Josep Torra Valles [Tue, 19 Feb 2008 16:16:55 +0000 (16:16 +0000)]
gst/typefind/gsttypefindfunctions.c: Increase the MPEG PS typefind lookup to fix typefinding on HD clips.

Original commit message from CVS:
2008-02-19  Julien Moutte  <julien@fluendo.com>

Patch by: Josep Torra Valles <josep@fluendo.com>

* gst/typefind/gsttypefindfunctions.c: Increase the MPEG PS
typefind lookup to fix typefinding on HD clips.

16 years agogst/playback/gstscreenshot.*: Fix up copyright (I rewrote the GStreamer-0.10 code...
Tim-Philipp Müller [Tue, 19 Feb 2008 15:50:37 +0000 (15:50 +0000)]
gst/playback/gstscreenshot.*: Fix up copyright (I rewrote the GStreamer-0.10 code for this from scratch back in the d...

Original commit message from CVS:
* gst/playback/gstscreenshot.c:
* gst/playback/gstscreenshot.h:
Fix up copyright (I rewrote the GStreamer-0.10 code for
this from scratch back in the days).

16 years agogst/playback/: Add screenshot conversion code from totem.
Wim Taymans [Tue, 19 Feb 2008 15:02:33 +0000 (15:02 +0000)]
gst/playback/: Add screenshot conversion code from totem.

Original commit message from CVS:
* gst/playback/Makefile.am:
* gst/playback/gstscreenshot.c: (feed_fakesrc), (save_result),
(create_element), (gst_play_frame_conv_convert):
* gst/playback/gstscreenshot.h:
Add screenshot conversion code from totem.
* gst/playback/gstplay-marshal.list:
* gst/playback/gstplaybin2.c: (gst_play_marshal_BUFFER__BOXED),
(gst_play_bin_class_init), (gst_play_bin_convert_frame),
(gst_play_bin_get_property), (no_more_pads_cb), (activate_group):
Implement frame property to get a color-unconverted snapshot.
Implement convert-frame action signal to get a converted snapshot image.
Configure connection speed in uridecodebin.
Document some more properties.
* gst/playback/gstplaysink.c: (gst_play_sink_class_init),
(gen_video_chain), (gen_audio_chain), (gst_play_sink_reconfigure),
(gst_play_sink_get_last_frame):
* gst/playback/gstplaysink.h:
Use last-buffer property of the video sink to get a video snapshot.
* tests/examples/seek/seek.c: (shot_cb), (main):
Add snapshot button for playbin2 and use the frame property to save the
frame as a png in the current directory.

16 years agogst/typefind/gsttypefindfunctions.c: Add typefinding support for h264 elementary...
Josep Torra Valles [Tue, 19 Feb 2008 11:45:56 +0000 (11:45 +0000)]
gst/typefind/gsttypefindfunctions.c: Add typefinding support for h264 elementary streams.

Original commit message from CVS:
Patch by: Josep Torra Valles <josep at fluendo dot com>
* gst/typefind/gsttypefindfunctions.c: (h264_video_type_find),
(plugin_init):
Add typefinding support for h264 elementary streams.
Fixes bug #517420.