robertphillips@google.com [Tue, 9 Apr 2013 14:01:44 +0000 (14:01 +0000)]
First pass at Rect Effect
https://codereview.chromium.org/
13521006/
git-svn-id: http://skia.googlecode.com/svn/trunk@8571
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 9 Apr 2013 11:59:42 +0000 (11:59 +0000)]
Deleting the hardcoded list of compile bots in trybots_to_run.
The submitted change https://codereview.chromium.org/
13493012/ makes this list unnecessary.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13947006
git-svn-id: http://skia.googlecode.com/svn/trunk@8570
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 9 Apr 2013 11:46:46 +0000 (11:46 +0000)]
Introduce aliases and regex in submit_try.
Adding the aliases 'compile' and 'cq'. Also adding a alias 'regex' that prompts the user for a regex, displays results and prompts again for confirmation.
Created to fix the feature request https://code.google.com/p/skia/issues/detail?id=1207 : replace hard-coded trybot lists with automated filtering.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13493012
git-svn-id: http://skia.googlecode.com/svn/trunk@8569
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 9 Apr 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8568
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 8 Apr 2013 21:54:58 +0000 (21:54 +0000)]
silence android warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8567
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 8 Apr 2013 21:44:11 +0000 (21:44 +0000)]
Error checking / reporting API
Review URL: https://codereview.chromium.org/
13699004
git-svn-id: http://skia.googlecode.com/svn/trunk@8566
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 20:37:35 +0000 (20:37 +0000)]
saving the old before blowing away
git-svn-id: http://skia.googlecode.com/svn/trunk@8565
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 20:36:19 +0000 (20:36 +0000)]
saving away the old before blowing the machine away
git-svn-id: http://skia.googlecode.com/svn/trunk@8564
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 8 Apr 2013 19:43:22 +0000 (19:43 +0000)]
Allow single-pass filters (which use asNewEffect()) to participate in the image filter DAG. This was done by introducing the SkSinglePassImageFilter abstract base class, which implements canFilterImageGPU() and filterImageGPU() on behalf of the derived class. The derived class still only needs to asNewEffect(). This allows us to recurse on the filter input in SkSinglePassImageFilter::onFilterImageGPU(). It also allows us to remove any knowledge of single-pass image filters from SkGpuDevice and from the SkImageFilter base class as well.
BUG=
Review URL: https://codereview.chromium.org/
13602013
git-svn-id: http://skia.googlecode.com/svn/trunk@8563
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 8 Apr 2013 15:45:30 +0000 (15:45 +0000)]
Add before and after command count to filter tool
https://codereview.chromium.org/
13405003/
git-svn-id: http://skia.googlecode.com/svn/trunk@8562
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Mon, 8 Apr 2013 14:57:40 +0000 (14:57 +0000)]
Switches to a Skia-specific appengine entry point that uses condensed data and taskqueue writes (SkipBuildbotRuns).
The default entry /add_point does not handle large data efficiently, so we've seen >30min timeouts for some bots to upload data. We now switch to using /skia_add_points that I'm writing for Skia, so we can condense the data to send to minimum (since all points in each batch have the same revision, platform and config), and dedicate the actual data processing to /skia_write_datastore which is a taskqueue task that has longer timeout and can run at app backend instead of blocking the bots.
Initial testing from my MacBook on Mac 64 bench data via vpn gave only a little more than 1 second for uploading data for one config, about 15 seconds for all 12 configs. That's a big win against 20+ minutes.
Review URL: https://codereview.chromium.org/
13762002
git-svn-id: http://skia.googlecode.com/svn/trunk@8560
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:53:42 +0000 (11:53 +0000)]
keep old experimental code in sync
git-svn-id: http://skia.googlecode.com/svn/trunk@8554
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:50:46 +0000 (11:50 +0000)]
Add implementation of path ops
This CL depends on
https://codereview.chromium.org/
12880016/
"Add intersections for path ops"
Given a path, iterate through its contour, and
construct an array of segments containing its curves.
Intersect each curve with every other curve, and for
cubics, with itself.
Given the set of intersections, find one with the
smallest y and sort the curves eminating from the
intersection. Assign each curve a winding value.
Operate on the curves, keeping and discarding them
according to the current operation and the sum of
the winding values.
Assemble the kept curves into an output path.
Review URL: https://codereview.chromium.org/
13094010
git-svn-id: http://skia.googlecode.com/svn/trunk@8553
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:50:00 +0000 (11:50 +0000)]
Add intersections for path ops
This CL depends on
https://codereview.chromium.org/
12827020/
"Add base types for path ops"
The intersection of a line, quadratic, or cubic
with another curve (or with itself) is found by
solving the implicit equation for the curve pair.
The curves are first reduced to find the simplest
form that will describe the original, and to detect
degenerate or special-case data like horizontal and
vertical lines.
For cubic self-intersection, and for a pair of cubics,
the intersection is found by recursively
approximating the cubic with a series of quadratics.
The implicit solutions depend on the root finding
contained in the DCubic and DQuad structs, and
the quartic root finder included here.
Review URL: https://codereview.chromium.org/
12880016
git-svn-id: http://skia.googlecode.com/svn/trunk@8552
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:47:37 +0000 (11:47 +0000)]
Add base types for path ops
Paths contain lines, quads, and cubics, which are
collectively curves.
To work with path intersections, intermediary curves
are constructed. For now, those intermediates use
doubles to guarantee sufficient precision.
The DVector, DPoint, DLine, DQuad, and DCubic
structs encapsulate these intermediate curves.
The DRect and DTriangle structs are created to
describe intersectable areas of interest.
The Bounds struct inherits from SkRect to create
a SkScalar-based rectangle that intersects shared
edges.
This also includes common math equalities and
debugging that the remainder of path ops builds on,
as well as a temporary top-level interface in
include/pathops/SkPathOps.h.
Review URL: https://codereview.chromium.org/
12827020
git-svn-id: http://skia.googlecode.com/svn/trunk@8551
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Sat, 6 Apr 2013 20:26:15 +0000 (20:26 +0000)]
Fix font handles leak. We return without freeing resources.
Fix for crbug/225256
Review URL: https://codereview.chromium.org/
13637004
git-svn-id: http://skia.googlecode.com/svn/trunk@8549
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 6 Apr 2013 07:01:10 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8548
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Fri, 5 Apr 2013 21:13:14 +0000 (21:13 +0000)]
Fix more clang errors.
Fixed -Wunused-private-field errors.
R=reed@google.com,bsalomon@google.com
Review URL: https://codereview.chromium.org/
13474012
git-svn-id: http://skia.googlecode.com/svn/trunk@8547
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Fri, 5 Apr 2013 14:38:08 +0000 (14:38 +0000)]
Unreviewed test fix
Just commenting out the test for now, will investigate...
git-svn-id: http://skia.googlecode.com/svn/trunk@8544
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 5 Apr 2013 14:21:04 +0000 (14:21 +0000)]
Reduce size of second iteration in SkTileGridNextDatum<>().
Rather than iterating over the entire dataset twice, during the first pass
track how large the second pass needs to be. Entirely data-dependent but
in practice approaches 2x speedup.
BUG=1212
R=junov
https://codereview.appspot.com/8315044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8543
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Fri, 5 Apr 2013 13:47:09 +0000 (13:47 +0000)]
New SVG turbulence in Skia
This cl contains the code for CPU generation of noise.
TEST:Added 'perlinnoise' gm
Review URL: https://codereview.chromium.org/
13094003
git-svn-id: http://skia.googlecode.com/svn/trunk@8541
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 4 Apr 2013 19:42:51 +0000 (19:42 +0000)]
Revert Skia to use -02.
There was no clear speed improvement and the
increase in binary size was substantial.
Committed: http://code.google.com/p/skia/source/detail?r=8492
Committed: https://code.google.com/p/skia/source/detail?r=8494
Review URL: https://codereview.chromium.org/
13468010
git-svn-id: http://skia.googlecode.com/svn/trunk@8539
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 4 Apr 2013 19:23:11 +0000 (19:23 +0000)]
re-land r8535, now that src.chromium.org is back up
Review URL: https://codereview.chromium.org/
13662002
git-svn-id: http://skia.googlecode.com/svn/trunk@8538
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 4 Apr 2013 19:13:40 +0000 (19:13 +0000)]
Whitespace change to see if svn.chromium.org is back
git-svn-id: http://skia.googlecode.com/svn/trunk@8537
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 4 Apr 2013 18:21:48 +0000 (18:21 +0000)]
Revert r8535
git-svn-id: http://skia.googlecode.com/svn/trunk@8536
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 4 Apr 2013 18:11:31 +0000 (18:11 +0000)]
gm: report ExpectationsMismatch and RenderModeMismatch results separately
Review URL: https://codereview.chromium.org/
13650002
git-svn-id: http://skia.googlecode.com/svn/trunk@8535
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 4 Apr 2013 14:12:22 +0000 (14:12 +0000)]
Whitespace change - Verify that checkouts are fixed
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@8533
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 4 Apr 2013 13:00:01 +0000 (13:00 +0000)]
Whitespace change to verify successful builds after master restart
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@8532
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 4 Apr 2013 11:59:55 +0000 (11:59 +0000)]
Whitespace change to test commit queue compile bots
(SkipBuildbotRuns)
Author: rmistry@google.com
Reviewed By: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
13631002
git-svn-id: http://skia.googlecode.com/svn/trunk@8530
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 4 Apr 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8529
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 3 Apr 2013 21:06:42 +0000 (21:06 +0000)]
Revert 8525,8526 pending investigation of bench_pictures crashes.
git-svn-id: http://skia.googlecode.com/svn/trunk@8527
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 3 Apr 2013 19:55:19 +0000 (19:55 +0000)]
Commit file accidentally left out of glc change for r8525
git-svn-id: http://skia.googlecode.com/svn/trunk@8526
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 3 Apr 2013 19:49:13 +0000 (19:49 +0000)]
Remove GrTexture::releaseRenderTarget() and add GrSurface::isSameAs().
Review URL: https://codereview.chromium.org/
13414006
git-svn-id: http://skia.googlecode.com/svn/trunk@8525
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 3 Apr 2013 18:48:18 +0000 (18:48 +0000)]
Add list of Skia trybots to run CLs against, along with existing lists of Chrome trybots
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13545002
git-svn-id: http://skia.googlecode.com/svn/trunk@8522
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 3 Apr 2013 18:35:35 +0000 (18:35 +0000)]
Make submit_try accept space- or comma-separated list
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13535005
git-svn-id: http://skia.googlecode.com/svn/trunk@8521
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 3 Apr 2013 18:30:26 +0000 (18:30 +0000)]
Whitespace change to test the commit queue compile bots
(SkipBuildbotRuns)
Author: rmistry@google.com
Reviewed By: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
13561002
git-svn-id: http://skia.googlecode.com/svn/trunk@8520
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 3 Apr 2013 18:00:39 +0000 (18:00 +0000)]
re-land r8514 without breaking 32-bit Mac compilers
Review URL: https://codereview.chromium.org/
13427004
git-svn-id: http://skia.googlecode.com/svn/trunk@8518
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 3 Apr 2013 17:31:22 +0000 (17:31 +0000)]
Rebaseline Ubuntu performance trigger
git-svn-id: http://skia.googlecode.com/svn/trunk@8516
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 3 Apr 2013 17:12:42 +0000 (17:12 +0000)]
roll out r8514
Review URL: https://codereview.chromium.org/
13503003
git-svn-id: http://skia.googlecode.com/svn/trunk@8515
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 3 Apr 2013 17:02:53 +0000 (17:02 +0000)]
gm: display summary of all results by ErrorType
as discussed in https://codereview.chromium.org/
12825005/#msg14
Review URL: https://codereview.chromium.org/
12851022
git-svn-id: http://skia.googlecode.com/svn/trunk@8514
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 3 Apr 2013 15:25:46 +0000 (15:25 +0000)]
Build fix for Surface Test on non-gpu builds
git-svn-id: http://skia.googlecode.com/svn/trunk@8513
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 3 Apr 2013 15:03:26 +0000 (15:03 +0000)]
Fixed bug with SkImage leaving canvas backing store in an immutable state after destroy.
Added unit test that verifies that surface backing is writable after creating and destroying an image.
Review URL: https://codereview.chromium.org/
13226002
git-svn-id: http://skia.googlecode.com/svn/trunk@8512
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 3 Apr 2013 14:56:40 +0000 (14:56 +0000)]
Add GrDrawTarget::copySurface.
Review URL: https://codereview.chromium.org/
13428004
git-svn-id: http://skia.googlecode.com/svn/trunk@8510
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 3 Apr 2013 13:58:32 +0000 (13:58 +0000)]
Replacing 'new' with 'SkNEW_ARGS' in SkImage_Gpu
Review URL: https://codereview.chromium.org/
13535004
git-svn-id: http://skia.googlecode.com/svn/trunk@8509
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 3 Apr 2013 12:34:16 +0000 (12:34 +0000)]
Fix build error when building Android in Release mode with -O2.
This fixes the folowing error...
../../../src/pdf/SkPDFShader.cpp: In function 'void gradientFunctionCode(const SkShader::GradientInfo&, SkString*)':
../../../src/pdf/SkPDFShader.cpp:69:19: error: array subscript is above array bounds [-Werror=array-bounds]
Review URL: https://codereview.chromium.org/
13471011
git-svn-id: http://skia.googlecode.com/svn/trunk@8506
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Wed, 3 Apr 2013 10:18:17 +0000 (10:18 +0000)]
SkDraw.h #include cleanup
Removal of SkAutoKern header was already done in r8495; this just
lands the replacement of #includes with forward declarations for
incremental compile speed.
https://codereview.appspot.com/8109043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8504
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 3 Apr 2013 07:01:14 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8503
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 2 Apr 2013 21:00:15 +0000 (21:00 +0000)]
Make drawRect preserve vertex attrib state and push/pop the geom sources.
Also, add some balancing calls for setIndexSource*()
Review URL: https://codereview.chromium.org/
13468004
git-svn-id: http://skia.googlecode.com/svn/trunk@8499
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 2 Apr 2013 20:48:38 +0000 (20:48 +0000)]
Fix for effect cache key.
Adds the additional shift needed to incorporate the attribKeyBits. Also simplifies the creation of the static globals for the edge effects.
Author: jvanverth@google.com
Reviewed By: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
13465019
git-svn-id: http://skia.googlecode.com/svn/trunk@8498
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 2 Apr 2013 18:41:32 +0000 (18:41 +0000)]
Remove unused header declaration.
BUG=1179
Author: djsollen@google.com
Reviewed By: reed@google.com,tomhudson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
13097005
git-svn-id: http://skia.googlecode.com/svn/trunk@8495
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 2 Apr 2013 18:14:21 +0000 (18:14 +0000)]
Revert Skia to use -02.
There was no clear speed improvement and the
increase in binary size was substantial.
Committed: http://code.google.com/p/skia/source/detail?r=8492
Review URL: https://codereview.chromium.org/
13468010
git-svn-id: http://skia.googlecode.com/svn/trunk@8494
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 2 Apr 2013 17:57:21 +0000 (17:57 +0000)]
Move edge GrEffects to locally defined classes.
This removes the general GrEdgeEffect and the specialized oval GrEffects and declares them within the renderer files that use them. It also splits GrEdgeEffect into three different GrEffects.
Author: jvanverth@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13344002
git-svn-id: http://skia.googlecode.com/svn/trunk@8493
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 2 Apr 2013 17:36:30 +0000 (17:36 +0000)]
Revert Skia to use -02.
There was no clear speed improvement and the
increase in binary size was substantial.
Author: djsollen@google.com
Reviewed By: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
13468010
git-svn-id: http://skia.googlecode.com/svn/trunk@8492
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 2 Apr 2013 16:41:55 +0000 (16:41 +0000)]
Increases batch size for sending bench data to appengine to 66.
This is part of the attempt to avoid bench step timeout errors (10-20min).
Review URL: https://codereview.chromium.org/
13430011
git-svn-id: http://skia.googlecode.com/svn/trunk@8491
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 2 Apr 2013 15:33:08 +0000 (15:33 +0000)]
resubmit https://code.google.com/p/skia/source/detail?r=7883 (in the meantime we
added capability to collect minidump and callstack if buildbot fails with heap
coruption in windows, and a NPE bug was fixed in SkPDFDocument, when document was destroyed without ever beeing used and a field was NULL + a few minor conflicts have been resolved)
git-svn-id: http://skia.googlecode.com/svn/trunk@8487
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 2 Apr 2013 15:30:03 +0000 (15:30 +0000)]
Expand filter 0 to handle transparent drawBitmapRect paints
https://codereview.chromium.org/
13394014/
git-svn-id: http://skia.googlecode.com/svn/trunk@8486
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 2 Apr 2013 15:18:41 +0000 (15:18 +0000)]
Add tile rendering to GM
https://codereview.chromium.org/
13165011/
git-svn-id: http://skia.googlecode.com/svn/trunk@8485
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 2 Apr 2013 15:05:55 +0000 (15:05 +0000)]
Re-enabling Mac 10.8 performance triggers removed in r8472
git-svn-id: http://skia.googlecode.com/svn/trunk@8484
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 2 Apr 2013 14:40:44 +0000 (14:40 +0000)]
Fix clang warning as error from 8480.
git-svn-id: http://skia.googlecode.com/svn/trunk@8482
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 2 Apr 2013 14:36:10 +0000 (14:36 +0000)]
Rebaseline Nexus7 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8481
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 2 Apr 2013 14:12:38 +0000 (14:12 +0000)]
Name table iterator.
https://codereview.appspot.com/8180043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8480
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 2 Apr 2013 12:50:49 +0000 (12:50 +0000)]
Reland 8459 with fix for #extension after default precision in FS.
git-svn-id: http://skia.googlecode.com/svn/trunk@8479
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 2 Apr 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8477
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 23:30:26 +0000 (23:30 +0000)]
Fix another clang warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@8476
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 23:24:15 +0000 (23:24 +0000)]
Fix clang compiler warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@8475
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 22:20:59 +0000 (22:20 +0000)]
Reverting r8459 due to shader error on Nexus 10
git-svn-id: http://skia.googlecode.com/svn/trunk@8474
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 21:38:37 +0000 (21:38 +0000)]
Remove MacMini_10_8 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8472
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 1 Apr 2013 21:00:27 +0000 (21:00 +0000)]
Taken together with the filter tool's new looping capabilities, these two optimizations can replace check_7 and apply_7.
Author: robertphillips@google.com
Reviewed By: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
13261019
git-svn-id: http://skia.googlecode.com/svn/trunk@8471
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 1 Apr 2013 20:28:08 +0000 (20:28 +0000)]
One more fix for r8468. Replace use of int with size_t. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@8470
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 1 Apr 2013 20:14:02 +0000 (20:14 +0000)]
Patches for r8468 build errors. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@8469
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 1 Apr 2013 20:06:51 +0000 (20:06 +0000)]
Take two for r8466:
Replace the old attribute binding and index interface with one where we include the binding as part of the attribute array. Also removed the fixed attribute indices for constant color and coverage attributes, and replaced with dynamic ones based on current attribute set. Removed binding of color and coverage attributes unless they're actually set.
Original author: bsalomon@google.com
Author: jvanverth@google.com
Reviewed By: bsalomon@google.com,robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13296005
git-svn-id: http://skia.googlecode.com/svn/trunk@8468
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 1 Apr 2013 19:29:32 +0000 (19:29 +0000)]
Rolling back r8466.
Not reviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@8467
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 1 Apr 2013 19:12:42 +0000 (19:12 +0000)]
Revise attribute binding interface.
Replace the old attribute binding and index interface with one where we include the binding as part of the attribute array. Also removed the fixed attribute indices for constant color and coverage attributes, and replaced with dynamic ones based on current attribute set. Removed binding of color and coverage attributes unless they're actually set.
Original author: bsalomon@google.com
Author: jvanverth@google.com
Reviewed By: bsalomon@google.com,robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13296005
git-svn-id: http://skia.googlecode.com/svn/trunk@8466
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 19:10:21 +0000 (19:10 +0000)]
Add looping over optimizations to filter tool
https://codereview.chromium.org/
13261018/
git-svn-id: http://skia.googlecode.com/svn/trunk@8465
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 1 Apr 2013 19:01:20 +0000 (19:01 +0000)]
Simplify the circle outset code and add comment relating it to the shader code.
Review URL: https://codereview.chromium.org/
13165012
git-svn-id: http://skia.googlecode.com/svn/trunk@8463
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Apr 2013 18:18:49 +0000 (18:18 +0000)]
Add getDrawCommandAt and setDrawCommandAt to SkDebugCanvas
https://codereview.chromium.org/
13393005/
git-svn-id: http://skia.googlecode.com/svn/trunk@8462
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 1 Apr 2013 18:02:55 +0000 (18:02 +0000)]
Add GM mixed_xfermodes. This is a work in progress and will be used to test fixes for GPU Xfermodes effects.
Review URL: https://codereview.chromium.org/
13365005
git-svn-id: http://skia.googlecode.com/svn/trunk@8461
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 1 Apr 2013 17:59:16 +0000 (17:59 +0000)]
Add short option for --bot in submit_try
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13133011
git-svn-id: http://skia.googlecode.com/svn/trunk@8460
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 1 Apr 2013 17:48:33 +0000 (17:48 +0000)]
Make GrGLShaderBuilder responsible for enabling GLSL extensions
Review URL: https://codereview.chromium.org/
12668019
git-svn-id: http://skia.googlecode.com/svn/trunk@8459
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 1 Apr 2013 12:51:34 +0000 (12:51 +0000)]
Add Xfermode bench. Also clear before rendering in bench (rather than after).
Author: bsalomon@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13334011
git-svn-id: http://skia.googlecode.com/svn/trunk@8454
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 1 Apr 2013 12:49:31 +0000 (12:49 +0000)]
Trim the copy of the dst made for dst-reading effects using the clip and dev-bounds of draw.
Adds dev bounds to circles and rects drawn by GrDrawTarget base class (GrIODB already provides rect bounds).
Author: bsalomon@google.com
Reviewed By: robertphilips@google.com,jvanverth@google.com,robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13222004
git-svn-id: http://skia.googlecode.com/svn/trunk@8453
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 30 Mar 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8452
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 29 Mar 2013 20:30:50 +0000 (20:30 +0000)]
Fix GLPrograms test.
Review URL: https://codereview.chromium.org/
13327008
git-svn-id: http://skia.googlecode.com/svn/trunk@8450
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 29 Mar 2013 19:22:36 +0000 (19:22 +0000)]
Add support for reading the dst pixel value in an effect. Use in a new effect for the kDarken xfer mode.
The current implementation is to always make a copy of the entire dst before the draw.
It will only succeed if the RT is also a texture.
Obviously, there is lots of room for improvement.
Review URL: https://codereview.chromium.org/
13314002
git-svn-id: http://skia.googlecode.com/svn/trunk@8449
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 29 Mar 2013 17:34:33 +0000 (17:34 +0000)]
Whitespace change to test Commit Queue
TBR=borenet
(SkipBuildbotRuns)
Author: rmistry@google.com
Reviewed By:
Review URL: https://chromiumcodereview.appspot.com/
13326003
git-svn-id: http://skia.googlecode.com/svn/trunk@8447
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 29 Mar 2013 17:26:00 +0000 (17:26 +0000)]
Display prompt for caution only if it is an interactive shell.
Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13325002
git-svn-id: http://skia.googlecode.com/svn/trunk@8446
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Fri, 29 Mar 2013 16:53:30 +0000 (16:53 +0000)]
Fix more clang tautological-constant-out-of-range-compare errors.
And one of unused-private-field:
samplecode/SampleStrokeText.cpp:109:10: error: private field 'fAA' is not used [-Werror,-Wunused-private-field]
bool fAA;
R=bsalomon@google.com,reed@google.com
Review URL: https://codereview.chromium.org/
12906016
git-svn-id: http://skia.googlecode.com/svn/trunk@8445
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 29 Mar 2013 14:57:22 +0000 (14:57 +0000)]
add matcher to fontstyleset
Review URL: https://codereview.chromium.org/
13312002
git-svn-id: http://skia.googlecode.com/svn/trunk@8444
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 29 Mar 2013 14:23:56 +0000 (14:23 +0000)]
use SkTCast
git-svn-id: http://skia.googlecode.com/svn/trunk@8443
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 29 Mar 2013 12:11:10 +0000 (12:11 +0000)]
Fix minor cppcheck-found issues
https://codereview.chromium.org/
13146005/
git-svn-id: http://skia.googlecode.com/svn/trunk@8440
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 29 Mar 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8439
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Mar 2013 19:18:12 +0000 (19:18 +0000)]
Make GM render to render targets that are also textures.
Review URL: https://codereview.chromium.org/
13211002
git-svn-id: http://skia.googlecode.com/svn/trunk@8438
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 28 Mar 2013 18:08:05 +0000 (18:08 +0000)]
Whitespace change to trigger builders to make sure codesite issue is resolved.
git-svn-id: http://skia.googlecode.com/svn/trunk@8437
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 28 Mar 2013 18:03:27 +0000 (18:03 +0000)]
Fix iOS compiler error/warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8436
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 28 Mar 2013 17:54:20 +0000 (17:54 +0000)]
Whitespace change to trigger builders to make sure codesite issue is resolved.
git-svn-id: http://skia.googlecode.com/svn/trunk@8435
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Mar 2013 15:11:14 +0000 (15:11 +0000)]
Attempt to silence signed/unsigned warnings in android build.
Review URL: https://codereview.chromium.org/
13168003
git-svn-id: http://skia.googlecode.com/svn/trunk@8434
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 28 Mar 2013 15:03:22 +0000 (15:03 +0000)]
disable tests that exercise serialization of fonts here, since we are experimentally
creating typeface styles that don't know how to serialize yet.
git-svn-id: http://skia.googlecode.com/svn/trunk@8433
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 28 Mar 2013 14:22:58 +0000 (14:22 +0000)]
Triggering rebuilds after master restart
git-svn-id: http://skia.googlecode.com/svn/trunk@8432
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 28 Mar 2013 14:15:37 +0000 (14:15 +0000)]
Triggering rebuilds after master restart.
git-svn-id: http://skia.googlecode.com/svn/trunk@8431
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 28 Mar 2013 14:12:10 +0000 (14:12 +0000)]
add caching to fontmgr for mac
Review URL: https://codereview.chromium.org/
13161002
git-svn-id: http://skia.googlecode.com/svn/trunk@8430
2bbb7eff-a529-9590-31e7-
b0007b416f81