add isl_pw_multi_aff_from_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_multi_aff_set_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_aff_zero

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_from_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_parameter_compression: use isl_vec_set

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_flow.c: use public isl_vec interface

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_vec_set_si

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_vec_set

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add public isl_vec interface

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_seq_set_si

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_pw_*_free: return NULL

Returning NULL helps to simplify error handling code.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

split off declarations of isl_union_map and isl_union_set

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_deltas: add memory management annotations

Signed-off-by: Riyadh Baghdadi <baghdadi.m.riyadh@gmail.com>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info: change interface for specifying restrictions

The original interface would only allow the user to restrict the source
iterations, while the user may also want to restrict the sink iterations.
The new interface also makes it more convenient for the user to specify
that no restriction should be applied and allows for a restriction
on the result of the maximization problem.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_coalesce: only coalesce pairs of basic maps with the same divs

Most of the heuristics won't be able to find any coalescing opportunities
on basic maps with different divs, so it's not worth it to even try.
A notable exception is the subset test, which is now handled separately.

Since we only perform the tests after checking that the divs are the same,
there is no point in aligning the divs over all basic maps.  This could
be a very expensive operation, especially if some divs are unknown as it
would then compute explicit representations for all divs.  This could have
the counter-intuitive effect that the ouptut of isl_map_coalesce would have
_more_ basic maps (because of the splits introduced during the computation
of explicit representations) than the input.
Instead, we know simply sort the known divs.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_coalesce.c: change interface of {in,}eq_status_in

We will want to call them on a modified basic map in the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_sort_divs

Sorting divs should improve the effectiveness of isl_merge_divs.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_coalesce test case

We will be making changes to isl_map_coalesce and we want to make sure
we won't break this case.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_map_get_divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_merge_divs: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_local_space_alloc_div: fix error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_set_compute_schedule: ignore backward proximity edges on split

Proximity edges are not taken into account during the detection
of strongly connected components.  When we split the dependence graph
based on these SCCs, we may therefore have proximity edges that go
back from a SCC behind the split to a SCC ahead of the split.  These should
be ignored, just like those edges that go from ahead of the split to behind
the split.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_insert: preserve emptiness

isl_basic_map_plain_is_empty doesn't look at the constraints but only
at the ISL_BASIC_MAP_EMPTY flag.  We therefore need to make sure the
flag is set on the output of isl_basic_map_insert if it was set on the
input.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_total_dim: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_term_get_div: support nested divs

Ever since 028d1a7 (drop isl_div abstraction, Fri Sep 9 14:55:16 2011 +0200),
the result of isl_term_get_div is an isl_aff and it can handle nested divs
just fine.  We therefore simply need to remove the now redundant check.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_term_get_div: normalize result

In particular, remove unused divs from the result.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_compute_flow: sort accesses in textual order

Before, we tried to be clever and sorted the accesses in order
of increasing number of shared levels with the sink access.
However, this has little advantage over textual order.
Textually later accesses that cannot precede the sink at a given level
are simply skipped.
On the other hand, when we consider a loop level, we usually
do want to consider the textually last access first and not some
textually earlier access that happens to share more levels with the sink.
In particular, if this textually last access covers all the pending
sink accesses, there is no need to consider earlier accesses,
whereas you would always have to consider later accesses if you started
out with an earlier access.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_flow.c: access_sort_cmp: use isl_quicksort

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_qsort.h: fix whitespace

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_coalesce: optionally bound the coefficients of wrapping constraints

One of the methods for combining pairs of basic relations is based on wrapping.
The coefficients of these wrapping constraints may be much larger than
those of the constraints in the input.  If isl_map_coalesce is called
to simplify the representation of a relation, then constraints with
large coefficients are typically undesirable.  We therefore do not allow
the coefficients in the wrapping constraints to be larger than those
in the input, but we allow the user to override this choice.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_seq_abs_max

Merge branch 'maint'

isl_map_coalesce: don't try to relax (implicit) equalities

An inequality that turns out to be an equality may have been removed
from the tableau, so we cannot relax it.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_relax: prevent relaxation on dead or redundant constraints

Trying to relax such constraints can only lead to problems,
especially if the constraints have been removed from the tableau.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_union: plug memory leak on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Fix a typo in isl_term_dup

Signed-off-by: Louis-Noel Pouchet <pouchet@cse.ohio-state.edu>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_map: allow "not" at start of grouped expression

Reported-by: Vladimir Klebanov <vladimir@cost-ic0701.org>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_test: test_parse_map_equal: return result of test

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_pw_*_on_shared_domain: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

link in new -lclangEdit when available

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_*alloc macros: return expression of desired type

The type information was dropped in 157122e (Check the ctx argument of the
memory macros, Tue Jun 7 16:15:15 2011 -0300).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_fixed_power and isl_union_map_fixed_power

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_token: change type of "type" field from enum isl_token_type to int

The field is also assigned values outside the enum.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_union_map_is_subset: properly handle non-obviously empty subsets

If the first argument of isl_union_map_is_subset contains an empty
set in some space that is not present in the second argument,
then isl_union_map_is_subset would incorrectly draw the conclusion
that the first is not a subset of the second.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_cond: change first argument from an isl_set to an isl_pw_aff

An isl_pw_aff can also convey information about whether the expression
is defined.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_{lower,upper}_bound

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_n_piece

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_indicator_function

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_affine_hull: consider points adjacent to any point found

This is usually a fairly cheap way of finding additional points in
the affine hull and may in some cases eliminate constraints with large
coefficients in the current approximation of the hull.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_has_dim_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: minor clean-up

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_space_has_dim_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

configure.ac: remove spurious ","

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: fix typo

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_sample: perform basis reduction at each level by default

Although always performing basis reduction can lead to slow-downs
on larger problems, only performing it once can result in some
relatively simple problems taking an inordinate amount of time.
We therefore revert back to the default from before 8db0a80
(isl_basic_set_sample: only perform basis reduction once,
Sun Aug 9 11:42:41 2009 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_is_subset

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_basic_map_is_subset

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_sample

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: document *_sample functions

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_coalesce.c: wrap_in_facets: bail out if any of the facets are empty

It the tableau corresponding to a facet is empty, then we don't have
accurate information on the ridges and we can't call add_wraps.
The facet can have no integer points due to other constraints.
An alternative would be to temporarily treat the tableau as a rational
tableau.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_test: test_coalesce_set: fail if coalescing failed

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_map_plain_is_single_valued

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_basic_map_partial_lexopt: properly normalize divs

We were only dividing out common divisors that also divide
the constant term, but we should ignore the constant term
while determining the greatest common divisor.

We already properly normalize the constraints and not properly
normalizing the divs could result in div constraints not being
recognized as such.  In particular, inside isl_map_affine_hull,
div constraints are added inside the call to isl_basic_map_overlying_set.
Usually, these constraints are removed again in remove_redundant_divs,
but they would remain if the the divs are not properly normalized.

Now, arguably, we shouldn't be adding div constraints inside
isl_map_affine_hull, but a proper normalization of divs is useful in any case.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_complement

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: allow to bound the coefficients in the calculated schedule

isl already supports the bounding of the constant term of the calculated
schedule, but within polybench there are several cases where bounding
the coefficients of parameter and variable dimensions is also needed.

With a bound of 20 Polly can run the isl scheduler on all polybench 2.0 kernels
and takes for each less than 5 seconds, whereas without the bound five test
cases had scheduling times larger than 40 seconds. This is still slower, than
scheduling with gist simplified dependences but it yields better results.
The bounded, non-gist-simplified schedule yields for dynprog, lu, reg_detect
and trmm to faster code compared to scheduling with gist simplified
dependences. For gramschmidt it yields slower code.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_basic_set_non_trivial_lexmin: do not add cuts for all variables

We found a test case where adding cuts for all variables can increase
the time of the scheduling algorithm significantly (from ms to never
seen terminating). Even though we did not understand the problem
entirely, the intuition we have is the following:

When using isl_tab_basic_set_non_trivial_lexmin, the ILP problem is
(usually) not empty, but infinite. Adding all cuts, seems to increase
the objective function only in very small steps. Adding only one cut at
a time allows us to increase it with a step as big as possible.

This patch does not change the behaviour when calling
check_integer_feasible.  In case we're calling cut_to_integer_lexmin
from check_integer_feasible, if it takes a long time to compute, then
it's "usually" because the context is empty and it's just taking a long
time for us to discover that it's empty. We believe in that case it
could still make sense to add all cuts.

This patch was tested on polybench 2.0 with Polly and minimal fusion.
On the larger kernels, it could not solve any infinite scheduling time
problems, but it was able to speed up one test case by 2x and did not
yield increased scheduling time for the other test cases.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_fix_si: drop basic maps that have become empty

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map.c: extract out common remove_if_empty

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_coalesce: drop empty parts before checking the number of parts

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_convex_hull.c: uset_convex_hull_wrap_bounded: remove redundant constraints

The caller compute_facet expects the result to not contain any redundant
constraints.  The input to uset_convex_hull_wrap_bounded, however, might
contain redundant constraints so if this input consists of only one
basic set, we need to make sure redundant constraints are removed.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_realign: preserve (most) flags

In particular, preserve the ISL_BASIC_MAP_EMPTY flag.
Many parts of the code check for this flags so they do not have
to deal with the "1 = 0" constraint.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_printer_print_pw_aff test

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_foreach_lexopt: normalize isl_affs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_*_union_add: don't subtract non-overlapping cells

There is no point in subtracting a cell from another if their intersection
is empty.  It can only lead to a further subdivision of the other cell.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: skip constraints implied by div expression

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_is_div_constraint

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

Conflicts:
isl_output.c

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: fix printing in C format

In 3280c05 (make isl_pw_* object live in a map space,
Tue Aug 30 16:47:59 2011 +0200), the space in which objects live was
changed from that of its domain to that of a map, but
isl_printer_print_pw_aff was not changed accordingly.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_aff: call isl_pw_aff_union_add instead of isl_pw_aff_add

We missed this in 7a86dd8 (rename isl_pw_aff_add to isl_pw_aff_union_add,
Thu Oct 13 12:16:45 2011 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_vertices.c: compute_chambers: avoid access to freed data structure

The problem was introduced in 328c78f (isl_tab_from_basic_map: preserve all
constraints in input when tracking, Mon Jan 16 16:55:44 2012 +0100).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_coalesce

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: remove unused divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_multi_aff_from_map: add a special case where result can be read off

If all output dimensions are uniquely defined in terms of the parameters
and input dimensions, we can directly read off the desired isl_pw_multi_aff.
This usually results in much simpler expressions.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_basic_map_plain_is_single_valued

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: simplify domain expression in C format

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_morph.c: fix typo in comment

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_basic_set_full_compression: detect equalities in input first

Without this explicit detection of equalities, some equalities
may be discovered in the middle of the computation, possibly
leading to the introduction of existentially quantified variables,
while callers of isl_basic_set_full_compression typically do not
want such variables.

Since the detection of equalities can in some cases be fairly expensive,
we may have to find a better way of dealing with this problem at some point.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_qpolynomial: accept products of integer divisions

Before, we called accept_affine to parse an integer division that appears
inside a function, but accept_affine also parses a subsequent '*' and
then expects this '*' to be followed by a constant.
Call accept_div directly intead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_set_product: call isl_set_product on entries

Before, we would simply delegate control to isl_union_map_product,
which calls isl_map_product on the entries.  This doesn't work
on isl_sets because they only have a "range" and no "domain".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_pip.c: sol_add: skip empty contexts

If the context becomes non-empty inside find_solutions, we stop
looking for solutions since a89841a (isl_tab_pip.c: find_solutions: break
when context becomes empty, Sun Jan 31 18:29:12 2010 +0100), but
we still call sol_add.  We need to return from sol_add early in
such cases because there is nothing to do and, more importantly,
when a basic set is marked empty, its existentials are removed,
resulting in a mismatch in the number of dimensions.  In particular,
the basic set returned by sol_domain may not satisfy all assumptions
made by the remainder of sol_add.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: also set id of parameter in nested spaces

A nested space is supposed to have the same parameters as
the nesting space, so if the id of a parameter in the nesting
space space changes, it has to be changed in the nested spaces too.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: rename "dim" variable to "space"

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: replace split_parallel by split_scaled option

The split_parallel option was ill-conceived.
The condition split_parallel looked for was too specific
and the implementation was wrong.  Part of this has been fixed
in 1b2fdb6 (schedule.c: split_parallel: avoid invalid memory accesses,
Mon Jan 30 15:23:18 2012 +0100), but the code could in principle
still produce an incorrect schedule because it didn't check the sizes
of the constant terms.

The new option essentially applies strip-mining and should therefore
be safe.  In particular, it is applied when the linear parts of the
schedules have a non-trivial common divisor.  The strip-mining is
then performed with respect to this common divisor.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>