platform/upstream/llvm.git
8 years agoFix two tests relying on LLVM -O1 behavior
Reid Kleckner [Thu, 11 Feb 2016 00:14:04 +0000 (00:14 +0000)]
Fix two tests relying on LLVM -O1 behavior

Something changed the inference of nonnull.

llvm-svn: 260472

8 years agoFix build failure caused in r260430
Hemant Kulkarni [Thu, 11 Feb 2016 00:01:47 +0000 (00:01 +0000)]
Fix build failure caused in r260430

llvm-svn: 260471

8 years ago[llvm-nm] Minor style change. Prefer EXIT_SUCCESS over 0.
Davide Italiano [Wed, 10 Feb 2016 23:56:18 +0000 (23:56 +0000)]
[llvm-nm] Minor style change. Prefer EXIT_SUCCESS over 0.

llvm-svn: 260470

8 years agoFix Windows bot failure in Transforms/FunctionImport/funcimport.ll
Teresa Johnson [Wed, 10 Feb 2016 23:47:38 +0000 (23:47 +0000)]
Fix Windows bot failure in Transforms/FunctionImport/funcimport.ll

Make sure we split ":" from the end of the global function id (which
is <path>:<function> for local functions) instead of the beginning to
avoid splitting at the wrong place for Windows file paths that contain
a ":".

llvm-svn: 260469

8 years ago[GlobalISel] Remember the size of generic virtual registers
Quentin Colombet [Wed, 10 Feb 2016 23:43:48 +0000 (23:43 +0000)]
[GlobalISel] Remember the size of generic virtual registers

llvm-svn: 260468

8 years agoReorder code to improve readability. NFC.
Rui Ueyama [Wed, 10 Feb 2016 23:43:16 +0000 (23:43 +0000)]
Reorder code to improve readability. NFC.

llvm-svn: 260467

8 years agoFunctionImport: add a progressive heuristic to limit importing too deep in the callgraph
Mehdi Amini [Wed, 10 Feb 2016 23:31:45 +0000 (23:31 +0000)]
FunctionImport: add a progressive heuristic to limit importing too deep in the callgraph

The current function importer will walk the callgraph, importing
transitively any callee that is below the threshold. This can
lead to import very deep which is costly in compile time and not
necessarily beneficial as most of the inline would happen in
imported function and not necessarilly in user code.

The actual factor has been carefully chosen by flipping a coin ;)
Some tuning need to be done (just at the existing limiting threshold).

Reviewers: tejohnson

Differential Revision: http://reviews.llvm.org/D17082

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260466

8 years agoDon't include NOBITS TLS in PT_LOAD.
Rafael Espindola [Wed, 10 Feb 2016 23:29:38 +0000 (23:29 +0000)]
Don't include NOBITS TLS in PT_LOAD.

They don't count for the memory or file size, so this is mostly just a
simplification.

The only noticeable difference should be fewer empty program headers.

llvm-svn: 260465

8 years agoMake llvm-nm test consistent with other tests
Hemant Kulkarni [Wed, 10 Feb 2016 23:28:43 +0000 (23:28 +0000)]
Make llvm-nm test consistent with other tests

llvm-svn: 260464

8 years agoELF: Use stable sort to sort .{init,fini}_array sections.
Rui Ueyama [Wed, 10 Feb 2016 23:26:27 +0000 (23:26 +0000)]
ELF: Use stable sort to sort .{init,fini}_array sections.

Global constructors and destructors are guaranteed to be called
in the order as they appear in a translation unit. So we don't want
to mess up the order if they have the same priority.

llvm-svn: 260463

8 years agoUse a StringSet in Internalize, and allow to create the pass from an existing one...
Mehdi Amini [Wed, 10 Feb 2016 23:24:31 +0000 (23:24 +0000)]
Use a StringSet in Internalize, and allow to create the pass from an existing one (NFC)

There is not reason to pass an array of "char *" to rebuild a set if
the client already has one.

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260462

8 years agoAdd the ability to initialize a StringSet from a pair of iterators (NFC)
Mehdi Amini [Wed, 10 Feb 2016 23:24:21 +0000 (23:24 +0000)]
Add the ability to initialize a StringSet from a pair of iterators (NFC)

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260461

8 years agoELF: Implement __attribute__((init_priority(N)) support.
Rui Ueyama [Wed, 10 Feb 2016 23:20:42 +0000 (23:20 +0000)]
ELF: Implement __attribute__((init_priority(N)) support.

llvm-svn: 260460

8 years ago[llvm-nm] Prefer range-based loop over explicit iterator.
Davide Italiano [Wed, 10 Feb 2016 23:16:17 +0000 (23:16 +0000)]
[llvm-nm] Prefer range-based loop over explicit iterator.

llvm-svn: 260459

8 years agoAdd a new insert_as() method to DenseMap and use it for ConstantUniqueMap
Mehdi Amini [Wed, 10 Feb 2016 23:07:29 +0000 (23:07 +0000)]
Add a new insert_as() method to DenseMap and use it for ConstantUniqueMap

Summary:
Just like the existing find_as() method, the new insert_as() accepts
an extra parameter which is used as a key to find the bucket in the
map.
When creating a Constant, we want to check the map before actually
creating the object. In this case we have to perform two queries to
the map, and this extra parameter can save recomputing the hash value
for the second query.

Reviewers: dexonsmith, chandlerc

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D16268

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260458

8 years ago[CMake] Add a macro definition to detect if we are building GlobalISel:
Quentin Colombet [Wed, 10 Feb 2016 23:00:57 +0000 (23:00 +0000)]
[CMake] Add a macro definition to detect if we are building GlobalISel:
LLVM_BUILD_GLOBAL_ISEL

llvm-svn: 260457

8 years ago[GlobalISel] More detailed skeleton for the IRTranslator.
Quentin Colombet [Wed, 10 Feb 2016 22:59:27 +0000 (22:59 +0000)]
[GlobalISel] More detailed skeleton for the IRTranslator.

llvm-svn: 260456

8 years agoBitcode reader: replace DecodeChar6() with a lookup table (NFC)
Mehdi Amini [Wed, 10 Feb 2016 22:47:48 +0000 (22:47 +0000)]
Bitcode reader: replace DecodeChar6() with a lookup table (NFC)

Summary: Measured to be more performant when reading bitcode.

Reviewers: rafael, dexonsmith

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D16285

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260455

8 years agoSimplify handleOperandChangeImpl() removing last argument (NFC)
Mehdi Amini [Wed, 10 Feb 2016 22:47:15 +0000 (22:47 +0000)]
Simplify handleOperandChangeImpl() removing last argument (NFC)

The Use argument was used to compute the operand number for a fast
path when replacing only one operand. However we always have to go
through all the operands. So the argument number can be recomputed
locally anyway.

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 260454

8 years agoSplit the creation of program headers in a few steps.
Rafael Espindola [Wed, 10 Feb 2016 22:43:13 +0000 (22:43 +0000)]
Split the creation of program headers in a few steps.

IMHO this makes the code easier to read and should help with linker
scripts.

This is strongly based on D16575. The main differences are:

We record a range of sections, not every section in a program header.

scanHeaders takes case of deciding what goes in every program header,
including PT_GNU_RELRO

We create dummy sections for the start of the file

With this, program header creation has 3 isolated stages:

Map sections to program headers.
Assign addresses to *sections*
Looking at sections find the address and size of each program header.

Thanks to George Rimar for the initial version.

llvm-svn: 260453

8 years agoRevert 260436. I pretty consistently upper-case the letter I use for the
Jim Ingham [Wed, 10 Feb 2016 22:30:20 +0000 (22:30 +0000)]
Revert 260436.  I pretty consistently upper-case the letter I use for the
short option as an aid to memory.  Like it's w because of the W in throW.

That helps me remember.  If we are going to take these out we should take them
all out.  But I kind of like them.

llvm-svn: 260452

8 years agoFollow up to 260439, Speculative fix to clang builders
Philip Reames [Wed, 10 Feb 2016 22:22:41 +0000 (22:22 +0000)]
Follow up to 260439, Speculative fix to clang builders

It looks like clang has a couple of test cases which caught the fact LVI was not slightly more precise after 260439.  When looking at the failures, it struck me as wasteful to be querying nullness of a constant via LVI, so instead of tweaking the clang tests, let's just stop querying constants from this source.

llvm-svn: 260451

8 years ago[PGO] Make the number of records for each value site metada adjustable
Rong Xu [Wed, 10 Feb 2016 22:19:43 +0000 (22:19 +0000)]
[PGO] Make the number of records for each value site metada adjustable

The patch adds a parameter in annotateValueSite() to control the max number
of records written to the value profile meta data for each value site. The
default is kept as the current value of 3.

Differential Revision: http://reviews.llvm.org/D17084

llvm-svn: 260450

8 years agoRevert r260388 "[MS ABI] Never reference dllimport'd vtables"
Hans Wennborg [Wed, 10 Feb 2016 22:18:37 +0000 (22:18 +0000)]
Revert r260388 "[MS ABI] Never reference dllimport'd vtables"

This caused the compiler to fail with "invalid linkage type
for global declaration" (PR26569).

llvm-svn: 260449

8 years agoBail on compilation as soon as a job fails.
Justin Lebar [Wed, 10 Feb 2016 22:17:00 +0000 (22:17 +0000)]
Bail on compilation as soon as a job fails.

Previously we attempted to be smart; if one job failed, we'd run all
jobs that didn't depend on the failing job.

Problem is, this doesn't work well for e.g. CUDA compilation without
-save-temps.  In this case, the device-side and host-side Assemble
actions (which actually are responsible for preprocess, compile,
backend, and assemble, since we're not saving temps) are necessarily
distinct.  So our clever heuristic doesn't help us, and we repeat every
error message once for host and once for each device arch.

The main effect of this change, other than fixing CUDA, is that if you
pass multiple cc files to one instance of clang and you get a compile
error, we'll stop when the first cc1 job fails.

Reviewers: tra, echristo

Subscribers: jhen, cfe-commits

Differential Revision: http://reviews.llvm.org/D16514

llvm-svn: 260448

8 years agoAPInt: Simplify EqualSlowCase
Matthias Braun [Wed, 10 Feb 2016 22:13:10 +0000 (22:13 +0000)]
APInt: Simplify EqualSlowCase

Previously the code used getActiveBits() to determine the highest set
bit of each APInt first. However doing so requires the same amount of
memory accesses as simply comparing both numbers right away.

Removing all the active bit checks leads to simpler code and is faster
in my benchmark.

Differential Revision: http://reviews.llvm.org/D16620

llvm-svn: 260447

8 years agoFix buildbot failure (hosts without zlib)
Xinliang David Li [Wed, 10 Feb 2016 22:05:41 +0000 (22:05 +0000)]
Fix buildbot failure (hosts without zlib)

llvm-svn: 260446

8 years agoWhen importing Objective-C protocols, mark them as having external decls.
Sean Callanan [Wed, 10 Feb 2016 22:00:32 +0000 (22:00 +0000)]
When importing Objective-C protocols, mark them as having external decls.

We already do this for Objective-C interfaces, but we never handled protocols
because the DWARF didn't represent them.  Nowadays, though, we can import them
from modules, and we have to mark them properly.

<rdar://problem/24193009>

llvm-svn: 260445

8 years agoELF: Combine cases that has the same code.
Rui Ueyama [Wed, 10 Feb 2016 22:00:21 +0000 (22:00 +0000)]
ELF: Combine cases that has the same code.

llvm-svn: 260444

8 years agoRemove changes that snuck in within r260431
Eric Fiselier [Wed, 10 Feb 2016 21:58:36 +0000 (21:58 +0000)]
Remove changes that snuck in within r260431

llvm-svn: 260443

8 years agoRestore "[ThinLTO] Use MD5 hash in function index." with fix
Teresa Johnson [Wed, 10 Feb 2016 21:55:02 +0000 (21:55 +0000)]
Restore "[ThinLTO] Use MD5 hash in function index." with fix

This restores commit r260408, along with a fix for a bot failure.

The bot failure was caused by dereferencing a unique_ptr in the same
call instruction parameter list where it was passed via std::move.
Apparently due to luck this was not exposed when I built the compiler
with clang, only with gcc.

llvm-svn: 260442

8 years agoFix invalid casts in <functional>.
Evgeniy Stepanov [Wed, 10 Feb 2016 21:53:28 +0000 (21:53 +0000)]
Fix invalid casts in <functional>.

static_cast of a pointer to object before the start of the object's
lifetime has undefined behavior.

This code triggers CFI warnings.

This change replaces C-style casts with reinterpret_cast, which is
fine per the standard, add applies an attribute to silence CFI (which
barks on reinterpret_cast, too).

llvm-svn: 260441

8 years agoFix copy/paste error in TestCModules.
Zachary Turner [Wed, 10 Feb 2016 21:47:36 +0000 (21:47 +0000)]
Fix copy/paste error in TestCModules.

llvm-svn: 260440

8 years ago[LVI] Handle constants defensively
Philip Reames [Wed, 10 Feb 2016 21:46:32 +0000 (21:46 +0000)]
[LVI] Handle constants defensively

There's nothing preventing callers of LVI from asking for lattice values representing a Constant.  In fact, given that several callers are walking back through PHI nodes and trying to simplify predicates, such queries are actually quite common.  This is mostly harmless today, but we start volatiling assertions if we add new calls to getBlockValue in otherwise reasonable places.

Note that this change is not NFC.  Specifically:
1) The result returned through getValueAt will now be more precise.  In principle, this could trigger any latent infinite optimization loops in callers, but in practice, we're unlikely to see this.
2) The result returned through getBlockValueAt is potentially weakened for non-constants that were previously queried.  With the old code, you had the possibility that a later query might bypass the cache and discover some information the original query did not.  I can't find a scenario which actually causes this to happen, but it was in principle possible.  On the other hand, this may end up reducing compile time when the same value is queried repeatedly.

llvm-svn: 260439

8 years ago[WebAssembly] Re-triage list of compilation failures for torture tests
Derek Schuff [Wed, 10 Feb 2016 21:43:16 +0000 (21:43 +0000)]
[WebAssembly] Re-triage list of compilation failures for torture tests

llvm-svn: 260438

8 years agoUse ArrayRef instead of deep copies of CompactUnwindEntries. NFC.
Pete Cooper [Wed, 10 Feb 2016 21:32:24 +0000 (21:32 +0000)]
Use ArrayRef instead of deep copies of CompactUnwindEntries.  NFC.

We have a vector of all of the compact unwind entries anyway, and
its live as long as we need it to be.  So instead of copying from that
vector to another, just take references to the range of the original vector
we need for each compact unwind page.

llvm-svn: 260437

8 years agoNo reason for these two letters to be uppercase
Enrico Granata [Wed, 10 Feb 2016 21:30:20 +0000 (21:30 +0000)]
No reason for these two letters to be uppercase

llvm-svn: 260436

8 years ago[clang-cl] /Z7 now generates normal debug info, not just line info
Reid Kleckner [Wed, 10 Feb 2016 21:28:38 +0000 (21:28 +0000)]
[clang-cl] /Z7 now generates normal debug info, not just line info

Previously LLVM could not process any debug info we produced, so it
didn't make sense to spend time generating it. Now that it has primitive
support for local variable info, it does make sense to generate normal
debug info.

llvm-svn: 260435

8 years agoNow that SymbolFileDWARF supports having types in completely separate .pcm file with...
Greg Clayton [Wed, 10 Feb 2016 21:28:13 +0000 (21:28 +0000)]
Now that SymbolFileDWARF supports having types in completely separate .pcm file with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF info by looking in other DWARF files. Then if you have 1000 .o files that each reference one or more .pcm files in their debug info, a simple Module::FindTypes(...) call can end up searching the same .pcm file over and over and over. Now all internal FindTypes methods in classes (ModuleList, Module, SymbolFile) now take an extra argument:

    llvm::DenseSet<lldb_private::SymbolFile *> &searched_symbol_files

Each time a SymbolFile::FindTypes() is called, it needs to check the searched_symbol_files list to make sure it hasn't already been asked to find the type and return immediately if it has been checked. This will stop circular dependencies from also crashing LLDB during type queries.

This has proven to be an issue when debugging large applications on MacOSX that use DWARF in .o files.

<rdar://problem/24581488>

llvm-svn: 260434

8 years agoTest commit, fixed "clang" to "Clang" in docs
Mandeep Singh Grang [Wed, 10 Feb 2016 21:06:10 +0000 (21:06 +0000)]
Test commit, fixed "clang" to "Clang" in docs

Reviewers: weimingz

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D17085

llvm-svn: 260433

8 years ago[codeview] Describe int local variables using .cv_def_range
Reid Kleckner [Wed, 10 Feb 2016 20:55:49 +0000 (20:55 +0000)]
[codeview] Describe int local variables using .cv_def_range

Summary:
Refactor common value, scope, and label tracking logic out of DwarfDebug
into a common base class called DebugHandlerBase.

Update an old LLVM IR test case to avoid an assertion in LexicalScopes.

Reviewers: dblaikie, majnemer

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D16931

llvm-svn: 260432

8 years agoRecommit r260012 - Cleanup node-type handling in the unordered containers.
Eric Fiselier [Wed, 10 Feb 2016 20:46:23 +0000 (20:46 +0000)]
Recommit r260012 - Cleanup node-type handling in the unordered containers.

This time I kept <ext/hash_map> working!

This patch is the first in a series of patches that's meant to better
support unordered_map. unordered_map has a special "value_type" that
differs from pair<const Key, Value>. In order to meet the EmplaceConstructible
and CopyInsertable requirements we need to teach __hash_table about this
special value_type.

This patch creates a "__hash_node_types" traits class that contains
all of the typedefs needed by the unordered containers and it's iterators.
These typedefs include ones for each node type and  node pointer type,
as well as special typedefs for "unordered_map"'s value type.

As a result of this change all of the unordered containers now all support
incomplete types.

As a drive-by fix I changed the difference_type in __hash_table to always
be ptrdiff_t. There is a corresponding change to size_type but it cannot
take affect until an ABI break.

This patch will be followed up shortly with fixes for various unordered_map
bugs and problems.

llvm-svn: 260431

8 years ago[llvm-readobj] Option to emit readelf like output
Hemant Kulkarni [Wed, 10 Feb 2016 20:40:55 +0000 (20:40 +0000)]
[llvm-readobj] Option to emit readelf like output

New option --elf-output-style=LLVM or GNU
Enables -file-headers in readelf style when elf-output-style=GNU

Differential revision: http://reviews.llvm.org/D14128

llvm-svn: 260430

8 years ago[WebAssembly] Address comments left over from r260421
Derek Schuff [Wed, 10 Feb 2016 20:14:15 +0000 (20:14 +0000)]
[WebAssembly] Address comments left over from r260421

llvm-svn: 260429

8 years ago[Coverage] add covmap v2 binary format regression test
Xinliang David Li [Wed, 10 Feb 2016 20:14:04 +0000 (20:14 +0000)]
[Coverage] add covmap v2 binary format regression test

llvm-svn: 260428

8 years agoAMDGPU: Release the scavenged offset register during VGPR spill
Nicolai Haehnle [Wed, 10 Feb 2016 20:13:58 +0000 (20:13 +0000)]
AMDGPU: Release the scavenged offset register during VGPR spill

Summary:
This fixes a crash where subsequent spills would be unable to scavenge
a register. In particular, it fixes a crash in piglit's
spec@glsl-1.50@execution@geometry@max-input-components (the test still
has a shader that fails to compile because of too many SGPR spills, but
at least it doesn't crash any more).

This is a candidate for the release branch.

Reviewers: arsenm, tstellarAMD

Subscribers: qcolombet, arsenm

Differential Revision: http://reviews.llvm.org/D16558

llvm-svn: 260427

8 years ago[x86] refactor masked load/store combine logic ; NFCI
Sanjay Patel [Wed, 10 Feb 2016 20:02:45 +0000 (20:02 +0000)]
[x86] refactor masked load/store combine logic ; NFCI

llvm-svn: 260426

8 years agoDon't assume that there is only one strchr overload in the global namespace;
Richard Smith [Wed, 10 Feb 2016 20:02:04 +0000 (20:02 +0000)]
Don't assume that there is only one strchr overload in the global namespace;
that's not true in general. Instead, use a preference order to pick the
standard C++ signature 'char*(char*, int)' where possible and fall back to the
C signature 'char*(const char*, int)' only when it's unavailable.

llvm-svn: 260425

8 years ago[ELF][MIPS] Add lazy relocation support for MIPS
Simon Atanasyan [Wed, 10 Feb 2016 19:57:19 +0000 (19:57 +0000)]
[ELF][MIPS] Add lazy relocation support for MIPS

The patch adds lazy relocation support for MIPS and R_MIPS_26 relocation
handing.

R_MIPS_26 relocation might require PLT entry creation. In that case it
is fully supported by the patch. But if the relocation target is a local
symbol we need to use a different expression to calculate the relocation
result. This case is not implemented yet because there is no method to
get know the kind of relocation target in the `relocateOne` routine.

Differential Revision: http://reviews.llvm.org/D16982

llvm-svn: 260424

8 years agoRemove skipUnlessListedRemote.
Zachary Turner [Wed, 10 Feb 2016 19:53:45 +0000 (19:53 +0000)]
Remove skipUnlessListedRemote.

This was supposed to have been removed but made it back in
accidentally.

llvm-svn: 260423

8 years agoRemove expectedFailureLinux decorator.
Zachary Turner [Wed, 10 Feb 2016 19:53:36 +0000 (19:53 +0000)]
Remove expectedFailureLinux decorator.

llvm-svn: 260422

8 years ago[WebAssembly] Switch varags calling convention to use a register
Derek Schuff [Wed, 10 Feb 2016 19:51:04 +0000 (19:51 +0000)]
[WebAssembly] Switch varags calling convention to use a register

Instead of passing varargs directly on the user stack, allocate a buffer in
the caller's stack frame and pass a pointer to it. This simplifies the C
ABI (e.g. non-C callers of C functions do not need to use C's user stack if
they have their own mechanism) and allows further optimizations in the future
(e.g. fewer functions may need to use the stack).

Differential Revision: http://reviews.llvm.org/D17048

llvm-svn: 260421

8 years ago[analyzer] Windows: launch scan-build from an arbitrary location.
Anton Yartsev [Wed, 10 Feb 2016 19:46:41 +0000 (19:46 +0000)]
[analyzer] Windows: launch scan-build from an arbitrary location.

The following batch files allow to launch scan-build from an arbitrary location if path to clang\tools\scan-build-py\bin is added to %PATH%.

llvm-svn: 260420

8 years ago[AArch64] Refactor is logic into a helper function. NFC.
Chad Rosier [Wed, 10 Feb 2016 19:45:48 +0000 (19:45 +0000)]
[AArch64] Refactor is logic into a helper function.  NFC.

llvm-svn: 260419

8 years agoFix a -Wsign-compare in Support Path unittests
Reid Kleckner [Wed, 10 Feb 2016 19:29:01 +0000 (19:29 +0000)]
Fix a -Wsign-compare in Support Path unittests

llvm-svn: 260418

8 years agoSilence MSVC warning about falling off the end of a function after a fully covered...
Reid Kleckner [Wed, 10 Feb 2016 19:28:13 +0000 (19:28 +0000)]
Silence MSVC warning about falling off the end of a function after a fully covered switch

llvm-svn: 260417

8 years agoDisable MSVC 2015's warning about zero extending after ~ and others
Reid Kleckner [Wed, 10 Feb 2016 19:25:51 +0000 (19:25 +0000)]
Disable MSVC 2015's warning about zero extending after ~ and others

Very often in LLVM we have APIs that take a bitwidth and a uint64_t that
we pass immediates such as ~0U to. Consider APInt, Constant, and
MachineInstrBuilder::addImm. Fixing all uses of these APIs to manually
extend their arguments to uint64_t doesn't seem worth it.

llvm-svn: 260416

8 years agoFix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.
Eugene Zelenko [Wed, 10 Feb 2016 19:11:58 +0000 (19:11 +0000)]
Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Differential revision: http://reviews.llvm.org/D17060

llvm-svn: 260414

8 years agoSilence some MSVC warnings about zero extending unsigned to void*
Reid Kleckner [Wed, 10 Feb 2016 19:11:15 +0000 (19:11 +0000)]
Silence some MSVC warnings about zero extending unsigned to void*

llvm-svn: 260413

8 years agoRevert "[ThinLTO] Use MD5 hash in function index." due to bot failure
Teresa Johnson [Wed, 10 Feb 2016 19:11:15 +0000 (19:11 +0000)]
Revert "[ThinLTO] Use MD5 hash in function index." due to bot failure

This reverts commit r260408. Bot failure that I need to investigate.

llvm-svn: 260412

8 years agoSilence some MSVC false positive warnings about integer zexts and falling off the...
Reid Kleckner [Wed, 10 Feb 2016 19:09:15 +0000 (19:09 +0000)]
Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch

llvm-svn: 260411

8 years agoEnable constexpr on Visual Studio 2015, add support for two equivalent attributes
Reid Kleckner [Wed, 10 Feb 2016 19:07:47 +0000 (19:07 +0000)]
Enable constexpr on Visual Studio 2015, add support for two equivalent attributes

Patch by Alexander Riccio

This patch enables `constexpr` on Visual Studio 2015 by adding `||
LLVM_MSC_PREREQ(1900)` to the preprocessor `#if` statement. Since VS2013
doesn't support `constexpr`, that's purposely excluded. The
`LLVM_CONSTEXPR` macro is used in ~25 places.

I also added the MSVC/SAL equivalent of:

  - `__attribute__((__warn_unused_result__))` as an
    `LLVM_ATTRIBUTE_UNUSED_RESULT` definition

  - `__attribute__((returns_nonnull))` as an
    `LLVM_ATTRIBUTE_RETURNS_NONNULL` definition

...in case anybody ever decides to run `/analyze` on LLVM (probably
myself, if anybody)

Reviewers: rnk, aaron.ballman

Differential Revision: http://reviews.llvm.org/D16751

llvm-svn: 260410

8 years agoFix return type of bool function
Matt Arsenault [Wed, 10 Feb 2016 19:04:12 +0000 (19:04 +0000)]
Fix return type of bool function

llvm-svn: 260409

8 years ago[ThinLTO] Use MD5 hash in function index.
Teresa Johnson [Wed, 10 Feb 2016 18:57:54 +0000 (18:57 +0000)]
[ThinLTO] Use MD5 hash in function index.

Summary:
This patch uses the lower 64-bits of the MD5 hash of a function name as
a GUID in the function index, instead of storing function names. Any
local functions are first given a global name by prepending the original
source file name. This is the same naming scheme and GUID used by PGO in
the indexed profile format.

This change has a couple of benefits. The primary benefit is size
reduction in the combined index file, for example 483.xalancbmk's
combined index file was reduced by around 70%. It should also result in
memory savings for the index file in memory, as the in-memory map is
also indexed by the hash instead of the string.

Second, this enables integration with indirect call promotion, since the
indirect call profile targets are recorded using the same global naming
convention and hash. This will enable the function importer to easily
locate function summaries for indirect call profile targets to enable
their import and subsequent promotion.

The original source file name is recorded in the bitcode in a new
module-level record for use in the ThinLTO backend pipeline.

Reviewers: davidxl, joker.eph

Subscribers: llvm-commits, joker.eph

Differential Revision: http://reviews.llvm.org/D17028

llvm-svn: 260408

8 years ago[ADT] Add "return *this;" to PointerEmbeddedInt::operator=.
Jordan Rose [Wed, 10 Feb 2016 18:54:41 +0000 (18:54 +0000)]
[ADT] Add "return *this;" to PointerEmbeddedInt::operator=.

llvm-svn: 260407

8 years ago[AArch64] Update comment to match reality. NFC.
Chad Rosier [Wed, 10 Feb 2016 18:49:28 +0000 (18:49 +0000)]
[AArch64] Update comment to match reality. NFC.

llvm-svn: 260406

8 years agoDisable the new Orc lazy JIT tests on Windows, they do not pass
Reid Kleckner [Wed, 10 Feb 2016 18:46:42 +0000 (18:46 +0000)]
Disable the new Orc lazy JIT tests on Windows, they do not pass

llvm-svn: 260405

8 years agoSelectionDAG: Make Properties a field of SDPatternOperator
Matt Arsenault [Wed, 10 Feb 2016 18:40:04 +0000 (18:40 +0000)]
SelectionDAG: Make Properties a field of SDPatternOperator

Currently you can't specify node properties like commutativity on
a PatFrag. If you want to create a PatFrag on a commutative node
with a hasOneUse predicate, this enables you to specify that the
PatFrag is also commutable.

llvm-svn: 260404

8 years agoSelectionDAG: Make min/max commutative and associative
Matt Arsenault [Wed, 10 Feb 2016 18:39:57 +0000 (18:39 +0000)]
SelectionDAG: Make min/max commutative and associative

llvm-svn: 260403

8 years agoRollback 260394 -- 32bit test needs more config support
Xinliang David Li [Wed, 10 Feb 2016 18:38:27 +0000 (18:38 +0000)]
Rollback 260394 -- 32bit test needs more config support

llvm-svn: 260402

8 years ago[MC] Merge VK_PPC_TPREL in to generic VK_TPREL.
Colin LeMahieu [Wed, 10 Feb 2016 18:32:01 +0000 (18:32 +0000)]
[MC] Merge VK_PPC_TPREL in to generic VK_TPREL.

Differential Revision: http://reviews.llvm.org/D17038

llvm-svn: 260401

8 years ago[PGO] Indirect-call profile annotation in IR level profiling
Rong Xu [Wed, 10 Feb 2016 18:24:45 +0000 (18:24 +0000)]
[PGO] Indirect-call profile annotation in IR level profiling

This patch reads the indirect-call value records in the profile and makes the
annotation in the indirect-call instruction. This is for IR level profile
instrumentation.

Differential Revision: http://reviews.llvm.org/D16935

llvm-svn: 260400

8 years agoAMDGPU: Fix indentation and variable names
Matt Arsenault [Wed, 10 Feb 2016 18:21:45 +0000 (18:21 +0000)]
AMDGPU: Fix indentation and variable names

llvm-svn: 260399

8 years agoAMDGPU: Split R600 and SI load lowering
Matt Arsenault [Wed, 10 Feb 2016 18:21:39 +0000 (18:21 +0000)]
AMDGPU: Split R600 and SI load lowering

These weren't actually sharing anything in the common
LowerLOAD.

llvm-svn: 260398

8 years agoRevert "[llvm-readobj] Option to emit readelf like output"
Hemant Kulkarni [Wed, 10 Feb 2016 18:21:01 +0000 (18:21 +0000)]
Revert "[llvm-readobj] Option to emit readelf like output"

This reverts commit a58765909660a7195b32e0cc8c7476168b913750.

llvm-svn: 260397

8 years ago[pdbdump] Fix test for different type ordering with DIA 2015
Reid Kleckner [Wed, 10 Feb 2016 18:17:17 +0000 (18:17 +0000)]
[pdbdump] Fix test for different type ordering with DIA 2015

llvm-svn: 260396

8 years ago[ThinLTO] Move global processing from Linker to TransformUtils (NFC)
Teresa Johnson [Wed, 10 Feb 2016 18:11:31 +0000 (18:11 +0000)]
[ThinLTO] Move global processing from Linker to TransformUtils (NFC)

Summary:
As discussed on IRC, move the ThinLTOGlobalProcessing code out of
the linker, and into TransformUtils. The name of the class is changed
to FunctionImportGlobalProcessing.

Reviewers: joker.eph, rafael

Subscribers: joker.eph, llvm-commits

Differential Revision: http://reviews.llvm.org/D17081

llvm-svn: 260395

8 years agoAdd tests for -m32
Xinliang David Li [Wed, 10 Feb 2016 17:57:55 +0000 (17:57 +0000)]
Add tests for -m32

llvm-svn: 260394

8 years ago[PGO] coverage map bug with cov data produced for 32bit target
Xinliang David Li [Wed, 10 Feb 2016 17:57:08 +0000 (17:57 +0000)]
[PGO] coverage map bug with cov data produced for 32bit target

Fix the result truncation bug: [PR26560]
Test case is following (compiler-rt).

llvm-svn: 260393

8 years ago[llvm-nm] Add -radix option
Hemant Kulkarni [Wed, 10 Feb 2016 17:51:39 +0000 (17:51 +0000)]
[llvm-nm] Add -radix option

Differential Revision: http://reviews.llvm.org/D16822

llvm-svn: 260392

8 years ago[llvm-readobj] Option to emit readelf like output
Hemant Kulkarni [Wed, 10 Feb 2016 17:51:28 +0000 (17:51 +0000)]
[llvm-readobj] Option to emit readelf like output

New option --elf-output-style=LLVM or GNU
Enables -file-headers in readelf style when elf-output-style=GNU

Differential revision: http://reviews.llvm.org/D14128

llvm-svn: 260391

8 years ago[SPARC] Repair floating-point condition encodings in assembly parser.
James Y Knight [Wed, 10 Feb 2016 17:47:20 +0000 (17:47 +0000)]
[SPARC] Repair floating-point condition encodings in assembly parser.

The encodings for floating point conditions A(lways) and N(ever) were
incorrectly specified for the assembly parser, per Sparc manual v8 page
121. This change corrects that mistake.

Also, strangely, all of the branch instructions already had MC test
cases, except for the broken ones. Added the tests.

Patch by Chris Dewhurst

Differential Revision: http://reviews.llvm.org/D17074

llvm-svn: 260390

8 years agoRename a member variable to be more accurate with how it is used
Daniel Berlin [Wed, 10 Feb 2016 17:41:25 +0000 (17:41 +0000)]
Rename a member variable to be more accurate with how it is used

llvm-svn: 260389

8 years ago[MS ABI] Never reference dllimport'd vtables
David Majnemer [Wed, 10 Feb 2016 17:40:47 +0000 (17:40 +0000)]
[MS ABI] Never reference dllimport'd vtables

Referencing a dllimported vtable is impossible in a constexpr
constructor.  It would be friendlier to C++ programmers if we
synthesized a copy of the vftable which referenced imported virtual
functions.  This would let us initialize the object in a way which
preserves both the intent to import functionality from another DLL while
also making constexpr work.

Differential Revision: http://reviews.llvm.org/D17061

llvm-svn: 260388

8 years agoConstify two functions, make them accessible to unit tests
Daniel Berlin [Wed, 10 Feb 2016 17:39:43 +0000 (17:39 +0000)]
Constify two functions, make them accessible to unit tests

llvm-svn: 260387

8 years agoDisable all llvm-config tests for now, will investigate later
Ehsan Akhgari [Wed, 10 Feb 2016 17:29:50 +0000 (17:29 +0000)]
Disable all llvm-config tests for now, will investigate later

llvm-svn: 260386

8 years ago[PGO] Differentiate Clang instrumentation and IR level instrumentation profiles
Rong Xu [Wed, 10 Feb 2016 17:18:30 +0000 (17:18 +0000)]
[PGO] Differentiate Clang instrumentation and IR level instrumentation profiles

This patch uses one bit in profile version to differentiate Clang
instrumentation and IR level instrumentation profiles.

PGOInstrumenation generates a COMDAT variable __llvm_profile_raw_version so
that the compiler runtime can set the right profile kind.
For Maco-O platform, we generate the variable as linkonce_odr linkage as
COMDAT is not supported.

PGOInstrumenation now checks this bit to make sure it's an IR level
instrumentation profile.

The patch was submitted as r260164 but reverted due to a Darwin test breakage.
Original Differential Revision: http://reviews.llvm.org/D15540

Differential Revision: http://reviews.llvm.org/D17020

llvm-svn: 260385

8 years agoAdd support for R_X86_64_DTPOFF64.
Rafael Espindola [Wed, 10 Feb 2016 16:26:31 +0000 (16:26 +0000)]
Add support for R_X86_64_DTPOFF64.

It is used by clang to produce debug info for tls variables.

llvm-svn: 260384

8 years ago[AArch64] This bit of logic is specific to pairing. NFC.
Chad Rosier [Wed, 10 Feb 2016 15:52:46 +0000 (15:52 +0000)]
[AArch64] This bit of logic is specific to pairing. NFC.

llvm-svn: 260383

8 years agoFix VST_CODE_* bitcode id comments (NFC)
Teresa Johnson [Wed, 10 Feb 2016 15:02:51 +0000 (15:02 +0000)]
Fix VST_CODE_* bitcode id comments (NFC)

llvm-svn: 260382

8 years agoLimit catopen usage to unix-like OSes
Ben Craig [Wed, 10 Feb 2016 13:47:25 +0000 (13:47 +0000)]
Limit catopen usage to unix-like OSes

Operating systems that are not unix-like are unlikely to have access to
catopen. Instead of black-listing each one, we now filter out all non-unix
operating systems first. We then exclude the unix-like operating systems
that don't have catopen. _WIN32 counts as a unix-like operating system
because of cygwin.

http://reviews.llvm.org/D16639

llvm-svn: 260381

8 years agoUse a SymbolBody to represent the personality.
Rafael Espindola [Wed, 10 Feb 2016 13:19:32 +0000 (13:19 +0000)]
Use a SymbolBody to represent the personality.

NFC, just more in line with the rest of lld.

Thanks to Rui for the suggestion.

llvm-svn: 260380

8 years agoReapply the patch of r260376.
Andrey Turetskiy [Wed, 10 Feb 2016 12:56:10 +0000 (12:56 +0000)]
Reapply the patch of r260376.

llvm-svn: 260379

8 years agoclang-format sort include use the source file name to determine the
Daniel Jasper [Wed, 10 Feb 2016 12:42:58 +0000 (12:42 +0000)]
clang-format sort include use the source file name to determine the
"main include" that will be the 1st include (category 0).

Because the clang-format visual studio extension does not pass the file
name and use the standard input, sort include cannot find a "main
include":

Testing fix on llvm\tools\clang\lib\Format\Format.cpp:
Original file:
  #include "clang/Format/Format.h"
  ...
  #include "clang/Basic/SourceManager.h"
  #include "clang/Lex/Lexer.h"

Without fix, selecting the includes and running visual studio
clang-format:
  ...
  #include "clang/Basic/SourceManager.h"
  #include "clang/Format/Format.h"
  #include "clang/Lex/Lexer.h"

With fix, selecting the includes and running visual studio clang-format:
  #include "clang/Format/Format.h"
  ...
  #include "clang/Basic/SourceManager.h"
  #include "clang/Lex/Lexer.h"

Test 2 with main header not at the start:
Original file:
  ...
  #include "clang/Format/Format.h"
  #include "clang/Basic/SourceManager.h"
  #include "clang/Lex/Lexer.h"

Without fix, selecting the includes and running visual studio
clang-format:
  ...
  #include "clang/Basic/SourceManager.h"
  #include "clang/Format/Format.h"
  #include "clang/Lex/Lexer.h"

With fix, selecting the includes and running visual studio clang-format:
  #include "clang/Format/Format.h"
  ...
  #include "clang/Basic/SourceManager.h"
  #include "clang/Lex/Lexer.h"

Patch by Jean-Philippe Dufraigne, thank you.
Review: http://reviews.llvm.org/D16524

llvm-svn: 260378

8 years agoRevert "Improve the handling of missing elf symtab and missing symbol sizes"
Tamas Berghammer [Wed, 10 Feb 2016 12:10:58 +0000 (12:10 +0000)]
Revert "Improve the handling of missing elf symtab and missing symbol sizes"

This reverts commit 252dda67782f2cbf838e375bce21ed4191f6d9ce.

The commit caused several test failure on the OSX build bot.

llvm-svn: 260377

8 years ago[X86] Fix stack alignment for MCU target (Clang part), by Anton Nadolskiy.
Andrey Turetskiy [Wed, 10 Feb 2016 11:58:46 +0000 (11:58 +0000)]
[X86] Fix stack alignment for MCU target (Clang part), by Anton Nadolskiy.

This patch fixes stack alignments for MCU (should be aligned to 4 bytes).

Differential Revision: http://reviews.llvm.org/D15647

llvm-svn: 260376

8 years ago[X86] Fix stack alignment for MCU target, by Anton Nadolskiy.
Andrey Turetskiy [Wed, 10 Feb 2016 11:57:06 +0000 (11:57 +0000)]
[X86] Fix stack alignment for MCU target, by Anton Nadolskiy.

This patch fixes stack alignments for MCU (should be aligned to 4 bytes).

Differential Revision: http://reviews.llvm.org/D15646

llvm-svn: 260375

8 years ago[OPENMP 4.5] Initial support for data members in 'firstprivate' clause.
Alexey Bataev [Wed, 10 Feb 2016 11:29:16 +0000 (11:29 +0000)]
[OPENMP 4.5] Initial support for data members in 'firstprivate' clause.
OpenMP 4.5 allows privatization of non-static data members of current
class in non-static member functions.

llvm-svn: 260374

8 years agoFix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type.
Denis Zobnin [Wed, 10 Feb 2016 11:23:48 +0000 (11:23 +0000)]
Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type.

This patch is to upgrade FunctionTypeUnwrapper for correct processing of
AttributedType. Fixes PR25786.
Patch by Alexander Makarov.

Differential Revision: http://reviews.llvm.org/D15373

llvm-svn: 260373

8 years ago[RenderScript] Refactor allocation expressions
Ewan Crawford [Wed, 10 Feb 2016 11:23:27 +0000 (11:23 +0000)]
[RenderScript] Refactor allocation expressions

Patch refractors RS plugin code specifying how format strings are used to JIT the runtime.

Author: Dean De Leo <dean@codeplay.com>
llvm-svn: 260372