reed@google.com [Mon, 10 Dec 2012 17:39:36 +0000 (17:39 +0000)]
optimize for paints that don't require deep copy during clone
Review URL: https://codereview.appspot.com/6903062
git-svn-id: http://skia.googlecode.com/svn/trunk@6739
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 10 Dec 2012 17:32:07 +0000 (17:32 +0000)]
Disable failing test on android.
Review URL: https://codereview.appspot.com/6899059
git-svn-id: http://skia.googlecode.com/svn/trunk@6738
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Dec 2012 16:10:33 +0000 (16:10 +0000)]
mark our unflattened bitmap as immutable (just as picture deserialization does)
git-svn-id: http://skia.googlecode.com/svn/trunk@6736
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Dec 2012 16:05:09 +0000 (16:05 +0000)]
add '--mode clone' option to bench_pictures
git-svn-id: http://skia.googlecode.com/svn/trunk@6735
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Dec 2012 15:50:37 +0000 (15:50 +0000)]
don't convert clipPath -> clipRect if the path is inverse-filled
git-svn-id: http://skia.googlecode.com/svn/trunk@6734
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 10 Dec 2012 15:40:55 +0000 (15:40 +0000)]
In SKP serialization, use existing encoded data.
If an SkBitmap has encoded data, write that during serialization
rather than reencoding it.
Add a test to ensure that this does not modify the output stream,
so the reader need not know the difference.
Review URL: https://codereview.appspot.com/6884054
git-svn-id: http://skia.googlecode.com/svn/trunk@6732
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 10 Dec 2012 14:57:54 +0000 (14:57 +0000)]
Fixing SkClipStack::clipDevPath so that it will not convert rectangular paths to rectangle clips if inverse fill.
BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test ClipStackTest/test_rect_inverse_fill
Review URL: https://codereview.appspot.com/6880044
git-svn-id: http://skia.googlecode.com/svn/trunk@6731
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 10 Dec 2012 14:50:04 +0000 (14:50 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6730
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 10 Dec 2012 14:12:55 +0000 (14:12 +0000)]
Reapply (r6718) with fix for compiler error on linux.
git-svn-id: http://skia.googlecode.com/svn/trunk@6729
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 10 Dec 2012 14:10:20 +0000 (14:10 +0000)]
revert Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
git-svn-id: http://skia.googlecode.com/svn/trunk@6728
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 10 Dec 2012 13:55:02 +0000 (13:55 +0000)]
Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
This reverts r5378.
Review URL: https://codereview.appspot.com/6815056
git-svn-id: http://skia.googlecode.com/svn/trunk@6727
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 10 Dec 2012 12:50:53 +0000 (12:50 +0000)]
shape ops work in progress
rewrite binary edge inclusion lookup
fix warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@6726
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 10 Dec 2012 03:27:47 +0000 (03:27 +0000)]
add helpers for isTranslate and isScaleTranslate
special-case determinant for isScaleTranslate
git-svn-id: http://skia.googlecode.com/svn/trunk@6725
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 8 Dec 2012 02:01:38 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6721
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 7 Dec 2012 22:10:39 +0000 (22:10 +0000)]
Revert "Added the following 3 features to sample app."
Review URL: https://codereview.appspot.com/6906054
git-svn-id: http://skia.googlecode.com/svn/trunk@6719
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 7 Dec 2012 21:52:34 +0000 (21:52 +0000)]
Added the following 3 features to sample app.
1) Imported SKP files can now be run using the bbox playback ('b' key)
2) Imported SKP files are displayed using their basename
3) FPS counter has been updated to print time to draw all tiles
Review URL: https://codereview.appspot.com/6904057
git-svn-id: http://skia.googlecode.com/svn/trunk@6718
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 7 Dec 2012 20:56:13 +0000 (20:56 +0000)]
Update filter tool to write out paths to .cpp file
https://codereview.appspot.com/6843125/
git-svn-id: http://skia.googlecode.com/svn/trunk@6714
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 7 Dec 2012 20:48:56 +0000 (20:48 +0000)]
Make debugger profiling honor deleted commands
https://codereview.appspot.com/6906043/
git-svn-id: http://skia.googlecode.com/svn/trunk@6713
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Dec 2012 20:43:52 +0000 (20:43 +0000)]
Improve handling of inverse clip paths in GrClipMaskManager.
Will require rebaselining of complexclip_aa and complexclip_aa_layer on GPU.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6907052
git-svn-id: http://skia.googlecode.com/svn/trunk@6712
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 7 Dec 2012 19:14:45 +0000 (19:14 +0000)]
Fix some extract subset bugs.
In SkBitmap::extractSubset, perform a deepCopy, if the pixelRef supports it.
Fixes a bug in the 'extractbitmap' gm, which attempts to draw a subset of a texture backed bitmap (if the canvas is really an SkGpuCanvas).
Also fix some bugs that happen when there is a pixel offset. These fixes get bypassed by the deepCopy, but a user can still set a pixel offset manually.
When copying GPU backed bitmap with a pixel offset, copy the offset.
If the new config is the same as the old, copy fRowBytes as well.
Add a function to SkBitmap.cpp (getUpperLeftFromOffset) to find the x,y coordinate to use when copying to a new config.
Fix a bug where readPixels copied to the correct desired config and we were setting the generation ID to match even though the desired config was not the same as the original config (caught by my new tests!).
Add some tests to verify the correct behavior.
Review URL: https://codereview.appspot.com/6839043
git-svn-id: http://skia.googlecode.com/svn/trunk@6710
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 7 Dec 2012 19:06:11 +0000 (19:06 +0000)]
utils.gyp: add SkCityHash.h, delete SkConsistentChecksum.h
Review URL: https://codereview.appspot.com/6906050
git-svn-id: http://skia.googlecode.com/svn/trunk@6709
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Dec 2012 17:48:04 +0000 (17:48 +0000)]
speedup peek32() when the offset is in the last block (fTail)
Review URL: https://codereview.appspot.com/6906047
git-svn-id: http://skia.googlecode.com/svn/trunk@6708
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 7 Dec 2012 17:19:07 +0000 (17:19 +0000)]
Rebaseline script: check for .git and .svn in the current directory as well. Add mesa to list of configs to update.
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6908050
git-svn-id: http://skia.googlecode.com/svn/trunk@6707
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Dec 2012 17:14:40 +0000 (17:14 +0000)]
cache fontmetrics in picture-record
Review URL: https://codereview.appspot.com/6908049
git-svn-id: http://skia.googlecode.com/svn/trunk@6706
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 7 Dec 2012 16:30:31 +0000 (16:30 +0000)]
add cityhash to SVN dependencies, not just DEPS file
git-svn-id: http://skia.googlecode.com/svn/trunk@6705
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 7 Dec 2012 15:54:01 +0000 (15:54 +0000)]
Mark 64-bit constants as ULL to fix broken 32-bit Mac 10.6 build
TBR=bungeman
Review URL: https://codereview.appspot.com/6867079
git-svn-id: http://skia.googlecode.com/svn/trunk@6704
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Dec 2012 15:53:49 +0000 (15:53 +0000)]
mark bitmaps as immutable as we deserialize them into picture-playback
Review URL: https://codereview.appspot.com/6900045
git-svn-id: http://skia.googlecode.com/svn/trunk@6703
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 7 Dec 2012 15:27:27 +0000 (15:27 +0000)]
comment-only fix
git-svn-id: http://skia.googlecode.com/svn/trunk@6702
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 7 Dec 2012 15:12:01 +0000 (15:12 +0000)]
Replace SkConsistentChecksum with SkCityHash (now including CityHash via DEPS)
Alternative to https://codereview.appspot.com/6847087/ ('Change SkConsistentChecksum to use SuperFastHash')
Review URL: https://codereview.appspot.com/6867060
git-svn-id: http://skia.googlecode.com/svn/trunk@6701
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 7 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6699
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@google.com [Thu, 6 Dec 2012 21:47:40 +0000 (21:47 +0000)]
Defining new color constat for transparent color
Review URL: https://codereview.appspot.com/6901044
git-svn-id: http://skia.googlecode.com/svn/trunk@6696
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 6 Dec 2012 21:47:48 +0000 (21:47 +0000)]
shape ops work in progress
overhaul coincident handling
git-svn-id: http://skia.googlecode.com/svn/trunk@6695
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 6 Dec 2012 20:58:57 +0000 (20:58 +0000)]
Use ReduceClipStack in ClipMaskManager.
R=robertphillips@google.com
This will require some gpu rebaselining (complexclip_rect_aa, complexclip_aa, aaclip, simpleaaclip, complexclip_aa_layer)xy
Review URL: https://codereview.appspot.com/6884051
git-svn-id: http://skia.googlecode.com/svn/trunk@6694
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 6 Dec 2012 20:13:11 +0000 (20:13 +0000)]
As part of preliminary groundwork for a chromium fix, this changelist is deprecating GrPathFill so that SkPath::FillType is used everywhere in order to remove some code duplication between Skia and Ganesh.
BUG=chromium:135111
TEST=Try path rendering tests from the gm
Review URL: https://codereview.appspot.com/6875058
git-svn-id: http://skia.googlecode.com/svn/trunk@6693
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 6 Dec 2012 19:16:36 +0000 (19:16 +0000)]
No longer generating 4444, remove from rebaseline tool.
https://codereview.appspot.com/6886048/
git-svn-id: http://skia.googlecode.com/svn/trunk@6692
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 6 Dec 2012 14:26:02 +0000 (14:26 +0000)]
add query to pixelref for its encoded data (if it has any)
Review URL: https://codereview.appspot.com/6891047
git-svn-id: http://skia.googlecode.com/svn/trunk@6689
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 6 Dec 2012 14:23:20 +0000 (14:23 +0000)]
Make the clip reducer operate on int rects. Remove redundant Gr from func
name.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6890045
git-svn-id: http://skia.googlecode.com/svn/trunk@6688
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 6 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6687
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 5 Dec 2012 22:26:11 +0000 (22:26 +0000)]
Move GrReducedClip to its own files.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6891045
git-svn-id: http://skia.googlecode.com/svn/trunk@6686
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 5 Dec 2012 22:13:59 +0000 (22:13 +0000)]
optimize translate and scale
add map2() to optimize for mapping an array of 2D points into homogeneous 4-vector
Review URL: https://codereview.appspot.com/6874064
git-svn-id: http://skia.googlecode.com/svn/trunk@6685
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 5 Dec 2012 20:30:00 +0000 (20:30 +0000)]
Add newline at end of tools/skdiff_html.h to happify the housekeeping bot
TBR=bungeman
Review URL: https://codereview.appspot.com/6893043
git-svn-id: http://skia.googlecode.com/svn/trunk@6684
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 5 Dec 2012 20:21:35 +0000 (20:21 +0000)]
Add script to help rebaseline gm self-tests, and run it right now
BUG=https://code.google.com/p/skia/issues/detail?id=995
TBR=rmistry
Review URL: https://codereview.appspot.com/6887046
git-svn-id: http://skia.googlecode.com/svn/trunk@6683
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 5 Dec 2012 20:13:26 +0000 (20:13 +0000)]
Delete no-longer-expected 4444 output images from gm self-test
git-svn-id: http://skia.googlecode.com/svn/trunk@6682
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 5 Dec 2012 20:13:12 +0000 (20:13 +0000)]
Update skdiff.
https://codereview.appspot.com/6850115/
git-svn-id: http://skia.googlecode.com/svn/trunk@6681
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 5 Dec 2012 20:11:43 +0000 (20:11 +0000)]
Delete no-longer-used 4444 gm-selftest input images
git-svn-id: http://skia.googlecode.com/svn/trunk@6680
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 5 Dec 2012 19:34:33 +0000 (19:34 +0000)]
Add display of a path's filltype to debugger
https://codereview.appspot.com/6887044/
git-svn-id: http://skia.googlecode.com/svn/trunk@6679
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 5 Dec 2012 19:07:21 +0000 (19:07 +0000)]
Add drawPoints dash bench
https://codereview.appspot.com/6866053/
git-svn-id: http://skia.googlecode.com/svn/trunk@6678
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 5 Dec 2012 15:32:35 +0000 (15:32 +0000)]
Clean up SkFontHost_mac_coretext.
https://codereview.appspot.com/6843087/
git-svn-id: http://skia.googlecode.com/svn/trunk@6676
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 5 Dec 2012 14:56:08 +0000 (14:56 +0000)]
The goal is to make the ClangCompile buildstep in the Housekeeping bot turn red if there is a warning.
Review URL: https://codereview.appspot.com/6868055
git-svn-id: http://skia.googlecode.com/svn/trunk@6674
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 5 Dec 2012 14:51:39 +0000 (14:51 +0000)]
Add operator delete to match operator new for SkTLList.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871061
git-svn-id: http://skia.googlecode.com/svn/trunk@6673
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 5 Dec 2012 06:15:42 +0000 (06:15 +0000)]
Add missing SK_API definition at request of Chromium callers
Review URL: https://codereview.appspot.com/6878050
git-svn-id: http://skia.googlecode.com/svn/trunk@6671
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 5 Dec 2012 05:34:51 +0000 (05:34 +0000)]
add test for adding outer contour first and second
git-svn-id: http://skia.googlecode.com/svn/trunk@6670
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 5 Dec 2012 02:01:21 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6669
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 4 Dec 2012 22:52:28 +0000 (22:52 +0000)]
add gm/pathinterior.cpp in advance of cary's path api
git-svn-id: http://skia.googlecode.com/svn/trunk@6668
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 4 Dec 2012 20:34:11 +0000 (20:34 +0000)]
Expand dashing3 GM to include additional dashing cases
https://codereview.appspot.com/6870056/
git-svn-id: http://skia.googlecode.com/svn/trunk@6667
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 15:22:12 +0000 (15:22 +0000)]
Make GrReduceClipStack use a caller provided query rect rather than return a
bounds.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6865059
git-svn-id: http://skia.googlecode.com/svn/trunk@6665
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 4 Dec 2012 15:08:56 +0000 (15:08 +0000)]
Handle recording a bitmap if copy fails.
If SkBitmapHeap::insert() returns INVALID_SLOT, assert at picture
record time so we can debug, but allow it to continue in release
mode, so that we can still capture a picture. At playback time,
print a message so we know that there was an error.
Review URL: https://codereview.appspot.com/6873050
git-svn-id: http://skia.googlecode.com/svn/trunk@6664
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 14:48:57 +0000 (14:48 +0000)]
Fix stale iterators in LList test. Add newline to end of SkTLList.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6663
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Dec 2012 14:18:50 +0000 (14:18 +0000)]
Pull SkMergeImageFilter out into its own file.
Review URL: https://codereview.appspot.com/6873052
git-svn-id: http://skia.googlecode.com/svn/trunk@6662
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 14:06:06 +0000 (14:06 +0000)]
Make SkClipStack::Iter use SkClipStack::Element.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871051
git-svn-id: http://skia.googlecode.com/svn/trunk@6661
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 4 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6660
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 3 Dec 2012 23:34:32 +0000 (23:34 +0000)]
Fix compiler error in SkTInternalList.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6659
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 22:52:30 +0000 (22:52 +0000)]
Provide default guess at font type in Mac CoreText font host, since CT's detection is unreliable.
git-svn-id: http://skia.googlecode.com/svn/trunk@6658
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 22:45:10 +0000 (22:45 +0000)]
The short version of the 'loca' table stores offsets divided by 2.
git-svn-id: http://skia.googlecode.com/svn/trunk@6657
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 3 Dec 2012 21:38:58 +0000 (21:38 +0000)]
Added SK_BUILD_FOR_NACL to SkPreConfig.h
Submitted on behalf of bmilnor@
git-svn-id: http://skia.googlecode.com/svn/trunk@6656
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 3 Dec 2012 21:19:52 +0000 (21:19 +0000)]
add getTypes() to SkMatrix44, to cache how complex the matrix is.
add bench
optimize operator== by performing 4 compares in a row before checking
optimize setconcat by noting when we can write the answer directly into this
At least on this macbook, I had to mark helpers like isIdentity() as inline to get them inlined.
Review URL: https://codereview.appspot.com/6863053
git-svn-id: http://skia.googlecode.com/svn/trunk@6655
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:47:41 +0000 (19:47 +0000)]
Reland r6649 with fix for build errors.
git-svn-id: http://skia.googlecode.com/svn/trunk@6653
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:18:57 +0000 (19:18 +0000)]
Revert 6649 due to build breaks.
git-svn-id: http://skia.googlecode.com/svn/trunk@6651
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 19:16:59 +0000 (19:16 +0000)]
Templatize AutoCFRelease and use it.
https://codereview.appspot.com/6855113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6650
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:05:44 +0000 (19:05 +0000)]
Insert in middle of SkTInternalLList and SkTLList, in place cons for
SkTLList.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6870050
git-svn-id: http://skia.googlecode.com/svn/trunk@6649
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 18:01:45 +0000 (18:01 +0000)]
Add SkTLList, linked list class implemented on top of the internal llist class.
R=robertphillips@google.com
Committed: https://code.google.com/p/skia/source/detail?r=6644
Review URL: https://codereview.appspot.com/6869049
git-svn-id: http://skia.googlecode.com/svn/trunk@6647
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 3 Dec 2012 17:35:19 +0000 (17:35 +0000)]
Fixed remaining clang compiler warnings
https://codereview.appspot.com/6865053/
git-svn-id: http://skia.googlecode.com/svn/trunk@6646
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 15:59:52 +0000 (15:59 +0000)]
Revert change accidentally committed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6645
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 15:54:12 +0000 (15:54 +0000)]
Add SkTLList, linked list class implemented on top of the internal llist class.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6869049
git-svn-id: http://skia.googlecode.com/svn/trunk@6644
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 14:54:59 +0000 (14:54 +0000)]
Rename SkTDLinkedList to SkTInternalLinked list, add some methods useful for forthcoming SkTLList.
Review URL: https://codereview.appspot.com/6858101
git-svn-id: http://skia.googlecode.com/svn/trunk@6643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Mon, 3 Dec 2012 14:38:08 +0000 (14:38 +0000)]
Fix clang 'overloaded-virtual' warnings.
This patch fixes the warning like the following:
../../src/animator/SkPaintParts.h:26:18: warning: 'SkPaintPart::add' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool add() = 0;
^
../../src/animator/SkDisplayable.h:35:18: note: hidden overloaded virtual function 'SkDisplayable::add' declared here
virtual bool add(SkAnimateMaker& , SkDisplayable* child);
^
R=robertphillips@google.com,
Review URL: https://codereview.appspot.com/6843134
git-svn-id: http://skia.googlecode.com/svn/trunk@6642
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 3 Dec 2012 11:41:21 +0000 (11:41 +0000)]
Tweak an enum declaration to make the clang compiler happy.
This exposes our "unknown type" to users, which is a loss of encapsulation.
TBR=robertphillips
http://codereview.appspot.com/6865050/
git-svn-id: http://skia.googlecode.com/svn/trunk@6641
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 1 Dec 2012 02:26:53 +0000 (02:26 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6640
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 30 Nov 2012 21:30:42 +0000 (21:30 +0000)]
Create aliases AddRef() and Release() to SkRefCnt for compatibility with scoped_refptr
Review URL: https://codereview.appspot.com/6844116
git-svn-id: http://skia.googlecode.com/svn/trunk@6639
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 30 Nov 2012 16:19:32 +0000 (16:19 +0000)]
Disabling validation of the glyph cache for standard debug builds.
The validation step is adding 50% overhead to the rendering of
text heavy SkPicture files.
Review URL: https://codereview.appspot.com/6856123
git-svn-id: http://skia.googlecode.com/svn/trunk@6635
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 30 Nov 2012 15:26:04 +0000 (15:26 +0000)]
Add auto table ref for coretext.
https://codereview.appspot.com/6849117/
git-svn-id: http://skia.googlecode.com/svn/trunk@6634
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Fri, 30 Nov 2012 04:42:59 +0000 (04:42 +0000)]
Adds BENCH_ALLOWED_NOISE to widen expected bench ranges.
This is especially useful for benches with small absolute value.
Review URL: https://codereview.appspot.com/6842112
git-svn-id: http://skia.googlecode.com/svn/trunk@6633
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 30 Nov 2012 02:01:24 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6632
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 30 Nov 2012 00:38:29 +0000 (00:38 +0000)]
Fix for roll-blocking compiler error in SkRRect.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@6630
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 22:39:10 +0000 (22:39 +0000)]
Clean up some Windows compiler warnings.
Review URL: https://codereview.appspot.com/6844111
git-svn-id: http://skia.googlecode.com/svn/trunk@6628
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 21:50:34 +0000 (21:50 +0000)]
rebaseline.py: Allow multiple testnames on the command line.
Review URL: https://codereview.appspot.com/6856118
git-svn-id: http://skia.googlecode.com/svn/trunk@6623
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:21:54 +0000 (21:21 +0000)]
remove 4444 support (for now) form gm -- not used (afaik) and slows us down
Review URL: https://codereview.appspot.com/6782137
git-svn-id: http://skia.googlecode.com/svn/trunk@6622
2bbb7eff-a529-9590-31e7-
b0007b416f81
jamesr@chromium.org [Thu, 29 Nov 2012 21:17:16 +0000 (21:17 +0000)]
Keep track of identity SkMatrix44s
This keeps a bool on SkMatrix44 indicating if we know for sure that the matrix
is identity, similar to the TypeMask on SkMatrix. This is useful to early-out
of potentially expensive matrix math at the cost of some memory.
Review URL: https://codereview.appspot.com/6854113
git-svn-id: http://skia.googlecode.com/svn/trunk@6620
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:14:59 +0000 (21:14 +0000)]
Remove SkClipStack::Iter::combinedNext.
Review URL: https://codereview.appspot.com/6844114
git-svn-id: http://skia.googlecode.com/svn/trunk@6619
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 29 Nov 2012 21:05:37 +0000 (21:05 +0000)]
Create a factory to decode an SkBitmap from an SkData.
Add a test and a GM for the factory, and a PNG file for it to decode.
The PNG file is copyright-free, obtained from
http://openclipart.org/detail/29213/paper-plane-by-ddoo
In cmykjpeg, do not attempt to decode in the constructor, since it
currently crashes on Mac (if you provide the correct resource path).
Even when we fix this crash there is no need to do it in the
constructor, since we create all of the gms in order to
get their names (to determine whether to run them).
Review URL: https://codereview.appspot.com/6847122
git-svn-id: http://skia.googlecode.com/svn/trunk@6618
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:05:13 +0000 (21:05 +0000)]
Make SkClipStack::Element public.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6858096
git-svn-id: http://skia.googlecode.com/svn/trunk@6617
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:01:00 +0000 (21:01 +0000)]
use fast-pt case when radius <= 1/2, instead of just hairlines
Review URL: https://codereview.appspot.com/6854116
git-svn-id: http://skia.googlecode.com/svn/trunk@6616
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:00:39 +0000 (21:00 +0000)]
add SkPictureUtils::GatherPixelRefs()
Review URL: https://codereview.appspot.com/6845106
git-svn-id: http://skia.googlecode.com/svn/trunk@6615
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 19:16:32 +0000 (19:16 +0000)]
Change SkClipStack::Element::State to SkClipStack::Type, rename Comine* members to combine*
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6844113
git-svn-id: http://skia.googlecode.com/svn/trunk@6607
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 19:00:22 +0000 (19:00 +0000)]
Turn on the separable blur (release the hounds!). This will require rebaselines of the following Skia tests: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect_grad, blurrect, blurs, drawbitmapmatrix (max. pixel change in 8888 is 5).
NOTE: This will require adding SK_DISABLE_SEPARABLE_MASK_BLUR to skia.gyp on the next roll into Chrome, until the Chrome rebaselines are done.
Review URL: https://codereview.appspot.com/6845111
git-svn-id: http://skia.googlecode.com/svn/trunk@6606
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 18:58:19 +0000 (18:58 +0000)]
Rename SkClipStack::Rec to SkClipStack::Element
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6854115
git-svn-id: http://skia.googlecode.com/svn/trunk@6605
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 17:27:37 +0000 (17:27 +0000)]
Fix the gr/gl destruction order in Test.cpp
R=djsollen@google.com
Review URL: https://codereview.appspot.com/6851126
git-svn-id: http://skia.googlecode.com/svn/trunk@6602
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 17:09:27 +0000 (17:09 +0000)]
Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse. (This #ifdef will hopefully be shortlived, once Chrome has switched).
The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality. (All of these on 32bit MacPro).
Review URL: https://codereview.appspot.com/6851117
git-svn-id: http://skia.googlecode.com/svn/trunk@6601
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 16:29:58 +0000 (16:29 +0000)]
Remove legacy flag for android from tests
Review URL: https://codereview.appspot.com/6782133
git-svn-id: http://skia.googlecode.com/svn/trunk@6600
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 15:28:45 +0000 (15:28 +0000)]
Fix test app to ensure that we destroy our GPU resources.
The problem arises on devices like the Nexus 10 where we allow the
destruction of resources using the destructor of a static variable.
However, we have no guarentee that the GPU driver has not already
cleaned up it's resources prior to our static destructor.
Review URL: https://codereview.appspot.com/6851124
git-svn-id: http://skia.googlecode.com/svn/trunk@6599
2bbb7eff-a529-9590-31e7-
b0007b416f81