Sudarshan Prasad [Thu, 2 Oct 2014 20:10:10 +0000 (13:10 -0700)]
Added mechanism to set URI in the regular entity handler's request.
This allows app's entity handler to retrieve the URI of resource from a request.
Patch 2:
Addressed review comments - Added lock before map operation
Change-Id: Iaa5cad56580046bc05efc974d4a7e65213856bfd
Joseph Morrow [Wed, 1 Oct 2014 21:56:01 +0000 (17:56 -0400)]
Fixed upsets in C Stack that caused breakage in the Arduino Build.
Change-Id: I6462963404db66d9c8af7543269d02d5591c718c
Sudarshan Prasad [Wed, 1 Oct 2014 08:26:37 +0000 (01:26 -0700)]
Release notes for Sept 30, 2014 release.
Patch 2:
Review comments addressed
Change-Id: Ifa00dee2d1e79d285a35fe750a92b9cba3ebe073
Erich Keane [Wed, 1 Oct 2014 08:05:28 +0000 (01:05 -0700)]
Merge "1 Bug fix to check for length of uri and query separately. 2 Addressed the code review feedback. No longer using strtok, moved check logic to separate function. 3 Optimized the code to use strlen only once. 4. Fixed Build failure"
Vijay [Wed, 1 Oct 2014 07:49:17 +0000 (00:49 -0700)]
1 Bug fix to check for length of uri and query separately.
2 Addressed the code review feedback. No longer using strtok,
moved check logic to separate function.
3 Optimized the code to use strlen only once.
4. Fixed Build failure
Change-Id: I1d1c8ad39716a93dc32196e110d5a8f1df2ee959
Sudarshan Prasad [Wed, 1 Oct 2014 07:22:31 +0000 (00:22 -0700)]
Fix in makefile to build fridgeclient and fridgeserver samples
Change-Id: I1b42d33c6dc3b77e25579a6370b9bf8327edaa08
Sashi Penta [Wed, 1 Oct 2014 07:01:06 +0000 (00:01 -0700)]
1. Supporting POST operation in C Stack.
2. Supporting POST operation in CPP Stack.
3. Updates to C sample application
4. Rebase
5. Fixed build issue.
Change-Id: I00b70a5eb8f4c1c911416d703e3c739b2a80ff7b
William Dieter [Wed, 1 Oct 2014 03:40:19 +0000 (20:40 -0700)]
Merge "C++ programer's guide"
Yamin S Al-mousa [Wed, 1 Oct 2014 00:48:32 +0000 (17:48 -0700)]
This commit to support exposing vendor specific options to application:
1) Define a structure defining the vendor specific options
2) Pass an array of vendor specific options needed with the call to OCDoResource
3) Vendor specific header options are checked against the range of acceptable vendor specific header options
4) Vendor specific header options are added to the pdu being sent
5) Vendor specific header options are parsed and added to OCEntityHandlerRequest and OCClientResponse structs
6) Rebased on to master
7) Adding a test case to occlient for sending vendor specific option
8) Adding The number of options to be sent and the ones received, also adding this infor to OCEntityHandlerRequest and OCClientResponse structs
9) Rebased on to master
Change-Id: I5d4c56028bf510fba57ad4fc440565fd4b87ca31
Erich Keane [Wed, 1 Oct 2014 00:29:36 +0000 (17:29 -0700)]
Merge "Added URI parameter for Device Entity Handler."
Erich Keane [Tue, 30 Sep 2014 23:38:35 +0000 (16:38 -0700)]
Merge "Modified makefiles so that each makefile could build its own dependencies or build only itself. Fixed .gitignore and makefiles base on review comments. Rebased as requested by Erich. Added fix to building with boost Cleaned up .gitignore"
Thuyen Tran [Wed, 24 Sep 2014 00:00:12 +0000 (17:00 -0700)]
Modified makefiles so that each makefile could build its own dependencies or build only itself.
Fixed .gitignore and makefiles base on review comments.
Rebased as requested by Erich.
Added fix to building with boost
Cleaned up .gitignore
Change-Id: I0829400e74694f2a7f8271ea72f93e7cd7be000c
Sashi Penta [Tue, 30 Sep 2014 07:35:52 +0000 (00:35 -0700)]
Added URI parameter for Device Entity Handler.
Change-Id: If37e64f6578b6a8eccee9b9ea43690123d6ac2aa
Sashi Penta [Tue, 30 Sep 2014 08:44:54 +0000 (01:44 -0700)]
APIs to setNULL and check for NULL in OCRepresenation
Change-Id: I3db71123c1362efaf7e641a845fa737057d56da5
Erich Keane [Mon, 29 Sep 2014 23:10:24 +0000 (16:10 -0700)]
Merge "1. Default device entity handler implementation in Cpp Stack. 2. Addressed review comments."
Erich Keane [Mon, 29 Sep 2014 23:04:13 +0000 (16:04 -0700)]
Merge "IOT-36 (Leak 2) : Fixing memory leaks Patch 2 : Taking care of some review comments. Patch 3 : Update in occoaphelper.c."
Sashi Penta [Thu, 25 Sep 2014 01:48:57 +0000 (18:48 -0700)]
1. Default device entity handler implementation in Cpp Stack.
2. Addressed review comments.
Change-Id: I8745b604d62d9c2e49fce1cedb3af185ae2f5f5b
Erich Keane [Mon, 29 Sep 2014 18:40:44 +0000 (11:40 -0700)]
Merge "Fix cosmetic regression bug reported by Habteab and Mark. https://01.org/jira/browse/IOT-54"
Erich Keane [Mon, 29 Sep 2014 18:01:44 +0000 (11:01 -0700)]
Merge "Logging effort created a regression in InProcClientWrapper that caused get/observe to not work. This fixes said regression"
Jesse Williamson [Mon, 29 Sep 2014 17:54:59 +0000 (10:54 -0700)]
Fix cosmetic regression bug reported by Habteab and Mark.
https://01.org/jira/browse/IOT-54
Change-Id: I6b7a946111800848249fea2258dff3253c7a5048
Erich Keane [Mon, 29 Sep 2014 17:51:27 +0000 (10:51 -0700)]
Merge "Simultaneous ACK and RST message received at Server causes SegFaults"
Erich Keane [Mon, 29 Sep 2014 17:46:55 +0000 (10:46 -0700)]
Merge "New APIs : hasAttribute, numberOfAttributes, erase in OCRepresentation."
Erich Keane [Mon, 29 Sep 2014 17:28:38 +0000 (10:28 -0700)]
Logging effort created a regression in InProcClientWrapper that caused get/observe to not work. This fixes said regression
Change-Id: Id6ac04d3aec3ee1f9f0d93e2cfe06cc65324d1b5
Sachin Agrawal [Mon, 29 Sep 2014 16:08:08 +0000 (09:08 -0700)]
IOT-36 (Leak 2) : Fixing memory leaks
Patch 2 : Taking care of some review comments.
Patch 3 : Update in occoaphelper.c.
Change-Id: I9bba4039e37cc94b0acad061a68d3f1cec427372
Sachin Agrawal [Mon, 29 Sep 2014 04:34:34 +0000 (21:34 -0700)]
Simultaneous ACK and RST message received at Server causes SegFaults
Change-Id: I9f609c926ed80bba940a8ba5533cea755c181be6
Sashi Penta [Fri, 26 Sep 2014 22:04:08 +0000 (15:04 -0700)]
New APIs : hasAttribute, numberOfAttributes, erase in OCRepresentation.
Change-Id: Ia6df616bdd73d7e73a34563896dd3c5d941b9a8b
Erich Keane [Wed, 24 Sep 2014 21:35:05 +0000 (14:35 -0700)]
c_logger implementation
Patch 2: rebase on master
Patch 3: adding license headers to missing files
Patch 4: rebase on master
Change-Id: I8c3d16000432df1de4b08633142ecc01ee423e0d
Doug Hudson [Fri, 26 Sep 2014 15:18:51 +0000 (11:18 -0400)]
1. Modify libcoap to use OCMalloc and OCFree.
2. Modify uri.c to call coap_free instead of free.
Change-Id: If404da557bf3f2191ad1036b9a6ac91e10a96ca9
Erich Keane [Thu, 25 Sep 2014 21:23:49 +0000 (14:23 -0700)]
Merge "Remove hard-coded IP address from the samples. removed duplicate call to OCBuildIPv4Address OCInitCoAP."
Sashi Penta [Wed, 24 Sep 2014 19:06:12 +0000 (12:06 -0700)]
Remove hard-coded IP address from the samples.
removed duplicate call to OCBuildIPv4Address OCInitCoAP.
Change-Id: I51ed3ff71997069e375043e37946180223a60141
Erich Keane [Thu, 25 Sep 2014 16:24:14 +0000 (09:24 -0700)]
Merge "IOT-36 : Fixing memory leaks"
Erich Keane [Thu, 25 Sep 2014 16:23:53 +0000 (09:23 -0700)]
Merge "1. Create csdk/ocmalloc directory 2. Create ocmalloc.c and ocmalloc.h 3. Remove OCMalloc and OCFree functions from ocstack.c and ocstack.h 4. Modify stack source modules to include ocmalloc.h 5. Modify stack makefiles to use ocmalloc.c and ocmalloc.h 6. Add doxygen function comments to ocmalloc.h 7. Remove #include from within #ifdef __cplusplus block 8. Add comment to ocmalloc.h describing the intention of the module."
Erich Keane [Wed, 24 Sep 2014 23:18:07 +0000 (16:18 -0700)]
Merge "Default device entity handler implementation in C Stack."
Doug Hudson [Wed, 24 Sep 2014 21:36:57 +0000 (17:36 -0400)]
1. Create csdk/ocmalloc directory
2. Create ocmalloc.c and ocmalloc.h
3. Remove OCMalloc and OCFree functions from ocstack.c and ocstack.h
4. Modify stack source modules to include ocmalloc.h
5. Modify stack makefiles to use ocmalloc.c and ocmalloc.h
6. Add doxygen function comments to ocmalloc.h
7. Remove #include from within #ifdef __cplusplus block
8. Add comment to ocmalloc.h describing the intention of the module.
Change-Id: I453d4ced530d7539f8b00b22b3f651327ea6a42c
Sachin Agrawal [Wed, 24 Sep 2014 21:22:47 +0000 (14:22 -0700)]
IOT-36 : Fixing memory leaks
Change-Id: I8ed2d398d79c43abf4d0131232c88f9ae8890f8f
Sashi Penta [Wed, 24 Sep 2014 21:07:08 +0000 (14:07 -0700)]
Default device entity handler implementation in C Stack.
Patch 1-3: Implementation.
Patch 4-5: Review comments from Doug and Joey.
Patch 6: Joey -> Resolved 'defaultDeviceHandler' declaration
down to one instance.
Patch 7: Reverted Patch 6.
Patch 8: Removed the declaration from ocresource.c
Change-Id: Ic1a47f65ae6772ecf417fa5f7dcb384db029a4b7
Erich Keane [Thu, 18 Sep 2014 22:56:30 +0000 (15:56 -0700)]
Fridge example which shows a nice set of the std::bind functionality as well as how to use the ResourceObject creation. Note that this will not function correctly without the csdk fix for resource commas.
Patch 2: Resolve Sudarshan's fixes
Patch 3: rebase & remove previous version of code
Change-Id: Ic7c5f3ae5da40cd8e6e82692e0f5e3b878f34489
Erich Keane [Wed, 24 Sep 2014 16:20:14 +0000 (09:20 -0700)]
Merge "Add const modifier"
Caiwen Zhang [Wed, 24 Sep 2014 20:11:26 +0000 (04:11 +0800)]
Add const modifier
const modifier is required for new avr-gcc compiler
Change-Id: I1a7b4b4059632e0c6ea83a65d7514785575416cf
Sashi Penta [Tue, 23 Sep 2014 23:38:36 +0000 (16:38 -0700)]
use of const reference where possible.
Change-Id: I4f47fdc385f58f2e52ce10bffa68ae0910e496c9
Erich Keane [Tue, 23 Sep 2014 22:49:15 +0000 (15:49 -0700)]
Merge "1. arrays in OCRepresentation 2. Fixed review comments from Jesse. 3. Refactored the code to get JSON from vector."
Erich Keane [Tue, 23 Sep 2014 22:49:04 +0000 (15:49 -0700)]
Merge "JSON Object implementation"
Sashi Penta [Tue, 23 Sep 2014 07:06:07 +0000 (00:06 -0700)]
1. arrays in OCRepresentation
2. Fixed review comments from Jesse.
3. Refactored the code to get JSON from vector.
Change-Id: I1f31f8f0c242f53f56cf50f9d9e781d8ed770f8c
Sashi Penta [Fri, 19 Sep 2014 07:06:05 +0000 (00:06 -0700)]
JSON Object implementation
1. Support for JSON object in OCRepresentation.
2. Code refactor for JSON composition in various parts of the stack into one place (OCRepresenation).
3. Similar code refactoring for JSON parsing needs to be done. I will revisit when we look into
JSON parse library alternatives.
4. Implemented correct JSON composition. Earlier we were returning strings for all the json types.
Now strings are only used for string types and JSON objects.
5. garageserver.cpp and garageclient.cpp examples to explain the user of JSON object with in
the representation.
Change-Id: I9461db811c7b5e3b827d5704cde489aa2005e291
shamit patel [Mon, 22 Sep 2014 22:59:50 +0000 (17:59 -0500)]
C++ programer's guide
Change-Id: Iab4d32ae3776cfbbe0f4c9947c71d11aaf605634
Erich Keane [Mon, 22 Sep 2014 18:16:33 +0000 (11:16 -0700)]
Non-discoverable resources cause bad JSON (trailing comma). By putting the comma generation first, we buy ourselves some room
Change-Id: Ie270c22e0f61c657f15ecf45fcbdb96de72d495f
Yamin S Al-mousa [Fri, 19 Sep 2014 17:56:47 +0000 (10:56 -0700)]
A fix for a bug reported by Omkar and Vijay:
The check for required uri lenght should consider that it includes the uri and query.
Change-Id: I1ca3e4709de02cb4f5217aba5133b8aa2bc4ee14
Sashi Penta [Fri, 19 Sep 2014 09:15:50 +0000 (02:15 -0700)]
Makefile in ocicuc is not cleaning up all the object files.
Change-Id: Ia1d198b96b61a82c07c069b4545ad40460cf2f4c
Erich Keane [Thu, 18 Sep 2014 17:32:45 +0000 (10:32 -0700)]
Merge "Revert "Replace to_string and stoi""
Erich Keane [Thu, 18 Sep 2014 17:32:32 +0000 (10:32 -0700)]
Revert "Replace to_string and stoi"
We have decided that sprintf is not stable/future proof enough, so we are going to revert this change (and the other one) and investigate what it would take to make android-only implementations of tostring and stoi
This reverts commit
dcfe2eb3bee0296aee3cc4453f4237c784251671.
Change-Id: I82bb37e42aa5b6809bdf6a6522dac678ba74aac0
Caiwen Zhang [Thu, 18 Sep 2014 17:56:05 +0000 (01:56 +0800)]
Replace to_string and stoi
Part of C++11 features aren't supported by Android NDK, includes
to_string and stoi. Replace them with snprintf and atoi.
Change-Id: I6edda1856ab34c0e1dcc23daef0b105875a09189
Erich Keane [Thu, 18 Sep 2014 16:49:57 +0000 (09:49 -0700)]
Merge "Fixing Arduino compilation error"
Erich Keane [Thu, 18 Sep 2014 16:49:22 +0000 (09:49 -0700)]
Merge "Avoid redefine 'NDEBUG'"
Caiwen Zhang [Thu, 18 Sep 2014 17:18:50 +0000 (01:18 +0800)]
Avoid redefine 'NDEBUG'
Change-Id: I1a8e1c5b0a8b7aa0c1ab19e292485e4e20ab90a5
Erich Keane [Thu, 18 Sep 2014 16:48:45 +0000 (09:48 -0700)]
Merge "Fixed warning (control reaching end of non void function) in OCPlatform.cpp"
Sachin Agrawal [Thu, 18 Sep 2014 15:39:57 +0000 (08:39 -0700)]
Fixing Arduino compilation error
Change-Id: I030f3d66b54ab61bd866f434e3cadfee30ff4ac7
Sudarshan Prasad [Thu, 18 Sep 2014 02:18:38 +0000 (19:18 -0700)]
Fixed warning (control reaching end of non void function) in OCPlatform.cpp
Change-Id: Ibab82216537c0927794bfb57dbe9e97f52b4d028
Erich Keane [Wed, 17 Sep 2014 21:07:36 +0000 (14:07 -0700)]
Merge "Support for notifying specific observers using observation Id"
Erich Keane [Wed, 17 Sep 2014 21:01:16 +0000 (14:01 -0700)]
Added release notes for Sept 17th, 2014 release.
Change-Id: I3bf64deb84e54b2c9306c03688ff5d8be9fe4053
Vijay [Wed, 17 Sep 2014 20:48:56 +0000 (13:48 -0700)]
Support for notifying specific observers using observation Id
1. Initial code changes
2. Combine GET & observe registration calls to entity handler into a single call; support for CON messages in NotifySpecificObservers; updates sample server app
3. Added the support for immediate observe cancelation in OCCancel
4. Fixed the new interface to OCCancel in C++ layer
5. A temp solution for the case when observation sequence number wraps around.
6. Merging with Yamin's changes
7. Changed OCNotifyObservers to OCNotifyAllObservers
8. Build issue
9. Another Merge to support calling the entity handler when deregister an observer
10. Rebase & CPP Changes from Sudarshan and Sashi to support Notify specific observers.
11. Command line argument options for simpleserver (so it can choose between all observers or specific observers)
12. CPP bugfix.
13. Fixed review comments for CPP.
14. Changed COAP_DEFAULT_RESPONSE_TIMEOUT to 2 and all the sample applications to sleep accordingly.
15. Fixed review comment for new line.
16. Fixed review commend for line exceed.
17. Response to comments received on patch 11
18. Header file comments updated
Change-Id: I03aa7ab2a580899441b70bd2a76cca05575b192a
Erich Keane [Tue, 16 Sep 2014 21:31:56 +0000 (14:31 -0700)]
Removed <oic-resource>/csdk/android and <oic-resoruce>/csdk/controller plus <oic-resource>/csdk/libcoap-4.1.1/config.log and config.status
PatchSet 2: Erich Rebased for submission sake
Change-Id: I0d5a355924aca94847aa70f8adcb10c700164cdc
Signed-off-by: Charunethran PG <charunethran.panchalam.govindarajan@intel.com>
Erich Keane [Tue, 16 Sep 2014 20:58:10 +0000 (13:58 -0700)]
Merge "Partial Implementation of US1574:"
Sashi Penta [Wed, 10 Sep 2014 22:19:16 +0000 (15:19 -0700)]
Partial Implementation of US1574:
OCRepresentation is now provides simpler interface to setValue and getValue from the applications.
Applications doesn't have to go through attributeMaps in OCRepresentation.
OCRepresentation now supports serialization/deserialization for primitive attributes (numbers, booleans and strings) so application doesn't have to deal with strings.
Change-Id: I09d323fc624d87c0b2a3c9b510935a6d5907a11b
Erich Keane [Tue, 16 Sep 2014 18:02:38 +0000 (11:02 -0700)]
Merge "Removed extraneous comment. The callback process is triggered from a lower point in the stack than from here. The consideration written in comment here has already been taken care of, as per Yamin."
Erich Keane [Tue, 16 Sep 2014 18:02:15 +0000 (11:02 -0700)]
Merge "IOT-48 : Updated makefiles for compiling OCStack with WiFi libraries for Arduino 1.0.5 Patch 2 : Included suggestions provided in Review comments."
Erich Keane [Tue, 16 Sep 2014 17:57:42 +0000 (10:57 -0700)]
Merge "Fixing a few warnings that we see coming out of the libcoap bits.h file."
Joseph Morrow [Tue, 16 Sep 2014 17:56:57 +0000 (13:56 -0400)]
Removed extraneous comment. The callback process is triggered from a
lower point in the stack than from here. The consideration written in
comment here has already been taken care of, as per Yamin.
Change-Id: I982922f8c87b42385e358cfe91b24bfee5ffc17f
Caiwen Zhang [Tue, 16 Sep 2014 18:16:41 +0000 (02:16 +0800)]
Remove <ifaddrs.h>
This header file is unnecessary. It will break android build as
android ndk doesn't have this file.
Change-Id: Iacd08868d1e426fe73d6b4c31d0c67ce38df9e69
Erich Keane [Tue, 16 Sep 2014 17:50:13 +0000 (10:50 -0700)]
Removing references to OCReflect that were left behind but didnt cause build issues
Change-Id: I5480fa14d5ea4960b361d62a67563f45d1dbbfed
Sachin Agrawal [Tue, 16 Sep 2014 17:42:24 +0000 (10:42 -0700)]
IOT-48 : Updated makefiles for compiling OCStack with WiFi libraries for Arduino 1.0.5
Patch 2 : Included suggestions provided in Review comments.
Change-Id: I70190ce85efcaf3b560687bff1ccace407778e44
Erich Keane [Mon, 15 Sep 2014 21:15:43 +0000 (14:15 -0700)]
Fixing a few warnings that we see coming out of the libcoap bits.h file.
Essentially, the result of the bit-shift on a uint8_t is always upconverted to a signed int despite it being impossible for it to be anything greater than 5 bits long (8 bits, shifted 3 more). We cast to unsigned size_t to prevent the warning and to prevent unsigned vs signed comparison.
Change-Id: I47d05611e75e55240b55b800c9370dbc019aedd2
Joseph Morrow [Mon, 15 Sep 2014 21:02:17 +0000 (17:02 -0400)]
Patch 1: Sending RST in response to the receipt of a notification from a server
that is not a presence nor an observe notifcation AND there is not
a callback associated.
Patch 2: Rebase
Patch 3: Changed debug print out message.
Patch 4: Oops. I had too much message in my log message.
Change-Id: If8f949827e9accf0dc45b69a5568960578b388f5
Erich Keane [Mon, 15 Sep 2014 17:50:33 +0000 (10:50 -0700)]
Merge "Patch 1: Arduino pdu malloc fix."
Erich Keane [Mon, 15 Sep 2014 15:33:19 +0000 (08:33 -0700)]
Merge "Updated Arduino sample app to reflect the current SRAM available. \n This will help in debugging Arduino crash issues in low SRAM scenarios Patch 2 : Updated code to execute only for MEGA2560 boards."
Joseph Morrow [Fri, 12 Sep 2014 17:17:46 +0000 (13:17 -0400)]
Patch 1: Arduino pdu malloc fix.
Patch 2: Rebase
Patch 3: Changed implementation of fix to simply change size of
COAP_MAX_PDU_SIZE to 320 for Arduino only. This will stay the same
going forth, but there is an uncaught case that can only be fixed
in the next sprint(as there is not enough time)-- We must implement
blockwise transfer so that a PDU larger than 320 is properly
handled (i.e. broken up into chunks of 320 or smaller). A Rally task
has already been created for Sprint 8 for this.
Patch 4: Meant to use "else" instead of "elif".
Change-Id: I4df20d28c821f6fc2c98a6bf3672331264978be5
Sachin Agrawal [Fri, 12 Sep 2014 16:08:25 +0000 (09:08 -0700)]
Updated Arduino sample app to reflect the current SRAM available. \n This will help in debugging Arduino crash issues in low SRAM scenarios
Patch 2 : Updated code to execute only for MEGA2560 boards.
Change-Id: If130815b1f8eedd9373e68e7e144ef8713a2f2cb
Erich Keane [Thu, 11 Sep 2014 23:56:30 +0000 (16:56 -0700)]
Merge "Revert "Doxygen run for *.h files""
Erich Keane [Thu, 11 Sep 2014 23:56:19 +0000 (16:56 -0700)]
Revert "Doxygen run for *.h files"
We should never have committed generated files. When necessary, Shamit can generate these himself.
This reverts commit
fdaa9cd9e05732b5087f11dcb40c2c66cc3a73e6.
Change-Id: Ibeb9f036ddf421d0d3e0f3d509ab6d2d92477db4
Thiago Macieira [Fri, 5 Sep 2014 01:21:00 +0000 (18:21 -0700)]
Remove unused variable
It's not used anywhere
Change-Id: I834b7e8f561e85dea45846d2bfe96ad90fed6ab8
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 01:20:13 +0000 (18:20 -0700)]
Fix mistaken use of && where & was intended
Found by Clang:
occoaphelper.c:93:59: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
It's clearly meant to be a &, as seen by the right shift by 5 and the
constant of 31 (5 bits)
Change-Id: Ie35ad6c313ad53d766fc6fe88ffd03b462d49519
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Erich Keane [Thu, 11 Sep 2014 17:57:44 +0000 (10:57 -0700)]
Fix use of uninitialized variable
If ctx == NULL, then VERIFY_NON_NULL would goto exit, which would then
OCFree the uninitialized variables.
Found by Clang:
occoap.c:274:5: warning: variable 'rcvObserveOption' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
occoap.c:44:36: note: expanded from macro 'VERIFY_NON_NULL'
#define VERIFY_NON_NULL(arg) { if (!arg) {OC_LOG_V(FATAL, TAG, "%s is NULL", #arg); goto exit;} }
^~~~
occoap.c:459:16: note: uninitialized use occurs here
--Erich: rebase on master
Change-Id: Ie829c6ac284dfd988eeeffad446d9872424e604a
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 01:00:53 +0000 (18:00 -0700)]
Fix warnings about diff and base possibly not initialized
This is a bogus warning by GCC, but it's easy to fix by having an "else"
case with no extra conditions.
Change-Id: I0f99527065138ff96c0613a57b0462613139900c
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 00:52:18 +0000 (17:52 -0700)]
Rewrite examples/ocicuc/Makefile
This Makefile was almost completely broken, as the comment at the top
indicated. This rewrite makes it work and also respect the top-level set
CXX variable.
Change-Id: I462b5caedfc090e6ebff72c869e82e3d57dc16c2
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 00:27:00 +0000 (17:27 -0700)]
Fix parallel build
All the .o files must be compiled before we can create the .a library
from them. When compiling with a -j option (as low as -j4), often one or
two .o files would be missing from the resulting .a because they hadn't
finished compiling yet.
Change-Id: Ie7bc0ad489b8b0afecab3ec318f2784ee706ae12
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 00:09:53 +0000 (17:09 -0700)]
Use CXX for the variable containing the name of the C++ compiler
CXX is standard, CCPLUS is not used anywhere else.
Change-Id: I2b98d609ade694306dd20062b8149a242ff7e91b
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Fri, 5 Sep 2014 00:05:52 +0000 (17:05 -0700)]
Building examples requires OCLib.a to be built first
Change-Id: I2864d8c2adc7373f6a7c6ed5619f671af26c5727
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Thu, 4 Sep 2014 23:58:47 +0000 (16:58 -0700)]
Update the #pragma GCC diagnostic usage
Don't force pedantic back on. Instead, push and pop the current state.
Don't pass these options to Clang and ICC, since they don't have the
-pedantic option anyway.
Change-Id: I302f7fcfe974f23423ca2ac7711a7c4a8ac39d88
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Thu, 4 Sep 2014 23:57:56 +0000 (16:57 -0700)]
Don't pass linker flags to compilation stages
Change-Id: Ie6d45dee1dd1919fb32a05c30143c4ba6ad085d8
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Thiago Macieira [Thu, 4 Sep 2014 23:40:39 +0000 (16:40 -0700)]
Add -p option to mkdir commands in the Makefiles
This makes mkdir not complain if it cannot create a directory that
already exists. The result of the command is ignored, but we don't need
the diagnostic either.
Change-Id: I25b9da5246e1469bccd5827886eecadd62ad319f
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Erich Keane [Thu, 11 Sep 2014 17:45:09 +0000 (10:45 -0700)]
Merge "Doxygen run for *.h files"
Erich Keane [Thu, 11 Sep 2014 17:44:23 +0000 (10:44 -0700)]
Merge "Add .gitignore file"
Erich Keane [Thu, 11 Sep 2014 16:50:10 +0000 (09:50 -0700)]
Merge "Added check for Time libraries in expected location for the Arduino Time Libraries from the TBStack makefile. If they are not there, the user will be told to put them where we expect them to be now."
Thiago Macieira [Thu, 4 Sep 2014 23:45:22 +0000 (16:45 -0700)]
Add .gitignore file
Change-Id: Ibb7a2b474bc4eb8a46654e2925fd73fddac0545a
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Joseph Morrow [Wed, 10 Sep 2014 21:36:18 +0000 (17:36 -0400)]
Added check for Time libraries in expected location for the Arduino
Time Libraries from the TBStack makefile. If they are not there,
the user will be told to put them where we expect them to be now.
Change-Id: I93693a4623d038e152559ff9d8260bdb91c9000f
Erich Keane [Wed, 10 Sep 2014 18:08:09 +0000 (11:08 -0700)]
Provided a mechanism for deleting the context pointer when the C Stack deletes callback. Otherwise, the callback context will be leaked.
Fixed some line endings.
Fixed some line lengths.
Fixed a series of memory leaks in C++ callbacks which assumed the C stack owned/deleted OCCallbackData
Patch 2: Removed deletion of function pointers becaues GCC says this violates the C spec.
Patch 3: Comments from Joey regarding the comment on the OCClientContextDeleter typedef
Patch 4: changed deleter to deleteCallback per sashi's suggestion
Change-Id: I0fb71896afac93356c1bd2f4916eb9f3eaa0ad13
Erich Keane [Wed, 10 Sep 2014 19:36:26 +0000 (12:36 -0700)]
Merge "IOT-31: Add copyright info to all makefiles"
Erich Keane [Wed, 10 Sep 2014 19:34:10 +0000 (12:34 -0700)]
Merge "A fix for building the Arduino TBStack without wifi libraries. This bug was apparent even when building for only ethernet, the makefile expected the wifi libraries to exist. Now the makefile only expects the wifi libraries to exist if you're building for wifi shield."
Charunethran PG [Wed, 10 Sep 2014 17:39:16 +0000 (19:39 +0200)]
Doxygen run for *.h files
Change-Id: Ia26ec0edc0f817ac872b261e9490c2319db466b4
Signed-off-by: Charunethran PG <charunethran.panchalam.govindarajan@intel.com>
Erich Keane [Wed, 10 Sep 2014 16:52:14 +0000 (09:52 -0700)]
IOT-31: Add copyright info to all makefiles
Change-Id: Idcdbf7e9a81b5f7f28e953cf31083d083c917aea
Erich Keane [Wed, 10 Sep 2014 16:35:04 +0000 (09:35 -0700)]
Merge "Just realized that these should NOT be PCF'd. If a server or client were using these as defined to be in program memory, the stack would have been storing the location the strings were stored in memory instead of their actual values when running on Arduino. PCF has no effect on Linux."