Mike Blumenkrantz [Wed, 8 Aug 2018 06:56:02 +0000 (15:56 +0900)]
efl_ui/image_zoomable: fix internal eina file refcounting
Summary:
this pointer is owned by elm_theme, not the image, so the image refcount
must be increased in order to avoid accidentally closing the file which is
still in use by elm_theme and triggering a crash
this resolves the crash in the `efl_ui_image_zoomable_icon` test
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6774
Bowon Ryu [Wed, 8 Aug 2018 06:20:42 +0000 (15:20 +0900)]
efl_ui_tab_pager: clean up and remove unnecessary signals.
Summary:
TAB of efl_ui_tab_bar is no longer widget_item.
TAB is now layout,
so, do not need below signals.
"efl,text,visible"
"efl,text,hidden"
"efl,icon,visible"
"efl,icon,hidden"
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6770
Bryce Harrington [Wed, 8 Aug 2018 04:52:25 +0000 (13:52 +0900)]
eina: Add doxygen in/out tags for rectangle
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6776
Wonki Kim [Mon, 25 Jun 2018 06:56:11 +0000 (15:56 +0900)]
eina_prefix: Fix a logic to use a canonical path for finding prefix
wip
Change-Id: Ib6b8f9ff15da7cfd3540d93dd8c7021d53678768
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Hermet Park [Tue, 14 Aug 2018 21:13:24 +0000 (17:13 -0400)]
evas gl: fix missing map texture target.
Summary:
Map context missed setting texture target.
I guess this is one of regression bugs in gl backend.
When shader is flushed, it sets invalid texture target with map texture.
That caused blank map rendering, this could be observed temporary
because gl pipe contexts are reusable and missing texture target means,
it could use previous texture target values that mostly have GL_TEXTURE_2D.
@fix
Reviewers: #committers, ManMower
Reviewed By: #committers, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6818
Change-Id: I4fa4f70864da7ee1e244a187116d7f71159e1940
Lukasz Wlazly [Fri, 10 Aug 2018 08:27:13 +0000 (10:27 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: Icb6171e61255b3e5561982387ced4e8440ce234a
Youngbok Shin [Thu, 9 Aug 2018 09:43:45 +0000 (18:43 +0900)]
edje_cc: remove edje_cc build warning message caused by efl_version
In Tizen, new Textblock calculation is already applied by default.
So, this warning message is meaningless in Tizen.
@tizen_fix
Change-Id: I9a02653ddd5c7f6c6eedea767d930687c1f3da54
Joogab Yun [Thu, 9 Aug 2018 03:58:45 +0000 (12:58 +0900)]
evas : fixed coverty issue CID:111611
Change-Id: If5cfe093d251fb75d7c15380ad71a6e81cb5a790
Joogab Yun [Thu, 9 Aug 2018 03:34:49 +0000 (12:34 +0900)]
evas : fixed coverity issue CID:1013912
Change-Id: I8bfcf9e9e2235dd76947f91261fde19c875659b1
Taehyub Kim [Thu, 9 Aug 2018 02:00:53 +0000 (11:00 +0900)]
ecore_wl_dnd: free seat selection event when num_types are less than 0
Change-Id: Ieaf11eb564c478f22c3b0f6ec0b38811b9fa65d3
Hermet Park [Wed, 8 Aug 2018 07:01:11 +0000 (16:01 +0900)]
evas image: fix screen flickering issue at partial + image preloading
Summary:
Prerequisite: Partial rendering ON + Image Prealoding + Triple surface buffer of GL.
Previously, evas trys to draw of an image which didn't prepare of image data yet (in case of preloading)
This time, it will draw a solid color onto the dest sufrace 1,
But luckily, preloading is finished just after, it draws proper image data onto next surface 2 and 3.
Now, triple buffer is filled with the image data but only first frame is still empty. That's a problem.
This patch skips to draw image if it doesn't prepare data yet, but once the preloading is finished,
it starts to draw images.
@fix
Reviewers: #committers
Subscribers: kimcinoo, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6739
Change-Id: I64f4b5a6ca68feba086f05b3d8da5e5110416345
Shinwoo Kim [Wed, 8 Aug 2018 04:51:40 +0000 (13:51 +0900)]
evas_image: do not render while preloading
Summary:
Unexpected image shows if image data is not ready.
Even though there is a change to check the 'preloading' in pre_render phase,
evas_object_image_render is called. So we need to check here as well.
Reference: https://phab.enlightenment.org/D6739
It seems that the 'preloading' is not enough. The 'preloading' could be reset
to FALSE by _evas_image_load_async_cancel > _image_preload_internal.
If the following step happens, then this patch set is neccessary.
(1) evas_object_image_pre_render
(2) _evas_iamge_load_async_start
(3) evas_object_image_render
I could not find out what the correct step, but it actullay happens.
The evas_object_image_render could be called with the 'preloading' TURE.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6778
Change-Id: I0b0d941868ee53bd4f89a0895b029034b6f035f2
Hermet Park [Wed, 8 Aug 2018 06:52:37 +0000 (15:52 +0900)]
elementary image: don't calc size using empty ones.
Summary:
Zero-sized image occasionally happens.
That occurs insane img/clipper region.
bj size => (w, h) then resize => (0, 0)
file_set(xx.jpg) then file_set (NULL)
Because of this, region could be flickered during prev/cur preloading images.
@fix
Reviewers: #committers, zmike
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6725
Change-Id: If3f01f66efe2eef6f62520dabbb6237d68dfb8b5
Lukasz Wlazly [Mon, 13 Aug 2018 08:54:22 +0000 (10:54 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: I558c4f41ce72321272db3db433f259c4d6f08387
Yeongjong Lee [Tue, 14 Aug 2018 09:41:23 +0000 (18:41 +0900)]
Revert "evas engines: do not immediately free native surface when unsetting it"
This reverts commit
c0ddc1b6a0dc710f4220250b40fd67234cb4ff9a.
@tizen-fix
Change-Id: I2426a5e602b1da688302555c943c9f01002066f6
Signed-off-by: Yeongjong Lee <yj34.lee@samsung.com>
Taehyub Kim [Wed, 8 Aug 2018 06:54:29 +0000 (15:54 +0900)]
efl_ui_popup_alert_text: apply tizen theme for label
Change-Id: I1c5a30990bf08f2d42262eb75de9f53a7ffffb9e
Shinwoo Kim [Mon, 18 Jun 2018 10:36:10 +0000 (19:36 +0900)]
ecore_evas: use timer for animator
[Problem]
The animator on the wayland ecore_evas engine used wl_surface frame callback
as its source(of _ecore_evas_tick_source_find). This made wl_surface_commit
be called too much and caused the Enlightenment performance issue.
[Solution]
So this patch set is using the timer for animator source.
The animator is working without intervention of the Enlightenment.
@tizen_only
Change-Id: Id20a95a35107454a908397eeb3640d7f6650ef2d
Taehyub Kim [Tue, 7 Aug 2018 06:23:53 +0000 (15:23 +0900)]
efl_selection: check the sel lost object to prevent invalid acesss
Change-Id: Iad7928d7da691e96dcce6b409f756ac80342a353
Mike Blumenkrantz [Tue, 7 Aug 2018 16:10:22 +0000 (12:10 -0400)]
tests/eolian: remove eolian_decl test
Summary:
<q66> just remove decl.eo and remove the eolian_decl test; it's useless
<q66> the reason: it used to be testing some specific API, which got replaced with more generalized API that is now used everywhere in the tests, so that specific test no longer has a purpose
resolves some compile errors due to type conflicts
Reviewers: q66
Reviewed By: q66
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6773
Marcel Hollerbach [Tue, 7 Aug 2018 04:25:34 +0000 (13:25 +0900)]
elm_genlist: fix item registration by correct realization
Summary:
there was a case when a block could be realized while a item that is
realized was brought from one block to the this new one. The block now
is simply realized using api instead of just setting the flag, this sets
the correct focus registrations. While fixing this the error of double
regiration of items came up, this is also fixed by unregistration and
reregistration in the correct block.
fix T7247
Reviewers: zmike, SanghyeonLee, YOhoho
Reviewed By: zmike
Subscribers: Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T7247
Differential Revision: https://phab.enlightenment.org/D6737
Mike Blumenkrantz [Mon, 6 Aug 2018 19:18:14 +0000 (15:18 -0400)]
ecore-evas/wayland: fix parent setting on canvas creation
Summary:
use the correct pointer when applying the passed parent object in order to
successfully set the parent
ref
78f27a3efff24ba3b935cc9e2620718e51af9304
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl_display_system
Differential Revision: https://phab.enlightenment.org/D6757
Change-Id: Iad0aeeb7542a3e6145c986434aa92b5d8a97fd3f
Hermet Park [Mon, 6 Aug 2018 11:23:48 +0000 (07:23 -0400)]
evas image: code refactoring.
Summary: remove duplicated, no logical changes.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6738
Marcel Hollerbach [Mon, 6 Aug 2018 07:38:58 +0000 (16:38 +0900)]
elm_genlist: remove unused function
Summary:
this got replaced by the none composition implementation and is not
required anymore.
Depends on D6737
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6752
Change-Id: I025bda18f9a6b67229a2ef33cc89a332a48e26ba
Marcel Hollerbach [Mon, 6 Aug 2018 07:34:05 +0000 (16:34 +0900)]
elm_genlist: fix ghost objects from the genlist cache
Summary:
the cache simply moved the objects to -9999 -9999 while leaving them
visible and focusable. Hiding them does not work since edje makes it
visible all the time again. Making them unfocusable fixes this.
Depends on D6752
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6753
Change-Id: I3e7ee3f04aa9f18110ca07305134dd56ca9be8cf
Mike Blumenkrantz [Mon, 6 Aug 2018 07:26:52 +0000 (16:26 +0900)]
tests/elm: when using buffer engine, clamp render and edje timing to 0.05s
Summary:
this sets manual render on buffer engine windows and dumps the render at every
interval in order to avoid doing any real rendering or animating or having to
wait on some irrelevant timing.
tests using buffer engine just want to complete as fast as possible, as they are
never being displayed anywhere, so just perform canvas operations (recalcs mostly)
and BAIL
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6749
Shinwoo Kim [Mon, 6 Aug 2018 07:21:55 +0000 (16:21 +0900)]
test/evas: add to check smart class overriding
Summary:
If Evas_Smart_Class.move is overridden,
then user defined move function should be used.
Check if "https://phab.enlightenment.org/D6468" works or not.
Reviewers: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6740
Alastair Poole [Sun, 5 Aug 2018 20:13:39 +0000 (21:13 +0100)]
elm_code_widget: match bg color with widget color.
Test Plan: elm_test -> "Code Editor" -> Consistent widget colours.
Reviewers: #committers, ajwillia.ms, zmike
Reviewed By: #committers, ajwillia.ms
Subscribers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6719
Mike Blumenkrantz [Mon, 23 Jul 2018 14:27:53 +0000 (10:27 -0400)]
ci: add build time to IRC notification
this will be useful while profiling CI builds to know whether a patch
has made builds slower so that it can potentially be examined
Differential Revision: https://phab.enlightenment.org/D6666
Mike Blumenkrantz [Sun, 22 Jul 2018 16:01:47 +0000 (12:01 -0400)]
ci: remove --always-build-examples from misc build
these should only be explicitly built by the examples target or built
during distcheck
Differential Revision: https://phab.enlightenment.org/D6665
Mike Blumenkrantz [Sun, 22 Jul 2018 02:22:17 +0000 (22:22 -0400)]
build: remove infuriating VTIME build define
this does nothing but ruin your entire ccache every time configure runs.
ref
cae354d299688304f609c5f064702891f02260b9
ref T5495
Differential Revision: https://phab.enlightenment.org/D6662
Mike Blumenkrantz [Fri, 20 Jul 2018 21:46:44 +0000 (17:46 -0400)]
build: remove BUILT_SOURCES usage from cxx examples makefiles
ref T7154
Differential Revision: https://phab.enlightenment.org/D6656
Mike Blumenkrantz [Wed, 18 Jul 2018 21:55:09 +0000 (17:55 -0400)]
build: move src/examples/ to a single makefile
this greatly improves build times by improving parallelizing, though it
does introduce more BUILT_SOURCES usage which causes builds with cxx
bindings to take significantly longer
fix T7157
ref T7154
Differential Revision: https://phab.enlightenment.org/D6633
Mike Blumenkrantz [Thu, 2 Aug 2018 20:42:56 +0000 (16:42 -0400)]
elm/genlist: use correct type of list when iterating
itb-items is Eina_List, not Eina_Inlist. this crashes due to wrong type
use
ref D6720
fix T7246
Differential Revision: https://phab.enlightenment.org/D6736
Marcel Hollerbach [Thu, 2 Aug 2018 13:42:06 +0000 (09:42 -0400)]
genlist: rework the focus model for performance
Summary:
the focus model before was more meant for simplicity and not for
performance, this now is more made for performance.
The performance boost is achived by not using composition anymore,
but rather register realized items by hand. This keeps the amount
of items bound to the size of the viewport.
Additionally item realization that is followed by unrealization
immediately is not resulting in focus calls.
This solves the performance issue from T6580 in regards of focus.
perf results after this:
http://www.enlightenment.org/ss/e-
5b61b50657f3c3.
82619729.png
Reviewers: ManMower, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6720
Change-Id: I5b753db6fca3d1feed5e4f13d7e08da717d9977e
Hermet Park [Thu, 2 Aug 2018 13:22:59 +0000 (09:22 -0400)]
elementary image: apply lazy calculation and guarantee retained method.
Summary:
Image couldn't gurantee retained concept status.
This patch change to setting up image object on the request time,
recovering image status, removing unencessary jobs.
Reviewers: #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6726
Change-Id: I8aec4de5c865d5110d1d317094e8f31a8aba9e71
Hosang Kim [Thu, 2 Aug 2018 13:14:15 +0000 (09:14 -0400)]
ecore: fix that timers are not called in the order they were registered.
Summary:
Timers are not called in the order they were registered.
Because when current timer is deleted, getting next timer is called twice.
Test Plan:
<error>
Timer1 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.
<correct>
Timer1 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.|
{
F3268233}
Reviewers: Hermet, Jaehyun_Cho, zmike, SanghyeonLee
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6700
Shinwoo Kim [Thu, 2 Aug 2018 13:10:41 +0000 (09:10 -0400)]
Efl.Canvas.Group: use desired function
Summary:
If a smart class overrides Evas_Smart_Class.move as below,
then original behavior must not be used for the smart class.
Evas_Smart_Class sc = EVAS_SMART_CLASS_INIT_NAME_VERSION("MyClass");
evas_object_smart_clipped_smart_set(&sc);
sc.move = &myMove;
But current implementation makes original behavior work.
So before using the original method, this patch is checking if the original
method is changed or not.
Reviewers: zmike, devilhorns
Reviewed By: zmike
Subscribers: woohyun, jypark, cedric, raster, jpeg, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6468
Hermet Park [Thu, 2 Aug 2018 13:08:43 +0000 (09:08 -0400)]
elementary bg: fix to guarantee compatibility.
Summary: This is additional fix to
b9b209f60f040d0afbccc1db0c96c8e36d14e682.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6727
Mike Blumenkrantz [Wed, 27 Jun 2018 20:53:55 +0000 (16:53 -0400)]
elm/genlist: remove conditional in _calc_job for verifying show_item code
I think at some point in the past this was necessary to avoid weird show
mechanics, but now things have changed and it's best to always attempt to
scroll and let the scroller internals figure things out
this resolves the case where attempting to scroll to an item during a genlist's
calc (ie. the item was not present in a full layout calc) would fail to scroll
to the item if the scroll method was TOP and the item was too close to the
bottom of the list
fix T6368
@fix
Differential Revision: https://phab.enlightenment.org/D6466
Jaehyun Cho [Thu, 2 Aug 2018 09:16:46 +0000 (18:16 +0900)]
evas_events: Fix to set mouse_in state to all pointers in the seat.
Summary:
mouse coordinate is set by seat.
Therefore, mouse_in state should be set based on seat.
As a result, mouse_in state of all pointers in the seat should be
updated at the same time.
Reviewers: eagleeye, devilhorns, zmike
Reviewed By: eagleeye, devilhorns, zmike
Subscribers: devilhorns, Hermet, kimcinoo, cedric, iscaro, zmike, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6699
Mike Blumenkrantz [Mon, 30 Jul 2018 11:12:31 +0000 (07:12 -0400)]
edje: add back function prototype for edje_object_color_class_description_get
this was removed in D4403
Differential Revision: https://phab.enlightenment.org/D6694
Hermet Park [Thu, 2 Aug 2018 03:20:27 +0000 (12:20 +0900)]
evas sdl: don't make confusing, we only use one-indexed egl handles.
Reviewers: ManMower
Subscribers: devilhorns, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6693
Felipe Magno de Almeida [Wed, 1 Aug 2018 22:45:36 +0000 (19:45 -0300)]
elementary: efl_ui_view_list cleanup
Summary:
private data cleanup
removed callbacks
Reviewers: felipealmeida, SanghyeonLee
Reviewed By: felipealmeida
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D6707
Change-Id: I20c7af06992ba7b03ab72ff773c6f7a866e0f75e
Felipe Magno de Almeida [Wed, 1 Aug 2018 21:42:13 +0000 (18:42 -0300)]
Efl.Ui.Layout.Factory: added missing factory_model_connect
Summary:
connect factory to edje part name
when create a new layout connect a factory to it
change example to use the factory_model_connect
Reviewers: felipealmeida
Differential Revision: https://phab.enlightenment.org/D6667
Daniel Kolesa [Wed, 1 Aug 2018 17:31:15 +0000 (13:31 -0400)]
build: disable Lua binding generation
Summary:
As Lua bindings don't work right now, it is pointless to waste
build time generating them. Elua itself on the other hand is
useful and should stay enabled.
This also does some preparation work for separate configure
switch for bindings after release, but for now keep configure
switches as they are.
Reviewers: zmike, stefan_schmidt
Subscribers: cedric, bu5hm4n, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6721
Mike Blumenkrantz [Wed, 1 Aug 2018 00:05:07 +0000 (20:05 -0400)]
ci: print config.log if configure fails
Differential Revision: https://phab.enlightenment.org/D6717
Mike Blumenkrantz [Wed, 1 Aug 2018 02:38:03 +0000 (22:38 -0400)]
ci: explicitly set PKG_CONFIG_PATH for openssl
travis upgraded to macos high sierra overnight without notification(?)
and this is now required in order to find openssl for some reason
also disable config.cache to prevent configure errors
Differential Revision: https://phab.enlightenment.org/D6718
Hosang Kim [Thu, 28 Jun 2018 11:17:46 +0000 (20:17 +0900)]
ttrace: apply ttrace log system.
@tizen_fix
Change-Id: I31526279b4ca1f6b15f01c157b385bcf4b2a14a1
Wonki Kim [Wed, 1 Aug 2018 12:02:34 +0000 (21:02 +0900)]
neon: fix a build fail on aarch64
there is a tizen only code on draw_convert.c.
and it make a build fail on aarch64.
this patch fix it.
Change-Id: I3b1270f5bb2258aca241222843b96e5d4bf8f82a
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Hermet Park [Mon, 30 Jul 2018 06:25:08 +0000 (15:25 +0900)]
evas gl_tbm: don't make confusing, we only use one-indexed egl handles.
Change-Id: I7d2708707b9d80e27ea4f21dc01702cd1ce5f9da
Yeshwanth Reddivari [Mon, 30 Jul 2018 16:34:44 +0000 (22:04 +0530)]
region_add: Fix copying wrong rect during smart merge
Summary:
When testing partial rendering on TV, found this bug.
Probably this was caused because of wrong copy/paste.
When region1 completely subsumes region2, region2 should be ignored.
But currently region2 is copied to region1 which makes region1 rect completly wrong.
This was causing lot of visual defects because of wrong rects.
This patch will fix those visual defects when partial rendering is enabled.
Test Plan: Tested with the patch on TV after enabling partial rendering.
Differential Revision: https://phab.enlightenment.org/D6696
Change-Id: I63c2d91e48a29311562d116ccb03c1a0e2db4ed1
Signed-off-by: Yeshwanth Reddivari <yashu21985@gmail.com>
Yeshwanth Reddivari [Fri, 27 Jul 2018 20:29:54 +0000 (01:59 +0530)]
evas_tbm : Send correct eglSurface and Remove duplicate SetDamageRegion
As per the spec https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_partial_update.txt,
its an error to call multiple eglSetDamageRegionKHR within same frame boundary.
So, removed the duplicate SetDamageRegion.
Also, wrong eglSurface was passed to DDK which caused issue in partial rendering
Change-Id: I70a5bda0aa5fee9785264f2528d9e184201ddb07
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Hermet Park [Thu, 12 Jul 2018 13:14:32 +0000 (09:14 -0400)]
canvas render: stop render_pre/post cb if it didn't render.
Summary:
Basically, render_pre/post should be called only if rendering happens.
Unfortunately, this behavior had been broken by some mistakes.
As far as I understand after reading history carefully,
this issue introduced for fixing unpair of pre/post cbs.
In case of async render, the post callback would be triggered in
evas_render_pipe_wakeup(), it means POST callbake shouldn't be tiggered in
evas_render_updates_internal(). If that post callback were removed in
evas_render_updates_internal(), then in case of sync_render,
POST callback won't be triggered. So previously, the PRE/POST couldn't get
paired.
I guess cedric put a mistake that nothing2rendering which brought
the pre/post pair issue, even he said that patch fix the unpair of them.
(But actually that patch brought the issue!)
See this:
dc841ed9b2ccf880df2d7590ea46d95e03e8752f
Whatever it was intented or not, that patch totally insane, even
non-descripting.
If we just trigger post cb only if sync render or no_rendered case,
We could make satisfication for both cases.
@fix
Reviewers: #committers, devilhorns, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6573
Change-Id: I267072faf71838b0ff4902b5c45e499a3f2af423
Taehyub Kim [Thu, 26 Jul 2018 06:15:45 +0000 (15:15 +0900)]
ecore_wl2_dnd: Supporting copy and paste for cbhm
- cbhm needs multiple mimetypes when selection occurs
Change-Id: I4b80e8df2615a5904cb122e8af5aaeae48e9385e
Taehyub Kim [Thu, 26 Jul 2018 06:04:17 +0000 (15:04 +0900)]
efl_selection_manager, ecore_wl2_dnd: Supporting Drag and Drop
- There is a problem that the visibility of drag_win(ELM_WIN_DND) depends on the order of show and resize.
Normally, The order should not be matter, but drag_win is visible in show and resize order not resize and show order.
So It should be fixed later.
- Ecore_Wl2_Event_Dnd_End is changed to Ecore_Wl2_Event_Data_Source_End in efl_selection_manager.c to make it consistency.
- Serial logic in efl_selection_manager.c is not stable now, so disable it.
Change-Id: I67aa5a4fb4f4c26192a2a638ca45063dc2457c49
Taehyub Kim [Thu, 26 Jul 2018 08:09:16 +0000 (17:09 +0900)]
Revert "Revert "efl_ui_win: add missing wayland interface for setting role of winodw""
This reverts commit
95b7a0938871585491ebe10e53ed04f53b3afde9.
Change-Id: I7d54541fa2403c64f1d4752add898ef741d1707b
SangHyeon Jade Lee [Wed, 1 Aug 2018 05:30:34 +0000 (14:30 +0900)]
evas : apply tizen only for evas gl thread support
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Mike Blumenkrantz [Tue, 31 Jul 2018 22:49:57 +0000 (18:49 -0400)]
elm/bg: call color_set up the class chain internally
Summary:
this ensures that the color_set call is propagated correctly, resulting
eventually in a call to the smart clipped class method for color_set which
will change the opacity of the edje object in addition to the bg widget's
internal rect object
this seems to have been a regression created during the move to the interfaces
version of the bg widget
fix T7232
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl_widgets
Maniphest Tasks: T7232
Differential Revision: https://phab.enlightenment.org/D6716
Chris Michael [Tue, 31 Jul 2018 21:23:46 +0000 (17:23 -0400)]
elementary: Check for valid object before calling smart calculate
Summary:
Small patch fixes an issue where evas_object_smart_calculate was being
called with a NULL box.
ref T7030
Depends on D6704
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6710
Derek Foreman [Tue, 31 Jul 2018 21:02:39 +0000 (17:02 -0400)]
ecore_evas: Make sure a manual render does a manual render
Summary:
If we call ecore_evas_manual_render() during an async render, it does
nothing.
This is harmful if we've added render post callbacks during that async
render and expect them to fire.
Force a sync and another render if we're in an async render.
ref T7156
Depends on D6714
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7156
Differential Revision: https://phab.enlightenment.org/D6715
Derek Foreman [Tue, 31 Jul 2018 21:02:17 +0000 (17:02 -0400)]
ecore_evas: Sync evas on manual_render_set
Summary:
Make sure any ongoing async rendering is finished before manual_render_set
returns.
Depends on D6711
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6714
Derek Foreman [Tue, 31 Jul 2018 21:02:12 +0000 (17:02 -0400)]
evas: Defer render post callbacks added during async render
Summary:
To take screenshots, Enlightenment makes a new snapshot object, performs
a manual render, and uses the snapshot results.
Turns out if this happens while an async render is in progress, the
async render's completion triggers a render post callback on the snapshot
object even though it's never been involved in a render.
We need to defer new render post callbacks until any currently running
render completes, then add them during that render's post.
Fix T7156
Reviewers: devilhorns, zmike
Reviewed By: devilhorns, zmike
Subscribers: devilhorns, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7156
Differential Revision: https://phab.enlightenment.org/D6711
Bryce Harrington [Tue, 31 Jul 2018 20:40:43 +0000 (16:40 -0400)]
eina: Add doxygen in/out tags for value and value_util
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6713
Bryce Harrington [Tue, 31 Jul 2018 19:27:08 +0000 (15:27 -0400)]
eina: Add doxygen in/out tags for rbtree
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6709
Bryce Harrington [Tue, 31 Jul 2018 19:16:39 +0000 (15:16 -0400)]
eina: Add doxygen in/out tags for quaternion
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6708
Marcel Hollerbach [Tue, 31 Jul 2018 15:26:19 +0000 (11:26 -0400)]
efl_model: fix redefine warning
Summary:
The struct definition here is not needed as it will be redefined anyways
later in the efl_model.eo.h header.
Depends on D6705
Reviewers: zmike, #committers, lauromoura, felipealmeida
Reviewed By: zmike, #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6706
Marcel Hollerbach [Tue, 31 Jul 2018 15:26:17 +0000 (11:26 -0400)]
elm_multibuttonentry: do not define multiple times the same structs
Summary: There is no reason to typedef Elm_Multibuttonentry multiple times, the header file can be included, there is no cyclic dependency.
Reviewers: CHAN, zmike, #committers
Reviewed By: zmike, #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6705
Yeshwanth Reddivari [Tue, 31 Jul 2018 12:29:03 +0000 (07:29 -0500)]
region_add: Fix copying wrong rect during smart merge
Summary:
When testing partial rendering on TV, found this bug.
Probably this was caused because of wrong copy/paste.
When region1 completely subsumes region2, region2 should be ignored.
But currently region2 is copied to region1 which makes region1 rect completly wrong.
This was causing lot of visual defects because of wrong rects.
This patch will fix those visual defects when partial rendering is enabled.
Test Plan: Tested with the patch on TV after enabling partial rendering.
Reviewers: raster, cedric, Hermet, ManMower
Reviewed By: ManMower
Subscribers: bu5hm4n, ajwillia.ms, ManMower, devilhorns, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6696
Bryce Harrington [Tue, 31 Jul 2018 06:51:02 +0000 (02:51 -0400)]
eina: Add doxygen in/out tags for promise
Summary: Also, add some missing param docs, and fix some incorrect ones.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6698
Mike Blumenkrantz [Fri, 20 Jul 2018 23:22:59 +0000 (19:22 -0400)]
build: disable eolian implicit rules in subdir builds
the ../ rules override the global rules to block actions which would
force eolian to generate files which should be managed by a higher
level makefile
this cuts a substantial amount of time out of distcheck from example
builds
Differential Revision: https://phab.enlightenment.org/D6660
Mike Blumenkrantz [Fri, 20 Jul 2018 23:21:31 +0000 (19:21 -0400)]
build: use $(@D) for eolian directory name
this is cosmetic; $(@D) is the standard automatic variable set to the directory
part of the target
https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html
Differential Revision: https://phab.enlightenment.org/D6659
Mike Blumenkrantz [Fri, 20 Jul 2018 22:37:16 +0000 (18:37 -0400)]
ci: disable dependency tracking in ci builds
ci builds are only built once, so tracking dependencies is just a waste
of build time
Differential Revision: https://phab.enlightenment.org/D6658
Mike Blumenkrantz [Fri, 20 Jul 2018 22:35:49 +0000 (18:35 -0400)]
build: disable dependency tracking in distcheck builds
files are only built once during distcheck, so tracking file changes
is just a waste of build time
Differential Revision: https://phab.enlightenment.org/D6657
Alastair Poole [Mon, 30 Jul 2018 15:42:28 +0000 (11:42 -0400)]
efl_selection: reintroduce missing ELM_CNP_EVENT_SELECTION_CHANGED symbol.
Summary:
During the 1.21 development cycle the symbol ELM_CNP_EVENT_SELECTION_CHANGED was lost.
The commit which introduced this:
e88bbaa1e314751e5c1a04dec7f1f179188428ae
This patch re-introduced the symbol and expected behaviour.
Reviewers: #committers, zmike, bu5hm4n, herb
Reviewed By: #committers, zmike
Subscribers: herb, ManMower, segfaultxavi, stefan_schmidt, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6689
Mike Blumenkrantz [Fri, 20 Jul 2018 18:24:10 +0000 (14:24 -0400)]
ci: use gold linker for linux builds
this is a substantially faster linker which should yield some speedups
for our builds
Differential Revision: https://phab.enlightenment.org/D6655
Mike Blumenkrantz [Fri, 20 Jul 2018 18:12:27 +0000 (14:12 -0400)]
ci: disable tests on macos
these all fail currently due to some dbus issues
ref T7174
Differential Revision: https://phab.enlightenment.org/D6654
Mike Blumenkrantz [Fri, 20 Jul 2018 15:46:41 +0000 (11:46 -0400)]
tests/ecore: remove tolerance threshold from ecore_timer_reset test case
unit tests should test one thing only: testing timer accuracy and the
effectiveness of resetting a timer in the same test leads to timing issues,
so remove the timing component from the test
ref T6878
Differential Revision: https://phab.enlightenment.org/D6653
Mike Blumenkrantz [Fri, 20 Jul 2018 15:40:58 +0000 (11:40 -0400)]
ci: attempt to print the test logs if distcheck fails
distcheck failures from test failures are hard to debug since distcheck
is more complicated than a regular build, this is a first step in providing
info for that debugging
Differential Revision: https://phab.enlightenment.org/D6652
Mike Blumenkrantz [Fri, 20 Jul 2018 15:26:05 +0000 (11:26 -0400)]
ci: disable built-in make rules and variables
these slow down build times and don't benefit us
Differential Revision: https://phab.enlightenment.org/D6651
Mike Blumenkrantz [Thu, 19 Jul 2018 23:42:57 +0000 (19:42 -0400)]
build: fix rpath for binaries which use ecore-x dependencies
somehow ecore-x explicitly pulls in ${libdir}/libX11.so at link-time,
which causes libtool to add ${libdir} to the rpath executable wrappers
before the remainder of the in-tree efl paths. this causes binaries run
from these wrappers (e.g., tests, built-time tools such as codegens) to
use system libraries instead of in-tree libraries
@fix
Differential Revision: https://phab.enlightenment.org/D6635
Mike Blumenkrantz [Thu, 19 Jul 2018 23:42:27 +0000 (19:42 -0400)]
build: use $() for automake variables, not ${}
this is not a functional change, just increasing consistency
https://www.gnu.org/software/make/manual/html_node/Reference.html#Reference
Differential Revision: https://phab.enlightenment.org/D6634
Marcel Hollerbach [Mon, 30 Jul 2018 12:18:02 +0000 (13:18 +0100)]
elm_entry: make the hoversel not focusable
Summary:
the hoversel is added to a entry while entrys are not build for handling
children focus. Disabling this prevents wrong focus operations.
fix T7163
Reviewers: zmike, #committers, netstar
Reviewed By: netstar
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7163
Differential Revision: https://phab.enlightenment.org/D6695
Bryce Harrington [Sat, 28 Jul 2018 15:50:49 +0000 (11:50 -0400)]
eina: Add doxygen in/out tags for mmap and module
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6691
Bryce Harrington [Sat, 28 Jul 2018 00:20:44 +0000 (20:20 -0400)]
eina: Add doxygen in/out tags for log
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6690
Alastair Poole [Fri, 27 Jul 2018 14:20:24 +0000 (15:20 +0100)]
elm_code_widget: fix keyboard and scrolling with active selection.
Summary:
This adds some attributes to the selectiont type in elm_code.
Including the type (whether it is mouse or keyboard) and also whether
a selection is in progress. Thus we can reliably select around the
file and also move/scroll when there is an active selection.
Test Plan:
Drag and select text with mouse. Also the same with keyboard (hold shift and select).
Leave selection active and scroll around the file. The selection should remain and
full movement is possible while retaining the active selection. This could really
be refactored for a next major release.
Reviewers: #committers, ajwillia.ms, cedric
Reviewed By: ajwillia.ms
Subscribers: zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6676
Bryce Harrington [Fri, 27 Jul 2018 07:59:44 +0000 (03:59 -0400)]
eina: Add doxygen in/out tags for lalloc and list
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6688
Mike Blumenkrantz [Thu, 26 Jul 2018 12:43:50 +0000 (21:43 +0900)]
evas: handle all failure cases with error messages in evas_init
Summary: fix T7026
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7026
Differential Revision: https://phab.enlightenment.org/D6677
Mike Blumenkrantz [Thu, 26 Jul 2018 12:30:03 +0000 (21:30 +0900)]
edje: handle all failure cases with error messages in init
Summary:
fix T7025
Depends on D6677
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7025
Differential Revision: https://phab.enlightenment.org/D6678
Mike Blumenkrantz [Thu, 26 Jul 2018 12:13:46 +0000 (21:13 +0900)]
elm: handle all failure cases with error messages in init
Summary:
fix T7021
Depends on D6678
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7021
Differential Revision: https://phab.enlightenment.org/D6679
Bryce Harrington [Thu, 26 Jul 2018 11:04:46 +0000 (20:04 +0900)]
eina: Add doxygen in/out tags for inlist and iterator
Reviewers: segfaultxavi
Subscribers: segfaultxavi, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6686
Youngbok Shin [Fri, 27 Jul 2018 07:14:31 +0000 (16:14 +0900)]
evas: don't call filter shutdown twice in evas shutdown
The above filter shutdown call is remained by wrong conflict resolution
Change-Id: I4479f335a394cf89cde844e4d0e157096716ab6a
Wonki Kim [Thu, 26 Jul 2018 04:31:02 +0000 (13:31 +0900)]
Revert "spec: Disable neon temporally"
This reverts commit
0ee57f3b6f17bae02e127463133f1f35e9be3e51.
Change-Id: Ic71a0fb36e736451003d49c128d9a04fe3e9830c
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Youngbok Shin [Thu, 26 Jul 2018 09:29:30 +0000 (18:29 +0900)]
ecore_main: check ecore_event generated by _ecore_main_prepare_handlers
For thread-safet related with wayland, below code was added.
https://review.tizen.org/gerrit/#/c/64820/
after this code, ecore_event related with wayland can be generated by prehandler.
so before waiting the select function, we need to check one more time
that ecore event was generated by prepare handler.
Change-Id: I1f3d5c4431bc277583b12a2754c35c79e308cc77
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Youngbok Shin [Thu, 26 Jul 2018 09:27:55 +0000 (18:27 +0900)]
Fix for missing move-out signal, when scrolling genlist
Change-Id: Idbe8db804eafd350841bb4384b4337c0060d7177
Hermet Park [Tue, 24 Jul 2018 16:04:11 +0000 (12:04 -0400)]
evas canvas: fix not to trigger unnecessary events.
Summary:
Here comparision is logically wrong because it compares
the coordinates(cur, prev) of the different spaces.
As you can see just above the conditions,
Cur coordinates could be transformed into the map space (if objs have)
on the otherhands, prev is not. These wrong condition could occur
embarassing event trigger.
@fix
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6674
Change-Id: I401deade25fe890a3e2bddafd1b0a68f4e388dd2
Joogab Yun [Mon, 16 Jul 2018 10:30:19 +0000 (19:30 +0900)]
[evas_gl_tbm] do not use hash
The newly created address of buffer may be rarely the
same as the previous value.
So, the hash returns the wrong image.
do not use hash as a workaround.
Change-Id: I10400b5d704619ca114324236b96d8006ff6e143
SangHyeon Jade Lee [Mon, 23 Jul 2018 07:49:20 +0000 (16:49 +0900)]
genlist: check item validation in ELM_GENLIST_ITEM_CHECK
Change-Id: Ic29a036858cd0c82e2185c9d457e97d912af0e21
Radoslaw Cybulski [Wed, 18 Jul 2018 10:42:15 +0000 (12:42 +0200)]
Fixes several issues with cleanup in accessibility
Change-Id: I01dcafb562a5ba82746174148133e819fd5c8541
Youngbok Shin [Thu, 26 Jul 2018 09:09:51 +0000 (18:09 +0900)]
evas_events: add storing last mouse device
@tizen_fix
Change-Id: I113326bbf659d4cf72189697b3ed381b27126f80
Umesh Tanwar [Wed, 18 Jul 2018 12:10:21 +0000 (08:10 -0400)]
ecore_evas: when window resized in ecore_evas, check evas rotate state.
Summary:
when ecore_evas is resized, get evas' size,
but angle not checked, so put a check.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: Hermet, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6627
Change-Id: I3342cbb5948f03825345dd42e60a906f998ceec9