Sergei Barannikov [Mon, 30 Jan 2023 01:39:36 +0000 (04:39 +0300)]
[PowerPC] Convert more tests to opaque pointers (NFC)
Kazu Hirata [Mon, 30 Jan 2023 02:08:00 +0000 (18:08 -0800)]
[clang] Remove clang::Optional
This is part of an effort to migrate from llvm::Optional to
std::optional:
https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716
Differential Revision: https://reviews.llvm.org/D142857
bixia1 [Fri, 27 Jan 2023 23:24:02 +0000 (15:24 -0800)]
[mlir][sparse] Change the quick sort pivot selection.
Previously, we choose the value at (lo + hi)/2 as a pivot for partitioning the
data in [lo, hi). We now choose the median for the three values at lo, (lo +
hi)/2, and (hi-1) as a pivot to match the std::qsort implementation.
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D142679
Kshitij Jain [Mon, 30 Jan 2023 01:26:45 +0000 (01:26 +0000)]
[JITLink] Fixes a bug in one of the test files which was causing build failures
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D142856
Sergei Barannikov [Sun, 29 Jan 2023 23:59:37 +0000 (02:59 +0300)]
[PowerPC] Convert more tests to opaque pointers (NFC)
* Add -fast-isel=false to func-alias.ll. The test was added as a
SelectionDAG test. Without this option, FastISel successfully selects
the call that had a ConstantExpr argument.
* fast-isel-branch.ll couldn't be handled by FastISel. Now it can,
hence the change in the stack offsets.
Kshitij Jain [Sun, 29 Jan 2023 17:19:41 +0000 (17:19 +0000)]
[JITLink] Adds support for PLT based relocations to the ELF/i386 JITLink backend
This commit adds support for PLT based relocations. Specifically -
1. It adds logic to create a `PLTTableManager` in the `buildTables_ELF_i386`
function, which is called as part of the post-prune JITLink passes. The `PLTTableManager`
handles creating pointer jump stubs and related GOT entries for position independent
code.
2. It also adds a pre-fixup pass to optimize away PLT based calls in position independent
code, when possible.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D142846
Kazu Hirata [Mon, 30 Jan 2023 00:07:04 +0000 (16:07 -0800)]
[Support] Use llvm::bit_ceil (NFC)
For nonzero X, NextPowerOf2(X) is equivalent to llvm::bit_ceil(X + 1).
Peter Klausler [Fri, 20 Jan 2023 01:01:06 +0000 (17:01 -0800)]
[flang] Fix ENUMERATOR declarations in nested scopes
ENUMERATOR declarations are checking for conflicts between new
enumerator names and names in both the local scope and scopes
that contain it. ENUMERATOR declarations belong to the local
scope and so only a conflict with a name therein is an error.
(In short, use FindInScope rather than FindSymbol.)
Differential Revision: https://reviews.llvm.org/D142773
Kazu Hirata [Sun, 29 Jan 2023 23:39:46 +0000 (15:39 -0800)]
[AST] Use llvm::bit_ceil (NFC)
For nonzero X that is not a power of 2, NextPowerOf2(X) is equivalent
to llvm::bit_ceil(X).
Kazu Hirata [Sun, 29 Jan 2023 23:25:49 +0000 (15:25 -0800)]
[ADT] Use llvm::bit_ceil (NFC)
For nonzero X, NextPowerOf2(X - 1) is equivalent to llvm::bit_ceil(X).
Lang Hames [Sun, 29 Jan 2023 23:08:02 +0000 (15:08 -0800)]
[ORC] Add ordering to ExecutorAddrRanges.
This allows ranges to be sorted and used as map keys.
Peter Klausler [Sun, 29 Jan 2023 22:53:40 +0000 (14:53 -0800)]
[flang][MSVC] Change XFAIL to UNSUPPORTED for disabled test
Test flang/test/Semantics/select-rank02.f90 has an unresolved
failure when built with MSVC on an x86 Windows buildbot, but it passes
on an Arm Windows buildbot. Change XFAIL to UNSUPPORTED to dodge
an XPASS buildbot complaint on the Arm Windows buildbot.
Florian Hahn [Sun, 29 Jan 2023 22:46:17 +0000 (22:46 +0000)]
[VPlan] Add sideffect/read or write test for VPPredInstPHIRecipe. (NFC)
Peter Klausler [Tue, 10 Jan 2023 23:53:12 +0000 (15:53 -0800)]
[flang] Check that DO index variables are definable
We're letting immutable objects appear as DO index variables;
catch and diagnose this error.
Differential Revision: https://reviews.llvm.org/D142767
Sergei Barannikov [Sun, 29 Jan 2023 20:52:16 +0000 (23:52 +0300)]
[PowerPC] Convert some tests to opaque pointers (NFC)
Sylvestre Ledru [Sun, 29 Jan 2023 09:09:16 +0000 (10:09 +0100)]
flang: remove the hardcoded 15 from the release notes
Differential Revision: https://reviews.llvm.org/D142835
Philipp Tomsich [Sun, 29 Jan 2023 21:00:32 +0000 (22:00 +0100)]
[RISCV] Fix wrong comment style. NFC
Philipp Tomsich [Sun, 29 Jan 2023 19:21:11 +0000 (20:21 +0100)]
[RISCV] Alphabetize X-extensions (and add a comment). NFC.
Craig Topper [Sun, 29 Jan 2023 20:30:52 +0000 (12:30 -0800)]
[RISCV] Move IsGPRAsFPR into RegOp struct in RISCVOperand. NFC
This field is only initialized for register operands, move it into
the struct to make that clear.
This also fixes a potential bug where the field wasn't copied by
the RISCVOperand copy constructor.
Craig Topper [Sun, 29 Jan 2023 20:25:00 +0000 (12:25 -0800)]
[RISCV] Move FRM parsing in the assembler to a custom operand parser.
Previously we parsed it as a symbol, and then accessed the name.
This works, but seems like an unusual way to do it.
This adds a custom parser that looks for an Identifier token containing
one of the valid FRM strings.
Differential Revision: https://reviews.llvm.org/D142833
Simon Pilgrim [Sun, 29 Jan 2023 20:14:46 +0000 (20:14 +0000)]
[X86] pr53419.ll - cleanup check-prefixes. NFC.
Avoid using CHECK unless its for all possible RUNs
Peter Klausler [Tue, 17 Jan 2023 21:30:09 +0000 (13:30 -0800)]
[flang] Don't fold REPEAT() when the result would be too large
A test program shouldn't be able to crash the compiler by getting it to
fold REPEAT() with an absurdly large repetition count.
Differential Revision: https://reviews.llvm.org/D142770
Kazu Hirata [Sun, 29 Jan 2023 19:43:10 +0000 (11:43 -0800)]
[Support] Use std::clamp (NFC)
Peter Klausler [Fri, 13 Jan 2023 22:33:57 +0000 (14:33 -0800)]
[flang] Fix defined I/O semantics crash & missing errors that exposed it
Semantics crashes when emitting runtime derived type information tables
for a type that has user-defined I/O procedures declared outside the
type with explicit INTERFACE blocks (as opposed to a GENERIC binding
within the type). This is due to the runtime table constructor
adding a table entry for each specific procedure of any explicit interface
of the right kind (e.g., READ(UNFORMATTED)) that it found, rather than
just the ones that pertain to the derived type in question. But
semantics also wasn't checking such interfaces for distinguishable
specific procedures, either.
Clean these up, improve the spelling of defined I/O procedure kinds
in error messages ("read(formatted)" rather than "READFORMATTED"),
and make error messages stemming from macro expansions only have
one "error:" prefix on the original message so that a new test
would work.
Differential Revision: https://reviews.llvm.org/D142769
Simon Pilgrim [Sun, 29 Jan 2023 18:03:49 +0000 (18:03 +0000)]
[Support] ModRef.h - fix include guard
ModRef.h is part of Support not IR
Fixes clang-tidy warning
Simon Pilgrim [Sun, 29 Jan 2023 18:02:54 +0000 (18:02 +0000)]
[IR] PatternMatch.h - m_SplatOrUndefMask::match - specialise auto to const auto*
Fixes clang-tidy warning
Simon Pilgrim [Sun, 29 Jan 2023 18:01:44 +0000 (18:01 +0000)]
[IR] InstrTypes.h - operandBundleFromBundleOpInfo - specialise auto to const auto*
Fixes clang-tidy warning
Kazu Hirata [Sun, 29 Jan 2023 18:03:15 +0000 (10:03 -0800)]
[Scalar] Remove an unused local varable (NFC)
The last uses of CRs were removed on Jan 17, 2023 in commit
61bb549cfd43fe4753fc78075b626ae18106fbeb.
Kazu Hirata [Sun, 29 Jan 2023 17:43:36 +0000 (09:43 -0800)]
[AST] Use std::clamp (NFC)
Simon Pilgrim [Sun, 29 Jan 2023 16:50:37 +0000 (16:50 +0000)]
[Support] StringSaver.h - add missing closing namespace comment. NFC.
Fixes clang-tidy warning
Simon Pilgrim [Sun, 29 Jan 2023 16:48:21 +0000 (16:48 +0000)]
[Support] ReverseIteration.h - add missing closing namespace comment. NFC.
Fixes clang-tidy warning
Simon Pilgrim [Sun, 29 Jan 2023 16:47:13 +0000 (16:47 +0000)]
[X86] vec_ss_load_fold.ll - use X86 check prefix instead of X32
We try to use X32 for tests on gnux32 triples
Peter Klausler [Tue, 10 Jan 2023 21:26:39 +0000 (13:26 -0800)]
[flang] If it's got an argument keyword, it can't become an array reference
Array references like A(1) are commonly misparsed as function references,
since the parser has almost no semantic context, and the parse tree is
fixed up later by semantics once it can be disambiguated. In a case
like A(I=1), however, the presence of an argument keyword must prevent
conversion into an array reference. (It might still also be a structure
constructor.)
Differential Revision: https://reviews.llvm.org/D142765
Philipp Tomsich [Tue, 24 Jan 2023 17:55:17 +0000 (18:55 +0100)]
[AArch64] Add A+B+1 and A-B-1 macro fusion for Ampere1A
The Ampere1A core supports a new fusion pattern that optimises the
case of A+B+1 and A-B-1. Add support.
Depends on D142396
Differential Revision: https://reviews.llvm.org/D142502
Sanjay Patel [Sun, 29 Jan 2023 15:24:52 +0000 (10:24 -0500)]
[InstSimplify] !(X && Y) || X --> true (for poison-safe logical ops)
https://alive2.llvm.org/ce/z/xuvL46
This is the similar to the existing folds added with:
D138853 /
f2973327496fc966c4e89597
7dbeb127eaf6
...but with the and/or swapped.
Sanjay Patel [Sun, 29 Jan 2023 14:43:14 +0000 (09:43 -0500)]
[InstSimplify] add tests for poison-safe logical nand+or; NFC
Simon Pilgrim [Sun, 29 Jan 2023 14:37:47 +0000 (14:37 +0000)]
[Support] TypeName.h - add missing closing namespace comment. NFC.
Fixes clang-tidy warning
Simon Pilgrim [Sun, 29 Jan 2023 14:30:35 +0000 (14:30 +0000)]
[X86] avx2-conversions.ll - use X86 check prefix instead of X32 + add common CHECK check-prefix
We try to use X32 for tests on gnux32 triples
Simon Pilgrim [Sun, 29 Jan 2023 14:24:45 +0000 (14:24 +0000)]
[X86] wide-scalar-shift-legalization.ll - use X86 check prefix instead of X32
We try to use X32 for tests on gnux32 triples
Simon Pilgrim [Sun, 29 Jan 2023 14:24:28 +0000 (14:24 +0000)]
[X86] wide-scalar-shift-by-byte-multiple-legalization.ll - use X86 check prefix instead of X32
We try to use X32 for tests on gnux32 triples
Simon Pilgrim [Sun, 29 Jan 2023 13:13:33 +0000 (13:13 +0000)]
[X86] matchShuffleAsBlend - keep per-lane blend masks 'whole' if only one input is used
For 32/64-bit element 256-bit X86ISD::BLENDI shuffle masks, see if each sub-lane only references (plus undefs) a single input - in which case ensure the blend mask component for that lane ONLY references that input.
This helps later subvector extraction/insertion nodes to peek through the blend node for that lane.
Matt Arsenault [Fri, 20 Jan 2023 17:03:56 +0000 (13:03 -0400)]
GlobalISel: Include register class/bank in regbankselect debug printing
Ivan Butygin [Sat, 28 Jan 2023 15:14:07 +0000 (16:14 +0100)]
[mlir][gpu][spirv] Gpu min/max reductions lowering to SPIR-V
Differential Revision: https://reviews.llvm.org/D142810
Simon Pilgrim [Sun, 29 Jan 2023 11:03:41 +0000 (11:03 +0000)]
[X86] lowerShuffleAsLanePermuteAndRepeatedMask - retain the per-lane undef elements and don't just copy the repeated mask
lowerShuffleAsLanePermuteAndRepeatedMask expands a shuffle from shuffle(x,y,mask) to shuffle(shuffle(x,y,lanemask1),shuffle(x,y,lanemask2),repeatedinlanemask)
However, we weren't making use of the fact that elements of the original mask might be undef - instead of fully applying the entire repeatedinlanemask to every lane, we can simplify the mask if we never demanded that element in the original mask.
Yet another improvement addressing regressions from D127115
Differential Revision: https://reviews.llvm.org/D142536
Emmmer [Sun, 15 Jan 2023 14:25:40 +0000 (22:25 +0800)]
[LLDB][RISCV] Add RVV registers enums
RVV stands for "RISC-V V Extension", which adds 32 vector registers, and seven unprivileged CSRs (vstart, vxsat, vxrm, vcsr, vtype, vl, vlenb) to a base scalar RISC-V ISA.
The base vector extension is intended to provide general support for data-parallel execution within the 32-bit instruction encoding space, with later vector extensions supporting richer functionality for certain domains.
Reviewed By: DavidSpickett, kito-cheng
Differential Revision: https://reviews.llvm.org/D141898
Ben Shi [Sat, 7 Jan 2023 14:44:57 +0000 (22:44 +0800)]
[ELF][test] Improve AVR relocation tests
Reviewed By: aykevl, MaskRay
Differential Revision: https://reviews.llvm.org/D141197
Ben Shi [Sat, 7 Jan 2023 07:25:38 +0000 (15:25 +0800)]
[AVR] Fix incorrect decoding of conditional branch instructions
This patch fixes the inaccurate decoding of the offset operand of
the conditional branch instructions.
Reviewed By: aykevl
Differential Revision: https://reviews.llvm.org/D140816
Kazu Hirata [Sun, 29 Jan 2023 08:12:52 +0000 (00:12 -0800)]
[llvm] Use llvm::bit_ceil (NFC)
If X is nonzero, NextPowerOf2(X - 1) is equivalent to
llvm::bit_ceil(X). In this patch, std::max guarantees that X is
nonzero.
Craig Topper [Sun, 29 Jan 2023 06:43:20 +0000 (22:43 -0800)]
[RISCV] Simplify code slightly. NFC
These two pieces of code were using a switch with a single case and
a default that always returned.
Replace with an if statement that early returns.
Liming Liu [Sun, 29 Jan 2023 06:27:12 +0000 (14:27 +0800)]
Revert commit
01adf96ebc86 because it caused "Unhandled DeclRefExpr" errors.
Craig Topper [Sun, 29 Jan 2023 06:04:34 +0000 (22:04 -0800)]
[RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.
Differential Revision: https://reviews.llvm.org/D142596
Liming Liu [Tue, 10 Jan 2023 12:28:52 +0000 (20:28 +0800)]
[clang] Add the check of membership in decltype for the issue #58674
D137531 had once fixed the issue. However, it caused a crash during compiling
llvm/unittests/IR/PatternMatch.cpp in stage-2. The reason is the predicator
isDerivedFrom does not consider independent types if the derived type is
dependent.
This patch improves D137531 by adding an option to make isDerivedFrom consider
independent types.
Differential Revision: https://reviews.llvm.org/D142437
Lang Hames [Sat, 28 Jan 2023 05:10:03 +0000 (21:10 -0800)]
[JITLink][MachO] Error on N_EXT symbols with illegal string-table index 0.
Index 0 is reserved for anonymous symbols, which can't have the N_EXT bit
set (since N_EXT means non-local scope, and non-local scope requires a name).
Matt Arsenault [Fri, 6 Jan 2023 23:50:55 +0000 (18:50 -0500)]
AMDGPU: Don't insert pointer bitcasts for printf lowering
Cleanup leftover typed pointer handling.
Peter Klausler [Sun, 29 Jan 2023 01:25:50 +0000 (17:25 -0800)]
[flang][MSVC] Disable test on Windows
A test is crashing the compiler unexpectedly when built with MSVC;
disable it with an XFAIL until it can be analyzed further.
Peter Klausler [Tue, 10 Jan 2023 22:30:27 +0000 (14:30 -0800)]
[flang] Diagnose invalid initializations
f18 current ignores attempts to initialize (with =expr) things
that are not objects, or allows meaningless initializations of
things that have mistakenly been promoted to be objects.
Fix by refusing to promote to objects names that have any
attributes that cannot be applied to objects, and then catch
data initializations of symbols that are not objects.
Differential Revision: https://reviews.llvm.org/D142766
Matt Arsenault [Sat, 7 Jan 2023 21:42:12 +0000 (16:42 -0500)]
Attributes: Check declarations for dereferenceable bytes
This will allow tablegen to start directly marking intrinsics as
dereferenceable in a useful way. Not sure if callsites should override
or use the max.
Alexander Shaposhnikov [Sun, 29 Jan 2023 00:04:51 +0000 (00:04 +0000)]
[Clang] Treat `std::forward_like` as builtin
This diff extends D123345 by adding support for std::forward_like.
Test plan: ninja check-clang check-clang-tools check-llvm
Differential revision: https://reviews.llvm.org/D142430
Kazu Hirata [Sun, 29 Jan 2023 00:13:09 +0000 (16:13 -0800)]
Use llvm::bit_ceil (NFC)
Note that:
std::has_single_bit(X) ? X : llvm::NextPowerOf2(X);
is equivalent to:
std::bit_ceil(X)
even for input 0.
Shilei Tian [Sat, 28 Jan 2023 23:56:00 +0000 (18:56 -0500)]
[OpenMP][NVPTX] Added `__tgt_rtl_launch_kernel` in old CUDA plugin
Fix #60248.
Reviewed By: jhuber6
Differential Revision: https://reviews.llvm.org/D142819
Peter Klausler [Tue, 10 Jan 2023 20:23:57 +0000 (12:23 -0800)]
[flang] Diagnose known out-of-range subscripts in more circumstances
Semantics can catch out-of-range subscript values already when they
appear in DATA statement objects and constant folding of name constant
array indexing; this patch fills the gap by checking known constant
subscript values in other contexts.
Differential Revision: https://reviews.llvm.org/D142764
Kazu Hirata [Sat, 28 Jan 2023 23:24:36 +0000 (15:24 -0800)]
[ADT] Fix a comment typo
Kazu Hirata [Sat, 28 Jan 2023 23:22:37 +0000 (15:22 -0800)]
Use llvm::byteswap instead of ByteSwap_{16,32,64} (NFC)
Kazu Hirata [Sat, 28 Jan 2023 23:04:20 +0000 (15:04 -0800)]
[llvm] Use llvm::bit_width (NFC)
Kazu Hirata [Sat, 28 Jan 2023 23:04:18 +0000 (15:04 -0800)]
[Target] Use llvm::Log2_{32,64} (NFC)
Kazu Hirata [Sat, 28 Jan 2023 23:04:16 +0000 (15:04 -0800)]
[SystemZ] Use llvm::bit_floor (NFC)
Florian Hahn [Sat, 28 Jan 2023 21:33:28 +0000 (21:33 +0000)]
Revert "[SCCP] Support NUW/NSW inference for all overflowing binary operators."
This reverts commit
024115ab14822a97c09adcd2545c14e78b843b36.
I suspect that this may be causing some buildbot bootstrapping failures.
Revert while I investigate.
Kazu Hirata [Sat, 28 Jan 2023 20:41:19 +0000 (12:41 -0800)]
Use llvm::count{lr}_{zero,one} (NFC)
Akash Banerjee [Thu, 26 Jan 2023 14:40:33 +0000 (14:40 +0000)]
[MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP Target Data directives
This enables conversion of OpenMP Target Data, Enter Data and Exit Data from FIR Dialect to LLVM IR Dialect.
Differential Revision: https://reviews.llvm.org/D142629
Kazu Hirata [Sat, 28 Jan 2023 20:14:43 +0000 (12:14 -0800)]
[RISCV] Simplify predicates with llvm::countr_zero (NFC)
It takes less code (in C++ and the host assembly) to get rid of the
trailing zeros and compare against {3,5,9} than divide the immediate
by {3,5,9} and check to see if we have a power of 2.
Amir Ayupov [Sat, 28 Jan 2023 19:49:58 +0000 (11:49 -0800)]
[CMake] Replace clang binary if using clang-bolt target
Instead of creating an extra clang-bolt binary and clang++-bolt symlink,
replace the original clang binary with BOLT-optimized one.
This fixes the issue with installing optimized binary as `install-clang`
target now copies the new version.
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D139454
Kazu Hirata [Sat, 28 Jan 2023 19:33:02 +0000 (11:33 -0800)]
[RISCV] Use llvm::Log2_64 (NFC)
Kazu Hirata [Sat, 28 Jan 2023 19:20:47 +0000 (11:20 -0800)]
[llvm] Use llvm::Log2_64 (NFC)
Peter Klausler [Mon, 9 Jan 2023 23:53:39 +0000 (15:53 -0800)]
[flang] Diagnose fixed form statement that begins with continuation line
A fixed form continuation line should not be the first line of a statement;
emit a warning if it looks like one is so that the programmer can look
for a missing card.
Differential Revision: https://reviews.llvm.org/D142763
Peter Klausler [Mon, 9 Jan 2023 22:16:17 +0000 (14:16 -0800)]
[flang] Warn about defined operator with too few/many dummy arguments
A function in a defined operator generic interface will syntactically
have one or two arguments. If a defined operator includes a specific
function with 0 or more than 2 dummy arguments, there's no way that it
could be invoked by way of the interface. Emit a warning.
Differential Revision: https://reviews.llvm.org/D142762
Florian Hahn [Sat, 28 Jan 2023 17:40:40 +0000 (17:40 +0000)]
[SCCP] Support NUW/NSW inference for all overflowing binary operators.
Extend the NUW/NSW inference logic add in
72121a20cd and
cdeaf5f28c3dc
to all overflowing binary operators.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D142721
Peter Klausler [Thu, 5 Jan 2023 18:40:50 +0000 (10:40 -0800)]
[flang] Enforce ENTRY dummy argument usage restriction
A dummy argument that appears only in ENTRY statements may
not be used in the executable part prior to its first ENTRY
statement.
Differential Revision: https://reviews.llvm.org/D142758
Kazu Hirata [Sat, 28 Jan 2023 17:23:07 +0000 (09:23 -0800)]
[Target] Use llvm::count{l,r}_{zero,one} (NFC)
Mark de Wever [Sat, 21 Jan 2023 12:38:39 +0000 (13:38 +0100)]
[libc++] Addresses LWG3754
LWG3754 Class template expected synopsis contains declarations that do
not match the detailed description
This parts of the detailed synopsis that is not copied in libc++, so
effectively there's nothing to do.
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D142809
Kazu Hirata [Sat, 28 Jan 2023 17:06:31 +0000 (09:06 -0800)]
[llvm] Use llvm::bit_floor instead of llvm::PowerOf2Floor (NFC)
Kazu Hirata [Sat, 28 Jan 2023 16:49:02 +0000 (08:49 -0800)]
[RISCV] Use std::clamp (NFC)
Kirill Stoimenov [Sat, 28 Jan 2023 15:57:21 +0000 (15:57 +0000)]
[LSAN] Remove -fuse-ld=lld from HWASAN config
I needed that to make -fsanitize-hwaddress-experimental-aliasing work, but it looks like the test pass without it also. This should fix https://lab.llvm.org/buildbot/#/builders/192 failures.
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D142812
Hans Wennborg [Sat, 28 Jan 2023 15:38:15 +0000 (16:38 +0100)]
Revert "[X86][ABI] Don't preserve return regs for preserve_all/preserve_most CCs"
This caused Chromium to crash, see comment on the code review.
> Currently both calling conventions preserve registers that are used to
> store a return value. This causes the returned value to be lost:
>
> define i32 @bar() {
> %1 = call preserve_mostcc i32 @foo()
> ret i32 %1
> }
>
> define preserve_mostcc i32 @foo() {
> ret i32 2
> ; preserve_mostcc will restore %rax,
> ; whatever it was before the call.
> }
>
> This contradicts the current documentation (preserve_allcc "behaves
> identical to the `C` calling conventions on how arguments and return
> values are passed") and also breaks [[clang::preserve_most]].
>
> This change makes CSRs be preserved iff they are not used to store a
> return value (e.g. %rax for scalars, {%rax:%rdx} for __int128, %xmm0
> for double). For void functions no additional registers are
> preserved, i.e. the behaviour is backward compatible with existing
> code.
>
> Differential Revision: https://reviews.llvm.org/D141020
This reverts commit
0276fa89d7a4dbe73105c9148f947716b3d8f17f.
Aaron Ballman [Sat, 28 Jan 2023 13:56:22 +0000 (08:56 -0500)]
Fix Clang sphinx build
This addresses the issue found in:
https://lab.llvm.org/buildbot/#/builders/92/builds/39306
Matt Arsenault [Fri, 27 Jan 2023 00:25:17 +0000 (20:25 -0400)]
AMDGPU: Convert fcopysign tests to generated checks and add cases
Matt Arsenault [Tue, 13 Dec 2022 18:26:25 +0000 (13:26 -0500)]
AMDGPU: Add fneg and select test
eopXD [Wed, 18 Jan 2023 13:50:19 +0000 (05:50 -0800)]
[Clang][RISCV] Simplify RVV intrinsic policy suffix
This patch works towards the simplification proposal [0] of Nick
Knight. After this patch, we have reduced the hierarchy of intrinsics
from two sets (non-policy and policy) into a single set, with a general
assumption that policy behavior is agnostic unless specified.
[0] https://gist.github.com/nick-knight/
6cb0b74b351a25323dfb1821d3a269b9
Pull Request: riscv-non-isa/rvv-intrinsic-doc#186.
Depends on D141796.
Reviewed By: craig.topper, kito-cheng
Differential Revision: https://reviews.llvm.org/D142016
Benjamin Kramer [Sat, 28 Jan 2023 10:04:57 +0000 (11:04 +0100)]
[bazel] Adjust lsp-server-support include paths for
305d71853965
Benjamin Kramer [Sat, 28 Jan 2023 10:01:07 +0000 (11:01 +0100)]
[bazel] Add a dep from target asm parsers to :TargetParser
This is needed for the AArch64 asm parser after
9ea00fc74c3c
Chenguang Wang [Sat, 28 Jan 2023 09:58:55 +0000 (10:58 +0100)]
[bazel][mlir] Remove references to SubElementInterfaces.
It was removed in D142272.
This commit is manually verified with:
bazel test --config=generic_clang @llvm-project//mlir/unittests:ir_tests
Reviewed By: bkramer
Differential Revision: https://reviews.llvm.org/D142789
Kazu Hirata [Sat, 28 Jan 2023 08:49:38 +0000 (00:49 -0800)]
[RISCV] Use llvm::bit_floor and std::clamp (NFC)
Kazu Hirata [Sat, 28 Jan 2023 08:45:19 +0000 (00:45 -0800)]
Use std::optional instead of llvm::Optional (NFC)
Craig Topper [Sat, 28 Jan 2023 07:41:06 +0000 (23:41 -0800)]
[RISCV] Refine the (mul (zext.w X), C) -> mulhu isel heuristic.
We try to shift both X and C left by 32 to replace the zext.w
with a SLLI and use mulhu. If C is already a simm32, this likely
makes a constant that is more expensive to materialize.
Shivam Gupta [Sat, 28 Jan 2023 05:01:33 +0000 (10:31 +0530)]
[Docs] Fix a statement wrt instruction alignment of 0
Noah Goldstein [Fri, 27 Jan 2023 23:26:41 +0000 (17:26 -0600)]
Recommit "Reorder (shl (add/sub (shl x, C0), y), C1) -> (add/sub (shl x, C0 + C1), (shl y, C1))" 2nd Try
First time caused build failure:
https://lab.llvm.org/buildbot/#/builders/183/builds/10447
but after investigating it seems to be unrelated. The same
test/build passed later with the original commit here:
https://lab.llvm.org/buildbot/#/builders/183/builds/10448
This is just expanding the existing pattern that exists for AND/XOR/OR
and gets a bit more parallelism in from the instruction sequence.
Alive2:
Add - https://alive2.llvm.org/ce/z/dSmPkV
Sub1 - https://alive2.llvm.org/ce/z/6rpi5V
Sub2 - https://alive2.llvm.org/ce/z/UfYeUd
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D141875
Noah Goldstein [Fri, 27 Jan 2023 23:26:19 +0000 (17:26 -0600)]
Recommit "Add optimizations for icmp eq/ne (mul(X, Y), 0)" 2nd Try
First time caused build failure:
https://lab.llvm.org/buildbot/#/builders/183/builds/10447
but after investigating it seems to be unrelated. The same
test/build passed later with the original commit here:
https://lab.llvm.org/buildbot/#/builders/183/builds/10448
1. Add checks if X and/or Y are odd. The Odd values are unnecessary to
the icmp: isZero(Odd * N) == isZero(N)
2. If neither X nor Y is known odd, then if X * Y cannot overflow AND
if X and/or Y is non-zero, the non-zero values are unnecessary to the
icmp.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D140850
Kazu Hirata [Sat, 28 Jan 2023 02:33:25 +0000 (18:33 -0800)]
[X86] Use llvm::bit_ceil (NFC)
The argument is known to be nonzero, so we can safely switch to
llvm::bit_ceil.
Matt Arsenault [Sat, 28 Jan 2023 02:14:05 +0000 (22:14 -0400)]
llvm-reduce: Add REQUIRES: default_triple to test
Allegedly fixes test failure if there are no targets built.
Matt Arsenault [Sat, 28 Jan 2023 02:00:25 +0000 (22:00 -0400)]
LoopStrengthReduce: Convert AMDGPU tests to opaque pointers
Matt Arsenault [Thu, 3 Nov 2022 06:42:58 +0000 (23:42 -0700)]
AMDGPU: Support atomicrmw uinc_wrap/udec_wrap
For now keep the exising intrinsics working.