Sebastian Dröge [Mon, 8 Nov 2021 13:30:18 +0000 (15:30 +0200)]
bin: Switch `g_warning()`s to `GST_WARNING_OBJECT()`s when adding/removing an element to a bin fails
The failure conditions can be overidden by subclasses, and a boolean
return value is provided to the caller whether adding/removing the child
element has actually worked. The caller can then handle this
accordingly but flooding stderr with this is not very useful.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1320>
Zhao, Gang [Sat, 6 Nov 2021 08:48:20 +0000 (16:48 +0800)]
vpxdec: Skip check of key frame when open GOP
Valid stream [1] might has no key frame.
Fixed: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/890
[1] https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/vp90-2-16-intra-only.webm
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1316>
Tim-Philipp Müller [Mon, 18 Oct 2021 16:42:37 +0000 (17:42 +0100)]
gst-integration-tests: medias: update git module to latest commit
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1184>
Joe Todd [Tue, 5 Oct 2021 17:07:06 +0000 (18:07 +0100)]
osxaudio: Increase max channels to 64
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1059>
Nicolas Dufresne [Fri, 24 Sep 2021 12:19:51 +0000 (08:19 -0400)]
gstinfo: Fix leak in generate_backtrace_trace
Spotted by Laurent Pinchart.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/901>
Martin Reboredo [Fri, 21 May 2021 19:56:33 +0000 (16:56 -0300)]
aom: Set fixed_qp_offsets to a deactivated value
aom only uses fixed_qp_offsets with the
Constant Quality (Q) Rate Control mode,
previously this was locking any usage
with another Rate Control mode.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1198>
Thibault Saunier [Mon, 8 Nov 2021 14:08:45 +0000 (11:08 -0300)]
meson:ges: Fix typo adding ges gir to libs list
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1322>
Nirbheek Chauhan [Thu, 4 Nov 2021 07:54:57 +0000 (13:24 +0530)]
gst-ptp-helper: Do not disable multicast loopback
Otherwise we cannot run gst-ptp-helper if the PTP master is on the
same device.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1306>
Thibault Saunier [Fri, 5 Nov 2021 14:36:11 +0000 (11:36 -0300)]
tests:ges: Take TIMEOUT_FACTOR into account
This env var is set in the CI so we grow the timeout as required
(when running in valgrind for example).
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/jobs/
15449209
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1315>
Antonio Ospite [Fri, 5 Nov 2021 12:12:14 +0000 (13:12 +0100)]
magicleap: update lumin_rt libraries names to the latest official version
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1314>
He Junyan [Mon, 4 Oct 2021 17:07:57 +0000 (01:07 +0800)]
codecs: h264dec: Calculate the latency by its bump mode.
The current latency calculation just uses the num_reorder_frames,
which is not very precise. We should consider the bump mode of the
DPB, the faster it bumps, the lower latency we will have.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1046>
Thibault Saunier [Thu, 4 Nov 2021 19:06:22 +0000 (19:06 +0000)]
doc: Update nvdec documentation
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/870
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1309>
Sanchayan Maity [Fri, 5 Nov 2021 09:47:20 +0000 (15:17 +0530)]
imagefreeze: Only set caps if they do not match current caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1311>
Seungha Yang [Wed, 3 Nov 2021 08:09:52 +0000 (17:09 +0900)]
h264parse: Don't insert extra AUD if exists in bitstream already
AUD nalu in packetized format is completely valid and therefore we should not
assume that we should insert AUD for packetized -> bytestream
conversion.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/862
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296>
Seungha Yang [Wed, 3 Nov 2021 11:36:09 +0000 (20:36 +0900)]
tests: h264parse: Add test for AUD insertion
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296>
Sebastian Dröge [Thu, 4 Nov 2021 14:04:30 +0000 (16:04 +0200)]
v4l2: Support bools for setting extra-controls
They're just mapped to 0 / 1 and can already be set as integers, but
being able to set them as booleans seems useful.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1308>
Seungha Yang [Thu, 4 Nov 2021 07:36:05 +0000 (16:36 +0900)]
wasapi2ringbuffer: Fix client object leak
Check whether ringbuffer is holding client object already since
open_device() may be called multiple times
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1307>
Sebastian Dröge [Thu, 4 Nov 2021 10:48:28 +0000 (12:48 +0200)]
webrtcbin: Clear errors from finding codec preferences before the next iteration
The media is just skipped and the error is not propagated to the caller,
so keeping it around here would cause assertions a bit later when trying
to set a new error over the old one.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291>
Sebastian Dröge [Thu, 4 Nov 2021 10:45:34 +0000 (12:45 +0200)]
webrtcbin: Move addition of attributes to the caps after making sure they're not empty or any
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291>
Sebastian Dröge [Tue, 2 Nov 2021 09:21:34 +0000 (11:21 +0200)]
webrtcbin: Don't require fixed caps when querying caps for a transceiver pad to match it with a media
Upstream caps might for example be
application/x-rtp,media=audio,encoding-name={OPUS, X-GST-OPUS-DRAFT-SPITTKA-00, multiopus}
and while that is not fixed caps it is enough to match it with a media.
Only caps structures that have the correct structure name and that have
the media and encoding-name field are preserved, but if both are present
then these caps are used as "codec preferences".
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291>
Marcin Kolny [Thu, 4 Nov 2021 09:30:31 +0000 (09:30 +0000)]
typefind: fix reading file extension from URI
Currently reading extension relies on the fact that everything after the
last"." character is a file extension. Whereas that works fine for most
of the cases, it breaks when the URI contains a query part.
E.g.: `http://url.com/file.mp4?param=value` returns `mp4?param=value`
instead of `mp4`.
In this commit we use URI parser to read the path of the URI (in the example
above, that is `/file.mp4`) and read extension from that path.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1305>
Tim-Philipp Müller [Wed, 3 Nov 2021 18:44:03 +0000 (18:44 +0000)]
Back to development
Tim-Philipp Müller [Wed, 3 Nov 2021 15:43:36 +0000 (15:43 +0000)]
Release 1.19.3
Tim-Philipp Müller [Wed, 3 Nov 2021 15:43:32 +0000 (15:43 +0000)]
Update ChangeLogs for 1.19.3
Nicolas Dufresne [Tue, 2 Nov 2021 20:09:52 +0000 (16:09 -0400)]
ci: Do not clone in the trigger job
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1298>
Sebastian Dröge [Tue, 2 Nov 2021 14:46:08 +0000 (16:46 +0200)]
multifilesink: Make minimum distance between keyframes in next-file=key-frame mode configurable
Previously this was hardcoded to 10s, which is not necessarily the
desired behaviour.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1292>
Erlend Eriksen [Mon, 1 Nov 2021 15:32:10 +0000 (16:32 +0100)]
qtmux: Fix deadlock in gst_qt_mux_prepare_moov_recovery
Regression from
5766731bd4200c3a374522a749386f740347661a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1288>
Matthias Clasen [Mon, 1 Nov 2021 19:48:58 +0000 (15:48 -0400)]
egl: handle configless contexts
With EGL_KHR_no_config_context, EGL contexts may just not
have an EGLConfig to give you. Deal with it.
Fixes: #858
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1289>
Seungha Yang [Fri, 29 Oct 2021 16:55:38 +0000 (01:55 +0900)]
examples: win32-videooverlay-playbin: Add a repeat option
... in order to test pipeline/element reuse cases.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1275>
Nicolas Dufresne [Tue, 2 Nov 2021 13:40:43 +0000 (09:40 -0400)]
codecs: mpeg2: Drain before a new_sequence get signalled
The decoder may need to re-allocate the output buffer, it is easier if all
pictured have been outputed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Thu, 8 Apr 2021 19:24:49 +0000 (16:24 -0300)]
v4l2codecs: gstv4l2codecsmpeg2dec: implement a render delay
The v4l2 backend support delayed output for performance reasons.
It is then possible to use render delays to queue multiple requests
simultaneously, thus increasing performance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Thu, 8 Apr 2021 19:07:23 +0000 (16:07 -0300)]
codecs: gstmpeg2decoder: add support for render delay
Some decoding APIs support delayed output for performance reasons.
One example would be to request decoding for multiple frames and
then query for the oldest frame in the output queue.
This also increases throughput for transcoding and improves seek
performance when supported by the underlying backend.
Introduce support in the mpeg2 base class, so that backends that
support render delays can actually implement it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Tue, 6 Apr 2021 19:40:28 +0000 (16:40 -0300)]
v4l2codecs: Implement a MPEG2 V4L2 decoder element
Implement a MPEG2 V4L2 decoder element based on the previous h264
implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Tue, 6 Apr 2021 19:42:54 +0000 (16:42 -0300)]
v4l2codecs: mpeg2: update to the new uAPI
The mpeg2 stateless api has undergone changes as it is being
destage. Update the v4l2-controls header to match.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Fri, 26 Mar 2021 18:52:21 +0000 (15:52 -0300)]
sys: va: GstVaMpeg2Dec: use slice sc_offset and size
Seeing as how GstMpeg2Slice will now record the start code offset
as well as its size with the above field taken into account, the
manual computation in this class is not needed.
Remove it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
Daniel Almeida [Fri, 26 Mar 2021 18:31:51 +0000 (15:31 -0300)]
codecs: GstMpeg2Slice: add field for sc_offset and size
Downstream might need the start code offset when decoding.
Previously this computation would be scattered in multiple sites. This
is error prone, so move it to the base class. Subclasses can access
slice->sc_offset directly without computing the address themselves
knowing that the size will also take the start code into account.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013>
James Cowgill [Wed, 20 Oct 2021 11:11:49 +0000 (12:11 +0100)]
v4l2codecs: Handle allocator creation failure
If `VIDIOC_REQBUFS` doesn't return enough buffers the allocator creation
function can fail and return `NULL`. Handle this by generating an error
and returning instead of segfaulting.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220>
James Cowgill [Wed, 20 Oct 2021 11:08:49 +0000 (12:08 +0100)]
v4l2codecs: Fix segfault when destroying non-detached allocator
The GstV4l2CodecAllocator dispose function clears `self->decoder` but
the finalize function then tries to use it if the allocator has no been
detached yet.
Fix by detaching in the dispose function before we clear
`self->decoder`.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220>
Guillaume Desmottes [Tue, 2 Nov 2021 09:14:28 +0000 (10:14 +0100)]
re-add gst-plugins-rs.wrap
It's been lost during the monorepo migration.
Note that building Rust plugins as a subproject is currently broken,
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/171
but I'm going to fix that.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1290>
Julian Bouzas [Fri, 29 Oct 2021 20:08:20 +0000 (16:08 -0400)]
alphacombine: use the same allocation query data for both decoders
This allows downstream elements to set allocation query parameters for both
decoders, which should be always the same.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1277>
Nirbheek Chauhan [Sun, 31 Oct 2021 08:13:40 +0000 (13:43 +0530)]
applemedia: Add ARGB64_BE, RGBA64_LE support to vtenc/vtdec
We can add this now that ARGB64_BE videoconvert support was added in:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Tue, 19 Oct 2021 20:49:33 +0000 (02:19 +0530)]
vtenc: Add FieldDetail properties for interlaced input
Standard interlace handling:
* If we have interlace-mode=interleaved and the field order, we just
set it when creating the session
* If we have interlace-mode=(interleaved|mixed) and no field order, we
set the field order on the first buffer
The encoder session does not support changing the FieldDetail after it
has started encoding frames, so we cannot support mixed streams
correctly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Tue, 19 Oct 2021 20:19:29 +0000 (01:49 +0530)]
vtenc: Add a property to forcibly ignore alpha values
This PropertyKey is not documented in any headers anywhere, so we need
to define it ourselves.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Tue, 19 Oct 2021 18:23:39 +0000 (23:53 +0530)]
vtenc: Set colorimetry information
It looks like VideoToolbox doesn't support all our colorimetries.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Sun, 17 Oct 2021 13:24:10 +0000 (18:54 +0530)]
applemedia: Add ProRes support to vtenc and vtdec
For vtdec, we continue to prefer NV12; else we pick whatever
downstream wants. In the special case where we're decoding 10-bit or
12-bit ProRes formats, we will prefer AYUV64.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Sun, 17 Oct 2021 13:49:15 +0000 (19:19 +0530)]
vtenc: Improve error reporting in chain function
Otherwise it is quite difficult to figure out why the chain function
failed. Also assert not reached for case statements that should not be
hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Nirbheek Chauhan [Thu, 14 Oct 2021 06:44:49 +0000 (12:14 +0530)]
vtdec: Remove dead code in switch statement
We never advertise these formats, so these cases will never be hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214>
Piotrek Brzeziński [Sun, 31 Oct 2021 19:20:08 +0000 (20:20 +0100)]
mediatype-video-raw: add ARGB64_LE/BE and variants
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1286>
Xavier Claessens [Thu, 28 Oct 2021 14:09:21 +0000 (10:09 -0400)]
Allow Strawberry Perl on Windows with Meson >= 0.60.0
Meson now explicitly blacklists pkg-config.bat from Strawberry Perl and
thus building GStreamer on Windows has been fixed.
This allows for instance to build GStreamer on GitHub Action Windows
runners that have Strawberry Perl by default.
It is also useful when needing to build OpenSSL on the same Windows
machine because it requires Perl.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1263>
Sebastian Dröge [Sat, 30 Oct 2021 13:22:39 +0000 (16:22 +0300)]
video: Fix order of new video formats
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1282>
Sebastian Dröge [Sat, 30 Oct 2021 12:50:30 +0000 (15:50 +0300)]
base: Fix some annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1281>
Tim-Philipp Müller [Fri, 29 Oct 2021 23:58:55 +0000 (00:58 +0100)]
Couple more g_memdup() -> g_memdup2() fixes
Fixes deprecation warnings with newer GLib versions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>
Tim-Philipp Müller [Fri, 29 Oct 2021 23:52:42 +0000 (00:52 +0100)]
dtls: don't use deprecated g_binding_get_source() with newer GLib versions
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>
Tim-Philipp Müller [Fri, 29 Oct 2021 23:34:35 +0000 (00:34 +0100)]
Use g_pattern_spec_match() instead of g_pattern_match() which is deprecated since glib 2.70
Fixes compiler warnings with glib 2.70
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279>
Seungha Yang [Fri, 29 Oct 2021 16:41:51 +0000 (01:41 +0900)]
codecs: h265decoder: Fix per-slice leak
As documented, slice header parsed via gst_h265_parser_parse_slice_hdr()
should be cleared, otherwise it would result in memory leak.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1274>
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 14:05:24 +0000 (16:05 +0200)]
va: Delay decoders downstream negotiation.
Delay decoders downstream negotiation just before an output frame
needs to be allocated.
This is required, are least for H.264 and H.265 decoders, since
codec_data might trigger a new sequence before finishing upstream
negotiation, and sink pad caps need to set before setting source pad
caps, particularly to forward HDR fields. The other decoders are
changed too in order to keep the same structure among them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:41:53 +0000 (09:41 +0200)]
vabasedec: Move warning message to decoder's category.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:28:10 +0000 (09:28 +0200)]
va: Move common variable need_negotiation to GstBaseDec.
This is a common variable to all decoders, so it's sound to move it to
the base helper.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:23:42 +0000 (09:23 +0200)]
va: Move back parent_object to each element.
Using GstBaseDec hack to access the parent_object of each element in
the element itself is a bit fragile. It would be better to keep its
own parent object as the usual global variable. It would make it
resistant to code changes.
The GstBaseDec macro to access the parent object now it's internal to
base decoder.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>
Piotrek Brzeziński [Fri, 22 Oct 2021 22:44:57 +0000 (00:44 +0200)]
video-format: Add support for ARGB64 LE/BE and similar variants
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247>
Vivia Nikolaidou [Fri, 29 Oct 2021 10:27:37 +0000 (13:27 +0300)]
identity: Fix crash when receiving a gap event outside the current segment
We were checking if the start time of the gap event was
GST_CLOCK_TIME_NONE, which is superfluous because that cannot happen,
and then not checking if it was NONE after gst_segment_to_running_time,
which caused a crash if an identity received a gap event fully or
partially outside the current segment.
This patch was done in cooperation with:
Jan Alexander Steffens (heftig) <jan.steffens@ltnglobal.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1269>
Mathieu Duponchelle [Fri, 29 Oct 2021 01:46:25 +0000 (03:46 +0200)]
rtptwcc: don't assume all PacketInfo->data are buffers
They can also be buffer lists
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1268>
Heiko Becker [Sun, 26 Sep 2021 19:34:30 +0000 (21:34 +0200)]
neon: Allow building against neon 0.32.x
No API/ABI changes: https://github.com/notroj/neon/blob/0.32.0/NEWS#L3
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1267>
Tim-Philipp Müller [Mon, 25 Oct 2021 10:37:45 +0000 (11:37 +0100)]
meson: require matching GStreamer dep versions for unstable development releases
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/929
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>
Tim-Philipp Müller [Mon, 25 Oct 2021 14:57:36 +0000 (15:57 +0100)]
subprojects: fdk-aac: add fallback_url
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>
Mathieu Duponchelle [Tue, 26 Oct 2021 22:20:57 +0000 (00:20 +0200)]
webrtcbin: fix check_negotiation computing on caps event
It seems logical that check_negotiation be true if received_caps
is *not* equal to the new caps.
Also clean up handling of transceivers' ssrc events, as this
patch triggered a leaky code path.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>
Mathieu Duponchelle [Fri, 22 Oct 2021 23:54:05 +0000 (01:54 +0200)]
webrtcbin: connect input stream when receiving caps
.. if a current direction has already been set
When `webrtcbin` has created an offer based on codec_preferences,
it might not have received caps on its sinkpads by the time a
remote description is set, in which case we want to connect the
input stream upon actual reception of the caps instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>
Mathieu Duponchelle [Mon, 18 Oct 2021 13:23:48 +0000 (15:23 +0200)]
webrtcbin: consider pads with trans->codec_preferences ready
.. when determining whether we can emit on-negotiation-needed
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>
Tim-Philipp Müller [Thu, 28 Oct 2021 16:41:54 +0000 (17:41 +0100)]
mpeg4videoparse: fix criticals trying to insert configs that don't exist yet
With mpeg4videoparse drop=false config-interval=N|-1 we might be
trying to insert a config before we have actually received one,
in which case we'll try to map a NULL buffer which will generate
lots of criticals.
Fixes #855
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1265>
Jan Schmidt [Thu, 28 Oct 2021 10:37:47 +0000 (21:37 +1100)]
qtdemux: Fix text and closed-caption handling.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182
broke text and and closed caption extraction when introducing WebVTT
support, by making the output buffers not have timestamps any more.
Fix that by making the process functions copy buffer metadata
when generating new output buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1262>
Mengkejiergeli Ba [Wed, 20 Oct 2021 09:46:10 +0000 (17:46 +0800)]
msdk: Insert hdr sei at hevc encoder
There are two HDR SEIs defined in spec: mastering display colour volume and
content light level. Add insertion of HDR SEIs when they are available
during encoding.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1242>
Rob Agar [Thu, 21 Oct 2021 15:12:06 +0000 (16:12 +0100)]
webrtcbin: Also check data channel transport when collating connection state
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/838
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1224>
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:54:09 +0000 (11:54 +0200)]
vapostproc: Color fixation will choose othercaps' structure.
gst_va_fixate_format() will iterate all othercaps' structures to find
the one with less information lost at color conversion. If a structure
with same color format is found, the iteration stops. It's like a
smart truncation. Then, this function also will choose the caps
feature.
Later this structure is used fixate its size and no further truncation
is needed.
Don't intersect at fixate, since it kills possible resizing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:53:28 +0000 (11:53 +0200)]
vapostproc: Ignore direction at orientation swapping.
It doesn't matter the direction of the negotiation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 08:31:04 +0000 (10:31 +0200)]
vapostproc: Consider video orientation for border calculation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>
Jan Schmidt [Wed, 27 Oct 2021 11:49:44 +0000 (22:49 +1100)]
decodebin3: Only unblock for GAP events and buffers.
An alternate fix for
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1239
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1236
that makes it clear the intent is to only unblock on a GAP event, and
not any others.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1260>
Chris Wiggins [Wed, 27 Oct 2021 04:20:39 +0000 (17:20 +1300)]
python: Update audiotestsrc to return correct tuple on FlowReturn Errors
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1259>
Timo Wischer [Wed, 6 Oct 2021 14:00:56 +0000 (16:00 +0200)]
avtpsrc: Retry receive with same buffer size
Without this patch in case of a retry recv() will be called with a
negative size argument.
Signed-off-by: Timo Wischer <timo.wischer@de.bosch.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1078>
Guillaume Desmottes [Tue, 26 Oct 2021 13:12:16 +0000 (15:12 +0200)]
parsebin: fix critical when sorting pads
If the pad does not have a current caps, get_pad() returns the query
caps which can be ANY. In such case the caps does not have any structure
resulting in a critical warning when calling gst_caps_get_structure().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1254>
Mathieu Duponchelle [Tue, 26 Oct 2021 14:00:36 +0000 (16:00 +0200)]
cccombiner: fix default value when installing schedule property
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>
Mathieu Duponchelle [Tue, 26 Oct 2021 13:58:26 +0000 (15:58 +0200)]
cccombiner: fix emission of selected-samples in one case
Detected while reading the code, cccombiner must set
self->current_video_buffer to NULL *after* emitting selected-samples
in order for the application to get a useful return when peeking
the next video sample.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>
Mathieu Duponchelle [Mon, 25 Oct 2021 23:09:58 +0000 (01:09 +0200)]
cccombiner: stop attaching caption buffers when caption pad has gone EOS
When schedule is true (as is the case by default), we insert padding
when no caption data is present in the schedule queue, and previously
weren't checking whether the caption pad had gone EOS, leading to
infinite scheduling of padding after EOS on the caption pad.
Rectify that by adding a "drain" parameter to dequeue_caption()
In addition, update the captions_and_eos test to push valid cc_data
in: without this cccombiner was attaching padding buffers it had
generated itself, and with that patch would now stop attaching
said padding to the second buffer. By pushing valid, non-padding
cc_data we ensure a caption buffer is indeed attached to the first
and second video buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>
Matthew Waters [Tue, 26 Oct 2021 08:11:19 +0000 (19:11 +1100)]
ci/fuzzing: update for mono repo
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1253>
Mats Lindestam [Wed, 20 Oct 2021 11:19:00 +0000 (13:19 +0200)]
curlsftpsink: Add support for sha256 fingerprint
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1193>
Mengkejiergeli Ba [Thu, 21 Oct 2021 03:09:07 +0000 (11:09 +0800)]
msdkvpp: Add 12bit formats
Add 12bit formats for different chroma samplings at sink pad and
src pad, including P012_LE, Y212_LE and Y412_LE.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1218>
Ruben Gonzalez [Mon, 25 Oct 2021 19:55:25 +0000 (21:55 +0200)]
devicemonitor: g_queue_clear_full introduced in glib 2.60
The GStreamer dependency is glib >=2.56.0. Therefore, define
g_queue_clear_full if glib < 2.60.
Issue added in commit
1912bcbc
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1251>
Floris [Mon, 25 Oct 2021 16:52:24 +0000 (18:52 +0200)]
gs: update README to use fixed versions
Use specific versions, instead of relying on 'master'.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>
Floris [Mon, 25 Oct 2021 16:47:46 +0000 (18:47 +0200)]
gssrc: use default blocksize
The blocksize is set to 3 * 1024 * 1024 / 2, which is the default download_size of Google-Cloud-CPP.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/846
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>
Víctor Manuel Jáquez Leal [Mon, 25 Oct 2021 14:53:14 +0000 (16:53 +0200)]
vah265dec: Fix end_picture() vmethod.
Since commit
88437a9c the signature of h265decoder's end_picture()
changed to return GstFlowReturn, but vah265dec was not updated.
This commit fixes this regression.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1248>
Sebastian Dröge [Tue, 19 Oct 2021 10:39:55 +0000 (13:39 +0300)]
devicemonitor: Only fail start() if no provider at all could be started
Also refactor various internals of the monitor code:
- Don't allow starting twice but just return directly when starting a
second time.
- Don't end up in an inconsistent state if call start() a second time
while the monitor is starting up.
- Remove complicated cookie code: it was not possible to add/remove
filters while the monitor was started anyway so this was only useful
in the very small time-window while starting the monitor or while
getting the devices. Instead disallow adding/removing filters while
the monitor is starting, and when getting devices work on a snapshot
of providers/filters.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/667
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1189>
Tim-Philipp Müller [Sun, 16 May 2021 00:00:53 +0000 (01:00 +0100)]
docs: contribute: bump compiler reqs and coding style to C99
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-project/-/issues/78
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1243>
Sebastian Dröge [Sat, 23 Oct 2021 13:06:54 +0000 (16:06 +0300)]
typefindfunctions: Use memcmp() instead of a strange macro around strncmp()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>
Sebastian Dröge [Sat, 23 Oct 2021 11:31:59 +0000 (14:31 +0300)]
typefindfunctions: Add various CMAF brands to the MP4 typefinder
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>
Sebastian Dröge [Sat, 23 Oct 2021 11:30:02 +0000 (14:30 +0300)]
typefindfunctions: Refactor ftyp brands checking
Store known brands in arrays and add a helper function to check them.
Also add all the `iso3` to `isob` ISO brands and the `hlsf` ISO
fragmented brand.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>
Sebastian Dröge [Sat, 23 Oct 2021 11:28:35 +0000 (14:28 +0300)]
typefindfunctions: Add various other boxes to the list of known top-level MP4 boxes
styp, udta, sidx, ssix, prft, mfra, pdin and meta are in the ISOBMFF
spec and emsg in the CMAF spec.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:32:30 +0000 (17:32 +0800)]
va: allocator: Fix possible memory leaks
At gst_va_dmabuf_allocator_setup_buffer_full, static code analysis tool
does not know number of objects in descriptor is always larger than 0 if
export_surface_to_dmabuf succeeds. Thus, the tool will assume buf is
allocated with mem but not released when desc.num_objects equals to 0
and raise a mem leak issue.
For gst_va_dambuf_memories_setup, we should also inform the tool that
n_planes will be larger than 0 by checking the value at very beginning.
Then, the defect similar to above will not be raised during static analysis.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1241>
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:36 +0000 (01:02 +0100)]
gst-plugins-ugly: update translations
Fixes #656
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:28 +0000 (01:02 +0100)]
gst-plugins-bad: update translations
Fixes #656
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:07 +0000 (01:02 +0100)]
gst-plugins-good: update translations
Fixes #656
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>
Tim-Philipp Müller [Mon, 25 Oct 2021 00:01:56 +0000 (01:01 +0100)]
gst-plugins-base: update translations
Fixes #656
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>