platform/upstream/coreclr.git
7 years agogdbjit symbols exported (#11739)
chunseoklee [Thu, 1 Jun 2017 16:51:31 +0000 (01:51 +0900)]
gdbjit symbols exported (#11739)

* multiple export files as input for generate_exports_file

Now, generate_exports_file is able to process multiple input arguments.
This feature is useful when you want to export additional symbols depending on
compile time dependannt feature(-D option.)

* export file for gdbjit added

src/dlls/mscoree/gdbjit_unixexports.src file added
To enable gdbjit feature, libcoreclr.so should have __jit_xxx
symbols.
Current tizen build system removes .symtab section during rpm debuginfo
build. This patch moves __jit_xx symbols into .dynsym section.

7 years ago[Arm64] Use inner shareable for instGen_MemoryBarrier
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Tue, 16 May 2017 17:37:28 +0000 (17:37 +0000)]
[Arm64] Use inner shareable for instGen_MemoryBarrier

7 years ago[Arm64] Use half barriers for IL Volatile implementation
Steve MacLean [Fri, 12 May 2017 16:44:08 +0000 (12:44 -0400)]
[Arm64] Use half barriers for IL Volatile implementation

7 years agoUpdating version of xUnit-Performance-Api (#11987)
José Rivero [Thu, 1 Jun 2017 15:56:27 +0000 (08:56 -0700)]
Updating version of xUnit-Performance-Api (#11987)

- This update contains a fix for this issue: https://github.com/Microsoft/xunit-performance/issues/230
- Consolidate the Api version in two places: `dependencies.prop` and `PerfHarness.csproj`
- Move performance log files to root directory where Jenkins can archive them
- Fixed the output to console, so it is easier to see on the Jenkins job the sccript steps live and get an exact repro step if needed

7 years agoFixes deserializaing TimeZoneInfo by putting back the IDeserializationCallback.OnDese...
Morgan Brown [Thu, 1 Jun 2017 12:09:07 +0000 (05:09 -0700)]
Fixes deserializaing TimeZoneInfo by putting back the IDeserializationCallback.OnDeserialization method. (#12024)

7 years ago[x64/Linux] Use correct argument registers in InterpreterStub (#12002)
Jonghyun Park [Thu, 1 Jun 2017 08:49:33 +0000 (17:49 +0900)]
[x64/Linux] Use correct argument registers in InterpreterStub (#12002)

* [x64/Linux] Use correct argument registers in InterpreterStub

* Adjust Linux/Windows ABI difference

* Use macros instead of array

* Follow naming convention

7 years agoMerge pull request #11988 from stephentoub/fix_fds
Stephen Toub [Thu, 1 Jun 2017 03:05:06 +0000 (23:05 -0400)]
Merge pull request #11988 from stephentoub/fix_fds

Ensure several runtime file descriptors are CLOEXEC

7 years agoRemove GCX_PREEMP call when allocating a buffer. (#12016)
Brian Robbins [Wed, 31 May 2017 23:48:56 +0000 (16:48 -0700)]
Remove GCX_PREEMP call when allocating a buffer. (#12016)

7 years agoPost-Serialization cleanup fixes to Reflection (#12010)
Atsushi Kanamori [Wed, 31 May 2017 23:40:04 +0000 (16:40 -0700)]
Post-Serialization cleanup fixes to Reflection (#12010)

This is based on the following principles:

- We should not be making changes to instance/virtual methods
in the abstract base types for Reflection. These are apis
in themselves to third party classes that subclass these types.
Even if the Runtime chooses not to make its own implementations
of these type serializable, third party classes have the right
to make that choice for themselves and build off the base class
serialization infrastructure that was shipped before.

RuntimeAssembly and RuntimeModule still override with PNSE
so we'll get the desired exception for those cases.

- The Runtime's own implementations of these types will not be
serializable. Removing all [Serializable] attributes and
serialization interfaces. Runtime types are internal types and
thus have no duty to implement ISerializable if the public
abstract base type does not.

7 years agoDelete useless file (#12021)
mikedn [Wed, 31 May 2017 22:57:46 +0000 (01:57 +0300)]
Delete useless file (#12021)

7 years agoDisable inheritance of several common file descriptors
Stephen Toub [Wed, 31 May 2017 21:18:24 +0000 (17:18 -0400)]
Disable inheritance of several common file descriptors

7 years agoDefault to portable build in dev and official builds (#11985)
Gaurav Khanna [Wed, 31 May 2017 15:53:47 +0000 (08:53 -0700)]
Default to portable build in dev and official builds (#11985)

7 years agoFix issues with RelativePointer instead of RelativeFixupPointer (#12004)
gbalykov [Wed, 31 May 2017 15:39:43 +0000 (18:39 +0300)]
Fix issues with RelativePointer instead of RelativeFixupPointer (#12004)

7 years agoExpose Enumerator members out of EnvironmentAugments. (#11980)
Atsushi Kanamori [Wed, 31 May 2017 15:23:02 +0000 (08:23 -0700)]
Expose Enumerator members out of EnvironmentAugments. (#11980)

Expose Enumerator members out of EnvironmentAugments.

7 years agoMerge pull request #11995 from ViktorHofer/SerializationFollowUp
Krzysztof Wicher [Wed, 31 May 2017 03:02:47 +0000 (20:02 -0700)]
Merge pull request #11995 from ViktorHofer/SerializationFollowUp

Internal hashtable serialization attribute removed

7 years agoAllowing larger segment size for SOH, in preparation for enabling it for NoGC region...
Maoni Stephens [Wed, 31 May 2017 01:29:29 +0000 (18:29 -0700)]
Allowing larger segment size for SOH, in preparation for enabling it for NoGC region. (#11923)

This is just so that I can test with larger SOH seg size to make sure we are not getting AVs.
More perf changes will happen with the NoGC region changes.

7 years agoRemove relocations from SECTION_MethodDesc for ngened images (#11394)
gbalykov [Wed, 31 May 2017 01:25:04 +0000 (04:25 +0300)]
Remove relocations from SECTION_MethodDesc for ngened images (#11394)

7 years agoInternal hashtable serialization attribute removed
Viktor Hofer [Wed, 31 May 2017 00:46:43 +0000 (02:46 +0200)]
Internal hashtable serialization attribute removed

7 years agoCoretype variables renamed back to netfx counterpart for reflection based serializati...
Viktor Hofer [Wed, 31 May 2017 00:16:32 +0000 (02:16 +0200)]
Coretype variables renamed back to netfx counterpart for reflection based serialization (#11910)

* Variables renamed for reflection based serialization

* Make EqualityComparers serialize like desktop

* add missing interfaces

* TimeZone serializable added

* Internal hashtable serializable

* Removed TimeZone as serializable type

* Remove Lazy<T>'s [Serializable] attribute for 2.0

For performance, Lazy was completely rewritten for .NET Core 2.0 and has an entirely different format than desktop; trying to get it to match the desktop serialization format would require either reverting or providing a complicated custom serialization/deserialization implementation to try to match.  Lazy can also wrap an Exception that occurred from trying to instantiate the object, and the only exception types that are serializable as of now in core are the base Exception and AggregateException.  As such, we're cutting it from the list of supported types in 2.0.  An easy workaround is simply to do what the implementation does: serialize lazy.Value instead of lazy.

* tiny fixes to equalitycomparer.cs

7 years agoMerge pull request #11977 from mskvortsov/FixDoubleRegArgNext
Carol Eidt [Tue, 30 May 2017 23:28:05 +0000 (16:28 -0700)]
Merge pull request #11977 from mskvortsov/FixDoubleRegArgNext

[RyuJIT/arm32] Fix double argument passing

7 years agoMerge pull request #11872 from hqueue/arm/ryujit/dodge_lowering_long_cmp
Pat Gavlin [Tue, 30 May 2017 23:06:23 +0000 (16:06 -0700)]
Merge pull request #11872 from hqueue/arm/ryujit/dodge_lowering_long_cmp

[RyuJIT/ARM32] Dodge lowering long compares

7 years agoSkip cast nodes for the tail call check. (#11986)
Sergey Andreenko [Tue, 30 May 2017 23:02:20 +0000 (16:02 -0700)]
Skip cast nodes for the tail call check. (#11986)

Fix #11983

7 years agoFix build break
Jan Kotas [Tue, 30 May 2017 16:21:04 +0000 (09:21 -0700)]
Fix build break

7 years agoMoves windows specific field to Debug.Windows.cs file (dotnet/corert#3733)
Marek Safar [Tue, 30 May 2017 06:29:57 +0000 (08:29 +0200)]
Moves windows specific field to Debug.Windows.cs file (dotnet/corert#3733)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoUse FD_CLOEXEC instead of equivalent 1 in InternalCreatePipe
Stephen Toub [Tue, 30 May 2017 19:49:42 +0000 (15:49 -0400)]
Use FD_CLOEXEC instead of equivalent 1 in InternalCreatePipe

7 years agoRemove Debian Armel (#11978)
Gaurav Khanna [Tue, 30 May 2017 19:15:05 +0000 (12:15 -0700)]
Remove Debian Armel (#11978)

7 years agoRyuJIT/arm32: Fix double argument passing
Mikhail Skvortcov [Tue, 30 May 2017 15:47:54 +0000 (18:47 +0300)]
RyuJIT/arm32: Fix double argument passing

7 years agoFix failures in ETW logging on 4GB aware 32 bit processes (#11941)
Vance Morrison [Tue, 30 May 2017 16:09:29 +0000 (09:09 -0700)]
Fix failures in ETW logging on 4GB aware 32 bit processes (#11941)

We incorrectly cast a 32 bit pointer to a 64 bit poitner using as a SIGNED integer.
If this is a 32 bit process that is using more than 2GB of memory this can result in
sign rather than zero extension.  This makes the poitner invalid at the OS level
and causes the OS API to fail.

We disovered this in Visual Studio when debugging large (Rosyln) scenarios.
There were numerous failures which causes sever slowdowns becasue the
EventSource logged OutputDebugString events when the OS API failed.

The fix is to use unsigned extension.   Note that I have confirmed that casting
from a IntPtr or a void* to a ulong does zero extension (that is it uses the target type
to determine whether to use sign or zero extension).

To be useful for Visual Studio, this needs to be ported to the desktop runtime.

7 years agoMerge pull request #11972 from hseok-oh/ryujit/issue_11971
Carol Eidt [Tue, 30 May 2017 15:31:47 +0000 (08:31 -0700)]
Merge pull request #11972 from hseok-oh/ryujit/issue_11971

[RyuJIT/ARM32] Fix offset of struct argument when using stack

7 years agoMerge pull request #11973 from hseok-oh/ryujit/issue_11837
Carol Eidt [Tue, 30 May 2017 15:30:15 +0000 (08:30 -0700)]
Merge pull request #11973 from hseok-oh/ryujit/issue_11837

[RyuJIT/ARM32] Fix assertion failed 'remainingSize == TARGET_POINTER_SIZE'

7 years ago[RyuJIT/ARM32] Fix assertion failed 'remainingSize == TARGET_POINTER_SIZE'
Hyeongseok Oh [Tue, 30 May 2017 10:05:35 +0000 (19:05 +0900)]
[RyuJIT/ARM32] Fix assertion failed 'remainingSize == TARGET_POINTER_SIZE'

Fix assertion failed by 'remainingSize == TARGET_POINTER_SIZE'
Fix to check register allocation correctly

7 years ago[RyuJIT/ARM32] Fix offset of struct argument when using stack
Hyeongseok Oh [Tue, 30 May 2017 09:58:33 +0000 (18:58 +0900)]
[RyuJIT/ARM32] Fix offset of struct argument when using stack

Fix offset value when struct argument is passed on stack

7 years agoImplement GetCurrentProcessCpuCount for Unix and merge NumberOfProcesors implementati...
Tom Deseyn [Mon, 29 May 2017 13:46:10 +0000 (15:46 +0200)]
Implement GetCurrentProcessCpuCount for Unix and merge NumberOfProcesors implementations. (#11742)

* Implement GetCurrentProcessCpuCount for Unix and merge NumberOfProcessors implementations.

* Split GetCurrentProcessCpuCount in PAL and non-PAL parts

* gcenv.unix.cpp: GetCurrentProcessAffinityMask: revert, GetCurrentProcessCpuCount: add implementation

* bugfix: #if instead of #ifdef HAVE_SCHED_GETAFFINITY

* Remove PAL_GetCurrentProcessCpuCount

* gcenv.unix: implement GetCurrentProcessAffinityMask, GetCurrentProcessCpuCount

* numa.cpp: initialize g_cpuToAffinity[i].Number when numa.h is missing

* cleanup

* mscorwks_unixexports.src: Add GetProcessAffinityMask

* PR feedback

* Add GetProcessAffinityMask to mscordac_unixexports.src

7 years agoadded DWARF exprloc for static value class fields (#11911)
Buyduck [Mon, 29 May 2017 11:26:41 +0000 (14:26 +0300)]
added DWARF exprloc for static value class fields (#11911)

7 years agoFix build breaks
Morgan Brown [Sat, 27 May 2017 02:13:06 +0000 (19:13 -0700)]
Fix build breaks

* Remove UnitySerializationHolder references
* Remove the fields of StrongNameKeyPair
* Initialize BadImageFormatException._fusionLog
* Remove MemberInfoSerializationHolder references

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoIDeserializationCallback cleanup
Morgan Brown [Sun, 28 May 2017 04:07:32 +0000 (21:07 -0700)]
IDeserializationCallback cleanup

Throws PlatformNotSupportedException from IDeserializationCallback and IObjectReference implementations on types that are no longer serializable.

7 years agoFix tool initialization detection (#11912)
mikedn [Sat, 27 May 2017 23:09:11 +0000 (02:09 +0300)]
Fix tool initialization detection (#11912)

init-tools.cmd attempts to create a file in a directory that doesn't exist. File creation fails and next time the script is run initialization will be performed again. That wastes a lot of time.

7 years agoUpdate CoreClr to preview1-25327-01 (#11949)
dotnet bot [Sat, 27 May 2017 23:07:59 +0000 (16:07 -0700)]
Update CoreClr to preview1-25327-01 (#11949)

7 years agoUpdate test coverage statements in workflow doc
Rich Lander [Sat, 27 May 2017 18:46:13 +0000 (11:46 -0700)]
Update test coverage statements in workflow doc

7 years agoUpdate license links
Rich Lander [Sat, 27 May 2017 05:01:25 +0000 (22:01 -0700)]
Update license links

7 years agoUpdate CoreClr, CoreFx to preview1-25326-02, preview1-25324-02, respectively (#11932)
dotnet bot [Sat, 27 May 2017 05:00:51 +0000 (22:00 -0700)]
Update CoreClr, CoreFx to preview1-25326-02, preview1-25324-02, respectively (#11932)

7 years agoUpdate contributor docs (#11944)
Rich Lander [Sat, 27 May 2017 04:56:27 +0000 (21:56 -0700)]
Update contributor docs (#11944)

* Update contributor docs

* Update

* Added up-for-grabs and ports

* Update binary licensing

* Update\

* Simplify developer workflow doc

* Update per feedback

7 years agoEnable linux perf runs (#11905)
José Rivero [Sat, 27 May 2017 01:01:05 +0000 (18:01 -0700)]
Enable linux perf runs (#11905)

- Removing `[assembly: MeasureInstructionsRetired]` from performance tests.
- Due to this issue: https://github.com/Microsoft/xunit-performance/issues/231, we are blocked from running on performance tests on Linux.
  The tag is not used by infrastructure and it is passed during runtime when profiling on Windows.
- Adding the option to execute CoreRun with the stability prefix.
- Moving file to be archived by Jenkins and updating groovy file.
- Setting the maximum number of iterations.

7 years agoISerializable cleanup (#11873)
Morgan Brown [Sat, 27 May 2017 00:45:37 +0000 (17:45 -0700)]
ISerializable cleanup (#11873)

Changes to throw PlatformNotSupportedException from ISerializable.GetObjectData and serialization constructors on non-Serializable types. Also removes private serialization constructors and some unneeded code that was used to support serializing non-serializable types. A few tests testing GetObjectData implementations are also removed. For Exception types, we call base instead of throwing from GetObjectData to be consistent with the many Exceptions that don't override GetObjectData

7 years agoMove rundown to the same code-site where we do ETW rundown before EEShutdown is marke...
Brian Robbins [Fri, 26 May 2017 21:39:42 +0000 (14:39 -0700)]
Move rundown to the same code-site where we do ETW rundown before EEShutdown is marked as started. (#11937)

7 years agoMerge pull request #11920 from briansull/crossgen-tuning
Brian Sullivan [Fri, 26 May 2017 18:08:01 +0000 (11:08 -0700)]
Merge pull request #11920 from briansull/crossgen-tuning

Remove the check that requires an instrumented flags for SPC when collecting IBC data

7 years agoFix BitSetUint64, clean and improve the surrounding code. (#11721)
Sergey Andreenko [Fri, 26 May 2017 16:13:08 +0000 (09:13 -0700)]
Fix BitSetUint64, clean and improve the surrounding code. (#11721)

1. Add the functions that were not implemented in bitsetasuint64inclass/
2. BitSetUint64: make copy_constructor public
3. delete VARSET_INIT_NOCOPY and ALLVARSET_INIT_NOCOPY
4. delete VARSET_INIT and ALLVARSET_INIT.
5. Use the correct const type for VARSET_TP.

7 years agoMerge pull request #11823 from hqueue/arm/ryujit/lsra_gc_helper
Carol Eidt [Fri, 26 May 2017 15:13:27 +0000 (08:13 -0700)]
Merge pull request #11823 from hqueue/arm/ryujit/lsra_gc_helper

[RyuJIT/ARM][LSRA] Update register mask for GC helper

7 years agoEETypeHashTable lookups can deadlock with GC during comparison with unrestored persis...
Jan Kotas [Fri, 26 May 2017 14:17:51 +0000 (07:17 -0700)]
EETypeHashTable lookups can deadlock with GC during comparison with unrestored persisted TypeHandles (#11922)

7 years agoFix compile with disabled FEATURE_READYTORUN option (#11875)
Petr Bred [Fri, 26 May 2017 14:17:05 +0000 (17:17 +0300)]
Fix compile with disabled FEATURE_READYTORUN option (#11875)

- just remove FEATURE_READYTORUN definitions
in clrdefinitions.cmake to turn off option

Signed-off-by: Petr Bred <bredpetr@gmail.com>
7 years ago[RyuJIT/ARM32] Update RMB for helper function
Hyung-Kyu Choi [Fri, 26 May 2017 07:12:33 +0000 (16:12 +0900)]
[RyuJIT/ARM32] Update RMB for helper function

Make RBM_CALLEE_TRASH be consistent with CORINFO_HELP_STOP_FOR_GC helper
which is JIT_RareDisableHelper defined in vm/arm/asmhelpers.S

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years agoMerge pull request dotnet/corert#3709 from dotnet/nmirror
Michal Strehovský [Fri, 26 May 2017 01:24:34 +0000 (18:24 -0700)]
Merge pull request dotnet/corert#3709 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoMerge pull request #11917 from JosephTremoulet/RationalCall
Joseph Tremoulet [Fri, 26 May 2017 05:41:38 +0000 (01:41 -0400)]
Merge pull request #11917 from JosephTremoulet/RationalCall

Clear GTF_CALL from non-calls in rationalize

7 years agoRemove the check that requires an instrumented flags for mscorlib when collecting...
Brian Sullivan [Thu, 25 May 2017 22:27:15 +0000 (15:27 -0700)]
Remove the check that requires an instrumented flags for mscorlib when collecting IBC data
This is not needed for CoreCLR and blocks some valuable usage cases.

7 years agoMerge pull request #11878 from CarolEidt/ContainLclVars
Carol Eidt [Thu, 25 May 2017 22:01:33 +0000 (15:01 -0700)]
Merge pull request #11878 from CarolEidt/ContainLclVars

Make non-tracked lclVars contained

7 years agoMerge pull request #11919 from pgavlin/XunitTestResults
Pat Gavlin [Thu, 25 May 2017 21:55:27 +0000 (14:55 -0700)]
Merge pull request #11919 from pgavlin/XunitTestResults

Add XUnit results for Windows_NT x86 jobs.

7 years agoMerge pull request #11880 from mskvortsov/FixSetRegToCond
Pat Gavlin [Thu, 25 May 2017 21:35:24 +0000 (14:35 -0700)]
Merge pull request #11880 from mskvortsov/FixSetRegToCond

[RyuJIT/arm32] Fix genRegSetToCond() for FP case

7 years agoAdd XUnit results for Windows_NT x86 jobs.
Pat Gavlin [Thu, 25 May 2017 21:29:48 +0000 (14:29 -0700)]
Add XUnit results for Windows_NT x86 jobs.

7 years agoMake untracked lclVars contained
Carol Eidt [Fri, 28 Apr 2017 22:32:07 +0000 (15:32 -0700)]
Make untracked lclVars contained

Make untracked lclVars contained where possible.

7 years agoImplement Activity ID / Related Activity ID for EventSources Writing to EventPipe...
Brian Robbins [Thu, 25 May 2017 19:28:24 +0000 (12:28 -0700)]
Implement Activity ID / Related Activity ID for EventSources Writing to EventPipe (#11904)

* Implement thread-local storage of activity ids.

* Plumb the activity id and related activity id into the trace file.

7 years agoClear GTF_CALL from non-calls in rationalize
Joseph Tremoulet [Thu, 25 May 2017 19:14:48 +0000 (15:14 -0400)]
Clear GTF_CALL from non-calls in rationalize

Since rationalization hoists comma antecedents out into separate
statements, any side-effects that the antecedent had might no longer apply
to the comma's ancestor nodes.  Moreover, in LIR, side-effect flags need
only describe the immediate node; summary flags are computed when Ranges
are constructed.  So, update rationalize to clear the `GTF_CALL` flag from
any node that is not a call.  Failure to do so gives an
overly-conservative view of side-effects, which can inhibit dead store
removal.

7 years agoMerge pull request #11834 from jashook/renable_arm64_span_test
Jarret Shook [Thu, 25 May 2017 15:46:08 +0000 (08:46 -0700)]
Merge pull request #11834 from jashook/renable_arm64_span_test

[Arm64 Windows] Renable SpanBench

7 years ago[ARM32/Linux] Copy tests.zip only for CI test
Hyeongseok Oh [Tue, 16 May 2017 10:37:03 +0000 (19:37 +0900)]
[ARM32/Linux] Copy tests.zip only for CI test

Copy tests.zip only from x64 Windows build for CI test
We can reduce saved build results of linux/arm in CI machine

7 years agoAdds System.Runtime.CompilerServices.Runtimefeature.PortablePdb (#11845)
Tomáš Matoušek [Thu, 25 May 2017 06:48:05 +0000 (23:48 -0700)]
Adds System.Runtime.CompilerServices.Runtimefeature.PortablePdb (#11845)

7 years agoRemove g_fEEManagedEXEStartup and g_fEEIJWStartup. (#11907)
Aditya Mandaleeka [Thu, 25 May 2017 06:47:28 +0000 (23:47 -0700)]
Remove g_fEEManagedEXEStartup and g_fEEIJWStartup. (#11907)

7 years agoMark the EventPipe crst as host breakable. (#11899)
Brian Robbins [Thu, 25 May 2017 01:19:22 +0000 (18:19 -0700)]
Mark the EventPipe crst as host breakable. (#11899)

7 years agoUpdate CoreClr, CoreFx to preview1-25323-01, preview1-25323-02, respectively (master...
dotnet bot [Thu, 25 May 2017 01:15:00 +0000 (18:15 -0700)]
Update CoreClr, CoreFx to preview1-25323-01, preview1-25323-02, respectively (master) (#11809)

* Update CoreClr, CoreFx to preview1-25323-01, preview1-25323-02, respectively

* Update corefx package versions in projects

7 years ago[x86/Linux] Reentrant PEImage::Load (#11867)
Jonghyun Park [Thu, 25 May 2017 00:42:31 +0000 (09:42 +0900)]
[x86/Linux] Reentrant PEImage::Load (#11867)

* [x86/Linux] Reentrant PEImage::Load

* Use HasLoadedLayout and add comments

7 years agoMerge pull request #11894 from pgavlin/gh11804
Pat Gavlin [Wed, 24 May 2017 23:45:04 +0000 (16:45 -0700)]
Merge pull request #11894 from pgavlin/gh11804

Never enregister type-punned regStruct lclVars.

7 years agoFix Issue 11861 (#11886)
Xiang Fan [Wed, 24 May 2017 22:51:38 +0000 (15:51 -0700)]
Fix Issue 11861 (#11886)

* Fix issues exposed by building with MSVC and /permissive-.

Using full-qualified name to declare members inside class is ill-formed and incorrectly allowed by MSVC.
MSVC now gives error when /permissive- is used.

* Add a forward declaration for SafeAddRef from utilcode.h.
SafeAddRef in holder.h calls SafeAddRef in utilcode.h. The latter hasn't been declared yet, so it isn't a valid candidate during overload resolution.
It happens to work in MSVC default mode because of the lack of two phase name lookup.

7 years agoAllow RelativePointer::SetValue usage for non-DAC builds only (#11891)
gbalykov [Wed, 24 May 2017 22:50:26 +0000 (01:50 +0300)]
Allow RelativePointer::SetValue usage for non-DAC builds only (#11891)

7 years agoMerge pull request #11893 from JosephTremoulet/WeakenIBRAssert
Joseph Tremoulet [Wed, 24 May 2017 22:12:28 +0000 (18:12 -0400)]
Merge pull request #11893 from JosephTremoulet/WeakenIBRAssert

Weaken type assertion in gtNewLclNode

7 years agoMerge pull request #11883 from JosephTremoulet/PromotedStructRefs
Joseph Tremoulet [Wed, 24 May 2017 21:44:28 +0000 (17:44 -0400)]
Merge pull request #11883 from JosephTremoulet/PromotedStructRefs

Update full-struct references to promoted IBR args

7 years agoIndicate if thread time events are in managed or native code. (#11892)
Brian Robbins [Wed, 24 May 2017 21:43:54 +0000 (14:43 -0700)]
Indicate if thread time events are in managed or native code. (#11892)

7 years agoMerge pull request #11832 from jashook/add_1_mod_1_case
Jarret Shook [Wed, 24 May 2017 20:37:59 +0000 (13:37 -0700)]
Merge pull request #11832 from jashook/add_1_mod_1_case

Add the case 1 % 1 to our bringup test

7 years agoNever enregister type-punned regStruct lclVars.
Pat Gavlin [Wed, 24 May 2017 19:34:09 +0000 (12:34 -0700)]
Never enregister type-punned regStruct lclVars.

Type-punned lclVars--i.e. lclVars that are accessed via
`(INDIR Tx (ADDR (LCLVAR Ty V)))`--are currently considered
enregisterable if they are SIMD-typed, have not been the accessed by
field, and have not otherwise been declared unenregisterable. This
appears to be an oversight, as the JIT is not able to generate correct
code for the type-punned access if the lclVar is in fact enregistered.

This change removes the special case for these SIMD-typed lclVars.

Fixes #11804.

7 years agoWeaken type assertion in gtNewLclNode
Joseph Tremoulet [Wed, 24 May 2017 20:08:36 +0000 (16:08 -0400)]
Weaken type assertion in gtNewLclNode

Implicit byref parameters originally have struct type in both the lvaTable
and on their appearances in the IR.  In fgRetypeImplicitByRefArgs, the
types in the lvaTable are updated, and subsequently, during global morph,
in fgMorphImplicitByRefArgs, the types of their appearances in the IR are
updated.  Weaken an assertion in lcl var creation to allow the type
disagreement for implicit byref parameter references during global morph.

Fixes #11831.

7 years agoImprove comments around implicit byref rewrite
Joseph Tremoulet [Wed, 24 May 2017 19:37:15 +0000 (15:37 -0400)]
Improve comments around implicit byref rewrite

A number of fields on the LclVarDsc get hijacked during the multi-stage
rewrite of implicit-by-reference parameters; add comments at the fields'
declarations as well as the hijacking uses.

7 years ago[Arm64/Win] Revise JIT_MemSet (#11420)
Steve MacLean [Wed, 24 May 2017 18:31:44 +0000 (14:31 -0400)]
[Arm64/Win] Revise JIT_MemSet (#11420)

* [Arm64/Win] Revise JIT_MemSet

This is the Windows equivalent of #11217 which merged

* [Arm64/Win] Use csel<con> for csel

MS Assembler expects csel<cond> for the csel instruction

7 years ago[x86/Linux] Thread-safe UMThunkMarshInfo::RunTimeInit (#11864)
Jonghyun Park [Wed, 24 May 2017 17:34:59 +0000 (02:34 +0900)]
[x86/Linux] Thread-safe UMThunkMarshInfo::RunTimeInit (#11864)

7 years agoUpdate full-struct references to promoted IBR args
Joseph Tremoulet [Wed, 24 May 2017 16:23:52 +0000 (12:23 -0400)]
Update full-struct references to promoted IBR args

Update fgMorphImplicitByRefArgs to rewrite references to struct-promoted
implicit-by-reference parameters as references to the new struct temps
created in fgRetypeImplicitByRefArgs; fgMorphStructField isn't updating
these because it's only interested in field references, and runs upstream
of fgRetypeImplicitByRefArgs where the full struct temp is created,
anyway.
Invert the sense of lvPromoted for implicit byref args in the interim
between fgRetypeImplicitByRefArgs and fgMarkDemotedImplicitByRefArgs,
since now fgMarkDemotedImplicitByRefArgs needs to update both and would
look horribly backwards the other way around.

Fixes #11814.

7 years agoRyuJIT/arm32: Fix genRegSetToCond for FP cases
Mikhail Skvortcov [Wed, 24 May 2017 15:01:36 +0000 (18:01 +0300)]
RyuJIT/arm32: Fix genRegSetToCond for FP cases

7 years agoFix format
Hyung-Kyu Choi [Wed, 24 May 2017 07:42:09 +0000 (16:42 +0900)]
Fix format

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years ago[RyuJIT/ARM32] Dodge lowering long compares
Hyung-Kyu Choi [Wed, 24 May 2017 07:19:30 +0000 (16:19 +0900)]
[RyuJIT/ARM32] Dodge lowering long compares

Let's dodge lowering long compares to avoid ryujit/arm32 failure
and enable it later when required implementaion is available.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years agoILLink performance: Disable Roslyn Test
Swaroop Sridhar [Tue, 23 May 2017 21:33:36 +0000 (14:33 -0700)]
ILLink performance: Disable Roslyn Test

Temporarily disable roslyn test, since it is failing in the lab.

7 years agoScale back [Serializable] on CoreCLR types (#11765)
Morgan Brown [Wed, 24 May 2017 00:11:24 +0000 (17:11 -0700)]
Scale back [Serializable] on CoreCLR types (#11765)

Removes SerializableAttribute from CoreCLR types not intended to be serializable as well as adding special handling to MulticastDelegate to prevent serializing delegates (which can't be correctly serialized cross platform/runtime).

7 years agoReturn early if EventPipeBuffer is empty. (#11855)
Brian Robbins [Tue, 23 May 2017 23:11:44 +0000 (16:11 -0700)]
Return early if EventPipeBuffer is empty. (#11855)

7 years agoDelete special handling of IJW RVA fields at NGen time (#11818)
Jan Kotas [Tue, 23 May 2017 22:09:03 +0000 (15:09 -0700)]
Delete special handling of IJW RVA fields at NGen time (#11818)

Mixed mode managed C++ is not supported by CoreCLR so this is not needed for anything.

Fixes #11761

7 years agoMerge pull request #11694 from JosephTremoulet/IconHoist
Joseph Tremoulet [Tue, 23 May 2017 21:57:56 +0000 (17:57 -0400)]
Merge pull request #11694 from JosephTremoulet/IconHoist

Don't hoist IConHandle statics above cctors

7 years ago[Arm64 Windows] Renable SpanBench
jashook [Tue, 23 May 2017 17:13:38 +0000 (10:13 -0700)]
[Arm64 Windows] Renable SpanBench

7 years agoAdd the case 1 % 1 to our bringup test
jashook [Tue, 23 May 2017 16:50:33 +0000 (09:50 -0700)]
Add the case 1 % 1 to our bringup test

Addresses lack of coverage shown in #7168.

7 years agoMerge pull request #11366 from ruben-ayrapetyan/remove-zap-code-relocs-for-linux...
Bruce Forstall [Tue, 23 May 2017 16:38:03 +0000 (09:38 -0700)]
Merge pull request #11366 from ruben-ayrapetyan/remove-zap-code-relocs-for-linux-arm32

Change relocations in ngen-ed code with PC-relative constants for Linux ARM32

7 years agoMerge pull request #10275 from mikedn/x86-cmp-long-lower
Pat Gavlin [Tue, 23 May 2017 15:29:45 +0000 (08:29 -0700)]
Merge pull request #10275 from mikedn/x86-cmp-long-lower

Lower long compares that are materialized into a register

7 years agoRemove "corerun" sos plugin command. (#11812)
Mike McLaughlin [Tue, 23 May 2017 15:01:25 +0000 (08:01 -0700)]
Remove "corerun" sos plugin command. (#11812)

It broke building on debug osx and isn't used or needed anymore.

7 years agoDirect mapping of IL-assembly images that don't contain writeable sections.
Ruben Ayrapetyan [Wed, 5 Apr 2017 18:08:32 +0000 (21:08 +0300)]
Direct mapping of IL-assembly images that don't contain writeable sections.

7 years agoExtract PEImage::CreateLayoutMapped and PEImage::CreateLayoutFlat from PEImage::GetLa...
Ruben Ayrapetyan [Fri, 7 Apr 2017 10:25:42 +0000 (13:25 +0300)]
Extract PEImage::CreateLayoutMapped and PEImage::CreateLayoutFlat from PEImage::GetLayoutInternal.

7 years ago[RyuJIT/ARM][LSRA] Update register mask for GC helper
Hyung-Kyu Choi [Tue, 23 May 2017 12:46:46 +0000 (21:46 +0900)]
[RyuJIT/ARM][LSRA] Update register mask for GC helper

CORINFO_HELP_STOP_FOR_GC helper preserves integer and double return register.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years agoMerge pull request #10990 from mikedn/narrow-test
Pat Gavlin [Tue, 23 May 2017 06:09:25 +0000 (23:09 -0700)]
Merge pull request #10990 from mikedn/narrow-test

Narrow TEST instructions when possible

7 years agoDelete long compare support from x86 codegen
Mike Danes [Sun, 19 Mar 2017 12:57:19 +0000 (14:57 +0200)]
Delete long compare support from x86 codegen

7 years agoLower long compares that are materialized into a register
Mike Danes [Sat, 18 Mar 2017 00:39:25 +0000 (02:39 +0200)]
Lower long compares that are materialized into a register