dotnet-bot [Fri, 15 Sep 2023 18:30:38 +0000 (18:30 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Fri, 15 Sep 2023 18:19:06 +0000 (11:19 -0700)]
[release/8.0] fix ReceiveFrom with dual mode socket (#92103)
* fix ReceiveFrom with dual mode socket
* test
* feedback
---------
Co-authored-by: wfurt <tweinfurt@yahoo.com>
Co-authored-by: Anton Firszov <Anton.Firszov@microsoft.com>
dotnet-bot [Fri, 15 Sep 2023 18:02:02 +0000 (18:02 +0000)]
Merge in 'release/8.0' changes
dotnet-maestro[bot] [Fri, 15 Sep 2023 17:50:41 +0000 (10:50 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230914.6 (#92122)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23463.3 -> To Version 1.0.0-prerelease.23464.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-bot [Fri, 15 Sep 2023 17:35:44 +0000 (17:35 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Fri, 15 Sep 2023 17:23:10 +0000 (10:23 -0700)]
[release/8.0] Implement support for `InlineArray` in the trimmer (#92107)
* Implement support for InlineArray in the trimmer
Types annotated with `InlineArray` need to preserve all of their fields, even if otherwise this would not be the case. It's possible to have a struct with `LayoutKind.Auto` and with `InlineArray` - trimmer would normally trim fields on such struct. This leads to corruption since the field is never accessed directly.
This changes the marking to preserve all fields on a type with `InlineArray` attribute just like we would for explicit layout struct and similar other types.
Adds tests to cover both the explicit usage of `InlineArray` attribute as well as the compiler generate usage via collection literals.
* Update src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/InlineArrayDataflow.cs
Co-authored-by: Sven Boemer <sbomer@gmail.com>
---------
Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
github-actions[bot] [Fri, 15 Sep 2023 17:20:59 +0000 (10:20 -0700)]
[release/8.0] [browser] ENVIRONMENT_IS_WEB is also true on WebWorker (#91627)
* ENVIRONMENT_IS_WEB is now also true on WebWorker
* noExitRuntime stay false on pthread
---------
Co-authored-by: pavelsavara <pavel.savara@gmail.com>
dotnet-bot [Fri, 15 Sep 2023 16:47:52 +0000 (16:47 +0000)]
Merge in 'release/8.0' changes
dotnet-maestro[bot] [Fri, 15 Sep 2023 16:40:22 +0000 (09:40 -0700)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230914.2 (#92121)
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23458.2 -> To Version 3.11.0-beta1.23464.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Fri, 15 Sep 2023 16:36:40 +0000 (09:36 -0700)]
[release/8.0] Update FixupPrecode and StubPrecode types for ARM (#92075)
* Update FixupPrecode and StubPrecode types for ARM
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
* Update ThisPtrRetBufPrecode and NDirectImportPrecode types for arm
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
* Addressing PR feedback - remove unnecessary #ifdef's
* FIx riscv64 build break due to NDirectImportPrecode::Type conflict with ThisPtrRetBufPrecode::Type
---------
Co-authored-by: Tom McDonald <tommcdon@microsoft.com>
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
dotnet-bot [Fri, 15 Sep 2023 14:42:08 +0000 (14:42 +0000)]
Merge in 'release/8.0' changes
dotnet bot [Fri, 15 Sep 2023 14:31:13 +0000 (07:31 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2267753 (#92090)
dotnet-bot [Thu, 14 Sep 2023 22:10:17 +0000 (22:10 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Thu, 14 Sep 2023 22:08:14 +0000 (15:08 -0700)]
Replace newline characters in NoWarn (#92062)
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
github-actions[bot] [Thu, 14 Sep 2023 21:58:50 +0000 (14:58 -0700)]
[release/8.0] Fix binder gen compile issues due to inaccessible members and identifier name clashes (#91967)
* Fix binder gen compile issues due to inaccessible members and identifier name clashes
* Minimize net diff of binder-gen visibility/identifier-clash fix
* Improve identifier formatting
* Use built-in API for accessiblity check
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Thu, 14 Sep 2023 20:31:56 +0000 (20:31 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Thu, 14 Sep 2023 20:20:31 +0000 (13:20 -0700)]
[release/8.0] Replace http.error.reason with OTel standard error.type (#91996)
* implement standard semantics for the request.duration error tag
* delete unused using
* reduce s_statusCodeStrings size
---------
Co-authored-by: antonfirsov <antonfir@gmail.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Anton Firszov <Anton.Firszov@microsoft.com>
github-actions[bot] [Thu, 14 Sep 2023 20:19:27 +0000 (13:19 -0700)]
[release/8.0] Remove implicit narrowing conversions from zlib (#91962)
* Make zlib compile clean against MSVC C4244 and clang implicit-int-conversion
Descriptions of each changes are in the respective .patch files.
* Unbreak mono build
---------
Co-authored-by: Levi Broderick <levib@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Thu, 14 Sep 2023 19:31:45 +0000 (19:31 +0000)]
Merge in 'release/8.0' changes
dotnet-maestro[bot] [Thu, 14 Sep 2023 19:22:13 +0000 (12:22 -0700)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/cecil dotnet/hotreload-utils dotnet/arcade dotnet/source-build-reference-packages (#91928)
* Update dependencies from https://github.com/dotnet/cecil build
20230911.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23454.2 -> To Version 0.11.4-alpha.23461.1
* Update dependencies from https://github.com/dotnet/arcade build
20230911.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23451.1 -> To Version 8.0.0-beta.23461.2
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230911.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23455.2 -> To Version 8.0.0-alpha.0.23461.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230911.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23457.1 -> To Version 8.0.0-alpha.1.23461.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230912.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23460.1 -> To Version 8.0.0-rc.2.23462.1
* Update dependencies from https://github.com/dotnet/cecil build
20230911.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23454.2 -> To Version 0.11.4-alpha.23461.1
* Update dependencies from https://github.com/dotnet/arcade build
20230911.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23451.1 -> To Version 8.0.0-beta.23461.2
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230911.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23455.2 -> To Version 8.0.0-alpha.0.23461.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230912.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23457.1 -> To Version 8.0.0-alpha.1.23462.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230913.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23460.1 -> To Version 8.0.0-rc.2.23463.1
* Update dependencies from https://github.com/dotnet/cecil build
20230911.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23454.2 -> To Version 0.11.4-alpha.23461.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230911.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23455.2 -> To Version 8.0.0-alpha.0.23461.1
* Update dependencies from https://github.com/dotnet/arcade build
20230913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23451.1 -> To Version 8.0.0-beta.23463.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230913.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23457.1 -> To Version 8.0.0-alpha.1.23463.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 14 Sep 2023 19:21:43 +0000 (12:21 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91913)
* Update dependencies from https://github.com/dotnet/roslyn build
20230911.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23461.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230911.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23461.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230912.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.10
* Permit TypeAttributes.BeforeFieldInit for InterfaceTypeTestBase
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Filip Navara [Thu, 14 Sep 2023 19:13:43 +0000 (23:13 +0400)]
Do not throw PNSE exception from NegotiateAuthentication constructor, report Unsupported status instead (#91753)
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Thu, 14 Sep 2023 17:56:02 +0000 (17:56 +0000)]
Merge in 'release/8.0' changes
dotnet-bot [Thu, 14 Sep 2023 17:51:41 +0000 (17:51 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Thu, 14 Sep 2023 17:49:25 +0000 (10:49 -0700)]
[wasi] Work arounbd WASI's mmap implementation not returning aligned memory. (#92061)
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes https://github.com/dotnet/runtime/issues/88501 and others.
Co-authored-by: Zoltan Varga <vargaz@gmail.com>
dotnet-maestro[bot] [Thu, 14 Sep 2023 17:49:06 +0000 (10:49 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230913.3 (#92059)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23462.6 -> To Version 1.0.0-prerelease.23463.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 17:47:04 +0000 (10:47 -0700)]
[release/8.0] Fix si.ibAllocated in FrozenObjectHeapManager (#92052)
* Fix si.ibAllocated in FrozenObjectHeapManager
* Add an assert
---------
Co-authored-by: EgorBo <egorbo@gmail.com>
github-actions[bot] [Thu, 14 Sep 2023 17:45:18 +0000 (10:45 -0700)]
[release/8.0] Arm64: Pass the small size accurately to emitIns_valid_imm_for_ldst_offset (#92041)
* Pass the right size to check if immediate will fit or not
* Revert "Pass the right size to check if immediate will fit or not"
This reverts commit
d7c511abce6634d65434a149e719c6f4516d6966.
* review feedback
* fix the size to be passed to the instruction
* fix the assert
---------
Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
Tarek Mahmoud Sayed [Thu, 14 Sep 2023 17:44:58 +0000 (10:44 -0700)]
[release/8.0] Metrics Feature Switch (#92019)
* Metrics Feature Switch
* Add missed empty lines
---------
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Carlos Sánchez López [Thu, 14 Sep 2023 17:40:22 +0000 (10:40 -0700)]
Merge pull request #91956 from vseanreesermsft/internal-merge-8.0-2023-09-12-1259
Merging internal commits for release/8.0
Nikola Milosavljevic [Thu, 14 Sep 2023 17:39:41 +0000 (10:39 -0700)]
Update THIRD-PARTY-NOTICES for 8.0 release (#91933)
* Update THIRD-PARTY-NOTICES for 8.0 release
* Addressed review comments
* Remove test-only notice
dotnet-bot [Thu, 14 Sep 2023 17:01:00 +0000 (17:01 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Thu, 14 Sep 2023 16:50:09 +0000 (09:50 -0700)]
[release/8.0] Don't shut down event pipe in DLLs on Windows (#92044)
Trying to enable EventSourceSupport in a shared library project on Native AOT currently results in a build failure since this is actively blocked in the targets. But EventSourceSupport/event pipe mostly work, with some issues (#91762).
The blocking makes it impossible for anyone to run diagnostics on their shared library. This is a regression from .NET 7, where it was at least possible to get GC ETW events in PerfView on Windows.
This changes the blocking to a suppressible warning, and fixes and issue that was causing a shutdown hang.
dotnet-bot [Thu, 14 Sep 2023 00:16:31 +0000 (00:16 +0000)]
Merge in 'release/8.0' changes
dotnet-maestro[bot] [Thu, 14 Sep 2023 00:12:00 +0000 (17:12 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230912.6 (#92001)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23458.2 -> To Version 1.0.0-prerelease.23462.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 00:11:22 +0000 (17:11 -0700)]
Update Marshal.QueryInterface() argument modifier (#91984)
Change "in" modifier to "ref readonly" to avoid warnings
in existing interop code.
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 00:09:15 +0000 (17:09 -0700)]
Limit special diagnostics size region to 4KiB. (#91953)
This fixes out-of-bounds access when trying to write the
diagnostics info on platforms where the PAGE_SIZE is larger
than the DumpWriter's 16KiB m_tempBuffer.
Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 00:08:55 +0000 (17:08 -0700)]
[release/8.0] Skip duplicate --info output if it is known SDK output (#92013)
* Skip duplicate --info output if it is known SDK output
* Update src/native/corehost/fxr/fx_muxer.cpp
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
* Add tests
---------
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 00:08:12 +0000 (17:08 -0700)]
[release/8.0] Make Options source gen support Validation attributes having constructor with array parameters (#91934)
* Make Options source gen support Validation attributes having constructor with params Parameter
* delta change
* Rename the generator
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
---------
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Thu, 14 Sep 2023 00:05:32 +0000 (17:05 -0700)]
Added missing *Async overrides to TlsStream (#91794)
Co-authored-by: Manicka <manicka@Manickas-MacBook-Pro.local>
Andrew Au [Thu, 14 Sep 2023 00:04:54 +0000 (17:04 -0700)]
Delete the RequiresPreviewFeaturesAttribute from RefreshMemoryLimit (#91622) (#91688)
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Thu, 14 Sep 2023 00:04:47 +0000 (00:04 +0000)]
Merge in 'release/8.0' changes
github-actions[bot] [Wed, 13 Sep 2023 23:52:26 +0000 (16:52 -0700)]
[release/8.0] Revert "Emit less metadata for not-reflection-visible types (#91660)" (#91989)
* Revert "Emit less metadata for not-reflection-visible types (#91660)"
This reverts commit
0bfc0c9e838193b699415a015504b4aede1f7f0a.
* Regression test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Wed, 13 Sep 2023 22:37:29 +0000 (22:37 +0000)]
Merge in 'release/8.0' changes
Juan Hoyos [Wed, 13 Sep 2023 22:26:38 +0000 (15:26 -0700)]
Try to disable VSIX update service or failfast (#92028)
dotnet-bot [Wed, 13 Sep 2023 18:57:44 +0000 (18:57 +0000)]
Merge in 'release/8.0' changes
Carlos Sánchez López [Wed, 13 Sep 2023 18:49:08 +0000 (11:49 -0700)]
Merge branch 'release/8.0' into internal-merge-8.0-2023-09-12-1259
Carlos Sánchez López [Wed, 13 Sep 2023 18:46:12 +0000 (11:46 -0700)]
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (#92011)
This reverts commit
282da2cd568a4e1429990d3257efbc3724b79fee.
Natalia Kondratyeva [Tue, 12 Sep 2023 22:26:34 +0000 (22:26 +0000)]
Merged PR 33648: [release/8.0] Update MsQuic
Sean Reeser [Tue, 12 Sep 2023 19:59:43 +0000 (12:59 -0700)]
Merge commit '
92959931a32a37a19d8e1b1684edc6db0857d7de' into internal-merge-8.0-2023-09-12-1259
github-actions[bot] [Tue, 12 Sep 2023 17:22:35 +0000 (10:22 -0700)]
[release/8.0] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile (#91877)
* Unconditionally supress trimming warnings when calling InvokeNativeHandlerMethod
* Update HttpClientHandler
---------
Co-authored-by: Simon Rozsival <simon@rozsival.com>
github-actions[bot] [Tue, 12 Sep 2023 16:07:15 +0000 (09:07 -0700)]
[release/8.0] JIT: Fix illegal IR created by GetElement/ToScalar lowering (#91874)
* JIT: Fix illegal IR created by GetElement/ToScalar lowering
These could create TYP_ULONG/TYP_UINT indirs/LCL_FLD nodes, which are
illegal.
Fix #91174
* Add test
* Fix license header in new test
---------
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
github-actions[bot] [Tue, 12 Sep 2023 15:56:53 +0000 (08:56 -0700)]
Don't log warnings for certain RemoveAttributeInstances (#91866)
Fixes #88994.
ILLinker attribute XML format has a way to express "only remove these attributes when parameter X has value of Y". We currently generate a warning and don't trim the attribute at all.
The savings from trimming these attributes are going to be miniscule. Even in IL, this is scraping the bottom of the barrel. In Native AOT these attributes are pretty effectively deduplicated across assemblies. We'll likely never need this.
This keeps the existing behavior (don't trim the attribute), but removes the warning.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
github-actions[bot] [Tue, 12 Sep 2023 15:26:55 +0000 (08:26 -0700)]
[release/8.0] Fix `Item4` is missing in some `ValueTuple`s' `IStructuralEquatable.Equals` (#91470)
* Add missing comparisons
* Add unit tests
---------
Co-authored-by: Hamish Arblaster <hamarb123@gmail.com>
github-actions[bot] [Mon, 11 Sep 2023 23:27:35 +0000 (17:27 -0600)]
JIT: ensure AVX512 ternary operands aren't used twice (#91883)
Don't spill unused zeros early; we might decide to use them later.
Fixes #91796.
Co-authored-by: Andy Ayers <andya@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 23:24:18 +0000 (17:24 -0600)]
[release/8.0] Improve perf of ActivatorUtilities.CreateInstance() (#91881)
* Improve perf of ActivatorUtilities.CreateInstance()
* Support MetadataUpdateHandler for hot reload
* Support unloadable assembly contexts
* Add tests
* Rename new test classes
* Remove Mono from test; remove cache for NetFramework; remove use of ConstructorInvoker for possible risk of callstack usage
* Misc naming etc; non-functional
* Update some comments
* Simplify use of ConditionalWeakTable.Add
---------
Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
Jakob Botsch Nielsen [Mon, 11 Sep 2023 23:23:50 +0000 (01:23 +0200)]
[release/8.0] JIT: DNER multiregs with SIMD12 (#91878)
* JIT: DNER multiregs with SIMD12s
Locals with SIMD12 fields will never match the ABI when they end up
as multireg returns, so these should always be DNER'd.
Fix #91214
* Fix test build
Djuradj Kurepa [Mon, 11 Sep 2023 23:19:43 +0000 (01:19 +0200)]
Check DotNetFinalVersionKind when setting WorkloadVersionSuffix (#91791)
github-actions[bot] [Mon, 11 Sep 2023 23:18:32 +0000 (17:18 -0600)]
[maccatalyst] Make sure MacProxy is included in System.Net.Http (#91599)
https://github.com/dotnet/runtime/issues/90258 identified that `HttpClient.DefaultProxy` returned `System.Net.Http.HttpNoProxy` when using MacCatalyst. This is due to a condition in System.Net.Http.csproj not including maccatalyst as a condition and as a result, skipped adding the MacProxy sources.
Way back when, https://github.com/dotnet/runtime/pull/47823 had the condition, but this appears to have changed in https://github.com/dotnet/runtime/pull/48652 when we thought MacCatalyst would inherit settings from iOS. That turned out to not be the case and this check was never added back.
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 23:17:44 +0000 (17:17 -0600)]
[release/8.0] Fix Dispose and SendData Race on Http3 Test (#91690)
* Fix Dispose and Send Data Race
* Review feedback
---------
Co-authored-by: Ahmet Ibrahim Aksoy (from Dev Box) <aaksoy@microsoft.com>
dotnet-maestro[bot] [Mon, 11 Sep 2023 23:13:46 +0000 (17:13 -0600)]
[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91501)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230901.6
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23451.6
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230902.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230902.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230902.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230907.4
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23457.4
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230908.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230908.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230908.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Mon, 11 Sep 2023 23:09:49 +0000 (17:09 -0600)]
[release/8.0] Add Native AOT Pri0 test leg (#91373)
* Pri0 test leg
* wip
* hm
* Update Comparer_get_Default.csproj
* Revert "wip"
This reverts commit
af025c048145685352b70eb76894c6d6d1eca0c5.
* Add failing JIT test to issues.targets
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <andy@commentout.net>
github-actions[bot] [Mon, 11 Sep 2023 23:09:04 +0000 (17:09 -0600)]
Fix implementation of NegotiateAuthentication.Wrap for Kerberos on Windows (#91311)
Co-authored-by: Filip Navara <navara@emclient.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
dotnet-maestro[bot] [Mon, 11 Sep 2023 22:39:35 +0000 (16:39 -0600)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/source-build-reference-packages (#91671)
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230905.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23455.3
* Update dependencies from https://github.com/dotnet/emsdk build
20230906.3
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23456.3
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230905.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23455.3
* Update dependencies from https://github.com/dotnet/emsdk build
20230907.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23457.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230907.3
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23457.3
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230907.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230908.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230907.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230908.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230907.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230910.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23460.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230905.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230908.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230907.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
dotnet-maestro[bot] [Mon, 11 Sep 2023 22:38:49 +0000 (16:38 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn (#91482)
* Update dependencies from https://github.com/dotnet/roslyn build
20230901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230904.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
* Update dependencies from https://github.com/dotnet/roslyn build
20230905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
* Update dependencies from https://github.com/dotnet/roslyn build
20230906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Mon, 11 Sep 2023 19:47:11 +0000 (12:47 -0700)]
Remove DebugProxy from ClaimsIdentity and ClaimsPrincipal (#91680)
Co-authored-by: David Cantú <dacantu@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 14:47:18 +0000 (07:47 -0700)]
[release/8.0] Emit less metadata for not-reflection-visible types (#91703)
* Emit less metadata for not-reflection-visible types
In .NET 8 we massively regressed the size of an empty WinForms app. A WinForms app now brings in a big chunk of WPF with it. I traced it down to the `ICommand` interface having a WPF `TypeConverter` and `ValueSerializer` attribute on it: https://github.com/dotnet/runtime/blob/
04bd438844482c907062583153a43a9e3b37dbb8/src/libraries/System.ObjectModel/src/System/Windows/Input/ICommand.cs#L13-L16.
An empty app will have a call to a method on `ICommand`, but nothing actually implements `ICommand`. Previously this would mean we generate an unconstructed `MethodTable` for `ICommand`, the unconstructed `MethodTable`s get no reflection metadata, and that's the end of the story.
After #85810 however, the reflection stack can no longer reason about `MethodTable`s that don't have reflection metadata, so we need to generate it. This means we end up with the custom attribute and all the reflection dataflow that comes out of it.
But this metadata is not actually visible in trim safe apps (the only place where reflection could see these method tables in trim safe code is if they're used in a type comparison `x == typeof(Foo)` and we were able to optimize the method table to the unconstructed version because of that). So we can generate less of it and still get away with it.
In this PR I'm adding support for skipping generation of custom attribute metadata for such types. The size of an empty WinForms app goes from 50-something MB to 20-something MB. I think we'll be able to further reduce this number to ~7 MB or less because 12 MB of this are embedded resources that look designer related.
* CR feedback
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 14:45:57 +0000 (07:45 -0700)]
[release/8.0] JIT: Handle mistyped commas in morph in pre-order too (#91718)
* JIT: Compensate for mistyped commas in morph pre-order too
Morph has post-order logic to compensate for mistyped commas produced by
impStoreStruct. However, block morphing can optimize unused stores into
INDs; this interacts with the mistyped commas to produce illegal IR
shapes (e.g. `COMMA<simd12>(..., IND<ubyte>(...))`).
The ideal solution is to fix impStoreStruct (#91586 tracks this), but
this change has a more surgical fix for the problem that can be
backported to .NET 8.
Fix #91443
* Fix build
---------
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 14:44:55 +0000 (07:44 -0700)]
[release/8.0] JIT: Fix invalid zero-init suppression for untracked variables (#91840)
* JIT: Fix invalid zero-init supression for untracked variables
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fix #91576
* Make EH succ logic less conservative
---------
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
github-actions[bot] [Mon, 11 Sep 2023 14:42:45 +0000 (07:42 -0700)]
JIT: Fix invalid memory barrier removal optimization (#91870)
The ARM32/ARM64 backends have an optimization where they optimize out
the latter of two subsequent memory barriers if no memory store/load has
been seen between them. This optimization should not be allowed to
remove memory barriers when a call has been seen.
Fix #91732
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
github-actions[bot] [Fri, 8 Sep 2023 01:56:38 +0000 (18:56 -0700)]
Split the informational version on both SemVer2 separators, not just '-'. (#91760)
This fixes a build break found when we stabilize the package version (and the only separator in the informational version is '+' before the commit id)
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
github-actions[bot] [Thu, 7 Sep 2023 15:18:26 +0000 (08:18 -0700)]
Add Microsoft.Extensions.Options.SourceGeneration To TransitivePackage (#91700)
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
github-actions[bot] [Wed, 6 Sep 2023 23:54:27 +0000 (16:54 -0700)]
[release/8.0] Add late binding lookup in VB.NET for COM objects (#91433)
* Add late binding lookup in VB.NET for COM objects
* Review feedback
* Feedback
---------
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
github-actions[bot] [Wed, 6 Sep 2023 19:52:57 +0000 (12:52 -0700)]
[release/8.0] Enable interceptors implicitly in binder gen nupkg when generator is enabled (#91559)
* Enable interceptors implicitly in binder gen nupkg when generator is enabled
* Simplify impl & remove unneeded target
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
github-actions[bot] [Wed, 6 Sep 2023 18:42:13 +0000 (11:42 -0700)]
Enable output compilation validation in binder gen unit tests (#91602)
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
dotnet-maestro[bot] [Wed, 6 Sep 2023 10:31:33 +0000 (12:31 +0200)]
[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dotnet/icu dotnet/source-build-reference-packages dotnet/emsdk (#91500)
* Update dependencies from https://github.com/dotnet/arcade build
20230901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23431.2 -> To Version 8.0.0-beta.23451.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230901.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23451.1
* Update dependencies from https://github.com/dotnet/cecil build
20230904.2
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23428.2 -> To Version 0.11.4-alpha.23454.2
* Update dependencies from https://github.com/dotnet/icu build
20230904.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.2.23421.2 -> To Version 8.0.0-rc.2.23454.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230905.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23455.1
* Bump Microsoft.Private.Intellisense package version
(cherry picked from commit
94d7ad5232a2a8a0543c29790c2eb91788818599)
* Update dependencies from https://github.com/dotnet/emsdk build
20230905.2
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.2
* Update dependencies from https://github.com/dotnet/emsdk build
20230905.4
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Jan Vorlicek [Wed, 6 Sep 2023 05:22:00 +0000 (07:22 +0200)]
[Release/8.0] Fix x64 crossbuild on macOS arm64 (#91635)
cpufeatures.h/.c uses TARGET_ ifdefs, but it should use HOST_ ifdefs
github-actions[bot] [Tue, 5 Sep 2023 01:00:22 +0000 (18:00 -0700)]
[release/8.0] Fix usage of load library (#91490)
* Use LoadLibraryExW on Windows.
* Use correct flag.
---------
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
dotnet bot [Sat, 2 Sep 2023 09:00:22 +0000 (02:00 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2258306 (#91485)
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:26:37 +0000 (15:26 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn (#91420)
* Update dependencies from https://github.com/dotnet/roslyn build
20230831.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230831.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230831.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230831.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230901.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23451.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:25:51 +0000 (15:25 -0600)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/arcade (#91423)
* Update dependencies from https://github.com/dotnet/emsdk build
20230831.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23415.5 -> To Version 8.0.0-rc.2.23431.1
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23423.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
* Update dependencies from https://github.com/dotnet/arcade build
20230831.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23429.1 -> To Version 8.0.0-beta.23431.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:15:06 +0000 (15:15 -0600)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230831.4 (#91462)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23430.6 -> To Version 1.0.0-prerelease.23431.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Fri, 1 Sep 2023 18:38:59 +0000 (12:38 -0600)]
Fix LDTOKEN of methods that have modifiers (#91439)
When we started generating custom modifiers into metadata format to support new function pointer APIs in #85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at #91381.
No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/
50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
github-actions[bot] [Fri, 1 Sep 2023 18:34:35 +0000 (12:34 -0600)]
Fix runtime dispatch to static virtuals on interface types (#91440)
We were not generating information about static virtuals on interface types. Information about default interface methods normally goes to the class, but if the T we're dispatching on is an interface, this information wasn't generated. The fix is to put this information into dispatch maps and sealed vtables, same way we do for classes.
The test shows what the problem is - if we change `IBar` to be a class, things would work even before this PR.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
github-actions[bot] [Fri, 1 Sep 2023 18:33:48 +0000 (12:33 -0600)]
Fix arm64/arm32 cross-DAC (#91438)
The precode code was incorrectly using the HOST_ARM64, HOST_ARM, etc. defines instead
of the TARGET_ ones. This means the cross-DAC was using the wrong architectures
*Precode::Type codes.
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
github-actions[bot] [Fri, 1 Sep 2023 18:31:41 +0000 (12:31 -0600)]
[release/8.0] [nodejs] Remove experimental wasm arguments from template (#91401)
* Remove experimental wasm arguments from template and add them to features.md
* Fix WBT
* Use lowercase host in runtimeconfig.template.json
* Override runtimeconfig only for wasmconsole
---------
Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Marek Safar <marek.safar@gmail.com>
github-actions[bot] [Fri, 1 Sep 2023 18:30:15 +0000 (12:30 -0600)]
[release/8.0] Options Source Gen Fixes (#91432)
* Options Source Gen Fixes
* Remove unnecessary interpolated string usage
* Address the feedback
* Remove repeated word in the comment
---------
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
github-actions[bot] [Fri, 1 Sep 2023 18:24:29 +0000 (12:24 -0600)]
[release/8.0] [Mono] Fix offset calculation for nested struct, when pinvoke is enabled (#91417)
* Fix offset calculation for nested struct
* Add a test for nested struct with pinvoke
* Move and update test with real c++ implementation
* Exclude newly added test from wasm
* Disable interop tests on android and apple devices
---------
Co-authored-by: Fan Yang <yangfan@microsoft.com>
github-actions[bot] [Thu, 31 Aug 2023 22:27:06 +0000 (15:27 -0700)]
[release/8.0] [DependencyInjection] introduce feature switch to disable S.R.E (#91352)
* [DependencyInjection] introduce feature switch to disable S.R.E
When recording a new AOT profile for .NET MAUI apps running on Android,
we noticed that System.Reflection.Emit work was being done on a
background thread. The call seen in `dotnet-trace` output:
11.32ms microsoft.extensions.dependencyinjection!Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder.GenerateMethodBody(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite,System.Reflection.Emit.ILGenerator)
.NET Android apps are unique in that there is a JIT,
`RuntimeFeature.IsDynamicCodeCompiled` is true, System.Reflection.Emit
is possible -- S.R.E is however, not great for startup performance.
Starting threads on Android during startup can also be slow, as Android
will commonly put all but a single core to sleep for battery saving
purposes. We try to avoid starting threads on startup for "hello world"
applications on Android.
To solve this for now, introduce a new feature flag:
Microsoft.Extensions.DependencyInjection.DisableDynamicEngine
Which, we will provide a value in either the Android or .NET MAUI
optional workload via an MSBuild property. To test, I put this in my
app's `.csproj` file:
<RuntimeHostConfigurationOption Include="Microsoft.Extensions.DependencyInjection.DisableDynamicEngine"
Condition="'$(DisableDynamicEngine)' != ''"
Value="$(DisableDynamicEngine)"
Trim="true" />
Customers *could* opt to change this flag, but we don't think it will
particularly useful. An example of services realized by .NET MAUI at
startup, via some logging added:
08-25 13:21:55.647 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeService]
08-25 13:21:55.664 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeScopedService]
08-25 13:21:55.665 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Dispatching.IDispatcher
08-25 13:21:55.668 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.LifecycleEvents.LifecycleEventRegistration]
08-25 13:21:56.057 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.HandlerMauiAppBuilderExtensions+HandlerRegistration]
08-25 13:21:56.115 16530 16530 I DOTNET : RealizeService called: Microsoft.Extensions.DependencyInjection.IServiceScopeFactory
08-25 13:21:56.670 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager
08-25 13:21:56.712 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.ImageSourcesMauiAppBuilderExtensions+ImageSourceRegistration]
08-25 13:21:57.700 16530 16530 I DOTNET : RealizeService using S.R.E: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager
`HideSoftInputOnTappedChangedManager` would be realized once per page,
which would not be a huge payoff to use S.R.E for. So the only way the
S.R.E codepath could be useful on Android would be if the customer is
registering lots of services themselves. They might be better off just
using `new()` in that case?
An example of the startup time Android reports with the new flag on/off:
DisableDynamicEngine=false
08-25 14:31:37.462 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +733ms
08-25 14:31:39.394 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +737ms
08-25 14:31:41.326 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +730ms
DisableDynamicEngine=true
08-25 14:32:20.233 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +724ms
08-25 14:32:22.137 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +727ms
08-25 14:32:24.042 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +716ms
This was a `dotnet new maui` project, using dotnet/maui/main on a Pixel
5 device.
* Update docs/workflow/trimming/feature-switches.md
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
---------
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
github-actions[bot] [Thu, 31 Aug 2023 22:26:43 +0000 (15:26 -0700)]
[release/8.0] Fix nullable annotation for Validator.TryValidateValue and ValidateValue (#91293)
* Fix nullable annotation for Validator.TryValidateValue and ValidateValue
* Revert Options source generator nullable annotation changes for Validator.TryValidateValue (#91305)
* Fix nullable annotation for Validator.ValidateValue ref source (#91351)
---------
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Layomi Akinrinade [Thu, 31 Aug 2023 22:25:40 +0000 (15:25 -0700)]
Update binder gen emitted-interceptor nullability to match framework impl (#91180) (#91359)
dotnet-maestro[bot] [Thu, 31 Aug 2023 15:53:58 +0000 (08:53 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230830.6 (#91390)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23429.4 -> To Version 1.0.0-prerelease.23430.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Thu, 31 Aug 2023 15:43:11 +0000 (08:43 -0700)]
Support Windows based ECDSA SignedCms (#91247)
Supports SignedCms signatured with an ECDSA key created by the Windows
API or .NET Framework. These signatures store an EC public key OID
rather than a hash specific ECDSA OID used in newer versions of dotnet.
Fixes https://github.com/dotnet/runtime/issues/77377
Co-authored-by: Jordan Borean <jborean93@gmail.com>
dotnet-maestro[bot] [Thu, 31 Aug 2023 15:42:42 +0000 (08:42 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91239)
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230828.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23429.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.12
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.13
* Update dependencies from https://github.com/dotnet/roslyn build
20230829.14
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.14
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23430.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230830.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.6
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet bot [Thu, 31 Aug 2023 08:20:42 +0000 (01:20 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256435 (#91360)
dotnet bot [Wed, 30 Aug 2023 21:07:16 +0000 (14:07 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251 (#91347)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251
github-actions[bot] [Wed, 30 Aug 2023 21:07:02 +0000 (14:07 -0700)]
[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice (#91346)
* Fix crash when calling AssemblyLoadContext.Unload twice
The AssemblyLoadContext.InitiateUnload method was not handling multiple
calls correctly. Instead of making the extra calls dummy, it was
calling the native runtime helper again.
This change fixes it by simply ensuring that the runtime helper is
called just once.
* Add regression test
---------
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
github-actions[bot] [Wed, 30 Aug 2023 21:06:02 +0000 (14:06 -0700)]
[release/8.0] Emit interceptor info correctly when invocation expr is on separate line (#91218)
* Emit interceptor info correctly when invocation expr is on separate line
* Add more tests and add helper to udpate baselines
* Add comments to binding gen tests for invocations on new lines (#91237)
* Add comments to binding gen tests for invocations on new lines
* Address feedback & test static method call syntax
* Reorganize and comment the newline/whitespace scenarios
* Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions
---------
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
* Update baselines
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
github-actions[bot] [Wed, 30 Aug 2023 19:48:03 +0000 (12:48 -0700)]
Ensure the relevant containable nodes are handled (#91334)
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
dotnet-maestro[bot] [Wed, 30 Aug 2023 19:47:43 +0000 (12:47 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230829.4 (#91330)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23427.2 -> To Version 1.0.0-prerelease.23429.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>