barraclough@apple.com [Thu, 22 Sep 2011 23:22:02 +0000 (23:22 +0000)]
Windows build fix pt. 2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 23:05:39 +0000 (23:05 +0000)]
Windows build fix pt. 1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 22:58:42 +0000 (22:58 +0000)]
[Qt][Mac]Unreviewed gardening.
New Qt specific results were added by r95723, but they fail on Qt-Mac platform
* platform/qt-mac/Skipped: Skip css3/selectors3 tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 22 Sep 2011 22:49:55 +0000 (22:49 +0000)]
Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644
Reviewed by Sam Weinig.
Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.
Make some inline helper methods to create WKSize, WKPoint and WKRect
types.
* GNUmakefile.am:
* Shared/API/c/WKBase.h:
* Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.
(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):
* Shared/API/c/WKGeometry.h:
(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):
* Shared/API/c/WKSharedAPICast.h:
* Shared/APIObject.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebGeometry.h: Added.
(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2API.pri:
* win/WebKit2.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 22 Sep 2011 22:42:54 +0000 (22:42 +0000)]
DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582
Reviewed by Darin Adler.
This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.
When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::scratchBufferForSize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 22 Sep 2011 22:35:21 +0000 (22:35 +0000)]
Progress control gets cropped on the bottom
https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/
10069915>
Reviewed by Kent Tamura.
As it turns out the smaller control type does not get rendered either, so this patch
fixes both.
* manual-tests/dom/progressbar.html: Altered to show both sizes of controls
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 22:28:21 +0000 (22:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68658
Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.
Reviewed by Anders Carlsson.
Source/WebCore:
Added new tests in fast/regions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
* rendering/RenderBlock.h:
Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.
(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.
LayoutTests:
* fast/regions/webkit-flow-inlines-dynamic.html: Added.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 22:13:32 +0000 (22:13 +0000)]
EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
https://bugs.webkit.org/show_bug.cgi?id=68660
Reviewed by Adam Barth.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseUp):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 22 Sep 2011 22:02:24 +0000 (22:02 +0000)]
DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597
Reviewed by Darin Adler.
This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).
This is a 4% win on Kraken and a 1% loss on V8.
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 22 Sep 2011 21:55:07 +0000 (21:55 +0000)]
Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653
Reviewed by Gavin Barraclough.
Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 22 Sep 2011 21:43:31 +0000 (21:43 +0000)]
Skip test that need new baselines.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 21:22:17 +0000 (21:22 +0000)]
Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382
Reviewed by Sam Weinig.
Source/JavaScriptCore:
This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jsc.cpp:
(GlobalObject::addFunction):
* runtime/CommonIdentifiers.h:
* runtime/ConstructData.h:
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
* runtime/FunctionPrototype.h:
* runtime/JSBoundFunction.cpp: Added.
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):
* runtime/JSBoundFunction.h: Added.
(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundFunctionStructure):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
Source/WebCore:
Test: fast/js/function-bind.html
* bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
- Function::create no longer requires functionStructure() to be passed.
LayoutTests:
We now pass Function.bind tests.
* fast/js/Object-getOwnPropertyNames-expected.txt:
* fast/js/basic-strict-mode-expected.txt:
* fast/js/function-bind-expected.txt: Added.
* fast/js/function-bind.html: Added.
* fast/js/mozilla/strict/15.3.4.5-expected.txt:
* fast/js/script-tests/function-bind.js: Added.
* ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
* ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
* ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
* ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 20:50:41 +0000 (20:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68650
Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.
Reviewed by Sam Weinig.
Source/WebCore:
Covered by existing fast/regions tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.
(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.
(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.
(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.
(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.
LayoutTests:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 20:37:34 +0000 (20:37 +0000)]
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570
Reviewed by Darin Adler.
These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.
This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
* rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 22 Sep 2011 19:41:00 +0000 (19:41 +0000)]
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Reviewed by Anders Carlsson.
Re-landing with a slightly less aggressive check.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 19:38:17 +0000 (19:38 +0000)]
Platform-specific results for test introduced by r95726
* platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Sep 2011 19:25:54 +0000 (19:25 +0000)]
Unreviewed, rolling out r95335 and r95645.
http://trac.webkit.org/changeset/95335
http://trac.webkit.org/changeset/95645
https://bugs.webkit.org/show_bug.cgi?id=68649
Wrong fix (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
Source/WebCore:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
* editing/markup.h:
LayoutTests:
* editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-address.html: Removed.
* editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
* editing/deleting/merge-paragraph-from-h6.html: Removed.
* editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-listing.html: Removed.
* editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
* editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
* editing/deleting/merge-paragraph-into-h1.html: Removed.
* editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-pre.html: Removed.
* platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 19:14:20 +0000 (19:14 +0000)]
Unreviewed, update expected results after r95726
* platform/chromium-win/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.png:
* platform/chromium-win/css2.1/
20110323/abspos-replaced-width-margin-000-expected.png:
* platform/gtk/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt:
* platform/gtk/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt:
* platform/qt/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt:
* platform/qt/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Sep 2011 18:55:35 +0000 (18:55 +0000)]
Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):
* rendering/RenderWidget.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 22 Sep 2011 18:51:02 +0000 (18:51 +0000)]
Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640
Reviewed by Gavin Barraclough.
Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 18:31:10 +0000 (18:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68645
Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.
Reviewed by Beth Dakin.
* fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
* fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* fast/regions/flows-dependency-same-flow-expected.txt: Removed.
* fast/regions/render-region-renderer-expected.txt: Removed.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/mac/fast/regions/no-split-line-box-expected.png: Added.
* platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 18:12:20 +0000 (18:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68638
Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.
Reviewed by Dan Bernstein and Adam Roben.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
* rendering/RenderFlowThread.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 18:01:01 +0000 (18:01 +0000)]
FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=68639
Reviewed by David Hyatt.
FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
* page/FrameView.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 22 Sep 2011 17:52:44 +0000 (17:52 +0000)]
Unreviewed build fix (fixes warning about too many parens).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 17:51:19 +0000 (17:51 +0000)]
Widget::frameRect shouldn't be virtual
https://bugs.webkit.org/show_bug.cgi?id=68637
Reviewed by Sam Weinig.
Nobody overrides Widget::frameRect and nobody should.
* platform/Widget.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:48:45 +0000 (17:48 +0000)]
Remove FindSafari
It isn't used or built anymore.
Fixes <http://webkit.org/b/68628>
Reviewed by Darin Adler.
* FindSafari: Removed this directory and its contents.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:48:18 +0000 (17:48 +0000)]
Remove FindSafari from all our .sln files
It isn't used anymore, so there's no point in building it.
Part of <http://webkit.org/b/68628> Remove FindSafari
Reviewed by Steve Falkenburg.
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.sln:
Source/WebKit/win:
* WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
Tools:
* DumpRenderTree/DumpRenderTree.sln:
* WebKitTestRunner/WebKitTestRunner.sln:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:47:40 +0000 (17:47 +0000)]
Remove all uses of FindSafari
It isn't really needed anymore.
Fixes <http://webkit.org/b/68626>.
Reviewed by Darin Adler.
* Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
* Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
WebKit, but now we use WebKit.exe for that.
* Scripts/webkitdirs.pm:
(installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
do the same thing.
(readRegistryString):
(writeRegistryString):
Moved here from old-run-webkit-tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:47:13 +0000 (17:47 +0000)]
Use the "direct object" form of system() to run WebKit.exe
This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.
Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%
Reviewed by Steve Falkenburg.
* Scripts/webkitdirs.pm:
(runSafari):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:46:50 +0000 (17:46 +0000)]
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
spaces in the path to the WebKit source tree
Reviewed by John Sullivan.
* Scripts/webkitdirs.pm:
(setupCygwinEnv):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:46:24 +0000 (17:46 +0000)]
Add testRegExp.vcproj to WebKit.sln
Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
Reviewed by Brian Weinstein.
* WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
does when built as part of JavaScriptCore.sln.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 22 Sep 2011 17:40:35 +0000 (17:40 +0000)]
[Qt] Use same DPI for application font as rest of app in DRT and WTR
QApplication will initialize the default application font based
on the application DPI at construction time, but we then override
the application DPI using QX11Info (hard-coding it to 96 for
consistency). This hard-coding is not reflected in the application
font, so we explicitly have update the font ourselves.
The 6 test results that are updated were originally produced with
a DPI of 75, as this is the default fallback DPI when a QFont is
constructed before QApplication. This was wrong, and the results
are updated to match a DPI of 96.
Reviewed by Csaba Osztrogonác.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 17:36:03 +0000 (17:36 +0000)]
Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
https://bugs.webkit.org/show_bug.cgi?id=68630
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-22
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/canvas/webgl/shader-deleted-by-accessor.html
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getAttachedShaders):
* html/canvas/WebGLRenderingContext.h:
LayoutTests:
* fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
* fast/canvas/webgl/shader-deleted-by-accessor.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 17:30:58 +0000 (17:30 +0000)]
Unreviewed, platform-specific results for r95721.
* platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
* platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 17:16:47 +0000 (17:16 +0000)]
CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
https://bugs.webkit.org/show_bug.cgi?id=47148
Reviewed by David Hyatt.
Source/WebCore:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::startAlignedOffsetForLine):
Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
* rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
- The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the
containing block's direction) when computing static distance. The container block's direction
is still used in the other width and offset related calculations.
- In the context of this function, the logicalRight value is just an element that will be used later to calculate
the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft()
in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get
logicalLeft in computePositionedLogicalWidthUsing().
(WebCore::RenderBox::computePositionedLogicalWidth):
- Update comments and use the container block's direction except when calculating the static distance.
- Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced
blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
- Update comments and use the container block's direction except when calculating the static distance.
(WebCore::RenderBox::computePositionedLogicalHeight):
- Update comments.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
- Update comments and use the container block's direction except when calculating the static distance.
- If the containing block is RTL, always assume that values are over-constrained.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- Update comments.
LayoutTests:
* platform/chromium-linux/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.png:
* platform/chromium-linux/css2.1/
20110323/abspos-replaced-width-margin-000-expected.png:
New results for CSS 2.1 reference tests. These match exactly the reference test results.
* fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
* platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.
* fast/block/positioning/absolute-position-direction-strict.html: Removed.
* fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
* platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
* platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
* platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
* platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
* platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/mac/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt:
* platform/mac/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt:
* platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
* platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
* platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
* platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
* platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
* platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's
direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 17:09:22 +0000 (17:09 +0000)]
Get rid of Widget::setBoundsSize
https://bugs.webkit.org/show_bug.cgi?id=68491
Reviewed by Sam Weinig.
This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
Source/WebCore:
* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
* page/FrameView.cpp:
(WebCore::FrameView::create):
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/Widget.cpp:
* platform/Widget.h:
(WebCore::Widget::resize):
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::refresh):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::visibleContentRect):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
* rendering/RenderWidget.h:
Source/WebKit/mac:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
* WebView/WebFrameView.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 16:33:40 +0000 (16:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68590
Floats pushed to next page, column or region don't reposition properly if the amount of
available logical width at the new position changes. Refactor the code so that we can
run the float placement algorithm again when this happens.
Source/WebCore:
Covered by an existing regions test that exposes the issue.
Reviewed by Adam Roben.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):
* rendering/RenderBlock.h:
LayoutTests:
Reviewed by Adam Roben.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 16:31:41 +0000 (16:31 +0000)]
[Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests.
All of them pass, they are compared to mac png results manually.
* platform/qt/Skipped:
* platform/qt/css3/selectors3/ [...]: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandrogracia@chromium.org [Thu, 22 Sep 2011 16:18:50 +0000 (16:18 +0000)]
Source/WebCore: Fire TextInput events on speech input, but not set/add any inputMethod attribute.
https://bugs.webkit.org/show_bug.cgi?id=60451
Reviewed by Ryosuke Niwa.
Introduce code to dispatch TextInput events when text is introduced via
the speech input feature. Handle also the cases where speech input is
started programmatically from the LayoutTestController.
Test: fast/speech/input-ontextinput-event.html
* dom/TextEventInputType.h:
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
LayoutTests: Testing text events triggered by speech input.
https://bugs.webkit.org/show_bug.cgi?id=60451
Reviewed by Ryosuke Niwa.
* fast/speech/input-ontextinput-event-expected.txt: Added.
* fast/speech/input-ontextinput-event.html: Added.
* fast/speech/input-text-speechstart.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 16:14:30 +0000 (16:14 +0000)]
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.
CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793
Patch by Jason Liu <jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <robert@webkit.org>
Source/WebCore:
Test: fast/css/outline-narrowLine.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
LayoutTests:
* fast/css/outline-narrowLine.html: Added.
* platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
* platform/qt/fast/css/outline-narrowLine-expected.png: Added.
* platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
* platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 22 Sep 2011 16:08:52 +0000 (16:08 +0000)]
[GTK]Popup drop-down menu contains extra empty spaces at beginning and
occupies whole screen when items in popup reaches the height of display device.
https://bugs.webkit.org/show_bug.cgi?id=68533
When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.
Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 15:42:12 +0000 (15:42 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Thu, 22 Sep 2011 14:48:10 +0000 (14:48 +0000)]
[chromium] Rebaseline following r95715
https://bugs.webkit.org/show_bug.cgi?id=68619
Unreviewed, rebaseline.
* platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
* platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
* platform/chromium-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
* platform/chromium-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Thu, 22 Sep 2011 13:54:04 +0000 (13:54 +0000)]
Define export symbol correctly due to rename of pageScaleFactor to
frameScaleFactor.
Not reviewed. Build fix.
* WebCore.exp.in:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 22 Sep 2011 13:43:23 +0000 (13:43 +0000)]
Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.wasShown):
(WebInspector.ConsoleView.prototype.storeScrollPositions):
(WebInspector.ConsoleView.prototype.restoreScrollPositions):
(WebInspector.ConsoleView.prototype.onResize):
(WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
(WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleCleared):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/inspector.js:
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Thu, 22 Sep 2011 13:30:59 +0000 (13:30 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.
Reviewed by Simon Fraser.
The following things are done in this patch:
1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better
reflect its purpose.
2. Frame::frameScaleFactor() returns the scale factor of this frame with
respect to the container. So for the main frame it'll return the scale
factor of the page, inner frames will return 1.0
3. scrollBy(), scrollX() and scrollY() to take into account of the frame
scale factor, causing incorrect coordinates reported to Javascript.
Tests: fast/events/scale-and-scroll-body.html
fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html
* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
* page/Frame.cpp:
(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
main frame, otherwise 1.0
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.
Reviewed by Simon Fraser.
* WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.
(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.
Reviewed by Simon Fraser.
Add tests to cover the following cases:
1. Scale and scroll window
2. Scale and scroll document.body
3. Scale and scroll iframe's contentWindow
4. Scale and scroll iframe's contentDocument.body
* fast/events/scale-and-scroll-body-expected.png: Added.
* fast/events/scale-and-scroll-body-expected.txt: Added.
* fast/events/scale-and-scroll-body.html: Added.
* fast/events/scale-and-scroll-iframe-body-expected.png: Added.
* fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
* fast/events/scale-and-scroll-iframe-body.html: Added.
* fast/events/scale-and-scroll-iframe-window-expected.png: Added.
* fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
* fast/events/scale-and-scroll-iframe-window.html: Added.
* fast/events/scale-and-scroll-window-expected.png: Added.
* fast/events/scale-and-scroll-window-expected.txt: Added.
* fast/events/scale-and-scroll-window.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 13:25:00 +0000 (13:25 +0000)]
CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666
Patch by Andreas Kling <kling@webkit.org> on 2011-09-22
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/getComputedStyle/computed-style-font.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
This function will always return a CSSValueList, as opposed to the previous
implementation which would return a CSSPrimitiveValue if there was only one family.
getCSSPropertyValue() will return the first element of the list for 1-element lists
to preserve the current behavior of getPropertyCSSValue('font-family').
(WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
(WebCore::fontSizeFromStyle): Ditto.
(WebCore::fontStyleFromStyle): Ditto.
(WebCore::fontVariantFromStyle): Ditto.
(WebCore::fontWeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
implementation of the computed 'font' property (CSSPropertyFont.)
LayoutTests:
* fast/css/getComputedStyle/computed-style-font-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-font.html: Added.
* fast/css/getComputedStyle/script-tests/computed-style-font.js: Added.
(computedFont):
(computedFontCSSValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 22 Sep 2011 13:05:08 +0000 (13:05 +0000)]
Remove useless empty WebKit namespace.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-22
Reviewed by Xan Lopez.
* webkit/webkitglobals.cpp:
(webkitInit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 13:01:54 +0000 (13:01 +0000)]
[Qt][WK2] Unreivewed gardening.
* platform/qt-wk2/Skipped: Skip new failing test introduced in r95645.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 12:50:17 +0000 (12:50 +0000)]
[Qt] 69 tests failing after trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721
Unreviewed gardening. Update Qt 4.8 specific expected files after r95706.
* platform/qt-4.8/ [...]: Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jesus@webkit.org [Thu, 22 Sep 2011 12:43:32 +0000 (12:43 +0000)]
[Qt] Redirection overflow errors have wrong error domain
https://bugs.webkit.org/show_bug.cgi?id=68612
Reviewed by Andreas Kling.
Source/WebCore:
Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::redirect):
Source/WebKit2:
Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().
* UIProcess/API/qt/qweberror.cpp:
(QWebError::type):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 12:23:19 +0000 (12:23 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expected files for new test introduced in r95671.
* platform/qt/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/qt/fast/table/quote-text-around-iframe-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 11:50:07 +0000 (11:50 +0000)]
REGRESSION(r95679): It broke everything.
https://bugs.webkit.org/show_bug.cgi?id=68611
Unreviewed rolling out r95679 and r95690, because it broke everything.
* UIProcess/API/mac/WKView.mm:
(maybeCreateSandboxExtensionFromPasteboard):
(-[WKView performDragOperation:]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::getPluginPath):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::initializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::missingPluginButtonClicked):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::addBackForwardItem):
* UIProcess/WebProcessProxy.h:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 11:05:41 +0000 (11:05 +0000)]
32-bit call code clobbers the function cell tag
https://bugs.webkit.org/show_bug.cgi?id=68606
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Csaba Osztrogonác.
This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 10:23:19 +0000 (10:23 +0000)]
[Qt] 69 tests failing after trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721
Unreviewed gardening. Update Qt specific expected files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Thu, 22 Sep 2011 10:17:38 +0000 (10:17 +0000)]
[chromium] Update test expectation following r95685
https://bugs.webkit.org/show_bug.cgi?id=68604
Unreviewed, update test expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 10:05:26 +0000 (10:05 +0000)]
[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596
Update Qt specific expected files.
* platform/qt/fast/css-generated-content/table-cell-before-content-expected.png:
* platform/qt/fast/css-generated-content/table-cell-before-content-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
* platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
* platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Thu, 22 Sep 2011 09:29:55 +0000 (09:29 +0000)]
[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596
Unreviewed gardening. Typo fixes.
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 22 Sep 2011 07:53:28 +0000 (07:53 +0000)]
Unreviewed, rolling out r95699.
http://trac.webkit.org/changeset/95699
https://bugs.webkit.org/show_bug.cgi?id=67417
Makes many chromium compositor tests crash
Source/WebCore:
* platform/CrossThreadCopier.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::TEST_F):
* tests/TreeSynchronizerTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 22 Sep 2011 07:40:37 +0000 (07:40 +0000)]
Unreviewed, GTK rebaseline after r95671.
* platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
* platform/gtk/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/gtk/fast/table/quote-text-around-iframe-expected.txt: Added.
* platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
* platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
* platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt:
* platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
* platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
* platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt:
* platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt:
* platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
* platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Thu, 22 Sep 2011 07:35:47 +0000 (07:35 +0000)]
[Qt] 11 tests failed after r95671.
https://bugs.webkit.org/show_bug.cgi?id=68596
Unreviewed gardening.
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 22 Sep 2011 07:22:10 +0000 (07:22 +0000)]
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417
Source/WebCore:
Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.
Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.
* platform/graphics/IntRect.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418
Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.
* tests/CCLayerTreeHostTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 04:06:31 +0000 (04:06 +0000)]
Implement WebKit side of IDBFactory::getDatabaseNames
https://bugs.webkit.org/show_bug.cgi?id=68037
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.
Interface changes and stub implementations for
new IndexedDB IDBFactory.getDatabaseNames. This is
part one of a two-sided patch.
* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::getDatabaseNames):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 22 Sep 2011 03:29:50 +0000 (03:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67415
Text drawn via -webkit-background-clip:text is blurry at device scale factors >1.0
-and corresponding-
<rdar://problem/
10060379>
Reviewed by Darin Adler.
New helper function RenderBoxModelObject scales the mask image by the
deviceScaleFactor to get an image of the appropriate resolution. It also scales
the image's GraphicsContext so that the clip is set up on the same scale. Back in
paintFillLayerExtended() we still clip the image to the original maskRect to get
everything scaled back to the appropriate size.
* rendering/RenderBoxModelObject.cpp:
(WebCore::createDeviceScaledImageBuffer):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Make the deviceScaleFactor convenience function just a namespace-level function in
Page rather than a static member or Page.
* page/Page.cpp:
(WebCore::deviceScaleFactor):
* page/Page.h:
Pre-existing callers of Page::deviceScaleFactor(Frame*) must now use
WebCore::deviceScaleFactor(Frame*)
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 22 Sep 2011 02:14:36 +0000 (02:14 +0000)]
Unreviewed. Chromium rebaselines for r95671.
* platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-cell-before-content-expected.txt:
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt:
* platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt:
* platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 22 Sep 2011 02:04:29 +0000 (02:04 +0000)]
[CG] ImageBufferData::getData has an invariant comparison in the inner part of a loop which doesn't get optimized out
https://bugs.webkit.org/show_bug.cgi?id=68588
<rdar://problem/
10164955>
Reviewed by Simon Fraser.
Factor the unmultiplied check out of the inner loop, resulting in a
speed bump in ImageBufferData::getData.
No new tests, performance improvement.
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 01:52:32 +0000 (01:52 +0000)]
:hover selector fails when hovering over a child select element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=67594
Patch by Sameer Patil <mkrp87@motorola.com> on 2011-09-21
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/hover-affects-ancestor.html
This patch addresses the problem of deactivation of the ancestor element :hover rules
when hovered its contained elements.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):
LayoutTests:
* fast/css/hover-affects-ancestor-expected.txt: Added.
* fast/css/hover-affects-ancestor.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 01:46:12 +0000 (01:46 +0000)]
Add missing addPtr->add32 mapping for X86.
Rubber stamped by Sam Weinig.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::addPtr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 01:10:31 +0000 (01:10 +0000)]
Add missing addDouble for AbsoluteAddress to X86
Rubber stamped by Geoff Garen.
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::addDouble):
* assembler/X86Assembler.h:
(JSC::X86Assembler::addsd_mr):
(JSC::X86Assembler::cvtsi2sd_rr):
(JSC::X86Assembler::cvtsi2sd_mr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 01:06:10 +0000 (01:06 +0000)]
Rebaseline for bug 65583 (path based border radius drawing on skia) part 4
https://bugs.webkit.org/show_bug.cgi?id=68339
Patch by Ben Wells <benwells@chromium.org> on 2011-09-21
Reviewed by James Robinson.
* platform/chromium-linux/css1/box_properties/border_style-expected.png:
* platform/chromium-linux/css1/box_properties/border_style_inline-expected.png:
* platform/chromium-linux/css2.1/: 14 changes
* platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png: Added.
* platform/chromium-linux/fast/borders/border-styles-split-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
* platform/chromium-win/css1/box_properties/border_style-expected.png:
* platform/chromium-win/css1/box_properties/border_style_inline-expected.png:
* platform/chromium-win/css2.1/: 14 changes
* platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png: Added.
* platform/chromium-win/fast/borders/border-radius-inset-outset-expected.txt: Added.
* platform/chromium-win/fast/borders/border-styles-split-expected.png: Added.
* platform/chromium-win/fast/borders/border-styles-split-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 22 Sep 2011 01:01:26 +0000 (01:01 +0000)]
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Unreviewed follow-up fix.
* UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
Just like we allow null URLs, also allow empty strings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Sep 2011 00:17:45 +0000 (00:17 +0000)]
[Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
https://bugs.webkit.org/show_bug.cgi?id=68584
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/message-port-deleted-by-accessor.html
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::portsAccessorGetter):
LayoutTests:
* fast/dom/message-port-deleted-by-accessor-expected.txt: Added.
* fast/dom/message-port-deleted-by-accessor.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 22 Sep 2011 00:05:41 +0000 (00:05 +0000)]
[chromium] Rebaselines for passing tests and expectation updates/narrowing.
* platform/chromium-cg-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t090204-display-change-01-b-ao-expected.png: Added.
* platform/chromium-mac-leopard/editing/inserting/editable-inline-element-expected.png: Added.
* platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/chromium-mac/css2.1/t090204-display-change-01-b-ao-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 00:04:21 +0000 (00:04 +0000)]
Build fix following fix for bug #68586.
* jit/JIT.cpp:
* jit/JITInlineMethods.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 21 Sep 2011 23:58:20 +0000 (23:58 +0000)]
Add back protection against the NSView going away while handling mouseDown
https://bugs.webkit.org/show_bug.cgi?id=68585
Reviewed by Darin Adler.
Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
as a followup fix to https://bugs.webkit.org/show_bug.cgi?id=68570.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 21 Sep 2011 23:50:54 +0000 (23:50 +0000)]
Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled
https://bugs.webkit.org/show_bug.cgi?id=68133
Reviewed by Darin Adler.
.:
* Source/autotools/symbols.filter: Added the mangled symbols needed for window.internals
Source/WebCore:
Tests: fast/css/webkit-mask-crash-fieldset-legend.html
fast/css/webkit-mask-crash-figure.html
fast/css/webkit-mask-crash-table.html
fast/css/webkit-mask-crash-td-2.html
fast/css/webkit-mask-crash-td.html
GraphicsContext::getCTM crashes if called with a GraphicsContext that has painting
disabled. RenderBox::paintMaskImages would thus crash if called in this condition.
This change just modifies the different GraphicsContext::getCTM method to bail early
if painting is disabled on the GraphicsContext. The rest of the change is exposing
paintControlTints that exposes this.
* WebCore.exp.in: Added symbols of the newly export window.internals function.
* page/FrameView.cpp:
(WebCore::FrameView::updateControlTints): Split this function in 2 so that
I can expose the internal paintControlTints.
(WebCore::FrameView::paintControlTints):
This is the one exposed to Internals as we want to be testable regardless of
whether the platform supports control tints.
* page/FrameView.h: Added paintControlTints.
* testing/Internals.cpp:
(WebCore::Internals::paintControlTints):
* testing/Internals.h:
* testing/Internals.idl:
Added a way to force a fake painting so that we can easily reproduce the bugs.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getCTM):
Fixed all our back-end to exit early if painting is disabled.
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
Exported the new FrameView::paintControlTints function.
LayoutTests:
Those tests checks that we do not crash when calling internals.paintControlTints.
* platform/mac/Skipped: Skipped 2 tests as they are hitting an ASSERT unrelated to
this change on Mac.
* fast/css/webkit-mask-crash-fieldset-legend-expected.txt: Added.
* fast/css/webkit-mask-crash-fieldset-legend.html: Added.
* fast/css/webkit-mask-crash-figure-expected.txt: Added.
* fast/css/webkit-mask-crash-figure.html: Added.
* fast/css/webkit-mask-crash-table-expected.txt: Added.
* fast/css/webkit-mask-crash-table.html: Added.
* fast/css/webkit-mask-crash-td-2-expected.txt: Added.
* fast/css/webkit-mask-crash-td-2.html: Added.
* fast/css/webkit-mask-crash-td-expected.txt: Added.
* fast/css/webkit-mask-crash-td.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 21 Sep 2011 23:49:24 +0000 (23:49 +0000)]
DFG JIT should be able to compile op_throw
https://bugs.webkit.org/show_bug.cgi?id=68571
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-21
Reviewed by Geoffrey Garen.
This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 21 Sep 2011 23:46:09 +0000 (23:46 +0000)]
DFG JIT should be able to compile op_throw
https://bugs.webkit.org/show_bug.cgi?id=68571
Reviewed by Geoffrey Garen.
This compiles op_throw in the simplest way possible: it's an OSR
point back to the old JIT. This is a good step towards increasing
coverage, particularly on Kraken, but it's neutral because the
same functions that do throw also use some other unsupported
opcodes.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 21 Sep 2011 23:44:20 +0000 (23:44 +0000)]
IndexedDB: compare strings without decoding
https://bugs.webkit.org/show_bug.cgi?id=68554
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-21
Reviewed by Tony Chang.
Resolves a FIXME in IndexedDB that was also identified as a hotspot
during profiling. Yields a small performance improvement.
* Source/WebCore/storage/IDBLevelDBCoding.cpp:
* Source/WebCore/storage/IDBLevelDBCoding.h:
* Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 21 Sep 2011 23:36:35 +0000 (23:36 +0000)]
DFG should support continuous optimization
https://bugs.webkit.org/show_bug.cgi?id=68329
Reviewed by Geoffrey Garen.
This adds the ability to reoptimize a code block if speculation
failures happen frequently. 6% speed-up on Kraken, 1% slow-down
on V8, neutral on SunSpider.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getStrongPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
(JSC::DFG::getOSREntryDataBytecodeIndex):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
* heap/Heap.cpp:
(JSC::Heap::addJettisonCodeBlock):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/JettisonedCodeBlocks.cpp: Added.
(JSC::JettisonedCodeBlocks::JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::~JettisonedCodeBlocks):
(JSC::JettisonedCodeBlocks::addCodeBlock):
(JSC::JettisonedCodeBlocks::clearMarks):
(JSC::JettisonedCodeBlocks::deleteUnmarkedCodeBlocks):
(JSC::JettisonedCodeBlocks::traceCodeBlocks):
* heap/JettisonedCodeBlocks.h: Added.
(JSC::JettisonedCodeBlocks::mark):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
* runtime/Executable.h:
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
* wtf/BitVector.h: Added.
(WTF::BitVector::BitVector):
(WTF::BitVector::~BitVector):
(WTF::BitVector::operator=):
(WTF::BitVector::size):
(WTF::BitVector::ensureSize):
(WTF::BitVector::resize):
(WTF::BitVector::clearAll):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::bitsInPointer):
(WTF::BitVector::maxInlineBits):
(WTF::BitVector::byteCount):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::OutOfLineBits::numBits):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::OutOfLineBits::create):
(WTF::BitVector::OutOfLineBits::destroy):
(WTF::BitVector::OutOfLineBits::OutOfLineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):
(WTF::BitVector::resizeOutOfLine):
(WTF::BitVector::bits):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Wed, 21 Sep 2011 23:32:31 +0000 (23:32 +0000)]
Update committers.py with a new contributor contact
https://bugs.webkit.org/show_bug.cgi?id=68565
Reviewed by Eric Carlson.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 21 Sep 2011 23:25:35 +0000 (23:25 +0000)]
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(maybeCreateSandboxExtensionFromPasteboard): Return a boolean, telling the caller whether
an extension actually needed to be created
(-[WKView performDragOperation:]): Tell process proxy when the process is going to get
universal file read sandbox extension.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::didPerformClientRedirect): Check the URLs.
(WebKit::WebContext::didPerformServerRedirect): Ditto.
(WebKit::WebContext::didUpdateHistoryTitle): Ditto.
(WebKit::WebContext::getPluginPath): Ditto. Also, properly parse the URL - we can never
assume that a string coming from WebProcess is a ParsedURLString.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Tell process proxy when the process
is going to get universal file read sandbox extension.
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): Changed to return a boolean,
telling the caller whether an extension actually needed to be created.
(WebKit::WebPageProxy::loadURL): Tell process proxy about extension.
(WebKit::WebPageProxy::loadURLRequest): Ditto.
(WebKit::WebPageProxy::loadHTMLString): Tell process proxy if a file URL was used as a base
one for a string. In this case, WebKit2 assumes that WebProcess has access to a subdirectory,
(typically, one where error page resources live), and can load from it.
(WebKit::WebPageProxy::loadAlternateHTMLString): Ditto.
(WebKit::WebPageProxy::goForward): Tell process proxy about extension.
(WebKit::WebPageProxy::goBack): Tell process proxy about extension.
(WebKit::WebPageProxy::goToBackForwardItem): Tell process proxy about extension.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Check the URL.
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto.
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Ditto.
(WebKit::WebPageProxy::decidePolicyForNewWindowAction): Ditto.
(WebKit::WebPageProxy::decidePolicyForResponse): Ditto.
(WebKit::WebPageProxy::didInitiateLoadForResource): Ditto.
(WebKit::WebPageProxy::didSendRequestForResource): Ditto.
(WebKit::WebPageProxy::didReceiveResponseForResource): Ditto.
(WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
* UIProcess/WebPageProxy.h: Changed initializeSandboxExtensionHandle() to return a bool,
and renamed to maybeInitializeSandboxExtensionHandle (matching WKView counterpart).
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy): Initialize m_mayHaveUniversalFileReadSandboxExtension.
It's going to be true if we ever granted an extension for "/".
(WebKit::WebProcessProxy::willLoadHTMLStringWithBaseURL): Remember the path, we should expect
that WebProcess will load subresources from it.
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): Check that it's reasonable to expect
WebProcess send us a URL like this.
(WebKit::WebProcessProxy::addBackForwardItem): Check the URLs.
* UIProcess/WebProcessProxy.h: Added data members remembering what to expect from this process.
* UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData):
Tell process proxy when the process is going to get universal file read sandbox extension.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 21 Sep 2011 23:06:42 +0000 (23:06 +0000)]
Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=68382
Source/WebCore:
Reviewed by Darin Adler.
Only create a AudioContext object if the Web Audio feature is runtime-enabled in Settings.
No new tests, as this feature is not yet enabled by default.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitAudioContext):
Source/WebKit/mac:
Reviewed by Darin Adler.
Initialize the webAudioEnabled preference to NO by default.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
Add support for the webAudioEnabled preference in WebKit2.
Reviewed by Darin Adler.
* Shared/WebPreferencesStore.h: Add WebAudioEnabled getter and setter macro.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebAudioEnabled): Added.
(WKPreferencesGetWebAudioEnabled): Added.
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update the webAudioEnabled preference.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 21 Sep 2011 22:54:50 +0000 (22:54 +0000)]
[chromium] Code cleanup in gesture recognizer unit tests
https://bugs.webkit.org/show_bug.cgi?id=68561
Fix some style nits in the gesture recognizer unit tests.
Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-21
Reviewed by David Levin.
* tests/InnerGestureRecognizerTest.cpp:
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 21 Sep 2011 22:43:11 +0000 (22:43 +0000)]
Should support value profiling on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=68575
Reviewed by Sam Weinig.
Fix verbose profiling in ToT (SlowCaseProfile had been
partially renamed to RareCaseProfile), add in-memory
bucket counter for CPU(X86), move JIT::m_canBeOptimized
out of the DFG_JIT ifdef.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 21 Sep 2011 22:41:11 +0000 (22:41 +0000)]
Remove checks for Leopard-only Objective-C APIs
https://bugs.webkit.org/show_bug.cgi?id=68579
Reviewed by Sam Weinig.
We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
../WebCore:
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
* bridge/objc/objc_instance.mm:
(allocateAutoReleasePool):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcField::ObjcField):
* page/mac/EventHandlerMac.mm:
../WebKit/mac:
* Misc/WebNSObjectExtras.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 21 Sep 2011 22:33:21 +0000 (22:33 +0000)]
Fix resolve-Changelog's strange butchery of the LayoutTests/Changelog.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 21 Sep 2011 22:20:04 +0000 (22:20 +0000)]
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570
Reviewed by Sam Weinig.
These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
* rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 21 Sep 2011 22:17:06 +0000 (22:17 +0000)]
DFG does not support compiling functions as constructors
https://bugs.webkit.org/show_bug.cgi?id=68500
Reviewed by Oliver Hunt.
This adds support for compiling constructors to the DFG. It's a
1% speed-up on V8, mostly due to a 6% speed-up on early-boyer.
It's also a 13% win on access-binary-trees, but it's neutral in
the SunSpider and Kraken averages.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 21 Sep 2011 22:05:07 +0000 (22:05 +0000)]
Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
https://bugs.webkit.org/show_bug.cgi?id=67656
Reviewed by David Hyatt.
Test: fast/table/quote-text-around-iframe.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
LayoutTests: Not use anonymousContainer on beforeChild calculation
and let later code handle it.
https://bugs.webkit.org/show_bug.cgi?id=67656
Reviewed by David Hyatt.
* fast/table/quote-text-around-iframe.html: Added.
* fast/table/table-row-style-not-updated-with-after-content-expected.txt:
* platform/mac/fast/table/quote-text-around-iframe-expected.png: Added.
* platform/mac/fast/table/quote-text-around-iframe-expected.txt: Added.
and lot of style propagation rebaselines.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 21 Sep 2011 21:56:18 +0000 (21:56 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68562
Pagination struts don't update properly when collapsing margin estimates are wrong.
Refactor the pagination adjustments that happen during block layout to allow for
a 3-pass layout system instead of just a 2-pass layout system. The basic idea is
to come up with an estimate that includes collapsing, clearance and pagination.
If the estimate only with collapsing and clearance was wrong, then we lay out again
using the correct collapsing margin values and clearance before applying pagination breaks.
After this second layout, the normal code that runs when unpaginated compares estimates
and lays out a third time to account for adjustments as a result of pagination movement.
Reviewed by Sam Weinig.
Added fast/regions/text-regions-split-small-pagination.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::adjustBlockChildForPagination):
* rendering/RenderBlock.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68562
Pagination struts don't update properly when collapsing margin estimates are wrong.
Add a new regions result to test the bug fix.
Reviewed by Sam Weinig.
* fast/regions/text-region-split-small-pagination.html: Added.
* platform/mac/fast/regions/text-region-split-small-pagination-expected.png: Added.
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Wed, 21 Sep 2011 21:21:47 +0000 (21:21 +0000)]
Remove old and busted context notification APIs
https://bugs.webkit.org/show_bug.cgi?id=68381
Reviewed by David Levin.
* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 21 Sep 2011 20:39:08 +0000 (20:39 +0000)]
[chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558
Reviewed by Stephen White.
The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 21 Sep 2011 20:13:57 +0000 (20:13 +0000)]
[Chromium] Protect the Frame in V8HTMLDocument::openCallback
https://bugs.webkit.org/show_bug.cgi?id=68555
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-21
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/dom/frame-deleted-in-document-open.html
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
LayoutTests:
* fast/dom/frame-deleted-in-document-open-expected.txt: Added.
* fast/dom/frame-deleted-in-document-open.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 21 Sep 2011 19:59:39 +0000 (19:59 +0000)]
Replace jsFunctionVPtr compares with a type check on the Structure.
https://bugs.webkit.org/show_bug.cgi?id=68557
Reviewed by Oliver Hunt.
This will permit calls to still optimize to subclasses of JSFunction
that have the correct type (but a different C++ vptr).
This patch stops passing the globalData into numerous functions.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotType):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.h:
(JSC::isHostFunction):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
* runtime/JSObject.h:
(JSC::getJSFunction):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/JSType.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Wed, 21 Sep 2011 19:49:23 +0000 (19:49 +0000)]
Unreviewed. Remove unused ENABLE_AS_IMAGE flag after r95234 from
Options{Efl,WinCE}.cmake.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 21 Sep 2011 19:47:48 +0000 (19:47 +0000)]
Clean up CSS Counter code
https://bugs.webkit.org/show_bug.cgi?id=68492
Reviewed by Tony Chang.
Source/WebCore:
Several cleanups/fixes:
- Make Counter::listStyle() return the actual list style string,
rather than empty string.
- Handle a specified list style of "none" correctly when generating
cssText and in Counter::listStyle().
- Use StringBuilder when generating cssText.
Test: fast/css/counters/getCounterValue.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCounterContent):
Simplify processing (moving conversion to CSSStyleSelector),
pass a CSS_IDENT as the listStyle to Counter::create.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
Use StringBuilder.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Convert from a CSS_IDENT to an EListStyleType.
* css/Counter.h:
(WebCore::Counter::listStyleIdent):
Renamed from listStyleNumber to match its new functionality.
LayoutTests:
Added tests for setting the list style to "none"
as well as tests for getCounterValue.
* fast/css/counters/counter-cssText-expected.txt:
* fast/css/counters/counter-cssText.html:
* fast/css/counters/getCounterValue-expected.txt: Added.
* fast/css/counters/getCounterValue.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 21 Sep 2011 19:34:39 +0000 (19:34 +0000)]
Removed WTFTHREADDATA_MULTITHREADED, making it always true
https://bugs.webkit.org/show_bug.cgi?id=68549
Reviewed by Darin Adler.
Another part of making threads exist in WebKit.
* wtf/WTFThreadData.cpp:
* wtf/WTFThreadData.h:
(WTF::wtfThreadData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Wed, 21 Sep 2011 19:33:10 +0000 (19:33 +0000)]
2011-09-21 Chris Marrin <cmarrin@apple.com>
Check in WebCore.vcproj file unchanged but written like MSDev likes it
Unreviewed.
* WebCode.vcproj/WebCore.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 21 Sep 2011 19:30:44 +0000 (19:30 +0000)]
Use the prefix "WK" instead of "Web" for Objective-C classes defined in WebKit2.
Reviewed by Anders Carlsson.
Renamed WebInspectorProxyObjCAdapter to WKWebInspectorProxyObjCAdapter.
Renamed WebInspectorWKView to WKWebInspectorWKView.
Renamed WebFindIndicatorWindowAnimation to WKFindIndicatorWindowAnimation.
Renamed WebFindIndicatorView to WKFindIndicatorView.
Renamed WebUserDataWrapper to WKUserDataWrapper.
Updated the build phase checking for inappropriate Objective-C class names to disallow the prefix
"Web" and only allow "WK".
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItemVector):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc