David Kershner [Mon, 17 Jul 2017 20:17:15 +0000 (16:17 -0400)]
staging: unisys: visorbus: Remove unused define for visorchipset.
The define CURRENT_FILE_PC was not being used, so just remove it.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Foresta [Mon, 17 Jul 2017 20:17:14 +0000 (16:17 -0400)]
staging: unisys: visorbus: cleaned up include block of visorchipset.c
Removed 4 unneeded includes netdevice, nls, fs, and ctype.
Signed-off-by: Mark Foresta <Mark.Foresta@Unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Foresta [Mon, 17 Jul 2017 20:17:13 +0000 (16:17 -0400)]
staging: unisys: visorbus: Removed unused define from visorbus_main.c
Removed unused #define CURRENT_FILE_PC.
Signed-off-by: Mark Foresta <Mark.Foresta@Unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Foresta [Mon, 17 Jul 2017 20:17:12 +0000 (16:17 -0400)]
staging: unisys: visorbus: removed blank line in viorbus_main.c
Removed blank line between #defines.
Signed-off-by: Mark Foresta <Mark.Foresta@Unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 17 Jul 2017 20:17:09 +0000 (16:17 -0400)]
staging: unisys: visorchipset: remove local_addr in handle_command
In the function handle_command, the variable local_addr is always false. So
this patch is getting rid of logic when it is true.
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 17 Jul 2017 20:17:08 +0000 (16:17 -0400)]
staging: unisys: visorbus: remove target_hostname comment
This patch simply removes TARGET_HOSTNAME comment that is no
longer relevant.
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 17 Jul 2017 20:17:07 +0000 (16:17 -0400)]
staging: unisys: visorbus: rename fix_vbus_dev_info
Rename fix_vbus_dev_info to something clearer: publish_vbus_dev_info.
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Zachary Dremann [Mon, 17 Jul 2017 20:17:03 +0000 (16:17 -0400)]
staging: unisys: visorbus: Fix memory leak
The name of a visor_device was never freed, which was allocated in
visorbus_configure.
It is expected that visorbus_device_destroy will not be called on the
same visor_device again, or this would be a double free.
Signed-off-by: Zachary Dremann <dremann@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:17:02 +0000 (16:17 -0400)]
staging: unisys: moved visor_check_channel from include/channel.h to visorbus/visorbus_main.c
Moved the function visor_check_channel() from include/channel.h to
visorbus/visorbus_main.c.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:17:01 +0000 (16:17 -0400)]
staging: unisys: include: Remove unused CHANNEL_OK defines.
The VISOR_VNIC_CHANNEL_OK_CLIENT and VISOR_HBA_CHANNEL_OK_CLIENT macros
were not being used. They can be removed.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:17:00 +0000 (16:17 -0400)]
staging: unisys: remove unused define VISOR_VSWITCH_CHANNEL_VERSIONID
The VSWITCH channel is not used in Linux guests, so remove the VERSIONID.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:16:59 +0000 (16:16 -0400)]
staging: unisys: visorbus: add checks for probe, remove, pause and resume in visorbus_register_visor_driver
Added checks for functions probe, remove, pause and resume in
visorbus_register_visor_driver() and removed these checks from
the individual functions itself.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:16:58 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorbus_main.c: remove check from typename_show
Remove check for xbus in typename_show() function in
visorbus_main.c.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:16:57 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorbus_main.c: put function name and return value on same line.
This patch makes function definitions more consistent by having function
name and return values on the same line.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:16:56 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorbus_main.c: remove extra checks for dev->visorchannel
Removed checks for dev->visorchannel in visorbus_release_device()
and visorbus_remove_instance() since it is also checked in the
visorchannel_destroy() function.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Mon, 17 Jul 2017 20:16:55 +0000 (16:16 -0400)]
staging: unisys: visorbus: convert VMCALL_CONTROLVM_ADDR enum to #define
VMCALL_CONTROLVM_ADDR is the only element left in enum
vmcall_monitor_interface_method_tuple. Converting it to a #define.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alex Curtin [Mon, 17 Jul 2017 20:16:54 +0000 (16:16 -0400)]
staging: unisys: include: iochannel.h: removed VISOR_VSWITCH_CHANNEL_SIGNATURE
VISOR_VSWITCH_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. It wasn't being used, so it has been removed.
Signed-off-by: Alex Curtin <alexander.curtin@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alex Curtin [Mon, 17 Jul 2017 20:16:53 +0000 (16:16 -0400)]
staging: unisys: include: iochannel.h: removed VISOR_VNIC_CHANNEL_SIGNATURE
VISOR_VNIC_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. This replaces that definition with
VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin <alexander.curtin@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alex Curtin [Mon, 17 Jul 2017 20:16:52 +0000 (16:16 -0400)]
staging: unisys: include: iochannel.h: removed VISOR_VHBA_CHANNEL_SIGNATURE
VISOR_VHBA_CHANNEL_SIGNATURE is a redundant definition that points to
VISOR_CHANNEL_SIGNATURE. This replaces that definition with
VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin <alexander.curtin@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alex Curtin [Mon, 17 Jul 2017 20:16:51 +0000 (16:16 -0400)]
staging: unisys: visorbus: vbuschannel.h: removed VISOR_VBUS_CHANNEL_SIGNATURE
VISOR_VBUS_CHANNEL_SIGNATURE just pointed to VISOR_CHANNEL_SIGNATURE, so
this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin <alexander.curtin@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alex Curtin [Mon, 17 Jul 2017 20:16:50 +0000 (16:16 -0400)]
staging: unisys: visorbus: controlvmchannel.h: removed VISOR_CONTROLVM_CHANNEL_SIGNATURE
VISOR_CONTROLVM_CHANNEL_SIGNATURE points to VISOR_CHANNEL_SIGNATURE, so
this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE.
Signed-off-by: Alex Curtin <alexander.curtin@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 17 Jul 2017 20:16:49 +0000 (16:16 -0400)]
staging: unisys: include: channel.h: remove unused pound defines
This patch removes all the unused pound defines currently in
channel.h.
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:48 +0000 (16:16 -0400)]
staging: unisys: visorhba: viosrhba_main.c: Remove unnecessary checks
Removes unnecessary checks for a NULL pointer in a non-API function.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 17 Jul 2017 20:16:47 +0000 (16:16 -0400)]
staging: unisys: visorbus: controlvmchannel.h: fix spacing
This patch fixes space and tab aligned comments in
controlvmchannel.h.
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:46 +0000 (16:16 -0400)]
staging: unisys: visornic: visornic_main.c: Adjust whitespace usage
Adjusts whitespace usage in order to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:45 +0000 (16:16 -0400)]
staging: unisys: visorinput: visorinput.c: Adjust whitespace usage
Adjusts whitespace usage in order to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:44 +0000 (16:16 -0400)]
staging: unisys: visorhba: visorhba_main.c: Adjust whitespace usage
Removes unnecessary blank lines to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:43 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorbus_main.c: Adjust code layout
Adjusts the ordering of function statements, as well as modifies
whitespace usage, in order to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Mon, 17 Jul 2017 20:16:42 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorchipset.c: Adjust code layout
Adjusts the ordering of function statements, as well as modifies whitespace
usage, in order to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Zachary Dremann [Mon, 17 Jul 2017 20:16:41 +0000 (16:16 -0400)]
staging: unisys: visorbus: visorbus_main.c: use __func__ over hardcoded name
As reported by checkpatch.pl, replace hard-coded usage of the current
function's name in format string with usage of __func__.
Signed-off-by: Zachary Dremann <dremann@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Fri, 14 Jul 2017 21:33:54 +0000 (22:33 +0100)]
staging: lustre: fix spelling mistake, "grranted" -> "granted"
Trivial fix to spelling mistake in CERROR error message. Also
clean up the grammar.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Sat, 15 Jul 2017 15:39:22 +0000 (11:39 -0400)]
staging: lustre: lustre: fix all braces issues reported by checkpatch
Cleanup all braces that was reported by checkpatch. The only
issue not fixed up is in mdc_lock.c. Removing the braces in
the case of mdc_lock.c will break the build.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shreeya Patel [Sun, 16 Jul 2017 09:50:42 +0000 (15:20 +0530)]
Staging: rtl8192u: Use __func__ instead of function name.
Current function name is accessed using __func__.
Use '%s and __func__' instead of a function name.
Problem found by checkpatch.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marcus Wolf [Sun, 16 Jul 2017 10:52:06 +0000 (11:52 +0100)]
staging: pi433: New driver
Added a driver for the pi433 radio module
(see https://www.pi433.de/en.html for details).
Signed-off-by: Marcus Wolf <linux@Wolf-Entwicklungen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Craig Inches [Wed, 12 Jul 2017 09:03:28 +0000 (09:03 +0000)]
Staging: Lustre Fix block statement style issue
This fixes a block statement which didnt end with */
Signed-off-by: Craig Inches <Craig@craiginches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Craig Inches [Wed, 12 Jul 2017 09:03:04 +0000 (09:03 +0000)]
Staging: Lustre Fixing multiline block comments in lnetst.h
This fixes multiple block statements found not to match
style as per checkpatch
Signed-off-by: Craig Inches <Craig@craiginches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Craig Inches [Wed, 12 Jul 2017 09:02:53 +0000 (09:02 +0000)]
Staging: Lustre Fix up multiple Block Comments in lib-types.h
This patch fixes some multiline comment blocks which didnt conform
to the style guide, found by checkpatch.
Signed-off-by: Craig Inches <Craig@craiginches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Craig Inches [Wed, 12 Jul 2017 09:02:40 +0000 (09:02 +0000)]
Staging: Lustre Clean up line over 80Char in lib-lnet.h
This patch fixes a warning generated by checkpatch for
a line over 80 characters.
Signed-off-by: Craig Inches <Craig@craiginches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Simon Sandström [Fri, 30 Jun 2017 21:38:54 +0000 (23:38 +0200)]
staging: vt6656: Use variable instead of its type in sizeof(...)
Use sizeof(variable) instead of sizeof(type) in memory allocations to
prevent problems if the variable type changes in the future.
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Simon Sandström [Fri, 30 Jun 2017 21:38:53 +0000 (23:38 +0200)]
staging: vt6656: Align function parameters
Fixes checkpatch.pl warnings "Alignment should match open parenthesis".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Simon Sandström [Fri, 30 Jun 2017 21:38:52 +0000 (23:38 +0200)]
staging: vt6656: Remove unnecessary blank lines
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open
brace". Also adds braces to balance if-else statement.
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Simon Sandström [Fri, 30 Jun 2017 21:38:51 +0000 (23:38 +0200)]
staging: vt6656: Add spaces between operators
Fixes checkpatch.pl warnings "spaces preferred around that <operator>".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janusz Lisiecki [Mon, 3 Jul 2017 04:41:39 +0000 (06:41 +0200)]
staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c
This patch fixes the following Sparse warnings in ks_wlan_net.c:
drivers/staging/ks7010/ks_wlan_net.c:1359:24: warning: cast to restricted __le16
link_ap_info_t structure field 'capability' has native order and is used everywhere
in the code in such way (i.e get_ap_information, get_current_ap). Both sides of
assignment are u16 (native order) so 'le16_to_cpu' is not needed and wrong.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lukasz Faber [Wed, 5 Jul 2017 09:45:09 +0000 (11:45 +0200)]
staging: rtl8192u: Fix braces placement and spacing
Fixes the following checkpatch errors:
- open brace '{' following enum go on the same line
- space required after that close brace '}'
Signed-off-by: Lukasz Faber <faber@agh.edu.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Mon, 10 Jul 2017 14:05:28 +0000 (16:05 +0200)]
staging: rtl8192u: reduce stack frame size in ieee80211_rx_mgt_rsl
I ran into a stack frame size warning in code that hasn't changed much
recently, no idea why I didn't spot this earlier despite build many
thousand randconfigs.
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function 'ieee80211_rx_mgt_rsl':
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2563:1: error: the frame size of 1676 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
We have a couple of other copies of the same function in the kernel,
and they simply don't put a gigantic structure on the stack, so I'm
changing this copy to do the same as the others, replacing the
stack variable with a GFP_ATOMIC allocation.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Tue, 11 Jul 2017 17:49:27 +0000 (18:49 +0100)]
staging: fbtft: make const array gamma_par_mask static
Don't populate array gamma_par_mask on the stack but instead make it
static. Makes the object code smaller by 148 bytes:
Before:
text data bss dec hex filename
2993 1104 0 4097 1001 drivers/staging/fbtft/fb_st7789v.o
After:
text data bss dec hex filename
2757 1192 0 3949 f6d drivers/staging/fbtft/fb_st7789v.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Teng [Thu, 13 Jul 2017 02:10:17 +0000 (10:10 +0800)]
staging: lustre: fix sparse error: incompatible types in comparison expression
Comparing two user space addresses to avoid sparse error:
drivers/staging//lustre/lnet/selftest/conrpc.c:490:30: error:
incompatible types in comparison expression (different address spaces)
Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bincy K Philip [Wed, 12 Jul 2017 07:31:12 +0000 (13:01 +0530)]
staging: ccree: move comment to fit coding style
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:20:02 +0000 (11:20 +0300)]
staging: ccree: remove whitespace before a quoted newline
Remove unnecessary whitespace before a quoted newline in strings.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:59 +0000 (11:19 +0300)]
staging: ccree: avoid unnecessary line continuation
Avoid unnecessary line continuation in log function call.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:58 +0000 (11:19 +0300)]
staging: ccree: avoid constant comparison
Re-write predicate to avoid constant comparison.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:57 +0000 (11:19 +0300)]
staging: ccree: CamelCase to snake_case in aead struct
Rename aead_req_struct fields from CamelCase to snake_case.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:56 +0000 (11:19 +0300)]
staging: ccree: CamelCase to snake_case in func vars
Turn local vars and function parameters names in CamelCase
to snake_case.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:53 +0000 (11:19 +0300)]
staging: ccree: use proper printk format for dma_addr_t
Fix needless casting to unsigned long long in printk for
DMA addresses by using proper %pad format.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:52 +0000 (11:19 +0300)]
staging: ccree: clean up struct ssi_aead_ctx
struct ssi_aead_ctx has some nested structure defined, resulting
in code accessing them to be very unreadable.
Move out the nested structure definitions out of the struct
and use the change to make the code accessing it more readable
and better coding style compliant by shortening lines and
properly matching alignment,
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gilad Ben-Yossef [Thu, 13 Jul 2017 08:19:51 +0000 (11:19 +0300)]
staging: ccree remove unnecessary parentheses
Remove unnecessary parentheses from ccree driver code.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Mon, 3 Jul 2017 23:13:34 +0000 (19:13 -0400)]
staging: comedi: Use offset_in_page macro
Use offset_in_page macro instead of (var & ~PAGE_MASK)
The Coccinelle semantic patch used to make this change is as follows:
// <smpl>
@@
unsigned long p;
@@
- p & ~PAGE_MASK
+ offset_in_page(p)
// </smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Nowotyński [Sun, 9 Jul 2017 16:14:42 +0000 (18:14 +0200)]
Staging: android: use BIT macro
Use BIT macro instead of left shifting in android/ion/ion.h
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Nowotyński [Sun, 9 Jul 2017 16:14:41 +0000 (18:14 +0200)]
Staging: android: Fix code alignment issue
Fixes code alignment issue in ion/ion.h
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Nowotyński [Sun, 9 Jul 2017 16:14:40 +0000 (18:14 +0200)]
Staging: android: Remove unnecessary blank lines
Removes unnecessary blank lines in android/ion/ion_system_heap.c
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Nowotyński [Sun, 9 Jul 2017 16:14:39 +0000 (18:14 +0200)]
Staging: android: fix sizeof style issue
Converts sizeof(type) to sizeof(variable) in android/ion/ion_cma_heap.c
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Nowotyński [Sun, 9 Jul 2017 16:14:38 +0000 (18:14 +0200)]
Staging: android: remove unnecessary blank lines
Removes unnecessary blank lines in android/ion/ion_cma_heap.c
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kamal Heib [Fri, 30 Jun 2017 18:34:43 +0000 (21:34 +0300)]
staging: android: ion: statify __ion_add_cma_heaps
Fix the following sparse warning:
symbol '__ion_add_cma_heaps' was not declared. Should it be static?
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Radulescu [Thu, 29 Jun 2017 16:25:46 +0000 (11:25 -0500)]
staging: fsl-dpaa2/eth: Remove dead code
All possible values of the switch statement are explicitly
handled, so there's no need to have a default branch.
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Acked-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Fri, 30 Jun 2017 19:43:26 +0000 (15:43 -0400)]
staging: unisys: visorbus: fix improper bracket blocks
This patch fixes visorbus_main.c improper function brackets.
for the following functions:
partition_handle_show
partition_guid_show
partition_name_show
channel_addr_show
channel_bytes_show
channel_id_show
Signed-off-by: Erik Arfvidson <erik.arfvidson@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Zachary Dremann [Fri, 30 Jun 2017 19:43:25 +0000 (15:43 -0400)]
staging: unisys: visorbus: use __func__ over hardcoded name
As reported by checkpatch.pl, replace hardcoded uses of the current
function's name in format strings with uses of __func__.
Signed-off-by: Zachary Dremann <dremann@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Zachary Dremann [Fri, 30 Jun 2017 19:43:24 +0000 (15:43 -0400)]
staging: unisys: visorbus: Indent struct assignment correctly
Several structure initializations all had their members indented with 2
tabs instead of one. Remove the extra tabs.
Signed-off-by: Zachary Dremann <dremann@gmail.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Steve Wilson [Fri, 30 Jun 2017 19:43:23 +0000 (15:43 -0400)]
staging: unisys: visorbus: adjust tabs in function
Removed extra tabs in visorbus_get_device_by_id function.
Signed-off-by: Steve Wilson <steven.d.wilson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:22 +0000 (15:43 -0400)]
staging: unisys: visorbus: controlvmchannel.h: Adjust whitespace usage
Removes unnecessary blank lines to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:21 +0000 (15:43 -0400)]
staging: unisys: include: visorbus.h: Adjust whitespace usage
Adjusts presence of blank lines to create a more uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:20 +0000 (15:43 -0400)]
staging: unisys: include: iochannel.h: Adjust whitespace usage
Adjusts spacing and removes unnecessary blank lines to create a more
uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:19 +0000 (15:43 -0400)]
staging: unisys: include: channel.h: Adjust whitespace usage
Adjusts spacing and removes unnecessary blank lines to create a more
uniform coding style.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:18 +0000 (15:43 -0400)]
staging: unisys: visorhba: Fix up existing function comments
Refactors existing static function comments to increase code readability.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:17 +0000 (15:43 -0400)]
staging: unisys: visorbus: Rename #define to fit surrounding namespace
Renames MYDRVNAME to better fit with the surrounding driver namespace.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:16 +0000 (15:43 -0400)]
staging: unisys: visorbus: Remove unused #define
Removes unused MYDRVNAME define.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder [Fri, 30 Jun 2017 19:43:15 +0000 (15:43 -0400)]
staging: unisys: include: Fix spelling mistake
Fixes minor spelling mistake: stired -> stored.
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:14 +0000 (15:43 -0400)]
staging: unisys: visorinput: ultrainputreport.h: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:13 +0000 (15:43 -0400)]
staging: unisys: visorinput: visorinput.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:12 +0000 (15:43 -0400)]
staging: unisys: visorhba: visorhba_main.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:11 +0000 (15:43 -0400)]
staging: unisys: visornic: visornic_main.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:10 +0000 (15:43 -0400)]
staging: unisys: include: iochannel.h: fixed comment formatting issues
Removed comments from the right side of the lines.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:09 +0000 (15:43 -0400)]
staging: unisys: include: channel.h: fixed comment formatting issues
Removed comments from the right side of the lines.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:08 +0000 (15:43 -0400)]
staging: unisys: visorbus: visorchipset.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:07 +0000 (15:43 -0400)]
staging: unisys: visorbus: visorchannel.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 30 Jun 2017 19:43:06 +0000 (15:43 -0400)]
staging: unisys: include: remove unused macros in channel.h
Several MACROS were not in use by the code, get rid of them.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:05 +0000 (15:43 -0400)]
staging: unisys: visorbus: visorbus_main.c: fixed comment formatting issues
Removed comments from the right side of the lines.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:04 +0000 (15:43 -0400)]
staging: unisys: visorbus: vmcallinterface.h: fixed comment formatting issues
Removed comments from the right side of the lines.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:03 +0000 (15:43 -0400)]
staging: unisys: visorbus: vbuschannel.h: fixed comment formatting issues
Removed comments from the right side of the lines.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sameer Wadgaonkar [Fri, 30 Jun 2017 19:43:02 +0000 (15:43 -0400)]
staging: unisys: visorbus: controlvmchannel.h: fixed comment formatting issues
Removed comments from the right side of lines and fixed spacing in
comments.
Added kernel-doc like comments and cleaned up the inline comments in the
structures.
Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dmitriy Cherkasov [Fri, 7 Jul 2017 23:03:42 +0000 (16:03 -0700)]
staging: lustre: lnet: remove dead code and useless wrapper
After removing commented out code, ksocknal_csum() becomes a useless
wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
Fixes the following checkpatch warning:
WARNING: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmitriy@oss-tech.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Gardner [Fri, 7 Jul 2017 00:24:32 +0000 (10:24 +1000)]
staging: typec: Fix endianness warning discovered by sparse
The below warning is resolved by removing the cpu_to_le32() call. This
call was redundant; vdm_run_state_machine() ensures that SVDM responses
have the correct endianness before sending.
typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types)
typec/tcpm.c:1019:49: expected unsigned int [unsigned] [usertype] <noident>
typec/tcpm.c:1019:49: got restricted __le32 [usertype] <noident>
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shreeya Patel [Sat, 8 Jul 2017 19:58:25 +0000 (01:28 +0530)]
staging: rtl8723bs: Place constant at the right.
Move constant to the right of a relational operator.
This coding style is more common for the kernel code.
Problem found by checkpatch.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Muhammad Falak R Wani [Fri, 7 Jul 2017 10:10:39 +0000 (15:40 +0530)]
staging: rtl8712: Remove explicit NULL comparison
Replace the explicit "if (val != NULL)" with if (val).
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arushi Singhal [Fri, 7 Jul 2017 05:41:36 +0000 (11:11 +0530)]
staging: rtl8712: fix "Alignment match open parenthesis"
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mitchell Tasman [Tue, 11 Jul 2017 03:14:44 +0000 (23:14 -0400)]
staging: greybus: arche: wrap over-length lines
Adjust formatting of several comments to keep line length within
the 80 column limit preferred by the Linux kernel coding style.
Signed-off-by: Mitchell Tasman <tasman@leaflabs.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aleksey Rybalkin [Mon, 3 Jul 2017 18:27:15 +0000 (23:27 +0500)]
staging: greybus: loopback_test: fix comment style issues
According to checkpatch warning, block comments should align the * on
each line. Also, preferred style for multi-line comments is starting the
comment text after the second *.
Signed-off-by: Aleksey Rybalkin <aleksey@rybalkin.org>
Acked-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilia Sergachev [Sun, 9 Jul 2017 21:36:35 +0000 (23:36 +0200)]
staging: wilc1000: fix variable signedness
txq_count receives a value from wilc_wlan_handle_txq()
and therefore should be u32
found using sparse:
drivers/staging/wilc1000/linux_wlan.c:306:58: warning:
incorrect type in argument 2 (different signedness)
Signed-off-by: Ilia Sergachev <ilia.sergachev@unibas.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dmitriy Cherkasov [Sat, 8 Jul 2017 22:44:47 +0000 (15:44 -0700)]
staging: wilc1000: add parameter name to function definition
Add missing parameter name to fix the following checkpatch.pl warning:
WARNING: function definition argument 'struct device *' should also have
an identifier name
Signed-off-by: Dmitriy Cherkasov <dmitriy@oss-tech.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Fri, 30 Jun 2017 10:46:40 +0000 (11:46 +0100)]
staging: wilc1000: fix a typo: "incative" -> "inactive"
Trivial fix to typos in netdev_err error messages. I should have spotted
this in a previous round of spelling mistake checks on this driver but
this one slipped through.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joe Perches [Thu, 29 Jun 2017 15:42:00 +0000 (08:42 -0700)]
staging: wilc1000: Neaten refresh_scan - remove always 1 argument
All uses of refresh_scan() have a constant 1 as the second argument.
Remove it and neaten the function declaration.
Miscellanea:
o Remove overly deep indentation by using continue;
o Remove unnecessary test of the address of a static array as it's
always non-zero
o Rename and use proper type for the first void * argument as it's
always the struct wilc_priv *
o Move variables into loop where used
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log