platform/upstream/llvm.git
7 years ago[InstSimplify] Try hard to simplify pointer comparisons
David Majnemer [Sun, 7 Aug 2016 07:58:10 +0000 (07:58 +0000)]
[InstSimplify] Try hard to simplify pointer comparisons

Simplify ptrtoint comparisons involving operands with different source
types.

llvm-svn: 277951

7 years ago[InstCombine] Infer inbounds on geps of allocas
David Majnemer [Sun, 7 Aug 2016 07:58:00 +0000 (07:58 +0000)]
[InstCombine] Infer inbounds on geps of allocas

llvm-svn: 277950

7 years ago[X86] Add commutable floating point max/min instructions to the load folding tables.
Craig Topper [Sun, 7 Aug 2016 05:39:51 +0000 (05:39 +0000)]
[X86] Add commutable floating point max/min instructions to the load folding tables.

llvm-svn: 277949

7 years ago[AVX-512] Add andnps/andnpd to the avx512vl stack folding test.
Craig Topper [Sun, 7 Aug 2016 05:39:48 +0000 (05:39 +0000)]
[AVX-512] Add andnps/andnpd to the avx512vl stack folding test.

llvm-svn: 277948

7 years ago[X86] Simplify a shuffle mask copy. NFC
Craig Topper [Sun, 7 Aug 2016 05:39:46 +0000 (05:39 +0000)]
[X86] Simplify a shuffle mask copy. NFC

llvm-svn: 277947

7 years agoRevert "Revert "[LoopSimplify] Fix updating LCSSA after separating nested loops.""
Michael Zolotukhin [Sun, 7 Aug 2016 01:56:54 +0000 (01:56 +0000)]
Revert "Revert "[LoopSimplify] Fix updating LCSSA after separating nested loops.""

This reverts commit r277901. Reaaply the commit as it looks like it has
nothing to do with the bots failures.

llvm-svn: 277946

7 years ago[ExecutionEngine][RuntimeDyld] Move JITSymbol from ExecutionEngine to RuntimeDyld.
Lang Hames [Sun, 7 Aug 2016 01:19:37 +0000 (01:19 +0000)]
[ExecutionEngine][RuntimeDyld] Move JITSymbol from ExecutionEngine to RuntimeDyld.

JITSymbol really belongs in RuntimeDyld. This should fix the llvm-rtdyld link
failures caused by r277943.

llvm-svn: 277945

7 years ago[RuntimeDyld] Remove symbol that is unused as of r277943.
Lang Hames [Sun, 7 Aug 2016 01:12:44 +0000 (01:12 +0000)]
[RuntimeDyld] Remove symbol that is unused as of r277943.

llvm-svn: 277944

7 years ago[RuntimeDyld] Replace manual flag checks with JITSymbolFlags::fromObjectSymbol.
Lang Hames [Sun, 7 Aug 2016 00:18:14 +0000 (00:18 +0000)]
[RuntimeDyld] Replace manual flag checks with JITSymbolFlags::fromObjectSymbol.

llvm-svn: 277943

7 years ago[ORC] Re-apply r277896, removing bogus triples and datalayouts that broke tests
Lang Hames [Sat, 6 Aug 2016 22:36:26 +0000 (22:36 +0000)]
[ORC] Re-apply r277896, removing bogus triples and datalayouts that broke tests
on linux last time.

llvm-svn: 277942

7 years ago[libFuzzer] make libFuzzer work with a bit older clang versions
Kostya Serebryany [Sat, 6 Aug 2016 21:28:56 +0000 (21:28 +0000)]
[libFuzzer] make libFuzzer work with a bit older clang versions

llvm-svn: 277941

7 years ago[libFuzzer] don't print bogus error message
Kostya Serebryany [Sat, 6 Aug 2016 21:23:29 +0000 (21:23 +0000)]
[libFuzzer] don't print bogus error message

llvm-svn: 277940

7 years ago[X86][AVX2] Improve sign/zero extension on AVX2 targets
Simon Pilgrim [Sat, 6 Aug 2016 21:21:12 +0000 (21:21 +0000)]
[X86][AVX2] Improve sign/zero extension on AVX2 targets

Split extensions to large vectors into 256-bit chunks - the equivalent of what we do with pre-AVX2 into 128-bit chunks

llvm-svn: 277939

7 years agoCoroSplit: Squash unused variable FnTrigger warning in NDEBUG
Gor Nishanov [Sat, 6 Aug 2016 21:11:10 +0000 (21:11 +0000)]
CoroSplit: Squash unused variable FnTrigger warning in NDEBUG

llvm-svn: 277938

7 years ago[Coroutines] Passify the build bots. Remove restart-trigger.ll test for now
Gor Nishanov [Sat, 6 Aug 2016 21:01:22 +0000 (21:01 +0000)]
[Coroutines] Passify the build bots. Remove restart-trigger.ll test for now

llvm-svn: 277937

7 years ago[Coroutines] Part 5: Add CGSCC restart trigger
Gor Nishanov [Sat, 6 Aug 2016 20:44:39 +0000 (20:44 +0000)]
[Coroutines] Part 5: Add CGSCC restart trigger

Summary:
CoroSplit pass processes the coroutine twice. First, it lets it go through
complete IPO optimization pipeline as a single function. It forces restart
of the pipeline by inserting an indirect call to an empty function "coro.devirt.trigger"
which is devirtualized by CoroElide pass that triggers a restart of the pipeline by CGPassManager.
(In later patches, when CoroSplit pass sees the same coroutine the second time, it splits it up,
adds coroutine subfunctions to the SCC to be processed by IPO pipeline.)

Documentation and overview is here: http://llvm.org/docs/Coroutines.html.

Upstreaming sequence (rough plan)
1.Add documentation. (https://reviews.llvm.org/D22603)
2.Add coroutine intrinsics. (https://reviews.llvm.org/D22659)
3.Add empty coroutine passes. (https://reviews.llvm.org/D22847)
4.Add coroutine devirtualization + tests.
ab) Lower coro.resume and coro.destroy (https://reviews.llvm.org/D22998)
c) Do devirtualization (https://reviews.llvm.org/D23229)
5.Add CGSCC restart trigger + tests. <= we are here
6.Add coroutine heap elision + tests.
7.Add the rest of the logic (split into more patches)

Reviewers: mehdi_amini, majnemer

Subscribers: llvm-commits, mehdi_amini

Differential Revision: https://reviews.llvm.org/D23234

llvm-svn: 277936

7 years agoAdd the new scan-build option (--show-description) in the 4.0 release notes
Sylvestre Ledru [Sat, 6 Aug 2016 20:23:54 +0000 (20:23 +0000)]
Add the new scan-build option (--show-description) in the 4.0 release notes

llvm-svn: 277935

7 years ago[AVX-512] Add SQRT/RCP14/RNDSCALE to hasUndefRegUpdate.
Craig Topper [Sat, 6 Aug 2016 19:31:52 +0000 (19:31 +0000)]
[AVX-512] Add SQRT/RCP14/RNDSCALE to hasUndefRegUpdate.

llvm-svn: 277934

7 years ago[AVX-512] Add AVX-512 scalar CVT instructions to hasUndefRegUpdate.
Craig Topper [Sat, 6 Aug 2016 19:31:50 +0000 (19:31 +0000)]
[AVX-512] Add AVX-512 scalar CVT instructions to hasUndefRegUpdate.

llvm-svn: 277933

7 years ago[AVX-512] Add AVX512 run line to a test and re-generate the checks. Future commits...
Craig Topper [Sat, 6 Aug 2016 19:31:47 +0000 (19:31 +0000)]
[AVX-512] Add AVX512 run line to a test and re-generate the checks. Future commits will refine some of the sequences.

llvm-svn: 277932

7 years ago[X86] Add VRCPSSr_Int, VRSQRTSSr_Int, VSQRTSSr_Int, and VSQRTSDr_Int to hasUndefRegUp...
Craig Topper [Sat, 6 Aug 2016 19:31:44 +0000 (19:31 +0000)]
[X86] Add VRCPSSr_Int, VRSQRTSSr_Int, VSQRTSSr_Int, and VSQRTSDr_Int to hasUndefRegUpdate.

llvm-svn: 277931

7 years ago[X86][SSE] Enable commutation between MOVHLPS and UNPCKHPD
Simon Pilgrim [Sat, 6 Aug 2016 18:40:28 +0000 (18:40 +0000)]
[X86][SSE] Enable commutation between MOVHLPS and UNPCKHPD

Assuming SSE2 is available then we can safely commute between these, removing some unnecessary register moves and improving memory folding opportunities.

VEX encoded versions don't benefit so I haven't added support to them.

llvm-svn: 277930

7 years agoCOFF ARM: Fix typos in the relocation test
Saleem Abdulrasool [Sat, 6 Aug 2016 18:02:51 +0000 (18:02 +0000)]
COFF ARM: Fix typos in the relocation test

Fix comments.  NFC.

Patch by Martin Storsjö!

llvm-svn: 277929

7 years agoHeaders: Add ARM support to intrin.h for MSVC compatibility
Saleem Abdulrasool [Sat, 6 Aug 2016 17:58:24 +0000 (17:58 +0000)]
Headers: Add ARM support to intrin.h for MSVC compatibility

This fixes compiling with headers from the Windows SDK for ARM, where the
YieldProcessor function (in winnt.h) refers to _ARM_BARRIER_ISHST.

The actual MSVC armintr.h contains a lot more definitions, but this is enough to
build code that uses the Windows SDK but doesn't use ARM intrinsics directly.

An alternative would to just keep the addition to intrin.h (to include
armintr.h), but not actually ship armintr.h, instead having clang's intrin.h
include armintr.h from MSVC's include directory. (That one works fine with
clang, at least for building code that uses the Windows SDK.)

Patch by Martin Storsjö!

llvm-svn: 277928

7 years ago[libfuzzer] do not warn about missing pcbuffer functions: they are new.
Mike Aizatsky [Sat, 6 Aug 2016 17:03:22 +0000 (17:03 +0000)]
[libfuzzer] do not warn about missing pcbuffer functions: they are new.

llvm-svn: 277927

7 years agoUnpollute the global namespace. lld edition.
Benjamin Kramer [Sat, 6 Aug 2016 13:52:37 +0000 (13:52 +0000)]
Unpollute the global namespace. lld edition.

llvm-svn: 277926

7 years ago[X86][SSE] Regenerate SSE1 shuffle tests
Simon Pilgrim [Sat, 6 Aug 2016 13:46:09 +0000 (13:46 +0000)]
[X86][SSE] Regenerate SSE1 shuffle tests

llvm-svn: 277925

7 years ago[ARM] Don't copy MCInsts in loop. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 12:58:24 +0000 (12:58 +0000)]
[ARM] Don't copy MCInsts in loop. NFC.

llvm-svn: 277924

7 years ago[ASTReader] Use real move semantics instead of emulating them in the copy ctor.
Benjamin Kramer [Sat, 6 Aug 2016 12:45:16 +0000 (12:45 +0000)]
[ASTReader] Use real move semantics instead of emulating them in the copy ctor.

No functionality change intended.

llvm-svn: 277923

7 years ago[Inliner] Use function_ref for functors which are never taken ownership of.
Benjamin Kramer [Sat, 6 Aug 2016 12:33:46 +0000 (12:33 +0000)]
[Inliner] Use function_ref for functors which are never taken ownership of.

llvm-svn: 277922

7 years ago[LoadCombine] Simplify code with a brace init. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 12:11:11 +0000 (12:11 +0000)]
[LoadCombine] Simplify code with a brace init. NFC.

llvm-svn: 277921

7 years ago[Sema] Make switch fully covered again.
Benjamin Kramer [Sat, 6 Aug 2016 11:28:20 +0000 (11:28 +0000)]
[Sema] Make switch fully covered again.

llvm-svn: 277920

7 years ago[X86][SSE] Add 2 input shuffle support to matchBinaryVectorShuffle
Simon Pilgrim [Sat, 6 Aug 2016 11:22:39 +0000 (11:22 +0000)]
[X86][SSE] Add 2 input shuffle support to matchBinaryVectorShuffle

Not actually used yet...

llvm-svn: 277919

7 years agoMove helpers into anonymous namespaces. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 11:21:04 +0000 (11:21 +0000)]
Move helpers into anonymous namespaces. NFC.

llvm-svn: 277918

7 years ago[StaticAnalyzer] Remove dead code.
Benjamin Kramer [Sat, 6 Aug 2016 11:20:59 +0000 (11:20 +0000)]
[StaticAnalyzer] Remove dead code.

llvm-svn: 277917

7 years agoMove helpers into anonymous namespaces. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 11:13:10 +0000 (11:13 +0000)]
Move helpers into anonymous namespaces. NFC.

llvm-svn: 277916

7 years ago[CodeGen] Fix a -Wdocumentation warning
David Majnemer [Sat, 6 Aug 2016 08:37:12 +0000 (08:37 +0000)]
[CodeGen] Fix a -Wdocumentation warning

A parameter was documented with the wrong name.
No functionality change is intended.

llvm-svn: 277915

7 years ago[ValueTracking] Teach computeKnownBits about [su]min/max
David Majnemer [Sat, 6 Aug 2016 08:16:00 +0000 (08:16 +0000)]
[ValueTracking] Teach computeKnownBits about [su]min/max

Reasoning about a select in terms of a min or max allows us to derive a
tigher bound on the result.

llvm-svn: 277914

7 years ago[CallGraphSCCPass] Use an ArrayRef instead of a pair of iterators
David Majnemer [Sat, 6 Aug 2016 06:21:02 +0000 (06:21 +0000)]
[CallGraphSCCPass] Use an ArrayRef instead of a pair of iterators

No functional change is intended.

llvm-svn: 277913

7 years ago[ADT] Make the triple test 1000x faster through more focused test cases.
Chandler Carruth [Sat, 6 Aug 2016 06:00:50 +0000 (06:00 +0000)]
[ADT] Make the triple test 1000x faster through more focused test cases.

The current approach isn't a long-term viable pattern. Given the set of
architectures A, vendors V, operating systems O, and environments E, it
does |A| * |V| * |O| * |E| * 4! tests. As LLVM grows, this test keeps
getting slower, despite my working very hard to make it get some
"optimizations" even in -O0 builds in order to lower the constant
factors. Fundamentally, we're doing an unreasonable amount of work.i

Looking at the specific thing being tested -- the goal seems very
clearly to be testing the *permutations*, not the *combinations*. The
combinations are driving up the complexity much more than anything else.

Instead, test every possible value for a given triple entry in every
permutation of *some* triple. This really seems to cover the core goal
of the test. Every single possible triple component is tested in every
position. But because we keep the rest of the triple constant, it does
so in a dramatically more scalable amount of time. With this model we do
(|A| + |V| + |O| + |E|) * 4! tests.

For me on a debug build, this goes from running for 19 seconds to 19
milliseconds, or a 1000x improvement. This makes a world of difference
for the critical path of 'ninja check-llvm' and other extremely common
workflows.

Thanks to Renato, Dean, and David for the helpful review comments and
helping me refine the explanation of the change.

Differential Revision: https://reviews.llvm.org/D23156

llvm-svn: 277912

7 years ago[ELF][MIPS] Produce a correct and complete set of MIPS ELF header flags
Simon Atanasyan [Sat, 6 Aug 2016 05:11:41 +0000 (05:11 +0000)]
[ELF][MIPS] Produce a correct and complete set of MIPS ELF header flags

The patch extends the `getMipsEFlags` function. Now in that function
we iterate over all object files, parse ELF header flags and merge them.
If a file is incompatible with previously analyzed ones we show an error
or warning. That can happen if, for example, we try to link files with
incompatible ABI, ISA, NAN encoding etc.

There is an alternative solution. We can check and merge flags and
reject incompatible input modules in the `isCompatible` function which
is called from the `SymbolTable::addFile` method. But in that case we
have to save and keep somewhere a merged ELF flags combination to use it
later in the writer.

Differential Revision: http://reviews.llvm.org/D23161

llvm-svn: 277911

7 years ago[InstCombine] Don't coerce non-integral pointers to integers
Sanjoy Das [Sat, 6 Aug 2016 02:58:48 +0000 (02:58 +0000)]
[InstCombine] Don't coerce non-integral pointers to integers

Reviewers: majnemer

Subscribers: mcrosier, llvm-commits

Differential Revision: https://reviews.llvm.org/D23231

llvm-svn: 277910

7 years agoRevert "(refs/bisect/bad) GVN-hoist: enable by default"
Matthias Braun [Sat, 6 Aug 2016 02:23:15 +0000 (02:23 +0000)]
Revert "(refs/bisect/bad) GVN-hoist: enable by default"

GVN-Hoist appears to miscompile llvm-testsuite
SingleSource/Benchmarks/Misc/fbench.c at the moment.

I filed http://llvm.org/PR28880

This reverts commit r277786.

llvm-svn: 277909

7 years agoPart 4c: Coroutine Devirtualization: Devirtualize coro.resume and coro.destroy.
Gor Nishanov [Sat, 6 Aug 2016 02:16:35 +0000 (02:16 +0000)]
Part 4c: Coroutine Devirtualization: Devirtualize coro.resume and coro.destroy.

Summary:
This is the 4c patch of the coroutine series. CoroElide pass now checks if PostSplit coro.begin
is referenced by coro.subfn.addr intrinsics. If so replace coro.subfn.addrs with an appropriate coroutine
subfunction associated with that coro.begin.

Documentation and overview is here: http://llvm.org/docs/Coroutines.html.

Upstreaming sequence (rough plan)
1.Add documentation. (https://reviews.llvm.org/D22603)
2.Add coroutine intrinsics. (https://reviews.llvm.org/D22659)
3.Add empty coroutine passes. (https://reviews.llvm.org/D22847)
4.Add coroutine devirtualization + tests.
ab) Lower coro.resume and coro.destroy (https://reviews.llvm.org/D22998)
c) Do devirtualization <= we are here
5.Add CGSCC restart trigger + tests.
6.Add coroutine heap elision + tests.
7.Add the rest of the logic (split into more patches)

Reviewers: majnemer

Subscribers: mehdi_amini, llvm-commits

Differential Revision: https://reviews.llvm.org/D23229

llvm-svn: 277908

7 years agoRevert r277896.
Nico Weber [Sat, 6 Aug 2016 02:00:45 +0000 (02:00 +0000)]
Revert r277896.

It breaks ExecutionEngine/OrcLazy/weak-function.ll on most bots.

Script:
--
...
--
Exit Code: 1

Command Output (stderr):
--
Could not find main function.

llvm-svn: 277907

7 years ago[NFC] Silence noisy -Wreturn-type warnings
Erik Pilkington [Sat, 6 Aug 2016 01:54:50 +0000 (01:54 +0000)]
[NFC] Silence noisy -Wreturn-type warnings

llvm-svn: 277906

7 years agoCodeGen: If Convert blocks that would form a diamond when tail-merged.
Kyle Butt [Sat, 6 Aug 2016 01:52:37 +0000 (01:52 +0000)]
CodeGen: If Convert blocks that would form a diamond when tail-merged.

The following function currently relies on tail-merging for if
conversion to succeed. The common tail of cond_true and cond_false is
extracted, and this then forms a diamond pattern that can be
successfully if converted.

If this block does not get extracted, either because tail-merging is
disabled or the threshold is higher, we should still recognize this
pattern and if-convert it.
define i32 @t2(i32 %a, i32 %b) nounwind {
entry:
%tmp1434 = icmp eq i32 %a, %b ; <i1> [#uses=1]
br i1 %tmp1434, label %bb17, label %bb.outer

bb.outer: ; preds = %cond_false, %entry
%b_addr.021.0.ph = phi i32 [ %b, %entry ], [ %tmp10, %cond_false ]
%a_addr.026.0.ph = phi i32 [ %a, %entry ], [ %a_addr.026.0, %cond_false ]
br label %bb

bb: ; preds = %cond_true, %bb.outer
%indvar = phi i32 [ 0, %bb.outer ], [ %indvar.next, %cond_true ]
%tmp. = sub i32 0, %b_addr.021.0.ph
%tmp.40 = mul i32 %indvar, %tmp.
%a_addr.026.0 = add i32 %tmp.40, %a_addr.026.0.ph
%tmp3 = icmp sgt i32 %a_addr.026.0, %b_addr.021.0.ph
br i1 %tmp3, label %cond_true, label %cond_false

cond_true: ; preds = %bb
%tmp7 = sub i32 %a_addr.026.0, %b_addr.021.0.ph
%tmp1437 = icmp eq i32 %tmp7, %b_addr.021.0.ph
%indvar.next = add i32 %indvar, 1
br i1 %tmp1437, label %bb17, label %bb

cond_false: ; preds = %bb
%tmp10 = sub i32 %b_addr.021.0.ph, %a_addr.026.0
%tmp14 = icmp eq i32 %a_addr.026.0, %tmp10
br i1 %tmp14, label %bb17, label %bb.outer

bb17: ; preds = %cond_false, %cond_true, %entry
%a_addr.026.1 = phi i32 [ %a, %entry ], [ %tmp7, %cond_true ], [ %a_addr.026.0, %cond_false ]
ret i32 %a_addr.026.1
}

Without tail-merging or diamond-tail if conversion:
LBB1_1:                                 @ %bb
                                        @ =>This Inner Loop Header: Depth=1
        cmp     r0, r1
        ble     LBB1_3
@ BB#2:                                 @ %cond_true
                                        @   in Loop: Header=BB1_1 Depth=1
        subs    r0, r0, r1
        cmp     r1, r0
        it      ne
        cmpne   r0, r1
        bgt     LBB1_4
LBB1_3:                                 @ %cond_false
                                        @   in Loop: Header=BB1_1 Depth=1
        subs    r1, r1, r0
        cmp     r1, r0
        bne     LBB1_1
LBB1_4:                                 @ %bb17
        bx      lr

With diamond-tail if conversion, but without tail-merging:
@ BB#0:                                 @ %entry
        cmp     r0, r1
        it      eq
        bxeq    lr
LBB1_1:                                 @ %bb
                                        @ =>This Inner Loop Header: Depth=1
        cmp     r0, r1
        ite     le
        suble   r1, r1, r0
        subgt   r0, r0, r1
        cmp     r1, r0
        bne     LBB1_1
@ BB#2:                                 @ %bb17
        bx      lr

llvm-svn: 277905

7 years agoIfConverter: Split ScanInstructions into 2 functions.
Kyle Butt [Sat, 6 Aug 2016 01:52:34 +0000 (01:52 +0000)]
IfConverter: Split ScanInstructions into 2 functions.

ScanInstructions is now 2 functions:
AnalyzeBranches and ScanInstructions. ScanInstructions also now takes a
pair of arguments delimiting the instructions to be scanned. This will
be used for forked diamond support to re-scan only a portion of the
block.

llvm-svn: 277904

7 years agoIfConversion: Document countDuplicatedInstructions. NFC
Kyle Butt [Sat, 6 Aug 2016 01:52:33 +0000 (01:52 +0000)]
IfConversion: Document countDuplicatedInstructions. NFC

llvm-svn: 277903

7 years agoIfConversion: factor out 2 functions to skip debug instrs. NFC
Kyle Butt [Sat, 6 Aug 2016 01:52:31 +0000 (01:52 +0000)]
IfConversion: factor out 2 functions to skip debug instrs. NFC

Skipping debug instructions occurrs repeatedly, factor it out.

llvm-svn: 277902

7 years agoRevert "[LoopSimplify] Fix updating LCSSA after separating nested loops."
Michael Zolotukhin [Sat, 6 Aug 2016 01:48:51 +0000 (01:48 +0000)]
Revert "[LoopSimplify] Fix updating LCSSA after separating nested loops."

This reverts commit r277877.
Try to appease clang-x64-ninja-win7 buildbot.

llvm-svn: 277901

7 years agoFix typos from r277797 and unused variable from r277889.
Richard Trieu [Sat, 6 Aug 2016 01:44:06 +0000 (01:44 +0000)]
Fix typos from r277797 and unused variable from r277889.

llvm-svn: 277900

7 years ago[sanitizer] allocator: move TransferBatch into SizeClassAllocator64/SizeClassAllocato...
Kostya Serebryany [Sat, 6 Aug 2016 01:24:11 +0000 (01:24 +0000)]
[sanitizer] allocator: move TransferBatch into SizeClassAllocator64/SizeClassAllocator32 because we actually need different iplementations for the 64- and 32-bit case. NFC; the following patches will make the TransferBatch implementations differ

llvm-svn: 277899

7 years agoTry to fix the ill.cc test on Linux
Reid Kleckner [Sat, 6 Aug 2016 00:57:58 +0000 (00:57 +0000)]
Try to fix the ill.cc test on Linux

llvm-svn: 277898

7 years agoThe lack of classes in the hash table is not an error - it's very legitimately possib...
Enrico Granata [Sat, 6 Aug 2016 00:57:07 +0000 (00:57 +0000)]
The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging /bin/ls

llvm-svn: 277897

7 years ago[ORC] Add (partial) weak symbol support to the CompileOnDemand layer.
Lang Hames [Sat, 6 Aug 2016 00:54:43 +0000 (00:54 +0000)]
[ORC] Add (partial) weak symbol support to the CompileOnDemand layer.

This adds partial support for weak functions to the CompileOnDemandLayer by
modifying the addLogicalModule method to check for existing stub definitions
before building a new stub for a weak function. This scheme is sufficient to
support ODR definitions, but fails for general weak definitions if strong
definition is encountered after the first weak definition. (A more extensive
refactor will be required to fully support weak symbols).

This patch does *not* add weak symbol support to RuntimeDyld: I hope to add
that in the near future.

llvm-svn: 277896

7 years agoFix Windows build - add return statement in SBThread::StepUsingScriptedThreadPlan.
Oleksiy Vyalov [Sat, 6 Aug 2016 00:42:23 +0000 (00:42 +0000)]
Fix Windows build - add return statement in SBThread::StepUsingScriptedThreadPlan.

llvm-svn: 277895

7 years agoUse %stdcxx11 instead of -std=c++11 so the test passes with VS 2015
Reid Kleckner [Sat, 6 Aug 2016 00:37:14 +0000 (00:37 +0000)]
Use %stdcxx11 instead of -std=c++11 so the test passes with VS 2015

llvm-svn: 277894

7 years agoFix a -Wunused-const-variable due to a bug in clang.
Zachary Turner [Sat, 6 Aug 2016 00:13:32 +0000 (00:13 +0000)]
Fix a -Wunused-const-variable due to a bug in clang.

llvm-svn: 277893

7 years ago[IRCE] Remove unused headers; NFC
Sanjoy Das [Sat, 6 Aug 2016 00:02:01 +0000 (00:02 +0000)]
[IRCE] Remove unused headers; NFC

llvm-svn: 277892

7 years ago[IRCE] Preserve loop-simplify form
Sanjoy Das [Sat, 6 Aug 2016 00:01:56 +0000 (00:01 +0000)]
[IRCE] Preserve loop-simplify form

Fixes PR28764.  Right now there is no way to test this, but (as
mentioned on the PR) with Michael Zolotukhin's yet to be checked in
LoopSimplify verfier, 8 of the llvm-lit tests for IRCE crash.

llvm-svn: 277891

7 years agoMention the scripted thread plans in the python reference.
Jim Ingham [Fri, 5 Aug 2016 23:35:26 +0000 (23:35 +0000)]
Mention the scripted thread plans in the python reference.

llvm-svn: 277890

7 years agoFix two false positives in -Wreturn-stack-address
Richard Trieu [Fri, 5 Aug 2016 23:24:47 +0000 (23:24 +0000)]
Fix two false positives in -Wreturn-stack-address

If the return type is a pointer and the function returns the reference to a
pointer, don't warn since only the value is returned, not the reference.

If a reference function parameter appears in the reference chain, don't warn
since binding happens at the caller scope, so addresses returned are not
to local stack.  This includes default arguments as well.

llvm-svn: 277889

7 years agoResubmit "Make YAML support SmallVector"
Zachary Turner [Fri, 5 Aug 2016 23:12:31 +0000 (23:12 +0000)]
Resubmit "Make YAML support SmallVector"

This resubmits a3770391c5fb64108d565e12f61dd77ce71b5b4f,
which was reverted due to breakages on non-Windows machines.

Due to differences in template instantiation rules on Microsoft
and non-Microsoft platforms, a member access restriction was
triggering on non-Microsoft compilers.  Previously, a friend
declaration for std::vector<> had been introduced into the
DebugMap class to make the member access restriction pass,
but the introduction of support for SmallVector<> meant that
an additional friend declaration would need to be added.

This didn't really make a lot of sense since the user of the
macro is probably only using one type (SmallVector<>, vector<>,
etc) and we could in theory add support for even more types
to this macro in the future (e.g. std::deque), so rather than
add another friend declaration, I just made the type being
referenced a public nested typedef instead of a private nested
typedef.

llvm-svn: 277888

7 years ago[NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl
Erik Pilkington [Fri, 5 Aug 2016 22:59:03 +0000 (22:59 +0000)]
[NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl

Differential revision: https://reviews.llvm.org/D23221

llvm-svn: 277887

7 years agoDisable a few more flaky asan64 tests.
Nico Weber [Fri, 5 Aug 2016 22:51:10 +0000 (22:51 +0000)]
Disable a few more flaky asan64 tests.

llvm-svn: 277886

7 years ago[clang-tblgen] Remove unused #include (NFC)
Vedant Kumar [Fri, 5 Aug 2016 22:48:53 +0000 (22:48 +0000)]
[clang-tblgen] Remove unused #include (NFC)

llvm-svn: 277885

7 years agoMention is_stale in the scripted step doc.
Jim Ingham [Fri, 5 Aug 2016 22:47:43 +0000 (22:47 +0000)]
Mention is_stale in the scripted step doc.

llvm-svn: 277884

7 years ago[InstCombine] refactor ctlz/cttz folds (NFCI)
Sanjay Patel [Fri, 5 Aug 2016 22:42:46 +0000 (22:42 +0000)]
[InstCombine] refactor ctlz/cttz folds (NFCI)

Note that this fold really belongs in InstSimplify.
Refactoring here anyway as an intermediate step because
there's a planned addition to this function in D23134.

Differential Revision: https://reviews.llvm.org/D23223

llvm-svn: 277883

7 years agoDisable a few win asan64 tests that don't reliably pass, https://reviews.llvm.org...
Nico Weber [Fri, 5 Aug 2016 22:36:30 +0000 (22:36 +0000)]
Disable a few win asan64 tests that don't reliably pass, https://reviews.llvm.org/D23230

llvm-svn: 277882

7 years agoRevert "Make YAML support SmallVector"
Justin Bogner [Fri, 5 Aug 2016 22:32:33 +0000 (22:32 +0000)]
Revert "Make YAML support SmallVector"

This breaks building dsymutil, causing my local build and many bots to
fail.

This reverts r277870.

llvm-svn: 277881

7 years ago[MSSA] Use depth first iterator instead of custom version.
Daniel Berlin [Fri, 5 Aug 2016 22:09:14 +0000 (22:09 +0000)]
[MSSA] Use depth first iterator instead of custom version.

Summary:
Originally the plan was to use the custom worklist to do some block popping,
and because we don't actually need a visited set. The custom one we have
here is slightly broken, and it's not worth fixing vs using depth_first_iterator since we aren't going to go the route we originally
were.

Fixes PR28874
Reviewers: george.burgess.iv

Subscribers: llvm-commits, gberry

Differential Revision: https://reviews.llvm.org/D23187

llvm-svn: 277880

7 years agoAdd a few more needed bits to the scripted thread plans.
Jim Ingham [Fri, 5 Aug 2016 22:06:12 +0000 (22:06 +0000)]
Add a few more needed bits to the scripted thread plans.

llvm-svn: 277879

7 years agoCodeView: Remove an unused variable
Justin Bogner [Fri, 5 Aug 2016 21:57:10 +0000 (21:57 +0000)]
CodeView: Remove an unused variable

It was breaking the -Werror build.

llvm-svn: 277878

7 years ago[LoopSimplify] Fix updating LCSSA after separating nested loops.
Michael Zolotukhin [Fri, 5 Aug 2016 21:52:58 +0000 (21:52 +0000)]
[LoopSimplify] Fix updating LCSSA after separating nested loops.

This fixes PR28825. The problem was that we only checked if a value from
a created inner loop is used in the outer loop, and fixed LCSSA for
them. But we missed to fixup LCSSA for values used in exits of the outer
loop.

llvm-svn: 277877

7 years agoFix non portable include path.
Zachary Turner [Fri, 5 Aug 2016 21:50:02 +0000 (21:50 +0000)]
Fix non portable include path.

llvm-svn: 277876

7 years agoPowerPC: Add a triple to this test
Justin Bogner [Fri, 5 Aug 2016 21:49:54 +0000 (21:49 +0000)]
PowerPC: Add a triple to this test

This is running opt without specifying a triple, which isn't correct.

llvm-svn: 277875

7 years agoFix two tests in Win64 ASan
Reid Kleckner [Fri, 5 Aug 2016 21:47:46 +0000 (21:47 +0000)]
Fix two tests in Win64 ASan

Go back to intercepting kernel32!RaiseException, and only go for
ntdll!RtlRaiseException if that fails. Fixes throw_and_catch.cc test.

Work around an issue in LLVM's win64 epilogues. We end up with an
epilogue that looks like this, and it drives the Win64 unwinder crazy
until stack overflow:
        call    ill_cc!__asan_handle_no_return
        xor     eax,eax
        add     rsp,40h // epilogue starts
        pop     rbp     // CSR
        ud2             // Trap here
        ret             // Ret?
        nop     word ptr [rax+rax]
        sub     rsp,28h // Next function

Will file a PR soon.

llvm-svn: 277874

7 years ago[MSSA] Match assert vs llvm_unreachable style in verification functions.
Daniel Berlin [Fri, 5 Aug 2016 21:47:20 +0000 (21:47 +0000)]
[MSSA] Match assert vs llvm_unreachable style in verification functions.

llvm-svn: 277873

7 years agoRewrite domination verifier to handle local domination as well.
Daniel Berlin [Fri, 5 Aug 2016 21:46:52 +0000 (21:46 +0000)]
Rewrite domination verifier to handle local domination as well.

Summary:
Rewrite domination verifier to handle local domination as well.
This catches a bug Geoff Berry noticed.

Reviewers: george.burgess.iv

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23184

llvm-svn: 277872

7 years ago[CodeView] Decouple record deserialization from visitor dispatch.
Zachary Turner [Fri, 5 Aug 2016 21:45:34 +0000 (21:45 +0000)]
[CodeView] Decouple record deserialization from visitor dispatch.

Until now, our use case for the visitor has been to take a stream of bytes
representing a type stream, deserialize the records in sequence, and do
something with them, where "something" is determined by how the user
implements a particular set of callbacks on an abstract class.

For actually writing PDBs, however, we want to do the reverse. We have
some kind of description of the list of records in their in-memory format,
and we want to process each one. Perhaps by serializing them to a byte
stream, or perhaps by converting them from one description format (Yaml)
to another (in-memory representation).

This was difficult in the current model because deserialization and
invoking the callbacks were tightly coupled.

With this patch we change this so that TypeDeserializer is itself an
implementation of the particular set of callbacks. This decouples
deserialization from the iteration over a list of records and invocation
of the callbacks.  TypeDeserializer is initialized with another
implementation of the callback interface, so that upon deserialization it
can pass the deserialized record through to the next set of callbacks. In
a sense this is like an implementation of the Decorator design pattern,
where the Deserializer is a decorator.

This will be useful for writing Pdbs from yaml, where we have a
description of the type records in Yaml format. In this case, the visitor
implementation would have each visitation callback method implemented in
such a way as to extract the proper set of fields from the Yaml, and it
could maintain state that builds up a list of these records. Finally at
the end we can pass this information through to another set of callbacks
which serializes them into a byte stream.

Reviewed By: majnemer, ruiu, rnk
Differential Revision: https://reviews.llvm.org/D23177

llvm-svn: 277871

7 years agoMake YAML support SmallVector
Zachary Turner [Fri, 5 Aug 2016 21:45:19 +0000 (21:45 +0000)]
Make YAML support SmallVector

Currently YAML sequences require std::vectors. All of the methods that the
YAML parser accesses though are present in SmallVector, so there's no
reason we can't support SmallVector inherently. This patch does that.

Reviewed By: majnemer
Differential Revision: https://reviews.llvm.org/D23213

llvm-svn: 277870

7 years agoExportTrie nodes need to be visisted in order.
Pete Cooper [Fri, 5 Aug 2016 21:37:12 +0000 (21:37 +0000)]
ExportTrie nodes need to be visisted in order.

The export trie was being emitted in the order the nodes were
added to the vector, but instead needs to be visited in the order
that the nodes are traversed.  This matches the behaviour of ld64.

llvm-svn: 277869

7 years agounwind: disable executable stacks
Saleem Abdulrasool [Fri, 5 Aug 2016 21:35:28 +0000 (21:35 +0000)]
unwind: disable executable stacks

Similar to compiler-rt, ensure that we disable executable stacks for the custom
assembly.

llvm-svn: 277868

7 years agoAMDGPU/SI: Increase SGPR limit to 96 on Tonga/Iceland
Marek Olsak [Fri, 5 Aug 2016 21:23:29 +0000 (21:23 +0000)]
AMDGPU/SI: Increase SGPR limit to 96 on Tonga/Iceland

Summary:
This is the setting of the Vulkan closed source driver.

It decreases the max wave count from 10 to 8.

26010 shaders in 14650 tests
Totals:
VGPRS: 829593 -> 808440 (-2.55 %)
Spilled SGPRs: 81878 -> 42226 (-48.43 %)
Spilled VGPRs: 367 -> 358 (-2.45 %)
Scratch VGPRs: 1764 -> 1748 (-0.91 %) dwords per thread
Code Size: 36677864 -> 35923932 (-2.06 %) bytes

There is a massive decrease in SGPR spilling in general and -7.4% spilled
VGPRs for DiRT Showdown (= SGPRs spilled to scratch?)

Reviewers: arsenm, tstellarAMD, nhaehnle

Subscribers: arsenm, llvm-commits, kzhuravl

Differential Revision: https://reviews.llvm.org/D23034

llvm-svn: 277867

7 years agoFix false positive in -Wunsequenced and templates.
Richard Trieu [Fri, 5 Aug 2016 21:02:34 +0000 (21:02 +0000)]
Fix false positive in -Wunsequenced and templates.

For builtin logical operators, there is a well-defined ordering of argument
evaluation.  For overloaded operator of the same type, there is no argument
evaluation order, similar to other function calls.  When both are present,
uninstantiated templates with an operator&& is treated as an unresolved
function call.  Unresolved function calls are treated as normal function calls,
and may result in false positives when the builtin logical operator is used.
Have the unsequenced checker ignore dependent expressions to avoid this
false positive.  The check also happens in template instantiations to catch
when the overloaded operator is used.

llvm-svn: 277866

7 years ago[ARM] Constant Materialize: imms with specific value can be encoded into mov.w
Weiming Zhao [Fri, 5 Aug 2016 20:58:29 +0000 (20:58 +0000)]
[ARM] Constant Materialize: imms with specific value can be encoded into mov.w

Summary: Thumb2 supports encoding immediates with specific patterns into mov.w by splatting the low 8 bits into other bytes.

I'm resubmitting this patch. The test case in the original commit
r277610 does not specify triple, so builds with differnt default triple
will have different output.

This patch fixed trile as thumb-darwin-apple.

Reviewers: john.brawn, jmolloy, bruno

Subscribers: jmolloy, aemerson, rengolin, samparker, llvm-commits

Differential Revision: https://reviews.llvm.org/D23090

llvm-svn: 277865

7 years ago[FlattenCFG] Simplify + remove unused variable. NFCI.
Davide Italiano [Fri, 5 Aug 2016 20:53:35 +0000 (20:53 +0000)]
[FlattenCFG] Simplify + remove unused variable. NFCI.

llvm-svn: 277864

7 years agoRemove cold callsite heuristic that is not necessary because of cold callee heuristic.
Dehao Chen [Fri, 5 Aug 2016 20:49:04 +0000 (20:49 +0000)]
Remove cold callsite heuristic that is not necessary because of cold callee heuristic.

llvm-svn: 277863

7 years ago[sanitizers] remove failing test.
Mike Aizatsky [Fri, 5 Aug 2016 20:48:48 +0000 (20:48 +0000)]
[sanitizers] remove failing test.

The test often fails on Windows because there are more branches
in the code that is generated.

llvm-svn: 277862

7 years ago[SCEV] Un-grep'ify tests; NFC
Sanjoy Das [Fri, 5 Aug 2016 20:33:49 +0000 (20:33 +0000)]
[SCEV] Un-grep'ify tests; NFC

llvm-svn: 277861

7 years agoReplace hot-callsite based heuristic to use its own threshold parameter instead of...
Dehao Chen [Fri, 5 Aug 2016 20:28:41 +0000 (20:28 +0000)]
Replace hot-callsite based heuristic to use its own threshold parameter instead of share inline-hint parameter

Summary: Hot callsites should have higher threshold than inline hints. This patch uses separate threshold parameter for hot callsites.

Reviewers: davidxl, eraman

Subscribers: Prazek, llvm-commits

Differential Revision: https://reviews.llvm.org/D22368

llvm-svn: 277860

7 years ago[sanitizers] trace buffer API to use user-allocated buffer.
Mike Aizatsky [Fri, 5 Aug 2016 20:09:53 +0000 (20:09 +0000)]
[sanitizers] trace buffer API to use user-allocated buffer.

Differential Revision: https://reviews.llvm.org/D23185

llvm-svn: 277859

7 years ago[sanitizers] trace buffer API to use user-allocated buffer.
Mike Aizatsky [Fri, 5 Aug 2016 20:09:42 +0000 (20:09 +0000)]
[sanitizers] trace buffer API to use user-allocated buffer.

Subscribers: kubabrecka

Differential Revision: https://reviews.llvm.org/D23186

llvm-svn: 277858

7 years agoUpdate outdated comments in the new PM internals (NFC)
Mehdi Amini [Fri, 5 Aug 2016 19:51:00 +0000 (19:51 +0000)]
Update outdated comments in the new PM internals (NFC)

The analysis manager was made not optional and turned into a
reference instead of a pointer in r272978. Some comments were
still refering to the previous behavior.

llvm-svn: 277857

7 years agoWholeProgramDevirt: print remarks with devirtualized method names.
Ivan Krasin [Fri, 5 Aug 2016 19:45:16 +0000 (19:45 +0000)]
WholeProgramDevirt: print remarks with devirtualized method names.

Summary:
Chrome on Linux uses WholeProgramDevirt for speed ups, and it's
important to detect regressions on both sides: the toolchain,
if fewer methods get devirtualized after an update, and Chrome,
if an innocently looking change caused many hot methods become
virtual again.

The need to track devirtualized methods is not Chrome-specific,
but it's probably the only user of the pass at this time.

Reviewers: kcc

Differential Revision: https://reviews.llvm.org/D23219

llvm-svn: 277856

7 years ago[ADCE] Refactoring for new functionality (NFC)
David Callahan [Fri, 5 Aug 2016 19:38:11 +0000 (19:38 +0000)]
[ADCE] Refactoring for new functionality (NFC)

Summary:
This is another refactoring to break up the one function into three logical components functions.
Another non-functional change before we start added in features.

Reviewers: nadav, mehdi_amini, majnemer

Subscribers: twoh, freik, llvm-commits

Differential Revision: https://reviews.llvm.org/D23102

llvm-svn: 277855

7 years ago[ConstantFolding] Don't create illegal (non-integral) inttoptrs
Sanjoy Das [Fri, 5 Aug 2016 19:23:29 +0000 (19:23 +0000)]
[ConstantFolding] Don't create illegal (non-integral) inttoptrs

Reviewers: majnemer, arsenm

Subscribers: mcrosier, llvm-commits

Differential Revision: https://reviews.llvm.org/D23182

llvm-svn: 277854

7 years agofix documentation comments; NFC
Sanjay Patel [Fri, 5 Aug 2016 19:09:25 +0000 (19:09 +0000)]
fix documentation comments; NFC

llvm-svn: 277853

7 years agoPR26423: Assert on valid use of using declaration of a function with an undeduced...
David Blaikie [Fri, 5 Aug 2016 19:03:01 +0000 (19:03 +0000)]
PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

For now just disregard the using declaration in this case. Suboptimal,
but wiring up the ability to have declarations of functions that are
separate from their definition (we currently only do that for member
functions) and have differing return types (we don't have any support
for that) is more work than seems reasonable to at least fix this crash.

llvm-svn: 277852