mike@reedtribe.org [Sun, 3 Mar 2013 01:15:48 +0000 (01:15 +0000)]
move some of the impl in fonthost into typeface virtuals
git-svn-id: http://skia.googlecode.com/svn/trunk@7944
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 2 Mar 2013 19:56:18 +0000 (19:56 +0000)]
gm self-test: make all test cases exercise transparency
BUG=https://code.google.com/p/skia/issues/detail?id=1142
Review URL: https://codereview.chromium.org/
12379047
git-svn-id: http://skia.googlecode.com/svn/trunk@7943
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 2 Mar 2013 17:45:27 +0000 (17:45 +0000)]
Move initialization to PictureRenderer ctor
https://codereview.appspot.com/
7435052/
git-svn-id: http://skia.googlecode.com/svn/trunk@7942
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 2 Mar 2013 12:02:08 +0000 (12:02 +0000)]
Relanding 7914
git-svn-id: http://skia.googlecode.com/svn/trunk@7940
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 2 Mar 2013 07:01:56 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7939
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 21:34:26 +0000 (21:34 +0000)]
Revert 7932
git-svn-id: http://skia.googlecode.com/svn/trunk@7938
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 20:30:01 +0000 (20:30 +0000)]
Remove constructors from GrVertexAttrib.
It fits our style better to use initializer lists, so the constructors have
been removed and replaced with said lists.
Review URL: https://codereview.chromium.org/
12379052
git-svn-id: http://skia.googlecode.com/svn/trunk@7936
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 1 Mar 2013 20:28:57 +0000 (20:28 +0000)]
Add freetype to skia_base_libs when building for NaCl
External users need access to libfreetype.a when they use skia_base_libs.
Review URL: https://codereview.chromium.org/
12383022
git-svn-id: http://skia.googlecode.com/svn/trunk@7934
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 20:15:18 +0000 (20:15 +0000)]
Initialize grid info in TiledPictureRenderer::init
https://codereview.appspot.com/
7444053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7932
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 19:44:30 +0000 (19:44 +0000)]
Reland r7918 & r7916
git-svn-id: http://skia.googlecode.com/svn/trunk@7931
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 18:54:50 +0000 (18:54 +0000)]
Make global static variable kVertexAttribs in GrAARectRenderer local to functions.
Chrome was choking on this static variable because it's global and initialized
using a constructor. Moved it inside the two functions that use it, so it's no
longer global.
In addition, made the constructors for GrVertexAttrib inline so hopefully they
will be optimized away.
git-svn-id: http://skia.googlecode.com/svn/trunk@7930
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 1 Mar 2013 18:21:22 +0000 (18:21 +0000)]
Resubmit r7899 and r7901.
git-svn-id: http://skia.googlecode.com/svn/trunk@7929
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 18:10:41 +0000 (18:10 +0000)]
Fix mesa issues.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
12389055
git-svn-id: http://skia.googlecode.com/svn/trunk@7928
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 1 Mar 2013 16:46:49 +0000 (16:46 +0000)]
gm self-test: disable spuriously-failing aaclip tests
Review URL: https://codereview.chromium.org/
12377049
git-svn-id: http://skia.googlecode.com/svn/trunk@7927
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 1 Mar 2013 16:18:06 +0000 (16:18 +0000)]
gm self-test: fix results that break housekeeping bot
Review URL: https://codereview.chromium.org/
12393011
git-svn-id: http://skia.googlecode.com/svn/trunk@7926
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 15:43:41 +0000 (15:43 +0000)]
Revert r7918 & r7916 due to Linux rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7925
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 15:36:02 +0000 (15:36 +0000)]
Add support to GrGLInterface for vertex array objects
Committed: https://code.google.com/p/skia/source/detail?r=7919
Review URL: https://codereview.chromium.org/
12379025
git-svn-id: http://skia.googlecode.com/svn/trunk@7924
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 15:32:49 +0000 (15:32 +0000)]
Revert 7919 and 7920 (committed wrong version of r7919.)
git-svn-id: http://skia.googlecode.com/svn/trunk@7923
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 1 Mar 2013 15:32:34 +0000 (15:32 +0000)]
gm self-test: use a pathologically simple test case instead of dashing2
BUG=https://code.google.com/p/skia/issues/detail?id=677
Review URL: https://chromiumcodereview.appspot.com/
12381038
git-svn-id: http://skia.googlecode.com/svn/trunk@7922
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 15:18:41 +0000 (15:18 +0000)]
Revert r7914 due to Linux rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7921
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 14:56:40 +0000 (14:56 +0000)]
Fix mesa build error from r7519.
git-svn-id: http://skia.googlecode.com/svn/trunk@7920
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Mar 2013 14:37:18 +0000 (14:37 +0000)]
Add support to GrGLInterface for vertex array objects
Review URL: https://codereview.chromium.org/
12379025
git-svn-id: http://skia.googlecode.com/svn/trunk@7919
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:24:33 +0000 (14:24 +0000)]
Fix for Mac compiler problem in 7916
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7918
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:17:58 +0000 (14:17 +0000)]
Fix for skp chunk sizes when clips are used outside of any save
https://codereview.appspot.com/
7342047/
git-svn-id: http://skia.googlecode.com/svn/trunk@7917
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:12:59 +0000 (14:12 +0000)]
Collapse saveLayer/drawBitmapRect/restore trios to drawBitmapRect when possible
https://codereview.appspot.com/
7387045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7916
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 1 Mar 2013 14:10:57 +0000 (14:10 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported
https://codereview.appspot.com/
7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7914
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 1 Mar 2013 12:12:55 +0000 (12:12 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7910
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 28 Feb 2013 23:08:28 +0000 (23:08 +0000)]
Revert r7901 & r7899 to allow DEPS roll
git-svn-id: http://skia.googlecode.com/svn/trunk@7909
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Feb 2013 22:06:02 +0000 (22:06 +0000)]
Checkpoint towards core profile support.
1) Stop calling glDisable for removed state
2) Use new GLSL names for texture sampling functions.
Review URL: https://codereview.chromium.org/
12330181
git-svn-id: http://skia.googlecode.com/svn/trunk@7908
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 28 Feb 2013 20:16:25 +0000 (20:16 +0000)]
Split GrGLContextInfo into GrGLContext & GrGLContextInfo
https://codereview.appspot.com/
7436045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7905
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 28 Feb 2013 19:26:04 +0000 (19:26 +0000)]
Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig.
R=senorblanco@google.com
Review URL: https://codereview.chromium.org/
12390021
git-svn-id: http://skia.googlecode.com/svn/trunk@7904
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 19:18:07 +0000 (19:18 +0000)]
Adding missing const for r7902
git-svn-id: http://skia.googlecode.com/svn/trunk@7903
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 28 Feb 2013 19:03:13 +0000 (19:03 +0000)]
Make SkTDArray accessors const-friendly.
This change creates const and non-const versions of SkTDArray::begin(), end(), operator[]() and getAt(). This will keep us from inadvertently changing a const SkTDArray, which the previous signatures allowed.
Review URL: https://chromiumcodereview.appspot.com/
12315131
git-svn-id: http://skia.googlecode.com/svn/trunk@7902
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 17:15:03 +0000 (17:15 +0000)]
Fix assert in bench due to r7899. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7901
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 28 Feb 2013 17:11:11 +0000 (17:11 +0000)]
Use updated Khronos signature for glShaderSource
(const char* const instead of char**).
This is needed for new Khronos headers.
BUG=178589
Review URL: https://chromiumcodereview.appspot.com/
12310156
git-svn-id: http://skia.googlecode.com/svn/trunk@7900
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 28 Feb 2013 16:28:34 +0000 (16:28 +0000)]
Add new vertex attribute array specification.
This changes the old method of setting vertex layout to a new one where we
specify vertex attribute data separately from attribute bindings (i.e. program
functionality). Attribute data is now set up via an array of generic attribute
types and offsets, and this is mapped to the old program functionality by
setting specific attribute indices. This allows us to create more general
inputs to shaders.
git-svn-id: http://skia.googlecode.com/svn/trunk@7899
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 28 Feb 2013 16:12:39 +0000 (16:12 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7898
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 28 Feb 2013 15:50:13 +0000 (15:50 +0000)]
Only print error message in debug mode.
Currently, PictureTest runs a test of recording a bad bitmap to a
picture and then replaying the picture. We assert at the record
step in debug mode, so the test only runs in release, to ensure that
we can still play back a picture, even if it has a bad bitmap. Silence
the error message in release, so our test doesn't appear to error
(since it is actually working as desired).
Review URL: https://codereview.chromium.org/
12315138
git-svn-id: http://skia.googlecode.com/svn/trunk@7897
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 28 Feb 2013 14:01:44 +0000 (14:01 +0000)]
revert r7892
git-svn-id: http://skia.googlecode.com/svn/trunk@7896
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 28 Feb 2013 12:33:47 +0000 (12:33 +0000)]
Whitespace change: Reset skia-autogen
git-svn-id: http://skia.googlecode.com/svn/trunk@7895
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 27 Feb 2013 20:27:44 +0000 (20:27 +0000)]
Reverting r7882 (Replace A8 with RGBA8 when renderable A8 isn't supported) due Android rendering issues
git-svn-id: http://skia.googlecode.com/svn/trunk@7893
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 19:45:11 +0000 (19:45 +0000)]
resubmit after fixing assert issue: https://codereview.appspot.com/
6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7892
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 27 Feb 2013 19:17:41 +0000 (19:17 +0000)]
Tests : Unused parameters cleanup
I removed unused parameters in the tests wherever it was trivial to do so. I'm trying to get the easy ones out of the way before we get into more involved discussions around this.
Review URL: https://codereview.appspot.com/
7394055
git-svn-id: http://skia.googlecode.com/svn/trunk@7891
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:17:07 +0000 (19:17 +0000)]
revert fontconfig gyp change for now (need to install it on housekeeper and chromeos bots)
git-svn-id: http://skia.googlecode.com/svn/trunk@7890
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 27 Feb 2013 19:07:32 +0000 (19:07 +0000)]
Sort GL extension strings and search to find.
Review URL: https://codereview.chromium.org/
12316141
git-svn-id: http://skia.googlecode.com/svn/trunk@7889
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:06:52 +0000 (19:06 +0000)]
enable fontconfig by default in ports.gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@7888
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 27 Feb 2013 19:06:30 +0000 (19:06 +0000)]
use fontconfig fonthost for skia (in prep for using in chrome)
Review URL: https://codereview.chromium.org/
12319150
git-svn-id: http://skia.googlecode.com/svn/trunk@7887
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 27 Feb 2013 18:43:47 +0000 (18:43 +0000)]
Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads.
We were assigning color to oldColor but it in turn would never be read because the valid flags
would be cleared.
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
12313150
git-svn-id: http://skia.googlecode.com/svn/trunk@7886
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 27 Feb 2013 18:35:16 +0000 (18:35 +0000)]
Change SkTileGride geometry calculations to match the Chromium compositor.
This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.
Companion Chromium CL required for roll: https://codereview.chromium.org/
12221077/
TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/
7350050
git-svn-id: http://skia.googlecode.com/svn/trunk@7885
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 17:46:09 +0000 (17:46 +0000)]
Revert r7883
git-svn-id: http://skia.googlecode.com/svn/trunk@7884
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 16:54:44 +0000 (16:54 +0000)]
Use SkSet to fix issue when pdf generates an exp number of resources.
The problem fixed - http://code.google.com/p/skia/issues/detail?id=940 - is that getResources will recursively obtain all child resource recursively without checking for duplicates.
If we have lots of duplicates, then we try to build a very large vector (exponential with the number of nodes usually) and sooner or later we end up using too much memory and crash.
A possible solution could have been to make sure resources do not have duplicates, but that requirement is impractical, and it this leaves the solution fragile, if there is any issue in the tree, we crash.
When we emit the pdf, the large number of duplicates is not an issue, because SkPDFCatalog::addObject will deal with duplicates.
I have run the gm with --config pdf, and the images are 100% same bits, while the pdfs have the same size but some very small changes, the order of some objects.
Review URL: https://codereview.appspot.com/
6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7883
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 27 Feb 2013 16:43:49 +0000 (16:43 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported
https://codereview.appspot.com/
7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7882
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 27 Feb 2013 15:41:12 +0000 (15:41 +0000)]
GM : Unused parameters cleanup
I removed unused parameters in the gms wherever it was trivial to do so. I'm
trying to get the easy ones out of the way before we get into more involved
discussions around this.
Review URL: https://codereview.appspot.com/
7398056
git-svn-id: http://skia.googlecode.com/svn/trunk@7881
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 27 Feb 2013 14:12:55 +0000 (14:12 +0000)]
Build freetype as a standalone_static_library
Needed by external applications which don't use our libraries in-place.
Review URL: https://codereview.chromium.org/
12328138
git-svn-id: http://skia.googlecode.com/svn/trunk@7879
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:35 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7878
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:22 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7877
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:12 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7876
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 27 Feb 2013 07:10:10 +0000 (07:10 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7875
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 22:58:09 +0000 (22:58 +0000)]
fix getFamilyName by calling FcFreeTypeQuery
git-svn-id: http://skia.googlecode.com/svn/trunk@7874
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 26 Feb 2013 21:56:19 +0000 (21:56 +0000)]
Fixed sk_getMetrics_utf32_xy function
The unused parameters x and y here seems to be a mistake.
Review URL: https://codereview.appspot.com/
7386055
git-svn-id: http://skia.googlecode.com/svn/trunk@7873
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Use glGetStringi to get extensions when available.
Review URL: https://codereview.chromium.org/
12328111
git-svn-id: http://skia.googlecode.com/svn/trunk@7872
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:11:07 +0000 (17:11 +0000)]
implement CreateTypefaceFromFile
git-svn-id: http://skia.googlecode.com/svn/trunk@7869
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:01:26 +0000 (17:01 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7868
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 16:57:16 +0000 (16:57 +0000)]
move SampleTypeface into gm/typefacestyles
git-svn-id: http://skia.googlecode.com/svn/trunk@7867
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 26 Feb 2013 16:25:04 +0000 (16:25 +0000)]
Whitespace change to test commit-queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12328109
git-svn-id: http://skia.googlecode.com/svn/trunk@7866
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 26 Feb 2013 16:01:21 +0000 (16:01 +0000)]
Removing blank lines from codereview.settings.
depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/
7388061
git-svn-id: http://skia.googlecode.com/svn/trunk@7865
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 26 Feb 2013 15:56:05 +0000 (15:56 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7864
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 15:50:51 +0000 (15:50 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7863
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 15:40:01 +0000 (15:40 +0000)]
Rename template param to SkSTArray to be consistent with its base class, SkTArray.
R=jvanverth@google.com
Review URL: https://codereview.appspot.com/
7372050
git-svn-id: http://skia.googlecode.com/svn/trunk@7862
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 14:45:41 +0000 (14:45 +0000)]
Add files omitted from gcl change in r7860.
git-svn-id: http://skia.googlecode.com/svn/trunk@7861
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 14:34:43 +0000 (14:34 +0000)]
Consolidate functions common the the null and debug GL interfaces.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
7400053
git-svn-id: http://skia.googlecode.com/svn/trunk@7860
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 26 Feb 2013 13:13:44 +0000 (13:13 +0000)]
Whitespace change to test commit queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12326121
git-svn-id: http://skia.googlecode.com/svn/trunk@7859
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 26 Feb 2013 12:01:28 +0000 (12:01 +0000)]
Pointing CODE_REVIEW_SERVER to Chromium Rietveld.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/
7382058
git-svn-id: http://skia.googlecode.com/svn/trunk@7858
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 26 Feb 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7857
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 22:19:20 +0000 (22:19 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7856
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 21:47:41 +0000 (21:47 +0000)]
Fix a bunch of warnings, mainly around rowBytes.
My recent change changed the way SkBitmap::fRowBytes is stored,
and parameter/return values referring to rowBytes were changed
to type size_t. Change the storage back, and eliminate warnings
resulting from returning a size_t.
Review URL: https://codereview.appspot.com/
7396059
git-svn-id: http://skia.googlecode.com/svn/trunk@7855
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 21:02:21 +0000 (21:02 +0000)]
remove duplicate impl for getFileName() on SkFDStream
git-svn-id: http://skia.googlecode.com/svn/trunk@7854
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Mon, 25 Feb 2013 20:42:44 +0000 (20:42 +0000)]
Fixed the hash key comparison function.
Review URL: https://codereview.appspot.com/
7378065
git-svn-id: http://skia.googlecode.com/svn/trunk@7853
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 20:38:07 +0000 (20:38 +0000)]
check-point: skiafy SkFontHost_fontconfig from chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@7852
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 20:24:24 +0000 (20:24 +0000)]
add --tmpDir foo option to tests, to allow unittests that want to write/read files
use tmpDir in SkStream tests
git-svn-id: http://skia.googlecode.com/svn/trunk@7851
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 25 Feb 2013 20:12:45 +0000 (20:12 +0000)]
Give GrDrawTarget a back ptr to its owning GrContext.
Review URL: https://codereview.appspot.com/
7395055
git-svn-id: http://skia.googlecode.com/svn/trunk@7850
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 25 Feb 2013 20:07:24 +0000 (20:07 +0000)]
Add an SkSet class to be used by Pdf only, for now - reverted because of triggering heap corruption on Win7, original coe review: https://codereview.appspot.com/
6749054
git-svn-id: http://skia.googlecode.com/svn/trunk@7849
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:46:11 +0000 (18:46 +0000)]
don't #include <unistd.h> if we're windows
git-svn-id: http://skia.googlecode.com/svn/trunk@7848
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:41:26 +0000 (18:41 +0000)]
don't try to access filedescriptors on windows
git-svn-id: http://skia.googlecode.com/svn/trunk@7847
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:17:12 +0000 (18:17 +0000)]
move SkFDStream out of images into core
git-svn-id: http://skia.googlecode.com/svn/trunk@7846
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 16:05:00 +0000 (16:05 +0000)]
Remove bogus ability for creating an SkPicturePlayback to fail.
Change SkPicturePlayback::parseBufferTag to return void, since
it can never return false.
Change SkPicturePlayback::parseStreamTag to return void, since
the only way it can return false is if parseBufferTag returns
false, or if creating a sub picture failed, both of which are
nonsensical.
Due to the above, there is no reason for creating an
SkPicturePlayback to fail, so remove the isValid parameter.
Update subclasses in SkDebuggerGUI.
Review URL: https://codereview.appspot.com/
7388050
git-svn-id: http://skia.googlecode.com/svn/trunk@7844
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 16:02:36 +0000 (16:02 +0000)]
Use size_t for rowBytes.
Previously, we were using uint32_t sometimes, int sometimes, and
size_t sometimes. Switch to using size_t, since we are actually
talking about a number of bytes.
In copyPixelsTo, use 0 as a flag to use the internal rowBytes,
which is more consistent with setConfig.
Review URL: https://codereview.appspot.com/
7370047
git-svn-id: http://skia.googlecode.com/svn/trunk@7843
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 25 Feb 2013 15:55:13 +0000 (15:55 +0000)]
Always round text position correctly.
https://codereview.appspot.com/
7383049/
Will require rebaseline of fontscaler GM.
Must add SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX to Chromium
until ~150 layout tests can be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@7842
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Feb 2013 13:32:31 +0000 (13:32 +0000)]
Whitespace change to test commit queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12340051
git-svn-id: http://skia.googlecode.com/svn/trunk@7841
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 25 Feb 2013 01:38:01 +0000 (01:38 +0000)]
Fixed '#if with no expression' warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@7840
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 23 Feb 2013 07:02:45 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7839
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 22:37:31 +0000 (22:37 +0000)]
Fix debugger build.
Review URL: https://codereview.appspot.com/
7375050
git-svn-id: http://skia.googlecode.com/svn/trunk@7838
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 22:04:19 +0000 (22:04 +0000)]
Remove SkSerializationHelpers.
Move the function definition for EncodeBitmap to SkPicture,
where InstallPixelRefProc has already moved (and where it is
relevant).
Review URL: https://codereview.appspot.com/
7386053
git-svn-id: http://skia.googlecode.com/svn/trunk@7837
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 22 Feb 2013 21:50:07 +0000 (21:50 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7836
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 21:38:35 +0000 (21:38 +0000)]
Create SkLazyPixelRef which performs lazy decoding.
The new pixel ref behaves similarly to SkImageRef, with some key differences:
It does not depend on the images project.
It requires an SkImageCache, which handles allocation and caching of the pixel
memory.
It takes a function signature for decoding which decodes into already allocated
pixel memory rather than into an SkBitmap.
Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache.
Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc,
and update sites that referenced it.
SkBitmapFactory now sets the pixel ref to a new object of the new
class SkLazyPixelRef, provided it has an SkImageCache for caching.
Provide an option to do lazy decodes in render_pictures and bench_pictures.
SkPicture:
Eliminate the default parameters in the constructor.
If a proc for decoding bitmaps is installed, use it to decode any encoded
data in subpictures.
When parsing deserializing subpictures, check for success.
When serializing subpictures, pass the picture's bitmap encoder to the
subpicture's call to serialize.
Update BitmapFactoryTest to test its new behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1008
BUG=https://code.google.com/p/skia/issues/detail?id=1009
Review URL: https://codereview.appspot.com/
7060052
git-svn-id: http://skia.googlecode.com/svn/trunk@7835
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 19:17:13 +0000 (19:17 +0000)]
Fix signed/unsigned comparison warnings in benchmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7833
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 17:28:16 +0000 (17:28 +0000)]
use DEF_GM
git-svn-id: http://skia.googlecode.com/svn/trunk@7832
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:44:04 +0000 (16:44 +0000)]
Enable cpu-array dynamic vertex data on SGX.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
7388045
git-svn-id: http://skia.googlecode.com/svn/trunk@7830
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 16:36:57 +0000 (16:36 +0000)]
remove obsolete build flags:
SK_IGNORE_TRANS_CLAMP_FIX
SK_IGNORE_1XN_BITMAP_OPT
SK_IGNORE_CLIP_BUG_FIX
SK_IGNORE_FAST_SCALEMATRIX_INVERT
SK_IGNORE_QUAD_STROKE_FIX
SK_IGNORE_MULTIPLY_XFERMODE_OPT
SK_IGNORE_LARGE_DASH_OPT
Review URL: https://codereview.appspot.com/
7381050
git-svn-id: http://skia.googlecode.com/svn/trunk@7829
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:25:28 +0000 (16:25 +0000)]
Fix GPU-less build of bench.
git-svn-id: http://skia.googlecode.com/svn/trunk@7828
2bbb7eff-a529-9590-31e7-
b0007b416f81