Armin Novak [Tue, 14 Nov 2017 12:58:55 +0000 (13:58 +0100)]
Fixed missing parameter checks.
Armin Novak [Tue, 14 Nov 2017 12:58:31 +0000 (13:58 +0100)]
Fixed uninitialized variables.
Armin Novak [Tue, 14 Nov 2017 12:58:08 +0000 (13:58 +0100)]
Fixed missing error check.
Armin Novak [Tue, 14 Nov 2017 12:57:48 +0000 (13:57 +0100)]
Fixed uninitialized arguments.
Armin Novak [Tue, 14 Nov 2017 12:57:00 +0000 (13:57 +0100)]
Fixed warnings and formatting.
Armin Novak [Tue, 14 Nov 2017 12:56:19 +0000 (13:56 +0100)]
Functions static, warnings fixed.
Armin Novak [Tue, 14 Nov 2017 12:55:58 +0000 (13:55 +0100)]
Fixed formatting and warnings.
Armin Novak [Tue, 14 Nov 2017 12:55:24 +0000 (13:55 +0100)]
Fixed dead store warning.
Armin Novak [Tue, 14 Nov 2017 12:54:59 +0000 (13:54 +0100)]
Removed unused argument.
Armin Novak [Tue, 14 Nov 2017 12:54:26 +0000 (13:54 +0100)]
Fixed missing function return check.
Armin Novak [Tue, 14 Nov 2017 12:54:05 +0000 (13:54 +0100)]
Fixed multiple warnings in parser
Armin Novak [Tue, 14 Nov 2017 12:52:52 +0000 (13:52 +0100)]
Fixed compile warnings.
Armin Novak [Tue, 14 Nov 2017 12:52:19 +0000 (13:52 +0100)]
Fixed warnings and test return values.
Armin Novak [Tue, 14 Nov 2017 12:51:37 +0000 (13:51 +0100)]
Fixed NULL arguments and compile warnings.
Armin Novak [Tue, 14 Nov 2017 12:50:30 +0000 (13:50 +0100)]
Fixed dead store.
David Fort [Wed, 15 Nov 2017 14:47:35 +0000 (15:47 +0100)]
Merge pull request #3940 from akallabeth/custom_help_arguments
Added a new function to allow printing help with additional arguments.
David Fort [Wed, 15 Nov 2017 14:37:27 +0000 (15:37 +0100)]
Merge pull request #4235 from akallabeth/avcodec_encode_video_fix
Added encoder path for libavcodec versions <1.0
Armin Novak [Thu, 4 May 2017 12:46:58 +0000 (14:46 +0200)]
Allow printing of custom arguments in help.
Armin Novak [Tue, 14 Nov 2017 08:15:43 +0000 (09:15 +0100)]
Added encoder path for libavcodec versions <1.0
David Fort [Mon, 13 Nov 2017 16:39:27 +0000 (17:39 +0100)]
Merge pull request #4233 from akallabeth/kerberos_rebased
Kerberos rebased
David Fort [Mon, 13 Nov 2017 16:09:48 +0000 (17:09 +0100)]
Merge pull request #4232 from akallabeth/ffmpeg_compat
Added compat define for missing format.
David Fort [Mon, 13 Nov 2017 14:50:28 +0000 (15:50 +0100)]
Fix logic in nla_read_ts_credentials
Armin Novak [Tue, 18 Jul 2017 09:38:59 +0000 (11:38 +0200)]
Fixed uninitialized values and leaks.
dodo040 [Fri, 18 Aug 2017 17:18:02 +0000 (19:18 +0200)]
fix Kerberos flavour's detection (MIT/Heimdal) and double free for MIT<1.13
dodo040 [Thu, 27 Jul 2017 15:02:06 +0000 (17:02 +0200)]
fix typo
dodo040 [Wed, 12 Jul 2017 09:59:39 +0000 (11:59 +0200)]
fix undeclared identifier on Windows
dodo040 [Tue, 11 Jul 2017 15:32:28 +0000 (17:32 +0200)]
use SSIZE_T instead of ssize_t
dodo040 [Tue, 11 Jul 2017 09:30:44 +0000 (11:30 +0200)]
handle missing ssize_t on Windows
dodo040 [Mon, 10 Jul 2017 14:51:41 +0000 (16:51 +0200)]
remove useless includes
dodo040 [Mon, 3 Jul 2017 10:47:56 +0000 (12:47 +0200)]
fix: GSS API init, enterprise name management, variable names and format code
dodo040 [Wed, 17 May 2017 09:36:36 +0000 (11:36 +0200)]
fix undefined symbol references at linking stage
dodo040 [Thu, 11 May 2017 16:51:45 +0000 (18:51 +0200)]
initial commit for kerberos support
Armin Novak [Mon, 13 Nov 2017 10:28:43 +0000 (11:28 +0100)]
Added compat define for missing format.
akallabeth [Mon, 13 Nov 2017 09:01:01 +0000 (10:01 +0100)]
Merge pull request #4122 from ben-cohen/sshagent
Forward ssh-agent data between ssh-agent and RDP
David Fort [Mon, 13 Nov 2017 08:30:28 +0000 (09:30 +0100)]
Merge pull request #4212 from SriRamanujam/ffmpeg_encoder_fixes
Fix libavcodec encoding errors and set tunables.
Sri Ramanujam [Sun, 12 Nov 2017 22:31:22 +0000 (17:31 -0500)]
Fallback #ifdefs for older versions of libavcodec
Ben Cohen [Fri, 10 Nov 2017 20:09:49 +0000 (20:09 +0000)]
Remove underscores from define in sshagent_main.h
Ben Cohen [Thu, 9 Nov 2017 21:45:12 +0000 (21:45 +0000)]
Fix comments at the start of these files and adjust copyrights
Ben Cohen [Fri, 8 Sep 2017 19:05:06 +0000 (20:05 +0100)]
Add server side plugin [UNTESTED]
This is based on xrdpapi/xrdp-ssh-agent.c from xrdp PR #867.
Ben Cohen [Fri, 8 Sep 2017 17:00:34 +0000 (18:00 +0100)]
Add rdpcontext so read thread can report channel error
Also fix copyright dates...
Ben Cohen [Fri, 8 Sep 2017 16:09:50 +0000 (17:09 +0100)]
Remove EAGAIN/EWOULDBLOCK from blocking read/write
Ben Cohen [Fri, 8 Sep 2017 15:52:14 +0000 (16:52 +0100)]
Fix socket fd leak and other changes
1. In connect_to_sshagent() if connect() fails, the socket agent_fd is
leaked. It needs to be closed before returning.
2. Fix copyright messages.
3. Make if statement with call to CreateThread() clearer to read.
Ben Cohen [Mon, 26 Jun 2017 20:16:22 +0000 (21:16 +0100)]
Forward ssh-agent data between ssh-agent and RDP
Add the sshagent plugin to forward the ssh-agent protocol over an RDP
dynamic virtual channel, just as the normal ssh-agent forwards it over
an SSH channel. Add the "/ssh-agent" command line option to enable it.
Usage:
Run FreeRDP with the ssh-agent plugin enabled:
xfreerdp /ssh-agent ...
In the remote desktop session run xrdp-ssh-agent and evaluate the output
in the shell as for ssh-agent to set the required environment variables
(specifically $SSH_AUTH_SOCK):
eval "$(xrdp-ssh-agent -s)"
This is the same as for the normal ssh-agent. You would typically do
this in your Xsession or /etc/xrdp/startwm.sh.
Limitations:
1. Error checking and handling could be improved.
2. This is only tested on Linux and will only work on systems where
clients talk to the ssh-agent via Unix domain sockets. It won't
currently work on Windows but it could be ported.
akallabeth [Fri, 10 Nov 2017 08:32:39 +0000 (09:32 +0100)]
Merge pull request #4225 from krisztian-kovacs-balabit/use-redirection-pdu-password-on-reconnect
core/connection: use redirection password when reconnecting
David Fort [Thu, 9 Nov 2017 17:11:12 +0000 (18:11 +0100)]
Merge pull request #4226 from krisztian-kovacs-balabit/open-x509-keyfile-readonly
libfreerdp/core/certificate: open key file for reading only
Sri Ramanujam [Fri, 18 Aug 2017 17:19:44 +0000 (13:19 -0400)]
Fix libavcodec encoding errors and set tunables.
KOVACS Krisztian [Thu, 28 Sep 2017 12:00:18 +0000 (14:00 +0200)]
libfreerdp/core/certificate: open key file for reading only
There's no point in writing the key file for read-write, and it makes it
impossible to run the shadow server with the key file being read only.
Martin Fleisz [Thu, 9 Nov 2017 15:24:46 +0000 (16:24 +0100)]
Merge pull request #4224 from krisztian-kovacs-balabit/nsc-memory-corruption-fix
codec/nsc: fix memory corruption in case of chroma subsampling
David Fort [Thu, 9 Nov 2017 14:26:06 +0000 (15:26 +0100)]
Merge pull request #4163 from rjcorrig/tzscripts
winpr: Convert time zone generator programs to C# scripts
David Fort [Thu, 9 Nov 2017 14:24:27 +0000 (15:24 +0100)]
Merge pull request #4151 from ondrejholy/manpages-update-master
Manpage and /help update
KOVACS Krisztian [Tue, 7 Nov 2017 15:06:01 +0000 (16:06 +0100)]
core/connection: use redirection password when reconnecting
According to MS-RDPBCGR the server might send a password in the Redirection PDU
that then must be sent by the client to the server as password.
Since the field either contains a password string (unicode) or a binary cookie,
we try to convert the password from unicode and use it only if conversion
succeeds.
KOVACS Krisztian [Tue, 7 Nov 2017 12:52:09 +0000 (13:52 +0100)]
codec/nsc: fix memory corruption in case of chroma subsampling
For odd number of rows, the memory copy operation was broken: after exiting
the loop, yplane points to the end of the last row data, and thus (yplane +
rw) points *after* the end of the last row.
David Fort [Thu, 9 Nov 2017 12:35:56 +0000 (13:35 +0100)]
Merge pull request #4223 from akallabeth/mac_client_crash_fix
Added missing pointer callback.
Armin Novak [Thu, 9 Nov 2017 09:22:16 +0000 (10:22 +0100)]
Added missing pointer callback.
Martin Fleisz [Thu, 9 Nov 2017 08:37:18 +0000 (09:37 +0100)]
Merge pull request #4219 from akallabeth/various_fixes
Various fixes
Martin Fleisz [Wed, 8 Nov 2017 12:34:26 +0000 (13:34 +0100)]
Merge pull request #4211 from akallabeth/silence_duplicate_warnings
Silence WLog_ERR messages if last error is set.
Martin Fleisz [Wed, 8 Nov 2017 12:04:04 +0000 (13:04 +0100)]
Merge pull request #4214 from hardening/serial_fixes
Serial fixes
Armin Novak [Wed, 8 Nov 2017 11:37:23 +0000 (12:37 +0100)]
Fixed compilation errors with old FFMPEG versions.
Armin Novak [Wed, 8 Nov 2017 10:30:32 +0000 (11:30 +0100)]
Fixed NLA default error to FREERDP_ERROR_AUTHENTICATION_FAILED
David Fort [Mon, 6 Nov 2017 21:23:07 +0000 (22:23 +0100)]
serial redirection: implement event char
The signotec signature device requires the eventChar support to work properly in
serial redirection mode. This implementation is basic but does the job for this
device.
Sponsored by: Rangee GmbH (http://www.rangee.de)
David Fort [Mon, 6 Nov 2017 21:09:01 +0000 (22:09 +0100)]
Disambiguate USB error messages and fix a typo
David Fort [Mon, 6 Nov 2017 20:58:10 +0000 (21:58 +0100)]
Added some checks for the serial redirection channel
Sponsored by: Rangee GmbH (http://www.rangee.de)
David Fort [Mon, 6 Nov 2017 13:23:50 +0000 (14:23 +0100)]
Merge pull request #4210 from akallabeth/nla_errors_extended
Added additional NLA error mappings.
Armin Novak [Mon, 6 Nov 2017 13:02:22 +0000 (14:02 +0100)]
Silence WLog_ERR messages if last error is set.
David Fort [Mon, 6 Nov 2017 10:25:48 +0000 (11:25 +0100)]
Merge pull request #4053 from akallabeth/ffmpeg_encoder
Implemented FFMPEG based encoder.
akallabeth [Mon, 6 Nov 2017 09:22:37 +0000 (10:22 +0100)]
Merge pull request #4200 from cedrozor/upstream-master
Windows client: refresh only updated region(s) instead of whole screen
akallabeth [Mon, 6 Nov 2017 09:02:07 +0000 (10:02 +0100)]
Merge pull request #4187 from hardening/multimon_fix
Multimonitor fix
Armin Novak [Mon, 6 Nov 2017 08:49:03 +0000 (09:49 +0100)]
Added additional NLA error mappings.
David Fort [Fri, 3 Nov 2017 20:34:18 +0000 (21:34 +0100)]
Merge pull request #4206 from akallabeth/x_window_title
X11 window title fix
Armin Novak [Tue, 31 Oct 2017 17:00:15 +0000 (18:00 +0100)]
X11 window title fix
Martin Fleisz [Tue, 31 Oct 2017 16:17:43 +0000 (17:17 +0100)]
Merge pull request #4205 from akallabeth/WIN32_FIND_DATA
Fixed #4199: ConvertFindDataAToW string length
Armin Novak [Tue, 31 Oct 2017 11:02:29 +0000 (12:02 +0100)]
Fixed #4199: ConvertFindDataAToW string length
akallabeth [Tue, 31 Oct 2017 14:36:22 +0000 (15:36 +0100)]
Merge pull request #4159 from aleksei-klv/dex
Optimized aFreeRDP for Samsung DeX
Martin Fleisz [Tue, 31 Oct 2017 10:42:58 +0000 (11:42 +0100)]
Merge pull request #4179 from akallabeth/android_cleanup_fix
[android] Ensure native session is disconnected before resource free.
Martin Fleisz [Tue, 31 Oct 2017 08:55:43 +0000 (09:55 +0100)]
Merge pull request #4204 from lunixoid/master
Fixed twice assigned values
Roman Kalashnikov [Mon, 30 Oct 2017 21:11:25 +0000 (00:11 +0300)]
Fixed twice assigned values
Mike Gilbert [Mon, 30 Oct 2017 16:29:58 +0000 (12:29 -0400)]
Merge pull request #4203 from floppym/mkdir-error
winpr: _IoCreateDeviceEx: fix mkdir error check
Mike Gilbert [Mon, 30 Oct 2017 00:26:53 +0000 (20:26 -0400)]
winpr: _IoCreateDeviceEx: fix mkdir error check
The mkdir(2) function returns 0 on success, and -1 on error.
This resolves an error in TestIoDevice when /tmp/.device/ does not
exist.
Bug: https://bugs.gentoo.org/635838
akallabeth [Mon, 30 Oct 2017 14:47:02 +0000 (15:47 +0100)]
Merge pull request #4201 from kakaroto/listener-unlink-bugfix
Do not delete the listener socket right after creating it.
David Fort [Sun, 29 Oct 2017 16:52:19 +0000 (17:52 +0100)]
Merge pull request #4202 from lunixoid/master
Static analyser issues
Roman Kalashnikov [Sat, 28 Oct 2017 08:59:23 +0000 (11:59 +0300)]
Update semaphore.c
Roman Kalashnikov [Fri, 27 Oct 2017 22:48:41 +0000 (01:48 +0300)]
Fixed Expression 'pComm != NULL' is always true
pComm was checked earlier in 1363 string:
`if (pComm == NULL)`
Roman Kalashnikov [Fri, 27 Oct 2017 22:46:06 +0000 (01:46 +0300)]
Fixed duplicated assigne
Youness Alaoui [Fri, 27 Oct 2017 18:38:35 +0000 (14:38 -0400)]
Do not delete the listener socket right after creating it.
The listener server socket file needs to be deleted before we bind it
otherwise it's an "address already in use" error. But it was getting
deleted after the bind, causing the file to disappear, and preventing
anyone from connecting to the listener socket since the socket stops
existing.
This is caused by commit
884e87fde4ece132c3b7bdf947de044ecb3d4b14
cedrozor [Fri, 27 Oct 2017 12:30:00 +0000 (14:30 +0200)]
fixed hdc initialization into wf_begin_paint so the region invalidation into wf_end_paint applies to the same hdc
the objective is that only the updated region(s) are refreshed instead of the whole screen
it's not much a problem for normal FreeRDP usage but becomes a serious issue if the display is processed, forwarded and rendered remotely, as done by web gateways such as Guacamole, FreeRDP-WebConnect and Myrtille (I'm the author of the latter)
Aleksei Kliuev [Thu, 26 Oct 2017 12:36:53 +0000 (15:36 +0300)]
remove temporary hack
David Fort [Wed, 25 Oct 2017 22:17:03 +0000 (00:17 +0200)]
Merge pull request #4198 from akallabeth/nla_error_fix
Added better error mapping for NEGO results.
Armin Novak [Wed, 25 Oct 2017 07:56:39 +0000 (09:56 +0200)]
Added better error mapping for NEGO results.
Armin Novak [Mon, 23 Oct 2017 07:48:52 +0000 (09:48 +0200)]
Fixed possible race condition on resource cleanup.
David Fort [Thu, 19 Oct 2017 11:15:04 +0000 (13:15 +0200)]
Merge pull request #4195 from nfedera/fix-sse3-yuv444pixel
primitives/yuv: fix endianess issue
Norbert Federa [Thu, 19 Oct 2017 09:55:13 +0000 (11:55 +0200)]
primitives/yuv: fix endianess issue
Norbert Federa [Wed, 18 Oct 2017 08:24:35 +0000 (10:24 +0200)]
Merge pull request #4190 from akallabeth/media_foundation_fix_win7
Removed unused function pointer
Armin Novak [Wed, 18 Oct 2017 07:52:41 +0000 (09:52 +0200)]
Removed unused function pointer
The function was breaking windows 7 compatibility.
Norbert Federa [Tue, 17 Oct 2017 19:33:16 +0000 (21:33 +0200)]
Merge pull request #4189 from nfedera/fix-h264-init
codec/h264: fix potential segfault and mf_init
Norbert Federa [Tue, 17 Oct 2017 17:28:54 +0000 (19:28 +0200)]
codec/h264: fix potential segfault and mf_init
David Fort [Tue, 17 Oct 2017 12:31:11 +0000 (14:31 +0200)]
multimon: flag the primary monitor according to the /monitors option
The first monitor of the list is considered like the primary monitor.
David Fort [Tue, 17 Oct 2017 12:07:23 +0000 (14:07 +0200)]
multimon: correctly set the primary monitor
According to the spec the primary monitor is supposed to be in (0,0) and other monitors
to be given relative to this one.
Armin Novak [Tue, 17 Oct 2017 07:12:27 +0000 (09:12 +0200)]
Added default return if instance not in list.
akallabeth [Mon, 16 Oct 2017 15:21:35 +0000 (17:21 +0200)]
Merge pull request #4177 from rjcorrig/tabfix
Android: Fix tab key mapping for hardware keyboard
Armin Novak [Fri, 13 Oct 2017 11:13:33 +0000 (13:13 +0200)]
Ensure native session is disconnected before resource free.