andersca@apple.com [Fri, 27 May 2011 22:14:13 +0000 (22:14 +0000)]
2011-05-27 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Always use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=61670
<rdar://problem/9516130>
Always use the default localization strategy when there's no platform strategy.
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::shared):
* platform/DefaultLocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::inputElementAltText):
(WebCore::resetButtonDefaultLabel):
(WebCore::searchableIndexIntroduction):
(WebCore::submitButtonDefaultLabel):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::defaultDetailsSummaryText):
(WebCore::copyImageUnknownFileLabel):
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagCopyImageUrlToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchInSpotlight):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagShowFonts):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagStyles):
(WebCore::contextMenuItemTagShowColors):
(WebCore::contextMenuItemTagSpeechMenu):
(WebCore::contextMenuItemTagStartSpeaking):
(WebCore::contextMenuItemTagStopSpeaking):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagCorrectSpellingAutomatically):
(WebCore::contextMenuItemTagSubstitutionsMenu):
(WebCore::contextMenuItemTagShowSubstitutions):
(WebCore::contextMenuItemTagSmartCopyPaste):
(WebCore::contextMenuItemTagSmartQuotes):
(WebCore::contextMenuItemTagSmartDashes):
(WebCore::contextMenuItemTagSmartLinks):
(WebCore::contextMenuItemTagTextReplacement):
(WebCore::contextMenuItemTagTransformationsMenu):
(WebCore::contextMenuItemTagMakeUpperCase):
(WebCore::contextMenuItemTagMakeLowerCase):
(WebCore::contextMenuItemTagCapitalize):
(WebCore::contextMenuItemTagChangeBack):
(WebCore::contextMenuItemTagOpenVideoInNewWindow):
(WebCore::contextMenuItemTagOpenAudioInNewWindow):
(WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
(WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::searchMenuNoRecentSearchesText):
(WebCore::searchMenuRecentSearchesText):
(WebCore::searchMenuClearRecentSearchesText):
(WebCore::AXWebAreaText):
(WebCore::AXLinkText):
(WebCore::AXListMarkerText):
(WebCore::AXImageMapText):
(WebCore::AXHeadingText):
(WebCore::AXDefinitionListTermText):
(WebCore::AXDefinitionListDefinitionText):
(WebCore::AXARIAContentGroupText):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
(WebCore::missingPluginText):
(WebCore::crashedPluginText):
(WebCore::multipleFileUploadText):
(WebCore::unknownFileSizeText):
(WebCore::uploadFileText):
(WebCore::allFilesText):
(WebCore::keygenMenuItem512):
(WebCore::keygenMenuItem1024):
(WebCore::keygenMenuItem2048):
(WebCore::keygenKeychainItemName):
(WebCore::imageTitle):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 27 May 2011 21:36:05 +0000 (21:36 +0000)]
[Chromium] Unreviewed test expectations update.
Flip svg/html/by-reference.html to its new failed state after r87526.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 27 May 2011 21:15:46 +0000 (21:15 +0000)]
First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
Reviewed by Darin Adler.
Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.
No new tests. No change in behavior.
Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):
* dom/Document.h:
Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):
* WebCore.exp.in:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 27 May 2011 21:05:00 +0000 (21:05 +0000)]
2011-05-27 Adrienne Walker <enne@google.com>
[chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
https://bugs.webkit.org/show_bug.cgi?id=61652
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 27 May 2011 20:56:13 +0000 (20:56 +0000)]
2011-05-27 Adam Klein <adamk@chromium.org>
Unreviewed. Rebaselines and test expectations updates after r87526.
* platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
* platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
* platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
* platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 27 May 2011 20:53:43 +0000 (20:53 +0000)]
2011-05-27 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
30 second rewind button obscured in fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=61663
If reset() is called while in full-screen mode, make sure to show and hide
the correct controls for that mode.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 27 May 2011 20:39:28 +0000 (20:39 +0000)]
2011-05-27 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.
* runtime/JSGlobalData.cpp:
(JSGlobalData::JSGlobalData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 27 May 2011 20:29:12 +0000 (20:29 +0000)]
2011-05-27 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590
* compositing/iframes/resizer-expected.txt: Added.
* compositing/iframes/resizer.html: Added.
2011-05-27 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590
Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
graphics layer tree consistent.
Test: compositing/iframes/resizer.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 27 May 2011 20:25:27 +0000 (20:25 +0000)]
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
Fix last failing win/svg test, put result in correct directory.
* platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
* platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 27 May 2011 20:22:46 +0000 (20:22 +0000)]
<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.
Rubber-stamped by Steve Falkenburg.
* WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 20:21:20 +0000 (20:21 +0000)]
Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 20:18:39 +0000 (20:18 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
The feature is tracked by the bug 61630.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 May 2011 19:53:45 +0000 (19:53 +0000)]
2011-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLVideoElement::currentSrc() should return a KURL
https://bugs.webkit.org/show_bug.cgi?id=61578
I suspect we got into this mess because the author of this code didn't
know about the URL attribute in WebKit IDL, which is super useful!
Bad news: The line of code in question seems to have another bug, which
I've documented in a FIXME. Let the yak shaving continue!
* html/HTMLMediaElement.cpp:
(WebCore::urlForLogging):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::currentSrc):
(WebCore::HTMLMediaElement::currentURL):
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::checkOrigin):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteMediaURL):
- This complete URL call was unnecessary because currentSrc is
already absolute.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 19:52:26 +0000 (19:52 +0000)]
2011-05-27 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=61177
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get className):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 27 May 2011 19:50:35 +0000 (19:50 +0000)]
Always decode tester names from location.hash
When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 27 May 2011 19:48:25 +0000 (19:48 +0000)]
2011-05-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add a few validity assertions to JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=61659
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 27 May 2011 19:44:09 +0000 (19:44 +0000)]
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
Rebaseline some qt/win/leopard results.
* platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
* platform/qt/svg/in-html/by-reference-expected.txt:
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
* platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 27 May 2011 19:32:57 +0000 (19:32 +0000)]
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Rob Buis.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
Fixes crash in svg/custom/immutable-properties.html, seen on the bots.
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 27 May 2011 19:32:50 +0000 (19:32 +0000)]
2011-05-27 Nat Duca <nduca@chromium.org>
Unreviewed, landed by enne@google.com.
[chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
https://bugs.webkit.org/show_bug.cgi?id=61652
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 18:56:21 +0000 (18:56 +0000)]
Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 18:52:59 +0000 (18:52 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61610
Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.
* editing/pasteboard/paste-pre-001-expected.txt: Added.
* editing/pasteboard/paste-pre-001.html:
* editing/pasteboard/paste-pre-002-expected.txt: Added.
* editing/pasteboard/paste-pre-002.html:
* platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
* platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 27 May 2011 18:49:13 +0000 (18:49 +0000)]
Remove testing code that snuck into r87528
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 27 May 2011 18:47:34 +0000 (18:47 +0000)]
Build fix
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 27 May 2011 18:41:56 +0000 (18:41 +0000)]
Add links to TestFailures to easily file bugs about failing tests
Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 27 May 2011 18:30:08 +0000 (18:30 +0000)]
2011-05-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Try to release unused executable memory when the FixedVMPool allocator is under pressure
https://bugs.webkit.org/show_bug.cgi?id=61651
Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::create):
(JSC::ExecutablePool::alloc):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::poolForSize):
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::alloc):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::releaseExecutableMemory):
(JSC::releaseExecutableMemory):
* runtime/JSGlobalData.h:
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::invalidateCode):
* runtime/RegExpCache.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 27 May 2011 18:27:50 +0000 (18:27 +0000)]
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976
Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793
WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)
CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)
SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972
Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086
* http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
* http/tests/misc/resources/embedded.svg: Added.
* http/tests/misc/resources/svg-slow.pl: Added.
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
* platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-expected.png: Added.
* platform/mac/svg/custom/object-sizing-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
* platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
* platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/mac/svg/hixie/text/003-expected.png:
* platform/mac/svg/hixie/text/003-expected.txt:
* platform/mac/svg/in-html/by-reference-expected.txt:
* platform/mac/svg/wicd: Added.
* platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
* svg/custom/object-no-size-attributes.xhtml: Added.
* svg/custom/object-sizing-explicit-height.xhtml: Added.
* svg/custom/object-sizing-explicit-width-height.xhtml: Added.
* svg/custom/object-sizing-explicit-width.xhtml: Added.
* svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
* svg/custom/object-sizing-no-width-height.xhtml: Added.
* svg/custom/object-sizing.xhtml: Added.
* svg/custom/resources/embedded.svg: Added.
* svg/custom/resources/red-circle.svg: Added.
* svg/in-html/by-reference-expected.png:
* svg/wicd: Added.
* svg/wicd/resources: Added.
* svg/wicd/resources/a.svg: Added.
* svg/wicd/resources/bcde.svg: Added.
* svg/wicd/resources/empty1.svg: Added.
* svg/wicd/resources/empty2.svg: Added.
* svg/wicd/resources/empty3.svg: Added.
* svg/wicd/resources/f.svg: Added.
* svg/wicd/resources/g.svg: Added.
* svg/wicd/resources/h.svg: Added.
* svg/wicd/resources/i.svg: Added.
* svg/wicd/resources/j.svg: Added.
* svg/wicd/resources/k.svg: Added.
* svg/wicd/resources/l.svg: Added.
* svg/wicd/resources/main.css: Added.
(body,html):
(body):
(.buttons):
(h1):
(h2):
(h4):
(p):
(table):
(th):
(td,th):
(td a):
(a):
(a:hover):
(a:focus):
(a:visited):
(a.index):
(a.index:hover):
(a.index:focus):
(a.index:visited):
(ul):
(ol):
(.red):
(.navi):
(.navi a):
(.navi a:hover):
(.navi a:visited):
* svg/wicd/resources/mnop.svg: Added.
* svg/wicd/resources/q.svg: Added.
* svg/wicd/resources/r.svg: Added.
* svg/wicd/resources/s.svg: Added.
* svg/wicd/resources/t.svg: Added.
* svg/wicd/resources/test-rightsizing-a.css: Added.
(html,body):
(div.all):
(object.w100):
(object.h100):
* svg/wicd/resources/test-rightsizing-b.css: Added.
(html,body):
(object):
* svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
* svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
* svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
* svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
* svg/wicd/rightsizing-grid.xhtml: Added.
* svg/wicd/test-rightsizing-a.xhtml: Added.
* svg/wicd/test-rightsizing-b.xhtml: Added.
* svg/zoom/page/resources: Added.
* svg/zoom/page/resources/absolute-sized-svg.png: Added.
* svg/zoom/page/resources/absolute-sized-svg.svg: Added.
* svg/zoom/page/resources/huge-rect.svg: Added.
* svg/zoom/page/resources/percentage-sized-svg.png: Added.
* svg/zoom/page/resources/percentage-sized-svg.svg: Added.
* svg/zoom/page/resources/text.svg: Added.
* svg/zoom/page/resources/tux.svg: Added.
* svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
* svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
* svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
* svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
* svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
* svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.
2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526
<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976
Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793
WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)
CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)
SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972
Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086
Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).
SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.
If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)
Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".
Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml
svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml
* platform/Length.h:
(WebCore::Length::isSpecified):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::embeddedSVGContentRenderer):
(WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
(WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
(WebCore::RenderPart::computeReplacedLogicalWidth):
(WebCore::RenderPart::computeReplacedLogicalHeight):
(WebCore::RenderPart::layout):
* rendering/RenderPart.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeIntrinsicRatio):
(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
* rendering/svg/RenderSVGRoot.h:
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
* svg/SVGSVGElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Fri, 27 May 2011 18:11:28 +0000 (18:11 +0000)]
2011-05-27 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
[chromium] drop unused WebFrame parameter to WebStorageArea::setItem
https://bugs.webkit.org/show_bug.cgi?id=61583
* public/WebStorageArea.h:
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::setItem):
* src/WebStorageAreaImpl.cpp:
(WebKit::WebStorageAreaImpl::setItem):
* src/WebStorageAreaImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Fri, 27 May 2011 17:52:05 +0000 (17:52 +0000)]
2011-05-27 Michael Saboff <msaboff@apple.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=61646
Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font
Change the platformIsEqual to just compare the m_font members if
either is not null.
No tests added - functionality unchanged, fixing memory abandonment.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformIsEqual):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 27 May 2011 17:39:53 +0000 (17:39 +0000)]
2011-05-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917
Added a GTK+ specific test that verifies that zero pixel sized
fonts do not corrupt the Cairo context.
* platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
* platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
* platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.
2011-05-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917
When instantiating a cairo_scaled_font_t font would put the font in an error state,
leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
in the error state can later lead to corrupted rendering.
Due to this change, we must always null check cairo_scaled_font_t and the platform
data now carries the cairo_font_face_t object with it, so that it can be accessed later
if there is no cairo_scaled_font_t.
Test: platform/gtk/fonts/zero-pixel-sized-fonts.html
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
* platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): Initialize the new member.
(WebCore::FontPlatformData::operator=): Carry over the new member.
(WebCore::FontPlatformData::operator==): Check equality with the new member.
(WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont
put the font into an error state, then just free it and return.
(WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap
when the scaled font is null, because rendering is always a no-op and the font data never
needs to be read.
* platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit): Return early when there's no scaled font.
(WebCore::SimpleFontData::scaledFontData): Use the new m_font member.
(WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font.
(WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 27 May 2011 17:39:35 +0000 (17:39 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized ConservativeSet to avoid double-visiting objects
https://bugs.webkit.org/show_bug.cgi?id=61592
SunSpider thinks this might be a 1% speedup
* heap/ConservativeRoots.h:
(JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting
an object.
* heap/Heap.h:
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::testAndClearMarked):
(JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type
to void*, since clients want to ask questions about arbitrary pointers
into the heap, even when they aren't known to be JSCells.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::testAndClearMarked):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::isMarked):
(JSC::MarkedSpace::testAndSetMarked):
(JSC::MarkedSpace::testAndClearMarked):
(JSC::MarkedSpace::setMarked):
(JSC::MarkedSpace::contains): Ditto.
* wtf/Bitmap.h:
(WTF::::testAndClear): New function for ConservativeRoots's inverted
marking pass.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 27 May 2011 17:25:06 +0000 (17:25 +0000)]
Need a callback for when the preferred rendered size may have changed.
https://bugs.webkit.org/show_bug.cgi?id=61309
Reviewed by Darin Fisher.
Source/WebCore:
No new tests needed since no new functionality is exposed.
* page/Chrome.cpp:
(WebCore::Chrome::layoutUpdated): Plumbed through the call.
* page/Chrome.h: Added the new method.
* page/ChromeClient.h:
(WebCore::ChromeClient::layoutUpdated): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Added a callback for whem a layout has finished.
Source/WebKit/chromium:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::didUpdateLayout): Added stub.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.
* src/ChromeClientImpl.h: Added declaration.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 27 May 2011 16:59:08 +0000 (16:59 +0000)]
Rubber Stamped by Adam Roben.
Source/JavaScriptCore:
Update Order Files. Use -order_file flag since it can order more of the binary.
* Configurations/Base.xcconfig:
* JavaScriptCore.order:
Source/WebCore:
Update Order Files. Use -order_file flag since it can order more of the binary.
* Configurations/Base.xcconfig:
* WebCore.order:
Source/WebKit/mac:
Update Order Files. Use -order_file flag since it can order more of the binary.
* Configurations/Base.xcconfig:
* WebKit.order:
Source/WebKit2:
Add Order File. Use -order_file flag since it can order more of the binary.
* Configurations/Base.xcconfig:
* mac/WebKit2.order: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 16:34:10 +0000 (16:34 +0000)]
2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643
client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).
* http/tests/websocket/tests/client-close-expected.txt: Removed.
* http/tests/websocket/tests/client-close.html: Removed.
* http/tests/websocket/tests/client-close_wsh.py: Removed.
* http/tests/websocket/tests/close-before-open-expected.txt:
* http/tests/websocket/tests/close-event-expected.txt:
* http/tests/websocket/tests/close-event.html:
* http/tests/websocket/tests/close-unref-websocket-expected.txt:
* http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
* http/tests/websocket/tests/server-close-expected.txt: Removed.
* http/tests/websocket/tests/server-close.html: Removed.
* http/tests/websocket/tests/server-close_wsh.py: Removed.
* http/tests/websocket/tests/websocket-event-target-expected.txt:
2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643
client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).
* platform/network/SocketStreamHandleBase.cpp:
(WebCore::SocketStreamHandleBase::send):
(WebCore::SocketStreamHandleBase::close):
(WebCore::SocketStreamHandleBase::sendPendingData):
* platform/network/SocketStreamHandleBase.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didClose):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::processBuffer):
* websockets/WebSocketChannel.h:
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643
client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).
* Scripts/webkitpy/thirdparty/__init__.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Fri, 27 May 2011 16:19:53 +0000 (16:19 +0000)]
2011-05-27 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.
Remove 003-broken.xml and replace it with a 003.xml that is text-only.
* platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
* platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
* svg/hixie/links/003-broken.xml: Removed.
* svg/hixie/links/003-expected.txt: Added.
* svg/hixie/links/003.xml: Added.
2011-05-27 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.
Only allow links to animation elements within the document.
Test: svg/hixie/links/003.xml
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 27 May 2011 16:14:39 +0000 (16:14 +0000)]
2011-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
https://bugs.webkit.org/show_bug.cgi?id=60757
cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::paint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 27 May 2011 16:10:00 +0000 (16:10 +0000)]
[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 27 May 2011 15:41:20 +0000 (15:41 +0000)]
Added Douglas Davidson to contributors list for easier CC'ing.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 27 May 2011 15:34:17 +0000 (15:34 +0000)]
2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044
Make sure to set the active window on the application too.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 15:19:03 +0000 (15:19 +0000)]
Unreviewed.
WebKit2 does not support eventSender.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 27 May 2011 15:03:50 +0000 (15:03 +0000)]
2011-05-27 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449
HTML5 now specifies that fully transparent colors should have their alpha value
serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)
The number of decimals for alpha values between 0 and 1 is not specified,
so match Gecko and Presto by returning the lowest number of decimals needed
to represent the number. (No more trailing zeroes.)
* platform/graphics/Color.cpp:
(WebCore::Color::serialized):
2011-05-27 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449
Update tests to reflect the new behavior.
* canvas/philip/tests/2d.fillStyle.get.transparent.html:
* canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
* canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
* editing/style/inline-style-container-expected.txt
* editing/style/script-tests/inline-style-container.js:
* fast/canvas/canvas-color-clamping-expected.txt:
* fast/canvas/canvas-color-serialization-expected.txt:
* fast/canvas/canvas-currentColor-expected.txt:
* fast/canvas/script-tests/canvas-color-clamping.js:
* fast/canvas/script-tests/canvas-color-serialization.js:
* fast/canvas/script-tests/canvas-currentColor.js:
* fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
* fast/dom/canvasContext2d-element-attribute-js-null.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 14:35:51 +0000 (14:35 +0000)]
Unreviewed.
Skip a test that requires eventSender.beginDragWithFiles.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 14:23:37 +0000 (14:23 +0000)]
Unreviewed.
Skip a test that is failing until investigated.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 27 May 2011 14:19:07 +0000 (14:19 +0000)]
2011-05-26 Jeff Miller <jeffm@apple.com>
Reviewed by Alexey Proskuryakov.
Add a key handling logging channel for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61588
Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.
* Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
* Platform/Logging.h: Added LogKeyHandling channel.
* UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment.
(WebKit::webKeyboardEventTypeString): Added to support logging.
(WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event.
(WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 27 May 2011 14:02:26 +0000 (14:02 +0000)]
2011-05-27 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615
New test for adding new entries to an objecet store while running a
cursor over it.
* storage/indexeddb/mutating-cursor-expected.txt: Added.
* storage/indexeddb/mutating-cursor.html: Added.
2011-05-27 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615
We need to support the case where a new node is added to the tree in a
transaction after the TreeIterator has covered the whole tree.
Since this is done lazily, i.e. we set a flag that the tree might have
changed, and act upon it later, some members need to be mutable,
because we might need to re-seek the tree iterator in a const function.
Test: storage/indexeddb/mutating-cursor.html
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::set):
(WebCore::LevelDBTransaction::TreeIterator::reset):
(WebCore::LevelDBTransaction::TreeIterator::~TreeIterator):
(WebCore::LevelDBTransaction::TreeIterator::TreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):
(WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
(WebCore::LevelDBTransaction::TransactionIterator::next):
(WebCore::LevelDBTransaction::TransactionIterator::prev):
(WebCore::LevelDBTransaction::TransactionIterator::key):
(WebCore::LevelDBTransaction::TransactionIterator::value):
(WebCore::LevelDBTransaction::TransactionIterator::treeChanged):
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::registerIterator):
(WebCore::LevelDBTransaction::unregisterIterator):
(WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
* platform/leveldb/LevelDBTransaction.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 13:51:04 +0000 (13:51 +0000)]
2011-05-27 Sujin Park <sujjin.park@gmail.com>
Unreviewed, buildfix if --no-javascript-debugger.
Regression(R84125): Broke GTK build
https://bugs.webkit.org/show_bug.cgi?id=60698
No new tests since this doesn't change any behavior.
* inspector/WorkerInspectorController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 May 2011 13:48:35 +0000 (13:48 +0000)]
[Qt][Mac] Daily gardening.
Typo fix, and remove non-existent files from Skipped list.
* platform/qt-mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 May 2011 13:12:30 +0000 (13:12 +0000)]
[Qt][Mac] Daily gardening.
* platform/qt-mac/Skipped:
- plugins/embed-attributes-setting.html was unskipped by r87306, but fails on Qt-Mac.
- plugins/plugin-initiate-popup-window.html unskipped by r87429, but fails on Qt-Mac.
- fast/css/disabled-author-styles unskipped by r87311, but fails on Qt-Mac.
* platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Added after r87468.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 12:59:03 +0000 (12:59 +0000)]
Unreviewed.
Skip test that is failing on the bot, until investigated.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 12:48:21 +0000 (12:48 +0000)]
Unreviewed.
Skip new dropzone tests. Qt's DRT does not support drag 'n drop.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 12:46:35 +0000 (12:46 +0000)]
[Chromium] Unreviewed, suppress editing/pasteboard/smart-paste-004.html on Win after r87496
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 12:43:10 +0000 (12:43 +0000)]
[Chromium] Unreveiwed, suppress editing/pasteboard/smart-paste-003.html on Win after r87495
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 May 2011 12:42:43 +0000 (12:42 +0000)]
[WK2] Skip new failing tests because of missing SVG animation pause API.
* platform/mac-wk2/Skipped: Add failing tests.
* platform/qt-wk2/Skipped: Remove tests, because they fail because of WK2 specific bug, not Qt-WK2 specific.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 27 May 2011 12:37:48 +0000 (12:37 +0000)]
webkit should implement the dropzone attribute
https://bugs.webkit.org/show_bug.cgi?id=58210
Reviewed by Tony Chang.
Source/WebCore:
Add support for dropzone attribute.
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
If there is such an element, and it matches the drag data store, set the action defined by that
element and continue processing the drag and drop operation.
Tests: fast/events/dropzone-001.html
fast/events/dropzone-002.html
fast/events/dropzone-003.html
fast/events/dropzone-004.html
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::Clipboard::processDropZoneKeyword):
* dom/Clipboard.h:
* html/HTMLAttributeNames.in:
* html/HTMLElement.idl:
* page/EventHandler.cpp:
(WebCore::EventHandler::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
* page/EventHandler.h:
LayoutTests:
* fast/events/dropzone-001-expected.txt: Added.
* fast/events/dropzone-001.html: Added.
* fast/events/dropzone-002-expected.txt: Added.
* fast/events/dropzone-002.html: Added.
* fast/events/dropzone-003-expected.txt: Added.
* fast/events/dropzone-003.html: Added.
* fast/events/dropzone-004-expected.txt: Added.
* fast/events/dropzone-004.html: Added.
* fast/events/resources/dropzone.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 May 2011 12:20:46 +0000 (12:20 +0000)]
[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60175
[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176
* platform/qt-4.8/Skipped: The bug is in Qt 4.8, add Qt bug tracker URL's.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Fri, 27 May 2011 11:57:46 +0000 (11:57 +0000)]
[Qt][WK2] Make the bot environmentally friendly.
* platform/qt-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 11:44:07 +0000 (11:44 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert smart-paste-004.html through smart-paste-006.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61618
Converted smart-paste-004.html, smart-paste-005.html, and smart-paste-005.html to dumpAsText tests.
* editing/pasteboard/smart-paste-004-expected.txt: Added.
* editing/pasteboard/smart-paste-004.html:
* editing/pasteboard/smart-paste-005-expected.txt: Added.
* editing/pasteboard/smart-paste-005.html:
* editing/pasteboard/smart-paste-006-expected.txt: Added.
* editing/pasteboard/smart-paste-006.html:
* platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-005-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-006-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-004-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-005-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-005-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-006-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-004-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-005-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-005-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-006-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-006-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-004-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-004-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-005-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-005-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-006-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-006-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-004-expected.png: Removed.
* platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-005-expected.png: Removed.
* platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-006-expected.png: Removed.
* platform/qt/editing/pasteboard/smart-paste-006-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 11:38:49 +0000 (11:38 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61617
Converted smart-paste-001.html, smart-paste-002.html, and smart-paste-003.html to dumpAsText tests.
* editing/pasteboard/smart-paste-001-expected.txt: Added.
* editing/pasteboard/smart-paste-001.html:
* editing/pasteboard/smart-paste-002-expected.txt: Added.
* editing/pasteboard/smart-paste-002.html:
* editing/pasteboard/smart-paste-003-expected.txt: Added.
* editing/pasteboard/smart-paste-003.html:
* platform/chromium-linux/editing/pasteboard/smart-paste-001-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-002-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-001-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-003-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-001-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-002-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-002-expected.txt: Removed.
* platform/gtk/editing/pasteboard/smart-paste-003-expected.png: Removed.
* platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-001-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-001-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-002-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-002-expected.txt: Removed.
* platform/mac/editing/pasteboard/smart-paste-003-expected.png: Removed.
* platform/mac/editing/pasteboard/smart-paste-003-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-002-expected.png: Removed.
* platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Removed.
* platform/qt/editing/pasteboard/smart-paste-003-expected.png: Removed.
* platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 27 May 2011 11:36:02 +0000 (11:36 +0000)]
2011-05-27 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r87467.
* page/wince/FrameWinCE.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 11:22:55 +0000 (11:22 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert editing/pasteboard/paste-unrendered-select.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61616
Converted paste-unrendered-select.html to a dump-as-markup test.
* editing/pasteboard/paste-unrendered-select-expected.txt: Added.
* editing/pasteboard/paste-unrendered-select.html:
* platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 11:16:52 +0000 (11:16 +0000)]
2011-05-27 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397
* platform/chromium/test_expectations.txt:
2011-05-27 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397
* features.gypi:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 27 May 2011 10:54:40 +0000 (10:54 +0000)]
2011-05-26 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=61517
Support cursors where the direction is set to NEXT_NO_DUPLICATE,
or PREV_NO_DUPLICATE, as specified here:
http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE
This is tested by storage/indexeddb/mozilla/indexes.html
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 27 May 2011 10:37:23 +0000 (10:37 +0000)]
2011-05-26 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
LevelDB: turn on paranoid checks and verify checksums, log errors
https://bugs.webkit.org/show_bug.cgi?id=61516
This allows for detection of corrupted databases.
Even if we can't recover from a corrupted database, discovering the
problem is a step in the right direction.
No new functionality, no new tests.
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::put):
(WebCore::LevelDBDatabase::remove):
(WebCore::LevelDBDatabase::get):
(WebCore::LevelDBDatabase::write):
(WebCore::IteratorImpl::checkStatus):
(WebCore::IteratorImpl::seekToLast):
(WebCore::IteratorImpl::seek):
(WebCore::IteratorImpl::next):
(WebCore::IteratorImpl::prev):
(WebCore::LevelDBDatabase::createIterator):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 10:16:40 +0000 (10:16 +0000)]
[Chromium] Unreviewed, mark fast/canvas/webgl/uniform-location.html as timing out
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 09:11:30 +0000 (09:11 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61614
Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.
* editing/pasteboard/paste-text-002-expected.txt: Added.
* editing/pasteboard/paste-text-002.html:
* editing/pasteboard/paste-text-003-expected.txt: Added.
* editing/pasteboard/paste-text-003.html:
* platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 08:26:49 +0000 (08:26 +0000)]
2011-05-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
CachedResourceLoader stores data: urls in validated URL set
https://bugs.webkit.org/show_bug.cgi?id=61604
CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 08:01:49 +0000 (08:01 +0000)]
[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 07:56:25 +0000 (07:56 +0000)]
2011-05-23 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] DocumentMarker should be carried around as a pointer, not value.
https://bugs.webkit.org/show_bug.cgi?id=61262
- Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
- Introduced markersFor() that returns Vector<DocumentMarker*>
- Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by
RenderedDocumentMarker::setRenderedRect().
- This change didn't remove markersForNode() beucase there is patches on review which depends
markersForNode(). I'll remove its call after these patches are landed.
No new tests. No behavior change.
* WebCore.exp.in:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::markersFor):
(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::hasMarkers):
* dom/DocumentMarkerController.h:
* dom/RenderedDocumentMarker.h:
(WebCore::toRenderedDocumentMarker):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasMarkerFor):
* editing/SpellingCorrectionController.cpp:
(WebCore::markersHaveIdenticalDescription):
(WebCore::SpellingCorrectionController::respondToChangedSelection):
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::shouldStartTimerFor):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
* rendering/InlineTextBox.h:
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 07:54:44 +0000 (07:54 +0000)]
[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 07:45:34 +0000 (07:45 +0000)]
[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 07:26:34 +0000 (07:26 +0000)]
2011-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebCore::HTMLSummaryElement::isMainSummary crashes
https://bugs.webkit.org/show_bug.cgi?id=61511
* fast/html/details-summary-document-child-expected.txt: Added.
* fast/html/details-summary-document-child.html: Added.
2011-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511
Removed Unnecessary wrong cast to Elmement, which can be non-Element.
Test: fast/html/details-summary-document-child.html
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::detailsElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 May 2011 06:54:19 +0000 (06:54 +0000)]
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Ryosuke Niwa.
FrameLoader cannot be null
https://bugs.webkit.org/show_bug.cgi?id=61609
This code has a bunch of cargo-cult null checking.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createRenderer):
(WebCore::HTMLMediaElement::attach):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::getPluginProxyParams):
(WebCore::HTMLMediaElement::createMediaPlayerProxy):
(WebCore::HTMLMediaElement::updateWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:43:29 +0000 (06:43 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/paste-blockquote-1.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61608
Converted paste-blockquote-1.html to a dump-as-markup test.
* editing/pasteboard/paste-blockquote-1-expected.txt: Added.
* editing/pasteboard/paste-blockquote-1.html:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:42:19 +0000 (06:42 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/merge-end-*.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61607
* editing/pasteboard/merge-end-1-expected.txt: Added.
* editing/pasteboard/merge-end-1.html:
* editing/pasteboard/merge-end-2-expected.txt: Added.
* editing/pasteboard/merge-end-2.html:
* editing/pasteboard/merge-end-3-expected.txt: Added.
* editing/pasteboard/merge-end-3.html:
* editing/pasteboard/merge-end-4-expected.txt: Added.
* editing/pasteboard/merge-end-4.html:
* editing/pasteboard/merge-end-5-expected.txt: Added.
* editing/pasteboard/merge-end-5.html:
* platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-5-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:40:43 +0000 (06:40 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/interchange-newline-*.html to dump-as-markup tests.
https://bugs.webkit.org/show_bug.cgi?id=61605
Converted interchange-newline-1 thorugh 4 to dump-as-markup tests.
Also revised some test descriptions.
* editing/pasteboard/interchange-newline-1-expected.txt: Added.
* editing/pasteboard/interchange-newline-1.html:
* editing/pasteboard/interchange-newline-2-expected.txt: Added.
* editing/pasteboard/interchange-newline-2.html:
* editing/pasteboard/interchange-newline-3-expected.txt: Added.
* editing/pasteboard/interchange-newline-3.html:
* editing/pasteboard/interchange-newline-4-expected.txt: Added.
* editing/pasteboard/interchange-newline-4.html:
* platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 06:28:40 +0000 (06:28 +0000)]
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
* transforms/2d/set-transform-and-top-expected.txt: Added.
* transforms/2d/set-transform-and-top.html: Added.
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
When a transform is modified in a style, we were upgrading our understanding
of the difference from PositionedMovementOnly to SimplifiedLayout. However,
if the position of the style is independently changed at the same time, both
PositionedMovement and SimplifiedLayout passes are required.
Test: transforms/2d/set-transform-and-top.html
* rendering/RenderObject.cpp:
Added checks for SimplifiedLayoutAndPositionedMovement - when encountered,
set both PositionedMovement and SimplifiedLayout update flasgs.
* rendering/style/RenderStyleConstants.h:
Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for
cases when both PositionedMovement and SimplifiedLayout are required.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 06:26:57 +0000 (06:26 +0000)]
2011-05-26 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61589
No new tests as no new functionality added.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add handlers for:
CSSPropertyWebkitMarginBeforeCollapse
CSSPropertyWebkitMarginAfterCollapse
CSSPropertyWebkitMarginTopCollapse
CSSPropertyWebkitMarginBottomCollapse
CSSPropertyWebkitMarginCollapse
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove cases that are no longer required.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 May 2011 06:12:45 +0000 (06:12 +0000)]
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015
Test various cases involving CORS requests and canvas tainting.
* http/tests/security/canvas-remote-read-remote-image-allowed-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed.html: Added.
* http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html: Added.
* http/tests/security/resources/abe-allow-credentials.php: Added.
* http/tests/security/resources/abe-allow-star.php: Added.
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015
This patch add support for the crossorigin attribute of images and
teaches 2D canvas to respect that flag and not taint a canvas if the
image drawn on the canvas is allowed by CORS.
While I was editing this code, I couldn't resist a couple touch-up
changes.
Tests: http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html
http/tests/security/canvas-remote-read-remote-image-allowed.html
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html
* html/HTMLAttributeNames.in:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::securityOrigin):
* html/HTMLCanvasElement.h:
* html/HTMLImageElement.idl:
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::checkOrigin):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::passesAccessControlCheck):
* loader/cache/CachedResource.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:33:49 +0000 (05:33 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/4700297.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61595
Renamed 4700297.html to insert-div-text-into-text.html and converted it into a dump-as-markup test.
* editing/pasteboard/4700297.html: Removed.
* editing/pasteboard/insert-div-text-into-text-expected.txt: Added.
* editing/pasteboard/insert-div-text-into-text.html: Copied from LayoutTests/editing/pasteboard/4700297.html.
* platform/chromium-linux/editing/pasteboard/4700297-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4700297-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4700297-expected.txt: Removed.
* platform/gtk/editing/pasteboard/4700297-expected.png: Removed.
* platform/gtk/editing/pasteboard/4700297-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/4700297-expected.png: Removed.
* platform/mac/editing/pasteboard/4700297-expected.png: Removed.
* platform/mac/editing/pasteboard/4700297-expected.txt: Removed.
* platform/qt/editing/pasteboard/4700297-expected.png: Removed.
* platform/qt/editing/pasteboard/4700297-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:31:57 +0000 (05:31 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Hajime Morita.
editing/pasteboard/5483567.html should be renamed and converted to a dump-as-markup test.
https://bugs.webkit.org/show_bug.cgi?id=61599
Renamed 5483567.html to pasting-word-in-div-extra-line.html and converted it to
a dump-as-markup test.
* editing/pasteboard/5483567.html: Removed.
* editing/pasteboard/pasting-word-in-div-extra-line-expected.txt: Added.
* editing/pasteboard/pasting-word-in-div-extra-line.html: Copied from
LayoutTests/editing/pasteboard/5483567.html.
* platform/chromium-linux/editing/pasteboard/5483567-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5483567-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5483567-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5483567-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5483567-expected.png: Removed.
* platform/mac/editing/pasteboard/5483567-expected.png: Removed.
* platform/mac/editing/pasteboard/5483567-expected.txt: Removed.
* platform/qt/editing/pasteboard/5483567-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:29:57 +0000 (05:29 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61597
Renamed 5089327.html to paste-into-blockquote-with-document-font-color.html and converted it
to a dump-as-markup test.
* editing/pasteboard/5089327.html: Removed.
* editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt: Added.
* editing/pasteboard/paste-into-blockquote-with-document-font-color.html: Copied from
LayoutTests/editing/pasteboard/5089327.html.
* platform/chromium-linux/editing/pasteboard/5089327-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5089327-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5089327-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5089327-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5089327-expected.png: Removed.
* platform/mac/editing/pasteboard/5089327-expected.png: Removed.
* platform/mac/editing/pasteboard/5089327-expected.txt: Removed.
* platform/qt/editing/pasteboard/5089327-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 27 May 2011 05:29:45 +0000 (05:29 +0000)]
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* bindings/v8/ScriptController.h:
* bindings/v8/V8Proxy.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
* page/SecurityOrigin.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
* src/WebFrameImpl.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:27:50 +0000 (05:27 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/5027857.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61602
Renamed 5027857.html to paste-code-in-pre.html and converted it to a dump-as-markup test.
* editing/pasteboard/5027857.html: Removed.
* editing/pasteboard/paste-code-in-pre-expected.txt: Added.
* editing/pasteboard/paste-code-in-pre.html: Copied from LayoutTests/editing/pasteboard/5027857.html.
* platform/chromium-linux/editing/pasteboard/5027857-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5027857-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5027857-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Added.
* platform/gtk/editing/pasteboard/5027857-expected.png: Removed.
* platform/gtk/editing/pasteboard/5027857-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5027857-expected.png: Removed.
* platform/mac/editing/pasteboard/5027857-expected.png: Removed.
* platform/mac/editing/pasteboard/5027857-expected.txt: Removed.
* platform/qt/editing/pasteboard/5027857-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Fri, 27 May 2011 04:53:46 +0000 (04:53 +0000)]
2011-05-26 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Replace RenderLayer::x/y/width/height with location/size
https://bugs.webkit.org/show_bug.cgi?id=61414
Covered by existing tests.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computeRelativePosition):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(WebCore::RenderBox::maxLayoutOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::location):
(WebCore::RenderLayer::setSize):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeLayers):
(WebCore::externalRepresentation):
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::absoluteQuads):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 04:18:25 +0000 (04:18 +0000)]
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148
Add a test for the case given in the bug: deleting an unstyled table
should not leave behind a style span.
Rebaseline tests now that border-collapse, -webkit-border-horizontal-spacing,
and -webkit-border-vertical-spacing style spans are no longer added on
table and table cell deletion, and no longer applied when copying to the
clipboard.
* editing/deleting/5026848-2-expected.txt:
* editing/deleting/5026848-3-expected.txt:
* editing/deleting/5032066-expected.txt:
* editing/deleting/5115601-expected.txt:
* editing/deleting/5206311-2-expected.txt:
* editing/deleting/delete-block-table-expected.txt:
* editing/deleting/delete-last-char-in-table-expected.txt: Added.
* editing/deleting/delete-last-char-in-table.html: Added. New test for bug.
* editing/deleting/delete-select-all-001-expected.txt:
* editing/pasteboard/data-transfer-items-expected.txt:
* editing/pasteboard/onpaste-text-html-expected.txt:
* editing/selection/4895428-1-expected.txt:
* editing/selection/4895428-4-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148
Removes border-collapse, -webkit-border-horizontal-spacing, and
-webkit-border-vertical-spacing from the list of properties which
should be preserved during edit operations. Also renames this
list to editingInheritableProperties to be more clear about what
the list is for.
Test: editing/deleting/delete-last-char-in-table.html
* editing/EditingStyle.cpp: Removes border vertical/horizontal
spacing from editingStyleProperties.
* editing/EditingStyle.h: Renames OnlyInheritableProperties to
OnlyEditingInheritableProperties.
* editing/markup.cpp: Renames InheritablePropertiesAndBackgroundColorInEffect.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 04:14:46 +0000 (04:14 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
editing/pasteboard/style-from-rules.html is flaky on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=61586
Don't attach an event listener to dump markup on paste when ran by DRT
because we manually dump markup in DRT.
* editing/pasteboard/style-from-rules.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 27 May 2011 03:24:02 +0000 (03:24 +0000)]
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
* http/tests/websocket/tests/client-close-expected.txt: Added.
* http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
* http/tests/websocket/tests/client-close_wsh.py: Added.
* http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
* http/tests/websocket/tests/close-event-expected.txt:
* http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
* http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
* http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket
waits for a close frame to arrive and this test will time out.
* http/tests/websocket/tests/server-close-expected.txt: Added.
* http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
* http/tests/websocket/tests/server-close_wsh.py: Added.
* http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.
Tests: http/tests/websocket/tests/client-close.html
http/tests/websocket/tests/server-close.html
* platform/network/SocketStreamHandleBase.cpp:
(WebCore::SocketStreamHandleBase::send):
Do not send a message if we are in Closing state.
(WebCore::SocketStreamHandleBase::close):
Do not disconnect if we have pending data which have not been sent yet.
In this case, the actual disconnection will happen in sendPendingData().
(WebCore::SocketStreamHandleBase::disconnect):
Renamed from close(). Disconnect the connection immediately.
(WebCore::SocketStreamHandleBase::sendPendingData):
* platform/network/SocketStreamHandleBase.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
to didClose().
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
Fail if close() is attempted before the connection is established.
Otherwise, set the state to CLOSING and start the closing handshake.
(WebCore::WebSocket::bufferedAmount):
If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
We need to invoke message event in CLOSING state as well as OPEN state.
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::close):
Start the closing handshake.
(WebCore::WebSocketChannel::disconnect):
Disconnect the socket stream, instead of close.
(WebCore::WebSocketChannel::didClose):
(WebCore::WebSocketChannel::didReceiveData): Ditto.
(WebCore::WebSocketChannel::didFail): Ditto.
(WebCore::WebSocketChannel::processBuffer):
Ditto.
Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
(WebCore::WebSocketChannel::startClosingHandshake):
Send 0xFF 0x00 byte sequence.
(WebCore::WebSocketChannel::closingTimerFired):
Disconnect the socket stream if the closing handshake has timed out.
* websockets/WebSocketChannel.h:
m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
specification).
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
(WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
* websockets/WorkerThreadableWebSocketChannel.cpp:
Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::workerContextDidStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
* Scripts/webkitpy/thirdparty/__init__.py:
Pull in pywebsocket 0.6b1. We need to update pywebsocket
to get the right behavior of closing handshake.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 02:22:41 +0000 (02:22 +0000)]
2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Dmitry Titov.
Add missing compile guards for WebWorkers in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=61536
* src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/PlatformBridge.cpp:
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
* src/WorkerAsyncFileSystemChromium.cpp:
* src/WorkerAsyncFileSystemChromium.h:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerAsyncFileWriterChromium.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
* src/WorkerFileWriterCallbacksBridge.cpp:
* src/WorkerFileWriterCallbacksBridge.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 27 May 2011 02:16:21 +0000 (02:16 +0000)]
2011-05-26 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
WebKit's font notification has problems when the WebKit main thread != UI thread.
https://bugs.webkit.org/show_bug.cgi?id=61391
This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
some time to write correctly. In the meantime, this issues happens to be causing
some crashes in Chrome so here's the fix alone for the time being.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread.
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation.
Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically,
there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code.
(WebCore::fontCacheATSNotificationCallback): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 02:07:09 +0000 (02:07 +0000)]
2011-05-26 MORITA Hajime <morrita@google.com>
Unreviewed expectations update for <details>.
* platform/chromium-linux-x86/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-linux/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-linux/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-win/fast/html/details-nested-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-win/fast/html/details-nested-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.txt:
* platform/chromium-win/fast/html/details-no-summary2-expected.txt:
* platform/chromium-win/fast/html/details-no-summary3-expected.txt:
* platform/chromium-win/fast/html/details-no-summary4-expected.txt:
* platform/chromium-win/fast/html/details-open-javascript-expected.txt:
* platform/chromium-win/fast/html/details-open1-expected.txt:
* platform/chromium-win/fast/html/details-open2-expected.txt:
* platform/chromium-win/fast/html/details-open3-expected.txt:
* platform/chromium-win/fast/html/details-open4-expected.txt:
* platform/chromium-win/fast/html/details-open5-expected.txt:
* platform/chromium-win/fast/html/details-open6-expected.txt:
* platform/chromium-win/fast/html/details-position-expected.txt:
* platform/chromium-win/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-win/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-win/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-win/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 27 May 2011 01:36:54 +0000 (01:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Roll back in now that the Crashes are fixed. ResourceResponseBase and ResourceResponse had two different definitions
for m_isNull. ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse.
ResourceResponseBase treats m_isNull as meaning no fields have been initialized. Consolidate calls into ResourceResponseBase meaning.
Reviewed by Geoff Garen.
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
No new functionality so no new tests.
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Fri, 27 May 2011 01:16:57 +0000 (01:16 +0000)]
2011-05-26 James Kozianski <koz@chromium.org>
Reviewed by Eric Seidel.
Implement a whitelist for registerProtocolHandler.
Described in the thread here
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-April/031220.html
https://bugs.webkit.org/show_bug.cgi?id=60322
* fast/dom/register-protocol-handler.html:
2011-05-26 James Kozianski <koz@chromium.org>
Reviewed by Eric Seidel.
Implement a whitelist for registerProtocolHandler
https://bugs.webkit.org/show_bug.cgi?id=60322
* page/Navigator.cpp:
(WebCore::initProtocolHandlerWhitelist):
(WebCore::isProtocolWhitelisted):
(WebCore::verifyProtocolHandlerScheme):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 27 May 2011 01:12:21 +0000 (01:12 +0000)]
Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492
Reviewed by Darin Adler.
The method for determining which WebPage is actually focused and foreground was faulty. More
extensive checks are required to check which WebPage should be returned as the focusable one.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowIsFocused):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 27 May 2011 01:00:59 +0000 (01:00 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Remove some passing tests from the test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Fri, 27 May 2011 00:29:40 +0000 (00:29 +0000)]
2011-05-26 Jon Lee <jonlee@apple.com>
Reviewed by Darin Adler.
REGRESSION (5.0.5-Jazz): Transition to full screen video animates in wrong location when scrolled (61559)
https://bugs.webkit.org/show_bug.cgi?id=61559
<rdar://problem/9496054>
The CALayer that gets animated has a position that is offset by the scroll position of the web view. To
fix this, we set the destination location based on the rect of the full screen, and add a position
animation which keeps the position of the layer centered. This prevents glitches if others
are trying to change the layer position while the animation is running.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Refactor the calculation of the CALayer windowed
position into a private helper function, as well as the animation setup.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::animateFullScreen): Sets up the zoom animation, and the position offset
animation.
(WebKit::WebFullScreenManagerMac::windowedCGTransform): Calculates the placement of the windowed layer
in screen coordinates.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 27 May 2011 00:18:32 +0000 (00:18 +0000)]
2011-05-26 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] simplify TestNetscapePlugIn naming logic
https://bugs.webkit.org/show_bug.cgi?id=61577
* WebKit.gyp: drop use of product_prefix, just use the name
needed directly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 00:08:09 +0000 (00:08 +0000)]
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
[debug feature] CSSStyleDeclaration should have a way to print cssText
https://bugs.webkit.org/show_bug.cgi?id=61570
Adds a method to print the cssText to stderr for debugging.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::showStyle): New method to print cssText to stderr
* css/CSSStyleDeclaration.h: New method declaration
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Fri, 27 May 2011 00:00:42 +0000 (00:00 +0000)]
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAuthorAndUserStylesEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAuthorAndUserStylesEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 23:58:38 +0000 (23:58 +0000)]
2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377
LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
For an array of active uniform, we should be careful while truncating the name of the uniform.
Currently we are truncating the last three characters of an array with out checking for [0].
As a result we are truncating the the actual name of the active uniforms i.e. color to co.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 23:47:40 +0000 (23:47 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed heapRootMarker to heapRootVisitor to match its class name
https://bugs.webkit.org/show_bug.cgi?id=61584
* heap/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 23:47:32 +0000 (23:47 +0000)]
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582
Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
* page/FrameView.h:
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582
Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).
* public/WebFrameClient.h:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc