Matthew Barnes [Mon, 13 Jun 2011 16:08:09 +0000 (12:08 -0400)]
NEWS update for 3.1.2 release.
Matthew Barnes [Mon, 13 Jun 2011 14:24:19 +0000 (10:24 -0400)]
Coding style and whitespace cleanups.
Chenthill Palanisamy [Mon, 13 Jun 2011 10:50:44 +0000 (16:20 +0530)]
EBookBackendSqliteDB, e-sqlite3-vfs.[ch]: Add sqlitedb cache for addressbook. It can
be used as summary+cache.
Matthew Barnes [Sat, 11 Jun 2011 18:54:50 +0000 (14:54 -0400)]
CamelImapStore: Remove unused declarations.
Matthew Barnes [Fri, 10 Jun 2011 14:36:24 +0000 (10:36 -0400)]
CamelIMAPXFolder: Fix handling of "filter_junk" option.
Looks like a typo. Just stumbled on this by accident, but I wonder
if it has something to do with certain junk filtering bugs I've seen
reported by IMAPX users.
Alexander Larsson [Fri, 10 Jun 2011 12:41:46 +0000 (14:41 +0200)]
Fixup markup of e_vcard_attribute_add_param (takes ownership of param)
Alexander Larsson [Fri, 10 Jun 2011 10:10:49 +0000 (12:10 +0200)]
Annotate e_vcard_attribute_new (group name may be null)
Alexander Larsson [Fri, 10 Jun 2011 10:10:01 +0000 (12:10 +0200)]
Use the right free function in the boxed type for EVCardAttributeParam
We were using e_vcard_attribute_free, not e_vcard_attribute_param_free
Abduxukur Abdurixit [Fri, 10 Jun 2011 07:54:04 +0000 (09:54 +0200)]
Added UG translation
Kjartan Maraas [Thu, 9 Jun 2011 10:44:33 +0000 (12:44 +0200)]
Updated Norwegian bokmål translation
Chenthill Palanisamy [Tue, 7 Jun 2011 12:50:35 +0000 (18:20 +0530)]
CamelVeeFolder: Check for the presence of unmatched folder before
accessing full_name, error in previous commit.
Chenthill Palanisamy [Tue, 7 Jun 2011 10:51:25 +0000 (16:21 +0530)]
CamelVeeFolder: Adapt changes to unmatched_check_uid that was missed in commit -
6bc75c47f516301364d653140fcf82193d0a2d52 .
Chenthill Palanisamy [Tue, 7 Jun 2011 10:35:51 +0000 (16:05 +0530)]
CamelVeeFolder: Fix a hang in folder_change_change. do not read db in between a transaction
Patrick Ohly [Tue, 17 May 2011 07:45:24 +0000 (09:45 +0200)]
calendar: include rid in "objects-removed" ECalView signal
Since migration to D-Bus for libecal<->EDS communication, the
RECURRENCE-ID (rid) has not been sent in the "objects-removed" signal.
As a result, a backend could not communicate the removal of specific
recurrences.
This patch adds the rid after a newline to the string stored
internally and transferred via D-Bus. Because the newline is only
added when needed, traditional uid-only removals look the same as
before and continue to work with older versions of libecal. A uid+rid
combination will look like an unknown uid to an older libecal which
does not know how to split them. Therefore the D-Bus API is considered
unchanged and the interface number is not increased.
Whether clients really interpret "objects-removed" with empty rid (=
parent removed) or valid rid (= child removed) correctly is outside
the scope of this patch.
Patrick Ohly [Thu, 12 May 2011 12:04:37 +0000 (14:04 +0200)]
calendar file backend: support remove with CALOBJ_MOD_ONLY_THIS
Support for this capability is easy:
- report removal of the detached recurrence
- report error when not found
- avoid modifying the parent (= full_object)
Patrick Ohly [Thu, 12 May 2011 11:30:06 +0000 (13:30 +0200)]
calendar file backend: removal notification for detached recurrence, part 2
e_cal_remove_object_with_mod() can only return one pair of old/new
object pointers to the caller. When the function modifies the parent
and removes a detached recurrence, the removal of the detached
recurrence had to be deduced by clients from the modification of the
parent.
Now clients are explicitly informed about removal of the detached
recurrence in addition to the modification of the parent.
Patrick Ohly [Thu, 12 May 2011 09:05:59 +0000 (11:05 +0200)]
calendar file backend: removal notification for detached recurrence, part 1
If e_cal_remove_object_with_mod() was called for an appointment where
only a detached recurrence existed, no "objects-removed" signal was
triggered although it should have been.
Apparently Evolution avoids the problem by calling
e_cal_remove_component() instead in this case. Fixing the problem
makes writing clients easier (no special cases).
With this patch, remove_instance() itself decides what it reports back
to the caller. Note that it cannot report back both a modification and
a removal at the moment.
Patrick Ohly [Thu, 12 May 2011 07:48:37 +0000 (09:48 +0200)]
calendar file backend: white list check for supported CalObjModType
Explicitly check that the CalObjModType is supported before
starting to work on the appointment. Relies in libecal to reject
completely bogus modes with an "invalid parameter" error.
Patrick Ohly [Thu, 12 May 2011 07:36:59 +0000 (09:36 +0200)]
libecal: catch invalid CalObjModType values
This protects backends without their own parameter checking
from being invoked with invalid CalObjModType values. Note
that this only excludes values that haven't been defined.
Backends still need to check whether they support the
selected mode.
Patrick Ohly [Thu, 12 May 2011 07:29:16 +0000 (09:29 +0200)]
libecal: added CALOBJ_MOD_ONLY_THIS
The goal is to have an orthogonal API where each operation also
has an inverse operation. Adding a detached recurrence was
possible with e_cal_modify_object(), but removing it again
wasn't without modifying the parent appointment.
CALOBJ_MOD_ONLY_THIS in e_cal_remove_object_with_mod() provides
that inverse operation by avoiding the modifications to the
parent.
The semantic in e_cal_modify_object(), the other call taking a
CalObjModType, is unchanged. CALOBJ_MOD_ONLY_THIS is not valid there.
Because not all backends reject CALOBJ_MOD_ONLY_THIS when they don't
support it, a static capability CAL_STATIC_CAPABILITY_REMOVE_ONLY_THIS
is added that must be checked first before using CALOBJ_MOD_ONLY_THIS.
Patrick Ohly [Wed, 11 May 2011 14:59:51 +0000 (16:59 +0200)]
calendar file backend: support removing parent event with CALOBJ_MOD_THIS
It was possible to create a meeting series with just a detached event
(RECURRENCE-ID set) by importing a meeting invitation for that single
recurrence. It was not possible to arrive at that same state after
adding the parent event (the one with the RRULE) because
e_cal_remove_object_with_mod() removed all instances for
CALOBJ_MOD_THIS and empty rid.
This contradicts the intended semantic of e_cal_remove_object_with_mod():
"By using a combination of the @uid, @rid and @mod
arguments, you can remove specific instances. If what you want
is to remove all instances, use e_cal_remove_object instead."
This patch implements the desired semantic:
- e_cal_backend_file_remove_object(CALOBJ_MOD_THIS) now always
calls remove_instance().
- remove_instance() was extended to also work for the parent
event.
- That call removes the complete object if nothing is left
after removing the instance. This case must be handled by
the caller. The return value is the original object (if
it still exists) and NULL if not.
- Because the uid pointer into the object may become invalid
as part of the removal, a more permanent pointer has to
be provided by the caller.
Kjartan Maraas [Tue, 7 Jun 2011 09:04:59 +0000 (11:04 +0200)]
Updated Norwegian bokmål translation
Christophe Dumez [Mon, 6 Jun 2011 13:48:42 +0000 (16:48 +0300)]
e_book_backend_file_get_contact_list: Fix memory leak
vcard_dbt.data should be freed if it is not appended to
the contact list otherwise memory gets leaked.
Christophe Dumez [Mon, 6 Jun 2011 13:55:04 +0000 (16:55 +0300)]
e_contact_name_from_string(): Fix possible memory leak
The 'name' variable memory was leaked when name_str
is NULL.
Milan Crha [Mon, 6 Jun 2011 13:16:27 +0000 (15:16 +0200)]
Fix few memory leaks
Christophe Dumez [Mon, 30 May 2011 11:43:14 +0000 (14:43 +0300)]
e_dbhash_new: Close and reopen db handle to avoid memory leak
According to the documentation, "If DB->open fails,
the DB->close method should be called to discard the DB
handle". The current code was calling open() again on
the same handle without closing it it first, possibly
causing memory leaks.
This patch is adapted from commit
37d3c0f65c989afe9ffc2d734d86b2ae0019edae in eds-fremantle GIT
repository.
Christophe Dumez [Mon, 30 May 2011 07:40:55 +0000 (10:40 +0300)]
e_name_western_reorder_asshole: Fix possible memory leak
Free 'prefix' variable on early return.
Raul Gutierrez Segales [Sun, 5 Jun 2011 18:02:46 +0000 (19:02 +0100)]
Add constructor for EContactAddress
Needed by introspected bindings.
Raul Gutierrez Segales [Sat, 4 Jun 2011 11:02:06 +0000 (12:02 +0100)]
Add constructor for EContactPhoto
This is needed by introspected bindings, otherwise they have
no way to instantiate EContactPhotos.
Matthew Barnes [Mon, 6 Jun 2011 03:02:34 +0000 (22:02 -0500)]
Limit libgdata to 0.7 or 0.8.
There are unreleased API changes beyond 0.8 which we don't support yet.
Fran Diéguez [Sun, 5 Jun 2011 21:19:35 +0000 (23:19 +0200)]
Updated Galician translations
Jorge González [Sat, 4 Jun 2011 11:24:49 +0000 (13:24 +0200)]
Updated Spanish translation
Daniel Mustieles [Sat, 4 Jun 2011 11:19:33 +0000 (13:19 +0200)]
Updated Spanish translation
Raul Gutierrez Segales [Mon, 30 May 2011 10:24:17 +0000 (11:24 +0100)]
Bug #651458 - Add getters/settrs for EContactPhoto
This is needed for introspected bindings since gobject-introspection
can't cope with the current layout of the EContactPhoto structure.
Milan Crha [Fri, 3 Jun 2011 14:21:49 +0000 (16:21 +0200)]
Workaround compiler warnings
Mathieu Trudel-Lapierre [Fri, 3 Jun 2011 13:10:27 +0000 (15:10 +0200)]
Bug #633948 - Try harder to use -lresolv in LDAP_LIBS
Christophe Dumez [Fri, 3 Jun 2011 09:33:49 +0000 (11:33 +0200)]
Bug #651226 - e_book_new_system_addressbook() should create source in GConf
The same problem was fixed in libecal by commit
3bb75464a67
and commit
05c0b7b4bd0.
Milan Crha [Fri, 3 Jun 2011 09:08:47 +0000 (11:08 +0200)]
Bug #649757 - Filtering based on a source account always succeeded
Milan Crha [Thu, 2 Jun 2011 07:30:10 +0000 (09:30 +0200)]
Bug #640083 - Force secured connection when using LDAPS port
Milan Crha [Wed, 1 Jun 2011 21:07:41 +0000 (23:07 +0200)]
Bug #649757 - Return back camel_filter_driver_filter_mbox()
It's still used for "Local delivery" mbox files and it has nothing
to do with On This Computer store type.
Milan Crha [Wed, 1 Jun 2011 11:33:04 +0000 (13:33 +0200)]
Fix a typo in the code, do not call itself recursively
Matthew Barnes [Wed, 1 Jun 2011 10:12:43 +0000 (06:12 -0400)]
Fix build breaks.
Milan Crha [Wed, 1 Jun 2011 05:34:17 +0000 (07:34 +0200)]
Bug #651147 - EBook/ECal done signals ignored due to wrong name
Milan Crha [Wed, 1 Jun 2011 05:22:14 +0000 (07:22 +0200)]
Replace deprecated g_atomic_int_exchange_and_add()
Milan Crha [Tue, 31 May 2011 16:10:49 +0000 (18:10 +0200)]
Bug #651446 - Implement e_book_client_get_contacts_uids()
Matthew Barnes [Sun, 29 May 2011 22:43:45 +0000 (18:43 -0400)]
Oops, little Freudian slip there in the comment.
Matthew Barnes [Sun, 29 May 2011 22:34:49 +0000 (18:34 -0400)]
CamelVeeFolder: Fix a deadlock.
folder_added_uid() was trying to obtain a reader lock while holding a
writer lock, since a DB transaction had already been started.
To work around the issue, queue up message UIDs in folder_added_uid(),
and then execute a DB transaction using the queued message UIDs AFTER
we're done iterating over the 'matchhash' hash table.
Matthew Barnes [Sun, 29 May 2011 21:07:09 +0000 (17:07 -0400)]
camel_store_get_folder_sync(): Readability cleanups.
Raul Gutierrez Segales [Sun, 29 May 2011 21:25:01 +0000 (22:25 +0100)]
Introspection: fix annotation in e_book_client_get_contact_finish
Raul Gutierrez Segales [Sun, 29 May 2011 21:20:43 +0000 (22:20 +0100)]
Introspection: fix annotation in e_book_client_get_contact_sync
Raul Gutierrez Segales [Sun, 29 May 2011 14:29:35 +0000 (15:29 +0100)]
Vala bindings: use e-book-client.h instead of e-book.h
Raul Gutierrez Segales [Sun, 29 May 2011 14:14:58 +0000 (15:14 +0100)]
Introspection: fix annotation for e_book_client_get_view_finish ()
Raul Gutierrez Segales [Sun, 29 May 2011 13:55:05 +0000 (14:55 +0100)]
Introspection: add missing annotations in libedataserver
Raul Gutierrez Segales [Sun, 29 May 2011 13:54:19 +0000 (14:54 +0100)]
Vala bindings: set the type of the signals emitted by BookClientView
Raul Gutierrez Segales [Sun, 29 May 2011 13:53:49 +0000 (14:53 +0100)]
Vala bindings: include gio-2.0 needed by EDataServer
Raul Gutierrez Segales [Sun, 29 May 2011 12:53:22 +0000 (13:53 +0100)]
Vala bindings: include gio-2.0 needed by EBookClient
Carles Ferrando [Sun, 29 May 2011 12:00:10 +0000 (14:00 +0200)]
[l10n]Updated Catalan (Valencian) translation
Matthew Barnes [Sat, 28 May 2011 15:33:48 +0000 (11:33 -0400)]
Including <glib-object.h> directly is rarely needed.
Matthew Barnes [Sat, 28 May 2011 15:30:07 +0000 (11:30 -0400)]
Including <glib.h> directly is rarely needed.
Raul Gutierrez Segales [Sat, 28 May 2011 13:33:45 +0000 (14:33 +0100)]
Introspection: add missing annotations in libebook
Raul Gutierrez Segales [Sat, 28 May 2011 13:32:40 +0000 (14:32 +0100)]
Vala bindings: include EBookClient and EBookClientView
Christophe Dumez [Fri, 27 May 2011 13:40:06 +0000 (15:40 +0200)]
Bug #651113 - [libebook] Querying date fields is not supported
Christophe Dumez [Fri, 27 May 2011 13:37:35 +0000 (15:37 +0200)]
Bug #651054 - Support queries based on "photo" contact field
Christophe Dumez [Fri, 27 May 2011 13:30:39 +0000 (15:30 +0200)]
Bug #650952 - Remove unknown EContact field name runtime warning
Christophe Dumez [Fri, 27 May 2011 13:27:30 +0000 (15:27 +0200)]
Bug #650950 - entry_compare() should iterate over attributes with the same name
Extend entry_compare() to iterate over attributes that have
the same name (e.g. X-HOBBY) so that it can match any of
them, not just the first one in the vCard.
Matthew Barnes [Fri, 27 May 2011 12:01:18 +0000 (14:01 +0200)]
Bug #648736 - Crash when adding default vcard for newly created DB
Daniel Mustieles [Thu, 26 May 2011 18:05:01 +0000 (20:05 +0200)]
Updated Spanish translation
Matthew Barnes [Thu, 26 May 2011 15:34:28 +0000 (11:34 -0400)]
Automated Gtk-Doc updates from backend API changes.
Matthew Barnes [Thu, 26 May 2011 15:21:37 +0000 (11:21 -0400)]
Reduce diff noise with account-mgmt branch.
Mostly silly code cleanup type stuff, so I can see the important changes
more easily.
Raul Gutierrez Segales [Thu, 26 May 2011 11:50:52 +0000 (12:50 +0100)]
Vala bindings: metadata helpers for EContactAddress
Raul Gutierrez Segales [Thu, 26 May 2011 11:45:47 +0000 (12:45 +0100)]
Vala bindings: metadata helpers for EContactName
Raul Gutierrez Segales [Thu, 26 May 2011 11:34:16 +0000 (12:34 +0100)]
Vala bindings: add path to dependency GIRs
Chenthill Palanisamy [Thu, 26 May 2011 11:31:32 +0000 (17:01 +0530)]
CamelDB: Initiate a transaction before writing into db.
Chenthill Palanisamy [Thu, 26 May 2011 10:26:07 +0000 (15:56 +0530)]
Bug 640054 - CamelDB: do not read the db while a trasaction is in progress.
Fix the dead-lock caused due to transaction (DB WRITE_LOCK) and summary lock.
Chenthill Palanisamy [Thu, 26 May 2011 08:09:30 +0000 (13:39 +0530)]
CamelDB: Ensure that begin_transaction is called before adding queries to a transaction
Chenthill Palanisamy [Thu, 26 May 2011 07:55:32 +0000 (13:25 +0530)]
CamelFolderSummary: Remove undefined function camel_folder_summary_header_load from header file
Chenthill Palanisamy [Thu, 26 May 2011 07:53:49 +0000 (13:23 +0530)]
CamelDB: Use camel_db_select while retrieving the folder version
Chenthill Palanisamy [Wed, 25 May 2011 07:40:53 +0000 (13:10 +0530)]
CamelDB: use a RW lock to prevent reads while write is in progress
Milan Crha [Thu, 26 May 2011 09:11:09 +0000 (11:11 +0200)]
Bug #589495 - Search folder by Size (KB) counts bytes, not KB
Jorge González [Wed, 25 May 2011 20:46:15 +0000 (22:46 +0200)]
Updated Spanish translation
Daniel Mustieles [Wed, 25 May 2011 17:10:46 +0000 (19:10 +0200)]
Updated Spanish translation
Matthew Barnes [Mon, 23 May 2011 16:51:00 +0000 (12:51 -0400)]
camel_store_create_folder_sync(): Add a status message.
Milan Crha [Mon, 23 May 2011 15:59:26 +0000 (17:59 +0200)]
Fix issues reported by intltool-update
Milan Crha [Mon, 23 May 2011 14:49:19 +0000 (16:49 +0200)]
Bug #550414 - Corruption of mailbox and can't expunge trash
The second attempt - be more aggressive with locking
Seán de Búrca [Mon, 23 May 2011 12:07:13 +0000 (06:07 -0600)]
Updated Irish translation.
Seán de Búrca [Mon, 23 May 2011 10:43:15 +0000 (04:43 -0600)]
Remove groupwise files from POTFILES.in
Milan Crha [Mon, 23 May 2011 09:45:20 +0000 (11:45 +0200)]
New EClient/EBookClient/ECalClient API deprecating EBook/ECal
Matthew Barnes [Sun, 22 May 2011 02:59:58 +0000 (22:59 -0400)]
Bug 650524 - Use g_unix_signal_add_watch_full() for SIGTERM
We can't call anything safely except write() inside a signal handler,
g_unix_signal_add_watch_full() handles this for us nicely.
Matthew Barnes [Sun, 22 May 2011 00:54:47 +0000 (20:54 -0400)]
Handle SIGTERM instead of SIGQUIT.
SIGQUIT is supposed to produce a core dump. We don't want that.
Chenthill Palanisamy [Fri, 20 May 2011 10:29:29 +0000 (15:59 +0530)]
IMAPX: optionally download the messages in descending order.
TODO: Add advanced UI options for the same.
Document all the url parameters in a common place.
Raul Gutierrez Segales [Wed, 18 May 2011 22:00:15 +0000 (23:00 +0100)]
Vala bindings: mark metadata file as EXTRA_DIST
Raul Gutierrez Segales [Wed, 18 May 2011 20:08:02 +0000 (21:08 +0100)]
Vala bindings: use metadata to get the correct types for signals
The contacts_{added,removed,changed} signals were specified with
the wrong parameter types (void * instead of GLib.List<void *>) in the
generated VAPI file for libebook.
Raul Gutierrez Segales [Wed, 18 May 2011 20:07:06 +0000 (21:07 +0100)]
libedataserver: break down long lines of the Introspection part
Raul Gutierrez Segales [Wed, 18 May 2011 20:05:43 +0000 (21:05 +0100)]
libebook: add --pkg-export to get a package name in the generated GIR
Raul Gutierrez Segales [Wed, 18 May 2011 18:59:10 +0000 (19:59 +0100)]
libebook: annotate params for e_book_get_{book_view_async,self}
Raul Gutierrez Segales [Wed, 18 May 2011 18:28:37 +0000 (19:28 +0100)]
libebook: annotate more methods
Raul Gutierrez Segales [Wed, 18 May 2011 16:59:48 +0000 (17:59 +0100)]
Vala bindings: add missing case for xml. -> Xml. transformation
Raul Gutierrez Segales [Wed, 18 May 2011 16:43:47 +0000 (17:43 +0100)]
Vala bindings: help vapigen get the correct Xml names
Raul Gutierrez Segales [Wed, 18 May 2011 16:16:06 +0000 (17:16 +0100)]
Add the correct headers to libedataserver's GIR file
Matthew Barnes [Tue, 17 May 2011 14:09:23 +0000 (10:09 -0400)]
CamelService: Add async query_auth_types() functions.
Breaks ABI since sizeof(CamelServiceClass) changes.
I've already bumped the libcamel soname since 3.1.1.