Denis Kenzior [Wed, 7 Jul 2010 20:12:16 +0000 (15:12 -0500)]
stk: Don't submit all pending envelopes at once
Denis Kenzior [Wed, 7 Jul 2010 19:34:38 +0000 (14:34 -0500)]
stk: Fix copy / paste error
Denis Kenzior [Wed, 7 Jul 2010 19:33:32 +0000 (14:33 -0500)]
stk: Get rid of bin to hex converter
That much code for a debug message is pretty silly. Perhaps an
ofono_debug_hexdump function is in order.
Denis Kenzior [Wed, 7 Jul 2010 19:28:11 +0000 (14:28 -0500)]
stk: cancelled variable is not used
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:08 +0000 (00:39 +0200)]
stk: Handle the Timer Management proactive command
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:05 +0000 (00:39 +0200)]
stk: Handle the Set Up Idle Text proactive command
This adds a SimToolkit dbus interface with just one property
(IdleModeText).
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:03 +0000 (00:39 +0200)]
stk: Handle the Send SMS proactive command.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:02 +0000 (00:39 +0200)]
Add __ofono_sms_submit for other atoms to submit SMs.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:07 +0000 (00:39 +0200)]
stkutil: Timer Value is conditional, not optional.
Make the parser check that the value is present when necessary,
so that stk.c doesn't have to check this.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:06 +0000 (00:39 +0200)]
sktutil: Use the Mandatory flag in parse_dataobj.
We need to look at the Mandatory flag and not at the Minimum flag
when parsing CTLVs. The Minimum flag is important when encoding CTLVs
because CR bit is set according to it.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:04 +0000 (00:39 +0200)]
Add Dbus interface names for STK.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:01 +0000 (00:39 +0200)]
stk: Handle ENVELOPEs in a queue, retry on sim busy.
Some envelope types need to be retried when sim reports busy status.
Then envelopes such as Event Download need to be returned in the
order of the event occurences, so need to be handled in a queue.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:39:00 +0000 (00:39 +0200)]
atmodem: Make sim operations return sim error codes.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:38:59 +0000 (00:38 +0200)]
Add OFONO_ERROR_TYPE_SIM for negative SIM statuses
Expected value of the .error field is status word 1 and status word 2
in bits 8:15 and 0:7 of the field.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:38:58 +0000 (00:38 +0200)]
stk: Handle MoreTime command as a no-op
Andrzej Zaborowski [Tue, 6 Jul 2010 22:38:57 +0000 (00:38 +0200)]
mbmmodem: End session on *STKEND.
Andrzej Zaborowski [Tue, 6 Jul 2010 22:38:56 +0000 (00:38 +0200)]
stk: Utilities for proactive command/envelope handling.
Denis Kenzior [Thu, 8 Jul 2010 18:36:42 +0000 (13:36 -0500)]
smsutil: Fix valgrind complaint
SMS cannot be split over GSM extension chars, however on the last
segment this code was causing us to overflow the buffer and resulted in
valgrind complaining.
Denis Kenzior [Thu, 8 Jul 2010 18:36:26 +0000 (13:36 -0500)]
test-sms: Fix a memory leak
Denis Kenzior [Thu, 8 Jul 2010 16:19:13 +0000 (11:19 -0500)]
TODO: Add CDIP support task
Marcel Holtmann [Wed, 7 Jul 2010 20:41:05 +0000 (17:41 -0300)]
Release 0.24
Pekka Pessi [Tue, 6 Jul 2010 17:17:51 +0000 (20:17 +0300)]
TODO: Voicecall gaps
Pekka Pessi [Tue, 6 Jul 2010 17:17:52 +0000 (20:17 +0300)]
doc: clarify VoiceCallManager SendTones method
Zhenhua Zhang [Wed, 7 Jul 2010 01:46:32 +0000 (09:46 +0800)]
gatppp: Unset disconnect function when unref PPP
Unset IO disconnect function when we try to destroy GAtPPP instance.
After freeing the instance, the IO disconnect function should not be
invoked.
Zhenhua Zhang [Wed, 7 Jul 2010 01:46:31 +0000 (09:46 +0800)]
gatserver: Restore GAtServer disconnect handling
Restore GAtServer disconnect handling when resuming a server session
Zhenhua Zhang [Wed, 7 Jul 2010 00:42:23 +0000 (08:42 +0800)]
test-server: Refactor set_raw_mode
Rename variable 'options' to 'ti' and use sizeof(ti).
Zhenhua Zhang [Mon, 5 Jul 2010 02:59:12 +0000 (10:59 +0800)]
gatserver: Don't free twice after user disconnect
It's possible to free gatserver in user disconnect function. So we
should not free it again.
Zhenhua Zhang [Tue, 6 Jul 2010 06:23:06 +0000 (14:23 +0800)]
test-server: Use cfmakeraw to set TTY raw mode
Use cfmakeraw to disable echoing and special characters processing. If
we don't turn off ICRNL, TTY layer translates \r\n to \n\n.
Zhenhua Zhang [Tue, 6 Jul 2010 09:57:37 +0000 (17:57 +0800)]
gatppp: Check ppp instance before unref it
Marcel Holtmann [Mon, 5 Jul 2010 13:25:33 +0000 (10:25 -0300)]
Also add another rule for Pekka to .mailmap
Marcel Holtmann [Mon, 5 Jul 2010 13:23:52 +0000 (10:23 -0300)]
Update .mailmap rules
Marcel Holtmann [Mon, 5 Jul 2010 13:18:25 +0000 (10:18 -0300)]
Add .mailmap file to fix Luiz's name spelling in git shortlog
Inaky Perez-Gonzalez [Fri, 25 Jun 2010 23:15:23 +0000 (16:15 -0700)]
documentation: add note about referencing standards
Andrzej Zaborowski [Wed, 30 Jun 2010 15:24:16 +0000 (17:24 +0200)]
test-stkutil: Fix always true condition.
Denis Kenzior [Fri, 2 Jul 2010 19:50:05 +0000 (14:50 -0500)]
test-stkutil: Fix some memory leaks
Andrzej Zaborowski [Wed, 30 Jun 2010 15:24:15 +0000 (17:24 +0200)]
stkutil: Move scaddr field to gsm_sms
Zhenhua Zhang [Fri, 2 Jul 2010 03:04:34 +0000 (11:04 +0800)]
huawei: Add Huawei EM770 modem support
Huawei EM770W is a 3G WCDMA modem that supports HSPA/UMTS/EDGE/GPRS/GSM
data service and WCDMA/GSM short message services. It also has voice
call capability that supports both 2G and 3G network.
Zhenhua Zhang [Fri, 2 Jul 2010 03:04:33 +0000 (11:04 +0800)]
huawei: Remove existing Huawei EM770 plugin
Denis Kenzior [Tue, 29 Jun 2010 19:44:20 +0000 (14:44 -0500)]
huawei: cleanup warnings from the previous patch
Kalle Valo [Tue, 29 Jun 2010 07:59:37 +0000 (10:59 +0300)]
PPP GPRS context is now done, update documentation
Kalle Valo [Tue, 29 Jun 2010 07:59:31 +0000 (10:59 +0300)]
huawei: reopen the GPRS context on hup
Huawei always closes the tty port after PPP disconnect. Handle this in
huawei plugin, similarly as done with novatel. Now there's no need
to unplug the modem after disconnection.
Tested with Huawei E1552.
Based on a patch by Marcel Holtmann:
commit
0329a6ceaf8f69857cb5f8437b9db86ca327ef1d
Author: Marcel Holtmann <marcel@holtmann.org>
Date: Mon Jun 7 02:36:12 2010 -0700
Reopen the GPRS context channel when the modem closes it after PPP
Andrzej Zaborowski [Tue, 29 Jun 2010 03:00:27 +0000 (05:00 +0200)]
atmodem: Don't unregister *EPEV in *EPEV handler.
Handlers are called when looping over the unsolicited responses hash,
registering or unregistering modifies that hash and confuses glib.
Pekka Pessi [Tue, 29 Jun 2010 11:06:41 +0000 (14:06 +0300)]
mbm: use CPIN? to check if SIM is missing
AT+CRSM=242 is not supported by all mbm models.
Pekka Pessi [Mon, 28 Jun 2010 18:20:12 +0000 (21:20 +0300)]
Documented Present property in sim-api.txt.
Denis Kenzior [Tue, 29 Jun 2010 17:15:44 +0000 (12:15 -0500)]
gsmdial: Wait for a no carrier before sending CFUN
Denis Kenzior [Tue, 29 Jun 2010 17:12:42 +0000 (12:12 -0500)]
test-server: Send a NO_CARRIER when ppp is done
Denis Kenzior [Tue, 29 Jun 2010 17:01:34 +0000 (12:01 -0500)]
test-server: Update to the new API
Denis Kenzior [Tue, 29 Jun 2010 16:55:18 +0000 (11:55 -0500)]
ppp: Don't accept 0 ip-addr/dns1/dns2
Denis Kenzior [Tue, 29 Jun 2010 16:53:11 +0000 (11:53 -0500)]
ppp: Refactor server-side API
The biggest update here is that the server needs to be in dormant mode
by default, so as not to send a Configure-Req to the peer until the peer
is ready. This requires adding special constructor for LCP to
initialize it to Stopped state instead of initial state.
Along with this, we pass the server local IP directly to the ppp server
constructor.
Denis Kenzior [Tue, 29 Jun 2010 16:50:25 +0000 (11:50 -0500)]
test-server: Update to the new API
Denis Kenzior [Tue, 29 Jun 2010 16:49:40 +0000 (11:49 -0500)]
ppp: Tweak set_server_info API some more
Denis Kenzior [Tue, 29 Jun 2010 16:46:40 +0000 (11:46 -0500)]
hdlc: Stop recording packets to stdout (fd = 0)
Denis Kenzior [Tue, 29 Jun 2010 16:46:20 +0000 (11:46 -0500)]
hdlc: Don't bother recording empty packets
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:09 +0000 (11:19 +0800)]
gsmdial: Configure network interface for PPP
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:08 +0000 (11:19 +0800)]
test-server: Configure network interface
Require ROOT priviledge to:
1. Run external command to configure and bring up network interface.
2. Enable kernel IP forwarding.
Denis Kenzior [Mon, 28 Jun 2010 22:38:54 +0000 (17:38 -0500)]
ppp: Tweak the set_server_info API
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:07 +0000 (11:19 +0800)]
test-server: Add PPP server support
So that gsmdial and wvdial could talk to test-server and establish PPP
connection.
Denis Kenzior [Mon, 28 Jun 2010 17:13:24 +0000 (12:13 -0500)]
ppp: Refactor server RCR action
We need to generate the Conf-Rej / Conf-Nak in the same order as the
client sent us.
Denis Kenzior [Mon, 28 Jun 2010 16:16:20 +0000 (11:16 -0500)]
ppp: Refactor client RCR action
Denis Kenzior [Mon, 28 Jun 2010 16:15:44 +0000 (11:15 -0500)]
ppp: Simplify the logic by re-using code
Denis Kenzior [Mon, 28 Jun 2010 15:21:33 +0000 (10:21 -0500)]
ppp: Minor style tweaks
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:05 +0000 (11:19 +0800)]
atmodem: Update to the new PPP API
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:05 +0000 (11:19 +0800)]
gsmdial: Update to the new API
Zhenhua Zhang [Fri, 25 Jun 2010 03:19:05 +0000 (11:19 +0800)]
gatppp: Add PPP server extension
1. Add interface to set PPP server info by g_at_ppp_set_server_info.
2. Pass local and peer address through IPCP handshaking.
Denis Kenzior [Fri, 25 Jun 2010 22:53:12 +0000 (17:53 -0500)]
sms: Update doc about the default Bearer setting
Denis Kenzior [Fri, 25 Jun 2010 22:49:36 +0000 (17:49 -0500)]
sms: Tweak the Bearer API
Denis Kenzior [Fri, 25 Jun 2010 19:24:10 +0000 (14:24 -0500)]
Update TODO & overview.txt
Denis Kenzior [Fri, 25 Jun 2010 19:21:48 +0000 (14:21 -0500)]
atmodem: Add CGSMS support to sms driver
Denis Kenzior [Fri, 25 Jun 2010 19:21:35 +0000 (14:21 -0500)]
sms: Add support for SMS Bearer settings
Denis Kenzior [Fri, 25 Jun 2010 19:20:23 +0000 (14:20 -0500)]
sms: Add driver API for SMS bearer settings
Denis Kenzior [Fri, 25 Jun 2010 19:25:22 +0000 (14:25 -0500)]
TODO: Add owner
Denis Kenzior [Fri, 25 Jun 2010 17:18:14 +0000 (12:18 -0500)]
gprs: Fix to attachment race condition
Sometimes we get unsolicited attachment status before our query
finishes. If the client is fast enough they can attempt to attach
and get the AttachInProgress error
Denis Kenzior [Fri, 25 Jun 2010 19:12:32 +0000 (14:12 -0500)]
sms: Update API with UseDeliveryReports property
Denis Kenzior [Fri, 25 Jun 2010 01:51:59 +0000 (20:51 -0500)]
hso: Don't query tech if not registered or roaming
{NetworkRegistration} [/hso0] LocationAreaCode = 34591
{NetworkRegistration} [/hso0] CellId = 5903759
{NetworkRegistration} [/hso0] Strength = 32
{NetworkRegistration} [/hso0] Strength = 22
{PrimaryDataContext} [/hso0/primarycontext1] Settings =
dbus.Dictionary({}, signature=dbus.Signature('sv'), variant_level=1)
{PrimaryDataContext} [/hso0/primarycontext1] Active = 0
{DataConnectionManager} [/hso0] Attached = 0
{NetworkRegistration} [/hso0] Status = searching
{NetworkRegistration} [/hso0] Technology = umts <--- Oops
{NetworkOperator} [/hso0/operator/26201] Status = available
{NetworkRegistration} [/hso0] Name =
{NetworkRegistration} [/hso0] Status = registered
{NetworkRegistration} [/hso0] LocationAreaCode = 35342
{NetworkRegistration} [/hso0] CellId = 5903759
{NetworkRegistration} [/hso0] Technology = edge
Denis Kenzior [Thu, 24 Jun 2010 19:24:00 +0000 (14:24 -0500)]
sms: minor style fix
Denis Kenzior [Thu, 24 Jun 2010 19:13:04 +0000 (14:13 -0500)]
sms: Don't bother setting SCA if we can't query
Zhenhua Zhang [Wed, 23 Jun 2010 09:46:37 +0000 (17:46 +0800)]
ppp: Fix incorrect packet length for little-endian
packet->length is in TCP/IP network byte order. It needs to call ntohs()
to convert to host byte order, which is little-endian.
Andrzej Zaborowski [Wed, 23 Jun 2010 04:13:50 +0000 (06:13 +0200)]
stkutil: Alpha Id is optional for Select Item.
Andrzej Zaborowski [Tue, 22 Jun 2010 11:20:44 +0000 (13:20 +0200)]
stkutil: Refactor command parser error handling
When parsing the full command fails but Command Details has been parsed,
return a struct stk_command containing this information and the type of
parsing problem found. We need the command details to be able to
even respond to the command.
This patch also makes the parser skip over unknown data objects found
in the BER-TLV, if they don't have Comprehension Required set.
Marcel Holtmann [Tue, 22 Jun 2010 15:15:06 +0000 (17:15 +0200)]
Check sanity the MNC length value from the SIM card
In case the SIM entry is wrong or we force reading of it, nasty things
like this can happen:
ofonod[12456]: Control:> AT+CRSM=176,28589,0,0,4\r
ofonod[12456]: Control:< +CRSM: 144,0,"00FFFF"\r\n\r\nOK\r\n
*** buffer overflow detected ***: ./src/ofonod terminated
======= Backtrace: =========
/lib64/libc.so.6(__fortify_fail+0x37)[0x3e42efb417]
/lib64/libc.so.6[0x3e42ef9310]
/lib64/libc.so.6(__strncpy_chk+0x17b)[0x3e42ef85cb]
Denis Kenzior [Tue, 22 Jun 2010 14:46:25 +0000 (09:46 -0500)]
Fix huawei udev rules
Denis Kenzior [Tue, 22 Jun 2010 03:53:05 +0000 (22:53 -0500)]
hfp: Fix style issues
Gustavo F. Padovan [Sun, 20 Jun 2010 08:51:23 +0000 (05:51 -0300)]
hfp: use bluetooth helpers and remove similar code
Denis Kenzior [Tue, 22 Jun 2010 03:48:15 +0000 (22:48 -0500)]
bluetooth: Various style issues
Gustavo F. Padovan [Sun, 20 Jun 2010 08:51:22 +0000 (05:51 -0300)]
bluetooth: add PropertyChanged watch
This one is a bit diferent from the hfp.c one, so a separated patch for
it.
Gustavo F. Padovan [Sun, 20 Jun 2010 08:51:21 +0000 (05:51 -0300)]
bluetooth: add watches for service and adapters
Exactly the same code from hfp.c
Gustavo F. Padovan [Sun, 20 Jun 2010 08:51:20 +0000 (05:51 -0300)]
bluetooth: add device_properties_cb() and has_uuid()
Gustavo F. Padovan [Sun, 20 Jun 2010 08:51:19 +0000 (05:51 -0300)]
bluetooth: Move functions from hfp.c to bluetooth.c
The part that call device_properties_cb is commented to permit this patch
compile.
device_properties_cb() will be changed, so it will have separated patch.
Denis Kenzior [Mon, 21 Jun 2010 20:40:14 +0000 (15:40 -0500)]
storage: whitespace issue
Denis Kenzior [Mon, 21 Jun 2010 20:33:13 +0000 (15:33 -0500)]
smsutil: Fix up some comment style
Andrzej Zaborowski [Mon, 21 Jun 2010 08:41:10 +0000 (10:41 +0200)]
test-common: Avoid accessing an unitialised variable.
Fixes a segfault, reported by valrgind as:
[...]
==6300== Use of uninitialised value of size 4
==6300== at 0x8048B4D: test_invalid (test-common.c:81)
Andrzej Zaborowski [Mon, 21 Jun 2010 08:41:11 +0000 (10:41 +0200)]
stkutil: Remove obsolete comment.
Denis Kenzior [Mon, 21 Jun 2010 20:03:42 +0000 (15:03 -0500)]
atmodem: Support CDS indicators for MBM
MBM does not advertise support for CNMA, yet only supports CDS style
notifications which do not need to be acknowledged.
Denis Kenzior [Mon, 21 Jun 2010 18:39:17 +0000 (13:39 -0500)]
sms: Only emit property if value actually differs
Denis Kenzior [Mon, 21 Jun 2010 18:38:57 +0000 (13:38 -0500)]
test: Fix the no-argument case
Denis Kenzior [Mon, 21 Jun 2010 20:04:43 +0000 (15:04 -0500)]
unit: Add unit tests for status report assembly
Denis Kenzior [Mon, 21 Jun 2010 17:48:55 +0000 (12:48 -0500)]
smsutil: Take ton_npi into account in sr assembly
Denis Kenzior [Mon, 21 Jun 2010 17:42:23 +0000 (12:42 -0500)]
smsutil: More code cleanup
- Change the flow of the code a bit, in the case that all fragments have
been sent and an udelivered sr arrives, we can simply remove the node
and signal undelivered up
- We ignore temporary and temporary final status reports
Denis Kenzior [Mon, 21 Jun 2010 17:03:14 +0000 (12:03 -0500)]
smsutil: Make code flow easier to understand
Denis Kenzior [Mon, 21 Jun 2010 16:29:51 +0000 (11:29 -0500)]
smsutil: multiline comments to preferred style