review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 Aug 2013 15:14:24 +0000 (15:14 +0000)]

add remote debugging support for x86 phone

R=djsollen@google.com, borenet@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/19920003

git-svn-id: http://skia.googlecode.com/svn/trunk@10511 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 2 Aug 2013 14:39:25 +0000 (14:39 +0000)]

Add fullscreen rect bench

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/21592002

git-svn-id: http://skia.googlecode.com/svn/trunk@10510 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 Aug 2013 13:59:50 +0000 (13:59 +0000)]

Support MSAA in the picture debugger

Add radio buttons for setting the GL sample count to 0 ("off"), 4 or
16.

Change the default mode of the GL widget to MSAA4. Previous behavior
corresponded to "off".

BUG=1459
R=robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/21752002

git-svn-id: http://skia.googlecode.com/svn/trunk@10509 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 2 Aug 2013 07:00:59 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10503 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 2 Aug 2013 00:20:34 +0000 (00:20 +0000)]

Add onRefMatchingStyle to SkFontHost_linux.

git-svn-id: http://skia.googlecode.com/svn/trunk@10502 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 Aug 2013 22:48:21 +0000 (22:48 +0000)]

Fix SkTMin call introduced in 10500 which fails on some platforms.

git-svn-id: http://skia.googlecode.com/svn/trunk@10501 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 Aug 2013 22:29:43 +0000 (22:29 +0000)]

Implement onGetTableTags and onGetTableData on Windows.

Implements these and removes default implementation, making the
declaration in SkTypeface pure virtual.

Review URL: https://codereview.chromium.org/20672004

git-svn-id: http://skia.googlecode.com/svn/trunk@10500 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 21:54:26 +0000 (21:54 +0000)]

Fix memory leak in SkPDFResourceDict

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20655004

git-svn-id: http://skia.googlecode.com/svn/trunk@10499 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 1 Aug 2013 21:20:47 +0000 (21:20 +0000)]

pdfviewer: debug the parameters for snc, and for resolveReference

Review URL: https://codereview.chromium.org/21604003

git-svn-id: http://skia.googlecode.com/svn/trunk@10498 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 Aug 2013 21:01:28 +0000 (21:01 +0000)]

Reintroduce default impls removed in 10495.

Due to poor placement of overrides in the hierarchy, nacl is failing.

git-svn-id: http://skia.googlecode.com/svn/trunk@10497 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 Aug 2013 20:18:41 +0000 (20:18 +0000)]

Implement onGetTableTags and onGetTableData on Windows.

Implements these and removes default implementation, making the
declaration in SkTypeface pure virtual.

Review URL: https://codereview.chromium.org/20672004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10495 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 1 Aug 2013 20:06:42 +0000 (20:06 +0000)]

pdfviewer: finish implementation of SkPdfObject.toString(), and include in debugging traces we leave when rendering.

Review URL: https://codereview.chromium.org/20628008

git-svn-id: http://skia.googlecode.com/svn/trunk@10494 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 1 Aug 2013 18:36:08 +0000 (18:36 +0000)]

Revert "Don't call SkGpuDevice::drawVertices from drawPoints when AA is required."

This reverts commit r10489.

Review URL: https://codereview.chromium.org/21496003

git-svn-id: http://skia.googlecode.com/svn/trunk@10492 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 1 Aug 2013 18:33:03 +0000 (18:33 +0000)]

New baselines for imagefiltersgraph GM after r10482.

TBR=djsollen
BUG=

Review URL: https://codereview.chromium.org/20938004

git-svn-id: http://skia.googlecode.com/svn/trunk@10491 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 17:32:56 +0000 (17:32 +0000)]

Added 3-color gradient scraper for detecting symmetrical gradients.

Made changes to lua to scrape info about 3 color gradients

BUG=
R=reed@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/21571002

git-svn-id: http://skia.googlecode.com/svn/trunk@10490 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 17:30:32 +0000 (17:30 +0000)]

Don't call SkGpuDevice::drawVertices from drawPoints when AA is required.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/12943007

git-svn-id: http://skia.googlecode.com/svn/trunk@10489 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Thu, 1 Aug 2013 17:09:11 +0000 (17:09 +0000)]

Add Loop Blinn hairline conics to GPU

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/21036008

git-svn-id: http://skia.googlecode.com/svn/trunk@10487 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 15:58:07 +0000 (15:58 +0000)]

When skia run bench cases to test performance, it will run constructors for all cases one by one, then getName to skip unnecessary cases according to command line parameters, so these constructors should be lightweight enough to avoid redundant computing. Unfortunately, some constructors contain intensive computing/rendering. They are very heavy, maybe much heavier than need-to-run bench case itself. And these redundant computation will be run every time you run bench, even you just test a single simple case. Moreover, it will mislead the real hotspot/bottleneck of the case itself.
For example, run a lightweight case, say, region_intersectsrgn_16, the hot spots are gles operation, SuperBlitter, SkRTree... introduced by irrelevant cases' constructors. These redundant computation will mislead performance tuning.
So we can move these intensive computation to onPreDraw() of these case. They will be executed only if this case should be run.

R=reed@google.com, robertphillips@google.com, humper@google.com, tomhudson@chromium.org

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/20997003

git-svn-id: http://skia.googlecode.com/svn/trunk@10486 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 1 Aug 2013 15:53:39 +0000 (15:53 +0000)]

stub support for SK_FONTHOST_USES_FONTMGR

BUG=

Review URL: https://codereview.chromium.org/21563002

git-svn-id: http://skia.googlecode.com/svn/trunk@10485 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 15:35:06 +0000 (15:35 +0000)]

Make SkPath::conservativelyContainsRect not assert on paths that begin with repeated moveTos

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/21565002

git-svn-id: http://skia.googlecode.com/svn/trunk@10484 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 1 Aug 2013 15:03:42 +0000 (15:03 +0000)]

Fixes for JPEG subset decoding.

Ensure that the stream passed to JPEG for subset decoding is
neither deleted before it is no longer needed nor deleted an
extra time.

src/images/SkJpegUtility.h:
src/images/SkJpegUtility.cpp:
Always ref and unref the stream provided to skjpeg_source_mgr.
Add some comments explaining how skjpeg_source_mgr's members
handle ownership.
Fix a warning comparing signed and unsigned numbers, converting
to size_t which is more appropriate for measuring bytes.
Remove dead code referring to fMemoryBase and fMemoryBaseSize,
which are never used.

src/images/SkImageDecoder_libjpeg.cpp:
Call the new constructor for skjpeg_source_mgr, which no longer
takes a boolean to determine ownership.

include/images/SkBitmapRegionDecoder.h
src/images/SkBitmapRegionDecoder.cpp:
This small shim has been removed, since it is not needed to use
Skia's image decoders. Its functionality will be folded into
Android.

Required for the merge to Android.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/21561002

git-svn-id: http://skia.googlecode.com/svn/trunk@10483 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 1 Aug 2013 14:59:05 +0000 (14:59 +0000)]

Remove SkBlendImageFilter, and all tests. Its functionality has been subsumed by SkXfermodeImageFilter.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/21404002

git-svn-id: http://skia.googlecode.com/svn/trunk@10482 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 14:23:33 +0000 (14:23 +0000)]

Mark GrMemoryPool methods as static.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/21553002

git-svn-id: http://skia.googlecode.com/svn/trunk@10481 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 Aug 2013 14:23:23 +0000 (14:23 +0000)]

ARM Skia NEON patches - 14 - S32A_Blend

Blitrow32: S32A_Blend new NEON version

Adding a NEON version of S32A_Blend_BlitRow32. Here are the
benchmark results:

+-------+--------------------------+--------------------------+
|       |      Speedup vs. C       |    Speedup vs. ARM asm   |
| count +------------+-------------+------------+-------------+
|       | Cortex A-9 | Cortex A-15 | Cortex A-9 | Cortex A-15 |
+-------+------------+-------------+------------+-------------+
| 1     | +8,5%      | +18,5%      | +0.9%      | +2,9%       |
+-------+------------+-------------+------------+-------------+
| 2     | +65,6%     | +94%        | +70,3%     | +80%        |
+-------+------------+-------------+------------+-------------+
| 4     | +42,4%     | +87,8%      | +56,8%     | +84,4%      |
+-------+------------+-------------+------------+-------------+
| 8     | +30%       | +90%        | +49,9%     | +82,7%      |
+-------+------------+-------------+------------+-------------+
| 16    | +23,1%     | +95,4%      | +46,6%     | +87,6%      |
+-------+------------+-------------+------------+-------------+
| 64    | +23,1%     | +95,7%      | +46,1%     | +89,4%      |
+-------+------------+-------------+------------+-------------+
| 256   | +35,5%     | +122%       | +53,6%     | +99,2%      |
+-------+------------+-------------+------------+-------------+
| 1024  | +61,8%     | +101%       | +64,2%     | +91,2%      |
+-------+------------+-------------+------------+-------------+

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18614010

git-svn-id: http://skia.googlecode.com/svn/trunk@10480 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 1 Aug 2013 13:24:00 +0000 (13:24 +0000)]

pdfviewer: remove simple implementation for non-isolated groups. will be implemented in skia most probably. also it is not generated by SkPDFDevice

Review URL: https://codereview.chromium.org/21537003

git-svn-id: http://skia.googlecode.com/svn/trunk@10479 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 1 Aug 2013 12:08:58 +0000 (12:08 +0000)]

N7 performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10478 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 1 Aug 2013 07:01:05 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10477 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 31 Jul 2013 22:54:31 +0000 (22:54 +0000)]

Inverse fill support in PDF

BUG= https://code.google.com/p/skia/issues/detail?id=241 (partial fix)
R=edisonn@google.com, vandebo@chromium.org, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19519017

git-svn-id: http://skia.googlecode.com/svn/trunk@10476 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 31 Jul 2013 20:21:50 +0000 (20:21 +0000)]

New baselines for imagefilterscropped.

TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/21340005

git-svn-id: http://skia.googlecode.com/svn/trunk@10475 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 31 Jul 2013 20:09:25 +0000 (20:09 +0000)]

Enable runtime checks for SSSE3 on x86 on Android.

$ compare-android.sh bench --match bitmap_ --repeat 30
master -> ssse3
N=30 p=0.001000 (corrected to 0.000033)
sig?  speedup  bench
  n    -1.16%  bitmap_scale_filter_256_64
  y    -0.72%  bitmap_8888_A_scale_bicubic
  y    -0.21%  bitmap_index8_A
  n    -0.00%  bitmap_565
  n    -0.00%  bitmap_scale_filter_90_80
  n     0.03%  bitmap_8888_A_source_transparent
  y     0.06%  bitmap_index8
  y     0.30%  bitmap_8888_A_source_stripes_two
  n     0.34%  bitmap_scale_filter_80_90
  y     0.42%  bitmap_8888_A
  y     0.44%  bitmap_8888_A_source_opaque
  n     0.53%  bitmap_scale_filter_90_10
  y     0.71%  bitmap_8888_A_source_stripes_three
  y     0.91%  bitmap_8888_A_scale_rotate_bicubic
  y     1.04%  bitmap_8888_update
  n     1.19%  bitmap_scale_filter_10_90
  n     1.39%  bitmap_scale_filter_90_90
  y     1.77%  bitmap_8888_update_volatile
  y     1.89%  bitmap_8888
  y     2.37%  bitmap_scale_filter_30_90
  y     9.57%  bitmap_scale_filter_64_256
  n    17.86%  bitmap_scale_filter_90_30
  y    25.40%  bitmap_8888_A_scale_rotate_bilerp
  y    27.19%  bitmap_8888_scale_rotate_bilerp
  y    27.23%  bitmap_8888_update_scale_rotate_bilerp
  y    27.29%  bitmap_8888_update_volatile_scale_rotate_bilerp
  y    55.08%  bitmap_8888_A_scale_bilerp
  y    58.75%  bitmap_8888_update_volatile_scale_bilerp
  y    58.90%  bitmap_8888_scale_bilerp
  y    58.92%  bitmap_8888_update_scale_bilerp
Overall speedup: 10.52%

BUG=skia:1111
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21203005

git-svn-id: http://skia.googlecode.com/svn/trunk@10474 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 31 Jul 2013 20:00:56 +0000 (20:00 +0000)]

Committed: code.google.com/p/skia/source/detail?r=10372

R=borenet@google.com, bungeman@google.com, robertphillips@google.com, scroggo@google.com, sglez@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19862002

git-svn-id: http://skia.googlecode.com/svn/trunk@10473 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 19:36:07 +0000 (19:36 +0000)]

Revert "Revert "Revert "try enabling FONTHOST_USES_FONTMGR and see what breaks"""

This reverts commit d0a1a568ac5d5c2ed94e826e91b01241de2ca0ce.

git-svn-id: http://skia.googlecode.com/svn/trunk@10472 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 19:00:30 +0000 (19:00 +0000)]

Revert "Revert "try enabling FONTHOST_USES_FONTMGR and see what breaks""

This reverts commit a8946cf4180908d577681cb62d621db0ebcbe67e.

i.e. reapply the change to try enabling FONTHOST_USES_FONTMGR

git-svn-id: http://skia.googlecode.com/svn/trunk@10471 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 31 Jul 2013 18:52:31 +0000 (18:52 +0000)]

set nominmax on windows

R=scroggo@google.com

Review URL: https://codereview.chromium.org/20990007

git-svn-id: http://skia.googlecode.com/svn/trunk@10470 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 18:49:33 +0000 (18:49 +0000)]

add impls for createfromstream for fontconfig fontmgr

git-svn-id: http://skia.googlecode.com/svn/trunk@10469 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 18:25:33 +0000 (18:25 +0000)]

Revert "try enabling FONTHOST_USES_FONTMGR and see what breaks"

This reverts commit a289c38fc14664b5ba1269cfe08b3048cdbd1e97.

git-svn-id: http://skia.googlecode.com/svn/trunk@10468 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 31 Jul 2013 18:22:36 +0000 (18:22 +0000)]

pdfviewer: transparency groups - implementation of non-isolated and non-knockout flags

Review URL: https://codereview.chromium.org/21288002

git-svn-id: http://skia.googlecode.com/svn/trunk@10467 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 18:08:49 +0000 (18:08 +0000)]

try enabling FONTHOST_USES_FONTMGR and see what breaks

git-svn-id: http://skia.googlecode.com/svn/trunk@10466 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 18:02:55 +0000 (18:02 +0000)]

add dox to SkTDynamicHash, fix typo of Key instead of KEY

BUG=
R=mtklein@google.com

Review URL: https://codereview.chromium.org/21028008

git-svn-id: http://skia.googlecode.com/svn/trunk@10465 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 31 Jul 2013 17:37:31 +0000 (17:37 +0000)]

adapt FontConfig to use SK_FONTHOST_USES_FONTMGR

BUG=

Review URL: https://codereview.chromium.org/21331003

git-svn-id: http://skia.googlecode.com/svn/trunk@10463 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 31 Jul 2013 16:01:25 +0000 (16:01 +0000)]

Remove a stray double assign that g++ 4.8 thinks has ill-defined sequencing.

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/21352003

git-svn-id: http://skia.googlecode.com/svn/trunk@10462 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 31 Jul 2013 15:48:10 +0000 (15:48 +0000)]

Upstream changes from Android

R=scroggo@google.com

Review URL: https://codereview.chromium.org/21053009

git-svn-id: http://skia.googlecode.com/svn/trunk@10461 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 31 Jul 2013 14:57:53 +0000 (14:57 +0000)]

added drawVertices path to GameBench

https://codereview.chromium.org/21168006/

git-svn-id: http://skia.googlecode.com/svn/trunk@10459 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 31 Jul 2013 12:57:27 +0000 (12:57 +0000)]

update gyp for ARM builds to be more well defined.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/21096005

git-svn-id: http://skia.googlecode.com/svn/trunk@10454 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 31 Jul 2013 07:01:00 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10449 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 31 Jul 2013 01:17:42 +0000 (01:17 +0000)]

Rebaseline blur tests for r10444. Max color mismatch 1.

TBR=
BUG=

Review URL: https://codereview.chromium.org/21235011

git-svn-id: http://skia.googlecode.com/svn/trunk@10448 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 31 Jul 2013 00:00:56 +0000 (00:00 +0000)]

Alter assert that is causing Chromium compilation failure

../../third_party/skia/include/core/SkTypeface.h:303:19: error: implicit conversion turns string literal into bool: 'const char [14]' to 'bool' [-Werror,-Wstring-conversion]
SkASSERT(!"unimplemented");
~^~~~~~~~~~~~~~~

git-svn-id: http://skia.googlecode.com/svn/trunk@10447 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 30 Jul 2013 21:54:10 +0000 (21:54 +0000)]

+ ,fLastAllocated(NULL)

BUG=
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/21046011

git-svn-id: http://skia.googlecode.com/svn/trunk@10446 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 30 Jul 2013 21:25:49 +0000 (21:25 +0000)]

support SK_FONTHOST_USES_FONTMGR on mac

BUG=

Review URL: https://codereview.chromium.org/21142004

git-svn-id: http://skia.googlecode.com/svn/trunk@10445 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 30 Jul 2013 21:11:05 +0000 (21:11 +0000)]

Optimize the blur convolution by only applying domain clamping where necessary. Split the blur convolution into left and right margins which have clamping applied and a center portion which doesn't. Also reorder the convolve_gaussian() parameters to match GrConvolutionEffect params. Correctness is covered by existing tests; performance is covered by BlurImageFilter bench.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/21224003

git-svn-id: http://skia.googlecode.com/svn/trunk@10444 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 30 Jul 2013 19:32:16 +0000 (19:32 +0000)]

Remove old default implementation of SkTypeface::onGetUPEM.

In order to introduce onGetUPEM there was written a generic but slow
version in SkTypeface.cpp. All ports now implement this method and the
declaration is now marked as pure virtual.

git-svn-id: http://skia.googlecode.com/svn/trunk@10442 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 30 Jul 2013 17:47:39 +0000 (17:47 +0000)]

refactoring for SK_FONTHOST_USES_FONTMGR option

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/21149008

git-svn-id: http://skia.googlecode.com/svn/trunk@10440 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 30 Jul 2013 17:23:01 +0000 (17:23 +0000)]

leading slash confuses non-git tools that read .gitignore, like ag

BUG=
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/21055005

git-svn-id: http://skia.googlecode.com/svn/trunk@10439 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 30 Jul 2013 16:06:12 +0000 (16:06 +0000)]

pdfviewer: more prerequired work to have examples working for transparency work items.

Review URL: https://codereview.chromium.org/21252003

git-svn-id: http://skia.googlecode.com/svn/trunk@10438 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Tue, 30 Jul 2013 14:47:04 +0000 (14:47 +0000)]

Adds links to dashboard plots for skp bench values out of range. (SkipBuildbotRuns).
They are single-line plots for the specific bench/platform/config combos.
Review URL: https://codereview.chromium.org/21157003

git-svn-id: http://skia.googlecode.com/svn/trunk@10437 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Tue, 30 Jul 2013 14:14:14 +0000 (14:14 +0000)]

ndk r8d->r8e, adding mips toolchain

tested:
platform_tools/android/bin/android_make -d nexus_4 -j 4 BUILDTYPE=Release && platform_tools/android/bin/android_make -d razr_i BUILDTYPE=Release -j 4 && echo "OK"

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19670018

git-svn-id: http://skia.googlecode.com/svn/trunk@10435 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Tue, 30 Jul 2013 13:35:54 +0000 (13:35 +0000)]

Rebaseline a couple of Nexus 7 GPU GMs for thumb2.

The max color mismatch across all these is 1, and they're all in blurs.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/21246002

git-svn-id: http://skia.googlecode.com/svn/trunk@10434 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 30 Jul 2013 13:34:10 +0000 (13:34 +0000)]

pdfviewer: add doPage function, cet stream from Contents

Review URL: https://codereview.chromium.org/21049009

git-svn-id: http://skia.googlecode.com/svn/trunk@10433 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 30 Jul 2013 13:16:29 +0000 (13:16 +0000)]

fold SK_CPU_HAS_CONDITION_INSTR through as always defined

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/21122005

git-svn-id: http://skia.googlecode.com/svn/trunk@10432 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 30 Jul 2013 13:16:18 +0000 (13:16 +0000)]

add scalar stubs for neon functions to give arm guys a place to work

BUG=
R=djsollen@google.com, reed@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20749003

git-svn-id: http://skia.googlecode.com/svn/trunk@10431 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 30 Jul 2013 13:16:07 +0000 (13:16 +0000)]

set a correct breakpoint for gdbserver, gdb can stop here before the app is running, and we can set more breakpoints if we need. For previous one, gdb will not stop, so it will run the app and exit.

R=djsollen@google.com, borenet@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/20671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10430 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 30 Jul 2013 12:29:20 +0000 (12:29 +0000)]

Fix compiler warning/error in r10428

git-svn-id: http://skia.googlecode.com/svn/trunk@10429 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 30 Jul 2013 12:15:19 +0000 (12:15 +0000)]

Fix quickReject computation for blurs

https://codereview.chromium.org/17035007/

git-svn-id: http://skia.googlecode.com/svn/trunk@10428 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 30 Jul 2013 12:09:14 +0000 (12:09 +0000)]

pdfviewer: fix condition for element in array, reset back the default color to white, and verify type before value in PDF API mapper

Review URL: https://codereview.chromium.org/21017004

git-svn-id: http://skia.googlecode.com/svn/trunk@10427 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 30 Jul 2013 07:01:00 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10426 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 30 Jul 2013 01:07:48 +0000 (01:07 +0000)]

Fix subpixel metrics with GDI.

The previous code uncovered a rather strange issue with GDI, where it
appears that alternating between two HFONTs with the same attributes but
vastly different heights does not appear to invalidate the the 'x'
metrics (the 'y' metrics appear to be correct). As a result it is
possible to get completely useless results from GetGlyphOutlineW. This
change works around the issue by simply scaling the one font to the
required sizes, which also saves us an HFONT.

Review URL: https://codereview.chromium.org/21047008

git-svn-id: http://skia.googlecode.com/svn/trunk@10425 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 29 Jul 2013 22:25:02 +0000 (22:25 +0000)]

Fix invalid comparison between int16 and int16be in name table code.

Review URL: https://codereview.chromium.org/21138005

git-svn-id: http://skia.googlecode.com/svn/trunk@10424 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 29 Jul 2013 22:14:45 +0000 (22:14 +0000)]

pdfviewer: load files with missing xref (we need in order to help with testing, as most good pdfx in the whild miss the xref). add period as a valid character to start a real value.

Review URL: https://codereview.chromium.org/21096006

git-svn-id: http://skia.googlecode.com/svn/trunk@10423 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 29 Jul 2013 20:53:14 +0000 (20:53 +0000)]

always have conditional instruction

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21155002

git-svn-id: http://skia.googlecode.com/svn/trunk@10422 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 29 Jul 2013 19:30:00 +0000 (19:30 +0000)]

one more thing to try before rebaselining android

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21112004

git-svn-id: http://skia.googlecode.com/svn/trunk@10420 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 29 Jul 2013 19:10:58 +0000 (19:10 +0000)]

pdfviewer: more plumming for soft masks, blend modes and transparency groups

Review URL: https://codereview.chromium.org/21125002

git-svn-id: http://skia.googlecode.com/svn/trunk@10419 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 29 Jul 2013 18:54:08 +0000 (18:54 +0000)]

expose getFamilyName to public SkTypeface

git-svn-id: http://skia.googlecode.com/svn/trunk@10418 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 29 Jul 2013 18:45:44 +0000 (18:45 +0000)]

Small optimization for convolution shader: only apply the bounds check in direction of convolution, not both. This requires generating different versions of the shader depending on direction.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/20789003

git-svn-id: http://skia.googlecode.com/svn/trunk@10417 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 29 Jul 2013 18:33:33 +0000 (18:33 +0000)]

Turn thumb back on.

We expect this might break Android GMs. If it does I'll rebaseline or revert.

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21096004

git-svn-id: http://skia.googlecode.com/svn/trunk@10415 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 29 Jul 2013 14:43:31 +0000 (14:43 +0000)]

Matrix decomposition cleanup: Add is_degenerate_2x2(), and fix some asserts
(atan2 can take a zero x value, but both x == 0 and y == 0 is undefined).

R=reed@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/20303003

git-svn-id: http://skia.googlecode.com/svn/trunk@10410 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Mon, 29 Jul 2013 13:29:49 +0000 (13:29 +0000)]

adjust performance triggers for flakes on the Windows bots.

R=borenet@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/21076002

git-svn-id: http://skia.googlecode.com/svn/trunk@10408 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Sun, 28 Jul 2013 20:04:35 +0000 (20:04 +0000)]

pdfviewer: fix a few warnings

Review URL: https://codereview.chromium.org/20662003

git-svn-id: http://skia.googlecode.com/svn/trunk@10404 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Sun, 28 Jul 2013 18:34:14 +0000 (18:34 +0000)]

pdfviewer: gs operator implementation: dashing and font

Review URL: https://codereview.chromium.org/20810002

git-svn-id: http://skia.googlecode.com/svn/trunk@10403 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sun, 28 Jul 2013 07:01:03 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10402 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Sun, 28 Jul 2013 00:53:43 +0000 (00:53 +0000)]

Rebaseline for 10399 and 10400 (GDI metrics).

git-svn-id: http://skia.googlecode.com/svn/trunk@10401 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Sat, 27 Jul 2013 21:42:21 +0000 (21:42 +0000)]

Disable GDI slight hinting.

FontHostTest fails because 'Times New Roman' 'o' and 'g' have
a different number of points in their hinted and un-hinted versions.
Disable slight hinting until this is understood.

git-svn-id: http://skia.googlecode.com/svn/trunk@10400 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Sat, 27 Jul 2013 20:37:56 +0000 (20:37 +0000)]

Fix metrics on Windows.

With this change, Skia's metrics are much better in general, and
specifically can be made to match the metrics produced by current
Blink code. This allows Blink to use Skia's metrics.

This change will require a number of rebaselines in Skia, since
previous metrics were quite different. This will require about five
rebaslines in Blink, as the new code may cause GDI's matrix to differ
in the low bits.

Review URL: https://codereview.chromium.org/20585004

git-svn-id: http://skia.googlecode.com/svn/trunk@10399 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 27 Jul 2013 07:01:06 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10398 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 26 Jul 2013 20:40:06 +0000 (20:40 +0000)]

differentiate mag and min filters

BUG=
R=bsalomon@google.com, robertphillips@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20809002

git-svn-id: http://skia.googlecode.com/svn/trunk@10397 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 19:55:28 +0000 (19:55 +0000)]

Remove Nexus10 strokes3_gpu expectations. This one seems to change every run (uninit? driver bug?).

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20501004

git-svn-id: http://skia.googlecode.com/svn/trunk@10396 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 26 Jul 2013 19:29:39 +0000 (19:29 +0000)]

process gm expectation violations

R=epoger@google.com

Review URL: https://codereview.chromium.org/20527002

git-svn-id: http://skia.googlecode.com/svn/trunk@10395 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 17:27:21 +0000 (17:27 +0000)]

Another try at rebaselining strokes_gpu on Nexus10. If this doesn't work, I'll just add all of the hashes generated so far to the list.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20774002

git-svn-id: http://skia.googlecode.com/svn/trunk@10394 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 26 Jul 2013 16:36:04 +0000 (16:36 +0000)]

get genmipmap function in the struct

BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20436002

git-svn-id: http://skia.googlecode.com/svn/trunk@10393 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 26 Jul 2013 15:23:43 +0000 (15:23 +0000)]

add more stats to the bitmap matrix locator

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19091006

git-svn-id: http://skia.googlecode.com/svn/trunk@10392 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 12:29:37 +0000 (12:29 +0000)]

New Nexus10 baselines for strokes3_gpu.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20725002

git-svn-id: http://skia.googlecode.com/svn/trunk@10387 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 11:52:19 +0000 (11:52 +0000)]

New Galaxy Nexus lighting baselines.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20718002

git-svn-id: http://skia.googlecode.com/svn/trunk@10386 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 26 Jul 2013 07:00:58 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10385 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 03:10:17 +0000 (03:10 +0000)]

New Nexus10 baselines after r10379.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20648002

git-svn-id: http://skia.googlecode.com/svn/trunk@10384 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 02:46:19 +0000 (02:46 +0000)]

Yet another round of lighting rebaselines: win7.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20625003

git-svn-id: http://skia.googlecode.com/svn/trunk@10383 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 02:21:12 +0000 (02:21 +0000)]

Next round of lighting rebaselines after r10379.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20636003

git-svn-id: http://skia.googlecode.com/svn/trunk@10382 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 01:14:38 +0000 (01:14 +0000)]

Next round of lighting baselines after r10379.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10381 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 00:51:29 +0000 (00:51 +0000)]

First round of new lighting baselines after r10379.

TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20600003

git-svn-id: http://skia.googlecode.com/svn/trunk@10380 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 26 Jul 2013 00:10:07 +0000 (00:10 +0000)]

Implement crop rect for lighting image filters. Changes for the CPU path were fairly straightforward: use the bounds rectangle when traversing the pixels, not the source rectangle.

For the GPU path, this required modifying the signature of SkImageFilter::asNewEffect() to receive the bounds offset, so that the lighting filters could offset the light position by the offset. It also required modifying the base-class implementation of SkImageFilter::filterImageGPU() (which implements single-pass filters) to intersect against the bounds rect, to pass its offset to asNewEffect(), and to modify the caller's offset (so it's drawn in the correct place).

Note: this will require rebaselining the lighting GM. Six new test cases were added, to accommodate a cropped version of each lighting filter.

R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/20426002

git-svn-id: http://skia.googlecode.com/svn/trunk@10379 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 25 Jul 2013 23:29:40 +0000 (23:29 +0000)]

Make SkImage_Gpu share it's pixelref with the surface to prevent premature return to scratch pool.

BUG=crbug.com/263329
TEST=Surface unit test, function Test_crbug263329
R=bsalomon@google.com, reed@google.com

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20354003

git-svn-id: http://skia.googlecode.com/svn/trunk@10378 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 25 Jul 2013 22:03:22 +0000 (22:03 +0000)]

pdfviewer: limit the characters we support in ToUnicode, to 0xffff

Review URL: https://codereview.chromium.org/20538002

git-svn-id: http://skia.googlecode.com/svn/trunk@10377 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;