platform/upstream/libSkiaSharp.git
12 years agoFix GrTextureAccess::operator ==
bsalomon@google.com [Thu, 20 Sep 2012 15:37:30 +0000 (15:37 +0000)]
Fix GrTextureAccess::operator ==

compare the textures, correctly intepret memcmp result, don't compare last byte of swizzle array which must be 0.

BUG=895
Review URL: https://codereview.appspot.com/6542048

git-svn-id: http://skia.googlecode.com/svn/trunk@5605 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIn render_pictures tiled rendering, draw a separate PNG for each tile.
scroggo@google.com [Thu, 20 Sep 2012 14:54:21 +0000 (14:54 +0000)]
In render_pictures tiled rendering, draw a separate PNG for each tile.

Since the passed in picture may represent an image which is too large
to be represented on the GPU, never create such a large canvas. Instead,
after drawing to each tile, create a file showing just that tile.

Review URL: https://codereview.appspot.com/6532056

git-svn-id: http://skia.googlecode.com/svn/trunk@5603 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIn bench_pictures, use a pool of tiles for multicore drawing.
scroggo@google.com [Thu, 20 Sep 2012 14:42:33 +0000 (14:42 +0000)]
In bench_pictures, use a pool of tiles for multicore drawing.

Also includes some code cleanup and code sharing.

Allow setting the number of threads on the command line.

Rename ThreadSafePipeController::playback to ::draw, to be the same
as SkPicture so DrawTileToCanvas can take a template parameter.

Disallow multithreading with GPU turned on.

Display help information with improper tiled arguments.

BUG=https://code.google.com/p/skia/issues/detail?id=871

Review URL: https://codereview.appspot.com/6536050

git-svn-id: http://skia.googlecode.com/svn/trunk@5602 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoYet another speculative Android fix. Unreviewed.
senorblanco@chromium.org [Wed, 19 Sep 2012 22:50:21 +0000 (22:50 +0000)]
Yet another speculative Android fix.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5600 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRenaming a couple methods in SkDeferredCanvas.cpp to improve readability
junov@chromium.org [Wed, 19 Sep 2012 22:48:34 +0000 (22:48 +0000)]
Renaming a couple methods in SkDeferredCanvas.cpp to improve readability
Review URL: https://codereview.appspot.com/6536060

git-svn-id: http://skia.googlecode.com/svn/trunk@5599 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSpeculative fix for Android GMs. Unreviewed.
senorblanco@chromium.org [Wed, 19 Sep 2012 22:40:54 +0000 (22:40 +0000)]
Speculative fix for Android GMs.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5598 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSkip empty directories and input files not ending in .skp in *_pictures
borenet@google.com [Wed, 19 Sep 2012 17:28:29 +0000 (17:28 +0000)]
Skip empty directories and input files not ending in .skp in *_pictures

Addressing https://code.google.com/p/skia/issues/detail?id=886
Review URL: https://codereview.appspot.com/6531047

git-svn-id: http://skia.googlecode.com/svn/trunk@5597 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agobegin to skiafy PDF headers : removing use of SkRefPtr
reed@google.com [Wed, 19 Sep 2012 17:05:55 +0000 (17:05 +0000)]
begin to skiafy PDF headers : removing use of SkRefPtr
Review URL: https://codereview.appspot.com/6526050

git-svn-id: http://skia.googlecode.com/svn/trunk@5596 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWhitespace change to trigger a rebuild after removing bad bench data from r5592
borenet@google.com [Wed, 19 Sep 2012 12:32:06 +0000 (12:32 +0000)]
Whitespace change to trigger a rebuild after removing bad bench data from r5592

This should stop the failures from GenerateBenchGraphs

git-svn-id: http://skia.googlecode.com/svn/trunk@5595 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 19 Sep 2012 02:01:47 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5594 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoUnreviewed; build fix.
senorblanco@chromium.org [Tue, 18 Sep 2012 20:44:01 +0000 (20:44 +0000)]
Unreviewed; build fix.

Disable matrixconvolution bench until I can figure out the
premul issues.

git-svn-id: http://skia.googlecode.com/svn/trunk@5593 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoImplements a matrix convolution filter (raster path only). The filtering loop
senorblanco@chromium.org [Tue, 18 Sep 2012 20:32:34 +0000 (20:32 +0000)]
Implements a matrix convolution filter (raster path only).  The filtering loop
is templated on the tiling mode for speed:  interior pixels are unconditionally
fetched; border pixels apply the appropriate tiling mode before fetching.  It
handles target, bias, divisor (as gain), and edge modes (named to be more
skia-like).  It does not handle the "preserveAlpha" semantics of
feConvolveMatrix, nor "kernelUnitLength".

git-svn-id: http://skia.googlecode.com/svn/trunk@5592 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Tue, 18 Sep 2012 20:08:37 +0000 (20:08 +0000)]
shape ops work in progress

at least 12M of the quad/quad intersection tests pass

git-svn-id: http://skia.googlecode.com/svn/trunk@5591 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoExplicitly convert from int to SkScalar to avoid a compiler error on gcc 4.5
george@mozilla.com [Tue, 18 Sep 2012 19:05:48 +0000 (19:05 +0000)]
Explicitly convert from int to SkScalar to avoid a compiler error on gcc 4.5

Review URL: https://codereview.appspot.com/6526047

git-svn-id: http://skia.googlecode.com/svn/trunk@5589 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix for r5587 compiler error (removed ../src/gpu in HashCacheTest.cpp)
robertphillips@google.com [Tue, 18 Sep 2012 17:30:47 +0000 (17:30 +0000)]
Fix for r5587 compiler error (removed ../src/gpu in HashCacheTest.cpp)

git-svn-id: http://skia.googlecode.com/svn/trunk@5588 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded functor to GrTHashCache to allow discovery of un-reffed resources
robertphillips@google.com [Tue, 18 Sep 2012 17:16:33 +0000 (17:16 +0000)]
Added functor to GrTHashCache to allow discovery of un-reffed resources

http://codereview.appspot.com/6503126/

git-svn-id: http://skia.googlecode.com/svn/trunk@5587 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoupdate gyp files to build on iOS
caryclark@google.com [Tue, 18 Sep 2012 15:41:18 +0000 (15:41 +0000)]
update gyp files to build on iOS

Note that there's a hack in SkImageDecoder_CG.cpp --
the necessary defines are included directly. This
is temporary until I can figure out how to include
them properly.
Review URL: https://codereview.appspot.com/6523044

git-svn-id: http://skia.googlecode.com/svn/trunk@5586 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agore-re-land 5578
reed@google.com [Tue, 18 Sep 2012 15:14:33 +0000 (15:14 +0000)]
re-re-land 5578

will follow w/ new .skp files to keep the waterfall green (I hope)

git-svn-id: http://skia.googlecode.com/svn/trunk@5584 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReuse one canvas for every tile in bench_pictures (in single threaded mode).
scroggo@google.com [Tue, 18 Sep 2012 14:32:35 +0000 (14:32 +0000)]
Reuse one canvas for every tile in bench_pictures (in single threaded mode).

Turn off multi threaded option for now.

In bench_pictures, do not create a large canvas, since we never use it.

Remove unused functions on TiledPictureRenderer.

Review URL: https://codereview.appspot.com/6521043

git-svn-id: http://skia.googlecode.com/svn/trunk@5583 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove GrTextureParams from GrSamplerState to GrTextureAccess
bsalomon@google.com [Tue, 18 Sep 2012 14:14:49 +0000 (14:14 +0000)]
Move GrTextureParams from GrSamplerState to GrTextureAccess

Review URL: https://codereview.appspot.com/6496135/

git-svn-id: http://skia.googlecode.com/svn/trunk@5582 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorevert 5580
reed@google.com [Tue, 18 Sep 2012 14:04:54 +0000 (14:04 +0000)]
revert 5580

git-svn-id: http://skia.googlecode.com/svn/trunk@5581 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agore-land 5578 w/ pipe fix
reed@google.com [Tue, 18 Sep 2012 13:47:20 +0000 (13:47 +0000)]
re-land 5578 w/ pipe fix

git-svn-id: http://skia.googlecode.com/svn/trunk@5580 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorevert 5578 -- broke pipe
reed@google.com [Tue, 18 Sep 2012 13:20:52 +0000 (13:20 +0000)]
revert 5578 -- broke pipe

git-svn-id: http://skia.googlecode.com/svn/trunk@5579 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoChange drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
reed@google.com [Tue, 18 Sep 2012 12:59:44 +0000 (12:59 +0000)]
Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
allows the client more control over the scaling. Because of virtual overrides
and wanting to keep the old call-sites up and running, this CL renames the
virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to
a non-virtual helper function.

The implementation is to use the float-rect for computing the matrix, but still
cons-up an integer rect for the purposes of subsetting the original bitmap. We
do this by calling float_src->roundOut(&int_src) so that we include all
(partially) covered src pixels.

No change needed on SkDevice, since that signature is explicitly passed the
computed matrix.
Review URL: https://codereview.appspot.com/6501140

git-svn-id: http://skia.googlecode.com/svn/trunk@5578 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 18 Sep 2012 02:01:09 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5577 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd a header for OverView.cpp as well.
tfarina@chromium.org [Tue, 18 Sep 2012 01:52:20 +0000 (01:52 +0000)]
Add a header for OverView.cpp as well.

This fixes another FIXMEs.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6492125

git-svn-id: http://skia.googlecode.com/svn/trunk@5576 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSet DEFAULT_REPEATS to 1
borenet@google.com [Mon, 17 Sep 2012 21:10:05 +0000 (21:10 +0000)]
Set DEFAULT_REPEATS to 1

bench defaults to 1 repeat, so bench_pictures should do the same.

This is causing the Android build cycles to be *hours* long.
Review URL: https://codereview.appspot.com/6490123

git-svn-id: http://skia.googlecode.com/svn/trunk@5575 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCheck for invalid SkPictures
borenet@google.com [Mon, 17 Sep 2012 18:26:06 +0000 (18:26 +0000)]
Check for invalid SkPictures

- Remove hasRecorded() since nobody uses it.
- Add "success" boolean to SkPicture stream constructor
- Track failures in render_pictures and bench_pictures
Review URL: https://codereview.appspot.com/6493105

git-svn-id: http://skia.googlecode.com/svn/trunk@5573 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd GrColor to RGBA float helper func
bsalomon@google.com [Mon, 17 Sep 2012 17:23:21 +0000 (17:23 +0000)]
Add GrColor to RGBA float helper func

Review URL: https://codereview.appspot.com/6518044/

git-svn-id: http://skia.googlecode.com/svn/trunk@5572 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix a Ref count bug in SkFontHost_win_dw.cpp
bungeman@google.com [Mon, 17 Sep 2012 14:25:42 +0000 (14:25 +0000)]
Fix a Ref count bug in SkFontHost_win_dw.cpp
https://codereview.appspot.com/6495133

Props tinytail.

git-svn-id: http://skia.googlecode.com/svn/trunk@5568 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed unused variable compiler complaint
robertphillips@google.com [Mon, 17 Sep 2012 13:38:57 +0000 (13:38 +0000)]
Fixed unused variable compiler complaint

http://codereview.appspot.com/6496129/

git-svn-id: http://skia.googlecode.com/svn/trunk@5567 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed valgrind complaint in MatrixBench
robertphillips@google.com [Mon, 17 Sep 2012 13:36:47 +0000 (13:36 +0000)]
Fixed valgrind complaint in MatrixBench

https://codereview.appspot.com/6492129/

git-svn-id: http://skia.googlecode.com/svn/trunk@5566 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofixed compiler complaints
robertphillips@google.com [Mon, 17 Sep 2012 12:05:40 +0000 (12:05 +0000)]
fixed compiler complaints

http://codereview.appspot.com/6499124/

git-svn-id: http://skia.googlecode.com/svn/trunk@5565 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed memory leak in deferred_canvas_record bench
robertphillips@google.com [Mon, 17 Sep 2012 11:52:48 +0000 (11:52 +0000)]
Fixed memory leak in deferred_canvas_record bench

http://codereview.appspot.com/6499123/

git-svn-id: http://skia.googlecode.com/svn/trunk@5564 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMade more benchs non-rendering
robertphillips@google.com [Mon, 17 Sep 2012 10:49:30 +0000 (10:49 +0000)]
Made more benchs non-rendering

http://codereview.appspot.com/6498132/

git-svn-id: http://skia.googlecode.com/svn/trunk@5562 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 15 Sep 2012 02:01:41 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5561 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTemporarily revert r5433 due to http://www.crbug.com/148637 until after M23 branch.
bsalomon@google.com [Fri, 14 Sep 2012 20:30:37 +0000 (20:30 +0000)]
Temporarily revert r5433 due to crbug.com/148637 until after M23 branch.

git-svn-id: http://skia.googlecode.com/svn/trunk@5557 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agospeculative fix for crbug.com/147406 -- disabling save/clip/restore peephole
reed@google.com [Fri, 14 Sep 2012 19:07:28 +0000 (19:07 +0000)]
speculative fix for crbug.com/147406 -- disabling save/clip/restore peephole
optimization, to see if it reduces crash rates.

git-svn-id: http://skia.googlecode.com/svn/trunk@5556 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDouble size of buffer for SkString::printf()
rileya@google.com [Fri, 14 Sep 2012 19:03:42 +0000 (19:03 +0000)]
Double size of buffer for SkString::printf()
Review URL: https://codereview.appspot.com/6503120

git-svn-id: http://skia.googlecode.com/svn/trunk@5555 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd file I forgot in https://code.google.com/p/skia/source/detail?r=5552
epoger@google.com [Fri, 14 Sep 2012 18:52:10 +0000 (18:52 +0000)]
Add file I forgot in https://code.google.com/p/skia/source/detail?r=5552

git-svn-id: http://skia.googlecode.com/svn/trunk@5554 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoUpdate expected bench results for picture_playback_drawText_GPU_c
epoger@google.com [Fri, 14 Sep 2012 18:47:13 +0000 (18:47 +0000)]
Update expected bench results for picture_playback_drawText_GPU_c
to fix http://code.google.com/p/skia/issues/detail?id=877

git-svn-id: http://skia.googlecode.com/svn/trunk@5553 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd a header file for TransitionView.cpp
epoger@google.com [Fri, 14 Sep 2012 18:42:01 +0000 (18:42 +0000)]
Add a header file for TransitionView.cpp
committed from https://codereview.appspot.com/6492119/ for Thiago Farina <tfarina@chromium.org>

git-svn-id: http://skia.googlecode.com/svn/trunk@5552 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTurn serialization back on in GM.
scroggo@google.com [Fri, 14 Sep 2012 17:37:46 +0000 (17:37 +0000)]
Turn serialization back on in GM.

With https://codereview.appspot.com/6503106/ it is now safe to do
serialization by default.

Review URL: https://codereview.appspot.com/6498121

git-svn-id: http://skia.googlecode.com/svn/trunk@5551 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFor a picture playback with nothing written, use an empty SkData.
scroggo@google.com [Fri, 14 Sep 2012 17:26:37 +0000 (17:26 +0000)]
For a picture playback with nothing written, use an empty SkData.

This prevents crashing when attempting to access fOpData.

BUG=https://code.google.com/p/skia/issues/detail?id=870

Review URL: https://codereview.appspot.com/6499108

git-svn-id: http://skia.googlecode.com/svn/trunk@5550 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agolanding https://codereview.appspot.com/6506117
reed@google.com [Fri, 14 Sep 2012 16:00:01 +0000 (16:00 +0000)]
landing https://codereview.appspot.com/6506117

git-svn-id: http://skia.googlecode.com/svn/trunk@5549 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix some nits from http://codereview.appspot.com/6506103/
rileya@google.com [Fri, 14 Sep 2012 15:52:47 +0000 (15:52 +0000)]
Fix some nits from codereview.appspot.com/6506103/

git-svn-id: http://skia.googlecode.com/svn/trunk@5547 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoScale even smaller in bench_pictures to get things green
borenet@google.com [Fri, 14 Sep 2012 15:27:41 +0000 (15:27 +0000)]
Scale even smaller in bench_pictures to get things green

Over-the-shoulder review from reed@
Review URL: https://codereview.appspot.com/6512043

git-svn-id: http://skia.googlecode.com/svn/trunk@5545 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofix fragile cubic stepper, where we want to assert that each tesselated segment
reed@google.com [Fri, 14 Sep 2012 15:18:41 +0000 (15:18 +0000)]
fix fragile cubic stepper, where we want to assert that each tesselated segment
is monotonically going down, but the finite math we use cannot ensure that...
so we explicitly pin the y-value after it is calculated.

add unittest that exercises the bug/assert that was found on an SVG site

git-svn-id: http://skia.googlecode.com/svn/trunk@5544 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoEnable automatic rescaling in bench_pictures
borenet@google.com [Fri, 14 Sep 2012 14:34:28 +0000 (14:34 +0000)]
Enable automatic rescaling in bench_pictures

bench_pictures with "--device gpu" is failing because we're trying to allocate
too much GPU memory.  Move the recently-added scaling code into picture_utils
and share it between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6495125

git-svn-id: http://skia.googlecode.com/svn/trunk@5543 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix picture refcnt bug in distantclip gm. Unreviewed.
rileya@google.com [Fri, 14 Sep 2012 14:24:14 +0000 (14:24 +0000)]
Fix picture refcnt bug in distantclip gm. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5542 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Fri, 14 Sep 2012 14:19:30 +0000 (14:19 +0000)]
shape ops work in progress
add quartic solution for intersecting quadratics

git-svn-id: http://skia.googlecode.com/svn/trunk@5541 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd gm to test SkRegion/clipPath bug.
rileya@google.com [Fri, 14 Sep 2012 13:53:36 +0000 (13:53 +0000)]
Add gm to test SkRegion/clipPath bug.
Review URL: https://codereview.appspot.com/6501131

git-svn-id: http://skia.googlecode.com/svn/trunk@5540 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 14 Sep 2012 02:01:10 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5539 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix for gcc compile error. Unreviewed.
rileya@google.com [Thu, 13 Sep 2012 21:47:48 +0000 (21:47 +0000)]
Fix for gcc compile error. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5538 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd R-Tree record flag to SkPicture, plus some cleanup/fixes in associated classes.
rileya@google.com [Thu, 13 Sep 2012 21:41:51 +0000 (21:41 +0000)]
Add R-Tree record flag to SkPicture, plus some cleanup/fixes in associated classes.
Review URL: https://codereview.appspot.com/6506103

git-svn-id: http://skia.googlecode.com/svn/trunk@5537 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdds bench expectation file and mechanism for triggering bench-out-of-range alerts...
bensong@google.com [Thu, 13 Sep 2012 21:08:52 +0000 (21:08 +0000)]
Adds bench expectation file and mechanism for triggering bench-out-of-range alerts from bench_graph_svg.

git-svn-id: http://skia.googlecode.com/svn/trunk@5536 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDo not exit on failure to open logFile
borenet@google.com [Thu, 13 Sep 2012 18:54:48 +0000 (18:54 +0000)]
Do not exit on failure to open logFile

Temporary solution for write-protected Android devices.  Intention is to revert
in favor of a more permanent solution.
Review URL: https://codereview.appspot.com/6497132

git-svn-id: http://skia.googlecode.com/svn/trunk@5535 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCheck if SK_BUILD_FOR_MAC is defined rather than whether it's 1
george@mozilla.com [Thu, 13 Sep 2012 17:55:34 +0000 (17:55 +0000)]
Check if SK_BUILD_FOR_MAC is defined rather than whether it's 1

git-svn-id: http://skia.googlecode.com/svn/trunk@5532 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTo avoid running out of memory, we rescale very large pictures before we
reed@google.com [Thu, 13 Sep 2012 17:44:32 +0000 (17:44 +0000)]
To avoid running out of memory, we rescale very large pictures before we
render them.
Review URL: https://codereview.appspot.com/6504045

git-svn-id: http://skia.googlecode.com/svn/trunk@5530 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake all random path benchs non-rendering
robertphillips@google.com [Thu, 13 Sep 2012 16:39:08 +0000 (16:39 +0000)]
Make all random path benchs non-rendering

https://codereview.appspot.com/6490111/

git-svn-id: http://skia.googlecode.com/svn/trunk@5527 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoLet SkBenchmark classes specify that they do no rendering.
tomhudson@google.com [Thu, 13 Sep 2012 15:50:24 +0000 (15:50 +0000)]
Let SkBenchmark classes specify that they do no rendering.
Doing this gives us a 15-20% speedup in bench cycle time.
Here again I'm just picking the easy targets.

http://codereview.appspot.com/6500115/

git-svn-id: http://skia.googlecode.com/svn/trunk@5525 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTurn down repeat count on ref counting and memory pool benches.
tomhudson@google.com [Thu, 13 Sep 2012 15:42:33 +0000 (15:42 +0000)]
Turn down repeat count on ref counting and memory pool benches.
No reason these things need to run for 10s of ms.

http://codereview.appspot.com/6501122/

git-svn-id: http://skia.googlecode.com/svn/trunk@5524 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded GPU resource cache stats printing to render_pictures
robertphillips@google.com [Thu, 13 Sep 2012 15:40:37 +0000 (15:40 +0000)]
Added GPU resource cache stats printing to render_pictures

https://codereview.appspot.com/6492104/

git-svn-id: http://skia.googlecode.com/svn/trunk@5523 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoKeep the entries in .gitignore sorted in alphabetical order.
scroggo@google.com [Thu, 13 Sep 2012 15:26:51 +0000 (15:26 +0000)]
Keep the entries in .gitignore sorted in alphabetical order.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6506107

git-svn-id: http://skia.googlecode.com/svn/trunk@5522 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert r5520
borenet@google.com [Thu, 13 Sep 2012 14:53:15 +0000 (14:53 +0000)]
Revert r5520

Unfortunately, since we can only build ANGLE by including a gypi, and since
gyp cannot process includes conditionally, we *have* to have a build_angle.gypi
file in the third_party/externals/ANGLE/src directory.  We could do a hack
where we create an empty gypi if ANGLE is not checked out, but for now we just
check out ANGLE on all platforms.

git-svn-id: http://skia.googlecode.com/svn/trunk@5521 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoOnly check out ANGLE on Windows
borenet@google.com [Thu, 13 Sep 2012 14:38:04 +0000 (14:38 +0000)]
Only check out ANGLE on Windows
Review URL: https://codereview.appspot.com/6500118

git-svn-id: http://skia.googlecode.com/svn/trunk@5520 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded GPU resource cache stats printing to bench & removed some noise from inst count...
robertphillips@google.com [Thu, 13 Sep 2012 14:05:00 +0000 (14:05 +0000)]
Added GPU resource cache stats printing to bench & removed some noise from inst counting information

https://codereview.appspot.com/6497125/

git-svn-id: http://skia.googlecode.com/svn/trunk@5519 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAddress warnings from clang build bot
robertphillips@google.com [Thu, 13 Sep 2012 13:25:30 +0000 (13:25 +0000)]
Address warnings from clang build bot

http://codereview.appspot.com/6506111/

git-svn-id: http://skia.googlecode.com/svn/trunk@5518 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agore-apply 5508, but with the new compile-flag disabled for now
reed@google.com [Wed, 12 Sep 2012 21:08:33 +0000 (21:08 +0000)]
re-apply 5508, but with the new compile-flag disabled for now

git-svn-id: http://skia.googlecode.com/svn/trunk@5516 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoProvide labels for variant settings in bench graph.
bungeman@google.com [Wed, 12 Sep 2012 19:34:17 +0000 (19:34 +0000)]
Provide labels for variant settings in bench graph.
https://codereview.appspot.com/6494118/

git-svn-id: http://skia.googlecode.com/svn/trunk@5515 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoUse double dashes for bench options to be consistent.
scroggo@google.com [Wed, 12 Sep 2012 19:27:11 +0000 (19:27 +0000)]
Use double dashes for bench options to be consistent.

Breaks the bots, since the arguments being passed to bench have changed, but there is a change to fix it at https://codereview.appspot.com/6488114/

Review URL: https://codereview.appspot.com/6500108

git-svn-id: http://skia.googlecode.com/svn/trunk@5513 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake texteffects gm work through serialization and pipe.
scroggo@google.com [Wed, 12 Sep 2012 18:53:49 +0000 (18:53 +0000)]
Make texteffects gm work through serialization and pipe.

Move Line2DPathEffect (now Sk_) into a separate header file so it can
be shared and initialized.

Switch to the shared version in SampleAll and SampleSlides.

Remove the skip pipe flag from texteffects, since it can now be serialized.

I have a separate change to turn serialization on by default at https://codereview.appspot.com/6498121/

Review URL: https://codereview.appspot.com/6503106

git-svn-id: http://skia.googlecode.com/svn/trunk@5512 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorevert 5508 -- it broke most of the builds
reed@google.com [Wed, 12 Sep 2012 18:34:49 +0000 (18:34 +0000)]
revert 5508 -- it broke most of the builds

Use http://skia.googlecode.com/svn/buildbot/buildbots.html to see the state of the build.

git-svn-id: http://skia.googlecode.com/svn/trunk@5511 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd some more things that should be ignored to .gitignore
scroggo@google.com [Wed, 12 Sep 2012 16:32:05 +0000 (16:32 +0000)]
Add some more things that should be ignored to .gitignore

Reviewed at https://codereview.appspot.com/6498119/

Review URL: https://codereview.appspot.com/6503107

git-svn-id: http://skia.googlecode.com/svn/trunk@5509 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoUsing the device scale factor for glyph positioning
wjmaclean@chromium.org [Wed, 12 Sep 2012 15:53:20 +0000 (15:53 +0000)]
Using the device scale factor for glyph positioning

The master bug is http://code.google.com/p/chromium/issues/detail?id=138101 .
The corresponding WebKit changes for this CL are here:
https://bugs.webkit.org/show_bug.cgi?id=96137

BUG=

Review URL: https://codereview.appspot.com/6506099

git-svn-id: http://skia.googlecode.com/svn/trunk@5508 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd some untracked directories to gitignore.
epoger@google.com [Wed, 12 Sep 2012 15:03:27 +0000 (15:03 +0000)]
Add some untracked directories to gitignore.
(Landing https://codereview.appspot.com/6488100/ for tfarina)

git-svn-id: http://skia.googlecode.com/svn/trunk@5507 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 12 Sep 2012 02:00:57 +0000 (02:00 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5504 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix noisy Android build
borenet@google.com [Tue, 11 Sep 2012 21:37:28 +0000 (21:37 +0000)]
Fix noisy Android build
Review URL: https://codereview.appspot.com/6488107

git-svn-id: http://skia.googlecode.com/svn/trunk@5503 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix texture ref/unref bug in GrContext::createResizedTexture
robertphillips@google.com [Tue, 11 Sep 2012 21:25:51 +0000 (21:25 +0000)]
Fix texture ref/unref bug in GrContext::createResizedTexture

https://codereview.appspot.com/6500107/

git-svn-id: http://skia.googlecode.com/svn/trunk@5502 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert r5491, r5495, r5497, and r5498.
borenet@google.com [Tue, 11 Sep 2012 20:39:09 +0000 (20:39 +0000)]
Revert r5491, r5495, r5497, and r5498.
Review URL: https://codereview.appspot.com/6499097

git-svn-id: http://skia.googlecode.com/svn/trunk@5501 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd SkBBoxRecord subclass that builds up a BBoxHierarchy and PictureStateTree.
rileya@google.com [Tue, 11 Sep 2012 20:21:44 +0000 (20:21 +0000)]
Add SkBBoxRecord subclass that builds up a BBoxHierarchy and PictureStateTree.
Review URL: https://codereview.appspot.com/6490104

git-svn-id: http://skia.googlecode.com/svn/trunk@5500 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix GrGLCreateNativeInterface_android
borenet@google.com [Tue, 11 Sep 2012 20:01:04 +0000 (20:01 +0000)]
Fix GrGLCreateNativeInterface_android
Review URL: https://codereview.appspot.com/6503101

git-svn-id: http://skia.googlecode.com/svn/trunk@5499 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd more logging to GrGLInterface. Temporary.
borenet@google.com [Tue, 11 Sep 2012 19:36:43 +0000 (19:36 +0000)]
Add more logging to GrGLInterface.  Temporary.

git-svn-id: http://skia.googlecode.com/svn/trunk@5498 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd lots of logging to GrGLInterface.cpp. Temporary.
borenet@google.com [Tue, 11 Sep 2012 19:29:34 +0000 (19:29 +0000)]
Add lots of logging to GrGLInterface.cpp.  Temporary.

git-svn-id: http://skia.googlecode.com/svn/trunk@5497 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd -logPerIter, -timers, and -min to bench_pictures.
scroggo@google.com [Tue, 11 Sep 2012 19:15:32 +0000 (19:15 +0000)]
Add -logPerIter, -timers, and -min to bench_pictures.

Additional changes:

Add instance count to bench_pictures.

Remove various PictureBenchmark subclasses which did not do
anything besides have a different PictureRenderer.

BUG=https://code.google.com/p/skia/issues/detail?id=856

Review URL: https://codereview.appspot.com/6496109

git-svn-id: http://skia.googlecode.com/svn/trunk@5496 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoprintf->SkDebugf for r5491
borenet@google.com [Tue, 11 Sep 2012 19:00:37 +0000 (19:00 +0000)]
printf->SkDebugf for r5491

Over-the-shoulder review by robertphillips@

git-svn-id: http://skia.googlecode.com/svn/trunk@5495 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix 5492.
bungeman@google.com [Tue, 11 Sep 2012 18:47:43 +0000 (18:47 +0000)]
Fix 5492.

git-svn-id: http://skia.googlecode.com/svn/trunk@5493 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReduce SkMaskGamma cache thrashing.
bungeman@google.com [Tue, 11 Sep 2012 18:44:55 +0000 (18:44 +0000)]
Reduce SkMaskGamma cache thrashing.
https://codereview.appspot.com/6497114/

git-svn-id: http://skia.googlecode.com/svn/trunk@5492 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTemporarily add logging to GrContextFactory and SkNativeGLContext_android
borenet@google.com [Tue, 11 Sep 2012 18:35:35 +0000 (18:35 +0000)]
Temporarily add logging to GrContextFactory and SkNativeGLContext_android

Over-the-shoulder review from robertphillips@ and bsalomon@

Will revert soon.
Review URL: https://codereview.appspot.com/6496110

git-svn-id: http://skia.googlecode.com/svn/trunk@5491 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorm temp slides
reed@google.com [Tue, 11 Sep 2012 17:46:42 +0000 (17:46 +0000)]
rm temp slides

git-svn-id: http://skia.googlecode.com/svn/trunk@5488 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBaseline DirectWrite.
bungeman@google.com [Tue, 11 Sep 2012 17:29:37 +0000 (17:29 +0000)]
Baseline DirectWrite.

git-svn-id: http://skia.googlecode.com/svn/trunk@5487 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWrap all GrCustomStage textures in GrTextureAccess, remove StageDesc::fInConfigFlags
bsalomon@google.com [Tue, 11 Sep 2012 15:45:20 +0000 (15:45 +0000)]
Wrap all GrCustomStage textures in GrTextureAccess, remove StageDesc::fInConfigFlags

Review URL: https://codereview.appspot.com/6494114

git-svn-id: http://skia.googlecode.com/svn/trunk@5485 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake BBoxHierarchy ref-counted, fix leak in RTreeTest.
rileya@google.com [Tue, 11 Sep 2012 15:41:50 +0000 (15:41 +0000)]
Make BBoxHierarchy ref-counted, fix leak in RTreeTest.
Review URL: https://codereview.appspot.com/6489108

git-svn-id: http://skia.googlecode.com/svn/trunk@5484 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd helper for maintaining clip/matrix state in non-contiguous picture playback.
rileya@google.com [Tue, 11 Sep 2012 14:57:33 +0000 (14:57 +0000)]
Add helper for maintaining clip/matrix state in non-contiguous picture playback.
Review URL: https://codereview.appspot.com/6509043

git-svn-id: http://skia.googlecode.com/svn/trunk@5483 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove GrTextureAccess decl/defn to separate files
bsalomon@google.com [Tue, 11 Sep 2012 13:29:29 +0000 (13:29 +0000)]
Move GrTextureAccess decl/defn to separate files

Review URL: https://codereview.appspot.com/6500104/

git-svn-id: http://skia.googlecode.com/svn/trunk@5482 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoExtended instance counting to all GrResource-derived classes
robertphillips@google.com [Tue, 11 Sep 2012 13:02:31 +0000 (13:02 +0000)]
Extended instance counting to all GrResource-derived classes

http://codereview.appspot.com/6489109/

git-svn-id: http://skia.googlecode.com/svn/trunk@5480 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemoved access of freed memory in GrContext dtor
robertphillips@google.com [Tue, 11 Sep 2012 12:50:53 +0000 (12:50 +0000)]
Removed access of freed memory in GrContext dtor

http://codereview.appspot.com/6488111/

git-svn-id: http://skia.googlecode.com/svn/trunk@5479 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed memory leak in RTreeBench
robertphillips@google.com [Tue, 11 Sep 2012 11:54:07 +0000 (11:54 +0000)]
Fixed memory leak in RTreeBench

http://codereview.appspot.com/6500101/

git-svn-id: http://skia.googlecode.com/svn/trunk@5478 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 11 Sep 2012 02:01:14 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@5477 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix for DEPS compiler issue in SkGrFontScaler.cpp
robertphillips@google.com [Mon, 10 Sep 2012 22:57:42 +0000 (22:57 +0000)]
Fix for DEPS compiler issue in SkGrFontScaler.cpp

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@5476 2bbb7eff-a529-9590-31e7-b0007b416f81