commit-bot@chromium.org [Tue, 11 Mar 2014 14:23:50 +0000 (14:23 +0000)]
Revert of New version of the bbh shootout (https://codereview.chromium.org/
186973005/)
Reason for revert:
breaking build on at least 12 configurations.
Original issue's description:
> New version of the bbh shootout.
> There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
> The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
> Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.
>
> Doing this so I can reasonably compare the new QuadTree implementation.
> BUG=skia:2242
>
> Committed: http://code.google.com/p/skia/source/detail?r=13736
R=tomhudson@google.com, mtklein@google.com, reed@google.com, iancottrell@google.com
TBR=iancottrell@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2242
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
194903003
git-svn-id: http://skia.googlecode.com/svn/trunk@13737
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 13:51:28 +0000 (13:51 +0000)]
New version of the bbh shootout.
There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.
Doing this so I can reasonably compare the new QuadTree implementation.
BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
186973005
git-svn-id: http://skia.googlecode.com/svn/trunk@13736
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 22:53:20 +0000 (22:53 +0000)]
plumbing for GPU fast blur
BUG=skia:2281
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
193193002
git-svn-id: http://skia.googlecode.com/svn/trunk@13735
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 10 Mar 2014 21:42:48 +0000 (21:42 +0000)]
Rebase bezier_effect GMs and lingering changed GMs from laggy bots
Review URL: https://codereview.chromium.org/
190663019
git-svn-id: http://skia.googlecode.com/svn/trunk@13734
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 21:42:06 +0000 (21:42 +0000)]
plumb API for analytic rrect blur
BUG=skia:2281
R=bsalomon@google.com, reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
189663012
git-svn-id: http://skia.googlecode.com/svn/trunk@13733
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 20:37:54 +0000 (20:37 +0000)]
Revert of Add new module for distance field generation. (https://codereview.chromium.org/
178543007/)
Reason for revert:
multiple compile errors
Original issue's description:
> Add new module for distance field generation.
>
> This improves the speed over the previous method by 10x+, and makes using distance fields practical.
>
> BUG=skia:2173
>
> Committed: http://code.google.com/p/skia/source/detail?r=13729
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2173
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
190753015
git-svn-id: http://skia.googlecode.com/svn/trunk@13732
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 10 Mar 2014 19:51:46 +0000 (19:51 +0000)]
Fix no GPU build after r13728
Review URL: https://codereview.chromium.org/
193163002
git-svn-id: http://skia.googlecode.com/svn/trunk@13731
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Mar 2014 19:47:58 +0000 (19:47 +0000)]
flag to make kClipToLayer_SaveFlag the default behavior
#define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior
The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer.
R=robertphillips@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
190723004
git-svn-id: http://skia.googlecode.com/svn/trunk@13730
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:38:51 +0000 (19:38 +0000)]
Add new module for distance field generation.
This improves the speed over the previous method by 10x+, and makes using distance fields practical.
BUG=skia:2173
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
178543007
git-svn-id: http://skia.googlecode.com/svn/trunk@13729
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:33:16 +0000 (19:33 +0000)]
reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
190953008
git-svn-id: http://skia.googlecode.com/svn/trunk@13728
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:12:53 +0000 (19:12 +0000)]
rebaseline_server: disable image magnifier, for huge UI speedup
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
193073003
git-svn-id: http://skia.googlecode.com/svn/trunk@13727
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 18:09:25 +0000 (18:09 +0000)]
rebaseline_server: add actual_repo and actual_revision command line options
So, if you want to see divergences from expectations as of https://code.google.com/p/skia-autogen/source/detail?r=29365 , specify --actuals-revision 29365
This is also handy for testing rebaseline_server performance improvements against a static set of results.
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com, bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
193023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13726
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 18:05:15 +0000 (18:05 +0000)]
rebaseline_server: fix reload delay when there is client/server clock skew
Currently, if there is >10 second clock skew between client and server, the
client will attempt to reload constantly while the server is still loading
results.
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
192833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13725
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:41:00 +0000 (16:41 +0000)]
Pulling these out of other reviews so avoid code review clutter.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
192783002
git-svn-id: http://skia.googlecode.com/svn/trunk@13724
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:08:22 +0000 (16:08 +0000)]
Use bitfield rather than distinct enum types for circular corners in RRectEffect.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
191613003
git-svn-id: http://skia.googlecode.com/svn/trunk@13723
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:05:57 +0000 (16:05 +0000)]
remove legacy ifdef wrapping fast blur
BUG=skia:
R=robertphillips@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
192833002
git-svn-id: http://skia.googlecode.com/svn/trunk@13722
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:04:47 +0000 (16:04 +0000)]
Avoid black flashes when resizing debugger window using MSAA
Avoid black flashes when resizing debugger window using MSAA. Clear the
stencil buffer always after resize. Also reset the GrContext state
when Qt calls resizeGL -- we do not know what GL state Qt changes.
Remove setting of white background to SkGLWidget, it is not
effective. QGLWidget does not respect the stylesheet.
Also move the initial stencil clearing before GrContext is created
in order to preserve GrContext state consistent with actual GL
state.
R=robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
192433003
git-svn-id: http://skia.googlecode.com/svn/trunk@13721
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 15:36:06 +0000 (15:36 +0000)]
rebaseline_server: display how long it took to render the list
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
189833008
git-svn-id: http://skia.googlecode.com/svn/trunk@13720
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Mar 2014 12:17:06 +0000 (12:17 +0000)]
Revert "remove flag for legacy copyTo -- call sites have been updated"
This reverts commit
85586a92f50942ede4422aca7308b9d8a88469db.
git-svn-id: http://skia.googlecode.com/svn/trunk@13719
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 10:51:58 +0000 (10:51 +0000)]
Factory methods for heap-allocated SkImageFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkImageFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
182983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13718
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 07:40:03 +0000 (07:40 +0000)]
Add API for GrContext to recommend rendertarget sample count
Add GrContext::getRecommendedSampleCount method that can be
used to determine which GPU backend and what exact sample count
is recommendeded for a particular render target at particular
dpi.
Make this initially recommend 4xMSAA for contexts which have
NVPR enabled if dpi is 250 or more, 16 if dpi is less than 250
and no MSAA for others.
BUG=chromium:347962
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
188403003
git-svn-id: http://skia.googlecode.com/svn/trunk@13717
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 9 Mar 2014 03:02:09 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13716
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 8 Mar 2014 03:57:19 +0000 (03:57 +0000)]
hide getTotalClip, so we can eventually remove it
hide getClipType, so we can eventually remove it
patch from issue
189443007
TBR=robertphilips@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
189883010
git-svn-id: http://skia.googlecode.com/svn/trunk@13715
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 8 Mar 2014 03:02:06 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13714
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Mar 2014 22:34:32 +0000 (22:34 +0000)]
Rebaselines for https://codereview.chromium.org/
188693008/
Review URL: https://codereview.chromium.org/
189913006
git-svn-id: http://skia.googlecode.com/svn/trunk@13713
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Mar 2014 20:33:07 +0000 (20:33 +0000)]
update ignored-tests.txt to accound for acceptable changes due to r13710
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
189803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13712
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Mar 2014 19:44:59 +0000 (19:44 +0000)]
remove dead code
git-svn-id: http://skia.googlecode.com/svn/trunk@13711
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 19:43:43 +0000 (19:43 +0000)]
Implement the clip as 4 or fewer GrEffects when possible.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
188693008
git-svn-id: http://skia.googlecode.com/svn/trunk@13710
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 18:42:15 +0000 (18:42 +0000)]
Once Chromium starts holding on to paths and we can actually reuse cached path data (e.g., masks & geometry) we will need a way to preserve that reuse in the skps. This CL begins adding that capability. More analysis & profiling needs to be done before it is always enabled.
When enabled it does make the disabled path de-duping test in the Canvas unit test pass.
BUG=skia:507
R=bsalomon@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
190923002
git-svn-id: http://skia.googlecode.com/svn/trunk@13709
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 18:41:14 +0000 (18:41 +0000)]
Add nvprmsaa4 and nvprmsaa16 configs to bench_pictures
Add nvprmsaa4 and nvprmsaa16 configs to bench_pictures.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
189263012
git-svn-id: http://skia.googlecode.com/svn/trunk@13708
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 17:34:21 +0000 (17:34 +0000)]
Ignore failure of mixed_xfermodes_gpu on N4
BUG=skia:1596
NOTRY=true
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
190843004
git-svn-id: http://skia.googlecode.com/svn/trunk@13707
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Mar 2014 16:20:47 +0000 (16:20 +0000)]
remove flag for legacy copyTo -- call sites have been updated
TBR=robertphilips@google.com
Review URL: https://codereview.chromium.org/
189513005
git-svn-id: http://skia.googlecode.com/svn/trunk@13706
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 16:20:36 +0000 (16:20 +0000)]
update Doxygen config file to include gpu directory in api generation
BUG=skia:2263
R=epoger@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/
182253012
git-svn-id: http://skia.googlecode.com/svn/trunk@13705
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 15:53:01 +0000 (15:53 +0000)]
This is just the first version and shows how I intend to orchestrate this. Future enhancements will:
track the portion of the bitmap required
track any resizing that might be required
actually preload something
R=bsalomon@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
187833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13704
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 14:52:22 +0000 (14:52 +0000)]
remove code disabled from writePixels change
These tests were asserting that particular, non-documented, optimizations were taking place
in the deferreddevice. Theese particualr short-cuts are no longer possible given the change
to canvas' writepixels to always require a raw-pointer.
R=junov@google.com
TBR=junov@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
190853002
git-svn-id: http://skia.googlecode.com/svn/trunk@13703
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 14:52:09 +0000 (14:52 +0000)]
getFactory() must return a factory.
BUG=348821
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
190843002
git-svn-id: http://skia.googlecode.com/svn/trunk@13702
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 14:43:00 +0000 (14:43 +0000)]
Fix underlying issue causing crbug.com/348821.
SkDashPathEffect refuses to flatten itself if it thinks it's a no-op. This
messes with the assumption that flattening a non-NULL effect and then
unflattening from those bytes produces a non-NULL effect. I'd rather make that
assumption always be true than save a few bytes for rare nonsense path effects.
BUG=348821
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
189643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13701
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 13:24:52 +0000 (13:24 +0000)]
fix the build error of SkiaExample -- use setColorType, not setConfig
BUG=skia:
R=reed@google.com, scroggo@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
190303002
git-svn-id: http://skia.googlecode.com/svn/trunk@13700
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 13:24:42 +0000 (13:24 +0000)]
SSE2 implementation of S32A_D565_Opaque_Dither
Run benchmarks with command line option "--forceDither true --forceBlend
1", almost all the benchmarks exercised S32A_D565_Opaque_Dither can get
about 20%-70% performance improvement.
Here are the data on i7-3770:
before after
verts 4314.81 3627.64 15.93%
constXTile_MM_filter_trans 1434.22 432.82 69.82%
constXTile_CC_filter_trans_scale 1440.17 437.00 69.66%
constXTile_RR_filter_trans 1436.96 431.93 69.94%
constXTile_MM_trans_scale 1436.33 435.77 69.66%
constXTile_CC_trans 1433.12 431.36 69.90%
constXTile_RR_trans_scale 1436.13 436.06 69.64%
constXTile_MM_filter 1411.55 408.06 71.09%
constXTile_CC_filter_scale 1416.68 414.18 70.76%
constXTile_RR_filter 1429.46 409.81 71.33%
constXTile_MM_scale 1415.00 412.56 70.84%
constXTile_CC 1410.32 408.36 71.04%
constXTile_RR_scale 1413.26 413.16 70.77%
repeatTile_4444_A 1922.01 879.03 54.27%
repeatTile_4444_A 1430.68 818.34 42.80%
repeatTile_4444_X 1817.43 816.63 55.07%
maskshader 5911.09 5895.46 0.26%
gradient_create_alpha 4.41 4.41 -0.15%
gradient_conical_clamp_3color 35298.71 27574.34 21.88%
gradient_conical_clamp_hicolor 35262.15 27538.99 21.90%
gradient_conical_clamp 35276.21 27599.80 21.76%
gradient_radial2_mirror 20846.74 12969.39 37.79%
gradient_radial2_clamp_hicolor 21848.12 13967.57 36.07%
gradient_radial2_clamp 21829.95 13978.57 35.97%
bitmap_4444_A_scale_rotate_bicubic 105.31 87.13 17.26%
bitmap_4444_A_scale_bicubic 73.69 47.76 35.20%
bitmap_4444_update_scale_rotate_bilerp 125.65 87.86 30.08%
bitmap_4444_update_volatile_scale_rotate_bilerp 125.50 87.65 30.16%
bitmap_4444_scale_rotate_bilerp 124.46 87.91 29.37%
bitmap_4444_A_scale_rotate_bilerp 105.09 87.27 16.96%
bitmap_4444_update_scale_bilerp 106.78 63.28 40.74%
bitmap_4444_update_volatile_scale_bilerp 106.66 63.66 40.32%
bitmap_4444_scale_bilerp 106.70 63.19 40.78%
bitmap_4444_A_scale_bilerp 83.05 62.25 25.04%
bitmap_a8 98.11 52.76 46.22%
bitmap_a8_A 98.24 52.85 46.20%
BUG=
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
179443003
git-svn-id: http://skia.googlecode.com/svn/trunk@13699
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 03:25:32 +0000 (03:25 +0000)]
SSE2 implementation of S32_D565_Opaque_Dither
Run benchmarks with command line option "--forceDither true". The result
shows that all benchmarks exercised S32_D565_Opaque_Dither benefit from
this SSE2 optimization. Here are the data on i7-3770:
before after
constXTile_MM_filter 900.93 217.75 75.83%
constXTile_CC_filter_scale 907.59 225.65 75.14%
constXTile_RR_filter 903.33 219.41 75.71%
constXTile_MM_scale 902.45 221.46 75.46%
constXTile_CC 898.55 218.37 75.70%
constXTile_RR_scale 902.69 222.35 75.37%
repeatTile_4444_X 938.53 240.49 74.38%
gradient_radial2_mirror 16999.49 11540.39 32.11%
gradient_radial2_clamp_hicolor 17943.38 12501.71 30.33%
gradient_radial2_clamp 17816.36 12492.04 29.88%
bitmaprect_FF_filter_trans 47.81 10.98 77.03%
bitmaprect_FF_nofilter_trans 47.79 10.91 77.18%
bitmaprect_FF_filter_identity 47.74 10.89 77.18%
bitmaprect_FF_nofilter_identity 47.83 10.89 77.24%
bitmap_4444_update_scale_rotate_bilerp 100.45 76.84 23.50%
bitmap_4444_update_volatile_scale_rotate_bilerp 100.80 76.70 23.91%
bitmap_4444_scale_rotate_bilerp 100.43 77.18 23.15%
bitmap_4444_update_scale_bilerp 79.00 49.03 37.93%
bitmap_4444_update_volatile_scale_bilerp 78.90 48.87 38.06%
bitmap_4444_scale_bilerp 78.92 48.81 38.16%
bitmap_4444_update 42.19 11.53 72.68%
bitmap_4444_update_volatile 42.28 11.49 72.82%
bitmap_a8 60.37 29.75 50.72%
bitmap_4444 42.19 11.52 72.69%
BUG=
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
181293002
git-svn-id: http://skia.googlecode.com/svn/trunk@13698
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 03:25:16 +0000 (03:25 +0000)]
Add SkCanvas::writePixels that takes info+pixels directly
add corresponding methods to device (w/ diff name to avoid colliding with exising virtuals)
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com, junov@google.com, junov@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
180113010
git-svn-id: http://skia.googlecode.com/svn/trunk@13697
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 03:24:41 +0000 (03:24 +0000)]
Add a class to allocate small objects w/o extra calls to new.
Add SkSmallAllocator, a template for allocating small (as defined by the
instantiation) objects without extra calls to new. Add a helper macro to
make using it simple.
Remove SkTemplatesPriv.h, whose behavior is replaced by SkSmallAllocator.
The old SK_PLACEMENT_NEW had the following drawbacks:
- Easily confused with SkNEW_PLACEMENT.
- Requires passing around lots of void*s along with the storageSize.
- Requires using a separate class for deleting it.
- We had multiple ways Auto objects for deleting in different places.
- It always did a straight heap allocation on Windows, meaning Windows
did not get any advantages from the confusing code.
The new SkSmallAllocator simplifies things:
- It is clear about what it does.
- It takes care of the deletion in one place that is automatically
handled.
Further, the new class can be used to create more than one object. This
is in preparation for BUG=skia:1976, for which we would like to create
a new object without extra heap allocations. The plan is to create both
the blitter and the new object on the stack using the SkSmallAllocator.
Add a new test for SkSmallAllocator.
SkShader.h:
Move the private version of CreateBitmapShader to SkBitmapProcShader
(which already has the implementation) and remove the friend class
(which was only used to call this private function). This allows
SkSmallAllocator to reside in the private src/ directory.
SkBitmapProcShader:
Move CreateBitmapShader and the macro for the storage size here. With
the macro in a (private) header, the (private) headers with function
declarations (which now depend on the storage size used) can see the
macro.
Use SkSmallAllocator in CreateBitmapShader.
Change the macro to kBlitterStorageByteCount, since SkSmallAllocator
takes a byte count as its template parameter.
SkBlitter:
Use the SkSmallAllocator.
Remove Sk3DShader::fKillProc and SkAutoCallProc. Both of their
behaviors have been moved into SkSmallAllocator (SkAutoCallProc was
unnecessary anyway, because the only time we ever used it we also
called detach(), so its auto behavior never happened).
Create the Sk3DShader on the stack, if there's room.
Remove the helper version of Choose, which was unused.
SmallAllocatorTest:
Test for the new class.
The rest:
Use SkSmallAllocator.
BUG=skia:1976
R=reed@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
179343005
git-svn-id: http://skia.googlecode.com/svn/trunk@13696
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 23:38:52 +0000 (23:38 +0000)]
Yet another whitespace change to see if the bots are fixed
NOTRY=true
NOTREECHECKS=true
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
189453002
git-svn-id: http://skia.googlecode.com/svn/trunk@13695
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 23:08:33 +0000 (23:08 +0000)]
Whitespace change to verify that the bots are fixed
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
NOTREECHECKS=true
NOTRY=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
189253003
git-svn-id: http://skia.googlecode.com/svn/trunk@13694
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 21:48:57 +0000 (21:48 +0000)]
Whitespace change to test whether builders are fixed
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
188633005
git-svn-id: http://skia.googlecode.com/svn/trunk@13693
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 20:53:44 +0000 (20:53 +0000)]
Add debug check of chunk size written to skp
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
182153003
git-svn-id: http://skia.googlecode.com/svn/trunk@13692
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 20:34:02 +0000 (20:34 +0000)]
Mark mixed_xfermodes_gpu on Win7 perspective bot as ignore-failure
BUG=skia:2262
NOTRY=true
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
183803034
git-svn-id: http://skia.googlecode.com/svn/trunk@13691
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:56:58 +0000 (19:56 +0000)]
Remove MCRec.fNext
No longer used.
R=reed@google.com, mtklein@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
186973004
git-svn-id: http://skia.googlecode.com/svn/trunk@13690
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:29:24 +0000 (19:29 +0000)]
Manually add baseline for typeface_565
BUG=skia:2146
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
180533011
git-svn-id: http://skia.googlecode.com/svn/trunk@13689
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:23:51 +0000 (19:23 +0000)]
Actually, we wrote only size bytes.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
188343004
git-svn-id: http://skia.googlecode.com/svn/trunk@13688
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:10:44 +0000 (19:10 +0000)]
Avoid recomputing two consecutive identical 1D filters.
If the arguments to the X and Y filter computation are identical,
the results will be identical; copying is much faster than recomputing.
With a change like https://codereview.chromium.org/
183763047/ applied
this speeds up BitmapScaleBench on Linux by around 10%.
BUG=skia:2236
R=humper@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
188743002
git-svn-id: http://skia.googlecode.com/svn/trunk@13687
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:47:49 +0000 (17:47 +0000)]
Make arm64 test script more efficient with old versions of gsutil.
This continues the changes indtroduced in
<https://codereview.chromium.org/
183883020>, and also simplifies the
script considerably.
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
176973010
git-svn-id: http://skia.googlecode.com/svn/trunk@13686
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:16:37 +0000 (17:16 +0000)]
Adding this call simulates seeing a *different* bitmap every time we scale, which changes the code path (places much heavier load on constructing a new filter). This better emulates the kind of environment most embedders see us in, where they try to cache a scaled bitmap rather than frequently rescaling it.
This change will cause significant regressions in microbenchmark scores.
BUG=skia:2236
R=humper@google.com, reed@google.com, scroggo@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
183763047
git-svn-id: http://skia.googlecode.com/svn/trunk@13685
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:16:26 +0000 (17:16 +0000)]
Add size_t bytesWritten() const to SkWStream.
BUG=skia:
R=reed@google.com, mtklein@google.com, robertphillips@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
187653003
git-svn-id: http://skia.googlecode.com/svn/trunk@13684
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 6 Mar 2014 15:37:53 +0000 (15:37 +0000)]
Revert of Manually set fFilterValues in SkConvolutionFilter1D
Revert of https://codereview.chromium.org/
184323003
Reason for revert:
Caused unexpected CompareGM failures-
http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86_64-Debug/builds/461/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Release/builds/2062/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/1400/steps/CompareGMs/logs/stdio
TBR=
NOTREECHECKS=True
NOTRY=True
git-svn-id: http://skia.googlecode.com/svn/trunk@13683
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 15:13:53 +0000 (15:13 +0000)]
Begin making SkPerlinNoiseShader const.
The overall goal is to make SkShader itself immutable (BUG=skia:1976).
The fields cannot yet be made constant, due to the constructor which
takes an SkReadBuffer. Other than that constructor, the fields are now
unchanged.
Remove setTileSize and initPaint. Merge initPaint with the constructor
of PaintingData, since it is only ever used on a new PaintingData.
Merge setTileSize with the SkPerlinNoiseShader constructor, its only
call site.
BUG=skia:1976
R=reed@google.com, sugoi@google.com, dominikg@chromium.org, senorblanco@google.com, senorblanco@chromium.org
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
169973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13682
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 14:57:46 +0000 (14:57 +0000)]
Manually set fFilterValues in SkConvolutionFilter1D.
Using fFilterValues.reset() or a loop of fFilterValues.push_back() is about 5x slower than calling fFilterValues.resize_back() and then looping using primitive [] and =.
This is only going to show up if you apply https://codereview.chromium.org/
183763047/, where it yields about 2.5% speedup in the bitmap resize microbenchmarks on a Linux desktop. Ceteris paribus, it should actually improve rasterization time of drawBitmapRectToRect() with a resize by about 5% in Chromium.
BUG=skia:2258
R=humper@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
184323003
git-svn-id: http://skia.googlecode.com/svn/trunk@13681
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 13:18:07 +0000 (13:18 +0000)]
Now that the matching changes have landed in Chromium we can clean up the API on our side.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
187553003
git-svn-id: http://skia.googlecode.com/svn/trunk@13680
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 6 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13679
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 20:59:45 +0000 (20:59 +0000)]
Give PictureTest more verbose error messages.
Motivation: On an odd build system I'm testing, we're triggering these
errors. More verbose test output will help me diagnose the errors.
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
183023014
git-svn-id: http://skia.googlecode.com/svn/trunk@13678
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 20:49:59 +0000 (20:49 +0000)]
Update baselines for Win7 perspective and Nexus4
BUG=skia:2146
NOTRY=true
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
185943007
git-svn-id: http://skia.googlecode.com/svn/trunk@13677
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 19:46:17 +0000 (19:46 +0000)]
rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images
BUG=skia:2248,skia:2231
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
183893030
git-svn-id: http://skia.googlecode.com/svn/trunk@13676
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 19:41:10 +0000 (19:41 +0000)]
Fix FontMgrTest to allow for unnamed fonts.
Motivation: we are testing on a system without fonts and are falling
back on SkTypeface_Empty.
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
187933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13675
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 18:27:43 +0000 (18:27 +0000)]
Unify edge type enums across GrEffect subclasses that clip rendering to a geometry.
BUG=skia:
R=egdaniel@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
183893023
git-svn-id: http://skia.googlecode.com/svn/trunk@13674
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 18:25:20 +0000 (18:25 +0000)]
This CL is motivated by the desire to make the skpinfo tool work a bit better. The main concern is that the assumptions made w.r.t. written bytes may not be valid for all SkWStream sub-classes.
R=bungeman@gmail.com, bungeman@google.com, reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
182733008
git-svn-id: http://skia.googlecode.com/svn/trunk@13673
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 17:09:46 +0000 (17:09 +0000)]
Remove unused TimerData that generates errors
As far as I can tell all uses of TimerData::appendTimes were stripped out in https://chromiumcodereview.appspot.com/
23121002 but the surrounding code was left in, causing it to print errors when there are none.
BUG=skia:2242
R=sglez@google.com, tomhudson@chromium.org, mtklein@google.com, tomhudson@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
187643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13672
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 5 Mar 2014 16:26:14 +0000 (16:26 +0000)]
Prevent SkBlockMemoryStream::skip from writing to low memory.
SkBlockMemoryStream::read was modeled on SkDynamicMemoryWStream::read.
However, SkDynamicMemoryWStream::read does not allow passing a NULL buffer
and SkBlockMemoryStream::read must correctly handle this case for skips.
In the current code, if a 'skip' crosses a block boundary, 'read' may
attempt to write to low memory.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
187683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13671
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 5 Mar 2014 15:38:21 +0000 (15:38 +0000)]
New baselines for offsetimagefilter GM.
TBR=rmistry@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
187883002
git-svn-id: http://skia.googlecode.com/svn/trunk@13670
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 15:37:11 +0000 (15:37 +0000)]
DM: read image files without an extra copy
BUG=skia:
R=halcanary@google.com, reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185263012
git-svn-id: http://skia.googlecode.com/svn/trunk@13669
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 14:16:36 +0000 (14:16 +0000)]
Make arm64 test script comaptable with old versions of gsutil.
NOTRY=true
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
183883020
git-svn-id: http://skia.googlecode.com/svn/trunk@13668
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 13:44:18 +0000 (13:44 +0000)]
Replace scaled bitmap if entry already exist in cache.
BUG=skia:2251
R=reed@google.com
Author: reveman@chromium.org
Review URL: https://codereview.chromium.org/
185263009
git-svn-id: http://skia.googlecode.com/svn/trunk@13667
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 13:43:15 +0000 (13:43 +0000)]
remove deprecated use of bitmap config from tests
BUG=skia:
R=halcanary@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
184233003
git-svn-id: http://skia.googlecode.com/svn/trunk@13666
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 5 Mar 2014 03:02:06 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13665
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 02:34:58 +0000 (02:34 +0000)]
remove SK_SUPPORT_DEEPCOPYTO_CONFIG code -- no longer used
R=reed@google.com
TBR=bsalomon@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
183763035
git-svn-id: http://skia.googlecode.com/svn/trunk@13664
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 01:00:50 +0000 (01:00 +0000)]
Counterproposal to
182733007: Add iterator to SkTDynamicHash
BUG=skia:
R=egdaniel@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
177263005
git-svn-id: http://skia.googlecode.com/svn/trunk@13663
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 22:37:29 +0000 (22:37 +0000)]
Manual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf regression.
BUG=344020
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
187023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13662
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 22:32:49 +0000 (22:32 +0000)]
Fix error in barelinux_make build script
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
187093002
git-svn-id: http://skia.googlecode.com/svn/trunk@13661
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 20:44:32 +0000 (20:44 +0000)]
Factor out a BaseContext from JsContext.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
186783004
git-svn-id: http://skia.googlecode.com/svn/trunk@13660
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Mar 2014 19:22:43 +0000 (19:22 +0000)]
New baselines for imagefiltersclipped, imagefiltersscaled GMs.
Required after r13637.
TBR=rmistry@google.com
Review URL: https://codereview.chromium.org/
186933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13659
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 19:08:57 +0000 (19:08 +0000)]
The motivation for this CL is to de-clutter SkPicture's beginRecording method.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
186813003
git-svn-id: http://skia.googlecode.com/svn/trunk@13658
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 19:05:50 +0000 (19:05 +0000)]
Start prototyping what DisplayList support will look like.
None of the new codepaths get executed yet since DisplayList doesn't exist, but that will happening in the new few CLs.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
183883017
git-svn-id: http://skia.googlecode.com/svn/trunk@13657
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Mar 2014 19:05:25 +0000 (19:05 +0000)]
Apply the CTM to the offset in the slow SkOffsetImageFilter path.
This was being done in the fast path, but not the slow path.
Since I had to rebaseline the offsetimagefilter GM anyway (to accomodate
the new test case), I added a red border around the intersection
of the (transformed) crop rect and clip rect in each sample, beyond
which no pixels should be drawn.
Chrome bug: https://code.google.com/p/chromium/issues/detail?id=346362
BUG=skia:
R=sugoi@google.com
Review URL: https://codereview.chromium.org/
186643003
git-svn-id: http://skia.googlecode.com/svn/trunk@13656
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Mar 2014 16:52:20 +0000 (16:52 +0000)]
Make rrects.cpp compile in no-gpu mode
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
186663004
git-svn-id: http://skia.googlecode.com/svn/trunk@13655
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 16:46:22 +0000 (16:46 +0000)]
rebaseline_server: better reporting for bad URL fetch
context: https://codereview.chromium.org/
183763025/ ('vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own')
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
183833019
git-svn-id: http://skia.googlecode.com/svn/trunk@13654
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 16:25:34 +0000 (16:25 +0000)]
Add GM that directly tests GrRRectEffect and add inverse fill version of effect.
BUG=skia:
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
176843016
git-svn-id: http://skia.googlecode.com/svn/trunk@13653
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 14:41:52 +0000 (14:41 +0000)]
New baselines for perspective switch
BUG=skia:2245
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
186563004
git-svn-id: http://skia.googlecode.com/svn/trunk@13652
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 4 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13651
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 00:58:21 +0000 (00:58 +0000)]
rebaseline_server: keep going on exception in ImagePair.__init__()
BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
184103022
git-svn-id: http://skia.googlecode.com/svn/trunk@13650
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:41 +0000 (23:25 +0000)]
This adds cull rect visualization to the debugger's "mega" visualization mode.
R=fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
177423013
git-svn-id: http://skia.googlecode.com/svn/trunk@13649
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:26 +0000 (23:25 +0000)]
Don't emit declaration of gl_FragPos unless also changing the origin.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
182003002
git-svn-id: http://skia.googlecode.com/svn/trunk@13648
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 22:50:13 +0000 (22:50 +0000)]
bench rebase after skp update.
BUG=skia:2163
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
182443005
git-svn-id: http://skia.googlecode.com/svn/trunk@13647
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 3 Mar 2014 22:13:56 +0000 (22:13 +0000)]
Cleanup patch to move all of SkImageFilterUtils into SkImageFilter.
This was a utility class that dates from before GPU code was allowed
in core. Now that it is, there's no reason not to have this
functionality in SkImageFilter.
Covered by existing tests.
R=reed@google.com
Review URL: https://codereview.chromium.org/
185973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13646
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:31:08 +0000 (19:31 +0000)]
Baselines for skia:2146
BUG=skia:2146
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
180253004
git-svn-id: http://skia.googlecode.com/svn/trunk@13645
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:23:28 +0000 (19:23 +0000)]
Rename test files to end with Test.cpp.
DM builds all of {bench,gm,test}/*.cpp. A Windows build warned us that we were
trying to link typeface.obj twice. This must have something to do with there
existing gm/typeface.cpp and tests/Typeface.cpp. To be safe, make sure tests
have a Test.cpp suffix to disambiguate.
BUG=skia:
R=rmistry@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185923002
git-svn-id: http://skia.googlecode.com/svn/trunk@13644
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:18:39 +0000 (19:18 +0000)]
Generating the 1M skps frequently yields truncated skps. This tool is intended to help automate weeding these out.
Please see skbug:1057
rmistry for tools, gyp
mtklein for src\core & include\core
BUG=skia:1057
R=rmistry@google.com, mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
176863004
git-svn-id: http://skia.googlecode.com/svn/trunk@13643
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 17:57:41 +0000 (17:57 +0000)]
roll_deps: Return a tuple even when returning early
This fixes the bot going red when DEPS is already up-to-date.
BUG=skia:
R=halcanary@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
185413012
git-svn-id: http://skia.googlecode.com/svn/trunk@13642
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 17:51:12 +0000 (17:51 +0000)]
Add the ability to select bbh type, and include quadtree support.
This is a breaking change to tileGridSize flag added in
184543003, as it now defaults to a sensible value but does not implicitly turn on the tile grid bbh.
BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, skyostil@chromium.org, skyostil@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
183763022
git-svn-id: http://skia.googlecode.com/svn/trunk@13641
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 16:32:17 +0000 (16:32 +0000)]
The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves).
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
185293007
git-svn-id: http://skia.googlecode.com/svn/trunk@13640
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 15:44:56 +0000 (15:44 +0000)]
DM: tweak output.
Show task name in verbose mode only, and add task runtime.
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185233004
git-svn-id: http://skia.googlecode.com/svn/trunk@13639
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 15:43:56 +0000 (15:43 +0000)]
DM: fix -w/-r problems stemming from PM/UPM conversions.
DM will now read and write a custom image format, which begins first with a
normal PNG, but also includes the bitmap's raw pixels. Most tools (file
browser, Preview, Chrome, Skia image decoder) will read the file as PNG. DM
skips the encoded PNG and reads the raw pixels instead.
This scheme allows perfect pixel comparisons that never go through PM -> UPM or
UPM -> PM conversions, as long as you compare on a machine with the same native
pixel format as the machine which generated the images. Since we've only ever
used this to do same-machine comparisons, that's more than good enough for now.
We could convert as needed to a standardized PM pixel format if we find we want
these files to be portable.
DM -w output now does increase to ~1.3G. If that turns out to be annoyingly
big, I'm sure I can come up with a simple pixelwise RLE instead of writing
uncompressed pixels.
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185343002
git-svn-id: http://skia.googlecode.com/svn/trunk@13638
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log