platform/upstream/efl.git
2 years agoRevert "vg_common_json: No path information, do not create a shape" 63/268563/1 accepted/tizen/unified/20211228.140402 submit/tizen/20211227.054708
Chun [Mon, 27 Dec 2021 02:47:16 +0000 (02:47 +0000)]
Revert "vg_common_json: No path information, do not create a shape"

This reverts commit b688e1d312aa33ac3c71c7aeac783bdbefc0fb78.

Change-Id: I82a45e07b36057bfce1238fa56c80a423ff3f293

2 years agovg_common_json: No path information, do not create a shape 77/268377/1 submit/tizen/20211227.021527
JunsuChoi [Wed, 22 Dec 2021 04:18:26 +0000 (20:18 -0800)]
vg_common_json: No path information, do not create a shape

Change-Id: Ic016bf3e41d8fd706c31973a78b3c6825d0941b4

2 years agoecore_wl2_input: fix calibration logic for repeating key event 52/268252/1
Hosang Kim [Fri, 17 Dec 2021 09:47:10 +0000 (18:47 +0900)]
ecore_wl2_input: fix calibration logic for repeating key event

Change-Id: I6f444b2a71e6e4d2c0379b0ffad8e755d9375ee0

2 years agoevas canvas: remove tizen only code. 06/268206/2
Hermet Park [Fri, 17 Dec 2021 04:48:19 +0000 (13:48 +0900)]
evas canvas: remove tizen only code.

remove the temporary api usage,
correct the right api call.

Change-Id: I49077d27845a16c1b8722accc295513510eafdc7

2 years agoecore_wl2_input: fix order of calcuation 92/268092/1
Hosang Kim [Thu, 16 Dec 2021 05:51:36 +0000 (14:51 +0900)]
ecore_wl2_input: fix order of calcuation

Change-Id: I5e77796721ebfacc37bfc6ed9ca68067d7398b1a

2 years agoefl: remove unnecessary packed files 65/268065/1
Shinwoo Kim [Wed, 15 Dec 2021 11:31:11 +0000 (20:31 +0900)]
efl: remove unnecessary packed files

This patch will remove unexpected installed files such as

/usr/lib/debug/.build-id
/usr/lib/debug/.build-id/00
/usr/lib/debug/.build-id/00/6352bb9b60c759f3a3fbe71636aa1af486cbaf
/usr/lib/debug/.build-id/00/6352bb9b60c759f3a3fbe71636aa1af486cbaf.debug
...

Change-Id: Ife39da7694e887ac95edde9157e6a6e7baf16268

2 years agoefl: remove touch position log for improving security. 12/267912/1
Hosang Kim [Mon, 13 Dec 2021 07:03:13 +0000 (16:03 +0900)]
efl: remove touch position log for improving security.

Change-Id: Icb99aba71e486a71d6f7f87258ca246a005b7b9e

2 years agodnd: keep the order of enter and leave event for dnd 71/267671/2 accepted/tizen/unified/20211210.115209 submit/tizen/20211209.063123
Taehyub Kim [Wed, 8 Dec 2021 11:34:34 +0000 (20:34 +0900)]
dnd: keep the order of enter and leave event for dnd

Change-Id: I97ce6ee2a26d7c24d25a403cd4e44db383a4cc53

2 years agoelm_cnp: keep the copy and paste selection backword compatibility 74/267674/1
Taehyub Kim [Wed, 8 Dec 2021 11:39:17 +0000 (20:39 +0900)]
elm_cnp: keep the copy and paste selection backword compatibility

Change-Id: Icf64b185929bc2b04911adcb08ebdd98b63807d9

2 years agoevas common: remove lru optimization. 18/267518/2
Hermet Park [Mon, 6 Dec 2021 12:01:53 +0000 (21:01 +0900)]
evas common: remove lru optimization.

This lru optimization is useless because we have already reference count,
Actually, we can't remove the data even though the cache capacity is full
because those are completed referenced.

This mis-implementation occurs the memory leak.

Change-Id: If25e843bcbb6759df81e87c076a002bf771ea1b1

2 years agoevas: fixed memory leak on lottie images container destruction 86/267386/2
Michal Maciola [Thu, 2 Dec 2021 13:04:55 +0000 (14:04 +0100)]
evas: fixed memory leak on lottie images container destruction

Change-Id: I43798742ce06b69fe0691c1c98a0c6b1548b5e3e

2 years agoecore evas extn: Check queue pointer before use. 48/267248/3
Michal Szczecinski [Tue, 30 Nov 2021 08:42:30 +0000 (09:42 +0100)]
ecore evas extn: Check queue pointer before use.

This commit increates safety of _compositor_socket_get() API.

Change-Id: I44ca3a2a095cba9f1aa073bd7749ec008de358f0

2 years ago[AT-SPI] Fixed providing number of items for objects of AT_SPI role DIALOG and POPUP_MENU 69/267169/5
Maria Bialota [Fri, 26 Nov 2021 20:29:42 +0000 (21:29 +0100)]
[AT-SPI] Fixed providing number of items for objects of AT_SPI role DIALOG and POPUP_MENU

Change-Id: I074172a98064da6e1bc7fb957feb1c7ed4a8fe1a

2 years agoedje lua2: check string ptr before dereference 17/267217/1
Taehyub Kim [Tue, 30 Nov 2021 01:48:37 +0000 (10:48 +0900)]
edje lua2: check string ptr before dereference

Summary: fix null pointer dereference

Reviewers: Hermet, kimcinoo, jsuya, raster

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12309

Change-Id: I32e0edbdf7709b516acaa6d91c7b734b36adab9d

2 years agoevas: Fixed invalid sanity check 90/265490/4 accepted/tizen/unified/20211130.125551 submit/tizen/20211125.062540 submit/tizen/20211129.000112
Michal Szczecinski [Wed, 20 Oct 2021 11:53:06 +0000 (13:53 +0200)]
evas: Fixed invalid sanity check

Change-Id: I35f2674d5a29c52cba5540439ec92fb59829da7c

2 years agoecore_wl2: add events for interactive move/resize done 78/266878/1
Doyoun Kang [Mon, 22 Nov 2021 04:22:58 +0000 (13:22 +0900)]
ecore_wl2: add events for interactive move/resize done

Event Type
- ECORE_WL2_EVENT_WINDOW_INTERACTIVE_MOVE_DONE
- ECORE_WL2_EVENT_WINDOW_INTERACTIVE_RESIZE_DONE

Event Structure
- Ecore_Wl2_Event_Window_Interactive_Move_Done
- Ecore_Wl2_Event_Window_Interactive_Resize_Done

Change-Id: I4752611802a3dc9268f7941d769dc20ae399f992

2 years agoevas vg shape: gradient taken from the proper source 88/266588/4
Mira Grudzinska [Tue, 16 Nov 2021 01:13:49 +0000 (02:13 +0100)]
evas vg shape: gradient taken from the proper source

When a shape with the gradient is duplicated, the gradient
adr was taken from the source obj instead of from the target
of the duplication.
In TVG, when a shape is duplicated all its properties, like grad,
are duplicated as well. EFL created independently a new gradient,
which has to be relased first and replaced by the one created
in TVG.

Change-Id: I0848b0591671b6e69148b0d248a0ba0c8bd66726

2 years agoecore_wl2_input: unref device before device is deleted. 99/266599/2
Hosang Kim [Tue, 16 Nov 2021 05:28:47 +0000 (14:28 +0900)]
ecore_wl2_input: unref device before device is deleted.

@fix

Change-Id: I96a09ae32b768ebb9c54bf8ade2a95f14721432a

2 years agovg: update the tvg apis 62/265762/3
Hermet Park [Thu, 28 Oct 2021 06:28:44 +0000 (15:28 +0900)]
vg: update the tvg apis

These apis has been modified under the beta.
now we correct it with the latest ones.

Change-Id: I52fdbe2d28da29057db8b61d3965b8351f5f069d

2 years agoevas_font_query: fix ARABIC HAMZA ABOVE render issue 78/266378/2
Bowon Ryu [Thu, 11 Nov 2021 07:22:35 +0000 (16:22 +0900)]
evas_font_query: fix ARABIC HAMZA ABOVE render issue

INHERITED skip prevents ARABIC_HAMZA_ABOVE from rendering standalone.
Do not skip when ARABIC_HAMZA_ABOVE is at the begginning of an arabic word.

Change-Id: I75d5206194543031fcfe81f5ed208a8b404fc26a
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
2 years agoefl_ui_win: delete ecore_evas when inlined image window is deleted 73/266073/3 accepted/tizen/unified/20211109.042919 submit/tizen/20211108.084528
Hosang Kim [Fri, 5 Nov 2021 07:02:35 +0000 (16:02 +0900)]
efl_ui_win: delete ecore_evas when inlined image window is deleted

When inlined image window is deleted, associated image object and ecore
evas are not deleted. So there is memory leak.

@tizen_only

Change-Id: Iab248b0cf0bfe3f3a9f81a8eb8604a68218be232

2 years agoefl_canvas_image : remove the animated image limitation 08/266108/1
Taehyub Kim [Thu, 4 Nov 2021 07:38:48 +0000 (16:38 +0900)]
efl_canvas_image : remove the animated image limitation

Summary: remove FRAME_MAX limitation to play the huge animated image which has more than 1024 frames

Test Plan: load gif image which has more than 1024 frames

Reviewers: Hermet, kimcinoo

Reviewed By: Hermet

Subscribers: raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12303

Change-Id: I59bd00d0e2fb647805c70230df72f4e811a6e58c

2 years agowayland_egl: fix egl attribute type 06/265806/2
Changyeon Lee [Fri, 29 Oct 2021 04:58:59 +0000 (13:58 +0900)]
wayland_egl: fix egl attribute type

attribute of evas_gl_common_eglCreateImage is EGLAttrib

Change-Id: I8afbfc98c4aa8b363dd75d16a6ea86744eb3dee7

2 years agowayland_egl: fix checking egl extension for native image 79/265779/3
Changyeon Lee [Thu, 28 Oct 2021 06:05:49 +0000 (15:05 +0900)]
wayland_egl: fix checking egl extension for native image

initial value of has_tizen_native_surface and has_dma_buf_import
is EINA_TRUE.
it is changed to EINA_FALSE after checking extension in gl_extn_veto.

Change-Id: I74224e3ff696774d46063dc3e2cb3d4a5343d40c

2 years agoevas vg json: fix invisible layer 87/265787/2 accepted/tizen/unified/20211102.024819 submit/tizen/20211101.025718
Michal Maciola [Thu, 28 Oct 2021 11:35:01 +0000 (13:35 +0200)]
evas vg json: fix invisible layer

This patch fixes the reported rendering bug for particular json files.
If the layer was invisible, it was skipped and not rendered, but if it had
some masking layer, it was incorrectly applied for previous layer as a parent.
This fixes incorrect behaviour by skipping these masking layer.

Change-Id: I9015e47b83d479d6ac3e644fcd52551df8836042

2 years agotests: enhance evas_map test
Shinwoo Kim [Mon, 18 Oct 2021 08:10:17 +0000 (09:10 +0100)]
tests: enhance evas_map test

Reviewers: raster, Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12296

2 years agotests: add evas_map test
Shinwoo Kim [Tue, 12 Oct 2021 07:36:23 +0000 (08:36 +0100)]
tests: add evas_map test

Reviewers: raster, Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12295

2 years agoevas_render: fix a mistake of ++safety 89/265489/1
Shinwoo Kim [Wed, 20 Oct 2021 11:13:26 +0000 (20:13 +0900)]
evas_render: fix a mistake of ++safety

There was a mistake of following commit.

   928c008 evas: ++safety

And it caused performance issue by not adding obscuring objects.

*tizen_fix

Change-Id: Ie0b376b12e74a4d32925e6ea2500084ad1399f97

2 years agoEcore_Wl2: move ecore_wl2_offer functions for the internal usage 91/265391/3
Taehyub Kim [Mon, 18 Oct 2021 05:36:33 +0000 (14:36 +0900)]
Ecore_Wl2: move ecore_wl2_offer functions for the internal usage

To implement the drag and drop feature in dali,
ecore_wl2_offer functions should be added to Ecore_Wl2.h

Change-Id: I78f872fe6493854a094901c03346b569a83928ee

2 years agoecore_wayland2: include eina 48/265348/1
Shinwoo Kim [Fri, 15 Oct 2021 08:22:43 +0000 (17:22 +0900)]
ecore_wayland2: include eina

If application includes Ecore_Wayland2.h without Eina.h,
then application will have build break as below.

   "error: unknown type name 'Eina_Bool'"

So this patch makes Ecore_Wayland2.h include Eina.h
to fix the application side build error.

Change-Id: Ibd8a65e4cee111c00305ac70b1a930bbb8e4e08d

2 years agoevas map: check source image size for direct render 84/264784/1 accepted/tizen/6.5/unified/20211028.225531 accepted/tizen/unified/20211007.154801 submit/tizen/20211007.055733 submit/tizen_6.5/20211028.163301 tizen_6.5.m2_release
Shinwoo Kim [Wed, 29 Sep 2021 12:54:45 +0000 (21:54 +0900)]
evas map: check source image size for direct render

The direct render is working correctly only if source image size
is equal to the size of smart object.

So this patch is cheking the size of source image.

Change-Id: I2e6c70360a477283903e4c494410c6683dfaa0c0

2 years agoevas: reset change after map direct render 56/264656/3 accepted/tizen/unified/20210929.022336 submit/tizen/20210928.143216
Shinwoo Kim [Tue, 28 Sep 2021 02:30:13 +0000 (11:30 +0900)]
evas: reset change after map direct render

There is a flickering issue which is caused by absence of reset.

If the source image does not reset, then it remains in pending objects
array at the end of  evas_render_updates_internal, and it keeps the
'obj->changed' as TRUE for next frame. And it makes its parent 'changed'
value TRUE as well.

But after handling pending objects array, we are handling render objects
array. The parent 'changed' value is set to FALSE.

As a result, the parent object does not draw on the next frame, and its
children including the source image neither.
(no push to restack objects array, render_pre, output_redraws_rect_add)

Even though there is a change on the source image for the next frame,
(for example, evas_object_color_set)
it cannot makes the parent object 'changed' value TRUE,
(see the logic of evas_object_change)
because the source image 'changed' is already TRUE by the logic handling
pending objects array on the previous frame.

We are calling evas_object_change_reset after evas_render_mapped.
So, same logic should exist for the map direct render.

*tizen_fix

Change-Id: If8b57a8f423e25f0c1f91a90dc30ac1f2c8b4972

2 years agoevas vg: fix for invisible masking layer 72/264572/3 accepted/tizen/unified/20211001.001525 submit/tizen/20210928.074404
Michal Maciola [Fri, 24 Sep 2021 12:02:33 +0000 (14:02 +0200)]
evas vg: fix for invisible masking layer

This patch solves the problem of masking on layers that visibility
is set to false.

Change-Id: I0d96362709e551d8dadf151d7fd79ddb39e8ce7d

2 years agoeo_base_class: Avoid useless memory alloc 90/264590/1
Woochanlee [Thu, 24 Dec 2020 02:47:03 +0000 (11:47 +0900)]
eo_base_class: Avoid useless memory alloc

Summary:
The pd->ext will be NULL when the target object on invalidate state or edje object or isolated object etc..

In above case, If data is NULL and ext is not needed, it seems there is no need to create a node.

Reviewers: raster, cedric, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12206

Change-Id: I7000fd4cbf48c0841865483092e5b778602886d1

2 years agoevas vg: json/lottie memory usage optimization 72/264272/1
Michal Maciola [Wed, 15 Sep 2021 08:41:02 +0000 (10:41 +0200)]
evas vg: json/lottie memory usage optimization

This patch fixes potential memory leaks and unnecessary allocations.

Change-Id: I515c5a809dc5b23e433514aad177dcbda47beb75

2 years agocommon json: fix for an empty layer used as a mask 35/264235/2 accepted/tizen/unified/20210916.123547 submit/tizen/20210915.070054
Michal Maciola [Tue, 14 Sep 2021 14:51:32 +0000 (16:51 +0200)]
common json: fix for an empty layer used as a mask

If a layer is empty, do not use it as a mask, so not to incorrectly completely
hide a parent layer.

Change-Id: Ia48b0b150faa3a1fd44cc79c16facab14ab00564

2 years agoevas vg: Added localization support in append path API. 46/264146/6
Michal Szczecinski [Mon, 13 Sep 2021 17:13:04 +0000 (19:13 +0200)]
evas vg: Added localization support in append path API.

In some languages strtod function don't parse '.' and ',' properly. Due
to this issue set locale part was added. Now path is parsed in the same
way as it was in efl_gfx API.

Change-Id: Ibcd0e460e0dad0e09a0ff08365418aab670194ca

2 years agoupdated edje license. 81/264181/2
Hermet Park [Tue, 14 Sep 2021 06:00:16 +0000 (15:00 +0900)]
updated edje license.

edje uses BSD license and its tools(epp) uses GPL.

Change-Id: Idc18fa7a0db0865d106f129eab94350837aa5f48

2 years agoevas_vg refactoring: thorvg svg loader: edje 49/261149/5 accepted/tizen/unified/20210910.004743 submit/tizen/20210909.071105
Michal Maciola [Mon, 12 Jul 2021 10:39:38 +0000 (12:39 +0200)]
evas_vg refactoring: thorvg svg loader: edje

This patch changes evas svg loader to using thorvg svg loader.
The patch extands .svg only; .svgz and .svg.gz will be loaded using old loader.
For edje_cc support (edj/edc files), svg file content is written into edj.

Patch is divided into two parts- edje & evas. This is edje part.

Change-Id: I716fa0a8b2e5bc23d2b262bb4b134a7972a545ce

2 years agoecore_wl2: add code to handle below_child 67/263467/2
Doyoun Kang [Fri, 3 Sep 2021 04:19:04 +0000 (13:19 +0900)]
ecore_wl2: add code to handle below_child

If the child window wants to place under the parent window, then we call the
tizen_policy_set_parent_with_below(). Otherwise, we call the tizen_policy_set_parent().

@tizen_only

Change-Id: I8a8e8887bae52624bac763b790db940abeef8f79
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
2 years agoecore_wl2_window: add fallback code for ecore_wl2_window_transient_parent_set 66/263466/2
Doyoun Kang [Fri, 3 Sep 2021 04:05:12 +0000 (13:05 +0900)]
ecore_wl2_window: add fallback code for ecore_wl2_window_transient_parent_set

If the tizen_policy version is not supported tizen_policy_set_parent_with_below, then
ecore_wl2_window_transient_parent_set calls the ecore_wl2_window_parent_set instead.

@tizen_only

Change-Id: I83280f30c59e0eadab63daaa043910c5b9f7f5bd
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
2 years agoeina_thread: check if pthread_getschedparam fails 64/263164/1 accepted/tizen/unified/20210901.103715 submit/tizen/20210830.054133 submit/tizen/20210831.021621
Jaehyun Cho [Fri, 27 Aug 2021 05:55:15 +0000 (14:55 +0900)]
eina_thread: check if pthread_getschedparam fails

The return value of pthread_getschedparam is checked to know if it
fails.

Change-Id: Idef27abcdfc2de0dfcf6e746edaf2230258c3eed

2 years agoevas: set default values of strokeCap and strokeJoin to prevent inconsistency 41/263141/2
Michal Maciola [Thu, 26 Aug 2021 12:18:14 +0000 (14:18 +0200)]
evas: set default values of strokeCap and strokeJoin to prevent inconsistency

Default values of strokeCap and strokeJoin differs in EFL and THORVG.
Set EFL default values to prevent inconsistency

Change-Id: Ib935f7470f9d64a63b9dfdd06b6d0dcc50de8f29

2 years agoedje: remove debug message that is likely to break the memory. 22/263122/2
Hermet Park [Thu, 26 Aug 2021 09:36:22 +0000 (18:36 +0900)]
edje: remove debug message that is likely to break the memory.

There are potential scenarios that invalid edje objects are passed during the deletion sequence,
In this case, efl encounter the memory corruption, debug message doesn't helpful.

Although this might be the user problems but this bothers us to review the call stack from time to time.

So disable it.

Change-Id: Iccd18073e48135eb6d4fdbd84672c762341e41ee

2 years agoevas canvas: ++safety 97/262997/2
Hermet Park [Tue, 24 Aug 2021 09:37:56 +0000 (18:37 +0900)]
evas canvas: ++safety

+ null checking as for the exception handling.

Change-Id: I529d2730136f9b4ecf740e30b17664bd69f568b0

2 years agoevas_vg refactoring: thorvg svg loader: evas 47/261147/8
Michal Maciola [Mon, 12 Jul 2021 10:31:13 +0000 (12:31 +0200)]
evas_vg refactoring: thorvg svg loader: evas

This patch changes evas svg loader to using thorvg svg loader.
The patch extands .svg only; .svgz and .svg.gz will be loaded using old loader.
For edje_cc support (edj/edc files), svg file content is written into edj.

Patch is divided into two parts- edje & evas. This is evas part.

Change-Id: I3bbff14058daf737ec4c3c9b3244f1810649b948

2 years agoedje multisense: fix a broken implementation. 86/262586/4 accepted/tizen/unified/20210822.213311 submit/tizen/20210818.053418 submit/tizen/20210818.080539 submit/tizen/20210819.014835
Hermet Park [Fri, 13 Aug 2021 10:10:48 +0000 (19:10 +0900)]
edje multisense: fix a broken implementation.

The latest efl doesn't allow the null parent object.
efl_add_ref() is recommended in this case.

Also, apis doesn't allow the thread calls.
The calls must be synced on the main thread.

Change-Id: Id25ce83900b88bc7630710b808c9fe84b921cf6e

2 years agoevas render: add a null check for ++safety 33/262633/1
Hermet Park [Tue, 17 Aug 2021 04:45:20 +0000 (13:45 +0900)]
evas render: add a null check for ++safety

Change-Id: I202333d0ab79ad439b7c70fdacbda2041d015840

2 years agovg common json: Don't ignore layer opacity. 76/262576/2
Michal Szczecinski [Fri, 13 Aug 2021 09:06:49 +0000 (11:06 +0200)]
vg common json: Don't ignore layer opacity.

Some lottie files use translucent layers as a mask. We can't ignore
them. This commit pass layer opacity to tree to fix rendering issues in
some lottie files.

Change-Id: I05eb2eb43755c2ca3aa2194daeded76613b4d7d4

2 years agowayland_egl: use LINUX_DMA_BUF_EXT when EGLImage is created with tbm_surface 52/260552/9
Changyeon Lee [Wed, 23 Jun 2021 10:48:49 +0000 (19:48 +0900)]
wayland_egl: use LINUX_DMA_BUF_EXT when EGLImage is created with tbm_surface

It is possible gl driver doesn't support EGL_TIZEN_image_native_surface.
but if gl dirver support EGL_EXT_image_dma_buf_import, we can use it
instead of EGL_TIZEN_image_native_surface.

This patch try to use EGL_EXT_image_dma_buf_import extension if
EGL_TIZEN_image_native_surface extension isn't supported when
eglImage is created with tbm_surface.

Change-Id: Ia779101d32448d966343034495dad899574f8552

2 years agogl_tbm: use LINUX_DMA_BUF_EXT when EGLImage is created with tbm_surface 51/260551/9
Changyeon Lee [Tue, 18 May 2021 08:41:14 +0000 (17:41 +0900)]
gl_tbm: use LINUX_DMA_BUF_EXT when EGLImage is created with tbm_surface

It is possible gl driver doesn't support EGL_TIZEN_image_native_surface.
but if gl dirver support EGL_EXT_image_dma_buf_import, we can use it
instead of EGL_TIZEN_image_native_surface.

This patch try to use EGL_EXT_image_dma_buf_import extension if
EGL_TIZEN_image_native_surface extension isn't supported when
eglImage is created with tbm_surface.

Change-Id: Ie1c2c98ec1db14d46149911343aec55095f35853

2 years agoecore_evas: introduce ecore_evas_tbm_native_allocfunc_new 50/260550/7
Changyeon Lee [Tue, 18 May 2021 08:19:00 +0000 (17:19 +0900)]
ecore_evas: introduce ecore_evas_tbm_native_allocfunc_new

tizen display server needs to create ecore_evas by native_surface
and native_display of EGL created in display server if EGL driver
deosn't support tbm.

native_display and native_surface must be not destroyed before
ecore_evas is freed.

Change-Id: Id096c1c233f0f49112171ab4c824fff5aa58b898

2 years agoevas vg: minor changes in vg_common_json.c 29/262329/1
Michal Maciola [Fri, 6 Aug 2021 10:49:05 +0000 (12:49 +0200)]
evas vg: minor changes in vg_common_json.c

Change-Id: I5ee39ec5c2f73cd973e2023bfcef192bebf1f04c

2 years agoRevert "Revert "evas vg: lottie rendering optimization"" 97/262197/2
Hermet Park [Wed, 4 Aug 2021 03:07:09 +0000 (12:07 +0900)]
Revert "Revert "evas vg: lottie rendering optimization""

This reverts commit 5aecd0c3d221a402340e59f5ba7ec8ccb4f8ff07.

Change-Id: I7c3abc8c1f6599434ebacf15c918fff7a1392c0c

2 years agoevas vg: added evas-vg-json-multiple.c example 15/262215/2
Michal Maciola [Wed, 4 Aug 2021 09:57:42 +0000 (11:57 +0200)]
evas vg: added evas-vg-json-multiple.c example

Added evas-vg-json-multiple.c example for loading multiple lottie files
Example shows the usage of efl_file_simple_load and eina_file_dir_list
and is helpful testing json loader changes

Change-Id: I11de3eb5ff774e1ab26d6db9cc7e0e1d809f793f

2 years agoevas canvas: ++safety 94/262194/2 accepted/tizen/unified/20210805.131712 submit/tizen/20210804.104948
Hermet Park [Wed, 4 Aug 2021 02:49:28 +0000 (11:49 +0900)]
evas canvas: ++safety

prevent null memory access.

Change-Id: I14a9e07d2a4122db9170dc40eafe0e55cc80524a

3 years agoRevert "evas vg: lottie rendering optimization" 20/262020/1
Michal Maciola [Fri, 30 Jul 2021 15:18:52 +0000 (17:18 +0200)]
Revert "evas vg: lottie rendering optimization"

This reverts commit b4e4e4a2bf25367fe778dd6fa674685430067c1e.

Change-Id: I7c4a68d0aad658a746e670912196ffd3cd958315

3 years agoecore_wl2: add ecore_wl2_window_transient_parent_set API 06/261706/6
Doyoun Kang [Fri, 23 Jul 2021 03:52:45 +0000 (12:52 +0900)]
ecore_wl2: add ecore_wl2_window_transient_parent_set API

This API makes relationship between windows as a child and a parent.
And the child window must set the place_below flag where it is placed.
If the place_below flag is true, then child window is placed UNDER the parent,
Otherwise, it is placed ON the parent.

@tizen_only

Change-Id: I19d834a14e2fa0376be9ecf356f713713e77366c
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
3 years agoecore_wl2: update tizen_policy version to 9 from 8 02/261702/2
Doyoun Kang [Fri, 23 Jul 2021 02:59:34 +0000 (11:59 +0900)]
ecore_wl2: update tizen_policy version to 9 from 8

According to the updated version of tizen_policy,
ecore_wl2 also updates the version of ecore_wl2's tizen_policy.

@tizen_only

Change-Id: I139c8dbc94ebfb2f624565f06d3832582e2e7218
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
3 years agoevas gl: bind texture with external target for map 75/261875/1
Shinwoo Kim [Wed, 28 Jul 2021 04:39:37 +0000 (13:39 +0900)]
evas gl: bind texture with external target for map

Summary:
egl images created using tbm surface for native surface set use
GL_TEXTURE_EXTERNA_OES as texture target, so we should bind to
this target when rendering. Or there is a GL_INVALID_OPERATION
error on glBindTexture in function _orig_shader_array_flush.

Thia patch follows logic of following commit;

7db0e20 evas/gl: Bind texture with external target for tbm surface

Reviewers: Hermet, raster, jsuya, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12286

Change-Id: Ie0b9bb35285dbd553443ab814461bd9eb38b526e

3 years agoecore_wl2: recover missing extern "C" 11/261811/1 accepted/tizen/unified/20210728.090535 submit/tizen/20210727.032657
Shinwoo Kim [Tue, 27 Jul 2021 03:10:15 +0000 (12:10 +0900)]
ecore_wl2: recover missing extern "C"

There is a build error on cpp project
because following commit remove extern "C".

8548d4d ecore_wl2: Move managed APIs to public header

Change-Id: Ic508303c317445194f22399fd77a7dc1efaa366c

3 years agoevas: ++safety. 73/261373/5 submit/tizen/20210726.093758
Michal Szczecinski [Fri, 16 Jul 2021 06:57:56 +0000 (08:57 +0200)]
evas: ++safety.

Added possible null dereference check in evas object clipping
recalculation.

Change-Id: I353d09809d7884b0d827a914199ac4dba6dd8958

3 years agoecore_wl2: Move managed APIs to public header 47/261547/3
Woochanlee [Wed, 21 Jul 2021 04:56:54 +0000 (13:56 +0900)]
ecore_wl2: Move managed APIs to public header

From this patch set ecore-devel package provides both
Ecore_Wl2.h and Ecore_Wayland2.h

Change-Id: I0a2b4121eaa9473607586b84f21e549ea3e0b372

3 years agoevas: ++safety 64/261264/2
Michal Szczecinski [Wed, 14 Jul 2021 06:42:18 +0000 (08:42 +0200)]
evas: ++safety

Added null pointer dereference checkers for evas mask object.

Change-Id: Ie8fef77982bfb8883ec208ab0e0f06b1efe6283c

3 years agoscroller: initialize flags for scrollbar 76/261276/2
Hosang Kim [Wed, 14 Jul 2021 09:26:34 +0000 (18:26 +0900)]
scroller: initialize flags for scrollbar

After scroller theme apply is called, scrollbar flags should be initialized
also.

@tizen_only

Change-Id: I278d22c1213174f80b61fc87ee2175f6ec41d2e4

3 years agoecore_wl2 input: prevent unintended key repeats by performance. 88/261088/2
Hermet Park [Fri, 9 Jul 2021 14:02:21 +0000 (23:02 +0900)]
ecore_wl2 input: prevent unintended key repeats by performance.

Change-Id: I32d14ccf5f4ea811aa30da44c84afd872b85b0f4

3 years agoevas canvas: ++safety 09/261109/1
Hermet Park [Mon, 12 Jul 2021 05:55:47 +0000 (14:55 +0900)]
evas canvas: ++safety

prevent null access just in case.

Change-Id: I5cb089edf8d8209ac85eb287f2d3a6245d951a3c

3 years agoevas vg: lottie rendering optimization 25/259925/6 accepted/tizen/unified/20210712.025004 submit/tizen/20210708.025913
Michal Maciola [Tue, 15 Jun 2021 11:16:08 +0000 (13:16 +0200)]
evas vg: lottie rendering optimization

Patch changes vg_common_json.c for loading json file directly into
tvg_scene, without efl functions used.
About 15% improvement was obtained.

Change-Id: I0ce55fa1f6d1d5a17dedbf6372492d8fce03347d

3 years agoecore_wl2: prevent invalid timer if the input is invalid. 33/260833/1
Hermet Park [Mon, 5 Jul 2021 09:07:04 +0000 (18:07 +0900)]
ecore_wl2: prevent invalid timer if the input is invalid.

Summary:
It is non-sense that running timer even if the input/timer is invalid.
Stop the timer to prevent invalid key down repeating.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12285

Change-Id: Id36b9b61b90ad6dd886cb2e7653be6b7f7b29c84

3 years agoevas vg: revise buffer caching mechanism from ector version. 00/260000/9
Hermet Park [Thu, 17 Jun 2021 09:44:04 +0000 (18:44 +0900)]
evas vg: revise buffer caching mechanism from ector version.

This helps to save memory when process uses the same resource
among the objects.

In case of ui, many ui instances uses the same visual resources,
So this mechanism is very effective.

Additionally, this keeps the designated buffer for animation frames.

Previously, we didn't reuse the buffer so every frame buffer is
generated and destroyed, it's an inefficient task...

Change-Id: Ida6c59d972ccc130cb0fa990fce475ce5a2dca64

3 years agoecore_wl2: ++safety code 97/260197/1 accepted/tizen/unified/20210629.051647 submit/tizen/20210628.020154
Shinwoo Kim [Tue, 22 Jun 2021 01:55:32 +0000 (10:55 +0900)]
ecore_wl2: ++safety code

This patch is removing 'Dereference after null check' type issue.

Change-Id: Ifb0fdcc690fa8682d71303323083f688a93d4119

3 years agoevas vg: ++optimization rendering performance. 07/259807/13
Hermet Park [Tue, 15 Jun 2021 03:23:16 +0000 (12:23 +0900)]
evas vg: ++optimization rendering performance.

recover to use the tbm-surface to update the texture data from
the tvg canvas. This brings skipping memory copy, improve the
fps around 10 on average.

Change-Id: I6eb54e8b62c88a6475c6750f69f55a50b4a6f566

3 years agoecore_wl2_window: use set_config geometry. 13/259913/1
Hosang Kim [Mon, 28 Jan 2019 08:10:59 +0000 (17:10 +0900)]
ecore_wl2_window: use set_config geometry.

Sometimes _ecore_wl_window_cb_angle_change is called before
_zxdg_toplevel_cb_configure is called.
In this case def_config geometry is not yet updated,
therefore we use set_config geometry.

@tizen_only

Change-Id: I13eb16db6ef476ac45a886bfb3ce1c788369e8e3
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
3 years agoevas vg: code refactoring. 57/259857/1
Hermet Park [Wed, 16 Jun 2021 05:14:56 +0000 (14:14 +0900)]
evas vg: code refactoring.

remove redundant code.

Change-Id: Icac48d3e0c027b18c24ef7084f5dec38302028e6

3 years agoevas_gl_common: increase max num_fbo_fmts of EVGL_Cap to 150 06/259306/2
Changyeon Lee [Fri, 4 Jun 2021 06:01:51 +0000 (15:01 +0900)]
evas_gl_common: increase max num_fbo_fmts of EVGL_Cap to 150

num_fbo_fmts of Adreno 650 is 114

Change-Id: I21137edc2ba9ee472fc2aba199244c8330e5a143

3 years agoecore_wl2: improve document of exported shell 25/259825/1
Shinwoo Kim [Tue, 15 Jun 2021 08:24:42 +0000 (17:24 +0900)]
ecore_wl2: improve document of exported shell

The commit behaviour is synchronized mode by default, so all relevant API
needs parent wl_surface.commit to get applied.
If user change the commit behaviour to desynchronized mode, then it is
necessary to call ecore_wl2_subsurface_exported_surface_commit.

Change-Id: I7b08568b1935079630058039b67adf351ea02925

3 years agoevas vg: code refactoring. 06/259806/5
Hermet Park [Tue, 15 Jun 2021 02:37:54 +0000 (11:37 +0900)]
evas vg: code refactoring.

remove redundant code...

Change-Id: Icbe384b0768c24c2b37012571bfecc5bda6ee1a5

3 years agocanvas vg: recover the origin code to allocate optimial canvas size while it keeps... 94/259794/8
Hermet Park [Mon, 14 Jun 2021 10:28:45 +0000 (19:28 +0900)]
canvas vg: recover the origin code to allocate optimial canvas size while it keeps the aspect-ratio.

Change-Id: I927a55aec6ca236bed8fbda5268ae4303c141707

3 years agoecore_wl2: update document for subsurface sync mode 12/259812/2
Shinwoo Kim [Tue, 15 Jun 2021 05:50:42 +0000 (14:50 +0900)]
ecore_wl2: update document for subsurface sync mode

The default commit behaviour of subsurface is syncronized mode.
User needs to know about this information.

Change-Id: Iff87f10e520febce116e72b1026c7dcd9ffd1a73

3 years agoecore_wl2: enhance document of exported shell 05/259805/1
Shinwoo Kim [Tue, 15 Jun 2021 02:25:28 +0000 (11:25 +0900)]
ecore_wl2: enhance document of exported shell

The parameter transform without any information is not kind.
We need to provide more information refering to:

  wayland-extension/protocol/tizen/wtz-foreign.xml

Change-Id: Ic1ab7dece1a1e6e3a19eeb313f012589ff6fc61e

3 years agoevas vector: do not redraw the canvas if the both cache tree & user tree are valid. 78/259678/1
Hermet Park [Fri, 11 Jun 2021 03:21:56 +0000 (12:21 +0900)]
evas vector: do not redraw the canvas if the both cache tree & user tree are valid.

previous logic has a potential issue that cache tree drawing result is erased
if the user tree is valid.

To fix this, tvg canvas must draw once after update both trees.

Change-Id: I59405d17b22cc587b69d268dbc86ab525f626905

3 years agoefl canvas: code refactoring 42/259242/4
Hermet Park [Thu, 3 Jun 2021 02:55:20 +0000 (11:55 +0900)]
efl canvas: code refactoring

keep it neat & clean code.

Change-Id: I1f76c2c674db380d7a363c37cb7d0fd3590d4e07

3 years agoevas canvas: fix a potential memory leak. 77/259677/1 accepted/tizen/unified/20210617.124948 submit/tizen/20210611.033305 submit/tizen/20210614.083948 submit/tizen/20210615.004451
Hermet Park [Fri, 11 Jun 2021 02:57:59 +0000 (11:57 +0900)]
evas canvas: fix a potential memory leak.

Change-Id: Iaf6be94c576c80b99ec8b24d2435e62b4074b6cc

3 years agoevas engine: Fixed error in evas render sync type use handling. 10/259610/4
jykeon [Thu, 10 Jun 2021 07:40:07 +0000 (16:40 +0900)]
evas engine: Fixed error in evas render sync type use handling.
             Change duplicate use render sync type.

Change-Id: I926eed7fca1f74eebebbc0b941a55f987e95a42b
Signed-off-by: jykeon <jykeon@samsung.com>
3 years agoector - code clean up. 56/259056/11
Hermet Park [Mon, 31 May 2021 10:46:36 +0000 (19:46 +0900)]
ector - code clean up.

remove unused code, leave the ector buffer for evas_filter feature.

Change-Id: I86ad883fc094fdcc9c3216fe2e17d51ebe6b6db1

3 years agoevas vg: Fixed possible crash in shape interpolate. 04/259504/1
Michal Szczecinski [Wed, 9 Jun 2021 06:08:40 +0000 (08:08 +0200)]
evas vg: Fixed possible crash in shape interpolate.

Added ptr checks before dereference.

Change-Id: I51e625a17be5cd82b30242c73c1b9d8fffb202d9

3 years agoatspi: make plug and socket window work 05/258905/9
Shinwoo Kim [Thu, 27 May 2021 11:39:26 +0000 (20:39 +0900)]
atspi: make plug and socket window work

This is for making Elm.Plug and Efl.Ui.Win_Socket_Legacy work
Elm.Plug (Embedding side such as Quickpanel) has a child Elm.Atspi.Proxy
Efl.Ui.Win_Socket_Legacy (Such as Music player) also has Elm.Atspi.Proxy.

1 finger tap did not work because PLUG proxy does not have size.
It is able to override efl_access_component_accessible_at_get to fix this.
But this patch set makes PLUG proxy have size.

flick "next" and "prev" did not work.
The changes in elm_atspi_bridge.c is fixing this issue.
Each comment explains what the change is going to fix.

This patch is fixing following items
(1) connection between plug and socket window including
    atspi on > off > on case
(2) 1 finger single tap on socket window
(3) 1 finger swipe between plug and socket window
(4) 1 finger double tap and hold on socket window, then 1 finger tap on plug

*tizen-fix

Change-Id: I34f76892da29232c4ae9da892d550fc023759570

3 years agoatspi: add atspi bridge ready event 67/259367/2
Shinwoo Kim [Fri, 4 Jun 2021 11:20:00 +0000 (20:20 +0900)]
atspi: add atspi bridge ready event

Summary:
calling elm_init does not guarantee of readiness of atspi bridge
even though elm_init is calling _elm_atspi_bridge_init.
widget or user could want to know when the atspi bridge is ready.

Reviewers: Hermet, jsuya, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12283

Change-Id: I75f1f45851ec51af07d3f9ba68d69019160ed721

3 years agocanvas vg: fix a crash issue. 54/259354/3
Hermet Park [Fri, 4 Jun 2021 15:00:29 +0000 (00:00 +0900)]
canvas vg: fix a crash issue.

clear the scene before its parent is changed.
this can occur the corruption of the scene tree
that brings the shapes appended to multiple scenes.

Change-Id: I9d729e185e3d5e27653ec54bda259081c67f5214

3 years agoecore_wl2: fix declaration mistake 80/259280/1
Shinwoo Kim [Fri, 4 Jun 2021 01:51:09 +0000 (10:51 +0900)]
ecore_wl2: fix declaration mistake

It should be ecore_wl2_subsureface_exported_surface_commit
ecore_wl2_subsurface_exported_surface_ is prefix for foreing shell
related API family.

Change-Id: I40a8f5a28503019720c471a050a0a55ce35ee4b6

3 years agoatspi: move duplicated code in one place 63/259263/1
Shinwoo Kim [Thu, 3 Jun 2021 03:44:24 +0000 (12:44 +0900)]
atspi: move duplicated code in one place

Summary: we do not have to change several place for updating.

Reviewers: Hermet, jsuya, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12282

Change-Id: I655345e11ff6fbf85d5f02e6d1f600a4da6cae68

3 years agoevas vg: Don't update thorvg shapes when node is not changed. 44/259144/5
Michal Szczecinski [Mon, 31 May 2021 13:26:32 +0000 (15:26 +0200)]
evas vg: Don't update thorvg shapes when node is not changed.

When node is not changed it is not necessary to update and redraw
canvas. This change speed up lottie rendering process in vg-benchmark up
to 25%.

Change-Id: If0c85d9fb2f8a20de47e1f243f49e5276617d086

3 years agoevas vg: Removed warnings 53/259153/2
Michal Szczecinski [Tue, 1 Jun 2021 16:48:46 +0000 (18:48 +0200)]
evas vg: Removed warnings

Change-Id: I5c31dd88331ebd2f030fca1e54900d64d5f16000

3 years agoRevert "Revert "ector - code clean up."" 28/259128/1
Hermet Park [Tue, 1 Jun 2021 09:38:27 +0000 (18:38 +0900)]
Revert "Revert "ector - code clean up.""

This reverts commit 2d935a44c1f69a9ac6548efb46900f63c4fd81e7.

Change-Id: Ic84ff4a35a9c9827600dc87a5423bcd7aa7764d8

3 years agoRevert "ector - code clean up." 91/259091/1 accepted/tizen/unified/20210602.122542 submit/tizen/20210601.080645 submit/tizen/20210601.084003
Chun [Tue, 1 Jun 2021 05:00:13 +0000 (05:00 +0000)]
Revert "ector - code clean up."

This reverts commit 8aae7d5e11124e37c1cc43454ead4dc91a1a6ceb.

Change-Id: I1029adbf5952a24c27be20f0e4e5c4c70d0c8dfc

3 years agoector - code clean up. 85/258985/2
Hermet Park [Fri, 28 May 2021 11:35:48 +0000 (20:35 +0900)]
ector - code clean up.

remove ector software engine.

Change-Id: If28abc6060426a794d30d9415c84250f323dce09

3 years agoevas canvas: +null check for safety. 26/259026/1
Hermet Park [Mon, 31 May 2021 06:02:46 +0000 (15:02 +0900)]
evas canvas: +null check for safety.

Prevent any corrupted objects in efl side...
It rarely happens that freed objects are accessed again with null properties...

Change-Id: If026d1ca29a1b9002b4f9c0c073cb4e455f55515

3 years agoevas vg: Fixed code style 82/258982/1
Michal Szczecinski [Fri, 28 May 2021 10:19:45 +0000 (12:19 +0200)]
evas vg: Fixed code style

Change-Id: Ia92af55e4e323d420f5d787c155eed6b84717a10

3 years agocanvas vg: fix the memory leak issue. 45/258845/7
Hermet Park [Wed, 26 May 2021 12:39:03 +0000 (21:39 +0900)]
canvas vg: fix the memory leak issue.

some dangled tvg nodes occured memory leak when interpolating vg tree.

this fixes the issue.

Change-Id: Ifef6f3cad011ef0fd4197bc6c06d00ebc75adbb8

3 years agoevas vg: Shape interpolation patch: indent and case check fix 26/258626/6
Michal Maciola [Fri, 21 May 2021 07:36:56 +0000 (09:36 +0200)]
evas vg: Shape interpolation patch: indent and case check fix

This patch fixes indent and if condition in patch "evas vg: Shape
interpolation patch".

Change-Id: I6d3c322c174f3b5d5cdcc4f8f866de05b3047d98