review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

mtklein@google.com [Wed, 20 Nov 2013 18:06:10 +0000 (18:06 +0000)]

More common_conditions simplifications.

BUG=
R=bungeman@google.com, djsollen@google.com

Review URL: https://codereview.chromium.org/78653002

git-svn-id: http://skia.googlecode.com/svn/trunk@12322 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 20 Nov 2013 18:02:00 +0000 (18:02 +0000)]

Hide unused gFormats.

Presumably this is WIP code? Otherwise, we delete it?

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78503003

git-svn-id: http://skia.googlecode.com/svn/trunk@12321 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 20 Nov 2013 17:59:54 +0000 (17:59 +0000)]

GpuTest::GetContext() doesn't exist.

BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/76143003

git-svn-id: http://skia.googlecode.com/svn/trunk@12320 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 20 Nov 2013 17:59:48 +0000 (17:59 +0000)]

Remove the SKIA_IGNORE_GPU_MIPMAPS now that Chrome sets glGenMipmap for
the skia GL interface.

R=bsalomon@google.com, humper@google.com

Author: skaslev@chromium.org

Review URL: https://codereview.chromium.org/74783011

git-svn-id: http://skia.googlecode.com/svn/trunk@12319 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 20 Nov 2013 17:08:13 +0000 (17:08 +0000)]

Update expectations for Ubuntu x32 bot.

GM diffs are few, tiny, and unreproducable on our workstations.

BUG=

Review URL: https://codereview.chromium.org/78913002

git-svn-id: http://skia.googlecode.com/svn/trunk@12318 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 20 Nov 2013 16:44:59 +0000 (16:44 +0000)]

Fix a warning building DM using ninja on Mac.

Here is the warning:
../../dm/DMTask.cpp: In copy constructor ‘DM::Task::Task(const DM::Task&)’:
../../dm/DMTask.cpp:17: warning: base class ‘class SkRunnable’ should be explicitly initialized in the copy constructor

Also add an SK_OVERRIDE.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/76903002

git-svn-id: http://skia.googlecode.com/svn/trunk@12317 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 20 Nov 2013 15:56:14 +0000 (15:56 +0000)]

Reverting r12315 (More Windows 64b compilation warning fixes) due to compilation failures

git-svn-id: http://skia.googlecode.com/svn/trunk@12316 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 20 Nov 2013 15:46:10 +0000 (15:46 +0000)]

More Windows 64b compilation warning fixes

https://codereview.chromium.org/47513017/

git-svn-id: http://skia.googlecode.com/svn/trunk@12315 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 20 Nov 2013 15:13:49 +0000 (15:13 +0000)]

Add extra warnings to match what Android uses.

R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12310

Review URL: https://codereview.chromium.org/74193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12314 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 20 Nov 2013 15:11:05 +0000 (15:11 +0000)]

De-generalize create_typeface on Windows.

The gdi and dw backends have a local create_typeface function.
This function is now called in only one place, onLegacyCreateTypeface.
Move the implementation into the caller.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/76763002

git-svn-id: http://skia.googlecode.com/svn/trunk@12313 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Wed, 20 Nov 2013 14:29:51 +0000 (14:29 +0000)]

Add missing (trivial) virtual destructors.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78543002

git-svn-id: http://skia.googlecode.com/svn/trunk@12312 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 20 Nov 2013 13:58:58 +0000 (13:58 +0000)]

Revert "Add extra warnings to match what Android uses."

This reverts commit d234662df1ffeb1bf45b2ade16c4acfb94f89450.

This change broke the build. Will resubmit after fixing warnings.

git-svn-id: http://skia.googlecode.com/svn/trunk@12311 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 20 Nov 2013 13:16:47 +0000 (13:16 +0000)]

Add extra warnings to match what Android uses.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/74193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12310 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Wed, 20 Nov 2013 13:15:40 +0000 (13:15 +0000)]

fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler option

In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is
eithe defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change
those headers were not read prior to trying to include the GPU headers which
resulted in a failed compile.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/76213004

git-svn-id: http://skia.googlecode.com/svn/trunk@12309 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 18 Nov 2013 21:29:36 +0000 (21:29 +0000)]

SkMemoryStream::setData should also set the current offset to 0.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/73273004

git-svn-id: http://skia.googlecode.com/svn/trunk@12308 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 18 Nov 2013 21:01:29 +0000 (21:01 +0000)]

Remove unused kMaxPOI.

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/62333026

git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 18 Nov 2013 20:55:29 +0000 (20:55 +0000)]

Revert SK_REQUIRE_LOCAL_VAR changes for DEPS roll.

BUG=

Review URL: https://codereview.chromium.org/59703012

git-svn-id: http://skia.googlecode.com/svn/trunk@12306 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 18 Nov 2013 17:27:16 +0000 (17:27 +0000)]

Remove unnecessary includes.

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/68893028

git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 18 Nov 2013 16:33:08 +0000 (16:33 +0000)]

Fix Windows build after the SkAutoFoo guard CL.

BUG=

Review URL: https://codereview.chromium.org/66593004

git-svn-id: http://skia.googlecode.com/svn/trunk@12303 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 18 Nov 2013 16:26:25 +0000 (16:26 +0000)]

Fix DocumentTest/SkDocument memory leaks

https://codereview.chromium.org/72833002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12302 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 18 Nov 2013 16:03:59 +0000 (16:03 +0000)]

Guard against most unintentionally ephemeral SkAutoFoo instantiations.

I think I applied the trick everywhere possible.  Limitations:
    - can't be used with templated classes
    - all constructors and destructors must be defined inline

A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I
deleted them.  This change caught the same bugs Cary found in SkPath, plus one
more in SampleApp.

BUG=
R=reed@google.com, caryclark@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/72603005

git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 17 Nov 2013 16:19:11 +0000 (16:19 +0000)]

Whitespace change to test CQ.

TBR=
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/74723002

git-svn-id: http://skia.googlecode.com/svn/trunk@12300 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Thu, 14 Nov 2013 20:15:51 +0000 (20:15 +0000)]

fix general-pespective for conical gradient bug=1744

BUG=
R=edisonn@google.com

Review URL: https://codereview.chromium.org/71303003

git-svn-id: http://skia.googlecode.com/svn/trunk@12299 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 14 Nov 2013 19:50:26 +0000 (19:50 +0000)]

Ignore GM dashing_gpu on Debug ANGLE

BUG=Skia:1844

Committed: http://code.google.com/p/skia/source/detail?r=12297

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/72993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12298 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 14 Nov 2013 19:39:49 +0000 (19:39 +0000)]

Ignore GM dashing_gpu on Debug ANGLE

BUG=Skia:1844
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/72993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12297 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 14 Nov 2013 19:09:27 +0000 (19:09 +0000)]

Pdfviewer refactoring.

Mostly superficial changes, to help me make sure I understand the
code while making modifications.

SkPdfRenderer:
First class I'm modifying. Move it into include/ and src/ directories.
Inherit from SkNoncopyable.
Replace load() with factory function which returns NULL if the load
fails.
Remove unload() and loaded(), which no longer make sense, since the
factory will return NULL on a failure to load, and unload() happens
on destruction.
Use a const char* for loading a PDF, following the convention of
SkStream::NewFromFile.
Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap.
Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro
to convert to an integer.
Use this-> when calling member functions.

pdf_viewer_main.cpp:
Call the new interface for SkPdfRenderer.

gyp files:
Refer to the new location of SkPdfRenderer.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/59493011

git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 14 Nov 2013 19:02:41 +0000 (19:02 +0000)]

Add missing functions to SkNWayCanvas

R=reed@google.com
BUG=none

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/65513003

git-svn-id: http://skia.googlecode.com/svn/trunk@12295 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 14 Nov 2013 18:52:52 +0000 (18:52 +0000)]

Remove suppression of blurrect_outer

git-svn-id: http://skia.googlecode.com/svn/trunk@12294 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 14 Nov 2013 18:45:13 +0000 (18:45 +0000)]

rebaseline blurrect_outer images

https://codereview.chromium.org/70103015/

git-svn-id: http://skia.googlecode.com/svn/trunk@12293 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 14 Nov 2013 17:05:05 +0000 (17:05 +0000)]

Fix warnings and Win only error in pdf_viewer.

git-svn-id: http://skia.googlecode.com/svn/trunk@12292 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 14 Nov 2013 16:53:22 +0000 (16:53 +0000)]

increase coverage of SkPath.cpp, remove unused code

Using Mike Klein's excellent coverage tool, increase the
unit testing of SkPath.cpp from 70% to 95%.

Along the way, determined that these functions were not
maintained or used:

SkPath::pathTo
SkPath::contains

as well as a large block of SkPath::cheapGetDirection().

Changed SkPath::validate() to permit infinities in
the path data points.

Fixed errors in preserving direction.
Fixed error setting direction when convexity is unknown.

Added missing conic to moveTo only detector.

BUG=
R=bsalomon@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/65493004

git-svn-id: http://skia.googlecode.com/svn/trunk@12291 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 14 Nov 2013 16:35:35 +0000 (16:35 +0000)]

Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, simpleaaclip_path, strokerect, strokes_round

git-svn-id: http://skia.googlecode.com/svn/trunk@12290 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 14 Nov 2013 16:01:23 +0000 (16:01 +0000)]

Include SkBitmapDevice for pdf_viewer.

git-svn-id: http://skia.googlecode.com/svn/trunk@12289 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 14 Nov 2013 15:46:25 +0000 (15:46 +0000)]

Include pdfviewer in everything.

This simplifies the process for building pdfviewer. Now it can be
built using

./gyp_skia

make pdfviewer

(ninja can also be used).

R=edisonn@google.com

Review URL: https://codereview.chromium.org/70353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12288 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 14 Nov 2013 14:47:56 +0000 (14:47 +0000)]

Address some more valgrind issues

R=borenet@google.com

Review URL: https://codereview.chromium.org/59713010

git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 14 Nov 2013 14:43:16 +0000 (14:43 +0000)]

pdfviewer: ignore flanky test

Review URL: https://codereview.chromium.org/64223008

git-svn-id: http://skia.googlecode.com/svn/trunk@12285 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 14 Nov 2013 07:02:31 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12283 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 22:00:11 +0000 (22:00 +0000)]

Add rrect_aa and rrect_bw to ignore list

git-svn-id: http://skia.googlecode.com/svn/trunk@12282 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 21:36:30 +0000 (21:36 +0000)]

Ignore failures for blurrect_outer (needs rebaselining).

git-svn-id: http://skia.googlecode.com/svn/trunk@12281 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 13 Nov 2013 21:32:12 +0000 (21:32 +0000)]

pdfviewer: seed expectations for Mac 10.8 native renderer

Review URL: https://codereview.chromium.org/61683010

git-svn-id: http://skia.googlecode.com/svn/trunk@12280 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 21:23:56 +0000 (21:23 +0000)]

Add missing rebaselines for rrect_clip.

git-svn-id: http://skia.googlecode.com/svn/trunk@12279 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 21:06:30 +0000 (21:06 +0000)]

Ignore Nexus4 failures for complexclip2_path_aa_gpu.

git-svn-id: http://skia.googlecode.com/svn/trunk@12278 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 20:54:49 +0000 (20:54 +0000)]

Rebaseline and enable GMs: pathopsskpclip roundrects rrect rrect_clip samplerstress

git-svn-id: http://skia.googlecode.com/svn/trunk@12277 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 13 Nov 2013 20:23:40 +0000 (20:23 +0000)]

pdfviewer: readobject can return null, and catalog can be null

Review URL: https://codereview.chromium.org/72053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12276 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 13 Nov 2013 19:53:46 +0000 (19:53 +0000)]

Remove backward compatibility shims from SkStream.h.

R=reed@google.com

Review URL: https://codereview.chromium.org/68773009

git-svn-id: http://skia.googlecode.com/svn/trunk@12275 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 19:09:48 +0000 (19:09 +0000)]

Rebaseline and enable GMs: convexpaths mixed_xfermodes nested_aa ninepatch-stretch pathfill pathinterior

git-svn-id: http://skia.googlecode.com/svn/trunk@12274 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 13 Nov 2013 19:09:13 +0000 (19:09 +0000)]

move SkImageInfo into its own header

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/71813002

git-svn-id: http://skia.googlecode.com/svn/trunk@12273 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 13 Nov 2013 17:03:44 +0000 (17:03 +0000)]

Update expectations for complexclip2_path_*.

git-svn-id: http://skia.googlecode.com/svn/trunk@12272 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 13 Nov 2013 16:02:18 +0000 (16:02 +0000)]

Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice""

This reverts commit ff0152ec5e2a0faf38ae1a317c5d77df08139104.

BUG=

Review URL: https://codereview.chromium.org/68203018

git-svn-id: http://skia.googlecode.com/svn/trunk@12271 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 13 Nov 2013 15:22:15 +0000 (15:22 +0000)]

drawPosTextOnPath is now deprecated, removing all overrides and impls

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/61743017

git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 13 Nov 2013 15:04:41 +0000 (15:04 +0000)]

Whitespace change: Updates should be fixed

Review URL: https://codereview.chromium.org/59623010

git-svn-id: http://skia.googlecode.com/svn/trunk@12269 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 13 Nov 2013 14:26:52 +0000 (14:26 +0000)]

"Fix" another crash in DeferredCanvasTest on valgrind bot

https://codereview.chromium.org/71463003/

git-svn-id: http://skia.googlecode.com/svn/trunk@12265 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 13 Nov 2013 13:59:44 +0000 (13:59 +0000)]

Whitespace change to trigger builds after r12262.

"Fixes for auto-detecting access to the git mirror in Update"

Review URL: https://codereview.chromium.org/59533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12263 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 13 Nov 2013 07:02:17 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12261 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 22:27:30 +0000 (22:27 +0000)]

Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"

This reverts commit 72958c374bdb9457419beeba7de1387da3293882.

BUG=

Review URL: https://codereview.chromium.org/58933007

git-svn-id: http://skia.googlecode.com/svn/trunk@12260 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 22:14:08 +0000 (22:14 +0000)]

switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice

BUG=
R=robertphillips@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/70473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12259 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 12 Nov 2013 21:56:39 +0000 (21:56 +0000)]

pdfviewer: remove sqrt from the formula computing the scale (DPI is dots per inch, not dots per square inch)

Review URL: https://codereview.chromium.org/70793003

git-svn-id: http://skia.googlecode.com/svn/trunk@12258 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Tue, 12 Nov 2013 20:58:41 +0000 (20:58 +0000)]

Rebaseline bench expectations for tabl_theverge.skp_tile_256x256_grid.

git-svn-id: http://skia.googlecode.com/svn/trunk@12257 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 20:53:05 +0000 (20:53 +0000)]

Hide implementation details: SkFrontBufferedStream

R=reed@google.com

Review URL: https://codereview.chromium.org/25581002

git-svn-id: http://skia.googlecode.com/svn/trunk@12256 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 20:43:34 +0000 (20:43 +0000)]

Ignore Windows verylargebitmap GMs for 565 and 8888

BUG=Skia:1822
R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/68123010

git-svn-id: http://skia.googlecode.com/svn/trunk@12255 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 19:36:14 +0000 (19:36 +0000)]

[PDF] Speculative fix for chrome crash w/ SRC xfer mode.

BUG=chromium:316546
R=edisonn@google.com, reed@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/61153003

git-svn-id: http://skia.googlecode.com/svn/trunk@12253 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 12 Nov 2013 18:29:17 +0000 (18:29 +0000)]

fix multithread related crashes in skpdiff

BUG=skia:1798
R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/60833002

git-svn-id: http://skia.googlecode.com/svn/trunk@12252 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 18:16:34 +0000 (18:16 +0000)]

Remove deprecated setIsOpaque() API from SkBitmap.

Clients we care (Blink, Chromium) were updated, so we can remove this now.

BUG=None
R=bsalomon@google.com, reed@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/66723017

git-svn-id: http://skia.googlecode.com/svn/trunk@12251 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 17:44:28 +0000 (17:44 +0000)]

pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used)

R=scroggo@google.com, jvanverth@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/68533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12249 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 17:33:02 +0000 (17:33 +0000)]

"Fix" another crash on valgrind bot

https://codereview.chromium.org/70463002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12248 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 17:10:02 +0000 (17:10 +0000)]

Override drawRRect in fake SkBitmapDevices.

Recent changes to SkBitmapDevice modified ::drawRRect() to take
an optimized drawing case. Some subclasses of SkBitmapDevice were
depending on the old behavior of calling ::drawPath(). Since they
do not draw, attempting to take the drawing path can cause problems.
For these subclasses, call drawPath() in the subclass.

R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/70443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12247 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 12 Nov 2013 16:46:43 +0000 (16:46 +0000)]

Remove some now-unused #ifdefs.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/68473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12246 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 16:11:07 +0000 (16:11 +0000)]

add colortable enum to SkImage to ease interop between it and SkBitmap::Config

BUG=
R=halcanary@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/68853003

git-svn-id: http://skia.googlecode.com/svn/trunk@12245 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 15:30:06 +0000 (15:30 +0000)]

Clean up after longjmp in SkImageDecoder_libpng.

In onDecodeInit, if longjmp sends us back to setjmp, destroy the
png_struct and info_ptr before returning false. Since the
PNGAutoClean has not been created yet, we were previously
leaking resources.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/68453006

git-svn-id: http://skia.googlecode.com/svn/trunk@12244 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 15:25:31 +0000 (15:25 +0000)]

Make bench_compare executable.

(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/63153005

git-svn-id: http://skia.googlecode.com/svn/trunk@12243 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 12 Nov 2013 15:25:29 +0000 (15:25 +0000)]

Fix leak detected in FontMgrMatchGM::onDraw by Valgrind.

git-svn-id: http://skia.googlecode.com/svn/trunk@12242 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:52:47 +0000 (14:52 +0000)]

Add a script for running pdfviewer and comparing to existing results.

For quick, local checking to see how changes to pdfviewer have changed
PDF files.

Scripts were originally written by edisonn, and updated here for checkin.

R=epoger@google.com

Review URL: https://codereview.chromium.org/62103008

git-svn-id: http://skia.googlecode.com/svn/trunk@12241 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:43:44 +0000 (14:43 +0000)]

Use SkPathJoin and SkBasename in Pdfviewer.

Remove redundant code.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/68263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12240 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:41:20 +0000 (14:41 +0000)]

Changes to make SkPDiff more robost.

bitmap_to_cielab now returns a boolean. Instead of asserting that the
config is 8888, copy to 8888 (and return false on failure). This allows
skpdiff to work on Index8 bitmaps (without changing the code that does
the real work). If it returns false, do not attempt to create a pmetric.

In pmetric, exit early if maxLevels is <= 2, since this would crash later
in the function (creation of an ImageL3D if maxLevels is 0, and then the
creation of an array of a negative number of entries). maxLevels is small
if the width or height of the image is small (i.e. a bitmap with width 1
has maxLevels of 0).

R=djsollen@google.com

Review URL: https://codereview.chromium.org/65253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:38:41 +0000 (14:38 +0000)]

Create nonPOD before setjmp.

With PNGAutoClean created after setjmp, when longjmp is called its destructor
is never called. Create it before setjmp, ensuring that its destructor is
called.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/65283002

git-svn-id: http://skia.googlecode.com/svn/trunk@12238 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:32:38 +0000 (14:32 +0000)]

Fix a memory leak in SkGPipeCanvas.

In cross process mode (currently unused but tested on the bots),
SkGPipeCanvas has a tangle of circular references, which prevents
it from being deleted. Break the chain of references.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/69633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12237 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 14:05:15 +0000 (14:05 +0000)]

Silence another valgrind leak

https://codereview.chromium.org/68523006/

git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 13:51:03 +0000 (13:51 +0000)]

Fix crash in tests on valgrind bot

https://codereview.chromium.org/63543005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12234 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Tue, 12 Nov 2013 13:49:52 +0000 (13:49 +0000)]

New SVG SKPs have been added to the buildbot repo. Triggering rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@12233 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 12 Nov 2013 07:02:05 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12232 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 01:16:56 +0000 (01:16 +0000)]

Disable Blurred RR optimization in Chrome

https://codereview.chromium.org/68773005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12231 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 11 Nov 2013 20:55:15 +0000 (20:55 +0000)]

Implement DPI for perspective bitmaps in PDF - we save the bitmap at the resolution requested.

R=reed@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/54913004

git-svn-id: http://skia.googlecode.com/svn/trunk@12230 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 20:54:09 +0000 (20:54 +0000)]

Hook in rough distance field support for fonts

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/41213003

git-svn-id: http://skia.googlecode.com/svn/trunk@12229 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 11 Nov 2013 20:12:34 +0000 (20:12 +0000)]

Implement a speedup for Y-only blurs by transposing.

R=mtklein@google.com, mtklein, reed@google.com
BUG=

Review URL: https://codereview.chromium.org/66413007

git-svn-id: http://skia.googlecode.com/svn/trunk@12227 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 11 Nov 2013 20:04:28 +0000 (20:04 +0000)]

Add another FontConfig suppression to valgrind suppressions

https://codereview.chromium.org/69403002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12226 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 19:59:40 +0000 (19:59 +0000)]

The coloremoji GM should now look like it did before.

With r12224 we now check that a stream looks like a font
before trying to use it.

git-svn-id: http://skia.googlecode.com/svn/trunk@12225 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 19:52:29 +0000 (19:52 +0000)]

Make onCreateFromStream check that the stream looks like a font.

git-svn-id: http://skia.googlecode.com/svn/trunk@12224 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 19:48:14 +0000 (19:48 +0000)]

Ignore coloremoji GM for now.

git-svn-id: http://skia.googlecode.com/svn/trunk@12223 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 11 Nov 2013 18:45:18 +0000 (18:45 +0000)]

Fix memory leak in filterRRectToNine

https://codereview.chromium.org/65723005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12222 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 18:36:46 +0000 (18:36 +0000)]

Android FontHost cannot use FontMgr yet.

git-svn-id: http://skia.googlecode.com/svn/trunk@12221 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 17:49:42 +0000 (17:49 +0000)]

Give Android a SkFontMgr::Factory which was missing as of r12217.

git-svn-id: http://skia.googlecode.com/svn/trunk@12220 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 11 Nov 2013 16:48:51 +0000 (16:48 +0000)]

Implement a NEON version of morphology. This is good for ~2.2X speedup on Tegra3.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/68123003

git-svn-id: http://skia.googlecode.com/svn/trunk@12219 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 16:26:55 +0000 (16:26 +0000)]

Re-add NULL FontMgr::Factory hadnling code removed in r12217.

git-svn-id: http://skia.googlecode.com/svn/trunk@12218 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 15:53:29 +0000 (15:53 +0000)]

Remove SK_FONTHOST_USES_FONTMGR.

Review URL: https://codereview.chromium.org/66783003

git-svn-id: http://skia.googlecode.com/svn/trunk@12217 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 11 Nov 2013 15:36:44 +0000 (15:36 +0000)]

pdfviewer: fix build break in windows (wrong return type on function)

Review URL: https://codereview.chromium.org/68973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12216 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 11 Nov 2013 15:10:47 +0000 (15:10 +0000)]

Initial draft code to run pdfviewer withg gms
draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h

R=scroggo@google.com, borenet@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/26269002

git-svn-id: http://skia.googlecode.com/svn/trunk@12214 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 14:36:54 +0000 (14:36 +0000)]

Update bench expectations.

git-svn-id: http://skia.googlecode.com/svn/trunk@12213 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 11 Nov 2013 13:43:22 +0000 (13:43 +0000)]

Specify --patchlevel 0 to trychange.py

For some reason, trychange.py creates patches with level 0, even from a git
repo. We were assuming that the patch level was 1 from a git repo, so patches
were failing to apply.

BUG=skia:1669
R=rmistry@google.com

Review URL: https://codereview.chromium.org/61733011

git-svn-id: http://skia.googlecode.com/svn/trunk@12212 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 10 Nov 2013 15:08:45 +0000 (15:08 +0000)]

Removed deprecated API calls that have crept in

git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 10 Nov 2013 14:40:21 +0000 (14:40 +0000)]

Re-enable SK_ATTR_DEPRECATED (i.e., revert r12067)

git-svn-id: http://skia.googlecode.com/svn/trunk@12209 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom