Lukasz Krok [Wed, 25 Feb 2015 16:24:50 +0000 (17:24 +0100)]
[M34 Merge] Fix for the 'Reload' button not displayed on page load finish
[Cause] "load,started" callback was triggered more than once,
e.g when an iframe present on the page was reloaded. In a browser,
it caused the status bar to be refreshed and reload button to
be changed into cancel button. Additionally, in such case, the "load,finished"
callback was not triggered and the cancel button never changed back into
reload.
[Solution] "load,started" and "load,finished" should be called
only once, when a page is loaded.
M34-merge: http://165.213.202.130:8080/#/c/69958/
Bug: http://168.219.209.56/jira/browse/TNEF-172
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park
Change-Id: I4b47a3833cbf487e2473c2fe70d2340111b5c807
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
SeungSeop Park [Thu, 26 Feb 2015 13:35:13 +0000 (22:35 +0900)]
Deprecate non-ewk api usages in app.c
In following commit, only ewk_ prefixed symbol will be exported.
To avoid build break, this patch comments out the code using
unexported symbols such as FOR_TESTING_ewk_hit_test_*.
TODO: replace this with proper solution.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11609
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I6f4c9afe5d9048c6658e18a7f2090990a9e87c3a
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Piotr Grad [Fri, 20 Feb 2015 08:47:57 +0000 (09:47 +0100)]
Fix incorrect key code in JS key press event
Platform was sending ascii code instead of utf8 code.
Used cached value for utf8 code passed by platform in
ime preedit and commit callbacks.
Bug: http://168.219.209.56/jira/browse/TNEF-235
Reviewed by: Jaesik Chang, Marcin Kolibabka, Marcin Krakowiak
Change-Id: I812c4fefefe7e45ab5b762940e751ee8eec5fbc7
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 16:58:11 +0000 (12:58 -0400)]
Only show selection handles when scrolling/flinging has stopped.
In text selection mode, handles and magnifier glance controls
are hidden while scrolling. That involves the two main scroll cases:
- user is flinging, i.e. kinetic scrolling;
- user is panning, i.e. dragging the page content around
without lifting his finger off the screen.
In our current implementation, the following case is broken:
- load a scrollable page and enter text selection mode (by
long press, for example).
- start kinetic scroll the page
One will notice that when he lifts off his finger from the screen
text selection controls are prematurely shown while scrolling is
still active, and it becomes junky.
This happens because when user lifts off his finger a GESTURE_END type
of event is emitted and handled by RWHVEfl::HandleGestureEnd. There,
it is assumed to mean "scroll has stopped, and text selection controls
can be shown". Although it covers the panning case well, it fails for
the flinging case.
Patch fix this by moving the panning-stop code from ::HandleGestureEnd
to ::HandleGesture, when a 'ScrollEnd' type of event is emitted.
The kinetic scrolling case is then alread properly handled by the
RenderWidgetHostView hook named 'DidStopFling'.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I2ac1569ebf3a7812c5ae71b17aa11decbf5a5c9d
Dongjun Kim [Thu, 26 Feb 2015 07:25:30 +0000 (16:25 +0900)]
fixup! fixup! After changed edit type, IME state doesn't change.
After this patch, IME was shown up with select picker in same time.
[Reproduce step]
1. open test file(select_picker_test.html)
2. choose edit field
3. choose select picker
We need to checking "TextInputType" before updating IME state.
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Grad
Change-Id: I926c430270272e8be7e8cf14e8144ff5d9f85e72
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Karol Furmaniak [Thu, 26 Feb 2015 11:25:33 +0000 (12:25 +0100)]
Scroll to focused editable node when ime change geometry.
[Problem]: Sometimes when changing orientation, page is not
scrolled to focused editable node.
[Solution]: Added scroll to focused editable node when
virtual keyboard change geometry to non zero size.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11586
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I34a98fcf20764a6e306f01dfa2aba5735788745f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 00:33:43 +0000 (16:33 -0800)]
Remove SendOrientationChangeEventIfNeeded
SendOrientationChangeEventIfNeeded method is not used anymore. It has
been replaced by SetOrientation. This patch removes the unneeded method.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I9604cc01dc0f61d3a2489b8339ce06722daf482c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Venugopal S M [Wed, 25 Feb 2015 18:54:57 +0000 (00:24 +0530)]
[MM] Buffered data indication is incorrect for Media Element.
Gstreamer 1.x gives buffered range in percentage in seven digits along
with precision. This large number caused overflow of progress bar.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11544
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I75111ee4dc4b426e8928332ee5837b33b87437cf
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
Daniel Waślicki [Thu, 26 Feb 2015 10:00:24 +0000 (11:00 +0100)]
Temporary disable Drag&Drop
As agress with Gyuyoung Kim, Drag&Drop currently is not officaly
supported with W3C standard. Although we want to have implementation
in engine to be able to simply turn it on when it will land in
official standard. For now we will turn it off to see how things
in W3C will go.
Change-Id: Iad55c48f7be1805596978a62565c6d85bf817796
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Daniel Waślicki [Wed, 18 Feb 2015 09:25:08 +0000 (10:25 +0100)]
Bring up drag option in context menu
This reverts commit
ddc255acd3b2955c28c29af67104881f1840b52d.
Implementation of Drag&Drop was splitted into two parts. First one
implemented EFL`s port for D&D with default behavior, which is
dragging on long press. Second part changed default behavior to
starting D&D after choosing proper option from context menu. After
merge of first patch issues was raised that one cannot open context
menu for URL links. Now both parts are merged so this issue does not
occur any more.
Together with: I1b3cc3280e119ea69fa3939b51315100f512e527
Together with: I5aeff041e53f659181b85c92e2e3674beb46f0be
Change-Id: I641c466f36791c73055dae9cd20b5f0738fcc666
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
sonal.g1@samsung.com [Wed, 25 Feb 2015 15:37:58 +0000 (21:07 +0530)]
[Tizen][WebRTC] Appsink implementation with fimcconvert
Appsink has been implemented using fimcconvert, it will be used if
pixmap(zero-copy) is not working. It works by registering a callback with
appsink. After receiving the buffer it will send buffer to renderer process
via shared memory.
Reviewed by: Min-Soo Koo, Sharath Kamath
Change-Id: I270ad24f5ebd6ccfd8d9609a6a3259db68b25a25
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
KangYong Park [Thu, 26 Feb 2015 01:56:32 +0000 (10:56 +0900)]
fixup! Added implementation of Drag&Drop for EFL port
This is add-hoc patch for running content_shell.
When running content_shell, ewk_view_ is not initialize.
Reviewed by: Antonio Gomes, Gyuyoung Kim, Piotr Tworek
Change-Id: I6fcf3b29dd44ace8499af1a2aea1369ff95c8daf
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 19:59:14 +0000 (11:59 -0800)]
Use asynchronous hit test in unittests
unit tests of Ewk_Hit_Test use synchronous hit test. This patch use the
new synchronous api.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I89f09ff25d7bbfb09b9d47851700185f3bfbd031
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 23:16:33 +0000 (15:16 -0800)]
Ability to run browsers trought gdb with -g option
Right now, it is not easy to run ubrowser or efl_webview_app with gdb.
This patch adds a -g option to both wrappers scripts. If they are called
with that option, the applications are launched with gdb.
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: Icb504e12b8c286f13164ecbe41915e2e261ff07d
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
[MM][Tizen 3.0] Fix video corruption when video resolution is changed.
When the resolution of video is changed from server, video was corrupted.
This patch makes MediaSourcePlayerGstreamer handle the video resolution changes.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11432
Change-Id: I0185c67e3a25785fe4b6866e9c708881b41578d7
Signed-off-by: msu.koo <msu.koo@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 13:45:38 +0000 (19:15 +0530)]
fixup! fixup! fixup! Fix ewk_view_orientation_send API Reviewed by: Piotr Tworek, venu musham
Change-Id: I8e80329d12e5b6cae84b549c860b7a0ae8743a52
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
Fix for renderer crash during video playback
If we scroll/zoom the page during video playback, renderer
crash is observed. Currently, invalidation of video layer
happens on the main thread in WebMediaPlayerTizen. It should
happen on the compositor thread instead. This patch ensures
that and thus avoids the crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11278
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I40b7fa90c467e80af06f8ce39de4d3a763f1117e
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 20:06:34 +0000 (12:06 -0800)]
Use asynchronous hit test in efl_webview_app
efl_webview_app still uses deprecated (synchronous) hit test api. This
patch fixes it.
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ibe774ad8a8c798cf7a9449744a54d04d7bf17a7c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 20:48:47 +0000 (12:48 -0800)]
Factor out common bits of build_mobile and build_tv scripts
Both scripts were almost identical, except in the values
set to TIZEN_VERSION and PROFILE_FLAG variable.
To avoid such duplication, patch factors out the common bits
into a function in common.sh named setupAndExecuteTargetBuild.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I2e36fc5c950d1af2d549838fa7d7246790498f53
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Michał Obrembski [Tue, 24 Feb 2015 14:44:44 +0000 (15:44 +0100)]
fixup! Generalize and improve current suport for l10n
[Issue] Original patch breaks WCS TC 213.
[Note]
Changed the place of LocaleEfl::Initialize(), as it requires existing
SharedIntance of ui::ResourceBundle, and BasicStartupComplete() is called
before PreSandboxStartup(),
Also removed check for renderer process, as PreSandboxStartup() is
called from zygote process.
Reviewed by: Antonio Gomes, Marcin Kolibabka
Change-Id: Ic6b89d7c5f68d404eb264eaeba01cc5b37c06d7f
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Piotr Pruski [Wed, 11 Feb 2015 15:21:22 +0000 (16:21 +0100)]
Implementation for ewk_settings_private_browsing
Implementation of set and get functions to use private browsing mode.
Implementation replaces current webcontext to new one with private settings.
The old one is held till user goes back to normal browsing.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11110
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: I922a1e674be01024e55622c0d1822c414dd17bbf
Signed-off-by: Piotr Pruski <p.pruski@samsung.com>
Youngsoo Choi [Wed, 25 Feb 2015 11:09:10 +0000 (20:09 +0900)]
[HOTFIX][tizen v3.0][aarch64] Disabling aarch64 build on OBS
To release chromium-efl onto OBS system,
the build for aarch64 needs to be disabled.
Supporting aarch64 task is in progress.
Once it's done, this patch will be removed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11575
Reviewed by: Antonio Gomes, KC Park
Change-Id: I99863b2756e9d2809e37a9f1dc5da6f518fce771
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
joke.song [Tue, 24 Feb 2015 08:44:55 +0000 (17:44 +0900)]
Fix Insertion popup tool-tip is displayed on selecting 'Cut'
After selecting context menu 'cut', Insertion menu is
displayed. Insertion popup tool tip should not be displayed.
Bug: http://168.219.209.56/jira/i#browse/TNEF-189
Reviewed by: Jaesik Chang, Karol Furmaniak
Change-Id: Ib89be98522fdd86cbff417a2da831b6b1c4e1d34
Signed-off-by: joke.song <joke.song@samsung.com>
ByungJun Kim [Wed, 25 Feb 2015 13:46:33 +0000 (22:46 +0900)]
Change size of DateTime Popup to prevent hidden by IME.
When open DateTime popup and tap on MM/DD/YY fileds,
IME hide the popup.
We need change size of DateTime popup.
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Ica3ea7f02883f609309c21bd5f86498fd3334c63
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Piotr Tworek [Thu, 9 Oct 2014 15:56:44 +0000 (17:56 +0200)]
[M34-Merge] Avoid overriding DIR_MODULE path also on desktop.
On desktop DIR_MODULE is used to find files in build directory.
Overriding it makes efl_webview_app or content shell look for some of
the resources it needs in wrong directories under
out.x64/Debug/resources/resources instead of out.x64/Debug/resources.
The code was not present in the original code copied from chrome. For
unknown reasons it is only enabled in chromium-efl desktop builds.
Remove it as it's clearly wrong. We should not override paths which may
be used as base values for other paths.
M34-Merge: http://165.213.202.130:8080/#/c/70612/
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park, commitbot
Change-Id: If02c9d6ec314a9d327a04754cea3bd3bea5375a5
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
k2.nagaraju [Thu, 19 Feb 2015 13:46:00 +0000 (19:16 +0530)]
[MM] Video corruption issue with AppSink
Gstbuffer size aligned to multiple 8, Videoframe buffer size
aligned to multiple of 16. For resolutions which are not
multiple of 16, gst buffers as to copy row-by-row to videoframe
buffer.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11484
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: I30c7007400148c0b9ffb5cc28599e4f1e71f76ae
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
Marcin Strakowski [Wed, 25 Feb 2015 12:44:15 +0000 (13:44 +0100)]
fixup! After changed edit type, IME state doesn't change.
Fix on showing context IME.
Reviewed by: Jaesik Chang, Marcin Kolibabka
Change-Id: I7fcf784fa6a89bb5279d1283358d9b74114f78a4
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
Youngcheol Kang [Wed, 25 Feb 2015 09:12:58 +0000 (18:12 +0900)]
Resolved the build problem which uses the ccache option
Below error were occurred when we uses the '--ccache' option
build/apply_patches.sh: pushd: /var/src: No such file or directory
build/apply_patches.sh: popd: directory stack empty
The 'CHROME_SRC' value is already contained as '/var/src' when we
uses the '--ccache' option.
For resolving this problem, we removed the conditions
which check whether 'CHROME_SRC' value was contained.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11572
Reviewed by: Antonio Gomes, joonhwan kwon
Change-Id: I91716ecc67e0c36fb1d22943dc09ac582c8991b1
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
hyungsun.ryu [Wed, 25 Feb 2015 06:00:44 +0000 (15:00 +0900)]
[Tizen 3.0] Set S/W codec for MSE
Odroid can not support omx decoder yet.
Hence, video and audio codec are changed to S/W codec.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11432
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Idf6e9a215864a3d582b8ce93064369340eab8c8f
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
Daniel Waślicki [Wed, 18 Feb 2015 08:21:38 +0000 (09:21 +0100)]
Revert "temporary fix! - disable drag&drop"
This reverts commit
499a670310761938ea861fa809a4302c66f48015.
Implementation of Drag&Drop was splitted into two parts. First one
implemented EFL`s port for D&D with default behavior, which is
dragging on long press. Second part changed default behavior to
starting D&D after choosing proper option from context menu. After
merge of first patch issues was raised that one cannot open context
menu for URL links. Now both parts are merged so this issue does not
occur any more.
Reviewed by: Antonio Gomes, Michal Roj, Piotr Tworek, SeungSeop Park, arno renevier
Change-Id: Ibb466c3068ce074b79211ea482271e97e2a059a0
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 20:59:21 +0000 (12:59 -0800)]
Do not log an error when gl surface creation is successful
When gl surface is created successfuly, an error is logged. This is
confusing and clutters stderr uselessly. This patch removes this
spurious logging.
Reviewed by: Antonio Gomes, venu musham
Change-Id: Icb02f0ca21abb6f39188c2bd520d5abd8af69fa9
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngsoo Choi [Mon, 23 Feb 2015 01:20:37 +0000 (10:20 +0900)]
fixup! Added Tizen Trace package for debugging
Tizen v2.3 does not support ttrace rpm package.
Original message:
SQE usually uses Tizen Trace for debugging.
So, it is needed to add "ttrace" package into chromium-efl
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11501
Reviewed by: Antonio Gomes, KC Park
Change-Id: I6af315b1d4639e907f4bbb2c60b1f5f60d34c3e8
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Venugopal S M [Fri, 20 Feb 2015 12:52:31 +0000 (18:22 +0530)]
[MM] Gstreamer 1.0 packages for desktop
Added support for downloading Gstreamer 1.0 packages for
desktop.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10745
Reviewed by: Hyungsun Ryu, SeungSeop Park, Sharath Kamath
Change-Id: Id94a000b9cbec094981656d0aabd5c50811255bb
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
k.r.ranjan [Mon, 23 Feb 2015 08:11:19 +0000 (13:41 +0530)]
fixup! [Tizen][MM][Webrtc] GetUserMedia Support
This commit includes
- taking camera_id from constraints from getusermedia
- making rear camera as default in case of no constraints
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10584
Reviewed by: Min-Soo Koo, Sharath Kamath, Venugopal S M
Change-Id: Ia7874f7587307af2fae60b27c0f027106d9a4aa1
Signed-off-by: k.r.ranjan <k.r.ranjan@samsung.com>
Youngsoo Choi [Tue, 24 Feb 2015 09:20:36 +0000 (18:20 +0900)]
[tizen v3.0][x86_64] Disabling linux_use_gold_flags
[issue]
Following error is coming during x86_64 build.
>> collect2: fatal error: cannot find 'ld'
[resolve]
We are currently using gold linker in 'build/prebuild'.
because Tizen platform does not support gold linker.
When building for x64, common.gypi sets linux_use_gold_flags
to 1, which adds -fuse-ld=gold to the linker command.
This causes the linker to be search at in '/usr/bin',
so the error has been happens.
Until gold linker is supported by Tizen platform.
we need to disable the flag 'linux_use_gold_flags'.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11542
Reviewed by: Antonio Gomes, Eun Namgung, KC Park
Change-Id: I86c419b08ff8d34ec33151696a77ee820d4ce073
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Marcin Strakowski [Thu, 19 Feb 2015 15:13:48 +0000 (16:13 +0100)]
After changed edit type, IME state doesn't change.
When we change input box type (eg. Enter, Done, Alpha, Numeric),
IME has to change also its appearance. Sometimes on mobile platform
keyboard doesn't change its layout; even when we requested for this. This
patch is workaround for platform issue and triggers new layout by
hide/show on IME.
Bug: http://168.219.209.56/jira/i#browse/TNEF-231
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I9d5562986f034aae2795bcd66b1173eb7a2d90de
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
ByungJun Kim [Tue, 24 Feb 2015 02:42:26 +0000 (11:42 +0900)]
Add *.po for supporing many languange.
In WCS test cases: Works only for languages which translation files
are present in platform for example: Korean, Polish.
For other languages files with translation are needed.
To supporting translation, need to add *.po.
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Id6584abf6f5bef1bec6ada77adf08ebaca1d3fdd
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Karol Furmaniak [Mon, 23 Feb 2015 11:06:54 +0000 (12:06 +0100)]
fixup! Let long press selection bits be handled by SelectionController
[Problem]: Context menu is not displayed when long tap on text links
or images.
[Solution]: HandleLongPressEventPrivate should be called only
when long press on editable area or plain text.
Bug: http://168.219.209.56/jira/browse/TNEF-167
Reviewed by: Antonio Gomes, Jaesik Chang, Marcin Kolibabka
Change-Id: I7c0c753c71b41950e7d2f505b87f77a8bff40ddc
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
s.kamath [Thu, 19 Feb 2015 13:05:04 +0000 (18:35 +0530)]
[MM][WebRTC] OMX codec integration on m0 target.
Added support for accelarated encoding/decoding with WebRTC.
Uses omxh264 encoder & decoder for accelaration.
Avoiding usage of convertor as camera output is in I420 format.
h264parser needed at decoder pipeline as omxh264dec take
parsed frames at src pad.
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: I28708efeb48427125c3ba708c454cd556fb205c3
Signed-off-by: s.kamath <s.kamath@samsung.com>
Youngsoo Choi [Tue, 10 Feb 2015 10:32:40 +0000 (19:32 +0900)]
[Tizen][OBS] Changes for Tizen OBS Build
[Issue]
OBS build does not support running script 'build_{target].sh'.
1) GBS Build Options
In OBS build, definitions, coming through gbs build option, can NOT be used,
such as 'chromium_efl_tizen_version'.
2) Package Name
In OBS build, using macros around property 'Name' in spec file is not allowed.
3) Supplementary Repository
In OBS build, the supplementary repository is not allowed.
[Resolve]
1) GBS Build Options
The definitions, coming through gbs repository, are used,
instead of the definitions coming through gbs build option.
2) Package Name
In Tizen v3.0, appid should be consist of '.',
but package name doesn't need to follow that rule.
3) Supplementary Repository
The supplementary repository is removed in the file 'gbs.conf'.
Currently, chromium-efl doesn't have dependency of supplementary repository.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11500
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11502
Reviewed by: Antonio Gomes, KC Park, SeungSeop Park
Change-Id: I91876dadbd3643dec2046e87d7e0658a68292d81
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
amit.kumar8 [Tue, 24 Feb 2015 07:19:57 +0000 (12:49 +0530)]
fixup! fixup! Fix ewk_view_orientation_send API
Sending following message:
rwh->Send(new ViewMsg_Resize(rwh->GetRoutingID(), params));
is causing video playback issues during orientation change.
In chromium code there is only one place that is sending
this message and it's guarded around in many ways, hence
disabling it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11476
Reviewed by: DaeHyun Ko, Siba Samal
Change-Id: I53a91c07a55d1f73cbfb364e4ba646e209ac55bc
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Sergey Stepantsov [Thu, 12 Feb 2015 10:47:14 +0000 (19:47 +0900)]
TV Crash in Speed reading site
Lunch timer in appropriate thread
TV uses player_product.h in media_player_bridge_capi.cc,
player_prepare_async is used to prepare player to play content
callback for this returned in new thread and in this thread
timers will be lunched to update current time and buffer state. It
leads to crash, as timer should be run from the same thread.
(For phone problem is not reproducible, because phone uses
player_internal.h and callback for player_prepare_async always
returns control to UI thread).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10941
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: Id2026e6a093410dbb173c4f7edbae20b57a6273e
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
uzair.jaleel [Mon, 16 Feb 2015 13:36:26 +0000 (19:06 +0530)]
Updated EGL samples to 4 for Mali t400
Best Supported EGL framebuffer configuration is
Red : 8
Green : 8
Blue : 8
Alpha : 8
Depth : 24
Stencil : 8
Samples : 4
Bug :http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: Ie758837c7be52cd8691970b629dc3ad1c4772d61
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 23:12:21 +0000 (15:12 -0800)]
Fixes compiler warnings
This patch fixes various compiler warnings: initialization order of
class members, incorrect sign comparaison, uninitialized variable,
incorrect return types, incorrect enum comparaison and incorrect type
conversions.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9706
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I6aeccb073cf9561d2cbb09c5c63e60397d81a8d1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngcheol Kang [Mon, 23 Feb 2015 09:06:25 +0000 (18:06 +0900)]
[TIZEN][OBS] Excluded all Arch build from wearable profile
The chromium-efl doesn't support the wearable profile.
According to the platform team's request,
the codes for excluding the all Arch from wearable were
added into the spec file.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11507
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I6cbf89ee20fb17c867031b77604a8cfb536dc904
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
uzair.jaleel [Thu, 19 Feb 2015 14:36:24 +0000 (20:06 +0530)]
Invoke draw call to evas gl surface only for a valid texture.
Currently, texture id is not initialized for a new RWHV. So, when we
navigate to a new page, a draw attempt is made for an undefined texture
and hence we see the black screen. With this patch, we draw only when
the texture is valid.
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: Siba Samal, venu musham
Change-Id: I19665a4fa6252d86364b2fc4e4ea484d78a551cf
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Chandan Padhi [Fri, 20 Feb 2015 10:28:44 +0000 (15:58 +0530)]
[M34 Merge] Fixed that webview is crushed on resizing viewport.
webView is crushed when creating/removing IME and rotating device.
It is caused by diffrence between the size of egl surface rendered
and glViewport arguments. The arguments were set by evas geometry size,
but it was different from the size of rendered surface.
M34-merge: http://165.213.202.130:8080/#/c/69746/
Bug: http://168.219.209.56/jira/browse/TNEF-190
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: I3e00275dc439ef04c78b6709010aaf5a49c54a84
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Arnaud Renevier [Tue, 17 Feb 2015 18:26:08 +0000 (10:26 -0800)]
fixup! Fix user agent setter unittests
Right now, utc_blink_ewk_view_user_agent_set_func.cpp fails to build
with "error: invalid conversion from ‘const void*’ to ‘void*’"
We now Eina_Stringshare instead of const char*
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10887
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: I2dd071569b61d59495373ff456ff1990f956b39b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
venu musham [Tue, 17 Feb 2015 10:37:48 +0000 (19:37 +0900)]
[M34 Merge] Add default color to new initialized EvasGL
While new tab in browser is created there is black screen
visible, because EvasGL is initialized with default black
image. This change initialize EvasGL with white image and
result there is no more black screen while new tab is
opened.
M34-merge: http://165.213.202.130:8080/#/c/69924/
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: DaeHyun Ko, Prashant Nevase (OOO Feb/20 to Feb/24)
Change-Id: Ia8e337cf49db06122a496822a0e4833eb16e7afc
Signed-off-by: venu musham <venu.musham@samsung.com>
Dominik Duda [Tue, 17 Feb 2015 11:20:24 +0000 (12:20 +0100)]
Add profile for build on Tizen 3.0 TV emulator
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11434
Reviewed by: KC Park, Marcin Kolibabka, Piotr Tworek
Change-Id: I73f7c3fcdacedaaf16edd820c27344b69c921cdd
Signed-off-by: Dominik Duda <d.duda@samsung.com>
Antonio Gomes [Thu, 18 Dec 2014 15:56:32 +0000 (07:56 -0800)]
Remove unneeded pkg-config dependency: capi-appfw-application
No targets actually need it to build/link/run.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Piotr Tworek, Viatcheslav Ostapenko, commitbot
Change-Id: I369c850b41880049ace073a55457ed4633595ae6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Filip Piechocki [Tue, 16 Dec 2014 10:01:23 +0000 (11:01 +0100)]
Custom protocol handler test page added.
Custom protocol handlers' origin must have 'http' or 'https'
protocol and the site registering the custom handler must be
of the same origin as this handler. This implies, that the
test page's origin must have 'http' or 'https' protocol, so
we hosted this test page on GitHub:
http://jmajnert.github.io/tests/customProtocols/
and modified tests to use it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9522
Reviewed by: Antonio Gomes, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I5bfc9ff681f1bdfde1131af6d25f88c42bc92235
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Sergey Stepantsov [Mon, 15 Dec 2014 05:18:19 +0000 (14:18 +0900)]
Added functionality to take screenshot in mini_browser phone application.
By pressing menu button mini_browser saves
screen shot of web page in /opt/usr/media/Downloads as png.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9796
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
Change-Id: I9afb4ceb6424da106a150b57026761c64616fa05
Antonio Gomes [Wed, 18 Feb 2015 16:06:40 +0000 (12:06 -0400)]
Properly handle context menu item callbacks on desktop.
In ContextMenuControllerEfl::ContextMenuItemSelectedCallback
there is desktop only ifdef that at somepoint made it possible
to get context menu items callbacks working.
Today, the assumption and workaround in that block of code do
not apply anymore, and was making in fact breaing context menu
items' callbacks to work.
Patch removes it and unifies mobile, tv and desktop code paths.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I4230f336430b9e97478c9efa1f1592a5d3d18b5e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Tomasz Czekala [Fri, 20 Feb 2015 10:00:46 +0000 (11:00 +0100)]
Fix unittests for ewk_view_add_with_session_data
Added check for ewk_view_add_with_session_data and deleting webview to
remove all instances of WebContext
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: DONGJUN KiM, Filip Piechocki, Piotr Tworek
Change-Id: I582a06562df6b67dc78a38c2b9f3626019e0a473
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 21:20:11 +0000 (17:20 -0400)]
Let tap's selection bits be handled by SelectionController
Lots of code in EWebView::HandleTapGesture did not belong there,
and should be defered to SelectionControllerEfl.
Patch pulls the trigger.
http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Tworek, arno renevier
Change-Id: If59d48daad54b05e1432e42bb5814444942d2088
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 20:54:11 +0000 (16:54 -0400)]
Let long press selection bits be handled by SelectionController
Lots of code in EWebView::HandleLongPressGesture did not
belong there, and should be defered to SelectionControllerEfl.
Patch pulls the trigger.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Grad, arno renevier
Change-Id: I157619d78cb590ae67b93564050837391fcc3a43
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 14:34:48 +0000 (10:34 -0400)]
Remove unused methods from tizen_webview/public/tw_webview.cc
In the process of slimming simplifying our code, patch
removes two unused methods from our WebView API:
HandleGesture(ui::GestureEvent*) and HandleTouchEvent(ui::TouchEvent)
Reviewed by: Piotr Grad, arno renevier
Change-Id: I2d2e369c9bf5ae717d184fb214fc77c00845db86
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Grad [Mon, 16 Feb 2015 15:16:53 +0000 (16:16 +0100)]
Fix for JS popup appearance
Because current efl for mobile doesn't pass rotate events to windows and
there are other issues with rendering windows (black screen, transparent,
flickering, etc.) popup is created now on top of EWebView instead of a
new window. Even popup is resized upon rotate its content wasn't - so
that changed min scroller height to fit display size in landscape mode.
elm_object_widget_type_get(content) was failing (platform issue) so used bool flag instead.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11390
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad
Change-Id: Id2787f74cd6f0f61d6d183ec7e8b1f8fd2ca96fc
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Venugopal S M [Thu, 19 Feb 2015 07:01:48 +0000 (12:31 +0530)]
fixup! Add initial support for Tizen 3.0 TV platform
Gstreamer1.0 is used for Mobile(Tizen 2.4). Modified
condition to enable Gstreamer1.0 support for Tizen 2.4
and above.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11476
Reviewed by: Antonio Gomes, Sharath Kamath
Change-Id: I4eb4a04f30610ab3f3c49685cc20193b2f9541ad
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
s.kamath [Thu, 19 Feb 2015 11:47:24 +0000 (17:17 +0530)]
fixup! [Tizen][WebRTC] Pixmap implementation for video decode accelerator
Fixing build error with Gstreamer1.2 update on 2.4 branch.
Reviewed by: Antonio Gomes, Venugopal S M
Change-Id: Ie1aac7f30dd98366717544afc43acb88b152cbee
Signed-off-by: s.kamath <s.kamath@samsung.com>
Bartlomiej Gajda [Wed, 18 Feb 2015 19:35:16 +0000 (20:35 +0100)]
Fix using HWBackKey on select picker changing page to previous.
[Issue] if there was previous page, and select picker was shown
clicking HW Back changed page to previous one.
[Reason] redundant GoBack()
[Note] top level BackKey to return is handled in ref-browser:
url_bar::__back_cb().
[Fix] remove this redundant call, as it servers no purpose.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11389
JIRA: http://168.219.209.56/jira/browse/TNEF-252
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I1673ab40d83c58bd59c0f2ed0622568582f3b5db
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
sonal.g1@samsung.com [Mon, 19 Jan 2015 14:56:14 +0000 (20:26 +0530)]
[Tizen][WebRTC] Pixmap implementation for video decode accelerator
Implementation of Rendering through pixmap surface.
Together with: I325093df8aac31fc0eab155da08cd87de2ab58f7
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: I80a06a4fa0fa65106061a32f0a57b4e2b8a3635b
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
sonal.g1@samsung.com [Thu, 22 Jan 2015 13:42:04 +0000 (19:12 +0530)]
[Tizen][WebRTC] Fix delivery of Video Frame from encoder
A queue has been created to maintain the encoded buffers before they are send
to renderer side for further processing. Queue size goes maximum upto 4 in
usual scenario. If queue is not used then frames have to be unnecessarily
dropped when output buffers are not available.
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: I422a783871e61543052f37bf16b6536ac52829f6
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
Bartlomiej Gajda [Wed, 18 Feb 2015 12:41:48 +0000 (13:41 +0100)]
Add title to alert() and confirm() javascript popups.
[Note] There was no title set, UX document tells that there should be one.
This does not affect prompt(), as title is equal to first argument by function.
(so prompt() title won't be translated, only alert() and confirm().)
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I64c0ab61ee2ba402ebca8b0efd9402c06ae9f2b6
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Robert Jadczak [Fri, 13 Feb 2015 15:28:37 +0000 (16:28 +0100)]
Show context menu for email and phone link
Added context menu with proper options for tap event on email or phone link.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11229
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad, Piotr Tworek
Change-Id: Ia67069cf6ee76a5f26b21c897b9b4848d6d5b7ef
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
KangYong Park [Fri, 13 Feb 2015 02:32:11 +0000 (11:32 +0900)]
fixup! Fixed WebInspector inability to early report errors
DevToolsHttpHandlerImpl::GetFrontendURLInternal() returns incorrect url link.
To fix this issue, it need to change parameter when calling
content::DevToolsHttpHandler::Start function.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Antonio Gomes, Janusz Majnert, Kamil Klimek, Piotr Tworek
Change-Id: Id9e07fb130f03501b08de129058a686b23f09001
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Bartlomiej Gajda [Mon, 16 Feb 2015 18:59:54 +0000 (19:59 +0100)]
Fix overlapping of button labels in context menu.
[Note] This removes overridden style of context menu, which was probably
intended for icons-only menus. When it's enabled, it prevents resizing
of text items based on their length, which makes some of menu options
overlaps.
If this style will be corrected by platform owners this can be
turned back, if such need occurs.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11394
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I040c6efd7ccb926b509f9bacba0432ab01eb13ac
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 17:16:06 +0000 (18:16 +0100)]
Remove RenderWidgetHostViewEfl::set_eweb_view function.
It's no longer necessary since EWebView is provided in the class
constructor. We can initialize ::web_view_ on the constructor
intialization list.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: Ib1a30e78f230148f584f8be068735df588e91227
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 17:21:40 +0000 (18:21 +0100)]
fixup! WCS Feature: Autofill and Password Manager changes
Make sure the code compiles also with clang.
password_manager_client_efl.cc:23:1: error: cannot define or redeclare
'kLocatorKey' here because namespace 'password_manager' does not enclose
namespace 'WebContentsUserData<password_manager::PasswordManagerClientEfl>
Reviewed by: Kamil Klimek, Piotr Tworek, arno renevier
Change-Id: Ie4bf056185c45bd8ff1a1ccce96cc5f43e9bc5f5
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 13 Feb 2015 14:56:12 +0000 (15:56 +0100)]
Generalize and improve current suport for l10n
Current version of chromium-efl uses two different localization systems.
First from generic chromium product (pak files), second is based around
libintl. Both systems are pretty generic and serve their purpose well
enough. The problem is our current libintl system works only on tizen,
but not on desktop. This is unfortunate considering the fact libintl is
a generic library available on almsost every unix system, not only linux.
There is no good reason to make the funcionality tizen specific.
This patch tries to fix this problem. To do this it:
1. Adds a proper gyp support for compiling portable object (po) files.
It replaces the previous solution with inline shell code in RPM spec
file. Spec is only responsible for packaging output produced during
build (ninja) step.
2. All the generic code responsible for changing application locale is
moved outside of OS_TIZEN ifdefs. The only Tizen specific part is
usage of vconf to get current system locale. To keep the alternative
simple desktop uses hardcoded english localization. (Can be improved
if necessary)
3. The bindtextdomain calls are moved to
ContentMainDelegate::BasicStartupComplete function implementations
(one for UI another for renderer). Bindtextdomain should be called
only once during application initialization. The filesystem location
of translation files is not supposed to change during app lifetime.
4. Implements necessary PathsEfl support to find necessary translation
files on desktop (out.x64/{Debug|Release}/locale.
With the patch in place all the application menus which use
libintl/gettext for translation work on both desktop and tizen. It
should make it easier to test the functionality.
On a side note I also believe that the translation files should be moved
out of ewk directory into impl. Technically they are used by the code
from impl, not ewk. Still, if we'd like to do this it might be a good
idea for a separate patch.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek, arno renevier
Change-Id: I8e06778c730a7c313a08dc195d7fff513ca7e32f
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
ws29.jung [Tue, 17 Feb 2015 02:08:39 +0000 (11:08 +0900)]
Enable ME for Tizen 3.0
This patch enables media playback feature for Tizen 3.0.
Currently odriod board doesn't support ASM and CAPI.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11405
Change-Id: I4e32077f8000f830f41f93fd942b95f536893ee4
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
SeungSeop Park [Tue, 17 Feb 2015 16:01:18 +0000 (01:01 +0900)]
fixup! Add initial support for Tizen 3.0 TV platform
Fix mobile build break due to missing capi-system-sensor dependency.
Change-Id: I63ece319738badcb4d959e04940241fc5d5a08c9
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Youngsoo Choi [Wed, 28 Jan 2015 04:07:02 +0000 (13:07 +0900)]
Add spec and manifest files for supporting tizen v3.0
Tizen v3.0 has some constraints of package configuration
which are diffrent from Tizen v2.x.
1. xml file should be installed in '/usr/share/packages'.
2. app should be installed in '/usr/apps'.
3. appid should be consist of '.' such as 'org.tizen.chromium-efl'.
4. environment variable 'ELM_ENGINE' has to be set as 'gl'.
bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11063
Change-Id: I106cca288ef15c4618452602bd725960404b9f5e
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Piotr Tworek [Wed, 21 Jan 2015 14:53:46 +0000 (15:53 +0100)]
Add initial support for Tizen 3.0 TV platform
This patch adds initial build system support for Tizen 3.0 for TV profile.
Due to missing, or sometimes broken multimedia support in the current repos
the current build disables support for it.
The code has been run tested on odroid board.
Change-Id: I9de86728cca255565b31972025db585831176487
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
uzair.jaleel [Mon, 16 Feb 2015 17:00:43 +0000 (22:30 +0530)]
Fix for WRT installer error
Native buffer manager should get called in zero copy only.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11451
Reviewed by: Prashant Nevase, venu musham
Change-Id: Ib151bd2a3a721a8a8b5399863aa24d5073bc5f59
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
uzair.jaleel [Fri, 13 Feb 2015 09:42:33 +0000 (15:12 +0530)]
Fix for Bad drawable error in zero copy
Added XSync(..) call which basically flushes the output buffer
and then waits until all requests have been received and
processed by the X server with this bad drawable issue is fixed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: DaeHyun Ko, Prashant Nevase
Change-Id:I20aa39e43c191bf62f2f12e6f2f6bd6b2b8a1cc5
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Antonio Gomes [Thu, 12 Feb 2015 23:35:39 +0000 (15:35 -0800)]
[M40][Tizen3.0]Enabling gold linker for hawk-p TV target
Recently TV builds started suffering from the following
problem:
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between //usr/lib/libc_nonshared.a(atexit.oS) and output
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/gcc/armv7l-tizen-linux-gnueabi/4.8.3/crtendS.o and output
[ XXs] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/crtn.o and output
The above problem is explained in details here [1] and fixed in
gold linker itself, released as part of binutils-2.24 [2].
However, our current bundled linker gold binary (in build/prebuild)
built by Viatcheslav Ostapenko was based on binutils-2.23 [3].
Patch fixes the problem by rebuilding linker gold from [1]
and enabling it for TV builds.
[1] https://sourceware.org/ml/binutils/2012-12/msg00202.html
[2] http://ftp.gnu.org/gnu/binutils/binutils-2.24.tar.gz
[3] http://ftp.gnu.org/gnu/binutils/binutils-2.23.2.tar.gz
Patch also work arounds a Tizen 3.0 GBS QEMU problem that was causing
the following issue with linker gold:
[ XXs] eu-strip: while writing '<path>/<package>/<binary>': cannot write data to file
Problem is reported in various places, including [4], [5] and [6].
The solution applied to Tizen public requires to patch QEMU [7].
Until our Tizen 3.x QEMU is fixed, we use a home made x64 bit statically
linked eu-strip, so that we can link with gold.
[4] https://bugzilla.redhat.com/show_bug.cgi?id=1174267
[5] http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg02702.html
[6] http://bit.ly/1E8W1Uo
[7] https://review.tizen.org/gerrit/#/c/32365/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10967
Reviewed by: Antonio Gomes, KC Park, Piotr Tworek
Change-Id: Ifd5cb31b1fa6d67eac633e371574c8bbd715f492
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Maciej Piotrowski [Tue, 10 Feb 2015 10:53:20 +0000 (11:53 +0100)]
Define for MENU_ITEM_SEARCH_IN_SPOTLIGHT option in context menu
MENU_ITEM_SEARCH_IN_SPOTLIGHT menu option shouldn't be present on Tizen Mobile.
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: Iaf52620470b430deaec1e52ea589ae57eafab4b1
Signed-off-by: Maciej Piotrowski <m.piotrowski@samsung.com>
Youngcheol Kang [Mon, 16 Feb 2015 12:47:57 +0000 (21:47 +0900)]
Changed the API of the capi-appfw-application in Tizen Mobile
According to the change of API in the capi-appfw-application,
Some API were changed in the browser applications.
- Changed the 'app_event_callback_s' to the 'ui_app_lifecycle_callback_s'
Also below structures were removed about this changing.
> low_memory
> low_battery
> device_orientation
> language_changed
> region_format_changed
- Changed the 'app_efl_main(&argc, &argv, NULL, NULL)'
to the 'ui_app_main(argc, argv, NULL, NULL)'
Reviewed by: Antonio Gomes, Tomasz Weglarski, jong chul park, joonhwan kwon
Change-Id: Ib3ff835851965d6787abaf7bf3d45b424e353ff0
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Suchit Agrawal [Wed, 11 Feb 2015 15:16:44 +0000 (15:16 +0000)]
Add multisampling samples count to '4' for canvas.
Default multisampling count set to 4.
We can change it using command line argument :
--canvas-msaa-sample-count=|value|
Reviewed by: Prashant Nevase, venu musham
Change-Id: I3a33cef5542946af99dd038fa1c9b28c96b767b7
Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Venugopal S M [Sat, 14 Feb 2015 16:54:08 +0000 (01:54 +0900)]
Revert "Remove ffmpeg dependency"
FFT is used for Analyzing WebAudio track. It requires FFMPEG.
This reverts commit
f8d73fd6fe9b0a579d668667f3891a3bb6e8c03e.
This also fixes the renderer crash issue in some webaudio site.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11414
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10516
Change-Id: I93c75a7e6ae55761ddd16ca92c32dbce64ea6623
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
SeungSeop Park [Sat, 14 Feb 2015 14:36:42 +0000 (23:36 +0900)]
Revert "Bring up drag option in context menu"
This reverts commit
e421b5aaf5299487e933b131a98373d485807287.
Daniel Waślicki [Mon, 9 Feb 2015 07:39:27 +0000 (08:39 +0100)]
Bring up drag option in context menu
Starting Drag&Drop has to be started from context menu.
This patch brings up this option, by removing EWK_BRINGUP
check.
Together with: I1af148db205ae3bac19eb76c7756a22d0bf685df
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10755
Change-Id: I90e2cb7266a9aab59e393b74d269b0ab8c527585
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Tomasz Czekala [Sat, 14 Feb 2015 12:52:44 +0000 (13:52 +0100)]
temporary fix! - disable drag&drop
Drag&Drop is causing problems when long pressing links, so it has to
be disabled until it is fixed
Change-Id: I3a603790518ef275e7ee387d458177aec53fd168
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
msu.koo [Fri, 13 Feb 2015 15:03:41 +0000 (00:03 +0900)]
fixup! [Tizen][WebRTC][M0] Enable video capture port on M0
This patch fixed
- Remove unrequired format converting before returning the captured buffer
to VideoCaptureController.
- Fix the issue which the device rotation is
not reflecting to captured video frames.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11388
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: Ib9d6eb0f70784777c24b57d2a602b38e165d311c
Signed-off-by: msu.koo <msu.koo@samsung.com>
Venugopal S M [Thu, 12 Feb 2015 06:45:46 +0000 (12:15 +0530)]
[MM]Gstreamer 1.2 Upversion
- Media Element with GST works with AppSink.
- Media Source Extension works with AppSink.
PIXMAP support for video playback is not present
- WebAudio works
- WebRtc needs platform support
Merged commits:
Ib377730584f3f3ffd61776facb63d8d196f64d1f
I0cc3c9c1c43d97c2c3d518655401be40757c47c7
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10745
Reviewed by: SeungSeop Park, Sharath Kamath, Venugopal S M
Change-Id: I36675af2bbfd63d7d8c7fdfb5bf34585ca57ffd1
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
Daniel Waślicki [Thu, 5 Feb 2015 13:03:36 +0000 (14:03 +0100)]
Added implementation of Drag&Drop for EFL port
This patch adds implementation of Drag&Drop for EFL port.
D&D will be enabled after long press and allows to drag
any elements.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10755
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I3fec12f5bcbd3544b08ba4bd24b23419f828d1fe
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
hyungsun.ryu [Fri, 13 Feb 2015 11:58:48 +0000 (20:58 +0900)]
Disable CAPI port for ME and PIXMAP for Multimedia
Recently, MSE and ME is unstable due to platfrom upversion.
Hence, Using capi-player and PXMAP will be diabled until platfom is stable.
- MediaElement will work using Gstreamer
- ME, MSE and WebRTC will work using appsink.
Reviewed by: Antonio Gomes, Hyungsun Ryu, Piotr Tworek, SeungSeop Park
Change-Id: If76a10f50195c3477b759f10eefed4b7ec040f5e
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
KangYong Park [Fri, 13 Feb 2015 01:35:27 +0000 (10:35 +0900)]
fixup! fixup! Add library path to run layout_test
For importing libraries, it need to get host architecture.
And then, bash operator is used, expecially "==".
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11098
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I17ffc71d231aad7eeff00756a53f949caef5543f
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Tomasz Czekala [Fri, 13 Feb 2015 12:48:29 +0000 (13:48 +0100)]
temporary fix - add Ewk_Context to ewk_notification_showed to make WRT compile
Context was not used and we removed it, but WRT assumes that
ewk_notification_showed takes context as one of the parameters
and after our Notification API refactoring it doesn't compile.
WRT will update to the new API, but for now we need this temporary
fix for it to work.
Reviewed by: Piotr Tworek, joonhwan kwon
Change-Id: I6d1fad4c07c4bdfdbef3511864a4b71abb71b429
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Marcin Kędzierski [Thu, 12 Feb 2015 11:14:02 +0000 (12:14 +0100)]
Remove EWK_BRINGUP from ScopedAllowWait
ScopedAllowWait was disabled in impl directory by EWK_BRINGUP define,
because using ScopedAllowWait caused compilation error. The reason is
that ScopedAllowWait is private part of ThreadRestrictions. It can be
used only if it is a member of a friend class. Adding new friend class
to ThreadRestrictinos was used in m34:
http://suprem.sec.samsung.net/gerrit/#/c/1202/ . We don't want to modify
base classes so Kamil Klimek suggests to use solution taken from android
port. To create class which is already friend of ThreadRestrictions.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7271
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I10ccab9ab7b1d14c1d4153c1272daa6295914afd
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
Tomasz Czekala [Fri, 13 Feb 2015 09:47:24 +0000 (10:47 +0100)]
fixup! Refactor notification API
Moved members initialization to initialization list in unittests to make
the code compatible with older C++ and compile with our mobile toolchain
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9526
Reviewed by: Filip Piechocki, Piotr Tworek, SeungSeop Park
Change-Id: I9f6955a04e172464d8225c9dbab2da2d92f10861
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Dongjun Kim [Wed, 11 Feb 2015 11:24:30 +0000 (20:24 +0900)]
Change position of TTS engine initialization
TTS is always initialized whenever we are open the webpage.
Even if it does not have contents for WebSpeech, tts engine was
initialized.
So, we need to change position of TTS engine intialization
into the "OnInitializeVoiceList()".
TTS engine will begin when page load with tts contents.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10974
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: I48af1aba8745f9abbffcc4f4245b6d0da6e6b295
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Bartlomiej Gajda [Wed, 11 Feb 2015 16:13:36 +0000 (17:13 +0100)]
Enable exporting blink locale pak files, and use them correctly.
[Note] This uses language settings set while browser was run,
to fill locale strings for things like Submit button.
[Requirement] WCS TC 213
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=6508
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: Ia4f21fb0bb18f37457a0c729bf1aa2fb71e9e82e
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Piotr Grad [Thu, 12 Feb 2015 14:00:31 +0000 (15:00 +0100)]
Elm objects were out off screen or not resized upon rotate.
As a workaround of platform issue this patch propagates window size change upon
rotation to all efl popups.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11223
Reviewed by: DONGJUN KiM, Jaesik Chang, Piotr Grad
Change-Id: I5dd559d2c9018819742b6c172376ef40be09d0ae
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Tomasz Czekala [Tue, 3 Feb 2015 07:41:55 +0000 (08:41 +0100)]
Fix user agent setter unittests
Unittests for ewk_view_user_agent_set didn't test it properly. Positive test
case didn't even invoke ewk_view_user_agent_set. This patch adds
meaningful tests and adds tests for empty and NULL string
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10887
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: Ibba46e6579a8542914310c4a3fae6c2dd38a1768
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Lukasz Krok [Mon, 9 Feb 2015 16:39:43 +0000 (17:39 +0100)]
Fix for utc_blink_ewk_view_orientation_send.TEST_0DG test.
If this test is run as first in a test suit,
the orientation will already be 0 degrees (default),
so the orientation change event won't fire
and the test will fail. Setting orientation to other
value before checking ewk_view_orientation_send()
method with 0 as argument resolves the problem.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9541
Reviewed by: DONGJUN KiM, Filip Piechocki, Kamil Klimek
Change-Id: I4e5b96c0b17ec6589aebcd8dca5ea8f3ee9e9477
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Karol Furmaniak [Mon, 9 Feb 2015 12:22:38 +0000 (13:22 +0100)]
Context popup menu is not showing.
Removed creating new efl window for popup.
Added creating context popup menu in webview window,
there is no need to create new one.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9051
Reviewed by: Antonio Gomes, DONGJUN KiM, Piotr Grad
Change-Id: Id4583df4d4c958804baa95ad8c03c5617786d353
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Piotr Tworek [Tue, 10 Feb 2015 11:36:43 +0000 (12:36 +0100)]
Remove dead code and warnings from RenderWidgetHostViewEfl
Chromium removed support for SW rendering around milestone 36.
Chromium-efl port followed upstream and currently needs OpenGL to render
web content. Still there are some code paths left behind frow SW
rendering days. Since nobody seems to be interested in resurrecting
those code paths lets just remove them.
Reviewed by: Antonio Gomes, Daniel Waślicki, SeungSeop Park, arno renevier
Change-Id: Ic3d85229272df9259bde087f95d8f1082fdf27e6
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>