Armin Novak [Thu, 7 Nov 2019 18:31:26 +0000 (19:31 +0100)]
Added KeyboardCodePage option
Thanks to @byteboon for the hint.
Bernhard Miklautz [Thu, 7 Nov 2019 11:13:19 +0000 (12:13 +0100)]
Merge pull request #5703 from akallabeth/reformat
Reformatted to new style
Armin Novak [Thu, 7 Nov 2019 06:59:34 +0000 (07:59 +0100)]
Added cast and checks for info packet.
Armin Novak [Thu, 7 Nov 2019 06:41:48 +0000 (07:41 +0100)]
Fixed NULL checks for strnlen calls, limit static channel name length.
As reported by @metametaclass in #5687 check the strings for NULL before
using strnlen. Also extend the same checks to static channel loading.
Armin Novak [Wed, 6 Nov 2019 14:24:51 +0000 (15:24 +0100)]
Reformatted to new style
Armin Novak [Wed, 6 Nov 2019 14:24:41 +0000 (15:24 +0100)]
Updated format file.
David Fort [Thu, 7 Nov 2019 09:48:56 +0000 (10:48 +0100)]
Merge pull request #5704 from XiaopengZHOU/cursor-xor-padding
Fix padding of encoded scan-line for XOR mask of pointer.
Raphaël ZHOU [Thu, 7 Nov 2019 09:12:22 +0000 (10:12 +0100)]
Fix padding of encoded scan-line for XOR mask of pointer.
Martin Fleisz [Wed, 6 Nov 2019 12:52:33 +0000 (13:52 +0100)]
Merge pull request #5687 from akallabeth/channel_write_leaks
Fixed VirtualChannelWriteEx error case leaks.
Armin Novak [Wed, 6 Nov 2019 11:56:20 +0000 (12:56 +0100)]
Added CHANNEL_EVENT_WRITE_CANCELLED for remdesk channel
Armin Novak [Mon, 28 Oct 2019 15:43:47 +0000 (16:43 +0100)]
Fixed userdata pointer and CHANNEL_EVENT_WRITE_CANCELLED message.
Armin Novak [Mon, 28 Oct 2019 14:13:42 +0000 (15:13 +0100)]
Listen to CHANNEL_EVENT_WRITE_CANCELLED and emit if queue is cleared.
Armin Novak [Mon, 28 Oct 2019 13:57:39 +0000 (14:57 +0100)]
Fixed #4809: Properly process CHANNEL_EVENT_WRITE_COMPLETE
Armin Novak [Mon, 28 Oct 2019 13:28:11 +0000 (14:28 +0100)]
Fixed VirtualChannelWriteEx error case leaks.
Martin Fleisz [Wed, 6 Nov 2019 08:09:22 +0000 (09:09 +0100)]
Merge pull request #5685 from akallabeth/multi_instance_arg_parse
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
Martin Fleisz [Tue, 5 Nov 2019 14:28:02 +0000 (15:28 +0100)]
Merge pull request #5689 from akallabeth/cleanups
Cleanups
Armin Novak [Tue, 5 Nov 2019 13:55:33 +0000 (14:55 +0100)]
Fixed strnlen issues.
Bernhard Miklautz [Tue, 5 Nov 2019 13:19:07 +0000 (14:19 +0100)]
Merge pull request #5690 from akallabeth/winpr_ini_cleanup
Cleaned up ini.h and added error checks.
Armin Novak [Tue, 5 Nov 2019 10:30:26 +0000 (11:30 +0100)]
Removed invalid use of strnlen
Armin Novak [Tue, 5 Nov 2019 09:31:09 +0000 (10:31 +0100)]
Use BOOL return for IniFile_Open_File and IniFile_Load_File
Martin Fleisz [Tue, 5 Nov 2019 08:35:45 +0000 (09:35 +0100)]
Merge pull request #5553 from akallabeth/win_console_fix
Reattach to cmd if wfreerdp was started from one.
Armin Novak [Mon, 4 Nov 2019 10:18:53 +0000 (11:18 +0100)]
Fixed review remarks.
Bernhard Miklautz [Mon, 4 Nov 2019 08:42:27 +0000 (09:42 +0100)]
Merge pull request #5699 from akallabeth/proxy_link_fix
Fix #5693: Add missing link to gfx client channel library
David Fort [Mon, 28 Oct 2019 11:46:18 +0000 (12:46 +0100)]
rdp: fix byte and packet counters
Best to count bytes directly at the transport level.
David Fort [Mon, 28 Oct 2019 11:45:22 +0000 (12:45 +0100)]
fix typo
akallabeth [Sat, 2 Nov 2019 08:57:03 +0000 (09:57 +0100)]
Fix #5693: Add missing link to gfx client channel library
David Fort [Thu, 31 Oct 2019 13:17:50 +0000 (14:17 +0100)]
Merge pull request #5692 from kubistika/proxy/when_possible_do_nla_fallback
server: proxy: client: always do NLA fallback
kubistika [Thu, 31 Oct 2019 09:26:13 +0000 (11:26 +0200)]
server: proxy: client: always do NLA fallback
Armin Novak [Tue, 29 Oct 2019 11:57:19 +0000 (12:57 +0100)]
Fixed warnings from TestEnvironmentGetEnvironmentStrings
Armin Novak [Tue, 29 Oct 2019 11:23:06 +0000 (12:23 +0100)]
Cleaned up TestCryptoHash
Armin Novak [Tue, 29 Oct 2019 10:33:27 +0000 (11:33 +0100)]
Removed strlen from GetComputerNameExA
Armin Novak [Tue, 29 Oct 2019 10:29:47 +0000 (11:29 +0100)]
Fixed length checks for GetComputerNameA
Armin Novak [Tue, 29 Oct 2019 10:25:44 +0000 (11:25 +0100)]
Removed strlen use in wlog (and speed up check)
Armin Novak [Tue, 29 Oct 2019 10:12:15 +0000 (11:12 +0100)]
Fixed int/size_t use for channel add functions.
Armin Novak [Tue, 29 Oct 2019 10:11:53 +0000 (11:11 +0100)]
Fixed tmpnam warning.
Armin Novak [Tue, 29 Oct 2019 09:23:48 +0000 (10:23 +0100)]
Removed strcpy use.
Armin Novak [Tue, 29 Oct 2019 09:18:09 +0000 (10:18 +0100)]
Code cleanups (strlen, casts, size_t, ...)
Armin Novak [Tue, 29 Oct 2019 10:54:55 +0000 (11:54 +0100)]
Cleaned up ini.h and added error checks.
Martin Fleisz [Mon, 28 Oct 2019 14:19:30 +0000 (15:19 +0100)]
Merge pull request #5673 from akallabeth/audin_format_leak_fix
Fixed memory leak when freeing up audin formats.
Martin Fleisz [Mon, 28 Oct 2019 14:18:59 +0000 (15:18 +0100)]
Merge pull request #5670 from akallabeth/cairo_detection_fix
Fix #5669: If cairo is detected as part of other dependencies ignore it
Martin Fleisz [Mon, 28 Oct 2019 13:13:07 +0000 (14:13 +0100)]
Merge pull request #5668 from akallabeth/xfreerdp_mon_check
Added missing check for monitor indices
kubistika [Sun, 27 Oct 2019 11:39:22 +0000 (13:39 +0200)]
server: proxy: export config utils functions to be used by modules
kubistika [Sun, 27 Oct 2019 11:38:31 +0000 (13:38 +0200)]
server: proxy: stop loading session captures config if it is disabled
Armin Novak [Mon, 28 Oct 2019 10:53:12 +0000 (11:53 +0100)]
Use COMMAND_LINE_ARGUMENT_A copy also in shadow server code.
Armin Novak [Mon, 28 Oct 2019 09:10:14 +0000 (10:10 +0100)]
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
Remove the old global structs as the parser modifies them. When using
multiple instances in the same process space this could break parsing.
Martin Fleisz [Mon, 28 Oct 2019 12:06:36 +0000 (13:06 +0100)]
Merge pull request #5676 from akallabeth/hotplug_leak_fix
Hotplug leak fix
Martin Fleisz [Mon, 28 Oct 2019 10:54:23 +0000 (11:54 +0100)]
Merge pull request #5680 from akallabeth/fixes2
Some smaller Fixes
Bernhard Miklautz [Mon, 28 Oct 2019 10:43:17 +0000 (11:43 +0100)]
Merge pull request #5684 from akallabeth/disp_static_fkt
Made disp channel internal functions static.
Armin Novak [Mon, 28 Oct 2019 08:31:50 +0000 (09:31 +0100)]
Made disp channel internal functions static.
Martin Fleisz [Mon, 28 Oct 2019 07:03:44 +0000 (08:03 +0100)]
Merge pull request #5679 from akallabeth/gdi_clamp
Fix gdi coordinate clamping.
Armin Novak [Fri, 25 Oct 2019 12:23:01 +0000 (14:23 +0200)]
Fix #5687: check for file extensions case insensitive.
Armin Novak [Fri, 25 Oct 2019 11:20:28 +0000 (13:20 +0200)]
wts_read_drdynvc_close_response quit message queue.
Armin Novak [Fri, 25 Oct 2019 11:19:42 +0000 (13:19 +0200)]
Added MessageQueue_Dispatch argument checks
Armin Novak [Fri, 25 Oct 2019 10:57:32 +0000 (12:57 +0200)]
Fix gdi coordinate clamping.
Armin Novak [Thu, 24 Oct 2019 12:44:01 +0000 (14:44 +0200)]
Removed experimental warning from gfx
Armin Novak [Thu, 24 Oct 2019 12:34:26 +0000 (14:34 +0200)]
devman_load_device_service device argument can be const.
kubistika [Thu, 24 Oct 2019 07:51:52 +0000 (10:51 +0300)]
server: proxy: refactor config loader
kubistika [Wed, 23 Oct 2019 09:39:58 +0000 (12:39 +0300)]
server: proxy: capture: refactor path creation
kubistika [Tue, 22 Oct 2019 13:06:28 +0000 (16:06 +0300)]
server: proxy: add python script to create a video from session frames
kubistika [Tue, 22 Oct 2019 13:06:05 +0000 (16:06 +0300)]
server: proxy: implement session capture feature
kubistika [Tue, 22 Oct 2019 13:01:00 +0000 (16:01 +0300)]
server: proxy: client use PIXEL_FORMAT_BGRA32 (easier to write frames to bitmap)
kubistika [Tue, 22 Oct 2019 12:58:05 +0000 (15:58 +0300)]
channels: rdpgfx: export API to create rdpgfx client
kubistika [Mon, 2 Sep 2019 13:02:55 +0000 (16:02 +0300)]
winpr: utils: image: fix const correctness
Armin Novak [Thu, 24 Oct 2019 10:18:24 +0000 (12:18 +0200)]
Fixed memory leak when freeing up audin formats.
Armin Novak [Wed, 23 Oct 2019 14:13:25 +0000 (16:13 +0200)]
Fix #5669: If cairo is detected as part of other dependencies ignore it
If WITH_CAIRO=OFF it was still used when the library was detected as
part of some other dependency. With this commit the dependency is
only added if WITH_CAIRO=ON
Armin Novak [Wed, 23 Oct 2019 13:03:39 +0000 (15:03 +0200)]
Added missing check for monitor indices
AzureusNation [Fri, 18 Oct 2019 09:44:24 +0000 (10:44 +0100)]
Fixes hub was not found! error
Again as with auto usb detection strtol needs to use base 10 and force to use base 10 else the conversion does not work correctly.
AzureusNation [Fri, 18 Oct 2019 09:21:58 +0000 (10:21 +0100)]
Fixes Auto USB Redirection
Base 0 does not work when converting the string to long int. This ends up not showing the correct device id and sometimes the wrong bus id. By changing it to base 10 conversion instead of base 0 this fixes the issue of auto redirect usb devices.
David Fort [Tue, 22 Oct 2019 21:35:18 +0000 (23:35 +0200)]
rdp: count in/out bytes and packets
asapelkin [Wed, 16 Oct 2019 16:49:24 +0000 (19:49 +0300)]
Fix some static analizer warnings
kubistika [Tue, 22 Oct 2019 07:38:25 +0000 (10:38 +0300)]
server: proxy: client: terminate the connection if pre connect hook fails
kubistika [Fri, 18 Oct 2019 12:02:59 +0000 (15:02 +0300)]
channels: cliprdr: client: fix leak in cliprdr_packet_send
kubistika [Thu, 17 Oct 2019 15:59:07 +0000 (18:59 +0300)]
channels: cliprdr: improved common cliprdr api
kubistika [Sun, 15 Sep 2019 11:48:12 +0000 (14:48 +0300)]
channels: cliprdr: reformat cliprdr_common.c
kubistika [Sun, 15 Sep 2019 10:53:56 +0000 (13:53 +0300)]
channels: cliprdr: get rid of duplicated server and client code
kubistika [Sun, 15 Sep 2019 10:51:32 +0000 (13:51 +0300)]
channels: cliprdr: remove formatDataResp.dwFlags
According to the channel docs, this field is only used in format data
request. Therefore, there's no need to hold it in the response. cliprdr
server code was copy-pasted from client code, therefore this must be
some leftover.
Martin Fleisz [Thu, 17 Oct 2019 15:00:57 +0000 (17:00 +0200)]
Merge pull request #5657 from akallabeth/warning_fixes2
Warning fixes2
Martin Fleisz [Thu, 17 Oct 2019 10:54:43 +0000 (12:54 +0200)]
Merge pull request #5648 from akallabeth/h264_dyn
H264 runtime detection
Armin Novak [Wed, 16 Oct 2019 12:54:05 +0000 (14:54 +0200)]
Fixed compilation warnings.
Armin Novak [Wed, 16 Oct 2019 12:53:42 +0000 (14:53 +0200)]
Fixed missing initializer
Armin Novak [Wed, 16 Oct 2019 12:53:27 +0000 (14:53 +0200)]
Fixed floating point calculations.
Martin Fleisz [Mon, 7 Oct 2019 08:43:11 +0000 (10:43 +0200)]
Merge pull request #5646 from akallabeth/realloc_fixes
Fixed #5645: realloc return handling
Armin Novak [Mon, 7 Oct 2019 07:47:03 +0000 (09:47 +0200)]
Let shadow server detect H264 support at runtime
Armin Novak [Mon, 7 Oct 2019 07:31:20 +0000 (09:31 +0200)]
Allow freerdp clients to function with WITH_OPENH264_LOADING
If no library can be loaded at runtime ignore H264 capabilities.
This allows a build with only OpenH264 support and dynamic loading
enabled to function when no openh264 library was detected.
Martin Fleisz [Mon, 7 Oct 2019 07:01:26 +0000 (09:01 +0200)]
Merge pull request #5644 from akallabeth/nsc_cleanup
Cleaned up NSC API
Armin Novak [Fri, 4 Oct 2019 15:13:00 +0000 (17:13 +0200)]
Fixed windows shadow server startup issue.
Armin Novak [Fri, 4 Oct 2019 13:52:46 +0000 (15:52 +0200)]
Fixed leak in verify_cb.
Armin Novak [Fri, 4 Oct 2019 13:02:08 +0000 (15:02 +0200)]
Added /buildconfig command line for shadow.
Armin Novak [Fri, 4 Oct 2019 12:49:30 +0000 (14:49 +0200)]
Fixed #5645: realloc return handling
Martin Fleisz [Fri, 4 Oct 2019 11:32:07 +0000 (13:32 +0200)]
Merge pull request #5639 from akallabeth/error_category
Added function to get an error category for better error handling.
Armin Novak [Fri, 4 Oct 2019 09:46:14 +0000 (11:46 +0200)]
Removed check for wrong buffer size.
Martin Fleisz [Fri, 4 Oct 2019 09:23:29 +0000 (11:23 +0200)]
Merge pull request #5643 from akallabeth/openh264_fixes
fixed openh264 related issues, thx to mythos from IRC
Martin Fleisz [Fri, 4 Oct 2019 09:07:37 +0000 (11:07 +0200)]
Merge pull request #5641 from akallabeth/settings_use_after_free
Fixed use after free.
Armin Novak [Fri, 4 Oct 2019 08:13:43 +0000 (10:13 +0200)]
Cleaned up NSC API
Armin Novak [Fri, 4 Oct 2019 08:23:43 +0000 (10:23 +0200)]
fixed openh264 related issues, thx to mythos from IRC
Armin Novak [Thu, 3 Oct 2019 14:15:52 +0000 (16:15 +0200)]
Fixed use after free.
Armin Novak [Thu, 3 Oct 2019 08:59:45 +0000 (10:59 +0200)]
Added function to get an error category for better error handling.
Martin Fleisz [Thu, 3 Oct 2019 06:45:44 +0000 (08:45 +0200)]
Merge pull request #5634 from akallabeth/error_code_update
Added missing error codes.
Martin Fleisz [Wed, 2 Oct 2019 14:48:42 +0000 (16:48 +0200)]
Merge pull request #5636 from akallabeth/silence_cmake
Fix #5635: Silence double WITH_CUPS definition.
David Fort [Wed, 2 Oct 2019 14:34:34 +0000 (16:34 +0200)]
Merge pull request #5633 from akallabeth/event_fd_fix
GetEventFileDescriptor return handle internal event.