Glenn Versweyveld [Thu, 7 Nov 2019 12:22:10 +0000 (13:22 +0100)]
Return all visual elements needed (#8100) fixes #7027
* Return all visual elements needed
Fixes #7027
* Drop the private
Force of habit
* Added testpage
#7027
* Tidy up
VladislavAntonyuk [Thu, 7 Nov 2019 09:55:27 +0000 (11:55 +0200)]
[Bug] WPF ListViewRenderer fails on item tapped with empty item source #7995 (#8223)
* [Bug] WPF ListViewRenderer fails on item tapped with empty item source #7995
* Check ItemSource for null
Gerald Versluis [Wed, 6 Nov 2019 14:48:39 +0000 (15:48 +0100)]
[C] Added ability to predefine value to prompt (#8362) fixes #8346
* Added ability to predefine value
* Prevent ABI break
* Update Issue6713.cs
melimion [Tue, 5 Nov 2019 22:37:43 +0000 (01:37 +0300)]
Fix Button.CornerRadius doesn't work on WPF (#7895)
* fix
* test added
* button without corner radius added to test
fixes #6556
Shane Neuville [Tue, 5 Nov 2019 19:08:36 +0000 (12:08 -0700)]
Fix corner clipping on ImageButton and Button (FR) (#7723)
* Clip Button/ImageButton to corner radius
* - add ui test
* - fix warnings
Felipe Baltazar [Tue, 5 Nov 2019 16:33:28 +0000 (13:33 -0300)]
Fix 7181 | [Bug] Cannot update ToolbarItem text and icon (#8254) fixes #7181
* Created handler for Toolbaritem.OnPropertyChanged
* Code review ♻
* Code review ♻
Oliver Brown [Tue, 5 Nov 2019 14:53:33 +0000 (14:53 +0000)]
[macOS] Add character spacing to button and label (#8206)
* Add character spacing extension method to macOS
* Add character spacing to label on macOS.
* Add character spacing for button on macOS
* Add color pickers to character spacing gallery to check everything works with colors.
* Make character spacing and text color work properly together on button and label on macOS.
Joe Manke [Tue, 5 Nov 2019 14:52:34 +0000 (08:52 -0600)]
[Android Maps] Check for location permissions when IsShowingUser=true (#7282) fixes #4691
* Check for location permissions when IsShowingUser=true instead of crashing
* Fix courseLocationPermission -> coarseLocationPermission
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Mohamed CHOUCHANE [Tue, 5 Nov 2019 00:39:17 +0000 (01:39 +0100)]
[WPF] View doesn't render when set IsClippedToBounds to true (#8195)
fixes #5910
fixes #8087
Gerald Versluis [Mon, 4 Nov 2019 23:09:26 +0000 (00:09 +0100)]
Update FrameRenderer.cs (#7871)
fixes #7667
Oliver Brown [Mon, 4 Nov 2019 22:18:51 +0000 (22:18 +0000)]
[iOS] [macOS] Fix HTML string encoding (#8265)
* Improve HTML tests.
* Load HTML as UTF-8. Fix 8156
* Separate document attributes into a virtual method
fixes #8156
CleanCodeDeveloper [Mon, 4 Nov 2019 20:14:04 +0000 (21:14 +0100)]
[UWP] Enables usage of font image source for bottom bar tabs (#8354)
* Update StoreShell.xaml
Demonstrates the problem, FontImageIcon is not displayed in Bottom Tab Bar
* Update ShellItemRenderer.cs
Enables usage of FontImageSource for Tabs in Bottom Bar
Felipe Baltazar [Mon, 4 Nov 2019 20:04:22 +0000 (17:04 -0300)]
Fixe issue 5367 | Crash assigning excessively long text to Editor with MaxLength property set (#8052) fixes #5367
* Fixe issue 5367 🐛
* Code review
* code review
Rui Marinho [Mon, 4 Nov 2019 13:28:16 +0000 (13:28 +0000)]
Merge branch '4.4.0'
Rui Marinho [Mon, 4 Nov 2019 13:26:25 +0000 (13:26 +0000)]
Merge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 4 Nov 2019 13:10:00 +0000 (13:10 +0000)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Fri, 1 Nov 2019 20:58:47 +0000 (20:58 +0000)]
[Android] Fix API21 usage on shell (#8335)
* [Android] Fix API21 usage
* [Android] Remove extra usings
E.Z. Hart [Fri, 1 Nov 2019 20:20:32 +0000 (14:20 -0600)]
Prevent UWP error/crash when updating binding off the main thread; fixes #8167 (#8311)
Konrad Müller [Fri, 1 Nov 2019 18:50:32 +0000 (19:50 +0100)]
[iOS] Fix scroll to does not scroll to end (#8241)
* Fix scroll to does not scroll to end
* Remove private modifier
kingces95 [Thu, 31 Oct 2019 17:10:59 +0000 (07:10 -1000)]
multithreaded droid os calls during startup (#8245)
Rui Marinho [Thu, 31 Oct 2019 17:06:42 +0000 (17:06 +0000)]
[Build] Clean repos, update vs image (#8339)
Glenn Versweyveld [Thu, 31 Oct 2019 10:37:35 +0000 (11:37 +0100)]
Check for ValueType items to perform equals (#8299)
Johann Weiher [Thu, 31 Oct 2019 10:35:09 +0000 (11:35 +0100)]
macOS: Fixed IsPresented PopOver (#8312)
#3149
Samantha Houts [Thu, 31 Oct 2019 00:31:13 +0000 (17:31 -0700)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#8096)
adrianknight89 [Wed, 30 Oct 2019 21:15:20 +0000 (16:15 -0500)]
change accessibility modifiers (#8264)
Jon Robinson Levy [Wed, 30 Oct 2019 15:49:37 +0000 (16:49 +0100)]
Fix 8222 - [UWP] Make text in Editor control top aligned (#8280)
* Adding test case page for Issue 8222.
* Adding top alignment to text by setting VerticalContentAlignment = Verticalalignment.Top in the internal FormsTextBox. Fixes Issue 8222.
* Removing version file added by mistake
* Removing version file added by mistake
* Removing version file added by mistake
* Removing version file added by mistake
Durgesh Khandal [Wed, 30 Oct 2019 12:33:05 +0000 (18:03 +0530)]
Fixed - 5830 - Updated access modifier for EntryCellTableViewCell (#8286) fixes #5830
Konrad Müller [Wed, 30 Oct 2019 12:00:42 +0000 (13:00 +0100)]
implement placeholder text alignment (#8292)
Gerald Versluis [Wed, 30 Oct 2019 10:50:09 +0000 (11:50 +0100)]
Implement fix (#8281)
Rui Marinho [Tue, 29 Oct 2019 23:51:51 +0000 (23:51 +0000)]
Merge branch '4.4.0'
Rui Marinho [Tue, 29 Oct 2019 23:50:57 +0000 (23:50 +0000)]
Merge branch '4.3.0' into 4.4.0
Glenn Versweyveld [Tue, 29 Oct 2019 17:07:59 +0000 (18:07 +0100)]
Add ListViewHeaderItemMinHeight override in UWP resources.xaml (#8010)
* Add ListViewHeaderItemMinHeight override in UWP resources.xaml
* Amend csproj
Stephane Delcroix [Tue, 29 Oct 2019 17:06:35 +0000 (18:06 +0100)]
[C] Parent the ImageSource (#8063)
* [C] Parent the ImageSource
Properly parent the imagesource, instead of only setting the inherited context.
Allows proper propagation of DynamicResources and Styles
- fixes #6996
* fix merge
:bell: shame!
Pieter Nijs [Tue, 29 Oct 2019 14:09:19 +0000 (15:09 +0100)]
iOS: Frame with HasShadow set to true and BackgroundColor alpha < 1 casts shadow on all child views (#7518)
* Updated renderer with additional ShadowView
* Added buttons to test some behavior
* ShadowLayer background color tweaks
* Resolved flawed merge, restored _Template page
* Apply suggestions from code review
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Added more descriptive issue Title
* Updated Issue5108.xml's properties
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
Fixed missing closing tags
* Updated projitems
* Removed eventhandlers from XAML
* Update Issue5108.xaml.cs
Added eventhandlers in code + surrounded code-behind with APP preprocessor directive to avoid issues when building for UITEST
Rui Marinho [Tue, 29 Oct 2019 13:08:11 +0000 (13:08 +0000)]
[Android] Make sure we use the right Context (#8196)
Sławomir Kulików [Tue, 29 Oct 2019 12:19:49 +0000 (13:19 +0100)]
[macOS] Visual glitch when exiting the full screen with ScrollViewer (#8086) fixes #4854
* added test for issue4854
* fix issue4854
Javier Suárez Ruiz [Tue, 29 Oct 2019 11:31:39 +0000 (12:31 +0100)]
[Android] Fixed issue refreshing CollectionView using ScrollView inside DataTemplate (#8224) fixes #8198
* Fixed issue 8198 - ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh
* Added instructions to the Issue8198
* Added support for WebView on Android to align functionality with iOS
* Added more RefreshView Core Gallery samples
* Updated new samples
* Updated instructions text
Samantha Houts [Tue, 29 Oct 2019 11:18:34 +0000 (04:18 -0700)]
[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145
* Add test case for issue 8145
* [Android] Don't double dispose the more sheet
fixes #8145
Durgesh Khandal [Tue, 29 Oct 2019 10:35:04 +0000 (16:05 +0530)]
Fixed 5680 - Added method to force value coercion (#8097)
Shane Neuville [Tue, 29 Oct 2019 00:42:11 +0000 (18:42 -0600)]
Better detect IsCollapsed state/changes on master (#8181)
Shane Neuville [Tue, 29 Oct 2019 00:41:14 +0000 (18:41 -0600)]
[UWP] Delay RequestRefresh until Loaded (#8190)
fixes #8186
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)
kingces95 [Mon, 28 Oct 2019 22:37:49 +0000 (12:37 -1000)]
Fix unbalanced profiler push/pop (#8213)
Stephane Delcroix [Mon, 28 Oct 2019 18:25:35 +0000 (19:25 +0100)]
[X] resolve indexers on generic types (#8226)
The lovely #7837 is trying to be smarter at identifying which indexer to invoke,
by checking the parametertype. Of course, it wasn't tested on generic types...
So this is definitely a regression, I apologize for it.
- fixes #8221
melimion [Mon, 28 Oct 2019 18:24:00 +0000 (21:24 +0300)]
Scrolled event implemented (#8197)
Shane Neuville [Mon, 28 Oct 2019 17:26:55 +0000 (11:26 -0600)]
Fix Flyout behavior so it propagates from templated Content Page once it's created (#8135) fixes #7985
* Centralize SendAppearanceChanged call
* - Appearance Change UI tests
* - remove extra button and add better messaging
* - make sure there is space to swipe
* - fix rebase
* - only call appearance change if display page changes
* - process appearance changes before page has fully popped
Rui Marinho [Mon, 28 Oct 2019 12:40:41 +0000 (12:40 +0000)]
Merge branch '4.4.0'
Rui Marinho [Mon, 28 Oct 2019 12:21:29 +0000 (12:21 +0000)]
[Build] Remove duplicated compile items
Rui Marinho [Mon, 28 Oct 2019 11:42:23 +0000 (11:42 +0000)]
[Build] Fix merge
Rui Marinho [Mon, 28 Oct 2019 11:19:17 +0000 (11:19 +0000)]
Merge branch '4.4.0'
Rui Marinho [Mon, 28 Oct 2019 11:18:20 +0000 (11:18 +0000)]
Merge 4.3.0 to 4.4.0
Felipe Baltazar [Fri, 25 Oct 2019 22:39:48 +0000 (19:39 -0300)]
Fix Bug 7396 - Shell: Setting Shell.BackgroundColor overrides all colors of TabBar (#7962)
* Fix to bottom tabbar icon/text color 🐛
* Code review ♻
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7396.cs
Co-Authored-By: Shane Neuville <shane94@hotmail.com>
Glenn Versweyveld [Fri, 25 Oct 2019 22:35:41 +0000 (00:35 +0200)]
Let UICollectionViewCell handle state itself (#7884)
Fixes #7416
E.Z. Hart [Fri, 25 Oct 2019 22:25:22 +0000 (16:25 -0600)]
Disable packager in iOS ItemsViewRenderer (#8189)
* fix collectionview renderering weirdness
* add ui test
* include in projitems
* Disable the VisualElementPackager for the ItemsView
Shane Neuville [Fri, 25 Oct 2019 14:38:53 +0000 (08:38 -0600)]
Store references to local variable so it's not collected (#8205)
Gerald Versluis [Fri, 25 Oct 2019 14:07:07 +0000 (16:07 +0200)]
iOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850
* Update CellRenderer.cs
* Update CellRenderer.cs
* Update CellRenderer.cs
Alan Grgic [Fri, 25 Oct 2019 11:37:46 +0000 (06:37 -0500)]
use support libs for DrawableWrapper (#8106) fixes #6291
Samantha Houts [Thu, 24 Oct 2019 23:25:50 +0000 (16:25 -0700)]
Update GitInfo.txt
melimion [Thu, 24 Oct 2019 18:24:51 +0000 (21:24 +0300)]
foreground color fix (#8149)
fixes #8148
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)
Brian Macomber [Thu, 24 Oct 2019 10:11:24 +0000 (05:11 -0500)]
Rebase and Clean Up (#8107)
adrianknight89 [Thu, 24 Oct 2019 09:56:06 +0000 (04:56 -0500)]
Added instructions and changed the test for Issue2241 (#8080) fixes #2274
* added instructions
* cache old centerY
* Revert "cache old centerY"
This reverts commit
cd75d74654d23359cf3ab72d601cb4109a94cda0.
Glenn Versweyveld [Thu, 24 Oct 2019 09:50:46 +0000 (11:50 +0200)]
Set correct MinWidth for CheckBox style (#7978)
Fixes #7048
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Gerald Versluis [Thu, 24 Oct 2019 09:43:27 +0000 (11:43 +0200)]
[Android] Null checks (#7941) fixes #7939
Konrad Müller [Thu, 24 Oct 2019 07:49:25 +0000 (09:49 +0200)]
Fix bug 7581 - UWP Map not moving to location when map hidden then shown (#7960)
* Add repro
* Set region on layout when move to region failed before
Andrei [Thu, 24 Oct 2019 00:27:09 +0000 (03:27 +0300)]
[Enhancement] Batch updates via "using" statement (#7807)
* Added batch object
* updated unit tests
Oliver Brown [Wed, 23 Oct 2019 23:09:55 +0000 (00:09 +0100)]
[iOS] Fix iOS ScrollToAsync not completing when scrolling to current location (#7979)
* Add test case for scroll completed.
* Check iOS scrollview for scrolling to the same place.
fixes #7972
Andres G. Aragoneses [Wed, 23 Oct 2019 23:02:59 +0000 (07:02 +0800)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#3904) (#8096)
* Revert "[GTK] Fix visibility of hidden pages in the stack (#3904)"
This reverts commit
b5b9404bda761e7e5941da7ff26f1d42dd62d1b2.
# Conflicts:
# Xamarin.Forms.Platform.GTK/Controls/Page.cs
* Added test sample for #6663
Fixes #6663
melimion [Wed, 23 Oct 2019 23:01:52 +0000 (02:01 +0300)]
[macOs] implements Frame CornerRadius (#8168)
* implement CornerRadius in FrameRenderer
* add CornerRadius to FrameCoreGalleryPage
* CornerRadius added to Frame enum in TestAttributes
Ravinder Jangra [Wed, 23 Oct 2019 18:50:10 +0000 (00:20 +0530)]
[Android] Fix Material button renderer setbackgroundcolor (#8089) fixes #5747 fixes #7002
Bohdan Benetskyi [Wed, 23 Oct 2019 18:22:27 +0000 (20:22 +0200)]
Fix System.OverflowException for Hsl with double in invariant string (#8114) fixes #8113
Mikolaj Kieres [Wed, 23 Oct 2019 18:06:24 +0000 (05:06 +1100)]
Adding instructions to the UI Test (issue #38770) (#8062)
Ravinder Jangra [Wed, 23 Oct 2019 12:07:00 +0000 (17:37 +0530)]
Fix android scrollbar visibility issue (#8090) fixes #7629 #8015
Shane Neuville [Wed, 23 Oct 2019 10:37:02 +0000 (04:37 -0600)]
Don't force the Master page closed on disappear if it's set to always visible (#8164)
* Don't force master closed when on split
* - fix UI tests to correctly test for tablet
* - remove extra code
* - fix issue with rotation from Modal
Mikolaj Kieres [Wed, 23 Oct 2019 08:15:16 +0000 (19:15 +1100)]
Automating bugzilla issue 33870 (#7968)
* Automating bugzilla issue #33870
* Adding UITest category
* Fixing a typo
Elashi [Tue, 22 Oct 2019 16:50:36 +0000 (19:50 +0300)]
In Android : Reverse layout only when default layout direction is the… (#7809)
* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393)
* - remove ReverseLayout and just rely on LayoutDirection
* - fix formatting
Rui Marinho [Tue, 22 Oct 2019 09:54:50 +0000 (10:54 +0100)]
Fix random test failures (#8083)
* [UITEsts] Ignore vertical test
* [UITests] Ignore 5766 uitest
* [UITests] Ignore UITest 1342
Andrei [Tue, 22 Oct 2019 09:52:35 +0000 (12:52 +0300)]
Unregister effects on dispose (#8109)
Shane Neuville [Mon, 21 Oct 2019 19:50:47 +0000 (13:50 -0600)]
Set MinimumWidth to the correct value on grid calc (#7318)
fixes #7303
melimion [Mon, 21 Oct 2019 19:49:46 +0000 (22:49 +0300)]
opacity mask added to FrameRenderer (#7828)
fixes #7825
Shane Neuville [Mon, 21 Oct 2019 19:03:27 +0000 (13:03 -0600)]
set XF Verions File to be hidden (#8128)
Joe Manke [Mon, 21 Oct 2019 10:16:17 +0000 (05:16 -0500)]
[Android] Use AppCompat AlertDialog (#8046)
* Change Android ControlGallery theme to inherit from Theme.AppCompat.DayNight to test GitHub issue #8029
* Use AppCompat AlertDialog in Android PopupManager
* Apply style to both default and AppCompat dialogs for comparison.
Stephane Delcroix [Mon, 21 Oct 2019 08:45:57 +0000 (10:45 +0200)]
Merge branch '4.3.0'
Stephane Delcroix [Mon, 21 Oct 2019 08:40:15 +0000 (10:40 +0200)]
Merge branch '4.2.0' into 4.3.0
melimion [Fri, 18 Oct 2019 17:28:29 +0000 (20:28 +0300)]
Fix ListView.ScrollTo does not work in WPF (#7947)
* ScrollTo implementation added
* ScrollToPosition.Center implemented
* animation implemented
Konrad Müller [Fri, 18 Oct 2019 14:07:40 +0000 (16:07 +0200)]
Always use current dispatcher to invoke wpf timer (#7958) fixes #6957
Rui Marinho [Fri, 18 Oct 2019 12:03:53 +0000 (13:03 +0100)]
[MacOS] FIx agains NRE on disposing Entry renderer (#8019)
Gerald Versluis [Fri, 18 Oct 2019 12:03:43 +0000 (14:03 +0200)]
[MacOS] Fixed NRE with modal navigation (#7900)
* Added repro and fix
* Added UITest
adrianknight89 [Fri, 18 Oct 2019 11:54:16 +0000 (06:54 -0500)]
Add instructions and change UI test (#8077) fixes #2351
adrianknight89 [Fri, 18 Oct 2019 11:52:08 +0000 (06:52 -0500)]
added instructions (#8076) fixes #2352
Steven Thewissen [Fri, 18 Oct 2019 11:22:48 +0000 (12:22 +0100)]
Add extension methods for ScaleXTo and ScaleYTo (#8007) fixes #8004
* Add extension methods for ScaleXTo and ScaleYTo
* Updated sample with small description
* Updated test
Jon Robinson Levy [Fri, 18 Oct 2019 10:25:56 +0000 (12:25 +0200)]
Fixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElement, to check if the supplied NavigationPage Eelement has a CurrentPage. If not, an InvalidOperationException is thrown. (Otherwise a NullReferenceException would be thrown at a later point.) (#8034)
Mikolaj Kieres [Thu, 17 Oct 2019 17:53:54 +0000 (04:53 +1100)]
Created automated UI tests for issue 1769 (#8020)
ShaneN [Thu, 17 Oct 2019 17:35:08 +0000 (11:35 -0600)]
Merge branch '4.3.0'
Mikolaj Kieres [Thu, 17 Oct 2019 10:49:52 +0000 (21:49 +1100)]
Creating automated UI tests for the issue 1747 (#8023) fixes #2237
shmin [Thu, 17 Oct 2019 10:41:09 +0000 (19:41 +0900)]
[Tizen] Add Meterial Stepper Renderer (#8037)
Glenn Versweyveld [Thu, 17 Oct 2019 07:35:36 +0000 (09:35 +0200)]
Make UpdateCancelButton virtual (#8027)
This allows people to override the default behaviour
Oberdan Bitencourt Ferreira [Thu, 17 Oct 2019 07:32:54 +0000 (04:32 -0300)]
Preventing NRE when setting accessibility label while disposing controls (#8051)
fixes #5612
Shane Neuville [Thu, 17 Oct 2019 06:44:25 +0000 (00:44 -0600)]
Make the Refresh View Respect Command CanExecute and add Refreshing event (#7866)
* Make Refresh View respect Command CanExecute
* - force isrefreshing false when isenabled fasle
- Add IsRefreshing Event
* - shift command execution up to xplat code
* - fix ui test
* - cleanup
* - add additional check
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7803.xaml.cs
* - fix flag
E.Z. Hart [Wed, 16 Oct 2019 20:54:16 +0000 (14:54 -0600)]
[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)
* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes #7700
* Fix renaming error in UI test
* Add test and fix for adding groups offscreen
* Fix rebase error
* Remove flags
* Add instructions
* Better instructions