Fixed missing input sanitation for GFX surfaces.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit 5592cb2e10da42592af98f5533d2e42181e86821)

Fixed input sanitation in rdpgfx_recv_solid_fill_pdu

The input rectangle must be checked for plausibility.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit d862a03cbf88ec6e76e47b84eae7e214690cb607)

Fix seeking in Cache Brush and other Secondary Drawing Orders

(cherry picked from commit 9f7e475c1652c2b1e30e0406ec0bc7ea3f2330ff)

Fixes #6374

Merge pull request #6319 from akallabeth/stable-2.0-backports3

Stable 2 backports from master

server: proxy: add extern C for c++ plugins

(cherry picked from commit 755d20501bac9c935a88d0ba040a4410681c1aa7)

server: proxy: rail: Fix rail handshake flags sync issue at reconnect

(cherry picked from commit cc9ef8f74e59f9351aca84a2a95048a4af274af6)

rail: server: add API to set railHandshakeExflags

(cherry picked from commit 004c2f49e4068270cbd5cfb9f44c015c6fb931ea)

server: proxy: fix race issue

Proxy server might receive input updates while client side being
redirected (and reset), then a heap-after-free might occur. To solve
this, we register server input/update callbacks only after client is
fully activated.

(cherry picked from commit db0196fd01faa4234a4b2cabadb5f4cb16edeef1)

Updated version information for 2.2.0 release

Fixed urbdrc device path

(cherry picked from commit 63747000982f70bc169ff037bccb1bbcfd697747)

Fixed bDeviceClass check in udev_init

Use the proper constant  0xef (Miscellaneous) instead of
0xfe (Application Specific)
See https://www.usb.org/defined-class-codes

(cherry picked from commit b97cb4c95dd085142cadf1645505264632d1af21)

Replaced malloc in urbdrc channel

(cherry picked from commit 3ae6feeebe8638c3bea76fd270f3fd46ee768ff2)

Fixed discrepancy in string descriptor default

(cherry picked from commit 747513d901ae50c8223a5ddd5b447436bb782a66)

Replaced memset in urbdrc

(cherry picked from commit e84c3829bf942b28cd6ef4d7cff4d5f8cca8a5f8)

Unified logging for urbdrc libusb wrapper

(cherry picked from commit a81001c3a33818561bf0e6193e219b1b3245391d)

Initialize variable in func_instance_id_generate

(cherry picked from commit a4a4992750085367e52623209c94ed3f1c66b25b)

Improved error log for string descriptor read issues

(cherry picked from commit dd2589cebcac5b39c6af9bbe9f444f6451e9ad4b)

Reverted check for short usb descriptor

(cherry picked from commit 6ba67a07beeb44878912851cf6ed6c6bf7443e09)

Added compile time urbdrc debug option

(cherry picked from commit 5244efadcfb158c813d79b8e8c068fc33198f79b)

Dump USB channel data with log-level trace

(cherry picked from commit e32ba76deb8e16834a5bb0d099cc08d1ed44c04d)

server: proxy: proxy rdp heartbeats

(cherry picked from commit 659e4c772bbc7e3807dc94628934e8982f8efcf7)

libfreerdp: core: add ServerHeartbeat callback

(cherry picked from commit 2096ede5cc8caa209c532438e3a1173f6b47e2c4)

Moved pthread non portable function checks before ASAN

(cherry picked from commit 4d529f6f952c3632e13ba43261c263e5b83eca68)

Refined asan checks

Find threads before ASAN checks as for android builds the check
might fail if done afterward.

(cherry picked from commit 44f2e869820c9a33e8875982d20e9bb561736ce1)

Removed unnecessary checks for asan

check_c_compiler_flag is unreliable, only use where absolutely
necessary.

(cherry picked from commit 7864a985d48f0fba4d431b196464f2075ebacd4b)

rail: server: rename rail_send_pdu -> rail_server_send_pdu

(cherry picked from commit ec06a98e84690a9cf64d080145b71ca9a2e084fa)

rail_common.c: Fix rail_get_order_type_string

(cherry picked from commit 5438b94c979728feeccd13374c77c4881eda8137)

rail: server: mark rail_send_pdu as static function

(cherry picked from commit c3b28e8bced83dd992854e18b8f82eef7af9e54d)

Fixed #6335: windows client title length

(cherry picked from commit dfbeeb1e16d61734319dd32d25ee12e8715a1bc1)

Added hint for errors due to missing offscreen-cache

(cherry picked from commit 57e7a99393fd3db79cd2a78e6a447aaf2540c521)

Use CMake to detect availability of getlogin_r

(cherry picked from commit 3a5bfd2bd0eee134dbac4a98dcb3ed5227a8c6dc)

Fixed uninitialized value

(cherry picked from commit dc112d19355491f1b5e23631c15c5d960746bfac)

Filter GSM codec for microphone redirection

(cherry picked from commit c5984ff811f40b0382a251e76fc5f3690339f80a)

nsc: Fix memory leak

Fixes the following memory leak:

==115716== 16,662,960 bytes in 459 blocks are definitely lost in loss record 3,504 of 3,504
==115716==    at 0x48396AF: malloc (vg_replace_malloc.c:306)
==115716==    by 0x4C6A4E2: nsc_context_initialize_encode (nsc_encode.c:77)
==115716==    by 0x4C6A4E2: nsc_compose_message (nsc_encode.c:497)

(cherry picked from commit 9bd457405095c94a24175bc54bd99947fcf6a33d)

Fixed creating release zip from folder

(cherry picked from commit 16350dcdda73767c7012a2c8f09405944b39d09a)

Fixed #6298: Mask CACHED_BRUSH when checking brush style

(cherry picked from commit ce1a9d8d1969ecbb4d24b9f4812654638a44abc2)

Fixed spelling, print errors to stderr

(cherry picked from commit b50525d1fb47aa6b07450c10f8ad7b5245e523fa)

Fixed bug with creating release source_version

(cherry picked from commit 5490ce50992716d9230bd3ac84b3e819f1c5649f)

Merge pull request #6285 from akallabeth/stable-backports2

Stable backports

Updated versions to 2.1.2

Added changelog for 2.1.2

(cherry picked from commit 5dc50f64183755862cca75cf151933c42fabbb90)

Fixed possible integer overflow in crypto_rsa_common

Thanks @anticomputer for pointing this out

(cherry picked from commit 02c5ec66e5b47fe4cf2fc96e2cd387a18e3f2bb6)

Fixed fallback to getlogin for android

(cherry picked from commit caff01877d4df5f25a983b3aa5e57dde6a16a62f)

Removed duplicate semicolon

(cherry picked from commit 308c2c3544763873a5bea4d18c72c9f62e1584cb)

Fixed OOB read in ntlm_av_pair_get

CVE-2020-11097 thanks to @antonio-morales for finding this.

(cherry picked from commit 58a3122250d54de3a944c487776bcd4d1da4721e)

Fixed broken const variable.

(cherry picked from commit 1c6a6923f87dcfb295c508963f21bebbbc4292ae)

Reset freed HGDI_DC

CVE-2020-4031 thanks to @antonio-morales for finding this.

(cherry picked from commit f753c25ad3d5dae7890fe73cfb3c091c015d97ed)

Fixed out of bound read in RLEDECOMPRESS

CVE-2020-4033 thanks to @antonio-morales for finding this.

(cherry picked from commit 0a98c450c58ec150e44781c89aa6f8e7e0f571f5)

Fixed OOB read in update_recv_secondary_order

CVE-2020-4032 thanks to @antonio-morales for finding this.

(cherry picked from commit e7bffa64ef5ed70bac94f823e2b95262642f5296)

Fixed TrioParse and trio_length limts.

CVE-2020-4030 thanks to @antonio-morales for finding this.

(cherry picked from commit 05cd9ea2290d23931f615c1b004d4b2e69074e27)

Fixed OOB read in update_read_cache_bitmap_v3_order

CVE-2020-11096 thanks @antonio-morales for finding this.

(cherry picked from commit b8beb55913471952f92770c90c372139d78c16c0)

Fixed invalid access in update_recv_primary_order

CVE-2020-11095 thanks @antonio-morales for finding this.

(cherry picked from commit 733ee3208306b1ea32697b356c0215180fc3f049)

Use localtime_s on windows

(cherry picked from commit c3a1ed780cc4aed639e3391d7cafb9edc9dc623c)

Replaced gmtime with gmtime_r

(cherry picked from commit a45afe9db77a19e5a177fe1dc3e85119013f9587)

Fixed codition with side effects

(cherry picked from commit 1a02af5a12b400fcb6ad121a0a71e4440c2e9152)

Fixed pcap cleanup

(cherry picked from commit 3ac7bb5d6a743b19e8686410d5ec6dcf74869ebe)

Fixed double free

(cherry picked from commit 6d86e20e1e7caaab4f0c7f89e36d32914dbccc52)

Replaced getlogin with getlogin_r

(cherry picked from commit 36478d3d0b3d7fa378a875f60170a08e94747226)

Replaced localtime with localtime_r

(cherry picked from commit 240fdd07b123594a1f7a460de7e6877b1963d09e)

Fixed memory leaks in ntlm

(cherry picked from commit 057b6df4aebbe8e739139087dfaab15104ca5ba7)

Fixed Out-of-bound read in glyph_cache_put

CVE-2020-11098 thanks to @antonio-morales for finding this.

(cherry picked from commit c0fd449ec0870b050d350d6d844b1ea6dad4bc7d)

Fixed OOB Read in license_read_new_or_upgrade_license_packet

CVE-2020-11099 thanks to @antonio-morales for finding this.

(cherry picked from commit 6ade7b4cbfd71c54b3d724e8f2d6ac76a58e879a)

Respect SECBUFFER_READONLY flag in NTLM EncryptMessage

(cherry picked from commit 8e45a2dd50d5db6ac6125e0f60e833b6c6c6ea1b)

Added missing SECBUFFER_READONLY flag in rpc_client_write_call

(cherry picked from commit 0d80353bf30de860dcf86285c4e5e2770bc036f7)

TSG improvements

* Respect connection timeout during connect
* Better debug output
* Cleaned up data types,

(cherry picked from commit ff79636d3311269ec35fc1d6cc4246eef500ad5e)

Fixed missing lock during buffer submit.

(cherry picked from commit c902f583d0911c1e8938c5f14f3f257eb9737745)

Revert "winpr/library: Use RTLD_GLOBAL for dlopen"

Using RTLD_GLOBAL in LoadLibraryA introduces a different behavior than
expected.

This reverts commit d566e00258daffcb4c703afc3685e9a42ad01453.

(cherry picked from commit 529e30c273ba67e3924b9fe4419410888314d31f)

fix [client channels]: move exported API calls to client/common

The functions mappedGeometryRef and mappedGeometryUnref are API
functions ([1]) but were implemented in the geometry channel.
In case FreeRDP was built with BUILTIN_CHANNELS=OFF those functions
weren't available globally but used by the video channel.

Now the functions are fixed part of the freerdp-client library and
therefore available for all channels.

[1] exported in freerdp/client/geometry.h

Fixes #6236

(cherry picked from commit 1628939227fa82fa492f068f178f0cc0a42c518b)

Fixed double free for uwac buffers

(cherry picked from commit 1bc48b058f013a8c88db2a1d7da2ad25dcd3bc4c)

Lock wayland buffer updates

(cherry picked from commit 7361f75d11b77f998cf7dee08c8aa619df98754a)

server: proxy: cap plugin: fix var and func declaration

(cherry picked from commit 0cf764f170384b1f65aa4950f54c668f8212ac11)

server: proxy: implement session capture plugin

(cherry picked from commit 19809bf338e5503a33664440d0de9313dca038a3)

winpr: image: add API to construct bmp header

(cherry picked from commit 920acd4c0ee7f9112d77756b0c41474212446609)

Fixed compilation issue with shadow pam code

(cherry picked from commit e1e0f965e8636c587aea7762a94d611e193e07f3)

Fixed surface locking for shadow server.

(cherry picked from commit a38d6c53a62cdea302fbeb4e466bce22c006d20c)

Do not remove transfer data on usb cancel transfer

(cherry picked from commit a5e2d62e48619d5502f5334d431ee7d66ae9e4aa)

Fixed double free in urb_isoch_transfer_cb

(cherry picked from commit ef4de12887486857f7eec37ef93df692b2ecedf0)

Fixed sign compare warnings with constants.

(cherry picked from commit 5ec66cc6c79dadf4c3426060d5bb30ddb360f292)

fix +unmap-buttons option having the opposite effect

(cherry picked from commit 4607a2766afd2875696b7b7febd9dc63f778b8d7)

Improve X11 shadow authentication reason failure log

(cherry picked from commit e66ee477c00b91cddc228adaf1577be602e4f725)

Fix usage of DsMakeSpn with IP address hostnames

(cherry picked from commit 4e7b60b0028f5d33139065fb965c5cd9d2f6ec1d)

MessageQueue write time to current message not the next

(cherry picked from commit ea4df3f91a63c17f6a9bbf8d1b54f462004a992c)

Fixed #6267: adjust write_pixel_16 endian handling

(cherry picked from commit 51d3e07c8a4bca32bf82538075e4518b63e8ed4d)

uwac: don't try to use O_TMPFILE on FreeBSD

Currently, this sets an invalid open flag and attempts to open(), which
will fail.  Instead of doing that, don't try to define O_TMPFILE where
such a definition can't exist and force the fallback rather than making
an always-fail open() call.

(cherry picked from commit 082ddb3d2bd068536c17a4dbddcafd465ffcba3a)

drdynvc: client: fix #6252 use-after-free

(cherry picked from commit 6ed765c96052c65f16fb1964705bd5c894b51b78)

Fixed formatting.

(cherry picked from commit d1b310d970592226b2f0a70710ad3ae3da61c4bc)

smartcard: Teoretical fix of uninitialized values

This tries to fixes the following defects reported by covscan tool:
 - channels/smartcard/client/smartcard_operations.c:958: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".
 - channels/smartcard/client/smartcard_operations.c:932: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".

But I am not sure about it...

(cherry picked from commit 53459883529bf659488c4da81c30707ff3662820)

smartcard: Fix usage of uninitialized values

This fixes the following defect reported by covscan tool:
 - channels/smartcard/client/smartcard_pack.c:942: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:894: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:475: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".

(cherry picked from commit e70e25715f89aac823281d7c0674d2387f70f8a6)

wlfreerdp: Fix array overrun

This fixes the following defects reported by covscan tool:
 - client/Wayland/wlf_input.c:251: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:308: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:360: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10).
 - client/Wayland/wlf_input.c:251: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:308: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:360: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds.
 - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "y" when calling "wlf_scale_coordinates".
 - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "x" when calling "wlf_scale_coordinates".

The maximal number of touches can be higher then 10, see:
https://wayland.freedesktop.org/libinput/doc/latest/touchpads.html

Let's increse the MAX_CONTACTS count and add checks to prevent usage of
uninitialized values.

(cherry picked from commit 6ab79961ef09bc0340633319c388b6b7517b1f3d)

gdi: Fix missing unlock

This fixes the following defect reported by covscan tool:
libfreerdp/gdi/gfx.c:144: missing_unlock: Returning without unlocking "update->mux".

(cherry picked from commit 914808f62cd2ac4a6984ee638112e8dc3aad9e52)

[generate_argument_docbook] Fix typo in XML entity.

The character '>' was being rendered as < instead of >.

(cherry picked from commit 98930bf2759905f2290e5d777f57a79e7589f220)

Fix memory leaks in client/encomsp_main.c and client/remdesk_main.c

(cherry picked from commit 28e29f8ad568b195a9d6a1d785eaa81da13f93ff)

Fixed #6245: Added additional tests to assistance parser

(cherry picked from commit 69141aa830b6e73e859f907b9bd2a4cac2777d8f)

report only actual bytes received, not allocated buffer size (interrupt produces data, timeout doesn't)

(cherry picked from commit 2e4f27ac9f7bcecb3c3f453341818e538386207f)

Lock remaining occurances of security_encrypt/security_decrypt variables

(cherry picked from commit f01ae7d2573b677eba6c8a50fe12246a23b15f2e)

Lock security_decrypt to avoid simultaneous counter manipulation

(cherry picked from commit 164c00f68b64781d8c624a8c71fab6691519d294)

only call 'libusb_set_interface_alt_setting' when value is changed

(cherry picked from commit ea8c922355c48b6a18900aa543e716b6ae1cd08e)

winpr/library: Use RTLD_GLOBAL for dlopen

LoadLibraryA implementation uses the RTLD_LOCAL flag for dlopen currently.
This flag doesn't allow the symbols to be used by the subsequently loaded
libraries. This is a problem for the video channel when -DBUILTIN_CHANNELS=OFF
is used as it uses functions from the geometry channel. Let's use RTLD_GLOBAL
instead to prevent "undefined symbol" errors in such cases.

Fixes: https://github.com/FreeRDP/FreeRDP/issues/6236
(cherry picked from commit d8cd671cc68d503757e32eb80f7a4dee44e47754)

Added scancodes for launch keys

(cherry picked from commit c97c1ca359db825ee6d172b5860b793dcf3a1e83)

Added release zip creation to script.

(cherry picked from commit 25f62eedddc8fb249e0936f86f9984ee9724c6a1)