Mike Blumenkrantz [Fri, 5 Feb 2016 19:34:29 +0000 (14:34 -0500)]
evas: check EINA_MEMPOOL env var when creating evas mempool allocators
this should really be a utility function already since all mempools in efl use
the exact same code...
Mike Blumenkrantz [Fri, 5 Feb 2016 19:24:34 +0000 (14:24 -0500)]
eina: add test covering tiler rect add/del/add of same geometry regions
ref
ec2ec3e9d13f64b5a4792717204deb59eb9d4caa
Mike Blumenkrantz [Fri, 5 Feb 2016 19:16:51 +0000 (14:16 -0500)]
eina: invalidate last add/del rects when the opposite operation occurs
applying this optimization to prevent the same rectangle from being added
or removed repeatedly in succession would result in the rejecting of successive
operations of the same type when the other operation occurred in between.
as an example:
add(0, 0, 100, 100)
del(0, 0, 100, 100)
add(0, 0, 100, 100)
should yield (0, 0, 100, 100), not zero rects and a failure to add the
second rect
this fixes a serious issue in enlightenment where stacking three windows
on top of each other with the first and third windows having the same geometry
would result in the top window receiving no input geometry (oops)
@fix
Chris Michael [Fri, 5 Feb 2016 13:41:35 +0000 (08:41 -0500)]
evas-wayland-shm: Fix compiler warning about incompatible pointer type
This patch fixes some compiler warnings about assignment from
incompatible pointer type when getting image data from evas_cache. The
simple fix is to cast the return value to RGBA_Image.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Fri, 5 Feb 2016 13:35:04 +0000 (08:35 -0500)]
edje: Remove unused variables
This patch just removes some unused variables that the compiler was
warning about
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Tom Hacohen [Fri, 5 Feb 2016 11:48:36 +0000 (11:48 +0000)]
Ecore con local: properly clean up fd on error.
This wasn't done correctly in the previous commit. First of all, the
order of cleanup was wrong, the cleanup area should only be called if
failures occurred after the fd allocation, not before. Also, fd should
be reinitialised to -1 once we close the socket.
Awadhesh Singh [Fri, 5 Feb 2016 11:44:39 +0000 (11:44 +0000)]
Ecore con: Close server socket fd on failure.
Summary:
Socket fd must be closed to avoid file discripter leak.
Programs can usually only open a limited number of file descriptors,
so if this happens a lot, it may turn into a problem.
@fix
Reviewers: raster, Hermet, wonsik, spacegrapher, cedric, jpeg, tasn
Reviewed By: tasn
Subscribers: cedric, alok25, yashu21985, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D3660
Jee-Yong Um [Fri, 5 Feb 2016 07:30:31 +0000 (08:30 +0100)]
edje_cc: allow omitting "name" keyword in color_classes.color_class block
Summary:
This allows developer to omit "name" keyword in color_classes.color_class
block in EDC.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3598
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
perepelits.m [Fri, 5 Feb 2016 07:19:40 +0000 (08:19 +0100)]
edje: add new part types to edje_cache
Summary: Add new part types (Mesh_Node, Camera, Light) to edje_cache
Reviewers: cedric, raster, Hermet
Subscribers: jpeg, artem.popov
Differential Revision: https://phab.enlightenment.org/D3533
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 5 Feb 2016 07:09:53 +0000 (08:09 +0100)]
ecore_con: changing Ecore.Con.Server to Efl.Network.Server.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3549
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
se.osadchy [Fri, 5 Feb 2016 07:07:42 +0000 (08:07 +0100)]
eina: add eina_vector3 as static inline.
Summary: Move evas_vec3 to eina_vector3 and add documentation.
Reviewers: stefan_schmidt, jpeg, cedric
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3569
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 5 Feb 2016 07:02:39 +0000 (08:02 +0100)]
edje_cc: fix detecting missing part for insert_before/after
Summary:
Detecting missing part for insert_before/after is broken.
This patch makes the feature work and clarifies error message,
and removes redundant internal function.
Reviewers: cedric, jpeg
Subscribers: raster, jpeg
Maniphest Tasks: T2513
Differential Revision: https://phab.enlightenment.org/D3576
Jee-Yong Um [Fri, 5 Feb 2016 06:55:46 +0000 (07:55 +0100)]
edje: introduce color_tree (color_class inheritance)
Summary:
The "color_tree" block contains a list of one or more "node" blocks.
A "node" block consists of its own color class name and the list of child
color classes. At runtime, parent color class will be referred instead,
if child color class is set to part but its color values are not defined.
Reviewers: raster, Jaehyun_Cho, jpeg, cedric
Reviewed By: cedric
Subscribers: cedric, kimcinoo
Differential Revision: https://phab.enlightenment.org/D3606
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jee-Yong Um [Fri, 5 Feb 2016 06:51:31 +0000 (07:51 +0100)]
edje: add test for omitting "name" keyword in color_classes.color_class block
Summary:
This test checks whether omitting "name" keyword in color_classes.color_class
block in EDC work normally.
Depends on D3598
Test Plan: make check
Reviewers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3615
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Wonsik Jung [Fri, 5 Feb 2016 06:50:22 +0000 (07:50 +0100)]
evas: add native surface with TBM Surface for wayland_shm engine
Summary: @feature add evas object image's native surface with TBM surface for wayland_shm
Test Plan: Making tbm test sample and testing on Tizen Device/Emulator
Reviewers: raster, cedric, spacegrapher, jpeg
Reviewed By: spacegrapher
Subscribers: mer.kim, JoogabYun, scholb.kim, dkdk
Differential Revision: https://phab.enlightenment.org/D3618
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 5 Feb 2016 05:21:56 +0000 (06:21 +0100)]
eo: tests callback add and del return value.
Cedric BAIL [Fri, 5 Feb 2016 05:05:30 +0000 (06:05 +0100)]
ecore_evas: refactorize code and make sub ecore evas exploration recusrive.
Cedric BAIL [Fri, 5 Feb 2016 05:05:01 +0000 (06:05 +0100)]
ecore_evas: improve debugging for Ecore_Evas animator.
Cedric BAIL [Fri, 5 Feb 2016 05:02:29 +0000 (06:02 +0100)]
edje: add back use of Ecore_Animator when the Edje object is created on an non Ecore_Evas canvas.
This is necessary for backward compatibility still I am thinking of displaying a warning for this
use case and request people to update there work and drop that feature in the future (In a year
maybe from now). Elementary doesn't need this as it depends on Ecore_Evas.
Youngbok Shin [Thu, 4 Feb 2016 09:29:03 +0000 (11:29 +0200)]
Evas textblock: Save memory space reducing unused hyphen dictionary loads
Summary:
Commonly, only few hyphenation dictionaries are used at a application.
So, loading all of dictionary files could cause waste of memory.
Evas textblock has to load hyphenation dictionaries only when it is
really needed.
Test Plan: N/A
Reviewers: woohyun, tasn, herdsman
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3626
Chris Michael [Thu, 4 Feb 2016 14:44:45 +0000 (09:44 -0500)]
This should not have been pushed. Revert
Revert "ecore-drm: Add API functions for rotation support"
This reverts commit
b8ceaf0d403ce640ed6a485a59a3bd5a7b06a260.
Chris Michael [Thu, 4 Feb 2016 14:44:17 +0000 (09:44 -0500)]
This should not have been pushed. Unsure what happened here, but
revert this
Revert "ecore-drm: Add opaque type for Plane support"
This reverts commit
94082f54e8ce7d47402ea5d8d57e3871f8fa98a4.
Chris Michael [Wed, 20 Jan 2016 15:48:38 +0000 (10:48 -0500)]
ecore-drm: Add API functions for rotation support
This adds 2 new API functions for getting supported rotations of an
output, and for setting rotation on an output
@feature
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Wed, 20 Jan 2016 15:46:40 +0000 (10:46 -0500)]
ecore-drm: Add opaque type for Plane support
This adds an opaque structure to represent a hardware plane for use in
rotation, setting cursor/overlay/primary plane content, etc
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
ecore-drm: Add API functions for rotation support
This adds 2 new API functions for getting supported rotations from an
output, and for setting rotation on an output.
@feature
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Thu, 4 Feb 2016 14:14:31 +0000 (09:14 -0500)]
ecore-drm: Add internal function to create planes for an output
This patch adds an internal function that we use during output
creation in order to create the planes necessary and get the supported
rotation values for an output
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Thu, 4 Feb 2016 14:00:54 +0000 (09:00 -0500)]
ecore-drm: Add API function to set rotation on an output
This patch adds an API function to allow the Screen Setup dialog in
Enlightenment to support setting rotations on an output when running
under drm
@feature
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Thu, 4 Feb 2016 13:56:32 +0000 (08:56 -0500)]
ecore-drm: Add API function to get supported rotations from an output
This patch adds an API function so that we can get the supported
rotations from an output. This is needed so that the Screen Setup
dialog in Enlightenment can list the rotations supported for the user
to choose from while running using drm
@feature
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Chris Michael [Thu, 4 Feb 2016 13:53:16 +0000 (08:53 -0500)]
ecore-drm: Add opaque structure for Ecore_Drm_Plane
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Youngbok Shin [Thu, 4 Feb 2016 10:07:08 +0000 (10:07 +0000)]
Evas: Use proper language for harfbuzz shaping
Summary:
Evas Text, Textblock, Textgrid keeps own language information.
This language information could be vary from the result of setlocale().
Especially, Evas Textblock supports <lang> tag. The language could be
changed in the middle of text. All of these language has to be used
for harfbuzz shaping.
@fix
Test Plan: N/A
Reviewers: herdsman, raster, woohyun, tasn
Reviewed By: tasn
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3628
Tom Hacohen [Wed, 3 Feb 2016 16:52:25 +0000 (16:52 +0000)]
Eo tests: Add tests for eo_init()/shutdown() cycles.
We needed to fix the issue and remove a workaround in the test suite
before we could add these tests. Now they are here and they test that
init/shutdown cycles work as expected.
Tom Hacohen [Wed, 3 Feb 2016 16:38:29 +0000 (16:38 +0000)]
Eo tests: remove hack to prevent eo_init()/shutdown() cycles.
We can now remove it thanks to the previous commit.
Tom Hacohen [Wed, 3 Feb 2016 16:14:07 +0000 (16:14 +0000)]
Eo: add support for initialising eo after it has been shut down.
Until now it wasn't allowed/possible to init (eo_init) eo after it has
been shut down (eo_shutdown). This commit fixes that, so now that is
fully legal to have as many init/shutdown cycles as you want.
There was a previous workaround for this issue:
e47edc250dc715a6b0f94be4b1cb81d32e9d97fe.
This should allow more flexibility when using the EFL in loadable
modules and in various other scenarios.
The problem is that the class_get() functions cache the previously
created class for efficiency, but the class is freed if eo is shut down,
so the cached pointer is actually invalid.
The solution to the problem was to maintain a generation count
(incremented every time we shut down eo), and compare that to a locally
saved version in class_get(). If they don't match, recreate the class,
as it has already been freed.
@feature
Tom Hacohen [Wed, 3 Feb 2016 15:39:25 +0000 (15:39 +0000)]
Revert "Eo: Prevent shutdown from actually doing anything"
This commit was a workaround to let us shutdown and then init eo without
any issues. It leaks and it's wrong. This will properly be fixed in the
next commit.
This reverts commit
e47edc250dc715a6b0f94be4b1cb81d32e9d97fe.
Haifeng Deng [Tue, 24 Nov 2015 09:30:14 +0000 (17:30 +0800)]
ecore_imf/wayland: Fix IME hide -> show issue in case of focus-out and then focus-in
Change-Id: I1d3d7023dbd10b78f510380ff3c46087228f9180
Jihoon Kim [Thu, 4 Feb 2016 04:57:43 +0000 (13:57 +0900)]
ecore_imf/wayland: do not check input panel enable in show or hide
Input panel enable is already being checked in ecore_imf API.
Jihoon Kim [Thu, 4 Feb 2016 03:00:45 +0000 (12:00 +0900)]
ecore_imf/wayland: support to set prediction allow mode
Jihoon Kim [Thu, 4 Feb 2016 02:58:03 +0000 (11:58 +0900)]
ecore_imf/wayland: notify language changed
Jihoon Kim [Thu, 4 Feb 2016 02:56:13 +0000 (11:56 +0900)]
ecore_imf/wayland: Add support to get input panel language locale
Jihoon Kim [Wed, 3 Feb 2016 23:44:14 +0000 (08:44 +0900)]
ecore_imf/ibus: fix indentation
Jean Guyomarc'h [Wed, 3 Feb 2016 23:23:34 +0000 (15:23 -0800)]
edje: fix edje_file_data_get() when no collections are present
Summary:
edje_file_data_get() failed if the Edje file did not contain
a collection (e.g. contained only data.item.
This allows to load data from the file even when no collections
are present, but only if specified.
@fix
Reviewers: raster, jpeg, stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3632
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jee-Yong Um [Wed, 3 Feb 2016 23:21:14 +0000 (15:21 -0800)]
edje: add "keys" block to classes setter/getter
Summary:
With "keys" block, make color/text/size_class setter/getter
to @property methods.
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3619
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Felipe Magno de Almeida [Wed, 3 Feb 2016 23:06:17 +0000 (21:06 -0200)]
eolian-js: Remove replacing commas by underscores in events.
This was done before when the identifier was used to generate
methods. Now using strings to denote events this is not needed
anymore.
Felipe Magno de Almeida [Sun, 17 Jan 2016 16:09:55 +0000 (14:09 -0200)]
eolian-js: Modified formating to replace verb position in method names
Formatting now checks if the last function is a known verb and changes
its position to the first word of the method if it is. Making the
method use the same coding standard as node.js.
Felipe Magno de Almeida [Sun, 17 Jan 2016 16:07:17 +0000 (14:07 -0200)]
eina-cxx: Fix instantiating eina domain without eina_init
Added eina_init to eina_domain initialization as to force eina_init to
happen before initialization of global eina domains. This fixes
eolian_js domain in src/bin/eolian_js.
Tom Hacohen [Wed, 3 Feb 2016 16:32:50 +0000 (16:32 +0000)]
Eo: fix eo_shutdown()'s return value to be FALSE on shutdown.
The return value of init/shutdown is true if eo is init, false otherwise.
This was broken until now.
@fix.
Jean-Philippe Andre [Wed, 3 Feb 2016 11:13:46 +0000 (20:13 +0900)]
Efl: Fixup ref in eo file that I forgot to commit
Jean-Philippe Andre [Wed, 3 Feb 2016 09:23:45 +0000 (18:23 +0900)]
Efl: Eo-ify remaining Efl.Gfx enums and structs
Youngbok Shin [Wed, 3 Feb 2016 09:34:32 +0000 (09:34 +0000)]
Evas textgrid: Use default language according to locale
Summary:
Use default language according to locale.
It's the same as the recent changes on Evas Text, Textblock.
@feature
Test Plan: N/A
Reviewers: herdsman, raster, tasn
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3642
Tom Hacohen [Wed, 3 Feb 2016 09:15:04 +0000 (09:15 +0000)]
Eo base: Make object del event @hot.
This event also needs to be hot, because it's lifecycle related.
We could leak and etc. if this event is not hot.
@fix.
Jean-Philippe Andre [Wed, 3 Feb 2016 05:53:54 +0000 (14:53 +0900)]
Ecore evas: Fix compilation warning (missing initializer)
Jean-Philippe Andre [Wed, 3 Feb 2016 05:48:45 +0000 (14:48 +0900)]
Evas engines: Add missing initializers in Ecore_Evas_Engine_Func
Chris Michael [Tue, 2 Feb 2016 20:01:58 +0000 (15:01 -0500)]
efl: Update mailmap addresses
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Cedric BAIL [Tue, 2 Feb 2016 00:01:18 +0000 (16:01 -0800)]
edje: remove unecessary forced call to recalc all edje file.
This seems to be a fair improvement as it speeds up by 4% the shutdown
of application (and an overall benchmark used to track where genlist
spend its time).
Cedric BAIL [Mon, 1 Feb 2016 23:46:50 +0000 (15:46 -0800)]
evas: don't emit EVAS_CALLBACK_MOVE event if nobody is listening.
This give a constant improvement of 2% over a total benchmark run while scrolling
genlist. This benchmark included setup and destruction of the scene, so under
estimate the cost of the callback emit.
Cedric BAIL [Fri, 29 Jan 2016 20:42:36 +0000 (21:42 +0100)]
evas: no need to call legacy function internally when we can just dereference some pointers.
Cedric BAIL [Thu, 28 Jan 2016 22:59:07 +0000 (14:59 -0800)]
ecore_evas: add log when registering, unregistering and emitting animator.
Cedric BAIL [Thu, 28 Jan 2016 00:00:42 +0000 (16:00 -0800)]
ecore_evas: switch main animator to use the first windows source for tick.
Cedric BAIL [Wed, 27 Jan 2016 19:42:48 +0000 (11:42 -0800)]
eo: return a value when adding or removing callback to help the caller manage state.
Cedric BAIL [Tue, 26 Jan 2016 00:29:36 +0000 (16:29 -0800)]
edje: switch to use per window animator.
Cedric BAIL [Mon, 25 Jan 2016 23:44:54 +0000 (15:44 -0800)]
ecore_evas: optimize triggering of animator to happen only when someone is listening.
Cedric BAIL [Mon, 25 Jan 2016 23:18:28 +0000 (15:18 -0800)]
ecore_evas: introduce support for per window animator trigger.
This code is currently only using the older fallback code and not any
new event source, so all animator on all window are still triggered
whatever the case are.
Cedric BAIL [Fri, 29 Jan 2016 00:15:20 +0000 (16:15 -0800)]
evas: make evas object an animator provider.
Cedric BAIL [Fri, 29 Jan 2016 00:13:55 +0000 (16:13 -0800)]
evas: make evas a provider of animator.
Cedric BAIL [Fri, 29 Jan 2016 00:12:39 +0000 (16:12 -0800)]
efl: add Efl.Core.Animator interface.
Cedric BAIL [Tue, 2 Feb 2016 18:39:41 +0000 (10:39 -0800)]
eo: fix tests to actually account for callback,add and del signal to be @hot.
This example of code is a perfect demonstration of why we should have make
this events @hot from the beginning. As you can see, we ended up being unable
to detect reliably callback being registered and unregistered. Leading to an
negative accounting of callback being unregistered, making this signal unusable
in any scenario.
Cedric BAIL [Tue, 2 Feb 2016 18:28:28 +0000 (10:28 -0800)]
eo: mark both callback,add and callback,del as @hot.
This events needs to be hot to remain unfreezable or it is impossible
for anyone to track all callback setting/unsetting safely.
Cedric BAIL [Fri, 22 Jan 2016 23:07:51 +0000 (15:07 -0800)]
evas: move canvas event to be declared inside proper eolian file.
Cedric BAIL [Thu, 14 Jan 2016 22:52:37 +0000 (14:52 -0800)]
ecore: remove useless ecore_lock/unlock.
Daniel Kolesa [Tue, 2 Feb 2016 17:55:01 +0000 (17:55 +0000)]
eolian: add parsing and generation of hot events
Unfreezable events can now be marked @hot.
@feature
Carsten Haitzler (Rasterman) [Tue, 2 Feb 2016 14:12:25 +0000 (23:12 +0900)]
Revert "Revert "Revert "revise edje_object_size_min_restricted_calc() logic."""
This reverts commit
ade138a3d13f7cd1606d0c80cf40fa71cd1d983a.
Revert this commit because this basically causes e to hang solid if
you mousover ibar (and the window list popup slides in then i think
that tyriggers it). this is pretty bad.
Hermet Park [Tue, 2 Feb 2016 12:14:43 +0000 (21:14 +0900)]
evas/canvas: fix an incorrect sizing of smart object bounding box.
height of the children b-box should be arranged by parent y-pos.
Signed-Off-By: KeuckDo Bang <keuckdo.bang@samsung.com>
Signed-Off-By: MinKyu Kim <imetjade.kim@samsung.com>
@fix
Hermet Park [Tue, 2 Feb 2016 10:25:28 +0000 (19:25 +0900)]
Revert "Revert "increase recalculation_cycle.""
This reverts commit
9efdf309ce421affc0fdf87960df1d4c426217bd.
Hermet Park [Tue, 2 Feb 2016 10:24:50 +0000 (19:24 +0900)]
Revert "Revert "revise edje_object_size_min_restricted_calc() logic.""
This reverts commit
b62d656dbe2a4b4a6b0170526db33ad839cd4aa4.
push it again since 1.17 was released.
Youngbok Shin [Wed, 27 Jan 2016 13:14:52 +0000 (13:14 +0000)]
Evas textblock: Use a common thickness and position at a underline.
Summary:
If a underline is drawn with seperated thickness and position, it doesn't look good.
It will take the thickest and the lowest underline.
@feature
Test Plan:
Set the following markup text in Evas Textblock.
<underline=on underline_color=#fff><font_size=20>Markup text <font_size=50>with</font_size> underline tag</font_size></underline>
It shows the underline is split to 3 underlines with different thickness and positions.
Commonly, underline has to be drawn with same thickness ans position per each line.
Reviewers: woohyun, herdsman, tasn
Reviewed By: tasn
Subscribers: jpeg, raster, subodh6129, cedric
Differential Revision: https://phab.enlightenment.org/D2971
Youngbok Shin [Tue, 26 Jan 2016 10:48:42 +0000 (10:48 +0000)]
Evas Text/Textblock: Use locale for lang as default.
Summary:
The configuration files for Fontconfig can describe
how font list is made according to language information.
EFL also set the language for each Evas textblock styles
and used for loading font list.
But, this is inconvenient to use if we want to apply language
for loading font list according to system-wide locale information.
This patch will apply locale information for font list if there is
no specific language in description.
And it also add [lang=auto] for Evas Textblock.
auto - It loads locale for language.
none - It disables language.
@feature
Test Plan: N/A
Reviewers: woohyun, herdsman, tasn
Subscribers: jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D3344
Youngbok Shin [Tue, 12 Jan 2016 13:20:19 +0000 (13:20 +0000)]
edje: Reduce duplicated item obj creations and deletions.
Summary:
When text is changed, all of objects for item tag are deleted
and recreated. It is unnecessary work and can cause performance
issues. Actually, many of application developers wonder why
item provider callback functions are called every text changes.
@fix
Test Plan:
Run elementary_test -to "entry emoticon"
When you make a very little change on text,
36 emoticon objects are recreated.
Reviewers: woohyun, jaehwan, herdsman, tasn
Reviewed By: tasn
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3537
Stefan Schmidt [Tue, 2 Feb 2016 10:18:35 +0000 (11:18 +0100)]
configure: Switch to dev mode again. Merge window for 1.18 is now open.
Stefan Schmidt [Tue, 2 Feb 2016 09:25:12 +0000 (10:25 +0100)]
release: Update NEWS and bump version for 1.17.0 release
Hermet Park [Tue, 2 Feb 2016 09:11:35 +0000 (18:11 +0900)]
Revert "revise edje_object_size_min_restricted_calc() logic."
This reverts commit
32c12f60c99cbc363c1f65fcb9c7915398be087e.
rollback until release 1.17
Hermet Park [Tue, 2 Feb 2016 09:11:19 +0000 (18:11 +0900)]
Revert "increase recalculation_cycle."
This reverts commit
524fd2f6fc9afdd44fd371d99179d44a28bfd28a.
rollback until release 1.17
Hermet Park [Tue, 2 Feb 2016 09:09:01 +0000 (18:09 +0900)]
Revert "evas/canvas: simple optimization."
This reverts commit
ca124ce5cea162f130eeb80b6c95ee3fadd64761.
rollback until release 1.17
Hermet Park [Tue, 2 Feb 2016 08:59:27 +0000 (17:59 +0900)]
evas/canvas: simple optimization.
We don't need to reorder the clist here as far as I reviewed.
Because, the clist nodes will be calculated all in one.
If I'm wrong please ping me.
Hermet Park [Tue, 2 Feb 2016 08:54:29 +0000 (17:54 +0900)]
increase recalculation_cycle.
256 is too short.
entry can be much larger than this calculation cycle.
Hermet Park [Tue, 2 Feb 2016 08:40:11 +0000 (17:40 +0900)]
revise edje_object_size_min_restricted_calc() logic.
This change is to fix the 4000x4000 limitation issue in edje.
Previously, the sizing calc logic was experimentally confirmed with 4000x4000.
It worked somehow but was not perfect. This change may not be perfect either but
it gets rid of the limitation problem without any performance drop in
computating. Maybe it would be better than before.
I'd rather push the temporary version before we confirmed no side effects.
@fix T2978
José Roberto de Souza [Wed, 27 Jan 2016 20:32:49 +0000 (18:32 -0200)]
eldbus: Correctly read/write boolean to eina_value
DBus bool type is a uint32_t not a uint8_t, just changing how read
and write, not chaging how it is stored in eina_value to save some
bytes of RAM.
This fix the stack overflow pointed out here: https://phab.enlightenment.org/T3089
@fix
Vincent Torri [Mon, 1 Feb 2016 11:17:01 +0000 (12:17 +0100)]
Eina_Value: do not mix declarations and code
Reviewers: cedric, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3624
Jean-Philippe Andre [Mon, 1 Feb 2016 11:23:48 +0000 (20:23 +0900)]
evas: Fix typo in previous clip issue fix
See
100a7006b855fe4da2c2a5c1c4ec58e06b3a0bc0.
This typo actually caused some really rare crashes to happen
(even rarer than the one I fixed originally). Crashes nonetheless.
Chris Michael [Fri, 29 Jan 2016 18:46:30 +0000 (13:46 -0500)]
eeze: Fix eeze_udev_find_by_subsystem_sysname function
This function was severly broken when used for finding devices of a
particular subsystem. Previously, this function would return every
device in the system, regardless if subsystem or sysname was passed in.
This patch fixes the issue by adding udev_enumerate matches before we
scan for devices. This way, when we enumerate the scan results, we now
get only devices that match the subsystem (if supplied).
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Jean Guyomarc'h [Thu, 28 Jan 2016 21:29:32 +0000 (22:29 +0100)]
eina: fix invalid prototype
The prototype means "unspecified arguments". However, the implementation
specifies no parameters (void).
GCC's warning -Wstrict-prototypes complains a lots about this old-style
prototype, spamming the console when compiling more than one compiling
units including Eina.
@fix
Cedric BAIL [Fri, 29 Jan 2016 06:21:58 +0000 (07:21 +0100)]
ecore_evas: trigger pre render function as expected.
This should fix exactness and elementary documentation screenshot bug discovered
by commit
6149fd7a0a9ef3f9495270cf1c4ab7727a30f21c in elementary.
Jean-Philippe Andre [Thu, 28 Jan 2016 03:18:34 +0000 (12:18 +0900)]
Evas clip: Fix rare crash in _render_pre_clipper_change
Use delete callback instead of direct call to clip_unset,
which lets us know that clip_unset() is called during the
clipper's deletion, as opposed to a simple call.
We can then make sure that the previous object state does
not point to invalid data anymore.
Here is a scenario that could have crashed:
- load and show an edje object, hide it
- change its theme or style
- show it again
@fix
Chris Michael [Wed, 27 Jan 2016 17:05:59 +0000 (12:05 -0500)]
evas: Fix explicit NULL dereference
This patch fixes an Coverity issue that if 'dst' gets set to NULL (as can
happen above) then this eo_do call may segfault as it is directly
accessing 'dst->buffer'.
@fix
CID1347415
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Jihoon Kim [Wed, 27 Jan 2016 09:31:26 +0000 (18:31 +0900)]
ecore_imf/scim: fix uninitiazed value issue detected by valgrind
Chris Michael [Mon, 25 Jan 2016 21:10:25 +0000 (16:10 -0500)]
evas: Fix segfault when trying to determine overlay usage
Previously, _evas_render_can_use_overlay would segfault here when
trying to make use of an Evas_Video_Surface. This is because eo_tmp
variable was never reassigned to be the smart parent before we tried
to get eo data from it.
@fix
NB: Thanks Frenchie !! ;)
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Stefan Schmidt [Mon, 25 Jan 2016 16:37:38 +0000 (17:37 +0100)]
release: Update NEWS and bump version for 1.17.0-beta3 release
Mike Blumenkrantz [Mon, 25 Jan 2016 16:24:54 +0000 (11:24 -0500)]
efreet: add locking for efreet_desktop_x_field_get()
in a threaded environment, reading from a hash is not atomic and is
subject to race conditions
@fix
ref
39417cf0ea4e457fbc8d50d120bb8ac776aa366f
Mike Blumenkrantz [Mon, 25 Jan 2016 16:20:55 +0000 (11:20 -0500)]
efreet: reject invalid "" data for Efreet_Desktop->x hash
ref T3096
@fix
Chris Michael [Mon, 25 Jan 2016 12:47:03 +0000 (07:47 -0500)]
edje: Fix potential NULL pointer dereference
It is possible that evas_object_data_get here does not return an Edje,
so check the return value. This fixes a coverity reported issue.
@fix
CID1349866
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Jean-Philippe Andre [Mon, 25 Jan 2016 06:58:16 +0000 (15:58 +0900)]
ecore_evas_extn: Add safety checks, fixing a crash in elm_test
See T2835 (my crash was different from the one reported).
The buffer may be initialized after the first render_pre, due to
whatever timing issue. Check in elm_test "Window Socket" and then
open several "Window Plug".
@fix
Dave Andreoli [Sun, 24 Jan 2016 21:58:24 +0000 (22:58 +0100)]
Ethumb: make the emotion plugin correctly use the edje frame if requested.
The emotion plugin was lacking the ability to use the edje frame as expected,
this patch add this ability, so now video thumbnail works like the normal ones.
This commit is a bit of a new feature, but I consider this a @fix as now
the ethumb_frame_set() API works as expected, also the implementation
is so simple that I think it can go in without any problems.