platform/upstream/mesa.git
13 months agorusticl: advertize cl_khr_spirv_no_integer_wrap_decoration
Karol Herbst [Sat, 17 Jun 2023 21:15:04 +0000 (23:15 +0200)]
rusticl: advertize cl_khr_spirv_no_integer_wrap_decoration

It's supported with all drivers already.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23708>

13 months agodocs/cl: fix whitespace issues and add missing entries
Karol Herbst [Sat, 17 Jun 2023 21:13:52 +0000 (23:13 +0200)]
docs/cl: fix whitespace issues and add missing entries

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23708>

13 months agorusticl: advertize cl_khr_extended_versioning
Karol Herbst [Sat, 17 Jun 2023 19:44:30 +0000 (21:44 +0200)]
rusticl: advertize cl_khr_extended_versioning

We already implemented the OpenCL 3.0 core bits, but the extension also
has a `CL_DEVICE_OPENCL_C_NUMERIC_VERSION_KHR` query.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>

13 months agorusticl/version: use cl_version instead of cl_uint and provide a From impl
Karol Herbst [Sat, 17 Jun 2023 19:43:40 +0000 (21:43 +0200)]
rusticl/version: use cl_version instead of cl_uint and provide a From impl

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>

13 months agorusticl/device: sort cl_device_info queries
Karol Herbst [Sat, 17 Jun 2023 19:28:55 +0000 (21:28 +0200)]
rusticl/device: sort cl_device_info queries

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>

13 months agorusticl/device: add intel usm queries DPCPP cares about
Karol Herbst [Fri, 16 Jun 2023 21:26:12 +0000 (23:26 +0200)]
rusticl/device: add intel usm queries DPCPP cares about

We don't implement them and we don't advertise the extension, but DPCPP
queries them regardless. We ultimately plan to implement the intel USM
extension. However until we do, just return 0 for those queries.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23705>

13 months agogallium/hud: append results to files instead of overwriting them
Marek Olšák [Sun, 11 Jun 2023 05:10:09 +0000 (01:10 -0400)]
gallium/hud: append results to files instead of overwriting them

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23706>

13 months agoanv: do not explode on 32 bit builds
Iván Briano [Thu, 15 Jun 2023 23:22:53 +0000 (16:22 -0700)]
anv: do not explode on 32 bit builds

Fixes: 930e862af7a ("anv: add shaders for copying query results")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9213

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23686>

13 months agoci: implement farms handling trough files inside .ci-farms
David Heidelberg [Thu, 15 Jun 2023 08:49:40 +0000 (10:49 +0200)]
ci: implement farms handling trough files inside .ci-farms

 - Disable farm with `git mv .ci-farm{,-disabled}/$farm_name`.
 - Re-enable farm with `git mv .ci-farm{-disabled,}/$farm_name`.

NEVER MIX FARM MAINTENANCE WITH ANY OTHER CHANGE IN THE SAME MERGE REQUEST!

Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>

13 months agoci/crocus: depend on state of the Anholt farm
David Heidelberg [Wed, 14 Jun 2023 10:46:53 +0000 (12:46 +0200)]
ci/crocus: depend on state of the Anholt farm

Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>

13 months agoci/amd: hide vaapi job dependent on Collabora farm when it's down
David Heidelberg [Wed, 14 Jun 2023 10:42:10 +0000 (12:42 +0200)]
ci/amd: hide vaapi job dependent on Collabora farm when it's down

Fixes: ae9c67d773a7 ("ci/amd: add radeonsi-raven-va-full job to cover all VA-API tests")

Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>

13 months agoci/etnaviv: if farm is down, we expect no manual jobs can be triggered
David Heidelberg [Tue, 13 Jun 2023 21:28:01 +0000 (23:28 +0200)]
ci/etnaviv: if farm is down, we expect no manual jobs can be triggered

Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>

13 months agoci/windows: move microsoft farm rules
David Heidelberg [Tue, 13 Jun 2023 21:06:59 +0000 (23:06 +0200)]
ci/windows: move microsoft farm rules

No functional changes intended, align with other farms.

Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>

13 months agosvga: lower images before ntt
Charmaine Lee [Fri, 16 Jun 2023 01:45:16 +0000 (04:45 +0300)]
svga: lower images before ntt

ntt requires lowered images, so call gl_nir_lower_images first before
passing the shader to ntt.

Fixes piglit failures spec@glsl-4.30@execution@built-in-functions@cs*

Fixes: 0ac95418048 ("gallium: Drop PIPE_SHADER_CAP_PREFERRED_IR")

Reviewed-by: Neha Bhende <bhenden@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23697>

13 months agotgsi: remove unused functions and structs
Thomas H.P. Andersen [Tue, 13 Jun 2023 19:08:09 +0000 (21:08 +0200)]
tgsi: remove unused functions and structs

These are no longer used and can be removed

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23637>

13 months agoci: enforce formatting for RADV & ACO
Eric Engestrom [Fri, 26 May 2023 11:56:20 +0000 (12:56 +0100)]
ci: enforce formatting for RADV & ACO

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>

13 months agoaco: reformat according to its .clang-format
Eric Engestrom [Fri, 26 May 2023 11:55:35 +0000 (12:55 +0100)]
aco: reformat according to its .clang-format

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>

13 months agoradv: reformat according to its .clang-format
Eric Engestrom [Fri, 26 May 2023 11:56:20 +0000 (12:56 +0100)]
radv: reformat according to its .clang-format

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>

13 months agoradv,aco: tweaks to get clang-format to print nicer code
Eric Engestrom [Fri, 26 May 2023 18:14:31 +0000 (19:14 +0100)]
radv,aco: tweaks to get clang-format to print nicer code

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>

13 months agoclang-format: add explanation for anyone reading .clang-format-include
Eric Engestrom [Fri, 2 Jun 2023 18:24:17 +0000 (19:24 +0100)]
clang-format: add explanation for anyone reading .clang-format-include

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>

13 months agoegl: return correct error for EGL_KHR_image_pixmap
Eric Engestrom [Fri, 15 Mar 2019 11:58:16 +0000 (11:58 +0000)]
egl: return correct error for EGL_KHR_image_pixmap

EGL_KHR_image_pixmap says:
> If <target> is EGL_NATIVE_PIXMAP_KHR, and <ctx> is not EGL_NO_CONTEXT,
> the error EGL_BAD_PARAMETER is generated.

Reported-by: Rohan Garg <rohan@garg.io>
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/166
Fixes: a1c4a8a3c855d52fbfef "egl: Add support for EGL_KHR_image."
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/454>

13 months agoiris: Support MTL modifier MC_CCS
Jianxun Zhang [Thu, 27 Oct 2022 20:20:06 +0000 (13:20 -0700)]
iris: Support MTL modifier MC_CCS

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agointel/isl: Add MTL MC CCS modifier into modifier info
Jianxun Zhang [Thu, 27 Oct 2022 20:19:16 +0000 (13:19 -0700)]
intel/isl: Add MTL MC CCS modifier into modifier info

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agoiris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC modifier
Jianxun Zhang [Tue, 18 Oct 2022 19:53:08 +0000 (12:53 -0700)]
iris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC modifier

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agointel/isl: Add MTL RC CCS CC modifier into modifier info
Jianxun Zhang [Wed, 7 Dec 2022 20:22:25 +0000 (12:22 -0800)]
intel/isl: Add MTL RC CCS CC modifier into modifier info

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agoiris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS modifier
Jianxun Zhang [Mon, 10 Oct 2022 18:08:40 +0000 (11:08 -0700)]
iris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS modifier

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agointel/isl: Add MTL RC CCS modifier into modifier info
Jianxun Zhang [Mon, 10 Oct 2022 16:53:53 +0000 (09:53 -0700)]
intel/isl: Add MTL RC CCS modifier into modifier info

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agoinclude/uapi: Update drm_fourcc.h from drm kernel
Jianxun Zhang [Mon, 12 Jun 2023 17:01:27 +0000 (10:01 -0700)]
include/uapi: Update drm_fourcc.h from drm kernel

From:
ba57b9b11f78530146f02b776854b2b6b6d344a4
Merge: 959294e47953 24335848e543
Author: Dave Airlie <airlied@redhat.com>
Date:   Fri Jun 9 16:43:35 2023 +1000

    Merge tag 'drm-intel-gt-next-2023-06-08' of
    git://anongit.freedesktop.org/drm/drm-intel into drm-next

    UAPI Changes:

    - I915_GEM_CREATE_EXT_SET_PAT for Mesa on Meteorlake.

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agoiris: Fix memory alignment when importing dmabuf (GFX12.5)
Jianxun Zhang [Mon, 12 Jun 2023 20:30:02 +0000 (20:30 +0000)]
iris: Fix memory alignment when importing dmabuf (GFX12.5)

Fix the failure in modifier tests on MTL:

../src/intel/common/intel_aux_map.c:609: intel_aux_map_add_mapping:
Assertion `(address & get_page_mask(main_page_size)) == 0' failed.

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>

13 months agodri: Replace usage of boolean/TRUE/FALSE with bool/true/false
Yonggang Luo [Mon, 12 Jun 2023 05:58:00 +0000 (13:58 +0800)]
dri: Replace usage of boolean/TRUE/FALSE with bool/true/false

First do the find/replace in src/gallium/frontends/dri/ folder,
then fixes the compiling errors manually:
Because of this, the prototype of functions in include/GL/internal/dri_interface.h
are changed

Acked-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23582>

13 months agoradv/rt: Enable RT pipelines on GFX10_3+ excluding vangogh
Konstantin Seurer [Thu, 15 Jun 2023 15:17:35 +0000 (17:17 +0200)]
radv/rt: Enable RT pipelines on GFX10_3+ excluding vangogh

Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23677>

13 months agoRevert "radv: Enable ray tracing pipelines by default"
Konstantin Seurer [Thu, 15 Jun 2023 15:15:25 +0000 (17:15 +0200)]
Revert "radv: Enable ray tracing pipelines by default"

This partially reverts commit 374bd4e1bef25ba2aeef6016ac35b41df07f3a99.

Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23677>

13 months agoradv: Add the BOs of all shaders in a RT pipeline
Friedrich Vock [Thu, 15 Jun 2023 16:48:18 +0000 (18:48 +0200)]
radv: Add the BOs of all shaders in a RT pipeline

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23681>

13 months agoaco/opcodes: delete wrong comment copy pasted from NIR
Georg Lehmann [Sat, 22 Apr 2023 11:40:58 +0000 (13:40 +0200)]
aco/opcodes: delete wrong comment copy pasted from NIR

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>

13 months agoaco: remove v_cvt_pkrtz_f16_f32_e64 when it's actually VOP2
Georg Lehmann [Mon, 13 Mar 2023 19:05:26 +0000 (20:05 +0100)]
aco: remove v_cvt_pkrtz_f16_f32_e64 when it's actually VOP2

More consistent with how we handle all the opcodes which were moved to VOP3.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>

13 months agoaco/opcodes: move v_cndmask_b32 back to the VOP2 list
Georg Lehmann [Mon, 13 Mar 2023 18:23:25 +0000 (19:23 +0100)]
aco/opcodes: move v_cndmask_b32 back to the VOP2 list

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>

13 months agoaco/spill: Use arena allocator for spills
Tony Wasserka [Wed, 21 Jul 2021 15:19:13 +0000 (17:19 +0200)]
aco/spill: Use arena allocator for spills

Gives a marginal speedup.

Co-authored-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12000>

13 months agoaco/spill: Use arena allocator for next use distances
Tony Wasserka [Tue, 20 Jul 2021 15:05:43 +0000 (17:05 +0200)]
aco/spill: Use arena allocator for next use distances

Speedup of aco::spill(): ~50%

Co-authored-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12000>

13 months agonouveau: eliminate busy waiting on fences
Karol Herbst [Sat, 5 Nov 2022 10:49:11 +0000 (11:49 +0100)]
nouveau: eliminate busy waiting on fences

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19543>

13 months agoanv: convert most pc in genX_cmd_buffer to use pc helper
Tapani Pälli [Thu, 15 Jun 2023 09:53:14 +0000 (12:53 +0300)]
anv: convert most pc in genX_cmd_buffer to use pc helper

Some are left, batch_set_preemption does not have devinfo pointer
and IndirectStatePointersDisable does not have corresponding ANV bit.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: change most pipe controls in gfx8_cmd_buffer to use pc helper
Tapani Pälli [Thu, 8 Jun 2023 06:48:40 +0000 (09:48 +0300)]
anv: change most pipe controls in gfx8_cmd_buffer to use pc helper

One using a flag (PSDSyncEnable) that has no corresponding ANV bit.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: change pipe control in indirect draw gen to use pc helper
Tapani Pälli [Thu, 15 Jun 2023 09:30:43 +0000 (12:30 +0300)]
anv: change pipe control in indirect draw gen to use pc helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: change pipe controls in genX_gpu_memcpy to use pc helper
Tapani Pälli [Thu, 8 Jun 2023 06:36:57 +0000 (09:36 +0300)]
anv: change pipe controls in genX_gpu_memcpy to use pc helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: change pipe control in genX_pipeline to use pc helper
Tapani Pälli [Thu, 8 Jun 2023 06:35:22 +0000 (09:35 +0300)]
anv: change pipe control in genX_pipeline to use pc helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: change pipe controls in genX_state to use pc helper
Tapani Pälli [Thu, 8 Jun 2023 06:32:07 +0000 (09:32 +0300)]
anv: change pipe controls in genX_state to use pc helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: convert genX_query pipe controls to use pc helper
Tapani Pälli [Wed, 7 Jun 2023 10:45:53 +0000 (13:45 +0300)]
anv: convert genX_query pipe controls to use pc helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: implement invalidate part of emit_apply_pipe_flushes with helper
Tapani Pälli [Thu, 15 Jun 2023 09:20:45 +0000 (12:20 +0300)]
anv: implement invalidate part of emit_apply_pipe_flushes with helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: implement flush part of emit_apply_pipe_flushes with helper
Tapani Pälli [Thu, 15 Jun 2023 09:19:16 +0000 (12:19 +0300)]
anv: implement flush part of emit_apply_pipe_flushes with helper

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agoanv: wrap pipe control emission to a set of helper functions
Tapani Pälli [Wed, 7 Jun 2023 07:52:53 +0000 (10:52 +0300)]
anv: wrap pipe control emission to a set of helper functions

This makes it possible to have HW specific rules and WA's implemented
in a central place. Also all pipe controls will get anv_debug_dump_pc.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23583>

13 months agovirgl: Fix stack overflow in virgl_bind_sampler_states
Tim Pambor [Thu, 15 Jun 2023 15:06:28 +0000 (15:06 +0000)]
virgl: Fix stack overflow in virgl_bind_sampler_states

Triggered on hosts with more than 32 samplers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9207
Fixes: 63c4c559 ("virgl: obtain supported number of shader sampler views from host")
Signed-off-by: Tim Pambor <tp@osasysteme.de>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23678>

13 months agoradv: add dgc_emit_index_buffer()
Samuel Pitoiset [Thu, 15 Jun 2023 05:56:41 +0000 (07:56 +0200)]
radv: add dgc_emit_index_buffer()

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_INDEX_BUFFER_NV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: add dgc_emit_draw_indexed() helper
Samuel Pitoiset [Thu, 15 Jun 2023 05:50:59 +0000 (07:50 +0200)]
radv: add dgc_emit_draw_indexed() helper

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_DRAW_INDEXED_NV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: add dgc_emit_draw() helper
Samuel Pitoiset [Thu, 15 Jun 2023 05:43:05 +0000 (07:43 +0200)]
radv: add dgc_emit_draw() helper

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_DRAW_NV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: add dgc_emit_vertex_buffer() helper
Samuel Pitoiset [Mon, 12 Jun 2023 07:35:56 +0000 (09:35 +0200)]
radv: add dgc_emit_vertex_buffer() helper

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_VERTEX_BUFFER_NV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: add dgc_emit_push_constant() helper
Samuel Pitoiset [Mon, 12 Jun 2023 07:35:25 +0000 (09:35 +0200)]
radv: add dgc_emit_push_constant() helper

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_PUSH_CONSTANT_NV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: add dgc_emit_state() helper
Samuel Pitoiset [Mon, 12 Jun 2023 07:34:52 +0000 (09:34 +0200)]
radv: add dgc_emit_state() helper

For emitting VK_INDIRECT_COMMANDS_TOKEN_TYPE_STATE_FLAGS_NV.
The scissor workaround for GFX9 is only needed if the state is emitted,
so move it there as well.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoradv: remove unused radv_dgc_token struct
Samuel Pitoiset [Thu, 8 Jun 2023 07:39:26 +0000 (09:39 +0200)]
radv: remove unused radv_dgc_token struct

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23584>

13 months agoac/radeonsi: add av1 defaults header file from radeonsi
Dave Airlie [Tue, 7 Feb 2023 22:04:10 +0000 (08:04 +1000)]
ac/radeonsi: add av1 defaults header file from radeonsi

This just moves this header file so radv can use it.

Acked-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23640>

13 months agolavapipe: correctly update shader object per-stage push constant sizes
Mike Blumenkrantz [Wed, 14 Jun 2023 14:12:20 +0000 (10:12 -0400)]
lavapipe: correctly update shader object per-stage push constant sizes

Fixes: 8b3022c9180 ("lavapipe: implement EXT_shader_object")

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23663>

13 months agolavapipe: fix shader binary binding with mesh shaders
Mike Blumenkrantz [Wed, 14 Jun 2023 13:42:22 +0000 (09:42 -0400)]
lavapipe: fix shader binary binding with mesh shaders

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23663>

13 months agolavapipe: more fixes for sample shading
Mike Blumenkrantz [Wed, 14 Jun 2023 12:28:07 +0000 (08:28 -0400)]
lavapipe: more fixes for sample shading

this fixes the case where a draw without sample shading precedes
a draw with sample shading without changes to the sample mask

Fixes: cc9e9580531 ("lavapipe: fix DS3 min sample setting")

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23663>

13 months agoaux/trace: add methods for mesh shaders
Mike Blumenkrantz [Wed, 14 Jun 2023 12:13:55 +0000 (08:13 -0400)]
aux/trace: add methods for mesh shaders

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23663>

13 months agoclc: static assert that clc_optional_features has no padding
Karol Herbst [Thu, 15 Jun 2023 22:29:24 +0000 (00:29 +0200)]
clc: static assert that clc_optional_features has no padding

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23685>

13 months agomeson: Remove reference to removed SWR driver
Matt Turner [Thu, 15 Jun 2023 15:25:48 +0000 (11:25 -0400)]
meson: Remove reference to removed SWR driver

Fixes: e2de00876a7 ("gallium/swr: Remove common code and build options")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23679>

13 months agobin/pick-ui: use asyncio.new_event_loop
Dylan Baker [Thu, 20 Apr 2023 23:02:16 +0000 (16:02 -0700)]
bin/pick-ui: use asyncio.new_event_loop

Instead of .get_event_loop, which is deprecated when there isn't a
running loop (like in our case).

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23472>

13 months agobin/pick: Add support for adding notes on patches
Dylan Baker [Thu, 20 Apr 2023 18:27:21 +0000 (11:27 -0700)]
bin/pick: Add support for adding notes on patches

This is pretty useful for keeping track of why a patch isn't landed, or
who I'm waiting on feedback from.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23472>

13 months agobin/pick: use lineboxes to make the UI clearer
Dylan Baker [Thu, 13 Apr 2023 17:32:05 +0000 (10:32 -0700)]
bin/pick: use lineboxes to make the UI clearer

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23472>

13 months agobin/pick: fix issue where None for nomination_type could fail
Dylan Baker [Thu, 20 Apr 2023 18:22:42 +0000 (11:22 -0700)]
bin/pick: fix issue where None for nomination_type could fail

We have an assumption it's never None, so use a special value in the
Enum instead.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23472>

13 months agorusticl/spirv: Key optional clc features when caching.
Karol Herbst [Wed, 10 May 2023 17:49:22 +0000 (19:49 +0200)]
rusticl/spirv: Key optional clc features when caching.

Sadly I can't use serde yet, so I have to do this nonsense.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23532>

13 months agoclc: add commment to clc_optional_features to ensure no padding exists
Karol Herbst [Thu, 15 Jun 2023 13:41:31 +0000 (15:41 +0200)]
clc: add commment to clc_optional_features to ensure no padding exists

Hopefully this is good enough.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23532>

13 months agodocs: upgrade bootstrap to 5.3.0
Erik Faye-Lund [Sun, 4 Jun 2023 14:44:59 +0000 (16:44 +0200)]
docs: upgrade bootstrap to 5.3.0

The release version of Bootstrap 5.3.0 is out, let's upgrade from the
alpha-version we were using.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23423>

13 months agonv50/ir: resolve -Woverloaded-virtual=1 warnings
Karol Herbst [Thu, 15 Jun 2023 15:33:24 +0000 (17:33 +0200)]
nv50/ir: resolve -Woverloaded-virtual=1 warnings

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23656>

13 months agonv50/ir: use override
Karol Herbst [Thu, 15 Jun 2023 15:33:11 +0000 (17:33 +0200)]
nv50/ir: use override

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23656>

13 months agozink: more anv ci flakes
Mike Blumenkrantz [Thu, 15 Jun 2023 17:56:28 +0000 (13:56 -0400)]
zink: more anv ci flakes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23683>

13 months agoanv: avoid requiring ordered memory planes for explicit import
Yiwei Zhang [Wed, 14 Jun 2023 09:53:31 +0000 (02:53 -0700)]
anv: avoid requiring ordered memory planes for explicit import

The spec does not have such requirement, but anv requires it for
validating the offset. However, for DRM_FORMAT_YVU420, chroma channels
can be swapped upon import to match B/R channel order of
VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM.

This fixes some sw codec path in Instagram when interop with gpu.

v2: fix image memory requirement for re-ordered explicit import

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Emma Anholt <emma@anholt.net> (v1)
Reviewed-by: Matt Tuner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23643>

13 months agoasahi: Use bitfield_extract for texture lowering
Alyssa Rosenzweig [Sun, 21 May 2023 03:02:35 +0000 (23:02 -0400)]
asahi: Use bitfield_extract for texture lowering

This makes descriptor crawls a lot easier to read, which is good because more
are coming.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23351>

13 months agoagx: Implement bitfieldExtract natively
Alyssa Rosenzweig [Sun, 21 May 2023 02:15:06 +0000 (22:15 -0400)]
agx: Implement bitfieldExtract natively

We have a bfeil instruction which mostly maps to the GLSL thing, so use it with
the appropriate lowering.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23351>

13 months agonir/builder: Add ubitfield_extract_imm helper
Alyssa Rosenzweig [Sun, 21 May 2023 03:01:45 +0000 (23:01 -0400)]
nir/builder: Add ubitfield_extract_imm helper

We have a ubfe_imm helper that creates ubfe ops. Not all drivers support ubfe,
however, as it requires SM5 semantics. A few drivers support oly
ubitfield_extract. They should still get the convenience of an _imm helper, so
add a symmetric helper.

It might be nice to unify these helpers into a single helper that asserts its
inputs do not overflow (such that the two ops become equivalent) and emits
either ubfe or ubitfield_extract depending on the underlying driver. That is
left for future work as it's unclear exactly what naming/semantics we want.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23351>

13 months agopvr: add missing frag to geom dependency for jobs targetting same render target
SoroushIMG [Tue, 23 May 2023 07:43:22 +0000 (08:43 +0100)]
pvr: add missing frag to geom dependency for jobs targetting same render target

Seen as a firmware assert when using a debug build of the firmware
and tested against:

dEQP-VK.pipeline.monolithic.render_to_image.core.1d_array.huge.width_layers.r8g8b8a8_unorm_d16_unorm

Signed-off-by: SoroushIMG <soroush.kashani@imgtec.com>
Acked-by: James Glanville <james.glanville@imgtec.com>
Reported-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23651>

13 months agomicrosoft/clc: Add unreachable() to fix 'may be unitialized' warning
Caio Oliveira [Thu, 15 Jun 2023 06:17:36 +0000 (23:17 -0700)]
microsoft/clc: Add unreachable() to fix 'may be unitialized' warning

  In function ‘lower_load_kernel_input’,
      inlined from ‘clc_nir_lower_kernel_input_loads’ at ../src/microsoft/clc/clc_nir.c:205:28:
  ../src/microsoft/clc/clc_nir.c:169:7: warning: ‘base_type’ may be used uninitialized [-Wmaybe-uninitialized]
    169 |       glsl_vector_type(base_type, nir_dest_num_components(intr->dest));
        |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../src/microsoft/clc/clc_nir.c: In function ‘clc_nir_lower_kernel_input_loads’:
  ../src/microsoft/clc/clc_nir.c:151:24: note: ‘base_type’ was declared here
    151 |    enum glsl_base_type base_type;
        |                        ^~~~~~~~~

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23666>

13 months agor300: remove unused opcodes from r300_tgsi_to_rc
Pavel Ondračka [Wed, 14 Jun 2023 08:25:42 +0000 (10:25 +0200)]
r300: remove unused opcodes from r300_tgsi_to_rc

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused LIT lowering
Pavel Ondračka [Wed, 14 Jun 2023 08:01:13 +0000 (10:01 +0200)]
r300: remove unused LIT lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused ROUND lowering
Pavel Ondračka [Wed, 14 Jun 2023 07:58:30 +0000 (09:58 +0200)]
r300: remove unused ROUND lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused DST lowering
Pavel Ondračka [Wed, 14 Jun 2023 07:53:10 +0000 (09:53 +0200)]
r300: remove unused DST lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused POW lowering
Pavel Ondračka [Wed, 14 Jun 2023 06:45:59 +0000 (08:45 +0200)]
r300: remove unused POW lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused FLR lowering
Pavel Ondračka [Wed, 14 Jun 2023 06:42:30 +0000 (08:42 +0200)]
r300: remove unused FLR lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: move CEIL lowering to NIR
Pavel Ondračka [Wed, 14 Jun 2023 06:39:33 +0000 (08:39 +0200)]
r300: move CEIL lowering to NIR

Also remove unused backend CEIL lowering.

Single regressed gnome-shell shader due to fceil followed by f2i32
where before nir_lower_int_to_float would recognize that we already
have integer and emit mov instead of trunc for the f2i32. We can
clean this up easily once we move ntt to the backend.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused SSG lowering
Pavel Ondračka [Wed, 14 Jun 2023 06:36:08 +0000 (08:36 +0200)]
r300: remove unused SSG lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agor300: remove unused SIN/COS lowering
Pavel Ondračka [Wed, 14 Jun 2023 06:36:28 +0000 (08:36 +0200)]
r300: remove unused SIN/COS lowering

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23642>

13 months agoradv/rt: Stop forcing wave32 by setting compute_subgroup_size
Konstantin Seurer [Mon, 12 Jun 2023 15:24:49 +0000 (17:24 +0200)]
radv/rt: Stop forcing wave32 by setting compute_subgroup_size

We end up reporting the wrong subgroup size this way.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23572>

13 months agoiris: Drop GPGPU Tex Invalidate restriction for TGL+
Nanley Chery [Tue, 20 Sep 2022 23:39:01 +0000 (16:39 -0700)]
iris: Drop GPGPU Tex Invalidate restriction for TGL+

According to the HW docs, TGL+ no longer requires that a CS stall be
added to a texture cache invalidate done in the compute pipeline.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18725>

13 months agoiris: Drop the RT flush for PIPE_BARRIER_TEXTURE
Nanley Chery [Thu, 15 Sep 2022 22:41:59 +0000 (15:41 -0700)]
iris: Drop the RT flush for PIPE_BARRIER_TEXTURE

The render target flush would have been needed if it was possible to:

1) pollute the render cache and write to the data port in one draw
   call.

2) perform a subsequent operation that assumed the render cache was
   up-to-date.

However, this is not possible for the two glMemoryBarrier barrier bits
that get translated to this pipe barrier:

* GL_TEXTURE_FETCH_BARRIER_BIT is only used for sampling operations.
  It's possible to pollute the render cache and data cache with writes
  to a texture in one draw call (1). However, the GL spec states that
  apps cannot assume that any existing render caches are up-to-date for
  sampling the written locations immediately afterwards. Apps are
  required to use glTextureBarrier before the sampling operation, so
  requirement #2 is not satisfied.

* GL_PIXEL_BUFFER_BARRIER_BIT could be used for a PBO upload (2), but
  it's not possible to pollute the render cache and data cache with a
  PBO access in one draw call. PBOs cannot be bound to framebuffers
  for rendering, so requirement #1 is not satisfied.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> (v1)
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18725>

13 months agoRevert "iris: Add missed tile flush flag"
Nanley Chery [Thu, 15 Sep 2022 22:22:37 +0000 (15:22 -0700)]
Revert "iris: Add missed tile flush flag"

This reverts commit 0523607ebb108d8c90bbda9c6564b66a0a6250e6.

The issue that commit worked around seems to have been fixed as of
commit 1c8b4940ebf ("iris: Emit flushes for push constant source
buffers"). I could no longer reproduce it from that point onward with
this revert applied.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18725>

13 months agointel/blorp: Avoid 32bpc fast clear sampling issue
Nanley Chery [Mon, 12 Jun 2023 11:59:06 +0000 (07:59 -0400)]
intel/blorp: Avoid 32bpc fast clear sampling issue

For 32bpc formats, the ICL+ sampler fetches the raw clear color dwords
used for rendering instead of the converted pixel dwords typically used
for sampling. The CLEAR_COLOR struct page documents this for 128bpp
formats, but not for 32bpp and 64bpp formats.

In blorp_copy, map R11G11B10_FLOAT to R8G8B8A8_UINT instead of R32_UINT.
This will cause the sampler to fetch the clear color pixel, allowing
drivers to keep clear color support enabled during copies.

If iris is forced to convert blits to copies, this patch fixes the
following test on gfx12:

  dEQP-GLES3.functional.fbo.color.repeated_clear.blit.rbo.r11f_g11f_b10f

At the moment, both iris and anv won't hit this issue outside of
blorp_copy. This is due to the read/write access restrictions they
currently place on texture views that reinterpret the surface format.

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8964
Reviewed-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23604>

13 months agonir: add missed nir_cmp_imm-helpers
Erik Faye-Lund [Tue, 6 Jun 2023 11:56:18 +0000 (13:56 +0200)]
nir: add missed nir_cmp_imm-helpers

Seems I missed these in my previous round, let's fix them up now!

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>

13 months agonir: add and use nir_imod_imm
Erik Faye-Lund [Mon, 5 Jun 2023 13:31:47 +0000 (15:31 +0200)]
nir: add and use nir_imod_imm

Just a short-hand, really. Makes the code a bit easier to read.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>

13 months agonir: add and use nir_fdiv_imm
Erik Faye-Lund [Mon, 5 Jun 2023 13:15:21 +0000 (15:15 +0200)]
nir: add and use nir_fdiv_imm

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>

13 months agonir: use nir_imm_{true,false}
Erik Faye-Lund [Mon, 5 Jun 2023 12:54:54 +0000 (14:54 +0200)]
nir: use nir_imm_{true,false}

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>

13 months agonir: isub -> iadd_imm
Erik Faye-Lund [Mon, 5 Jun 2023 10:41:14 +0000 (12:41 +0200)]
nir: isub -> iadd_imm

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>

13 months agonir: use more imm-helpers
Erik Faye-Lund [Mon, 5 Jun 2023 10:36:39 +0000 (12:36 +0200)]
nir: use more imm-helpers

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23461>