platform/upstream/coreclr.git
5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190706.5 (#25583)
dotnet-maestro[bot] [Sun, 7 Jul 2019 15:06:52 +0000 (08:06 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190706.5 (#25583)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19356.5
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19356.5

5 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190706.07 ...
dotnet-maestro[bot] [Sun, 7 Jul 2019 15:06:43 +0000 (08:06 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build 20190706.07 (#25584)

- Microsoft.NETCore.App - 3.0.0-preview8-27906-07

5 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190705.12 ...
dotnet-maestro[bot] [Sat, 6 Jul 2019 16:48:06 +0000 (09:48 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build 20190705.12 (#25578)

- Microsoft.NETCore.App - 3.0.0-preview8-27905-12

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190705.7 (#25577)
dotnet-maestro[bot] [Sat, 6 Jul 2019 15:35:06 +0000 (08:35 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190705.7 (#25577)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19355.7
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19355.7

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190705.2 (#25576)
dotnet-maestro[bot] [Sat, 6 Jul 2019 15:24:45 +0000 (08:24 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190705.2 (#25576)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19355.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19355.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19355.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19355.2

5 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Sat, 6 Jul 2019 15:24:35 +0000 (08:24 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190706.1 (#25579)

- optimization.IBC.CoreCLR - 99.99.99-master-20190706.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190706.1

5 years agofix merge error (#25573)
Maoni Stephens [Sat, 6 Jul 2019 07:09:32 +0000 (00:09 -0700)]
fix merge error (#25573)

5 years ago[master] Update dependencies from dotnet/corefx (#25564)
dotnet-maestro[bot] [Fri, 5 Jul 2019 23:12:43 +0000 (16:12 -0700)]
[master] Update dependencies from dotnet/corefx (#25564)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19354.4
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19354.4

* Disable failing test

5 years agoRe-enable Microsoft.VisualBasic tests (#25572)
Sergiy Kuryata [Fri, 5 Jul 2019 20:03:34 +0000 (13:03 -0700)]
Re-enable Microsoft.VisualBasic tests (#25572)

5 years agomany core (#25350)
Maoni Stephens [Fri, 5 Jul 2019 19:48:34 +0000 (12:48 -0700)]
many core (#25350)

5 years ago[master] Update dependencies from dnceng/internal/dotnet-optimization (#25566)
dotnet-maestro[bot] [Fri, 5 Jul 2019 16:17:42 +0000 (09:17 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25566)

- optimization.IBC.CoreCLR - 99.99.99-master-20190705.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190705.1

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190704.2 (#25569)
dotnet-maestro[bot] [Fri, 5 Jul 2019 16:15:37 +0000 (09:15 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190704.2 (#25569)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19354.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19354.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19354.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19354.2

5 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190704.08 ...
dotnet-maestro[bot] [Fri, 5 Jul 2019 16:15:26 +0000 (09:15 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build 20190704.08 (#25570)

- Microsoft.NETCore.App - 3.0.0-preview8-27904-08

5 years agoFix instantiation stub maker for case where no register is used by function parameter...
Fadi Hanna [Fri, 5 Jul 2019 04:48:48 +0000 (21:48 -0700)]
Fix instantiation stub maker for case where no register is used by function parameters (#25558)

* Fix instantiation stub maker for case where no register is used by function parameters

5 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190703.14 ...
dotnet-maestro[bot] [Thu, 4 Jul 2019 22:06:23 +0000 (15:06 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build 20190703.14 (#25565)

- Microsoft.NETCore.App - 3.0.0-preview8-27903-14

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190703.19 (#25563)
dotnet-maestro[bot] [Thu, 4 Jul 2019 14:29:21 +0000 (07:29 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190703.19 (#25563)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19353.19
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19353.19
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19353.19
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19353.19

5 years agoFix dotnet-dump/createdump launch failure (#25562)
Mike McLaughlin [Thu, 4 Jul 2019 14:07:51 +0000 (07:07 -0700)]
Fix dotnet-dump/createdump launch failure (#25562)

On CentOS or OpenSUSE dotnet-dump collect fails but a
valid coredump is generated. The "prctl()" call is failing
that gives the child createdump process permission to ptrace
to the runtime process. On CentOS/OpenSUSE the PR_SET_PTRACER
option isn't supported and not needed.

Issue: https://github.com/dotnet/diagnostics/issues/334

5 years agoRemove legacy resource value (PrivateBuild) in binaries. (#25560)
Aaron Robinson [Thu, 4 Jul 2019 04:38:04 +0000 (21:38 -0700)]
Remove legacy resource value (PrivateBuild) in binaries. (#25560)

* Remove legacy resource value (PrivateBuild) in binaries.

* Never set the private file flag on the binary

5 years agoFix getting rundown events during EventPipe::Shutdown (#25450)
José Rivero [Thu, 4 Jul 2019 03:05:22 +0000 (20:05 -0700)]
Fix getting rundown events during EventPipe::Shutdown (#25450)

5 years agoarm64singlestepper (#25512)
Steve MacLean [Thu, 4 Jul 2019 02:29:07 +0000 (22:29 -0400)]
arm64singlestepper (#25512)

Add single step emulation for arm64 Linux

Add a copy and rework armsinglestepper to arm64singlestepper

Add arm64 emulation of all armv8 user space instructions which read or write PC.
- ADR, ADRP
- Branch instructions: B, BL, B.cond, BR, BLR, RET
- LDR (literal)

* Add FEATURE_EMULATE_SINGLESTEP
* Enable for ARM64 linux

* Debugging fixes

Fix IsSSFlagEnabled bug
Fix opcode type
Fix code buffer asserts
Fix CBZ typo
Fix BitExtract
Fix m_targetPc
Minimize written instructions
Fix comments
Fix Bypass address truncation
Fix false assert
Add additional logging
Use %lx to log addresses
Remove stray LOG
Remove stray assert

5 years agoPrevent EventPipe rundown from blocking on write (#25523)
John Salem [Thu, 4 Jul 2019 00:52:53 +0000 (17:52 -0700)]
Prevent EventPipe rundown from blocking on write (#25523)

* Write all rundown events to the buffer manager to prevent the write from blocking while holding the CodeManager lock

* * Incorporate PR feedback
* changed to one suspend rather than suspend->resume->suspend
* added some comments

* update comments

5 years agoAdd check to prevent attaching a profiler when one is already present (#25520)
David Mason [Thu, 4 Jul 2019 00:15:47 +0000 (17:15 -0700)]
Add check to prevent attaching a profiler when one is already present (#25520)

* Don't load multiple profilers

* add comment

* Move check to LoadProfiler, and eliminate race condition between attach profiler and startup profiled

5 years agoEnable coredumps on unix (#25551)
Jarret Shook [Wed, 3 Jul 2019 23:23:22 +0000 (16:23 -0700)]
Enable coredumps on unix (#25551)

* Enable coredumps on unix

* Remove morph change

5 years agoFix GCStress modes that do code instrumentation to work with code versioning (#25261)
Koundinya Veluri [Wed, 3 Jul 2019 23:22:31 +0000 (16:22 -0700)]
Fix GCStress modes that do code instrumentation to work with code versioning (#25261)

- SOS changes are in https://github.com/dotnet/diagnostics/pull/369
- Fixes https://github.com/dotnet/coreclr/issues/17646

5 years agoAdd test for eventcounter (#25555)
Sung Yoon Whang [Wed, 3 Jul 2019 22:50:46 +0000 (15:50 -0700)]
Add test for eventcounter (#25555)

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190702.11 (#25549)
dotnet-maestro[bot] [Wed, 3 Jul 2019 19:03:02 +0000 (12:03 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190702.11 (#25549)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19352.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19352.11

5 years ago[master] Update dependencies from dnceng/internal/dotnet-optimization (#25538)
dotnet-maestro[bot] [Wed, 3 Jul 2019 19:02:10 +0000 (12:02 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25538)

- optimization.IBC.CoreCLR - 99.99.99-master-20190703.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190703.1

5 years ago[master] Update dependencies from dotnet/core-setup (#25537)
dotnet-maestro[bot] [Wed, 3 Jul 2019 19:01:09 +0000 (12:01 -0700)]
[master] Update dependencies from dotnet/core-setup (#25537)

- Microsoft.NETCore.App - 3.0.0-preview8-27903-01

5 years agoCleanup IL linker heuristic usage (#25547)
Jan Kotas [Wed, 3 Jul 2019 15:59:25 +0000 (08:59 -0700)]
Cleanup IL linker heuristic usage (#25547)

Prep-work for using mainstream IL linker

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190702.7 (#25548)
dotnet-maestro[bot] [Wed, 3 Jul 2019 15:59:01 +0000 (08:59 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190702.7 (#25548)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19352.7
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19352.7
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19352.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19352.7

5 years agoDelete some dead code (#25546)
Jan Kotas [Wed, 3 Jul 2019 07:34:50 +0000 (00:34 -0700)]
Delete some dead code (#25546)

5 years agoAdd a new CompilationDiagnostic ETW Keyword (#25544)
Brian Robbins [Wed, 3 Jul 2019 05:50:26 +0000 (22:50 -0700)]
Add a new CompilationDiagnostic ETW Keyword (#25544)

5 years agoMerge ReadyToRunInfo::GenericMethodIterator in to ReadyToRunInfo::MethodIterator...
David Mason [Wed, 3 Jul 2019 01:30:43 +0000 (18:30 -0700)]
Merge ReadyToRunInfo::GenericMethodIterator in to ReadyToRunInfo::MethodIterator (#25518)

5 years agoEnsure YIELD_WHILE() in EventPipeBufferManager::SuspendWriteEvent() always terminates...
Andrew Au [Tue, 2 Jul 2019 23:35:40 +0000 (16:35 -0700)]
Ensure YIELD_WHILE() in EventPipeBufferManager::SuspendWriteEvent() always terminates (#25491)

5 years agoMerge pull request #25540 from MattGal/update-more-docker-images
Matt Galbraith [Tue, 2 Jul 2019 22:13:35 +0000 (15:13 -0700)]
Merge pull request #25540 from MattGal/update-more-docker-images

Fix all remaining Python 2 Helix Docker images

5 years agoRemove test method exclusions addressed in https://github.com/dotnet/corefx/pull...
Egor Chesakov [Tue, 2 Jul 2019 18:24:57 +0000 (11:24 -0700)]
Remove test method exclusions addressed in https://github.com/dotnet/corefx/pull/38856 (#25389)

5 years agoThis should finish off updating all of CoreCLR's images to versions supporting python...
Matt Galbraith [Tue, 2 Jul 2019 17:12:01 +0000 (10:12 -0700)]
This should finish off updating all of CoreCLR's images to versions supporting python 3 from https://github.com/dotnet/dotnet-buildtools-prereqs-docker (also saves some time by preinstalling virtualenv stuff)

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190702.1 (#25536)
dotnet-maestro[bot] [Tue, 2 Jul 2019 14:48:22 +0000 (07:48 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190702.1 (#25536)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19352.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19352.1

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190701.4 (#25535)
dotnet-maestro[bot] [Tue, 2 Jul 2019 14:48:09 +0000 (07:48 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190701.4 (#25535)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19351.4
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19351.4
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19351.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19351.4

5 years agoUse Array.MaxArrayLength in ArrayList (#25530)
Michal Strehovský [Tue, 2 Jul 2019 13:33:16 +0000 (15:33 +0200)]
Use Array.MaxArrayLength in ArrayList (#25530)

Now that `ArrayList` is in CoreLib, we don't need the copy.

5 years agoReduce allocations in GetLocale() (#25531)
Ilya [Tue, 2 Jul 2019 12:54:03 +0000 (17:54 +0500)]
Reduce allocations in GetLocale() (#25531)

5 years agoAdd RundownRequested switch to EventPipe IPC protocol (#25495)
Sung Yoon Whang [Tue, 2 Jul 2019 07:08:30 +0000 (00:08 -0700)]
Add RundownRequested switch to EventPipe IPC protocol (#25495)

* Add RundownRequested switch to EventPipe IPC protocol

* Fix linux build

* make the rundownRequested field a bool

* some renaming

* Make a new command that has an option for disabling rundown instead of breaking change

* code review feedback

5 years agoDecrease EventListener buffer size (#25526)
Sung Yoon Whang [Tue, 2 Jul 2019 06:19:07 +0000 (23:19 -0700)]
Decrease EventListener buffer size (#25526)

* Reduce the default EventPipe circularBufferSize to 10MB for EventListener sessions

* make it a static var instead of random # in the code

5 years agotest DisplayUnits/DisplayRateTimeScale properties (#25525)
Sung Yoon Whang [Tue, 2 Jul 2019 05:25:31 +0000 (22:25 -0700)]
test DisplayUnits/DisplayRateTimeScale properties (#25525)

5 years agoUse AssemblyLoadContext from shared partition (dotnet/corert#7570)
Michal Strehovský [Mon, 1 Jul 2019 05:15:28 +0000 (07:15 +0200)]
Use AssemblyLoadContext from shared partition (dotnet/corert#7570)

We were missing methods that got added for 3.0. The only LoadContext that works is the default one though.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoDelete dead code (#25513)
Jan Kotas [Tue, 2 Jul 2019 02:46:37 +0000 (19:46 -0700)]
Delete dead code (#25513)

5 years agoGet rid of warnings while building tests (#25514)
Michal Strehovský [Tue, 2 Jul 2019 02:46:24 +0000 (04:46 +0200)]
Get rid of warnings while building tests (#25514)

5 years ago[master] Update dependencies from dotnet/arcade (#25503)
dotnet-maestro[bot] [Mon, 1 Jul 2019 18:17:21 +0000 (11:17 -0700)]
[master] Update dependencies from dotnet/arcade (#25503)

* Update dependencies from https://github.com/dotnet/arcade build 20190629.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19329.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19329.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19329.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19329.2

* Update dependencies from https://github.com/dotnet/arcade build 20190630.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19330.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19330.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19330.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19330.1

5 years ago[master] Update dependencies from dnceng/internal/dotnet-optimization (#25504)
dotnet-maestro[bot] [Mon, 1 Jul 2019 16:05:41 +0000 (09:05 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25504)

- optimization.IBC.CoreCLR - 99.99.99-master-20190701.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190701.1

5 years ago[master] Update dependencies from dotnet/corefx (#25497)
dotnet-maestro[bot] [Mon, 1 Jul 2019 16:04:15 +0000 (09:04 -0700)]
[master] Update dependencies from dotnet/corefx (#25497)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19330.3
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19330.3

5 years agoDisable windows formatting job in PRs (#25507)
Russ Keldorph [Mon, 1 Jul 2019 04:06:55 +0000 (21:06 -0700)]
Disable windows formatting job in PRs (#25507)

Temporarily disable this job to stop redness in PRs until #25499 is addressed.

5 years ago[master] Update dependencies from dotnet/arcade (#25476)
dotnet-maestro[bot] [Sun, 30 Jun 2019 00:20:02 +0000 (17:20 -0700)]
[master] Update dependencies from dotnet/arcade (#25476)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19328.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19328.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19328.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19328.2

5 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Sun, 30 Jun 2019 00:16:55 +0000 (17:16 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190628.3 (#25498)

- optimization.IBC.CoreCLR - 99.99.99-master-20190628.3
- optimization.PGO.CoreCLR - 99.99.99-master-20190628.3

5 years agoRemove an old CoreFX exclusion file (#25500)
Bruce Forstall [Sat, 29 Jun 2019 21:57:58 +0000 (14:57 -0700)]
Remove an old CoreFX exclusion file (#25500)

Plus, add comments to the new exclusion file

5 years agoUpdate documentation for corefx testing in coreclr repo (#25493)
Bruce Forstall [Sat, 29 Jun 2019 16:50:02 +0000 (09:50 -0700)]
Update documentation for corefx testing in coreclr repo (#25493)

* Update documentation for corefx testing in coreclr repo

* Apply suggestions from code review

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
* Update a command line; improve clarity

5 years agoRe-enable corefx tests (#25490)
Bruce Forstall [Sat, 29 Jun 2019 15:57:05 +0000 (08:57 -0700)]
Re-enable corefx tests (#25490)

Re-enable corefx tests

5 years agoFix GCStress issue on x86 and Arm (#25445)
Brian Sullivan [Sat, 29 Jun 2019 08:26:37 +0000 (01:26 -0700)]
Fix GCStress issue on x86 and Arm (#25445)

* Fix GCStress issue on x86 and Arm32
  When we write one of the new gc stress instruction, such as INTERRUPT_INSTR_PROTECT_FIRST_RET
  we might be writing it in the epilog region on x86 or ARM as a direct call can be the last
  instruction before an epilog.  (This isn't allowed on x64)
  This fix expands the set of instructions we are allowed by IsMarkerInstr() toinclude these
  newly added gc stress instructions.
  added comment to GetGcMarkerExceptionCode
  Fix DAC build

* Code review feedback

* Additional code review chnages

5 years agoFix a mutex abandon case with WaitHandle.WaitAll in the PAL (#25452)
Koundinya Veluri [Sat, 29 Jun 2019 07:27:20 +0000 (00:27 -0700)]
Fix a mutex abandon case with WaitHandle.WaitAll in the PAL (#25452)

Fixes https://github.com/dotnet/coreclr/issues/25108
- Upon a `WaitAll` when all waits are already satisfied, the abandoned flag is overwritten with the abandoned state of the last wait object in the array
- So if the first wait object is an abandoned mutex and the second wait object is a signaled event, the `WaitAll` succeeds and does not report that anything was abandoned
- Fixed to accumulate into the flag instead of overwriting it

5 years agoStop using reflection on pollingcounter tests (#25489)
Sung Yoon Whang [Sat, 29 Jun 2019 00:06:19 +0000 (17:06 -0700)]
Stop using reflection on pollingcounter tests (#25489)

5 years agoDon't return TRUE on tracepoint_enabled if LTTng library does not exist on build...
Sung Yoon Whang [Fri, 28 Jun 2019 20:57:19 +0000 (13:57 -0700)]
Don't return TRUE on tracepoint_enabled if LTTng library does not exist on build (#25459)

5 years agoUse regular static variable for EEConfig storage (#25479)
Jan Kotas [Fri, 28 Jun 2019 20:31:19 +0000 (13:31 -0700)]
Use regular static variable for EEConfig storage (#25479)

Fixes #25475

5 years agoFix an assertion failure in the thread pool's QueueUserWorkItemCallbackBase (#25482)
Koundinya Veluri [Fri, 28 Jun 2019 20:08:22 +0000 (13:08 -0700)]
Fix an assertion failure in the thread pool's QueueUserWorkItemCallbackBase (#25482)

Fixes https://github.com/dotnet/coreclr/issues/25242
- The issue could be that there is no memory barrier (or in the wrong place) on the thread reading the value, and an old value could be cached and read

5 years agoAvoid the multiplication generated by mc.exe (#25454)
Andrew Au [Fri, 28 Jun 2019 17:41:31 +0000 (10:41 -0700)]
Avoid the multiplication generated by mc.exe (#25454)

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190627.9 (#25477)
dotnet-maestro[bot] [Fri, 28 Jun 2019 17:02:02 +0000 (10:02 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190627.9 (#25477)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19327.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19327.9

5 years agoAdd windows arm32 native vararg excludes (#25429)
Jarret Shook [Fri, 28 Jun 2019 15:41:05 +0000 (08:41 -0700)]
Add windows arm32 native vararg excludes (#25429)

* Add windows arm32 native vararg excludes

* Fix typo

5 years agoarm32_ci_script.sh: Fix tizen armel build (#25087)
Konstantin Baladurin [Fri, 28 Jun 2019 14:04:00 +0000 (17:04 +0300)]
arm32_ci_script.sh: Fix tizen armel build (#25087)

5 years agoEnable parsing multiple providers for LTTngConfig variable (#25451)
Sung Yoon Whang [Fri, 28 Jun 2019 06:04:58 +0000 (23:04 -0700)]
Enable parsing multiple providers for LTTngConfig variable (#25451)

* Enable parsing multiple providers for LTTngConfig variable

* Handle case where LTTngConfig==NULL

* renaming some methods

* Add comment about the format of environment variable being parsed

5 years agoAdd test for IncrementingEventCounter (#25462)
Sung Yoon Whang [Fri, 28 Jun 2019 05:47:25 +0000 (22:47 -0700)]
Add test for IncrementingEventCounter (#25462)

* Add test for IncrementingEventCounter

* Some cleanup

* Remove unused using

5 years agoMove coreclr-corefx pipelines into their own files (#25465)
Bruce Forstall [Fri, 28 Jun 2019 04:29:47 +0000 (21:29 -0700)]
Move coreclr-corefx pipelines into their own files (#25465)

5 years agoremoved unnecessary WriteLine form a test (#25460)
Vladimir Sadov [Thu, 27 Jun 2019 23:16:07 +0000 (16:16 -0700)]
removed unnecessary WriteLine form a test (#25460)

5 years agoMerge pull request #25424 from dotnet/darc-master-e048b5ab-4671-4e74-8671-932e8299b22b
William Godbe [Thu, 27 Jun 2019 20:23:32 +0000 (13:23 -0700)]
Merge pull request #25424 from dotnet/darc-master-e048b5ab-4671-4e74-8671-932e8299b22b

[master] Update dependencies from dotnet/arcade

5 years agoFix VersionBubbles test (#25392)
Jan Vorlicek [Thu, 27 Jun 2019 19:46:26 +0000 (21:46 +0200)]
Fix VersionBubbles test (#25392)

The test was not crossgening with large version bubble enabled since
the part of the .csproj that generates part of the .sh/.bat test
running scripts was commented out. There were also bugs in the
commented out code. Also, to ensure that it works, tiered compilation
and jit minopts need to be disables to ensure that the test method
won't be re-jitted.

5 years agoDon't reload or spill for keepAliveThis (#25441)
Carol Eidt [Thu, 27 Jun 2019 18:35:14 +0000 (11:35 -0700)]
Don't reload or spill for keepAliveThis (#25441)

Fix #25433

5 years agoReact to new compiler nullability warnings
Santiago Fernandez Madero [Thu, 27 Jun 2019 17:39:13 +0000 (10:39 -0700)]
React to new compiler nullability warnings

5 years ago[master] Update dependencies from dotnet/core-setup (#25426)
dotnet-maestro[bot] [Thu, 27 Jun 2019 17:50:52 +0000 (10:50 -0700)]
[master] Update dependencies from dotnet/core-setup (#25426)

- Microsoft.NETCore.App - 3.0.0-preview7-27826-04

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190626.15 (#25453)
dotnet-maestro[bot] [Thu, 27 Jun 2019 17:49:52 +0000 (10:49 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190626.15 (#25453)

- Microsoft.NETCore.Platforms - 3.0.0-preview8.19326.15
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19326.15

5 years agoFix SIGSEGV in GC when dealing with large double[] on ARM32 (#25403)
Vladimir Sadov [Thu, 27 Jun 2019 17:48:47 +0000 (10:48 -0700)]
Fix SIGSEGV in GC when dealing with large double[] on ARM32 (#25403)

* Fix for #25252
* revert to special casing 8-alignement for double[] in GC helpers for x86

5 years agoUpdate linux-instructions.md
Fadi Hanna [Thu, 27 Jun 2019 16:05:58 +0000 (09:05 -0700)]
Update linux-instructions.md

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190626.44
dotnet-maestro [Thu, 27 Jun 2019 12:23:38 +0000 (12:23 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190626.44

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19326.44
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19326.44
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19326.44
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19326.44

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190626.2
dotnet-maestro [Wed, 26 Jun 2019 12:21:07 +0000 (12:21 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190626.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19326.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19326.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19326.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19326.2

5 years agoHardcode LKG version of ucrtbased.dll (#25444)
William Godbe [Thu, 27 Jun 2019 03:41:42 +0000 (20:41 -0700)]
Hardcode LKG version of ucrtbased.dll (#25444)

* Hardcode LKG version of ucrtbased.dll

* Only use hardcoded UCRT version when search path fails

* Add missing single-quotes

5 years agoFix typo & make the code leaner (#25442)
Jan Kotas [Thu, 27 Jun 2019 01:25:21 +0000 (18:25 -0700)]
Fix typo & make the code leaner (#25442)

Enum.HasFlag generates bigger IL and depends on complex JIT optimization for a good code.
The classic bit check is strongly preferred accross CoreCLR and CoreFX.

5 years agoFix ActivityTracker ES_BUILD_STANDALONE build
Stephen Toub [Tue, 25 Jun 2019 02:10:45 +0000 (22:10 -0400)]
Fix ActivityTracker ES_BUILD_STANDALONE build

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoTweak nullable attribute per API review (#25443)
Stephen Toub [Thu, 27 Jun 2019 01:02:19 +0000 (21:02 -0400)]
Tweak nullable attribute per API review (#25443)

5 years agoUpdate docs (#25446)
Jan Kotas [Wed, 26 Jun 2019 23:47:04 +0000 (16:47 -0700)]
Update docs (#25446)

- Delete references to Jenkins CI
- Add note on Squash&Merge

5 years agoEventPipe events should only be sent to sessions that are listening to the event...
Andrew Au [Wed, 26 Jun 2019 22:21:39 +0000 (15:21 -0700)]
EventPipe events should only be sent to sessions that are listening to the event (#25401)

5 years agoFix EncoderNLS / DecoderNLS regression in reporting error index (#25397)
Levi Broderick [Wed, 26 Jun 2019 22:05:53 +0000 (15:05 -0700)]
Fix EncoderNLS / DecoderNLS regression in reporting error index (#25397)

Also fixes incorrect asserts in the Encoding type

5 years ago[createdump] Write page offset in NT_FILE note (#25384)
Mikhail Aksenov [Wed, 26 Jun 2019 19:16:40 +0000 (22:16 +0300)]
[createdump] Write page offset in NT_FILE note (#25384)

5 years agoUpdate branding to preview8 in master (#25438)
William Godbe [Wed, 26 Jun 2019 19:14:21 +0000 (12:14 -0700)]
Update branding to preview8 in master (#25438)

5 years ago[master] Update dependencies from dotnet/corefx (#25425)
dotnet-maestro[bot] [Wed, 26 Jun 2019 18:53:11 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/corefx (#25425)

* Update dependencies from https://github.com/dotnet/corefx build 20190626.2

- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19326.2
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19326.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19326.2

* Reenable globalization tests

5 years agoTweak some annotations on EventRegistrationTokenTable<T> (#25386)
Santiago Fernandez Madero [Wed, 26 Jun 2019 17:54:35 +0000 (10:54 -0700)]
Tweak some annotations on EventRegistrationTokenTable<T> (#25386)

5 years agoDelegate inspection API in the DBI (#25362)
Juan Hoyos [Wed, 26 Jun 2019 17:11:56 +0000 (10:11 -0700)]
Delegate inspection API in the DBI (#25362)

* Add ICorDebugDelegateObjectValue interfaces
* Expose appropriate HR (CORDBG_E_UNSUPPORTED_DELEGATE)
* Partially DACize DelegateObject
* Add DacDbi method for delegate inspection

5 years agoMerge pull request #25326 from BruceForstall/CrossPlatTestHost
Bruce Forstall [Wed, 26 Jun 2019 16:49:21 +0000 (09:49 -0700)]
Merge pull request #25326 from BruceForstall/CrossPlatTestHost

Expand corefx testing in coreclr repo

Currently, corefx testing is done on Windows/x64.
Expand testing to include:
1. Linux/x64, Linux/arm, Linux/arm64, Windows/x86 platforms.
   Windows/arm should be added after corefx official builds
   publish tests and test manifest. Windows/arm64 should be
   added after corefx tests are published, and we have
   sufficient hardware.
2. All JIT stress modes that are used in normal coreclr testing.

Testing is split into 4 Azure DevOps Pipelines: coreclr-corefx,
coreclr-corefx-jitstress, coreclr-corefx-jitstressregs, and
coreclr-corefx-jitstress2-jitstressregs.

In addition, we now use the corefx meta-package Microsoft.Private.CoreFx.OOB
instead of a list of individual assemblies when constructing
the testhost.

5 years agoFix disabling wrong session on EventPipe::Shutdown (#25409)
José Rivero [Wed, 26 Jun 2019 16:45:47 +0000 (09:45 -0700)]
Fix disabling wrong session on EventPipe::Shutdown (#25409)

- It's safe to call EventPipe::Disable during shutdown (eventpipe being disabled)

5 years agoFixes link to install SOS on linux (#25420)
Rafael Lillo [Wed, 26 Jun 2019 15:31:16 +0000 (16:31 +0100)]
Fixes link to install SOS on linux (#25420)

5 years agoDon't show AggressiveInlining items in exception stacks (#25408)
Ben Adams [Wed, 26 Jun 2019 12:55:14 +0000 (14:55 +0200)]
Don't show AggressiveInlining items in exception stacks (#25408)

5 years agoReverting the ShouldRoundUp logic to not change for custom numeric format strings...
Tanner Gooding [Wed, 26 Jun 2019 05:36:36 +0000 (22:36 -0700)]
Reverting the ShouldRoundUp logic to not change for custom numeric format strings. (#25400)

5 years agoFix incorrect signature of QCall (#25419)
Mukul Sabharwal [Wed, 26 Jun 2019 05:00:28 +0000 (22:00 -0700)]
Fix incorrect signature of QCall (#25419)

5 years agoFix LTTng filtering for runtime providers (#25374)
Sung Yoon Whang [Wed, 26 Jun 2019 04:03:04 +0000 (21:03 -0700)]
Fix LTTng filtering for runtime providers (#25374)

* LTTng filtering

* Fix Windows build, make IsInitialized check faster

* Cleanup/change default to no keywords/level set

* Keep the default to be the current policy - enable everything

* more cleanup

* No need to check for initialization

* Fix Windows build

5 years agoTell the compiler to emit nullable attributes for public API only (#25398)
Santiago Fernandez Madero [Wed, 26 Jun 2019 03:19:28 +0000 (20:19 -0700)]
Tell the compiler to emit nullable attributes for public API only (#25398)