arv@chromium.org [Wed, 11 Apr 2012 23:31:18 +0000 (23:31 +0000)]
File API does not support DOM events (like addEventListener)
https://bugs.webkit.org/show_bug.cgi?id=83688
Reviewed by Adam Barth.
Source/WebCore:
The IDL files where missing addEventListener, removeEventListener and dispatchEvent.
Tests: fast/filesystem/file-writer-events.html
fast/speech/scripted/basics.html
* Modules/filesystem/FileWriter.idl: Add missing methods.
* Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
* Modules/speech/SpeechRecognition.idl: Add missing methods.
LayoutTests:
* fast/filesystem/resources/file-writer-events.js:
(runTest):
* fast/speech/scripted/basics-expected.txt:
* fast/speech/scripted/basics.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 11 Apr 2012 23:28:30 +0000 (23:28 +0000)]
LayerFlushScheduler's run loop observer should have an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=83729
Reviewed by Dan Bernstein.
LayerFlushScheduler's run loop observer needs an autorelease pool.
NSApplication creates one, but it is only drained after processing user
input. In the case where a WebView is displaying composited content but
not receiving user input, NSApplication's pool will accumulate a large
number of objects autoreleased by the run loop observer. Have
LayerFlushScheduler create an autorelease pool that is drained after
each run loop observer callback.
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 23:20:55 +0000 (23:20 +0000)]
Split CSSStyleSheet into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=83612
Reviewed by Andreas Kling.
This will complete the separation of our style sheet data structures from CSSOM.
The internal parts of CSSStyleSheet move to StyleSheetInternal. CSS parser
and style selector will now operate on internal types. Unlike other CSSOM types
CSSStyleSheets are still always instantiated to hold the top level author stylesheets
(by Nodes).
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::styleSheet):
* css/CSSImportRule.h:
(WebCore):
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::addSubresourceStyleURLs):
* css/CSSReflectValue.h:
(CSSReflectValue):
* css/CSSRule.h:
(CSSRule):
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
Add a set for root CSSStyleSheet objects so that the wrappers created in ensureFullCSSOMWrapperForInspector
stay valid.
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::~StyleSheetInternal):
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::ruleCount):
(WebCore::StyleSheetInternal::clearCharsetRule):
(WebCore::StyleSheetInternal::clearRules):
(WebCore::StyleSheetInternal::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::addNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore::StyleSheetInternal::isLoading):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::notifyLoadedSheet):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::findStyleSheetOwnerNode):
(WebCore::StyleSheetInternal::findDocument):
(WebCore::StyleSheetInternal::setMediaQueries):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::StyleSheetInternal::baseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::StyleSheetInternal::addSubresourceStyleURLs):
(WebCore::StyleSheetInternal::parentStyleSheet):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):
* css/CSSStyleSheet.h:
(WebCore):
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::ownerNode):
(WebCore::StyleSheetInternal::clearOwnerNode):
(WebCore::StyleSheetInternal::ownerRule):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::title):
(WebCore::StyleSheetInternal::setTitle):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::finalURL):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::removeRule):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::internal):
(WebCore::CSSStyleSheet::isCSSStyleSheet):
(WebCore::CSSStyleSheet::type):
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore):
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::addSubresourceStyleURLs):
* css/CSSValueList.h:
(CSSValueList):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
* css/CSSValuePool.h:
(WebCore):
(CSSValuePool):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* css/StyleSheet.cpp:
(WebCore):
* css/StyleSheet.h:
(StyleSheet):
(WebCore::StyleSheet::media):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::isXSLStyleSheet):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
* dom/Document.cpp:
(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::documentUserSheets):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* dom/StyledElement.h:
(WebCore):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::parseAttribute):
* xml/XSLStyleSheet.h:
(XSLStyleSheet):
(WebCore::XSLStyleSheet::finalURL):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 23:14:28 +0000 (23:14 +0000)]
Unreviewed, rolling out r113912.
http://trac.webkit.org/changeset/113912
https://bugs.webkit.org/show_bug.cgi?id=83727
broke atsui-spacing-features.html on windows (Requested by
simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11
Source/WebCore:
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
* fast/text/international/arabic-justify.html: Removed.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png: Removed.
* platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 11 Apr 2012 23:08:13 +0000 (23:08 +0000)]
Remove a fprintf from LayoutTestController.
This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
It was added for no apparent reason by Ryosuke in r113651.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::redirectionDestinationForURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 22:52:00 +0000 (22:52 +0000)]
SpeculativeJIT::fillStorage() should work with all the states that a cell may be in
https://bugs.webkit.org/show_bug.cgi?id=83722
Reviewed by Gavin Barraclough.
It's now possible to do StorageOperand on a cell, in the case that the storage is
inline. But this means that fillStorage() must be able to handle all of the states
that a cell might be in. Previously it didn't.
With this change, it now does handle all of the states, and moreover, it does so
by preserving the DataFormat of cells and performing all of the cell speculations
that should be performed if you're using a cell as storage. But if you use this on
something that is known to be storage already then it behaves as it did before.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillStorage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 22:48:44 +0000 (22:48 +0000)]
[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454
The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.
This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.
Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.
HUD is not testable in webkit.
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 22:44:57 +0000 (22:44 +0000)]
Add two flaky plug-in tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 22:38:35 +0000 (22:38 +0000)]
Add tests that broke in r113900 to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 11 Apr 2012 22:12:37 +0000 (22:12 +0000)]
WebGLRenderingContext should defer caching program info
https://bugs.webkit.org/show_bug.cgi?id=83513
Reviewed by Kenneth Russell.
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::numActiveAttribLocations): call cacheInfoIfNeeded();
(WebCore::WebGLProgram::getActiveAttribLocation): Ditto.
(WebCore::WebGLProgram::isUsingVertexAttrib0): Ditto.
(WebCore::WebGLProgram::getLinkStatus): Ditto.
(WebCore):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded): Cache link status, active attire locations, etc if needed.
(WebCore::WebGLProgram::increaseLinkCount): also invalidate cached info.
* html/canvas/WebGLProgram.h:
(WebGLProgram):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::linkProgram): Do not cache program info immediately.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 22:04:01 +0000 (22:04 +0000)]
Add keySystem attribute to canPlayType() for Encrypted Media Extensions
https://bugs.webkit.org/show_bug.cgi?id=82973
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
The new attribute is behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions.
Source/Platform:
* chromium/public/WebMimeRegistry.h:
(WebKit::WebMimeRegistry::supportsMediaMIMEType):
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-can-play-type-webm.html
media/encrypted-media/encrypted-media-can-play-type.html
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore):
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::networkStateChanged):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
(WebCore):
Source/WebKit/chromium:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
* media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
* media/encrypted-media/encrypted-media-can-play-type-webm-expected.txt: Added.
* media/encrypted-media/encrypted-media-can-play-type-webm.html: Added.
* media/encrypted-media/encrypted-media-can-play-type.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 21:43:59 +0000 (21:43 +0000)]
[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.
* Source/tests.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 11 Apr 2012 21:42:57 +0000 (21:42 +0000)]
[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
GDI used to do Kashida justification.
After switch to Skia, we need to use space padding to justify the text
(assume Skia can not do Kashida justification -- stretching words).
Test: fast/text/international/arabic-justify.html
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
* fast/text/international/arabic-justify.html: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 21:33:19 +0000 (21:33 +0000)]
Unreviewed, GTK rebaseline after r113885.
* platform/gtk/css2.1/
20110323/replaced-elements-001-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Wed, 11 Apr 2012 21:27:21 +0000 (21:27 +0000)]
All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
https://bugs.webkit.org/show_bug.cgi?id=83411
Reviewed by Eric Carlson.
Patch by Antonio Gomes <agomes@rim.com>
Fix obvious problems with the test in order to make tests lets
flaky.
* media/nodesFromRect-shadowContent.html:
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 11 Apr 2012 21:07:47 +0000 (21:07 +0000)]
[CAIRO] Make GLContextGLX a subclass of GLContext
https://bugs.webkit.org/show_bug.cgi?id=81285
Reviewed by Gustavo Noronha Silva.
.:
* GNUmakefile.am: Add a configuration option for activating GLX.
This is selected automatically now, but in the future there will be
the choice to turn on EGL and turn off GLX at compilation time.
* configure.ac: Ditto.
Source/WebCore:
No new tests. This should not change behavior.
* GNUmakefile.list.am: Add new GLContextGLX files.
* platform/graphics/cairo/GLContext.cpp: Added. Composed of the
EGL/GLX independent portions of GLContext. Made the current context
a static variable so we can keep getting the current context platform-
-independent.
* platform/graphics/cairo/GLContext.h: Make this class an abstract
class. GLContextGLX is a concrete implementation.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Updated to reflect
slightly different calling conventions to create a sharing context.
* platform/graphics/glx/GLContextGLX.cpp: Updated to reflect
that this code is in a subclass now.
* platform/graphics/glx/GLContextGLX.h: Copied from Source/WebCore/platform/graphics/cairo/GLContext.h.
* platform/graphics/gtk/GLContextGtk.cpp:
(WebCore::GLContext::getContextForWidget): Updated to respect the new
USE(GLX) flag.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 11 Apr 2012 21:03:30 +0000 (21:03 +0000)]
fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
https://bugs.webkit.org/show_bug.cgi?id=83715
Reviewed by Rob Buis.
Converted the fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html to dumpAsText tests.
* fast/dom/dom-parse-serialize-display-expected.txt: Added.
* fast/dom/dom-parse-serialize-display.html:
* fast/dom/dom-parse-serialize-expected.txt: Added.
* fast/dom/dom-parse-serialize.html:
* platform/chromium-linux/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-linux/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/efl/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/efl/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/efl/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/efl/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/mac/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/qt/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/qt/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/qt/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/qt/fast/dom/dom-parse-serialize-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 20:51:21 +0000 (20:51 +0000)]
Global variable predictions should not be coalesced unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=83678
Reviewed by Geoff Garen.
Removed the PredictionTracker and everyone who used it. Converted GetGlobalVar
to have a heapPrediction like a civilized DFG opcode ought to.
No performance effect.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* bytecode/PredictionTracker.h: Removed.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Wed, 11 Apr 2012 20:34:52 +0000 (20:34 +0000)]
Unreviewed gardening and fix naming on EFL expected.txt files
* platform/chromium-linux/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac-leopard/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac-snowleopard/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-win/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-win/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt.
* platform/efl/test_expectations.txt:
* platform/mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/mac/test_expectations.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 11 Apr 2012 20:25:27 +0000 (20:25 +0000)]
[BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=83361
Reviewed by Antonio Gomes.
Upstream a cleaned up version.
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 20:19:45 +0000 (20:19 +0000)]
[chromium] Add OVERRIDE annotations for cc layer types
https://bugs.webkit.org/show_bug.cgi?id=83658
Reviewed by Daniel Bates.
This adds OVERRIDE annotations to overrides of functions on these classes:
- CCLayerImpl
- LayerChromium
- TiledLayerChromium
Source/WebCore:
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/CanvasLayerChromium.h:
(CanvasLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/PluginLayerChromium.h:
(PluginLayerChromium):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
* src/WebLayerImpl.cpp:
* src/WebLayerImpl.h:
(WebLayerImpl): Removed unused and empty paintContents() function.
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
* tests/LayerChromiumTest.cpp:
* tests/TreeSynchronizerTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 11 Apr 2012 20:16:47 +0000 (20:16 +0000)]
[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
https://bugs.webkit.org/show_bug.cgi?id=83709
Reviewed by Anders Carlsson.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 11 Apr 2012 20:13:16 +0000 (20:13 +0000)]
[Mac] lang, xml:lang, content-language ignored when choosing fonts
https://bugs.webkit.org/show_bug.cgi?id=10874
<rdar://problem/3220202>
Reviewed by Dan Bernstein.
Adding a default font table for Mac port. Clients can still override these if they want to,
but knowing which fonts to use is more about the platform than about the client.
Tests: platform/mac/fonts/han-disunification.html
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* Resources/DefaultFonts.plist.in: Added.
Added SettingsMac.mm. Added preprocessed property list with default fonts.
* page/Settings.cpp:
(WebCore::setGenericFontFamilyMap): Don't notify the page if we don't have one yet.
(WebCore::Settings::Settings): Assign to m_page after calling initializeDefaultFontFamilies,
so that we won't try to call page->setNeedsRecalcStyleInAllFrames() in a half-initialized
Page that's creating settings.
(WebCore::Settings::initializeDefaultFontFamilies): Dummy imlplementation for ports that
rely on client to set defaults.
* page/Settings.h: Added initializeDefaultFontFamilies().
* page/mac/SettingsMac.mm: Added.
(WebCore::defaultFontFamilyDictionary):
(WebCore::Settings::initializeDefaultFontFamilies):
Load defaults from a plist file inside WebCore framework.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 11 Apr 2012 20:05:04 +0000 (20:05 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-linux/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-linux/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-mac/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-win/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 20:03:25 +0000 (20:03 +0000)]
Crash in CSSStyleSheet::deleteRule
https://bugs.webkit.org/show_bug.cgi?id=83708
Source/WebCore:
Reviewed by Andreas Kling.
Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0).
Test: fast/css/delete-rule-crash.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::deleteRule):
LayoutTests:
Reviewed by Andreas Kling.
* fast/css/delete-rule-crash.html: Added.
* fast/css/delete-rule-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 20:00:26 +0000 (20:00 +0000)]
[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=83706
Reviewed by Ryosuke Niwa.
Source/WebCore:
The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.
This change is coming soon to the DOM4 spec, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.
* dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::createIfNeeded):
* dom/MutationObserverInterestGroup.h:
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
* dom/MutationObserverRegistration.h:
(WebCore):
(MutationObserverRegistration):
* dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
(Node):
LayoutTests:
Updated attributes test to match new behavior.
* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rafael.lobo@openbossa.org [Wed, 11 Apr 2012 19:52:22 +0000 (19:52 +0000)]
Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=83711
Unreviewed update to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 19:51:15 +0000 (19:51 +0000)]
Add two more DOM storage tests to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 19:45:42 +0000 (19:45 +0000)]
[EFL] LayoutTestController needs implementation of pageProperty
https://bugs.webkit.org/show_bug.cgi?id=82449
Source/WebKit/efl:
Add missing implementation pageProperty to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::pageProperty):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation pageProperty to EFL's LayoutTestController
in order to unskip printing/page-rule-selection.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pageProperty):
LayoutTests:
Unskip printing/page-rule-selection.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 19:40:10 +0000 (19:40 +0000)]
Move fast/js/navigator-language.html to platform/qt
https://bugs.webkit.org/show_bug.cgi?id=83710
Reviewed by Ryosuke Niwa.
This test was for a Qt specific bug, and using setlocale on Mac will not update the preferred language correctly.
* platform/qt/fast/js/navigator-language-expected.txt: Renamed from LayoutTests/fast/js/navigator-language-expected.txt.
* platform/qt/fast/js/navigator-language.html: Renamed from LayoutTests/fast/js/navigator-language.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:39:19 +0000 (19:39 +0000)]
[Chromium/Linux] fonts-glyph-04-t.svg fails after r87152
https://bugs.webkit.org/show_bug.cgi?id=61370
Unreviewed Chromium linux expectations update.
This test is now behaving like Mac. No complaints there, just a font change.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:33:07 +0000 (19:33 +0000)]
[chromium] svg/wicd/test-rightsizing-a.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=66320
Unreviewed Chromium test expectations cleanup.
This test had been fixed some time ago and has no appearance in the flakiness board.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 19:26:28 +0000 (19:26 +0000)]
add stereo source support in EqualPowerPanner
https://bugs.webkit.org/show_bug.cgi?id=81092
Patch by Wei James <james.wei@intel.com> on 2012-04-11
Reviewed by Chris Rogers.
Source/WebCore:
Test: webaudio/panner-equalpower-stereo.html
* platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
LayoutTests:
* webaudio/panner-equalpower-stereo-expected.txt: Added.
* webaudio/panner-equalpower-stereo.html: Copied from LayoutTests/webaudio/panner-equalpower.html.
* webaudio/panner-equalpower.html:
* webaudio/resources/audio-testing.js:
(createStereoImpulseBuffer):
* webaudio/resources/panner-model-testing.js:
(createGraph):
(createTestAndRun):
(equalPowerGain):
(checkResult):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:23:01 +0000 (19:23 +0000)]
[chromium] Need new image baseline for svg/dom/SVGTransformList-basics.xhtml
https://bugs.webkit.org/show_bug.cgi?id=63036
Unreviewed Chromium test expectations update.
* platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 11 Apr 2012 19:21:59 +0000 (19:21 +0000)]
StyleElement ownerNode is not cleared correctly
https://bugs.webkit.org/show_bug.cgi?id=83696
Reviewed by Antti Koivisto.
Source/WebCore:
When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.
Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
fast/dom/StyleSheet/detached-sheet-owner-node.html
* dom/StyleElement.cpp:
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):
* dom/StyleElement.h:
(StyleElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):
* html/HTMLLinkElement.h:
(HTMLLinkElement):
LayoutTests:
* fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Wed, 11 Apr 2012 19:09:31 +0000 (19:09 +0000)]
Optimize String.split() for 1 character separator
https://bugs.webkit.org/show_bug.cgi?id=83546
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.
This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.
The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline
function.
The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.
This makes String.split() faster by about 13% in that particular case.
* runtime/StringPrototype.cpp:
(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 11 Apr 2012 18:35:37 +0000 (18:35 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/
11177351>
REGRESSION: Table on wikipedia overlaps float on right hand side.
Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.
Reviewed by Dan Bernstein.
Added new test in fast/block/float.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83614
Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.
Reviewed by Dan Bernstein.
* fast/block/float/avoiding-float-centered.html: Added.
* platform/mac/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Wed, 11 Apr 2012 18:30:52 +0000 (18:30 +0000)]
Unreviewed gardening. Found EFL results.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 11 Apr 2012 18:20:23 +0000 (18:20 +0000)]
Fix regression where a clip style change did not update layer sizes
https://bugs.webkit.org/show_bug.cgi?id=82990
Reviewed by Simon Fraser.
Source/WebCore:
After r111456, the size of composited layers also used clip, whereas
it previously had only used overflow. Because of this, when clip
changes on a render layer, it needs to recalculate its layer tree.
Test: compositing/clip-change.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
LayoutTests:
* compositing/clip-change-expected.png: Added.
* compositing/clip-change-expected.txt: Added.
* compositing/clip-change.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Wed, 11 Apr 2012 18:03:37 +0000 (18:03 +0000)]
Expectations update after 81936 and 82734
https://bugs.webkit.org/show_bug.cgi?id=81936
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-11
Reviewed by Adam Barth.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/mac/test_expectations.txt:
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 18:02:10 +0000 (18:02 +0000)]
V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
https://bugs.webkit.org/show_bug.cgi?id=83699
Reviewed by Adam Barth.
Call them FooV8Internal instead.
* bindings/scripts/CodeGeneratorV8.pm:
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 17:58:33 +0000 (17:58 +0000)]
[chromium] Add OVERRIDE annotations for cc animation-related interfaces
https://bugs.webkit.org/show_bug.cgi?id=83650
Reviewed by Daniel Bates.
This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCAnimationCurve
- CCFloatAnimationCurve
- CCLayerAnimationControllerClient
- CCTransformAnimationCurve
Source/WebCore:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCTimingFunction.h:
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):
* platform/graphics/chromium/cc/CCLayerImpl.h:
Source/WebKit/chromium:
* tests/CCAnimationTestCommon.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Wed, 11 Apr 2012 17:50:55 +0000 (17:50 +0000)]
Fix bug where stroke's bounding box was clipped
https://bugs.webkit.org/show_bug.cgi?id=83651
Reviewed by Dirk Schulze.
Source/WebCore:
This change contains two fixes for one bug:
1) FloatRect::contains contained a nasty mistake where
maxy() < y() was compared instead of maxy() < point.y().
2) RenderSVGShape::strokeContains was depending on its internal
m_strokeAndMarkerBoundingBox instead of calling the virtual
method strokeBoundingBox(). This change switches to using
strokeBoundingBox().
Test: svg/hittest/svg-ellipse-rect-stroke.xhtml
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::contains):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):
LayoutTests:
* svg/hittest/svg-ellipse-rect-stroke-expected.txt: Added.
* svg/hittest/svg-ellipse-rect-stroke.xhtml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 11 Apr 2012 17:45:57 +0000 (17:45 +0000)]
Enable the [Supplemental] IDL on BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=75413
Reviewed by Rob Buis.
This patch enables the [Supplemental] IDL on BlackBerry by changing the build
flow of BlackBerry as follows.
- Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
- New build flow (See the discussions in bug 72138 for more details):
preprocess-idls.pl depends on all IDL files;
preprocess-idls.pl reads all IDL files;
preprocess-idls.pl resolves the dependency of [Supplemental=XXXX];
preprocess-idls.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,
including all attributes in the IDL files that are implementing $idl;
}
Tests: Confirm that build succeeds.
http/tests/websocket/tests/*
* PlatformBlackBerry.cmake: This change is similar to the change we have done for
UseJSC.cmake and UseV8.cmake (bug 75345).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 17:44:34 +0000 (17:44 +0000)]
Unreviewed, rolling out r113836.
http://trac.webkit.org/changeset/113836
https://bugs.webkit.org/show_bug.cgi?id=83705
Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11
Source/WebKit/win:
* WebCoreSupport/WebInspectorClient.cpp:
(registerWindowClass):
* WebInspector.cpp:
(WebInspector::setTimelineProfilingEnabled):
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):
Tools:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 17:36:54 +0000 (17:36 +0000)]
Unreviewed, rolling out r113872.
http://trac.webkit.org/changeset/113872
https://bugs.webkit.org/show_bug.cgi?id=83703
broke chromium win/mac builds (Requested by simonjam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(CCHeadsUpDisplay):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 17:32:54 +0000 (17:32 +0000)]
Remove webkit prefix from Media Source runtime feature name.
https://bugs.webkit.org/show_bug.cgi?id=83633
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
Source/WebCore:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
* html/HTMLMediaElement.idl:
Source/WebKit/chromium:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 11 Apr 2012 17:05:31 +0000 (17:05 +0000)]
Wider suppression.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 11 Apr 2012 16:59:35 +0000 (16:59 +0000)]
Single ShareableBitmap revision blacks out WebView on Harmattan
https://bugs.webkit.org/show_bug.cgi?id=83631
When swizzling is not supported in the driver, we need to initialize the texture as RGBA,
and make sure that the manual swizzling only modifies the sub-image.
Rubber stamped by Kenneth Rohde Christiansen.
Covered by existing tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::didReset):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 16:57:16 +0000 (16:57 +0000)]
[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454
The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.
This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.
Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.
HUD is not testable in webkit.
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 11 Apr 2012 16:21:10 +0000 (16:21 +0000)]
[chromium] Draw missing layer tile checkerboards as checkerboards
https://bugs.webkit.org/show_bug.cgi?id=83241
Reviewed by James Robinson.
Source/WebCore:
For non-Android platforms, draw missing tile checkerboards as actual
checkerboards. Use a shader to do this so that no texture uploads are
needed. This only happens on the non-composited content host to avoid
having unexpected (or transformed and aliased) checkerboards on other
content layers.
* WebCore.gypi:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setDrawCheckerboardForMissingTiles):
(WebCore::LayerChromium::drawCheckerboardForMissingTiles):
(LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore):
(WebCore::LayerRendererChromium::checkerboardProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderCheckerboard::FragmentShaderCheckerboard):
(WebCore):
(WebCore::FragmentShaderCheckerboard::init):
(WebCore::FragmentShaderCheckerboard::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(FragmentShaderCheckerboard):
(WebCore::FragmentShaderCheckerboard::alphaLocation):
(WebCore::FragmentShaderCheckerboard::texTransformLocation):
(WebCore::FragmentShaderCheckerboard::frequencyLocation):
(WebCore):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.
(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.
(WebCore):
(CCCheckerboardDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toCheckerboardDrawQuad):
(WebCore):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::setDrawCheckerboardForMissingTiles):
(WebCore::CCLayerImpl::drawCheckerboardForMissingTiles):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
Rename usedCheckerboard to hadMissingTile to avoid confusion. Update
tests to not expect SolidColor quads for checkerboards.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 11 Apr 2012 16:14:45 +0000 (16:14 +0000)]
[GTK] Initial cookies API for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82441
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitCookieManager.cpp: Added.
(webkit_cookie_manager_init):
(webkitCookieManagerFinalize):
(webkit_cookie_manager_class_init):
(webkitCookieManagerCreate): Create a new WebKitCookieManager for
the given WKCookieManagerRef.
(webkit_cookie_manager_set_accept_policy): Set the cookie
acceptance policy.
(webkitCookieManagerGetAcceptPolicyCallback): Callback called by
the C API when the cookie acceptance policy has been received.
(webkit_cookie_manager_get_accept_policy): Asynchronously get the
cookie acceptance policy.
(webkit_cookie_manager_get_accept_policy_finish): Finish async
operation started by webkit_cookie_manager_get_accept_policy()
returning the cookie acceptance policy.
(webkitCookieManagerGetDomainsWithCookiesCallback): Callback
called by the C API when the list of hostnames with cookies has
been received.
(webkit_cookie_manager_get_domains_with_cookies): Asynchronously
get the list of domains with cookies.
(webkit_cookie_manager_get_domains_with_cookies_finish): Finish
async operation started by
webkit_cookie_manager_get_domains_with_cookies() returning the
list of domains.
(webkit_cookie_manager_delete_cookies_for_domain): Delete all
cookies for the given domain.
(webkit_cookie_manager_delete_all_cookies): Delete all cookies.
* UIProcess/API/gtk/WebKitCookieManager.h: Added.
* UIProcess/API/gtk/WebKitCookieManagerPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_cookie_manager): Get the
WebKitCookieManager associated with the web context.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for
WebKitCookieManager.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_cookie_manager_get_type.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestCookieManager.cpp: Added.
(testCookieManagerAcceptPolicy):
(testCookieManagerDeleteCookies):
(serverCallback):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/webkit2.h: Include WebKitCookieManager.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 11 Apr 2012 16:09:28 +0000 (16:09 +0000)]
[Qt] Unreviewed gardening after r113738.
* platform/qt/Skipped: Unskip a non-existing test.
* platform/qt/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/qt/fast/multicol/cell-shrinkback-expected.txt: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.png:
* platform/qt/fast/multicol/table-vertical-align-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 16:05:49 +0000 (16:05 +0000)]
[BlackBerry] Update to the thread-safe GuardedPointer API
https://bugs.webkit.org/show_bug.cgi?id=83603
Patch by Joe Mason <jmason@rim.com> on 2012-04-11
Reviewed by Rob Buis.
Source/WebCore:
RIM PR: 134894
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker. Use GuardedPointerDeleter
to delete LayerCompositingThread to avoid a deadlock.
No new tests, refactor.
Reviewed internally by Yong Li and George Staikos.
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::~CookieDatabaseBackingStore):
* platform/blackberry/CookieManager.h:
* platform/graphics/blackberry/LayerCompositingThread.cpp:
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WTF::::deref):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
Source/WebKit/blackberry:
RIM PR: 134984
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker.
No new tests, refactor.
Reviewed internally by Yong Li and George Staikos.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::~BackingStore):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPage::destroy):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Wed, 11 Apr 2012 16:03:40 +0000 (16:03 +0000)]
[EFL][DRT] SVG dynamic-updates rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83689
Unreviewed, EFL gardening.
Bug 83562 landed EFL fixes for SVG support from JavaScript.
This allows us to unskip the dynamic-updates/* family of SVG tests.
All results were visually inspected and produced PASS results.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11
* platform/efl/Skipped: dynamic-updates removed.
* platform/efl/svg/dynamic-updates/: New baselines.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 11 Apr 2012 15:53:24 +0000 (15:53 +0000)]
[Qt] Fix the build on OpenGL ES2 platforms
Unreviewed build fix.
No new tests needed.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
Fix typo in TEXMAP_OPENGL_ES_2 define.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Wed, 11 Apr 2012 15:49:08 +0000 (15:49 +0000)]
Remove unused WebVideoFrame::Format values
https://bugs.webkit.org/show_bug.cgi?id=83625
Reviewed by Kenneth Russell.
Source/WebCore:
Covered by existing tests.
* platform/graphics/chromium/VideoFrameChromium.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::convertVFCFormatToGC3DFormat):
Source/WebKit/chromium:
* public/WebVideoFrame.h:
(WebKit):
* src/AssertMatchingEnums.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 11 Apr 2012 15:40:20 +0000 (15:40 +0000)]
Follow up to r113863: fix chromium inspector interactive test harness.
* src/js/Tests.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 11 Apr 2012 15:29:42 +0000 (15:29 +0000)]
Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684
Reviewed by Yury Semikhatsky.
Meta bug: https://bugs.webkit.org/show_bug.cgi?id=61363.
In this step, NetworkRequest is introduced. It temporarily inherits from
the Resource, but all the call sites are now referring to it as to request.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
* inspector/front-end/ConsoleMessage.js:
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
* inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry):
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HAREntry.prototype._buildCookie):
(WebInspector.HAREntry.prototype._interval):
(WebInspector.HAREntry.prototype.get requestBodySize):
(WebInspector.HAREntry.prototype.get responseBodySize):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get requests):
(WebInspector.NetworkLog.prototype.pageLoadForRequest):
(WebInspector.NetworkLog.prototype._onMainFrameNavigated):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.PageLoad):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.inflightRequestForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._finishNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._initializeView):
(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype._requestGridNode):
(WebInspector.NetworkLogView.prototype._createRequestGridNode):
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.get requests):
(WebInspector.NetworkLogView.prototype.requestById):
(WebInspector.NetworkLogView.prototype._onRequestStarted):
(WebInspector.NetworkLogView.prototype._appendRequest):
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._refreshRequest):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkLogView.prototype.get _setLargerRequests):
(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
(WebInspector.NetworkLogView.prototype._showPopover):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._copyAll):
(WebInspector.NetworkLogView.prototype._copyRequest):
(WebInspector.NetworkLogView.prototype._copyLocation):
(WebInspector.NetworkLogView.prototype._copyRequestHeaders):
(WebInspector.NetworkLogView.prototype._copyResponseHeaders):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkLogView.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype.handleShortcut):
(WebInspector.NetworkPanel.prototype.get requests):
(WebInspector.NetworkPanel.prototype.requestById):
(WebInspector.NetworkPanel.prototype._requestByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype._onViewCleared):
(WebInspector.NetworkPanel.prototype._onRequestSelected):
(WebInspector.NetworkPanel.prototype._showRequest):
(WebInspector.NetworkPanel.prototype._closeVisibleRequest):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundaries):
(WebInspector.NetworkTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.select):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
(WebInspector.NetworkDataGridNode.NameComparator):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):
* inspector/front-end/NetworkRequest.js: Added.
(WebInspector.NetworkRequest):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._requestFinished):
(WebInspector.RawSourceCode.prototype._createContentProvider):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set finished):
(WebInspector.Resource.prototype.set timing):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.requestContent):
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.wasShown):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdated):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._addRequest):
* inspector/front-end/ResourceUtils.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(WebInspector.networkRequestById):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.networkRequestById):
(WebInspector.openRequestInNetworkPanel):
Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684
Reviewed by Yury Semikhatsky.
* http/tests/inspector/network-preflight-options.html:
* http/tests/inspector/network-test.js:
* http/tests/inspector/network/async-xhr-json-mime-type.html:
* http/tests/inspector/network/download.html:
* http/tests/inspector/network/network-cachedresources-with-same-urls.html:
* http/tests/inspector/network/network-content-replacement-embed.html:
* http/tests/inspector/network/network-content-replacement-xhr.html:
* http/tests/inspector/network/network-cyrillic-xhr.html:
* http/tests/inspector/network/network-disable-cache-memory.html:
* http/tests/inspector/network/network-disable-cache-xhrs.html:
* http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
* http/tests/inspector/network/network-embed.html:
* http/tests/inspector/network/network-empty-xhr.html:
* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/inspector/network/network-initiator-from-console.html:
* http/tests/inspector/network/network-initiator.html:
* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/network/network-shared-worker.html:
* http/tests/inspector/network/network-sidebar-width.html:
* http/tests/inspector/network/network-size-chunked.html:
* http/tests/inspector/network/network-size-sync.html:
* http/tests/inspector/network/network-size.html:
* http/tests/inspector/network/network-timing.html:
* http/tests/inspector/network/network-worker.html:
* http/tests/inspector/network/network-xhr-async.html:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
* http/tests/inspector/network/network-xhr-sync.html:
* http/tests/inspector/network/ping.html:
* http/tests/inspector/network/x-frame-options-deny.html:
* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-har-headers.html:
* http/tests/inspector/resource-har-pages.html:
* http/tests/inspector/resource-parameters.html:
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.requestURLComparer):
* inspector/debugger/raw-source-code.html:
* inspector/debugger/source-frame.html:
* inspector/network-status-non-http.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arko@motorola.com [Wed, 11 Apr 2012 15:20:04 +0000 (15:20 +0000)]
Microdata: Implement cache mechanism for HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=80490
Reviewed by Ryosuke Niwa.
Implemented caching mechanism for HTMLPropertiesCollection.
propertyCache - contains microdata item properties.
itemRefElements - contains sorted microdata item and itemref elements.
propertyNames - contains microdata property names of the elements in the collection.
itemRefElementPosition - store the current position of itemRefElements.
hasItemRefElements - set to ture once we have sorted microdata item and itemref elements list i.e, itemRefElements.
Cache is invalidated only when dom tree modified. Whenever any query is made on HTMLPropertiesCollection,
result is returned from the cache. Earliar we used to calculate properties node list every time a query is made.
* html/HTMLPropertiesCollection.cpp:
(WebCore):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCacheIfNeeded):
(WebCore::HTMLPropertiesCollection::updateRefElements): Appends microdata item element and elements which
are added through itemref attribute in itemRefElements (in tree order).
(WebCore::nextNodeWithProperty):
(WebCore::HTMLPropertiesCollection::itemAfter): Takes parent base and previous item property as argument.
Finds the next item property in base.
(WebCore::HTMLPropertiesCollection::calcLength): Calculates the length of properties collection if length
is not available in the cache.
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::firstProperty): Returns the first property in the collection.
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties): Finds microdata item properties in the base element.
Appends the properties in propertyCache and property names in propertyNames.
(WebCore::HTMLPropertiesCollection::updateNameCache): It updates the propertyCache and propertyNames if hasNameCache is false.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:53:27 +0000 (14:53 +0000)]
[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594
Reviewed by Kenneth Rohde Christiansen.
.:
* Source/tests.pri:
Source/WebKit2:
This tests InspectorServer and WebSocketServer.
* UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Added.
* UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Added.
(tst_InspectorServer):
(tst_InspectorServer::tst_InspectorServer):
(tst_InspectorServer::prepareWebViewComponent):
(tst_InspectorServer::newWebView):
(tst_InspectorServer::init):
(tst_InspectorServer::cleanup):
(tst_InspectorServer::webView):
(tst_InspectorServer::fetchPageList):
(tst_InspectorServer::testPageList): This tests that pages with developerExtrasEnabled appear available for inspection.
(tst_InspectorServer::testRemoteDebuggingMessage): This tests a web socket connection using a raw inspector command.
(tst_InspectorServer::openRemoteDebuggingSession): This tests the whole pipeline by starting a remote inspection session.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::prepareWebViewComponent):
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.cpp:
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
* UIProcess/API/qt/tests/util.h:
(LoadStartedCatcher):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:52:19 +0000 (14:52 +0000)]
[Qt] InspectorServer: Improve the JSON page list's parameter names
https://bugs.webkit.org/show_bug.cgi?id=83592
Reviewed by Simon Hausmann.
- Add "id" that would be needed to build the URL when using local front-end resources
(and will be used by tests)
- Rename description to "title", the description contains both the title and URL on the final list
- Rename inspectorLocation to "inspectorUrl" to match with the url parameter.
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
(WebKit::WebInspectorServer::buildPageList):
* qt/Resources/inspectorPageIndex.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:50:42 +0000 (14:50 +0000)]
[Qt] Fix issues when using the WebView as ShaderEffectSource
https://bugs.webkit.org/show_bug.cgi?id=83587
Reviewed by Noam Rosenthal.
Source/WebCore:
- Make sure that the bound frame buffer is preserved instead of binding
to the default one
- Accept a "mirrored" flag in beginPainting that we're applying on the
projection matrix just as with internal FBOs
The "flip" logic in createProjectionMatrix has been reversed and renamed to
mirrored so that FBO rendering is considered the special case and not the
other way around just like within Qt.
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::beginPainting):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):
* platform/graphics/texmap/TextureMapperGL.h:
Source/WebKit2:
Qt is going to mirror the projection matrix when the shader effect source
is grabbed. Detect that the matrix is mirrored and pass on this information
to TextureMapper so that it can do the same.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::render):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:49:21 +0000 (14:49 +0000)]
[Qt] Remove unnecessary rendering code
https://bugs.webkit.org/show_bug.cgi?id=83591
Reviewed by Noam Rosenthal.
- Remove code that isn't needed since the introduction of WebLayerTreeRenderer
- Remove TextureMapper::bindSurface(0) calls following beginPainting, which calls it itself.
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.cpp:
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 14:00:18 +0000 (14:00 +0000)]
svg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
https://bugs.webkit.org/show_bug.cgi?id=63400
Unreviewed Chromium test expectation removal.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 13:41:51 +0000 (13:41 +0000)]
Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484
Unreviewed attempted build fix.
* dom/ContainerNodeAlgorithms.h: Adding Document.h include.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 11 Apr 2012 13:31:29 +0000 (13:31 +0000)]
[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor() implemetation.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-11
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 11 Apr 2012 13:29:01 +0000 (13:29 +0000)]
Remove unnecessary assignments from CSSParser::parseLinearGradient().
https://bugs.webkit.org/show_bug.cgi?id=83661
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 11 Apr 2012 13:23:36 +0000 (13:23 +0000)]
[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675
Make graphics surface available only for Qt 5, attempting to fix
the Qt-mac build.
Unreviewed build fix.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 13:18:30 +0000 (13:18 +0000)]
Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484
Reviewed by Hajime Morita.
The ContainerNode::removeAllChildren method does fast and dirty node removal.
As compared to ContainerNode::removeChildren, it does not include the
method to adopt the removed child node into the root document's TreeScope.
Rather, it leaves the existing TreeScope in place. However, the existing
TreeScope may be removed, causing a crash when something prevents the child
node from being deleted immediately. The fix is to modify the code in
ContainerNodeAlgorithms to do the TreeScope adoption.
Could not reproduce crash in layout test.
* dom/ContainerNodeAlgorithms.h:
(Private):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 11 Apr 2012 12:52:04 +0000 (12:52 +0000)]
Web Inspector: showing summary view is very slow on a snapshot with thousands of constructors
https://bugs.webkit.org/show_bug.cgi?id=83682
Node content is created only when the node becomes visible in the corresponding view.
This saves a lot of time when openning summary/comparison view of a snapshot
with lots of different classes.
Reviewed by Pavel Feldman.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid tr:empty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 12:24:13 +0000 (12:24 +0000)]
Unreviewed, GTK NRWT follow-up fix after r113849.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 11:57:52 +0000 (11:57 +0000)]
[GTK] media/event-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=71662
Patch by Simon Pena <spena@igalia.com> on 2012-04-11
Reviewed by Philippe Normand.
Source/WebCore:
In MediaPlayerPrivateGStreamer::didEnd, when EOS is reached, don't
synchronize position and duration on regular playback. That is:
synchronize it (and fire the durationChange signal) only on reverse
playback.
This change makes media/event-attributes.html pass. It was
previously failing because an additional durationChange signal was
emitted.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Avoid
sending durationChange signal on regular playback.
Tools:
PulseAudio's module "module-stream-restore" allows saving the volume
of a stream, restoring it the next time it runs.
This affects the tests, since DumpRenderTree's volume settings are
saved between test runs, and tests relying on specific volume values
would miss some volumeChange events (or get additional ones).
This patch hooks on the existing GtkPort setup_test_run method and
creates a new clean_up_test_run method, so PulseAudio's module is
unloaded (if found) before running the tests, and restored (if it
was there previously) after they finished, ensuring the tests run in
the right environment.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._clean_up_run): Invoke the port implementation of
clean_up_test_run.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.clean_up_test_run): Add an empty implementation of
clean_up_test_run.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module): Unloads the offending
pulseaudio module, if found.
(GtkPort):
(GtkPort._restore_pulseaudio_module): Restores the offending
pulseaudio module, if it was there previously.
(GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
(GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
LayoutTests:
Unskip tests media/video-seek-past-end-playing and
media/sources-fallback-codecs, which no longer fail, and
media/event-attributes, which is fixed with this patch.
* platform/gtk/Skipped: Unskip media/video-seek-past-end-playing,
media/sources-fallback-codecs and media/event-attributes
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 11 Apr 2012 11:23:19 +0000 (11:23 +0000)]
Fix the build with gcc 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=83584
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests needed.
* Target.pri: Disable Werror on the ANGLE code since it has several recurring issues
because older versions of flex (<2.5.35) and bison (<2.5) generate code which
triggers warnings. This generated code is committed on each version update of ANGLE,
and it is very likely that the code is generated with older versions of the mentioned
tools.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra
* platform/graphics/TiledBackingStoreClient.h: Fails because -Werror=delete-non-virtual-dtor,
gcc requires classes which have virtual methods to have a virtual destructor, if their instances
or the instances of their subclasses are deleted.
(WebCore::TiledBackingStoreClient::~TiledBackingStoreClient):
* platform/graphics/texmap/TextureMapperPlatformLayer.h: Ditto.
(WebCore::TextureMapperPlatformLayer::~TextureMapperPlatformLayer):
Tools:
* qmake/mkspecs/features/unix/default_post.prf:
The -fuse-ld=gold option is not supported with upstream gcc.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 10:50:48 +0000 (10:50 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Mark two a11y tests as flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 10:06:24 +0000 (10:06 +0000)]
[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=83561
Reviewed by Adam Barth.
Add ScriptController::installFunctionsForPagePopup(), which add
window.setValueAndClosePopup() for JavaScript code in PagePopup
environment, and the function calls
WebCore::PagePopupClient::setValueAndClosePopup().
This patch introduces Supplement<DOMWindow> object to hold a
PagePopupClient object. It makes keeping a PagePopupClient easier.
* WebCore.gypi: Add DOMWindowPagePopup.{cpp,h}
* bindings/v8/ScriptController.cpp:
(WebCore::setValueAndClosePopupCallback):
(WebCore::ScriptController::installFunctionsForPagePopup):
* bindings/v8/ScriptController.h:
(ScriptController): Add installFunctionsForPagePopup().
* page/DOMWindowPagePopup.cpp: Added.
(WebCore::DOMWindowPagePopup::DOMWindowPagePopup):
(WebCore::DOMWindowPagePopup::supplementName):
Returns "DOMWindowPagePopup" as a key of this Supplement<DOMWindow>.
(WebCore::DOMWindowPagePopup::setValueAndClosePopup):
Gets a DOMWindowPagePopup from the window, then calls PagePopupClient::setValueAndClosePopup().
(WebCore::DOMWindowPagePopup::install):
On-demand creation of DOMWindowPagePopup doesn't work because it
must have a PagePopupClient object. We need to install
DOMWindowPagePopup explicitly.
* page/DOMWindowPagePopup.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 10:00:21 +0000 (10:00 +0000)]
[chromium] Add Battery Status API support.
Source/WebCore:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
This change is covered by tests in batterystatus/.
* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Source/WebKit/chromium:
The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-
20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):
* public/WebBatteryStatusClient.h: Added.
(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):
* public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):
* public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):
* src/BatteryClientImpl.cpp: Added.
(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):
* src/BatteryClientImpl.h: Added.
(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 11 Apr 2012 09:44:20 +0000 (09:44 +0000)]
[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
https://bugs.webkit.org/show_bug.cgi?id=83574
Reviewed by Daniel Bates.
This new macro generates forwarding headers with absolute paths to the original files.
It accepts a list of files and/or a list of directories as input.
* Source/cmake/WebKitMacros.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 09:43:01 +0000 (09:43 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Mark an editing test as flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Wed, 11 Apr 2012 09:41:37 +0000 (09:41 +0000)]
[CSS Regions]Add helper class for flow threads info in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83464
Reviewed by David Hyatt.
This patch creates a new helper class FlowThreadController that will accommodate all the flow thread
related info from RenderView and moves all the data structures/methods from RenderView into this new class.
There is only one FlowThreadController object per RenderView and it can be retrieved using flowThreadController() method from RenderView.
The flow thread controller object is owned by the RenderView and it is created on demand only if there are flowing
threads in the page.
Since there is no change in functionality, there are no new tests added.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* rendering/FlowThreadController.cpp: Added.
(WebCore):
(WebCore::FlowThreadController::create):
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::~FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
* rendering/FlowThreadController.h: Added.
(WebCore):
(FlowThreadController):
(WebCore::FlowThreadController::currentRenderFlowThread):
(WebCore::FlowThreadController::setCurrentRenderFlowThread):
(WebCore::FlowThreadController::isRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::renderNamedFlowThreadList):
(WebCore::FlowThreadController::hasRenderNamedFlowThreads):
* rendering/RenderFlowThread.cpp:
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):
* rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::willBeDestroyed):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderNamedFlowThreads):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::flowThreadController):
* rendering/RenderView.h:
(WebCore):
(RenderView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 09:29:51 +0000 (09:29 +0000)]
[EFL][DRT] SVG Filters rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83673
Unreviewed, EFL rebaseline.
Bug 83562 fixed programmatically creating filters from JS, this
allows us to unskip a lot of SVG tests. This is part two.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11
* platform/efl/Skipped: Removed svg/filters/*.
* platform/efl/svg/filters/: New baselines.
* platform/efl/test_expectations.txt: Added one dropShadow filter failure.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 11 Apr 2012 09:16:11 +0000 (09:16 +0000)]
Web Inspector: [Device Metrics] Implement dimension swapping
https://bugs.webkit.org/show_bug.cgi?id=83676
The change adds a "Swap dimensions" button that swaps the emulated device dimensions to
mimic the device rotation (give that the ORIENTATION_EVENTS feature is disabled in Chromium).
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.swapDimensionsClicked):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 11 Apr 2012 08:54:53 +0000 (08:54 +0000)]
Refactor PerfTestRunner to include file extensions in test names
https://bugs.webkit.org/show_bug.cgi?id=83677
Reviewed by Hajime Morita.
Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_collect_tests):
(test_collect_tests_with_skipped_list):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 08:52:32 +0000 (08:52 +0000)]
Fix compiler warnings for generated CalendarPicker.cpp with VC++
https://bugs.webkit.org/show_bug.cgi?id=83672
Reviewed by Kentaro Hara.
* make-file-arrays.py:
(main): Do not generate literal integers larger than 127 for
members of char arrays. Use '\xHH' instead.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 08:49:30 +0000 (08:49 +0000)]
Unreviewed, GTK rebaseline and baselines for new tests.
* platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
* platform/gtk/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/gtk/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/gtk/ietestcenter/: Added.
* platform/gtk/tables/mozilla/bugs/bug2123-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2509-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 08:49:18 +0000 (08:49 +0000)]
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.
Source/WebKit/win:
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebCoreSupport/WebInspectorClient.cpp:
* WebInspector.cpp:
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):
Tools:
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 11 Apr 2012 08:38:33 +0000 (08:38 +0000)]
Web Inspector: fix category -> type refactoring implications.
https://bugs.webkit.org/show_bug.cgi?id=83680
Reviewed by Yury Semikhatsky.
We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):
* inspector/front-end/resourcesPanel.css:
(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 08:29:12 +0000 (08:29 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/Skipped: Skip failing ref test
* platform/gtk/test_expectations.txt: Mark two tests as crashing
and unskip tests needing rebaseline.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 11 Apr 2012 07:02:17 +0000 (07:02 +0000)]
[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83657
Reviewed by Martin Robinson.
Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 07:00:33 +0000 (07:00 +0000)]
Unreviewed, GTK rebaseline after r113756.
* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
* platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
* platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 11 Apr 2012 06:46:56 +0000 (06:46 +0000)]
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
* GNUmakefile.list.am: Ad missing files.
Source/WebCore:
* GNUmakefile.list.am: Add missing header file.
Source/WebKit2:
* GNUmakefile.am: Add missing header file.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 11 Apr 2012 06:26:39 +0000 (06:26 +0000)]
[chromium] Signedness issue with code informing v8 of PatternSkia memory use
https://bugs.webkit.org/show_bug.cgi?id=83642
Reviewed by James Robinson.
The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.
* platform/graphics/Pattern.h:
(Pattern):
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 11 Apr 2012 05:39:23 +0000 (05:39 +0000)]
Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 11 Apr 2012 05:35:16 +0000 (05:35 +0000)]
[chromium] ImageBuffer minor style fix: remove compound declaration
https://bugs.webkit.org/show_bug.cgi?id=83660
Reviewed by Kent Tamura.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Wed, 11 Apr 2012 05:23:01 +0000 (05:23 +0000)]
Roll Chromium DEPS to last-known good revision
https://bugs.webkit.org/show_bug.cgi?id=83652
Unreviewed, just a DEPS roll (131469:131684)
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 04:58:33 +0000 (04:58 +0000)]
Add gesture event enums for long-press and pinch
https://bugs.webkit.org/show_bug.cgi?id=83640
Patch by Alexandre Elias <aelias@google.com> on 2012-04-10
Reviewed by James Robinson.
Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.
Source/WebCore:
No new tests. (No-op change.)
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/PlatformEvent.h:
Source/WebKit/chromium:
* public/WebInputEvent.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 11 Apr 2012 04:48:41 +0000 (04:48 +0000)]
Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html
markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.
For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
LayoutTests:
* fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
* fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Wed, 11 Apr 2012 04:19:01 +0000 (04:19 +0000)]
Prevent fallthrough to keep static analysis tools happy
https://bugs.webkit.org/show_bug.cgi?id=83639
Reviewed by Darin Adler.
No new tests - no new behaviour.
* css/LengthFunctions.cpp:
(WebCore::valueForLength):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 11 Apr 2012 04:15:37 +0000 (04:15 +0000)]
Don't expose the intrinsic padding concept to the code outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83380
Reviewed by Eric Seidel.
No new tests, refactoring only.
The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.
This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.
* rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Killed the enum paddingOptions!
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.
* rendering/RenderTableCell.h:
(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
Updated these functions after the renaming.
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 03:35:05 +0000 (03:35 +0000)]
TextureMapperGL.cpp breaks build with OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=83622
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.
Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc