ossy@webkit.org [Tue, 17 Jan 2012 08:25:17 +0000 (08:25 +0000)]
[Qt] Unreviewed morning gardening.
* platform/qt/Skipped: Skip a failing test.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 17 Jan 2012 08:23:56 +0000 (08:23 +0000)]
[GTK] fast/dom/constructed-objects-prototypes.html fails
https://bugs.webkit.org/show_bug.cgi?id=75432
Reviewed by Martin Robinson.
Tools:
* Scripts/build-webkit: Enable video-track in GTK.
LayoutTests:
* platform/gtk/test_expectations.txt: Test now passing no longer
needs to be skipped.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 17 Jan 2012 08:18:15 +0000 (08:18 +0000)]
Unreviewed, GTK rebaseline after r105075 and r105085.
* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/gtk/fast/block/float/015-expected.txt:
* platform/gtk/fast/borders/rtl-border-05-expected.txt:
* platform/gtk/fast/dom/34176-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/inner-text-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
* platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 17 Jan 2012 07:08:29 +0000 (07:08 +0000)]
Unreviewed:more Chromium Linux rebaselining
* platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Removed.
* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-linux/svg/text/text-align-03-b-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jan 2012 06:44:52 +0000 (06:44 +0000)]
[Internals] member varaibles should follow naming convention.
https://bugs.webkit.org/show_bug.cgi?id=76426
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-16
Reviewed by Kent Tamura.
No new tests. Just a rename.
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
* testing/Internals.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 17 Jan 2012 06:02:29 +0000 (06:02 +0000)]
Unreviewed: updated baselines for Chromium Linux
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
* platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Removed.
* platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Removed.
* platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Removed.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
* platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium-linux/svg/text/text-align-02-b-expected.png:
* platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 17 Jan 2012 05:24:50 +0000 (05:24 +0000)]
Unreviewed: rebaselining fast/backgrounds/mask-box-image
* platform/chromium-mac-snowleopard/fast/backgrounds/mask-box-image-expected.png: Added.
* platform/chromium-win/fast/backgrounds/mask-box-image-expected.png: Added.
* platform/chromium-win/fast/backgrounds/mask-box-image-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 17 Jan 2012 03:56:16 +0000 (03:56 +0000)]
Implement multiple AT_TARGET event dispatching in regard to shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=76217
Reviewed by Dimitri Glazkov.
The original motivation is to fix the regression: Event.eventPhase is not set to 2
(at target) when handling dblclick event in <input> element.
Since the issue is not specific to <input> element, but general one, this patch fixes
the regression by adapting a living draft spec of shadow DOM.
This won't break a compatibility if there is no shadow boundaries in event dispatching.
See the following shadow dom spec how multiple AT_TARGET events work.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch
Source/WebCore:
* dom/EventContext.cpp:
(WebCore::EventContext::handleLocalEvents):
LayoutTests:
* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Tue, 17 Jan 2012 03:47:09 +0000 (03:47 +0000)]
Add toyoshim as a committer.
https://bugs.webkit.org/show_bug.cgi?id=76390
Reviewed by Hajime Morita.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jan 2012 03:35:24 +0000 (03:35 +0000)]
platformRequest(QNX) need to get the conditional information from ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=75216
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-01-16
Reviewed by George Staikos.
Pass the isConditional() flag in ResourceRequest to the QNX platform's network request.
QNX platform's network needs this flag to determine whether to use disk-cache.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(ResourceRequest::initializePlatformRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 17 Jan 2012 02:25:52 +0000 (02:25 +0000)]
Heap-use-after-free in WebCore::RenderBlock::selectionGaps
https://bugs.webkit.org/show_bug.cgi?id=75013
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/multiple-captions-crash3.html
fast/table/multiple-captions-crash4.html
fast/table/multiple-captions-crash5.html
When a child float is removed, the parent needs to ensure any reference to the
child is also removed from the floating objects list in any sibling block that
it intruded into.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
LayoutTests:
In multiple-captions-crash3.html a floating object is added as a child to a caption element, then removed and
added as a child to another caption element. When added to the first caption element it is added
to the floating objects list of both the parent tbody element and the keygen element, as it intrudes
into the latter. When removed, a stale reference to the floating object remains in the keygen element.
When the keygen element is in layout it attempts to access the stale reference to the floating object and
crashes. The fix is to ensure that any floats added as intruding floats to sibling blocks are removed
when the child is removed from the tree.
multiple-captions-crash4.html and multiple-captions-crash5.html are variants of this scenario.
* fast/table/multiple-captions-crash3-expected.html: Added.
* fast/table/multiple-captions-crash3.html: Added.
* fast/table/multiple-captions-crash4-expected.html: Added.
* fast/table/multiple-captions-crash4.html: Added.
* fast/table/multiple-captions-crash5-expected.html: Added.
* fast/table/multiple-captions-crash5.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 17 Jan 2012 01:17:48 +0000 (01:17 +0000)]
<rdar://problem/
10702758> REGRESSION: Every Safari Reader WKView leaks
Reviewed by John Sullivan and Ada Chan.
* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): Since this method can be called multiple times in a row
while [self window] is non-nil, check if there isn’t already an event monitor before adding
a new one.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Tue, 17 Jan 2012 01:12:51 +0000 (01:12 +0000)]
REGRESSION: r102553 Autocorrection bubble doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=76408
<rdar://problem/
10644746>
Prior to r102553 Editor::markAllMisspellingsAndBadGrammarInRanges() used to pass its
textCheckingOptions directly to markAndReplaceFor(). Now a request object is used,
but, when the object is created, the TextCheckingTypeShowCorrectionPanel flag is dropped.
Reviewed by Darin Adler.
* editing/Editor.cpp:
(WebCore::Editor::resolveTextCheckingTypeMask): Add TextCheckingTypeShowCorrectionPanel to
the returned checkingTypes when appropriate.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 17 Jan 2012 00:53:40 +0000 (00:53 +0000)]
DFG should be able to do JS and custom getter caching
https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/
10698060>
Source/JavaScriptCore:
Reviewed by Geoff Garen.
Added the ability to cache JS getter calls and custom getter calls in the DFG.
Most of this is pretty mundane, since the old JIT supported this functionality
as well. But a couple interesting things had to happen:
- There are now two variants of GetById: GetById, which works as before, and
GetByIdFlush, which flushes registers prior to doing the GetById. Only
GetByIdFlush can be used for caching getters. We detect which GetById style
to use by looking at the inline caches of the old JIT.
- Exception handling for getter calls planted in stubs uses a separate lookup
handler routine, which uses the CodeOrigin stored in the StructureStubInfo.
This is a 40% speed-up in the Dromaeo DOM Traversal average. It removes all of
the DFG regressions we saw in Dromaeo. This is neutral on SunSpider, V8, and
Kraken.
* bytecode/StructureStubInfo.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::willNeedFlush):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupResults):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::addExceptionCheck):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Geoff Garen.
* fast/js/dfg-custom-getter-expected.txt: Added.
* fast/js/dfg-custom-getter-throw-expected.txt: Added.
* fast/js/dfg-custom-getter-throw-inlined-expected.txt: Added.
* fast/js/dfg-custom-getter-throw-inlined.html: Added.
* fast/js/dfg-custom-getter-throw.html: Added.
* fast/js/dfg-custom-getter.html: Added.
* fast/js/dfg-getter-expected.txt: Added.
* fast/js/dfg-getter-throw-expected.txt: Added.
* fast/js/dfg-getter-throw.html: Added.
* fast/js/dfg-getter.html: Added.
* fast/js/script-tests/dfg-custom-getter-throw-inlined.js: Added.
(foo):
(baz):
(bar):
* fast/js/script-tests/dfg-custom-getter-throw.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-custom-getter.js: Added.
(foo):
* fast/js/script-tests/dfg-getter-throw.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-getter.js: Added.
(foo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 17 Jan 2012 00:25:44 +0000 (00:25 +0000)]
Crash when calling SecItemAdd with a null result pointer
https://bugs.webkit.org/show_bug.cgi?id=76407
<rdar://problem/
10696087>
Reviewed by Brady Eidson.
Add null check.
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::webSecItemAdd):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 17 Jan 2012 00:16:48 +0000 (00:16 +0000)]
[WinCairo] Build correction. Switch to Apple style builds without
the _debug postfix so that launching tools, etc., will work properly.
* win/tools/vsprops/debug_wincairo.vsprops: Remove use of _debug in
output files to be consistent with WebKit build/test tools.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 17 Jan 2012 00:04:56 +0000 (00:04 +0000)]
A follow-up fix for:
A warning is logged to console when typing a bare "/" in Safari address bar
https://bugs.webkit.org/show_bug.cgi?id=76236
<rdar://problem/
10702986>
Reviewed by John Sullivan.
* Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a
path when there is a base URL.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 16 Jan 2012 23:46:32 +0000 (23:46 +0000)]
Build fix for r105086.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
* notifications/NotificationCenter.idl: change to use ENABLE_TEXT_NOTIFICATIONS_ONLY, which is only defined on Mac platform.
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 23:38:12 +0000 (23:38 +0000)]
Fix typo in StyledElement::mappedAttributeCount().
<http://webkit.org/b/76393>
Rubber-stamped by Antti Koivisto.
* dom/StyledElement.h:
(WebCore::StyledElement::mappedAttributeCount): Less &&, more ?:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 16 Jan 2012 22:49:57 +0000 (22:49 +0000)]
Build fix for r105086.
* notifications/NotificationCenter.idl: expand ENABLE macro for .idl.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 16 Jan 2012 22:39:51 +0000 (22:39 +0000)]
Cache CSSStyleSelector::Features in RuleSets
https://bugs.webkit.org/show_bug.cgi?id=76337
Reviewed by Andreas Kling.
Currently whenever the style selector is updated we go through all the applicable rules and
collect the used features again. We should keep the features around as part of the RuleSets
and update them incrementally. Collecting the features will then be just a matter of taking
the union of all features used by the RuleSets.
This is 1-2% CPU time reduction (engadget, nytimes) due less time spent in feature collection.
This also simplifies the code by removing the need to cache the default style sheet features
separately.
* css/CSSStyleSelector.cpp:
Remove the global siblingRulesInDefaultStyle and uncommonAttributeRulesInDefaultStyle RuleSets.
These are now part of the cached features of the defaultStyle.
(WebCore::RuleSet::features):
Add a field for caching the features.
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectFeatures):
Unify the features of all RuleSets.
Create RuleSets for sibling and uncommon attribute lookups at the end.
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::Features::add):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
Collect the features when adding the rules rather than as a separate pass through all the rules.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::RuleSelectorPair::RuleSelectorPair):
Use Vector instead of a RuleSet for sibling and uncommon attribute selectors so unifying
Features is simpler.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 16 Jan 2012 22:37:13 +0000 (22:37 +0000)]
Huge filter area cause hangs and malloc failures
https://bugs.webkit.org/show_bug.cgi?id=75711
Reviewed by Dean Jackson.
Filtering an element with a child that had a huge negative text-indent
was extremely slow, because transparencyClipBox() returned a huge rect.
Add a method, paintingExtent(), that wraps transparencyClipBox()
and intersects it with the paintDirtyRect to constrain the size
of the rect used for filters and transparency layers.
Transparency layer extent is not testable in layout tests.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintingExtent):
(WebCore::RenderLayer::beginTransparencyLayers): Floating point literals are required
to avoid ambiguous constructor call.
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
* rendering/RenderLayer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 16 Jan 2012 22:21:48 +0000 (22:21 +0000)]
Borders and box masks behave incorrectly with overlapping offsets
https://bugs.webkit.org/show_bug.cgi?id=76137
Source/WebCore:
Reviewed by Dean Jackson.
There are some correct behaviors for -webkit-mask-box-image where
parts of the mask are missing (when the sum of the slice sizes is
greater than one dimension of the image). To render correctly
in these cases, always use a transparency layer when rendering
the mask.
Test: fast/backgrounds/mask-box-image.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages):
LayoutTests:
Reviewed by Dean Jackson.
Test -webkit-mask-box-image with large slice sizes, with and
without a transform.
* fast/backgrounds/mask-box-image.html: Added.
* fast/backgrounds/resources/dot.png: Added.
* platform/mac/fast/backgrounds/mask-box-image-expected.png: Added.
* platform/mac/fast/backgrounds/mask-box-image-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 16 Jan 2012 22:19:36 +0000 (22:19 +0000)]
Filtered element with composited content beneath it must be composited
https://bugs.webkit.org/show_bug.cgi?id=76322
Source/WebCore:
Reviewed by Dean Jackson.
If a RenderLayer has a filter effect, and a composited descendant, then
that layer must also be composited so that the filter is applied via
the compositing system, rather than via painting (otherwise the filter
will not affect the descendant).
Test: css3/filters/filtered-compositing-descendant.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
LayoutTests:
Reviewed by Dean Jackson.
Testcase with a filtered element having a composited child.
* css3/filters/filtered-compositing-descendant-expected.png: Added.
* css3/filters/filtered-compositing-descendant-expected.txt: Added.
* css3/filters/filtered-compositing-descendant.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 21:53:39 +0000 (21:53 +0000)]
Fix assertion failure in mappedAttributesEquivalent().
<http://webkit.org/b/76393>
Rubber-stamped by Antti Koivisto.
The assertion that two mapped attributes with matching name/value will always
have the exact same decl() was wrong, so make it a proper check once again.
* css/CSSStyleSelector.cpp:
(WebCore::mappedAttributesEquivalent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Mon, 16 Jan 2012 21:31:03 +0000 (21:31 +0000)]
[WinCairo] Build fix after r104155. Several debug targets were not
properly including the '*Common' property sheets.
* DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
* DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
* MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
* WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
* WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bbudge@chromium.org [Mon, 16 Jan 2012 21:18:39 +0000 (21:18 +0000)]
Changes AssociatedURLLoader to remove non-whitelisted HTTP response headers for CORS requests,
and Set-Cookie and Set-Cookie2 response headers for all requests.
https://bugs.webkit.org/show_bug.cgi?id=76228
Reviewed by Adam Barth.
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::create):
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
(WebKit::AssociatedURLLoader::loadAsynchronously):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::didReceiveResponse):
(WebKit::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 16 Jan 2012 21:11:44 +0000 (21:11 +0000)]
Remove HTML notifications support on Mac
https://bugs.webkit.org/show_bug.cgi?id=76401
<rdar://problem/
10589881>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
* wtf/Platform.h: Define ENABLE_HTML_NOTIFICATIONS macro.
Source/WebCore:
* notifications/NotificationCenter.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 20:50:46 +0000 (20:50 +0000)]
Add offline web applications API applicationCache.abort.
https://bugs.webkit.org/show_bug.cgi?id=76270
Patch by xueqing huang <huangxueqing@baidu.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests:
http/tests/appcache/abort-cache-onchecking.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
http/tests/appcache/abort-cache-ondownloading.html
http/tests/appcache/abort-cache-ondownloading-manifest-404.html
http/tests/appcache/abort-cache-ondownloading-resource-404.html
http/tests/appcache/abort-cache-onprogress.html
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
* loader/appcache/ApplicationCacheGroup.h:
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::abort):
* loader/appcache/ApplicationCacheHost.h:
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::abort):
* loader/appcache/DOMApplicationCache.h:
* loader/appcache/DOMApplicationCache.idl:
Source/WebKit/chromium:
* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::abort):
LayoutTests:
* http/tests/appcache/abort-cache-onchecking-expected.txt: Added.
* http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt: Added.
* http/tests/appcache/abort-cache-onchecking-manifest-404.html: Added.
* http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt: Added.
* http/tests/appcache/abort-cache-onchecking-resource-404.html: Added.
* http/tests/appcache/abort-cache-onchecking.html: Added.
* http/tests/appcache/abort-cache-ondownloading-expected.txt: Added.
* http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt: Added.
* http/tests/appcache/abort-cache-ondownloading-manifest-404.html: Added.
* http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt: Added.
* http/tests/appcache/abort-cache-ondownloading-resource-404.html: Added.
* http/tests/appcache/abort-cache-ondownloading.html: Added.
* http/tests/appcache/abort-cache-onprogress-expected.txt: Added.
* http/tests/appcache/abort-cache-onprogress.html: Added.
* http/tests/appcache/resources/abort-cache-onchecking-resource-404.manifest: Added.
* http/tests/appcache/resources/abort-cache-onchecking.manifest: Added.
* http/tests/appcache/resources/abort-cache-onchecking.text: Added.
* http/tests/appcache/resources/abort-cache-ondownloading-resource-404.manifest: Added.
* http/tests/appcache/resources/abort-cache-ondownloading.manifest: Added.
* http/tests/appcache/resources/abort-cache-ondownloading.text: Added.
* http/tests/appcache/resources/abort-cache-onprogress-1.text: Added.
* http/tests/appcache/resources/abort-cache-onprogress-2.text: Added.
* http/tests/appcache/resources/abort-cache-onprogress-3.text: Added.
* http/tests/appcache/resources/abort-cache-onprogress-4.text: Added.
* http/tests/appcache/resources/abort-cache-onprogress.manifest: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 20:28:30 +0000 (20:28 +0000)]
Remove caching of mapped attribute count on NamedNodeMap.
<http://webkit.org/b/76393>
Reviewed by Antti Koivisto.
Stop caching the mapped attribute count on Element's attribute map, effectively
shrinking NamedNodeMap by one CPU word. The price we pay is always walking over
the map in matchAllRules(), even if it has no mapped attribute styles.
This reduces memory consumption by 605 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>
* css/CSSStyleSelector.cpp:
(WebCore::mappedAttributesEquivalent):
Moved here from NamedNodeMap::mappedMapsEquivalent() to accomodate the only
user under the added assumption that the two attribute maps have the same
number of mapped attributes.
(WebCore::CSSStyleSelector::matchAllRules):
We don't have NamedNodeMap::hasMappedAttributes() at our convenience any
more so walk the attribute map (if there is one) looking for styles to add.
(WebCore::CSSStyleSelector::canShareStyleWithElement):
Compare the elements' mapped attribute counts at an earlier time. This is
slightly more expensive but we used to do it near the end anyway and this
ends up rejecting elements that can't share style before doing a lot of
semi-expensive checks.
* dom/StyledElement.h:
(WebCore::StyledElement::mappedAttributeCount):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::mappedAttributeCount):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::clearAttributes):
Remove NamedNodeMap::m_mappedAttributeCount and add a function that walks
the attribute map counting the attributes that have a decl().
* dom/NamedNodeMap.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
Remove declAdded()/declRemoved() callbacks.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Jan 2012 20:02:51 +0000 (20:02 +0000)]
REGRESSION(r105072): It broke committers_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=76396
Reviewed by Adam Barth.
* Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest._assert_fuzz_match): It should handle more names.
(CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 16 Jan 2012 19:28:30 +0000 (19:28 +0000)]
Unreviewed build fix.
Added necessary header files to VectorMath.cpp to fix Chromium compile error.
* platform/audio/VectorMath.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 16 Jan 2012 18:53:11 +0000 (18:53 +0000)]
WebAudio: Optimize AudioChannel::maxAbsValue().
https://bugs.webkit.org/show_bug.cgi?id=74359
Reviewed by Eric Carlson.
No new tests; optimization of existing code, so covered by existing test cases.
* platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::maxAbsValue): Replace implementation with optimized vector math
operation.
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vmaxmgv): Vector math operation for determining maximum
magnitude in a vector.
* platform/audio/VectorMath.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 16 Jan 2012 18:46:52 +0000 (18:46 +0000)]
A warning is logged to console when typing a bare "/" in Safari address bar
https://bugs.webkit.org/show_bug.cgi?id=76236
Reviewed by John Sullivan.
* Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 18:42:03 +0000 (18:42 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=41210
Cross Origin XMLHttpRequest can not expose headers indicated in Access-Control-Expose-Headers HTTP Response Header
Source/WebCore:
Parsing the "Access-Control-Expose-Headers" in the XMLHTTPRequest response header.
If the custom response-header is part of Access-Control-Expose-Headers, then consider that custom response-header as a valid one.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.
Test: http/tests/xmlhttprequest/access-control-response-with-expose-headers.html
* loader/CrossOriginAccessControl.cpp:
(WebCore::parseAccessControlExposeHeadersAllowList): parsing logic of Access-Control-Expose-Headers
* loader/CrossOriginAccessControl.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getAllResponseHeaders): checking whether the custom response-header is part of "Access-Control-Expose-Headers"
(WebCore::XMLHttpRequest::getResponseHeader): checking whether the custom response-header is part of "Access-Control-Expose-Headers"
LayoutTests:
Added test cases for Access-Control-Expose-Headers
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.
* http/tests/xmlhttprequest/access-control-response-with-expose-headers-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-response-with-expose-headers.html: Added.
* http/tests/xmlhttprequest/resources/access-control-response-with-expose-headers.php: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 18:40:21 +0000 (18:40 +0000)]
[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-16
Reviewed by Philippe Normand.
* gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zeno.albisser@nokia.com [Mon, 16 Jan 2012 18:17:35 +0000 (18:17 +0000)]
[Qt] Fix QT_VERSION related warnings when building on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=76340
Source/JavaScriptCore:
This bug was caused by r104826.
As already mentioned for https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.
Reviewed by Tor Arne Vestbø.
* wtf/Platform.h:
Source/WebKit2:
This bug was caused by r104826.
As was already mentioned for https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.
Reviewed by Tor Arne Vestbø.
* Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):
* UIProcess/LayerTreeHostProxy.h:
(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 16 Jan 2012 18:05:06 +0000 (18:05 +0000)]
[Chromium] Unreviewed, rebaseline SVG tests after r105061.
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
* platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-path-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
* platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
* platform/chromium-mac-leopard/svg/text/text-align-03-b-expected.png:
* platform/chromium-mac-leopard/svg/text/text-tselect-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/bidi-text-anchor-direction-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-align-03-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-tselect-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/tref-update-expected.txt:
* platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
* platform/chromium-win/svg/text/text-align-02-b-expected.png:
* platform/chromium-win/svg/text/text-align-03-b-expected.png:
* platform/chromium-win/svg/text/text-align-04-b-expected.txt:
* platform/chromium-win/svg/text/text-align-06-b-expected.png:
* platform/chromium-win/svg/text/text-align-06-b-expected.txt:
* platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
* platform/chromium-win/svg/text/text-text-01-b-expected.txt:
* platform/chromium-win/svg/text/text-tspan-01-b-expected.txt:
* platform/chromium-win/svg/text/text-ws-01-t-expected.txt:
* platform/chromium-win/svg/text/text-ws-02-t-expected.txt:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium/svg/text/bidi-text-anchor-direction-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danw@gnome.org [Mon, 16 Jan 2012 18:03:40 +0000 (18:03 +0000)]
Add myself as a committer
Unreviewed
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 16 Jan 2012 17:31:36 +0000 (17:31 +0000)]
Web Inspector: timeline record bars may overlap with the records column
https://bugs.webkit.org/show_bug.cgi?id=76387
Reviewed by Yury Semikhatsky.
* inspector/front-end/timelinePanel.css:
(#timeline-container .split-view-sidebar-left):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 16 Jan 2012 17:24:28 +0000 (17:24 +0000)]
Web Inspector: styles sidebar rendering is broken
https://bugs.webkit.org/show_bug.cgi?id=76065
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
* inspector/front-end/elementsPanel.css:
(.styles-section .header .subtitle):
(.styles-section .properties):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Mon, 16 Jan 2012 17:18:21 +0000 (17:18 +0000)]
Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
Some recent versions of a few Linux distributions have started passing
--as-needed and --no-copy-dt-needed-entries by default to the linker,
which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
needed a few symbols from libjavascriptcore_efl.so.
* DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
libraries are searched in the right order by the linker.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Jan 2012 17:17:53 +0000 (17:17 +0000)]
[Qt] Inremental build problem revealed by https://bugs.webkit.org/show_bug.cgi?id=74455
Reviewed by Tor Arne Vestbø.
* DerivedSources.pri: supplemental_dependency.tmp must depends on idl files too.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 16 Jan 2012 16:56:19 +0000 (16:56 +0000)]
Web Inspector: do not merge iframes into a single DOM hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=76383
Reviewed by Timothy Hatcher.
Source/WebCore:
* inspector/DOMEditor.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerFirstChild):
(WebCore::InspectorDOMAgent::innerParentNode):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._ownerDocumentId):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
* inspector/front-end/ElementsTreeOutline.js:
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.findNode.processChildren):
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/elements/set-outer-html-body.html:
* inspector/styles/styles-iframe.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 16 Jan 2012 16:47:19 +0000 (16:47 +0000)]
Web Inspector: setCurrentFocusElement should not update selection when focus is moved to text field or text area.
https://bugs.webkit.org/show_bug.cgi?id=76384
Reviewed by Timothy Hatcher.
* inspector/front-end/JavaScriptOutlineDialog.js:
(WebInspector.JavaScriptOutlineDialog):
* inspector/front-end/UIUtils.js:
(WebInspector._isTextEditingElement):
(WebInspector.setCurrentFocusElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Jan 2012 16:13:20 +0000 (16:13 +0000)]
[GTK] set audio resources path in NRTW
https://bugs.webkit.org/show_bug.cgi?id=76380
Reviewed by Martin Robinson.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
the uninstalled audio resources are used during webaudio tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Jan 2012 16:08:53 +0000 (16:08 +0000)]
Unreviewed, GTK rebaseline after r105061.
* platform/gtk/svg/carto.net/colourpicker-expected.txt:
* platform/gtk/svg/carto.net/combobox-expected.txt:
* platform/gtk/svg/carto.net/slider-expected.txt:
* platform/gtk/svg/carto.net/textbox-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Jan 2012 16:00:23 +0000 (16:00 +0000)]
Unreviewed, GTK baselines for new tests.
* platform/gtk/css2.1/
20110323/border-collapse-offset-002-expected.txt: Added.
* platform/gtk/css2.1/
20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/gtk/fast/borders/border-image-slice-constrained-expected.txt: Added.
* platform/gtk/fast/text/unicode-variation-selector-expected.txt: Added.
* platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/gtk/media/video-colorspace-yuv420-expected.txt: Added.
* platform/gtk/media/video-colorspace-yuv422-expected.txt: Added.
* platform/gtk/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
* platform/gtk/svg/filters/filter-refresh-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 14:28:27 +0000 (14:28 +0000)]
[Qt] Remove references to PagePointer in the FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=76342
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-16
Reviewed by Simon Hausmann.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createNetworkingContext):
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
* WebProcess/qt/QtNetworkAccessManager.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 16 Jan 2012 14:04:25 +0000 (14:04 +0000)]
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711
Reviewed by Zoltan Herczeg.
Source/WebCore:
Enable simple code path in SVGTextMetricsBuilder, allowing fast-measurement of simple text.
This affects the geometry of several <text> elements, thus several tests need rebaselining.
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
LayoutTests:
Update some test results after enabling the simple code path to measure SVG text.
* platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/textAnchor-expected.txt:
* platform/mac/svg/carto.net/window-expected.png:
* platform/mac/svg/carto.net/window-expected.txt:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.txt:
* platform/mac/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-detach-expected.txt:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
* platform/mac/svg/text/text-align-01-b-expected.png:
* platform/mac/svg/text/text-align-01-b-expected.txt:
* platform/mac/svg/text/text-align-02-b-expected.txt:
* platform/mac/svg/text/text-align-04-b-expected.txt:
* platform/mac/svg/text/text-align-06-b-expected.png:
* platform/mac/svg/text/text-align-06-b-expected.txt:
* platform/mac/svg/text/text-deco-01-b-expected.txt:
* platform/mac/svg/text/text-fonts-01-t-expected.txt:
* platform/mac/svg/text/text-spacing-01-b-expected.png:
* platform/mac/svg/text/text-text-04-t-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 13:44:14 +0000 (13:44 +0000)]
Web Inspector: CodeGeneratorInspector.py: generate array types.
https://bugs.webkit.org/show_bug.cgi?id=75284
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-16
Reviewed by Yury Semikhatsky.
New classes are generated for ecah array type instance. Some includes
and ifdefs are fixed.
* inspector/CodeGeneratorInspector.py:
(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.__init__):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.__init__):
(TypeData.get_binding):
* inspector/ConsoleMessage.cpp:
* inspector/InspectorValues.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 16 Jan 2012 13:40:04 +0000 (13:40 +0000)]
[GTK] Update NEWS and configure.ac for 1.7.4 release
https://bugs.webkit.org/show_bug.cgi?id=76375
Reviewed by Philippe Normand.
.:
* configure.ac: Bumped version number.
Source/WebKit/gtk:
* NEWS: Added release notes for 1.7.4.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 16 Jan 2012 13:35:04 +0000 (13:35 +0000)]
Web Inspector: editing body multiplies head
https://bugs.webkit.org/show_bug.cgi?id=62272
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-01-15
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/elements/set-outer-html-body.html
* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::insertBefore):
* inspector/DOMEditor.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
LayoutTests:
* inspector/elements/resources/set-outer-html-body-iframe.html: Added.
* inspector/elements/set-outer-html-body-expected.txt: Added.
* inspector/elements/set-outer-html-body.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 16 Jan 2012 13:08:29 +0000 (13:08 +0000)]
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711
Reviewed by Zoltan Herczeg.
Change the way we store x/y/dx/dy/rotate values for a <text> element and its ancestors.
SVGTextLayoutAttributesBuilder used to hold a Vector<float> for x/y/dx/dy/rotate, each as big
as the whole text subtree length. For each character, that has an absolute position, or rotation
the value was stored in this list. For all other characters a special empty value marker was stored.
This is highly inefficient, and is now replaced with a HashMap<unsigned, SVGCharacterData> where
SVGCharacterData is a struct, holding float x/y/dx/dy/rotate. The code is now optimized for the
common case, where only a few characters actually specify such values, eg:
<text x="50" y="90">looooong text<tspan x="50" y="30">abc</tspan></text>.
NOTE: There are still some inefficiencies in this patch (especially the copying of SVGTextLayoutAttributes).
To keep the patch size smaller, I decided to fix this in another patch, and only fix the memory issue with this patch.
This reduces the memory consumption from 35MB to 10MB on the attached testcase in bug 65711.
Doesn't affect any test, yet. A follow-up commit will enable the usage of the simple code path, using WidthIterator,
in SVGTextMetricsBuilder, which will result in several layout test changes, because of geometry changes.
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::RenderSVGInlineText):
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):
* rendering/svg/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::layoutAttributes):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::swapItemsInLayoutAttributes):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGTextLayoutAttributes.cpp:
(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::dumpSVGCharacterDataMapValue):
(WebCore::SVGTextLayoutAttributes::dump):
* rendering/svg/SVGTextLayoutAttributes.h:
(WebCore::SVGTextLayoutAttributes::characterDataMap):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
(WebCore::updateCharacterData):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
(WebCore::SVGTextLayoutAttributesBuilder::clearTextPositioningElements):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextLayoutEngine.h:
(WebCore::SVGTextLayoutEngine::layoutAttributes):
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 13:00:39 +0000 (13:00 +0000)]
CSSCanvasValue can't be renamed, enforce this at compile-time.
<http://webkit.org/b/76352>
Reviewed by Antti Koivisto.
Have the CSSCanvasValue constructor take the name as an argument instead of
having a setName() that's only called from one place in CSSParser.
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::create):
(WebCore::CSSCanvasValue::CSSCanvasValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCanvas):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 12:57:00 +0000 (12:57 +0000)]
CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
<http://webkit.org/b/76374>
Reviewed by Antti Koivisto.
Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".
* css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 16 Jan 2012 12:25:55 +0000 (12:25 +0000)]
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
* GNUmakefile.list.am: Fix typo.
Source/WebCore:
* GNUmakefile.list.am: Add missing files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 16 Jan 2012 12:19:41 +0000 (12:19 +0000)]
[GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
https://bugs.webkit.org/show_bug.cgi?id=76369
Reviewed by Xan Lopez.
If there's an installed version of webkit and there are new
symbols in the build tree, gtkdoc-scanobj fails due to undefined
references, because the env ldflags are given before the local
ones.
* gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Mon, 16 Jan 2012 12:05:03 +0000 (12:05 +0000)]
CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code
https://bugs.webkit.org/show_bug.cgi?id=76043
Re-use appendAuthorStylesheets() from within CSSStyleSelector constructor.
Reviewed by Antti Koivisto.
No new tests. (refactoring)
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/StyleSheetList.h:
(WebCore::StyleSheetList::vector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 11:32:40 +0000 (11:32 +0000)]
Unreviewed, rolling out r105040.
http://trac.webkit.org/changeset/105040
https://bugs.webkit.org/show_bug.cgi?id=76373
Breaks Win (dbg) canary builder (Requested by apavlov on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-16
* WebKit.gypi:
* tests/DispatchEventTest.cpp: Removed.
* tests/data/event_target.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 11:31:38 +0000 (11:31 +0000)]
[crash] Renderer crashes when spell checking a disabled input field.
https://bugs.webkit.org/show_bug.cgi?id=75941
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-16
Reviewed by Hajime Morita.
.:
* ManualTests/editing-disabled-node-replace-crash.html: Added.
Source/WebCore:
We confirm the selection is editable before replacing text.
Tests: ManualTests/editing-disabled-node-replace-crash.html
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 11:28:48 +0000 (11:28 +0000)]
Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
https://bugs.webkit.org/show_bug.cgi?id=75865
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.
Source/WebCore:
* WebCore.exp.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
* rendering/FilterEffectRenderer.cpp:
* svg/SVGElementInstance.idl:
Source/WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 11:09:00 +0000 (11:09 +0000)]
Compilation error on build-webkit --debug --no-request-animation-frame on mac.
https://bugs.webkit.org/show_bug.cgi?id=75875
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.
* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 16 Jan 2012 11:04:37 +0000 (11:04 +0000)]
[Chromium] Unreviewed, mark two inspector/debugger tests as SLOW on Linux Debug.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 16 Jan 2012 10:55:50 +0000 (10:55 +0000)]
[Chromium] Unreviewed, suppres webaudio/gain.html failures on Windows.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Jan 2012 10:51:33 +0000 (10:51 +0000)]
Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341
Unreviewed trivial buildfix/typo fix after r105043.
* inspector/front-end/WebKit.qrc:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 10:23:05 +0000 (10:23 +0000)]
Solaris Studio supports alignment macros too
https://bugs.webkit.org/show_bug.cgi?id=75453
Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-16
Reviewed by Hajime Morita.
* wtf/Alignment.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 16 Jan 2012 09:56:44 +0000 (09:56 +0000)]
Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341
Fixed dialog: in old implementation dialog never hides if you press mouse button
on Go button and release it somewhere else.
Dialog functionality extracted to be used for search dialog.
Reviewed by Pavel Feldman.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Dialog.js: Added.
(WebInspector.Dialog):
(WebInspector.Dialog.show):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._doFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.Dialog.prototype._onClick):
(WebInspector.DialogDelegate):
(WebInspector.DialogDelegate.prototype.get defaultFocusedElement):
(WebInspector.DialogDelegate.prototype.get okButton):
(WebInspector.DialogDelegate.prototype.onAction):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog._show):
(WebInspector.GoToLineDialog.prototype.get defaultFocusedElement):
(WebInspector.GoToLineDialog.prototype.get okButton):
(WebInspector.GoToLineDialog.prototype.onAction):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/dialog.css: Renamed from Source/WebCore/inspector/front-end/goToLineDialog.css.
(.dialog-glass-pane):
(.dialog):
(.dialog-contents):
(.go-to-line-dialog input):
(.go-to-line-dialog button):
(.go-to-line-dialog button:active):
* inspector/front-end/inspector.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Mon, 16 Jan 2012 09:41:59 +0000 (09:41 +0000)]
[EFL] Build fix when using pango as font backends.
https://bugs.webkit.org/show_bug.cgi?id=76368
Unreviewed build fix.
* ewk/ewk_view.cpp: include RefPtrCairo.h
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Mon, 16 Jan 2012 09:37:03 +0000 (09:37 +0000)]
ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350
Reviewed by Adam Barth.
Source/WebCore:
The CachedResourceLoader only keeps a raw pointer to a ScriptElement.
If an async ScriptElement is removed from the document before it is
executed, it might be garbage collected before the script is loaded, so
it's never run.
By making the ScriptRunner keep an explicit reference to the
ScriptElement while it's loading (as is done for sync ScriptElements),
we can guarantee that the ScriptElement lives until it is executed.
No more flaky timeouts: http/tests/misc/async-script.html:
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::~ScriptRunner):
(WebCore::ScriptRunner::queueScriptForExecution):
(WebCore::ScriptRunner::notifyScriptReady):
* dom/ScriptRunner.h:
(WebCore::ScriptRunner::hasPendingScripts):
LayoutTests:
* http/tests/misc/async-script.html:
* platform/qt/Skipped: unskip http/tests/misc/async-script.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 09:23:06 +0000 (09:23 +0000)]
Reland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id=72988
https://bugs.webkit.org/show_bug.cgi?id=73837
The original patch had a mistake that caused it to fail (not sure how I
missed that or why the bots didn't catch it).
Patch by Dave Michael <dmichael@chromium.org> on 2012-01-16
Reviewed by Hajime Morita.
* WebKit.gypi:
* tests/DispatchEventTest.cpp: Added.
(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::DispatchEventTest::createMessageEvent):
(WebKit::TEST_F):
* tests/data/event_target.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Mon, 16 Jan 2012 09:16:40 +0000 (09:16 +0000)]
Unreviewed build fix; added WebCore.exp.in changes lost in r105036.
* WebCore.exp.in:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Jan 2012 08:47:55 +0000 (08:47 +0000)]
ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350
* platform/qt/Skipped: Skip http/tests/misc/async-script.html until fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Mon, 16 Jan 2012 08:42:50 +0000 (08:42 +0000)]
Build fix on 32bit if verbose debug is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=76351
Reviewed by Hajime Morita.
Mostly change "%lu" to "%zu" to print a "size_t" variable.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jan 2012 07:33:31 +0000 (07:33 +0000)]
Add DeviceOrientationEvent.absolute
https://bugs.webkit.org/show_bug.cgi?id=51742
Patch by Xinchao He <xinchao.he@intel.com> on 2012-01-15
Reviewed by Darin Fisher.
This patch add the DeviceOrientationEvent.absolute to follow the
latest w3c device orientation event spec.
http://www.w3.org/TR/orientation-event/
Source/WebCore:
* bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
* dom/DeviceOrientation.cpp:
(WebCore::DeviceOrientation::create):
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::absolute):
(WebCore::DeviceOrientation::canProvideAbsolute):
* dom/DeviceOrientation.h:
* dom/DeviceOrientationEvent.idl:
Source/WebKit/chromium:
* public/WebDeviceOrientation.h:
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
* src/WebDeviceOrientation.cpp:
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
(WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 16 Jan 2012 04:03:47 +0000 (04:03 +0000)]
The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
https://bugs.webkit.org/show_bug.cgi?id=76355
Reviewed by Dan Bernstein.
Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers. This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions. I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has. Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code). Each of these except for JITCompiler can be reused for stub compilation.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGCCallHelpers.h: Added.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 16 Jan 2012 00:57:10 +0000 (00:57 +0000)]
Fix wrong bug URL in ChangeLog.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Sun, 15 Jan 2012 23:18:28 +0000 (23:18 +0000)]
Remove external references to CSSPrimitiveValue::UnitTypes enum.
https://bugs.webkit.org/show_bug.cgi?id=76229
Reviewed by Darin Adler.
No new tests / refactoring only.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::isCacheable):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isUnitTypeLength):
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isIdent):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isString):
(WebCore::CSSPrimitiveValue::isURI):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 15 Jan 2012 20:14:31 +0000 (20:14 +0000)]
Fix compilation errors on build-webkit --debug --no-video on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-15
Reviewed by Philippe Normand.
Source/JavaScriptCore:
Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.
* wtf/Platform.h:
Source/WebCore:
- Some exported HTMLMediaElement symbols were guarded by FULLSCREEN_API
feature instead of VIDEO.
- Unused parameter warning in CanvasRenderingContext::wouldTaintOrigin().
- RenderThemeMac::shouldShowPlaceholderWhenFocused() implementation
wrongly guarded by VIDEO feature.
* WebCore.exp.in:
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
* rendering/RenderThemeMac.mm:
Source/WebKit/mac:
- WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded
by VIDEO feature instead of FULLSCREEN_API.
- _isAnyMoviePlaying implementation depends on VIDEO.
* WebCoreSupport/WebChromeClient.h:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _isAnyMoviePlaying]):
Tools:
Add --[no-]video-track to build-webkit, since video track feature
depends on video.
* Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sun, 15 Jan 2012 19:42:47 +0000 (19:42 +0000)]
CSSParser: Fix failing assertion below BorderImageQuadParseContext.
<http://webkit.org/b/76343> and <rdar://problem/
10584969>
Reviewed by Antti Koivisto.
No longer asserts: fast/borders/inline-mask-overlay-image-outset-vertical-rl.html
* css/CSSParser.cpp:
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
Clone CSSValues by copying the RefPtrs instead of going through
the CSSValuePool's create-from-double factory. This prevents an
assertion when the incoming value is CSSValueAuto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 15 Jan 2012 17:17:36 +0000 (17:17 +0000)]
<embed> width and height properties propagate to parent object node
https://bugs.webkit.org/show_bug.cgi?id=17688
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html
WebKit seems to have inherited this behaviour from KHTML. When the width/height
of an <embed> element is set, it propagates the values up to any parent <object>
element. There doesn't seem to be any good reason for this and it is not consistent
with the behaviour of Firefox and Opera.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::attributeChanged): Removed
* html/HTMLEmbedElement.h:
(WebCore::HTMLEmbedElement::attributeChanged): Removed
LayoutTests:
* fast/dom/insertedIntoDocument-child-expected.txt:
* fast/dom/insertedIntoDocument-sibling-expected.txt:
These tests were added by http://trac.webkit.org/changeset/81611.
The fact that an <embed> element inserted into the document no longer passes its
height/width up to its parent object node seems to prevent the node getting removed
by a simple garbage collection now so the <embed> added by the test is still there at the end,
creating the trailing spaces. This is consistent with Opera's treatment of the test, FF is entirely
different - it doesn't add the embed node in the first place. So given that the purpose of the
test is to cause a crash (?), the change in result seems benign.
* fast/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt: Added.
* fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html: Added.
This tests that the width/height for an embed element does not get propagated to the parent object.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 15 Jan 2012 13:48:45 +0000 (13:48 +0000)]
compareBorders() is called too often during painting
https://bugs.webkit.org/show_bug.cgi?id=73349
Reviewed by Julien Chaffraix.
Collapsed borders are re-calculated every time they are painted.
This is unnecessary, they only change with the layout or style so calculate and
cache them whenever the layout or style changes and use the cached values when
painting. The cache is stored in the table section so that the memory footprint
of a table is only increased when it has collapsing borders.
The gain in performance here consists of skipping collapsed border computation
during painting. The only path that incurs a small performance penalty is the
additional get/set on the cache when a collapsed border is computed. This penalty only applies
during style change, layout, or when the width of the table is calculated. The computed
border value is not stored in the cache when it has been calculated without its color
for borderHalfStart and co., so that code path is unaffected by this change.
No new tests, covered by existing collapsed border tests.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::willBeDestroyed): remove entries from collapsed border cache
(WebCore::RenderTableCell::collapsedStartBorder):
Compute, and also cache if the full border including color was computed.
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder): ditto
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
Inline the function since it is only called in paintCollapsedBorders and remove
includeColor as a parameter. Move the call to the table's style to the caller rather
than call it 4 times in a row. Use the cached border values directly.
(WebCore::RenderTableCell::cachedCollapsedRightBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedTopBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedBottomBorder): ditto
(WebCore::RenderTableCell::paintCollapsedBorders):
This function always uses the collapsed border cache now.
* rendering/RenderTableCell.h:
Make the collapsed border functions private.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::removeCachedCollapsedBorders): The cache is deleted by the HashMap
since it is the only owner of the cached item.
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):
This will assert if there is no cached collapsed border for the side of the
cell requested by the caller.
* rendering/RenderTableSection.h:
HashMap wouldn't let me use CollapsedBorderSide in the key value for the cache
so use int instead.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 15 Jan 2012 03:14:07 +0000 (03:14 +0000)]
HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314
Reviewed by Sam Weinig.
Source/JavaScriptCore:
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
Source/WebCore:
No new functionality, so no new tests.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.
I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):
Source/WebKit/chromium:
* src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 15 Jan 2012 01:24:10 +0000 (01:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76339
Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.
Patch by Adam Treat <atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.
* platform/blackberry/LoggingBlackBerry.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 15 Jan 2012 00:31:23 +0000 (00:31 +0000)]
<rdar://problem/
10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298
Reviewed by Anders Carlsson.
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 14 Jan 2012 23:53:03 +0000 (23:53 +0000)]
Chromium results for test added by r105021
Unreviewed gardening.
* platform/chromium-linux/css2.1/
20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/outline-color-applies-to-008-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 14 Jan 2012 20:46:21 +0000 (20:46 +0000)]
Change expected failures from IMAGE+TEXT to TEXT on Mac.
The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.
Unreviewed gardening.
* platform/mac/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 14 Jan 2012 20:31:48 +0000 (20:31 +0000)]
Remove reference result added in r105021.
This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.
Unreviewed.
* css2.1/
20110323/outline-color-applies-to-008-expected.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Jan 2012 19:28:42 +0000 (19:28 +0000)]
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313
Patch by James Robinson <jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.
The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
* Scripts/run-chromium-webkit-unit-tests:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 14 Jan 2012 19:13:35 +0000 (19:13 +0000)]
CSS 2.1 failure: outline-color-applies-to* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71944
Reviewed by Julien Chaffraix.
Source/WebCore:
Paint the outline color for row, row-group, header-group and footer-group
elements.
Tests: css2.1/
20110323/outline-color-applies-to-001.htm
css2.1/
20110323/outline-color-applies-to-002.htm
css2.1/
20110323/outline-color-applies-to-003.htm
css2.1/
20110323/outline-color-applies-to-004.htm
css2.1/
20110323/outline-color-applies-to-005.htm
css2.1/
20110323/outline-color-applies-to-006.htm
css2.1/
20110323/outline-color-applies-to-007.htm
css2.1/
20110323/outline-color-applies-to-008.htm
css2.1/
20110323/outline-color-applies-to-009.htm
css2.1/
20110323/outline-color-applies-to-010.htm
(There is no outline-color-applies-to-011.htm in the test suite.)
css2.1/
20110323/outline-color-applies-to-012.htm
css2.1/
20110323/outline-color-applies-to-013.htm
css2.1/
20110323/outline-color-applies-to-014.htm
css2.1/
20110323/outline-color-applies-to-015.htm
fast/css/outline-color-self-painting-row.htm
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.
This is used by RenderTableSection::paintObject and RenderTableRow::paint
(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by
fast/css/outline-color-self-painting-row.htm.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.
LayoutTests:
* css2.1/
20110323/outline-color-applies-to-001-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-001.htm: Added.
* css2.1/
20110323/outline-color-applies-to-002-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-002.htm: Added.
* css2.1/
20110323/outline-color-applies-to-003-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-003.htm: Added.
* css2.1/
20110323/outline-color-applies-to-004-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-004.htm: Added.
* css2.1/
20110323/outline-color-applies-to-005-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-005.htm: Added.
* css2.1/
20110323/outline-color-applies-to-006-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-006.htm: Added.
* css2.1/
20110323/outline-color-applies-to-007-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-007.htm: Added.
* css2.1/
20110323/outline-color-applies-to-008-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-008.htm: Added.
* css2.1/
20110323/outline-color-applies-to-009-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-009.htm: Added.
* css2.1/
20110323/outline-color-applies-to-010-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-010.htm: Added.
* css2.1/
20110323/outline-color-applies-to-012-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-012.htm: Added.
* css2.1/
20110323/outline-color-applies-to-013-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-013.htm: Added.
* css2.1/
20110323/outline-color-applies-to-014-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-014.htm: Added.
* css2.1/
20110323/outline-color-applies-to-015-expected.html: Added.
* css2.1/
20110323/outline-color-applies-to-015.htm: Added.
* fast/css/outline-color-self-painting-row-expected.html: Added.
* fast/css/outline-color-self-painting-row.htm: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Sat, 14 Jan 2012 19:11:21 +0000 (19:11 +0000)]
[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327
Reviewed by Darin Fisher.
* public/WebWorker.h: Removed.
* src/WebWorkerClientImpl.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 14 Jan 2012 15:51:35 +0000 (15:51 +0000)]
Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
https://bugs.webkit.org/show_bug.cgi?id=76329
Source/WebCore:
Reviewed by Dan Bernstein.
When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
Reviewed by Dan Bernstein.
Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.
* ManualTests/filters/opacity-above-filter.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Jan 2012 13:43:37 +0000 (13:43 +0000)]
Unreviewed, rolling out r105017.
http://trac.webkit.org/changeset/105017
https://bugs.webkit.org/show_bug.cgi?id=76333
broke the build (Requested by philn-tp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-14
* gtk/jhbuild.modules:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Jan 2012 13:23:21 +0000 (13:23 +0000)]
[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.
* gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Sat, 14 Jan 2012 04:41:30 +0000 (04:41 +0000)]
Skip test that started failing after r105015.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Sat, 14 Jan 2012 03:03:08 +0000 (03:03 +0000)]
Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782
Reviewed by Tony Chang.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-expected.txt:
* css3/flexbox/flex-align.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
efidler@rim.com [Sat, 14 Jan 2012 02:47:27 +0000 (02:47 +0000)]
GCC compiler version is not detected properly for QNX qcc variant
https://bugs.webkit.org/show_bug.cgi?id=76288
Reviewed by Rob Buis.
Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).
* Source/cmake/WebKitHelpers.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Sat, 14 Jan 2012 01:13:35 +0000 (01:13 +0000)]
[Windows, WinCairo] Build correction after r104919.
* WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp
from the build, since it is built as part of DOMAllInOne.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Sat, 14 Jan 2012 00:28:26 +0000 (00:28 +0000)]
Pointer Lock: Change isLocked() from operator to attribute isLocked
https://bugs.webkit.org/show_bug.cgi?id=76311
Reviewed by Adam Barth.
Source/WebCore:
This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.
Test pointer-lock/pointer-lock-api.html updated to new spec.
* page/PointerLock.idl:
LayoutTests:
* pointer-lock/pointer-lock-api-expected.txt:
* pointer-lock/pointer-lock-api.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Sat, 14 Jan 2012 00:13:37 +0000 (00:13 +0000)]
Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
https://bugs.webkit.org/show_bug.cgi?id=57600
Reviewed by Adam Barth.
* http/tests/security/resources/cors-redirect.php: Added.
* http/tests/security/resources/empty.html: Added.
* http/tests/security/xhr-cors-redirect-expected.txt: Added.
* http/tests/security/xhr-cors-redirect.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc