Santiago Fernandez Madero [Fri, 6 Sep 2019 21:56:56 +0000 (14:56 -0700)]
Disable ToolboxBitmatAttribute test in netfx (dotnet/corefx#40901)
Commit migrated from https://github.com/dotnet/corefx/commit/
937e7d6d7eb6f1413aa48d14961d8f0c8a061e0e
Stephen Toub [Fri, 6 Sep 2019 19:45:09 +0000 (15:45 -0400)]
Fix Select.Count bug that iterates twice (dotnet/corefx#40718)
* Add System.Linq tests to validate enumerator lifecycle
* Fix bug with Select(...).Count() on an IPartition
It currently ends up potentially enumerating the source twice.
* Remove unnecessary source inputs in lifecycle tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8455fd2d9bd46fc8b97fe86f907d2a8ae748443f
Viktor Hofer [Fri, 6 Sep 2019 19:06:28 +0000 (21:06 +0200)]
Remove misleading test condition variable for registry (dotnet/corefx#40887)
Commit migrated from https://github.com/dotnet/corefx/commit/
d88152f91a5b08534873868afe93ddc3c840f76f
Viktor Hofer [Fri, 6 Sep 2019 19:04:52 +0000 (21:04 +0200)]
Disable two flaky EventLog tests (dotnet/corefx#40876)
Commit migrated from https://github.com/dotnet/corefx/commit/
9d5b200c6088d9dc038c64ec051596170731dbab
Stephen Toub [Fri, 6 Sep 2019 19:04:17 +0000 (15:04 -0400)]
Make "remote" more CultureInfo.CurrentCulture setting tests (dotnet/corefx#40891)
Commit migrated from https://github.com/dotnet/corefx/commit/
002d62b53343ae9b24310681c349913b97d30202
Viktor Hofer [Fri, 6 Sep 2019 16:42:03 +0000 (18:42 +0200)]
Disable two networking tests on UAP (dotnet/corefx#40875)
* Disable timeout sensitive networking test on UAP
Disabling GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream on UAP
* Update HttpClientHandlerTest.Cancellation.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
9161098ade5075a8c126b2d7eb98abbeadff2961
Stephen Toub [Fri, 6 Sep 2019 16:19:02 +0000 (12:19 -0400)]
Fix some low-hanging fruit boxing in JsonSerializer (dotnet/corefx#40867)
It's boxing lots of dictionary enumerators and KeyValuePairs. Stop doing that.
Commit migrated from https://github.com/dotnet/corefx/commit/
447f76f251d72a6d5e9bc102523937d05f929095
Michal Strehovský [Fri, 6 Sep 2019 15:51:56 +0000 (17:51 +0200)]
Add license header to S.R.CS.Unsafe (dotnet/corefx#40886)
Commit migrated from https://github.com/dotnet/corefx/commit/
b42c65ee76c35a63124a6b8e887bbd25c0d263df
Tomas Weinfurt [Fri, 6 Sep 2019 04:27:05 +0000 (21:27 -0700)]
use type for Http2LoopbackServer.CreateServer (dotnet/corefx#40863)
Commit migrated from https://github.com/dotnet/corefx/commit/
b46ebcb9a2408f9826c103ce6b340b419d948512
Tomas Weinfurt [Thu, 5 Sep 2019 23:49:16 +0000 (16:49 -0700)]
update SendAsync_ConcurentSendReceive_Ok to use DuplexContent (dotnet/corefx#40858)
Commit migrated from https://github.com/dotnet/corefx/commit/
88017f967529d30272ad75028e5538f35087e451
Steve Harter [Thu, 5 Sep 2019 22:45:41 +0000 (17:45 -0500)]
Address a couple non-functional nits (dotnet/corefx#40854)
Commit migrated from https://github.com/dotnet/corefx/commit/
4390a665c2fe082007f6bd25be0e055307ee5573
Stephen Toub [Thu, 5 Sep 2019 20:51:34 +0000 (16:51 -0400)]
Allow NetworkStream.WriteAsync calls to be canceled asynchronously (dotnet/corefx#40839)
In 3.0 we added the necessary support for this, and for Socket.WriteAsync calls we're appropriately passing the CancellationToken through, but we missed doing so for NetworkStream.WriteAsync, which takes a slightly different code path through AwaitableSocketAsyncEventArgs.
Commit migrated from https://github.com/dotnet/corefx/commit/
0a5b9286854c8bbb10677d730b0fe25425da562c
Jose Perez Rodriguez [Thu, 5 Sep 2019 18:57:18 +0000 (11:57 -0700)]
Update Stable Version info on package index (dotnet/corefx#40780)
* Upate Stable Version info on package index
* Re-adding back package version which was unlisted
Commit migrated from https://github.com/dotnet/corefx/commit/
95c10ccf3f17e35339070a5ecacdc44366585643
Hugh Bellamy [Thu, 5 Sep 2019 18:21:59 +0000 (19:21 +0100)]
Fix TypeConverter for IComponent (dotnet/corefx#40837)
Commit migrated from https://github.com/dotnet/corefx/commit/
3cc18081e24acdcfe7db737400a2dc702e314395
Adeel Mujahid [Thu, 5 Sep 2019 14:45:49 +0000 (17:45 +0300)]
Raise JsonException when PolicyProperty is null (dotnet/corefx#40501)
Commit migrated from https://github.com/dotnet/corefx/commit/
5dbbdfa0f924f02754a464d492a2116ad9f5752b
Steve Harter [Thu, 5 Sep 2019 14:41:47 +0000 (09:41 -0500)]
Use options.Encoder when serializing dictionary keys and property names (dotnet/corefx#40787)
Commit migrated from https://github.com/dotnet/corefx/commit/
7829d4acc8303a42e222415c7eb829fc3f8264cc
Carlos Sanchez Lopez [Thu, 5 Sep 2019 12:49:13 +0000 (05:49 -0700)]
Match src param name of BrotliEncoder.GetMaxCompressedLength to ref param name (dotnet/corefx#40822)
* Make the name of the parameter in the BrotliEncoder.GetMaxCompressedLength src match the name of the parameter in the ref.
* Update unit test validating parameter name.
Commit migrated from https://github.com/dotnet/corefx/commit/
c668e96cb0886d13a051d8021a3c3147e7daa15c
Cory Nelson [Thu, 5 Sep 2019 09:11:47 +0000 (02:11 -0700)]
Support PAC scripts that return multiple proxies (dotnet/corefx#40082)
* Support PAC scripts that return multiple proxies.
Resolves dotnet/corefx#39370
Commit migrated from https://github.com/dotnet/corefx/commit/
5e97c2b50ac2b18909606ce3ea14c3e7e61db7e8
Stephen Toub [Thu, 5 Sep 2019 01:03:34 +0000 (21:03 -0400)]
Reduce number of PFX loads in System.Net tests (dotnet/corefx#40821)
* Reduce number of PFX loads in System.Net tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
838832e2ecac9f81b5a5649bfac2fc835db76c1e
Wraith2 [Wed, 4 Sep 2019 23:52:07 +0000 (00:52 +0100)]
Fix | SqlClient fix for managed encryption connection failure (dotnet/corefx#40732)
Commit migrated from https://github.com/dotnet/corefx/commit/
30decee8aa72ce93eec0394e94f05a86cec7ab9d
Tomas Weinfurt [Wed, 4 Sep 2019 23:48:34 +0000 (16:48 -0700)]
fix more tests to work with http2 (dotnet/corefx#39019)
* fix cancelation tests to work with http2
* fix more tests and feedback from review
* feedback from review
* fix issues with missing connection: close
* update body check
* feedback from review
* fix resolve
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
5108d9245b891deeb36a164f434f4fb6975c8baf
Ahson Khan [Wed, 4 Sep 2019 23:01:41 +0000 (16:01 -0700)]
Add round-trip test to JsonSerializer with overflow that needs to be escaped. (dotnet/corefx#40793)
* Add round-trip test to JsonSerializer with overflow that needs to be
escaped.
* Used escaped property names and add a test for serializer/writer
interop.
Commit migrated from https://github.com/dotnet/corefx/commit/
76031d2f8ed714b54e0e7bbd7020f111b6c9c023
Stephen Toub [Wed, 4 Sep 2019 21:46:09 +0000 (17:46 -0400)]
Remove `readonly` from two `GCHandle` fields (dotnet/corefx#40807)
Due to the `readonly`, the mutations performed by `Free` will be done on a copy rather than on the data stored in the field.
Commit migrated from https://github.com/dotnet/corefx/commit/
437ce88edeb835e1dbe94c6d418b6169b69745fb
Stephen Toub [Wed, 4 Sep 2019 17:56:14 +0000 (13:56 -0400)]
Delete Box.cs from System.Threading.Tasks.Parallel (dotnet/corefx#40808)
We can just use `StrongBox<T>`.
Commit migrated from https://github.com/dotnet/corefx/commit/
0b572f1a7ec2f691a424d0c6dd403e11191ca8c5
Stephen Toub [Wed, 4 Sep 2019 16:24:03 +0000 (12:24 -0400)]
Remove reflection from ThreadPoolHelpers test class (dotnet/corefx#40810)
Commit migrated from https://github.com/dotnet/corefx/commit/
c9a124635dbfc0ec3958f06093cd5196b00b47b1
Stephen Toub [Wed, 4 Sep 2019 14:33:35 +0000 (10:33 -0400)]
Disable FileSystemWatcher_File_Create_ForceLoopRestart test (dotnet/corefx#40804)
Commit migrated from https://github.com/dotnet/corefx/commit/
aea8a56edf54228029b0f9ddf369e4d4f82f4446
Stephen Toub [Wed, 4 Sep 2019 14:33:13 +0000 (10:33 -0400)]
Move wildcard bind in Socket.ConnectAsync to be Windows-only (dotnet/corefx#40767)
* Move wildcard bind in Socket.ConnectAsync to be Windows-only
It's necessary to use ConnectEx; it's not necessary on Unix.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8a1fc9d6b3c9b85a881e220a9f9193b72c0e801b
Ahson Khan [Wed, 4 Sep 2019 05:24:28 +0000 (22:24 -0700)]
Fix the max token size threshold to correctly compute to 125MB for Base64 bytes. (dotnet/corefx#40792)
* Fix the max token size threshold to correctly compute to 125MB for
Base64 bytes.
* Rename constant to fix transpose error: Base46 -> Base64
* Enable the outerloop tests for windows and osx only and update to use
platform specific new line.
Commit migrated from https://github.com/dotnet/corefx/commit/
1511f723f7adfe82cef72460df45dc4422d303c6
Stephen Toub [Wed, 4 Sep 2019 04:04:25 +0000 (00:04 -0400)]
Disable XML crypto test failing on Windows 10 (dotnet/corefx#40775)
Commit migrated from https://github.com/dotnet/corefx/commit/
70b4d01e18236c925c2d44d49fff7cbb4919dc43
Stephen Toub [Wed, 4 Sep 2019 03:51:50 +0000 (23:51 -0400)]
Fix several recently added StyleCop tuple rules (dotnet/corefx#40794)
Commit migrated from https://github.com/dotnet/corefx/commit/
06007cdedee9cfb096d884016a99e3a64bdccb45
Liudmila Molkova [Wed, 4 Sep 2019 03:26:05 +0000 (20:26 -0700)]
DiagnosticSource Stop event was not reported in W3C mode by HttpHandlerDiagnosticListener on netfx (dotnet/corefx#40777)
Commit migrated from https://github.com/dotnet/corefx/commit/
687a84008e6c532584199305a75ec53e4e1f1c74
Tomas Weinfurt [Wed, 4 Sep 2019 02:34:24 +0000 (19:34 -0700)]
replace CRLF with Environment.NewLine where appropriate (dotnet/corefx#40723)
* replace CRLF with Environment.NewLine where appropriate
* use sb.AppendLine
* fix more unit tests
Commit migrated from https://github.com/dotnet/corefx/commit/
a6e7ffd72db078a46612afa9d085bd27ef8e2fed
Tomas Weinfurt [Wed, 4 Sep 2019 02:11:43 +0000 (19:11 -0700)]
surface _abortException (dotnet/corefx#40785)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc7e561e28839c56f7465f3382d5f60716a34bab
Ryan Lucia [Wed, 4 Sep 2019 02:05:17 +0000 (22:05 -0400)]
Add case-sensitive type lookup test to ActivatorTests (dotnet/corefx#40788)
Commit migrated from https://github.com/dotnet/corefx/commit/
ffe957980a1c33217d2fca68bb473029f37568e4
Jeremy Barton [Tue, 3 Sep 2019 22:59:24 +0000 (15:59 -0700)]
Fix JsonElement.WriteTo handling of escaped property names (dotnet/corefx#40784)
This removes the duplicate switch statement from writing properties,
as the usage of the new WritePropertyName API on the writer simplifies the logic here.
Commit migrated from https://github.com/dotnet/corefx/commit/
2d2abb32db879c877e14310c892faeeef756e27d
Cory Nelson [Tue, 3 Sep 2019 22:23:36 +0000 (15:23 -0700)]
Revert "set _requestQueueBoundHandle to null after disposing" (dotnet/corefx#40783)
* Revert "set _requestQueueBoundHandle to null after disposing (dotnet/corefx#40466)", but keep tests around (disabled re: 39552)
This reverts commit dotnet/corefx@
40949c48e1a24a735452248294c983609c77a26c.
Commit migrated from https://github.com/dotnet/corefx/commit/
7a668f4f13b962a20a4585fffadbf537d5ebf570
Stephen Toub [Tue, 3 Sep 2019 22:07:33 +0000 (18:07 -0400)]
Update analyzer versions (dotnet/corefx#40778)
In particular to pick up StyleCop fixes related to C# 8 and nullability.
Commit migrated from https://github.com/dotnet/corefx/commit/
1bf90840626cd2e7b19377bd6a16b17de0e6e672
Brian Robbins [Fri, 30 Aug 2019 23:31:37 +0000 (16:31 -0700)]
Add the DebuggableAttribute to System.Runtime.CompilerServices.Unsafe.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9c848d6ad5415c1fa844f5403ea8ef78c408f9a
Stephen Toub [Tue, 3 Sep 2019 19:24:08 +0000 (15:24 -0400)]
Pass a CancellationToken in a few more places (dotnet/corefx#40715)
Most of these to WaitAsync shouldn't actually matter, as the semaphores being used are there for corner cases or to protect erroneous usage, but if there's no contention, passing a token won't hurt, and if there is contention, passing the token makes it more robust.
Commit migrated from https://github.com/dotnet/corefx/commit/
14a7adb23569363b94d575d64b7cb1f38cda3e4a
Tom Deseyn [Tue, 3 Sep 2019 19:12:23 +0000 (21:12 +0200)]
Fix regression in TCPClient behavior when Disposed/Client set to null (dotnet/corefx#40769)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0a6f2b7b11afc2be10a535477910524d9fee834
Stephen Toub [Tue, 3 Sep 2019 15:21:35 +0000 (11:21 -0400)]
Disable a couple S.S.Cryptography.Algorithms tests deterministically failing locally
Commit migrated from https://github.com/dotnet/corefx/commit/
a533a0fad2c101881945824570dc21845783366a
Stephen Toub [Tue, 3 Sep 2019 09:39:43 +0000 (05:39 -0400)]
Disable RsaDecryptPkcs1LeadingZero test failing on some Windows (dotnet/corefx#40760)
Commit migrated from https://github.com/dotnet/corefx/commit/
5b2c6b7d286265d3bdaddb8445c1bbf3d9141461
Stephen Toub [Tue, 3 Sep 2019 01:59:05 +0000 (21:59 -0400)]
Consolidate / cleanup disposal checks in System.Net.Sockets (dotnet/corefx#40757)
Commit migrated from https://github.com/dotnet/corefx/commit/
b2412774416fc177cf5daa025bb4644a0a91c2df
Viktor Hofer [Tue, 3 Sep 2019 01:56:31 +0000 (03:56 +0200)]
Disable flaky PrintPage test (dotnet/corefx#40754)
Commit migrated from https://github.com/dotnet/corefx/commit/
b059630fc9139d0c940b2f0f249ff702a7b6250f
Viktor Hofer [Mon, 2 Sep 2019 20:48:05 +0000 (22:48 +0200)]
Retry eventlog deletion in tests on all platforms (dotnet/corefx#40743)
* Retry deleting eventlog on all platforms
* Remove OS differentiation
Commit migrated from https://github.com/dotnet/corefx/commit/
8c041484dda3059bd4adebebda939a15ee4a087d
Stephen Toub [Mon, 2 Sep 2019 15:05:50 +0000 (11:05 -0400)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
74708406b04b3d0946d53259ddbc93159ac90a24
Stephen Toub [Mon, 2 Sep 2019 14:22:58 +0000 (10:22 -0400)]
Delete duplicate line after LINQ nullable changes (dotnet/corefx#40746)
This line was moved into the ctor and should have been deleted from here, too. Addresses post-merge PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
71c669e918a5f4e48f09a697e9dd147f7dc31480
Viktor Hofer [Mon, 2 Sep 2019 11:58:38 +0000 (13:58 +0200)]
Disable TimerElapsedSignaled (dotnet/corefx#40742)
https://github.com/dotnet/corefx/issues/29166
Commit migrated from https://github.com/dotnet/corefx/commit/
a44c40809c43d29ab3d42d5e6a7d8ad1b65a4fe6
Viktor Hofer [Mon, 2 Sep 2019 07:55:24 +0000 (09:55 +0200)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
1d994feb73fcf57161e5bded92119c0d1b147616
Viktor Hofer [Mon, 2 Sep 2019 07:51:00 +0000 (09:51 +0200)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
49e2b4955ff83acc4b19b503709bd1e56f409871
Viktor Hofer [Sun, 1 Sep 2019 18:47:16 +0000 (20:47 +0200)]
Create pull-request-policy.md (dotnet/corefx#40701)
* Create pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Rename pull-request-validation.md to pull-request-policy.md
* Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
e2a3e98ee0ae608783906c3a352be27bf7e437b6
Next Turn [Sun, 1 Sep 2019 14:59:18 +0000 (22:59 +0800)]
Simplify BitArray enumerator (dotnet/corefx#40735)
Commit migrated from https://github.com/dotnet/corefx/commit/
130d8582e4973bbdb55ae737b942d214ad3c6570
Eric Erhardt [Sat, 31 Aug 2019 14:19:10 +0000 (09:19 -0500)]
Add tests for round trip serializing TimeZoneInfos. (dotnet/corefx#40637)
Fix dotnet/corefx#40578
Commit migrated from https://github.com/dotnet/corefx/commit/
75a591d4e5606c49f00e187ea2f5ba694d712523
Jose Perez Rodriguez [Sat, 31 Aug 2019 07:08:36 +0000 (00:08 -0700)]
Add harvest validation logic to the all configurations tests (dotnet/corefx#40717)
Commit migrated from https://github.com/dotnet/corefx/commit/
2c974d484209ab46815ec9abd35936ca66f2444e
Charles Stoner [Sat, 31 Aug 2019 01:38:32 +0000 (18:38 -0700)]
Skip tests on Arm (dotnet/corefx#40716)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1974096f6e02099a7e4d030ce0dd903574dd24e
Stephen Toub [Fri, 30 Aug 2019 22:10:37 +0000 (18:10 -0400)]
Annotate System.Threading.Channels for nullable reference types (dotnet/corefx#40653)
Commit migrated from https://github.com/dotnet/corefx/commit/
60e5e452977d0c51bd8c20e6c390f47333ad85b9
Tarek Mahmoud Sayed [Fri, 30 Aug 2019 21:56:24 +0000 (14:56 -0700)]
Tests for abbdrivated genitive month names parsing (dotnet/corefx#40595)
Commit migrated from https://github.com/dotnet/corefx/commit/
e62f9b61785a340a4a73182c2e228d6ef409dec4
Viktor Hofer [Fri, 30 Aug 2019 21:37:04 +0000 (23:37 +0200)]
Disable TestZeroTimeout hanging test (dotnet/corefx#40713)
In response to https://github.com/dotnet/corefx/issues/40711
Commit migrated from https://github.com/dotnet/corefx/commit/
5fef8a05c2ba51b614dbc2d5350fc3cc0e8541b4
Eirik Tsarpalis [Fri, 30 Aug 2019 21:14:49 +0000 (23:14 +0200)]
Httpstress: Add more checksum validations & expose Kestrel Http2 limits configuration (dotnet/corefx#40708)
Httpstress: Add more checksum validations & expose Kestrel Http2 limits configuration
Commit migrated from https://github.com/dotnet/corefx/commit/
a64e40535283d6470c2909c8f08b178454a8718b
Stephen Toub [Fri, 30 Aug 2019 20:49:29 +0000 (16:49 -0400)]
Annotate System.Linq for nullable reference types (dotnet/corefx#40651)
Commit migrated from https://github.com/dotnet/corefx/commit/
fe969a5893b845c0ba4550d828894c49745f456f
Benjamin Bartels [Fri, 30 Aug 2019 20:48:45 +0000 (21:48 +0100)]
Fixed missing Dispose call on Union on empty enumerable (dotnet/corefx#40384)
Commit migrated from https://github.com/dotnet/corefx/commit/
e78caf82ce13b6e1d1359cc239bf0535943cc386
Stephen Toub [Fri, 30 Aug 2019 19:23:38 +0000 (15:23 -0400)]
Annotate Microsoft.Win32.Primitives for nullable reference types (dotnet/corefx#40652)
Commit migrated from https://github.com/dotnet/corefx/commit/
70d2b62dcfd328228f8ea6754faae0ed3b69ff37
Stephen Toub [Fri, 30 Aug 2019 18:44:22 +0000 (14:44 -0400)]
Test for ArrayPool.Create allocating cleared arrays (dotnet/corefx#40592)
Commit migrated from https://github.com/dotnet/corefx/commit/
eeca0c2c0876919a9029cfdc371070bba84da02b
Jan Kotas [Fri, 30 Aug 2019 15:36:01 +0000 (08:36 -0700)]
Tests for Read_CharArrayTest reading more than necessary (dotnet/corefx#40521)
* Tests for Read_CharArrayTest reading more than necessary
* Update src/System.IO/tests/BinaryReader/BinaryReaderTests.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
a192823a84145546be747cc520625062fe6cb5a8
Viktor Hofer [Fri, 30 Aug 2019 14:55:22 +0000 (16:55 +0200)]
Limit precision checks in arm/64 (dotnet/corefx#40696)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e01a780a8a5bc61332c8d743e8516c15bbbb293
Ben Adams [Fri, 30 Aug 2019 13:32:32 +0000 (14:32 +0100)]
Net.Http Use span.SequenceEqual rather than custom EqualsOrdinal (dotnet/corefx#40694)
* Net.Http Use span.SequenceEqual rather than custom EqualsOrdinal
* Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
d3cd1d05357d3c5f756a89d9800af6ef91dd8efe
Viktor Hofer [Fri, 30 Aug 2019 13:31:38 +0000 (15:31 +0200)]
Ignore casing in servicename tests on nano server (dotnet/corefx#40699)
Commit migrated from https://github.com/dotnet/corefx/commit/
0c650b2765f64186f2fe84e332d8a74108866db2
Viktor Hofer [Fri, 30 Aug 2019 08:34:54 +0000 (10:34 +0200)]
Update pullrequest-builds.md
Commit migrated from https://github.com/dotnet/corefx/commit/
261b2cdc260bc94967a8af6666831739d91ceb96
Viktor Hofer [Fri, 30 Aug 2019 02:07:36 +0000 (04:07 +0200)]
Disable EventLog failing test on Windows (dotnet/corefx#40688)
Relates to dotnet/corefx#40224
Commit migrated from https://github.com/dotnet/corefx/commit/
ae0d0cb852a6186ca5ef8130b0bf862314485017
Viktor Hofer [Fri, 30 Aug 2019 02:07:11 +0000 (04:07 +0200)]
Disable two flaky tests Mutex/Netw (dotnet/corefx#40689)
Commit migrated from https://github.com/dotnet/corefx/commit/
3ef9df83a04113947c42d69cef4b7aadedd612c6
Steve Harter [Thu, 29 Aug 2019 22:18:38 +0000 (17:18 -0500)]
Deserialize extension data properly for child objects (dotnet/corefx#40662)
Commit migrated from https://github.com/dotnet/corefx/commit/
26782185622fde9ba354a3decd42f9a0a1a1a266
Viktor Hofer [Thu, 29 Aug 2019 21:39:44 +0000 (23:39 +0200)]
Enable macOS10.14 in PR builds (dotnet/corefx#40684)
Commit migrated from https://github.com/dotnet/corefx/commit/
7e5791b9fb20e29b5fbf8d89ff2688663ae9310a
Tom Deseyn [Thu, 29 Aug 2019 20:59:32 +0000 (22:59 +0200)]
SmtpClient: fix Timeout for low values (dotnet/corefx#37462)
* SmtpClient: fix Timeout for low values
The timeout is triggered from a Timer.
There were two race conditions:
- The timer event could occur before there was a connection to abort.
- The connection abort performs a TcpClient.Dispose, which may not
work when there is a TcpClient.Connect occurring simultaneously.
* TCPClient: make Dispose thread-safe
* Fix NullReferenceException from _networkstream.Close
* SmtpTransport: fix racy aborted detection
* TestZeroTimeout: skip on .NET Framework
* PR feedback
* Don't null out socket on Dispose to let ODE propagate from Socket
* Fix merge
* Run TestZeroTimeout test on Linux too
* Add back ODE to TcpClient.Connect(IPEndPoint)
* Add comment about why we're disposing the socket
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
807a18da803b09cdca42bfb7d05652b843f5079b
Steve Harter [Thu, 29 Aug 2019 20:02:09 +0000 (15:02 -0500)]
Add custom enum converter test for having flags as array (dotnet/corefx#40678)
Commit migrated from https://github.com/dotnet/corefx/commit/
e3644c538ab5dad6c19c6a7c975df0b160823875
Anirudh Agnihotry [Thu, 29 Aug 2019 17:46:09 +0000 (10:46 -0700)]
changing netcoreapp targetframework from 3.0 to 5.0 and adding support for targetgroup = netcoreapp5.0 (dotnet/corefx#40049)
* adding 5.0 target moniker
* Restoring packages for netcoreapp3.0
* package config for crypto done
* Drawing.Common and System.Windows.Extensions done
* some left over crypto and some smaller other libraries
* security.permissions, WindowsRuntime, WindowsRuntime.Xaml done
* experimental projects and openssl cryptography
* harvesting the runtime package version for windows Runtime
* update VS configurations
* reverting the shared framework package
* some remaining projects
* Using sdk to restore package and targetFrameowrk for netcoreapp3.0
* removing harvesting and using ReferenceFromRuntime for windowsRuntime project
* For oob packages with no pkg folder
* addresses feedback
* addresses the feedback
* reverting a commit with extra packageconfig additions
* System.text.Encoding.Web configurations edited
Commit migrated from https://github.com/dotnet/corefx/commit/
777dbdec193fcbe49b3f18614348ac96f77d57c3
Layomi Akinrinade [Thu, 29 Aug 2019 15:08:43 +0000 (11:08 -0400)]
Improve JsonSerializer support for derived types (dotnet/corefx#40654)
Commit migrated from https://github.com/dotnet/corefx/commit/
c59f5bf9badcda76581cd56cbfc5507f29fb022c
Steve Harter [Wed, 28 Aug 2019 22:46:55 +0000 (17:46 -0500)]
Fix additional issue of dictionary properties being skipped (dotnet/corefx#40629)
Commit migrated from https://github.com/dotnet/corefx/commit/
546fdc4198bdfd89504c8895c1bd608b4e92d80d
Cory Nelson [Wed, 28 Aug 2019 20:11:02 +0000 (13:11 -0700)]
Fix HashSet.SetCapacity() that increases capacity failing after a successful Remove(). (dotnet/corefx#40638)
Fix HashSet.SetCapacity() not accounting for freelist when increasing capacity.
Resolves dotnet/corefx#40621
Commit migrated from https://github.com/dotnet/corefx/commit/
2d6fe6b5cc3adba461bb8737c7e5c947992d4c7a
Jose Perez Rodriguez [Tue, 27 Aug 2019 23:06:07 +0000 (16:06 -0700)]
Calculate Harvest packages during build instead of using checked-in source (dotnet/corefx#40548)
* Calculate Harvest packages during build instead of using checked-in source
* Add ability to override the calculated package references and versions
* Switch to use PackageDownload instead of PackageReference
Commit migrated from https://github.com/dotnet/corefx/commit/
fde678cf14cf1a8e76fe8b6d384d2110f49d253d
Tom Deseyn [Tue, 27 Aug 2019 19:17:09 +0000 (21:17 +0200)]
Reconfigure terminal for Console usage even if only one of stdin/stdout was used by the child (dotnet/corefx#40563)
* Process: Unix: ensure we reconfigure the terminal for Console usage if only one of stdin/stdout was used by the child.
Console: Unix: Fix cache check for VTIME (read timeout).
Fixes https://github.com/dotnet/corefx/issues/40557
* Also consider not redirecting stderr as terminal usage
Commit migrated from https://github.com/dotnet/corefx/commit/
4b35a6fe24aed9ba44ef2534bd32b7a1e0bb7841
Charles Stoner [Tue, 27 Aug 2019 18:17:58 +0000 (11:17 -0700)]
Port remaining members of ErrObject, Interaction, SpecialDirectories (dotnet/corefx#40365)
Commit migrated from https://github.com/dotnet/corefx/commit/
063568705557b469606eef1069946484d78034ae
madmir [Tue, 27 Aug 2019 17:58:00 +0000 (19:58 +0200)]
Remove Uri.IdnScope and perform cleanup (dotnet/corefx#40546)
Commit migrated from https://github.com/dotnet/corefx/commit/
9630ecefc14671d26b2426e9bc76b8178dd3dd75
Jan Vorlicek [Tue, 27 Aug 2019 16:36:07 +0000 (18:36 +0200)]
Remove useless GdiPlus cleanup (dotnet/corefx#40617)
Part of the cleanup was not compiled in and the rest didn't have any
effect.
Commit migrated from https://github.com/dotnet/corefx/commit/
619f73197f28cc998265340c817cbbaa12d165c7
Stephen Toub [Tue, 27 Aug 2019 16:35:52 +0000 (12:35 -0400)]
Remove stray "#nullable enable" from Pkcs (dotnet/corefx#40622)
This assembly hasn't been reviewed yet for nullability annotations. We don't want to be mislead by this one file saying it has been.
Commit migrated from https://github.com/dotnet/corefx/commit/
c46bd6c33f4c6ad0303d64522bb1f02c6dc5b64c
Steve Harter [Tue, 27 Aug 2019 16:06:59 +0000 (11:06 -0500)]
Add additional skip tests and prevent reset of property index for perf (dotnet/corefx#40598)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cc4a04ed3bb9319ec2d80c186a22da3803fda23
David Cantu [Tue, 27 Aug 2019 06:11:59 +0000 (23:11 -0700)]
Change exception message when reading numbers with leading zeros (dotnet/corefx#40520)
* Change exception message when reading numbers with leading zeroes such as octals.
* Modified exception message and added condition to only throw it when an actual number is being read.
* Addressing suggestions.
* Narrowing scope to ConsumeZero and ConsumeZeroMultiSegment methods only.
* Addressing suggestion to use JsonHelpers.IsInRangeInclusive
Commit migrated from https://github.com/dotnet/corefx/commit/
7055b496a30dfe0f66a2f555cad31502473d144b
Stephen Toub [Tue, 27 Aug 2019 00:47:04 +0000 (20:47 -0400)]
Fix PLINQ outerloop tests (dotnet/corefx#40589)
* Revert dotnet/corefx#40415's changes to PLINQ tests
They broke outerloop significantly.
* Fix MemberData(BinaryOperations) usage in PLINQ
Lots of outerloop tests are failing because xunit is preferring the wrong overload of the BinaryOperations method via reflection. This just renames some of the methods to avoid the overloads.
Commit migrated from https://github.com/dotnet/corefx/commit/
8429c2a5cc01ac07122f4439f360f8ab2ca4ae86
Stephen Toub [Mon, 26 Aug 2019 23:47:48 +0000 (19:47 -0400)]
Re-enable XML theories with English-only variants (dotnet/corefx#39607)
* Re-enable XML theories with English-only variants
* Disable more XML tests on non-English systems
It turns out a bunch of these tests are comparing error strings against hardcoded English text as to what the expected error message will be.
Commit migrated from https://github.com/dotnet/corefx/commit/
a6059cdc54865304d1cb76b514096cadddda486f
Katarzyna Bułat [Mon, 26 Aug 2019 22:51:04 +0000 (15:51 -0700)]
JsonArray and transformations API implementation (dotnet/corefx#40469)
* JsonArray added
* Transformations API added
* Review Comments included
Commit migrated from https://github.com/dotnet/corefx/commit/
ad4fdd9cd3d99d0240fa53b9b7bdc23bb7a3f4a8
Mikel Blanchard [Mon, 26 Aug 2019 21:04:49 +0000 (14:04 -0700)]
Fix issue causing subsequent properties to be skipped during deserialization once a dictionary has been skipped (dotnet/corefx#40490)
Commit migrated from https://github.com/dotnet/corefx/commit/
fb30a2d1a2bffbba2c039fd294c471962576a2d7
Steve Harter [Mon, 26 Aug 2019 20:58:46 +0000 (15:58 -0500)]
Allow PathAssemblyResolver to use an assembly with different PublicKeyToken if reference is Retargetable (dotnet/corefx#40581)
Commit migrated from https://github.com/dotnet/corefx/commit/
fca60323d9606a90b327273d08089200ae6f527b
Aashik Nagadikeri Harish [Mon, 26 Aug 2019 20:17:19 +0000 (13:17 -0700)]
System.Numeric.Tests tests now have unique inputs (dotnet/corefx#40564)
Matrix add, subtract and multiplication tests now have unique inputs
Commit migrated from https://github.com/dotnet/corefx/commit/
cadc61e7696ceaab416db7f2132db55acfe7c48c
Hugh Bellamy [Mon, 26 Aug 2019 19:52:45 +0000 (21:52 +0200)]
Move ReferenceConverter to the new test base and add ComponentConverter tests (dotnet/corefx#38981)
Commit migrated from https://github.com/dotnet/corefx/commit/
8038032294f7a43b5b23bf84d1b0b7cf2d692768
Tomas Weinfurt [Mon, 26 Aug 2019 19:22:44 +0000 (12:22 -0700)]
detect libinotify on FreeBSD (dotnet/corefx#40202)
Commit migrated from https://github.com/dotnet/corefx/commit/
29e4b76150ace52cb7ccec2ab880fbf23f2dfab3
Stephen Toub [Mon, 26 Aug 2019 18:41:59 +0000 (14:41 -0400)]
Remove a few allocations (dotnet/corefx#40580)
Commit migrated from https://github.com/dotnet/corefx/commit/
0f7b2968f098f1231993b4e0751026884659b193
Levi Broderick [Mon, 26 Aug 2019 18:03:21 +0000 (11:03 -0700)]
Add more span-based Vector<T> ctors and CopyTo tests (dotnet/corefx#36136)
Commit migrated from https://github.com/dotnet/corefx/commit/
53edc76f126940875d6ea11ede1f6a00e4a4ce5b
Jeremy Barton [Mon, 26 Aug 2019 17:46:33 +0000 (10:46 -0700)]
Clean up JsonElementWriteTests (dotnet/corefx#40468)
* Make JsonElementWriteTests and JsonDocumentWriteTests share drivers
* Fix the casing of all escaped values in these tests (reducing the need for normalization)
* Hard-code the correct answer for a test that used NewtonSoft.Json to dynamically compute the same answer every run
* Make two async tests declare async, and await the async part.
As a followup the JsonElementWriteTests / JsonDocumentWriteTests / JsonReadonlyDomWriteTests classes can be split to multiple files, but in this PR it keeps the edits reduced to only the semantic changes (inheritance).
Commit migrated from https://github.com/dotnet/corefx/commit/
95d012c8bb53bcbc0ba2b024342c114b9105b26b
Next Turn [Mon, 26 Aug 2019 17:12:06 +0000 (01:12 +0800)]
Add tests for Encoding virtual methods (dotnet/corefx#40528)
* Add tests for Encoding virtual methods
* Update CustomEncoding
Commit migrated from https://github.com/dotnet/corefx/commit/
04b70f289b2840926fe84f7512f96650de8c780b
Tomas Weinfurt [Mon, 26 Aug 2019 16:33:44 +0000 (09:33 -0700)]
set _requestQueueBoundHandle to null after disposing (dotnet/corefx#40466)
* set _requestQueueBoundHandle to null after disposing
* remove extra spaces
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
40949c48e1a24a735452248294c983609c77a26c
Stephen Toub [Sat, 24 Aug 2019 02:24:14 +0000 (22:24 -0400)]
Contribute to IDE0055 (fix formatting)
Commit migrated from https://github.com/dotnet/corefx/commit/
b49a8a9be1d53cd9e50cb68fd8540be25c65d433