Jean-Philippe Andre [Thu, 30 Nov 2017 02:03:49 +0000 (11:03 +0900)]
evas: Animation is a property not method set+get
Jean-Philippe Andre [Wed, 29 Nov 2017 11:20:49 +0000 (20:20 +0900)]
eolian: Warn less on duplicate beta APIs
The check was only done on one of the two functions, resulting in some
unwanted warnings.
EOLIAN_WARN_FUNC_DUPLICATES=1 will show non-beta warnings.
EOLIAN_WARN_FUNC_DUPLICATES=2 will still show all warnings.
Jean-Philippe Andre [Wed, 29 Nov 2017 11:03:16 +0000 (20:03 +0900)]
efl: Introduce interface Efl.Dup
A few classes allow their objects to be duplicated, so they should all
use the same interface.
Also, rename VG's dup to copy_from as it's not conforming to the
definition of dup.
Jean-Philippe Andre [Wed, 29 Nov 2017 08:59:34 +0000 (17:59 +0900)]
evas: Implement scale API in proper EO fashion
This removes the internal function pointer for scale_update. This makes
all relevant classes implement the scale API in EO.
This removes the duplicate function in Efl.Canvas.Object and only uses
the one from Efl.Ui.Base interface.
This *seems* to be working as expected. Fingers crossed!
PS: I don't like the name Efl.Ui.Base. It's an interface for a few
common API's between Gfx, Canvas and UI levels... Maybe scale simply
doesn't belong there.
Jean-Philippe Andre [Wed, 29 Nov 2017 08:35:43 +0000 (17:35 +0900)]
edje: Move perspective to legacy
Note: Edje.Perspective is not bound to EO, and this is the only reason
why I'm moving this to legacy only. Marking as beta would mean the
legacy APIs would not be generated, so that would have almost the same
effect as moving to legacy.
It would be nice to actually support this in EO, though this seems like
a rarely used feature.
Ref T5315
Andy Williams [Wed, 29 Nov 2017 17:37:21 +0000 (17:37 +0000)]
elm_code: If showing line numbers don't resize at 10 lines.
Content will still shift at 100 but that should be less intrusive
Andy Williams [Wed, 29 Nov 2017 16:10:28 +0000 (16:10 +0000)]
elm_code: Don't bold beginnings of lines
Fixes T6444
Amitesh Singh [Wed, 29 Nov 2017 10:46:04 +0000 (19:46 +0900)]
focus: fix build break after previous commit.
Amitesh Singh [Wed, 29 Nov 2017 08:39:42 +0000 (17:39 +0900)]
focus: remove focus.get{} from widget.eo
This is taking care by focus manager now.
Jean-Philippe Andre [Wed, 29 Nov 2017 06:34:52 +0000 (15:34 +0900)]
edje: Move text_change_cb to legacy only
This should probably be replaced by a well defined signal.
Note: If edje sends signals on swallow/unswallow and text set/unset we
could simplify some of the elementary code, eg. for button's icon
handling. The theme should be handling the padding automatically, it's
not the elementary widget's role
Ref T5315
Jean-Philippe Andre [Wed, 29 Nov 2017 04:45:58 +0000 (13:45 +0900)]
edje: Move "preload" to legacy only
EO file API is still in flux, especially wrt. async loading. Let's just
keep this in legacy for now.
A few more patches and Edje.Object will reach its final form.
Ref T5315
Jean-Philippe Andre [Wed, 29 Nov 2017 03:05:10 +0000 (12:05 +0900)]
edje: Implement Efl.File.load_error
Don't create a new function with the same name, it's absurd.
Jaehyun Cho [Wed, 29 Nov 2017 04:43:21 +0000 (13:43 +0900)]
elm_part_helper: Change macro name for default content part
Yeongjong Lee [Wed, 29 Nov 2017 02:48:21 +0000 (11:48 +0900)]
evas: Remove duplicated code
Reviewers: raster, cedric
Reviewed By: raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5552
Jean-Philippe Andre [Wed, 29 Nov 2017 02:47:43 +0000 (11:47 +0900)]
test: Adjust eo flag for popup test cases
Chris Michael [Tue, 28 Nov 2017 16:42:01 +0000 (11:42 -0500)]
elementary: Remove set but unused variables
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Woochan Lee [Tue, 28 Nov 2017 11:03:06 +0000 (20:03 +0900)]
efl_ui_spin: Support value change using mouse wheel.
Summary:
Enable value change using wheel.
(Up, Down key value change will be supported after D4933 dicussing.)
Test Plan: elementary_test efl_ui_spin test sample.
Reviewers: Jaehyun_Cho, jpeg, woohyun
Reviewed By: Jaehyun_Cho
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5546
Woochan Lee [Tue, 28 Nov 2017 11:02:53 +0000 (20:02 +0900)]
test_part_bg: Clean up code.
Summary:
Add spin class in ther test list.
Clean up code.
Reviewers: Jaehyun_Cho, jpeg, taxi2se
Reviewed By: Jaehyun_Cho
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5545
Jaehyun Cho [Mon, 27 Nov 2017 09:50:11 +0000 (18:50 +0900)]
efl_ui_popup: Replace Efl.Container to Efl.Content to rebase
Jaehyun Cho [Mon, 27 Nov 2017 06:31:37 +0000 (15:31 +0900)]
efl_ui_popup_alert: Remove expandable property for now
It needs more time to stabilize expandable property.
So the expandable property is removed for now.
The expandable property will be added later.
Jaehyun Cho [Wed, 15 Nov 2017 12:16:22 +0000 (21:16 +0900)]
examples: Add popup cxx example
Jaehyun Cho [Fri, 10 Nov 2017 08:56:34 +0000 (17:56 +0900)]
efl_ui_popup: Make backwall efl part object of Efl.Ui.Popup
Jaehyun Cho [Mon, 30 Oct 2017 11:34:42 +0000 (20:34 +0900)]
efl_ui_popup: Rename bg_set with backwall_set
Since "background" is used as a basic part property, "backwall" is used
to indicate the area behind efl_ui_popup.
Jaehyun Cho [Mon, 30 Oct 2017 11:03:01 +0000 (20:03 +0900)]
test_ui_popup: Move code for Efl.Ui.Popup classes from test_popup
Code refactoring to replace legacy APIs and move test code for
Efl.Ui.Popup and its sub classes from test_popup to test_ui_popup.
Taehyub Kim [Fri, 27 Oct 2017 09:11:58 +0000 (18:11 +0900)]
test_popup: modify Efl.Ui.Popup Sample Code
Summary: make Efl.Ui.Popup sample codes simpler
Test Plan:
1. run elementary_test -to efluipopup
2. test various options of efluipopup by clicking each button
Reviewers: Jaehyun_Cho, Blackmole, jpeg, cedric, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5366
Taehyub Kim [Thu, 26 Oct 2017 07:33:31 +0000 (16:33 +0900)]
efl_ui_popup: add _calc_align function in sizing eval function
Summary: add _calc_align function in sizing eval function to show popup correctly.
Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5373
Taehyub Kim [Thu, 26 Oct 2017 07:32:58 +0000 (16:32 +0900)]
efl_ui_popup: add timeout signal
Summary: add the timeout signal for user notification
Reviewers: Jaehyun_Cho, jpeg, cedric, Blackmole, thiepha, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5372
Jaehyun Cho [Tue, 24 Oct 2017 13:30:49 +0000 (22:30 +0900)]
efl_ui_popup_alert: Define Clicked_Event structure
Jaehyun Cho [Tue, 24 Oct 2017 12:29:15 +0000 (21:29 +0900)]
efl_ui_popup: Replace group_add/del with constructor/destructor
Jaehyun Cho [Tue, 24 Oct 2017 09:34:36 +0000 (18:34 +0900)]
efl_ui_popup: Code refactoring to replace legacy APIs
JinYong Park [Tue, 24 Oct 2017 11:13:21 +0000 (20:13 +0900)]
efl_ui_popup: remove parent_window_get method
Summary: remove Efl.Ui.Popup's internal method "parent_window_get"
Test Plan: elementary_test -to efluipopup
Reviewers: jpeg, Jaehyun_Cho, woohyun, herb
Reviewed By: Jaehyun_Cho
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5363
JinYong Park [Tue, 24 Oct 2017 11:13:04 +0000 (20:13 +0900)]
efl_ui_popup: replace title_set to efl_text_set with efl_part
Summary: Replace Efl.Ui.Popup.Alert's title set method to using efl_text_set with efl_part
Test Plan: elementary_test -to efluipopupalert
Reviewers: jpeg, Jaehyun_Cho, woohyun, herb
Reviewed By: Jaehyun_Cho
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5359
Jaehyun Cho [Tue, 24 Oct 2017 03:20:53 +0000 (12:20 +0900)]
test_popup: Fix Efl Ui Popup Anchor test title
Taehyub Kim [Thu, 21 Sep 2017 08:21:18 +0000 (17:21 +0900)]
efl_ui_popup: add timeout property
Summary: add timeout property
Test Plan:
1. run elementary_test -to efluipopup
2. after 3 seconds, popup will be delete
Reviewers: Jaehyun_Cho, jpeg, woohyun, thiepha, Blackmole, cedric
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5205
JinYong Park [Wed, 20 Sep 2017 10:36:39 +0000 (19:36 +0900)]
efl_ui_popup_anchor: add Efl.Ui.Popup.Anchor class
Summary:
Add initial code for Efl.Ui.Popup.Anchor class.
It supports adding anchor object to popup.
Test Plan: 1. run elementary_test -to efluipopupanchor
Reviewers: Jaehyun_Cho, thiepha, herb, jpeg, cedric, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5126
JinYong Park [Tue, 19 Sep 2017 07:23:43 +0000 (16:23 +0900)]
efl_ui_popup: remove unnecessary function call
Summary:
In _calc_align function, it could get align property through Efl_Ui_Popup_Data *pd directly,
but call align_get function previously.
Reviewers: Jaehyun_Cho, herb, thiepha, jpeg, cedric, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5207
Taehyub Kim [Tue, 19 Sep 2017 00:36:26 +0000 (09:36 +0900)]
efl_ui_popup_alert_scroll: check sizing evaluation while scroller is changed
Summary: add a sizing check variable for safety of sizing evaluation when the min size of scroller is changed.
Test Plan:
1. run elementary_test
2. search the sample with "popup" keyword
3. click the Efl Ui Popup Alert Scroll sample
Reviewers: Jaehyun_Cho, jpeg, woohyun, thiepha, Blackmole, cedric
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5204
JinYong Park [Wed, 6 Sep 2017 02:09:08 +0000 (11:09 +0900)]
efl_ui_popup: remove efl_ui_popup_position_set
Summary:
Remove efl_ui_popup_position_set.
Its functionality is replaced with efl_gfx_position_set.
Test Plan:
1. elementary_test -to efluipopup
Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, jpeg, cedric
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5129
JinYong Park [Thu, 31 Aug 2017 06:21:04 +0000 (15:21 +0900)]
efl_ui_popup: use efl_data_scope_get instead of using 'self' object
Summary:
Use efl_data_scope_get to get Efl_Ui_Popup_Data structure.
There is no reason using "self" object in Efl_Ui_Popup_Data.
Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D5128
Taehyub Kim [Thu, 31 Aug 2017 04:20:05 +0000 (13:20 +0900)]
efl_ui_popup_alert_text: add Efl.Ui.Popup.Alert.Text Class
Summary:
Add initial code for Efl.Ui.Popup.Alert.Text Class.
It supports setting texts on the content area.
Test Plan: 1. run elementary_text -to efluipopupalerttext
Reviewers: Jaehyun_Cho, jpeg, thiepha, cedric, woohyun, Blackmole
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5124
Taehyub Kim [Thu, 31 Aug 2017 04:18:45 +0000 (13:18 +0900)]
efl_ui_popup_alert_scroll: add Efl.Ui.Popup.Alert.Scroll class
Summary:
Add initial code for Efl.Ui.Popup.Alert.Scroll Class.
It supports scrolling content.
Test Plan: 1. run elementary_test -to efluipopupalertscroll
Reviewers: Jaehyun_Cho, jpeg, thiepha, cedric, Blackmole, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5123
Taehyub Kim [Thu, 31 Aug 2017 04:17:56 +0000 (13:17 +0900)]
efl_ui_popup: cover the corner case of popup sizing evaluation
Summary: cover the corner case of popup sizing evaluation
Test Plan: 1. run elementary_test -to efluipopup
Reviewers: Jaehyun_Cho, jpeg, thiepha, Blackmole, woohyun, cedric
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5146
Taehyub Kim [Wed, 23 Aug 2017 06:50:18 +0000 (15:50 +0900)]
efl_ui_popup_alert: add Efl.Ui.Popup.Alert class
Summary:
Add initial code for Efl.Ui.Popup.Alert class.
It supports setting title and buttons.
Test Plan: 1. run elementary_test -to efluipopupalert
Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun
Differential Revision: https://phab.enlightenment.org/D5108
Taehyub Kim [Thu, 17 Aug 2017 10:27:53 +0000 (19:27 +0900)]
efl_ui_popup: make popup size expandable
Summary: make popup size expandable
Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun
Differential Revision: https://phab.enlightenment.org/D5107
Taehyub Kim [Thu, 17 Aug 2017 08:37:54 +0000 (17:37 +0900)]
efl_ui_popup: add align and position properties
Summary:
add align feature and position properties (center, left, right, top, bottom)
efl_ui_popup_position_set should be seperated from evas_object_move
since evas_object_move can be called internally.
Test Plan: 1. run elementary_test -to efluipopup
Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5105
JinYong Park [Thu, 10 Aug 2017 06:48:36 +0000 (15:48 +0900)]
efl_ui_popup: add bg_set and bg_repeat_events_set/get API
Summary:
add bg_set and bg_repeat_events_set/get API
bg_set enables user change popup's outside bg
bg_repeat_events_set enables popup's outside bg repeat events
Test Plan:
1. run elementary_test -to efluipopup
2. click outside area of popup
3. click button in popup
Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, cedric, jpeg, singh.amitesh
Reviewed By: Jaehyun_Cho
Subscribers: jpeg
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D5054
Taehyub Kim [Fri, 28 Jul 2017 05:48:48 +0000 (14:48 +0900)]
efl_ui_popup: add Efl.Ui.Popup class
Summary: add initial code for Efl.Ui.Popup class
Test Plan: 1. run elementary_test -to efluipopup
Reviewers: Jaehyun_Cho, Blackmole, thiepha, woohyun, cedric
Reviewed By: Jaehyun_Cho
Subscribers: bu5hm4n, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5037
Amitesh Singh [Tue, 28 Nov 2017 08:05:31 +0000 (17:05 +0900)]
Efl.Ui.Format: do format check once only.
Amitesh Singh [Tue, 28 Nov 2017 03:12:08 +0000 (12:12 +0900)]
Efl.Ui.Format: do proper checking for string template.
Add support to take action based on string format specifier.
If string template is '%d' and value type is double, do safe
conversion to int from double.
Sungtaek Hong [Tue, 28 Nov 2017 02:47:42 +0000 (11:47 +0900)]
elc_combobox: use elm_legacy_add for internal component
Summary:
elm_combobox has entry, genlist, hover as its component.
Those components should be marked as legacy during efl_add.
Test Plan:
Run elementary test.
Run combobox test.
Reviewers: jpeg, cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D5542
Prasoon Singh [Tue, 28 Nov 2017 00:56:32 +0000 (09:56 +0900)]
elm_entry : Added access action interface in entry.
Summary:
Added access action interface in entry. On activate action from atspi client , entry will emit click signal and input panel
would be shown.
Test Plan:
When activate action comes, entry will emit click signal and input panel
should be shown.
Reviewers: shilpasingh, kimcinoo
Reviewed By: shilpasingh
Subscribers: cedric, jpeg, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D5544
Andy Williams [Mon, 27 Nov 2017 21:23:11 +0000 (21:23 +0000)]
elm_code: Reload grid colours on theme change
Derek Foreman [Mon, 27 Nov 2017 17:31:22 +0000 (11:31 -0600)]
efl_wl: Silence ridiculous warning
Including wayland client code before wayland server code causes
spurious "struct wl_buffer deprecated" nonsense.
Recent ecore_wl2 changes brought wayland client code into Ecore_Wl2.h
which caused the warning to trigger here.
Simply re-ordering the include files should resolve with no functional
change.
Andy Williams [Mon, 27 Nov 2017 14:48:35 +0000 (14:48 +0000)]
Provide a meaningful label
Andy Williams [Mon, 27 Nov 2017 14:37:17 +0000 (14:37 +0000)]
elementary: Be consistent for the display of test widgets
Woochan Lee [Mon, 20 Nov 2017 10:12:49 +0000 (19:12 +0900)]
efl_ui_spin: Add new spin and spin_button widgets
Summary:
https://phab.enlightenment.org/T5900
Creating base class(efl_ui_spin) to support various shape of spinner.
Added button interaction widget efl_ui_spin_button inherited from efl_ui_spin.
Test Plan: Add tests in elementary_test.
Reviewers: Jaehyun_Cho, woohyun, jpeg, singh.amitesh
Subscribers: jenkins, id213sin, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5424
Ross Vandegrift [Mon, 27 Nov 2017 06:38:16 +0000 (15:38 +0900)]
evas: Fix sign mismatch in evas between.c and .h definitions
Summary:
Parameters w and h are declared as int for evas_common_rgba_image_from_data
and evas_common_rgba_image_from_copied_data in evas_image_data.c. This
does not match the prototypes in evas_image_private.h which declares them
unsigned.
Original report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748026
Reviewers: jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5540
Pawel Aksiutowicz [Mon, 27 Nov 2017 06:35:58 +0000 (15:35 +0900)]
elementary: fixed single typos in few modules
Reviewers: stanluk, lukasz.stanislawski
Reviewed By: lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5534
Amitesh Singh [Mon, 27 Nov 2017 07:55:04 +0000 (16:55 +0900)]
Efl.Ui.Format: remove the dupicalte code
struct tm check is already done at the beginning of the function.
Sungtaek Hong [Mon, 27 Nov 2017 02:55:24 +0000 (11:55 +0900)]
efl_ui_bg: add Efl.Gfx.color_get.
Summary:
since legacy elm_bg_color_set/get is changed to efl_gfx_color_set/get,
efl_gfx_color_get also should get color of inner rect.
@fix
Test Plan:
1) run elementary test.
2) run Bg EO API(Efl.Ui.Bg)
3) set/unset "Bg color" check.
4) observe printed color values.
Reviewers: jpeg, woohyun, cedric
Differential Revision: https://phab.enlightenment.org/D5429
Marcel Hollerbach [Sun, 26 Nov 2017 18:29:36 +0000 (19:29 +0100)]
elm: fix legacy code
earlier elm_object_focused_object_get returned gengrid genlist toolbar
objects if a item of them is focused. This should fix that.
thank you @davemds for the report!
Chris Michael [Sun, 26 Nov 2017 17:12:53 +0000 (12:12 -0500)]
ecore-wl2: Fix resource leak
Coverity detected a resource leak here because we were not freeing the
malloc'd 'obo' variable.
Fixes Coverity CID1382907
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Al Poole [Sun, 26 Nov 2017 12:36:42 +0000 (12:36 +0000)]
elm_code: set the color scheme from the default edc.
This allows us to override in the application also. Work from
myself and @ajwillia.ms.
Carsten Haitzler (Rasterman) [Sun, 26 Nov 2017 05:01:14 +0000 (14:01 +0900)]
ecore ipc/con: fix nasty ... they dont mutually exclude
by deleting the socket they wont mutually exclude at bind which means
eny new server just nides the pror one and you can get lots of copies
of the same server. this wasnt the case before. it shouldnt have been.
i think ther was an rm path for stale sockets when connecting failed
or something. anyway... this here was causing multilpe efreetd's and
all sorts of nastiness. this is the root cause. so... fix it.
@fix
Carsten Haitzler (Rasterman) [Fri, 24 Nov 2017 14:52:08 +0000 (23:52 +0900)]
elm ifrace scrollable - fix uninitialized values on scroll asjust
dragable values were invalid (not fetched) so vx/y were junk and this
was making decisions based on that. guarantee it to be 0.
@fix
Carsten Haitzler (Rasterman) [Fri, 24 Nov 2017 14:45:14 +0000 (23:45 +0900)]
efl ui slider - fix crashes with fmt callback data and class data
the format free cb was passed the class data (sd) as the callback data
but this was freed by the time _indi_default_format_free_cb was called
causing an invalid access. fix this by looking it up from the obj
which is probably invalid at this point...
Daniel Kolesa [Fri, 24 Nov 2017 09:53:27 +0000 (10:53 +0100)]
elua: correctly wrap gettext funcs
Now, we cannot directly register funcs defined by a different
signature than the lua standard (int (*)(lua_State *)) so we
have to correctly wrap those with proper conversions etc.
Carsten Haitzler (Rasterman) [Thu, 23 Nov 2017 09:07:01 +0000 (18:07 +0900)]
elua - use safeptr with lightuserdata to work around luajit 64bit issue
luajit only supports 47bits on 64bit for lightuser data (bad! don't
mess with opaque pointers... really unexpected and bad and probably
should be fixed in luajit by doing things like on 32bit where
pointers are not messed with etc.)
Carsten Haitzler (Rasterman) [Thu, 23 Nov 2017 09:06:12 +0000 (18:06 +0900)]
eina safepointer - mimic 47 bit eoid patch
same thing as
b209b9a92286209281c12e81fd9dd72dc28c7495 but for safeptr
Carsten Haitzler (Rasterman) [Thu, 23 Nov 2017 04:27:52 +0000 (13:27 +0900)]
eo - by default on 64bit only use 47 bits because of luajit
luajit wants to check the upper 17 bits of pointers and assume they
are all 0 if on a 64bit architecture. it will panic and barf if they
are used. we have been using them in our eoid's for a long time.
my take on this is that this is unportable. assuming how many bits are
or are not valid in an opaque pointer (void *) that is simply passed
to you and you cannot dereference or use (no size information even for
what amount of data it points to etc.), is just wrong. it's not
portable and it's trying to be too smart and creating such issues. my
take is that luajit needs a fix for this in the longer term. but for
now let's have a 47 bit mode and go with that. it does mean i have to
drop our generation counter to 10 bits on 64bit (from 27 bits) which
increases likelihood of eoid re-use being falsely detected as valid
(before on 64bit it was 1 in 130 million or so chance, with this 47
bit change it's 1 in 1000. but to be fair on 32bit it's 7 bits for gen
count so 1 in 127 ... so still more than 10x "safer" than on 32bit...
but still...). the relevant check in luajit is:
(((uint64_t)(p) >> 47) ? (lj_err_msg(L, LJ_ERR_BADLU), NULL) : (p))
it ONLY does this on 64bit. on 32bit pointers are not checked for
validity at all.
as an aside, armv8.2 seemingly will bring 52bit addresses so luajit is
going to fall over flat on a newer rev of armv8. it may be x86 also
uses more bits. last i knew it was 48bits so the 47 bit check luajit
does i think is even wrong for x86-64. to be detailed i read:
amd64 arch == 48 bits (so luajit is wrong). even better In addition,
the AMD specification requires that the most significant 16 bits of
any virtual address, bits 48 through 63, must be copies of bit 47 (in
a manner akin to sign extension). so if the upper bit of 48 is set
THEN all the 16 upper bits must be 1... breaking luajit, even if it
were 47bit and this rule applied. I read the architecture allows for
up to 52bits of actual addresses so architecture-wise this is even
wrong...
So I smell a core bug here in luajit. Certainly in the number of bits
it insists must be 0 (the upper 17 bits where on amd64/x86-64 it
should be the upper 16 bits... and even then these may NOT be 0 if bit
47 (the upper bit of the lower 48 is 1).... so the whole check is
invalid... :(
at least the above is at a theoretical level. i believe that the
addresses divide the 48 bits into 2 chunks (thus 47)... but at the
PHYSICAL level with no mmu and virtual memory. arm64 has this:
https://www.kernel.org/doc/Documentation/arm64/memory.txt
note in all cases the 2nd chunk of memory has at leats some upper bits
of physical addresses beign 1 ... which makes luajit invalid tyo use
without virtual memory remapping these away from high bits.
@fix
Jean-Philippe Andre [Fri, 24 Nov 2017 08:22:31 +0000 (17:22 +0900)]
mbe: Fix invalid part handling
Only the text parts need special handling.
Ping @CHAN :)
Jean-Philippe Andre [Fri, 24 Nov 2017 08:10:30 +0000 (17:10 +0900)]
win: Fix window background EO APIs
Broken in a previous commit
Lukasz Stanislawski [Fri, 24 Nov 2017 07:50:01 +0000 (16:50 +0900)]
elm: add custom access state for Elm.Hover
Reviewers: jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5523
Jean-Philippe Andre [Fri, 24 Nov 2017 07:23:48 +0000 (16:23 +0900)]
layout: Fix erroneous warnings (from earlier patch)
Oops. Bad check :)
Jean-Philippe Andre [Fri, 24 Nov 2017 07:19:21 +0000 (16:19 +0900)]
elm_part: Mark as auto-unref before finalize
This simplifies the IMPLEMENT macro, which can now be a proper function.
Also, do not set a parent for the part object, as it's not useful and
could mess up the refcount.
Jean-Philippe Andre [Fri, 24 Nov 2017 07:15:03 +0000 (16:15 +0900)]
eo: Make sure auto_unref only applies after finalize
It would be pretty stupid to create an object that dies before it even
gets created. Auto-unref is for parts and should probably not be used
anywhere else :)
Jean-Philippe Andre [Fri, 24 Nov 2017 06:17:05 +0000 (15:17 +0900)]
part bg: Fix up some unnecessary complexity
See previous commit :)
Note: right now the background part has a small 3d indent which comes
from the legacy theme being used. This will be fixed soon.
Sungtaek Hong [Fri, 24 Nov 2017 05:41:31 +0000 (14:41 +0900)]
efl_ui_layout: create efl_ui_bg when efl_part for background is called.
Reviewers: woohyun, jpeg, cedric
Subscribers: felipealmeida, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5151
Amitesh Singh [Fri, 24 Nov 2017 05:56:10 +0000 (14:56 +0900)]
Efl.Ui.Format: add string format checking for user input
Jean-Philippe Andre [Fri, 24 Nov 2017 05:36:01 +0000 (14:36 +0900)]
widget: Add EINA_UNUSED
Sungtaek Hong [Fri, 24 Nov 2017 05:32:36 +0000 (14:32 +0900)]
efl_ui_widget: secure elm_legacy_add flag
Summary:
_elm_legacy_add goes back to EINA_FALSE after setting sd->legacy.
if constructor get called again after going back to EINA_FALSE,
sd->legacy should remain EINA_TRUE.
also, elm_legacy_add() should not be called non-elm_widget.
Test Plan:
Run elementary test->Efl.Ui.Text.Label.
Check legacy flag in _elm_theme_object_set() for efl_ui_win.
Check legacy flag for efl_ui_text after scrollable text is added.
Reviewers: jpeg, woohyun
Reviewed By: jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5529
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:43:36 +0000 (15:43 -0800)]
evas: remove warning from image_loaders/png/evas_image_load_png
Reviewers: stanluk, lukasz.stanislawski, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5501
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Sungtaek Hong [Thu, 23 Nov 2017 23:43:23 +0000 (15:43 -0800)]
efl_ui_bg: fix unclipped image on EFL_UI_IMAGE_SCALE_TYPE_NONE
@fix
Summary:
efl_ui_bg has internal image and image may be larger than
resize_obj when EFL.UI.IMAGE.SCALE_TYPE is none.
Now resize_obj clips the internal image.
Test Plan:
1.Run elementary_test, part background(will be added soon)
2.Create a bg in a box with other widgets.
Set bg as EFL_UI_IMAGE_SCALYE_TYPE_NONE.
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D5509
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:41:41 +0000 (15:41 -0800)]
elementary: fix typos in elm_win_legacy
Reviewers: stanluk, lukasz.stanislawski, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5511
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:40:58 +0000 (15:40 -0800)]
elementary: fix typos in elm_gesture_layer
Reviewers: stanluk, lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5512
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:40:12 +0000 (15:40 -0800)]
elementary: fix typos in elm_atspi_bridge
Reviewers: stanluk, lukasz.stanislawski
Reviewed By: lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5513
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:38:48 +0000 (15:38 -0800)]
ecore_con: quiet 2 "clobbered" warnings in ecore_con
Reviewers: stanluk, lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5514
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Pawel Aksiutowicz [Thu, 23 Nov 2017 23:37:56 +0000 (15:37 -0800)]
evas: fix typos for canvas
Reviewers: stanluk, lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5516
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Lauro Moura [Thu, 23 Nov 2017 23:34:50 +0000 (15:34 -0800)]
elementary: fix compilation of cxx examples
Summary: Missing ecore_con library
Reviewers: felipealmeida, jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5517
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Lauro Moura [Thu, 23 Nov 2017 23:32:08 +0000 (15:32 -0800)]
elementary: Windows requires EAPI for the legacy .eo.h
Summary:
After the reorganization of elm eos, some sources include the .eo
headers directly instead of through Elementary.h. This causes problems
on windows as the declarations won't be decorated with the dllexport
attributes.
Reviewers: cedric, felipealmeida, jpeg, vtorri
Subscribers: jenkins
Tags: #windows, #efl
Differential Revision: https://phab.enlightenment.org/D5519
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Lauro Moura [Thu, 23 Nov 2017 23:30:58 +0000 (15:30 -0800)]
ecore_evas: use access() instead of stat()
Summary: stat() wasn't working on Windows due to some msys2/mingw quirk.
Reviewers: felipealmeida, cedric, vtorri
Subscribers: jenkins, jpeg
Tags: #windows
Differential Revision: https://phab.enlightenment.org/D5520
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Lauro Moura [Thu, 23 Nov 2017 23:30:29 +0000 (15:30 -0800)]
elementary: fix compilation of elm_code test on windows
Summary:
Added some guards to avoid redefinition of functions.
Partially fixes T5866, as there is still the question whether we should
test internal functions or not, as stated by jpeg in the comments.
Reviewers: vtorri, felipealmeida, jpeg, cedric
Reviewed By: cedric
Subscribers: jenkins, cedric
Maniphest Tasks: T5866
Differential Revision: https://phab.enlightenment.org/D5521
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Cedric Bail [Thu, 23 Nov 2017 23:12:30 +0000 (15:12 -0800)]
ecore: during fd cleanup we didn't remove freed fd handler from the ready fd list.
Jean-Philippe Andre [Thu, 23 Nov 2017 06:20:00 +0000 (15:20 +0900)]
elm: Add hack to make test case work
Because of the way elm_code test case is written, by directly including
the C file, we end up with two symbols for the internal _elm_legacy_add
flag. This makes some test case fail (after applying a pending patch).
Solution found by Sungtaek Hong.
elm_code test case needs to be fixed. Don't include the C files
directly, testing static inlines should be done through a common .x or
something, but not by including the C file itself. This has led and will
lead to many issues.
Jean-Philippe Andre [Thu, 23 Nov 2017 05:49:49 +0000 (14:49 +0900)]
eolian: Add API's for part enumeration
@feature
Jean-Philippe Andre [Thu, 23 Nov 2017 05:31:47 +0000 (14:31 +0900)]
bg: Remove trailing \n in ERR message
Shilpa Singh [Thu, 23 Nov 2017 03:07:52 +0000 (12:07 +0900)]
efl_access: Add reading_info_type set/get APIs
Summary:
Information obtained by atspi client is name, role, description, state of an object.
reading_info_type_set/get APIs give control to application to decide on the information
that can be exposed.
Test Plan:
The reading info is added as an attribute of an accessible object, on query of
attribute, reading_info_type and corresponding character buffer should be given to ATSPI clients.
Reviewers: kimcinoo
Subscribers: cedric, govi, rajeshps, jpeg
Differential Revision: https://phab.enlightenment.org/D5524
Andy Williams [Wed, 22 Nov 2017 19:31:19 +0000 (19:31 +0000)]
elm_code: don't crash on NULL scope
This could be triggerd with the cursor was not in the file
Al Poole [Wed, 22 Nov 2017 16:11:12 +0000 (16:11 +0000)]
efl_ui_focus_manager: remove unnecessary debugging printf.
Marcel Hollerbach [Wed, 22 Nov 2017 13:57:57 +0000 (14:57 +0100)]
efl_ui_focus_manager: fixup previous commit
i forgot to git commit --amend ... i am sorry :[