commit-bot@chromium.org [Thu, 10 Apr 2014 22:49:20 +0000 (22:49 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
234243002/)
Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
233813004
git-svn-id: http://skia.googlecode.com/svn/trunk@14145
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 22:36:34 +0000 (22:36 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
227433009/)
Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
234243002
git-svn-id: http://skia.googlecode.com/svn/trunk@14144
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Apr 2014 22:26:29 +0000 (22:26 +0000)]
Clean up the default gamma settings.
This makes it a compile error to specify both SK_GAMMA_EXPONENT
and SK_GAMMA_SRGB. It also ensures that SK_GAMMA_EXPONENT will
be set consistently.
R=djsollen@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
233003003
git-svn-id: http://skia.googlecode.com/svn/trunk@14143
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 21:57:32 +0000 (21:57 +0000)]
remove two more effects that are now immutable
BUG=skia:
R=scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
233753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14142
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 10 Apr 2014 21:15:30 +0000 (21:15 +0000)]
when getClipBounds returns false, the out-param is uninitialized
BUG=skia:
Review URL: https://codereview.chromium.org/
233933002
git-svn-id: http://skia.googlecode.com/svn/trunk@14141
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 21:09:33 +0000 (21:09 +0000)]
Cast int to float.
Get rid of warning->error.
TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
233883002
git-svn-id: http://skia.googlecode.com/svn/trunk@14140
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 20:42:53 +0000 (20:42 +0000)]
Create SkLayerRasterizer w/o destroying Builder.
Add a new method to SkLayerRasterizer::Builder that creates a new
SkLayerRasterizer without destroying the Builder. Necessary to
continue to support Android's API.
Also fix a bug where creating a Builder and never calling
detachRasterizer results in not calling the destructor for any SkPaints
in the Builder.
Add tests.
BUG=b/
13729784
R=reed@google.com, dominikg@chromium.org
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
233673002
git-svn-id: http://skia.googlecode.com/svn/trunk@14139
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 20:41:13 +0000 (20:41 +0000)]
rebaseline_server: eliminate meaningless 404 errors while waiting for content to load
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
231513004
git-svn-id: http://skia.googlecode.com/svn/trunk@14138
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 20:24:14 +0000 (20:24 +0000)]
Flesh out the list of includes, also fix up README markdown
Currently only pulls in 'core' and 'effects'. Will add in gpu once we add an option to render via Mesa.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
232883004
git-svn-id: http://skia.googlecode.com/svn/trunk@14137
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 18:36:19 +0000 (18:36 +0000)]
Add MakeEmpty to GrIRect16
The GrLayerCache will use this capability.
R=jvanverth@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
232563007
git-svn-id: http://skia.googlecode.com/svn/trunk@14136
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 10 Apr 2014 16:16:13 +0000 (16:16 +0000)]
Add a new bench that tests a simple image filter DAG.
This bench exercises a blur filter connected to 5 inputs of the same
merge filter.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
233383002
git-svn-id: http://skia.googlecode.com/svn/trunk@14135
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 16:03:06 +0000 (16:03 +0000)]
Fix GPU-less build.
Do not include GrTBackendEffectFactory.h if SK_SUPPORT_GPU is
undefined.
R=egdaniel@google.com
TBR=egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
233093003
git-svn-id: http://skia.googlecode.com/svn/trunk@14134
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 15:39:02 +0000 (15:39 +0000)]
add explicit filepaths to render_pictures JSON summary
BUG=skia:2230,skia:1942
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
226293002
git-svn-id: http://skia.googlecode.com/svn/trunk@14133
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 15:37:52 +0000 (15:37 +0000)]
Move build guard to fix Android framework compile.
After merging into the Android tree, this file was not compiling.
It turns out that it was because SK_SUPPORT_GPU was not defined. When
built by GYP, SK_SUPPORT_GPU is defined by GYP. When built by the
Android framework, we depend on SkUserConfig.h, which is included by
other files, to set SK_SUPPORT_GPU. Moving the includes outside of
#if SK_SUPPORT_GPU ensures that the dependency chain defining
SK_SUPPORT_GPU is included, so this code gets compiled as expected.
R=egdaniel@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
228893003
git-svn-id: http://skia.googlecode.com/svn/trunk@14132
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 15:05:24 +0000 (15:05 +0000)]
rebaseline_server: allow user to specify which builders to process
BUG=skia:1543,skia:1915
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
232103002
git-svn-id: http://skia.googlecode.com/svn/trunk@14131
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 14:13:23 +0000 (14:13 +0000)]
Rename README and DESIGN so their markdown gets picked up my GitHub.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
231883008
git-svn-id: http://skia.googlecode.com/svn/trunk@14130
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 14:10:08 +0000 (14:10 +0000)]
Add the chromium ninja builder to the list of trybots for a DEPS roll.
R=robertphillips@google.com, borenet@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
227913005
git-svn-id: http://skia.googlecode.com/svn/trunk@14129
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Thu, 10 Apr 2014 12:46:36 +0000 (12:46 +0000)]
revert of 14111 to fix build
git-svn-id: http://skia.googlecode.com/svn/trunk@14128
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 10 Apr 2014 03:05:44 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14127
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 10 Apr 2014 02:26:33 +0000 (02:26 +0000)]
SkRecordDraw: don't bother clipping an empty clip down further
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, fmalita@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
231933003
git-svn-id: http://skia.googlecode.com/svn/trunk@14126
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 23:38:57 +0000 (23:38 +0000)]
Revert of remove sprintf (https://codereview.chromium.org/
230413005/)
Reason for revert:
Boo, hiss, SK_ARRAY_COUNT not defined in skia_launcher.cpp!
Original issue's description:
> remove sprintf
>
> Committed: http://code.google.com/p/skia/source/detail?r=14123
R=halcanary@google.com
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
232323002
git-svn-id: http://skia.googlecode.com/svn/trunk@14125
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 23:30:28 +0000 (23:30 +0000)]
SkRecordDraw: skip draw ops when the clip is empty
- Adds tests for SkRecordDraw's two main features: cull- and clip- based skipping.
- Adds full SkCanvas semantic mode to SkRecorder, so it can be used as a target for SkRecordDraw.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
231653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14124
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 23:22:44 +0000 (23:22 +0000)]
remove sprintf
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
230413005
git-svn-id: http://skia.googlecode.com/svn/trunk@14123
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 9 Apr 2014 22:54:57 +0000 (22:54 +0000)]
Real fix for SK_API / Windows shared lib problems.
Ben reviewed this over my shoulder, and we tested on his machine.
git-svn-id: http://skia.googlecode.com/svn/trunk@14122
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 22:54:02 +0000 (22:54 +0000)]
Cleaned up the start page, added wait cursor, disabled Run button while waiting for results.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
231853002
git-svn-id: http://skia.googlecode.com/svn/trunk@14121
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 21:43:27 +0000 (21:43 +0000)]
SK_API for SkXfermode_opts_SSE2 so Chrome can initialize flattenables.
BUG=skia:2401
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
231423003
git-svn-id: http://skia.googlecode.com/svn/trunk@14120
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 21:35:18 +0000 (21:35 +0000)]
I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header.
Also forgot one last place that referenced syscall_reporter.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
231663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14119
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 21:26:11 +0000 (21:26 +0000)]
Implement drawDRRect for GPU
BUG=skia:2259
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
220233011
git-svn-id: http://skia.googlecode.com/svn/trunk@14118
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 20:45:29 +0000 (20:45 +0000)]
Rename kPMColor_SkColorType to kN32_SkColorType.
The new name better represents what this flag means.
BUG=skia:2384
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
227433009
git-svn-id: http://skia.googlecode.com/svn/trunk@14117
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Wed, 9 Apr 2014 19:31:48 +0000 (19:31 +0000)]
More SkPictureShader baselines.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
231563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14116
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Wed, 9 Apr 2014 19:14:23 +0000 (19:14 +0000)]
Baselines for the SkPictureShader GM.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
230443007
git-svn-id: http://skia.googlecode.com/svn/trunk@14115
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 18:59:44 +0000 (18:59 +0000)]
Initial code for webtry, a web application for allowing users to try out Skia.
Currently running at http://108.170.220.126:8000/
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
228693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14114
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:42 +0000 (18:57 +0000)]
enable developers to provide their own android toolchain
R=halcanary@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
227673003
git-svn-id: http://skia.googlecode.com/svn/trunk@14113
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:02 +0000 (18:57 +0000)]
Adjusts the bench expectations calculation to consider average value.
BUG=skia:2225
NOTRY=true
R=borenet@google.com
TBR=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
231513002
git-svn-id: http://skia.googlecode.com/svn/trunk@14112
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 9 Apr 2014 18:47:28 +0000 (18:47 +0000)]
no more callers of getTotalClip -- except in android
git-svn-id: http://skia.googlecode.com/svn/trunk@14111
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 17:11:09 +0000 (17:11 +0000)]
Do div-by-zero check for all gpus in ellipse/rr effects.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
231093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14110
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 9 Apr 2014 17:09:36 +0000 (17:09 +0000)]
Rebaselines for r14106.
git-svn-id: http://skia.googlecode.com/svn/trunk@14109
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 16:50:55 +0000 (16:50 +0000)]
Define SK_CPU_X86 on x86 machines.
Use this to only register flattening for SkSSE2ProcCoeffXfermode::CreateProc when it's linked.
BUG=skia:
R=reed@google.com, mtklein@google.com, bsalomon@google.com
TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
231223002
git-svn-id: http://skia.googlecode.com/svn/trunk@14108
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 15:43:46 +0000 (15:43 +0000)]
Xfermode: SSE2 implementation of multiply_modeproc
This patch implements basics for Xfermode SSE optimization. Based on
these basics, SSE2 implementation of multiply_modeproc is provided. SSE2
implementation for other modes will come in future. With this patch
performance of Xfermode_Multiply will improve about 45%. Here are the
data on desktop i7-3770.
before:
Xfermode_Multiply 8888: cmsecs = 33.30 565: cmsecs = 45.65
after:
Xfermode_Multiply 8888: cmsecs = 17.18 565: cmsecs = 24.87
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14006
Committed: http://code.google.com/p/skia/source/detail?r=14050
R=mtklein@google.com, robertphillips@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
202903004
git-svn-id: http://skia.googlecode.com/svn/trunk@14107
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 9 Apr 2014 15:35:03 +0000 (15:35 +0000)]
Measure DirectWrite BW consistently with rendering.
Also move DirectWrite glyph drawing into the scaler context, as this
reduces duplication.
R=reed@google.com
Review URL: https://codereview.chromium.org/
225283021
git-svn-id: http://skia.googlecode.com/svn/trunk@14106
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 14:34:24 +0000 (14:34 +0000)]
Rebaselines for https://codereview.chromium.org/
181523002/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
230733004
git-svn-id: http://skia.googlecode.com/svn/trunk@14105
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 13:34:26 +0000 (13:34 +0000)]
Fixes to Android.mk generation for arm64.
Remove warning about no optimizations for arm64 and rebaseline the
associated test.
Exclude _opts_none.cpps when building arm64, to avoid double definitions.
BUG=skia:1975
R=halcanary@google.com, djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
229393002
git-svn-id: http://skia.googlecode.com/svn/trunk@14104
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 9 Apr 2014 09:46:31 +0000 (09:46 +0000)]
ARM Skia NEON patches - 22 - S32_D565_Blend
BlitRow565: new NEON version of S32_D565_Blend
This new implementation brings a good speedup in most cases and
gives exact results (removes one mismatch in gm).
Here are the benchmark results (speedup vs. existing S32A_D565_Blend):
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | -26,7% | -27,5% |
+-------+-----------+------------+
| 2 | 0% | +53% |
+-------+-----------+------------+
| 4 | +38,3% | +26,5% |
+-------+-----------+------------+
| 8 | +10,9% | -4,5% |
+-------+-----------+------------+
| 16 | +18,2% | +1,6% |
+-------+-----------+------------+
| 64 | +22,3% | +8,75% |
+-------+-----------+------------+
| 256 | +12,3% | +11,2% |
+-------+-----------+------------+
| 1024 | +79,2% | +10,9% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
181523002
git-svn-id: http://skia.googlecode.com/svn/trunk@14103
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 9 Apr 2014 03:04:11 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14102
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 23:31:35 +0000 (23:31 +0000)]
SkRecord: make culling work if SkRecordAnnotateCullingPairs is called.
- Allow stateful functors; allow visit()/mutate() at a given index; add count().
- Annotate cull push/pop pairs on the PushCull records. (tested)
- Use those annotations to skip ahead in SkRecordDraw. (not yet tested beyond dm --skr)
- Make SkRecordDraw a function, move its implementation to a .cpp.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
229523002
git-svn-id: http://skia.googlecode.com/svn/trunk@14101
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 21:01:17 +0000 (21:01 +0000)]
More SkRecord TODOs:
- add basic test for SkRecorder
- rejigger GYPs so that the include dir comes along with the dependency
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14099
NOTRY=true
NOTREECHECKS=true
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
227673011
git-svn-id: http://skia.googlecode.com/svn/trunk@14100
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 20:17:26 +0000 (20:17 +0000)]
More SkRecord TODOs:
- add basic test for SkRecorder
- rejigger GYPs so that the include dir comes along with the dependency
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
227673011
git-svn-id: http://skia.googlecode.com/svn/trunk@14099
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 20:14:32 +0000 (20:14 +0000)]
Don't try to render color fonts using distance fields.
Adds detection of ARGB mask format, which is only used for color fonts.
BUG=skia:2173
R=bungeman@google.com, reed@google.com, bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
224903012
git-svn-id: http://skia.googlecode.com/svn/trunk@14098
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 17:31:08 +0000 (17:31 +0000)]
Start on some unwritten SkRecord TODOs:
- add SK_OVERRIDE for SkCanvas methods in SkRecorder
- start on unit tests, here just for SkRecord itself
BUG=skia:2378
R=fmalita@google.com, mtklein@google.com, fmalita@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
228723003
git-svn-id: http://skia.googlecode.com/svn/trunk@14097
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Apr 2014 16:57:05 +0000 (16:57 +0000)]
use default to fix warning (or I will shoot myself)
git-svn-id: http://skia.googlecode.com/svn/trunk@14096
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Apr 2014 16:02:45 +0000 (16:02 +0000)]
fix warning for uninitialized count
git-svn-id: http://skia.googlecode.com/svn/trunk@14095
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Apr 2014 15:48:26 +0000 (15:48 +0000)]
fix warning about uninitialized typeface_encoding by folding glyph case into switch
git-svn-id: http://skia.googlecode.com/svn/trunk@14094
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Apr 2014 15:29:10 +0000 (15:29 +0000)]
fix warning by removing padding field
git-svn-id: http://skia.googlecode.com/svn/trunk@14093
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 15:19:34 +0000 (15:19 +0000)]
Initial picture shader implementation
This CL adds an SkPictureShader class to support SkPicture-based
patterns.
The implementation renders the picture into an SkBitmap tile and then
delegates to SkBitmapProcShader for the actual operation.
R=bsalomon@google.com, reed@google.com, robertphillips@google.com
Committed: http://code.google.com/p/skia/source/detail?r=14085
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
221923007
git-svn-id: http://skia.googlecode.com/svn/trunk@14092
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 15:17:17 +0000 (15:17 +0000)]
Add push/pop cull to SkRecord.
BUG=skia:2378
R=fmalita@google.com, mtklein@google.com, fmalita@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
224723026
git-svn-id: http://skia.googlecode.com/svn/trunk@14091
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Apr 2014 15:04:29 +0000 (15:04 +0000)]
WIP -- SkFont
BUG=skia:
R=bungeman@google.com, fmalita@chromium.org
Review URL: https://codereview.chromium.org/
185293018
git-svn-id: http://skia.googlecode.com/svn/trunk@14090
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 8 Apr 2014 14:11:26 +0000 (14:11 +0000)]
Relax the assert in SkReadBuffer::setPictureVersion().
I'm hitting this with SkPictureShader serialization because there can be
multiple pictures deserialized from the same buffer.
I think we can relax the assert to allow setting the same version
multiple times.
(Alternatively, we could guard all the callers - but since setting the
same version is a no-op, that seems overkill)
R=mtklein@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
226743004
git-svn-id: http://skia.googlecode.com/svn/trunk@14089
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 8 Apr 2014 12:24:01 +0000 (12:24 +0000)]
Removes deleted files SkBitmapShader* from gyp/core.gypi.
BUG=skia:
NOTRY=true
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
228513003
git-svn-id: http://skia.googlecode.com/svn/trunk@14088
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 23:45:31 +0000 (23:45 +0000)]
Revert of Initial picture shader implementation (https://codereview.chromium.org/
221923007/)
Reason for revert:
breaking the buildbots. Subsequent CL only addressed CompareGMs but GenerateGMs are also failing.
Original issue's description:
> Initial picture shader implementation
>
> This CL adds an SkPictureShader class to support SkPicture-based
> patterns.
>
> The implementation renders the picture into an SkBitmap tile and then
> delegates to SkBitmapProcShader for the actual operation.
>
> R=reed@google.com,robertphillips@google.com,bsalomon@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14085
R=bsalomon@google.com, reed@google.com, robertphillips@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
227553010
git-svn-id: http://skia.googlecode.com/svn/trunk@14087
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Mon, 7 Apr 2014 23:30:37 +0000 (23:30 +0000)]
Suppress pictureshader GM failures.
Pending baselines.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
225413018
git-svn-id: http://skia.googlecode.com/svn/trunk@14086
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 23:11:45 +0000 (23:11 +0000)]
Initial picture shader implementation
This CL adds an SkPictureShader class to support SkPicture-based
patterns.
The implementation renders the picture into an SkBitmap tile and then
delegates to SkBitmapProcShader for the actual operation.
R=bsalomon@google.com, reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
221923007
git-svn-id: http://skia.googlecode.com/svn/trunk@14085
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 21:37:36 +0000 (21:37 +0000)]
Add option to SkDecodingImageGenerator to require unpremul.
Android needs to be able to set unpremul for purgeable
pixelRefs.
Once Android switches to the new interface, we can delete SkImageRef.
Bug=skia:2389
R=reed@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
223903007
git-svn-id: http://skia.googlecode.com/svn/trunk@14084
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 21:33:06 +0000 (21:33 +0000)]
remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
227643005
git-svn-id: http://skia.googlecode.com/svn/trunk@14083
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 21:18:46 +0000 (21:18 +0000)]
clear bitmap in texture domain gm
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
227563007
git-svn-id: http://skia.googlecode.com/svn/trunk@14082
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 19:34:38 +0000 (19:34 +0000)]
SkNonCopyable should be used with private inheritance.
This is mostly s/public SkNoncopyable/SkNoncopyable/g.
Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor. I added SkNoncopyableVirtual to make them work as intended. Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
226183018
git-svn-id: http://skia.googlecode.com/svn/trunk@14081
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 19:34:16 +0000 (19:34 +0000)]
Factory methods for heap-allocated SkTypeface objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkTypeface and its subclasses non-public
and instead provides factory methods for creating these objects on the heap.
BUG=skia:2187
R=scroggo@google.com, bungeman@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
227693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14080
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 18:26:22 +0000 (18:26 +0000)]
Convert SkPicture's generation ID to a unique ID
This CL addresses linger code review comments on r14037 (Add generation ID to SkPicture https://codereview.chromium.org/
222683002/)
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
225283014
git-svn-id: http://skia.googlecode.com/svn/trunk@14079
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 18:01:09 +0000 (18:01 +0000)]
Remove SkBitmapShaderTemplate.
Remove files that are no longer needed:
src/core/SkBitmapShaderTemplate.h
src/core/SkBitmapShader16BilerpTemplate.h
BUG=skia:1976
R=scroggo@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
225023028
git-svn-id: http://skia.googlecode.com/svn/trunk@14078
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 17:43:01 +0000 (17:43 +0000)]
Revert of Discard scratch render targets before reusing them. (https://codereview.chromium.org/
225183012/)
Reason for revert:
Asserts in debug.
Original issue's description:
> Discard scratch render targets before reusing them.
>
> R=robertphillips@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14075
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
224963014
git-svn-id: http://skia.googlecode.com/svn/trunk@14077
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 17:13:10 +0000 (17:13 +0000)]
Fix EffectKey for XferEffect
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
227233007
git-svn-id: http://skia.googlecode.com/svn/trunk@14076
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 17:03:00 +0000 (17:03 +0000)]
Discard scratch render targets before reusing them.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
225183012
git-svn-id: http://skia.googlecode.com/svn/trunk@14075
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 15:17:37 +0000 (15:17 +0000)]
remove SK_SUPPORT_LEGACY_GETCLIPTYPE
after this lands and sticks, we can remove the assocated code from skia
BUG=skia:
R=robertphillips@google.com, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
216703004
git-svn-id: http://skia.googlecode.com/svn/trunk@14074
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 15:11:08 +0000 (15:11 +0000)]
Remove SkResizeImageFilter.
Its functionality has been subsumed by SkMatrixImageFilter, and it's no longer
used in Blink.
BUG=skia:
R=bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
222923005
git-svn-id: http://skia.googlecode.com/svn/trunk@14073
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 14:00:31 +0000 (14:00 +0000)]
Remove deprecated function.
We have switched Android to call decodeSubset, so this function
is no longer necessary.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
225413013
git-svn-id: http://skia.googlecode.com/svn/trunk@14072
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 7 Apr 2014 13:12:47 +0000 (13:12 +0000)]
Fixed Skia compilation error with strict clang.
BUG=skia:
R=reed@google.com, sergeyberezin@chromium.org, hcm@google.com
Author: kolczyk@opera.com
Review URL: https://codereview.chromium.org/
227043006
git-svn-id: http://skia.googlecode.com/svn/trunk@14071
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 5 Apr 2014 03:05:27 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14070
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 5 Apr 2014 01:13:43 +0000 (01:13 +0000)]
get iOS building again
1) Disable SampleApp. Seems like it's totally horked? SkOSFile_iOS.mm is missing about half the functions needed, and SkOSFile_stdio.cpp is double-providing the others.
2) Drop armv6.
3) Switch from putting headers in sources to putting the corresponding directories in includes.
4) Force cast the type of glShaderSource. Something to do with GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE?
After all this,
env CC=clang CXX=clang++ GYP_DEFINES=skia_os=ios make
builds for me.
BUG=skia:2363
R=bsalomon@google.com, epoger@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
226413005
git-svn-id: http://skia.googlecode.com/svn/trunk@14069
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 21:23:30 +0000 (21:23 +0000)]
Rebaselining resizeimagefilter
BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
226413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14068
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 21:19:53 +0000 (21:19 +0000)]
Updates to Android.mk generation.
These defines were manually added to the last merge.
BUG=skia:1975
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
226663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14067
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 20:13:05 +0000 (20:13 +0000)]
Change SkDecodingImageGenerator to hide implementation details.
Motivation: A later CL will move SkDecodingImageGenerator into
include/ for Android to use.
R=scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
226253003
git-svn-id: http://skia.googlecode.com/svn/trunk@14066
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 18:16:04 +0000 (18:16 +0000)]
fix nacl build using ninja
BUG=skia:2366
NOTREECHECKS=True
NOTRY=True
R=robertphillips@google.com
TBR=robertphillips
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
225683005
git-svn-id: http://skia.googlecode.com/svn/trunk@14065
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 18:14:39 +0000 (18:14 +0000)]
Prevent potential leaking of memory by using SkString and SkTArray.
R=bungeman@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
226183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14064
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 16:43:38 +0000 (16:43 +0000)]
SkDiscardableMemoryPool to abstract class
Motivation - we want to keep our public headers small.
R=scroggo@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
223403012
git-svn-id: http://skia.googlecode.com/svn/trunk@14063
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 16:40:25 +0000 (16:40 +0000)]
teach rebaseline_server how to compare results of multiple render_pictures runs
BUG=skia:2230,skia:1942
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
216103004
git-svn-id: http://skia.googlecode.com/svn/trunk@14062
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 16:26:42 +0000 (16:26 +0000)]
hack hack hack
Edit down the android scripts a bit.
- set -e
- detect ccache by default
- -t for BUILDTYPE
I figure the -t changes are going to break some bots.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
223613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14061
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 4 Apr 2014 14:46:10 +0000 (14:46 +0000)]
Perform perlin noise matrix computations once per frame, not per pixel.
Before (Retina MBP):
running bench [640 480] perlinnoise 8888: cmsecs = 1853.18
After:
running bench [640 480] perlinnoise 8888: cmsecs = 1667.06
Review URL: https://codereview.chromium.org/
225583006
git-svn-id: http://skia.googlecode.com/svn/trunk@14060
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 4 Apr 2014 13:50:50 +0000 (13:50 +0000)]
Add base effect for gpu 2pt conical gradients
This is in preparation to add more "sub-effects" for the various fast path cases for 2 pt conical gradients
BUG=skia:
R=jvanverth@google.com, robertphillips@google.com, bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
224083002
git-svn-id: http://skia.googlecode.com/svn/trunk@14059
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 4 Apr 2014 03:04:32 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14058
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 23:39:46 +0000 (23:39 +0000)]
Revert to old behavior regarding SK_CPU_ARM and update documentation around SK_CPU_ARM64 on iOS.
R=robertphillips@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
216823008
git-svn-id: http://skia.googlecode.com/svn/trunk@14057
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 22:21:08 +0000 (22:21 +0000)]
Add skia.buildbots@gmail.com to CQ_COMMITTERS
BUG=skia:2225
R=borenet@google.com, rmistry@google.com
Author: skia.buildbots@gmail.com
Review URL: https://codereview.chromium.org/
218393023
git-svn-id: http://skia.googlecode.com/svn/trunk@14056
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 21:47:15 +0000 (21:47 +0000)]
Revert of Properly set alpha type in webp decode. (https://codereview.chromium.org/
223893002/)
Reason for revert:
Breaks ImageDecoding tests on several platforms.
Original issue's description:
> Properly set alpha type in webp decode.
>
> Also use the newer setConfig function.
>
> Add a test to confirm that we set the alpha type properly.
>
> Add some images with alpha for testing. (These images are also beneficial for the compare_unpremul test, which was previously not meaningful on 100% opaque images.)
>
> All of the added images are in the public domain. They were taken from https://developers.google.com/speed/webp/gallery2:
>
> yellow_rose:
> "Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers"
> Image Author: Jon Sullivan
> This file is in the public domain.
> http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg
>
> baby_tux:
> "baby tux for my user page"
> Image Author: Fizyplankton
> This file is in the public domain.
> http://www.minecraftwiki.net/images/8/85/Fizyplankton.png
>
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=14054
R=halcanary@google.com
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
223903008
git-svn-id: http://skia.googlecode.com/svn/trunk@14055
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 20:55:39 +0000 (20:55 +0000)]
Properly set alpha type in webp decode.
Also use the newer setConfig function.
Add a test to confirm that we set the alpha type properly.
Add some images with alpha for testing. (These images are also beneficial for the compare_unpremul test, which was previously not meaningful on 100% opaque images.)
All of the added images are in the public domain. They were taken from https://developers.google.com/speed/webp/gallery2:
yellow_rose:
"Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers"
Image Author: Jon Sullivan
This file is in the public domain.
http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg
baby_tux:
"baby tux for my user page"
Image Author: Fizyplankton
This file is in the public domain.
http://www.minecraftwiki.net/images/8/85/Fizyplankton.png
NOTRY=true
R=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
223893002
git-svn-id: http://skia.googlecode.com/svn/trunk@14054
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 18:53:33 +0000 (18:53 +0000)]
Revert of Xfermode: SSE2 implementation of multiply_modeproc (https://codereview.chromium.org/
202903004/)
Reason for revert:
It looks like serialization is broken. The serialize and pipe-cross-process tests are failing and turning (at least the Ubuntu12 and Win7) bots red
Original issue's description:
> Xfermode: SSE2 implementation of multiply_modeproc
>
> This patch implements basics for Xfermode SSE optimization. Based on
> these basics, SSE2 implementation of multiply_modeproc is provided. SSE2
> implementation for other modes will come in future. With this patch
> performance of Xfermode_Multiply will improve about 45%. Here are the
> data on desktop i7-3770.
> before:
> Xfermode_Multiply 8888: cmsecs = 33.30 565: cmsecs = 45.65
> after:
> Xfermode_Multiply 8888: cmsecs = 17.18 565: cmsecs = 24.87
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14006
>
> Committed: http://code.google.com/p/skia/source/detail?r=14050
R=mtklein@google.com, qiankun.miao@intel.com
TBR=mtklein@google.com, qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
224253003
git-svn-id: http://skia.googlecode.com/svn/trunk@14053
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 3 Apr 2014 18:37:13 +0000 (18:37 +0000)]
Rebaseline flaky image on Win7 GPU
https://codereview.chromium.org/
216883009/
git-svn-id: http://skia.googlecode.com/svn/trunk@14052
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 18:27:11 +0000 (18:27 +0000)]
Fix for SkTwoPointConicalGradient_gpu define
NOTREECHECK=True
NOTRY=True
TBR=robertphillips@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
224353002
git-svn-id: http://skia.googlecode.com/svn/trunk@14051
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 18:26:40 +0000 (18:26 +0000)]
Xfermode: SSE2 implementation of multiply_modeproc
This patch implements basics for Xfermode SSE optimization. Based on
these basics, SSE2 implementation of multiply_modeproc is provided. SSE2
implementation for other modes will come in future. With this patch
performance of Xfermode_Multiply will improve about 45%. Here are the
data on desktop i7-3770.
before:
Xfermode_Multiply 8888: cmsecs = 33.30 565: cmsecs = 45.65
after:
Xfermode_Multiply 8888: cmsecs = 17.18 565: cmsecs = 24.87
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14006
R=mtklein@google.com, robertphillips@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
202903004
git-svn-id: http://skia.googlecode.com/svn/trunk@14050
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 18:25:48 +0000 (18:25 +0000)]
Add LCD support for distance field text.
LCD support is handled by shifting the uv coordinate by 1/3 of a pixel (transformed by the inverse CTM) to the left and right of the original texture coordinate, and using left, center, and right lookups to set the RGB values. This supports both RGB and BGR subpixel order.
BUG=skia:2173
R=robertphillips@google.com, egdaniel@google.com, bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
219243012
git-svn-id: http://skia.googlecode.com/svn/trunk@14049
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 3 Apr 2014 17:50:01 +0000 (17:50 +0000)]
Fix ios build in chromium when targeting multiple architectures
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
222583003
git-svn-id: http://skia.googlecode.com/svn/trunk@14048
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 17:47:17 +0000 (17:47 +0000)]
Remove RHB msaa4 from bench_pictures cfg
NOTRY=true
BUG=skia:2386
R=robertphillips@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
224303002
git-svn-id: http://skia.googlecode.com/svn/trunk@14047
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 3 Apr 2014 16:38:01 +0000 (16:38 +0000)]
Add more big endian platforms
This patch adds more platforms to the list that have the BIGENDIAN defines set.
Downstream users are using parts of SKIA on BigEndian machines.
R=cmp@chromium.org, bungeman@google.com, bsalomon@google.com, reed@google.com, sergeyberezin@chromium.org
Author: steve@ssinger.info
Review URL: https://codereview.chromium.org/
218733002
git-svn-id: http://skia.googlecode.com/svn/trunk@14046
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log