svenpanne@chromium.org [Tue, 10 Jan 2012 16:12:24 +0000 (16:12 +0000)]
Changes after code review#
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10373
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Tue, 10 Jan 2012 16:12:16 +0000 (16:12 +0000)]
Fixed AccessorPair handling
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10372
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Tue, 10 Jan 2012 16:11:33 +0000 (16:11 +0000)]
Use a separate new type AccessorPair for JavaScript callbacks instead of a FixedArray of length 2
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10371
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Tue, 10 Jan 2012 16:06:32 +0000 (16:06 +0000)]
Avoid recording unnecessary deoptimization environments in a couple of places.
This reduces the number of uses and potentially shortens live ranges.
Review URL: http://codereview.chromium.org/8983018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10370
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Tue, 10 Jan 2012 14:52:41 +0000 (14:52 +0000)]
Inline fast case of CodeGenerationFromStringsAllowed
Review URL: http://codereview.chromium.org/9155011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10369
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 10 Jan 2012 13:43:44 +0000 (13:43 +0000)]
MIPS: Check that address given to __RecordWrite is correct.
ARM: Clean up equivalent functionality on ARM.
This subsumes http://codereview.chromium.org/8561001/
Review URL: http://codereview.chromium.org/9168006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10368
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 10 Jan 2012 13:24:18 +0000 (13:24 +0000)]
Minor cleanups of numeric seeded hashing patch.
Review URL: http://codereview.chromium.org/9155010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10367
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 10 Jan 2012 12:58:41 +0000 (12:58 +0000)]
Add seed to hash of numeric keyed properties. This is a commit of codereview.chromium.org/9148006/ for Fedor Indutny.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10366
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 10 Jan 2012 12:01:04 +0000 (12:01 +0000)]
Fix zero hash handling on ARM.
Some cleanup.
Review URL: http://codereview.chromium.org/9169010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10362
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 10 Jan 2012 10:05:45 +0000 (10:05 +0000)]
Fix handling of -0.0 in IsInt32/IsUInt32
R=ager@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9169009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10361
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 10 Jan 2012 08:37:45 +0000 (08:37 +0000)]
Fixing windows builds.
Review URL: http://codereview.chromium.org/9169007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10358
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 10 Jan 2012 08:17:08 +0000 (08:17 +0000)]
Fixing minGW build.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9149001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10357
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Mon, 9 Jan 2012 16:37:47 +0000 (16:37 +0000)]
Make sure transitioned arrays efficiently call builtin Array functions
Loosen the requirement for Map equivalency on several map checks, including checks up the prototype chain, that are not sensitive to ElementsKinds. These selected map checks should also match against FAST_DOUBLE_ELEMENT and FAST_ELEMENT transitions of the original map. This specifically helps all variants of transitioned JSArrays to still efficiently call builtins like push, pop and sort.
BUG=none
TEST=none
Committed: http://code.google.com/p/v8/source/detail?r=10331
Review URL: http://codereview.chromium.org/9015020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10356
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 9 Jan 2012 13:33:59 +0000 (13:33 +0000)]
Use shift and add instead of mul on ARM for integer hash.
Review URL: http://codereview.chromium.org/9153002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10355
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 6 Jan 2012 11:33:20 +0000 (11:33 +0000)]
Fix test-hashing after recent changes to string hashing.
Acriave test-hashing in SCons and buildbot runs.
Small cleanups in root register handling on ARM and MIPS.
Review URL: http://codereview.chromium.org/9110029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10351
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Fri, 6 Jan 2012 10:26:17 +0000 (10:26 +0000)]
Adjust position recorded for call expressions.
For calls of the form ident(...) record position of the identifier as the position of the call. For other calls record positions of the opening parenthesis.
This guarantees that for expressions of the form function(){}() call position will not intersect with positions recorded for function literal which is used by the debugger for scope chain resolution.
R=kmillikin@chromium.org
BUG=http://crbug.com/109195
TEST=test/mjsunit/regress/regress-109195.js
Review URL: http://codereview.chromium.org/9125001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10350
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Thu, 5 Jan 2012 17:16:19 +0000 (17:16 +0000)]
Move handlified functions from handles.cc to objects.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9008012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10348
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Thu, 5 Jan 2012 14:56:44 +0000 (14:56 +0000)]
Prepare push to trunk. Now working on version 3.8.6.
R=yangguo@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9114009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10345
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 5 Jan 2012 14:28:45 +0000 (14:28 +0000)]
Fix several minor issues with grokdump.py tool.
This includes the following changes:
* Bring instance type mapping up to date.
* Enable loading of maps without available meta-map.
* Add missing IntSize() method.
* Fix reference to Code.CODE_ALIGNMENT_MASK.
* Add alignment checks for objects and maps.
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/9075003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10344
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 5 Jan 2012 13:16:15 +0000 (13:16 +0000)]
Fix broken test that assumes that no GC can clear the regexp
cache (GC can happen at any time due to Crankshaft).
Review URL: http://codereview.chromium.org/9113012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10343
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 5 Jan 2012 12:55:06 +0000 (12:55 +0000)]
Fix handling of bogus receivers for Harmony collections.
R=rossberg@chromium.org
BUG=v8:1884
TEST=mjsunit/harmony/collections
Review URL: http://codereview.chromium.org/9074003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10342
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 5 Jan 2012 12:17:08 +0000 (12:17 +0000)]
Add netbsd support to gyp build.
Review URL: http://codereview.chromium.org/9071004
Patch from Matthew Sporleder <msporleder@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10341
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 5 Jan 2012 10:18:28 +0000 (10:18 +0000)]
Fix the logic that should ensure that a string cannot have
a hash key of zero.
Review URL: http://codereview.chromium.org/9113006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10338
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 5 Jan 2012 10:07:33 +0000 (10:07 +0000)]
Determine page size at runtime on posix platforms. Landing for kalmard. codereview.chromium.org/9023007/
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10337
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 5 Jan 2012 09:57:10 +0000 (09:57 +0000)]
Alter the second hash used in StoreBuffer::Compact.
hash2 >> (kHashMapLengthLog2 * 2) was always zero because hash2 was masked with (kHashMapLength - 1).
R=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/9085021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10336
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 5 Jan 2012 09:26:15 +0000 (09:26 +0000)]
MIPS: Avoid embedding new space objects into code objects in the lithium gap resolver.
Port r10301 (
c91aeb4c).
BUG=
TEST=
Review URL: http://codereview.chromium.org/9032005
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10335
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 5 Jan 2012 07:53:28 +0000 (07:53 +0000)]
Ensure that store buffer filtering hash sets are cleared after StoreBuffer::Filter.
R=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/8964025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10334
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 4 Jan 2012 19:59:01 +0000 (19:59 +0000)]
When shrinking semispace don't relink pages if semispace is not committed
R=mstarzinger@chromium.org
Review URL: http://codereview.chromium.org/9086005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10333
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 4 Jan 2012 17:29:01 +0000 (17:29 +0000)]
Rollback 10331: Make sure transitioned arrays efficiently call builtin Array functions
Due to perf regressions
TBR=fschneider@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8983027
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10332
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 4 Jan 2012 17:16:04 +0000 (17:16 +0000)]
Make sure transitioned arrays efficiently call builtin Array functions
Loosen the requirement for Map equivalency on several map checks, including checks up the prototype chain, that are not sensitive to ElementsKinds. These selected map checks should also match against FAST_DOUBLE_ELEMENT and FAST_ELEMENT transitions of the original map. This specifically helps all variants of transitioned JSArrays to still efficiently call builtins like push, pop and sort.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9015020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10331
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 4 Jan 2012 15:12:15 +0000 (15:12 +0000)]
Randomize the seed used for string hashing. This helps guard against
CPU-eating DOS attacks against node.js servers. Based on code from
Bert Belder. This version only solves the issue for those that compile
V8 themselves or those that do not use snapshots. A snapshot-based
precompiled V8 will still have predictable string hash codes.
Review URL: http://codereview.chromium.org/9086006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10330
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 4 Jan 2012 14:45:29 +0000 (14:45 +0000)]
Fix a few preprocessor macros that could capture an 'else'.
Namely they are SLOW_ASSERT, RETURN_IF_SCHEDULED_EXCEPTION, and
RETURN_IF_EMTPY_HANDLE_VALUE.
R=svenpanne@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8983016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10329
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 4 Jan 2012 09:58:21 +0000 (09:58 +0000)]
Fix windows build.
Review URL: http://codereview.chromium.org/8983014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10328
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 4 Jan 2012 09:40:47 +0000 (09:40 +0000)]
MIPS: Undo allocation of half-formed array during elements transition
Port r10320 (
bb429e82)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9082001
Patch from Gergely Kis <gergely@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10327
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 4 Jan 2012 09:39:35 +0000 (09:39 +0000)]
MIPS: Add InternalArrayCodeGeneric
Port r10308 (
4e74cc88)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9078002
Patch from Gergely Kis <gergely@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10326
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 4 Jan 2012 09:38:08 +0000 (09:38 +0000)]
MIPS: Ensure that InternalArrays remain InternalArrays regardless of how they are constructed.
Port r10306 (
9141da8e)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9080001
Patch from Gergely Kis <gergely@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10325
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 4 Jan 2012 08:48:35 +0000 (08:48 +0000)]
Implement callback when script finishes running in V8 API.
TEST=test-api/LeaveScriptCallback
Review URL: http://codereview.chromium.org/8937003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10323
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 3 Jan 2012 16:38:42 +0000 (16:38 +0000)]
Update LICENSE file
R=erik.corry@gmail.com
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9074002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10322
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 3 Jan 2012 10:45:28 +0000 (10:45 +0000)]
Improve performance of Math.min and Math.max for the case of two arguments.
BUG=v8:1325
TEST=
Review URL: http://codereview.chromium.org/9065008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10321
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 3 Jan 2012 09:39:34 +0000 (09:39 +0000)]
Undo allocation of half-formed array during elements transition
R=vegorov@chromium.org
BUG=none
TEST=no asserts in debug tests with smi-only-array on
Review URL: http://codereview.chromium.org/9015023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10320
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Mon, 2 Jan 2012 15:22:21 +0000 (15:22 +0000)]
Make Runtime_Apply safer.
There is a call to Object::GetElement that could conceivably cause a GC.
Handlify all raw pointer local variables.
R=vegorov@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8952028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10319
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 2 Jan 2012 09:46:47 +0000 (09:46 +0000)]
Fix typo in tools/grokdump.py. Stack pointer on x86 is esp not rbp.
R=fschneider@chromium.org
Review URL: http://codereview.chromium.org/9069001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10316
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Mon, 2 Jan 2012 09:20:45 +0000 (09:20 +0000)]
Prepare push to trunk. Now working on version 3.8.5.
R=danno@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8952023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10313
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 2 Jan 2012 08:54:01 +0000 (08:54 +0000)]
Filter transitions while searching for CONSTANT_FUNCTION property in Call::ComputeTarget.
Otherwise transition will hide CONSTANT_FUNCTION property with the same name residing on the prototype.
R=danno@chromium.org
BUG=v8:1883
Review URL: http://codereview.chromium.org/9064003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10312
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 30 Dec 2011 14:28:14 +0000 (14:28 +0000)]
Reland 10309: Ensure large Smi-only arrays don't transition to FAST_DOUBLE_ARRAY
TBR=jkummerow@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9051014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10311
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 30 Dec 2011 13:42:21 +0000 (13:42 +0000)]
Rollback 10309
TBR=jkummerow@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8968042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10310
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 30 Dec 2011 12:54:23 +0000 (12:54 +0000)]
Ensure large Smi-only arrays don't transition to FAST_DOUBLE_ARRAY
BUG=v8:1849
TEST=test/mjsunit/regress/regress-1849.js
Review URL: http://codereview.chromium.org/8968028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10309
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 29 Dec 2011 12:19:34 +0000 (12:19 +0000)]
Add InternalArrayCodeGeneric
R=whesse@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9006051
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10308
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 28 Dec 2011 15:14:33 +0000 (15:14 +0000)]
Remove unused runtime function
R=whesse@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9008042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10307
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 27 Dec 2011 15:12:12 +0000 (15:12 +0000)]
Ensure that InternalArrays remain InternalArrays regardless of how they are constructed.
R=whesse@chromium.org
BUG=v8:1878
TEST=test/mjsunit/regress/regress-1878.js
Review URL: http://codereview.chromium.org/9016041
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10306
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 27 Dec 2011 10:03:28 +0000 (10:03 +0000)]
Prepare push to trunk. Now working on version 3.8.4.
TBR=vegorov@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9041003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10303
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 27 Dec 2011 08:41:30 +0000 (08:41 +0000)]
MIPS: fix bug in KeyedStoreIC::GenerateNonStrictArguments()
r8425 (1081f75) had fixed this originally, but those changes were
accidentally reverted when the experimental/gc branch was merged
at r9600.
BUG=
TEST=debug mozilla regress-137181
Review URL: http://codereview.chromium.org/9026006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10302
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Fri, 23 Dec 2011 10:39:01 +0000 (10:39 +0000)]
Avoid embedding new space objects into code objects in the lithium gap resolver.
R=danno@chromium.org
BUG=http://crbug.com/108296
TEST=test/mjsunit/regress/regress-108296.js
Review URL: http://codereview.chromium.org/8960004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10301
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 22 Dec 2011 16:23:47 +0000 (16:23 +0000)]
Remove unnecessary environment from LStoreKeyedFastElements.
This was a left-over from a time when bounds-check was performed
as part of this instruction.
I also refactored and improved the code for smi-only arrays.
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/9023006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10300
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Thu, 22 Dec 2011 06:33:32 +0000 (06:33 +0000)]
Enable max optimization for v8 in chromium.
First attempt to do this failed, we need per target flags.
Review URL: http://codereview.chromium.org/9018013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10297
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 21 Dec 2011 21:50:24 +0000 (21:50 +0000)]
Fix GCC 4.7 warnings:
* src/debug.cc (Debug::SetBreakPoint): Compare value not pointer.
Review URL: http://codereview.chromium.org/8971002
Patch from Tobias Burnus <burnus@net-b.de>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10296
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 21 Dec 2011 21:28:41 +0000 (21:28 +0000)]
Fix GCC 4.7 warnings.
* src/string-search.h (StringSearch): Avoid -Werror=strict-overflow
warning.
Review URL: http://codereview.chromium.org/8947022
Patch from Tobias Burnus <burnus@net-b.de>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10295
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Wed, 21 Dec 2011 16:19:55 +0000 (16:19 +0000)]
Do not reassign debug-only flag in release mode.
BUG=1871
TEST=
Review URL: http://codereview.chromium.org/9021011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10294
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 21 Dec 2011 16:14:38 +0000 (16:14 +0000)]
Fix JavaScript accessors on objects with interceptors.
This fixes how Object.defineProperty() defines JavaScript accessors on
objects with installed API interceptors. The definition itself does not
cause any interceptors to be called, whereas any subsequent accesses on
said object will still fire the interceptor. This behavior is in sync
with API accessors.
R=rossberg@chromium.org
BUG=v8:1651,chromium:94666
TEST=cctest/test-api
Review URL: http://codereview.chromium.org/9021019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10293
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Wed, 21 Dec 2011 08:51:59 +0000 (08:51 +0000)]
Uncommit free pages in all spaces on low memory notification.
BUG=v8:1669
TEST=
R=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/8969017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10289
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 21 Dec 2011 08:11:47 +0000 (08:11 +0000)]
Fix presubmit.
Review URL: http://codereview.chromium.org/9020004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10285
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 21 Dec 2011 07:50:24 +0000 (07:50 +0000)]
Prepare push to trunk. Now working on version 3.8.3.
R=ricow@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9019007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10284
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 21 Dec 2011 07:27:31 +0000 (07:27 +0000)]
Add max optimization flag to v8 build flag, chrome will use less optimization as default soon.
Review URL: http://codereview.chromium.org/9017004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10283
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Tue, 20 Dec 2011 12:59:23 +0000 (12:59 +0000)]
MIPS: Support Smi->Double->HeapObject transitions in constructed Arrays.
Port r10218 (1f42dff).
Original commit message:
Also several bugs with Smi/double elements handling and make Ensure* routines more flexible.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8894030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10282
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 20 Dec 2011 12:36:36 +0000 (12:36 +0000)]
MIPS: Clean up handling of global cell stores in the optimizing compiler.
Port r10280 (5f6aec5).
Original commit message:
Tell the register allocator the value is not overwritten. Never use
temporary registers on ia32, avoid them on x64 and ARM. Restore the
original copyright date on assembler.cc.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9004017
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10281
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 20 Dec 2011 10:57:12 +0000 (10:57 +0000)]
Clean up handling of global cell stores in the optimizing compiler.
Tell the register allocator the value is not overwritten. Never use
temporary registers on ia32, avoid them on x64 and ARM. Restore the
original copyright date on assembler.cc.
R=fschneider@chromium.org
BUG=v8:1870
TEST=
Review URL: http://codereview.chromium.org/8965038
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10280
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 20 Dec 2011 08:49:51 +0000 (08:49 +0000)]
Fix handling of foreign callbacks in DefineOwnProperty.
We use foreign callbacks to make some properties shadow internal values
but still behave as data properties from within JavaScript. This means
when a value is passed to Object.defineProperty() on such a property,
it should update the internal value instead of redefinind the property
and destroying the shadowing.
R=rossberg@chromium.org
BUG=v8:1530
TEST=mjsunit/regress/regress-1530,test262/S15.3.3.1_A4
Review URL: http://codereview.chromium.org/8996008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10279
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Mon, 19 Dec 2011 12:39:52 +0000 (12:39 +0000)]
Fix bug with filtering of foreign context maps in the type feedback.
The first attempt did not properly handle keyed loads/stores and
did not check the constructors of the objects in the prototype
chain.
Added two more tests to handle the fixed cases.
BUG=v8:1823
TEST=LeakGlobalObjectViaMapKeyed,LeakGlobalContextViaMapProto
Review URL: http://codereview.chromium.org/8974009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10277
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 19 Dec 2011 11:57:47 +0000 (11:57 +0000)]
Prepare push to trunk. Now working on version 3.8.2
Review URL: http://codereview.chromium.org/8953026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10274
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 19 Dec 2011 11:33:54 +0000 (11:33 +0000)]
Do not delay sweeping of pages that are completely free.
R=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/8997004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10273
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 16 Dec 2011 17:00:26 +0000 (17:00 +0000)]
Add tools/gyp/preparser_lib.vcproj to svn:ignore
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10272
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 16 Dec 2011 13:46:01 +0000 (13:46 +0000)]
Fixed --print-source crash.
BUG=v8:1866
TEST=d8 --print-source
Review URL: http://codereview.chromium.org/8969021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10271
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 16 Dec 2011 13:37:20 +0000 (13:37 +0000)]
Fix Test262 command line in test harness.
This just simplifies the command line used to run test cases, allowing
to copy them from the test harness output without editing. The passed
expression is obsolete by now.
R=yangguo@chromium.org
Review URL: http://codereview.chromium.org/8966023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10270
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 16 Dec 2011 12:54:08 +0000 (12:54 +0000)]
Remove bogus writability check in DefineGetterSetter.
R=rossberg@chromium.org
TEST=test262
Review URL: http://codereview.chromium.org/8951013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10269
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 16 Dec 2011 08:38:52 +0000 (08:38 +0000)]
Change --print-all-code to include --code-comments.
Review URL: http://codereview.chromium.org/8968010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10268
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 17:00:27 +0000 (17:00 +0000)]
Introduce --print-all-code flag and infrastructure for one flag to imply another flag.
Review URL: http://codereview.chromium.org/8957009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10267
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 14:24:07 +0000 (14:24 +0000)]
Fix cctest/test-hashing on MIPS.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8953016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10266
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 14:04:50 +0000 (14:04 +0000)]
MIPS: Porting r10252 to ARM.
Port r10262 (694b67).
BUG=
TEST=
Review URL: http://codereview.chromium.org/8947017
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10265
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 13:38:46 +0000 (13:38 +0000)]
MIPS: Porting r10221 to ARM (avoid bailing out to runtime for short substrings).
Port r10250 (77889cc).
BUG=
TEST=
Review URL: http://codereview.chromium.org/8953013
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10264
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 15 Dec 2011 12:13:34 +0000 (12:13 +0000)]
Add X64 minidumps support to tools/grokdump.py
R=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/8957005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10263
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 11:04:58 +0000 (11:04 +0000)]
Porting r10252 to ARM (handle external strings in generated code when concatenating short strings).
BUG=
TEST=
Review URL: http://codereview.chromium.org/8913010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10262
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 15 Dec 2011 10:59:39 +0000 (10:59 +0000)]
Porting r10252 to x64 (handle external strings in generated code when concatenating short strings).
Review URL: http://codereview.chromium.org/8909004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10261
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 15 Dec 2011 10:08:25 +0000 (10:08 +0000)]
Temporarily disable new test until no-snapshot version is fixed.
Review URL: http://codereview.chromium.org/8957004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10260
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 15 Dec 2011 09:41:28 +0000 (09:41 +0000)]
Align tools/gc-nvp-trace-processor.py with --trace-gc-nvp output.
R=erik.corry@gmail.com
BUG=
TEST=
Review URL: http://codereview.chromium.org/8915005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10259
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 14 Dec 2011 14:55:16 +0000 (14:55 +0000)]
Mark Test262 test cases for known issue 1475.
R=rossberg@chromium.org
BUG=v8:1475
TEST=test262/15.2.3.6-4-4??
Review URL: http://codereview.chromium.org/8911006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10258
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 14 Dec 2011 14:01:54 +0000 (14:01 +0000)]
Filter out maps from different global context when collecting type feedback.
This avoid leaking memory because optimized code may hold on to maps
from different tabs otherwise.
BUG=v8:1823, 102895
Review URL: http://codereview.chromium.org/8892002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10257
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 14 Dec 2011 13:32:34 +0000 (13:32 +0000)]
Fix outdated test expectations for array literal crankshafting
TEST=nosnap builder green
Review URL: http://codereview.chromium.org/8915006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10256
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 14 Dec 2011 13:01:27 +0000 (13:01 +0000)]
Create missing boilerplate for array literals instead of deoptimizing
BUG=107370
TEST=new additions to mjsunit/array-literal-transitions
Review URL: http://codereview.chromium.org/8914006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10255
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 14 Dec 2011 12:46:32 +0000 (12:46 +0000)]
Fix invalid usage of StoreIC_ArrayLength optimization.
This introduces an additional check into the StoreIC_ArrayLength builtin
checking that the array still has fast properties. Redifinitions of the
length property that would cause it's type or attributes to change, will
switch to slow properties, thereby invalidating said optimization.
R=svenpanne@chromium.org
BUG=v8:1756
TEST=test262
Review URL: http://codereview.chromium.org/8895025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10254
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 14 Dec 2011 11:48:55 +0000 (11:48 +0000)]
Fix nosnap builds.
Review URL: http://codereview.chromium.org/8938017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10253
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 14 Dec 2011 10:32:22 +0000 (10:32 +0000)]
Handle external strings in generated code when concatenating short strings.
TEST=string-external-cached.js
Review URL: http://codereview.chromium.org/8931025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10252
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 14 Dec 2011 10:26:24 +0000 (10:26 +0000)]
Porting r10221 to x64 (avoid bailing out to runtime for short substrings).
Review URL: http://codereview.chromium.org/8894001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10251
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 14 Dec 2011 10:22:33 +0000 (10:22 +0000)]
Porting r10221 to ARM (avoid bailing out to runtime for short substrings).
Review URL: http://codereview.chromium.org/8923002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10250
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 14 Dec 2011 08:43:55 +0000 (08:43 +0000)]
Fix two x64 code generation bugs introduced by const context slot code from r10244
TEST=mjsunit debug tests pass again.
Review URL: http://codereview.chromium.org/8932014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10249
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Tue, 13 Dec 2011 17:13:47 +0000 (17:13 +0000)]
Landing forgotten mjsunit test file from previous CL.
Patch by Fedor Indutny <fedor.indutny@gmail.com>.
Original code review: http://codereview.chromium.org/8857001/
Review URL: http://codereview.chromium.org/8935006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10245
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Tue, 13 Dec 2011 17:10:34 +0000 (17:10 +0000)]
[hydrogen] don't bailout assignments to consts
If constant variable is allocated in CONTEXT
Patch by Fedor Indutny <fedor.indutny@gmail.com>.
BUG=
TEST=
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/8857001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10244
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Tue, 13 Dec 2011 14:20:03 +0000 (14:20 +0000)]
Guard against undefined fields in global context.
BUG=v8:1860
TEST=
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/8917014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10243
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Tue, 13 Dec 2011 13:51:58 +0000 (13:51 +0000)]
Fix crash in d8 when external array ctor hits stack overflow
BUG=100859
TEST=mjsunit/regress/regress-crbug-100859
Review URL: http://codereview.chromium.org/8898021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10242
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 13 Dec 2011 13:02:08 +0000 (13:02 +0000)]
Fix GCC 4.7 warnings, which are related to char being signed in GCC
("narrowing conversion ... inside { } is ill-formed in C++11").
* src/mksnapshot.cc: Cast "char" to "unsigned char" when outputting snapshot.
* test/cctest/test-regexp.cc: Use static_cast to uc16 as the char
literal is signed.
Review URL: http://codereview.chromium.org/8825003
Patch from Tobias Burnus <burnus@net-b.de>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10241
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 13 Dec 2011 12:57:33 +0000 (12:57 +0000)]
Avoid using an invalid working directory in mjsunit/d8-os.
This test deleted its working directory and then tried to run several
shell commands which caused a failure on nfs.
Changes:
-TEST_DIR is only removed at the very end of the test
-the working directory is changed to /tmp at the beginning so that
every iteration (when running with --stress-opt) has a valid working directory
BUG=
TEST=
Review URL: http://codereview.chromium.org/8936004
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10240
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00