isaacs [Mon, 7 Jan 2013 20:31:44 +0000 (12:31 -0800)]
dtrace: More style
Continuation lines should be indented with 4 spaces, not a tab.
isaacs [Mon, 7 Jan 2013 20:20:21 +0000 (12:20 -0800)]
dtrace: Make D style more D-ish
Fedor Indutny [Thu, 27 Dec 2012 03:16:23 +0000 (07:16 +0400)]
dtrace: x64 ustack helper
Fedor Indutny [Mon, 7 Jan 2013 18:53:50 +0000 (22:53 +0400)]
dtrace: fix style in ustack helper
Trevor Norris [Tue, 19 Mar 2013 09:06:13 +0000 (02:06 -0700)]
v8: revert dtrace fix from 3.14 downgrade
Revert "v8: fix postmortem and dtrace helper build"
This reverts commit
aa985392777dbe6159ce4ca56ae79d1039e43ec7.
Bryan Cantrill [Tue, 18 Sep 2012 22:35:29 +0000 (15:35 -0700)]
v8: loosen artificial mmap constraint
Fixes #4010.
Trevor Norris [Mon, 18 Mar 2013 20:54:00 +0000 (13:54 -0700)]
bindings: update api
All compile time warnings about using deprecated APIs have been
suppressed by updating node's API. Though there are still many function
calls that can accept Isolate, and still need to be updated.
node_isolate had to be added as an extern variable in node.h and
node_object_wrap.h
Also a couple small fixes for Error handling.
Before v8 3.16.6 the error stack message was lazily written when it was
needed, which allowed you to change the message after instantiation.
Then the stack would be written with the new message the first time it
was accessed. Though that has changed. Now it creates the stack message
on instantiation. So setting a different message afterwards won't be
displayed.
This is not a complete fix for the problem. Getting error without any
message isn't very useful.
Trevor Norris [Mon, 18 Mar 2013 20:50:55 +0000 (13:50 -0700)]
v8: remove optimization switches
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
they are set globally in $(TOPLEVEL)/common.gypi.
Trevor Norris [Mon, 18 Mar 2013 20:49:34 +0000 (13:49 -0700)]
deps: update v8 to 3.17.13
Scott Blomquist [Mon, 18 Mar 2013 17:48:13 +0000 (10:48 -0700)]
test: Misc Windows unit test fixes
Fixes #5071, #5073.
* Normalize capitalization of drive letter
* Fix `exit()` typo in failure path
* Ignore symlink tests (Windows) if not elevated
The `test_relative_input_cwd()` test was failing on Windows when
`skipSymlinks` was `true`. So we won't run it if `skipSymlinks` is
`true`.
When it failed, the unhandled error caused Node to die before
having a chance to clean up, which resulted in two files missing
in subsequent unit tests:
* `test/fixtures/nested-index/one/hello.js`
* `test/fixtures/nested-index/one/index.js`
We should probably find a way to isolate this test from the other
test (`simple/test-module-loading`) that was failing when this test
poluted the disk state.
Fedor Indutny [Fri, 15 Mar 2013 18:49:31 +0000 (22:49 +0400)]
tls: write pending data of opposite side
Fix stucked CryptoStream behaviour, happening when one of the sides
locks-up in queued state.
fix #5023
Nao Iizuka [Sat, 16 Mar 2013 02:18:30 +0000 (16:18 -1000)]
readline: handle wide characters properly
Handle wide characters (such as あ, 谢, 고) as two column wide to make
cursor move properly.
Closes #555.
Closes #4994.
isaacs [Thu, 14 Mar 2013 21:16:13 +0000 (14:16 -0700)]
repl: Use a domain to catch async errors safely
Fix #2031
Sami Samhuri [Thu, 14 Mar 2013 20:49:14 +0000 (10:49 -1000)]
repl: emit 'reset' event when context is reset
Closes #1183.
isaacs [Wed, 13 Mar 2013 22:36:52 +0000 (15:36 -0700)]
Revert "fs: Missing cb errors are deprecated, not a throw"
This reverts commits
6bd8b7e5405e1cdc9f56214f5f6b741806c32e5f
and
fa05e8a2706e20a191942fe2b2273481605a1f14.
isaacs [Wed, 13 Mar 2013 22:51:24 +0000 (15:51 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
src/node_version.h
isaacs [Wed, 13 Mar 2013 22:48:56 +0000 (15:48 -0700)]
Revert "stream: Never call decoder.end() multiple times"
This reverts commit
615d809ac684a7d2cc7ee5e1aa58f0a921b529a0.
isaacs [Wed, 13 Mar 2013 21:59:42 +0000 (14:59 -0700)]
fs: Missing cb errors are deprecated, not a throw
Commit a804347 makes fs function rethrow errors when the callback is
omitted. While the right thing to do, it's a change from the old v0.8
behavior where such errors were silently ignored.
To give users time to upgrade, temporarily disable that and replace it
with a function that warns once about the deprecated behavior.
Close #5005
Ben Noordhuis [Wed, 13 Mar 2013 21:52:33 +0000 (22:52 +0100)]
doc: implicit fs callbacks don't throw in v0.10
But they will in v0.12.
Re #5005.
Ben Noordhuis [Wed, 13 Mar 2013 22:22:55 +0000 (23:22 +0100)]
doc: add note on process.title max length
Fixes #5006.
Gil Pedersen [Tue, 12 Mar 2013 14:56:30 +0000 (15:56 +0100)]
stream: Never call decoder.end() multiple times
Fixes decoder.end() being called on every push(null). As the tls module
does this, corrupt stream data could potentially be added to the end.
isaacs [Wed, 13 Mar 2013 18:22:33 +0000 (11:22 -0700)]
core: Move UNWRAP_NO_ABORT to handle_wrap.h
Otherwise it cannot be used in StreamWrap.
Forgot to include in last patch, broke the build.
Ben Noordhuis [Wed, 13 Mar 2013 17:27:09 +0000 (18:27 +0100)]
doc: path.join() arguments must be strings
In v0.8, non-string arguments were ignored. v0.10 throws an exception.
Fedor Indutny [Wed, 13 Mar 2013 12:53:27 +0000 (16:53 +0400)]
net: handle 'finish' event only after 'connect'
isaacs [Wed, 13 Mar 2013 17:16:26 +0000 (10:16 -0700)]
core: Unwrap without aborting in handle fd getter
isaacs [Wed, 13 Mar 2013 17:15:30 +0000 (10:15 -0700)]
blog: Fix typo in typo fix
Fedor Indutny [Wed, 13 Mar 2013 12:53:27 +0000 (16:53 +0400)]
net: handle 'finish' event only after 'connect'
Nathan Rajlich [Wed, 13 Mar 2013 02:00:48 +0000 (19:00 -0700)]
blog: fix small typo in v0.10.0 release article
Nathan Rajlich [Tue, 12 Mar 2013 22:58:27 +0000 (15:58 -0700)]
doc: fix inpect() -> inspect() typo
Fedor Indutny [Tue, 12 Mar 2013 19:15:21 +0000 (23:15 +0400)]
crypto: replace BIO_free with BIO_free_all
From OpenSSL's documentation:
"If BIO_free() is called on a BIO chain it will only free one BIO
resulting in a memory leak."
and
"BIO_free_all() frees up an entire BIO chain, it does not halt if an
error occurs freeing up an individual BIO in the chain"
Fedor Indutny [Tue, 12 Mar 2013 10:18:24 +0000 (14:18 +0400)]
crypto: refactor crypto classes
Fedor Indutny [Tue, 12 Mar 2013 10:09:27 +0000 (14:09 +0400)]
crypto: merge Cipher and Decipher
Fedor Indutny [Mon, 11 Mar 2013 21:59:46 +0000 (01:59 +0400)]
crypto: split crypto classes
Nathan Rajlich [Wed, 30 Jan 2013 03:06:32 +0000 (19:06 -0800)]
util: custom `inspect()` method may return an Object
This is more like how `JSON.stringify()` works.
Closes #2711.
Nathan Rajlich [Wed, 30 Jan 2013 02:44:29 +0000 (18:44 -0800)]
console: `console.dir()` bypasses inspect() methods
Use the `customInspect: false` option of `util.inspect()` to bypass any custom
inspect() function on the object being logged.
Closes #2717.
Ben Noordhuis [Mon, 11 Mar 2013 23:03:56 +0000 (00:03 +0100)]
doc: events: add 'removeListener' event section
Amends commit 84221fd by (also) documenting the 'removeListener' event
in a dedicated section, like the 'newListener' event.
Fixes #4977.
isaacs [Mon, 11 Mar 2013 15:56:47 +0000 (08:56 -0700)]
blog: Post about v0.10.0
isaacs [Mon, 11 Mar 2013 15:49:33 +0000 (08:49 -0700)]
Now working on 0.10.1
isaacs [Mon, 11 Mar 2013 15:49:20 +0000 (08:49 -0700)]
Merge branch 'v0.10.0-release' into v0.10
isaacs [Sat, 9 Mar 2013 17:24:56 +0000 (09:24 -0800)]
2013.03.11, Version 0.10.0 (Stable)
* npm: Upgrade to 1.2.14
* core: Append filename properly in dlopen on windows (isaacs)
* zlib: Manage flush flags appropriately (isaacs)
* domains: Handle errors thrown in nested error handlers (isaacs)
* buffer: Strip high bits when converting to ascii (Ben Noordhuis)
* win/msi: Enable modify and repair (Bert Belder)
* win/msi: Add feature selection for various node parts (Bert Belder)
* win/msi: use consistent registry key paths (Bert Belder)
* child_process: support sending dgram socket (Andreas Madsen)
* fs: Raise EISDIR on Windows when calling fs.read/write on a dir (isaacs)
* unix: fix strict aliasing warnings, macro-ify functions (Ben Noordhuis)
* unix: honor UV_THREADPOOL_SIZE environment var (Ben Noordhuis)
* win/tty: fix typo in color attributes enumeration (Bert Belder)
* win/tty: don't touch insert mode or quick edit mode (Bert Belder)
isaacs [Sun, 10 Mar 2013 02:05:39 +0000 (18:05 -0800)]
stream: Don't emit 'end' unless read() called
This solves the problem of calling `readable.pipe(writable)` after the
readable stream has already emitted 'end', as often is the case when
writing simple HTTP proxies.
The spirit of streams2 is that things will work properly, even if you
don't set them up right away on the first tick.
This approach breaks down, however, because pipe()ing from an ended
readable will just do nothing. No more data will ever arrive, and the
writable will hang open forever never being ended.
However, that does not solve the case of adding a `on('end')` listener
after the stream has received the EOF chunk, if it was the first chunk
received (and thus, length was 0, and 'end' got emitted). So, with
this, we defer the 'end' event emission until the read() function is
called.
Also, in pipe(), if the source has emitted 'end' already, we call the
cleanup/onend function on nextTick. Piping from an already-ended stream
is thus the same as piping from a stream that is in the process of
ending.
Updates many tests that were relying on 'end' coming immediately, even
though they never read() from the req.
Fix #4942
isaacs [Sat, 9 Mar 2013 18:56:17 +0000 (10:56 -0800)]
stream: Avoid nextTick warning filling read buffer
In the function that pre-emptively fills the Readable queue, it relies
on a recursion through:
stream.push(chunk) ->
maybeReadMore(stream, state) ->
if (not reading more and < hwm) stream.read(0) ->
stream._read() ->
stream.push(chunk) -> repeat.
Since this was only calling read() a single time, and then relying on a
future nextTick to collect more data, it ends up causing a nextTick
recursion error (and potentially a RangeError, even) if you have a very
high highWaterMark, and are getting very small chunks pushed
synchronously in _read (as happens with TLS, or many simple test
streams).
This change implements a new approach, so that read(0) is called
repeatedly as long as it is effective (that is, the length keeps
increasing), and thus quickly fills up the buffer for streams such as
these, without any stacks overflowing.
Julian Gruber [Fri, 8 Mar 2013 18:41:28 +0000 (19:41 +0100)]
events: Handle missing error obj when domains in use
so `ee.emit('error')` doesn't throw when domains are active
create an empty error only when handled by a domain
test for when no error is provided to an error event
koichik [Sun, 10 Mar 2013 11:10:19 +0000 (20:10 +0900)]
http: ServerRequest does not timeout after 'end'
Fixes #4967
isaacs [Sun, 10 Mar 2013 02:46:39 +0000 (18:46 -0800)]
http: Do not setTimeout a not-yet-existent socket
Fixes #4967
isaacs [Sun, 10 Mar 2013 02:34:59 +0000 (18:34 -0800)]
uv: Upgrade to 5462dab
isaacs [Sat, 9 Mar 2013 17:22:00 +0000 (09:22 -0800)]
win/msi: Fix typos
isaacs [Sat, 9 Mar 2013 17:11:22 +0000 (09:11 -0800)]
npm: Upgrade to 1.2.14 (fixed)
hc [Fri, 8 Mar 2013 11:07:27 +0000 (06:07 -0500)]
http: check if incoming parser has already been freed
Fix #4948
This adds a check before setting the incoming parser
to null. Under certain circumstances it'll already be set to
null by freeParser().
Otherwise this will cause node to crash as it tries to set
null on something that is already null.
Andreas Madsen [Tue, 26 Feb 2013 17:26:09 +0000 (18:26 +0100)]
timers: consistent this keyword in setImmediate
When calling setImmediate with extra arguments the this keyword in the
callback would refer to the global object, but when not calling
setImmediate with extra arguments this would refer to the returned
handle object.
This commit fixes that inconsistency so its always set handle object.
The handle object was chosen for performance reasons.
isaacs [Sat, 9 Mar 2013 15:00:21 +0000 (07:00 -0800)]
domain: Fix double-exit on nested domains
Minor oversight in fix for #4953.
isaacs [Sat, 9 Mar 2013 05:52:36 +0000 (21:52 -0800)]
Now working on 0.11.0
isaacs [Sat, 9 Mar 2013 05:52:09 +0000 (21:52 -0800)]
Now working on 0.10.0
isaacs [Sat, 9 Mar 2013 04:26:26 +0000 (20:26 -0800)]
lint
Gil Pedersen [Fri, 8 Mar 2013 08:26:53 +0000 (09:26 +0100)]
stream: Always defer preemptive reading to improve latency
isaacs [Sat, 9 Mar 2013 02:59:44 +0000 (18:59 -0800)]
Merge remote-tracking branch 'ry/v0.8' into master
Conflicts:
AUTHORS
ChangeLog
src/node_version.h
isaacs [Sat, 9 Mar 2013 02:31:21 +0000 (18:31 -0800)]
test: Fail faster in simple/test-cluster-bind-twice-v2
Crashing on windows, but at least now it's a crash rathert han a timeout.
isaacs [Fri, 8 Mar 2013 17:29:13 +0000 (09:29 -0800)]
test: Kill zombies when debugger-client fails on windows
isaacs [Fri, 8 Mar 2013 17:10:57 +0000 (09:10 -0800)]
test: Don't run async operation in process 'exit'
Also, this seems to occasionally cause some annoying file-locking
errors in Windows. Not sure if this is the best fix, but it seems
to make the warnings go away in that spot.
isaacs [Fri, 8 Mar 2013 16:29:36 +0000 (08:29 -0800)]
test: Use copy instead of symlink in child-process-fork-exec-path
isaacs [Fri, 8 Mar 2013 00:29:30 +0000 (16:29 -0800)]
test: Trim cat output for windows
isaacs [Fri, 8 Mar 2013 00:13:52 +0000 (16:13 -0800)]
test: Sending dgram sockets to child procs not supported on windows
isaacs [Thu, 7 Mar 2013 23:14:22 +0000 (15:14 -0800)]
core: Append filename properly in dlopen on windows
Fixes simple/test-module-loading on win32
isaacs [Thu, 7 Mar 2013 22:28:32 +0000 (14:28 -0800)]
test: Make stream2-transform less timing-dependent
isaacs [Thu, 7 Mar 2013 20:04:17 +0000 (12:04 -0800)]
test: Don't fail tls-session-cache if openssl is bad
isaacs [Fri, 8 Mar 2013 15:55:45 +0000 (07:55 -0800)]
zlib: Manage flush flags appropriately
If you call z.flush();z.write('foo'); then it would try to write 'foo'
before the flush was done, triggering an assertion in the zlib binding.
Closes #4950
isaacs [Fri, 8 Mar 2013 19:12:15 +0000 (11:12 -0800)]
domains: Handle errors thrown in nested error handlers
If a domain error handler throws, it should be caught if it was
in a stack of nested domains.
Fix #4953
Ben Noordhuis [Thu, 6 Dec 2012 04:26:35 +0000 (05:26 +0100)]
buffer: speed up ascii character scanning
Speed up ASCII character scanning and conversion by 25% to 30% by scanning and
converting whole words instead of individual bytes.
Ben Noordhuis [Thu, 6 Dec 2012 04:13:14 +0000 (05:13 +0100)]
buffer: strip high bits when converting to ascii
Consider the following example:
console.log(Buffer('ú').toString('ascii'));
Before this commit, the contents of the buffer was used as-is and hence it
prints 'ú'.
Now, it prints 'C:'. Perhaps not much of an improvement but it conforms to what
the documentation says it does: strip off the high bits.
Fixes #4371.
isaacs [Fri, 8 Mar 2013 22:35:00 +0000 (14:35 -0800)]
Revert "http: check if incoming parser has already been freed"
This reverts commit
9f4c3b0d45f858d3d3021ef4b8edebf6005008ff.
hheennrryy@gmail.com [Fri, 8 Mar 2013 11:07:27 +0000 (06:07 -0500)]
http: check if incoming parser has already been freed
Fix #4948
This adds a check before setting the incoming parser
to null. Under certain circumstances it'll already be set to
null by freeParser().
Otherwise this will cause node to crash as it tries to set
null on something that is already null.
isaacs [Fri, 8 Mar 2013 21:47:36 +0000 (13:47 -0800)]
doc: Add wrk's license to LICENSE file
Bert Belder [Fri, 8 Mar 2013 00:44:42 +0000 (01:44 +0100)]
win/msi: enable modify and repair
Bert Belder [Thu, 7 Mar 2013 17:25:06 +0000 (18:25 +0100)]
win/msi: miscellaneous style cleanups
Bert Belder [Thu, 7 Mar 2013 17:22:43 +0000 (18:22 +0100)]
win/msi: don't include architecture in start menu group name
Bert Belder [Thu, 7 Mar 2013 17:22:06 +0000 (18:22 +0100)]
win/msi: update 'install finished' message
Bert Belder [Thu, 7 Mar 2013 17:01:57 +0000 (18:01 +0100)]
win/msi: clean up the 'documentation shortcuts' feature
Bert Belder [Thu, 7 Mar 2013 16:48:43 +0000 (17:48 +0100)]
win/msi: refactor 'node.js runtime' feature
* This feature now includes the start menu items.
* 'nodejsvars.bat' was renamed to 'nodevars.bat'.
* Improved feature description.
Bert Belder [Thu, 7 Mar 2013 13:44:46 +0000 (14:44 +0100)]
win/msi: make 'add to path' a separate feature
Bert Belder [Thu, 7 Mar 2013 13:08:38 +0000 (14:08 +0100)]
win/msi: separate features for ETW and perfctr support
Bert Belder [Thu, 7 Mar 2013 10:55:47 +0000 (11:55 +0100)]
win/msi: make npm a feature separate from the runtime
Bert Belder [Thu, 7 Mar 2013 10:37:07 +0000 (11:37 +0100)]
win/msi: use consistent registry key paths
Bert Belder [Wed, 6 Mar 2013 14:41:12 +0000 (15:41 +0100)]
win/msi: don't create empty npm folder in %appdata%
Npm creates this folder when it's needed. Creating it in the installer
violates the per-user / per-machine scope separation.
Bert Belder [Wed, 6 Mar 2013 14:39:07 +0000 (15:39 +0100)]
win/msi: don't install pdb file
It's only available in debug builds, and we're not providing
installer packages for debug builds anyway.
Bert Belder [Thu, 28 Feb 2013 14:29:00 +0000 (15:29 +0100)]
win/msi: define features before directories/components
Bert Belder [Fri, 8 Mar 2013 00:28:18 +0000 (01:28 +0100)]
win: make nodejsvars.bat detect whether npm is available
isaacs [Fri, 8 Mar 2013 15:35:35 +0000 (07:35 -0800)]
stream: Emit error on stream object, not global
Apparently this function got abstracted out at some point, and 'this'
wasn't changed to the correct object.
Bert Belder [Tue, 5 Mar 2013 18:38:28 +0000 (19:38 +0100)]
Revert "build, windows: disable SEH"
This is no longer necessary - the underlying issue was fixed in 01fa5ee.
This reverts commit
d87904286024f5ceb6a2d0d5f17e919c775830a0.
Bert Belder [Tue, 5 Mar 2013 18:36:29 +0000 (19:36 +0100)]
win/openssl: mark assembled object files as seh safe
There are no unsafe structured exception handlers in object files
generated from hand-crafted assembly - because they contain no exception
handlers at all.
Raymond Feng [Sat, 2 Mar 2013 18:08:08 +0000 (10:08 -0800)]
windows/msi: fix msi build issue with WiX 3.7/3.8
The `heat` tool that gathers NPM source files wasn't getting called.
Closes #4896
isaacs [Fri, 8 Mar 2013 02:17:28 +0000 (18:17 -0800)]
uv: Upgrade to b68ee40
isaacs [Thu, 7 Mar 2013 19:56:53 +0000 (11:56 -0800)]
bench: Do math on numbers in compare.js, not strings
isaacs [Wed, 6 Mar 2013 23:44:08 +0000 (15:44 -0800)]
uv: Upgrade to f89125e
Andreas Madsen [Wed, 27 Feb 2013 18:31:24 +0000 (19:31 +0100)]
child_process: support sending dgram socket
child.send can send net servers and sockets. Now that we have support
for dgram clusters this functionality should be extended to include
dgram sockets.
Ben Noordhuis [Thu, 7 Mar 2013 13:13:01 +0000 (14:13 +0100)]
doc: dgram: add v0.10 bind() behavior note
dgram.Socket#bind() is always asynchronous now. Add a note at the top
of the documentation that explains how to upgrade.
Fixes #4944.
Ben Noordhuis [Thu, 7 Mar 2013 13:10:47 +0000 (14:10 +0100)]
doc: dgram: document bind() callback argument
isaacs [Thu, 7 Mar 2013 00:22:23 +0000 (16:22 -0800)]
blog: Post for v0.8.22
isaacs [Thu, 7 Mar 2013 00:20:00 +0000 (16:20 -0800)]
Now working on 0.8.23
isaacs [Thu, 7 Mar 2013 00:19:29 +0000 (16:19 -0800)]
Merge branch 'v0.8.22-release' into v0.8
isaacs [Wed, 6 Mar 2013 23:47:29 +0000 (15:47 -0800)]
2013.03.07, Version 0.8.22 (Stable)
* npm: Update to 1.2.14
* cluster: propagate bind errors (Ben Noordhuis)
* crypto: don't assert when calling Cipher#final() twice (Ben Noordhuis)
* build, windows: disable SEH (Ben Noordhuis)