Panu Matilainen [Fri, 12 Mar 2010 18:46:00 +0000 (20:46 +0200)]
Lose unused iterator + its freeing
Panu Matilainen [Fri, 12 Mar 2010 18:43:02 +0000 (20:43 +0200)]
Remove unnecessary rpmdsSetNoPromote() calls in checkPackageSet()
- rpmdsNew() sets nopromote to the global default already
Panu Matilainen [Fri, 12 Mar 2010 18:40:05 +0000 (20:40 +0200)]
Add internal API for depsolve callback
- rpmts struct is now fully opaque within depends.c
Panu Matilainen [Fri, 12 Mar 2010 17:41:10 +0000 (19:41 +0200)]
Record problems into the transaction elements causing them
- Any problem found in transaction processing is caused, or at least
triggered by, some transaction element. Having the problems in
elements lets API users easily determine which package caused which
problem instead of having to parse problem strings in vain.
- No problem set stored in transaction set itself now, rpmtsProblems() API p
reserved by making it collect problems from our transaction elements
into a new set. The problem set fiddling in rpmtsRun() wrt %pretrans
and all is a bit crazy - always was, now its just more visible...
- Make rpmtsCheck() pass the associated transaction elements into
the lower level functions. rpmdsProblem() removed from API, it's
not particularly useful outside rpmtsCheck() internals.
- rpmts struct is now opaque within depends.c except for solve callback
- This breaks --badreloc, need to figure out something saner for the
problem filtering
Panu Matilainen [Fri, 12 Mar 2010 14:18:16 +0000 (16:18 +0200)]
Add a few API bits for problem sets in transaction elements
- make rpmteProblems() public and refcount the returned sets
- add public rpmteCleanProblems() to destroy the per-element problem sets
- add internal rpmteAddDepProblem() for adding per-element dependency problems
Panu Matilainen [Fri, 12 Mar 2010 14:11:15 +0000 (16:11 +0200)]
Move rpmps typedef into rpmtypes.h, its common enuf
Panu Matilainen [Fri, 12 Mar 2010 12:38:18 +0000 (14:38 +0200)]
Free iterators in the function which initialized them (symmetry is good)
Panu Matilainen [Fri, 12 Mar 2010 12:36:37 +0000 (14:36 +0200)]
Eliminate a bunch of pointless "can't happen" checks
- if these things actually happen, we're probably better of segfaulting...
Panu Matilainen [Fri, 12 Mar 2010 12:27:52 +0000 (14:27 +0200)]
Further cleanup the return code craziness in dependency checks
- any problems found are added to the problem set, none of these
return codes have been used since forever
Panu Matilainen [Fri, 12 Mar 2010 11:53:01 +0000 (13:53 +0200)]
Clean up dependency checking code
- unsatisfiedDepend() only ever returns 0 or 1, lose the hysterical
can't happen switch-cases and other bogus error code checking
- also lose unnecessary and mis-indented NULL-tests,
rpmdsInit() and rpmdsNext() handle NULL cleanly by themselves
Panu Matilainen [Fri, 12 Mar 2010 09:44:47 +0000 (11:44 +0200)]
Move rpmte-specific problem creation to a helper function
Panu Matilainen [Fri, 12 Mar 2010 08:20:25 +0000 (10:20 +0200)]
Split transaction member information out of rpmts to separate struct
- add internal rpmtsMembers() function to get the member structures
- the main rpmts struct is now opaque within order.c, and much closer
to being so for depends.c and transaction.c too
- no functional changes
Panu Matilainen [Fri, 12 Mar 2010 07:01:25 +0000 (09:01 +0200)]
Turn PSM into a complete blackbox
- The psm structures aren't stored or passed around by any users,
so there's no need for them to separately allocate and free the
struct, bury this all inside rpmpsmRun() which takes care of
initialization, actual actions and freeing.
- There's also no need for refcounting now as allocations are completely
contained within the rpmpsmRun() blackbox. Lose psm-debug foo which
was only used for refcount debugging.
- No functional changes
Panu Matilainen [Fri, 12 Mar 2010 06:32:15 +0000 (08:32 +0200)]
Split file state structures + routines out of rpmte to separate sources
- no functional changes
Yuri Chornoivan [Thu, 11 Mar 2010 17:56:24 +0000 (17:56 +0000)]
l10n: Updates to Ukrainian (uk) translation
Transmitted-via: Transifex (www.transifex.net)
Panu Matilainen [Thu, 11 Mar 2010 11:38:52 +0000 (13:38 +0200)]
Not all scriptlets have bodies (eg -p /sbin/ldconfig), dont expand NULLs
Panu Matilainen [Thu, 11 Mar 2010 11:34:17 +0000 (13:34 +0200)]
More dumb thinko/typo/braindamage in scriptlet expansion patches
- qformat certainly shouldn't default to on, duh
Panu Matilainen [Thu, 11 Mar 2010 11:21:20 +0000 (13:21 +0200)]
Dumb segfault on trigger scripts with no flags, doh
Panu Matilainen [Thu, 11 Mar 2010 10:06:49 +0000 (12:06 +0200)]
Support run-time macro and queryformat expansion on scriptlets
- Add per-scriptlet type flag tags to control special behavior.
- Add rpmlib dependency on scriptlet expansion - if a package relies
on scriptlet expansion it cannot be correctly installed with
a version of rpm that doesn't support it.
- Expansion is always an opt-in behavior, enabled with -q and/or -e argument
in spec. We can't just blindly expand even macros as there's no telling
%{} constructs might mean in whatever language is used for the script.
- Queryformat expansion requires great care with strange and ugly escapes
when writing scriptlets, but OTOH it permits access arbitrary header
data at runtime, which has previously been completely impossible.
- The handling of these expansions needs unifying for all scriptlet types,
the trigger scriptlet handling is uuugly. Macro expansion could be
transparently done from rpmScriptRun(), but because of their similar
syntax, macro expansion needs to happen before query format expansion,
and we dont have the header available in rpmScriptrun()
Yuri Chornoivan [Tue, 9 Mar 2010 18:15:02 +0000 (18:15 +0000)]
l10n: Initial Ukrainian translation
Transmitted-via: Transifex (www.transifex.net)
Panu Matilainen [Mon, 8 Mar 2010 13:00:15 +0000 (15:00 +0200)]
Updated Spanish translation (Héctor Daniel Cabrera through Transifex)
Panu Matilainen [Sun, 7 Mar 2010 10:43:25 +0000 (12:43 +0200)]
Updated Polish translation from Piotr Drąg
Panu Matilainen [Sat, 6 Mar 2010 09:34:09 +0000 (11:34 +0200)]
Minor cleanup to PSM_INIT stage, no functional changes
- lose redundant RPMRC_OK assignment + cosmetics
Panu Matilainen [Sat, 6 Mar 2010 09:17:29 +0000 (11:17 +0200)]
Update translations to shed non-existent messages from recent changes
Panu Matilainen [Sat, 6 Mar 2010 09:04:48 +0000 (11:04 +0200)]
Lose a couple of leftover variables from times before headerPutString()
Panu Matilainen [Sat, 6 Mar 2010 09:03:11 +0000 (11:03 +0200)]
Dont bother translators with internal error debug foo
Panu Matilainen [Sat, 6 Mar 2010 09:01:08 +0000 (11:01 +0200)]
rpmdsN() and rpmdsEVR() returning NULL here is a serious can't happen
Panu Matilainen [Mon, 1 Mar 2010 14:32:54 +0000 (16:32 +0200)]
Lose more ancient compatibility retrofit goo
- FILEUIDS, FILEGIDS and DEFAULTPREFIX are all rpm 1.x - 2.x era,
packages we can't even read anymore...
Panu Matilainen [Mon, 1 Mar 2010 14:13:52 +0000 (16:13 +0200)]
Rip out more rpm 2.x era relocation leftovers
- we can't even read packages from that timeframe, much less relocate them
Panu Matilainen [Mon, 1 Mar 2010 13:55:57 +0000 (15:55 +0200)]
Remove now unused inFtw from file lists
Panu Matilainen [Mon, 1 Mar 2010 13:52:46 +0000 (15:52 +0200)]
Lose ancient prefix remnants from build code
- since commit
840599e3d92e29e8e1c1cf7ecf4ad5c37d3bf021 in 1998, nothing
has set RPMTAG_DEFAULTPREFIX meaning fl.prefix is always NULL...
Ville Skyttä [Fri, 26 Feb 2010 17:25:04 +0000 (19:25 +0200)]
Fix rpmfcAttrDeps() for perl modules (was broken in
c03be327).
Ville Skyttä [Thu, 25 Feb 2010 17:51:25 +0000 (19:51 +0200)]
Emit highest versions of perl module deps, not first versioned ones found.
Requires the "version" module installed (perl >= 5.9 or separately), falls
back to the previous "output first versioned one found" behavior if it is
not available.
Ville Skyttä [Thu, 25 Feb 2010 17:45:10 +0000 (19:45 +0200)]
Fix open POD section leak across different files in perl.req.
Ville Skyttä [Thu, 25 Feb 2010 17:37:55 +0000 (19:37 +0200)]
Make perl.{req,prov} warn about unreadable files.
Panu Matilainen [Mon, 1 Mar 2010 09:48:28 +0000 (11:48 +0200)]
Updated Spanish translation from Héctor Daniel Cabrera (ticket #141)
Panu Matilainen [Fri, 26 Feb 2010 11:45:47 +0000 (13:45 +0200)]
Minor rpmtsCheckDSIProblems() cleanup
Panu Matilainen [Fri, 26 Feb 2010 07:36:42 +0000 (09:36 +0200)]
Lose some unnecessary includes
Panu Matilainen [Fri, 26 Feb 2010 07:17:03 +0000 (09:17 +0200)]
Hide install/erase statistics collection inside psm
Panu Matilainen [Thu, 25 Feb 2010 19:50:20 +0000 (21:50 +0200)]
Lose fluff from ensureOlder()
- p and h can't possibly be NULL in the place this gets called
- the single caller doesn't care about return value
Panu Matilainen [Thu, 25 Feb 2010 19:35:56 +0000 (21:35 +0200)]
Lose another pointless NULL-check on rpmfi iteration + an unused variable
Panu Matilainen [Thu, 25 Feb 2010 19:18:47 +0000 (21:18 +0200)]
Remove unnecessary fiddling with ts element header
- rpmteClose() takes care of freeing the header already
Panu Matilainen [Thu, 25 Feb 2010 18:52:35 +0000 (20:52 +0200)]
Lose some completely pointless "can't happen" checks
- rpmfiFC() returns 0 if called with NULL, which is ok in these cases
- rpmfiInit() and rpmfiNext() behave correctly when passed NULL, no need
check separately
- "dn" is already referenced before checking for NULL... it really
cannot happen ;)
Panu Matilainen [Thu, 25 Feb 2010 18:42:55 +0000 (20:42 +0200)]
Tidy up checkProblems() a bit, no functional changes
- avoid a million redundant calls to rpmtsFilterFlags()
- turn osOkay() and archOkay() into macros, they're suitably dumb for that
Panu Matilainen [Thu, 25 Feb 2010 18:26:28 +0000 (20:26 +0200)]
Lose some long since unnecessary includes
Panu Matilainen [Thu, 25 Feb 2010 18:18:48 +0000 (20:18 +0200)]
Duh, yet more leftover io flag stuff in psm
- should've been in commit
6193da9cad40dbbc1d7ce974ab9df96986a52183
Panu Matilainen [Thu, 25 Feb 2010 13:16:39 +0000 (15:16 +0200)]
Gah, stupid thinko in elfdeps
- for DSO's without a soname, we should be adding a *provide* of the
basename, not require
- dumb regression from commit
87c237bebfc792a8b439fa2c5a2b78328b139d50
Panu Matilainen [Thu, 25 Feb 2010 12:22:34 +0000 (14:22 +0200)]
Implement pretrans, posttrans and verifyscript as psm goals
- Loose rpmpsmScriptStage() hack and bury the psm details inside
the psm implementation
- Map the script-only goal enums to the corresponding script tag
to avoid having to re-re-re-map stuff unnecessarily
- pretrans and posttrans should really be handled as a part of PKG_INSTALL
process, but as these stages are disconnected from the main install
part we can't remember the state in the psm - it would need to be
stashed into transaction elements in the meanwhile
Panu Matilainen [Thu, 25 Feb 2010 11:54:51 +0000 (13:54 +0200)]
Separate PSM goals from individual stages
- no functional changes - supposedly
- nothing outside the PSM should need to know anything about its
internals, the general goals need to be sufficient (not the case yet)
- define goals to match rpmteType so there's no need to re-re-re-map
the operations
- loose the big unused individual stage string switch
Panu Matilainen [Thu, 25 Feb 2010 11:34:51 +0000 (13:34 +0200)]
Transaction element type is not a bitfield but a plain old enum
Panu Matilainen [Thu, 25 Feb 2010 10:36:09 +0000 (12:36 +0200)]
Improve failed transaction element behavior + logging
- handle failed element in rpmteOpen() already, avoiding need to check
everywhere else
- elements cancelled due to parent failure can further cancel their
dependent elements
- all failed, including skipped, elements are now logged
Panu Matilainen [Thu, 25 Feb 2010 10:32:57 +0000 (12:32 +0200)]
Count the number of failures for transaction elements
- this lets us track whether the package itself failed or if it
was cancelled due to parent failure
Panu Matilainen [Thu, 25 Feb 2010 09:25:15 +0000 (11:25 +0200)]
Yank out a bunch of unused defines
Panu Matilainen [Thu, 25 Feb 2010 09:05:02 +0000 (11:05 +0200)]
Lose now unnecessary progTag from psm
- our scriptlet thingie knows which progtag to use for a given script tag
already, no need to baby-feed the psm
Panu Matilainen [Thu, 25 Feb 2010 08:58:51 +0000 (10:58 +0200)]
First rough-cut version of scriptlet abstraction
- Split the low-level scriptlet machinery out of psm
- New struct to hold the necessary information about scriptlets so
we can execute them without having a header at hand.
- Trigger handling is hackish and needs more love...
Panu Matilainen [Thu, 25 Feb 2010 08:58:09 +0000 (10:58 +0200)]
Log all install/erase failures in rpmtsProcess()
Panu Matilainen [Thu, 25 Feb 2010 08:36:15 +0000 (10:36 +0200)]
Move rpmteTypeString() back to rpmte, internal only though
Panu Matilainen [Thu, 25 Feb 2010 06:28:34 +0000 (08:28 +0200)]
Kick out stillborn code
- psm aint the place to fiddle with db internals anyway
Panu Matilainen [Wed, 24 Feb 2010 14:53:52 +0000 (16:53 +0200)]
Clean up handleOneTrigger() a bit
- no functional changes (supposedly ;) - just shuffle things a bit
to condense and make it friendlier on the eyes
Panu Matilainen [Wed, 24 Feb 2010 13:02:42 +0000 (15:02 +0200)]
Lose unused PSM_RPMIO_FLAGS state
- should've been in commit
6193da9cad40dbbc1d7ce974ab9df96986a52183
Panu Matilainen [Wed, 24 Feb 2010 07:42:11 +0000 (09:42 +0200)]
Permit simple strings to be returned argv-style from headers too
Panu Matilainen [Tue, 23 Feb 2010 13:11:21 +0000 (15:11 +0200)]
The lower level script runners dont really need psm for anything now
Panu Matilainen [Wed, 24 Feb 2010 14:35:45 +0000 (16:35 +0200)]
Bury the signal queue stuff inside runExtScript()
- lose psmWait() which is just a fancy wrapper for rpmsqWait(), instead
collect scriptlet runtime stats for all scripts (previously lua wasn't
counted)
Panu Matilainen [Tue, 23 Feb 2010 12:59:25 +0000 (14:59 +0200)]
Lose psmWait(), instead collect scriptlet runtime stats for all scripts
- psmWait() which was not much more than a fancy wrapper over
rpmsqWait() predates lua scriptlets by far and no time got counted
for them at all. Useless but everybody loves stats...
Panu Matilainen [Wed, 24 Feb 2010 14:33:21 +0000 (16:33 +0200)]
Push prefix calculation higher in the psm foodchain
- Header is no longer needed for the low-level scriptlet execution
- Lose support for ancient RPMTAG_INSTALLPREFIX relocation, it was
deprecated in 1998 already. Preserve $RPM_INSTALL_PREFIX behavior
for scriptlets though.
Panu Matilainen [Mon, 22 Feb 2010 09:45:28 +0000 (11:45 +0200)]
Remove unused os and arch score from transaction elements
Panu Matilainen [Mon, 22 Feb 2010 09:13:05 +0000 (11:13 +0200)]
Handle NULL passed to rpmMachineScore()
Panu Matilainen [Thu, 18 Feb 2010 13:23:02 +0000 (15:23 +0200)]
Extract #!/usr/bin/env interpreter dependencies, part 1 (ticket #136)
- With "#!/usr/bin/env <interpreter>" shebang directives, rpm previously
only added a dependency for /usr/bin/env, completely missing the
actual interpreter. If the interpreter happens to be an absolute path, we
can just add it as is.
- Patch originally from Ville Skyttä
Panu Matilainen [Thu, 18 Feb 2010 11:23:18 +0000 (13:23 +0200)]
Perform dependency extraction solely based on collected attributes
- Yank out the now unnecessary apply table + related apply functions, simply
collect dependencies for whatever attributes we found for a given file
Panu Matilainen [Thu, 18 Feb 2010 10:44:05 +0000 (12:44 +0200)]
Classify .desktop files by just path
- Previously we required a file to be classified as text and have
.desktop suffix, for now replace that with just a regex. We'll eventually
want/need some extra qualifying logic to handle cases like these,
eg "only apply path attributes if condition X is also true"
Panu Matilainen [Thu, 18 Feb 2010 10:31:34 +0000 (12:31 +0200)]
fontconfig -> font dependency extractor rename
- No functional changes, just clearing the naming conventions to avoid
having to extra mapping for attribute -> extractor name. The current
font provides are handled by fontconfig, but that's just an internal
implementation detail.
Panu Matilainen [Thu, 18 Feb 2010 10:26:03 +0000 (12:26 +0200)]
Add debug output for file attributes
Panu Matilainen [Thu, 18 Feb 2010 10:25:04 +0000 (12:25 +0200)]
Add path coloring for versioned python interpreter itself
- pythondeps.sh knows how to figure python(abi) provide from
/usr/bin/pythonN.N version but as that's an ELF file, pythondeps.sh
never got a chance to run on that file
Panu Matilainen [Thu, 18 Feb 2010 09:47:34 +0000 (11:47 +0200)]
Replace python-specific path-coloring hack with a generic mechanism
- Use a table of regex pattern - attribute list pairs to apply any
additional path based attributes. While the fundamental type of a file
certainly does not depend on its location on the filesystem, its
location *does* have attached semantics and it'd be just silly to
ignore that fact.
- The current implementation is dumb as it ends up recompiling the regexes
and splitting the attr strings a million times. OTOH compiling the
regexes into the static rpmfcPathTable would be wrong as the patterns
can contain macros and they can vary from package to package when building
several packages on one invocation. The attribute split + regex compilation
should be done once per rpmfc instanciation...
Panu Matilainen [Thu, 18 Feb 2010 08:35:21 +0000 (10:35 +0200)]
Script/interpreter terminology renaming
- No functional changes, just making more obvious mapping between
attributes and the dependency extractor names. This also leaves the
term "interpreter" free for use for the actual interpreters, such
as interpreter(python) provides if we go that way (ticket #136).
Panu Matilainen [Thu, 18 Feb 2010 08:26:24 +0000 (10:26 +0200)]
Eliminate silly redundancy
- rpmfcSaveArg() and addAttr() were the very same thing, unify
- turn hasAttr() into a macro, its just dumb enough for that
Panu Matilainen [Wed, 17 Feb 2010 15:12:52 +0000 (17:12 +0200)]
Only run dependency extractors on files with attached attributes
- looking at file colors still works as every relevant type has
RPMFC_INCLUDE set but this includes various things we might not have
attributes for, just avoids unnecessary work and is more obvious this way
- should really have been in commit
ad2c8485ea109d37a2fb8ee9ed5f688eef282bf8
Panu Matilainen [Wed, 17 Feb 2010 15:03:19 +0000 (17:03 +0200)]
Simplify rpmfcAddFileDep()
- rpmfcHelper() already has the "deptype" character in the format
we want for file deps, pass it as argument avoiding bunch of silliness
Panu Matilainen [Wed, 17 Feb 2010 13:09:20 +0000 (15:09 +0200)]
Use text token attributes instead of bitfield for file classification
- 32 bits are nowhere near enough to meaningfully classify all the
types of data we might want to extract dependencies for, the bitfield
was already almost used up and twisty with embedded enumeration in the
middle etc. With text-based tokens, there are no limits to the total
number of known attributes or number of attributes that can be attached
to a given file. This also paves way to moving the classification table
out of librpmbuild into configuration file(s).
- Remove most of the now unused RPMFC_FOO definitions from the FCOLOR enum,
leaving just the more abstract INCLUDE, WHITE etc which control other
aspects of the operation. Also ELF is special as the value ends up
in headers, preserve it too.
Panu Matilainen [Wed, 17 Feb 2010 10:58:40 +0000 (12:58 +0200)]
Plug a silly memleak in processPackageFiles()
Panu Matilainen [Mon, 15 Feb 2010 06:52:54 +0000 (08:52 +0200)]
Skip over =for ... perlpod construct (RhBug:477516)
- patch from Ville Skyttä
Ville Skyttä [Sat, 13 Feb 2010 10:02:20 +0000 (12:02 +0200)]
Don't trump versioned module dependencies with unversioned ones.
Ville Skyttä [Sat, 13 Feb 2010 09:52:38 +0000 (11:52 +0200)]
Extract dependencies from some usual syntaxes of "use base qw(Foo)".
Ville Skyttä [Sat, 13 Feb 2010 09:04:17 +0000 (11:04 +0200)]
Trivial perl.req cleanups.
Drop dead code, comment fixes, weed out duplicate dependencies to perl
(done by rpm itself anyway, but does not hurt to do it already on this
level for cleaner results when testing).
Ville Skyttä [Wed, 10 Feb 2010 19:58:43 +0000 (21:58 +0200)]
Emit dependencies only to interpreters with absolute paths.
Ville Skyttä [Wed, 10 Feb 2010 19:56:33 +0000 (21:56 +0200)]
Allow whitespace between #! and the interpreter.
Ville Skyttä [Wed, 3 Feb 2010 21:15:31 +0000 (23:15 +0200)]
Avoid some unnecessary command invocations in scripts.
Ville Skyttä [Wed, 3 Feb 2010 21:14:27 +0000 (23:14 +0200)]
Avoid some stat() calls.
Ville Skyttä [Wed, 3 Feb 2010 21:13:07 +0000 (23:13 +0200)]
Fix reversed logic in getSystemBundles().
Panu Matilainen [Wed, 10 Feb 2010 09:12:54 +0000 (11:12 +0200)]
Permit requires extraction too from fontconfig and desktop files
- presently unused but...
Panu Matilainen [Wed, 10 Feb 2010 08:52:40 +0000 (10:52 +0200)]
Split elf dependency extraction out of librpmbuild to external helper
- Elf dependency extraction code code lifted from rpmfcELF() and refactored
to saner pieces. Having it in separate executable also frees librpmbuild
of libelf dependency, clean up the unnecessary linkage etc from
autofoo
- This lets internal dependency generator for elf files be
overridden without losing file coloring (which is required for
correct multilib handling). It also permits non-native elf files
(eg when cross-building) to be handled by providing a custom
elf dependency helper
- On the flip side, this inevitably slows down builds somewhat as
two fork-exec's are needed for every elf file, but unlike invoking
something like the python interpreter, this is a slim helper...
- All dependency extractors of the internal dependency generator are now
external helpers (how twisted is that, huh? :) and thus can be customized
and filtered through %__foo_provides|requires macros
Panu Matilainen [Wed, 10 Feb 2010 09:19:49 +0000 (11:19 +0200)]
Separate helper for script interpreters, split out of librpmbuild
- permit overriding/customization of script interepreter dependencies
- unlike the C-version, the interpreter.req only looks at the first line
for shebang: libmagic only looks at the first line too, so anything
else will never get classified as scripts in the first place
Panu Matilainen [Wed, 10 Feb 2010 07:24:21 +0000 (09:24 +0200)]
Make rpmfcSCRIPT() a bit easier on the eyes...
Panu Matilainen [Tue, 9 Feb 2010 09:35:47 +0000 (11:35 +0200)]
Move rpmVersionCompare() into a more logical place
- it has nothing to do with psm so no point having it there
Panu Matilainen [Tue, 9 Feb 2010 09:21:29 +0000 (11:21 +0200)]
Unify scriptlet execution calling conventions and error handling
- Split external scriptlet execution to separate function, called
identically with internal (ie lua) scriptlet run
- runScript() is now just a dispatcher which calls the lower level script
runner and decides whether the scriptlet failure is fatal or not.
- Only %prein and %preun scriptlet failures are considered fatal
regardless of the type of failure, as they prevent the install/erase
from taking place at all. Other failures might or might not be fatal
in terms of package functionality but rpm has no way of knowing whether
that is the case, so we only report what we know for a fact:
either the package was installed/erased or not, and either it had
scriptlet failures (for which callbacks are issued) or it didn't.
Panu Matilainen [Tue, 9 Feb 2010 08:17:19 +0000 (10:17 +0200)]
Lose unused stillborn psm threading stuff (didn't I already do this?)
Panu Matilainen [Tue, 9 Feb 2010 08:01:40 +0000 (10:01 +0200)]
Use a more reasonable type for rpmteHeaderSize()
- Headers must always fit into memory which is not true of rpm_loff_t,
and the real size is arbitrarily capped far below even that limit.
headerSizeof() uses unsigned int here, just use that...
- Doesn't affect the calculations, just type pedantry...
Panu Matilainen [Tue, 9 Feb 2010 07:47:35 +0000 (09:47 +0200)]
Move tsortInfo typedef into internal-only header
- this is not exposed outside librpm internals
Panu Matilainen [Tue, 9 Feb 2010 07:45:58 +0000 (09:45 +0200)]
Panu Matilainen [Tue, 9 Feb 2010 07:37:51 +0000 (09:37 +0200)]
Unbreak python(abi) requires generation (RhBug:562906)
- commit
426a7b6f44c6a0e1633693575c7bb6fcc76cf8a5 caused pythondeps.sh
to match too much, undo the damage
- patch from David Malcolm