commit-bot@chromium.org [Mon, 24 Feb 2014 21:59:29 +0000 (21:59 +0000)]
Add some SkPath lua functions
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
178243002
git-svn-id: http://skia.googlecode.com/svn/trunk@13572
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 21:39:01 +0000 (21:39 +0000)]
Fix ChromeOS build broken in
f84722e4777
NOTREECHECKS=true
NOTRY=true
R=scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
178413003
git-svn-id: http://skia.googlecode.com/svn/trunk@13571
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 20:22:34 +0000 (20:22 +0000)]
Build Skia for a bare-bones embedded Linux system.
Motivation:
I have downloaded a barebones Linux system built for 64-bit ARM
from linaro.org and a ARMv8 Foundation Model from arm.com to run
it on. This will let us build and test Skia on ARM64 before we
aquire hardware to allow that. This CL introduces the changes to
the build files necessary to build Skia on a barebones embedded
Linux system. I tested it with the aarch64 GCC compiler provided
by linaro.org.
Changes:
Add a "barelinux" target_os for the DEPS file. Add an optional
git download of zlib.
Changes to gyp files: these changes abstract out libpng, libz, and
giflib so that images.gyp doesn't know whether they are static or
dynamically linked. I also add the variables skia_giflib_static,
skia_libpng_static, skia_zlib_static, and skia_freetype_static,
all of which default to false but when set to true will override
the behavior of the giflib, libpng, zlib, and freetype build
targets to require them to build statically. Also, the
skia_no_fontconfig variable turns off use of the fontconfig service.
Scripts in platform_tools/barelinux/bin:
arm64_download - this script downloads the Linaro's ARMv8 Aarch64
toolchain and minimal embedded Linux system as well as ARM's
foundation model. The required files are mirrored on Google
Cloud. The script then starts a emulated Arm64 Linux system in
the background. After the boot is complete, you can SSH into the
system at port 8022 via user@localhost. The SSH key will be
downloaded into the working directery as well.
download_deps - Uses gclient to download Skia's dependencies for a
bare Linux system (the normal dependecies plus giflib, libpng, and
zlib.)
barelinux_make - this script builds a version of skia that does
not depend on external libraries, perfect for putting in an
embedded system running Linux. Assumes you have run download_deps
first.
To test:
To build a barelinux target, use the barelinux_make script.
To build for a armv8 system: skia_arch_type=arm arm_neon=0 armv7=1
armv8=1 arm_thumb=0 skia_arch_width=64 and set the CC and CXX
variables to point at the cross-compiler downloaded by
arm64_download.
R=djsollen@google.com, scroggo@google.com, borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
152513007
git-svn-id: http://skia.googlecode.com/svn/trunk@13570
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 24 Feb 2014 19:53:45 +0000 (19:53 +0000)]
Rebaselines for https://codereview.chromium.org/
158973002/
This catches the remaining configs for the GPU that were not caught
with the original rebaseline.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
177373005
git-svn-id: http://skia.googlecode.com/svn/trunk@13569
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 24 Feb 2014 19:38:20 +0000 (19:38 +0000)]
add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results
BUG=skia:
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
177073006
git-svn-id: http://skia.googlecode.com/svn/trunk@13568
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 18:59:48 +0000 (18:59 +0000)]
Add getClipStack method to lua SkCanvas
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
177933003
git-svn-id: http://skia.googlecode.com/svn/trunk@13567
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 18:51:43 +0000 (18:51 +0000)]
Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia.
Clean up our callers who depend on the deprecated function.
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
178003003
git-svn-id: http://skia.googlecode.com/svn/trunk@13566
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 17:28:55 +0000 (17:28 +0000)]
Add DRRect to debugger
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
177683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13565
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 17:24:15 +0000 (17:24 +0000)]
I believe this makes it clearer what is going on; namely:
saveLayers cause their enclosing MC state to become a prefix for their child canvas calls. In such cases we don't want to inadvertently close the nesting MC state but when we do (i.e., when the saveLayer's restore is seen) we want to also restore the nesting MC state to be the current one.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
176413002
git-svn-id: http://skia.googlecode.com/svn/trunk@13564
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 16:37:45 +0000 (16:37 +0000)]
adjust one mac bench range.
BUG=skia:2163
NOTRY=true
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
177533004
git-svn-id: http://skia.googlecode.com/svn/trunk@13563
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Feb 2014 15:51:15 +0000 (15:51 +0000)]
Fix compile errors in legacy copyTo().
R=reed@google.com, reed
Review URL: https://codereview.chromium.org/
178003002
git-svn-id: http://skia.googlecode.com/svn/trunk@13562
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Feb 2014 15:16:42 +0000 (15:16 +0000)]
Fix saveLayer() clipping w/filters, GPU path.
Don't modify the clipstack in saveLayer() if the kClipToLayer_SaveFlag is
not set. Without this the GPU path will clip the offscreen to the layer's
bounds, even if the flag is not set.
R=robertphillips@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
164203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13561
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 14:27:35 +0000 (14:27 +0000)]
bench rebaseline with new parameters.
BUG=skia:2163
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
176813003
git-svn-id: http://skia.googlecode.com/svn/trunk@13560
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 13:36:21 +0000 (13:36 +0000)]
Rebaselines for https://codereview.chromium.org/
158973002/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
176683004
git-svn-id: http://skia.googlecode.com/svn/trunk@13559
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 24 Feb 2014 13:13:26 +0000 (13:13 +0000)]
use colortypes instead of bitmap::config
BUG=skia:
Review URL: https://codereview.chromium.org/
177823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13558
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 12:05:02 +0000 (12:05 +0000)]
Use vertex buffer objects instead of client side arrays in fixed-function codepaths
Pass vertices to the fixed-function shaders in vertex buffer object
stored at attribute 0. This is specified in OpenGL Compatibility
Profile Section 10.8.2 (Transferring Vertices With Vertex Attribute
Zero).
This makes future integration to Chromium command buffer better, since
the command buffer already has code for vertex buffer objects but not
vertex arrays.
Delete unused function pointers related to fixed-function codepaths.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
130423013
git-svn-id: http://skia.googlecode.com/svn/trunk@13557
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Feb 2014 04:23:39 +0000 (04:23 +0000)]
SSE2 implementation of S32_D565_Opaque
Benchmarks hitting this path can benfit from this patch.
Here are the data:
before after
gradient_radial2_mirror 10885.52 10849.48 0.33%
gradient_radial2_clamp_hicolor 11819.69 11644.83 1.48%
gradient_radial2_clamp 11816.10 11649.91 1.41%
bitmaprect_FF_filter_trans 6.27 4.88 22.17%
bitmaprect_FF_nofilter_trans 6.27 4.88 22.17%
bitmaprect_FF_filter_identity 6.31 4.86 22.98%
bitmaprect_FF_nofilter_identity 6.25 4.86 22.24%
bitmap_4444_update 6.26 5.05 19.33%
bitmap_4444_update_volatile 6.21 5.06 18.52%
bitmap_4444 6.22 5.06 18.65%
BUG=
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
172083003
git-svn-id: http://skia.googlecode.com/svn/trunk@13556
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Mon, 24 Feb 2014 03:01:55 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13555
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 23 Feb 2014 15:18:39 +0000 (15:18 +0000)]
Removes bench alerts for googleplus, forecastio.
BUG=skia:2163
NOTRY=true
R=scroggo@google.com
TBR=scroggo@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
176593002
git-svn-id: http://skia.googlecode.com/svn/trunk@13554
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 23 Feb 2014 03:59:35 +0000 (03:59 +0000)]
add new copyTo version to SkBitmap, which takes SkColorType
BUG=skia:
R=scroggo@google.com, halcanary@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
171723007
git-svn-id: http://skia.googlecode.com/svn/trunk@13553
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 22 Feb 2014 21:53:13 +0000 (21:53 +0000)]
Removes some dynamic SKPs from bench alerts.
BUG=skia:2163
R=scroggo@google.com
TBR=scroggo@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
176463002
git-svn-id: http://skia.googlecode.com/svn/trunk@13552
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 22 Feb 2014 03:02:18 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13551
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 22 Feb 2014 00:37:18 +0000 (00:37 +0000)]
Rebaseline bench with a little wider ranges.
BUG=skia:2163
NOTRY=true
R=scroggo@google.com
TBR=scroggo@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
175513005
git-svn-id: http://skia.googlecode.com/svn/trunk@13550
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 23:11:35 +0000 (23:11 +0000)]
Revert of Enable the SSSE3 files to be built for Android when SSSE3 is not present. (https://codereview.chromium.org/
169753004/)
Reason for revert:
Breaking the build.
Non-android machines are calling sk_throw().
Original issue's description:
> Enable the SSSE3 files to be built for Android when SSSE3 is not present.
>
> Committed: http://code.google.com/p/skia/source/detail?r=13547
R=reed@google.com, mtklein@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
175543004
git-svn-id: http://skia.googlecode.com/svn/trunk@13549
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 22:41:56 +0000 (22:41 +0000)]
Add effect-based clipping for circular "tab" style rrects.
BUG=skia:2181
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
175423002
git-svn-id: http://skia.googlecode.com/svn/trunk@13548
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 22:35:45 +0000 (22:35 +0000)]
Enable the SSSE3 files to be built for Android when SSSE3 is not present.
R=reed@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
169753004
git-svn-id: http://skia.googlecode.com/svn/trunk@13547
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 22:21:17 +0000 (22:21 +0000)]
Fix error on iOS native interface
NOTREECHECK=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
175913002
git-svn-id: http://skia.googlecode.com/svn/trunk@13546
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 20:11:42 +0000 (20:11 +0000)]
Fix warnings on Ubuntu13
Turn off warnings when building libwebp.
Turn off warnings when building libjpeg.
Initialize some variables immediately.
NOTRY=True
NOTREECHECKS=True
BUG=skia:2213
BUG=skia:2214
R=bsalomon@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
175383002
git-svn-id: http://skia.googlecode.com/svn/trunk@13545
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 20:09:13 +0000 (20:09 +0000)]
Use SkRRect to store rects in SkClipStack::Element
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
163483003
git-svn-id: http://skia.googlecode.com/svn/trunk@13544
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 19:49:17 +0000 (19:49 +0000)]
ARM Skia NEON patches - 12 - S32_Blend
Blitrow32: S32_Blend fix and little speed improvement
- the results are now exactly similar as the C code
- the speed has improved, especially for small values of count
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | +30% | +18% |
+-------+-----------+------------+
| 2 | 0 | 0 |
+-------+-----------+------------+
| 4 | - <1% | +14% |
+-------+-----------+------------+
| > 4 | -0.5..+5% | -0.5..+4% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13532
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
158973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13543
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 19:49:10 +0000 (19:49 +0000)]
Stub for conic section max curvature
BUG=skia:
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
175193003
git-svn-id: http://skia.googlecode.com/svn/trunk@13542
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 19:46:21 +0000 (19:46 +0000)]
Fix for ANGLE interface error
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
165673003
git-svn-id: http://skia.googlecode.com/svn/trunk@13541
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 19:19:47 +0000 (19:19 +0000)]
DM: don't run rtree when kSkipTiled is set.
Follow up to http://crrev.com/
165723009, which changed this in GM.
Tested: out/Debug/dm
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13537
NOTREECHECKS=True
NOTRY=True
R=scroggo@google.com, senorblanco@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
175283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13540
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 18:46:30 +0000 (18:46 +0000)]
Factory methods for heap-allocated SkColorFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkColorFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@google.com, reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
175293002
git-svn-id: http://skia.googlecode.com/svn/trunk@13539
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 18:45:30 +0000 (18:45 +0000)]
Add hooks for GL_EXT_debug_marker in gpu
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
174123003
git-svn-id: http://skia.googlecode.com/svn/trunk@13538
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 18:33:25 +0000 (18:33 +0000)]
DM: don't run rtree when kSkipTiled is set.
Follow up to http://crrev.com/
165723009, which changed this in GM.
Tested: out/Debug/dm
BUG=skia:
R=scroggo@google.com, senorblanco@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
175283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13537
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 18:18:05 +0000 (18:18 +0000)]
Merge tomhudson and mtklein SkPaint shrinking approaches.
I think this is cherry picking the best parts of both our CLs. We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc. Paints are typically 1/3 their original size when flattened in the dictionary.
bench_record on my desktop looks promising. Generally, looks faster. (Best in monospace.)
a/b skp before after
0.83 desk_techcrunch.skp 0.29 0.24
0.83 tabl_gamedeksiam.skp 0.52 0.43
0.87 desk_carsvg.skp 0.4 0.35
0.87 desk_googlehome.skp 0.038 0.033
0.87 desk_pokemonwiki.skp 3.9 3.4
0.88 desk_fontwipe.skp 0.0089 0.0078
0.88 desk_googlespreadsheet.skp 0.16 0.14
0.89 desk_jsfiddlebigcar.skp 0.027 0.024
0.89 desk_tigersvg.skp 0.038 0.034
0.89 desk_weather.skp 0.19 0.17
0.89 tabl_engadget.skp 0.37 0.33
0.89 tabl_googleblog.skp 0.28 0.25
0.9 desk_facebook.skp 0.2 0.18
0.91 desk_mapsvg.skp 0.45 0.41
0.91 desk_youtube.skp 0.22 0.2
0.92 desk_forecastio.skp 0.12 0.11
0.92 desk_googlespreadsheetdashed.skp 0.49 0.45
0.92 desk_gws.skp 0.13 0.12
0.92 desk_pinterest.skp 0.037 0.034
0.92 desk_twitter.skp 0.25 0.23
0.92 tabl_culturalsolutions.skp 0.26 0.24
0.92 tabl_gspro.skp 0.072 0.066
0.92 tabl_mercurynews.skp 0.26 0.24
0.93 desk_booking.skp 0.46 0.43
0.93 desk_chalkboard.skp 0.28 0.26
0.93 desk_linkedin.skp 0.14 0.13
0.93 desk_mobilenews.skp 0.28 0.26
0.93 tabl_cuteoverload.skp 0.46 0.43
0.93 tabl_deviantart.skp 0.15 0.14
0.93 tabl_gmail.skp 0.029 0.027
0.93 tabl_googlecalendar.skp 0.15 0.14
0.93 tabl_mlb.skp 0.15 0.14
0.94 desk_blogger.skp 0.18 0.17
0.94 desk_jsfiddlehumperclip.skp 0.034 0.032
0.94 desk_wordpress.skp 0.33 0.31
0.94 desk_wowwiki.skp 0.94 0.88
0.94 desk_yahooanswers.skp 0.17 0.16
0.94 desk_youtubetvvideo.skp 0.017 0.016
0.94 tabl_sahadan.skp 0.093 0.087
0.94 tabl_worldjournal.skp 0.35 0.33
0.95 desk_css3gradients.skp 0.21 0.2
0.95 desk_gmailthread.skp 0.19 0.18
0.95 tabl_cnet.skp 0.42 0.4
0.95 tabl_mozilla.skp 1.9 1.8
0.95 tabl_pravda.skp 0.19 0.18
0.96 mobi_wikipedia.skp 0.55 0.53
0.96 tabl_cnn.skp 0.48 0.46
0.96 tabl_nofolo.skp 0.05 0.048
0.97 desk_googleplus.skp 0.29 0.28
0.97 tabl_frantzen.skp 0.059 0.057
0.97 tabl_onlinewsj.skp 0.38 0.37
0.97 tabl_slashdot.skp 0.1 0.097
0.97 tabl_vnexpress.skp 0.29 0.28
0.99 desk_amazon.skp 0.088 0.087
1 desk_baidu.skp 0.097 0.099
1 desk_ebay.skp 0.18 0.18
1 desk_espn.skp 0.24 0.24
1 desk_oldinboxapp.skp 0.026 0.026
1 desk_rectangletransition.skp 0.014 0.014
1 desk_samoasvg.skp 0.23 0.24
1 desk_yahoogames.skp 0.029 0.029
1 desk_yahoosports.skp 0.0033 0.0033
1 desk_youtubetvbrowse.skp 0.01 0.01
1 tabl_androidpolice.skp 0.65 0.65
1 tabl_digg.skp 0.33 0.33
1 tabl_hsfi.skp 0.32 0.32
1 tabl_nytimes.skp 0.22 0.22
1 tabl_techmeme.skp 0.069 0.072
1 tabl_ukwsj.skp 0.35 0.35
1.1 desk_sfgate.skp 0.25 0.28
BUG=skia:2190,skia:2194
Committed: http://code.google.com/p/skia/source/detail?r=13487
Committed: http://code.google.com/p/skia/source/detail?r=13496
R=tomhudson@google.com, reed@google.com, mtklein@google.com, robertphillips@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
158913005
git-svn-id: http://skia.googlecode.com/svn/trunk@13536
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 17:52:29 +0000 (17:52 +0000)]
Hide GrRRectEffect class from header
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
175233002
git-svn-id: http://skia.googlecode.com/svn/trunk@13535
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 17:52:17 +0000 (17:52 +0000)]
Revert of ARM Skia NEON patches - 12 - S32_Blend (https://codereview.chromium.org/
158973002/)
Reason for revert:
Breaking the build.
See http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-Nexus4/builds/2966 (and others).
We are getting warnings that vsrc and vdst may be uninitialized. Please fix and resubmit.
Original issue's description:
> ARM Skia NEON patches - 12 - S32_Blend
>
> Blitrow32: S32_Blend fix and little speed improvement
>
> - the results are now exactly similar as the C code
> - the speed has improved, especially for small values of count
>
> +-------+-----------+------------+
> | count | Cortex-A9 | Cortex-A15 |
> +-------+-----------+------------+
> | 1 | +30% | +18% |
> +-------+-----------+------------+
> | 2 | 0 | 0 |
> +-------+-----------+------------+
> | 4 | - <1% | +14% |
> +-------+-----------+------------+
> | > 4 | -0.5..+5% | -0.5..+4% |
> +-------+-----------+------------+
>
> Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13532
R=djsollen@google.com, mtklein@google.com, kevin.petit@arm.com
TBR=djsollen@google.com, kevin.petit@arm.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
175433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13534
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 21 Feb 2014 17:46:37 +0000 (17:46 +0000)]
Fix saveLayer bugs in SkMatrixClipStateMgr
https://codereview.chromium.org/
169283011/
git-svn-id: http://skia.googlecode.com/svn/trunk@13533
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 17:40:35 +0000 (17:40 +0000)]
ARM Skia NEON patches - 12 - S32_Blend
Blitrow32: S32_Blend fix and little speed improvement
- the results are now exactly similar as the C code
- the speed has improved, especially for small values of count
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | +30% | +18% |
+-------+-----------+------------+
| 2 | 0 | 0 |
+-------+-----------+------------+
| 4 | - <1% | +14% |
+-------+-----------+------------+
| > 4 | -0.5..+5% | -0.5..+4% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
158973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13532
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 15:27:49 +0000 (15:27 +0000)]
Potential fix for array bounds warning.
BUG=skia:2123
R=caryclark@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
164753003
git-svn-id: http://skia.googlecode.com/svn/trunk@13531
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 15:04:07 +0000 (15:04 +0000)]
Rebaselines for https://codereview.chromium.org/
167433002/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, hshi@chromium.org
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
174093006
git-svn-id: http://skia.googlecode.com/svn/trunk@13530
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 12:20:45 +0000 (12:20 +0000)]
override new virtual onDrawDRRect in util canvas subclasses
BUG=skia:
R=robertphillips@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
174593003
git-svn-id: http://skia.googlecode.com/svn/trunk@13529
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 12:17:34 +0000 (12:17 +0000)]
update for coding style, remove explicit floats
BUG=skia:
R=reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
174683002
git-svn-id: http://skia.googlecode.com/svn/trunk@13528
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 10:13:32 +0000 (10:13 +0000)]
Factory methods for heap-allocated SkMaskFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkMaskFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@google.com, reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
173633003
git-svn-id: http://skia.googlecode.com/svn/trunk@13527
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 05:42:57 +0000 (05:42 +0000)]
fix the visual difference of raster vs gpu -- inverse_paths
If a path has no verbs, it is empty. If a path has verbs, but both the width and height of the bounds are zero. the path is empty too. This situation happens when you add an empty rect or circle... , say a rect{x, y, width, height} = {100, 100, 0, 0}, to a path.
For 8888 config, drawPath() checked the bounds.
For gpu config, it doesn't.
BUG=skia:2176
R=reed@google.com, bsalomon@google.com, schenney@chromium.org
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
166023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13526
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Feb 2014 03:02:02 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13525
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 02:32:36 +0000 (02:32 +0000)]
add SkCanvas::drawDRRect
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com, humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
174243003
git-svn-id: http://skia.googlecode.com/svn/trunk@13524
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Feb 2014 00:40:16 +0000 (00:40 +0000)]
Fix NaCl build for pepper_32
BUG=skia:
R=rmistry@google.com, djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
171233015
git-svn-id: http://skia.googlecode.com/svn/trunk@13523
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 22:01:53 +0000 (22:01 +0000)]
Bench rebaseline after Brian's Android improvement.
BUG=skia:2169
NOTRY=true
TBR=scroggo@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
174413003
git-svn-id: http://skia.googlecode.com/svn/trunk@13522
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 21:04:40 +0000 (21:04 +0000)]
Fix bug in deferred decoding where we don't properly pass the unpremul option to the codec.
R=reed@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
172873003
git-svn-id: http://skia.googlecode.com/svn/trunk@13521
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Feb 2014 20:55:37 +0000 (20:55 +0000)]
use colortype instead of config
patch from issue
172063004
BUG=skia:
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
173893002
git-svn-id: http://skia.googlecode.com/svn/trunk@13520
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 20:40:19 +0000 (20:40 +0000)]
Factory methods for heap-allocated SkPathEffect and SkXfermode objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkPathEffect, SkXfermode and
their subclasses non-public and instead provides factory methods for
creating these objects on the heap. We temporarily keep the constructors
of the following classes public to not break Chrome/Blink:
SkXfermode
SkCornerPathEffect
SkDashPathEffect
BUG=skia:2187
R=scroggo@google.com, reed@google.com, mtklein@google.com, bungeman@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
166583002
git-svn-id: http://skia.googlecode.com/svn/trunk@13519
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 20:13:54 +0000 (20:13 +0000)]
ARM Skia NEON patches - 20bis - BitmapProcState accurracy
Use SkFractionalInt for some calculations to improve accuracy.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:2175
NOTRY=true
R=djsollen@google.com, mtklein@google.com, hshi@chromium.org
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
167433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13518
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Feb 2014 19:43:30 +0000 (19:43 +0000)]
Add new baselines for bitmapsource, imagefiltersclipped and imagefiltersscaled GMs.
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
174203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13517
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 19:08:07 +0000 (19:08 +0000)]
Offer single-param version of deepCopyTo -- much easier to migrate to colortypes
BUG=skia:
R=reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
167683006
git-svn-id: http://skia.googlecode.com/svn/trunk@13516
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Feb 2014 18:44:17 +0000 (18:44 +0000)]
New baselines for imageblurtiled GM.
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
170303004
git-svn-id: http://skia.googlecode.com/svn/trunk@13515
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Feb 2014 17:17:57 +0000 (17:17 +0000)]
Re-enable imageresizetiled, but skip it in tilegrid and rtree.
This change makes kSkipTiled_Flag also skip --tileGrid and --rtree.
All GMs which were passing kSkipTiled_Flag before were also passing
kSkipPicture_Flag, which also skips tilegrid and rtree, so this should
have no effect on them, but provides a smaller hammer for GMs which
still want to test picture playback, but not tiling.
The exception is magnifier, which was passing only kSkipTiled_Flag,
but magnifier is an odd beast and not web-exposed, so I'm not worried
about reducing its coverage slightly.
R=scroggo@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
165723009
git-svn-id: http://skia.googlecode.com/svn/trunk@13514
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 16:22:55 +0000 (16:22 +0000)]
Updates bench alert test output to match latest changes.
BUG=skia:2193
TBR=epoger@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
167703005
git-svn-id: http://skia.googlecode.com/svn/trunk@13513
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 15:58:32 +0000 (15:58 +0000)]
Separates faster and slower bench alerts; sorts by delta.
Separate faster and slower bench alerts; sort by delta.
BUG=skia:2193
NOTRY=true
R=epoger@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
172683002
git-svn-id: http://skia.googlecode.com/svn/trunk@13512
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 15:41:17 +0000 (15:41 +0000)]
Upstream fix for DecodeBench.
Use SkBasename to get the basename.
Fixes a bug on Android where calling strrchar conflicts with
Android's setting for FORTIFY_SOURCE.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
170783012
git-svn-id: http://skia.googlecode.com/svn/trunk@13511
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Feb 2014 14:03:47 +0000 (14:03 +0000)]
Rebaseline bench after nightly Chrome update.
BUG=skia:2198
R=rmistry@google.com
TBR=scroggo@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
172263004
git-svn-id: http://skia.googlecode.com/svn/trunk@13510
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 20 Feb 2014 13:08:17 +0000 (13:08 +0000)]
Reverting r13496 (Merge tomhudson and mtklein SkPaint shrinking approaches) due to memory leaks
git-svn-id: http://skia.googlecode.com/svn/trunk@13509
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 20 Feb 2014 03:01:56 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13508
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Feb 2014 22:36:32 +0000 (22:36 +0000)]
Disable imageresizetiled GM for now due to rtree and tilegrid failures.
TBR=scroggo@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
172793006
git-svn-id: http://skia.googlecode.com/svn/trunk@13507
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Feb 2014 22:10:12 +0000 (22:10 +0000)]
Fix CTM application in SkResizeImagefilter; implement bounds traversals.
SkResizeImageFilter resizes all the pixels from its input (subject to
the input's crop rect), but the offset to be applied was incorrect.
It should take the CTM into account, so that the origin of the resize is
the world space origin, unaffected by whatever clipping is applied.
New GM imageresizetiled exercises the behaviour under
impl-side-painting-like conditions, and existing GMs now have resize
cases added.
R=reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
168283006
git-svn-id: http://skia.googlecode.com/svn/trunk@13506
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Feb 2014 22:08:36 +0000 (22:08 +0000)]
Revert "First draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilter.", aka r13504 (this was an erroneous commit).
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
172793005
git-svn-id: http://skia.googlecode.com/svn/trunk@13505
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Feb 2014 22:06:20 +0000 (22:06 +0000)]
First draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilter.
git-svn-id: http://skia.googlecode.com/svn/trunk@13504
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 19 Feb 2014 21:45:35 +0000 (21:45 +0000)]
Fix issue in image decoders where the bitmap config was not properly set.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
167763003
git-svn-id: http://skia.googlecode.com/svn/trunk@13503
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 19:30:42 +0000 (19:30 +0000)]
Fix bench to compile when SK_SUPPORTS_GPU is not provided as a compiler option
In the case that SK_SUPPORTS_GPU is not provided to the compiler, the value is
either defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change
HairlinePathBench would test that value before including anything, which led to
build errors.
BUG=skia:
R=djsollen@google.com, bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
172103007
git-svn-id: http://skia.googlecode.com/svn/trunk@13502
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 19 Feb 2014 16:57:29 +0000 (16:57 +0000)]
revert to previous behavior in installPixels, allowing for NULL address
BUG=skia:
Review URL: https://codereview.chromium.org/
172603002
git-svn-id: http://skia.googlecode.com/svn/trunk@13501
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 19 Feb 2014 15:50:25 +0000 (15:50 +0000)]
Add f suffix to 0.5 to fix mac 10.6 warning
BUG=skia:2195
Review URL: https://codereview.chromium.org/
172233004
git-svn-id: http://skia.googlecode.com/svn/trunk@13500
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 15:38:13 +0000 (15:38 +0000)]
rebaseline_server: extract common unittest code, and rename tests/ -> testdata/
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
170803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13499
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 15:18:05 +0000 (15:18 +0000)]
Analytic rrect clip for cicular corners, radius >= 0.5
BUG=skia:2181
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
171413004
git-svn-id: http://skia.googlecode.com/svn/trunk@13498
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 15:11:23 +0000 (15:11 +0000)]
This CL improves saveLayer handling in the SkMatrixClipStateMgr by:
1) no longer storing the clip skip offsets in the stack (since saveLayers can force multiple clip states to be open at one time)
2) writing out only the clips that are relative to the saveLayer's clip state
3) updates the testing harness to accept a save/restore bracketing a saveLayer/restore (since clips have to be applied to the saveLayer's result upon restore)
R=bsalomon@google.com, epoger@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
164823003
git-svn-id: http://skia.googlecode.com/svn/trunk@13497
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 13:55:07 +0000 (13:55 +0000)]
Merge tomhudson and mtklein SkPaint shrinking approaches.
I think this is cherry picking the best parts of both our CLs. We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc. Paints are typically 1/3 their original size when flattened in the dictionary.
bench_record on my desktop looks promising. Generally, looks faster. (Best in monospace.)
a/b skp before after
0.83 desk_techcrunch.skp 0.29 0.24
0.83 tabl_gamedeksiam.skp 0.52 0.43
0.87 desk_carsvg.skp 0.4 0.35
0.87 desk_googlehome.skp 0.038 0.033
0.87 desk_pokemonwiki.skp 3.9 3.4
0.88 desk_fontwipe.skp 0.0089 0.0078
0.88 desk_googlespreadsheet.skp 0.16 0.14
0.89 desk_jsfiddlebigcar.skp 0.027 0.024
0.89 desk_tigersvg.skp 0.038 0.034
0.89 desk_weather.skp 0.19 0.17
0.89 tabl_engadget.skp 0.37 0.33
0.89 tabl_googleblog.skp 0.28 0.25
0.9 desk_facebook.skp 0.2 0.18
0.91 desk_mapsvg.skp 0.45 0.41
0.91 desk_youtube.skp 0.22 0.2
0.92 desk_forecastio.skp 0.12 0.11
0.92 desk_googlespreadsheetdashed.skp 0.49 0.45
0.92 desk_gws.skp 0.13 0.12
0.92 desk_pinterest.skp 0.037 0.034
0.92 desk_twitter.skp 0.25 0.23
0.92 tabl_culturalsolutions.skp 0.26 0.24
0.92 tabl_gspro.skp 0.072 0.066
0.92 tabl_mercurynews.skp 0.26 0.24
0.93 desk_booking.skp 0.46 0.43
0.93 desk_chalkboard.skp 0.28 0.26
0.93 desk_linkedin.skp 0.14 0.13
0.93 desk_mobilenews.skp 0.28 0.26
0.93 tabl_cuteoverload.skp 0.46 0.43
0.93 tabl_deviantart.skp 0.15 0.14
0.93 tabl_gmail.skp 0.029 0.027
0.93 tabl_googlecalendar.skp 0.15 0.14
0.93 tabl_mlb.skp 0.15 0.14
0.94 desk_blogger.skp 0.18 0.17
0.94 desk_jsfiddlehumperclip.skp 0.034 0.032
0.94 desk_wordpress.skp 0.33 0.31
0.94 desk_wowwiki.skp 0.94 0.88
0.94 desk_yahooanswers.skp 0.17 0.16
0.94 desk_youtubetvvideo.skp 0.017 0.016
0.94 tabl_sahadan.skp 0.093 0.087
0.94 tabl_worldjournal.skp 0.35 0.33
0.95 desk_css3gradients.skp 0.21 0.2
0.95 desk_gmailthread.skp 0.19 0.18
0.95 tabl_cnet.skp 0.42 0.4
0.95 tabl_mozilla.skp 1.9 1.8
0.95 tabl_pravda.skp 0.19 0.18
0.96 mobi_wikipedia.skp 0.55 0.53
0.96 tabl_cnn.skp 0.48 0.46
0.96 tabl_nofolo.skp 0.05 0.048
0.97 desk_googleplus.skp 0.29 0.28
0.97 tabl_frantzen.skp 0.059 0.057
0.97 tabl_onlinewsj.skp 0.38 0.37
0.97 tabl_slashdot.skp 0.1 0.097
0.97 tabl_vnexpress.skp 0.29 0.28
0.99 desk_amazon.skp 0.088 0.087
1 desk_baidu.skp 0.097 0.099
1 desk_ebay.skp 0.18 0.18
1 desk_espn.skp 0.24 0.24
1 desk_oldinboxapp.skp 0.026 0.026
1 desk_rectangletransition.skp 0.014 0.014
1 desk_samoasvg.skp 0.23 0.24
1 desk_yahoogames.skp 0.029 0.029
1 desk_yahoosports.skp 0.0033 0.0033
1 desk_youtubetvbrowse.skp 0.01 0.01
1 tabl_androidpolice.skp 0.65 0.65
1 tabl_digg.skp 0.33 0.33
1 tabl_hsfi.skp 0.32 0.32
1 tabl_nytimes.skp 0.22 0.22
1 tabl_techmeme.skp 0.069 0.072
1 tabl_ukwsj.skp 0.35 0.35
1.1 desk_sfgate.skp 0.25 0.28
BUG=skia:2190
Committed: http://code.google.com/p/skia/source/detail?r=13487
R=tomhudson@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
158913005
git-svn-id: http://skia.googlecode.com/svn/trunk@13496
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Feb 2014 03:09:52 +0000 (03:09 +0000)]
SSE2 implementation of S32A_D565_Opaque
microbenchmark of S32A_D565_Opaque() shows a 3x speedup after SSE optimization with various count on i7-3770.
BUG=
R=mtklein@google.com, reed@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
138163013
git-svn-id: http://skia.googlecode.com/svn/trunk@13495
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 23:32:05 +0000 (23:32 +0000)]
fix iOS build -- pass colortype, not config
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
170743002
git-svn-id: http://skia.googlecode.com/svn/trunk@13494
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 22:08:16 +0000 (22:08 +0000)]
Add link to how to generate new SKPs when increasing the picture version
BUG=skia:2041
R=robertphillips@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
170923003
git-svn-id: http://skia.googlecode.com/svn/trunk@13493
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 21:35:24 +0000 (21:35 +0000)]
installPixels returns true if null-pixels -- devolving to setConfig
fixes assumptions in chrome's ui_unittests: RenderTextTest.SelectionKeepsLigatures
R=robertphillips@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
170713006
git-svn-id: http://skia.googlecode.com/svn/trunk@13492
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 18:41:16 +0000 (18:41 +0000)]
Revert of Merge tomhudson and mtklein SkPaint shrinking approaches. (https://codereview.chromium.org/
158913005/)
Reason for revert:
Breaking the build - see https://code.google.com/p/skia/issues/detail?id=2190
Original issue's description:
> Merge tomhudson and mtklein SkPaint shrinking approaches.
>
> I think this is cherry picking the best parts of both our CLs. We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc. Paints are typically 1/3 their original size when flattened in the dictionary.
>
> bench_record on my desktop looks promising. Generally, looks faster. (Best in monospace.)
> a/b skp before after
> 0.83 desk_techcrunch.skp 0.29 0.24
> 0.83 tabl_gamedeksiam.skp 0.52 0.43
> 0.87 desk_carsvg.skp 0.4 0.35
> 0.87 desk_googlehome.skp 0.038 0.033
> 0.87 desk_pokemonwiki.skp 3.9 3.4
> 0.88 desk_fontwipe.skp 0.0089 0.0078
> 0.88 desk_googlespreadsheet.skp 0.16 0.14
> 0.89 desk_jsfiddlebigcar.skp 0.027 0.024
> 0.89 desk_tigersvg.skp 0.038 0.034
> 0.89 desk_weather.skp 0.19 0.17
> 0.89 tabl_engadget.skp 0.37 0.33
> 0.89 tabl_googleblog.skp 0.28 0.25
> 0.9 desk_facebook.skp 0.2 0.18
> 0.91 desk_mapsvg.skp 0.45 0.41
> 0.91 desk_youtube.skp 0.22 0.2
> 0.92 desk_forecastio.skp 0.12 0.11
> 0.92 desk_googlespreadsheetdashed.skp 0.49 0.45
> 0.92 desk_gws.skp 0.13 0.12
> 0.92 desk_pinterest.skp 0.037 0.034
> 0.92 desk_twitter.skp 0.25 0.23
> 0.92 tabl_culturalsolutions.skp 0.26 0.24
> 0.92 tabl_gspro.skp 0.072 0.066
> 0.92 tabl_mercurynews.skp 0.26 0.24
> 0.93 desk_booking.skp 0.46 0.43
> 0.93 desk_chalkboard.skp 0.28 0.26
> 0.93 desk_linkedin.skp 0.14 0.13
> 0.93 desk_mobilenews.skp 0.28 0.26
> 0.93 tabl_cuteoverload.skp 0.46 0.43
> 0.93 tabl_deviantart.skp 0.15 0.14
> 0.93 tabl_gmail.skp 0.029 0.027
> 0.93 tabl_googlecalendar.skp 0.15 0.14
> 0.93 tabl_mlb.skp 0.15 0.14
> 0.94 desk_blogger.skp 0.18 0.17
> 0.94 desk_jsfiddlehumperclip.skp 0.034 0.032
> 0.94 desk_wordpress.skp 0.33 0.31
> 0.94 desk_wowwiki.skp 0.94 0.88
> 0.94 desk_yahooanswers.skp 0.17 0.16
> 0.94 desk_youtubetvvideo.skp 0.017 0.016
> 0.94 tabl_sahadan.skp 0.093 0.087
> 0.94 tabl_worldjournal.skp 0.35 0.33
> 0.95 desk_css3gradients.skp 0.21 0.2
> 0.95 desk_gmailthread.skp 0.19 0.18
> 0.95 tabl_cnet.skp 0.42 0.4
> 0.95 tabl_mozilla.skp 1.9 1.8
> 0.95 tabl_pravda.skp 0.19 0.18
> 0.96 mobi_wikipedia.skp 0.55 0.53
> 0.96 tabl_cnn.skp 0.48 0.46
> 0.96 tabl_nofolo.skp 0.05 0.048
> 0.97 desk_googleplus.skp 0.29 0.28
> 0.97 tabl_frantzen.skp 0.059 0.057
> 0.97 tabl_onlinewsj.skp 0.38 0.37
> 0.97 tabl_slashdot.skp 0.1 0.097
> 0.97 tabl_vnexpress.skp 0.29 0.28
> 0.99 desk_amazon.skp 0.088 0.087
> 1 desk_baidu.skp 0.097 0.099
> 1 desk_ebay.skp 0.18 0.18
> 1 desk_espn.skp 0.24 0.24
> 1 desk_oldinboxapp.skp 0.026 0.026
> 1 desk_rectangletransition.skp 0.014 0.014
> 1 desk_samoasvg.skp 0.23 0.24
> 1 desk_yahoogames.skp 0.029 0.029
> 1 desk_yahoosports.skp 0.0033 0.0033
> 1 desk_youtubetvbrowse.skp 0.01 0.01
> 1 tabl_androidpolice.skp 0.65 0.65
> 1 tabl_digg.skp 0.33 0.33
> 1 tabl_hsfi.skp 0.32 0.32
> 1 tabl_nytimes.skp 0.22 0.22
> 1 tabl_techmeme.skp 0.069 0.072
> 1 tabl_ukwsj.skp 0.35 0.35
> 1.1 desk_sfgate.skp 0.25 0.28
>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13487
R=tomhudson@google.com, reed@google.com, mtklein@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
169183003
git-svn-id: http://skia.googlecode.com/svn/trunk@13491
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 18:13:34 +0000 (18:13 +0000)]
Revert changes which were breaking the build.
Revert "Improve saveLayer handling in SkMatrixClipStateMgr"
This reverts commit
f7d08ed626a4825317405c3708cf2896509209d6.
Revert "Compile fix for r13488 (Improve saveLayer handling in SkMatrixClipStateMgr)"
This reverts commit
a48822f3ebe86056afc76c96da73c950c80c686a.
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=True
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
170973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13490
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Feb 2014 17:53:28 +0000 (17:53 +0000)]
Compile fix for r13488 (Improve saveLayer handling in SkMatrixClipStateMgr)
git-svn-id: http://skia.googlecode.com/svn/trunk@13489
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Feb 2014 17:28:52 +0000 (17:28 +0000)]
Improve saveLayer handling in SkMatrixClipStateMgr
https://codereview.chromium.org/
164823003/
git-svn-id: http://skia.googlecode.com/svn/trunk@13488
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 17:25:25 +0000 (17:25 +0000)]
Merge tomhudson and mtklein SkPaint shrinking approaches.
I think this is cherry picking the best parts of both our CLs. We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc. Paints are typically 1/3 their original size when flattened in the dictionary.
bench_record on my desktop looks promising. Generally, looks faster. (Best in monospace.)
a/b skp before after
0.83 desk_techcrunch.skp 0.29 0.24
0.83 tabl_gamedeksiam.skp 0.52 0.43
0.87 desk_carsvg.skp 0.4 0.35
0.87 desk_googlehome.skp 0.038 0.033
0.87 desk_pokemonwiki.skp 3.9 3.4
0.88 desk_fontwipe.skp 0.0089 0.0078
0.88 desk_googlespreadsheet.skp 0.16 0.14
0.89 desk_jsfiddlebigcar.skp 0.027 0.024
0.89 desk_tigersvg.skp 0.038 0.034
0.89 desk_weather.skp 0.19 0.17
0.89 tabl_engadget.skp 0.37 0.33
0.89 tabl_googleblog.skp 0.28 0.25
0.9 desk_facebook.skp 0.2 0.18
0.91 desk_mapsvg.skp 0.45 0.41
0.91 desk_youtube.skp 0.22 0.2
0.92 desk_forecastio.skp 0.12 0.11
0.92 desk_googlespreadsheetdashed.skp 0.49 0.45
0.92 desk_gws.skp 0.13 0.12
0.92 desk_pinterest.skp 0.037 0.034
0.92 desk_twitter.skp 0.25 0.23
0.92 tabl_culturalsolutions.skp 0.26 0.24
0.92 tabl_gspro.skp 0.072 0.066
0.92 tabl_mercurynews.skp 0.26 0.24
0.93 desk_booking.skp 0.46 0.43
0.93 desk_chalkboard.skp 0.28 0.26
0.93 desk_linkedin.skp 0.14 0.13
0.93 desk_mobilenews.skp 0.28 0.26
0.93 tabl_cuteoverload.skp 0.46 0.43
0.93 tabl_deviantart.skp 0.15 0.14
0.93 tabl_gmail.skp 0.029 0.027
0.93 tabl_googlecalendar.skp 0.15 0.14
0.93 tabl_mlb.skp 0.15 0.14
0.94 desk_blogger.skp 0.18 0.17
0.94 desk_jsfiddlehumperclip.skp 0.034 0.032
0.94 desk_wordpress.skp 0.33 0.31
0.94 desk_wowwiki.skp 0.94 0.88
0.94 desk_yahooanswers.skp 0.17 0.16
0.94 desk_youtubetvvideo.skp 0.017 0.016
0.94 tabl_sahadan.skp 0.093 0.087
0.94 tabl_worldjournal.skp 0.35 0.33
0.95 desk_css3gradients.skp 0.21 0.2
0.95 desk_gmailthread.skp 0.19 0.18
0.95 tabl_cnet.skp 0.42 0.4
0.95 tabl_mozilla.skp 1.9 1.8
0.95 tabl_pravda.skp 0.19 0.18
0.96 mobi_wikipedia.skp 0.55 0.53
0.96 tabl_cnn.skp 0.48 0.46
0.96 tabl_nofolo.skp 0.05 0.048
0.97 desk_googleplus.skp 0.29 0.28
0.97 tabl_frantzen.skp 0.059 0.057
0.97 tabl_onlinewsj.skp 0.38 0.37
0.97 tabl_slashdot.skp 0.1 0.097
0.97 tabl_vnexpress.skp 0.29 0.28
0.99 desk_amazon.skp 0.088 0.087
1 desk_baidu.skp 0.097 0.099
1 desk_ebay.skp 0.18 0.18
1 desk_espn.skp 0.24 0.24
1 desk_oldinboxapp.skp 0.026 0.026
1 desk_rectangletransition.skp 0.014 0.014
1 desk_samoasvg.skp 0.23 0.24
1 desk_yahoogames.skp 0.029 0.029
1 desk_yahoosports.skp 0.0033 0.0033
1 desk_youtubetvbrowse.skp 0.01 0.01
1 tabl_androidpolice.skp 0.65 0.65
1 tabl_digg.skp 0.33 0.33
1 tabl_hsfi.skp 0.32 0.32
1 tabl_nytimes.skp 0.22 0.22
1 tabl_techmeme.skp 0.069 0.072
1 tabl_ukwsj.skp 0.35 0.35
1.1 desk_sfgate.skp 0.25 0.28
BUG=skia:
R=tomhudson@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
158913005
git-svn-id: http://skia.googlecode.com/svn/trunk@13487
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Feb 2014 16:40:42 +0000 (16:40 +0000)]
add param name w/ default arg to work around clang bug on mac 10.7
git-svn-id: http://skia.googlecode.com/svn/trunk@13486
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 16:15:05 +0000 (16:15 +0000)]
staticMethod -> StaticMethod
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
166193006
git-svn-id: http://skia.googlecode.com/svn/trunk@13485
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Feb 2014 14:38:22 +0000 (14:38 +0000)]
rebaseline_server: fail fast if skpdiff binary is not available
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
169943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13484
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 18 Feb 2014 03:01:51 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13483
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 21:21:46 +0000 (21:21 +0000)]
replace SkBitmap::Config with SkColorType in gms
add helper installMaskPixels() to SkBitmap
BUG=skia:
R=halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
169913003
git-svn-id: http://skia.googlecode.com/svn/trunk@13482
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 19:50:02 +0000 (19:50 +0000)]
Fix another clipstack element !rect doesn't mean path bug.
BUG=skia:2183
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
169763002
git-svn-id: http://skia.googlecode.com/svn/trunk@13481
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 17 Feb 2014 17:02:17 +0000 (17:02 +0000)]
Use factories instead of directly creating SkImageInfo.
R=reed@google.com
Review URL: https://codereview.chromium.org/
169363007
git-svn-id: http://skia.googlecode.com/svn/trunk@13480
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Feb 2014 16:28:05 +0000 (16:28 +0000)]
fix style nit in drawIRect
git-svn-id: http://skia.googlecode.com/svn/trunk@13479
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 15:28:55 +0000 (15:28 +0000)]
Fix spelling of class name in comment.
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
76623004
git-svn-id: http://skia.googlecode.com/svn/trunk@13478
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 15:28:00 +0000 (15:28 +0000)]
change PictureRecord (and its private subclasses) to take size instead of device
BUG=skia:
R=mtklein@google.com, scroggo@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
168983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13477
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 15:24:26 +0000 (15:24 +0000)]
still trying to kill setDevice: rename to setRootDevice (better name) and make private
BUG=skia:
COLLABORATOR=reed@google.com
R=bsalomon@google.com, scroggo@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
169023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13476
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 15:22:26 +0000 (15:22 +0000)]
Small fixes for auto generating Android.mk
Turn off -Wno-c++11-extensions for Android. The Android framework does
not support this flag. Using it gives a bunch of warnings when building,
so remove it.
Remove skia_chrome_utils from framework. They are experimental and not
used by Android.
BUG=skia:1975
R=djsollen@google.com, robertphillips@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
164793002
git-svn-id: http://skia.googlecode.com/svn/trunk@13475
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 14:20:43 +0000 (14:20 +0000)]
Remove unnecessary includes.
R=mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
163893002
git-svn-id: http://skia.googlecode.com/svn/trunk@13474
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Feb 2014 02:55:57 +0000 (02:55 +0000)]
use SkColorType instead of SkBitmap::Config in samplecode
BUG=skia:
R=reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
169063002
git-svn-id: http://skia.googlecode.com/svn/trunk@13473
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log