platform/upstream/dotnet/runtime.git
7 years agoFix morphing of block op assignments
Bruce Forstall [Sat, 28 Jan 2017 01:05:05 +0000 (17:05 -0800)]
Fix morphing of block op assignments

During morphing, block op assignments had their children set to
the "IND" morph context. This is incorrect. Previously, block
ops would "incorporate" the "IND-ness" of their children. However,
now, the operands will be a IND/BLK/OBJ node explicitly. Deleting
this incorrect code enables other changes, not yet merged, to work.

This causes no amd64 SPMI desktop asm diffs.

Commit migrated from https://github.com/dotnet/coreclr/commit/87ebd5f4fca70a50d51e5503d13b4e5a05d8d712

7 years agoMerge pull request dotnet/coreclr#9164 from justinvp/string_split
Dan Moseley [Sat, 28 Jan 2017 00:46:56 +0000 (17:46 -0700)]
Merge pull request dotnet/coreclr#9164 from justinvp/string_split

Remove unnecessary private String.SplitInternal method

Commit migrated from https://github.com/dotnet/coreclr/commit/cff36bfdfaa459cd3c0f79b75e9a4f834bb6e2a8

7 years agoUpdate glossary.md
Karel Zikmund [Fri, 27 Jan 2017 23:58:18 +0000 (15:58 -0800)]
Update glossary.md

Commit migrated from https://github.com/dotnet/coreclr/commit/7551e45532af1696dab23a5c5ac021e724c823fe

7 years agoMerge pull request dotnet/coreclr#9163 from BruceForstall/FixAddrModeBuilding
Bruce Forstall [Fri, 27 Jan 2017 22:42:26 +0000 (14:42 -0800)]
Merge pull request dotnet/coreclr#9163 from BruceForstall/FixAddrModeBuilding

Stop address mode building in TreeNodeInfoInit pass

Commit migrated from https://github.com/dotnet/coreclr/commit/44d4d3be49948136ea9453829b3e11e9cfdf0e45

7 years agoJIT: Remove empty try regions (dotnet/coreclr#8949)
Andy Ayers [Fri, 27 Jan 2017 17:36:09 +0000 (09:36 -0800)]
JIT: Remove empty try regions (dotnet/coreclr#8949)

In runtimes that do not support thread abort, a try-finally with
an empty try can be optimized to simply the content of the finally.

See documentation update for more details.

Closes dotnet/coreclr#8924.

Commit migrated from https://github.com/dotnet/coreclr/commit/119b04c1d3b7a9842eaaacb974e991e5d454f2b4

7 years agoEnable IsInPrologOrEpilog only if GC Info Decoder is not used (dotnet/coreclr#9136)
Jonghyun Park [Fri, 27 Jan 2017 11:58:40 +0000 (20:58 +0900)]
Enable IsInPrologOrEpilog only if GC Info Decoder is not used (dotnet/coreclr#9136)

* Enable IsInPrologOrEpilog only if GC Info Decoder is not used

Commit migrated from https://github.com/dotnet/coreclr/commit/13ff59c43fcf7ddede25579a8651d7ba50ecaa31

7 years agoMerge pull request dotnet/coreclr#9130 from RussKeldorph/corefx
Russ Keldorph [Fri, 27 Jan 2017 10:59:28 +0000 (02:59 -0800)]
Merge pull request dotnet/coreclr#9130 from RussKeldorph/corefx

Support new corefx workflow

Commit migrated from https://github.com/dotnet/coreclr/commit/1ba64840b54c98781d9536d4ac6052c2c1ba5242

7 years agoUse a constant to define the location of '/tmp' (dotnet/coreclr#9150)
Frederik Carlier [Fri, 27 Jan 2017 09:38:32 +0000 (10:38 +0100)]
Use a constant to define the location of '/tmp' (dotnet/coreclr#9150)

* The temp folder is in /data/local/tmp on Android, not /tmp

Commit migrated from https://github.com/dotnet/coreclr/commit/c01abca4e3d47f53ed973848d822877defaa99ce

7 years agoSupport platforms where pthread is part of libc (dotnet/coreclr#9154)
Frederik Carlier [Fri, 27 Jan 2017 09:37:49 +0000 (10:37 +0100)]
Support platforms where pthread is part of libc (dotnet/coreclr#9154)

* Make threading code compatible with Android

Commit migrated from https://github.com/dotnet/coreclr/commit/6ee7c2074cb6e9be0425af981c08593fd505f723

7 years agoAdding trivial implementations of Span Fill and Clear (dotnet/coreclr#9162)
Ahson Ahmed Khan [Fri, 27 Jan 2017 04:33:48 +0000 (20:33 -0800)]
Adding trivial implementations of Span Fill and Clear (dotnet/coreclr#9162)

Commit migrated from https://github.com/dotnet/coreclr/commit/b462e748844f61726c51b0e1792c004cf7c7647f

7 years agoRemove unnecessary private String.SplitInternal method
Justin Van Patten [Fri, 27 Jan 2017 03:42:29 +0000 (19:42 -0800)]
Remove unnecessary private String.SplitInternal method

Avoid the unnecessary intermediate method call.

Commit migrated from https://github.com/dotnet/coreclr/commit/a8b0f75f8f6849cef6a1193f220cad4d09e4f4c1

7 years agoMerge pull request dotnet/coreclr#9054 from kouvel/SpanGcReporting
Sivarv [Fri, 27 Jan 2017 03:23:26 +0000 (19:23 -0800)]
Merge pull request dotnet/coreclr#9054 from kouvel/SpanGcReporting

Fix GC info for `ByReference<T>`

Commit migrated from https://github.com/dotnet/coreclr/commit/b8f8a13b900a4b3a175e7597cd7119db3846d43a

7 years agoStop address mode building in TreeNodeInfoInit pass
Bruce Forstall [Fri, 27 Jan 2017 02:44:31 +0000 (18:44 -0800)]
Stop address mode building in TreeNodeInfoInit pass

During Lower, TryCreateAddrMode() will try to find address
modes and convert them to GT_LEA by calling genCreateAddrMode().
Later, the TreeNodeInfoInit() pass walks the IR annotating
nodes with register requirements. It was also calling
genCreateAddrMode() and then clearing various previously
created register requirements, but not actually changing the
node to a GT_LEA. In some cases (in new code I have not checked
in yet), this was leading to code that codegen couldn't handle.
It turns out this second call to genCreateAddrMode() is
unnecessary (and undesireable), so I've removed it. This causes
no asm diffs on amd64 or x86 (run on desktop: superpmi
and ngen, respectively).

Commit migrated from https://github.com/dotnet/coreclr/commit/b358e5c43373730910b1c45e6777b3ed207955da

7 years agoMerge pull request dotnet/coreclr#9123 from CarolEidt/FixCoreFx15309
Carol Eidt [Fri, 27 Jan 2017 01:54:31 +0000 (17:54 -0800)]
Merge pull request dotnet/coreclr#9123 from CarolEidt/FixCoreFx15309

Fix SIMD field issues

Commit migrated from https://github.com/dotnet/coreclr/commit/7478520c40f9ccea0ead7bd9f3853387679a6466

7 years agoPAL Tests: Centralize common code (dotnet/coreclr#9151)
Frederik Carlier [Fri, 27 Jan 2017 01:11:40 +0000 (02:11 +0100)]
PAL Tests: Centralize common code (dotnet/coreclr#9151)

Create a single COMMON_TEST_LIBRARIES variable which contains all libraries
with which the tests link.

Commit migrated from https://github.com/dotnet/coreclr/commit/a928a37a1503871b5da5c80f74fe54b9f937ddc3

7 years agoMerge pull request dotnet/coreclr#9157 from dotnet-bot/from-tfs
Brian Sullivan [Fri, 27 Jan 2017 01:08:58 +0000 (17:08 -0800)]
Merge pull request dotnet/coreclr#9157 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/7ad71a1a0a7704286c50652f103ac100e997c490

7 years agoMerge pull request dotnet/coreclr#9155 from dotnet/revert-9152-SpeedUpSync
William Godbe [Fri, 27 Jan 2017 00:55:03 +0000 (16:55 -0800)]
Merge pull request dotnet/coreclr#9155 from dotnet/revert-9152-SpeedUpSync

Revert "Speed up test native binary syncing in pipeline"

Commit migrated from https://github.com/dotnet/coreclr/commit/427b02caf1efdfb7c4ed1f8070851de564bde839

7 years agoRevert "Speed up test native binary syncing in pipeline"
William Godbe [Fri, 27 Jan 2017 00:54:39 +0000 (16:54 -0800)]
Revert "Speed up test native binary syncing in pipeline"

Commit migrated from https://github.com/dotnet/coreclr/commit/fdcda4dd6da13d903228a66625fac4d6e2a1afe0

7 years agoMerge pull request dotnet/coreclr#9152 from wtgodbe/SpeedUpSync
William Godbe [Fri, 27 Jan 2017 00:54:10 +0000 (16:54 -0800)]
Merge pull request dotnet/coreclr#9152 from wtgodbe/SpeedUpSync

Speed up test native binary syncing in pipeline

Commit migrated from https://github.com/dotnet/coreclr/commit/0ff5302eb0fab432c3af5b7277f0f86f2705f7b3

7 years agoMerge pull request dotnet/coreclr#9153 from adityamandaleeka/jitdisasm_fix
Aditya Mandaleeka [Fri, 27 Jan 2017 00:53:54 +0000 (16:53 -0800)]
Merge pull request dotnet/coreclr#9153 from adityamandaleeka/jitdisasm_fix

Fix another JIT-disasm check

Commit migrated from https://github.com/dotnet/coreclr/commit/ff68f30c877740c18bfe8f942a23b8cfcf8bd41f

7 years agoMerge pull request dotnet/coreclr#9141 from pgavlin/RemoveDeadCode
Pat Gavlin [Thu, 26 Jan 2017 23:22:02 +0000 (15:22 -0800)]
Merge pull request dotnet/coreclr#9141 from pgavlin/RemoveDeadCode

Remove dead code in the JIT.

Commit migrated from https://github.com/dotnet/coreclr/commit/7dda23fa137844c43ab2912fbbbc25cfecb471f4

7 years agoDon't require write barrier for assignment to ByRef
Koundinya Veluri [Thu, 26 Jan 2017 22:21:03 +0000 (14:21 -0800)]
Don't require write barrier for assignment to ByRef

The legacy code gen was hitting an assert when trying to use a write barrier for ByRef to ByRef assignment. RyuJIT is also generating an unnecessary write barrier but the assert is not there. As ByRefs are never in GC locations, don't require a write barrier.

Commit migrated from https://github.com/dotnet/coreclr/commit/4727df385c68b5b5f83d694167b4d0b902f5bbb9

7 years agoFix another JIT-disasm check.
Aditya Mandaleeka [Thu, 26 Jan 2017 22:53:54 +0000 (14:53 -0800)]
Fix another JIT-disasm check.

Commit migrated from https://github.com/dotnet/coreclr/commit/dc7c98f4a09d0d5e9fe476978f01724a9446ead1

7 years ago[GDB-JIT][Linux] Fix incorrect DWARF offset for primitive types with typedef node...
Evgeny Pavlov [Thu, 26 Jan 2017 22:52:31 +0000 (01:52 +0300)]
[GDB-JIT][Linux] Fix incorrect DWARF offset for primitive types with typedef node (char, byte and sbyte) (dotnet/coreclr#9106)

Commit migrated from https://github.com/dotnet/coreclr/commit/04549885287571dfb9ca59c986ad1211b27bcf39

7 years agoClean up PAL functions (dotnet/coreclr#9149)
Frederik Carlier [Thu, 26 Jan 2017 22:35:37 +0000 (23:35 +0100)]
Clean up PAL functions (dotnet/coreclr#9149)

Clean up PAL functions to enable cross-compiling for Android
* Rename wcsnlen to PAL_wcsnlen, avoids a name collision on Android
* Remove unuwed _getw and _putw functions

Commit migrated from https://github.com/dotnet/coreclr/commit/69b5d5c46e007cbb580c411b60dc501362af0486

7 years agoSpeed up test native binary syncing in pipeline
wtgodbe [Thu, 26 Jan 2017 22:01:18 +0000 (14:01 -0800)]
Speed up test native binary syncing in pipeline

Commit migrated from https://github.com/dotnet/coreclr/commit/fede4b52f4f2f4b767045a0c9c5d689d877f24b3

7 years agoMerge pull request dotnet/coreclr#9142 from AndyAyersMS/FixAsserts
Andy Ayers [Thu, 26 Jan 2017 21:18:55 +0000 (13:18 -0800)]
Merge pull request dotnet/coreclr#9142 from AndyAyersMS/FixAsserts

JIT: fix some bad asserts

Commit migrated from https://github.com/dotnet/coreclr/commit/10b85acbf6f635b9b2094b28758e60e86ab9e5d1

7 years agoMerge pull request dotnet/coreclr#9129 from RussKeldorph/defineenum
Russ Keldorph [Thu, 26 Jan 2017 21:01:52 +0000 (13:01 -0800)]
Merge pull request dotnet/coreclr#9129 from RussKeldorph/defineenum

Disable assertions in ModuleBuilder.DefineEnum

Commit migrated from https://github.com/dotnet/coreclr/commit/347a36da580d1f6889d20f2b54d014e74d900cba

7 years agoFix encoding of native signatures in the presence of Enum.GetHashCode optimization...
Jan Kotas [Thu, 26 Jan 2017 20:41:45 +0000 (12:41 -0800)]
Fix encoding of native signatures in the presence of Enum.GetHashCode optimization (dotnet/coreclr#9138)

Fixes dotnet/coreclr#9118

Commit migrated from https://github.com/dotnet/coreclr/commit/0bc4bffb923a792ac15b070610fe40a4e4629146

7 years agoFix CodeGenMirror build break due to 347243f80d62d5aaa5359ef8c8d. This includes the...
dotnet-bot [Thu, 26 Jan 2017 18:51:17 +0000 (10:51 -0800)]
Fix CodeGenMirror build break due to 347243f80d62d5aaa5359ef8c8d. This includes the new file unwindx86.cpp to be compiled.

[tfs-changeset: 1645771]

Commit migrated from https://github.com/dotnet/coreclr/commit/6d0f1745a0d298c675a7137fdda102c6d93d906f

7 years agoJIT: fix some bad asserts
Andy Ayers [Thu, 26 Jan 2017 18:48:35 +0000 (10:48 -0800)]
JIT: fix some bad asserts

Fix a few asserts that use = instead of ==.

Commit migrated from https://github.com/dotnet/coreclr/commit/d0322cdd07f8090239254f9eafb3ba52ff87337e

7 years agoRemove dead code in the JIT.
Pat Gavlin [Thu, 26 Jan 2017 18:35:03 +0000 (10:35 -0800)]
Remove dead code in the JIT.

All code under `LONG_ASG_OPS` and `FANCY_ARRAY_OPT` is statically dead
(these symbols are never defined as anything besides 0). This change
removes this cruft.

Commit migrated from https://github.com/dotnet/coreclr/commit/6c1998c03e4b888b8f000bdd9069964c76507048

7 years agoMerge pull request dotnet/coreclr#9132 from BruceForstall/FixBuildTest
Bruce Forstall [Thu, 26 Jan 2017 18:32:20 +0000 (10:32 -0800)]
Merge pull request dotnet/coreclr#9132 from BruceForstall/FixBuildTest

Fix build-test.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/63b07cc9c659642d6fb00fecf5a7b2683c82f4b1

7 years agoMerge pull request dotnet/coreclr#9125 from BruceForstall/ImproveAddrModeJitDump
Bruce Forstall [Thu, 26 Jan 2017 18:16:32 +0000 (10:16 -0800)]
Merge pull request dotnet/coreclr#9125 from BruceForstall/ImproveAddrModeJitDump

Improve address mode detection JitDumps

Commit migrated from https://github.com/dotnet/coreclr/commit/8724be8c109dd2db2f4cebd4335c8cb92bbcb17d

7 years agoMerge pull request dotnet/coreclr#9126 from BruceForstall/CleanUnusedTailcallNodes
Bruce Forstall [Thu, 26 Jan 2017 18:16:08 +0000 (10:16 -0800)]
Merge pull request dotnet/coreclr#9126 from BruceForstall/CleanUnusedTailcallNodes

Clean up unused tailcall via helper nodes

Commit migrated from https://github.com/dotnet/coreclr/commit/206522569d11c753c302142b3ee74f3336d45f86

7 years agoMerge pull request dotnet/coreclr#9133 from BruceForstall/ImproveSimdTests
Bruce Forstall [Thu, 26 Jan 2017 18:14:55 +0000 (10:14 -0800)]
Merge pull request dotnet/coreclr#9133 from BruceForstall/ImproveSimdTests

Improve SIMD tests

Commit migrated from https://github.com/dotnet/coreclr/commit/ad3fc59cc25726f130b7afee75c91e6ab5e23e71

7 years agoMerge pull request dotnet/coreclr#9120 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Thu, 26 Jan 2017 16:32:50 +0000 (08:32 -0800)]
Merge pull request dotnet/coreclr#9120 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/a126c83cbd09a9f2e060a6f0b02f0a671708f42b

7 years agoUpdate CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively
dotnet-bot [Thu, 26 Jan 2017 15:15:11 +0000 (15:15 +0000)]
Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively

Commit migrated from https://github.com/dotnet/coreclr/commit/2422572d6a4bc33d8eb3c90a4699c99d58f76ce8

7 years agoExtract GetStackParameterSize from ESPIncrOnReturn (dotnet/coreclr#9135)
Jonghyun Park [Thu, 26 Jan 2017 14:13:23 +0000 (23:13 +0900)]
Extract GetStackParameterSize from ESPIncrOnReturn (dotnet/coreclr#9135)

Commit migrated from https://github.com/dotnet/coreclr/commit/6849320915a0ed7a4f9ddc9553950f21da8d6fb9

7 years agoShow register name in UPDATEREG log (dotnet/coreclr#9134)
Jonghyun Park [Thu, 26 Jan 2017 14:10:59 +0000 (23:10 +0900)]
Show register name in UPDATEREG log (dotnet/coreclr#9134)

Commit migrated from https://github.com/dotnet/coreclr/commit/d24162bd144b37b2b353797db846aab80bf13db1

7 years agoImplement PAL_ProbeMemory with write/read to pipe (issue dotnet/coreclr#4094) (dotnet...
Mike McLaughlin [Thu, 26 Jan 2017 14:07:00 +0000 (06:07 -0800)]
Implement PAL_ProbeMemory with write/read to pipe (issue dotnet/coreclr#4094) (dotnet/coreclr#9122)

The recommended way to validate/probe memory on Linux/xplat is to use the write/read file apis to a pipe instead
of the hacky fragile hardware exception catching based probing we have now.

This builds on previous cleanup work in the master branch that removed the PAL Read/WriteProcessMemory
functions and added/replaced them with PAL_ProbeMemory. The DbgTransportSession::CheckBufferAccess that
issue mentions was also replaced.

Commit migrated from https://github.com/dotnet/coreclr/commit/69527c9bcdf1c6f163c0acd3e42a2e012f2b4328

7 years agoMerge pull request dotnet/coreclr#9114 from erozenfeld/SecurityPermissionAttribute
Eugene Rozenfeld [Thu, 26 Jan 2017 06:08:24 +0000 (22:08 -0800)]
Merge pull request dotnet/coreclr#9114 from erozenfeld/SecurityPermissionAttribute

Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.

Commit migrated from https://github.com/dotnet/coreclr/commit/4f1be9361b960ae49999d5df2e388105d974b57c

7 years agoMerge pull request dotnet/coreclr#9124 from BruceForstall/FixSimdDetection
Bruce Forstall [Thu, 26 Jan 2017 05:48:36 +0000 (21:48 -0800)]
Merge pull request dotnet/coreclr#9124 from BruceForstall/FixSimdDetection

Fix non-deterministic AVX2 detection

Commit migrated from https://github.com/dotnet/coreclr/commit/b0e0168b65813f0067648966c81befff0a439da1

7 years agoReduce number of branches and IL size of string.Trim methods (dotnet/coreclr#9115)
Justin Van Patten [Thu, 26 Jan 2017 05:30:02 +0000 (21:30 -0800)]
Reduce number of branches and IL size of string.Trim methods (dotnet/coreclr#9115)

Commit migrated from https://github.com/dotnet/coreclr/commit/fa3eac0956c70454d7f9768a58f4effb0482cc5b

7 years agoFix GC info for `ByReference<T>`
Koundinya Veluri [Mon, 23 Jan 2017 07:14:09 +0000 (23:14 -0800)]
Fix GC info for `ByReference<T>`

When `ByRefernece<T>` is directly on the stack, not inside a `Span<T>`, ComputeGCLayout was missing to include in the GC info. This was causing many span tests to fail in GCStress=c mode.

Commit migrated from https://github.com/dotnet/coreclr/commit/1fd11a910fc7b2d7c5355047987cc8cff73fbae9

7 years agoImprove SIMD tests
Bruce Forstall [Thu, 26 Jan 2017 02:53:44 +0000 (18:53 -0800)]
Improve SIMD tests

1. Since the F1/F2 tests of VectorReturn found an issue Vector2
on x86, I added variants of the same test for Vector3 and Vector4
(by basically copying F1/F2 and altering appropriately).
2. I noticed VectorMin for Vector4 wasn't checking the 'W' member,
so I fixed that.

Commit migrated from https://github.com/dotnet/coreclr/commit/92fb13263f3be6da8f2069027e20e304be5f249c

7 years agoFix build-test.cmd
Bruce Forstall [Thu, 26 Jan 2017 02:25:11 +0000 (18:25 -0800)]
Fix build-test.cmd

Move set of __TestWorkingDir so it is available even when
__BuildAgainstPackages is not defined.

Commit migrated from https://github.com/dotnet/coreclr/commit/32ef113b7c1a63a7f2bbeb343ff279b3292fe570

7 years agoSupport new corefx workflow
Russ Keldorph [Thu, 19 Jan 2017 16:58:56 +0000 (08:58 -0800)]
Support new corefx workflow

Update the run-corefx-tests.py script and enable it to run CI jobs
against corefx HEAD again.  Also update the instructions for running
corefx tests with a private coreclr.

Commit migrated from https://github.com/dotnet/coreclr/commit/d32a829c127be5195b3bf666ec063f2d9134e521

7 years agoDisable assertions in ModuleBuilder.DefineEnum
Russ Keldorph [Thu, 26 Jan 2017 01:47:55 +0000 (17:47 -0800)]
Disable assertions in ModuleBuilder.DefineEnum

The assertions fire when the enum name contains embedded null characters,
and we don't want to take a breaking change to fix that.

Fixes dotnet/coreclr#7669

Commit migrated from https://github.com/dotnet/coreclr/commit/1de6fe60fd616b4c25f64f8d1c6f17a1e45915d1

7 years agoFix SIMD field issues
Carol Eidt [Thu, 26 Jan 2017 00:18:56 +0000 (16:18 -0800)]
Fix SIMD field issues

First, when a GT_FIELD is transformed to a GT_IND, if its GTF_FLD_NULLCHECK flag is set, it must be cleared. Having this set leads to assertions or worse in value numbering. It is not entirely clear why this is only causing issues for SIMD fields.

Second, when a SIMD assignment is re-morphed, the dest may have already been changed to a GT_IND, in which case no further morphing is required (it is already a simple assignment).

Commit migrated from https://github.com/dotnet/coreclr/commit/86ebb7becabe39d8994ca98c6a62ff3fc56ed76d

7 years agoRemove System.Security.Permissions.SecurityPermissionAttribute from System.Private...
Eugene Rozenfeld [Wed, 25 Jan 2017 19:09:57 +0000 (11:09 -0800)]
Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.

When compiling with /unsafe+ Roslyn emits
  .permissionset reqmin
             = {class 'System.Security.Permissions.SecurityPermissionAttribute, System.Private.CoreLib,
             Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' =
             {property bool 'SkipVerification' = bool(true)}}
if System.Security.Permissions.SecurityPermissionAttribute is present.

In particular, System.Private.CoreLib.dll is compiled with /unsafe+ and has the above in the manifest.

https://github.com/dotnet/coreclr/commit/dotnet/coreclr@e516211b2d3a3ae2dbd80f2c94b129910a9e280d
made BclRewriter remove System.Security.Permissions.SecurityPermissionAttribute
from System.Private.CoreLib.dll but the above reference remained.

This change removes System.Security.Permissions.SecurityPermissionAttribute completely
to avoid confusion when tools are analyzing msil and try to resolve the manifest
of System.Private.CoreLib.dll.

Commit migrated from https://github.com/dotnet/coreclr/commit/b6c8522d8c02d7ed3ebc0ee8200a0d7a001b1c6d

7 years agoClean up unused tailcall via helper nodes
Bruce Forstall [Fri, 13 Jan 2017 07:28:51 +0000 (23:28 -0800)]
Clean up unused tailcall via helper nodes

For x86 tailcall via helper, delete the unused placeholder target
location nodes when they are replaced.

Commit migrated from https://github.com/dotnet/coreclr/commit/88772400b7c5dab645f8e900ddc2cae754859d47

7 years agoImprove address mode detection JitDumps
Bruce Forstall [Thu, 26 Jan 2017 00:23:55 +0000 (16:23 -0800)]
Improve address mode detection JitDumps

Commit migrated from https://github.com/dotnet/coreclr/commit/7e2a6cbd352f4be72a41e6e70b69e7ad825d74b0

7 years agoFix `Span<T>` GCStress issue on x86 (dotnet/coreclr#9116)
Koundinya Veluri [Thu, 26 Jan 2017 00:28:52 +0000 (16:28 -0800)]
Fix `Span<T>` GCStress issue on x86 (dotnet/coreclr#9116)

x86 by default treats the type of `ByReference<T>` as the actual type of its IntPtr field as an optimization. `ByReference<T>` is a special case where the struct needs to be treated as a value type so that its field can be considered as a by-ref pointer. This fixes `GCStress=f` issues on span tests on x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/6f7baa9e1ec9a848c1b98a4af8d9d8c2851ef023

7 years agoFix non-deterministic AVX2 detection
Bruce Forstall [Wed, 11 Jan 2017 06:38:57 +0000 (22:38 -0800)]
Fix non-deterministic AVX2 detection

The caller required ECX to be zero when calling CPUID, but wasn't calling
the getextcpuid() function to cause that to happen.

Commit migrated from https://github.com/dotnet/coreclr/commit/71075ab95119af411a5d161f68d2eafea07b610d

7 years agoIntroduce REGDISPLAY_BASE (dotnet/coreclr#9095)
Jonghyun Park [Wed, 25 Jan 2017 23:59:20 +0000 (08:59 +0900)]
Introduce REGDISPLAY_BASE (dotnet/coreclr#9095)

* Introduce REGDISPLAY_BASE

Commit migrated from https://github.com/dotnet/coreclr/commit/8f4cb1beaa68e74a16492510c86d9b2fec539e60

7 years agoMerge pull request dotnet/coreclr#9119 from wtgodbe/fixGroovyFx
William Godbe [Wed, 25 Jan 2017 23:54:37 +0000 (15:54 -0800)]
Merge pull request dotnet/coreclr#9119 from wtgodbe/fixGroovyFx

Fix CoreFX Binary copying in netci.groovy

Commit migrated from https://github.com/dotnet/coreclr/commit/a042c4cfdf5549e26dd19cdd7aa68cbab393a7ea

7 years agoFix CoreFX Binary copying in netci.groovy
wtgodbe [Wed, 25 Jan 2017 23:45:52 +0000 (15:45 -0800)]
Fix CoreFX Binary copying in netci.groovy

Commit migrated from https://github.com/dotnet/coreclr/commit/2fb67dcc33d80034df532cab87d0c2dc3680896d

7 years agoThis will stop building frankenjit.dll for x86.
dotnet-bot [Wed, 25 Jan 2017 23:12:29 +0000 (15:12 -0800)]
This will stop building frankenjit.dll for x86.

[tfs-changeset: 1645686]

Commit migrated from https://github.com/dotnet/coreclr/commit/fbe9c5c07daa523ca577fcd909b7ef3f302783df

7 years agoMerge pull request dotnet/coreclr#9111 from adiaaida/fixCompatJitLeg
Michelle McDaniel [Wed, 25 Jan 2017 21:04:20 +0000 (13:04 -0800)]
Merge pull request dotnet/coreclr#9111 from adiaaida/fixCompatJitLeg

Fix x86compatjit and x86lb legs

Commit migrated from https://github.com/dotnet/coreclr/commit/6475866517b923ed4e15038d1d60bfd89dafc267

7 years agoMerge pull request dotnet/coreclr#9099 from wtgodbe/CoreRootRunTest
William Godbe [Wed, 25 Jan 2017 20:12:18 +0000 (12:12 -0800)]
Merge pull request dotnet/coreclr#9099 from wtgodbe/CoreRootRunTest

Reintroduce building Core_Root to runtest.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/eab3b514ed94a95f04b95717cc910114106d4faf

7 years agoMerge pull request dotnet/coreclr#9113 from wtgodbe/groovyRelease
William Godbe [Wed, 25 Jan 2017 20:11:06 +0000 (12:11 -0800)]
Merge pull request dotnet/coreclr#9113 from wtgodbe/groovyRelease

Always use release folder for CoreFxBinDir

Commit migrated from https://github.com/dotnet/coreclr/commit/8555dcce4a48745ce84fe480474e0f42eb1170a0

7 years agoFix x86compatjit and x86lb legs
Michelle McDaniel [Wed, 25 Jan 2017 18:44:49 +0000 (10:44 -0800)]
Fix x86compatjit and x86lb legs

Change 7eacdd7 moved Exclude from runtest.cmd to build-test.cmd, which
broke the x86compatjit and x86lb legs in the lab. This change splits the
builds for these jobs into build.cmd skiptests and build-tests.cmd Exclude
<exclusion file> and removes the Exclude option from the runtest command.

Commit migrated from https://github.com/dotnet/coreclr/commit/47bf26423daa4e83ff2a2b619a3c91cd92653c34

7 years agoAlways use release folder for CoreFxBinDir
wtgodbe [Wed, 25 Jan 2017 19:03:21 +0000 (11:03 -0800)]
Always use release folder for CoreFxBinDir

Commit migrated from https://github.com/dotnet/coreclr/commit/1e6198435ee8d364f9cb5ca8d63eeb0e8921abcc

7 years agoMerge pull request dotnet/coreclr#9112 from wtgodbe/fixbuildagainstpackages
William Godbe [Wed, 25 Jan 2017 18:51:59 +0000 (10:51 -0800)]
Merge pull request dotnet/coreclr#9112 from wtgodbe/fixbuildagainstpackages

Fix arg parsing for buildagainstpackages argument

Commit migrated from https://github.com/dotnet/coreclr/commit/2f1e57a89df432d733262b7d4f574bc3e1b3fc92

7 years agoFix arg parsing for buildagainstpackages argument
wtgodbe [Wed, 25 Jan 2017 18:50:50 +0000 (10:50 -0800)]
Fix arg parsing for buildagainstpackages argument

Commit migrated from https://github.com/dotnet/coreclr/commit/12885e883984e0c6b07e461ca047972cabe1b335

7 years agoMerge pull request dotnet/coreclr#9100 from adiaaida/vso370233
Michelle McDaniel [Wed, 25 Jan 2017 18:50:48 +0000 (10:50 -0800)]
Merge pull request dotnet/coreclr#9100 from adiaaida/vso370233

Update isUsedFromMemory to include CNS_DBLs

Commit migrated from https://github.com/dotnet/coreclr/commit/d1305d2442be97e2c868e2050919d41777950ba2

7 years agoUpdate isUsedFromMemory to include CNS_DBLs
Michelle McDaniel [Tue, 24 Jan 2017 23:56:18 +0000 (15:56 -0800)]
Update isUsedFromMemory to include CNS_DBLs

Contained GT_CNS_DBLs should also be considered as isUsedFromMemory.

Fixes VSO 370233.

Commit migrated from https://github.com/dotnet/coreclr/commit/ae4fa9e1f2add97030cafdd9dcdfbdd50fb32662

7 years agoMerge pull request dotnet/coreclr#9024 from stephentoub/fix_taskwhenany
Stephen Toub [Wed, 25 Jan 2017 14:31:59 +0000 (09:31 -0500)]
Merge pull request dotnet/coreclr#9024 from stephentoub/fix_taskwhenany

Fix race condition in Task.WhenAny

Commit migrated from https://github.com/dotnet/coreclr/commit/f4be1f2319cde160eedc65a000e7b221c3433733

7 years agoMerge pull request dotnet/coreclr#9102 from dotnet/revert-8969-encoding
Jan Kotas [Wed, 25 Jan 2017 13:48:56 +0000 (05:48 -0800)]
Merge pull request dotnet/coreclr#9102 from dotnet/revert-8969-encoding

Revert "Fast-path for ASCII & UTF8 Encoding ASCII data"

Commit migrated from https://github.com/dotnet/coreclr/commit/7c4d22f30336ec15495a0e3fd23b07ee497fb9cd

7 years agoMerge pull request dotnet/coreclr#9104 from dotnet/revert-9091-perf-CompareOrdinalIgn...
Jan Kotas [Wed, 25 Jan 2017 13:48:38 +0000 (05:48 -0800)]
Merge pull request dotnet/coreclr#9104 from dotnet/revert-9091-perf-CompareOrdinalIgnoreCaseHelper

Revert "Improve CompareOrdinalIgnoreCaseHelper performance for matching chars"

Commit migrated from https://github.com/dotnet/coreclr/commit/c9de37eb69462cb9d1d4581a224eb99689004bef

7 years agoMerge pull request dotnet/coreclr#9084 from hqueue/arm/ryujit/fp_sqrt
Sivarv [Wed, 25 Jan 2017 04:50:37 +0000 (20:50 -0800)]
Merge pull request dotnet/coreclr#9084 from hqueue/arm/ryujit/fp_sqrt

[Ryujit/ARM32] Implement GT_INTRINSIC_Sqrt for floating point type

Commit migrated from https://github.com/dotnet/coreclr/commit/c3addb7aec0fc27c1f1139fd00e350342e5ea8c5

7 years agoRevert "Improve CompareOrdinalIgnoreCaseHelper performance for matching chars"
Jan Kotas [Wed, 25 Jan 2017 04:17:48 +0000 (20:17 -0800)]
Revert "Improve CompareOrdinalIgnoreCaseHelper performance for matching chars"

Commit migrated from https://github.com/dotnet/coreclr/commit/f72c59773399753075ec00c4060a61e00e313c31

7 years agoRevert "Fast-path for ASCII & UTF8 Encoding ASCII data"
Tarek Mahmoud Sayed [Wed, 25 Jan 2017 03:25:23 +0000 (19:25 -0800)]
Revert "Fast-path for ASCII & UTF8 Encoding ASCII data"

Commit migrated from https://github.com/dotnet/coreclr/commit/84a983a2801365cf255485b842b2a0d4b21ab1a7

7 years agoMerge pull request dotnet/coreclr#9073 from DrewScoggins/DevEngUbuntuFix
Drew Scoggins [Wed, 25 Jan 2017 03:14:21 +0000 (19:14 -0800)]
Merge pull request dotnet/coreclr#9073 from DrewScoggins/DevEngUbuntuFix

Fix Ubuntu Perf Runs

Commit migrated from https://github.com/dotnet/coreclr/commit/d47b92a252d327f92f989a178aa646ea01af88f7

7 years agoFix Ubuntu Perf Runs
Drew Scoggins [Sat, 21 Jan 2017 00:05:16 +0000 (16:05 -0800)]
Fix Ubuntu Perf Runs

After the dev/eng work the Ubuntu perf runs were broken because of
layout changes in the bin drop of CoreFX.  We relied on these for the
CoreFX that we used during perf testing.  I have made changes on the
CoreFX side to tar up the new runtime folder instead of a collection of
other bin folder.  This change allows the infrastructure to consume
this.

Commit migrated from https://github.com/dotnet/coreclr/commit/1a00e7dbbe4fef687c80246f8daca5c20f830493

7 years agoMerge pull request dotnet/coreclr#9096 from AndyAyersMS/RevComplement
Andy Ayers [Wed, 25 Jan 2017 01:44:58 +0000 (17:44 -0800)]
Merge pull request dotnet/coreclr#9096 from AndyAyersMS/RevComplement

Add BenchmarkGames revcomp benchmark

Commit migrated from https://github.com/dotnet/coreclr/commit/4fc4d2ad522477dfa873be1ac12ab9ac736a7b14

7 years agoMerge pull request dotnet/coreclr#9020 from briansull/jumpstub-logging
Brian Sullivan [Wed, 25 Jan 2017 00:57:30 +0000 (16:57 -0800)]
Merge pull request dotnet/coreclr#9020 from briansull/jumpstub-logging

Add logging for jumpsStubs and ClrVirtualAllocWithinRange

Commit migrated from https://github.com/dotnet/coreclr/commit/3992010c31ffc9eb50359713f1c29fd29902e04a

7 years agoMerge pull request dotnet/coreclr#9092 from wtgodbe/fixRunTest
William Godbe [Wed, 25 Jan 2017 00:49:49 +0000 (16:49 -0800)]
Merge pull request dotnet/coreclr#9092 from wtgodbe/fixRunTest

Fix runtest.sh build of Coreoverlay to account for new directory structure in CoreFX

Commit migrated from https://github.com/dotnet/coreclr/commit/b609a5fe63af293406d85c9e3134b5d1309c82ae

7 years agoReintroduce building Core_Root to runtest.cmd
wtgodbe [Wed, 25 Jan 2017 00:16:22 +0000 (16:16 -0800)]
Reintroduce building Core_Root to runtest.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/8ea4f12731dd17ef60f7b0201dc89fec59f4e065

7 years agoFix runtest.sh build of Coreoverlay to account for new directory strucure in CoreFX
wtgodbe [Tue, 24 Jan 2017 21:59:29 +0000 (13:59 -0800)]
Fix runtest.sh build of Coreoverlay to account for new directory strucure in CoreFX

Commit migrated from https://github.com/dotnet/coreclr/commit/0509183c860f54e230ea3aa65aedc8ee3b62f782

7 years agoAdd BenchmarkGames revcomp benchmark
Andy Ayers [Wed, 18 Jan 2017 00:07:41 +0000 (16:07 -0800)]
Add BenchmarkGames revcomp benchmark

This is based on version 1 of the C# variants. Am not including
the largest input file since it is ~250MB. Instead we iterate
on a smaller file.

Note the text input files are opened as binary and the app looks for
Unix line endings, hence the update to .gitattributes.

The benchmark is setup to look for its input next to the benchmark exe
as run in both normal test and xunit-perf test modes, keying off the
CORE_ROOT environment variable. In the xunit-perf mode the input files
are subsequently copied into the sandbox.

Also updated the ending copyright date on the Benchmark Games
license page.

Commit migrated from https://github.com/dotnet/coreclr/commit/efe09f824c2aa55d1ee9a749fc3d2166bf17b595

7 years agoDocument jumpStub usage in Codeman.cpp
Brian Sullivan [Fri, 20 Jan 2017 02:38:33 +0000 (18:38 -0800)]
Document jumpStub usage in Codeman.cpp
Added new STRESS_LOG calls that do the following:
 logging for JumpStubs
      log the total count of jump stub lookups: JumpStubLookup
      log the number of actual jump stub thunks created: JumpStubUnique
      log the number of jump stub blocks allocated: JumpStubBlockAllocCount
      log the number jump stub blocks that are completely filled: JumpStubBlockFullCount
 logging for ClrVirtualAllocWithinRange
      log the total number of calls to ClrVirtualAllocWithinRange
      log the number of VirtualQuery operations used by the current call
      log the range that was requested
      log the return value
      log any reasons for failure.

Commit migrated from https://github.com/dotnet/coreclr/commit/1da14f92116332b22dd6f0e6964625e39604c469

7 years agoImprove CompareOrdinalIgnoreCaseHelper performance for matching chars (dotnet/coreclr...
Bruce Bowyer-Smyth [Tue, 24 Jan 2017 22:22:01 +0000 (08:22 +1000)]
Improve CompareOrdinalIgnoreCaseHelper performance for matching chars (dotnet/coreclr#9091)

Commit migrated from https://github.com/dotnet/coreclr/commit/02511952eca7a41eb7d6ce7ac7b5e6d76ae991d6

7 years agoMerge pull request dotnet/coreclr#9065 from pgavlin/FixPhaseListOrder
Andy Ayers [Tue, 24 Jan 2017 22:15:00 +0000 (14:15 -0800)]
Merge pull request dotnet/coreclr#9065 from pgavlin/FixPhaseListOrder

Fix the ordering of phases in compphases.h.

Commit migrated from https://github.com/dotnet/coreclr/commit/8a5a61366890d45654e26ad670a485bafb4f8c20

7 years agoMerge pull request dotnet/coreclr#8973 from wtgodbe/HelixTestRuns
William Godbe [Tue, 24 Jan 2017 22:03:02 +0000 (14:03 -0800)]
Merge pull request dotnet/coreclr#8973 from wtgodbe/HelixTestRuns

Add support for running CoreCLR Tests in Helix

Commit migrated from https://github.com/dotnet/coreclr/commit/7eacdd774414e8c2d325e8aa3c3657df1fb0c032

7 years agoMerge pull request dotnet/coreclr#9090 from rahku/arm64fix
Rahul Kumar [Tue, 24 Jan 2017 21:47:37 +0000 (13:47 -0800)]
Merge pull request dotnet/coreclr#9090 from rahku/arm64fix

Fix arm64 build break

Commit migrated from https://github.com/dotnet/coreclr/commit/025f8b05bd023ad578d484921a73d8b7222ff4b5

7 years agoFast-path for ASCII & UTF8 Encoding ASCII data (dotnet/coreclr#8969)
Ben Adams [Tue, 24 Jan 2017 21:21:52 +0000 (21:21 +0000)]
Fast-path for ASCII & UTF8 Encoding ASCII data (dotnet/coreclr#8969)

* ASCII Encoding fast-path

* Add skipp for BIGENDIAN

* fixes

* ascii  GetBytes(char[] chars) fix

* feedback

* Clean up

* Reuse exception block

* Add debug Asserts

Commit migrated from https://github.com/dotnet/coreclr/commit/5c20488da0d06c14f8d28e9bade3e8e6d8cd970f

7 years agoMerge pull request dotnet/coreclr#8944 from DmitryDzuba/patch-1
Ian Hays [Tue, 24 Jan 2017 21:18:27 +0000 (13:18 -0800)]
Merge pull request dotnet/coreclr#8944 from DmitryDzuba/patch-1

Add version increment into Sort(Comparison<T>)

Commit migrated from https://github.com/dotnet/coreclr/commit/a4049636da7ba109629cd277dd2f12e1466d4e6f

7 years agoAdd support for running CoreCLR Tests in Helix
wtgodbe [Tue, 17 Jan 2017 22:47:51 +0000 (14:47 -0800)]
Add support for running CoreCLR Tests in Helix

Commit migrated from https://github.com/dotnet/coreclr/commit/eb610f615bc4076ad950c98157e83bc34649064f

7 years agoMerge pull request dotnet/coreclr#9071 from gkhanna79/FixVer200
Gaurav Khanna [Tue, 24 Jan 2017 19:57:12 +0000 (11:57 -0800)]
Merge pull request dotnet/coreclr#9071 from gkhanna79/FixVer200

Update CoreCLR nuget package versions to 2.0.0

Commit migrated from https://github.com/dotnet/coreclr/commit/6a3c584b80dde7752a595344b3dc727918c94183

7 years agoFix arm64 build break
Rahul Kumar [Tue, 24 Jan 2017 19:32:24 +0000 (11:32 -0800)]
Fix arm64 build break

Commit migrated from https://github.com/dotnet/coreclr/commit/67c9dda70b909e6dd5371c9615d61c19fba13199

7 years agoMerge pull request dotnet/coreclr#9076 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Tue, 24 Jan 2017 17:28:56 +0000 (09:28 -0800)]
Merge pull request dotnet/coreclr#9076 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24924-01, beta-24924-02, respectively (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/8d0946c0fb7c597f9de0dbb997fe63d59376f38b

7 years agoDelete unused files (dotnet/coreclr#9082)
mikedn [Tue, 24 Jan 2017 15:30:45 +0000 (17:30 +0200)]
Delete unused files (dotnet/coreclr#9082)

- *.vrg files (registry entries)
- *.ini files (performance counters)
- *.vcproj/vcxproj/vspscc/sln (out of date)
- mscorrc.rc2 (not referenced from anywhere)

Commit migrated from https://github.com/dotnet/coreclr/commit/c9aecb547dad29d44eb9e2e9b798aa8e6aef830a

7 years agoUpdate CoreClr, CoreFx to beta-24924-01, beta-24924-02, respectively
dotnet-bot [Tue, 24 Jan 2017 15:13:54 +0000 (15:13 +0000)]
Update CoreClr, CoreFx to beta-24924-01, beta-24924-02, respectively

Commit migrated from https://github.com/dotnet/coreclr/commit/7344f962336c0344736abb92fb4a5cefac4a8da0

7 years ago[x86/Linux] Port CheckRegDisplaySP (dotnet/coreclr#9081)
Jonghyun Park [Tue, 24 Jan 2017 14:54:37 +0000 (23:54 +0900)]
[x86/Linux] Port CheckRegDisplaySP (dotnet/coreclr#9081)

Remove duplicated declarations of CheckRegDisplaySP, and enable it for x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/285c9f3002627135a8a152fea8ef97c93c8a27e0

7 years agoFix codegen for GT_NEG to handle floating point type
Hyung-Kyu Choi [Tue, 24 Jan 2017 11:50:12 +0000 (20:50 +0900)]
Fix codegen for GT_NEG to handle floating point type

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/ff01346b7816a40058a1a5e8487172e15efc33fb

7 years ago[x86/Linux] Fix EH Region Mismatch (dotnet/coreclr#9043)
Jonghyun Park [Tue, 24 Jan 2017 12:39:37 +0000 (21:39 +0900)]
[x86/Linux] Fix EH Region Mismatch (dotnet/coreclr#9043)

Commit migrated from https://github.com/dotnet/coreclr/commit/617c0cf4448b3728b1f07f9aec5f2dc2a40ce5f9

7 years agoSimplify #ifdef related with UnwindStackFrame (dotnet/coreclr#9052)
Jonghyun Park [Tue, 24 Jan 2017 11:09:16 +0000 (20:09 +0900)]
Simplify #ifdef related with UnwindStackFrame (dotnet/coreclr#9052)

Commit migrated from https://github.com/dotnet/coreclr/commit/69e3c50ee80a16fd4d2c287422ed7c4d1056b667

7 years agoImplement GT_INTRINSIC_Sqrt for floating-point
Hyung-Kyu Choi [Tue, 24 Jan 2017 11:04:09 +0000 (20:04 +0900)]
Implement GT_INTRINSIC_Sqrt for floating-point

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/b044c6050e7b35ccdee42278587b9d8206915db1