Piotr Tworek [Thu, 5 Mar 2015 11:41:00 +0000 (20:41 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.
Make sure our message filters use EwkMsgStart ID instead of
ChromeMsgStart. This fixes problems with running RWK in multiprocess mode,
--single-process flag should no longer be required to run ubrowser or
efl_webview_app.
Change-Id: If6f839d757c218d83d71e51973e0b11f7ece6d5b
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 5 Mar 2015 11:36:08 +0000 (20:36 +0900)]
Reuse efl initialization code from chromium_impl in ewk
AppendPortParams is supposed to contain the necesary minimum to
bootstrap working EFL version of chromium. CommandLineEfl should only
append extra flags which are supposed to activate additional, non
critical functionality. The idea is xwalk and EWK can configure chromium
differently, but they should share some base flags.
Change-Id: I2c1ea27c9054b228c078d0ddd6a708b1e3fdb3dc
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 5 Mar 2015 11:35:08 +0000 (20:35 +0900)]
fixup! Merge efl-port POC code into tizen_src
Andjust tizen_src code to fixup from:
http://165.213.202.130:8080/#/c/76146/
Change-Id: Ie2d9fcc32b7edaa3b926dce8c5f6fc2616a79420
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 5 Mar 2015 10:41:39 +0000 (19:41 +0900)]
Fix EWK content rendering support.
With this patch in place it's possible to get a working ubrowser build
that both renders the content, reacts to input and can handle a lot of
EWK API calls.
Note: For the app to work --single-process flag still needs to be
specified. I'm still looking why it's needed.
Change-Id: I4a585ecd5a8b3a14260386d5c76b3082d6fc6608
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 5 Mar 2015 09:44:28 +0000 (18:44 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.
Re-enable building of various resources EWK needs from chrome.
Change-Id: I6c9ad25d92e82f502ff37ee74d8d1108174604e2
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 5 Mar 2015 09:39:02 +0000 (18:39 +0900)]
Make sure we compile chromium code with the same defines as chromium-efl
Apparently some of them are needed to ship chromium code in shared
library. Would be good to investigate them and explain what they
actually do.
Change-Id: I459ba1458fced5ddaaeb6a133f0d13f79149d252
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 4 Mar 2015 11:02:47 +0000 (20:02 +0900)]
Move EWK implementation code into ewk/ directory where it belongs.
Around 3/4 of the code from impl is responsible for implementing EWK API
specifics. This code belongs in ewk/ directory of tizen_src. This patch
performs the move and ajusts the build system and chromium_impl code to
make EWK buildable again. With this patch in place it's possible to
build crosswalk, content_shell and EWK apps once again on desktop. All
of the apps should run, but rendering is still broken in EWK. This will
be handlled in a separate commit.
Change-Id: I28bcbbd4c142c6db25e0efbbabfc69d79e2542ca
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Tue, 3 Mar 2015 09:04:37 +0000 (18:04 +0900)]
Migrate chromium-efl device_sensors provider into chromium_impl
It implements generic chromium interface. The code should be reusable by
both EWK and content apps line xwalk or content_shell.
Change-Id: I952f6a5a284cf4c1a37c1d8bad28859a038e03de
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Tue, 3 Mar 2015 08:06:45 +0000 (17:06 +0900)]
Migrate chromium speech synthesizer code (TTS) to chormium_impl
Can't test it properly now as I don't have a tizen mobile device, but
the code belongs in chromium_impl, not ewk directory.
Change-Id: I85318e6a175ddfa23169cf938c9f540e2e7d8cbb
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Tue, 3 Mar 2015 08:48:40 +0000 (17:48 +0900)]
Migrate tizen battery API provider implementation to new dir structure
Generic code, should be usable for both xwalk and EWK, move to
chromium_impl.
Change-Id: Ie912672308462056653ee7b85324843bd940bf16
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Tue, 3 Mar 2015 06:19:04 +0000 (15:19 +0900)]
Migrate multimedia support code to new chromium_impl structure.
The code implements internal chromium interfaces so it belongs in
chromium part of new project structure. The expectation is it'll be
possible to use it from both xwalk/content_shell and EWK.
Due to the fact that xwalk gyp files
(xwalk/build/xwalk_filename_rules.gypi) exclude files with tizen in
their path from build if tizen gyp variable is set to 0 the code had to
be renamed. These files were renamed to have the "efl" suffix instead, given
that there were no Tizen specific (desktop build also builds them).
This way we still keep the ability to build and test the code on desktop.
Change-Id: Ic967fb97131152494520ac9232b986126918c969
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Piotr Tworek [Sat, 28 Feb 2015 03:30:44 +0000 (12:30 +0900)]
Merge efl-port POC code into tizen_src
This commit merges code from efl-port POC into tizen_src directory
structure. With this commit in place it's possible to build xwalk and
content_shell on top of cgromium using EFL toolkit. On desktop it should
be as simple as (from top level directory):
$ ./xwalk/gyp_xwalk -Duse_aura=0 -Duse_efl=1 -Dbuilding_for_tizen_mobile=0
$ ninja -C out/Debug content_shell xwalk
Running:
$ ./out/Debug/xwalk <some link>
or:
$ ./out/Debug/content_shell --no-sandbox <some link>
Building the code for Tizen 3.0 is handled by crosswalk-efl.spec file in
xwalk repo.
Building EWK code is currently not possible. EWK will be fixed by future
commits.
Change-Id: I53862b74202c36eb531204f155153b8a9b18deb0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
hh4813.kim [Wed, 4 Feb 2015 13:48:11 +0000 (22:48 +0900)]
fixup! [Crosswalk] Switch repositories to CT and bgerrit.
Change-Id: Ifa76de51a64e7b6c5ed7cc26943b04ca1a8d0041
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Fri, 23 Jan 2015 21:49:43 +0000 (13:49 -0800)]
[Crosswalk] Switch repositories to CT and bgerrit.
Change-Id: I4b40b5c9f902869ba848297a64bfab1ddd10e423
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Thu, 22 Jan 2015 20:51:57 +0000 (12:51 -0800)]
fixup! Implement Chromium Theme for Tizen.
Change-Id: Iafb891a4aab335614f763e2ab850f71b984bbdde
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Mon, 15 Dec 2014 21:14:22 +0000 (13:14 -0800)]
[Crosswalk] Move away from custom_hooks needs in .gclient.
Patch adds a DEPS file in tizen_src where 'xwalk' is specified
as a hard dependency. It allows us to greatly simplify
our suggested .gclient.
Our 'custom_hooks' also got to be declared as 'hooks' in DEPS.
Change-Id: I21d55ed5b7730bed1100abcd9efee2d272d9720c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Mon, 15 Dec 2014 19:01:08 +0000 (11:01 -0800)]
[Crosswalk] Move away from sync_repos.sh.
Patch implements a fully gclient based featch solution,
moving away from sync_repos.sh completely.
The following actions are done (README.md updated):
- The custom_hook associated to sync_repos.sh in .gclient is removed
- Chromium and WebKit are pulled directly from EFL forks via .gclient-xwalk.
- Crosswalk is pulled as a separate "solition" in .gclient.
- The needed custom hooks are overriden.
Change-Id: Ifeb4060ea0152d8c373235003a4a5020b0b17fcc
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Fri, 5 Dec 2014 22:22:36 +0000 (14:22 -0800)]
[Crosswalk] Fetch from the proper crosswalk repository
Change-Id: I5ddf18c2fafa15a2501f9ec1f7a08fd28df726fa
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Taeho Kim [Mon, 24 Nov 2014 14:38:37 +0000 (23:38 +0900)]
[Crosswalk] Update README.md
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8505
Change-Id: I75c911517b8b8531dba70b3ed283494246e5c8c8
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Abhijeet Gopalrao Kandalkar [Wed, 3 Dec 2014 14:54:54 +0000 (06:54 -0800)]
[Crosswalk] Suppress linker warnings as errors.
Change-Id: I8c54a3fccda76c5ae81dcab01111e33ef46b4b47
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Thu, 6 Nov 2014 17:46:56 +0000 (09:46 -0800)]
[Crosswalk] Define building_for_tizen_{mobile,tv} when building xwalk.
Change-Id: Id84b02cdd17bfdd66194453e8caf7a8d7e8efb2c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Mon, 10 Nov 2014 04:03:15 +0000 (20:03 -0800)]
[Crosswalk] Add extra EWK_BRINGUP guards for unsupported calls.
Change-Id: I1a9392cdeb447d5709ea6f67572878f098589721
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Wed, 3 Dec 2014 14:07:33 +0000 (06:07 -0800)]
[Crosswalk] Integrate with Crosswalk gclient machinary.
Crosswalk first pulls itself (into src/xwalk) and then re-run
gclient in order to pull src and all its dependencies.
Patch makes it possible to pull in a custom src and blink code
by forking and adapting src/walk/DEPS.xwalk and src/xwalk/generate_gclient-xwalk.py.
(see script/xwalk). Patch also reintroduces sync_repos.sh, adapted
to crosswalk's integration needs.
Patch also adapts our build system to have .gclient as entry point.
Precedure:
$ create .gclient file (as below)
$ gclient sync
Details:
1) Gclient pulls chromium-efl into "src/tizen_src".
2) The it runs 3 custom hooks in order to get the rest of the source:
*) fetch-src-blink: src/tizen_src/sync_repos.sh is called and
pulls in src and src/third_party/WebKit from a pre-defined locations.
*) generate-gclient-xwalk: .gclient-xwalk is created by running
src/tizen_src/scripts/xwalkgenerate_gclient-xwalk.py (this is a fork
of the same script in xwalk repository).
4) 'fetch-deps': actually fetches all depedencies in .gclient-xwalk.
.gclient content:
solutions = [
{ "name" : "src/tizen_src",
"url" : "<chromium_efl_clone_url@branch>",
"deps_file" : "DEPS",
"managed" : True,
"custom_hooks": [
{
# fetch custom src and blink repositories.
"name": "fetch-src-blink",
"pattern": ".",
"action": ["src/tizen_src/sync_repos.sh"],
},
{
# Generate .gclient-xwalk for Crosswalk's dependencies.
"name": "generate-gclient-xwalk",
"pattern": ".",
"action": ["python", "src/tizen_src/scripts/xwalk/generate_gclient-xwalk.py"],
},
{
# Fetch Crosswalk dependencies.
"name": "fetch-deps",
"pattern": ".",
"action": ["python", "src/xwalk/tools/fetch_deps.py", "-v"],
},
{
# At some point, we will integrate to gyp_xwalk. Not now...
"name": "gyp-xwalk",
}
],
"safesync_url": "",
},
]
cache_dir = None
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8505
Change-Id: I6d189daa1eae37a963422e0e0aa9102d871c667c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Fri, 27 Feb 2015 23:02:36 +0000 (15:02 -0800)]
Delete default context in ewk
Default Web context is managed by ewk. So it makes more sense to delete
it in ewk layer than in efl.
This will allow us to get rid of WebContext::defaultContext in a
followup patch.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I6ada8f2e46d2cf19ccacf072d384fd11008c3433
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
hyunjune.kim [Wed, 25 Feb 2015 05:33:52 +0000 (14:33 +0900)]
fixup! If click link, appear IME keyboad in moved page.
By mini_browser implementation, when click <a href ... target="_blank">
element a popup window appears to ask user whether to open a new window
or not. However, when this popup window is closed, the focus goes to url
bar, which in turn opens IME keyboard.
This patch fixes it by forcibly giving focus to webview inside two callbacks
(correspond to open/cancel button) that close the popup window.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11530
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I74f2f15c1c4ab5620880a8d15fcad303e1d53515
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
Arnaud Renevier [Thu, 26 Feb 2015 19:41:15 +0000 (11:41 -0800)]
tizen_webview removal: remove tw_view_mode.h
This is a first step toward removal of tizen_webview layer.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Reviewed by: Antonio Gomes, Balazs Kelemen
Change-Id: Ia0a52ea1f3577fdeed51cf0ae29f18d64abbf870
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Sat, 28 Feb 2015 05:32:48 +0000 (21:32 -0800)]
Remove tw_input_type.h
This patch remove tw_input_type.h. We can easily use ui::TextInputType
instead.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I2072200f74cbada0618674f43da31445f1708d68
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 25 Feb 2015 23:26:56 +0000 (15:26 -0800)]
Remove redundant install -d "%{buildroot}"%{_bindir}
The command 'install -d "%{buildroot}"%{_bindir}' is present twice in
packaging/chromium-efl.spec. This patch removes a superfluous line.
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: I558bf6ba7711b3c71c0d8bb2b7c65a677bcebd19
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
sangdeug.kim [Wed, 21 Jan 2015 10:58:31 +0000 (19:58 +0900)]
[MM]EME implementation using EncryptedMediaPlayerSupport.
SHA:
aaaae22e commit is included to fix crash issue.
(Refactor MediaSourceDelegate destruction.)
https://codereview.chromium.org/
605013002
Together with: I0e3d41130d1b66e32e248a2ac6495c5d52cd9e8f
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8682
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: I9c065ae4a9b442bf5141011e66aa7f4135cc8b65
Signed-off-by: sangdeug.kim <sangdeug.kim@samsung.com>
Tomasz Czekala [Thu, 26 Feb 2015 09:36:08 +0000 (10:36 +0100)]
Enable static asserts for enumerated values
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10791
Reviewed by: Laszlo Gombos, Piotr Grad, Piotr Tworek
Change-Id: Idb53a8ffb7ca8a3fcec30b2380a91cb3f9ef42a7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Antonio Gomes [Fri, 27 Feb 2015 18:22:19 +0000 (10:22 -0800)]
Replace build/prebuild/ninja-linux64 by a statically linked equivalent.
That will allow ninja-linux64 to be used by both
x64-86 and ARM64 builds.
Otherwise, when using the currently dynamically linked
version in ARM64 builds, the follow error happens:
[XXs] + build/prebuild/ninja-linux64 -j16 -Cout.tv.i386/Release <target list>
[XXs] line 85: build/prebuild/ninja-linux64: No such file or directory
NOTE: Binary is the same available in dev/master branch made
by Piotr Tworek <p.tworek@samsung.com>. For more information,
check http://165.213.202.130:8080/#/c/73132/.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11564
Reviewed by: Balazs Kelemen, arno renevier
Change-Id: I0f9069c2d9b9f51c519f97ca782426b878255af1
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Dongjun Kim [Fri, 27 Feb 2015 07:24:29 +0000 (16:24 +0900)]
IME is not occured in prompt popup
Regarding latest code, prompt popup was added by elm_popup_add().
In this case, IME is not shown with prompt popup.
Because of that IME only works on elm_conformant.
We need to adding elm_conformant_add() on top window.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11624
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Tworek
Change-Id: Iffad198e60bcd79ee4862c0db4b03256b192f934
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Antonio Gomes [Fri, 27 Feb 2015 06:16:27 +0000 (22:16 -0800)]
fixup! Hide Selection Handle when not in visible rect.
This method has no need to be target-only. By making it
ifdef-free, we make it possible to easier selection handles
shown on desktop builds similarly to target builds.
Reviewed by: Piotr Grad, SeungSeop Park
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10692
Change-Id: I9082c3561106513a5e8947e9abfc37b92901b158
SeungSeop Park [Thu, 26 Feb 2015 14:12:23 +0000 (23:12 +0900)]
export ewk_ipc_wrt_* API as C linkage
This is necessary due to merged commit http://165.213.202.130:8080/#/c/75191/,
which is to minimize memory size by restricting symbol export as ewk prefixed
ones. Without this patch, wrt package build fails with undefined symbol error.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Janusz Majnert, Min-Soo Koo, Piotr Tworek
Change-Id: I590eff2c4b529c3ec46cac427377c6828c52df7d
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Michał Pakuła vel Rutka [Thu, 26 Feb 2015 07:48:18 +0000 (08:48 +0100)]
ubrowser: Add support for file URI scheme
Currently ubrowser converts all URLs 'http://' with exception of ones
starting '/', 'http' and 'about'. This commit adds an exception for adresses
starting with 'file' or 'https' so they won't be converted to 'http://'
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, Tomasz Weglarski
Change-Id: I537a21a882abca76bbc4e0ef7bc1c369bd9d7ec9
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Antonio Gomes [Fri, 27 Feb 2015 06:36:45 +0000 (22:36 -0800)]
Add a aarch64-capable version of gold linker.
In order to support ARM64 builds we need a version of linker
gold that actually supports aarch64. According to [1],
such support is a very recent addition to gold itself, and no
releases have been made yet.
Patch updates our statically linked binary of gold binary
off of binutils trunk [2] (SHA
9ad55e9b) which issues problems
including:
[ XXs] [131/339] SOLINK(module) libffmpegsumo.so
[ XXs] (...)/prebuild/ld: fatal error: /usr/aarch64-tizen-linux/usr/lib/../lib64/crti.o:
unsupported ELF machine number 183
[1] https://sourceware.org/ml/binutils/2014-10/msg00192.html
[2] git://sourceware.org/git/binutils-gdb.git
Patch is a step forward to support arm64 builds.
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I19e339354040ef9996cefad71091d62ca2ec4bc7
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 26 Feb 2015 18:01:48 +0000 (10:01 -0800)]
Build custom allocator/tcmalloc respecting 'use_allocator' flag
Right now chromium-efl builds TCMalloc unconditonally for
all targets.
However, it is known that some targets, including ARM64,
are not yet supported by TCMalloc, and should be disabled.
Patch prepares the ground for this, only building allocator
the respecting 'use_allocator' GYP define. Now, it will
always build, but soon disabled for ARM64 builds.
Bug: web.sec.samsung.net/bugzilla/show_bug.cgi?id=11564
Reviewed by: Piotr Tworek, SeungSeop Park, arno renevier
Change-Id: I3c087d9782860c3645f4f7763b6e0ae2a4cec195
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
ByungJun Kim [Thu, 26 Feb 2015 10:43:43 +0000 (19:43 +0900)]
Hide the context_menu, when the selected text is not displayed.
If user scrolls a WebView and selected text gets offscreen,
context_menu doesn't disappear and sometimes overlaps with the URL bar.
Patch adds some logic to hide the context_menu when the selected text
is offscreen.
Reviewed by: Antonio Gomes, DONGJUN KiM, Jaesik Chang
Change-Id: I149be40b35897ff9962f79fe877c277cd3d0dca9
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
SeungSeop Park [Sat, 7 Feb 2015 04:08:51 +0000 (13:08 +0900)]
Add size optimization GCC options
Code size optimization via GCC option.
M34 patches:
- http://165.213.202.130:8080/#/c/67343/
- http://165.213.202.130:8080/#/c/67639/
- http://165.213.202.130:8080/#/c/67564/
Test result of libchromium-ewk.so size in mobile:
- Base : 35M after strip (63M before strip)
- After: 25M after strip (54M before strip)
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I639e8a929d2b99b71687d88c4a282541319e9e56
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 9 Feb 2015 09:56:20 +0000 (18:56 +0900)]
Only export necessary symbols (EWK + v8::*) in libchromium-ewk.so
Currently we are providing two shared libraries - libchromium-ewk.so and
libchromium-efl.so, as the former is relying on the latter.
Tizen applications are supposed to use only EWK api, hence would only see
libchromium-ewk.so, which uses in turn libchromium-efl.so in implementing
EWK. However, libchromium-efl.so is over-exporting symbols unnecessary to
EWK apis, resulting in large ROM size and runtime memory.
This patch does three things to fix above mentioned issues.
1. Change libchromium-efl to static library
2. export symbols required for EWK app and WRT in libchromium-ewk.so
- ewk_ prefixed API
- v8::*
3. Refactored efl_webprocess executable to link with libchromium-ewk.so.
Test result of .so size in mobile:
- Before: 46M after strip (76M before strip)
- After : 35M after strip (63M before strip)
The test result for runtime memory also showed over 8M reduction
in PSS code section.
Note: This is a partial commit of http://165.213.202.130:8080/#/c/75146/
which contains our effort to reduce memory footprint.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I527135ab844428d030477d194e5e5103c5533685
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Youngsoo Choi [Thu, 26 Feb 2015 10:52:00 +0000 (19:52 +0900)]
fixup! Factor out common bits of build_mobile and build_tv scripts
When building chromium-efl with tizen v3.0 profile,
The variable 'PROFILE_NAME' has been used without being set.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11596
Reviewed by: Antonio Gomes, venu musham
Change-Id: I6974f6ad6fb036c3d31181078bc806eab25f699a
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 22:59:46 +0000 (14:59 -0800)]
do not call elm_progressbar_pulse with null argument
When running the desktop UI, loading_indicator is NULL. This patch
avoids calling elm_progressbar_pulse when this is the case. This
prevents the following error: "obj_id (nil) is not pointing to a valid
object. Maybe it has already been freed."
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Ib89a80aea2cdf684ee72e79d2f106366050ff7d8
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Karol Furmaniak [Thu, 26 Feb 2015 14:11:46 +0000 (15:11 +0100)]
Page is auto zoomed on tapping URL bar.
[Problem]: When input field is focused and tap UTL bar
page is zoomed in.
[Solution]: Changed checking virtual keyboard state
from IsIMFVisible to IsShow which additionaly checked
if ime is in focused state,
Bug: http://168.219.209.56/jira/browse/TNEF-164
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad
Change-Id: I1bc8a3bd0e0fc32c8151c0536a18c6cdf118b20e
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Bartlomiej Gajda [Tue, 24 Feb 2015 13:37:54 +0000 (14:37 +0100)]
Fix showing context menu on elements with style "-webkit-user-select:none".
[Issue] Elements which are not selectable, should also not show context menu
on long press.
[Problem] Redundant showContextMenu() being called whenever LongPress ended.
[Solution] Trigger context menu only when neccessary.
[Requirment] WCS TC 49,50
[SPIN JIRA] TNEF-306
Reviewed by: Antonio Gomes, Jaesik Chang, Marcin Kolibabka, Piotr Grad
Change-Id: I841075559f2a82b94d5b4e3ecbcd485b5e119553
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Lukasz Krok [Wed, 25 Feb 2015 16:24:50 +0000 (17:24 +0100)]
[M34 Merge] Fix for the 'Reload' button not displayed on page load finish
[Cause] "load,started" callback was triggered more than once,
e.g when an iframe present on the page was reloaded. In a browser,
it caused the status bar to be refreshed and reload button to
be changed into cancel button. Additionally, in such case, the "load,finished"
callback was not triggered and the cancel button never changed back into
reload.
[Solution] "load,started" and "load,finished" should be called
only once, when a page is loaded.
M34-merge: http://165.213.202.130:8080/#/c/69958/
Bug: http://168.219.209.56/jira/browse/TNEF-172
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park
Change-Id: I4b47a3833cbf487e2473c2fe70d2340111b5c807
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
SeungSeop Park [Thu, 26 Feb 2015 13:35:13 +0000 (22:35 +0900)]
Deprecate non-ewk api usages in app.c
In following commit, only ewk_ prefixed symbol will be exported.
To avoid build break, this patch comments out the code using
unexported symbols such as FOR_TESTING_ewk_hit_test_*.
TODO: replace this with proper solution.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11609
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I6f4c9afe5d9048c6658e18a7f2090990a9e87c3a
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Piotr Grad [Fri, 20 Feb 2015 08:47:57 +0000 (09:47 +0100)]
Fix incorrect key code in JS key press event
Platform was sending ascii code instead of utf8 code.
Used cached value for utf8 code passed by platform in
ime preedit and commit callbacks.
Bug: http://168.219.209.56/jira/browse/TNEF-235
Reviewed by: Jaesik Chang, Marcin Kolibabka, Marcin Krakowiak
Change-Id: I812c4fefefe7e45ab5b762940e751ee8eec5fbc7
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 16:58:11 +0000 (12:58 -0400)]
Only show selection handles when scrolling/flinging has stopped.
In text selection mode, handles and magnifier glance controls
are hidden while scrolling. That involves the two main scroll cases:
- user is flinging, i.e. kinetic scrolling;
- user is panning, i.e. dragging the page content around
without lifting his finger off the screen.
In our current implementation, the following case is broken:
- load a scrollable page and enter text selection mode (by
long press, for example).
- start kinetic scroll the page
One will notice that when he lifts off his finger from the screen
text selection controls are prematurely shown while scrolling is
still active, and it becomes junky.
This happens because when user lifts off his finger a GESTURE_END type
of event is emitted and handled by RWHVEfl::HandleGestureEnd. There,
it is assumed to mean "scroll has stopped, and text selection controls
can be shown". Although it covers the panning case well, it fails for
the flinging case.
Patch fix this by moving the panning-stop code from ::HandleGestureEnd
to ::HandleGesture, when a 'ScrollEnd' type of event is emitted.
The kinetic scrolling case is then alread properly handled by the
RenderWidgetHostView hook named 'DidStopFling'.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I2ac1569ebf3a7812c5ae71b17aa11decbf5a5c9d
Dongjun Kim [Thu, 26 Feb 2015 07:25:30 +0000 (16:25 +0900)]
fixup! fixup! After changed edit type, IME state doesn't change.
After this patch, IME was shown up with select picker in same time.
[Reproduce step]
1. open test file(select_picker_test.html)
2. choose edit field
3. choose select picker
We need to checking "TextInputType" before updating IME state.
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Grad
Change-Id: I926c430270272e8be7e8cf14e8144ff5d9f85e72
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Karol Furmaniak [Thu, 26 Feb 2015 11:25:33 +0000 (12:25 +0100)]
Scroll to focused editable node when ime change geometry.
[Problem]: Sometimes when changing orientation, page is not
scrolled to focused editable node.
[Solution]: Added scroll to focused editable node when
virtual keyboard change geometry to non zero size.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11586
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I34a98fcf20764a6e306f01dfa2aba5735788745f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 00:33:43 +0000 (16:33 -0800)]
Remove SendOrientationChangeEventIfNeeded
SendOrientationChangeEventIfNeeded method is not used anymore. It has
been replaced by SetOrientation. This patch removes the unneeded method.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I9604cc01dc0f61d3a2489b8339ce06722daf482c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Venugopal S M [Wed, 25 Feb 2015 18:54:57 +0000 (00:24 +0530)]
[MM] Buffered data indication is incorrect for Media Element.
Gstreamer 1.x gives buffered range in percentage in seven digits along
with precision. This large number caused overflow of progress bar.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11544
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I75111ee4dc4b426e8928332ee5837b33b87437cf
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
Daniel Waślicki [Thu, 26 Feb 2015 10:00:24 +0000 (11:00 +0100)]
Temporary disable Drag&Drop
As agress with Gyuyoung Kim, Drag&Drop currently is not officaly
supported with W3C standard. Although we want to have implementation
in engine to be able to simply turn it on when it will land in
official standard. For now we will turn it off to see how things
in W3C will go.
Change-Id: Iad55c48f7be1805596978a62565c6d85bf817796
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Daniel Waślicki [Wed, 18 Feb 2015 09:25:08 +0000 (10:25 +0100)]
Bring up drag option in context menu
This reverts commit
ddc255acd3b2955c28c29af67104881f1840b52d.
Implementation of Drag&Drop was splitted into two parts. First one
implemented EFL`s port for D&D with default behavior, which is
dragging on long press. Second part changed default behavior to
starting D&D after choosing proper option from context menu. After
merge of first patch issues was raised that one cannot open context
menu for URL links. Now both parts are merged so this issue does not
occur any more.
Together with: I1b3cc3280e119ea69fa3939b51315100f512e527
Together with: I5aeff041e53f659181b85c92e2e3674beb46f0be
Change-Id: I641c466f36791c73055dae9cd20b5f0738fcc666
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
sonal.g1@samsung.com [Wed, 25 Feb 2015 15:37:58 +0000 (21:07 +0530)]
[Tizen][WebRTC] Appsink implementation with fimcconvert
Appsink has been implemented using fimcconvert, it will be used if
pixmap(zero-copy) is not working. It works by registering a callback with
appsink. After receiving the buffer it will send buffer to renderer process
via shared memory.
Reviewed by: Min-Soo Koo, Sharath Kamath
Change-Id: I270ad24f5ebd6ccfd8d9609a6a3259db68b25a25
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
KangYong Park [Thu, 26 Feb 2015 01:56:32 +0000 (10:56 +0900)]
fixup! Added implementation of Drag&Drop for EFL port
This is add-hoc patch for running content_shell.
When running content_shell, ewk_view_ is not initialize.
Reviewed by: Antonio Gomes, Gyuyoung Kim, Piotr Tworek
Change-Id: I6fcf3b29dd44ace8499af1a2aea1369ff95c8daf
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 19:59:14 +0000 (11:59 -0800)]
Use asynchronous hit test in unittests
unit tests of Ewk_Hit_Test use synchronous hit test. This patch use the
new synchronous api.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I89f09ff25d7bbfb09b9d47851700185f3bfbd031
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 23:16:33 +0000 (15:16 -0800)]
Ability to run browsers trought gdb with -g option
Right now, it is not easy to run ubrowser or efl_webview_app with gdb.
This patch adds a -g option to both wrappers scripts. If they are called
with that option, the applications are launched with gdb.
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: Icb504e12b8c286f13164ecbe41915e2e261ff07d
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
[MM][Tizen 3.0] Fix video corruption when video resolution is changed.
When the resolution of video is changed from server, video was corrupted.
This patch makes MediaSourcePlayerGstreamer handle the video resolution changes.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11432
Change-Id: I0185c67e3a25785fe4b6866e9c708881b41578d7
Signed-off-by: msu.koo <msu.koo@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 13:45:38 +0000 (19:15 +0530)]
fixup! fixup! fixup! Fix ewk_view_orientation_send API Reviewed by: Piotr Tworek, venu musham
Change-Id: I8e80329d12e5b6cae84b549c860b7a0ae8743a52
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
Fix for renderer crash during video playback
If we scroll/zoom the page during video playback, renderer
crash is observed. Currently, invalidation of video layer
happens on the main thread in WebMediaPlayerTizen. It should
happen on the compositor thread instead. This patch ensures
that and thus avoids the crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11278
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I40b7fa90c467e80af06f8ce39de4d3a763f1117e
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 20:06:34 +0000 (12:06 -0800)]
Use asynchronous hit test in efl_webview_app
efl_webview_app still uses deprecated (synchronous) hit test api. This
patch fixes it.
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ibe774ad8a8c798cf7a9449744a54d04d7bf17a7c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 20:48:47 +0000 (12:48 -0800)]
Factor out common bits of build_mobile and build_tv scripts
Both scripts were almost identical, except in the values
set to TIZEN_VERSION and PROFILE_FLAG variable.
To avoid such duplication, patch factors out the common bits
into a function in common.sh named setupAndExecuteTargetBuild.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I2e36fc5c950d1af2d549838fa7d7246790498f53
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Michał Obrembski [Tue, 24 Feb 2015 14:44:44 +0000 (15:44 +0100)]
fixup! Generalize and improve current suport for l10n
[Issue] Original patch breaks WCS TC 213.
[Note]
Changed the place of LocaleEfl::Initialize(), as it requires existing
SharedIntance of ui::ResourceBundle, and BasicStartupComplete() is called
before PreSandboxStartup(),
Also removed check for renderer process, as PreSandboxStartup() is
called from zygote process.
Reviewed by: Antonio Gomes, Marcin Kolibabka
Change-Id: Ic6b89d7c5f68d404eb264eaeba01cc5b37c06d7f
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Piotr Pruski [Wed, 11 Feb 2015 15:21:22 +0000 (16:21 +0100)]
Implementation for ewk_settings_private_browsing
Implementation of set and get functions to use private browsing mode.
Implementation replaces current webcontext to new one with private settings.
The old one is held till user goes back to normal browsing.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11110
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: I922a1e674be01024e55622c0d1822c414dd17bbf
Signed-off-by: Piotr Pruski <p.pruski@samsung.com>
Youngsoo Choi [Wed, 25 Feb 2015 11:09:10 +0000 (20:09 +0900)]
[HOTFIX][tizen v3.0][aarch64] Disabling aarch64 build on OBS
To release chromium-efl onto OBS system,
the build for aarch64 needs to be disabled.
Supporting aarch64 task is in progress.
Once it's done, this patch will be removed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11575
Reviewed by: Antonio Gomes, KC Park
Change-Id: I99863b2756e9d2809e37a9f1dc5da6f518fce771
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
joke.song [Tue, 24 Feb 2015 08:44:55 +0000 (17:44 +0900)]
Fix Insertion popup tool-tip is displayed on selecting 'Cut'
After selecting context menu 'cut', Insertion menu is
displayed. Insertion popup tool tip should not be displayed.
Bug: http://168.219.209.56/jira/i#browse/TNEF-189
Reviewed by: Jaesik Chang, Karol Furmaniak
Change-Id: Ib89be98522fdd86cbff417a2da831b6b1c4e1d34
Signed-off-by: joke.song <joke.song@samsung.com>
ByungJun Kim [Wed, 25 Feb 2015 13:46:33 +0000 (22:46 +0900)]
Change size of DateTime Popup to prevent hidden by IME.
When open DateTime popup and tap on MM/DD/YY fileds,
IME hide the popup.
We need change size of DateTime popup.
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Ica3ea7f02883f609309c21bd5f86498fd3334c63
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Piotr Tworek [Thu, 9 Oct 2014 15:56:44 +0000 (17:56 +0200)]
[M34-Merge] Avoid overriding DIR_MODULE path also on desktop.
On desktop DIR_MODULE is used to find files in build directory.
Overriding it makes efl_webview_app or content shell look for some of
the resources it needs in wrong directories under
out.x64/Debug/resources/resources instead of out.x64/Debug/resources.
The code was not present in the original code copied from chrome. For
unknown reasons it is only enabled in chromium-efl desktop builds.
Remove it as it's clearly wrong. We should not override paths which may
be used as base values for other paths.
M34-Merge: http://165.213.202.130:8080/#/c/70612/
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park, commitbot
Change-Id: If02c9d6ec314a9d327a04754cea3bd3bea5375a5
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
k2.nagaraju [Thu, 19 Feb 2015 13:46:00 +0000 (19:16 +0530)]
[MM] Video corruption issue with AppSink
Gstbuffer size aligned to multiple 8, Videoframe buffer size
aligned to multiple of 16. For resolutions which are not
multiple of 16, gst buffers as to copy row-by-row to videoframe
buffer.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11484
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: I30c7007400148c0b9ffb5cc28599e4f1e71f76ae
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
Marcin Strakowski [Wed, 25 Feb 2015 12:44:15 +0000 (13:44 +0100)]
fixup! After changed edit type, IME state doesn't change.
Fix on showing context IME.
Reviewed by: Jaesik Chang, Marcin Kolibabka
Change-Id: I7fcf784fa6a89bb5279d1283358d9b74114f78a4
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
Youngcheol Kang [Wed, 25 Feb 2015 09:12:58 +0000 (18:12 +0900)]
Resolved the build problem which uses the ccache option
Below error were occurred when we uses the '--ccache' option
build/apply_patches.sh: pushd: /var/src: No such file or directory
build/apply_patches.sh: popd: directory stack empty
The 'CHROME_SRC' value is already contained as '/var/src' when we
uses the '--ccache' option.
For resolving this problem, we removed the conditions
which check whether 'CHROME_SRC' value was contained.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11572
Reviewed by: Antonio Gomes, joonhwan kwon
Change-Id: I91716ecc67e0c36fb1d22943dc09ac582c8991b1
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
hyungsun.ryu [Wed, 25 Feb 2015 06:00:44 +0000 (15:00 +0900)]
[Tizen 3.0] Set S/W codec for MSE
Odroid can not support omx decoder yet.
Hence, video and audio codec are changed to S/W codec.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11432
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Idf6e9a215864a3d582b8ce93064369340eab8c8f
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
Daniel Waślicki [Wed, 18 Feb 2015 08:21:38 +0000 (09:21 +0100)]
Revert "temporary fix! - disable drag&drop"
This reverts commit
499a670310761938ea861fa809a4302c66f48015.
Implementation of Drag&Drop was splitted into two parts. First one
implemented EFL`s port for D&D with default behavior, which is
dragging on long press. Second part changed default behavior to
starting D&D after choosing proper option from context menu. After
merge of first patch issues was raised that one cannot open context
menu for URL links. Now both parts are merged so this issue does not
occur any more.
Reviewed by: Antonio Gomes, Michal Roj, Piotr Tworek, SeungSeop Park, arno renevier
Change-Id: Ibb466c3068ce074b79211ea482271e97e2a059a0
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Arnaud Renevier [Tue, 24 Feb 2015 20:59:21 +0000 (12:59 -0800)]
Do not log an error when gl surface creation is successful
When gl surface is created successfuly, an error is logged. This is
confusing and clutters stderr uselessly. This patch removes this
spurious logging.
Reviewed by: Antonio Gomes, venu musham
Change-Id: Icb02f0ca21abb6f39188c2bd520d5abd8af69fa9
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngsoo Choi [Mon, 23 Feb 2015 01:20:37 +0000 (10:20 +0900)]
fixup! Added Tizen Trace package for debugging
Tizen v2.3 does not support ttrace rpm package.
Original message:
SQE usually uses Tizen Trace for debugging.
So, it is needed to add "ttrace" package into chromium-efl
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11501
Reviewed by: Antonio Gomes, KC Park
Change-Id: I6af315b1d4639e907f4bbb2c60b1f5f60d34c3e8
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Venugopal S M [Fri, 20 Feb 2015 12:52:31 +0000 (18:22 +0530)]
[MM] Gstreamer 1.0 packages for desktop
Added support for downloading Gstreamer 1.0 packages for
desktop.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10745
Reviewed by: Hyungsun Ryu, SeungSeop Park, Sharath Kamath
Change-Id: Id94a000b9cbec094981656d0aabd5c50811255bb
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
k.r.ranjan [Mon, 23 Feb 2015 08:11:19 +0000 (13:41 +0530)]
fixup! [Tizen][MM][Webrtc] GetUserMedia Support
This commit includes
- taking camera_id from constraints from getusermedia
- making rear camera as default in case of no constraints
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10584
Reviewed by: Min-Soo Koo, Sharath Kamath, Venugopal S M
Change-Id: Ia7874f7587307af2fae60b27c0f027106d9a4aa1
Signed-off-by: k.r.ranjan <k.r.ranjan@samsung.com>
Youngsoo Choi [Tue, 24 Feb 2015 09:20:36 +0000 (18:20 +0900)]
[tizen v3.0][x86_64] Disabling linux_use_gold_flags
[issue]
Following error is coming during x86_64 build.
>> collect2: fatal error: cannot find 'ld'
[resolve]
We are currently using gold linker in 'build/prebuild'.
because Tizen platform does not support gold linker.
When building for x64, common.gypi sets linux_use_gold_flags
to 1, which adds -fuse-ld=gold to the linker command.
This causes the linker to be search at in '/usr/bin',
so the error has been happens.
Until gold linker is supported by Tizen platform.
we need to disable the flag 'linux_use_gold_flags'.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11542
Reviewed by: Antonio Gomes, Eun Namgung, KC Park
Change-Id: I86c419b08ff8d34ec33151696a77ee820d4ce073
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Marcin Strakowski [Thu, 19 Feb 2015 15:13:48 +0000 (16:13 +0100)]
After changed edit type, IME state doesn't change.
When we change input box type (eg. Enter, Done, Alpha, Numeric),
IME has to change also its appearance. Sometimes on mobile platform
keyboard doesn't change its layout; even when we requested for this. This
patch is workaround for platform issue and triggers new layout by
hide/show on IME.
Bug: http://168.219.209.56/jira/i#browse/TNEF-231
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I9d5562986f034aae2795bcd66b1173eb7a2d90de
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
ByungJun Kim [Tue, 24 Feb 2015 02:42:26 +0000 (11:42 +0900)]
Add *.po for supporing many languange.
In WCS test cases: Works only for languages which translation files
are present in platform for example: Korean, Polish.
For other languages files with translation are needed.
To supporting translation, need to add *.po.
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Id6584abf6f5bef1bec6ada77adf08ebaca1d3fdd
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Karol Furmaniak [Mon, 23 Feb 2015 11:06:54 +0000 (12:06 +0100)]
fixup! Let long press selection bits be handled by SelectionController
[Problem]: Context menu is not displayed when long tap on text links
or images.
[Solution]: HandleLongPressEventPrivate should be called only
when long press on editable area or plain text.
Bug: http://168.219.209.56/jira/browse/TNEF-167
Reviewed by: Antonio Gomes, Jaesik Chang, Marcin Kolibabka
Change-Id: I7c0c753c71b41950e7d2f505b87f77a8bff40ddc
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
s.kamath [Thu, 19 Feb 2015 13:05:04 +0000 (18:35 +0530)]
[MM][WebRTC] OMX codec integration on m0 target.
Added support for accelarated encoding/decoding with WebRTC.
Uses omxh264 encoder & decoder for accelaration.
Avoiding usage of convertor as camera output is in I420 format.
h264parser needed at decoder pipeline as omxh264dec take
parsed frames at src pad.
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: I28708efeb48427125c3ba708c454cd556fb205c3
Signed-off-by: s.kamath <s.kamath@samsung.com>
Youngsoo Choi [Tue, 10 Feb 2015 10:32:40 +0000 (19:32 +0900)]
[Tizen][OBS] Changes for Tizen OBS Build
[Issue]
OBS build does not support running script 'build_{target].sh'.
1) GBS Build Options
In OBS build, definitions, coming through gbs build option, can NOT be used,
such as 'chromium_efl_tizen_version'.
2) Package Name
In OBS build, using macros around property 'Name' in spec file is not allowed.
3) Supplementary Repository
In OBS build, the supplementary repository is not allowed.
[Resolve]
1) GBS Build Options
The definitions, coming through gbs repository, are used,
instead of the definitions coming through gbs build option.
2) Package Name
In Tizen v3.0, appid should be consist of '.',
but package name doesn't need to follow that rule.
3) Supplementary Repository
The supplementary repository is removed in the file 'gbs.conf'.
Currently, chromium-efl doesn't have dependency of supplementary repository.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11500
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11502
Reviewed by: Antonio Gomes, KC Park, SeungSeop Park
Change-Id: I91876dadbd3643dec2046e87d7e0658a68292d81
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
amit.kumar8 [Tue, 24 Feb 2015 07:19:57 +0000 (12:49 +0530)]
fixup! fixup! Fix ewk_view_orientation_send API
Sending following message:
rwh->Send(new ViewMsg_Resize(rwh->GetRoutingID(), params));
is causing video playback issues during orientation change.
In chromium code there is only one place that is sending
this message and it's guarded around in many ways, hence
disabling it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11476
Reviewed by: DaeHyun Ko, Siba Samal
Change-Id: I53a91c07a55d1f73cbfb364e4ba646e209ac55bc
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Sergey Stepantsov [Thu, 12 Feb 2015 10:47:14 +0000 (19:47 +0900)]
TV Crash in Speed reading site
Lunch timer in appropriate thread
TV uses player_product.h in media_player_bridge_capi.cc,
player_prepare_async is used to prepare player to play content
callback for this returned in new thread and in this thread
timers will be lunched to update current time and buffer state. It
leads to crash, as timer should be run from the same thread.
(For phone problem is not reproducible, because phone uses
player_internal.h and callback for player_prepare_async always
returns control to UI thread).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10941
Reviewed by: Min-Soo Koo, Venugopal S M
Change-Id: Id2026e6a093410dbb173c4f7edbae20b57a6273e
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
uzair.jaleel [Mon, 16 Feb 2015 13:36:26 +0000 (19:06 +0530)]
Updated EGL samples to 4 for Mali t400
Best Supported EGL framebuffer configuration is
Red : 8
Green : 8
Blue : 8
Alpha : 8
Depth : 24
Stencil : 8
Samples : 4
Bug :http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: Ie758837c7be52cd8691970b629dc3ad1c4772d61
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Arnaud Renevier [Mon, 23 Feb 2015 23:12:21 +0000 (15:12 -0800)]
Fixes compiler warnings
This patch fixes various compiler warnings: initialization order of
class members, incorrect sign comparaison, uninitialized variable,
incorrect return types, incorrect enum comparaison and incorrect type
conversions.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9706
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I6aeccb073cf9561d2cbb09c5c63e60397d81a8d1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngcheol Kang [Mon, 23 Feb 2015 09:06:25 +0000 (18:06 +0900)]
[TIZEN][OBS] Excluded all Arch build from wearable profile
The chromium-efl doesn't support the wearable profile.
According to the platform team's request,
the codes for excluding the all Arch from wearable were
added into the spec file.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11507
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I6cbf89ee20fb17c867031b77604a8cfb536dc904
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
uzair.jaleel [Thu, 19 Feb 2015 14:36:24 +0000 (20:06 +0530)]
Invoke draw call to evas gl surface only for a valid texture.
Currently, texture id is not initialized for a new RWHV. So, when we
navigate to a new page, a draw attempt is made for an undefined texture
and hence we see the black screen. With this patch, we draw only when
the texture is valid.
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: Siba Samal, venu musham
Change-Id: I19665a4fa6252d86364b2fc4e4ea484d78a551cf
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Chandan Padhi [Fri, 20 Feb 2015 10:28:44 +0000 (15:58 +0530)]
[M34 Merge] Fixed that webview is crushed on resizing viewport.
webView is crushed when creating/removing IME and rotating device.
It is caused by diffrence between the size of egl surface rendered
and glViewport arguments. The arguments were set by evas geometry size,
but it was different from the size of rendered surface.
M34-merge: http://165.213.202.130:8080/#/c/69746/
Bug: http://168.219.209.56/jira/browse/TNEF-190
Reviewed by: DaeHyun Ko, Siba Samal, venu musham
Change-Id: I3e00275dc439ef04c78b6709010aaf5a49c54a84
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Arnaud Renevier [Tue, 17 Feb 2015 18:26:08 +0000 (10:26 -0800)]
fixup! Fix user agent setter unittests
Right now, utc_blink_ewk_view_user_agent_set_func.cpp fails to build
with "error: invalid conversion from ‘const void*’ to ‘void*’"
We now Eina_Stringshare instead of const char*
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10887
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: I2dd071569b61d59495373ff456ff1990f956b39b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
venu musham [Tue, 17 Feb 2015 10:37:48 +0000 (19:37 +0900)]
[M34 Merge] Add default color to new initialized EvasGL
While new tab in browser is created there is black screen
visible, because EvasGL is initialized with default black
image. This change initialize EvasGL with white image and
result there is no more black screen while new tab is
opened.
M34-merge: http://165.213.202.130:8080/#/c/69924/
Bug: http://168.219.209.56/jira/browse/TNEF-166
Reviewed by: DaeHyun Ko, Prashant Nevase (OOO Feb/20 to Feb/24)
Change-Id: Ia8e337cf49db06122a496822a0e4833eb16e7afc
Signed-off-by: venu musham <venu.musham@samsung.com>
Dominik Duda [Tue, 17 Feb 2015 11:20:24 +0000 (12:20 +0100)]
Add profile for build on Tizen 3.0 TV emulator
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11434
Reviewed by: KC Park, Marcin Kolibabka, Piotr Tworek
Change-Id: I73f7c3fcdacedaaf16edd820c27344b69c921cdd
Signed-off-by: Dominik Duda <d.duda@samsung.com>
Antonio Gomes [Thu, 18 Dec 2014 15:56:32 +0000 (07:56 -0800)]
Remove unneeded pkg-config dependency: capi-appfw-application
No targets actually need it to build/link/run.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Piotr Tworek, Viatcheslav Ostapenko, commitbot
Change-Id: I369c850b41880049ace073a55457ed4633595ae6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Filip Piechocki [Tue, 16 Dec 2014 10:01:23 +0000 (11:01 +0100)]
Custom protocol handler test page added.
Custom protocol handlers' origin must have 'http' or 'https'
protocol and the site registering the custom handler must be
of the same origin as this handler. This implies, that the
test page's origin must have 'http' or 'https' protocol, so
we hosted this test page on GitHub:
http://jmajnert.github.io/tests/customProtocols/
and modified tests to use it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9522
Reviewed by: Antonio Gomes, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I5bfc9ff681f1bdfde1131af6d25f88c42bc92235
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Sergey Stepantsov [Mon, 15 Dec 2014 05:18:19 +0000 (14:18 +0900)]
Added functionality to take screenshot in mini_browser phone application.
By pressing menu button mini_browser saves
screen shot of web page in /opt/usr/media/Downloads as png.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9796
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
Change-Id: I9afb4ceb6424da106a150b57026761c64616fa05
Antonio Gomes [Wed, 18 Feb 2015 16:06:40 +0000 (12:06 -0400)]
Properly handle context menu item callbacks on desktop.
In ContextMenuControllerEfl::ContextMenuItemSelectedCallback
there is desktop only ifdef that at somepoint made it possible
to get context menu items callbacks working.
Today, the assumption and workaround in that block of code do
not apply anymore, and was making in fact breaing context menu
items' callbacks to work.
Patch removes it and unifies mobile, tv and desktop code paths.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I4230f336430b9e97478c9efa1f1592a5d3d18b5e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Tomasz Czekala [Fri, 20 Feb 2015 10:00:46 +0000 (11:00 +0100)]
Fix unittests for ewk_view_add_with_session_data
Added check for ewk_view_add_with_session_data and deleting webview to
remove all instances of WebContext
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: DONGJUN KiM, Filip Piechocki, Piotr Tworek
Change-Id: I582a06562df6b67dc78a38c2b9f3626019e0a473
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Antonio Gomes [Thu, 19 Feb 2015 21:20:11 +0000 (17:20 -0400)]
Let tap's selection bits be handled by SelectionController
Lots of code in EWebView::HandleTapGesture did not belong there,
and should be defered to SelectionControllerEfl.
Patch pulls the trigger.
http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Tworek, arno renevier
Change-Id: If59d48daad54b05e1432e42bb5814444942d2088
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>