Stephen Toub [Fri, 25 Oct 2019 18:05:19 +0000 (14:05 -0400)]
Remove ILLinkTrim.xml from System.Text.Json (dotnet/corefx#42118)
* Remove ILLinkTrim.xml from System.Text.Json
Instead use PreserveDependencyAttribute.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
567241af05d1e43142d04572dee84870b78761aa
buyaa-n [Fri, 25 Oct 2019 16:35:56 +0000 (09:35 -0700)]
Annotate System.Linq.Parallel for nullable ref types (dotnet/corefx#41533)
* Nullable annotation for System.Linq.Parallel
Commit migrated from https://github.com/dotnet/corefx/commit/
4a863a6232477c673f7a41aae656f5054f9dbc78
Youssef Victor [Fri, 25 Oct 2019 15:55:35 +0000 (18:55 +0300)]
Use NameOf in Conversion.vb (dotnet/corefx#42117)
Commit migrated from https://github.com/dotnet/corefx/commit/
be6bcd6cd996cc8e0e003e15a645e4c2f32e5249
Ahson Khan [Fri, 25 Oct 2019 03:05:48 +0000 (20:05 -0700)]
Update the S.T.E.W configurations to explicitly target a versioned TFM (nc3.0). (dotnet/corefx#42069)
* Update the S.T.E.W configurations to explicitly target a versioned TFM
(nc3.0).
* Use custom defined constant like S.T.Json - Building_Inbox_Library
* Update config.props to use package config and leave netcoreapp as a build config
* Add back netcoreapp specific config to the src csproj
* Revert "Use custom defined constant like S.T.Json - Building_Inbox_Library"
This reverts commit dotnet/corefx@
8648cf6d7f5cbe54a6b1facdebc3f33c255572a1.
* Remove extra new line.
Commit migrated from https://github.com/dotnet/corefx/commit/
0954a975f972546314bd3ac4eb6e0a6380a85701
Santiago Fernandez Madero [Fri, 25 Oct 2019 00:30:59 +0000 (17:30 -0700)]
Update SDL validation to use values from corefx-sdl-validation variable group (dotnet/corefx#42098)
Commit migrated from https://github.com/dotnet/corefx/commit/
cc81928acb2907ff0ae207630f82c2dfa37a9f89
Eirik Tsarpalis [Thu, 24 Oct 2019 23:02:30 +0000 (00:02 +0100)]
HttpStress: Add Stress Pipelines (dotnet/corefx#41833)
Commit migrated from https://github.com/dotnet/corefx/commit/
f41ba828c76126a871d986cb5b7e9c44ddf6f3d7
Eugene Samoylov [Thu, 24 Oct 2019 22:52:56 +0000 (03:52 +0500)]
Add tests to verify that JSON deserializer doesn't do any multiplication or addition on the string length (dotnet/corefx#41754)
* Add deserialization tests for very long input strings (dotnet/corefx#41687)
* Fix tests
* Add deserialization tests for the maximum possible string length
* Improve long strings creation in deserialization tests for netcoreapp
* Extract common logic from if/def block
* Fix assertion
* Remove unnecessary test cases
* Remove other extra test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
7105528014425ca7f042e05e8d57e9e243931a62
Alexander Nikolaev [Thu, 24 Oct 2019 22:51:16 +0000 (00:51 +0200)]
Use ValueStringBuilder in UriHelper.UnescapeString (dotnet/corefx#41684)
* UriExt.UnescapeDataString avoids a new string allocation for an unmodified unescaped string
* Original dest array reuse fixed
* ValueStringBuilder is used instead of PooledCharArray
* Remove unused type
* Changes to ValueStringBuilder reverted
* IsStringSame replaced with SequenceEqual
* Array returned from buffer is cleared
* - Indexer-based assignment is replaced with Append method
- Explicit pooled array cleaning is removed
* .sln file changes reverted
* Build fixed
* UnescapeString always copies the result to dest array
* Unused code removed
* Original string reuse fixed
* Heap validation fixed
* - Small optimizations
- Code style fixes
* By-char append is replaced with span-based one
* SequenceEqual is invoked against the original string
* Revert "By-char append is replaced with span-based one"
This reverts commit dotnet/corefx@
e5919e3dbe4be0681540c5084fce23d026149957.
Commit migrated from https://github.com/dotnet/corefx/commit/
dacc2557066141357674b4311c83457de35df9d0
dotnet-maestro[bot] [Thu, 24 Oct 2019 22:29:50 +0000 (22:29 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#42094)
* Update dependencies from https://github.com/dotnet/coreclr build
20191024.2
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19524.2
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19524.2
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19524.2
* Update ref/System.Runtime.Intrinsics.Experimental.cs corresponding to https://github.com/dotnet/coreclr/pull/27382/
* Updating System.Numerics.Vectors to type forward to S.P.Corelib
* Regenerating the System.Runtime.Intrinsics ref assembly for existing APIs
* Regenerating the System.Runtime.Intrinsics ref assembly for new APIs
* Removing DefaultTargets="Build" from the S.R.I and S.N.V Configurations.props
Commit migrated from https://github.com/dotnet/corefx/commit/
9a58cfa732994294b0d65fd115378ea98b3177e8
Krzysztof Wicher [Thu, 24 Oct 2019 22:06:34 +0000 (15:06 -0700)]
Support PinChangedEvent on Unix (dotnet/corefx#40383)
* Support PinChangedEvent on Unix
* address PR feedback
* Fix typo in RaisePinChanged
Commit migrated from https://github.com/dotnet/corefx/commit/
3dae29b60e6f0707b60f831ce77286de75ef8958
Stephen Toub [Thu, 24 Oct 2019 18:29:03 +0000 (14:29 -0400)]
Fix non-netcoreapp builds
Commit migrated from https://github.com/dotnet/corefx/commit/
bd5ff7a1f86be8b44697d2e6ab93be1510158e90
Tomas Weinfurt [Thu, 24 Oct 2019 20:36:01 +0000 (13:36 -0700)]
improve performance of GetAllNetworkInterfaces on Linux (dotnet/corefx#41490)
* improve GetLinuxNetworkInterfaces
* more improvements to GetAllNetworkInterfaces()
* fix compilation
* update ethtool to support older kernels
* fix osx
* more platform fixes
* put PrefixLengthToSubnetMask back as it was
* normalize units properlry
* fix constant
* feedback from review
* fix log initialization
Commit migrated from https://github.com/dotnet/corefx/commit/
8bd0eb37f048375f038954fe444f7abd7b5681b6
Jeremy Barton [Thu, 24 Oct 2019 20:26:54 +0000 (13:26 -0700)]
Clean up some X509FilesystemTests tests (dotnet/corefx#42089)
* Make all of the Fact methods public
* Improve the assert messages in VerifyCrlCache
* Make VerifyCrlCache understand offline revocation unknown asserts two flags now.
Commit migrated from https://github.com/dotnet/corefx/commit/
4494e09e68d1546dd69c8ef4bc44a32479e940d6
Sven Boemer [Thu, 24 Oct 2019 19:37:31 +0000 (12:37 -0700)]
Update ILLink.Tasks (dotnet/corefx#39287)
* Update ILLink.Tasks
* Don't import linker nuget package targets
We use custom targets to invoke the linker.
* Don't pass directories as assembly paths
Instead pass them as extra linker args. To avoid issues with the
response file parsing logic, we remove trailing slashes.
* Update to linker version with unusedinterfaces opt
* Update System.Text.Json with more ctor roots
Commit migrated from https://github.com/dotnet/corefx/commit/
e715ba830fa52e7cede03abb5bb702e53429bbf1
Noah Falk [Thu, 24 Oct 2019 19:29:54 +0000 (12:29 -0700)]
DiagnosticSourceEventSource fixes/improvements for distributed tracing (dotnet/corefx#41943)
* DiagnosticSourceEventSource fixes for distributed tracing
1) There is no existing mechanism for DiagnosticSourceEventSource to fetch the current activity object. By convention it is not passed as an event argument, but rather stored in the async-local property Activity.Current. This was fixed by adding a well-known "*Activity" property that returns the result of Activity.Current regardless what object it is applied to.
2) DiagnosticSourceEventSource fails to evaluate properties on value types, such as DateTime.Ticks. Calling MethodInfo.CreateDelegate
needs to use a different signature for ref and value type properties and previously the code always used the ref-style signature. Fixed by adding ValueTypedFetchProperty that does the proper CreateDelegate and delegate invocation for structs.
3) There is no mechanism for DiagnosticSourceEventSource to enumerate the tags on an activity. This change adds the *Enumerate well-known property which will iterate any IEnumerable`1, invoke ToString() on each element, then join it as a string.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef563159787f3976ab47b9f304d58a7505828591
Tarek Mahmoud Sayed [Thu, 24 Oct 2019 18:43:50 +0000 (11:43 -0700)]
Fix RegionInfo.DisplayName test (dotnet/corefx#42088)
Commit migrated from https://github.com/dotnet/corefx/commit/
974fe33fbdfc1b8a47671070ce99bc1114eec2a8
Layomi Akinrinade [Thu, 24 Oct 2019 18:40:46 +0000 (11:40 -0700)]
Ensure serializer throws JsonException when deserializing incompatible JSON into collections (dotnet/corefx#42066)
* Ensure serializer throws JsonException when deserializing incompatible JSON into collections
* Address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8c92fa400f7a96d08c0d35cf14d91446e58d3512
Tomas Weinfurt [Thu, 24 Oct 2019 17:19:39 +0000 (10:19 -0700)]
add entries for new FreeBSD releases (dotnet/corefx#41794)
Commit migrated from https://github.com/dotnet/corefx/commit/
32d103eecf9d1e9648e6b1ed063860fed00bcc8f
Jeremy Barton [Thu, 24 Oct 2019 13:01:53 +0000 (06:01 -0700)]
Normalize Linux and Windows X.509 Revocation Statuses (dotnet/corefx#41956)
* Add CrlCrl test before revocation support
* Add revocation tests
* Add lots of tests with revocation
* Make Linux download respect time remaining
* Use synchronous wait so Linux gets an answer
* Use IPv4Loopback name instead of localhost for stability (IPv4 vs IPv6)
* Some tracing improvements
* Add a lot more tests
* Linux multi-OCSP and revocation normalization support
* Even more tests, mainly invalid responses
* Respect CorruptRevocationIssuerName
* Fix the "no timeout" overflow.
* Treat OfflineRevocation as always suppressed
* Finish some half-finished tests
* De-spaghetti Linux OCSP processing
* Check what happens for testing the root directly
* Native changes for Linux multi-layer OCSP
* Make Linux portable build work
* Mitigate issue 41969 in tests
* Support decoding incorrect encoding of OCSPRequest
Also fix an exact-tag vs loose-tag check.
* Disable DynamicRevocationTests on macOS
* Disable designated responder tests on RHEL6.
* Cache the error string for each error code
* Self-review cleanup
* Disable designated OCSP responder tests on Win7
* Re-enable WIn7 designated responder tests, increase timeouts.
* Running locally on Win7 the designated responder tests pass
* Observation of the intermittent CI failures shows they were always in excess of 5 seconds.
* Running locally the longest test was 1 second, and that includes generating several RSA keys.
* Apply review feedback
* Move DynamicRevocationTests to OuterLoop
Commit migrated from https://github.com/dotnet/corefx/commit/
471c93883f24c22513387217890136d7fa7248b6
Vladimir Sadov [Thu, 24 Oct 2019 12:23:17 +0000 (05:23 -0700)]
Moving StopWatch to `src\Common\src\Corelib` (dotnet/corefx#42072)
Commit migrated from https://github.com/dotnet/corefx/commit/
681c3f138d6bcf1eeed8841ac7c3552c6e886e8d
Omair Majid [Thu, 24 Oct 2019 12:12:22 +0000 (08:12 -0400)]
Add cgroup v2 support to Interop.cgroups (dotnet/corefx#39686)
* Add cgroup v2 support to Interop.cgroups
Fix up code to adjust cgroup v1 assumptions and check cgroup v2 paths,
locations and values.
Continue using the older cgroup v1 terminology for APIs.
* Clean up new tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8d18e3c9ed8ec205429fb061aae676a70af71c50
Roman Marusyk [Thu, 24 Oct 2019 01:32:12 +0000 (03:32 +0200)]
Recombine files ProcessTests.cs and ProcessTests.netcoreapp.cs (dotnet/corefx#42063)
* Recombine files ProcessTests.cs and ProcessTests.netcoreapp.cs that aren't supported anymore
* Add namespaces
Commit migrated from https://github.com/dotnet/corefx/commit/
bd18c12df9e5dd365a8b708cc2e7e0488b8177c1
Tim [Wed, 23 Oct 2019 22:09:43 +0000 (06:09 +0800)]
Optimize Enumerable.SkipLast() for IPartition and IList (dotnet/corefx#41342)
* Optimize Enumerable.SkipLast() for IPartition and IList
* Convert to conditional expression
* Add parameter name
* Revert "Convert to conditional expression"
This reverts commit
7c7908fb
* Format conditional expression
Commit migrated from https://github.com/dotnet/corefx/commit/
bdd33976fe3713cc3e78b83cf2a1176c70b793be
Grisha Kotler [Wed, 23 Oct 2019 20:01:57 +0000 (23:01 +0300)]
Reduce the number of syscalls when converting Ticks to TimeSpan (dotnet/corefx#41989)
* Reduce the number of syscalls when converting Ticks to TimeSpan
* Remove the usage of Lazy
* Fix build
Commit migrated from https://github.com/dotnet/corefx/commit/
81a551c219041cacdb6c5f77ff1dd588e8bebd01
Stephen Toub [Wed, 23 Oct 2019 18:05:54 +0000 (14:05 -0400)]
Delete duplicative exception add in SourceCore (dotnet/corefx#42035)
Commit migrated from https://github.com/dotnet/corefx/commit/
be22fd85b2ceb377de87e6bda006f819569fec3a
Tanner Gooding [Wed, 23 Oct 2019 01:29:14 +0000 (18:29 -0700)]
Regenerating the ref assembly for System.Runtime.Intrinsics.Experimental
Commit migrated from https://github.com/dotnet/corefx/commit/
a3f71bfe819463e388fa7afe77a579ebf99ac866
Tom Deseyn [Wed, 23 Oct 2019 13:50:26 +0000 (15:50 +0200)]
Remove Socket.InnerSafeCloseSocket (dotnet/corefx#41888)
* Remove Socket.InnerSafeCloseSocket
* Move IsInvalid checks in SetHandle function
* PR feedback
* Remove unnecessary 'SocketPal.'
* Remove SafeSocketHandle.SetHandle
Commit migrated from https://github.com/dotnet/corefx/commit/
092dff2a5a660ac6cf1668e8feabc236bb045813
Dan Moseley [Wed, 23 Oct 2019 13:36:52 +0000 (06:36 -0700)]
Event log retries (dotnet/corefx#42017)
Commit migrated from https://github.com/dotnet/corefx/commit/
6249535d47b1679b8a7021aed2fcdb3af792e387
Eriawan Kusumawardhono [Wed, 23 Oct 2019 13:33:22 +0000 (20:33 +0700)]
Remove unused locals in System.Data.Common and keep some logic using discard (dotnet/corefx#41962)
* remove unused locals in System.Data.Common and keep some logic using discard
* revert the HandleTable(element) removal as PR feedback. Use discard as return value is ignored.
Commit migrated from https://github.com/dotnet/corefx/commit/
ae71c86289d759318e212144b94c58d0a586a33c
Stephen Toub [Wed, 23 Oct 2019 13:30:24 +0000 (09:30 -0400)]
Add test for SafeHandle handling in Socket.Select (dotnet/corefx#42018)
Commit migrated from https://github.com/dotnet/corefx/commit/
57c3a5490eb4d9235f824544b37cdbb21ac88c39
Tanner Gooding [Wed, 23 Oct 2019 12:44:26 +0000 (05:44 -0700)]
Move Matrix3x2/4x4, Plan, and Quaternion to the shared CoreLib partition (dotnet/corefx#42021)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c037f4c21bd8a9bb0f9d218f9581a933d5bac95
Ahson Khan [Wed, 23 Oct 2019 08:09:34 +0000 (01:09 -0700)]
When encoder is null, use JavaScriptEncoder.Default to check for NeedsEscaping (dotnet/corefx#42023)
* When encoder is null, use JavaScriptEncoder.Default to check for
NeedsEscaping.
* Remove unnecessary unsafe keyword and add comment to using directive.
* Address feedback.
* Remove gotos and move the IsEmpty check outside the fixed block.
Commit migrated from https://github.com/dotnet/corefx/commit/
daadeef2eef255f86b301ded57996dda25618e90
Ahson Khan [Wed, 23 Oct 2019 07:27:40 +0000 (00:27 -0700)]
JsonSerializer.Serialize should check whether the passed-in (dotnet/corefx#42026)
Utf8JsonWriter is null.
Commit migrated from https://github.com/dotnet/corefx/commit/
b8cb521e83456bd81dc314c0625d6236d7955bd9
Stephen Toub [Wed, 23 Oct 2019 03:08:01 +0000 (23:08 -0400)]
Fix several Socket tests to not dispose an event (dotnet/corefx#42020)
When I run these tests locally, due to my network configuration they sometimes fail. If they fail and the test is disposing of the ManualResetEvent, the async callback may try to set the event after it's already been disposed, which throws an exception that crashes the test process. The easy fix is to just dispose of these MRE instances on success and let their finalizers clean up for them if the tests fail.
Commit migrated from https://github.com/dotnet/corefx/commit/
623703d941115131a7f269f9e23560f6d937837c
Carlos Sanchez Lopez [Wed, 23 Oct 2019 02:42:48 +0000 (19:42 -0700)]
Add directory creation method that takes an ACL (dotnet/corefx#41834)
* First commit
* Fix OperationCanceledException dependency error, revert nullable indication
* Only Directory files
* Unit tests verifications
* Split FileSystem.Windows into two additional files instead of one. Fix pinning.
* Remove dead comment, add actual UT verifications
* User WellKnownSidType
* Make method unsafe, nit comments addressed.
* Remove irrelevant comment
* Add additional exceptions to triple slash
* Add unit tests for additional exceptions
* Remove FileSystem.cs, it has one obsolete method. Replace all calls of that removed method.
* Second pass on required strings.resx resources
* Remove unused dependency cs files
* Move shared files to Common
* Add the missing braces
* Add nulcheck for this argument, add exception, document exception in triple slash, add unit test.
* Fix netstandard CI build failure
* Fix Microsoft.IO.Redist build issue with NetStandard
* Remove unnecessary assert in ut
* Fix build problem in Windows Packaging All Configurations x64_Debug, System.Runtime needs to be included to recognize NotNullIfNotNullAttribute, consumed in Path.Internal.cs
* Additional file splitting and dependency addition to fix netstandard/netfx build problems
* Fix netstandard and netcoreapp build issues
* Remove unused file
* nit cleaning
* Minimal unit tests
* Remove unused unit test code and spacing fix
* Add full framework condition to unit test
* Additional fix for full framework
Commit migrated from https://github.com/dotnet/corefx/commit/
5ed2e98718700ba37ed95c34ee04960b5aba1aa0
Jan Kotas [Wed, 23 Oct 2019 01:41:21 +0000 (18:41 -0700)]
Simplify LOGFONT marshalling (dotnet/corefx#42011)
Commit migrated from https://github.com/dotnet/corefx/commit/
86972eac7ce0707073b724d71be2927fc1fe225f
Tom Deseyn [Wed, 23 Oct 2019 01:01:59 +0000 (03:01 +0200)]
Socket.Select: increase ref count while the handle is in use (dotnet/corefx#41763)
* Socket.Select: increase ref count while the handle is in use
* PR feedback
* Use Socket.InternalSafeHandle for ref/release.
* Socket.Windows: SelectFileDescriptor: add missing unrefs
Commit migrated from https://github.com/dotnet/corefx/commit/
6c62c7ffc1496d1b262b8e5809412a222809b173
Ahson Khan [Wed, 23 Oct 2019 00:34:24 +0000 (17:34 -0700)]
Optimize FindFirstCharToEncode for JavaScriptEncoder.Default and Relaxed using Sse2 intrinsics. (dotnet/corefx#41933)
* Optimize FindFirstCharToEncode for JavaScriptEncoder.Default and Relaxed
using Sse2 intrinsics.
* Create an Sse2Helper and improve perf of TextEncoder and
AllowedCharactersBitmap
* Loop unroll FindFirstCharacterToEncode
* Improve code coverage.
* Add more tests for surrogate pairs and fix call to WillEncode.
* Address PR feedback - remove some code duplication.
* Move DefaultJavaScriptEncoder to separate file and override EncodeUtf8
with better caching.
* Add default replacement character as a test.
* Address nits.
Commit migrated from https://github.com/dotnet/corefx/commit/
c4b93b6768a5edd6416145de108c584a855aef26
Tanner Gooding [Tue, 22 Oct 2019 22:53:10 +0000 (15:53 -0700)]
Move Vector2/3/4 to the shared CoreLib partition (dotnet/corefx#42005)
Commit migrated from https://github.com/dotnet/corefx/commit/
edc00837f7e59ea18aa9cfd26c0de3d918714782
Tanner Gooding [Tue, 22 Oct 2019 22:53:01 +0000 (15:53 -0700)]
Adding Unsafe.SkipInit (dotnet/corefx#41995)
* Adding Unsafe.SkipInit
* Removing the "where T : struct" constraint from Unsafe.SkipInit
* Adding tests for Unsafe.SkipInit
Commit migrated from https://github.com/dotnet/corefx/commit/
cd97cf573c9c30f56437d0c05c489a8e1fa97c4b
Levi Broderick [Tue, 22 Oct 2019 22:18:05 +0000 (15:18 -0700)]
Add Encoding extensions which work with sequences (dotnet/corefx#41810)
Commit migrated from https://github.com/dotnet/corefx/commit/
6696f1665bb01bb571a3fc333f85a0ab0945fddf
Aaron Robinson [Tue, 22 Oct 2019 20:41:56 +0000 (13:41 -0700)]
Expose SuppressGCTransitionAttribute (dotnet/corefx#41997)
Commit migrated from https://github.com/dotnet/corefx/commit/
17d22ab65efa048b2971d2d1c93cb8bfa54635b4
Stephen Toub [Tue, 22 Oct 2019 20:29:31 +0000 (16:29 -0400)]
Annotate System.Text.Encoding.CodePages for nullable reference types (dotnet/corefx#41991)
* Annotate System.Text.Encoding.CodePages for nullable reference types
* Fix .NET Core 2.0 build
I'm not sure why we still build for this as a target, but there a bunch of nullability failures in the build because Debug.Assert isn't annotated in .NET Core 2.0's surface area, and thus places we're relying on Debug.Assert to suppress nullable warnings are failing.
Commit migrated from https://github.com/dotnet/corefx/commit/
d850afb1435c27ee036a09c564bfd84607fb0e94
Jeremy Kuhne [Tue, 22 Oct 2019 19:56:32 +0000 (12:56 -0700)]
Handle non blittable LOGFONT structs (dotnet/corefx#41975)
* Handle non blittable LOGFONT structs
Adding support for blittable structs broke non-blittable structs passed to `Font.FromLogFont`. Try to blit and fall through to the marshaller for non blittable types.
Fixes: https://github.com/dotnet/winforms/issues/2136
* Clarify comment block
Commit migrated from https://github.com/dotnet/corefx/commit/
0e524eba15fd96755c45ffe93b23007a13c89f5f
Viktor Hofer [Tue, 22 Oct 2019 19:06:27 +0000 (21:06 +0200)]
Revert license renaming (dotnet/corefx#42002)
Commit migrated from https://github.com/dotnet/corefx/commit/
0b514bd24fee534b10afa31a29d8cdcc6d7a920f
Anton Landor [Tue, 22 Oct 2019 19:04:08 +0000 (21:04 +0200)]
System.IO.FileSystem.MoveFile(...) will now delete source file after copying it to its destination when moving files over file systems. (dotnet/corefx#41767)
Commit migrated from https://github.com/dotnet/corefx/commit/
fd752586114139c6f42a44b86c9afddd1a128df4
Viktor Hofer [Tue, 22 Oct 2019 18:59:07 +0000 (20:59 +0200)]
Rename LICENSE to LICENSE.TXT (dotnet/corefx#42000)
Commit migrated from https://github.com/dotnet/corefx/commit/
23f5ecd6a1231d286257d9cc2efda549efed949b
Carlos Sanchez Lopez [Tue, 22 Oct 2019 18:44:29 +0000 (11:44 -0700)]
Unit tests to verify value returned by DirectoryInfo.Parent.ToString, both in CoreFX and in Framework. (dotnet/corefx#41452)
Commit migrated from https://github.com/dotnet/corefx/commit/
f7081cf3bac10352f4a3ac57aa4b5c0963d33e77
Stephen Toub [Tue, 22 Oct 2019 17:48:43 +0000 (13:48 -0400)]
Annotate System.Runtime.Serialization.Primitives for nullable reference types (dotnet/corefx#41992)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc7a8d93838d23573069fe792aa326d001ec300f
Santiago Fernandez Madero [Tue, 22 Oct 2019 17:27:41 +0000 (10:27 -0700)]
Update TsaBugAreaPath to fix SDL Validation (dotnet/corefx#41993)
Commit migrated from https://github.com/dotnet/corefx/commit/
2513d13acfb7fff55c8d4f956bcc3d64cf33f810
Steve Harter [Tue, 22 Oct 2019 15:31:09 +0000 (10:31 -0500)]
Merge pull request dotnet/corefx#41903 from steveharter/DictionaryOfT
Support IDictionary<string,TValue> without IDictionaryEnumerator
Commit migrated from https://github.com/dotnet/corefx/commit/
d3c298496e9dbdc35008efcaa6c863286f211170
Stephen Toub [Tue, 22 Oct 2019 14:23:15 +0000 (10:23 -0400)]
Fix a rare GetAwaiter().GetResult() on a ValueTask in System.Net.Http (dotnet/corefx#41958)
* Fix a rare GetAwaiter().GetResult() on a ValueTask in System.Net.Http
If someone's custom HttpContent-derived type is implementing their async SerializeToStreamAsync with synchronous Write calls on the destination stream, and if that WriteAsync method returns an IValueTaskSource-based ValueTask that's not yet completed, this could throw an exception. This is unlikely to actually negative impact anyone right now, but it's worth fixing. This is one of the patterns an analyzer around ValueTasks will help find and fix.
* Update src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpBaseStream.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
f37f05d4a7d916f14980456e9ddb95d2708efa24
Kevin Jones [Tue, 22 Oct 2019 14:16:21 +0000 (10:16 -0400)]
Cleanup unused locals in more places (dotnet/corefx#41964)
* Removed unused locals from AsnReader.
The return value of the method is not needed however the out values
are.
* Remove key local from ECDiffieHellmanCng.
The return value is not needed however the key still needs to be
generated.
* Remove key local from ECDsaCng.
The return value is not needed however the key still needs to be
generated.
* Remove unused local.
The return value is not needed from the method however the out
parameters are.
* Discard result from `CryptAcquireContext`.
The result is discarded rather than entirely omitted to clearly express
the intent that the return value is not used.
Commit migrated from https://github.com/dotnet/corefx/commit/
3d4511a79cbdbe85832c2af2ec18e165b696adc9
Viktor Hofer [Tue, 22 Oct 2019 12:55:16 +0000 (14:55 +0200)]
Disable ComponentModel MemberDescriptor parallel (dotnet/corefx#41985)
Commit migrated from https://github.com/dotnet/corefx/commit/
007f4456374c582ebc7a7a678072935a2560eee5
Ahson Khan [Tue, 22 Oct 2019 07:59:19 +0000 (00:59 -0700)]
Use Sse2 instrinsics to make NeedsEscaping check faster for large JSON strings (dotnet/corefx#41845)
* Use Sse2 instrinsics to make NeedsEscaping check faster for large
strings.
* Update the utf-8 bytes needsescaping and add tests.
* Remove unnecessary bitwise OR and add more tests
* Add more tests around surrogates, invalid strings, and characters >
short.MaxValue.
Commit migrated from https://github.com/dotnet/corefx/commit/
7cae92b39d2fed2e4e88e900f2e7d787ed9f6cfa
Steve Harter [Mon, 21 Oct 2019 23:57:52 +0000 (18:57 -0500)]
Additional merge issues and non-generic support for that
Commit migrated from https://github.com/dotnet/corefx/commit/
3a5409bc2f56fccb1d39c4ae37bfd6a15f06e73f
Steve Harter [Mon, 21 Oct 2019 22:55:44 +0000 (17:55 -0500)]
Merge branch 'master' of https://github.com/steveharter/dotnet_corefx into DictionaryOfT
Commit migrated from https://github.com/dotnet/corefx/commit/
d52aae926802668d0296fa346bcbe50b1b3a3cab
Stephen Toub [Mon, 21 Oct 2019 22:13:35 +0000 (18:13 -0400)]
Guard against attempting to creating out-of-range spans in macOS FileSystemWatcher (dotnet/corefx#41957)
* Guard against attempting to creating out-of-range spans in macOS FilesystemWatcher
Fixes https://github.com/dotnet/corefx/issues/40054
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
4277ccfa457d0dfad3fad00f8adbd27781b3bc57
Petr Onderka [Mon, 21 Oct 2019 20:37:17 +0000 (22:37 +0200)]
Cache polymorphic properties (dotnet/corefx#41753)
* Cache polymorphic properties
* Move RuntimePropertyCache to JsonClassInfo
* Added test of RuntimePropertyCache using properties with different attributes
* Fixed typo
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Use allocating overload of GetOrAdd on .Net Standard 2.0
Commit migrated from https://github.com/dotnet/corefx/commit/
46299619e290936c495264162ede68354ced5b18
madmir [Mon, 21 Oct 2019 20:25:04 +0000 (22:25 +0200)]
Refactor DllImports in System.Reflection.Metadata (dotnet/corefx#40579)
Commit migrated from https://github.com/dotnet/corefx/commit/
90706ad4925bb66f83b3fcade61ddda4c7a0f4e4
Stephen Toub [Mon, 21 Oct 2019 17:46:01 +0000 (13:46 -0400)]
Don't root FileSystemWatcher unnecessarily (dotnet/corefx#41872)
We already try to do this on Unix, though it seems we don't currently have tests for it, but we don't on Windows.
Commit migrated from https://github.com/dotnet/corefx/commit/
776aae562a1e65e80db00d83669b59802cf153cb
Fons Sonnemans [Mon, 21 Oct 2019 16:10:37 +0000 (18:10 +0200)]
Add readonly to members of System.Drawing.Primitives (dotnet/corefx#40407)
Commit migrated from https://github.com/dotnet/corefx/commit/
4746f754a5a46c465d083c8999335d62e607f25d
Dong-Heon Jung [Mon, 21 Oct 2019 16:09:44 +0000 (01:09 +0900)]
Fix a build error on ARM (dotnet/corefx#41937)
- Add type casting in CryptoNative_X509VerifyCertErrorString
Commit migrated from https://github.com/dotnet/corefx/commit/
f359e8c48ea9000c1cc588365daabe396e35afc2
Roman Marusyk [Mon, 21 Oct 2019 15:10:02 +0000 (17:10 +0200)]
Remove dead code null check from DirectoryEntry (dotnet/corefx#41843)
* Fix possible NRE in DirectoryEntry from System.DirectoryServices
* Update DirectoryEntry.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
c037aa0c71b4cd3d506aab843997ca06ce390c3a
Michal Strehovský [Mon, 21 Oct 2019 14:58:21 +0000 (16:58 +0200)]
Update breaking change rules for default interface methods (dotnet/corefx#41949)
* Update breaking change rules for default interface methods
* Apply suggestions from code review
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
7c7a167b20bb33140c05c03edb4ef98affa2a5c3
Carlos Sanchez Lopez [Mon, 21 Oct 2019 13:52:38 +0000 (06:52 -0700)]
Backup important wiki information (dotnet/corefx#41774)
* Backup important wiki information
* Restore original title in unix-instructions.md
* FreeBSD instructions only for 3.0
* Remove conferences.md
* update unix-instructions.md title
* Move FreeBSD link to the end of unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
9f5e3025ee2cfbd96e8854f6d0fd92add9592788
Dan Moseley [Mon, 21 Oct 2019 13:50:01 +0000 (06:50 -0700)]
Fix XSLT tests to deterministically pick newer xsltc.exe (dotnet/corefx#41919)
* Fix XSLT tests
* Typo
* Typo
* Nits
Commit migrated from https://github.com/dotnet/corefx/commit/
340db06faadb1256c02d3eab8e36b6f3c2972bb0
Viktor Hofer [Mon, 21 Oct 2019 13:13:09 +0000 (15:13 +0200)]
Update netfx queue to Windows 10 19H1 (dotnet/corefx#41942)
Commit migrated from https://github.com/dotnet/corefx/commit/
8bc0584c5d84eb83bf5901a7f3de83549e5518e1
Viktor Hofer [Mon, 21 Oct 2019 13:06:57 +0000 (15:06 +0200)]
Disabling TaskCanceledQuickly timing out test (dotnet/corefx#41941)
Commit migrated from https://github.com/dotnet/corefx/commit/
69fc7edb110a69345253060bb611deb3d4bec417
Tom Deseyn [Mon, 21 Oct 2019 03:50:38 +0000 (05:50 +0200)]
StreamPipeWriter: don't flush when the writer is completed with an exception. (dotnet/corefx#40874)
This provides a way to discard buffered data without pushing it to the inner Stream.
Commit migrated from https://github.com/dotnet/corefx/commit/
03453d9aae8e5d18e571699c5d2229b1ab5f4b9d
Boris Parfenenkov [Mon, 21 Oct 2019 02:50:08 +0000 (07:50 +0500)]
Add tests to improving TimeSpan precision (dotnet/corefx#41499)
Fix dotnet/corefx#41380
Commit migrated from https://github.com/dotnet/corefx/commit/
db17568ad06ed96b08b5c31fef3e1a2554f6216e
dotnet-maestro[bot] [Sun, 20 Oct 2019 14:46:00 +0000 (14:46 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41926)
* Update dependencies from https://github.com/dotnet/coreclr build
20191019.1
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19519.1
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19519.1
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19519.1
* Update argument names for CoreLib change
Commit migrated from https://github.com/dotnet/corefx/commit/
8d87e5cae96c5fb25ac21442bb56c337029d77a4
Vladimir Sadov [Sun, 20 Oct 2019 01:01:33 +0000 (18:01 -0700)]
A few more test scenarios for casting of nullables and open generic arrays. (dotnet/corefx#41918)
* A few more test scenarios for casting of nullables and open generic arrays.
Commit migrated from https://github.com/dotnet/corefx/commit/
03dd803990dfb8f05db8d0ec1bc34268386c1d5b
Nathan Mascitelli [Sat, 19 Oct 2019 20:44:24 +0000 (16:44 -0400)]
Improve the performance of ImmutableList.Contains (dotnet/corefx#40540)
* Improve ImmutableList.IndexOf performance
* Implement a spicific Contains method
IndexOf has a lot of overhead because it's looking for an index when
all Contains wants to do is find a matching element.
* Fix tests
* Revert change to IndexOf
Commit migrated from https://github.com/dotnet/corefx/commit/
a866d9643f23ddd2f47762e02ccdd2e387a8e5c8
Filip Navara [Sat, 19 Oct 2019 17:06:03 +0000 (19:06 +0200)]
Fix invalid IL generated in Xml serializers (dotnet/corefx#39765)
Commit migrated from https://github.com/dotnet/corefx/commit/
5e4bf872154c17a1407997a38cc013fb12d5d1af
Dan Moseley [Sat, 19 Oct 2019 17:01:09 +0000 (10:01 -0700)]
Annotate System.Resources.ResourceWriter for nullable ref types (dotnet/corefx#41880)
* Annotate System.Resources.ResourceWriter for nullable ref types
* ref
* Mark common as nullable enable explicitly
* _resourceList
Commit migrated from https://github.com/dotnet/corefx/commit/
1ed115a32d2eb0cfd329f36b01e0a8fadc3f484e
Viktor Hofer [Sat, 19 Oct 2019 16:41:09 +0000 (18:41 +0200)]
Use Loopback for PreAuthenticate request test (dotnet/corefx#41891)
* Use Loopback for PreAuthenticate request test
* Remove outgoing web request
Commit migrated from https://github.com/dotnet/corefx/commit/
e23871fc42a09ce01f0977f8101b9eba29451d5b
Viktor Hofer [Sat, 19 Oct 2019 12:09:46 +0000 (14:09 +0200)]
Prepare license and other files for the repo consolidation (dotnet/corefx#41912)
* Update .azure-ci.yml
* Rename LICENSE.TXT to LICENSE and others
Commit migrated from https://github.com/dotnet/corefx/commit/
0cee444c677d5c52a71ab2d82c2488b8dc585d6a
Jose Perez Rodriguez [Sat, 19 Oct 2019 11:30:51 +0000 (04:30 -0700)]
Adding single statement if formatting rule to coding-style (dotnet/corefx#41906)
* Adding single statement if formatting rule to coding-style
cc: @stephentoub @carlossanlop
This came up in a recent PR and I just wanted to make it more clear in our Coding guidelines.
* Apply suggestions from code review
Co-Authored-By: Sam Harwell <sam.harwell@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
dab6a40e999373db3604c287c759e16fad0e3eb3
Levi Broderick [Sat, 19 Oct 2019 05:37:16 +0000 (22:37 -0700)]
Add UTF8Encoding compat tests (dotnet/corefx#41910)
Commit migrated from https://github.com/dotnet/corefx/commit/
5590d3896f012c1c9b7774774456331a36ba1d57
Layomi Akinrinade [Sat, 19 Oct 2019 00:31:06 +0000 (20:31 -0400)]
Populate non-immutable collections directly on deserialize (dotnet/corefx#41482)
* Populate non-immutable collections directly on deserialize
(rather than storing in temporary collections and using converters to
create and populate instances)
* Fix deserilizing nested dictionaries
* Don't get add method for types we can populate without reflection; fix failing tests
* Misc perf changes
* Additional changes
* More changes
* Address review feedback
* Address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
2c06259cf2400704e550a74bf7b044159c2fcce5
Kevin Jones [Fri, 18 Oct 2019 21:36:26 +0000 (17:36 -0400)]
Discard unused locals cleanup (dotnet/corefx#41876)
* Discard result from GetC14NDigest.
GetC14NDigest is being used to update the `hashAlg` from the
`GetDigestedOutput`, as well as update the `_digestedSignedInfo` and
cache flag. The return value is not needed. Discard it to make that
clearer.
* Discard the result from `CertControlStore`.
The comment above the change explains the reason for discarding
the result.
* Ignore result from CryptAcquireContext.
The comment below justifies the reason for ignoring the local.
* Code review feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef8756c03ff3808e2b065e6cf5c07aa169ac868f
Steve Harter [Fri, 18 Oct 2019 15:27:43 +0000 (10:27 -0500)]
Support IDictionary<string,TValue> without IDictionaryEnumerator
Commit migrated from https://github.com/dotnet/corefx/commit/
8124b88d3851c49a2cc09ce5de879b6622cd202e
Viktor Hofer [Fri, 18 Oct 2019 18:58:41 +0000 (20:58 +0200)]
Disable MemoryCacheTest.Contains test (dotnet/corefx#41890)
Commit migrated from https://github.com/dotnet/corefx/commit/
b8048a1e2bd7ee776b4cb6df684db3a0b35886c1
buyaa-n [Fri, 18 Oct 2019 16:40:35 +0000 (09:40 -0700)]
Annotate System.ObjectModel for nullable (dotnet/corefx#41808)
Annotate System.ObjectModel for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
0ca34f1595299b605f97149927c938a4e086b7f3
Roman Marusyk [Fri, 18 Oct 2019 07:40:17 +0000 (09:40 +0200)]
Store Description value of ConfigurationProperty 2 (dotnet/corefx#41873)
* Store Description value of ConfigurationProperty
* Skip test on the .NET Framework
Commit migrated from https://github.com/dotnet/corefx/commit/
2b92fc0930b941cd0d9146971745cd717689434c
Ahson Khan [Fri, 18 Oct 2019 02:20:43 +0000 (19:20 -0700)]
Followup to add more extension data tests. (dotnet/corefx#41877)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f5c965af1c14703d449da665a26a845eb76973a
dotnet-maestro[bot] [Thu, 17 Oct 2019 22:30:59 +0000 (22:30 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41851)
* Update dependencies from https://github.com/dotnet/coreclr build
20191016.3
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19516.3
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19516.3
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19516.3
* Add unit tests for DecoderNLS
Commit migrated from https://github.com/dotnet/corefx/commit/
6eb32bf0faef55321f02b1502ddaeac6dc4a76f6
Viktor Hofer [Thu, 17 Oct 2019 21:59:14 +0000 (23:59 +0200)]
Remove arcade SolutionBuildTargets hack (dotnet/corefx#41868)
* Remove arcade SolutionBuildTargets hack
Commit migrated from https://github.com/dotnet/corefx/commit/
9b558d32e7dc784bb16aec11c22d56a82892cae3
Viktor Hofer [Thu, 17 Oct 2019 21:56:24 +0000 (23:56 +0200)]
Disabling DualModeConnectAsync test (dotnet/corefx#41874)
Commit migrated from https://github.com/dotnet/corefx/commit/
73c898d40df25bbf195e8287c6e037aa036043db
Stephen Toub [Thu, 17 Oct 2019 20:18:03 +0000 (16:18 -0400)]
Annotate System.Runtime.CompilerServices.Unsafe for nullable reference types (dotnet/corefx#41855)
* Annotate System.Runtime.CompilerServices.Unsafe for nullable reference types
The actual implementation is in IL, and there'd be no benefit to adding annotations there, so I've only annotated the C# ref assembly.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
a7b4117d96e0b58a69bf4b76ef56fa9e8c0880bb
Stephen Toub [Thu, 17 Oct 2019 20:17:41 +0000 (16:17 -0400)]
Annotate System.Web.HttpUtility for nullable reference types (dotnet/corefx#41854)
Commit migrated from https://github.com/dotnet/corefx/commit/
a97191b79893556ea9e798e56bda7f80eeba0567
Jan Kotas [Thu, 17 Oct 2019 19:59:58 +0000 (12:59 -0700)]
Delete unused files (dotnet/corefx#41869)
Commit migrated from https://github.com/dotnet/corefx/commit/
9b261704c5195fd2dbbceedc07486bb952d2a2f8
Santiago Fernandez Madero [Thu, 17 Oct 2019 19:58:29 +0000 (12:58 -0700)]
Move analyzers restore to a .depproj to follow arcade Tools.proj convention (dotnet/corefx#41832)
* Move analyzers restore to a .depproj to follow arcade Tools.proj convention
* Fix build break
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
0a3bfee6f2af0e1558b98cae1a5b81ffd084aa99
Stephen Toub [Thu, 17 Oct 2019 17:36:29 +0000 (13:36 -0400)]
Annotate System.Runtime.Numerics for nullable reference types (dotnet/corefx#41861)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f46e170dee7ad6b03c5da8c014d8e95a05b835b
Stephen Toub [Thu, 17 Oct 2019 17:23:20 +0000 (13:23 -0400)]
Annotate System.Runtime.InteropServices.RuntimeInformation for nullable reference types (dotnet/corefx#41856)
Commit migrated from https://github.com/dotnet/corefx/commit/
fd6714a359ff68127e25f1aecbfbdf4be09524a7
Stephen Toub [Thu, 17 Oct 2019 17:13:17 +0000 (13:13 -0400)]
Annotate System.Runtime.CompilerServices.VisualC for nullable reference types (dotnet/corefx#41858)
This assembly really doesn't matter for nullability, as it's only meant to be used with C++/CLI and only by infrastructure. There's also no annotations necessary on any of the contained attributes, as they are either parameterless or take a parameter that shouldn't be null. Even so, we may as well mark the assembly as being annotated, so that its status is appropriately reflected by tools.
Commit migrated from https://github.com/dotnet/corefx/commit/
57e30310253d9c720722f4363fb75e7df93efa67
Stephen Toub [Thu, 17 Oct 2019 17:00:08 +0000 (13:00 -0400)]
Add back TraceListener handling for Callstack/LogicalOperationStack (dotnet/corefx#41844)
Commit migrated from https://github.com/dotnet/corefx/commit/
2177ff131e267472bab53f124fac160d7af952bb
Viktor Hofer [Thu, 17 Oct 2019 13:04:39 +0000 (15:04 +0200)]
Remove UAP target (dotnet/corefx#41759)
* Remove Uap target
* Remove RemoteInvokeForUap wrapper calls entirely
* Harvest S.D.SqlClient on UWP
* Disable UWP PInvoke analyzer
* Enable WindowsRuntime* tests on netcoreapp
Commit migrated from https://github.com/dotnet/corefx/commit/
3b6ec2ba944fb72f921f95b99b6ebf2e7bb3dc5a
Viktor Hofer [Thu, 17 Oct 2019 11:31:16 +0000 (13:31 +0200)]
Revert "Store Description value of ConfigurationProperty" (dotnet/corefx#41848)
This reverts commit dotnet/corefx@
b9186cfa3566ee24e5f16e45c542a3078e128dc6.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9233ab726031451edce2b95c02f51fc09960132