Tim-Philipp Müller [Sat, 22 Oct 2022 10:10:24 +0000 (11:10 +0100)]
fdkaacenc: fix output caps in case of implicit signaling and HE-AAC
Need to put the actual profile in the output caps otherwise any
capsfilter after the encoder that was used to force the output
profile will fail, such as
fdkaacenc ! audio/mpeg,stream-format=adts,profile=he-aac-v1 ! ..
because we put profile=lc in there to match the profile signaled
in the ADTS header. This is expressed through the base-profile=lc
in the GStreamer caps though, the profile needs to carry the
'real' profile.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1785>
Tim-Philipp Müller [Fri, 21 Oct 2022 16:10:57 +0000 (17:10 +0100)]
fdkaacenc: don't set base-profile=lc for non-backwards compatible output
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1785>
Tim-Philipp Müller [Fri, 21 Oct 2022 12:15:29 +0000 (13:15 +0100)]
fdkaacenc: rename profile=sbr|ps to profile=he-aac-v1|he-aac-v2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1785>
Piotrek Brzeziński [Tue, 1 Mar 2022 13:12:27 +0000 (14:12 +0100)]
fdkaacenc: add support for AAC-LD
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1785>
Piotrek Brzeziński [Wed, 23 Feb 2022 16:17:25 +0000 (17:17 +0100)]
fdkaacenc: add support for HE-AACv1 and HE-AACv2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1785>
Patrick Griffis [Mon, 24 Oct 2022 17:21:47 +0000 (12:21 -0500)]
webrtc: Fix double free in webrtc-recvonly-h264 demo
The "message" signal does not transfer ownership of the GBytes passed
to it so calling g_bytes_unref() on it is incorrect.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3257>
Seungha Yang [Fri, 21 Oct 2022 16:43:22 +0000 (01:43 +0900)]
gst-inspect: Hide GST_PARAM_DOC_SHOW_DEFAULT flag
It's known flag but only for documentation purpose. Don't show
its (and user cannot understand) value 0x2000
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3241>
Fabian Orccon [Tue, 18 Oct 2022 00:45:30 +0000 (19:45 -0500)]
ges: transition: Notify vtype change on ges_extractable_set_asset call
Fixes #1454
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3215>
Seungha Yang [Fri, 21 Oct 2022 19:28:03 +0000 (04:28 +0900)]
gst-plugins-bad: Update Windows plugins cache
Add/update d3d11, qsv, nvcodec, wic, directshow, and amfcodec plugins cache
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 18:02:56 +0000 (03:02 +0900)]
nvcodec: Update for documentation
* Use GST_PARAM_DOC_SHOW_DEFAULT flags for GPU ID related
properties
* Fix some typos
* Add since markers
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 17:59:13 +0000 (02:59 +0900)]
mediafoundation: Update for documentation
* Use GST_PARAM_DOC_SHOW_DEFAULT flags for GPU ID related
properties
* Add doc caps
* Add since markers
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 19:09:39 +0000 (04:09 +0900)]
mfvideoencoder: Document only hardware encoders
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Sat, 22 Oct 2022 13:37:33 +0000 (22:37 +0900)]
mfvideoencoder: Fix device enumeration
Although a GPU does not support the codec, the other GPU might
be able to support the codec
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 17:56:23 +0000 (02:56 +0900)]
amfcodec: Update for documentation
* Use GST_PARAM_DOC_SHOW_DEFAULT flags for GPU ID related
properties
* Add doc caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 17:53:16 +0000 (02:53 +0900)]
qsv: Use GST_PARAM_DOC_SHOW_DEFAULT flag
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 17:49:00 +0000 (02:49 +0900)]
d3d11: Update for documentation
* Use GST_PARAM_DOC_SHOW_DEFAULT flags for GPU ID related
properties
* Add doc caps
* Increase deinterlace max resolution
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 17:48:23 +0000 (02:48 +0900)]
d3d11: Run indent
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Sat, 22 Oct 2022 13:33:01 +0000 (22:33 +0900)]
wic: Add since marker
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Seungha Yang [Fri, 21 Oct 2022 18:12:19 +0000 (03:12 +0900)]
directshow: Add since marker
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3250>
Sebastian Dröge [Mon, 24 Oct 2022 10:18:42 +0000 (13:18 +0300)]
examples: webrtc: Update to gstreamer-rs 0.19 release
Also update the macOS workaround for gstreamer-gl requiring a
`NSRunLoop` / `NSApp` on the main thread, and update from strucopt to
clap 4.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3255>
Seungha Yang [Fri, 21 Oct 2022 14:20:47 +0000 (23:20 +0900)]
qsv: Enable MinGW toolchain support
Use PCRE regex method to work around (likely) GCC std::regex bug,
and enable building for non-MSVC
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3239>
Sebastian Dröge [Fri, 21 Oct 2022 13:23:08 +0000 (16:23 +0300)]
rtspsrc: Only EOS on timeout if all streams are timed out/EOS
Otherwise a stream that is just temporarily inactive might time out and
then can never become active again because the EOS event was sent
already.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3238>
Nirbheek Chauhan [Fri, 21 Oct 2022 16:20:01 +0000 (21:50 +0530)]
gl/vulkan: Fix static linking on macOS
duplicate symbol '__invoke_on_main' in:
/Library/Frameworks/GStreamer.framework/Versions/1.0/lib/libgstvulkan-1.0.a(cocoa_gstvkwindow_cocoa.m.o)
/Library/Frameworks/GStreamer.framework/Versions/1.0/lib/libgstgl-1.0.a(cocoa_gstglwindow_cocoa.m.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Also make the same change in iOS for consistency.
Continuation of https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1132
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3242>
Matthew Waters [Tue, 18 Oct 2022 06:05:41 +0000 (17:05 +1100)]
webrtcbin: configure rtpulpfecdec passthrough property
This allows downstream (payloaders mostly) to be able to correctly
detect actual packet loss from rtp sequence numbers.
See
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/581
for background.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1407
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3212>
Matthew Waters [Tue, 18 Oct 2022 05:51:39 +0000 (16:51 +1100)]
rtpulpfecdec: add property for passthrough
Support for enabling and disabling decoding of FEC data decoding on
packet loss events and unconditional seqnum rewriting of packets.
See
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/581
for background.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3212>
Patrick Griffis [Sun, 23 Oct 2022 19:56:32 +0000 (14:56 -0500)]
webrtc: Fix critical in webrtc-recvonly-h264 example
This signal only takes 2 properties yet a third was passed.
This would cause a critical in GLib.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3252>
Sebastian Dröge [Sat, 22 Oct 2022 15:34:14 +0000 (18:34 +0300)]
net: Add missing nullable annotation on the name parameter in the net/NTP clock constructors
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3249>
Seungha Yang [Sat, 22 Oct 2022 13:04:57 +0000 (22:04 +0900)]
padtemplate: Fix annotations
gst_caps_replace() does not take ownership of the new caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3248>
Devin Anderson [Tue, 18 Oct 2022 11:37:30 +0000 (11:37 +0000)]
gst-libav: Fix synchronization issues and errors created by the forwarding of
segment events by demuxer.
In order to play nicely with `ffmpeg`, demuxers in `gst-libav` have to make
buffers available to `ffmpeg` while taking the blocking I/O model in `ffmpeg`
into account, which results in buffers not being sent downstream until `ffmpeg`
has processed them in its separate thread.
In constrast, many `gstreamer` events are simply forwarded downstream.
Currently `GST_EVENT_SEGMENT` events are forwarded downstream without any
processing, which can potentially result in:
* `GST_EVENT_SEGMENT` events being out of sync with buffers
* `GST_EVENT_SEGMENT` events going out that are incorrect because they apply
to data seen by the demuxer, but not necessarily seen by downstream elements
I came across this bug when I was attempting to enable G723.1 demuxing/decoding
using the G723.1 demuxer and decoder provided by `ffmpeg`. I wrote tests to
verify support for the functionality, and found that, in push mode,
`GST_EVENT_SEGMENT` events pushed to the demuxer by the upstream `filesrc`
element would be forwarded to the decoder without modification, resulting in
an internal data streaming error. With this patch, tests work in both push and
pull mode.
This patch solves the problem by disabling the forwarding of
`GST_EVENT_SEGMENT` events downstream (an initial `GST_EVENT_SEGMENT` event is
still pushed downstream by the demuxer). It's possible there's a better way to
do this, but, having looked at how a few different `gstreamer` demuxers deal
with `GST_EVENT_SEGMENT` events, it seems like the processing is somewhat
specific to the demuxer implementation, whereas `gst-libav` has one general way
of handling the situation for any `ffmpeg` demuxer. Perhaps there's a better
way to solve this using the `ffmpeg` API to take advantage of specific demuxer
details. IDK.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3218>
Seungha Yang [Fri, 21 Oct 2022 20:29:59 +0000 (05:29 +0900)]
gst-inspect: Don't print link to doc if it's known to be unavailable
"gst_element_factory_get_skip_documentation() == true" means
documentation was intentionally skipped for the element feature
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3243>
François Laignel [Fri, 21 Oct 2022 09:47:11 +0000 (11:47 +0200)]
gst: uri query: fix inconsistent `uri` nullability assertion
Functions `gst_query_set_uri` and `gst_query_set_uri_redirection`
can both set a `NULL` `uri`, as annotated in the documentation.
However the functions bodies reject `NULL` `uri`s.
See [1] for a discussion on that matter.
[1]: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1134#note_1600988
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3237>
Seungha Yang [Thu, 6 Oct 2022 19:20:29 +0000 (04:20 +0900)]
d3d11screencapture: Add WinRT API based capture mode
Add Windows Graphics Capture (WGC) API based screen capture mode.
The conditions where this mode is used:
* Explicitly requested by user (capture-api property)
* To capture specific window
* When DXGI desktop duplication API does not work on hybrid graphics systems
(e.g., multi-gpu laptop)
Full features of this implementation require Windows 11. And Windows 11
SDK is required to build this feature.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3144>
Seungha Yang [Thu, 6 Oct 2022 14:54:14 +0000 (23:54 +0900)]
d3d11screencapture: Subclassing capture implementation
Preparation to use WinRT capture API
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3144>
Seungha Yang [Fri, 21 Oct 2022 10:08:49 +0000 (19:08 +0900)]
qsv: Add plugin doc
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2738>
Seungha Yang [Fri, 8 Jul 2022 20:38:05 +0000 (05:38 +0900)]
qsv: Update SDK version to v2022.2.4
See release note
https://github.com/oneapi-src/oneVPL/releases/tag/v2022.2.0
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2738>
He Junyan [Fri, 14 Oct 2022 08:05:28 +0000 (16:05 +0800)]
av1parse: Correct the pts for frames and OBUs inside a TU.
When the output alignment is smaller than the input alignment, for
example, When the output alignment is "FRAME" and the parse is likely
connecting to a decoder, the current PTS setting for AV1 frames inside
a TU is not very correct.
For example, a TU may begin with non-displayed frames and end with a
displayed frame. The current way will assign the PTS to the first
non-displayed frame, which is a decode-only frame and the PTS will be
discarded in the video decoder. While the last displayed frame has
invalid PTS, and so the video decoder needs to guess its PTS based on
the frame rate and previous frame's PTS. This is not a decent and
robust way. And more important, when the previous frames provide DTS,
the video decoder will also guess the PTS based on the previous frames'
DTS and trigger the warning like:
gstvideodecoder.c:3147:gst_video_decoder_prepare_finish_frame: \
<vavp9dec0> decreasing timestame
It sets the reordered_output and makes the decoder in free run mode.
We should correct the PTS for a TU, let the non-displayed frames have
no PTS while set the correct PTS to the displayed one. Also, when the
AV1 stream has multi spatial layers, there are more than one displayed
frames inside one TU with the same PTS.
Note: If the input alignment is not TU aligned, we can not know the
exact PTS of this TU, and so we just clear the PTS of the decode only
frame and leave others unchanged.
We also correct all the PTS if the output is OBU aligned. All their
PTS and DTS are set to the input buffer's PTS.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>
He Junyan [Fri, 14 Oct 2022 09:25:45 +0000 (17:25 +0800)]
av1parse: Only check the TU bound when the alignment is TU.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>
He Junyan [Fri, 14 Oct 2022 07:46:16 +0000 (15:46 +0800)]
av1parse: push all data once when input alignment not smaller than output.
When the incoming data has big alignment than the output, we do not need to
call finish_frame() and exit the current handle_frame() for each splitted
frame. We can push them all at one shot with in one handle_frame(), whcih
may improve the performance and can help us to find the edge of TU.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>
He Junyan [Fri, 14 Oct 2022 07:27:52 +0000 (15:27 +0800)]
av1parse: Set the output buffer flags correctly.
The current code forgets to clear some flags and has some typo.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>
Thibault Saunier [Fri, 21 Oct 2022 09:11:13 +0000 (11:11 +0200)]
docs: plugins-scanner: Handle interface used for plugin API properties
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3236>
Matthew Waters [Thu, 20 Oct 2022 23:50:36 +0000 (10:50 +1100)]
webrtcbin: also add rtcp-fb ccm fir for video mlines by default
In addition to the 'nack pli' already added. Both are supported by
rtpbin/rtpsession by default already.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3235>
Matthew Waters [Tue, 4 Oct 2022 04:39:51 +0000 (05:39 +0100)]
build/gl: fix automatic dispmanx detection for rpi4
rpi4 doesn't contain dispmanx but still contains bcm_host.pc which
confuses the configure detection. Add an explicit check for
EGL_DISPMANX_WINDOW_T to ensure that we only build with dispmanx when
the types are available.
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/893
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/952
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3230>
Sangchul Lee [Wed, 19 Oct 2022 07:03:55 +0000 (16:03 +0900)]
webrtcbin: Improve documentation of 'turn-server' property
Description about how to set time-limited credentials is added.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3229>
Seungha Yang [Mon, 17 Oct 2022 18:08:44 +0000 (03:08 +0900)]
docs: plugin-scanner: Stop updating "long-name" metadata
The "long-name" value can be environment dependent, and it's not
actually used by our documentation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3208>
Seungha Yang [Wed, 19 Oct 2022 13:30:38 +0000 (22:30 +0900)]
parse: Adjust debug log level
That's not an error case at all
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3228>
Matthew Waters [Wed, 19 Oct 2022 11:08:17 +0000 (22:08 +1100)]
docs/glcontextconfig: rename title to not be GstGLContext
Can be confusing havint two pages that both have GstGLContext as the
title.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3227>
Sebastian Dröge [Wed, 19 Oct 2022 10:34:28 +0000 (13:34 +0300)]
{element,deviceprovider}factory: g_object_new() can't ever return NULL
So treat it as the assertion it is.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>
Sebastian Dröge [Wed, 19 Oct 2022 10:33:39 +0000 (13:33 +0300)]
elementfactory: Handle element factory loading failure in gst_element_factory_create_valist() not as assertion
In gst_element_factory_create_with_properties() it is a normal error
path so let's keep this consistent.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>
Sebastian Dröge [Wed, 19 Oct 2022 10:28:06 +0000 (13:28 +0300)]
gst: Use G_TYPE_INVALID instead of 0 for GTypes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>
Mathieu Duponchelle [Wed, 14 Sep 2022 22:06:49 +0000 (00:06 +0200)]
tests: parse-launch: remove assignment order tests
These tests relied on setting the name of an element twice to verify
that the last one set took precedence, however name is a CONSTRUCT property
and the parser now errors out when such properties are set twice, in
g_object_new_with_properties .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3026>
Mathieu Duponchelle [Tue, 13 Sep 2022 21:16:08 +0000 (23:16 +0200)]
parse: refactor to make use of gst_element_factory_make_with_properties
Instead of creating the element first, then setting properties and
presets, we gather those and construct the element with the properties.
This means users of gst_parse_launch can now set construct-only
properties.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1380
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3026>
Bunio_FH [Tue, 18 Oct 2022 14:41:36 +0000 (16:41 +0200)]
gstminiobject: shares capacity increase
during the MSE (WebKit) tests from Apple suite:
https://hls-streaming.cdn-apple.com/hls_conformance/dist/v1.1/index.html?pretty=true&whitelist=MSE%20Suite
webkit attempts to add a single audio buffer containing ~35.5k frames.
when corresponding GstSamples are pulled buffer is being referenced
more than object capacity allows: 2^15-1. since the case could be considered
malformed a surgical patch is applied to increase the capacity.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3221>
Mathieu Duponchelle [Fri, 23 Sep 2022 16:25:41 +0000 (18:25 +0200)]
fake{video|audio}sink: don't proxy properties at instance init.
Instead proxy properties from the GstBaseSink class at class_init time,
and duplicate the rest of the fakesink properties manually.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1442
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3073>
Jordan Petridis [Wed, 6 Jul 2022 18:45:24 +0000 (21:45 +0300)]
cdparanoia: Ignore compiler warning coming from the cdparanoia header
When trying to build the plugin, GCC starts complaining about issues
with one of the cdparanoia headers and it block us from being able
to build the plugin with Werror.
The current warning in the header look like this:
```
[1/2] Compiling C object subprojects/gst-plugins-base/ext/cdparanoia/libgstcdparanoia.so.p/gstcdparanoiasrc.c.o
In file included from ../subprojects/gst-plugins-base/ext/cdparanoia/gstcdparanoiasrc.h:37,
from ../subprojects/gst-plugins-base/ext/cdparanoia/gstcdparanoiasrc.c:31:
/usr/include/cdda/cdda_interface.h:164:3: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
164 | "Success",
| ^~~~~~~~~
...
/usr/include/cdda/cdda_interface.h:163:14: warning: ‘strerror_tr’ defined but not used [-Wunused-variable]
163 | static char *strerror_tr[]={
| ^~~~~~~~~~~
[2/2] Linking target subprojects/gst-plugins-base/ext/cdparanoia/libgstcdparanoia.so
```
Last release of cdparanoia was in 2008, so our best bet for the
time is to ignore the warnings.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2722>
Alba Mendez [Tue, 18 Oct 2022 09:16:20 +0000 (11:16 +0200)]
webrtcbin: support adding TURN servers after pipeline start
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1680
When a TURN server is added for the first time, propagate
the change to all nice streams that already exist. This
lets us add servers after the pipeline has been started
(and streams have been added).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3217>
Nirbheek Chauhan [Wed, 19 Oct 2022 03:52:21 +0000 (09:22 +0530)]
meson: Use run_command check: true for windows binary subprojects
Fixes a warning about using the check kwarg
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3224>
Sam Van Den Berge [Tue, 18 Oct 2022 13:28:32 +0000 (15:28 +0200)]
examples: webrtc: mp-sendrecv: add bus handler
Without this bus handler, messages posted to the bus will keep a ref to
their source elements, preventing them from being disposed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>
Sam Van Den Berge [Tue, 18 Oct 2022 13:27:20 +0000 (15:27 +0200)]
examples: webrtc: mp-sendrecv: set element states to NULL after removing them from pipeline
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>
Sam Van Den Berge [Tue, 18 Oct 2022 13:17:40 +0000 (15:17 +0200)]
examples: webrtc: mp-sendrecv: remove wrong gst_object_unrefs
In !2958 some gst_object_unrefs were added. However these two don't
belong there because ownership is transfered due to the gst_bin_add_many
call a bit above.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>
Fabian Orccon [Mon, 17 Oct 2022 11:48:12 +0000 (06:48 -0500)]
srtp: Fix test skipping when plugin option is disabled
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3200>
Seungha Yang [Thu, 13 Oct 2022 15:17:52 +0000 (00:17 +0900)]
d3d11videosink: Add "emit-present" property
Controls the decision for "present" signal use, and
allows delayed "present" signal handler install via the property
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3176>
Sebastian Dröge [Mon, 17 Oct 2022 16:36:13 +0000 (19:36 +0300)]
play: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 11:43:42 +0000 (14:43 +0300)]
sdp: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 11:51:03 +0000 (14:51 +0300)]
tag: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 08:31:05 +0000 (11:31 +0300)]
allocators: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 08:29:02 +0000 (11:29 +0300)]
vulkan: Add/fix various annotations
And fix a memory leak in gst_vulkan_display_wayland_new() in error
cases.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 07:54:06 +0000 (10:54 +0300)]
d3d11: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 07:51:42 +0000 (10:51 +0300)]
cuda: Add/fix various annotations
And fix a memory leak when creating a CUDA context fails.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 07:47:02 +0000 (10:47 +0300)]
codecs: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Mon, 17 Oct 2022 07:44:24 +0000 (10:44 +0300)]
badaudio: Add/fix annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 16:36:47 +0000 (19:36 +0300)]
ges: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:40:04 +0000 (12:40 +0300)]
rtsp-server: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:31:17 +0000 (12:31 +0300)]
core: Add/fix various annotations
And fix memory leaks/null pointer dereferences in GstUri in error cases.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:24:46 +0000 (12:24 +0300)]
check: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:20:08 +0000 (12:20 +0300)]
net: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:18:28 +0000 (12:18 +0300)]
base: Add/fix annotations in GstQueueArray
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 09:16:01 +0000 (12:16 +0300)]
gl: Add/fix various annotations
And fix a memory leaks in gst_gl_display_egl_new() error cases.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Sat, 15 Oct 2022 08:38:02 +0000 (11:38 +0300)]
validate: Add/fix various annotations
And fix monitor constructors to correctly check for valid arguments.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 21:19:53 +0000 (00:19 +0300)]
pbutils: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 21:00:03 +0000 (00:00 +0300)]
rtp: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 20:52:40 +0000 (23:52 +0300)]
rtsp: Add/fix various annotations
Also initialize out parameters so that they don't have an undefined
value in case of errors.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 20:48:09 +0000 (23:48 +0300)]
controller: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 19:08:07 +0000 (22:08 +0300)]
app: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 19:04:00 +0000 (22:04 +0300)]
audio: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 18:59:43 +0000 (21:59 +0300)]
video: Add/fix various annotations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Sebastian Dröge [Fri, 14 Oct 2022 18:51:17 +0000 (21:51 +0300)]
webrtc: Add/fix various annotations
And mark string parameters as const.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>
Edward Hervey [Mon, 17 Oct 2022 11:01:53 +0000 (13:01 +0200)]
urisourcebin: Fix usage of raw and non-raw source provider
The computation in analyze_source was wrong, and would state that the element
has "all raw source pads" if it had at least one.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1029
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3199>
Sebastian Dröge [Mon, 17 Oct 2022 15:38:43 +0000 (18:38 +0300)]
rtpbuffer: Initialize extended timestamp to the first wraparound period
This allows correct handling of wrapping around backwards during the
first wraparound period and avoids the infamous "Cannot unwrap, any
wrapping took place yet" error message.
It allows makes sure that for actual timestamp jumps a valid value is
returned instead of 0, which then allows the caller to handle it
properly. Not having this can have the caller see the same timestamp (0)
for a very long time, which for example can cause rtpjitterbuffer to
output the same timestamp for a very long time.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1500
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3202>
Matthew Waters [Tue, 18 Oct 2022 01:26:21 +0000 (12:26 +1100)]
examples/webrtc: don't use factory_make_full() for enums
They are not currently translated into their respective enum values and
will produce an error.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3210>
Seungha Yang [Sun, 16 Oct 2022 15:40:46 +0000 (00:40 +0900)]
wasapi2: Add support for process loopback capture
Adding loopback capture mode for specified PID.
Note that this feature requires Windows 10 build 20348
(Windows 11/Windows Server 2022 or later),
and any process loopback related properties will not be exposed
if OS does not support it.
Example launch lines:
* wasapi2src loopback-mode=include-process-tree loopback-target-pid=<PID>
Captures audio generated by an application (specified by PID)
and its child process
* wasapi2src loopback-mode=exclude-process-tree loopback-target-pid=<PID>
Captures desktop audio excluding PID and its child process
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1278
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3195>
Nirbheek Chauhan [Mon, 17 Oct 2022 20:54:48 +0000 (02:24 +0530)]
ci: Run windows jobs when win-* binary subprojects are updated
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3209>
Nirbheek Chauhan [Mon, 17 Oct 2022 20:51:07 +0000 (02:21 +0530)]
meson: Update flex, bison, and nasm
Latest flex is 2.6.4, bison is 3.8.2, nasm is 2.15.04
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3209>
Sam Van Den Berge [Mon, 17 Oct 2022 08:39:18 +0000 (10:39 +0200)]
examples/webrtc/signalling: Fix compatibility with Python 3.10
Fix asyncio throwing a deprecation warning when using
asyncio.get_event_loop().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3196>
Arun Raghavan [Fri, 14 Oct 2022 20:21:07 +0000 (16:21 -0400)]
rtmp2sink: Correctly return GST_FLOW_ERROR on error
If there is an error while connecting, the streaming task will be stopped, and
is_running() will be false, causing a GST_FLOW_FLUSHING to be returned. Instead,
we perform the error check (!self->connection) first, to return an error if
that's what occured.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3189>
Edward Hervey [Fri, 14 Oct 2022 14:12:45 +0000 (16:12 +0200)]
gst-play: Don't leak the stream collection
We are given a reference to the collection when parsing it from the
message. Just store it (instead of referencing it again).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3186>
Mathieu Duponchelle [Fri, 14 Oct 2022 16:51:43 +0000 (18:51 +0200)]
webrtc/nice: fix small leak of split strings
g_strfreev previously stopped at our manual NULL-termination. Fix by
restoring the pointer after joining.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3188>
Nirbheek Chauhan [Thu, 13 Oct 2022 20:40:35 +0000 (02:10 +0530)]
gst-docs: Fix typo in hotdoc kwarg
The hotdoc module passes unknown keyword arguments as arguments to
hotdoc, and the fatal warnings argument is --fatal-warnings.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2972#note_1586361
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3178>
Devin Anderson [Fri, 14 Oct 2022 01:23:04 +0000 (01:23 +0000)]
wavparse: Avoid occasional crash due to referencing freed buffer.
We've seen occasional crashes in the `wavparse` module associated with
referencing a buffer in `gst_wavparse_chain` that's already been freed. The
reference is stolen when the buffer is transferred to the adapter with
`gst_adapter_push` and, IIUC, assuming the source doesn't hold a reference to
the buffer, the buffer could be freed during interaction with the adapter in
`gst_wavparse_stream_headers`.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3179>
Edward Hervey [Fri, 14 Oct 2022 06:53:18 +0000 (08:53 +0200)]
rtsp-client: Remove duplicate documentation
Confuses the documentation builder, since it's documented twice it complains
about a missing "Since:" marker whereas it's present in the documentation
comment further down
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3180>
Julian Bouzas [Thu, 13 Oct 2022 15:21:42 +0000 (11:21 -0400)]
riff: Mark jpeg as parsed
This is needed so that autoplugging works with avidemux and JPEG decoders that
need parsed sink caps (eg rockchip 'mppjpegdec' decoder). It also works fine
with 'jpegdec' decoder regardless.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3175>