Fraser Cormack [Mon, 6 Dec 2021 15:49:23 +0000 (15:49 +0000)]
[IR] Allow the 'align' param attr on vectors of pointers
This patch extends the available uses of the 'align' parameter attribute
to include vectors of pointers. The attribute specifies pointer
alignment element-wise.
This change was previously requested and discussed in D87304.
The vector predication (VP) intrinsics intend to use this for scatter
and gather operations, as they lack the explicit alignment parameter
that the masked versions use.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D115161
Lucas Prates [Thu, 2 Sep 2021 15:12:55 +0000 (16:12 +0100)]
[ARM][AArch64] Introduce Armv9.3-A
This patch introduces support for targetting the Armv9.3-A architecture,
which should map to the existing Armv8.8-A extensions.
Differential Revision: https://reviews.llvm.org/D116158
Simon Tatham [Thu, 11 Feb 2021 11:19:44 +0000 (11:19 +0000)]
[AArch64] Adding "armv8.8-a" BC instruction.
This instruction is described in the Arm A64 Instruction Set
Architecture documentation available here:
https://developer.arm.com/documentation/ddi0596/2021-12/Base-Instructions/BC-cond--Branch-Consistent-conditionally-?lang=en
FEAT_HBC "Hinted Conditional Branches" is listed in the 2021 A-Profile Architecture Extensions:
https://developer.arm.com/architectures/cpu-architecture/a-profile/exploration-tools/feature-names-for-a-profile
'BC.cc', where 'cc' is any ordinary condition code, is an instruction
that looks exactly like B.cc (the normal conditional branch), except
that bit 4 of the encoding is 1 rather than 0, which hints something
to the branch predictor (specifically, that this branch is expected to
be highly consistent, even though _which way_ it will consistently go
is not known at compile time).
This commit introduces a special subtarget feature for HBC, which is a
dependency of the top-level 8.8-A feature, and uses that to enable the
new BC instruction.
Differential Revision: https://reviews.llvm.org/D116156
mydeveloperday [Mon, 3 Jan 2022 11:19:02 +0000 (11:19 +0000)]
[clang-format] spacesRequiredBetween is not honouring clang-format off/on
https://github.com/llvm/llvm-project/issues/52881
It seems that clang-format off/on is not being honoured in regard to adding spaces.
My understanding of clang-format off/on is that it marks the token as finalized based on whether formatting is currently enabled or disabled.
This was causing a space to be added between the `<` and `<<` in the Cuda kernel `foo<<<1, 1>>>();`
This if doesn't solve this actual issue but ensure that clang-format is at least honoured.
Reviewed By: curdeius, owenpan
Differential Revision: https://reviews.llvm.org/D116494
Groverkss [Mon, 3 Jan 2022 10:53:07 +0000 (16:23 +0530)]
[MLIR] Remove dependency on IR for Simplex
This patch removes unnecessary dependency on IR for Simplex. This patch allows
users to use Presburger library without depending on MLIRIR.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D116530
Gabriel Smith [Mon, 3 Jan 2022 10:50:31 +0000 (11:50 +0100)]
[clang-format][NFC] Correct comment about checking merging of blocks
Reviewed By: HazardyKnusperkeks, MyDeveloperDay, owenpan
Differential Revision: https://reviews.llvm.org/D116189
Zhao Wei Liew [Mon, 3 Jan 2022 10:37:20 +0000 (11:37 +0100)]
[clang-format] Add option to explicitly specify a config file
This diff extends the -style=file option to allow a config file to be specified explicitly. This is useful (for instance) when adding IDE commands to reformat code to a personal style.
Usage: `clang-format -style=file:<path/to/config/file> ...`
Reviewed By: HazardyKnusperkeks, curdeius, MyDeveloperDay, zwliew
Differential Revision: https://reviews.llvm.org/D72326
Zhao Wei Liew [Mon, 3 Jan 2022 10:30:24 +0000 (11:30 +0100)]
[clang-format] Support inheriting from more than 1 parents in the fallback case
Currently, we are unable to inherit from a chain of parent configs where the outermost parent config has `BasedOnStyle: InheritParentConfig` set. This patch adds a test case for this scenario, and adds support for it.
To illustrate, suppose we have the following directory structure:
```
- e/
|- .clang-format (BasedOnStyle: InheritParentConfig) <-- outermost config
|- sub/
|- .clang-format (BasedOnStyle: InheritParentConfig)
|- sub/
|- .clang-format (BasedOnStyle: InheritParentConfig)
|- code.cpp
```
Now consider what happens when we run `clang-format --style=file /e/sub/sub/code.cpp`.
Without this patch, on a release build, only the innermost config will be applied. On a debug build, clang-format crashes due to an assertion failure.
With this patch, clang-format behaves as we'd expect, applying all 3 configs.
Reviewed By: HazardyKnusperkeks, curdeius
Differential Revision: https://reviews.llvm.org/D116371
Florian Hahn [Mon, 3 Jan 2022 09:59:39 +0000 (09:59 +0000)]
[LV] Set loop metadata after VPlan execution (NFC).
Setting the loop metadata for the vector loop after VPlan execution
allows generating the full loop body during VPlan execution. This is in
preparation for D113224.
Nikita Popov [Mon, 3 Jan 2022 09:55:47 +0000 (10:55 +0100)]
[LoadStoreVectorizer] Check for guaranteed-to-transfer (PR52950)
Rather than checking for nounwind in particular, make sure the
instruction is guaranteed to transfer execution, which will also
handle non-willreturn calls correctly.
Fixes https://github.com/llvm/llvm-project/issues/52950.
Nikita Popov [Mon, 3 Jan 2022 09:14:00 +0000 (10:14 +0100)]
[ConstantFold] Drop unused function (NFC)
isMaybeZeroSizeType() is no longer used after
5afbfe33e7d6ce40af0ad6d99421b443c45b351b.
Jim Lin [Mon, 3 Jan 2022 07:03:55 +0000 (15:03 +0800)]
[RISCV] Fix the code alignment for GroupFloatVectors. NFC
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D116520
Marek Kurdej [Mon, 3 Jan 2022 08:40:24 +0000 (09:40 +0100)]
[clang-format] Use get*StyleWithColumns helper. NFC.
Nikita Popov [Tue, 28 Dec 2021 11:27:04 +0000 (12:27 +0100)]
[ConstantFold] Make icmp of gep fold offset based
We can fold an equality or unsigned icmp between base+offset1 and
base+offset2 with inbounds offsets by comparing the offsets directly.
This replaces a pair of specialized folds that tried to reason
based on the GEP structure instead. One of those folds was plain
wrong (because it does not account for negative offsets), while
the other is unnecessarily complicated and limited (e.g. it will
fail with bitcasts involved).
The disadvantage of this change is that it requires data layout,
so the fold is no longer performed by datalayout-independent
constant folding. I don't think this is a loss in practice, but
it does regress the ConstantExprFold.ll test, which checks folding
without running any passes.
Differential Revision: https://reviews.llvm.org/D116332
Nikita Popov [Mon, 3 Jan 2022 08:38:04 +0000 (09:38 +0100)]
[DSE] Fix DSE test to use non-extern global (NFC)
The intended transform is not legal with an extern global, because
the actual global defined in a different TU might have larger
size. Make it non-extern to show that the desired transform already
works.
Nikita Popov [Fri, 24 Dec 2021 11:09:38 +0000 (12:09 +0100)]
[DSE] Check for whole object overwrite even if dead store size not known
If the killing store overwrites the whole object, we know that the
preceding store is dead, regardless of the accessed offset or size.
This case was previously only handled if the size of the dead store
was also known.
This allows us to perform conventional DSE for calls that write to
an argument (but without known size).
Differential Revision: https://reviews.llvm.org/D116267
Vitaly Buka [Mon, 3 Jan 2022 08:34:20 +0000 (00:34 -0800)]
[NFC][sanitizer] Allow madvise in symbolizer
Marek Kurdej [Mon, 3 Jan 2022 08:10:37 +0000 (09:10 +0100)]
[clang-format] [docs] Fix Mozilla coding style URL.
Fixes https://github.com/llvm/llvm-project/issues/52889.
Kazu Hirata [Mon, 3 Jan 2022 07:59:52 +0000 (23:59 -0800)]
[llvm] Fix namespace comments (NFC)
Identified with llvm-namespace-comment.
John Ericson [Mon, 3 Jan 2022 01:29:39 +0000 (01:29 +0000)]
[llvm][cmake] Normalize some indent
- Change a stray tab to spaces
- 4 not 2 spaces in second line of `set` like above.
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D116510
Craig Topper [Mon, 3 Jan 2022 07:20:32 +0000 (23:20 -0800)]
[Support] Add KnownBits::countMaxSignedBits(). Make KnownBits::countMinSignBits() always return at least 1.
Even if we don't have any known bits, we can assume that there is
at least 1 sign bit. This is consistent with ComputeNumSignBits
which always returns at least 1.
Add KnownBits::countMaxSignedBits() which computes the number of
bits needed to represent all signed values with those known bits.
This is the signed equivalent of countMaxActiveBits().
Split from D116469.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D116500
Victor Perez [Mon, 3 Jan 2022 07:12:06 +0000 (23:12 -0800)]
[RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select
Expand [nX]vXi1 vp.select the same way as [nX]vXi1 vselect.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D115546
Kazu Hirata [Mon, 3 Jan 2022 07:08:40 +0000 (23:08 -0800)]
[Transform] Remove redundant declaration PollyAllowFullFunction (NFC)
The variable is declared in ScopDetection.h, which ScopInliner.cpp
includes.
Identified by readability-redundant-declaration.
Craig Topper [Mon, 3 Jan 2022 07:00:09 +0000 (23:00 -0800)]
[RISCV] Prune more unnecessary vector pseudo instructions. NFC
For floating point specific vector instructions, we don't need
pseudos for mf8.
Reviewed By: khchen
Differential Revision: https://reviews.llvm.org/D116460
Mehdi Amini [Mon, 3 Jan 2022 06:58:45 +0000 (06:58 +0000)]
Fix doc on how to run clang-tidy on MLIR codebase (NFC)
Kazu Hirata [Mon, 3 Jan 2022 06:53:09 +0000 (22:53 -0800)]
[Transforms] Use all_of instead of any_of (NFC)
Kazu Hirata [Mon, 3 Jan 2022 06:44:15 +0000 (22:44 -0800)]
[API] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Mehdi Amini [Mon, 3 Jan 2022 06:31:44 +0000 (06:31 +0000)]
Revert "Define a `cppAccessorType` to const-ref in APFloatParameter and update ODS emitter to use it for verifier signatures"
This reverts commit
89af17c0c74eb9d8d11870f6510e475eff74eef4.
This broke the gcc5 build.
William S. Moses [Mon, 3 Jan 2022 04:49:29 +0000 (23:49 -0500)]
[MLIR] Canonicalize/fold select %x, 1, 0 to extui
Two canonicalizations for select %x, 1, 0
If the return type is i1, return simply the condition %x, otherwise extui %x to the return type.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116517
William S. Moses [Mon, 3 Jan 2022 05:38:41 +0000 (00:38 -0500)]
[MLIR][Arith] Canonicalize and/or with ext
Replace and(ext(a),ext(b)) with ext(and(a,b)). This both reduces one instruction, and results in the computation (and/or) being done on a smaller type.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116519
Mehdi Amini [Mon, 3 Jan 2022 06:18:25 +0000 (06:18 +0000)]
Add back missing return to non-void function
It was incorrectly removed accidentally in
e4e463e7476.
Mehdi Amini [Mon, 3 Jan 2022 06:17:00 +0000 (06:17 +0000)]
Remove misused RAII gil_scoped_release/gil_scoped_acquire: without name they don't have any effect
I'm not sure what is the right fix here, but adding a name to all these
lead to many segfaults.
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D116506
Groverkss [Mon, 3 Jan 2022 06:06:35 +0000 (11:36 +0530)]
[MLIR][NFC] Fix clang-tidy errors in Analysis/Presburger/
This patch fixes clang-tidy errors related to different parameter names
in header file and source file in Analysis/Presburger/ directory.
Mehdi Amini [Mon, 3 Jan 2022 06:06:36 +0000 (06:06 +0000)]
Use cast<> instead of dyn_cast<> when we don't check the result (NFC)
Mehdi Amini [Mon, 3 Jan 2022 06:03:34 +0000 (06:03 +0000)]
Remove dead return after return (NFC)
Mehdi Amini [Mon, 3 Jan 2022 06:02:21 +0000 (06:02 +0000)]
Remove useless nesting blok and dead return statement in TosaToLinalg.cpp (NFC)
Flagged by Coverity.
Mehdi Amini [Mon, 3 Jan 2022 05:51:35 +0000 (05:51 +0000)]
Minor reflow of FloorDivSIOp/CeilDivSIOp folder to limit the number of APInt API calls (NFC)
Cache the result of the comparison in boolean, and check early for 0 to
leverage `(a < 0) == !(a > 0)`.
Groverkss [Mon, 3 Jan 2022 05:40:14 +0000 (11:10 +0530)]
[MLIR] Move LinearTransform to Presburger/
This patch moves LinearTransform to Presburger/ and makes it use
IntegerPolyhedron instead of FlatAffineConstraints. Also modifies its usage in
`FlatAffineConstraints::findIntegerSample` to support the changes.
This patch is part of a series of patches for moving presburger math functionality into Presburger directory.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D116311
William S. Moses [Mon, 3 Jan 2022 03:06:57 +0000 (22:06 -0500)]
[MLIR] Create folders for extsi/extui
Create folders/canonicalizers for extsi/extui. Specifically,
extui(extui(x)) -> extui(x)
extsi(extsi(x)) -> extsi(x)
extsi(extui(x)) -> extui(x)
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116515
Mehdi Amini [Mon, 3 Jan 2022 04:56:08 +0000 (04:56 +0000)]
Define a `cppAccessorType` to const-ref in APFloatParameter and update ODS emitter to use it for verifier signatures
This reduce an unnecessary amount of copy of non-trivial objects, like
APFloat.
Reviewed By: rriddle, jpienaar
Differential Revision: https://reviews.llvm.org/D116505
Mehdi Amini [Mon, 3 Jan 2022 04:53:10 +0000 (04:53 +0000)]
Add a script to run clang-tidy on the entire MLIR codebase
Lang Hames [Mon, 3 Jan 2022 03:33:23 +0000 (14:33 +1100)]
[JITLink] Move AllocActions and associated types out of JITLinkMemoryManager.
They're shared with LinkGraph, so having them as top-level types makes sense,
and saves users from qualifying the names everywhere.
Mehdi Amini [Mon, 3 Jan 2022 02:32:10 +0000 (02:32 +0000)]
Apply clang-tidy fixes for misc-unused-parameters in MLIR AffineStructures.cpp (NFC)
Ellis Hoag [Mon, 3 Jan 2022 02:02:08 +0000 (18:02 -0800)]
[clang][AST] Fix crash when printing error
Clang will crash if it tries to compile the following code. This commit
fixes it.
```
$ cat foo.c
void foo(_Nullable int *ptr) {
__auto_type _Nonnull a = ptr;
};
$ clang foo.c -c -Wnullable-to-nonnull-conversion
```
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D116342
William S. Moses [Sun, 2 Jan 2022 22:44:08 +0000 (17:44 -0500)]
[MLIR] Create fold for cmp of ext
This patch creates folds for cmpi( ext(%x : i1, iN) != 0) -> %x
In essence this matches patterns matching an extension of a boolean, that != 0, which is equivalent to the original condition.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116504
Wenlei He [Mon, 3 Jan 2022 00:25:27 +0000 (16:25 -0800)]
[llvm-profgen] Error out for unsupported AutoFDO profile generate with probe
Error out instead of siliently generate empty profile when trying to generate AutoFDO profile with probe binary.
Differential Revision: https://reviews.llvm.org/D116508
Mehdi Amini [Sun, 2 Jan 2022 23:43:52 +0000 (23:43 +0000)]
Use `= default` for the ValueShapeRange copy-constructor (NFC)
This makes it trivially copyable.
Mehdi Amini [Sun, 2 Jan 2022 22:39:57 +0000 (22:39 +0000)]
Replace raw-loop with llvm::any_of() in PresburgerSet.cpp (NFC)
Reported by clang-tidy.
Mehdi Amini [Sun, 2 Jan 2022 22:02:20 +0000 (22:02 +0000)]
Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC)
Mehdi Amini [Sun, 2 Jan 2022 22:02:18 +0000 (22:02 +0000)]
Apply clang-tidy fixes for performance-move-const-arg to MLIR (NFC)
Mehdi Amini [Sun, 2 Jan 2022 22:02:21 +0000 (22:02 +0000)]
Apply clang-tidy fixes for readability-simplify-boolean-expr to MLIR NormalizeMemRefs.cpp (NFC)
Martin Storsjö [Tue, 16 Nov 2021 21:10:48 +0000 (23:10 +0200)]
[clang] [MinGW] Pass --no-demangle through to the mingw linker
Clang has custom handling of --no-demangle, where it is removed
from the input -Wl and -Xlinker options, and readded specifically
by the drivers where it's known to be supported.
Both ld.bfd and lld support the --no-demangle option. This handles
the option in the same way as in ToolChains/Gnu.cpp.
Differential Revision: https://reviews.llvm.org/D114064
Mehdi Amini [Sun, 2 Jan 2022 22:02:14 +0000 (22:02 +0000)]
Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC)
Mehdi Amini [Sun, 2 Jan 2022 22:01:50 +0000 (22:01 +0000)]
Apply clang-tidy fixes for modernize-use-equals-default to MLIR (NFC)
Mehdi Amini [Sun, 2 Jan 2022 22:01:48 +0000 (22:01 +0000)]
Apply clang-tidy fixes for modernize-use-default-member-init to MLIR ReductionNode.cpp (NFC)
Mehdi Amini [Sun, 2 Jan 2022 22:01:07 +0000 (22:01 +0000)]
Apply clang-tidy fixes for bugprone-argument-comment to MLIR ArithmeticOps.cpp (NFC)
Nathan Sidwell [Sat, 25 Dec 2021 18:30:42 +0000 (13:30 -0500)]
[clang] Allow using std::coroutine_traits in std::experimental
This is that diff I was aiming for. When transitioning code from
coroutines-ts to c++20, it can be useful to add a using declaration to
std::experimental pointing to std::coroutine_traits. This permits
that use by checking whether lookup in std::experimentl finds a
different decl to lookup in std. You still get a warning about
std::experimental::coroutine_traits being a thing, just not an error.
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D115943
Philip Reames [Sun, 2 Jan 2022 19:37:06 +0000 (11:37 -0800)]
Precommit SCEV symbolic w.overflow exit tests
Dave Lee [Sun, 2 Jan 2022 03:30:08 +0000 (19:30 -0800)]
[lldb] Remove unused AproposAllSubCommands (NFC)
Philip Reames [Sun, 2 Jan 2022 19:27:18 +0000 (11:27 -0800)]
Autogen a SCEV test for ease of update
Florian Hahn [Sun, 2 Jan 2022 19:09:30 +0000 (19:09 +0000)]
[LV] Use Builder.CreateVectorReverse directly. (NFC)
IRBuilder::CreateVectorReverse already handles all cases required by
LoopVectorize. It can be used directly instead of reverseVector.
Kazu Hirata [Sun, 2 Jan 2022 18:20:23 +0000 (10:20 -0800)]
[clang] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Kazu Hirata [Sun, 2 Jan 2022 18:20:21 +0000 (10:20 -0800)]
[wasm] Use nullptr instead of NULL (NFC)
Identified with modernize-use-nullptr.
Kazu Hirata [Sun, 2 Jan 2022 18:20:19 +0000 (10:20 -0800)]
Remove redundant void arguments (NFC)
Identified by modernize-redundant-void-arg.
Kazu Hirata [Sun, 2 Jan 2022 18:20:17 +0000 (10:20 -0800)]
Remove unused "using" (NFC)
Identified by misc-unused-using-decls.
Kazu Hirata [Sun, 2 Jan 2022 18:20:15 +0000 (10:20 -0800)]
[Target] Remove unused forward declarations (NFC)
Philip Reames [Sun, 2 Jan 2022 18:15:17 +0000 (10:15 -0800)]
[SCEV] Drop unused param from new version of computeExitLimitFromICmp [NFC]
Philip Reames [Sun, 2 Jan 2022 17:49:45 +0000 (09:49 -0800)]
[SCEV] Split computeExitLimitFromICmp into two versions [NFC]
This is in advance of a following change which needs to the non-icmp API.
Arthur O'Dwyer [Sun, 2 Jan 2022 17:49:55 +0000 (12:49 -0500)]
[libc++] [test] Remove an erroneously copy-paste in the hypot() tests. NFC.
Line 1140 is a duplicate of line 1119; it tests the two-argument version
of std::hypot, whereas all the lines in this section are supposed to be
testing the C++17 three-argument version. Remove the erroneous duplicated line.
Split out of D116295.
Philip Reames [Sun, 2 Jan 2022 17:25:19 +0000 (09:25 -0800)]
autogen unroll test for ease of futre update
Nathan Sidwell [Sat, 25 Dec 2021 18:29:58 +0000 (13:29 -0500)]
[clang] More informative mixed namespace diagnostics
First, let's check we get a TemplateDecl, before complaining about
where it might have been found.
Second, if it came from an unexpected place, show where that location is.
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D116164
Florian Hahn [Sun, 2 Jan 2022 12:24:13 +0000 (12:24 +0000)]
[VPlan] Don't consider VPWidenCanonicalIVRecipe phi-like.
VPWidenCanonicalIVRecipe does not create PHI instructions, so it does
not need to be placed in the phi section of a VPBasicBlock.
Also tidies the code so the WidenCanonicalIV recipe and the
compare/lane-masks are created in the header.
Discussed D113223.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D116473
Markus Böck [Sun, 2 Jan 2022 11:06:54 +0000 (12:06 +0100)]
[clang][MinGW] Explicitly ignore `-fPIC` & friends
GCC on Windows ignores this flag completely [0] which some build systems sadly rely on when compiling for Windows using MinGW. The current behaviour of clang however is to error out as -fPIC & friends has no effect on Windows.
This patch instead changes the behaviour for MinGW to ignore the option for the sake of compatibility
Fixes https://github.com/llvm/llvm-project/issues/52947
[0] https://gcc.gnu.org/legacy-ml/gcc-patches/2015-08/msg00836.html
Differential Revision: https://reviews.llvm.org/D116485
Markus Böck [Sat, 1 Jan 2022 23:59:23 +0000 (00:59 +0100)]
[lld][MinGW] Ignore `--[no-]as-neeed` flags in MinGW driver
These flags are specific to ELF, but are still accepted by GNU ld, even if it does not do anything. This patch adds them as ignored option for the sake of compatibility.
Part of https://github.com/llvm/llvm-project/issues/52947
Differential Revision: https://reviews.llvm.org/D116484
Kazu Hirata [Sun, 2 Jan 2022 06:50:26 +0000 (22:50 -0800)]
[DebugInfo] Remove hasInterestingContent (NFC)
hasInterestingContent was introduced without a use on Sep 15, 2015 in
commit
e5162dba49890d9d436ea99d003c792897c9b880.
Kazu Hirata [Sun, 2 Jan 2022 06:50:24 +0000 (22:50 -0800)]
[CodeGen] Remove DisconnectedComponentsRenamed (NFC)
The last use was removed on May 31, 2016 in commit
f9acacaa928d7ba9db900c42893c244fb19714c4.
Kazu Hirata [Sun, 2 Jan 2022 06:05:16 +0000 (22:05 -0800)]
[AArch64] Remove unused constant NeonBitsPerVector (NFC)
Kazu Hirata [Sun, 2 Jan 2022 06:05:14 +0000 (22:05 -0800)]
[ADT] Remove ImmutableSet::foreach and ImmutableMap::foreach (NFC)
These functions seem to be unused for at least 1 year.
Craig Topper [Sun, 2 Jan 2022 03:53:52 +0000 (19:53 -0800)]
[RISCV] Prune unnecessary vector pseudo instructions. NFC
For .vf instructions, we don't need MF8 pseudos for f16. We don't
need MF8 or MF4 pseudos for f32. Or MF8, MF4, MF2 for f64.
Reviewed By: khchen
Differential Revision: https://reviews.llvm.org/D116437
Mehdi Amini [Sun, 2 Jan 2022 01:58:56 +0000 (01:58 +0000)]
Apply clang-tidy fixes for readability-simplify-boolean-expr to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116253
Mehdi Amini [Sun, 2 Jan 2022 01:55:30 +0000 (01:55 +0000)]
Apply clang-tidy fixes for readability-container-size-empty for MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116252
Mehdi Amini [Sun, 2 Jan 2022 01:53:18 +0000 (01:53 +0000)]
Remove unused applyPad function from TosaToLinalg.cpp (NFC)
Mehdi Amini [Sun, 2 Jan 2022 01:50:43 +0000 (01:50 +0000)]
Apply clang-tidy fixes for readability-const-return-type to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116251
Mehdi Amini [Sun, 2 Jan 2022 01:26:44 +0000 (01:26 +0000)]
Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC)
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D116250
Mehdi Amini [Sun, 2 Jan 2022 01:24:54 +0000 (01:24 +0000)]
Apply clang-tidy fixes for modernize-use-using to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116357
Mehdi Amini [Sun, 2 Jan 2022 01:22:19 +0000 (01:22 +0000)]
Apply clang-tidy fixes for modernize-use-override to MLIR (NFC)
Reviewed By: rriddle, jpienaar
Differential Revision: https://reviews.llvm.org/D116356
Mehdi Amini [Sun, 2 Jan 2022 01:21:01 +0000 (01:21 +0000)]
Apply clang-tidy fixes for llvm-qualified-auto to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116355
Mehdi Amini [Sun, 2 Jan 2022 01:18:41 +0000 (01:18 +0000)]
Apply clang-tidy fixes for bugprone-macro-parentheses to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116354
Mehdi Amini [Sun, 2 Jan 2022 01:11:13 +0000 (01:11 +0000)]
Apply clang-tidy fixes for performance-move-const-arg to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116249
Mehdi Amini [Thu, 23 Dec 2021 22:13:06 +0000 (22:13 +0000)]
Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC)
Differential Revision: https://reviews.llvm.org/D116248
Mehdi Amini [Thu, 23 Dec 2021 22:13:00 +0000 (22:13 +0000)]
Apply clang-tidy fixes for modernize-use-equals-default to MLIR (NFC)
Differential Revision: https://reviews.llvm.org/D116247
Mehdi Amini [Sat, 1 Jan 2022 21:31:24 +0000 (21:31 +0000)]
Apply clang-tidy fixes for bugprone-copy-constructor-init to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116245
Mehdi Amini [Wed, 29 Dec 2021 05:12:02 +0000 (05:12 +0000)]
Apply clang-tidy fixes for bugprone-argument-comment to MLIR (NFC)
Differential Revision: https://reviews.llvm.org/D116244
Mehdi Amini [Wed, 22 Dec 2021 00:18:47 +0000 (00:18 +0000)]
Enable a few clang-tidy checks in MLIR
The dry-run of clang-tidy on the codebase with these enable were
well receive, and the codebase is "clean" (or almost) with respect
to these right now.
Kazu Hirata [Sun, 2 Jan 2022 00:18:18 +0000 (16:18 -0800)]
[llvm] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Mehdi Amini [Sat, 1 Jan 2022 21:19:31 +0000 (21:19 +0000)]
Move LinalgDetensorize pass option from .cpp file to the .td declaration (NFC)
Mehdi Amini [Sat, 1 Jan 2022 02:16:11 +0000 (02:16 +0000)]
Use const reference for diagnostic in callback (NFC)
This isn't a "small" struct, flagged by Coverity.
Kazu Hirata [Sat, 1 Jan 2022 21:14:59 +0000 (13:14 -0800)]
[lldb] Add NOLINT(modernize-use-nullptr)
thread_result_t is defined as unsigned on Windows.
This patch prevents clang-tidy from replacing 0 with nullptr.
Kazu Hirata [Sat, 1 Jan 2022 20:34:11 +0000 (12:34 -0800)]
Remove redundant string initialization (NFC)
Identified by readability-redundant-string-init.
David Green [Sat, 1 Jan 2022 20:08:45 +0000 (20:08 +0000)]
[ARM] Verify addressing immediates
This adds at extra check into ARMBaseInstrInfo::verifyInstruction to
verify the offsets used in addressing mode immediates using
isLegalAddressImm. Some tests needed fixing up as a result, adjusting
the opcode created from CMSE stack adjustments.
Differential Revision: https://reviews.llvm.org/D114939