Daniel Mack [Mon, 31 Aug 2015 11:58:29 +0000 (13:58 +0200)]
Merge pull request #1093 from poettering/unified-prepare
A variety of clean-ups
Lennart Poettering [Mon, 31 Aug 2015 11:29:46 +0000 (13:29 +0200)]
cgtop: rework error handling
Never report errors twice.
Lennart Poettering [Mon, 31 Aug 2015 11:07:24 +0000 (13:07 +0200)]
sd-event: improve debug message when we fail to remove and fd from an epoll
Let's help users to debug issues with epoll fd removal by printing the
name of the event source.
Lennart Poettering [Mon, 31 Aug 2015 11:03:16 +0000 (13:03 +0200)]
cgls: pretty print root cgroup path
Make sure show it as "/" rather than empty string.
Lennart Poettering [Sun, 30 Aug 2015 20:13:55 +0000 (22:13 +0200)]
manager: remove ask-password fd from sd_event before closing it
Otherwise we might attempt to remove a non-existing fd from epoll.
Lennart Poettering [Sun, 30 Aug 2015 14:38:52 +0000 (16:38 +0200)]
man: document relationship between keys and switches of cgtop
Lennart Poettering [Sun, 30 Aug 2015 14:15:08 +0000 (16:15 +0200)]
cgtop: allow toggling of --recursive= and -k at runtime
Lennart Poettering [Sun, 30 Aug 2015 13:11:35 +0000 (15:11 +0200)]
cgtop: recursively count cgroup member tasks
When showing the number of tasks in a cgroup, recursively count tasks in
child cgroups and include them in the number. This ensures that the
number of tasks is cummulative the same way as memory, cpu and IO
resources are.
Old behaviour can be restored by passing the new --recursive=no switch.
Lennart Poettering [Fri, 28 Aug 2015 17:31:07 +0000 (19:31 +0200)]
cgtop: ignore kernel threads when counting tasks
However, allow them to be counted in by specifying -k
Lennart Poettering [Fri, 28 Aug 2015 17:29:33 +0000 (19:29 +0200)]
cgls: print the expressive error message we have
Lennart Poettering [Fri, 28 Aug 2015 17:29:03 +0000 (19:29 +0200)]
process-util: trivial optimization
Lennart Poettering [Fri, 28 Aug 2015 17:17:47 +0000 (19:17 +0200)]
cgtop: show resource usage relative to cgroup root only
This way the output is restricted to cgroups from a container when run
in one.
Lennart Poettering [Fri, 28 Aug 2015 16:29:02 +0000 (18:29 +0200)]
unit: minor simplification
Lennart Poettering [Fri, 28 Aug 2015 16:22:14 +0000 (18:22 +0200)]
util: treat 'C' and 'POSIX' locale identical
Lennart Poettering [Fri, 28 Aug 2015 16:17:14 +0000 (18:17 +0200)]
pager: set $LESSCHARSET when we output UTF8 chars
This way we can be sure that less has the same idea of the terminal as
we do.
This solves issues in systems that have locale uninitalized, where
systemd would output UTF-8 but less wouldn't allow it and show them as
control characters.
Lennart Poettering [Fri, 28 Aug 2015 15:36:39 +0000 (17:36 +0200)]
unit: unify how we assing slices to units
This adds a new call unit_set_slice(), and simplifies
unit_add_default_slice(). THis should make our code a bit more robust
and simpler.
Lennart Poettering [Fri, 28 Aug 2015 15:14:59 +0000 (17:14 +0200)]
unit: add new macros to test for unit contexts
Lennart Poettering [Fri, 28 Aug 2015 15:11:37 +0000 (17:11 +0200)]
core: use DUAL_TIMESTAMP_NULL where we can
Lennart Poettering [Fri, 28 Aug 2015 14:05:32 +0000 (16:05 +0200)]
core: don't generate stub unit file for transient units
We store the properties for transient units in drop-ins anyway, and
units don't have to have fragment files, hence don't bother with them,
and don't create them.
Lennart Poettering [Fri, 28 Aug 2015 11:38:49 +0000 (13:38 +0200)]
build-sys: add missing Makefile symlink
Lennart Poettering [Sun, 30 Aug 2015 19:57:52 +0000 (21:57 +0200)]
update TODO
Daniel Mack [Mon, 31 Aug 2015 10:15:35 +0000 (12:15 +0200)]
Merge pull request #1091 from marmolak/master
socket: fix setsockopt call. SOL_SOCKET changed to SOL_TCP.
Robin Hack [Mon, 31 Aug 2015 09:45:09 +0000 (11:45 +0200)]
socket: fix setsockopt call. SOL_SOCKET changed to SOL_TCP.
Lennart Poettering [Mon, 31 Aug 2015 09:36:01 +0000 (11:36 +0200)]
Merge pull request #1083 from filbranden/configparse1
A few more tweaks to extract_first_word
Daniel Mack [Mon, 31 Aug 2015 06:47:49 +0000 (08:47 +0200)]
Merge pull request #1088 from filbranden/perltest2
test: udev - Signal that test was skipped when running as non-root
Daniel Mack [Mon, 31 Aug 2015 06:46:48 +0000 (08:46 +0200)]
Merge pull request #1084 from crrodriguez/master
misc bugfixes
Daniel Mack [Mon, 31 Aug 2015 06:44:02 +0000 (08:44 +0200)]
Merge pull request #1087 from whot/hwdb-updates
hwdb: Add trackpoint sensitivity setting for Thinkpad X230
Filipe Brandenburger [Mon, 31 Aug 2015 05:10:30 +0000 (22:10 -0700)]
test: udev - Signal that test was skipped when running as non-root
It is more accurate to report that the test was skipped rather than
succeeded if we did not get to run it because it requires root.
Tested by running `make check` and inspecting the log file:
$ cat test/udev-test.pl.log
Must have root permissions to run properly.
SKIP test/udev-test.pl (exit status: 77)
The `make check` output also reported:
SKIP: test/udev-test.pl
Peter Hutterer [Mon, 31 Aug 2015 04:53:07 +0000 (14:53 +1000)]
hwdb: move the Performance MX to 1000dpi
Original entry may have been skewed by an earlier setting on the device, we
have a confirmed 1000dpi for a new device.
https://github.com/systemd/systemd/issues/1049
Peter Hutterer [Mon, 31 Aug 2015 04:42:02 +0000 (14:42 +1000)]
hwdb: Add trackpoint sensitivity setting for Thinkpad X230
https://bugs.freedesktop.org/show_bug.cgi?id=91794
Filipe Brandenburger [Mon, 31 Aug 2015 02:40:44 +0000 (19:40 -0700)]
extract_first_word: Refactor EXTRACT_DONT_COALESCE_SEPARATORS handling
Refactor allocation of the result string to the top, since it is
currently done in both branches of the condition.
Remove unreachable code checking for EXTRACT_DONT_COALESCE_SEPARATORS
when state == SEPARATOR (the only place where SEPARATOR is assigned to
state follows a check for EXTRACT_DONT_COALESCE_SEPARATORS that jumps to
the end of the function.)
Tested by running test-util successfully.
Follow up to:
206644aedeb8859801051ac170ec562c6a113a79
Filipe Brandenburger [Mon, 31 Aug 2015 02:16:50 +0000 (19:16 -0700)]
extract_first_word: Refactor allocation in empty argument case
This covers the case where an argument is an empty string, such as ''.
Instead of allocating the empty string in the individual conditions when
state == VALUE, just always allocate it at the end of state == START, at
which point we know we will have an argument.
Tested that test-util keeps passing after the refactor.
Follow up to:
14e685c29d5b317b815e3e9f056648027852b07e
Cristian Rodríguez [Sun, 30 Aug 2015 21:19:34 +0000 (18:19 -0300)]
sd-bus: Fix incorrect cleanup attribute in bus_match_to_string()
Must be _cleanup_fclose_ not _cleanup_free_
Cristian Rodríguez [Mon, 17 Aug 2015 21:23:31 +0000 (18:23 -0300)]
core: add attribute printf to null_log()
Cristian Rodríguez [Mon, 17 Aug 2015 21:22:24 +0000 (18:22 -0300)]
locale: add printf attribute to log_xkb()
Lennart Poettering [Sun, 30 Aug 2015 11:19:17 +0000 (13:19 +0200)]
Merge pull request #1072 from piotrdrag/master
po: update Polish translation
Lennart Poettering [Sun, 30 Aug 2015 11:18:14 +0000 (13:18 +0200)]
Merge pull request #1073 from phomes/master
util: make malloc0 ask calloc for one block of size n
Lennart Poettering [Sun, 30 Aug 2015 11:16:53 +0000 (13:16 +0200)]
Merge pull request #1074 from phomes/networkd-initialize-var
networkd: initialize tz to null
Thomas Hindoe Paaboel Andersen [Sun, 30 Aug 2015 01:19:25 +0000 (03:19 +0200)]
networkd: initialize tz to null
We may not set it before checking it for null.
Thomas Hindoe Paaboel Andersen [Fri, 28 Aug 2015 19:16:39 +0000 (21:16 +0200)]
util: make malloc0 ask calloc for one block of size n
... instead of an array of n individual bytes.
Silences a lot of warnings in smatch.
Piotr Drąg [Sat, 29 Aug 2015 18:33:02 +0000 (20:33 +0200)]
po: update Polish translation
Lennart Poettering [Sat, 29 Aug 2015 17:43:48 +0000 (19:43 +0200)]
nspawn: don't try to extract quotes from option string, glibc doesn't do that either
Follow-up regarding #649.
Lennart Poettering [Sat, 29 Aug 2015 17:42:36 +0000 (19:42 +0200)]
Merge pull request #649 from eyakubovich/nspawn-rbind
nspawn: add --rbind and --rbind-ro options
Lennart Poettering [Sat, 29 Aug 2015 17:40:32 +0000 (19:40 +0200)]
Merge pull request #1069 from evverx/networkctl-bash-completion
shell-completion: bash: add networkctl completion
Eugene Yakubovich [Tue, 21 Jul 2015 22:48:38 +0000 (15:48 -0700)]
nspawn: add (no)rbind option to --bind and --bind-ro
--bind and --bind-ro perform the bind mount
non-recursively. It is sometimes (often?) desirable
to do a recursive mount. This patch adds an optional
set of bind mount options in the form of:
--bind=src-path:dst-path:options
options are comma separated and currently only
"rbind" and "norbind" are allowed.
Default value is "rbind".
David Herrmann [Fri, 28 Aug 2015 22:21:46 +0000 (00:21 +0200)]
Merge pull request #1058 from spasche/hwdb-logitech-mice
hwdb: add DPI data for a few Logitech mice
David Herrmann [Fri, 28 Aug 2015 22:20:25 +0000 (00:20 +0200)]
Merge pull request #1071 from phomes/master
hwdb: update the mouse db
Thomas Hindoe Paaboel Andersen [Fri, 28 Aug 2015 21:44:01 +0000 (23:44 +0200)]
hwdb: update entry for logitech RX 250
I tested a RX 250 and measured 1000 DPI. The spec for the mouse
agrees:
http://www.logitech.com/en-gb/product/rx250-optical-mouse-business
This is an optical mouse so it is extra sensitive to what kind of
surface it is tested on.
Thomas Hindoe Paaboel Andersen [Fri, 28 Aug 2015 21:42:39 +0000 (23:42 +0200)]
hwdb: add a few more mice
Evgeny Vereshchagin [Fri, 28 Aug 2015 18:00:38 +0000 (18:00 +0000)]
shell-completion: bash: add networkctl completion
Daniel Mack [Fri, 28 Aug 2015 16:46:04 +0000 (18:46 +0200)]
Merge pull request #1068 from evverx/networkctl-man
man: networkctl understands --no-legend too
Evgeny Vereshchagin [Fri, 28 Aug 2015 16:19:07 +0000 (16:19 +0000)]
man: networkctl understands --no-legend too
Lennart Poettering [Fri, 28 Aug 2015 10:17:37 +0000 (12:17 +0200)]
Merge pull request #1067 from teg/dhcp-server
sd-dhcp-server: improve predictability of leases
Tom Gundersen [Fri, 28 Aug 2015 10:01:46 +0000 (12:01 +0200)]
Merge pull request #1063 from poettering/dbus-interface-from-type
cgls/cgtop: a variety of modernizations
Tom Gundersen [Thu, 27 Aug 2015 06:54:41 +0000 (08:54 +0200)]
sd-dhcp-server: improve predictability of leases
Rather than having all clients attempt to get the same leases (starting at the
beginning of the pool), make each client star at a random offset into the pool
determined by their client id. This greatly increases the chances of a given
client receiving the same IP address even though both the client and server
have lost any lease information (and distinct server instances handing out
the same leases).
Daniel Mack [Fri, 28 Aug 2015 06:56:40 +0000 (08:56 +0200)]
Merge pull request #1062 from poettering/cgroups-show
cgroup-show: unescape cgroups on presentation
Daniel Mack [Fri, 28 Aug 2015 06:56:08 +0000 (08:56 +0200)]
Merge pull request #1061 from poettering/pager
A few auto-pager improvements
Daniel Mack [Fri, 28 Aug 2015 06:54:19 +0000 (08:54 +0200)]
Merge pull request #1060 from poettering/resolved-man-2
man: Document that resolved requires nss-resolve to work with libc
Lennart Poettering [Fri, 28 Aug 2015 00:47:22 +0000 (02:47 +0200)]
Merge pull request #1064 from evverx/systemctl-completion
shell-completion: add `failed` state to --state compwords
Evgeny Vereshchagin [Fri, 28 Aug 2015 00:31:19 +0000 (00:31 +0000)]
shell-completion: add `failed` state to --state compwords
Lennart Poettering [Fri, 28 Aug 2015 00:23:01 +0000 (02:23 +0200)]
cgls: modernize cgls in preparation for unified cgroup hierarchy work
Fix --machine= handling, don't hardcode long-obsolete container
cgroup paths
Many other clean-ups.
Lennart Poettering [Fri, 28 Aug 2015 00:04:33 +0000 (02:04 +0200)]
cgtop: major modernizations
In preparation of the unified cgroup support, let's clean up cgtop:
a) rework time code to be based on "nsec_t" rather than "struct timespec"
b) Introduce long option --order= for selecting ordering
c) count number of processes only in the main hierarchy, don't bother
with the controller hierarchies. We don't allow orthogonal
hierarchies in systemd anymore, hence there's no point to check the
other hierarchies.
d) Deal with non-monotonic cpuacct values (see #749)
e) When sorting groups, don't do prefix compare when ordering by number
of tasks, since this is not accumulative for all children.
f) Actually make --cpu without parameter work
g) Don't output control characters when we get them as input.
Fixes #749.
Lennart Poettering [Thu, 27 Aug 2015 20:30:43 +0000 (22:30 +0200)]
core: add unit_dbus_interface_from_type() to unit-name.h
Let's add a way to get the type-specific D-Bus interface of a unit from
either its type or name to src/basic/unit-name.[ch]. That way we can
share it with the client side, where it is useful in tools like cgls or
machinectl.
Also ports over machinectl to make use of this.
Lennart Poettering [Thu, 27 Aug 2015 22:12:38 +0000 (00:12 +0200)]
cgroup-show: unescape cgroups on presentation
Let's unescape cgroups on presentation, so that we show literal unit
names.
Lennart Poettering [Thu, 27 Aug 2015 22:13:34 +0000 (00:13 +0200)]
pager: also redirect stderr
It's really confusing if stdout goes to the pager, but stderr is written
directly to the screen. Hence, make sure both stdout and stderr are
passed to the pager when doing autopaging.
Lennart Poettering [Thu, 27 Aug 2015 22:11:49 +0000 (00:11 +0200)]
pager: port fallback pager to use copy_bytes()
Lennart Poettering [Thu, 27 Aug 2015 22:10:35 +0000 (00:10 +0200)]
copy: add splice() based fallback
Apparently, sendfile() does not work between fifos and ttys, but
splice() does, hence let's optionally fall back to that. This is useful
to implement the fallback pager this way.
Lennart Poettering [Fri, 28 Aug 2015 00:03:11 +0000 (02:03 +0200)]
man: Document that resolved requires nss-resolve to work with libc
Closes #884.
Lennart Poettering [Thu, 27 Aug 2015 23:38:51 +0000 (01:38 +0200)]
Merge pull request #1059 from evverx/systemd-run-bash-completion
shell-completion: update systemd-run bash completion
Evgeny Vereshchagin [Thu, 27 Aug 2015 23:24:15 +0000 (23:24 +0000)]
shell-completion: update systemd-run bash completion
Many new options have been added since the bash completion was last
updated.
Tom Gundersen [Thu, 27 Aug 2015 19:39:44 +0000 (21:39 +0200)]
Merge pull request #1057 from poettering/resolve-drop-res-query
sd-resolve: drop res_query() API
Tom Gundersen [Thu, 27 Aug 2015 19:38:36 +0000 (21:38 +0200)]
Merge pull request #1055 from poettering/dhcp-updates
Various networkd and dhcp updates
Sylvain Pasche [Thu, 27 Aug 2015 19:17:15 +0000 (21:17 +0200)]
hwdb: add DPI data for a few Logitech mice
Lennart Poettering [Thu, 27 Aug 2015 19:05:13 +0000 (21:05 +0200)]
update TODO
Lennart Poettering [Thu, 27 Aug 2015 18:47:13 +0000 (20:47 +0200)]
sd-resolve: drop res_query() API
Querying low-level DNS RRs should be done via resolved now, not via
glibc's awful res_query() API anymore. Let's not introduce an async
wrapper for it hence.
Lennart Poettering [Thu, 27 Aug 2015 18:23:17 +0000 (20:23 +0200)]
networkd: s/now/know
Lennart Poettering [Thu, 27 Aug 2015 17:57:11 +0000 (19:57 +0200)]
dhcp: say domain name, when we mean domain name
Lennart Poettering [Thu, 27 Aug 2015 17:56:52 +0000 (19:56 +0200)]
network: get rid of more RefCnt usage
A follow-up to
3733eec3e292e4ddb4cba5eb8d3bd8cbee7102d8
Lennart Poettering [Thu, 27 Aug 2015 17:55:29 +0000 (19:55 +0200)]
dhcp: fix n_ref type
Fixes fallout from
3733eec3e292e4ddb4cba5eb8d3bd8cbee7102d8.
Lennart Poettering [Thu, 27 Aug 2015 15:48:24 +0000 (17:48 +0200)]
tree-wide: we place the opening bracket on the same line as the function name
Let's do this everywhere the same way.
Lennart Poettering [Thu, 27 Aug 2015 15:38:05 +0000 (17:38 +0200)]
networkd: make sure we remove udev fd from epoll *before* closing it
Otherwise we'll try to remove an invalid fd from epoll all the time.
Lennart Poettering [Thu, 27 Aug 2015 15:32:30 +0000 (17:32 +0200)]
man: document the new DHCP settings added in the past commits
David Herrmann [Thu, 27 Aug 2015 15:03:18 +0000 (17:03 +0200)]
NEWS: update
Add 'machinectl shell' to NEWS and also update date and contributors
lists.
Lennart Poettering [Thu, 27 Aug 2015 14:47:26 +0000 (16:47 +0200)]
networkd: emit DNS/NTP/Timezone info via DHCP server by default
If we have the data, emit it by default.
Lennart Poettering [Thu, 27 Aug 2015 14:45:24 +0000 (16:45 +0200)]
networkd: propagate DNS/NTP server from uplink to dhcp server
When handing out DHCP leases, try to propagate DNS/NTP server
information from "uplink". The "uplink" is automatically determined as
the network interface with the highest priority default route on it.
David Herrmann [Thu, 27 Aug 2015 14:43:02 +0000 (16:43 +0200)]
sd-bus: do not connect to dbus-1 socket when kdbus is available
We should not fall back to dbus-1 and connect to the proxy when kdbus
returns an error that indicates that kdbus is running but just does not
accept new connections because of quota limits or something similar.
Based on a patch by Kay.
David Herrmann [Thu, 27 Aug 2015 14:32:22 +0000 (16:32 +0200)]
Revert "sd-bus: do not connect to dbus-1 socket when kdbus is available"
This reverts commit
d4d00020d6ad855d65d31020fefa5003e1bb477f. The idea of
the commit is broken and needs to be reworked. We really cannot reduce
the bus-addresses to a single address. We always will have systemd with
native clients and legacy clients at the same time, so we also need both
addresses at the same time.
David Herrmann [Thu, 27 Aug 2015 14:23:47 +0000 (16:23 +0200)]
selinux: drop mac_selinux_unit_access_check_strv()
It is not acceptable to load unit files during enable/disable operations
just to figure out the selinux labels. systemd implements lazy loading
for units, so the selinux hooks need to follow it.
This drops the mac_selinux_unit_access_check_strv() helper which
implements a non-acceptable policy check. If anyone cares for that
functionality, you really should pass a callback+userdata to the helpers
in src/shared/install.c which does policy checks on each touched file.
See #1050 on github for more.
David Herrmann [Thu, 27 Aug 2015 14:22:33 +0000 (16:22 +0200)]
sd-bus: rename bloom-tag to arg0-has
We use dashes in our bloom-tags. Make sure the newly introduced arg0has
tag uses the same style.
Note that the external dbus-tags don't use dashes, though. They are
defined in the spec and we need to keep compatibility there.
David Herrmann [Thu, 27 Aug 2015 14:14:20 +0000 (16:14 +0200)]
Merge pull request #1036 from poettering/sd-bus-arg0has
sd-bus: introduce new match type "arg0has=" for matching arrays of st…
David Herrmann [Thu, 27 Aug 2015 14:12:52 +0000 (16:12 +0200)]
Merge pull request #1024 from poettering/sd-bus-explicit
sd-bus: introduce new SD_BUS_VTABLE_PROPERTY_EXPLICIT flag
Lennart Poettering [Thu, 27 Aug 2015 12:48:37 +0000 (14:48 +0200)]
dhcp,network: support emitting DNS/NTP server information from DHCP server
For now, this is very simple and IP addresses have to be configured
manually.
Lennart Poettering [Thu, 27 Aug 2015 11:59:06 +0000 (13:59 +0200)]
networkd: split up networkd.h into per-object header files
No functional changes, just moving definitions into separate header
files.
Lennart Poettering [Thu, 27 Aug 2015 11:04:33 +0000 (13:04 +0200)]
networkd: port many log messages over to newer logging API
Let's drop some strerror() invocations, and make use of the easier to
use newer logging APIs.
Kay Sievers [Thu, 27 Aug 2015 10:57:17 +0000 (12:57 +0200)]
udev: control - add FIXME comment to remove work-around
Lennart Poettering [Thu, 27 Aug 2015 10:54:35 +0000 (12:54 +0200)]
sd-bus: it's not a user error to query the error contained in a bus message
It's an OK way to check whether a message contains an erro, let's not
consider this a loggable assertion event.
Lennart Poettering [Thu, 27 Aug 2015 10:53:43 +0000 (12:53 +0200)]
networkd: properly reset transient hostname when we lose a DHCP lease
Previously we were setting the transient hostname again, rather than
resetting it.
Lennart Poettering [Thu, 27 Aug 2015 00:12:27 +0000 (02:12 +0200)]
networkd: optionally push dhcp timezone into timedated
Lennart Poettering [Wed, 26 Aug 2015 23:59:43 +0000 (01:59 +0200)]
dhcp: don't underflow in lease time calculations
Don't underflow when calculating lease time.
Lennart Poettering [Wed, 26 Aug 2015 23:47:42 +0000 (01:47 +0200)]
networkd: make DHCP lease timeouts configurable