platform/upstream/dotnet/runtime.git
5 years agoRe-generate System.Collections ref assembly against implementation (dotnet/corefx...
Santiago Fernandez Madero [Wed, 29 May 2019 20:54:26 +0000 (13:54 -0700)]
Re-generate System.Collections ref assembly against implementation (dotnet/corefx#38005)

Commit migrated from https://github.com/dotnet/corefx/commit/837efeb37d25146f73d22952d4bbf84c1b216bcd

5 years agoAvoid .ToArray() in JsonSerializer .NET Standard implementation (dotnet/corefx#37976)
Adam Sitnik [Wed, 29 May 2019 16:58:07 +0000 (09:58 -0700)]
Avoid .ToArray() in JsonSerializer .NET Standard implementation (dotnet/corefx#37976)

* PooledBufferWriter<T> is always used as byte buffer, make it PooledByteBufferWriter to be able to call stream.Write(bytes)

* avoid expensive .ToArray in .NET Standard implementation

* rename

Commit migrated from https://github.com/dotnet/corefx/commit/e3a4edabd12b5f7dc9be20136cc867bbe67f1f7c

5 years agoRemove SSL cancellation workaround from SocketsHttpHandler (dotnet/corefx#37990)
Stephen Toub [Wed, 29 May 2019 15:30:52 +0000 (11:30 -0400)]
Remove SSL cancellation workaround from SocketsHttpHandler (dotnet/corefx#37990)

Both sockets cancellation and SslStream auth cancellation have been implemented.

Commit migrated from https://github.com/dotnet/corefx/commit/46800900077920534038be00d7bc73236e1a5fa7

5 years agoBase64 encoding with simd-support (dotnet/corefx#34529)
Günther Foidl [Wed, 29 May 2019 15:29:31 +0000 (17:29 +0200)]
Base64 encoding with simd-support (dotnet/corefx#34529)

* Optimized scalar code-path

* Fixed label names

* Implemented vectorized versions

* Added reference to source of algorithm

* Added back missing namespace

* Unsafe.Add instead of Unsafe.Subtract

Fixed build-failure (https://ci3.dot.net/job/dotnet_corefx/job/master/job/linux-musl-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/8247/console)
Seems like the internal Unsafe doesn't have a Subtract method, so use Add instead.

* Added THIRD-PARTY-NOTICES

* PR Feedback

* THIRD-PARTY-NOTICES in repo-base instead instead in folder

Cf. https://github.com/dotnet/corefx/pull/34529#issuecomment-453510246

* PR Feedback

* https://github.com/dotnet/corefx/pull/34529#discussion_r247200659
* https://github.com/dotnet/corefx/pull/34529#discussion_r247214904

* Rewritten to use raw-pointers instead of GC-tracked refs

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r247197669

* Initialized the static fields directly (i.e. w/o cctor)

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r247193419

* Added a test for decoding a (encoded) Guid

The case with decoding encoded 16 bytes was not covered by tests, so a wrong code got commited before, resulting
in DestinationTooSmall instead of the correct Done.

* EncodingMap / DecodingMap as byref instead of pointer

So got rid of the `rep stosd` in the prolog. Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r248075157

* PR Feedback

* https://github.com/dotnet/corefx/pull/34529#discussion_r262165689

* Debug.Fail instead throwing for the assertion

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r263894301

* ROSpan for static data

* ROS for lookup maps

* In decode avoided stack spill and hoisted zero-vector outside the loops

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287613894

* Assert assumption about destLength

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287605561

* Added comments from original source and some changes to variable names

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287606634 and https://github.com/dotnet/corefx/pull/34529#discussion_r287606714

* Use TestZ instead of MoveMask in AVX2-path

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287825385

* Fixed too complicated mask2F creation

Improved the version done in dotnet/corefx@c8b6cb3387ca856f52d246ad260172c8fe1d9dcd, so the static data isn't needed and code is more compact and readable.

Commit migrated from https://github.com/dotnet/corefx/commit/036e0a64bd190e80f1685c3b267e495b03bb2962

5 years agoUpdate ProjectNTfs to beta-27729-00
dotnet-maestro-bot [Wed, 29 May 2019 05:45:54 +0000 (22:45 -0700)]
Update ProjectNTfs to beta-27729-00

Commit migrated from https://github.com/dotnet/corefx/commit/5dc4a0875331970d9b7435f07f5c4eedf57d93a3

5 years agoDisable sporadically failing GetGCMemoryInfo test (dotnet/corefx#37995)
Stephen Toub [Wed, 29 May 2019 00:46:45 +0000 (20:46 -0400)]
Disable sporadically failing GetGCMemoryInfo test (dotnet/corefx#37995)

Commit migrated from https://github.com/dotnet/corefx/commit/c7d48ca7732b7717e84d8375588d83866104ef58

5 years agoMake AuthenticateAsClient/ServerAsync cancellation token optional (dotnet/corefx...
Stephen Toub [Wed, 29 May 2019 00:44:47 +0000 (20:44 -0400)]
Make AuthenticateAsClient/ServerAsync cancellation token optional (dotnet/corefx#37996)

Commit migrated from https://github.com/dotnet/corefx/commit/2f28708788d67eb9943cd14a39df4bc87298418e

5 years agoImprove SocketAddress.ToString() performance (dotnet/corefx#37973)
Stephen Toub [Wed, 29 May 2019 00:40:11 +0000 (20:40 -0400)]
Improve SocketAddress.ToString() performance (dotnet/corefx#37973)

* Improve SocketAddress.ToString() performance

* Disable test on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/7508b75b843d89f6df5e5789c65a3cc23b94b757

5 years agoCreating common security policy
Barry Dorrans [Tue, 28 May 2019 22:21:46 +0000 (15:21 -0700)]
Creating common security policy

Commit migrated from https://github.com/dotnet/corefx/commit/c0629b395e8cfe632fcf1bd75e9de1a02cbb514c

5 years agoRemove socket cancellation workarounds on Unix from System.IO.Pipes (dotnet/corefx...
Stephen Toub [Tue, 28 May 2019 21:46:40 +0000 (17:46 -0400)]
Remove socket cancellation workarounds on Unix from System.IO.Pipes (dotnet/corefx#37988)

Commit migrated from https://github.com/dotnet/corefx/commit/ac24849e0404b9a7caba56fd398dbe6c5dbede0a

5 years agoImprove Debug.Assert in ConcurrentBag (dotnet/corefx#37986)
Stephen Toub [Tue, 28 May 2019 20:42:32 +0000 (16:42 -0400)]
Improve Debug.Assert in ConcurrentBag (dotnet/corefx#37986)

To try to help track down a spurious assert failure.

Commit migrated from https://github.com/dotnet/corefx/commit/3ca2657708840510873d8564c182ed06e92d87f6

5 years agoMake JsonPropertyNameAttribute.Name readonly (dotnet/corefx#37829)
Maryam Ariyan [Tue, 28 May 2019 19:27:20 +0000 (12:27 -0700)]
Make JsonPropertyNameAttribute.Name readonly (dotnet/corefx#37829)

Rename ctor arg to name

Fixes: dotnet/corefx#37552

Commit migrated from https://github.com/dotnet/corefx/commit/e8990ae04e4ef62f5ccb143352472c9b4d5d5968

5 years agoAdd Skip and TrySkip APIs to Utf8JsonReader with tests. (dotnet/corefx#37793)
Ahson Khan [Tue, 28 May 2019 19:26:08 +0000 (12:26 -0700)]
Add Skip and TrySkip APIs to Utf8JsonReader with tests. (dotnet/corefx#37793)

* Add Skip and TrySkip APIs to Utf8JsonReader with tests.

* Auto-generate the ref assembly.

* Remove new lines and update bytes consumed to avoid adjusting OS specific offsets.

* Add IsFinalBlock public property.

* Break up the skip/try skip method into helpers.

* Add more direct tests and update impl to avoid unnecessary struct copy.

Commit migrated from https://github.com/dotnet/corefx/commit/2f2aca43ef9d24c794255c3ef5d0238dc479652b

5 years agoUser-Agent header is ignored in "CONNECT" requests (dotnet/corefx#37785)
Marco Rossignoli [Tue, 28 May 2019 16:36:25 +0000 (18:36 +0200)]
User-Agent header is ignored in "CONNECT" requests  (dotnet/corefx#37785)

* flow UserAgent on CONNECT

* Apply Stephen feedback

* address PR feedback

* update test

* fix style

Commit migrated from https://github.com/dotnet/corefx/commit/1064d0352c007fd2d8fb32d7f6e286fbb6d41264

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37953)
dotnet-maestro[bot] [Tue, 28 May 2019 16:34:33 +0000 (12:34 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37953)

* Update dependencies from https://github.com/dotnet/coreclr build 20190524.71

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19274.71
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19274.71
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19274.71

* Fix Monitoring tests to reflect newly implemented support

* Fix StringBuilder tests to reflect updated unsupported braces behavior

* Update dependencies from https://github.com/dotnet/coreclr build 20190527.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19277.72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19277.72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19277.72

* Fix ordering of retrieving process time values in Monitoring test

Commit migrated from https://github.com/dotnet/corefx/commit/f90b73ebf00fbe3a4e97fa6445bb69a69985a800

5 years agoMerge pull request dotnet/corefx#37975 from dotnet-maestro-bot/master-UpdateDependencies
Viktor Hofer [Tue, 28 May 2019 12:47:49 +0000 (14:47 +0200)]
Merge pull request dotnet/corefx#37975 from dotnet-maestro-bot/master-UpdateDependencies

Update ProjectNTfs to beta-27728-00 (master)

Commit migrated from https://github.com/dotnet/corefx/commit/8d1149c3c73cbb650014ccffe2136bad1287b216

5 years agoUpdate ProjectNTfs to beta-27728-00
dotnet-maestro-bot [Tue, 28 May 2019 05:44:43 +0000 (22:44 -0700)]
Update ProjectNTfs to beta-27728-00

Commit migrated from https://github.com/dotnet/corefx/commit/6033b11330ec30e378b17dc636cb667d103090ac

5 years agoMove tests with external servers to outerloop (dotnet/corefx#37934)
Tomas Weinfurt [Mon, 27 May 2019 21:48:04 +0000 (14:48 -0700)]
Move tests with external servers to outerloop (dotnet/corefx#37934)

* move tests with external servers to outerloop

* fix Set_ValidValues_Success

Commit migrated from https://github.com/dotnet/corefx/commit/d58a8ade31b4731759c92df00d0f6398c52f3d83

5 years agoMerge pull request dotnet/corefx#37950 from dotnet/darc-master-201ad320-f5b9-4f45...
Viktor Hofer [Mon, 27 May 2019 07:57:12 +0000 (00:57 -0700)]
Merge pull request dotnet/corefx#37950 from dotnet/darc-master-201ad320-f5b9-4f45-bcaa-3bd13b56ebcf

[master] Update dependencies from dotnet/arcade

Commit migrated from https://github.com/dotnet/corefx/commit/5dd3196b5af24be242019ac1c5eb9344dfd5e155

5 years agoUpdate ProjectNTfs to beta-27727-00 (dotnet/corefx#37961)
dotnet-maestro-bot [Mon, 27 May 2019 07:06:48 +0000 (00:06 -0700)]
Update ProjectNTfs to beta-27727-00 (dotnet/corefx#37961)

Commit migrated from https://github.com/dotnet/corefx/commit/ba19505d72fdd39e9a4f5ca1be1fa2084f76bf0f

5 years agoRemove custom restore for arcade
Viktor Hofer [Mon, 27 May 2019 06:45:38 +0000 (08:45 +0200)]
Remove custom restore for arcade

Commit migrated from https://github.com/dotnet/corefx/commit/c31734ad51d054919d27fe83847ad656e095b974

5 years agoUpdate xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties (dotnet...
Krzysztof Wicher [Sat, 25 May 2019 16:25:15 +0000 (09:25 -0700)]
Update xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties (dotnet/corefx#37910)

* Update xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties

* 'Note:' -> '<remarks>'

* Update src/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/corefx/commit/a59cb1a773af5bf651f461546ac1d89a92519278

5 years agoUse Thread instead of Task.Run in some Task tests (dotnet/corefx#37932)
Tarek Mahmoud Sayed [Fri, 24 May 2019 22:05:04 +0000 (15:05 -0700)]
Use Thread instead of Task.Run in some Task tests (dotnet/corefx#37932)

Stephen Toub pointed that it is possible when using Task.Run, there could be some ThreadLocal fields on the thread executing the task holding a reference to the object we are trying to GC collect and finalize. The fix here is use Thread objects instead of Task.

Commit migrated from https://github.com/dotnet/corefx/commit/bf7dbd6d37285a147dd30f5dfca6582046dcabc7

5 years agoFix binary bitwise operators with resized BitArray (dotnet/corefx#37876)
Ganbarukamo41 [Fri, 24 May 2019 16:40:58 +0000 (01:40 +0900)]
Fix binary bitwise operators with resized BitArray (dotnet/corefx#37876)

* fix binary bitwise operators with resized bitarray
* Use `Length` property instead of array.Length to avoid operating on unused area
* Add tests for binary bitwise operators using resized bitarrays

* Revert micro-optimisations

Commit migrated from https://github.com/dotnet/corefx/commit/3232bbdf246257690cb2710609de6ff9aa3412ce

5 years agoRe-generate System.Runtime.InteropServices ref source against implementation (dotnet...
Santiago Fernandez Madero [Fri, 24 May 2019 16:20:48 +0000 (09:20 -0700)]
Re-generate System.Runtime.InteropServices ref source against implementation (dotnet/corefx#37914)

* Re-generate System.Runtime.InteropServices ref source against implementation

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/564ced2a4cfcb02c1efc1e0da83c54f2b9073ea4

5 years agorename ToBytes to ToUtf8Bytes (dotnet/corefx#37912)
Anirudh Agnihotry [Fri, 24 May 2019 15:50:13 +0000 (08:50 -0700)]
rename ToBytes to ToUtf8Bytes (dotnet/corefx#37912)

Commit migrated from https://github.com/dotnet/corefx/commit/4e342b94a06e21604cd805d0340ef871adc47c43

5 years agoUpdate ProjectNTfs to beta-27724-00 (dotnet/corefx#37921)
dotnet-maestro-bot [Fri, 24 May 2019 14:03:33 +0000 (07:03 -0700)]
Update ProjectNTfs to beta-27724-00 (dotnet/corefx#37921)

Commit migrated from https://github.com/dotnet/corefx/commit/555d6e7991cec1f03b8782bd3fa4cfe5e7bcaa4d

5 years agofix dotnet/corefx#36798 by updating PipeReader doc comment (dotnet/corefx#37919)
Andrew Stanton-Nurse [Fri, 24 May 2019 13:50:01 +0000 (06:50 -0700)]
fix dotnet/corefx#36798 by updating PipeReader doc comment (dotnet/corefx#37919)

Fixes dotnet/corefx#36798

Corrects an inaccurate doc comment in System.IO.Pipelines.PipeReader

Commit migrated from https://github.com/dotnet/corefx/commit/cbc9701436853421b389e118e410e7470c887353

5 years agoAddress dotnet/corefx#37794 by removing "UTF-16" when not needed in System.Text.Json...
Christopher Watford [Fri, 24 May 2019 03:59:39 +0000 (23:59 -0400)]
Address dotnet/corefx#37794 by removing "UTF-16" when not needed in System.Text.Json docs (dotnet/corefx#37866)

* Remove UTF-16 notes from summary and param comments dotnet/corefx#37794

* Remove UTF-16 references from JsonEncodedText comments

* Address PR review comments by @ahsonkhan

Commit migrated from https://github.com/dotnet/corefx/commit/c539d6c627b169d45f0b4cf1826b560cd0862abe

5 years agoFix typo in JsonSerializer api documentation. (dotnet/corefx#37917)
Ahson Khan [Fri, 24 May 2019 03:14:50 +0000 (20:14 -0700)]
Fix typo in JsonSerializer api documentation. (dotnet/corefx#37917)

Commit migrated from https://github.com/dotnet/corefx/commit/57337477528b0b3344c4f190ea0ad85d5bc19cd0

5 years agoSupport unlimited array dimensions (dotnet/corefx#37867)
Steve Harter [Thu, 23 May 2019 20:46:19 +0000 (13:46 -0700)]
Support unlimited array dimensions (dotnet/corefx#37867)

Commit migrated from https://github.com/dotnet/corefx/commit/025bb33e27b15d973e8be430a9329309ecac37d3

5 years agoAdd nowarns for reference assemblies to be annotated with nullable warnings (dotnet...
Santiago Fernandez Madero [Thu, 23 May 2019 20:02:46 +0000 (13:02 -0700)]
Add nowarns for reference assemblies to be annotated with nullable warnings (dotnet/corefx#37901)

Commit migrated from https://github.com/dotnet/corefx/commit/41489a93acf3f36abcaaaea2003a8fdbb577cf35

5 years agoAdd logging at the Task timeout tests (dotnet/corefx#37874)
Tarek Mahmoud Sayed [Thu, 23 May 2019 15:40:39 +0000 (08:40 -0700)]
Add logging at the Task timeout tests (dotnet/corefx#37874)

We need to get more info to understand what is going on when the test timeout. Also, we are now FailFast to have the test runs create a debugger dump at least when running on Linux platforms. Hopefully this can help in the diagnostics

Commit migrated from https://github.com/dotnet/corefx/commit/510ab9e6433ff0df29e0ae080140f4f2c1b69abd

5 years agoUpdate ProjectNTfs to beta-27723-00 (dotnet/corefx#37887)
dotnet-maestro-bot [Thu, 23 May 2019 10:51:36 +0000 (03:51 -0700)]
Update ProjectNTfs to beta-27723-00 (dotnet/corefx#37887)

Commit migrated from https://github.com/dotnet/corefx/commit/97fb32cbd491a5614190ae476c41da3f49b0ab22

5 years agoUpdate to new compiler toolset by using arcade's property (dotnet/corefx#37883)
Santiago Fernandez Madero [Thu, 23 May 2019 04:28:22 +0000 (21:28 -0700)]
Update to new compiler toolset by using arcade's property (dotnet/corefx#37883)

* Update to new compiler toolset by using arcade's property

* Run manual darc update

Commit migrated from https://github.com/dotnet/corefx/commit/daa005b23d4954d4a41b1663171d6ada2d960bd2

5 years agoUse RepoTools instead of global tools (dotnet/corefx#37858)
Viktor Hofer [Thu, 23 May 2019 01:41:45 +0000 (18:41 -0700)]
Use RepoTools instead of global tools (dotnet/corefx#37858)

Commit migrated from https://github.com/dotnet/corefx/commit/58c30f7413b93f47d332c8ec50a40013c3694791

5 years agoRemove LanguageTargets switch (dotnet/corefx#37875)
Viktor Hofer [Wed, 22 May 2019 22:56:13 +0000 (15:56 -0700)]
Remove LanguageTargets switch (dotnet/corefx#37875)

Commit migrated from https://github.com/dotnet/corefx/commit/9963d520d38caf5318356a08c4a3b08f904d2b26

5 years agoUse netfx ref package from nuget (dotnet/corefx#37869)
Viktor Hofer [Wed, 22 May 2019 22:50:06 +0000 (15:50 -0700)]
Use netfx ref package from nuget (dotnet/corefx#37869)

Commit migrated from https://github.com/dotnet/corefx/commit/c8e1416eb6801c782e98bf6fff8e0110bde5011c

5 years agoFix threading issue when reading and writing from SslStream at the same time (dotnet...
Krzysztof Wicher [Wed, 22 May 2019 19:30:44 +0000 (12:30 -0700)]
Fix threading issue when reading and writing from SslStream at the same time (dotnet/corefx#37736)

Commit migrated from https://github.com/dotnet/corefx/commit/a28444b71a45171c07eb28a5d82086a4589665fe

5 years agoUpdate issue-guide.md
Karel Zikmund [Wed, 22 May 2019 18:35:49 +0000 (11:35 -0700)]
Update issue-guide.md

Adding Cory

Commit migrated from https://github.com/dotnet/corefx/commit/40197abf52c92572a3cdb2005d6250eae9b8a9f9

5 years agoinitial support for new network protocols (dotnet/corefx#37315)
Tomas Weinfurt [Wed, 22 May 2019 18:31:10 +0000 (11:31 -0700)]
initial support for new network protocols (dotnet/corefx#37315)

* initial support for new network protocols

* feedback from review

* fix compilation of AF_CAN

Commit migrated from https://github.com/dotnet/corefx/commit/6f6790fa8219359f2acbe4b0624a3fa9a0a6943b

5 years agoUpdate area owners for System.IO.Pipelines
Karel Zikmund [Wed, 22 May 2019 18:26:23 +0000 (11:26 -0700)]
Update area owners for System.IO.Pipelines

Commit migrated from https://github.com/dotnet/corefx/commit/23d3b1b5bd5fc97f2d96a0c5a63fa14657607b63

5 years agoMerge pull request dotnet/corefx#37851 from BruceForstall/PublishMoreCorefxTests
Bruce Forstall [Wed, 22 May 2019 16:19:01 +0000 (09:19 -0700)]
Merge pull request dotnet/corefx#37851 from BruceForstall/PublishMoreCorefxTests

Publish corefx tests for more platforms

Commit migrated from https://github.com/dotnet/corefx/commit/7432f96e2af8541bcb2a22cd6a0bd625fe7f71a2

5 years agoUpdate ProjectNTfs to beta-27722-00 (dotnet/corefx#37859)
dotnet-maestro-bot [Wed, 22 May 2019 14:12:54 +0000 (07:12 -0700)]
Update ProjectNTfs to beta-27722-00 (dotnet/corefx#37859)

Commit migrated from https://github.com/dotnet/corefx/commit/62951c47e6897c1c9f18a4b2aeee64d99968cb76

5 years agousing netcoreapp2.1 version if colorUtil (dotnet/corefx#37854)
Anirudh Agnihotry [Wed, 22 May 2019 04:51:30 +0000 (21:51 -0700)]
using netcoreapp2.1 version if colorUtil (dotnet/corefx#37854)

Commit migrated from https://github.com/dotnet/corefx/commit/ee35d4f56f8509267fe56086394966f2804d8557

5 years agoRegression test for multiple attributes on the same type (dotnet/corefx#37518)
Jan Kotas [Wed, 22 May 2019 04:26:13 +0000 (21:26 -0700)]
Regression test for multiple attributes on the same type (dotnet/corefx#37518)

Contributes to dotnet/corefx#37261

Commit migrated from https://github.com/dotnet/corefx/commit/85d82a0402e26fb02be4c006752904cb8e0f8b02

5 years agoFix ambiguous Utf8JsonReader Get/TryGet method documentation (dotnet/corefx#37779)
RJ [Wed, 22 May 2019 02:49:49 +0000 (22:49 -0400)]
Fix ambiguous Utf8JsonReader Get/TryGet method documentation (dotnet/corefx#37779)

Commit migrated from https://github.com/dotnet/corefx/commit/2016619a120bcf6c690801bc577b2e170f1a92e1

5 years agoUpdate packageIndex.json with packages from release branches (dotnet/corefx#37600)
Jose Perez Rodriguez [Tue, 21 May 2019 23:58:45 +0000 (16:58 -0700)]
Update packageIndex.json with packages from release branches (dotnet/corefx#37600)

* Update packageIndex.json with packages from release branches

* Fixing last packaging validation errors

Commit migrated from https://github.com/dotnet/corefx/commit/8d0428194d69a8d7fb249a9f4ef780cb4cd54de4

5 years agoPublish corefx tests for more platforms
Bruce Forstall [Tue, 21 May 2019 22:18:02 +0000 (15:18 -0700)]
Publish corefx tests for more platforms

Add publishing for Linux/arm64, Linux/arm32, musl/x64, musl/arm64.

Commit migrated from https://github.com/dotnet/corefx/commit/4c5a775daddc95fa484e36637bcb9a67edbbd575

5 years agoAdd Utc test to ensure creating only one instance (dotnet/corefx#37721)
Tarek Mahmoud Sayed [Tue, 21 May 2019 21:39:09 +0000 (14:39 -0700)]
Add Utc test to ensure creating only one instance (dotnet/corefx#37721)

* Add Utc test to ensure creating only one instance

* Address the feedback

Commit migrated from https://github.com/dotnet/corefx/commit/39c7df85afee9ddc8bc1a1726a92526d43b1959f

5 years agoExclude non netcoreapp packages from OOB package (dotnet/corefx#37845)
Viktor Hofer [Tue, 21 May 2019 19:16:50 +0000 (12:16 -0700)]
Exclude non netcoreapp packages from OOB package (dotnet/corefx#37845)

Commit migrated from https://github.com/dotnet/corefx/commit/008d21c47c22b5757e09f6c3d346998004a0f985

5 years agoAvoid StackOverflowException when cyclic enumerable Type (dotnet/corefx#37818)
Steve Harter [Tue, 21 May 2019 18:50:53 +0000 (11:50 -0700)]
Avoid StackOverflowException when cyclic enumerable Type (dotnet/corefx#37818)

Commit migrated from https://github.com/dotnet/corefx/commit/857d1d1a9e1cd3597e3b1488f119d3a52e8b921a

5 years agoUpdate ProjectNTfs to beta-27721-00 (dotnet/corefx#37832)
dotnet-maestro-bot [Tue, 21 May 2019 17:32:31 +0000 (10:32 -0700)]
Update ProjectNTfs to beta-27721-00 (dotnet/corefx#37832)

Commit migrated from https://github.com/dotnet/corefx/commit/a70f241c0096ed2695333faaa08811e09e947a80

5 years agoAdding some additional tests to validating formatting is correct with regards to...
Tanner Gooding [Tue, 21 May 2019 11:09:12 +0000 (04:09 -0700)]
Adding some additional tests to validating formatting is correct with regards to rounding. (dotnet/corefx#37820)

Commit migrated from https://github.com/dotnet/corefx/commit/b3ac650a36e2fa04988fb37c4a0a3195a9e2dc36

5 years agoAs Span and As Memory apis added for immutable arrays (dotnet/corefx#37757)
Anirudh Agnihotry [Tue, 21 May 2019 06:42:55 +0000 (23:42 -0700)]
As Span and As Memory apis added for immutable arrays (dotnet/corefx#37757)

* As Span and As memory added for immutable arrays

* Fixing netstandard build

* using a more generic compile constant

* fixing build for netcoreapp

* building fix for netfx and netstandard

* fixing netstandard1.0, using generateRefereceASource to get ref file, tests for string and default immutable arrays

Commit migrated from https://github.com/dotnet/corefx/commit/51a1f16ee2aaded4ce1fca6847471b58f7ffa160

5 years agoReenable ModifyStore tests (dotnet/corefx#37827)
Viktor Hofer [Tue, 21 May 2019 05:40:49 +0000 (07:40 +0200)]
Reenable ModifyStore tests (dotnet/corefx#37827)

Commit migrated from https://github.com/dotnet/corefx/commit/11eba7947e9736109c588a1cfcb77987cb80f570

5 years agoImplement GetComment API (dotnet/corefx#35705)
Mandar Sahasrabuddhe [Tue, 21 May 2019 02:25:22 +0000 (07:55 +0530)]
Implement GetComment API (dotnet/corefx#35705)

* CoreFx dotnet/corefx#33347: Implement GetComment API

* Generate References as per correct steps

* Exclude delims & line separators, new unescape test

* Revert consume comment changes, test case fixes

* Partial revert of previous incorrect online merge

* fixed another online merge conflict resolution slippage

* Intermediate rebase from master

* Reworked files

* Reworked files 2

* Fix coding sytle as per review comments

Commit migrated from https://github.com/dotnet/corefx/commit/53aaaf3c848e4e737420de2b46f7cace397d730a

5 years agoAdd Microsoft.Private.CoreFx.OOB package (dotnet/corefx#37784)
Viktor Hofer [Tue, 21 May 2019 00:18:36 +0000 (02:18 +0200)]
Add Microsoft.Private.CoreFx.OOB package (dotnet/corefx#37784)

* Add Microsoft.Private.CoreFx.OOB package

Commit migrated from https://github.com/dotnet/corefx/commit/ef1a5aa730098b6c3350977a991232c1ff11cfe3

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37746)
dotnet-maestro[bot] [Tue, 21 May 2019 00:15:57 +0000 (17:15 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37746)

* Update dependencies from https://github.com/dotnet/coreclr build 20190516.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27716-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27716-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27716-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190517.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27717-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27717-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27717-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190518.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27718-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27718-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27718-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190519.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27719-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27719-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27719-72

* Fix ref assemblies due to change in coreclr

* Fix serialization tests after TimeZone change

Commit migrated from https://github.com/dotnet/corefx/commit/c85411a30c2c3a1d6ad3beea7be92b19b1e24df9

5 years agoConverting SystemColors into InstanceDescriptors using Color Convertor (dotnet/corefx...
Anirudh Agnihotry [Mon, 20 May 2019 23:40:01 +0000 (16:40 -0700)]
Converting SystemColors into InstanceDescriptors using Color Convertor (dotnet/corefx#37810)

* fixed converting systemcolors into instance Descriptor using colorConvertor

* doing a color check first

* checking if right property is returned

Commit migrated from https://github.com/dotnet/corefx/commit/f403c576995dd5860af48226d3ffaec873094ca9

5 years agoUpdate supported architectures on Windows in docs
Viktor Hofer [Mon, 20 May 2019 23:05:32 +0000 (01:05 +0200)]
Update supported architectures on Windows in docs

Commit migrated from https://github.com/dotnet/corefx/commit/e94ff8a041014decb591ecff475792d68603ca70

5 years agoUpdate docs with Outerloop changes
Viktor Hofer [Mon, 20 May 2019 23:04:24 +0000 (01:04 +0200)]
Update docs with Outerloop changes

Commit migrated from https://github.com/dotnet/corefx/commit/5f61457d4f8ab9daff042c168c34fced70f2fda2

5 years agoGenerate System.Runtime.Extensions reference assembly against implementation (dotnet...
Santiago Fernandez Madero [Mon, 20 May 2019 22:39:16 +0000 (15:39 -0700)]
Generate System.Runtime.Extensions reference assembly against implementation (dotnet/corefx#37811)

Commit migrated from https://github.com/dotnet/corefx/commit/2e1d93ea69e703345d4f8396aba5a9e47c965dea

5 years agoEnsure JsonException is thrown parsing invalid DateTime, DateTimeOffset, and Guid...
Christopher Watford [Mon, 20 May 2019 19:11:17 +0000 (15:11 -0400)]
Ensure JsonException is thrown parsing invalid DateTime, DateTimeOffset, and Guid dotnet/corefx#37807 (dotnet/corefx#37809)

* Add tests to cover dotnet/corefx#36901 and dotnet/corefx#37807

* Ensure DateTime(Offset) and Guid throw JsonException dotnet/corefx#37807

- The original JsonValueConverterXXX code for these allowed an InvalidOperationException
to be raised from Utf8JsonReader.TryGetXXX, instead of returning false so a JsonException
could be thrown.

Commit migrated from https://github.com/dotnet/corefx/commit/3ff5c4a6eb6315c61cfb0078245c31b59f798290

5 years agoUpdate ProjectNTfs to beta-27720-00 (dotnet/corefx#37792)
dotnet-maestro-bot [Mon, 20 May 2019 16:41:15 +0000 (09:41 -0700)]
Update ProjectNTfs to beta-27720-00 (dotnet/corefx#37792)

Commit migrated from https://github.com/dotnet/corefx/commit/7373fd9794c4b52c2a4d253cc2bc4b47c2054241

5 years agoFix testscope usage in yml and sh script (dotnet/corefx#37805)
Viktor Hofer [Mon, 20 May 2019 16:25:58 +0000 (18:25 +0200)]
Fix testscope usage in yml and sh script (dotnet/corefx#37805)

Commit migrated from https://github.com/dotnet/corefx/commit/889491763322134a1a184f3d54eb1f3605949d33

5 years agoAdd string-based WriteAsProperty overload to JsonElement. (dotnet/corefx#37789)
Ahson Khan [Mon, 20 May 2019 09:57:17 +0000 (02:57 -0700)]
Add string-based WriteAsProperty overload to JsonElement. (dotnet/corefx#37789)

* Add string-based WriteAsProperty overload to JsonElement.

* Address PR feedback - remove UTF-16 from the comments.

Commit migrated from https://github.com/dotnet/corefx/commit/189766719a059512a515d488efc5c65c7abf0650

5 years agoSkipValidation when using the writer internally within the serializer. (dotnet/corefx...
Ahson Khan [Mon, 20 May 2019 07:21:36 +0000 (00:21 -0700)]
SkipValidation when using the writer internally within the serializer. (dotnet/corefx#37791)

Commit migrated from https://github.com/dotnet/corefx/commit/e58b35cd0f8fe6caa194ca7e48388d8d59854fe0

5 years ago[System.Drawing] Fix cut & paste error (dotnet/corefx#37788)
Filip Navara [Mon, 20 May 2019 05:59:05 +0000 (07:59 +0200)]
[System.Drawing] Fix cut & paste error (dotnet/corefx#37788)

Commit migrated from https://github.com/dotnet/corefx/commit/8261325d82e18ce559dd19cde7e40c2ab140ed8b

5 years agoThrow ArgumentException in JsonSerializer if ReadCommentHandling is Allow dotnet...
Christopher Watford [Mon, 20 May 2019 01:30:08 +0000 (21:30 -0400)]
Throw ArgumentException in JsonSerializer if ReadCommentHandling is Allow dotnet/corefx#37634 (dotnet/corefx#37713)

* Add tests for Allow failing in JsonSerializer Parse/Read dotnet/corefx#37634

* Add check to throw on ReadComentHandling == Allow dotnet/corefx#37634

* Remove unused parameter from CheckSupportedOptions

* Move Allow check into JsonSerializerOptions

Commit migrated from https://github.com/dotnet/corefx/commit/27dae83598c87e3cf4b139c8c981c13fe8e9a81e

5 years agoAdded value type serialization support (dotnet/corefx#36506)
Yoh Deadfall [Mon, 20 May 2019 01:29:05 +0000 (04:29 +0300)]
Added value type serialization support (dotnet/corefx#36506)

* Added value type serialization support

* Fixed coding style issue

Commit migrated from https://github.com/dotnet/corefx/commit/d70ba24c8ca8d8a4384ebe732b3cd748a22e9551

5 years agoAllow run Outerloop tests only (dotnet/corefx#37766)
Viktor Hofer [Sat, 18 May 2019 15:15:04 +0000 (17:15 +0200)]
Allow run Outerloop tests only (dotnet/corefx#37766)

* Allow run Outerloop tests only

* Rename to testScope

* Manual darc update from build '20190517.7'

Commit migrated from https://github.com/dotnet/corefx/commit/963480a7a8f8cf59e3be8f9bfe6ba87623d04088

5 years agoRemove aliases (dotnet/corefx#37759)
Anirudh Agnihotry [Sat, 18 May 2019 02:28:42 +0000 (19:28 -0700)]
Remove aliases (dotnet/corefx#37759)

Commit migrated from https://github.com/dotnet/corefx/commit/c671ce2be16ae3c6086a061d9d94b81005217735

5 years agoConsume comments changes (dotnet/corefx#35934)
Mandar Sahasrabuddhe [Fri, 17 May 2019 22:36:49 +0000 (04:06 +0530)]
Consume comments changes (dotnet/corefx#35934)

* Consume comments changes

* Fixed issues in branch splitting

* Use sequence positions. Elaborate comments.

* Reworked algos, review comment fixes

* Fixed review comments

* minor comment fix

* Standardize exception messages

* Clean up exception messages

Commit migrated from https://github.com/dotnet/corefx/commit/d72d7203a89d3207985c9aca6f02fb8576cbe47b

5 years agoGenerate System.Runtime ref assembly against implementation (dotnet/corefx#37737)
Santiago Fernandez Madero [Fri, 17 May 2019 21:20:13 +0000 (14:20 -0700)]
Generate System.Runtime ref assembly against implementation (dotnet/corefx#37737)

* Generate System.Runtime ref assembly against implementation

* PR Feedback and baseline uapaot errors

Commit migrated from https://github.com/dotnet/corefx/commit/959168e7ff3f9f1957e9e45206ed42d4231d1312

5 years agoAdd resource containers missing in Outerloop.yml (dotnet/corefx#37761)
Viktor Hofer [Fri, 17 May 2019 20:15:33 +0000 (22:15 +0200)]
Add resource containers missing in Outerloop.yml (dotnet/corefx#37761)

Commit migrated from https://github.com/dotnet/corefx/commit/b578d19c256d9a95111e2fd81e72f06c077b766c

5 years agoUnit tests for Path.Join overloads (dotnet/corefx#37285)
Blake Hensley [Fri, 17 May 2019 19:29:18 +0000 (12:29 -0700)]
Unit tests for Path.Join overloads (dotnet/corefx#37285)

* Unit tests for Path.Join overloads

* Add more unit tests

* Minor mod to JoinStringArray_8 test

* Add unit test for zero-length array

* Use proper const for zero-len string

* Added unit test for array of one element

* Format fix: missing/extra space

Commit migrated from https://github.com/dotnet/corefx/commit/a4da51f02f194bdedc9320a50aa63b72411488b6

5 years agoMove runtests to eng and fix invocation (dotnet/corefx#37754)
Viktor Hofer [Fri, 17 May 2019 19:18:29 +0000 (21:18 +0200)]
Move runtests to eng and fix invocation (dotnet/corefx#37754)

Commit migrated from https://github.com/dotnet/corefx/commit/26195605c37bbb2d269e64b0ee3bbfb8c47ddde5

5 years agoEnable rolling builds and add arm64 in outerloop (dotnet/corefx#37728)
Viktor Hofer [Fri, 17 May 2019 17:32:20 +0000 (19:32 +0200)]
Enable rolling builds and add arm64 in outerloop (dotnet/corefx#37728)

* Enable rolling builds and add arm64 in outerloop

* Disable tests on official builds

* Allow Outerloop to run aggregated

* Disable failing RH6 test

Commit migrated from https://github.com/dotnet/corefx/commit/9643d42eb34e9eadfcfea51379812d185dc4fc7c

5 years agoAdd extension data support to Json serializer (dotnet/corefx#37690)
Steve Harter [Fri, 17 May 2019 14:56:47 +0000 (07:56 -0700)]
Add extension data support to Json serializer (dotnet/corefx#37690)

Commit migrated from https://github.com/dotnet/corefx/commit/71487a4a5bf7c0043cca4672ff3352c098dabd8c

5 years agoClean up usage of ArrayPool in the Cryptography assemblies
Jeremy Barton [Fri, 17 May 2019 13:28:17 +0000 (06:28 -0700)]
Clean up usage of ArrayPool in the Cryptography assemblies

The primary motivator of this change is to prepare for moving cryptography from
the public, shared ArrayPool instance to a private pool (or pools), just as a defense
in depth strategy.  Since only the shared ArrayPool instance has GC cooperation
the change to a private pool is not happening at this time.

What this change does provide:
* Every ArrayPool.Rent was identified as being private to the assembly or shared
  out.  If the array gets shared out, it is not appropriate to use a private pool.
* CryptoPool clears returned arrays by default. Instead of an optional bool for
  clearing it has an optional length to clear (from index 0).
* Some rents were removed altogether, via a couple strategies:
  * Opportunistic stackalloc
  * Add a SpanAction-based AsnWriter.WriteBitString overload to avoid the
    pattern of rent-write-call-copy (instead do request-write-done).
  * Add AsnWriter.ValueEquals to prevent rent-encode-compare.
* At least one Rent with no Return was found and fixed.
* Fixed several Rent-growth strategies that could double-Return on exceptions.
* Changed Rfc2898DeriveBytes to just use the one field array instead of a
   lot of rent-write-copy-to-the-field.
* Moves some Return calls out of finally blocks in Async methods to avoid a
  Return-while-in-use path with Task composition when one Task gets aborted
  and another is still running.

Commit migrated from https://github.com/dotnet/corefx/commit/64609475281f2be05a0b9ca5b7bbdaf43b12dc55

5 years agoFix missing casts in Enumerable.Select assert (dotnet/corefx#37410) (dotnet/corefx...
Tim [Fri, 17 May 2019 06:08:25 +0000 (14:08 +0800)]
Fix missing casts in Enumerable.Select assert (dotnet/corefx#37410) (dotnet/corefx#37699)

Commit migrated from https://github.com/dotnet/corefx/commit/6f9570e012054bf407778c0b07632e7733ecbb13

5 years agoAdd interleaved comments to JSON tests (dotnet/corefx#37712)
Christopher Watford [Fri, 17 May 2019 01:51:54 +0000 (21:51 -0400)]
Add interleaved comments to JSON tests (dotnet/corefx#37712)

Commit migrated from https://github.com/dotnet/corefx/commit/18ddda0989624b742c5d6913eebb1851e443432f

5 years agoUse Arcade DotNetTool and NuGetPackageRoot (dotnet/corefx#37647)
Viktor Hofer [Fri, 17 May 2019 01:39:21 +0000 (03:39 +0200)]
Use Arcade DotNetTool and NuGetPackageRoot (dotnet/corefx#37647)

* Use Arcade props

* Use global dotnet if applicable

Commit migrated from https://github.com/dotnet/corefx/commit/f42e04b8d4be76b1818cf263ff06234d0e25ada0

5 years agoFix minor typo NanoSeconds -> nanoseconds (dotnet/corefx#37732)
Gergely Kalapos [Fri, 17 May 2019 00:32:40 +0000 (20:32 -0400)]
Fix minor typo NanoSeconds -> nanoseconds (dotnet/corefx#37732)

Commit migrated from https://github.com/dotnet/corefx/commit/ef25246c7ea01a96cda8a464b4b717213e8d9685

5 years agoFix ListenerWithFilter test (dotnet/corefx#37731)
Stephen Toub [Fri, 17 May 2019 00:31:47 +0000 (17:31 -0700)]
Fix ListenerWithFilter test (dotnet/corefx#37731)

It's searching the output to ensure the id doesn't get written out, so it can't match other IDs that are written out.

Commit migrated from https://github.com/dotnet/corefx/commit/05233fd0c0200f1fda258bab148bbae28592892d

5 years agoFix a bug in xsd validation during deserialization (dotnet/corefx#37596)
Jiayi [Fri, 17 May 2019 00:20:22 +0000 (17:20 -0700)]
Fix a bug in xsd validation during deserialization (dotnet/corefx#37596)

* Fix a bug in xsd validation during deserialization
* Add a test

Commit migrated from https://github.com/dotnet/corefx/commit/4435d785565f192392b29890401748a6cdea4109

5 years agoImprove performance of Linux X509Chain building via caching
Jeremy Barton [Thu, 16 May 2019 23:56:35 +0000 (16:56 -0700)]
Improve performance of Linux X509Chain building via caching

X509Chain will use cached versions of CU\My, CU\CA, and CU\Root, in addition to the already cached LM\CA and LM\Root stores.

By avoiding the dips down to the filesystem it knocks a significant amount of I/O and computation off of the store reloads (~45% of one of my perf tests was spent doing SHA-1... for verifying the HMAC on opening the CU\My files).

The new heuristics are:

* CU\My, CU\CA, CU\Root
  * After one second elapses check to see if the LastWriteTimeUtc on the directory has changed, if so, invalidate the cache.
  * After 30 seconds invalidate the cache no matter what.
  * Cache invalidation is per store
* LM\CA, LM\Root
  * After 5 seconds elapses check to see if the LastWriteTimeUtc on either (or both) of the SSL_CERT_FILE file or SSL_CERT_DIR directory has changed (and if so, invalidate the cache)
  * After 5 minutes invalidate the cache no matter what.
  * System stores are rebuilt together.

All X509Store objects for LM\CA and LM\Root will get the same Pal instance (which just no-ops the Dispose) which is a projection over the cache.

All X509Store objects for CU\ stores will still use the existing "raw read" model, because otherwise the cache led to observable differences between Windows and Linux. Only X509Chain gets the cached stores.

In running a chain-build-only 1000 times in a loop test, before this change my machine reported ~13.6ms per chain build, and after was 0.822ms.

In running a particular SslStream-to-SslStream handshake test, 10000 iterations before the change was 7 minutes 51 seconds. After was 3 minutes 40 seconds.

This change also fixes a bug introduced in the previous perf enhancement where ERR_get_error was used instead of ERR_peek_last_error (wrong end of the queue, and destructive vs passive)... and that the managed code wasn't checking for the error anyways.

Commit migrated from https://github.com/dotnet/corefx/commit/d8797a0f1616c1db1e5294964f2826e051f2615e

5 years agoFixed deserialization of null arrays for issue dotnet/corefx#37606 (dotnet/corefx...
gnovack [Thu, 16 May 2019 23:35:08 +0000 (19:35 -0400)]
Fixed deserialization of null arrays for issue dotnet/corefx#37606 (dotnet/corefx#37616)

* Fixed deserialization of null root arrays.

* Used reader.CurrentDepth to catch root level nulls.

Commit migrated from https://github.com/dotnet/corefx/commit/026fa6a6889ab1c9c8f14f55d414d2940fc59805

5 years agoAdd [EnumeratorCancellation] to Microsoft.Bcl.AsyncInterfaces (dotnet/corefx#37719)
Stephen Toub [Thu, 16 May 2019 22:53:45 +0000 (15:53 -0700)]
Add [EnumeratorCancellation] to Microsoft.Bcl.AsyncInterfaces (dotnet/corefx#37719)

Commit migrated from https://github.com/dotnet/corefx/commit/52c6527b80062c2a3a906fd3d01881ff2f36f405

5 years agoDetermine the anyAttribute Namespace based on the NamespaceList (dotnet/corefx#37409)
JosVerburg [Thu, 16 May 2019 22:20:20 +0000 (00:20 +0200)]
Determine the anyAttribute Namespace based on the NamespaceList (dotnet/corefx#37409)

* Determine the anyAttribute Namespace based on the NamespaceList

* Do not test the namespace attribute for full framework for intersection and union cases

* Compare namespaces using string comparison in unit tests

Commit migrated from https://github.com/dotnet/corefx/commit/2c22af8903522e54f71225c40ddd383b15632ae0

5 years agoUpdate issue-guide.md
Karel Zikmund [Thu, 16 May 2019 20:59:33 +0000 (13:59 -0700)]
Update issue-guide.md

Update owners

Commit migrated from https://github.com/dotnet/corefx/commit/75a6020a76e85fb65b6bdae9f8497f6d5596e4c2

5 years agoExecuting tests in a serial order (dotnet/corefx#37715)
Anirudh Agnihotry [Thu, 16 May 2019 20:27:56 +0000 (13:27 -0700)]
Executing tests in a serial order (dotnet/corefx#37715)

Commit migrated from https://github.com/dotnet/corefx/commit/81291b0793b90c535546d3d95c69085020891d28

5 years agoAdded failing test case for unexpected StackOverflowException
Oskar Dudycz [Thu, 16 May 2019 18:23:09 +0000 (20:23 +0200)]
Added failing test case for unexpected StackOverflowException

[System.Text.Json] Serializing class that has array of children of the same class throws StackOverflowException (dotnet/corefx#37611)

Commit migrated from https://github.com/dotnet/corefx/commit/374833115e24d6384da62fa631acde2e65101eb8

5 years agoUse CancellationToken.UnsafeRegister in a few more places (dotnet/corefx#37551)
Stephen Toub [Thu, 16 May 2019 18:08:10 +0000 (11:08 -0700)]
Use CancellationToken.UnsafeRegister in a few more places (dotnet/corefx#37551)

CancellationToken.Register captures the current ExecutionContext and uses it to invoke the callback if/when it's invoked.  That's generally desirable and is the right default, but in cases where we know for certain the callback doesn't care about EC (e.g. we're not invoking any 3rd-party code), we can use UnsafeRegister instead (newly added in 3.0), which skips capturing the ExecutionContext, as if Capture returned null.  This helps few a couple of small costs:
- Avoids thread local lookups to capture the current EC.
- Avoids additional delegate invocations and thread local gets/sets to invoke the callback with the captured EC.
- Avoids holding on to the EC in case it's needed, which can potentially keep alive an unbounded amount of state due to AsyncLocals.

Commit migrated from https://github.com/dotnet/corefx/commit/b1a1bfa0997ce35e8540fbbe74276858e315807e

5 years agoUpdate issue-guide.md
Karel Zikmund [Thu, 16 May 2019 17:37:28 +0000 (10:37 -0700)]
Update issue-guide.md

Update area ownerships

Commit migrated from https://github.com/dotnet/corefx/commit/ca9bf96e1cdce0c421c4f040fd10ec555dacd077

5 years agoLinux: ProcessName: return script name instead of interpreter program (dotnet/corefx...
Tom Deseyn [Thu, 16 May 2019 17:30:06 +0000 (10:30 -0700)]
Linux: ProcessName: return script name instead of interpreter program (dotnet/corefx#37294)

* Linux: ProcessName: return script name instead of interpreter program

Fixes https://github.com/dotnet/corefx/issues/37198
Regression by https://github.com/dotnet/corefx/pull/37144

* Add ProcessNameMatchesScriptName test

* ProcessNameMatchesScriptName: don't run on OSX

* LongProcessNamesAreSupported: don't run on Alpine

* Remove ActiveIssue attributes

Commit migrated from https://github.com/dotnet/corefx/commit/1b6f45ca261467baea62ef577f8b8a7c6cf3b96c

5 years agoMark System.Reflection.Emit* as inbox on netstandard2.1 (dotnet/corefx#37532)
William Godbe [Thu, 16 May 2019 16:53:04 +0000 (09:53 -0700)]
Mark System.Reflection.Emit* as inbox on netstandard2.1 (dotnet/corefx#37532)

Commit migrated from https://github.com/dotnet/corefx/commit/b885c2296e531be15151a4857c73b4cf1c1b08c6

5 years agoUpdate ProjectNTfs to beta-27716-00 (dotnet/corefx#37698)
dotnet-maestro-bot [Thu, 16 May 2019 15:42:41 +0000 (08:42 -0700)]
Update ProjectNTfs to beta-27716-00 (dotnet/corefx#37698)

Commit migrated from https://github.com/dotnet/corefx/commit/7e44240e1644e80a856d81cb989f26751fa52579

5 years agoFix serialization of Dictionary<string, object> (dotnet/corefx#37686)
Jeremy Kuhne [Thu, 16 May 2019 04:45:57 +0000 (21:45 -0700)]
Fix serialization of Dictionary<string, object> (dotnet/corefx#37686)

We didn't drill into the value type (of the key/value pair, i.e. "object") properly when serializing.

Commit migrated from https://github.com/dotnet/corefx/commit/cf80956620388850469b516cc895e30a299928e2