Marcel Hollerbach [Mon, 9 Dec 2019 17:26:31 +0000 (18:26 +0100)]
efl_ui_popup: do not leak the backwall part
freeing it in the destructor is not enough. This has to be done at the
invalidator stage, otherwise bindings might have a blocking element on
the screen for the time the object is not gargabe collected.
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10837
Xavi Artigas [Wed, 11 Dec 2019 17:09:56 +0000 (17:09 +0000)]
elementary_test: Add Canvas.Textblock style test
This test accepts a style string (as defined in the style_apply method)
and continuously applies it to a sample text block.
Useful for debugging Efl.Canvas.Textblock styles.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10853
Woochanlee [Wed, 11 Dec 2019 10:13:39 +0000 (10:13 +0000)]
eina_rbtree: Clean array intead of flush.
It doesn't have to flush all of the time when it iterating.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10858
Chris Michael [Wed, 11 Dec 2019 15:45:47 +0000 (10:45 -0500)]
NEWS: Fix minor typo that I missed during review
Carsten Haitzler (Rasterman) [Wed, 11 Dec 2019 15:27:26 +0000 (15:27 +0000)]
ecore exe - remove useless fd closing before _exit()
we call _exit() right after closing some fd's - don't bother. they
might already be closed anyway and they will all be closed at exit
either way...
Stefan Schmidt [Wed, 11 Dec 2019 15:04:49 +0000 (10:04 -0500)]
NEWS: update file with recent removals form tree
Summary:
We need to make sure this gets not overridden wwen we start the next
release process and auto-generate some parts of this.
Reviewers: vtorri, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10860
Stefan Schmidt [Wed, 4 Dec 2019 16:15:09 +0000 (17:15 +0100)]
eeze: remove tizen module support from eeze sensor
This has been disabled since the move to meson and unlikely to have
built before with autotools either. Tizen never adopted this so we can
ease our maintenance burden here.
The Eeze sensor API itself is EAPI sadly and can't be removed. We will
keep the udev backend (temperature only) and the fake backend for
testing for now.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10805
Ali Alzyod [Wed, 11 Dec 2019 08:12:29 +0000 (08:12 +0000)]
efl_ui_text: unit test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10776
Cedric BAIL [Fri, 15 Nov 2019 19:02:01 +0000 (11:02 -0800)]
elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView.
Once the object are created, the CollectionView will do a few modifiction on them before
giving this object to the position manager to deal with. Reducing events should slightly
improve performance.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10686
Cedric BAIL [Fri, 15 Nov 2019 18:55:09 +0000 (10:55 -0800)]
elementary: reduce event generation during object creation by Efl.Ui.WidgetFactory.
We can not freeze the canvas in all scenario as we are sometime building widget fully
asynchronously which prevent holding events on the canvas. Still it is better to do it
for the case we can.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10685
Marcel Hollerbach [Wed, 11 Dec 2019 09:23:33 +0000 (10:23 +0100)]
eo: add a tcase for testing forwarders
this just adds the newly introduced semantics from cedric.
Cedric BAIL [Fri, 6 Dec 2019 02:55:25 +0000 (18:55 -0800)]
evas: do not call Eina_Cow GC during invalidate it is pointless.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10818
Cedric BAIL [Fri, 6 Dec 2019 02:55:06 +0000 (18:55 -0800)]
eina: introduce an explicit eina_cow_done with no call to GC.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10817
Cedric BAIL [Fri, 6 Dec 2019 02:54:10 +0000 (18:54 -0800)]
evas: avoid unecessary Eina_Cow GC during image destruction.
If the stretch zone are NULL to start with, there is no reason to modify
them and this should avoid us a trip to the GC.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10816
Cedric BAIL [Fri, 6 Dec 2019 00:35:23 +0000 (16:35 -0800)]
evas: reduce useless allocation during destruction of image.
Evas image use a GC to reduce duplicated state accross multiple object.
Still during shutdown we do clean it up and free it. There is no point
to push that down the GC if we are to just free it after. Relying on
the fact that dynamic content will avoid triggering the GC altogether
as their content change to frequently and is expected to be uniq among
other objects, we can avoid unecessary allocation during the destruction
by just switching that early on during the destructor.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10815
Cedric BAIL [Fri, 6 Dec 2019 00:01:17 +0000 (16:01 -0800)]
evas: efl_gfx_image_stretch_region_set need access to image state before it is freed.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10814
Cedric BAIL [Thu, 5 Dec 2019 21:57:52 +0000 (13:57 -0800)]
eo: only forward event if someone is listening.
This limit long chain of useless event forwarding when nobody is listening
at the end of the pipe.
Differential Revision: https://phab.enlightenment.org/D10813
Woochanlee [Wed, 11 Dec 2019 06:49:44 +0000 (15:49 +0900)]
edje_entry: Fix resource leak.
Reviewers: Jaehyun_Cho, Hermet, ali.alzyod
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10854
Ali Alzyod [Wed, 11 Dec 2019 00:47:50 +0000 (09:47 +0900)]
efl.ui.text: rename to efl.ui.textbox
Summary:
This patch will rename efl.ui.text into efl.ui.textbox
Effected classes:
- efl.ui.text_async : efl.ui.textbox_async
- efl.ui.text_editable : efl.ui.textbox_editable **will be removed anyway**
Needs consider Classes:
- efl.ui.text_part
- efl.ui.text_factory.Emoticons
- efl.ui.text_factory.Fallback
- efl.ui.text_factory.Images
Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike, YOhoho
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10835
JunsuChoi [Wed, 11 Dec 2019 00:27:10 +0000 (09:27 +0900)]
eina_inline: Fixed a potential dangling pointer
Summary: fixed by null handling
Test Plan: N/A
Reviewers: Hermet, YOhoho, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10850
Change-Id: I208c91caa2256d720675770a3e4406c36bb42832
Jongmin Lee [Wed, 11 Dec 2019 08:00:06 +0000 (17:00 +0900)]
elm: do not free memory returned by elm_theme_system_dir_get() function
Since it is a constant value, it should not be freeed by the caller
@tizen_fix
Change-Id: Idd18cec3495c730ef3e47f1e80af1c69621caf48
Yeongjong Lee [Wed, 11 Dec 2019 05:40:20 +0000 (14:40 +0900)]
gbs: change upstream_branch to none
Wiki said,
`Reset the upstream branch as none by modifying gbs.conf, that is, make the package native.`
https://wiki.tizen.org/Analyzing_GBS_Local_Full_Build_Errors#Case_Analysis
Change-Id: Ie8dd11f48d8fbb50857de7b1a293889e3adc05b3
WooHyun Jung [Wed, 11 Dec 2019 04:52:10 +0000 (13:52 +0900)]
efl_ui_item: fix wrong returns correctly
@tizen_fix
Change-Id: Ide14d19abf14f9fc7998e4c39504453528ba9e90
JunsuChoi [Wed, 11 Dec 2019 00:27:10 +0000 (09:27 +0900)]
eina_inline: Fixed a potential dangling pointer
Summary: fixed by null handling
Test Plan: N/A
Reviewers: Hermet, YOhoho, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10850
Change-Id: I4822201dca0b7ad840128c2488e2598a1eb352fc
Jongmin Lee [Tue, 10 Dec 2019 21:19:45 +0000 (06:19 +0900)]
build: resolve migration build error
Change-Id: Ieebfc74262f7c8d0c0fe0c709c3170eebbcecb2b
Lauro Moura [Tue, 10 Dec 2019 17:01:26 +0000 (14:01 -0300)]
csharp: Removed duplicated call_match implementations
Summary:
Small refactor. Keep it in a single header that other files could use.
Ref T8515
Reviewers: brunobelo, felipealmeida, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8515
Differential Revision: https://phab.enlightenment.org/D10852
Ali Alzyod [Tue, 10 Dec 2019 17:02:54 +0000 (12:02 -0500)]
ector: Fix build warning about unused variable
Reviewers: bu5hm4n, Hermet, devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10851
Stefan Schmidt [Wed, 20 Nov 2019 12:01:31 +0000 (13:01 +0100)]
mailmap: update commit name and email cleanup file
Keep this up to date and get more matches working. Also merge in change
from Terminology copy. This allows better statistics on our git repo.
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10832
Wonki Kim [Tue, 10 Dec 2019 11:37:49 +0000 (12:37 +0100)]
docs: fix to make docs contain proper images
Summary:
links to images that this patch is modifying would be included in doxy docs
without pre or post process something in meson definition, if we applied this patch.
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10821
JunsuChoi [Tue, 10 Dec 2019 10:18:39 +0000 (19:18 +0900)]
Example: enhance efl-canvas-vg-simple
Summary:
- Use path reserve
- Use container object
Test Plan: ./build/src/examples/evas/efl-canvas-vg-simple
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10830
Ali Alzyod [Tue, 10 Dec 2019 10:00:34 +0000 (19:00 +0900)]
efl_ui_text_editable: remove class
Summary:
This class is the same as efl_ui_text, efl_ui_text is editable by default.
This class should be removed
Reviewers: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10831
Ali Alzyod [Tue, 10 Dec 2019 08:39:59 +0000 (17:39 +0900)]
Efl.Canvas.Text rename into Efl.Canvas.Textblock
Summary:
Efl.Canvas.Text renamed into **Efl.Canvas.Textblock**
Efl.Canvas.Text_Factory renamed into **Efl.Canvas.Textblock_Factory**
Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n, YOhoho
Reviewed By: segfaultxavi
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10808
Seungwan Woo [Tue, 3 Dec 2019 09:24:31 +0000 (18:24 +0900)]
elm_config: Loading overlay theme on elm_config_init()
we need to show OneUI theme.
so, try to load external resource for theme, color_class, text_class on elm_config
I think that we should check how to deal with OneUI theme and resources
Change-Id: I9a5fb253a0b75be0f4c96df19fd470304484156c
Signed-off-by: Seungwan Woo <s-w.woo@samsung.com>
Jongmin Lee [Mon, 9 Dec 2019 21:18:26 +0000 (06:18 +0900)]
build: remove elocation package
Change-Id: I9c82720d09c4fedcd92823549ff56f0fefe41431
Lauro Moura [Mon, 9 Dec 2019 19:40:13 +0000 (16:40 -0300)]
csharp: Refactor annotation selection function
Summary:
Better names to convey their intent and formatting.
Removing the hardcoded `return` from them will also free the return list
to be used for `@out` parameters as they have similar semantics to
`return`, different from regular `@in` parameters. This change in
behavior will come in a future commit, and explains why are are keeping
both lists for now despite being essentially the same.
Ref T8515
Test Plan: Run existing tests
Reviewers: felipealmeida, brunobelo, jptiz, YOhoho
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8515
Differential Revision: https://phab.enlightenment.org/D10827
Yeongjong Lee [Mon, 9 Dec 2019 16:45:56 +0000 (13:45 -0300)]
eolian_mono: reduce duplicated code in OnXXXEvent
Summary:
`CallNativeEventCallback` is used to reduce duplicated code.
E.g.
Before
```
protected virtual void OnFullscreenChangedEvent(Efl.Ui.WinFullscreenChangedEventArgs e)
{
var key = "_EFL_UI_WIN_EVENT_FULLSCREEN_CHANGED";
IntPtr desc = Efl.EventDescription.GetNative(efl.Libs.Elementary, key);
if (desc == IntPtr.Zero)
{
Eina.Log.Error($"Failed to get native event {key}");
return;
}
IntPtr info = Eina.PrimitiveConversion.ManagedToPointerAlloc(e.arg ? (byte) 1 : (byte) 0);
try
{
Efl.Eo.Globals.efl_event_callback_call(this.NativeHandle, desc, info);
}
finally
{
Marshal.FreeHGlobal(info);
}
}
```
After
```
protected virtual void OnFullscreenChangedEvent(Efl.Ui.WinFullscreenChangedEventArgs e)
{
IntPtr info = Eina.PrimitiveConversion.ManagedToPointerAlloc(e.arg ? (byte) 1 : (byte) 0);
CallNativeEventCallback("elementary", "_EFL_UI_WIN_EVENT_FULLSCREEN_CHANGED", info, (p) => Marshal.FreeHGlobal(p));
}
```
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10661
Yeongjong Lee [Mon, 9 Dec 2019 15:59:19 +0000 (12:59 -0300)]
eolian_mono: remove unused EventArgs parameter of OnXXXEvent
Summary:
if a event doesn't have `EventArgs`, parameter `EventArgs e` of its OnXXXEvent
is naver used.
ref T8414
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8414
Differential Revision: https://phab.enlightenment.org/D10656
Stefan Schmidt [Mon, 9 Dec 2019 15:05:19 +0000 (10:05 -0500)]
ecore_x: fix unused parameter warnings after xgesture removal
Summary:
I somehow missed these warnings when doing the removal patch. Should
have spotted them. :(
Reviewers: devilhorns, raster, bu5hm4n, segfaultxavi, vtorri
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10833
Stefan Schmidt [Wed, 2 Oct 2019 15:45:07 +0000 (17:45 +0200)]
elocation: remove beta library
This has never been fully finished or really used. The GeoClue project
dbus API moved on to a newer version as well. We still have it marked as
beta so we should take the chance and get rid of it to cleanup our tree
a little bit.
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10788
Woochanlee [Mon, 9 Dec 2019 12:57:31 +0000 (07:57 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_role functions
Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_class functions
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D10829
Bruno da Silva Belo [Mon, 9 Dec 2019 11:33:52 +0000 (08:33 -0300)]
c#: Suppressing warning for CA1724.
Summary: ref T8413
Reviewers: lauromoura, felipealmeida, YOhoho, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8413
Differential Revision: https://phab.enlightenment.org/D10811
Lauro Moura [Mon, 9 Dec 2019 11:32:02 +0000 (08:32 -0300)]
csharp: changing string literal with nameof.
Summary: ref T8407
Reviewers: lauromoura, felipealmeida, YOhoho, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8407
Differential Revision: https://phab.enlightenment.org/D10668
Lauro Moura [Mon, 9 Dec 2019 11:22:59 +0000 (08:22 -0300)]
csharp: Marking property with static.
Summary: ref T8420
Reviewers: lauromoura, felipealmeida, YOhoho, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8420
Differential Revision: https://phab.enlightenment.org/D10657
Xavi Artigas [Mon, 9 Dec 2019 10:04:56 +0000 (11:04 +0100)]
Efl.Ui.Internal_Text_Interactive: missed renames from previous commit
ali [Mon, 9 Dec 2019 09:49:13 +0000 (10:49 +0100)]
efl_text_cursor: rename enums
Summary:
rename two movement enums
**paragraph_first**: to just **first** this will move the cursor to the beginning of the text
**paragraph_last**: to just **last** this will move the cursor to the end of the text
These two are not directly related to paragraph the will move the cursor depending on the whole content
or maybe **start** and **end** what do you think ?
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10810
Hermet Park [Mon, 9 Dec 2019 06:41:33 +0000 (15:41 +0900)]
evas vg: ++documentation
ali [Mon, 9 Dec 2019 01:58:39 +0000 (10:58 +0900)]
Efl.Ui.Text : all related interfaces
Summary:
Change summary:
Removed :
- efl_ui_text_selectable.eo and add it functionality into efl_text_interactive.eo
- efl_ui_text_editable.eo because it is same as efl_ui_text.eo (just set one property by default)
Modifications:
- Move all Text Input enums and functionality from efl_ui_text class into its own interface, this interface will be implemented at efl_ui_internal_text_interactive class.
- Rename selection_allowed property to selectable (same as other "editable" property) in efl_text_interactive
- Add select_all function into efl_text_interactive interface
- Add have_selection property into efl_text_interactive interface
- Move user_change , selection_start/change/clear and undo/redo events into efl_text_interactive interface.
- Move methods and events of copy/paste/cut into efl_ui_text
- Fix password-related functionality
- Remove context menu clear and add_item methods. (these should be added later with better design)
- Remove Validation event from EFL_UI_TEXT. (these should be added later with better design)
Reviewers: woohyun, tasn, segfaultxavi, zmike, bu5hm4n
Subscribers: stefan_schmidt, a.srour, q66, zmike, segfaultxavi, cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10711
Yeongjong Lee [Mon, 28 Oct 2019 01:50:49 +0000 (10:50 +0900)]
efl_ui_widget: fix focus revert when focused object is disabled
Fix the issue that the focus does not shift to last focused object when a
focused object is being disabled.
Thanks to Dhyan Chand Bazio Desabattula for the reporting and test code.
test code:
```
/*
* gcc -o focus_disable_test focus_disable_test.c `pkg-config --cflags --libs elementary
*/
#include <Elementary.h>
static Eina_Bool
_disablella(void* data)
{
Evas_Object* baz = (Evas_Object*)data;
elm_object_disabled_set(baz,EINA_TRUE);
return EINA_FALSE;
}
static void _focused(void *data, Evas_Object *obj, void *event_info)
{
ecore_timer_add(1, _disablella, obj);
}
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Evas_Object *win = NULL;
Evas_Object *btn = NULL;
Evas_Object *baz = NULL;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("Greetings", "Hello, World!");
elm_win_autodel_set(win, EINA_TRUE);
btn = elm_button_add(win);
elm_object_text_set(btn, "Good-Bye, World!");
evas_object_resize(btn, 200, 100);
evas_object_move(btn, 860, 450);
evas_object_show(btn);
baz = elm_button_add(win);
elm_object_text_set(baz, "Hola Amigos!");
evas_object_resize(baz, 200, 100);
evas_object_move(baz, 860, 600);
evas_object_show(baz);
evas_object_smart_callback_add(baz, "focused", _focused, NULL);
evas_object_resize(win, 1920, 1080);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
`btn` should be focused when you click `baz`.
Change-Id: I219a4998e7c5f960dd890d72a1e32dacaa1c5961
Subodh Kumar [Tue, 3 Dec 2019 11:48:18 +0000 (17:18 +0530)]
Edje: Add color class feature for textblock properties.
These properties were missing, as underline color is being used used heavily.
There is link pressed effect feature which requires color class for underline color.
Also link pressed effect works on link tag. So link tag is provided by default and if app
wants to customises the color then whole style needs to be rrecreated so replacing
color code for link tag will work as aspected.
Change-Id: I04e826a64610981a0491d753a855d5c8984fc259
Yeongjong Lee [Sun, 8 Dec 2019 22:50:33 +0000 (07:50 +0900)]
efl_ui_widget: restore legacy focus of scrollable
restore legacy focus calculation removed from the commit below.
ref
e337c53348829799e0dcac26af50e988e1b759a8
@tizen_fix
Change-Id: I08e182697795451a3381038995163df420900d1f
ali [Fri, 6 Dec 2019 20:14:29 +0000 (20:14 +0000)]
evas_text: retain legacy behaviour
This will retain old legacy behaviour (No Eina Checks).
Warnings will be generated when using elementary test, unless we retain old behaviour
https://phab.enlightenment.org/D10716#203305
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10826
Carsten Haitzler (Rasterman) [Fri, 6 Dec 2019 20:51:26 +0000 (20:51 +0000)]
imf - make xim+scim the defaults not xim+ibus due to ibus being broken
at leats ibus seems to just not work for me on arch at least - even
with gtk apps, but scim does, so maybe make scim the main thing again?
also allows glib to be off by default. :)
Stefan Schmidt [Fri, 6 Dec 2019 19:40:20 +0000 (14:40 -0500)]
ecore_x: remove support XGesture extension
Summary:
This was a X11 extension mainly developed for Tizen. By now I can only
find it packaged by Gentoo as the only Linux distribution and Tizen is
now longer using it either. Bringing it up during EDD and on the mailing
list did not come up with any users.
I think we can go ahead and deprecate the API and remove the
functionality.
Reviewers: raster, cedric, devilhorns, zmike
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10823
Carsten Haitzler (Rasterman) [Fri, 6 Dec 2019 19:27:25 +0000 (19:27 +0000)]
glib - enable by default again - ibus imf needs it
Marcel Hollerbach [Fri, 6 Dec 2019 18:19:38 +0000 (19:19 +0100)]
elm_code: set box align correctly
sometimes the resize size is not in line with the size of the outer
widget, in this case the box should align its children at the very top,
otherwise the cursor grid is falling out of sync with the text content.
Jaehyun Cho [Fri, 6 Dec 2019 16:27:06 +0000 (16:27 +0000)]
efl_canvas_object_animation: support duration 0
The duration of animation means how long the animation is executed.
Therefore, if duration is 0, then the final state of animation should be
applied to the target object immediately.
In this case, if final_state_keep is true, then the final state of
animation is preserved. Otherwise, the final state of animation is not
preserved.
ref T8436, T8513
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10812
Lauro Moura [Fri, 6 Dec 2019 14:57:52 +0000 (14:57 +0000)]
elementary: Fix declaration of CV managers getters
This should convey better their intention of the setting taking
ownership of the passed value and the getter returning just a view to
them.
Fixes T8514
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10824
Yeongjong Lee [Mon, 11 Nov 2019 05:48:24 +0000 (05:48 +0000)]
efl: stabilize Efl.Gfx.Arrangement
ref T7864
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10642
Wonki Kim [Fri, 6 Dec 2019 08:29:26 +0000 (08:29 +0000)]
focus: modify a formula to calculate focus region to show
if there was a spacer around elm.swallow.content of scroller,
position of pan object would be different with position of the scroller obj.
this patch modifies a fomular that calculates some points relative to scroller
to a fomular that calculates the points relative to pan obj.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10745
Wonki Kim [Fri, 6 Dec 2019 08:30:51 +0000 (08:30 +0000)]
collection_view: fix a potentional error
assign signed int value on bigger unsigned variable
can make information of the varaible lost.
this patch fix the problem.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10723
Stefan Schmidt [Wed, 4 Dec 2019 16:25:19 +0000 (17:25 +0100)]
ci: re-enable cxx bindings for CI builds again
While cxx bindings are enabled by default we had them turned off on the
CI builds due to the amount of memory they used in the examples
building/linking. This often had lead to the case where the Travis build
failed due too little resources on the Travis nodes for it.
I have not seen this stalls during linking on my machine for a while now
and my tests on Travis do also not show this. Time to enable them again
and if the problem comes back we can revert.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10822
Hermet Park [Fri, 6 Dec 2019 09:58:54 +0000 (18:58 +0900)]
evas vector: add one comment todo.
Taehyub Kim [Fri, 6 Dec 2019 08:49:52 +0000 (17:49 +0900)]
efl_ui_alert_popup: remove beta for efl_ui_alert_popup_title
Summary: remove the title part beta tag for the efl ui alert popup
Reviewers: Jaehyun_Cho, zmike, bu5hm4n, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10820
JunsuChoi [Fri, 6 Dec 2019 07:51:07 +0000 (16:51 +0900)]
Example: Add efl-cavnas-vg-simple for unified API
Summary: Add Evas vector graphcis example based on unified APIs
Test Plan:
build
./build/src/examples/evas/efl-canvas-vg-simple
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10819
JunsuChoi [Fri, 6 Dec 2019 06:56:34 +0000 (15:56 +0900)]
evas vg: remove build warning
Remove parameter already deleted
Change-Id: I0d71ef01525376b1e52bf695a459ce21aab8a362
Hermet Park [Fri, 6 Dec 2019 06:30:50 +0000 (15:30 +0900)]
evas vg: --remove log
Hermet Park [Fri, 6 Dec 2019 06:22:56 +0000 (15:22 +0900)]
vg ector: Call a pair of ector begin/end for ector buffer drawing.
While we render vector drawing on ector,it uses ector buffers for subsequent compositions.
In this sequence, it switches ector buffer with a composition target,
while resuing the global ector context.
Previously, it trickly switched ector buffer, it broke the ector begin/end pair.
Now, it needs to recover global ector buffer once the composition finished.
Thus ector buffer need to return the current pixels information for this.
JunsuChoi [Fri, 6 Dec 2019 01:37:31 +0000 (10:37 +0900)]
ector_software_rasterizer: use dynamic array by span size.
Summary:
When use with intersect mask, if span_count over span array size, composition is to be wrong.
So, In this case, we use dynamic array by span_count.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: vtorri, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10748
JunsuChoi [Fri, 6 Dec 2019 01:30:34 +0000 (10:30 +0900)]
elm_label: Emit click signal on acivate action on label
Summary: In accessibility enabled case click signal of legacy label is not triggered.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10803
Hosang Kim [Fri, 6 Dec 2019 01:21:35 +0000 (10:21 +0900)]
evas_events: fix wrong condition of proxy event behavior.
Summary:
If source_events is false, Evas object doesn't repeat events to source.
But events is always repeated to source in multi touch case.
Reviewers: Hermet, raster, cedric
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10807
Jongmin Lee [Sun, 8 Dec 2019 21:56:16 +0000 (06:56 +0900)]
Revert "[Tizen5.5] Edje: Add color class feature for textblock properties."
This reverts commit
e0c9fef500b658530fb16bad70a0f96913fec9d9.
Jongmin Lee [Sun, 8 Dec 2019 21:56:00 +0000 (06:56 +0900)]
Revert "elm_label: Emit click signal on acivate action on label"
This reverts commit
4afbff17dd803c5eb9920cca9c1e7898dbe367a7.
Change-Id: I6fa1ebc82c993ab91639a4085c0e6fffb13f0174
Yeongjong Lee [Fri, 6 Dec 2019 07:01:02 +0000 (16:01 +0900)]
build: fix build warnings related to const qualifier
Change-Id: Iaa392fe228c379c878f61b03a80d6a0a67e75a76
Yeongjong Lee [Thu, 5 Dec 2019 07:17:29 +0000 (16:17 +0900)]
efl_ui: fix build warnings of focus_manager functions
@tizen_fix
Change-Id: I6b8a4e5af21159367ee4cc70ba16b37d9d3c8a93
Yeongjong Lee [Thu, 5 Dec 2019 02:29:45 +0000 (11:29 +0900)]
evas_events: remove unused tizen_only variables
@tizne_fix
Change-Id: Ib0755787495e060ee6b1066fae834152ce12633c
JunsuChoi [Fri, 6 Dec 2019 06:56:34 +0000 (15:56 +0900)]
evas vg: remove build warning
Remove parameter already deleted
Change-Id: I5ed106c2575ede766baf8a9f729096b8ef395236
Hermet Park [Fri, 6 Dec 2019 06:30:50 +0000 (15:30 +0900)]
evas vg: --remove log
Change-Id: Ia093f1ffd1e07b1806e92bab742c7fb1f2b74dea
Hermet Park [Fri, 6 Dec 2019 06:22:56 +0000 (15:22 +0900)]
vg ector: Call a pair of ector begin/end for ector buffer drawing.
While we render vector drawing on ector,it uses ector buffers for subsequent compositions.
In this sequence, it switches ector buffer with a composition target,
while resuing the global ector context.
Previously, it trickly switched ector buffer, it broke the ector begin/end pair.
Now, it needs to recover global ector buffer once the composition finished.
Thus ector buffer need to return the current pixels information for this.
Change-Id: I8029ad548660fe614923857af9520e67bd9344a1
JunsuChoi [Fri, 6 Dec 2019 01:56:11 +0000 (10:56 +0900)]
elm_label: Remove tizen only
4afbff patch has been applied to open source.
Therefore, delete tizen only.
Open source patch to be migrated will be empty patch.
Change-Id: I98224acdaef1559a2099d8f6a2b237d1226b297c
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Subodh Kumar [Tue, 3 Dec 2019 11:48:18 +0000 (17:18 +0530)]
[Tizen5.5] Edje: Add color class feature for textblock properties.
These properties were missing, as underline color is being used used heavily.
There is link pressed effect feature which requires color class for underline color.
Also link pressed effect works on link tag. So link tag is provided by default and if app
wants to customises the color then whole style needs to be rrecreated so replacing
color code for link tag will work as aspected.
Change-Id: I04e826a64610981a0491d753a855d5c8984fc259
Prasoon Singh [Wed, 4 Dec 2019 11:46:21 +0000 (17:16 +0530)]
elm_label: Emit click signal on acivate action on label
In screen-reader enabled case click signal of label is not triggered.
Change-Id: I218944122ba9747f7fb7ab425559ad1fc331f34e
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
maxerba [Thu, 5 Dec 2019 17:06:12 +0000 (18:06 +0100)]
Updating french translation
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL
Summary: ector thread can called *data(task) after deleting task object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10804
Change-Id: I05d5226ec7b950214f398f66d0ca82e430099cb5
Ali Alzyod [Thu, 5 Dec 2019 09:37:57 +0000 (10:37 +0100)]
efl_text_attribute_factory: update documention
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10806
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL
Summary: ector thread can called *data(task) after deleting task object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10804
Change-Id: I9e7b4893fc58a9670f2ac60e9b632cf9969c22c3
Taehyub Kim [Thu, 5 Dec 2019 05:15:16 +0000 (14:15 +0900)]
Revert "ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings."
This patch cause the ecore_buffer_register tc break,
then this need to revert temporary.
This reverts commit
f8f770ebf854d725b3bf8a2ec10f7526960fd5e2.
Change-Id: I75e6cbf3654dfbc62941715fe7272846f2ac93e7
Jongmin Lee [Wed, 4 Dec 2019 21:34:48 +0000 (06:34 +0900)]
build: remove gstreamer 0.10 support
Change-Id: I83824b7553ed13d17a640049f1077b710c30572a
Stefan Schmidt [Thu, 28 Nov 2019 08:59:41 +0000 (09:59 +0100)]
exotic: remove left-overs from Exotic support
This seems to have been gone a long time ago and only references left
that have not been disturbing the build. Time to clean up!
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10793
Subodh Kumar [Tue, 3 Dec 2019 10:56:00 +0000 (10:56 +0000)]
edje: Add text change signal
There is no way to know about text changes in edc.
This signal will help developer to know about text changes
and do some operation based on that.
@feature
Co-authored-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10780
Stefan Schmidt [Wed, 30 Oct 2019 16:09:20 +0000 (17:09 +0100)]
emotion & evas: remove gstreamer 0.10 support
We have Gstreamer 1.x support for a long time already. We used to keep
this around as fallback. By now Linux distributions start to actually no
longer ship the Gstreamer 0.10.x packages and upstream has not seen a
release in in 5 years. Time to remove it on our side as well.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10779
Stefan Schmidt [Fri, 1 Nov 2019 08:35:09 +0000 (09:35 +0100)]
esacpe: remove library from tree
This has not been used for a while and is not even buildable after our
switch to meson. It was a niche to start with given that it needed the
PS3 OS to run on. I asked for any remaining users at EDD and on the list
but heard nothing. Time to remove.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10778
Cedric BAIL [Sat, 23 Nov 2019 09:09:13 +0000 (01:09 -0800)]
elementary: small improvement on example migrating them to newer unified API.
Xavi Artigas [Wed, 4 Dec 2019 17:22:25 +0000 (18:22 +0100)]
code comments: annoying typos
Marcel Hollerbach [Wed, 4 Dec 2019 16:45:25 +0000 (17:45 +0100)]
efl_canvas_animation_group: show that playing backwards is also working
Summary:
playing backwards is also working, this is simply shown here, the
handcrafted backwards animation wasnt showing the correct animation
either.
Depends on D10799
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10802
Xavi Artigas [Wed, 4 Dec 2019 16:25:45 +0000 (17:25 +0100)]
Efl.Canvas.Animation: Rename repeat_count to play_count
Summary:
play_count is a tad simpler to understand, since it means the TOTAL number of
times the animation will play.
The default value is now 1, and 0 means INFINITE (instead of -1). This allows
removing yet another constant from header files.
Depends on D10799
Test Plan: Everything builds and passes tests. Elm_test Animation.Repeat has been adjusted accordingly.
Reviewers: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10800
Lauro Moura [Wed, 6 Nov 2019 18:41:13 +0000 (18:41 +0000)]
charp: Require mono bindings when using dotnet
Allow using `-Ddotnet=true` to automatically pull `bindings=mono`.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10610
JunsuChoi [Wed, 27 Nov 2019 13:23:12 +0000 (08:23 -0500)]
tests/layout: add unit test for legacy layout theme,changed signal
split from D10744
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10751
Mike Blumenkrantz [Wed, 27 Nov 2019 13:12:52 +0000 (08:12 -0500)]
efl_ui/layout: unconditionally emit theme,changed event for legacy layouts
this will automatically be optimized by smart callback internals and fix
emission of this event
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10750
Mike Blumenkrantz [Tue, 26 Nov 2019 15:59:21 +0000 (10:59 -0500)]
tests/layout: add explicit test for implicit theme,changed emission
this must be emitted automatically during finalize if theme_set is
not directly called during construction
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10741
Mike Blumenkrantz [Tue, 26 Nov 2019 15:54:36 +0000 (10:54 -0500)]
tests/layout: validate EFL_UI_LAYOUT_EVENT_THEME_CHANGED emission in theme test
ensure that this callback is emitted exactly one time if the theme is
set during construction
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10740